[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Really interesting feature, starting with QA tools:

 FAIL   installer/data/mysql/atomicupdate/add_history.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
   FAIL   filters
                missing_filter at line 903 (                                   
                <a href="#" class="buttonHistory" id="[%- mv.id -%]">)
                missing_filter at line 904 (                                   
                    <img src="[% interface %]/[% theme %]/img/icon-history.png"
alt="History" title="Display history for this field" />)
                missing_filter at line 904 (                                   
                    <img src="[% interface %]/[% theme %]/img/icon-history.png"
alt="History" title="Display history for this field" />)
                missing_filter at line 908 (                                   
            <table class="history_table" id="[%- mv.id -%]_history" name="[%-
mv.name -%]_history">)
                missing_filter at line 908 (                                   
            <table class="history_table" id="[%- mv.id -%]_history" name="[%-
mv.name -%]_history">)
                missing_filter at line 916 (                                   
                    <td><a href="#" data-tag='[%- mv.id -%]' data-history='[%
hist.data %]' class='hist_rollback'>[% hist.data %]</a></td>)
                missing_filter a

 FAIL   Koha/MetadataRecord/History.pm
   FAIL   critic
                "return" statement with explicit "undef" at line 103, column 9.
See page 199 of PBP.

Can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.