[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Kyle M Hall from comment #6)
> (In reply to Martin Renvoize from comment #3)
> > Comment on attachment 105938 [details] [review] [review]
> > Bug 25769: Patron self modification triggers change request for date of
> > birth to null
> > 
> > Review of attachment 105938 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: opac/opac-memberentry.pl
> > @@ +484,5 @@
> > >  
> > > +    if ( defined $borrower{'dateofbirth'} ) {
> > > +        my $dob_dt;
> > > +        $dob_dt = eval { dt_from_string( $borrower{'dateofbirth'} ); }
> > > +            if ( $borrower{'dateofbirth'} );
> > 
> > You're now testing if $borrower{'dateofbirth'} is defined above.. do you
> > still need to test it here too?
> 
> After examining the code, yes we do still need it. This new check tests to
> see if the dateofbirth param is part of the form. If it *is*, it still may
> be blank. Without this check, we'd set the dateofbirth to the current date.

Ah, of course.. good catch.

-- 
You are receiving this mail because:
You are watching all bug changes.