[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #34 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
While testing the advertised "Experimental MariaDB 10.3 support" for 19.05.x,
it turns out that this patch applied and fix two failure.

Will try to backport for 19.11.13

For the record the fixed failures are:

kohadev-koha at 665e4031f5cf:/kohadevbox/koha$ time prove -r
t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Koha/Object.t
t/db_dependent/Circulation/MarkIssueReturned.t .. 2/4 DBD::mysql::st execute
failed: Incorrect datetime value: 'bad_date' for column
`koha_kohadev`.`issues`.`returndate` at row 1 [for Statement "UPDATE `issues`
SET `returndate` = ? WHERE ( `issue_id` = ? )" with ParamValues: 0='bad_date',
1=252] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.

    #   Failed test 'An exception is thrown on bad date'
    #   at t/db_dependent/Circulation/MarkIssueReturned.t line 181.
    # expecting: Koha::Exceptions::Object::BadValue
    # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute():
Incorrect datetime value: 'bad_date' for column
`koha_kohadev`.`issues`.`returndate` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 157
    # )
    # Looks like you failed 1 test of 3.
t/db_dependent/Circulation/MarkIssueReturned.t .. 3/4 
#   Failed test 'Manually pass a return date'
#   at t/db_dependent/Circulation/MarkIssueReturned.t line 185.
t/db_dependent/Circulation/MarkIssueReturned.t .. 4/4 # Looks like you failed 1
test of 4.
t/db_dependent/Circulation/MarkIssueReturned.t .. Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/4 subtests 
t/db_dependent/Koha/Object.t .................... 7/12 
        #   Failed test 'Exception thrown correctly'
        #   at t/db_dependent/Koha/Object.t line 359.
        # expecting: Koha::Exceptions::Object::BadValue
        # found: DBIx::Class::Exception
(DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value:
'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 157
        # )
        # Looks like you failed 1 test of 1.

    #   Failed test 'Bad value tests'
    #   at t/db_dependent/Koha/Object.t line 363.
    # Looks like you failed 1 test of 16.
t/db_dependent/Koha/Object.t .................... 10/12 
#   Failed test 'store() tests'
#   at t/db_dependent/Koha/Object.t line 366.
# Looks like you failed 1 test of 12.
t/db_dependent/Koha/Object.t .................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/12 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation/MarkIssueReturned.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/db_dependent/Koha/Object.t                  (Wstat: 256 Tests: 12 Failed: 1)
  Failed test:  10
  Non-zero exit status: 1
Files=2, Tests=16, 13 wallclock secs ( 0.05 usr  0.01 sys +  9.84 cusr  1.82
csys = 11.72 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.