[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105972|0                           |1
        is obsolete|                            |

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 106170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106170&action=edit
Bug 25322: fix for not selected "relationship" defaults to father

When a user creates a patron's guarantor on
/cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a
dropdown, the relationship defaults to first value, which in default sysprefs
is "father". This may or may not be correct as this is not a conscious choice
from the user.

The solution is to make the "Relationship" field mandatory when there is no
empty entry in the system preferences, always starting with an empty option but
not allowing the user to save an empty entry.
And if there is an empty option in sysprefs, it allows to save empty, as well
as makes it default choice.

To reproduce with default system preferences:
    1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
    2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
    3) Observe that relationship is set as "father".
    4) Apply the patch.
    5) Repeat steps 1 and 2.
    6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

To reproduce with empty entry added to system preferences:
    1) Add an empty entry to borrowerRelationship at
/cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section
(example: "|father|mother").
    2) Create a new patron who is assumed to have a guarantor or modify the
existing one.
    3) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
    4) Observe that relationship is set as "father".
    5) Apply the patch.
    6) Repeat steps 1, 2 and 3.
    7) Observe when you save the empty entry it does set the relationship as
empty.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.