[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958

--- Comment #18 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Hi Owen,

This was baffling me too.  As you couldn't replicate it, I had another test to
see if I could help:

The value in localStorage still persisted with the ordinary tests.

I noticed you were using a different account, so on the off chance, I created a
new superlibrarian instead of using the koha default log in, but the value
still persisted.

I then looked at the Diff on the bug, and ran the JS command from the console: 
 $(localStorage.removeItem("sql_reports_activetab"));

This removed the storage element, so it verified that the JS you've used was
correct and there's nothing awry with the browsers I'm using.

I noticed that the command is next to the clearHoldFor() function in the JS
file, so I tested to see if the clear hold function still worked, and sure
enough:

- Load patron
- Use 'search to hold' function
- Log out
- Log back in
- Load record
- Place hold button still recalls the patron from step 1

So the JS command is correct, but perhaps the placement in the file has broken
the functionality?

Hope that helps :)

-- 
You are receiving this mail because:
You are watching all bug changes.