[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jun 25 16:41:27 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104638|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 106301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106301&action=edit
Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl

This warning emitted:

CGI::param called in list context from /admin/smart-rules.pl line 262,
this can lead to vulnerabilities. See the warning in "Fetching the value
or values of a single named parameter" at CGI.pm line 412.

Explained here:
https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter

And because all these params are not multi-params, so simple "scalar .."
forcing for CGI->param is the fix. Changes are transparent and same
values should be assigned as before, just no more warnings.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list