[Koha-bugs] [Bug 21395] Make perlcritic happy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #14)
> > This patch also modify t/00-testcritic.t to check all Perl files using
> > the new .perlcriticrc.
> > I'm not sure if this test script is still useful as it is now equivalent
> > to `perlcritic --quiet .` and it looks like it is much slower
> > (approximatively 5 times slower on my machine)
> 
> Are you sure about that?
> 
> % time perlcritic --quiet .
> real    2m10.957s
> 
> % time prove t/00-testcritic.t
> real    1m2.354s

I just tested again, and I get similar times (t/00-testcritic.t is even faster
(~40s)). It looks like t/00-testcritic.t uses multiple CPUs, unlike perlcritic.
So t/00-testcritic.t is still useful :)

-- 
You are receiving this mail because:
You are watching all bug changes.