[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
It works!

Are the additional warnings caused by the patch?

# Only test patch applied

kohadev-koha at ea2bce8f4ac7:/kohadevbox/koha$ prove t/db_dependent/Reserves.t
t/db_dependent/Reserves.t .. 14/62 Use of uninitialized value in string eq at
/kohadevbox/koha/C4/Reserves.pm line 558.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
558.
t/db_dependent/Reserves.t .. 59/62 
        #   Failed test 'record-level holds should not be possible with
opacitemholds set to "Force"'
        #   at t/db_dependent/Reserves.t line 1013.
        #          got: 'OK'
        #     expected: 'RecordHoldNotAllowed'

        #   Failed test 'item-level holds should not be possible with
opacitemholds set to "No"'
        #   at t/db_dependent/Reserves.t line 1049.
        #          got: 'OK'
        #     expected: 'notReservable'
        # Looks like you failed 2 tests of 6.

    #   Failed test 'test opacitemholds rules'
    #   at t/db_dependent/Reserves.t line 1079.
    # Looks like you failed 1 test of 3.
t/db_dependent/Reserves.t .. 61/62 
#   Failed test 'reserves.item_level_hold'
#   at t/db_dependent/Reserves.t line 1080.
t/db_dependent/Reserves.t .. 62/62 # Looks like you failed 1 test of 62.
t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/62 subtests 

Test Summary Report
-------------------
t/db_dependent/Reserves.t (Wstat: 256 Tests: 62 Failed: 1)
  Failed test:  61
  Non-zero exit status: 1
Files=1, Tests=62,  7 wallclock secs ( 0.04 usr  0.01 sys +  5.90 cusr  0.83
csys =  6.78 CPU)
Result: FAIL

# Applied the implementation

kohadev-koha at ea2bce8f4ac7:/kohadevbox/koha$ prove t/db_dependent/Reserves.t
t/db_dependent/Reserves.t .. 20/62 Use of uninitialized value in string eq at
/kohadevbox/koha/C4/Reserves.pm line 577.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
577.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value $opacitemholds in string eq at
/kohadevbox/koha/C4/Reserves.pm line 425.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value $opacitemholds in string eq at
/kohadevbox/koha/C4/Reserves.pm line 425.
t/db_dependent/Reserves.t .. ok     
All tests successful.
Files=1, Tests=62,  8 wallclock secs ( 0.05 usr  0.01 sys +  5.97 cusr  0.71
csys =  6.74 CPU)
Result: PASS
kohadev-koha at ea2bce8f4ac7:/kohadevbox/koha$

-- 
You are receiving this mail because:
You are watching all bug changes.