From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:01:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:01:25 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-xdBOQK7THa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, can't run the QA tools on this patch: 
An error occurred : Unmatched ) in regex; marked by <-- HERE in
m/_\([(?<string>[^[]*) <-- HERE [\)/ at
/home/vagrant/qa-test-tools/QohA/File/JS.pm line 29.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:09:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:09:48 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-TYXdSnx1NW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:10:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:10:38 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-Q1nBk6d8XI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
@RM: can you please add missing sign-off lines? :)

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:22:39 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-YEzgpNte5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Katrin Fischer from comment #4)
> Wondering if we can improve the license text a bit here - I assume it's from
> Pootle or po standard?

It's from 'xgettext' command, used to create the files.
It can be changed of course, after the file is created.
Other po files does not contain initial comments, an option is to eliminate
them.
But I suppose that all files must contain an initial (correct) notice.

In other bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:35:42 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-5JwYz4r2lB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:35:46 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-RyCkvKqBsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99321|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 99845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99845&action=edit
Bug 15377: Allow removal of 'checked out' items from course reserves

1) removes the restriction of not allowing a reserve to be removed if it is
onloan
2) adds a column to the display that says with the item is checked out or
available based on the onloan flag

testplan: add an item to course reserves, check the item out, check that the
Ciruclation column changes to Checked Out and that you can remove it

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Hannah Olsen <holsen at duncanville.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:35:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:35:50 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-LqpdgG8k1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 99846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99846&action=edit
Bug 15377: (QA follow-up) Fix capitalization and column heading

Checked Out -> Checked out
Circulation -> Status (matching other pages with this information)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 00:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 29 Feb 2020 23:36:16 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
 course reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-Y7UUY4VrvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove 'checked out' items  |Allow removal of 'checked
                   |from course reserves        |out' items from course
                   |                            |reserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 04:53:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 03:53:20 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-BdklzJ2ODz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #8 from David Nind <david at davidnind.com> ---
Patch no longer applies:

Applying: Bug 23531: fix ILSDI non-implemented but documented parameters
Using index info to reconstruct a base tree...
M       C4/ILSDI/Services.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/ILSDI/Services.pm
CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23531: fix ILSDI non-implemented but documented
parameters

Notes:
- Get DataTables error on patrons hold tab before patch is applied (bug 
- Before patch applied query for use in koha-testing-docker:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&needed_before_date=2020-03-02&pickup_expiry_date=2020-03-31&pickup_location=CPL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 04:54:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 03:54:41 +0000
Subject: [Koha-bugs] [Bug 24769] DataTable error on patron hold page when
 hold placed using ILS-DI
In-Reply-To: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24769-70-o9Htnv0OOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769

--- Comment #1 from David Nind <david at davidnind.com> ---
Error also showed up when testing bug 23531

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 04:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 03:55:28 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-YAmUkvwfhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #9 from David Nind <david at davidnind.com> ---
Bug for DataTables error on patrons hold tab is bug 24769

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 05:09:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 04:09:21 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-ZwtZulniBf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
I'm happy to test if you could provide some example URLs for ILS-DI requests
and the required parameters.

Notes:
- The patch still applies
- Tests don't pass:

root at 722db1e0af2e:koha(bz22379)$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 6/10 Use of uninitialized value $charge in
numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2991.
t/db_dependent/ILSDI_Services.t .. 8/10     # No tests run!
t/db_dependent/ILSDI_Services.t .. 9/10 
#   Failed test 'No tests run for subtest "CancelHold"'
#   at t/db_dependent/ILSDI_Services.t line 698.
Can't use string ("Su0VSFAs") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Reserves.pm line 175.
# Looks like your test exited with 255 just after 9.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 2/10 subtests 

Test Summary Report
-------------------
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 9 Failed: 1)
  Failed test:  9
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 9.
Files=1, Tests=9, 14 wallclock secs ( 0.04 usr  0.00 sys + 11.33 cusr  1.57
csys = 12.94 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 07:59:02 +0000
Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for
 the ILS-DI Service
In-Reply-To: <bug-23015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23015-70-l5m8l9jmfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #12 from David Nind <david at davidnind.com> ---
Have tested, but a couple of questions:

1) Details for the service don't display on
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl but can be accessed from
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPickupLocation

2) The result returned doesn't seem to match up with what is shown in the
describe text, for example for
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=GetPickupLocation&patron_id=19&id=23&id_type=item
I get: 

<GetPickupLocation>
<library>
<anon>
<branchname>Centerville</branchname>
<branchcode>CPL</branchcode>
<branchaddress1>Jefferson Summit</branchaddress1>
<pickup_location>1</pickup_location>
</anon>
<anon>
<pickup_location>1</pickup_location>
<branchaddress1>River Station</branchaddress1>
<branchcode>FFL</branchcode>
<branchname>Fairfield</branchname>
</anon>
<anon>
<pickup_location>1</pickup_location>
<branchaddress1>Hickory Squere</branchaddress1>
<branchcode>FPL</branchcode>
<branchname>Fairview</branchname>.....

Apart from the above it seems to work fine and the tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 09:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 08:44:43 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-PQQXBC8Ipj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Andreas Roussos <arouss1980 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arouss1980 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 10:41:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 09:41:18 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: <bug-24163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24163-70-K9AJfTQhPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 10:42:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 09:42:01 +0000
Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications
In-Reply-To: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23541-70-BQ1Gv3w7ug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 10:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 09:43:19 +0000
Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check
 for multiple holds allowed on a record
In-Reply-To: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16260-70-XpFGdbsPpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 10:45:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 09:45:58 +0000
Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold
 was cancelled because it was not picked up
In-Reply-To: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12656-70-pbRTxeOeWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 20:40:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 19:40:41 +0000
Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-9jGhwm56mD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #51 from David Nind <david at davidnind.com> ---
Everything works as per the the test plan, but tests fail:

root at ff2bb4ecb08d:koha(bz12430)$ prove t/Search.t
t/Search.t .. 1/6 
    #   Failed test 'Limit is correct'
    #   at t/Search.t line 94.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit desc is correct'
    #   at t/Search.t line 96.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit is correct'
    #   at t/Search.t line 121.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit desc is correct'
    #   at t/Search.t line 123.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit is correct'
    #   at t/Search.t line 148.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit desc is correct'
    #   at t/Search.t line 150.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit is correct'
    #   at t/Search.t line 268.
    #          got: ''
    #     expected: undef

    #   Failed test 'Limit desc is correct'
    #   at t/Search.t line 270.
    #          got: ''
    #     expected: undef
    # Looks like you failed 8 tests of 91.

#   Failed test 'buildQuery basic tests'
#   at t/Search.t line 283.
# Looks like you failed 1 test of 6.
t/Search.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests 

Test Summary Report
-------------------
t/Search.t (Wstat: 256 Tests: 6 Failed: 1)
  Failed test:  5
  Non-zero exit status: 1
Files=1, Tests=6,  4 wallclock secs ( 0.03 usr  0.01 sys +  3.42 cusr  0.12
csys =  3.58 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:29:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 20:29:16 +0000
Subject: [Koha-bugs] [Bug 24772] New: Deactivating Course Reserves reverts
 Item's Shelving Location,
 then deleting the same course reverts Course Reserve Values
Message-ID: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

            Bug ID: 24772
           Summary: Deactivating Course Reserves reverts Item's Shelving
                    Location, then deleting the same course reverts Course
                    Reserve Values
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Deactivating a from Course Reserves reverts Item's Shelving Location correctly,
then deleting the same course reverts the Course Reserve Items to old shelving
location values.

To Recreate: 

1. Add items to a Course - make sure they all have shelving locations prior to
being added to the course. 

2. When adding items change their shelving location to something else.

a. See that Shelving Location has changed; permanent location in parentheses
4. Deactivated course
a. See that Shelving Location has changed back to its original location
5. Deleted course
a. See that Shelving Location has changed back to what was picked during adding
it to the Course.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:33:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 20:33:52 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-lMUa9R7CsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #20)

> 3) I'd remove the a. b. c. etc. from the pref.

I added the letters so that the options would be sorted by how they appear in
the field, without the letters the options get sorted alphabetically. Happy to
make this change though if the order of the options is fine to be alphabetical

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 20:36:19 +0000
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
In-Reply-To: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8628-70-zA2KaEqpYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #95 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #94)
> 
> In the staff interface the add and edit screens take up the whole width of
> the screen, and the other tools menu items are pushed to the bottom.

Will look into this

> 
> On the signage screens, things don't display correctly.

Can you please advise what 'correctly' should look like? I took this patch over
from someone else and the signs have always displayed for me the way they do in
your screenshots. How do you expect them to look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:43:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 22:43:29 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-wdBaPcrLT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:53:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 22:53:58 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-3NN0cayO62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:54:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 22:54:03 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-z9qVeDASjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99512|0                           |1
        is obsolete|                            |

--- Comment #6 from Michal Denar <black23 at gmail.com> ---
Created attachment 99847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99847&action=edit
Bug 24219: Preserve sort order when returning to result list

There is a mismatch between sort_cgi, sort and sort_by variables.

 * sort_cgi
I did not find relevant occurrences of sort_cgi in the git log of both
search.pl and results.tt. So it seems that it never worked correctly.
 * sort
It is the JS variable use in browser.js
 * sort_by is the search.pl parameter to set the sort_by option

Test plan:
1. Perform a search in the staff client
2. Change the sort order to something different (try Author A-Z)
3. Click on a result to view the record
4. Click on "Results" button on left side to return to result list
=> Without this patch the result list is sorted by relevancy
=> With this patch applied the Author A-Z is kept

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2020 22:56:21 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-RhRifTC7qp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #3 from Michal Denar <black23 at gmail.com> ---
Hi Julian,
how test this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:27:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:27:06 +0000
Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon
 mode
In-Reply-To: <bug-16758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16758-70-LRR9fpI2Vh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:27:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:27:08 +0000
Subject: [Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon
 mode [OMNIBUS]
In-Reply-To: <bug-24761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24761-70-7uMRuFsqXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:29:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:29:35 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-lXpACu5cAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #11)
> It's always sad to remove code that has taken a lot of work and thought to
> get in, but at this point in time, it seems the right thing to do.

I was thinking the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:31:04 +0000
Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-v0Nq3Ayytg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #52 from David Cook <dcook at prosentient.com.au> ---
Interesting. I'll make a note to look at this later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:31:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:31:11 +0000
Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-gkqJ2sE3O1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #53 from David Cook <dcook at prosentient.com.au> ---
Interesting. I'll make a note to look at this later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 03:53:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 02:53:36 +0000
Subject: [Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which
 supports IPv6
In-Reply-To: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24739-70-VV0tXpf3rZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #9)
> That's awesome diligent work there David, thanks so much for checking it out
> and adding the enhanced test on top I was seeing of but unsure where to go
> with.
> 
> I'll work through testing it today for a quick route to QA.
> 
> Teamwork is awesome, it's great to have you back involved 😀.

Teamwork is totally awesome! Aww thanks. When you put it that way, I guess I
better keep up my efforts heh.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 04:49:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 03:49:19 +0000
Subject: [Koha-bugs] [Bug 24773] New: Report spacing incorrect on import
 from Mana
Message-ID: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

            Bug ID: 24773
           Summary: Report spacing incorrect on import from Mana
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Mana-kb
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com

When importing a report from Mana, there are missing whitespaces that break the
query. I'm not certain whether the spaces are lost when the report comes into
mana or when the report comes down to Koha. It might be dropping newlines?
Whatever the details, the reports require an amount of correction after
download that is prohibitive for some users.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 04:50:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 03:50:26 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-9GsRzQmT6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm not entirely clear whether this is something I should be filing here or
entering as an issue on Mana on Git.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 06:17:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 05:17:16 +0000
Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools
In-Reply-To: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24563-70-1h49d40I4Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563

--- Comment #4 from Govind Basedia <librarian at sageuniversity.in> ---
yes sir

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 07:07:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 06:07:33 +0000
Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools
In-Reply-To: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24563-70-32T6ssdwZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563

--- Comment #5 from Govind Basedia <librarian at sageuniversity.in> ---
Created attachment 99848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99848&action=edit
error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 07:23:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 06:23:58 +0000
Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14393-70-uIVamUrGLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #23 from David Cook <dcook at prosentient.com.au> ---
I think I've recently ported this to 19.11, so I'll have another look at this
soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 07:38:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 06:38:56 +0000
Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14393-70-pvh3GQkntr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:01 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-zkKWIw3JIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95627|0                           |1
        is obsolete|                            |

--- Comment #44 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99849&action=edit
Bug 22544: Move get_opac_new to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:05 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-IXgngTRWDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95628|0                           |1
        is obsolete|                            |

--- Comment #45 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99850&action=edit
Bug 22544: Move get_opac_news to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:10 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-lNcRqB3d75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95629|0                           |1
        is obsolete|                            |

--- Comment #46 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99851&action=edit
Bug 22544: Move del_opac_new to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:14 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-yAaiiC5OTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95630|0                           |1
        is obsolete|                            |

--- Comment #47 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99852&action=edit
Bug 22544: Move upd_opac_new to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:19 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-jI54m8sBIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95631|0                           |1
        is obsolete|                            |

--- Comment #48 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99853&action=edit
Bug 22544: Move add_opac_item to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:24 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-Gk71cI9FML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95632|0                           |1
        is obsolete|                            |

--- Comment #49 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99854&action=edit
Bug 22544: Move GetNewsToDisplay to Koha namespace

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:28 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-3ZZvIHN3Dh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95633|0                           |1
        is obsolete|                            |

--- Comment #50 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99855&action=edit
Bug 22544: Add tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:33 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-VpQM4wjciJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95634|0                           |1
        is obsolete|                            |

--- Comment #51 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99856&action=edit
Bug 22544: Refactor searching of news items

Test plan:
1) Go to tools and define some news
2) Try different parameters, try to edit new items, and delete some
3) Go to all places where news are presented and ensure that there are
the right ones shown:
    opac main page - based on language
    opac righ column (formerly syspref OpacNavRight) - based on language
    opac news rss feed
    circulation slip (not quick slip)
    intranet main page
4) run tests:
prove t/db_dependent/Koha/News.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:06:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:06:38 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-hWsTg1LaSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

--- Comment #52 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 99857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99857&action=edit
Bug 22544: (QA follow-up) Fix spelling

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 08:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 07:07:46 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-WKT3WkDJEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #53 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Katrin Fischer from comment #43)
> Patch no longer applies - please rebase!

Rebased on master. Thanks Katrin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:07:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:07:27 +0000
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
In-Reply-To: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8628-70-dIyfLeENae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

--- Comment #96 from David Nind <david at davidnind.com> ---
I'm not sure what 'correct' should look like, and was going off the original
mockups at https://wiki.koha-community.org/wiki/Digital_signs_RFC

I guess I was expecting the covers (if they exist) to display. When you click
(or touch on a touch screen) an item it will pop up with the details. You can
then continue paging through.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:22:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:22:05 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-Zw2wa8owEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Michal Denar from comment #3)
> Hi Julian,
> how test this patch?

Hi,

I think it's enough to `git grep Catmandu::MARC` and `git grep
Catmandu::Store::ElasticSearch` to see that they are used in Koha (thus they
must appear in cpanfile)

But you can go further and uninstall these modules, and see that search and
reindexation don't work when SearchEngine = Elasticsearch

You can try the latest version of Catmandu::Store::ElasticSearch and verify
that search doesn't work with it. Downgrade to 0.512 and verify that search
works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:26:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:26:29 +0000
Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should
 not be updated
In-Reply-To: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22273-70-3FtagBLDoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks Bernardo and Katrin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:29:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:29:28 +0000
Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should
 not be updated
In-Reply-To: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22273-70-bR110JW4LE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #7)
> This works well. Should we try and fix the updated_on with the created_on on
> update?

Did not think that it was so important for article requests to do so. Normally
I expect these dates to be quite close to each other.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:41:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:41:49 +0000
Subject: [Koha-bugs] [Bug 24753] Typo in filepath for test
 t/Koha/Middlware/RealIP.t
In-Reply-To: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24753-70-wtdOZi0jUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hmm. This has been pushed to master actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:41:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:41:59 +0000
Subject: [Koha-bugs] [Bug 24753] Typo in filepath for test
 t/Koha/Middlware/RealIP.t
In-Reply-To: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24753-70-iyrLvxBfmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:42:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:42:06 +0000
Subject: [Koha-bugs] [Bug 24753] Typo in filepath for test
 t/Koha/Middlware/RealIP.t
In-Reply-To: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24753-70-r40DtcO2OM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:42:12 +0000
Subject: [Koha-bugs] [Bug 24753] Typo in filepath for test
 t/Koha/Middlware/RealIP.t
In-Reply-To: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24753-70-tlCNmc2OGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:42:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:42:20 +0000
Subject: [Koha-bugs] [Bug 24753] Typo in filepath for test
 t/Koha/Middlware/RealIP.t
In-Reply-To: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24753-70-GwEbx9Vj6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:43:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:43:23 +0000
Subject: [Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which
 supports IPv6
In-Reply-To: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24739-70-nzoTfStRf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99752|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:45:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:45:36 +0000
Subject: [Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which
 supports IPv6
In-Reply-To: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24739-70-nqUmTwNInk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #19)
> *** Bug 24753 has been marked as a duplicate of this bug. ***

No, bug 24753 has been pushed. Follow-up removed. The QAed version of the
patches on this report is out of date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:52:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:52:45 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-EpWwq10NxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |BLOCKED

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Master D10 #100 29-02-2020 19:45 
not ok 7 - Expected import error
ok 8 - No read_net warn for remote import
Master D9 My8 #179 28-02-2020 15:57
idem not ok 7, ok 8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:55:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:55:06 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15985-70-91HjfbpYnN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is not FK on old_issues.branchcode, I think that should be taken into
account in Koha::Old::Issue->library

Also, POD and tests missing for Koha::Old::Issue->claim_returned

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:57:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 08:57:50 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15985-70-w8qIxopAhm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #23)
> 1. Changes are made in Koha/Schema/Result/OldIssue.pm, above the "DO NOT
> MODIFY THIS OR ANYTHING ABOVE!" line.
> Is it expected? Did you forget to attached the DB changes patch?
> If you wanted to add it after that line, why not adding the constraint at DB
> level?
> 
> Why not for Issue.pm?
> 
> 2.
> -use base qw(Koha::Object);
> +use base qw(Koha::Checkout);
> 
> Is this really needed? Why?
> If so I think it must be moved to its own bug report, explaining why we need
> it and what it will bring. Also tests must be provided for such changes.
> 
> Note that both t/db_dependent/Koha/Account/Lines.t and
> t/db_dependent/Koha/Checkouts.t are passing without that change.

And the 2 points here are been ignored. Please comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:00:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:00:39 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-LkwKbpjv7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |In Discussion

--- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Setting this to "In discussion" because bug 24608 depends on it and having it
"Blocked" prevents the QA of 24608. Although this bug is likely to be made
redundant by bug 24455, that bug is still awaiting sign off, so in the meantime
24608 cannot be QA'ed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:01:59 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-5VcXXtDHwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #9)
> Please fix the commit messages :(

What do you mean? All of them explain what they are doing.
With comment 0 and the 3 commit titles, everything is meaningful to me. I can
explain a bit more if you want me to clarify something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:02:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:02:59 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-OBkvrDBrsk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

--- Comment #10 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Actually, that doesn't seem to help as git bz still doesn't pick it up as a
dependency. I don't want to set it back to "Needs signoff", so I'll add a
comment to bug 24608 noting that this bug needs to be manually applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:03:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:03:07 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-U8XKAKT8xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:03:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:03:25 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-qlXIz40NSM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 99858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99858&action=edit
Bug 24756: Show the warnings on Jenkins

Temporary measure to see which warnings Jenkins got while we cannot
reproduce them ourselves on D8, D9 and D10.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:04:49 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-O5nPqZqK6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This produces output (in my D9 testing environment) like:

ok 7 - Expected import error. Additional info: $VAR1 = 'XSLT::Base: No such
file or directoryI/O warning : failed to load external entity
"http://notexpected.koha-community.org/noxsl/nothing.xsl"
# compilation error: file unknown-558d811413c0 element import
# xsl:import : unable to load
http://notexpected.koha-community.org/noxsl/nothing.xsl
#  at /usr/share/koha/Koha/XSLT/Base.pm line 343.
# ';
#
ok 8 - No read_net warn for remote import

Hopefully we'll know more when we run this on Jenkins?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:10:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:10:29 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: <bug-24162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24162-70-HMQdEyCbn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:13:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:13:51 +0000
Subject: [Koha-bugs] [Bug 24774] New: Specify 2 space indentation for JSON
 files in .editorconfig
Message-ID: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

            Bug ID: 24774
           Summary: Specify 2 space indentation for JSON files in
                    .editorconfig
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Developer documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at hypernova.fi
        QA Contact: testopia at bugs.koha-community.org

>From Bug 12545
>> It'd be usefull to have a .editorconfig [1] file, that enforces some of our
>> coding guidelines, in the source tree top level.
>> 
>> Those developers that have their editors configured to honour the file, will
>> benefit. Those that wouldn't use it, won't get bothered by the addition. So, a
>> harmless addition that would benefit those that are interested.
>>
>> There are plugins for several major editors:
>> - Emacs
>> - Vim
>> - SublimeText
>> - and so on...
>> 
>> [1] http://editorconfig.org/

Editors using .editorconfig by default set 4 space indentation in JSON files
although we have typically been using 2 spaces.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:14:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:14:20 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-jiSIkCvpxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi
                   |ity.org                     |
         Depends on|                            |12545
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545
[Bug 12545] Add EditorConfig file to the source tree
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:14:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:14:20 +0000
Subject: [Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree
In-Reply-To: <bug-12545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12545-70-yJFgCZLj9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774
[Bug 24774] Specify 2 space indentation for JSON files in .editorconfig
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:15:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:15:36 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-PXGKRQXO5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Owen - Thanks for taking a look at this, I appreciate it.

The reason for the error you're seeing is that this bug is dependent on bug
24650. That bug has been moved to "Blocked" status since another bug, bug 24455
is a possible duplicate, but is still awaiting sign-off. But since bug 24455
has not yet been signed off, I don't particularly want to make this bug
dependent on it.

Bug 24650 being blocked seems to stop git bz picking it up as a dependency. So
can I suggest manually applying that first and then applying this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:26:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:26:52 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-AK7VqQlRcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:26:54 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-tTzXPVa1Cy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 99860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99860&action=edit
Bug 24774: Set JSON indentation of 2 spaces in .editorconfig

To test:
1. Start an editor that supports .editorconfig
2. Open or create a JSON file
3. Observe identation is set to 2 spaces by default

Sponsored-by: Hypernova Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:28:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:28:24 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-M11VaCCsII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks guys, really pleased to see this one having made it through :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:28:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:28:31 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-4aINj8MWTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:30:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:30:36 +0000
Subject: [Koha-bugs] [Bug 24747] Library Transfer Limit page incorrectly
 describes its behavior
In-Reply-To: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24747-70-fsqUnKFQN1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24747

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This looks to be the first bug you've authored on Andrew, great to see, welcome
aboard! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:06 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-RYCkilPNq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:08 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-o6P2sdXUje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:10 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-Peesed2yQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:12 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-TpAE1Kf6pL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:14 +0000
Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should
 not be updated
In-Reply-To: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22273-70-ap8aLJzsjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:15 +0000
Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should
 not be updated
In-Reply-To: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22273-70-NJcwTiHKz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:17 +0000
Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word
 order in Patron card creator
In-Reply-To: <bug-23488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23488-70-YuuqrUJmdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:19 +0000
Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word
 order in Patron card creator
In-Reply-To: <bug-23488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23488-70-3ZACUdctV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:21 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-RMYs0GNXuR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:22 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-duINJhn02q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:24 +0000
Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron
 entry
In-Reply-To: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23536-70-rrSgajxm47@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:26 +0000
Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron
 entry
In-Reply-To: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23536-70-ph17bWOf73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:28 +0000
Subject: [Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using
 background job JavaScript
In-Reply-To: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23753-70-AmEyWp4sai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:29 +0000
Subject: [Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using
 background job JavaScript
In-Reply-To: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23753-70-DfYYuzWS3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:31 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-gFzo3ISs9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:33 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-doY35shDy6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:35 +0000
Subject: [Koha-bugs] [Bug 24727] Typo in circulation.js
In-Reply-To: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24727-70-cByzZ5XPRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24727

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:37 +0000
Subject: [Koha-bugs] [Bug 24727] Typo in circulation.js
In-Reply-To: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24727-70-iDWKSdEk52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24727

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:39 +0000
Subject: [Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory
 for js files
In-Reply-To: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24734-70-b8yjRXnCvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:40 +0000
Subject: [Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory
 for js files
In-Reply-To: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24734-70-ZgelhdR5Tm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:42 +0000
Subject: [Koha-bugs] [Bug 24736] "Enrollments" not correctly disabled when
 nobody is enrolled to a club yet
In-Reply-To: <bug-24736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24736-70-KKJvtyHt4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:44 +0000
Subject: [Koha-bugs] [Bug 24736] "Enrollments" not correctly disabled when
 nobody is enrolled to a club yet
In-Reply-To: <bug-24736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24736-70-Xx1lbRMICn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:46 +0000
Subject: [Koha-bugs] [Bug 24746] Duplicate id in opacheader markup
In-Reply-To: <bug-24746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24746-70-Z7279GQ2Zs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:48 +0000
Subject: [Koha-bugs] [Bug 24746] Duplicate id in opacheader markup
In-Reply-To: <bug-24746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24746-70-fk99ZNUy3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:49 +0000
Subject: [Koha-bugs] [Bug 24747] Library Transfer Limit page incorrectly
 describes its behavior
In-Reply-To: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24747-70-rtUR1a3Z9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24747

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:47:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:47:51 +0000
Subject: [Koha-bugs] [Bug 24747] Library Transfer Limit page incorrectly
 describes its behavior
In-Reply-To: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24747-70-gjRjLe85SU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24747

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:55:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:55:03 +0000
Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should
 not be updated
In-Reply-To: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22273-70-576yM40WkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

We got quite a few reports for libraries that use article requests - was
thinking more along these lines :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:59:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:59:31 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-3iihaCC4bq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:59:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:59:34 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-IyWDvhlrvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99861&action=edit
Bug 24757: Leap day failing tests - It's like we are on 2020-02-28

Those tests were failing on 2020-02-28, next day was a leap day.
Let's fake time and recreate the failure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:59:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:59:37 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-A2uyGdB28w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99862&action=edit
Bug 24757: Leap day failing tests - refactoring

Refactore the tests to add more of them after we fixed the failing ones.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:59:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:59:40 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-i4noO4tQfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99863&action=edit
Bug 24757: Leap day failing tests - Fix the tests!

The same day was returned, for a different subtraction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:59:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 09:59:43 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-NyxenbupDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99864&action=edit
Bug 24757: Add more tests

Now we want to make sure we are not missing another situation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:02:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:02:18 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-OlK6n9Xj7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24741


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741
[Bug 24741] Recent creation of unique index on library_groups erroneously
removes rows
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:02:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:02:18 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-gptUDyXM1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21674


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674
[Bug 21674] Data integrity not enforced for library groups
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:05:05 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-iue1zU8Lm1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The best here would be to add to the discussion to push forward a solution
(unblocking the depenencies).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:05:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:05:43 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-BNDb41Rpx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99861|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99865&action=edit
Bug 24757: Leap day failing tests - It's like we are on 2020-02-28

Those tests were failing on 2020-02-28, next day was a leap day.
Let's fake time and recreate the failure

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:05:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:05:46 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-DYSsXta8UZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99862|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99866&action=edit
Bug 24757: Leap day failing tests - refactoring

Refactore the tests to add more of them after we fixed the failing ones.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:05:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:05:49 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-kTvVaB0Ryw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99863|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99867&action=edit
Bug 24757: Leap day failing tests - Fix the tests!

The same day was returned, for a different subtraction.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:05:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:05:52 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-TgBC2RoI4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99864|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99868&action=edit
Bug 24757: Add more tests

Now we want to make sure we are not missing another situation.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:01 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-WThZnDsn3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:23 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-Nyga4c8CDf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Code all makes sense, thanks for the diligent and clear working through it.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:36 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-h6X42D2vMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:38 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-17saXvrTls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:39 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-1smprXNE0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:06:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:06:53 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-I1diPqNdas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>From 0445ff47aea8cbe01e5fbb212aebe4885b65deb3 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri, 15 Mar 2019 19:24:19 -0300
Subject: [PATCH] Bug 20728: Proof that there is no cheating

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>


The don't have descriptions or test plans. And I already failed to understand
the first one from the subject. comment #0 shoudl be in one of the commit
messages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:09:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:09:54 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-K2No7w0xDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I tried again.
For me it does not remove non-duplicate entries, but it removed an empty
subgroup:

Before: https://snipboard.io/20aTY9.jpg
After : https://snipboard.io/lKzaeE.jpg

Subgroup 'yyyy' has been removed (not correct), however 'FPL' has not been
removed from the first 'xx' group.

Did you notice another behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:15:48 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-POIhNZW28g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Gustafsson from comment #1)
> I'm not 100%, but think a correct query to remove duplicates could be
> written like:
>  
> DELETE FROM library_groups
> WHERE id NOT IN (
>   SELECT MIN(id)
>   FROM ( SELECT * FROM library_groups ) AS lg
>   GROUP BY parent_id, branchcode
> )
> AND NOT(parent_id IS NULL OR branchcode IS NULL);

This query looks correct to me. Could you submit a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:19:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:19:55 +0000
Subject: [Koha-bugs] [Bug 24390] Add item total to rotating collections
 (addItems.tt)
In-Reply-To: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24390-70-E5GW12n4ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Not entirely sure how the code worked before Katrins follow-up.. I like the
follow-up, it seems much clearer to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:21:19 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-935B1JRZuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

--- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
I'd say this bug looks far more useful than mine in bug 24650, which only
solves a single problem I had. If we are moving more towards API driven
interfaces, the need to reliably parse and manipulate dates in JS is crucial.
Since moment.js is the defacto way of doing this in JS, it seems by far the
best way forward.

I'll apply and sign this off now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:26:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:26:09 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-9WyiElJdsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #7)
> Created attachment 99829 [details] [review]
> Bug 24434: Remove updateWrongTransfer
> 
> This patch simply removes the unused updateWrongTransfer method from
> C4::Circulation.
> 
> Test plan: Read code and varify that the method would never actually be
> triggered.
> 
> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
> 
> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Katrin, did you investigate the possible problem I raised in my previous
comment?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:28:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:28:50 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-ggZ4xzNdNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97574|0                           |1
        is obsolete|                            |

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99869&action=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:28:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:28:54 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Nq7xO058Cj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97575|0                           |1
        is obsolete|                            |

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99870&action=edit
Bug 24455: Add moment library in staff

This patch adds koha-tmpl/intranet-tmpl/lib/moment/moment.min.js in order to
use the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:28:57 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-xX6ybsdQx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97576|0                           |1
        is obsolete|                            |

--- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99871&action=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:29:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:29:00 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-EBB30LzOjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97577|0                           |1
        is obsolete|                            |

--- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99872&action=edit
Bug 24455: Add moment-timezone library in staff

This patch adds
koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:29:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:29:03 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Uky3eS1JRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99195|0                           |1
        is obsolete|                            |

--- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99873&action=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the a js-date-format.inc file on each opac and staff interface
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:29:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:29:06 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-XoyliYyS2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99874&action=edit
Bug 24455: test timezone

This is just a test.. I added the .inc file to adimn's main page

To test:

1. go to Koha main page and open chrome or firefox console
2. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'America/Argentina/Buenos_Aires'})

   and you should get

   "02/18/2020 09:46"

   because America/Argentina/Buenos_Aires is -03:00

3. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'Asia/Shanghai'})

   and you should get

   "02/18/2020 20:46"

   because Asia/Shanghai is +08:00

4. type

   $datetime('2020-02-18T12:46:05Z')

   and it should be translated to your koha instance configured timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:30:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:30:27 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-ySucmzY7Xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah sorry, I didn't quite understand - I checked that the variable name didn't
seem to appear anywhere, coming to the conclusion it was not used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:32:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:32:11 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-fcKtRzJzEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #26 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99875&action=edit
Bug 24455: [DO NOT PUSH] test timezone

This is just a test.. I added the .inc file to adimn's main page

To test:

1. go to Koha main page and open chrome or firefox console
2. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'America/Argentina/Buenos_Aires'})

   and you should get

   "02/18/2020 09:46"

   because America/Argentina/Buenos_Aires is -03:00

3. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'Asia/Shanghai'})

   and you should get

   "02/18/2020 20:46"

   because Asia/Shanghai is +08:00

4. type

   $datetime('2020-02-18T12:46:05Z')

   and it should be translated to your koha instance configured timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:32:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:32:24 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-fTCmXYotGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99198|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:32:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:32:41 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-OEumvNb5eQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99874|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:33:39 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-24AwYZwcsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Signed off on the basis of passing the tests in comment #16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:34:10 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-nExrC1DaHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99876&action=edit
Bug 17016: (follow-up) Clear with 0.00 instead of blank (Use Price)

Using Price, to formatted it correctly if needed
So far it will not do anything as 'on_editing => 1' we keep 0.00, but it
must be improved later (when we will handle that)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:35:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:35:08 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-3RsOyjgXvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for the quick followup Jonathan :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:38:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:38:04 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-PuYu4TdLVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|date formatting from JS     |Date formatting from JS
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Andrew! If this solves your need - should we mark bug 24650 duplicate or
resolved moved?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:42:57 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-W39ylNPXyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:42:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:42:59 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-B6Jgvgm2q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:01 +0000
Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
In-Reply-To: <bug-21746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21746-70-eU2hObqJC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:02 +0000
Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
In-Reply-To: <bug-21746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21746-70-9o3AHXEaXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:04 +0000
Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves
 table in the OPAC
In-Reply-To: <bug-23547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23547-70-G92daK12sC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:06 +0000
Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves
 table in the OPAC
In-Reply-To: <bug-23547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23547-70-0uY3xN72yb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:08 +0000
Subject: [Koha-bugs] [Bug 24390] Add item total to rotating collections
 (addItems.tt)
In-Reply-To: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24390-70-0Tq5RYWplS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:10 +0000
Subject: [Koha-bugs] [Bug 24390] Add item total to rotating collections
 (addItems.tt)
In-Reply-To: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24390-70-BT3WHGcmoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:12 +0000
Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail
 (following 24530)
In-Reply-To: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24617-70-cpF2QPKlSn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:14 +0000
Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail
 (following 24530)
In-Reply-To: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24617-70-ZvUd26geIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:15 +0000
Subject: [Koha-bugs] [Bug 24732] Make DumpTemplateVars more readable
In-Reply-To: <bug-24732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24732-70-r6fGipdBp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24732

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:43:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:43:17 +0000
Subject: [Koha-bugs] [Bug 24732] Make DumpTemplateVars more readable
In-Reply-To: <bug-24732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24732-70-zOt2laHJen@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24732

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:46:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:46:02 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-CKR3SPxiwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99655|0                           |1
        is obsolete|                            |
  Attachment #99656|0                           |1
        is obsolete|                            |
  Attachment #99657|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99877&action=edit
Bug 20728: Proof that there is no cheating

To make sure the replacing code will acchieve the same things as the
actual one, we replace the raw SQL query with the DBIC version of it.
Then the tests will show us that they are equivalent.

Test plan:
Apply only this patch, run the tests, confirm they pass.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:46:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:46:05 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-pl24uKkXR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99878&action=edit
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent

There are 2 subroutines from C4::Acquisition that could be removed:
- GetLastOrderReceivedFromSubscriptionid
- GetLastOrderNotReceivedFromSubscriptionid

After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used
(from acqui/neworderempty.pl) and this call could be replaced easily with
Koha::Acquisition::Orders

The code (+ tests) related to these 2 subroutines could then be removed.

The parameters for the search is basic and does no really deserve its own
subroutine.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:46:08 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-FlHx5OI4EK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99879&action=edit
Bug 20728: Remove the 2 GetLastOrder* subroutines

At this point the 2 subroutines are no longer in used.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:46:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:46:41 +0000
Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20728-70-lhHmAdJVCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have adjusted the commit messages, hope it's better now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:47:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:47:13 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-diEJn6NuOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99880&action=edit
Bug 24608: (follow-up) Switch to bug 24455 dates

Bug 24455 does a far more comprehensive job of date parsing than my
single use case patch in bug 24650, therefore this bug has now switched
to using it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:49:01 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-c9sAjHfeDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24650                       |24455

--- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi (again) - I've now switched to depending on bug 24455 rather than my puny
bug 24650 as 24455 brings much more comprehensive date handling to JS in Koha
through use of moment.js


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] Date formatting from JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650
[Bug 24650] API returned timestamps are incompatible with existing helpers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:49:01 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Q23Z4R52ey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608
[Bug 24608] Allow modification of checkout due date
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:49:01 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-CvNm8g5Q9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608
[Bug 24608] Allow modification of checkout due date
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:50:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:50:00 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-aE69SajrxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #12 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Done. I have tested and signed off bug 24455, I've also switched my dependent
bug 24608 to use that. I'll mark this as a duplicate.

*** This bug has been marked as a duplicate of bug 24455 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:50:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:50:00 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-C0AjpXF4kf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
*** Bug 24650 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:51:12 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-hQ4EInnvBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #30 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #28)
> Thx, Andrew! If this solves your need - should we mark bug 24650 duplicate
> or resolved moved?

Done :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:52:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:52:50 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
 course reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-nxkWSMSr8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Welcome aboard Rogan Hamby, great to have a new name to add to the
contributors' list :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:54:39 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-XvAIaQWFdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94389|0                           |1
        is obsolete|                            |

--- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99881&action=edit
Bug 22806 : CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:54:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:54:57 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
 course reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-dabwTNt309@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:54:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:54:59 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
 course reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-uuUNTGc6vE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:55:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:55:01 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-pSKGEWn1OL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:55:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:55:03 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-S5Pgl2Bq1m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:55:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:55:05 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-cSQKNWLTyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:55:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:55:07 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-G5B7wO351p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:55:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:55:08 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-3bWG21mtTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94388|0                           |1
        is obsolete|                            |

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99882&action=edit
Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

As CanBookBeReserved() was failing as $patron and and $biblio were not
instantiated I fixed that up.

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Sponsored-By: Catalyst IT
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:57:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:57:20 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-CYTSpooDEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99883&action=edit
Bug 22806: CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:57:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:57:48 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-wCelxwUu44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #16 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99884&action=edit
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

As CanBookBeReserved() was failing as $patron and and $biblio were not
instantiated I fixed that up.

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Sponsored-By: Catalyst IT
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:58:18 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-qJN959ePJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 10:58:25 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-ccVUBFpC2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97947|0                           |1
        is obsolete|                            |

--- Comment #17 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99885&action=edit
Bug 22806: Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:00:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:00:45 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-xn6u39598y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to David Nind from comment #12)
> Patch no longer applies.

Hi David,
thanks for your help on that one, I've rebased the patch on current master and
made sure the tests and qa tools passes (is it passed qa then?)
patches ready for testing :)
Kr,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:01:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:01:30 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-mqxyQJ6X4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #14)
> Hopefully we'll know more when we run this on Jenkins?

=== https://jenkins.koha-community.org/job/Koha_Master_D8/725/
not ok 7 - Expected import error. Additional info: $VAR1 = 'XSLT::Base: I/O
warning : failed to load HTTP resource
# compilation error: file unknown-3d22ae0 element import
# xsl:import : unable to load
http://notexpected.koha-community.org/noxsl/nothing.xsl
#  at /kohadevbox/koha/Koha/XSLT/Base.pm line 343.
# ';
# 
ok 8 - No read_net warn for remote import

Here the wording "failed to load HTTP resource" is used instead of "failed to
load external entity". It appears that both can come up.
libxml2 contains both strings
  failed to load external entity "%s"
  failed to load HTTP resource "%s"
and even:
  Failed to load externalRef %s
  Failed to load include %s
(But we did not see the last two.)

So we probably just need:
    is( ( grep { /failed to load (external entity|HTTP resource)/ } @warn ), 1,
'Expected import error' );

I will wait a few days now before replacing the additional Dumper info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:41 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-9ERtLWxwnW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98586|0                           |1
        is obsolete|                            |

--- Comment #35 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99886&action=edit
Bug 23916: Add issues.issuer column and FK

This patch adds the issues.issuer column which is a foreign key to
borrowers.borrowernumber

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:44 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-Q0oMsJ2o0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98587|0                           |1
        is obsolete|                            |

--- Comment #36 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99887&action=edit
Bug 23916: Add "RecordIssuer" syspref

This patch adds the "RecordIssuer" syspref, which is disabled by default

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:47 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-i0LqT15AaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98588|0                           |1
        is obsolete|                            |

--- Comment #37 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99888&action=edit
Bug 23916: Record and display item issuer

This patch adds the recording and display of the item issuer. This
behaviour is governed by the RecordIssuer syspref, if disabled (the
default), no recording or display of issuer will take place.

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:50 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-dQq0GfhiEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98589|0                           |1
        is obsolete|                            |

--- Comment #38 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99889&action=edit
Bug 23916: Anonymise 'issuer' when required

This patch adds the anonymisation of 'old_issues.issuer' alongside the
existing anonymisation of 'old_issues.borrowernumber'

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:53 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-OuIOtNxIsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98590|0                           |1
        is obsolete|                            |

--- Comment #39 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99890&action=edit
Bug 23916: Add unit tests

This patch adds unit tests for the new functions

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:06:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:06:56 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-T7Qd6FV5O6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98591|0                           |1
        is obsolete|                            |

--- Comment #40 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99891&action=edit
Bug 23916: (follow-up) Fix column name collision

Seems that joining 'borrowers' into the query run in
C4::Members::GetAllIssues caused a column name collision, which blatted
the retrieval of issues.branchcode. So we now are being a bit more
specific in what is coming from where in the query.

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:12:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:12:14 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-WtOsa72xMy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99649|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:13:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:13:48 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-qzVqYWN8v9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:13:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:13:50 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-jVhoiBQDTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:15:53 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-fg7SBfUPng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:16:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:16:54 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-EjqKrFQ0ue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 99892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99892&action=edit
Bug 24756: Catch two failed to load-variations in Security.t

Test 7 in Security.t failed when 'failed to load HTTP resource' was
returned by libxml2 instead of 'failed to load external entity'.

We now remove the debugging with Dumper again and adjust the regex to
include both variations.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:17:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:17:58 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-1HmLTeA5T8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:20:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:20:19 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-4equMrfHU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This looks pretty sensible and sane to me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:34 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-4vUsZBC46S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95255|0                           |1
        is obsolete|                            |

--- Comment #60 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99893&action=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:37 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-ZWwSIDDC1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95256|0                           |1
        is obsolete|                            |

--- Comment #61 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99894&action=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:40 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-BQniDtZsnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95257|0                           |1
        is obsolete|                            |

--- Comment #62 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99895&action=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:44 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-HCgOb6TGpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95258|0                           |1
        is obsolete|                            |

--- Comment #63 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99896&action=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:47 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-LVYj0qAN70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95259|0                           |1
        is obsolete|                            |

--- Comment #64 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99897&action=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:51 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-2RlrsRKGeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95260|0                           |1
        is obsolete|                            |

--- Comment #65 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99898&action=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:54 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-OY1wKPK9nH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95261|0                           |1
        is obsolete|                            |

--- Comment #66 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99899&action=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:27:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:27:58 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-a6ouB4IGBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95262|0                           |1
        is obsolete|                            |

--- Comment #67 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99900&action=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:28:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:28:01 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-dKbzu8CXv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95263|0                           |1
        is obsolete|                            |

--- Comment #68 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99901&action=edit
Bug 23681: Add unit tests

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:28:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:28:05 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-DojdaUQ6c3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95264|0                           |1
        is obsolete|                            |

--- Comment #69 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99902&action=edit
Bug 23681: (follow-up) Fix typo

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:33:39 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-3bQquljp9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99903&action=edit
Bug 24479: Use $Price filters for '0' amounts

This patch adds the use of the $Price TT filter to properly format '0'
amounts in the POS system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:33:54 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-WH6T7den3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:40:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:40:39 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-LBFzr7OnsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #7)
> Should we have a QA script check/coding guidelines for this?

See https://gitlab.com/koha-community/qa-test-tools/issues/26 for the QA check.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:44:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:44:27 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-0fNeOYDHbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:45:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:45:01 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-e6FJu4PerW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm in agreement with Jonathan here.. I think we need a deeper investigation
into how/where these variable were removed in the first place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:54:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:54:05 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-MxqO65AtWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:54:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:54:05 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-BgG7FpTV5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24479


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479
[Bug 24479] New POS doesn't follow CurrencyFormat
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:55:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:55:41 +0000
Subject: [Koha-bugs] [Bug 24775] New: Payment submit button on POS page
 should have an ID
Message-ID: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

            Bug ID: 24775
           Summary: Payment submit button on POS page should have an ID
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    martin.renvoize at ptfs-europe.com,
                    testopia at bugs.koha-community.org
        Depends on: 23354
            Blocks: 13985

Sometimes people wish to override the payment button, for example to open a
cash register via JS.. as such it's helpful to have an ID for the button.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:55:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:55:41 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-QyNaHfCwZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775
[Bug 24775] Payment submit button on POS page should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:55:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:55:41 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-rC1piXgVuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775
[Bug 24775] Payment submit button on POS page should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:56:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 11:56:56 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-QyjjNxhAje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

--- Comment #4 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
(In reply to Jonathan Druart from comment #2)
> I tried again.
> For me it does not remove non-duplicate entries, but it removed an empty
> subgroup:
> 
> Before: https://snipboard.io/20aTY9.jpg
> After : https://snipboard.io/lKzaeE.jpg
> 
> Subgroup 'yyyy' has been removed (not correct), however 'FPL' has not been
> removed from the first 'xx' group.
> 
> Did you notice another behavior?

Yes.

In our case we had:

https://snipboard.io/cLhEY7.jpg

Since I've restored the data, I don't have an after-image, but after the
migration ACQ was the only one left under __SEARCH_GROUPS__. All the others had
been removed, with their entire substructure.

ACQ is the one with the lowest "id", and MIN(id) therefor kept that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:00:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:00:58 +0000
Subject: [Koha-bugs] [Bug 24730] Enhancing hold cancellations
In-Reply-To: <bug-24730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24730-70-3ikfc7vfNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24730

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:01:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:01:13 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-YKOl58HObK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99904&action=edit
Bug 24775: Add ID to POS submit payment button

This patch simply adds an ID to the submit button to make it easier to
overide styling and functionality.

Test Plan:
0/ Inspect the element on page and note there is no id
1/ Apply patch
2/ Refresh page
3/ Inspect the element on page and note there is now an id

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:01:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:01:31 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-VBlmSXioAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:01:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:01:41 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-TESLm7QXjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:01:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:01:50 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-qpX6RiNuRe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark.gavillet at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:02:15 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-MS2SZK14XX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:02:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:02:22 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-KDCUh2UAvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:03:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:03:54 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-rTNaMxace2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #45)
> (In reply to Jonathan Druart from comment #44)
> > What do others think? Could we get your opinions?
> 
> I think having option to get email notices as well as having the staff
> interface is useful - I don't think we need to pick only one - but once
> there is a GUI the notices should be optional

The problem with having the GUI after is that we do not deal with some of the
already created fields.
See comment 42: "the status will never be updated, what will happen when we
will have the UI?"

> >Bug 4461: Use KohaAdminEmailAddress pref as 'from'
> I don't understand that followup - 'from_address' is just picked form the
> message in C4/Letters - it is 'to_address' that usually gets filled at send
> - to be to the borrowernumber
> 
> In this case I think we could set it as:
> $patron->notice_email_address || $koha_admin;

I do not think so, as said in the commit message "I do not think it's a good
idea, we should not send an email with "from" if not really sent by the user."
I think it's bad practice to do that, I may be wrong however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 12:36:31 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-Nl3nGIBeOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:17:20 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-hJ63JgWXUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269
[Bug 10269] add a way to define a specific replyto email address for some
notice
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:17:20 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-LmTLlNiVZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |22821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:18:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:18:17 +0000
Subject: [Koha-bugs] [Bug 2234] Make cart email from/reply-to/return-path
 address configurable
In-Reply-To: <bug-2234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2234-70-PzU1eSyluD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |22821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:18:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:18:17 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-q4hJAjHasJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234
[Bug 2234] Make cart email from/reply-to/return-path address configurable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:18:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:18:29 +0000
Subject: [Koha-bugs] [Bug 3679] Specify Reply-To address when emailing a
 list or cart from OPAC
In-Reply-To: <bug-3679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3679-70-uPegdCWPVc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22821
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:18:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:18:29 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-p4ISdQcKYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679
[Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:18:54 +0000
Subject: [Koha-bugs] [Bug 24769] DataTable error on patron hold page when
 hold placed using ILS-DI
In-Reply-To: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24769-70-Yme2dwvXhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:24:27 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-rWaMTaTmT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If Aleisha says the GUI will be next, I am not so worried about the status and
such. It would be nice to see the code, but I feel this was just planning ahead
and would not cause harm for now.

> > In this case I think we could set it as:
> > $patron->notice_email_address || $koha_admin;
> 
> I do not think so, as said in the commit message "I do not think it's a good
> idea, we should not send an email with "from" if not really sent by the
> user." I think it's bad practice to do that, I may be wrong however.

I agree here. To avoid being rejected as spam you can use the reporting
patron's email as replyto, but not as From. So it's more than a bad practice as
a lot of mail servers got a lot stricter in the last years - it will be real
trouble (been there). From and Return-path needs to be from the mail servers
domain. See also:
https://wiki.koha-community.org/wiki/MRenvoize/Email

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:42:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:42:18 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-lG3FfRxI5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I documented some of the ReplyTo stuff back when it was first introduced as a
feature in bug 9530.. Jonathan is correct, we should not spoof user address in
the from address is it's very likely you'll end up in a spam list that way.

https://wiki.koha-community.org/wiki/MRenvoize/Email roughly explains it and I
have a feeling that was lifted and put in our own manual somewhere but I can't
see it right now.

In bug 22821 I add some handling to allow specifying reply-to address at the
EnqueuLetter stage.. it is my feeling if you want to send email 'from' a patron
'to' a library you should use a combination of not supplying a 'from' address
(as it'll pick an appropriate one in _send_message_by_email), setting the 'to'
using Koha::Library->get_effective_email (perhaps I should rename that
get_inbound_email_address) which will do an appropriate fallback through
replyto addresses and finally add a reply-to address of the patron so whoever
receives the email can reply to the actual user.

See bug 22821 and bug 22823 for some further details around email handling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:43:44 +0000
Subject: [Koha-bugs] [Bug 24747] Library Transfer Limit page incorrectly
 describes its behavior
In-Reply-To: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24747-70-V1Nqh8aR8x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24747

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Thanks, Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:45:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:45:09 +0000
Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken
In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23727-70-3SbTC28HPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Kyle, any ideas about how we could fix this correctly?
> 
> Something bad has happened to CourseReserves::_UpdateCourseItem. This
> function should check to see if the course is active. If it is inactive, it
> should edit the values in the course_items table, if it is active, it should
> edit the values in the items table. In master, it *always* edits the items
> table, and there is no way to ever update the course_items table no matter
> if the course is active or inactive!
> 
> This is appears to be a deeper more problematic issue than the stated one
> though. I think the solution for the "Unchanged" issue is to add a
> 'use/ignore' column for each of the swappable columns (itype_enabled,
> ccode_enabled, etc), along with a checkbox in the editor to enable them.
> 
> This would solves the original issue, that "Unchanged" as a value has been
> unreliable and weird. The module was first written without the expectation
> that a library would want an item column to be undef while *not* on course
> reserve, and have a value while *on* course reserve. Undef was used to
> signify the "Leave unchanged" status. It seems that after solving the more
> pressing issue above, moving the swap-ability indicator to it's own column
> would be the once-and-for-all solution to this problem.

Kyle, did you track down which patch (bug number) broke the original feature?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:50:37 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-eAveI67Xgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10269
             Blocks|10269                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269
[Bug 10269] add a way to define a specific replyto email address for some
notice
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:50:37 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-TkTMIczUqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22821
         Depends on|22821                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 13:51:28 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-KeCjpW18OQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm going to move the reply-to handling into a submission for bug 10269 as that
way it can then be a simple dependency for a bunch of other bugs that want it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:08:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:08:38 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-sDI8vmsXic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99905&action=edit
Bug 10269: Add reply_address field to message_queue table

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:08:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:08:41 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-lTlzkrABf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99906&action=edit
Bug 10269: Schema Update

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:08:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:08:43 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-C1EMO2HLoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99907&action=edit
Bug 10269: Use 'reply-to' address if passed to EnqueueLetter

This patch updates the EnqueueLetter method to allow passing a reply_to
address. This allows for passing in arbitrary addresses for the reply
address which will not override the from address. This improves the
chances of your email getting past spam filters.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:09:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:09:21 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-XeChq3IJvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pulling the SO through from bug 22821 where this code was originally submitted
and tested inline there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:11:51 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-9ZejfylBf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #95 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Just realized Age Restriction issue has been fixed in BZ13113.
Will re-post patches and change tests accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:12:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:12:11 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Y6hox2dzqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #47)
> If Aleisha says the GUI will be next, I am not so worried about the status
> and such. It would be nice to see the code, but I feel this was just
> planning ahead and would not cause harm for now.

For now no. But when the GUI will be there the message will be marked as "new"
even if they have been processed already. If we mark them all as "processed"
when the GUI is added, that will also be wrong: some may have not still been
processed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:14:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:14:20 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-JcJxDEQWfG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99734|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99908&action=edit
Bug 22821: Use 'reply-to' address in issue notes

This patch updates the issue notices to not pass from_address and so
default to the branch email of the user for from_address. We now pass
the patrons email (cascading through email, emailpro, B_email) into the
reply_address field so mail servers are less likely to report emails as
spam and mail clients still have access to the patron address via the
reply-to header when staff want to hit 'reply' and have the email go to
the user.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:14:23 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-fsrxBunn7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99735|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99909&action=edit
Bug 22821: Correct to_address for issue notes

This patch updates the controller and service code to use the newly
introduced 'get_effective_email' routine from bug 22823 to obtain the
branches most appropriate email address.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:14:40 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-Icy5jLV2Oo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99732|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:14:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:14:50 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-ePWUHWuS2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99733|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:11 +0000
Subject: [Koha-bugs] [Bug 2234] Make cart email from/reply-to/return-path
 address configurable
In-Reply-To: <bug-2234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2234-70-JcNxsj1Nm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22821                       |10269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269
[Bug 10269] add a way to define a specific replyto email address for some
notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:11 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-IHdLXhWWpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234
[Bug 2234] Make cart email from/reply-to/return-path address configurable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:11 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-HJM1eEH5en@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2234                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234
[Bug 2234] Make cart email from/reply-to/return-path address configurable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:17 +0000
Subject: [Koha-bugs] [Bug 3679] Specify Reply-To address when emailing a
 list or cart from OPAC
In-Reply-To: <bug-3679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3679-70-Dkjp5aJbiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22821                       |10269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269
[Bug 10269] add a way to define a specific replyto email address for some
notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:17 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-D4UoCBM2pm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679
[Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:15:17 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-fFBOS8ICb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3679                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679
[Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:16:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:16:55 +0000
Subject: [Koha-bugs] [Bug 24776] New: Remove Borrowers Template Toolkit
 plugin
Message-ID: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

            Bug ID: 24776
           Summary: Remove Borrowers Template Toolkit plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Borrowers Template Toolkit plugin contains methods IsDebarred and HasOverdues
that can be directly called from Koha::Patron object.
Also in template circ/returns.tt, when patron is restricted and checkin was
backdated, var "patron" is undefined, should be "issue.patron".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:17:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:17:21 +0000
Subject: [Koha-bugs] [Bug 24776] Remove Borrowers Template Toolkit plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-IWIFk1PIAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:25 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-RZjocWf0qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95565|0                           |1
        is obsolete|                            |

--- Comment #51 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99910&action=edit
Bug 23112: Add CirculateILL syspref

Sponsored-by: Loughborough University
Signed-off-by: Chris Walton <C.J.Walton at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:28 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-D2DkgXrUiv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95566|0                           |1
        is obsolete|                            |

--- Comment #52 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99911&action=edit
Bug 23112: Add circulation to ILL requests

This patch adds the ability to circulate ILL requests. Once a request has a
suitable status, a "Check out" button is displayed on the "Manage request"
toolbar. Clicking this will enable the user to check out the item either to the
user who made the request or an in-house statistical  user. A due date can be
specified, but if not circ rules are used.

Prior to the check out, an item is created which is attached to the biblio
record that was created when the request was added

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:32 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-kKw27COHIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95567|0                           |1
        is obsolete|                            |

--- Comment #53 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99912&action=edit
Bug 23112: Add permission checks

We only want the ILL circulation functionality to be available if the
appropriate syspref and perm are available, this patch adds those
checks.

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:36 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-reupydohZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95568|0                           |1
        is obsolete|                            |

--- Comment #54 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99913&action=edit
Bug 23112: Update request status on return

This patch updates a request's status to RET upon return

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:39 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-gjiz6sGkjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95569|0                           |1
        is obsolete|                            |

--- Comment #55 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99914&action=edit
Bug 23112: Add unit tests

This patch adds unit test for the new Koha::Illrequest::check_out method

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:43 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-q3VJtptXt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95570|0                           |1
        is obsolete|                            |

--- Comment #56 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99915&action=edit
Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues

In response to the problem Magnus was experiencing in comment #28 & #29
we now call GetAuthorisedValues by it's full path

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:47 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-KgwrptScNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96834|0                           |1
        is obsolete|                            |

--- Comment #57 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99916&action=edit
Bug 23112: (follow-up) Address QA feedback

As per comment #46

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:18:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:18:50 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-Vk24RR0JSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96870|0                           |1
        is obsolete|                            |

--- Comment #58 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99917&action=edit
Bug 23112: (follow-up) Fix test as per feedback

As per comment #48

https://bugs.koha-community.org/show_bug.cgi?id=23113

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:19:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:19:33 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-Tl9SIBITah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #59 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Needed rebase due to dependent patch in bug 23384 changing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:20:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:20:05 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-AowI1oS9om@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:20:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:20:06 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-UcnVfuUdMK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
renewalbranch is not a correct name. renewal_branchcode is more appropriate
here to avoid confusion.
Even better, for consistency, I would prefer renewal_library and make it
returns a Koha::Library object (if if you need an additional fetch).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:20:07 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-tjqaHUvgQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98808|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:20:28 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-XlFjEU7MRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99918&action=edit
Bug 17532: Make koha-shell propagate the error code

Context: I am trying to make koha-misc4dev stop when something wrong happens.
Basically we do not want the process to continue of the DB has not been
populated correctly.
It will make the errors easier to catch.

The issue: Say a script that will return an error (die in perl for an easy
example),
koha-shell will not return the 255 error code, but 0 instead.
The caller cannot know something wrong happened

The solution is to propagate the error and make koha-shell return the same
error code
as the command it executed

An example:
=== t.pl ===
die('something wrong');

% perl t.pl;echo $?
something wrong at t.pl line 1.
255

% sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $?
something wrong at xxx.pl line 1.
0

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Tested it with
  $ sudo debian/scripts/koha-shell kohadev -c 'exit 8'
  $ echo $?
  8
The unpatched version returns 0 (forgets about the error code).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:21:16 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
 reminder notices
In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15986-70-kOYGpiK1ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:21:19 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
 reminder notices
In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15986-70-dwSAAgkdUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91768|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99919&action=edit
Bug 15986: Add a script for sending hold waiting reminder notices

This patch adds a script for sending holds reminder notice to patrons.

We add a 'send_notice' routine to Koha::Patrons - this will either send using
the patron's
email prefs, or allow forcing of a single method via the cron

To test:
 1 - Create an email hold reminder notice for a single library (Koha module:
Holds, code HOLDREMINDER, branch: CPL)
 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have
'email' as the transport for hold filled notices
 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li
CPL
 4 - You should see the patrons here would have received emails
 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL
 6 - You should see the emails that were sent
 7 - Check the patron notices tab to confirm
 8 - Note a ptron with two holds waiting receives only one notice
 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL
-days 3
10 - No notices are sent
11 - Adjust the waiting date for the holds:
    UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAYS) WHERE
waitingdate = CURDATE();
12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL
-days 3
13 - Confirm the holds are now reminded
14 - Set yesterday as a holiday for CPL
15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li
CPL -holidays -days 3
16 - Notices should not be sent
17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li
CPL -holidays -days 4
18 - Notices should be sent again
19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n
-holidays -days 4
20 - Should get feedback that notice was not found for other libraries
21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n
-holidays -days 4 -mtt sms
22 - Notice is not found
23 - Add the notice for sms
24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n
-holidays -days 4 -mtt sms
25 - The notice should be sent
26 - Check patrons messaging tab to confirm
27 - prove -v t/db_dependent/Koha/Patrons.t

Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:25:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:25:04 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-O5blmKz2id@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I should note:
I have no idea how widely this script is used, but that will certainly
introduced regressions for people using it.
For Jenkins that will stop the build if something wrong happens during the
insert of the data in the DB (expected behavior).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:28:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:28:28 +0000
Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken
In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23727-70-JlfIHxVwnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Kyle, did you track down which patch (bug number) broke the original feature?

I did not, considering it's always been broken to some extent ( though not as
badly as it is now in master ). I decided to push forward with a more 'correct'
fix, rather that revert to past behavior which, while somewhat functional, was
still broken as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:29:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:29:18 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-9R8cmDjUr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
> I should note:
> I have no idea how widely this script is used, but that will certainly
> introduced regressions for people using it.
> For Jenkins that will stop the build if something wrong happens during the
> insert of the data in the DB (expected behavior).

I think it is worth changing the (currently) wrong behaviour. It will even help
sysadmins using it detect problems. We should of course mention this on the
release notes.

Good catch (as usual), Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:31:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:31:38 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-lm8JPk5w34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 99637
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99637
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

Review of attachment 99637:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4461&attachment=99637)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ +376,5 @@
>                    yes: Allow
>                    no: "Don't allow"
>              - patrons to submit problem reports for OPAC pages to the library or Koha Administrator.
> +            - "<br/>"
> +            - "<strong>NOTE:</strong> You must have KohaAdminEmailAddress enabled."

This isn't actually true is it?.. we use branch email in preference to
KohaAdminEmailAddress so it's just a fallback not a hard requirement.

::: opac/opac-reportproblem.pl
@@ +41,5 @@
>  );
>  
> +if (   !C4::Context->preference('OPACReportProblem')
> +    || !C4::Context->preference('KohaAdminEmailAddress') )
> +{

Don't we actually use branchemail in preference to KohaAdminEmailAddress so
this isn't actually a hard requirement?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:34:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:34:36 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-22hWAVHM6m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 99638
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99638
Bug 4461: Simplify recipients code

Review of attachment 99638:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4461&attachment=99638)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
@@ +32,5 @@
> +                        [% IF recipient == 'admin' %]
> +                            Your problem report has been sent to the Koha administrator.
> +                        [% ELSE %]
> +                            Your problem report has been sent to the library.
> +                        [% END %]

Do we really need to get this specific in the OPAC?

I'd say we just need to say whether the email was successfully sent or not and
not worry so much whether it's KohaAdminEmail or Library Branch Email.. the end
user doesn't have a way to select who it goes to anyway.

If we remove this we could simplify the code a little

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:36:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:36:38 +0000
Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19814-70-cFKh2suUkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:37:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:37:50 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-BXDYXHvAI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #49)
> (In reply to Katrin Fischer from comment #47)
> > If Aleisha says the GUI will be next, I am not so worried about the status
> > and such. It would be nice to see the code, but I feel this was just
> > planning ahead and would not cause harm for now.
> 
> For now no. But when the GUI will be there the message will be marked as
> "new" even if they have been processed already. If we mark them all as
> "processed" when the GUI is added, that will also be wrong: some may have
> not still been processed.

Agreed, without any way of maintaining the status, I think we should remove it
from this bug.. I like the idea of having a UI with Koha for progressing and
tracking reported issues but until that time we shouldn't record incorrect
status's.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:37:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:37:53 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-tNqBfa0HcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:37:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:37:56 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-MqAfoL4PZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80757|0                           |1
        is obsolete|                            |
  Attachment #88377|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99920&action=edit
Bug 21591: Check for record level item type issues too

To test:
1 - sudo koha-mysql kohadev
2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1
3 - UPDATE items SET itype = NULL where biblionumber = 1
4 - perl misc/maintenance/search_for_data_inconsistencies.pl
5 - Notice warnings
6 - Apply patch
7 - Undefined itemtype on bibliolevel is now warned
7 - Test also with itype=""

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:38:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:38:27 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-fYFtd7crDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #50)
> Comment on attachment 99637 [details] [review]
> Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
> 
> Review of attachment 99637 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> @@ +376,5 @@
> >                    yes: Allow
> >                    no: "Don't allow"
> >              - patrons to submit problem reports for OPAC pages to the library or Koha Administrator.
> > +            - "<br/>"
> > +            - "<strong>NOTE:</strong> You must have KohaAdminEmailAddress enabled."
> 
> This isn't actually true is it?.. we use branch email in preference to
> KohaAdminEmailAddress so it's just a fallback not a hard requirement.

With the 404 redirect in opac-reportproblem.pl it is a hard requirement.
Original code was assuming the pref was filled IIRC.

> ::: opac/opac-reportproblem.pl
> @@ +41,5 @@
> >  );
> >  
> > +if (   !C4::Context->preference('OPACReportProblem')
> > +    || !C4::Context->preference('KohaAdminEmailAddress') )
> > +{
> 
> Don't we actually use branchemail in preference to KohaAdminEmailAddress so
> this isn't actually a hard requirement?

Not what the code is actually doing. Maybe it needs to be adjusted.
105                         to_address             =>
C4::Context->preference('KohaAdminEmailAddress'),

(In reply to Martin Renvoize from comment #51)
> Comment on attachment 99638 [details] [review]
> Bug 4461: Simplify recipients code
> 
> Review of attachment 99638 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
> @@ +32,5 @@
> > +                        [% IF recipient == 'admin' %]
> > +                            Your problem report has been sent to the Koha administrator.
> > +                        [% ELSE %]
> > +                            Your problem report has been sent to the library.
> > +                        [% END %]
> 
> Do we really need to get this specific in the OPAC?
> 
> I'd say we just need to say whether the email was successfully sent or not
> and not worry so much whether it's KohaAdminEmail or Library Branch Email..
> the end user doesn't have a way to select who it goes to anyway.
> 
> If we remove this we could simplify the code a little

Feel free to submit any follow-ups you wish ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:00 +0000
Subject: [Koha-bugs] [Bug 24776] Remove Borrowers Template Toolkit plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-RZkIKEAGzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:02 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-4UfJTrGHJR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Bug say's it's sponsored.. can we add a Sponsored-by line to at least one of
the patches ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:04 +0000
Subject: [Koha-bugs] [Bug 24776] Remove Borrowers Template Toolkit plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-F4jxfg9TZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 99921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99921&action=edit
Bug 24776: Remove Borrowers.HasOverdues call

Borrowers Template Toolkit plugin contains method HasOverdues that can be
directly called from Koha::Patron object.

Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:22 +0000
Subject: [Koha-bugs] [Bug 24776] Remove Borrowers Template Toolkit plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-QM1R6NE3Hi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 99922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99922&action=edit
Bug 24776: Remove Borrowers.IsDebarred call

Borrowers Template Toolkit plugin contains method IsDebarred that can be
directly called from Koha::Patron object.

Also in template circ/returns.tt, when patron is restricted and checkin was
backdated, var "patron" is undefined, should be "issue.patron".

Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should
still be restricted."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:28 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-pQtcsxQtT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:39:31 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-247ewesodc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99923&action=edit
Bug 24765: Updated on date in Claims returned starts off as 12/31/1969

When an item is claimed returned by staff, there is a column called Updated On
- this date field column should remain blank until this claimed returned has
been updated.  Currently, when an item has been claimed returned, the date in
the updated column states 12/31/1969. This date only shows up in the display,
it is doesn't show up in the database like this.

Test Plan:
1) Enable return claims
2) Make a claim
3) Note the 'updated on' column has the date 1969-12-31
4) Apply this patch
5) Reload the page ( you may need to clear your browser cache )
6) Note the field is now blank

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:40:17 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-6xbOgeyOcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99923|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99924&action=edit
Bug 24765: Updated on date in Claims returned starts off as 12/31/1969

When an item is claimed returned by staff, there is a column called Updated On
- this date field column should remain blank until this claimed returned has
been updated.  Currently, when an item has been claimed returned, the date in
the updated column states 12/31/1969. This date only shows up in the display,
it is doesn't show up in the database like this.

Test Plan:
1) Enable return claims
2) Make a claim
3) Note the 'updated on' column has the date 1969-12-31
4) Apply this patch
5) Reload the page ( you may need to clear your browser cache )
6) Note the field is now blank

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:42:44 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-cygiyVZ7Wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove Borrowers Template   |Remove useless Borrowers
                   |Toolkit plugin              |Template Toolkit plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:43:12 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-FfKklrXksC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 99925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99925&action=edit
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:49:41 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Z1LnH7kpno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #49)
> (In reply to Katrin Fischer from comment #47)
> > If Aleisha says the GUI will be next, I am not so worried about the status
> > and such. It would be nice to see the code, but I feel this was just
> > planning ahead and would not cause harm for now.
> 
> For now no. But when the GUI will be there the message will be marked as
> "new" even if they have been processed already. If we mark them all as
> "processed" when the GUI is added, that will also be wrong: some may have
> not still been processed.

But that problem will be the same when we add the status column later on - if
it's there now or not. I'd just aim for having the GUI same release if
possible? I don't see the big issue here I'd rather spent the time to build the
GUI then to make it work perfectly without now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:49:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:49:45 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-uxNwceEGfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
s/regressions/side-effects
;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:52:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:52:05 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-TAWfq9vdag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It also requires 'OpacKohaUrl' to be enabled.. that feels like an error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:53:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:53:44 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-cJPT7033cu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followups coming.. this has turned into a todo list for myself to help get this
past the line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:57:04 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
 reminder notices
In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15986-70-eiygA56yFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is the test_mode parameter of the method really useful?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 14:58:52 +0000
Subject: [Koha-bugs] [Bug 24777] New: Use patron.is_debarred instead of
 patron.debarred in return.tt
Message-ID: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

            Bug ID: 24777
           Summary: Use patron.is_debarred instead of patron.debarred in
                    return.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In return page return.tt, when there is an hold message, patron is said as
restricted even if restriction end date is in the past.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:01:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:01:41 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-U8MX9FOQBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24776

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:01:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:01:41 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-1ZbmnbBLLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24777

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:01:59 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-rfRrWRa9WD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:09:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:09:56 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-51djeLVXWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:09:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:09:59 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-D1G3tBdC4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 99926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99926&action=edit
Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt

In return page return.tt, when there is an hold message, patron is said as
restricted even if restriction end date is in the past.

Test plan :
1) For a patron Jon Doe create a manual restriction with end date in the past
2) Create an hold for this patron on an item
3) Check in this item => You don't see message "Patron is RESTRICTED"
4) For a patron Kevin Doe create a manual restriction with end date in the
future
5) Create an hold for this patron on an item
6) Check in this item => You see message "Patron is RESTRICTED"
7) Repeate 1-6 with system preference HoldsAutoFill enabled
8) Repeate 1-6 with a waiting hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:16:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:16:33 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-qnVr9OMZfJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91581|0                           |1
        is obsolete|                            |
  Attachment #91591|0                           |1
        is obsolete|                            |

--- Comment #96 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99927&action=edit
Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved

- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
----------
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower

Apply the patch
3/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
4/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:17:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:17:50 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-4YC8NEDSZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:17:54 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-U2oVTzALam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91593|0                           |1
        is obsolete|                            |

--- Comment #97 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 99928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99928&action=edit
Bug 11999: Test improvements

improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:12 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-MiW5n69MGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99599|0                           |1
        is obsolete|                            |

--- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99929&action=edit
Bug 4461: Database and syspref changes

adding problem_reports table and OPACReportProblem syspref

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:16 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-zbM0FxNtG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99600|0                           |1
        is obsolete|                            |

--- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99930&action=edit
Bug 4461: Problem Report Koha objects

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:20 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-XbWm4DKo1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99601|0                           |1
        is obsolete|                            |

--- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99931&action=edit
Bug 4461: Submit a problem report

To test:
1) Apply patch, update database, rebuild schema file
2) Restart koha-common and memcached
3) Confirm that your user has an email address.
4) Confirm that your library does NOT have an email address.
5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are
not filled. Enable the OPACReportProblem syspref.
6) Log into OPAC
7) Click the 'Report a problem' link at the bottom of whatever page
you're on
8) Notice that there is no form is and there is an error message alerting that
reports cannot be submitted
9) Add an email address for your library (in either the email field or the
replyto field). Refresh the OPAC problem report page. The form should now show,
and the recipient field should say 'library'.
10) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is correct. Confirm there is a success message.
11) Add an email address for the syspref KohaAdminEmailAddress and refresh the
OPAC problem report page again. The recipient field should now be a dropdown.
Select the Koha Administrator option.
12) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is
a success message.
13) Ensure all details in the message_queue are correct.
14) Log out of the OPAC
15) Click the Report a problem link again and confirm you are forced to log in

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:24 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-LRtb5kmsem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99602|0                           |1
        is obsolete|                            |

--- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99932&action=edit
Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:28 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-q3rnnzOjQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99603|0                           |1
        is obsolete|                            |

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99933&action=edit
Bug 4461: (follow-up) Creating sample notice and other fixes

- filters
- capitalisation
- atomic update

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:32 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-w4iPg7du8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99633|0                           |1
        is obsolete|                            |

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99934&action=edit
Bug 4461: Rename report date with created_on

And make it a timestamp type column

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:35 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-KmIrzcCzpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99635|0                           |1
        is obsolete|                            |

--- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99935&action=edit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:40 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-hwZagbIJpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99636|0                           |1
        is obsolete|                            |

--- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99936&action=edit
Bug 4461: Use our local_referer instead of HTTP_REFERER

Cannot remember why exactly, but it seems that we should not use
HTTP_REFERER directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:44 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-eBY3cQpzc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99637|0                           |1
        is obsolete|                            |

--- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99937&action=edit
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:47 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-vxEd41OUEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99638|0                           |1
        is obsolete|                            |

--- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99938&action=edit
Bug 4461: Simplify recipients code

As the feature is now turned off without KohaAdminEmailAddress, we only
need to check if the email address of the library if defined.
Not that we should not check for $library->branchreplyto or
ReplytoDefault, but only $library->branchemail, as we do everywhere else
(I think)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:51 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-BaneVSGGUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99639|0                           |1
        is obsolete|                            |

--- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99939&action=edit
Bug 4461: Better error handling

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:55 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-gagtTOpsFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99940&action=edit
Bug 4461: Remove hard requirement on OpacKohaUrl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:22:59 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-eF8DfwCTg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99941&action=edit
Bug 4461: Drop 'from_address' use 'reply_address'

This patch adds support for using the reply-to field added in bug 10269
and drops 'from_address' as it will get defined at a later stage in the
emailing process anyway.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:23:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:23:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-2Jaq24yvjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99942&action=edit
Bug 4461: Use get_effective_email from bug 22823

Use the get_effective_email from Koha::Library to get an appropriate
inbound address for the branch as aposed to using branchemail directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:25:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:25:13 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-nc8JWhw8vA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm reasonably happy with the followups here.. it feels like this was written
with a GUI and a process in mind but without submitting the GUI half and as
such the code is a little confusing.. why not just send emails and skip the
table element entirely ;)

Still.. I like the feature and at this point, the code seems to work reasonably
well.. I'd love to see a GUI including a process for moving reports through
various states added this cycle if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:27:35 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-4zsnUjkzCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #98 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to David Nind from comment #94)
> Similar to Bug 17229 you get an error on the patron's page when following
> the test plan (step 2 before patch), but before trying to apply the patch:
> 
> 1) For the patron, the holds tab heading shows that there is a hold (1).
> 
> 2) When you click on the patron's holds tab a message pops up with
> "DataTables warning: table id=holds-table - Ajax error. For more information
> about this error, please see http://datatables.net/tn/7"
> 
> 3) The bibliographic record shows that there is a hold.
> 
> I'm assuming that is because the DataTables feature for displaying results
> is a more recent addition to Koha.
> 
> (Test URL I used for ILS_DI was
> http://127.0.0.1:8080/cgi-bin/koha/ilsdi.
> pl?service=HoldTitle&patron_id=19&bib_id=15&request_location='127.0.0.1'
> using koha-testing-docker)

Hi David,
Thanks again for testing, I've posted new patches with conflicts fixed + tests
green + qa tools green.
I cannot reproduce the issue you've seen with DataTable.
Kr,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:31:47 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-jHg8XqnoDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99918|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99943&action=edit
Bug 17532: Make koha-shell propagate the error code

Context: I am trying to make koha-misc4dev stop when something wrong happens.
Basically we do not want the process to continue of the DB has not been
populated correctly.
It will make the errors easier to catch.

The issue: Say a script that will return an error (die in perl for an easy
example),
koha-shell will not return the 255 error code, but 0 instead.
The caller cannot know something wrong happened

The solution is to propagate the error and make koha-shell return the same
error code
as the command it executed

An example:
=== t.pl ===
die('something wrong');

% perl t.pl;echo $?
something wrong at t.pl line 1.
255

% sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $?
something wrong at xxx.pl line 1.
0

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Tested it with
  $ sudo debian/scripts/koha-shell kohadev -c 'exit 8'
  $ echo $?
  8
The unpatched version returns 0 (forgets about the error code).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:31:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 15:31:56 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-Hgcw15rFU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:09:27 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-apjiZlBDvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #191 from David Gustafsson <glasklas at gmail.com> ---
Ok, thanks! A regression seems to been introduced in
https://github.com/Koha-Community/Koha/commit/abb51797d8d5ebb274856e912e207a921ace478b
causing this bug. Very difficult to debug since "delete" is somehow called
without appearing in the code, and a stack trace points out a line (where
delete is called) that does not exist. But I'm looking into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:17:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:17:49 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-iZ7lqqdiLP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95474|0                           |1
        is obsolete|                            |

--- Comment #127 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 99944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99944&action=edit
Bug 17674: Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Test plan :
- Apply patch.
- Create at least four serials with items.
- Notice that new items have a numbering pattern and a date in the enumchron
field.
- Use the button Delete selected issues for the following steps.
- Delete a serial and its associated item.
- Confirm the serial and item are gone.
- Delete a serial and not its item.
- Confirm the serial is gone.
- Confirm the item is still there and the date part in the enumchron field is
gone.
- Delete the two lasts serials.
- Confirm they are gone.

Sponsored by : CCSR

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: sonia <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:17:53 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-dE7pvuhuUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99434|0                           |1
        is obsolete|                            |

--- Comment #128 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 99945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99945&action=edit
Bug 17674: Handling of special cases

This patch adds handling for those 2 particular cases:
1. Deleting the expected issue
2. Deleting a serial and it's item, but one item cannot be deleted

To test:

1.1 Create a subscription that creates items
1.2 Receive two issues
1.3 Use the new button to delete the 'Expected' issue
1.4 The issue is correctly deleted, but the new expected issue created
to replace the one which has been deleted don't have a published or
received date and is show in it's own tab.
1.5 Apply patch
1.6 Repeat steps 1.1 through 1.4
    => The new expected issue is created correctly

2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2
2.2 Check out one of the items
2.3 Delete the corresponding serial and check box to delete items
2.4 The serial is deleted, but not the item.
    => No feedback is show to the user
2.5 Apply patch
2.6 Repeat step 2.1 through 2.4
    => As before, the serial is deleted, but not the item
    => This time, an error is shown to inform the user

Signed-off-by: sonia <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:22:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:22:51 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-kMXLkP2GIv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #129 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I've followed the test plan and everything looks Ok for me.
1. The next expected issue is correctly created when we delete the current
expected issue.
2. If an item is checked out, you can't delete this item when you delete the
serial issue. There's an alert to tell you that you can't delete the item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:26:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:26:42 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-TIRvInAvOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:26:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:26:42 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-92BUffq4gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24540


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540
[Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:30:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:30:10 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-8S7lFJwqfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:30:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:30:14 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-eF3ERyJqlq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99351|0                           |1
        is obsolete|                            |
  Attachment #99352|0                           |1
        is obsolete|                            |

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99946&action=edit
Bug 24502: object.search also filter by prefetched columns

This patch adds the possibility to object.search helper, to also filter by
prefetched columns.

In order to dynamically add filter parameters, they must be coded as json and
placed in the body of the request, coded as string in 'q' query parameter or as
string in 'x-koha-query' header.

The coded json, is in fact dbix syntax.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t
3. Sign off

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:30:30 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-nTNUyfVLUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99947&action=edit
Bug 24502: (follow-up) Add all 3 query parameters in api definition

This patch adds api definition for body, query or header parameters.

To use them include:

* "$ref": "../parameters.json#/q_body" for body parameter.
* "$ref": "../parameters.json#/q_param" for query parameter.
* "$ref": "../parameters.json#/q_header" for header parameter.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:47:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:47:42 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-hT2WhSaNB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99948&action=edit
Bug 24519: Match paycollect form validation for change collection

This patch adds form validation to the Point Of Sale payment page such
that one cannot submit the form with a 'collected' value that is less
than the 'owed' amount.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:47:53 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-cBLPv6C3i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:50:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:50:26 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-QWrnMYYL0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:50:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:50:30 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-74HUUTarMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97403|0                           |1
        is obsolete|                            |

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99949&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

This patch also fixes a FIXME about using effective_itemtype to fetch item
rules

To test:
1 - Set one itemtype to allow no holds
2 - Set 'Holds per record' to 0 for another itemtype/patron combination
3 - Create or find 2 records, each with items only of the itemtypes above
3 - Attempt to place a hold for a patron on each record above
4 - The message will be 'Too many holds'
5 - Apply patch and repeat
6 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
7 - Try placing a multihold with either record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"
8 - prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:50:33 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-T7B1IXNcbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #25 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99950&action=edit
Bug 16787: Add noReservesAllowed to club holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:52:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:52:19 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-BVZOsvJdDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99951&action=edit
Bug 24540: Prevent add button being triggered on enter

This patch prevents the add button being triggered by hitting return
from inside the collected from patron form input.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:56:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:56:22 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-zx9khoHTOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99951|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99952&action=edit
Bug 24540: Prevent add button being triggered on enter

This patch prevents the add button being triggered by hitting return
from inside the collected from patron form input.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:57:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:57:21 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-ZUWKPaYEaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:57:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 16:57:36 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-HT7833PUfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:00:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:00:59 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-sV4cjou6kI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Before this development,
      release notes|                            |the koha-shell script would
                   |                            |always return a successful
                   |                            |error code, making it hard
                   |                            |for the callers to notice
                   |                            |there was a problem with
                   |                            |the command being run
                   |                            |inside the instance's
                   |                            |shell.
                   |                            |
                   |                            |This development
                   |                            |makes koha-shell propagate
                   |                            |the running scripts' error
                   |                            |code so the caller can take
                   |                            |the required actions.
                   |                            |
                   |                            |Note: this implies a
                   |                            |behaviour change (for good)
                   |                            |but a warning should be
                   |                            |added to the release notes.
                   |                            |
                   |                            |Right now it always
                   |                            |returns

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:03:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:03:10 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-K5a09DFsem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99953&action=edit
Bug 24759: Rename renewalbranch to renewal_branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:04:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:04:09 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-tGhwUIXML8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #6)
> renewalbranch is not a correct name. renewal_branchcode is more appropriate
> here to avoid confusion.
> Even better, for consistency, I would prefer renewal_library and make it
> returns a Koha::Library object (if if you need an additional fetch).

Renamed to renewal_branchcode - returning a library object doesn't work so well
because we can have "" or "OPACRenew" as values, they won't have Library
objects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:08:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:08:47 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-iEeGWrL2QO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:14:29 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-xtrHFd9wAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99904|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99954&action=edit
Bug 24775: Add ID to POS submit payment button

This patch simply adds an ID to the submit button to make it easier to
overide styling and functionality.

Test Plan:
0/ Inspect the element on page and note there is no id
1/ Apply patch
2/ Refresh page
3/ Inspect the element on page and note there is now an id

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:14:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:14:44 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-xkEM8aprHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:16:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:16:56 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-4ANonioHqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:19:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:19:10 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-mIvtsBBIIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test plan
1) Change the Currency format preference
2) enter an amount equal to or less than the amount owed into the collected
field in the point of sale page and note that on leaving the field it will be
formatted as per the system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:20:28 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-fbHUYIB3j0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:21:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:21:36 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-ivVubzbTwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:22:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:22:27 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-yvnM5fySuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:22:30 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-4kXUrHjToc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93231|0                           |1
        is obsolete|                            |
  Attachment #98942|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99955&action=edit
Bug 23695: Set holding branch to transferring branch when manually initiating a
transfer

To test:
 1 - Go to Circulation->Transfer
 2 - Note your signed in branch
 3 - Find an item from your branch and create a transfer to branch B
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to brnach B
 7 - Confirm the item is held at your current branch and is being transferred
to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:22:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:22:33 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-UTRRi8kcFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 99956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99956&action=edit
Bug 23695: Alter transferbook to take a hash of params and specify from_branch

To test:
 1 - Go to Circulation->Transfer
 2 - Find an item from your branch and create a transfer to branch B
 3 - Note you can specify the origin and default is 'Item's holding library'
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to branch B from branch D
 7 - Confirm the item is held at branch D and is being transferred to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:38:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:38:28 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-4n6KHxbqlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
When testing I get the following error in the console in FireFox on the OPAC on
the holds history page:

TypeError: $(...).api is not a function opac-holdsrecord.pl:793:36

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:46:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:46:54 +0000
Subject: [Koha-bugs] [Bug 24778] New: Move from Memcached to Redis to solve
 L1 caching issues?
Message-ID: <bug-24778-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778

            Bug ID: 24778
           Summary: Move from Memcached to Redis to solve L1 caching
                    issues?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Would it be worthwhile to switch from Memcache to Redis? Redis has pub/sub
which in theory would allow all processes to listen for syspref changes and
update their L1 caches if necessary.

What made me think of this is bug 23640

I have no idea if this is worth the time and effort, but it seems like it would
solve the major issue we have with memcached.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:49:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:49:59 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-3Z32MHVvYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Once we have those I think we pretty much have what you are suggesting.. we
> can update the default config we ship to only include a pointer to the
> community gitlab and as we as a community deem a plugin to have reached a
> level of maturity we are happy with we can suggest an adoption of it into
> our gitlab and thus sign subsequent releases.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:51:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:51:33 +0000
Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via
 SIP2
In-Reply-To: <bug-23223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23223-70-LXve3Qn7tO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:51:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 17:51:36 +0000
Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via
 SIP2
In-Reply-To: <bug-23223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23223-70-4JYBOj1zCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96234|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 99957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99957&action=edit
Bug 23223: Add AllowItemsOnHoldCheckoutSIP preference

This patch adds a new systempreference for behavior for
AllowItemsOnHoldCheckout may difer between intranet, SCO and SIP

To test:
1. apply this patch
2. perl installer/data/mysql/updatedatabase.pl
SUCCESS => There is a new syspref called AllowItemsOnHoldCheckoutSIP
3. configure and start SIPServer
4. with misc/sip_cli_emulator.pl try to checkout an item with a hold
CHECK => checkout is not allowed
5. set AllowItemsOnHoldCheckoutSIP to Allow
6. restart SIPServer
7. repeat step 4
SUCCESS => checkout is allowed
8. Sign off

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 19:29:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 18:29:43 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-1Ww1sI74IL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds
      release notes|                            |CodeMirror plugins for
                   |                            |linting system preferences
                   |                            |that include JS, CSS, HTML,
                   |                            |and YAML. When invalid data
                   |                            |is entered in a linted
                   |                            |CodeMirror editor an icon
                   |                            |is displayed in the
                   |                            |editor's "gutter." Hovering
                   |                            |over the icon displays the
                   |                            |error message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 19:36:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 18:36:57 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
 course reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-cFAMfJ4rZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows the
      release notes|                            |removal of items that are
                   |                            |listed on a course reserve
                   |                            |and are checked out.
                   |                            |Previously, checked out
                   |                            |items could not be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 19:58:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 18:58:50 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-dTll7h4PkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99958&action=edit
Bug 23975: (QA follow-up) Fix stylingof install buttons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 20:38:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 19:38:33 +0000
Subject: [Koha-bugs] [Bug 24779] New: Shibboleth login url double encodes
 "=" in query
Message-ID: <bug-24779-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24779

            Bug ID: 24779
           Summary: Shibboleth login url double encodes "=" in query
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hannah.co at northwestu.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

login_shib_url and logout_shib use _get_return to process a url and parameters.
I am seeing urls come through with the "=" between the parameter name and the
query encoded to "%3D". I think this is because url encoding is done on line
214 to the whole parameter string after assembly. 

  214    return $uri_base_part .
URI::Escape::uri_escape_utf8($uri_params_part);

I believe only the query part of the parameter should be uri escaped, on line
209:

  209    $uri_params_part .= $uriPiece;

My installation with shibboleth login works with lines 209 and 214 changed as
follows:

  209    $uri_params_part .= URI::Escape::uri_escape_utf8($uriPiece);
  214    return $uri_base_part . $uri_params_part;

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 21:17:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 20:17:36 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-XEInp0pkRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 21:17:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 20:17:39 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-mG1y9lWzUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98769|0                           |1
        is obsolete|                            |

--- Comment #5 from Michal Denar <black23 at gmail.com> ---
Created attachment 99959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99959&action=edit
Bug 24573: Add missing dependencies to cpanfile

Catmandu::Store::ElasticSearch is required for search,
and Catmandu::MARC is required for indexation

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 21:38:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 20:38:14 +0000
Subject: [Koha-bugs] [Bug 19310] Warning on UpdateTotalIssuesOnCirc should
 be revisited
In-Reply-To: <bug-19310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19310-70-EkSTdjjiQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:28:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:28:58 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-HOytnqcYR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |rbit at rbit.cz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:10 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-B7N4LTl8uF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:16 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-54M5PrDWHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98011|0                           |1
        is obsolete|                            |
  Attachment #98012|0                           |1
        is obsolete|                            |
  Attachment #98013|0                           |1
        is obsolete|                            |
  Attachment #98014|0                           |1
        is obsolete|                            |
  Attachment #98015|0                           |1
        is obsolete|                            |
  Attachment #98016|0                           |1
        is obsolete|                            |
  Attachment #98017|0                           |1
        is obsolete|                            |
  Attachment #98018|0                           |1
        is obsolete|                            |

--- Comment #96 from Michal Denar <black23 at gmail.com> ---
Created attachment 99960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99960&action=edit
Bug 20388: Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
    (name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:21 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-hyyecEE7zT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #97 from Michal Denar <black23 at gmail.com> ---
Created attachment 99961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99961&action=edit
Bug 20388: Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
    authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:27 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-wbL6kSqicB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #98 from Michal Denar <black23 at gmail.com> ---
Created attachment 99962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99962&action=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:32 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-ucAPo0ne51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #99 from Michal Denar <black23 at gmail.com> ---
Created attachment 99963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99963&action=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:36 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-JyjaHxSEaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #100 from Michal Denar <black23 at gmail.com> ---
Created attachment 99964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99964&action=edit
Bug 20388: QA fixes: - pass search field objects in template instead of
unblessed ones - disable drag n drop

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:41 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-MpTFF3vQVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #101 from Michal Denar <black23 at gmail.com> ---
Created attachment 99965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99965&action=edit
Bug 20388: QA fixe : delete line who add elements in biblios and authorities in
the same time

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:47 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-IXTYacJqby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #102 from Michal Denar <black23 at gmail.com> ---
Created attachment 99966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99966&action=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:44:52 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-xOzNgpi2j6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #103 from Michal Denar <black23 at gmail.com> ---
Created attachment 99967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99967&action=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:55:15 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-LVpn9iLcx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 22:55:17 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-pGzq9fZKID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99756|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Denar <black23 at gmail.com> ---
Created attachment 99968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99968&action=edit
Bug 24760: Use C4::BackgroundJob->fetch in tests

Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless
loaded objects by default. This is not a problem as
C4::BackgroundJob->fetch bless them anyway.

So, instead of testing what's in the session, test the result of
C4::BackgroundJob->fetch, which is what's used everywhere else

Test plan:
1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not
installed)
2. prove t/db_dependent/BackgroundJob.t => should FAIL
3. Apply patch
4. prove t/db_dependent/BackgroundJob.t => should PASS
5. Verify that background jobs are still working (for instance,
tools/batchMod.pl)

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:03:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 23:03:03 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-siIfMG7jVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Radek Šiman (R-Bit Technology, s.r.o.) <rbit at rbit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:03:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 23:03:06 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-3rjCqRvyes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

--- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit at rbit.cz> ---
Created attachment 99969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99969&action=edit
Bug 24770: Show age of patron on circulation page

This patch only adds new line containing age to the patron info

1) Navigate to a patron checkout page
2) No age is visible above "category" in patron's info above circ menu
3) Apply the patch
4) Reload this patron
5) Age is here and always visible regardless the active tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:53:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2020 23:53:46 +0000
Subject: [Koha-bugs] [Bug 24780] New: 952$i stocknumber does not display in
 batch item modification
Message-ID: <bug-24780-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24780

            Bug ID: 24780
           Summary: 952$i stocknumber does not display in batch item
                    modification
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When trying to edit items via batch item modification, the subfield i does not
display.    

To recreate, add a value to 952$i, then add that barcode to the batch item
modification function.  You will see the value display in the item summary
across the top of the screen, but the $i does not show in the edit section
below.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 01:51:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 00:51:17 +0000
Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to
 Advanced search
In-Reply-To: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24155-70-6LPPGG8cNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Patch failed to apply:

Applying: Bug 24155: Make wieghting an option on advanced search
Using index info to reconstruct a base tree...
M       cataloguing/addbooks.pl
M       koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Auto-merging cataloguing/addbooks.pl
CONFLICT (content): Merge conflict in cataloguing/addbooks.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24155: Make wieghting an option on advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 02:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 01:06:28 +0000
Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to
 Advanced search
In-Reply-To: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24155-70-AUcVj2VkdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155

--- Comment #5 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
I would also like to add that as I was doing my base-line testing for this bug,
I found something interesting. When clicking on a record in the result list,
then clicking on the button to return to the results, the search re-executes
and applies weights. If a user had performed a search using advanced search
where weights are not applied, then used the button to return to the results
list, they would find that the results were in a different order.

The work-around is to just use the browser's back button to return to the
advanced search results list. If we're giving people the option to apply
weights to the advanced search, however, this inconsistency will continue to
happen unless there's a way to specify the return to results link to go back to
the previous results instead of launching a new search.

I did notice that there is a search_id value in the URL when the search
re-executes that is not there in the URL for the advanced search:

http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&q=computer&op=and&idx=kw&q=program*&op=and&idx=kw&sort_by=relevance
vs.
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=computer&op=and&idx=kw&q=program*&op=and&idx=kw&searchid=scs_1583197470738&offset=0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 02:28:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 01:28:32 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-8MDAhWDIoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #73 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
We keep getting stuck on the lack of GUI. I understand. I'll write the GUI for
this now so it can all go through in one go.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:09:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:09:28 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-oIeF5XLIM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:09:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:09:31 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-BtK1qth1W6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99958|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:09:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:09:34 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-kWhx6w2r1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98813|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:09:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:09:36 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-tbdi9vT5zc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98814|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:09:39 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-Z9lU9VDKDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98815|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:09 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-EsAE1JY5np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99970&action=edit
Bug 23975: Add ability to search and install plugins from GitHub

It would be nice to be able to search and install plugins directly from GitHub
( and GitLab if possible ). This would make it easier to verify the
authenticity of plugins and make discovering new plugins easier as well as
making installation of plugins simpler.

Test Plan:
1) Apply this patch
2) Add the new block for plugin_repos to your koha-conf.xml
3) Restart all the things!
4) Browse to the plugins home page
5) Try searching for 'patrons' in the new search box
6) Verify you get results!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:14 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-whMAWJSeLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99971&action=edit
Bug 23975: Add 'Install' support for github results

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:18 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-NoEg6wRJsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99972&action=edit
Bug 23975: (follow-up) Don't rely on save_to being present

The `save_to` shortcut method was introduced to Mojolicious in version
8.02 but we still support 7.21 as our minimum dependancy and as such we
cannot yet use it.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:22 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-twhvpVQXpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99973&action=edit
Bug 23975: (QA follow-up) Fix stylingof install buttons

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:26 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-5wHZtmXRaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99974&action=edit
Bug 23975: (QA follow-up) Search button style and functionality

This patch makes the search form button match the other buttons style,
and also adds the submit() action on click.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:10:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:10:42 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-dl4MPNMHDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 99975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99975&action=edit
Bug 23975: (QA follow-up) Add missing TT filters

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:11:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:11:16 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-3dlxyWCUFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:18:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 03:18:52 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-5TGGfVFCiF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:07:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:07:05 +0000
Subject: [Koha-bugs] [Bug 24781] New: Parse and build query strings more
 reliably
Message-ID: <bug-24781-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781

            Bug ID: 24781
           Summary: Parse and build query strings more reliably
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Throughout the code, you'll see a lot of string mangling to manipulate query
strings.

Examples from opac-search.pl:

$query_cgi = "tag=" .  uri_escape_utf8( $tag ) . "&" . $query_cgi;

$pasarParams .= '&amp;query=' . uri_escape_utf8($query);
$pasarParams .= '&amp;count=' . uri_escape_utf8($results_per_page);
$pasarParams .= '&amp;simple_query=' . uri_escape_utf8($simple_query);

$limit_cgi_not_availablity =~ s/&limit=available//g if defined
$limit_cgi_not_availablity;

It would be good to have a more reliable unit-tested way of creating and
editing query strings.

I have a module called Koha::Util::URL which should be able to help. I'm hoping
to put together a patch tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:07:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:07:57 +0000
Subject: [Koha-bugs] [Bug 24781] Parse and build query strings more reliably
In-Reply-To: <bug-24781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24781-70-9bJA4ECS9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
As a side note, I actually thought of this while creating a new "Peer-Reviewed"
facet for the search results, which imitates that "Availability" facet to a
degree. 

I didn't like the way limit=available was being handled, so I wrote an
alternative.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:12:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:12:50 +0000
Subject: [Koha-bugs] [Bug 24782] New: Calendar edit only applies to first day
Message-ID: <bug-24782-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782

            Bug ID: 24782
           Summary: Calendar edit only applies to first day
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at outlook.com
        QA Contact: testopia at bugs.koha-community.org

When editing holidays edit only applies to first day (from date). 

To test:
1. Add holidays on range e.g from 04/03 to 06/03 
2. Try edit these holidays so that from date is 04/03 and to date is set to
06/03
3. Save
=> Only 04/03 is changed  

There should be option to edit holidays on range.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:13:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:13:20 +0000
Subject: [Koha-bugs] [Bug 24783] New: Untranslatable strings in checkouts.js
Message-ID: <bug-24783-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24783

            Bug ID: 24783
           Summary: Untranslatable strings in checkouts.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Untranslatable strings in checkouts.js:

- title += ' by ' + oObj.author;
- title="Double click to edit"
- "on" in line desc = '<strong>' + oObj.resolution_data.lib + '</strong> on
<i>' + oObj.resolved_on + '</i>';
- </i> Delete</a>
- </i> Resolve</a>
- '  Actions <span class="caret">
- </i> Edit notes</a>
- </i> Update</a>
- href="#">Cancel</a>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:22:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:22:16 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-ZHpsz88KMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

--- Comment #13 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
I filed a separate bug report (bug 24782) regarding edit only applying to first
day.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:32:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 07:32:32 +0000
Subject: [Koha-bugs] [Bug 24784] New: Duplicated code in checkouts.js
Message-ID: <bug-24784-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24784

            Bug ID: 24784
           Summary: Duplicated code in checkouts.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

in LoadIssuesTable(), the issues-table and relatives-issues-table have couple
near-identical functions that should be unified. The major one is the mDataProp
function for showing the item title and author (column 5 for issues-table,
column 3 for relatives-issues-table)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:13:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:13:31 +0000
Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record
In-Reply-To: <bug-24589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24589-70-8uNFTzXaPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98429|0                           |1
        is obsolete|                            |

--- Comment #4 from paxed <pasi.kallinen at koha-suomi.fi> ---
Created attachment 99976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99976&action=edit
Bug 24589: Add plugin hook addbiblio_check_record

Adds a new plugin hook, addbiblio_check_record, to addbiblio.pl.
When saving a record, the hook is called with the MARC record as
a parameter. If the hook returns anything, the return values are
shown to the user, and saving the record is prevented.

This can be used to create plugins that eg. check or modify the record.

Advanced editor has not been changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:29:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:29:41 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-HHkcSQUojO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94861|0                           |1
        is obsolete|                            |

--- Comment #3 from paxed <pasi.kallinen at koha-suomi.fi> ---
Created attachment 99977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99977&action=edit
Bug 23925: Value builder plugin to check ISBN validity

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:29:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:29:49 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-66RSnJJIDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:39:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:39:29 +0000
Subject: [Koha-bugs] [Bug 24785] New: Search result column localization
Message-ID: <bug-24785-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24785

            Bug ID: 24785
           Summary: Search result column localization
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: stephane.delaye at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

At the level of the localization column in search result, it would either be
necessary to ignore itype of the items for the classification of the items in
the available or unvailable html span or to change the titles of these html
span. Because it is not fair to mix the concepts of availability and
borrowability: a dictionarie who is not borrowable with the display not
unavailable it's wrong: the items is on shelf, that's all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:47:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:47:07 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-OKrqhACryk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am sorry but I have concerns about this patch. Feel free to ignore them.

To me this feature is not ready as it.
With those patches, the default will be to search on theke and bws github repo.
Nothing says that the plugins are fetched from "outside".
Did anyone review those plugins?
Why only those 2 companies? What about others (ptfs-e, biblibre, inlibro, etc)?
What if a plugin that have security issues is pushed to those repos?

When are you going to work on follow-up bugs? Is the plan to have them ready
for 20.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:53:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:53:34 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-1gKAfmDwPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:59:30 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-dLp9PHneR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:59:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 08:59:33 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-7XsWSK07PQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99978&action=edit
Bug 24741: (bug 21674 follow-up) Fix destructive update DB 19.12.00.017

Previous version of the SQL query did not deal correctly with subgroup.

Test plan:
checkout the following commit to be just before 017
  commit 715da06db557edc4b1baa51cc278fdac362c01c4
  Bug 22868: DBRev 19.12.00.016
reset_all # recreate the DB
Create a complex tree of library groups, with several groups, subgroups,
etc.
When you add a new library, refresh the page to add it several time.
When ready, git checkout master, restart all the things, execute the
updatedatabase script, then go to the library groups page.
You should see that the duplicated entries have been removed, but
subgroups have not been deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:19:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:19:12 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-TlLQDerYTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It does not work for me/my webcam:
* Firefox:
I see "Take", but then the modal displays with "No permission to use camera" in
an alert. If I close it, I see the "Take the patron's picture" button in the
modal, but it generates a black picture.

* Chromium: No "Take"


The browsers does not ask me if I want to allow the webcam for this page.

The webcam seems to work with cheese and hangout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:22:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:22:57 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-Wsa2w5tSZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:22:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:22:59 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
 code
In-Reply-To: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17532-70-om1kzIlGCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:01 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-7NmH57FhuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:03 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-0vMIROznqf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:05 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-CDLMYdBHmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:07 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-9LvsazjU4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:09 +0000
Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns
In-Reply-To: <bug-24615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24615-70-mhRxbbYBKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:11 +0000
Subject: [Koha-bugs] [Bug 24615] REST API order by prefetched columns
In-Reply-To: <bug-24615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24615-70-3EyRdbRU73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:23:53 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-MMQ9EXSJ6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement improves
      release notes|                            |the OPACPopupAuthorsSearch
                   |                            |feature so that it works in
                   |                            |both the normal and XSLT
                   |                            |views
                   |                            |(OPACXSLTDetailsDisplay).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:25:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:25:18 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-y5pTj1uxNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not it be named get_effective_to_email (or something saying we should
not use it for from)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:36:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:36:56 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-3uQFqdcdAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 99979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99979&action=edit
Bug 24608: (follow-up) Buttons should be buttons

No idea why I used <a> elements for the Edit buttons. But the 'disabled'
attribute has no effect on <a> elements, which leads to all sorts of
problems when you have disabled buttons that are not disabled.

Switched to <button> elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:38:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:38:06 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-6OVa91le9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:38:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:38:25 +0000
Subject: [Koha-bugs] [Bug 24769] DataTable error on patron hold page when
 hold placed using ILS-DI
In-Reply-To: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24769-70-eQSK32PQGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769

--- Comment #2 from David Nind <david at davidnind.com> ---
Error also happening on bug 22806 before patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:39:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:39:56 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-ZDgEU1ohQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I intend to start working on those bugs, and encourage Kyle and Tomas to help
very soon.. I've left the default config in on master for now so that
developers get exposed to the feature whilst we're in development, but I intend
to drop those as defaults just before release... hopefully to have been
replaced with a default of the community gitlab with hopefully at least a few
reviewed plugins within it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:40:17 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-qUPPWEVsMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #19 from David Nind <david at davidnind.com> ---
Sorry, I wasn't quick enough to retest. The patch no longer applies:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22806 : CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions
Applying: Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must
check AllowHoldsOnPatronsPossessions
Applying: Bug 22806: CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions
Using index info to reconstruct a base tree...
M       C4/Reserves.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Reserves.pm
CONFLICT (content): Merge conflict in C4/Reserves.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 22806: CanBookBeReserved and CanItemBeReserved must
check AllowHoldsOnPatronsPossessions

Notes:

- ILS-DI request used for testing on koha-testing-docker 
 
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=11&item_id=32

- ILS-DI requests causes DataTable error o Patrons hold tab: see bug 24769

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:43:56 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-kNA7qE0mhQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch makes public
      release notes|                            |plugins discoverable from
                   |                            |within Koha itself via a
                   |                            |search box at the top of
                   |                            |the plugin management page.
                   |                            |
                   |                            |One can search for plugins
                   |                            |and install them directly
                   |                            |from their source.
                   |                            |
                   |                            |WARNING: Plugins are not
                   |                            |yet verified by the
                   |                            |community, use at your own
                   |                            |risk
                   |                            |
                   |                            |RELEASE NOTE: During
                   |                            |development, ByWater
                   |                            |Solutions, Theke Solutions
                   |                            |and PTFS-Europe
                   |                            |repositories have all been
                   |                            |added as example search
                   |                            |paths. The intention is to
                   |                            |remove these prior to
                   |                            |release and encourage
                   |                            |companies to add their own
                   |                            |instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:44:18 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-hTiUkODdIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target,           |
                   |RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:55:43 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-BFnwQ53Cmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:55:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:55:46 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-MzXZpveUEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99920|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 99980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99980&action=edit
Bug 21591: Check for record level item type issues too

To test:
1 - sudo koha-mysql kohadev
2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1
3 - UPDATE items SET itype = NULL where biblionumber = 1
4 - perl misc/maintenance/search_for_data_inconsistencies.pl
5 - Notice warnings
6 - Apply patch
7 - Undefined itemtype on bibliolevel is now warned
7 - Test also with itype=""

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:57:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:57:46 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-QrIhqSDgT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46232|0                           |1
        is obsolete|                            |
             Status|BLOCKED                     |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at outlook.com
                   |ity.org                     |

--- Comment #8 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 99981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99981&action=edit
Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines

This patch adds method to fetch all borrowers with unpaid
fines.

To test:
prove t/db_dependent/Koha/Patrons.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:58:52 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-gP3H0sNl0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

--- Comment #11 from David Nind <david at davidnind.com> ---
Notes from testing:

Warnings before patch applied
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

== Items do not have itype defined ==
Use of uninitialized value in sprintf at
misc/maintenancesearch_for_data_inconsistencies.pl line 61.
        * Item with itemnumber=1 does not have a itype value, biblio's item
type will be used ()
=> The system preference item-level_itypes expects item types to be defined at
item level

Warning after patch applied (also tested itype=""):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

== Items do not have itype defined ==
 * Item with itemnumber=1 does not have a itype value, additionally no item
type defined for biblionumber=1
=> The system preference item-level_itypes expects item types to be defined at
item level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:59:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 09:59:10 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-Dnj6E2tEnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
> Hmm, I slightly wonder if it's a good idea to allow passing
> credit_number and allowing it to override the AudoCreditNumber
> setting.. to me if it's set then we should throw an Exception if
> someone is trying to pass in their own?

Since credit_number can only be automatically generated, it does not make sense
to check if it's defined or not, so I can remove this check and always
autogenerate a value.
I can also throw an exception.
To me, both solutions are acceptable.

I'll let you pick the one you prefer ;)

> The second question here.. should this apply to ALL credit types, or
> just a subset of those that actually deal with taking money as apposed
> to writeoffs and other types of giving credit (like LOST_ITEM_RETURN)?

I don't know, but the answer is probably... it depends :)
Should I add a "Auto generate credit number" parameter in credit types ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:10:28 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-KB7ch0mh8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Julian Maurice from comment #14)
> > Hmm, I slightly wonder if it's a good idea to allow passing
> > credit_number and allowing it to override the AudoCreditNumber
> > setting.. to me if it's set then we should throw an Exception if
> > someone is trying to pass in their own?
> 
> Since credit_number can only be automatically generated, it does not make
> sense to check if it's defined or not, so I can remove this check and always
> autogenerate a value.
> I can also throw an exception.
> To me, both solutions are acceptable.
> 
> I'll let you pick the one you prefer ;)

I like throwing exceptions as it highlights errors when future devs make
mistakes.. but at the same time they have a tiny performance impact by calling
additional checks so I'm happy without if you'd rather just stop checking for
it and add a note in the POD of the store method to highlight we will be
ignoring it if passed. Your call, I'll accept either :)

> 
> > The second question here.. should this apply to ALL credit types, or
> > just a subset of those that actually deal with taking money as apposed
> > to write-offs and other types of giving credit (like LOST_ITEM_RETURN)?
> 
> I don't know, but the answer is probably... it depends :)
> Should I add a "Auto generate credit number" parameter in credit types ?

That's not a bad idea at all, and is probably reasonably trivial to add if
you're happy to do so, and will keep everbody happy :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:20:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:20:44 +0000
Subject: [Koha-bugs] [Bug 24681] Branch address country is used for HEA as-is
In-Reply-To: <bug-24681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24681-70-3oN9KsKESK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24681

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I moved it to the hea-ws project. I will handle that server-side.

https://gitlab.com/koha-community/hea-ws/issues/1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:31:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:31:28 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-XgcwLJWXSM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99982&action=edit
Bug 24757: (RM follow-up) Restore test count

Somehow we lost a '0' on the test count for
t/db_dependent/Koha/Patrons.t

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:38:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:38:38 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-q85s7P80zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:38:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:38:40 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-6XFNA54jq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:38:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 10:38:43 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
 on February 28 in a Leap Year
In-Reply-To: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24757-70-Y0Sz7LPqhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:37:37 +0000
Subject: [Koha-bugs] [Bug 24786] New: Allow setting a cash register for a
 login session
Message-ID: <bug-24786-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786

            Bug ID: 24786
           Summary: Allow setting a cash register for a login session
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: martin.renvoize at ptfs-europe.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23321

If enabled, the cash register associated with any transaction needs to be
selected for each and every transaction.  One can use a 'branch default' to set
the most likely register for all transactions at a branch, but it would be an
improvement to also allow for selecting a different till for the entirety of a
login session.

This enhancement aims to add that ability, allowing for a session register to
be selected at any point during a session and override the branch default for
that session.

One should still be able to override the register per transaction if required.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:37:37 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23321-70-y2UPUatF3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786
[Bug 24786] Allow setting a cash register for a login session
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:37:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:37:57 +0000
Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login
 session
In-Reply-To: <bug-24786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24786-70-VBRD69ogMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:37:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:37:57 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-giQI8vhx4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786
[Bug 24786] Allow setting a cash register for a login session
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:45:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:45:30 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-QTNDXfjpSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98854|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99983&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:45:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:45:33 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-lA9tIA1yqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98855|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99984&action=edit
Bug 24082: Add refund action to relevant lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:45:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:45:36 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-b1KsmITA0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98856|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99985&action=edit
Bug 24082: Add access to historical transactions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:14 +0000
Subject: [Koha-bugs] [Bug 24724] Add plugin hook for new SQL report export
 formats
In-Reply-To: <bug-24724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24724-70-9q1dTFEoPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24724

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:43 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-kSC6tnOOJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98931|0                           |1
        is obsolete|                            |

--- Comment #21 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99986&action=edit
Bug 24608: Add EditDueDates syspref

This patch adds a EditDueDates syspref which determines whether a button
for editing due dates appears in a patron's checkouts list

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:46 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-sIAxwVnF5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98932|0                           |1
        is obsolete|                            |

--- Comment #22 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99987&action=edit
Bug 24608: Allow due date modification

This patch adds the ability to modify due dates from a patron's
checkouts list.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:49 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-G1ju56SSpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99240|0                           |1
        is obsolete|                            |

--- Comment #23 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99988&action=edit
Bug 24608: (follow-up) Use strings.inc for "Edit"

As per comment #14

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:52 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-SGqr4Omadd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99880|0                           |1
        is obsolete|                            |

--- Comment #24 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99989&action=edit
Bug 24608: (follow-up) Switch to bug 24455 dates

Bug 24455 does a far more comprehensive job of date parsing than my
single use case patch in bug 24650, therefore this bug has now switched
to using it

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:55:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:55:55 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-D4RMUuJo2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99979|0                           |1
        is obsolete|                            |

--- Comment #25 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 99990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99990&action=edit
Bug 24608: (follow-up) Buttons should be buttons

No idea why I used <a> elements for the Edit buttons. But the 'disabled'
attribute has no effect on <a> elements, which leads to all sorts of
problems when you have disabled buttons that are not disabled.

Switched to <button> elements.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:56:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:56:19 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-KcsFPVfcuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:59:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 11:59:55 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-xSMkLx1THr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 99980
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99980
Bug 21591: Check for record level item type issues too

Review of attachment 99980:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21591&attachment=99980)
-----------------------------------------------------------------

::: misc/maintenance/search_for_data_inconsistencies.pl
@@ +89,4 @@
>  
>      my @itemtypes = Koha::ItemTypes->search->get_column('itemtype');
>      if ( C4::Context->preference('item-level_itypes') ) {
> +        my $items_with_invalid_itype = Koha::Items->search( { -and => [itype => { not_in => \@itemtypes }, itype => { '!=' => '' }] } );

I do not think we need that change. @itemtypes contains the values from the
itemtypes table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:03:05 +0000
Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
In-Reply-To: <bug-24562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24562-70-LXozxKpeX0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jawad Makki from comment #14)
> Do you think that this issue is related somehow to Bug 23844 - Noisy warns
> in addbiblio.pl when importing from Z3950 ?
> 
> can the path that you have suggested in Bug 23844 solve the problem reported
> here ?

No, I do not think so. I just removes warnings from logs.
Unless you get thousands of those warnings in the logs (that could slow the
server down), but I do not think it can happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:08:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:08:00 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-no0FUNtjEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99983|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99991&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:08:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:08:03 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-C1i9AuAeRI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99984|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99992&action=edit
Bug 24082: Add refund action to relevant lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:08:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:08:06 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-35h4qvlOIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99985|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99993&action=edit
Bug 24082: Add access to historical transactions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:36:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:36:02 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-D9BRqu057D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Séverine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:37:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:37:31 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-p0fTFlYlgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Owen, can't reproduce.
Could you please add the missing block of CSS in the test plan?

The <div id="opacheader"> is not showing if there are now news (for opacheader)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:39:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:39:18 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-0t1t6OiyUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at outlook.com

--- Comment #1 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
This is still valid. To test:
1. Add holidays for branch A
2. Copy branch A calendar to branch B
3. Repeat copy to branch B 
4. Check tables special_holidays and repeatable_holidays from your database
5. Branch B has now duplicate holidays

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:53:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:53:19 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-y0Tq9hziaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:53:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:53:22 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-7AMhMLzO13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99969|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Denar <black23 at gmail.com> ---
Created attachment 99994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99994&action=edit
Bug 24770: Show age of patron on circulation page

This patch only adds new line containing age to the patron info

1) Navigate to a patron checkout page
2) No age is visible above "category" in patron's info above circ menu
3) Apply the patch
4) Reload this patron
5) Age is here and always visible regardless the active tab

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 12:54:52 +0000
Subject: [Koha-bugs] [Bug 24787] New: send notices fail if there is no email
 in borrowers account
Message-ID: <bug-24787-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24787

            Bug ID: 24787
           Summary: send notices fail if there is no email in borrowers
                    account
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org

This bug is similar to bug 6302 or perhaps has reproduce again.

If there is not a to_address at messages_queue avoids to send any mail, to any
other user at message_queue

I think desirable behaviour should move to 'failed' thos without to_address and
continue with the next one of the list

tested in koha 18.11.03

debian 8

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:01:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:01:24 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-0g6De7hegb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99991|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99995&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:01:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:01:27 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-pC0mNYeKSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99992|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99996&action=edit
Bug 24082: Add refund action to relevant lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:01:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:01:31 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-NyJvcHvCWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99993|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 99997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99997&action=edit
Bug 24082: Add access to historical transactions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:15:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:15:05 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-jzMjOqTfiT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #192 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 99998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99998&action=edit
Bug 14957: Remove usage of deleted Koha::MarcMergeRulesModules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:19:45 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-Ju5LUksOP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99954|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 99999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99999&action=edit
Bug 24775: Add ID to POS submit payment button

This patch simply adds an ID to the submit button to make it easier to
overide styling and functionality.

Test Plan:
0/ Inspect the element on page and note there is no id
1/ Apply patch
2/ Refresh page
3/ Inspect the element on page and note there is now an id

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:26:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:26:43 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-pyVd1Xyx7X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100000&action=edit
Bug 24754: Simplify tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:26:46 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-cBHfYuUxia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100001&action=edit
Bug 24754: Test intranet at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:28:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:28:08 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-JDdT7TF4FH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100000|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:28:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:28:11 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-3MoQQZUZdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100001|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:28:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:28:42 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-HCo2EFN3Lx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100002&action=edit
Bug 24759: Simplify tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:28:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:28:45 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-m6BSCzxyom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100003&action=edit
Bug 24759: Test intranet at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:28:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:28:53 +0000
Subject: [Koha-bugs] [Bug 24788] New: Koha::Object->store calls column names
 as methods, relying on AUTOLOAD, with possibly surprising results
Message-ID: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

            Bug ID: 24788
           Summary: Koha::Object->store calls column names as methods,
                    relying on AUTOLOAD, with possibly surprising results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Koha::Object->store accesse sDBIx::Class::Row columns as $self->$col, using
AUTOLOAD, which in effect makes column names and methods share the same
namespace. I'm no security expert, but I think this should be considered bad
practice and could be an attack vector. It also has huge potential for causing
strange bugs, which happened in Bug 14957 where a column is named "delete",
calling the "delete" method instead of fetching the column value as intended.
Here is patch to fix this using a separate namespace for setting/getting
columns through get_column/set_column instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:29:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:29:12 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-CZc8KT01YW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:29:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:29:15 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-7sG5nKE3qT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99952|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100004&action=edit
Bug 24540: Prevent add button being triggered on enter

This patch prevents the add button being triggered by hitting return
from inside the collected from patron form input.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:30:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:30:05 +0000
Subject: [Koha-bugs] [Bug 24789] New: Remove 'ITS' macro format
Message-ID: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

            Bug ID: 24789
           Summary: Remove 'ITS' macro format
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

During development there was support added for a secondary macro format,
however, I do not believe it was fully supported or documented. It was based on
another ILS macro format I believe

As the rancor format was documented and explained I think we should remove the
other format. According to original developer this was intended to be done
before submission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:30:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:30:11 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-OzhonhHdef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24788


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788
[Bug 24788] Koha::Object->store calls column names as methods, relying on
AUTOLOAD, with possibly surprising results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:30:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:30:11 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-Oaijhlptru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14957


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
[Bug 14957] Write protecting MARC fields based on source of import
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:31:55 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-Jh2RWAnkrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:31:57 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-qlDZhXAalF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100005&action=edit
Bug 24789: Remove ITS macro format

To test:
1 - Apply patches
2 - Confirm you can save, load, and run macros
3 - Confirm you have no choice of format

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:32:23 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-KttoynVEtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17268
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |carnold at dgiinc.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268
[Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser
storage cleared
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:32:23 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-JZri7LxKvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24789


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789
[Bug 24789] Remove 'ITS' macro format
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:32:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:32:26 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-egqevGGFTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100006&action=edit
Bug 24754: Set branch for renewal

Originally I used 'opac' as the interface so that we would follow
opac rules for setting the branches for renewals.

If using api we must explicitly state the branch - falling back to
the checkout branch is the simplest fix as we don't have a user here.

This also corrects typo if setting surname/firstname to CRON instead of ILSDI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:32:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:32:44 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-zw6GS9KAkO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99778|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:37:43 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-SeMCVtkcfR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100007&action=edit
Bug 24788: Remove autoloaded column accessors in Koha::Object->store

Columns are accessed as methods, relying on AUTOLOAD, in
Koha::Object->store. This has security implications and could also be a
source of strange bugs.

To test:

1) Apply patches for Bug 14957
2) Follow the testing instructions, when saving a new marc rule and
error is thrown.
3) Apply patch
4) Try saving a new rule once again, this should now work

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:40:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:40:28 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-C6Xwb5b870@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #193 from David Gustafsson <glasklas at gmail.com> ---
I now found the source of the bug and created a new issue: Bug 24788. This
problem is currently blocking this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:41:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:41:00 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-3Yyf9GKVm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:42:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:42:24 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-MNiH3V9ITU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99948|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100008&action=edit
Bug 24519: Match paycollect form validation for change collection

This patch adds form validation to the Point Of Sale payment page such
that one cannot submit the form with a 'collected' value that is less
than the 'owed' amount.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 13:42:48 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-uH5EfeEKYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:11 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-duLk913J1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:15 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-9k5qq8PfX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98835|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:18 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-Y7EAJDFC2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98836|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:21 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-FTlZp9RpDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98837|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:24 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-o2Vj9d7JIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98838|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:27 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-06DmiQlk2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:30 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0nemDlkmub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98840|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:34 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-IZD50iTTXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:07:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:07:38 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-wTjXLZqPiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:21 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-vYSu6hR5w1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #93 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100009&action=edit
Bug 23355: Add cash_register_actions table

This patch adds the new cash_register_actions database table to allow
for storing of cash register actions which are not already stored as
accountlines.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:26 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-CwCfMusDRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #94 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100010&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:31 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-7Y7nphsWwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #95 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100011&action=edit
Bug 23355: Add CASHUP actions

This patch adds methods relating to cashup procedures to the cash
register object to ease adding and querying for cashup actions related
to the register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:35 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-rETqTKy1eA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #96 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100012&action=edit
Bug 23355: Add accountline deletion test

This patch adds a test to ensure database relations do not cascade
deletions when a cash register is deleted.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:40 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-vpu8BwMYj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #97 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100013&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:44 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-PUq2P11tq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #98 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100014&action=edit
Bug 23355: Split tests for Line vs Lines

This patch simply splits the existing tests for accountlines into two
test files, one for the singular object and one for the set.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:49 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-zAdDqdMgKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #99 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100015&action=edit
Bug 23355: Add register details page

This patch adds a new page which can be accessed via the menu to the
left of the point of sale page.  This new page displays a list of
transactions since the last 'cashup' action, a summary of transaction
amounts and a button to allow the recording of a new 'cashup action.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:53 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-wKidGqF6Kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #100 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100016&action=edit
Bug 23355: Add cashup permissions

Add new 'cashup' sub-permissions to the 'cash_management' permission to
allow fine grained control over whome may 'cashup' a cash register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:10:58 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-HIEkK50QkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #101 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100017&action=edit
Bug 23355: License fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:11:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:11:02 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-vpo0f2Y06i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #102 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100018&action=edit
Bug 23355: (QA follow-up) Add missing TT filters

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:11:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:11:07 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-e21HRqBOlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #103 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100019&action=edit
Bug 23355: (QA follow-up) Missing koha_object(s)_class definitions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:11:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:11:11 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-U6KpontB2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #104 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100020&action=edit
Bug 23355: Rename staff_id for manager_id

This patch makes the parameter naming more consistent and also fixes the
tests (there was a missmatch on the parameter naming, and tests count
was incorrect).

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:11:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:11:17 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-SuLEEPaq4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note: If I tested well, on top of bug 24759:
Without the patch, step 7 indicates "intranet" (test plan expects opac)

Also, test plan is wrong at 18, as the patch now put "api", not "opac".
However I think we should record opac, and depends on bug 24759.

It could help to have an updated test plan, as well as a quick message in the
git body explaining what we really want to achieve with this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:12:49 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0h7rn8d4i1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100021&action=edit
Bug 23355: (QA follow-up) Add a modal confirm to the cashup action

This patch adds a simple modal to confirm the cashup action adding a
safely measure to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:30 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-DNLNH9ELni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99793|0                           |1
        is obsolete|                            |

--- Comment #41 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100022&action=edit
Bug 24476: Database updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:33 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-IrZaEMd8ig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99794|0                           |1
        is obsolete|                            |

--- Comment #42 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100023&action=edit
Bug 24476: API Updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:35 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-9rPlAMtOZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99795|0                           |1
        is obsolete|                            |

--- Comment #43 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100024&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:38 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-y5luzMTDAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99796|0                           |1
        is obsolete|                            |

--- Comment #44 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100025&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:40 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-XgDz3IRHZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |
           Priority|P5 - low                    |P2
           Severity|enhancement                 |major
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:41 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-ueh9VBBo4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99797|0                           |1
        is obsolete|                            |

--- Comment #45 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100026&action=edit
Bug 24476: Rename autorenewal to autorenew_checkouts

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:43 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-2soj1zXOeo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99798|0                           |1
        is obsolete|                            |

--- Comment #46 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100027&action=edit
Bug 24476: DO NOT PUSH - Schema Updates

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:46 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-WDJDt5gRsW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99799|0                           |1
        is obsolete|                            |

--- Comment #47 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100028&action=edit
Bug 24476: Add boolean for TINYINT

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:13:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:13:49 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-DQinbCVf8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99800|0                           |1
        is obsolete|                            |

--- Comment #48 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100029&action=edit
Bug 24476: Allow direct editing of autorenew_checkouts by patron

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:15:11 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-6Vx8iyo30Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100021|0                           |1
        is obsolete|                            |

--- Comment #106 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100030&action=edit
Bug 23355: (QA follow-up) Add a modal confirm to the cashup action

This patch adds a simple modal to confirm the cashup action adding a
safely measure to it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:19:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:19:36 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-uW7pE0THSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:20:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:20:01 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-BOxew54zlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99995|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100031&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:20:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:20:04 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-O2BMPq3kBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99996|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100032&action=edit
Bug 24082: Add refund action to relevant lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:20:07 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-Q3zmWjiiGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99997|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100033&action=edit
Bug 24082: Add access to historical transactions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:36:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:36:09 +0000
Subject: [Koha-bugs] [Bug 24790] New: POS missing from the 'More' dropdown
Message-ID: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

            Bug ID: 24790
           Summary: POS missing from the 'More' dropdown
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We missed to add it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:37:45 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-kvAg2it9ip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target,           |
                   |RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:38:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:38:10 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-9kRVWVdlW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target,           |
                   |RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:39:02 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-hAQOs6jO6l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:39:02 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-cYtvsuF4ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790
[Bug 24790] POS missing from the 'More' dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:39:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:39:39 +0000
Subject: [Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
In-Reply-To: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23914-70-MnJGGYDZ6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:46:23 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-zfGgJnMTWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100034&action=edit
Bug 24790: Add POS to the 'More' dropdown on the staff client

This trivial patch adds 'Point of sale' to the dropdown.

To test:
1. Notice there is no 'Point of sale' entry in the staff dropdown
=> FAIL: No dropdown
2. Apply this patch and reload
=> SUCCESS: Point of sale displays and works
3. Play with enabling/disabling the feature and removing permissions
=> SUCCESS: The entry in the dropdown respects the configured
permissions and settings.
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:47:33 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-dWyrqOGRqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:47:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:47:43 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-TRxmsCWsdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:50:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:50:25 +0000
Subject: [Koha-bugs] [Bug 23359] Problem with batch operations
In-Reply-To: <bug-23359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23359-70-WdHmRhcz6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23359

--- Comment #1 from Vitor Fernandes <vitorfernandes87 at gmail.com> ---
Bug #22417 could help with this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:52:25 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-fTgJ2lMPJE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759
[Bug 24759] OpacRenewalBranch code should be a Koha::Item method
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:52:25 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-GqgTKhrZD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754
[Bug 24754] UserEnv not set for ISLDI requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:52:27 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-gEk6yctaWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99772|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100035&action=edit
Bug 24754: Set userenv for ilsdi requests

Currently ILSDI scripts do not have a userenv set. This affects both
action_logs and statistics.

For action_logs we either get no user or, if there is an active session, we use
that one. This can have unintended consequences and we should explicitly set
the env so that system user (0) is recorded

For statistics we need to speify a branch to record for actions like renewals.
With bug 24759 we add an items method for this. We should take advantage of
this method and use the 'opac' interface as the ilsdi scripts live there.

To test:
1 - Enable ILSDI in systempreferences
2 - Checkout an item to a patron
3 - Enable Renewal logs
4 - Ensure you will be able to renew the item several times
5 - Open an incognito/private browser
6 - Renew item via ilsdi:
   
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
7 - Check action logs, interface may be random, user should be 0, if not make
sure the user in step 9 is a different one
8 - In private browser open a new tab
9 - Sign in to staff client
10 - Return to other tab
11 - Refresh page to repeat renewal
12 - Check action_logs
13 - The second renewal indicates it was renewed via intranet by logged in
staff member
14 - Apply patch
15 - restart_all
16 - Ensure staff client still signed in
17 - Repeate renewal again
18 - Check logs, renewal now indicates opac again (as it should), user is 0
even if logged in on other tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 14:59:27 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-2K1oRd00wK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100036&action=edit
Bug 23534: Fix selenium tests

The title of the page now contains lot of info (is it what we really
want?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:00:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:00:16 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-ub4Uq59SUG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:15 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-hFnDJg0FTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:17 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-UjWqjbepo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:21 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-DXVacDfdfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:22 +0000
Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron
 entry
In-Reply-To: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23536-70-WziBzpT6P8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Not sure this is correct, here we wanted to make the "category_type"
translatable. It is not possible to create new category types.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:27 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-p4Bms8eELE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99903|0                           |1
        is obsolete|                            |

--- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100037&action=edit
Bug 24479: Use $Price filters for '0' amounts

This patch adds the use of the $Price TT filter to properly format '0'
amounts in the POS system.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:03:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:03:40 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-8YfkuktgcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:13:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:13:45 +0000
Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron
 entry
In-Reply-To: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23536-70-Tsia48QyQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #8)
> Not sure this is correct, here we wanted to make the "category_type"
> translatable. It is not possible to create new category types.

Hum weird, not from this patch, neither from previous bug that impacts it (bug
15407). So either it's super old, or it never worked as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:14:29 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-ftRR2kGxwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100034|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100038&action=edit
Bug 24790: Add POS to the 'More' dropdown on the staff client

This trivial patch adds 'Point of sale' to the dropdown.

To test:
1. Notice there is no 'Point of sale' entry in the staff dropdown
=> FAIL: No dropdown
2. Apply this patch and reload
=> SUCCESS: Point of sale displays and works
3. Play with enabling/disabling the feature and removing permissions
=> SUCCESS: The entry in the dropdown respects the configured
permissions and settings.
4. Sign off :-D

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:14:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:14:43 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-8Tg7SbzKUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:21:21 +0000
Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter
 features to datatables api wrapper
In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24561-70-bBZXTT9Iqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99723|0                           |1
        is obsolete|                            |

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100039&action=edit
Bug 24561: Datatables api wrapper also filter and order embedded columns

This patch adds the ability to filter and order by embedded columns.

To use it you must in JS:

$('datatable_selector').api({datatables_options})

where datatables_options are all datatables options plus:

1. embed: [list of embeddable tables]
   This option adds x-koha-embed header to request.

2. header_filter: true|false
   This option if true sets x-koha-query header with stringyfied json of
filters

Oderable and searchable columns must define data option as string, otherwise
filter and order won't be possible.
If you must custom the output, use the render function.

For example:

* Don't

> $('.table_selector').api({
>   columns: [
>     {
>       data: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

* Do

> $('.table_selector').api({
>   columns: [
>     {
>       data: 'holds.patron.firstname',
>       render: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

To test you must implement and test bug 20936, where it will be used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:23:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:23:47 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-3nbPciagpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #10 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Kyle, fixed an issue in bug 24561... now it should work.

Please try again.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:25:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:25:30 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-NR3SVQdlB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #11 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #7)
> For some reason, automatic dependency resolution of git bz doesn't show bug
> 20212 (that ist's a dependency of 24561) as an option to apply.
> 
> To successfuly apply this patch, first apply 20212 manually.

I almost forgot.. bug 24561 no longer depends on 20212.

Now 20212 depends on 24561, so there's no need to apply that bug manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:27:46 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-oXjrUPKNRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100038|0                           |1
        is obsolete|                            |

--- Comment #3 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100040&action=edit
Bug 24790: Add POS to the 'More' dropdown on the staff client

This trivial patch adds 'Point of sale' to the dropdown.

To test:
1. Notice there is no 'Point of sale' entry in the staff dropdown
=> FAIL: No dropdown
2. Apply this patch and reload
=> SUCCESS: Point of sale displays and works
3. Play with enabling/disabling the feature and removing permissions
=> SUCCESS: The entry in the dropdown respects the configured
permissions and settings.
4. Sign off :-D

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:28:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:28:24 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-nhncjftgO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:37:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:37:18 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-GqAv8pRQU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:37:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 15:37:22 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-q0pkZTqWZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99978|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100041&action=edit
Bug 24741: (bug 21674 follow-up) Fix destructive update DB 19.12.00.017

Previous version of the SQL query did not deal correctly with subgroup.

Test plan:
checkout the following commit to be just before 017
  commit 715da06db557edc4b1baa51cc278fdac362c01c4
  Bug 22868: DBRev 19.12.00.016
reset_all # recreate the DB
Create a complex tree of library groups, with several groups, subgroups,
etc.
When you add a new library, refresh the page to add it several time.
When ready, git checkout master, restart all the things, execute the
updatedatabase script, then go to the library groups page.
You should see that the duplicated entries have been removed, but
subgroups have not been deleted

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested with duplicated entries on groups and subgroups,
going back to the right commit and doing clean install.
Patch works, subgroups are preserved. No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:04:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:04:09 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-k77quhAYCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:04:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:04:13 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-tYZwhVvf7I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89372|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100042&action=edit
Bug 22529: Use new C4::Auth::haspermission from svc/members/search

The svc/members/search script can be used to retrieve patrons with a
specific permission. This feature is only used once, to link patrons to
funds.
The code in the script is duplicated from what we have in
C4::Auth::haspermission, and it makes sense to clean it.

Test plan:
Create a fund and add users to this fund.
When you search for users you must only have a list of patrons with the
acquisition.order_manage permission.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:17:35 +0000
Subject: [Koha-bugs] [Bug 24780] 952$i stocknumber does not display in batch
 item modification
In-Reply-To: <bug-24780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24780-70-eO3REJt5bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24780

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:41:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:41:15 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-uwZHpMX1rg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #5)
> I do not recreate this error, however I got it yesterday and fixed it.
> See
>   commit 884ab0d98e54d3a9f5229e2d21fd234dddf298b0
>   Bug 23777: (follow-up) Use To.json in results.tt

Bug 23777 has been pushed to master but this is still a problem. Reopening.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:41:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:41:28 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-g80f5Ktn6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:41:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 16:41:35 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-AdaKNPACcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:13:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 17:13:50 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-KU239H4weO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98713|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100043&action=edit
Bug 24627: Correct style of clubs search results during hold process

This patch updates some markup and CSS so that the process of selecting
a club from search results during the hold process looks the same as
when selecting a patron: Club names should be links (like patron
names are) and the table row should have a hover color to help indicate
that it is clickable.

This patch also changes the markup of the Patrons/Clubs tabs a little
bit to make the information clearer: Superfluous Bootstrap-related tab
markup has been removed, and the patron and club search results have
been moved into their respective tab containers. This means that if you
search for a patron but then switch to the clubs tab the patron list
doesn't still display.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - You should have more than one patron club defined.
 - Begin the process of placing a hold on a title.
 - Test the process of searching for both patrons and clubs.
   - In each case the name (patron or club) should be an active link.
   - Hovering your mouse over the table rows should change the row
     background to yellow.
   - Clicking the other tab at this stage should hide the search results
     from your last search.
   - Whether you click the linked name or elsewhere in the table row
     you should be correctly redirected to the next step in the holds
     process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:14:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 17:14:08 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-2UaqPbtwjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:21:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 17:21:35 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-QrtKzyUiNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #4)
> To recreate:
> 1 - Set AmazonCoverImages to "Show"
> 2 - Set AmazonCoverImages to "Don't show"

=> I get '0', and so I still do not recreate the bug.
I think the patch is valid however, but I'd like to understand why it works for
me. Can you confirm those steps are sufficient to recreate the problem? Which
OS?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 17:22:48 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-qtWTL3E1Wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am running koha-testing-docker with KOHA_IMAGE=master with docker-compose.yml
and docker-compose.mariadb_d9.yml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 17:22:52 +0000
Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory
In-Reply-To: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14393-70-hXTnj5cKbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #24 from Joy Nelson <joy at bywatersolutions.com> ---
David-
Glad to hear this is still moving forward!  We have a library interested in
this feature.  Let us know how we can help with testing/signoffs/QA etc!

Thanks
joy


(In reply to David Cook from comment #23)
> I think I've recently ported this to 19.11, so I'll have another look at
> this soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 19:20:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 18:20:14 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-enlPDxKiWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 19:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 18:21:16 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-xHkbqNWM6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #99 from David Nind <david at davidnind.com> ---
Hi Arthur. Have tested again, even though it is already signed off now.
Everything works fine, except for the DataTables/Ajax warning. Bug 24769
created for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 19:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 18:21:26 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-kx3stdfpDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

--- Comment #9 from Chris Slone <cslone at camdencountylibrary.org> ---
This appears to be bugged on 19.05 too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 19:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 18:21:56 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-uBTEQpHc0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

--- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> ---
I appreciate that the patch contains a div for the age because I know some
libraries would rather not always display the information. This will allow us
to use JQ to hide the information. 
For example we put all our adult patrons at birth year 1900 because we only
care if they over 18, not how old they are.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 19:22:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 18:22:05 +0000
Subject: [Koha-bugs] [Bug 24769] DataTable error on patron hold page when
 hold placed using ILS-DI
In-Reply-To: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24769-70-znPHCgVlVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769

--- Comment #3 from David Nind <david at davidnind.com> ---
Error also happening on bug 11999 before patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:10:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:10:16 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-qfdeRQwAMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #11)
> I am running koha-testing-docker with KOHA_IMAGE=master with
> docker-compose.yml and docker-compose.mariadb_d9.yml

I am using docker-compose.mariadb_d10.yml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:19:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:19:02 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-ULTV64p55O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

--- Comment #6 from Lisette Scheer <lisetteslatah at gmail.com> ---
I agree with Katrin that green so often means good that it would be confusing. 
I checked in word and libreoffice and they both did blue underline for grammar
errors. Maybe a blue highlight or underline would work here as well? 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:21:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:21:38 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-Zuu0tXIsEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

--- Comment #7 from Cori Lynn Arnold <carnold at dgiinc.com> ---

I'm good with highlight blue. 

We'd like this to be a bit more prominent than underline, as it's an insidious
problem and common for people converting from OCLC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:24:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:24:29 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-ekLeJN6jEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97090|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100044&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:24:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:24:32 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-mkoyxAe6Ni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97091|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100045&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:24:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:24:35 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-P9QsGfVsn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100046&action=edit
Bug 24081: Add discount action to boraccount

This patch adds the ability to apply discounts to existing patron
charges from the boraccount page.

Test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:25:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:25:39 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-PbRm8sQDSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88977|0                           |1
        is obsolete|                            |

--- Comment #45 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 100047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100047&action=edit
Bug 15400: Display date of birth and age more consistantly

Test plan:
0) Apply the patch
1) Go to all of these pages
    Patron detail
    Other patron pages - look on the left side (circ-menu)
    Patron search
    Guarantor search ( go to child patron -> edit -> in guarantor
        section click "Set to patron"
    Search through "Check out" (in the header)

2) Confirm that does show date of birth and date consistantly,
    try it on patrons with and without date of birth set to find
    possible reggressions

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:25:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:25:41 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-ttaz7AoDzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:25:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:25:47 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-IySr0ZhKFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88978|0                           |1
        is obsolete|                            |

--- Comment #46 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 100048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100048&action=edit
Bug 15400: (follow-up) Updating text display

Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and
search results

Sponsored-by: Catalyst IT

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:25:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:25:52 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-TQzCRxXjU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88979|0                           |1
        is obsolete|                            |

--- Comment #47 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 100049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100049&action=edit
Bug 15400: (follow-up) Adding age to check out search dropdown

Confirm age shows in the suggestions dropdown when using the checkout
search in header (if user set DOB).
Confirm 'Age unknown' shows if no DOB set.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:25:57 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-aJr3TqEmW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88980|0                           |1
        is obsolete|                            |

--- Comment #48 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 100050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100050&action=edit
Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:26:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:26:02 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-HOGamYggLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88981|0                           |1
        is obsolete|                            |

--- Comment #49 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 100051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100051&action=edit
Bug 15400: (follow-up) Add class to years span

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:26:04 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-I1E0L2H5lc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:27:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:27:48 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-rZShYM6TxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #50 from Josef Moravec <josef.moravec at gmail.com> ---
Rebased on master.

This was PQA before, but as it was so long then I finally rebased it (sorry for
that!) I am marking it back to signed off state.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:28:19 +0000
Subject: [Koha-bugs] [Bug 24770] Show age of patron on circulation page
In-Reply-To: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24770-70-PfpCXt4W3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---


*** This bug has been marked as a duplicate of bug 15400 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:28:19 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-MyCCiwmsB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #51 from Josef Moravec <josef.moravec at gmail.com> ---
*** Bug 24770 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:31:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:31:13 +0000
Subject: [Koha-bugs] [Bug 24791] New: Point of Sale module is missing from
 the 'more' menu
Message-ID: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

            Bug ID: 24791
           Summary: Point of Sale module is missing from the 'more' menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The top level point of sale page isn't yet listed in the 'more' menu at the top
of the staff client and it should be.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:31:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:31:17 +0000
Subject: [Koha-bugs] [Bug 24791] Point of Sale module is missing from the
 'more' menu
In-Reply-To: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24791-70-0U6gZXy4Nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:31:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:31:45 +0000
Subject: [Koha-bugs] [Bug 24791] Point of Sale module is missing from the
 'more' menu
In-Reply-To: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24791-70-hP5HUDgeNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:31:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:31:45 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-lRxURnA4IF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791
[Bug 24791] Point of Sale module is missing from the 'more' menu
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:35:26 +0000
Subject: [Koha-bugs] [Bug 24792] New: Cash register 'cashup' functionality
 should be available without 'Point of Sale'
Message-ID: <bug-24792-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24792

            Bug ID: 24792
           Summary: Cash register 'cashup' functionality should be
                    available without 'Point of Sale'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23355

The 'cashup' functionality introduced by bug 23355 is currently only available
via the point of sale module payment page; however such functionality only
relies upon cash registers having been defined and as such may be used without
enabling point of sale as a module.

We should add an entrance point to this functionality elsewhere for such a
case.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:35:26 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0zbdpq8wVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24792
[Bug 24792] Cash register 'cashup' functionality should be available without
'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:35:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:35:32 +0000
Subject: [Koha-bugs] [Bug 24792] Cash register 'cashup' functionality should
 be available without 'Point of Sale'
In-Reply-To: <bug-24792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24792-70-4hFq9WxO2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24792

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:36:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:36:59 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-cVyleC93a5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:04 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-QDFzhZn9lM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92933|0                           |1
        is obsolete|                            |

--- Comment #194 from David Nind <david at davidnind.com> ---
Created attachment 100052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100052&action=edit
Bug 14957: DO NOT PUSH Schema changes

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:11 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-TLvkJFmHY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92934|0                           |1
        is obsolete|                            |

--- Comment #195 from David Nind <david at davidnind.com> ---
Created attachment 100053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100053&action=edit
Bug 14957: Merge rules system for merging of MARC records

Add a rule based system for merging MARC records to for example
prevent field data from being overwritten.

To test:
    1. Apply this patch.
    2. Log in to staff client.
    3. Enable new syspref MARCMergeRules.
    4. Click the new link "MARC merge rules" in the "Catalog"
       section of the Koha administration page.
    5. Create a new rule:
       Module: source, Filter: *, Tag: 245, Preset: Protect.
    6. Clicking "Edit" should allow you to edit corresponding rule.
    7. Clicking "Delete" should remove corresponding rule after confirmation.
    8. Selecting one or more rules followed by clicking "Delete
       selected" should remove all selected rules after confirmation.
    9. Try creating a rule with tag set to "**", the other options does
       not matter. Verify that saving this rule produces an error
       message complaining about invalid tag regular expression.
    10. Try creating a rule with tag set to "008" (or other control
        field) and set Appended: Append and Removed: Skip, the other
        options does not matter. Verify that saving this rule produces
        an error message complaining about invalid combination of actions
        for control field.
    11. With the 245 rule in step 5 in place, edit a bibliographic record,
        change 245a for example (which should be Title for MARC21) and save.
    12. Verify that the changes has not been saved.
    13. Create a new rule:
        Module: source, Filter: intranet, Tag: 245, Preset: Overwrite.
    14. Repeat step 12, and verify that the changes has now been saved.
    15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very
        that all tests pass.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenburg University Library

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:18 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-H7S1eUxITw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92935|0                           |1
        is obsolete|                            |

--- Comment #196 from David Nind <david at davidnind.com> ---
Created attachment 100054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100054&action=edit
Bug 14957: Make preset labels translatable

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:24 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-nAF8pKVp2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92936|0                           |1
        is obsolete|                            |

--- Comment #197 from David Nind <david at davidnind.com> ---
Created attachment 100055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100055&action=edit
Bug 14957: Adjust paging option for new version of datatables

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:30 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-MXAN9VgCGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92937|0                           |1
        is obsolete|                            |

--- Comment #198 from David Nind <david at davidnind.com> ---
Created attachment 100056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100056&action=edit
Bug 14957: Fix rule javascript validation issue

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:37 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-VymRc1tiNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92938|0                           |1
        is obsolete|                            |

--- Comment #199 from David Nind <david at davidnind.com> ---
Created attachment 100057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100057&action=edit
Bug 14957: Change YUI layout to to Boostrap

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:43 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-GA4F0LjD18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92999|0                           |1
        is obsolete|                            |

--- Comment #200 from David Nind <david at davidnind.com> ---
Created attachment 100058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100058&action=edit
Bug 14957: Remove prefetch of removed relationship

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:49 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-PoBa3g8KHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94909|0                           |1
        is obsolete|                            |

--- Comment #201 from David Nind <david at davidnind.com> ---
Created attachment 100059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100059&action=edit
Bug 14957: Add icons for confirmation dialog and set preset based on actions
configuration

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:37:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:37:56 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-XZRzEZsxzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94911|0                           |1
        is obsolete|                            |

--- Comment #202 from David Nind <david at davidnind.com> ---
Created attachment 100060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100060&action=edit
Bug 14957: Replace filter value with label if one exists

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:38:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:38:02 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-tBp32HvVoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99998|0                           |1
        is obsolete|                            |

--- Comment #203 from David Nind <david at davidnind.com> ---
Created attachment 100061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100061&action=edit
Bug 14957: Remove usage of deleted Koha::MarcMergeRulesModules

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:42:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:42:19 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-7OJJlV9xUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:42:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:42:35 +0000
Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for
 each issue in subscription tab of /catalogue/detail.pl
In-Reply-To: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23450-70-46c7oIvRkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:45:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:45:15 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-S2CxKm5TZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:45:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:45:18 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-s15OXcBYxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87993|0                           |1
        is obsolete|                            |
  Attachment #88383|0                           |1
        is obsolete|                            |

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100062&action=edit
Bug 15253: Add Koha::Logger based logging for SIP2

Now that we have Koha::Logger, we should use it in our SIP server. This
has the potential to make debugging SIP issue much easier. We should add
the userid for the sipuser to the namespace so we can allow for separate
files per sip user if wanted.

Also modifies the log4perl.conf to lazy-open filehandles to log files,
so the same config can be used with log-files needing different
permissions.

Test Plan:
1) Apply this patch set
2) Update the modififed log4perl.conf to your system
3) Restart your sip server
4) Tail your sip2.log, run some queries
5) Note you still get the same output messages as before, with the
   addition of the ip address and username ( if available )
   prefixing the message.

Based on original patches by Kyle Hall and additions by Olli-Antti
Kivilahti.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:45:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:45:28 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-q4NoevQlhO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100063&action=edit
Bug 15253: Move subs to a new module, allow unit tests to function

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:47:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:47:56 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-WOtcjhgXQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:47:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:47:58 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-HAC0SrFMQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100007|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100064&action=edit
Bug 24788: Remove autoloaded column accessors in Koha::Object->store

Columns are accessed as methods, relying on AUTOLOAD, in
Koha::Object->store. This has security implications and could also be a
source of strange bugs.

To test:

1) Apply patches for Bug 14957
2) Follow the testing instructions, when saving a new marc rule and
error is thrown.
3) Apply patch
4) Try saving a new rule once again, this should now work

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 20:51:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 19:51:27 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-irJKiNjAu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #204 from David Nind <david at davidnind.com> ---
(In reply to David Gustafsson from comment #193)
> I now found the source of the bug and created a new issue: Bug 24788. This
> problem is currently blocking this patch.

Have signed off - everything seems to work as per the test plan the tests!

One note for test plan: need to update the database (updatedatabase on
koha-testing-docker)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:03:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:03:29 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-RWqsOq29pN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100047|0                           |1
        is obsolete|                            |
 Attachment #100048|0                           |1
        is obsolete|                            |
 Attachment #100049|0                           |1
        is obsolete|                            |
 Attachment #100050|0                           |1
        is obsolete|                            |
 Attachment #100051|0                           |1
        is obsolete|                            |

--- Comment #52 from Michal Denar <black23 at gmail.com> ---
Created attachment 100065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100065&action=edit
Bug 15400: Display date of birth and age more consistantly

Test plan:
0) Apply the patch
1) Go to all of these pages
    Patron detail
    Other patron pages - look on the left side (circ-menu)
    Patron search
    Guarantor search ( go to child patron -> edit -> in guarantor
        section click "Set to patron"
    Search through "Check out" (in the header)

2) Confirm that does show date of birth and date consistantly,
    try it on patrons with and without date of birth set to find
    possible reggressions

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:03:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:03:33 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-LJgERj1NK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #53 from Michal Denar <black23 at gmail.com> ---
Created attachment 100066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100066&action=edit
Bug 15400: (follow-up) Updating text display

Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and
search results

Sponsored-by: Catalyst IT

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:03:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:03:38 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-UJJNFFu1Zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #54 from Michal Denar <black23 at gmail.com> ---
Created attachment 100067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100067&action=edit
Bug 15400: (follow-up) Adding age to check out search dropdown

Confirm age shows in the suggestions dropdown when using the checkout
search in header (if user set DOB).
Confirm 'Age unknown' shows if no DOB set.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:03:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:03:43 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-IdNEkCPtrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #55 from Michal Denar <black23 at gmail.com> ---
Created attachment 100068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100068&action=edit
Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:03:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:03:48 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-vgFtWryTjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #56 from Michal Denar <black23 at gmail.com> ---
Created attachment 100069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100069&action=edit
Bug 15400: (follow-up) Add class to years span

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:09:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:09:28 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-P5ruir76od@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #6 from Michal Denar <black23 at gmail.com> ---
Hi Martin,
test plan? :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:15:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:15:22 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-B0KuYffh6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:01 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-v8b06OkWDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Works as expected, fixed minor QA issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:03 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-Fk2l3Auzxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100032|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:06 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-oCTTmSOkC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100033|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:09 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-WpzPhVK5xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100031|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:49 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-MvG2lnAidH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100070&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:27:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:27:55 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-L8XUeYrwAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100071&action=edit
Bug 24082: Add refund action to relevant lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:28:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:28:00 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-YWvS088vyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100072&action=edit
Bug 24082: Add access to historical transactions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:28:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:28:07 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-TTUiV2wThY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100073&action=edit
Bug 24082: (QA follow-up): Template fixes

This patch introduces missing TT filters and also replaces tabs for
spaces to fix indentation problems.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:30:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:30:53 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-DoBDcguHVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #7 from Michal Denar <black23 at gmail.com> ---
Test plan:

-create manual invoice
- go to Transaction a here is new button Appla discount, click
- in modal, set discount and confirm
- check if amount to pay is lower (minus discount)
- pay amount

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:32:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:32:05 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-B5HaekYEdq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:32:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:32:08 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-xmd6txnvqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100044|0                           |1
        is obsolete|                            |
 Attachment #100045|0                           |1
        is obsolete|                            |
 Attachment #100046|0                           |1
        is obsolete|                            |

--- Comment #8 from Michal Denar <black23 at gmail.com> ---
Created attachment 100074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100074&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:32:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:32:11 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-oYRl9GPxyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #9 from Michal Denar <black23 at gmail.com> ---
Created attachment 100075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100075&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:32:15 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-GLaTSfTHuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #10 from Michal Denar <black23 at gmail.com> ---
Created attachment 100076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100076&action=edit
Bug 24081: Add discount action to boraccount

This patch adds the ability to apply discounts to existing patron
charges from the boraccount page.

Test plan

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:38:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:38:23 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-WbcciLlXs2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

--- Comment #11 from Michal Denar <black23 at gmail.com> ---
Hi,
I really like this feature. It's works. But itsn't "user friendly". I prefer to
apply discout directly at "Pay an amount toward all fines" or "Pay an
individual fine" window. 

Thank you for opinions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:46:51 +0000
Subject: [Koha-bugs] [Bug 24793] New: TinyMCE for HTML notices
Message-ID: <bug-24793-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24793

            Bug ID: 24793
           Summary: TinyMCE for HTML notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: black23 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Hi,
what do you think about TinyMCE editor for HTML notices?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:48:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 20:48:34 +0000
Subject: [Koha-bugs] [Bug 24793] TinyMCE for HTML notices
In-Reply-To: <bug-24793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24793-70-wlwyBKCsA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24793

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |lucas at bywatersolutions.com,
                   |                            |magnus at libriotech.no,
                   |                            |oleonard at myacpl.org,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:04:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 21:04:41 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-PomKcoLCeO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Arthur Bousquet <arthur.bousquet at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95808|0                           |1
        is obsolete|                            |

--- Comment #18 from Arthur Bousquet <arthur.bousquet at inlibro.com> ---
Created attachment 100077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100077&action=edit
Bug 11361 - Fixing database and merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:11:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 21:11:53 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-JNNB8vBG5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Arthur Bousquet <arthur.bousquet at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #19 from Arthur Bousquet <arthur.bousquet at inlibro.com> ---
Should now pass the database update, also solved some new merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:20:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 21:20:59 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-DhZVuaMLzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:21:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 21:21:02 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-4pHyeRtHaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99683|0                           |1
        is obsolete|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100078&action=edit
Bug 24710: patron-title.inc should have seperate span classes for names

This patch adds some <span> elements with classes to patron-title.inc for both
the staff client and OPAC
TEST PLAN:
1. Have a patron with a firstname, surname, and othername and title
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS  to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
    .patron-firstname {display: none;}
    .patron-othernames {display:none};
    .patron-surname{display:none}
    .patron-title{display:none}
5. On the OPAC navigate to /cgi-bin/koha/opac-user.pl and check the names by
adding the same CSS to OPACUserCSS
6. Sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 21:23:33 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-OG6sRU26NA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #219 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 100079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100079&action=edit
Bug 17015: (follow-up) accept Koha::Library objects in place of a branchcode
string, always use the syspref 'dateformat'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:02:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:02:05 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-RYaQntVBRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

--- Comment #8 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 100080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100080&action=edit
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be detected and
highlighted (green).

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the delimiter the space and delimiter should be highlighted green.
  - Remove the extra space and confirm that the highlight
            disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:08:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:08:34 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-Zcyi6FDUVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100080|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:16:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:16:42 +0000
Subject: [Koha-bugs] [Bug 22933] Support for FIDO WebAuthn (passwordless)
In-Reply-To: <bug-22933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22933-70-5dZdEYZOeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22933

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #1 from Michal Denar <black23 at gmail.com> ---
http://blogs.perl.org/users/mschout/2018/01/testing-fidou2f-two-factor-authentication.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:19:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:19:34 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-6lW5MBfZX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99444|0                           |1
        is obsolete|                            |

--- Comment #9 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 100081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100081&action=edit
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be detected and
highlighted (green).

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the delimiter the space and delimiter should be highlighted green.
  - Remove the extra space and confirm that the highlight
            disappears.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:22:12 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-PLn6sIXkhB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #10 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by a red
dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the **delimiter the space and delimiter should be surrounded by a red dotted
border.
  - Remove the extra space and confirm that the red dotted border is removed

**To create a delimiter in the advanced editor, go to a non-control field
(after 010) and hit the control button with the letter "d" then enter any
letter or single digit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:23:52 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-i1eYyaPeSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100081|0                           |1
        is obsolete|                            |

--- Comment #11 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 100082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100082&action=edit
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by a red
dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
    - On any text entry line (e.g. 245), add a space immediately following
      the **delimiter the space and delimiter should be surrounded by a red
dotted border.
        - Remove the extra space and confirm that the red dotted border is
removed

        **To create a delimiter in the advanced editor, go to a non-control
field (after 010) and hit the control button with the letter "d" then enter any
letter or single digit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2020 22:30:30 +0000
Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after
 delimiter visually
In-Reply-To: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24709-70-zloUrsJaYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #12 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Issues with my vm space is causing this not to work :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 07:01:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 06:01:15 +0000
Subject: [Koha-bugs] [Bug 24794] New: On Adding a book using any framework
 in cataloging Error : Tag "" is not a valid tag. at
 /usr/share/koha/lib/C4/Biblio.pm line 2316
Message-ID: <bug-24794-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24794

            Bug ID: 24794
           Summary: On Adding a book using any framework in cataloging
                    Error : Tag "" is not a valid tag. at
                    /usr/share/koha/lib/C4/Biblio.pm line 2316
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: abhishekv at samanvayfoundation.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 100083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100083&action=edit
Error message after clicking save on the catalog screen.

Some people suggested to do mapping of biblioitemnumber field, the fild 999 c
and 999 d both are mapped in subfield under the framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 07:02:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 06:02:52 +0000
Subject: [Koha-bugs] [Bug 24794] On Adding a book using any framework in
 cataloging Error : Tag "" is not a valid tag. at
 /usr/share/koha/lib/C4/Biblio.pm line 2316
In-Reply-To: <bug-24794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24794-70-ilZh0YcfnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24794

Abhi <abhishekv at samanvayfoundation.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 08:25:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 07:25:13 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-7bysOVt0vF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at koha-suomi.fi

--- Comment #9 from paxed <pasi.kallinen at koha-suomi.fi> ---
This added an untranslatable "Print receipt" button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 08:34:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 07:34:26 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-3xDQgIPPg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to paxed from comment #9)
> This added an untranslatable "Print receipt" button.

Hi paxed - I don't see it in the patch - can you point it out?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 08:40:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 07:40:32 +0000
Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
In-Reply-To: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23534-70-CTgC39yn6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534

--- Comment #11 from paxed <pasi.kallinen at koha-suomi.fi> ---
(In reply to Katrin Fischer from comment #10)
> (In reply to paxed from comment #9)
> > This added an untranslatable "Print receipt" button.
> 
> Hi paxed - I don't see it in the patch - can you point it out?

Blah, comment ended up on the wrong one, meant bug 23355

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 08:41:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 07:41:48 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-7GszjOWVgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at koha-suomi.fi

--- Comment #108 from paxed <pasi.kallinen at koha-suomi.fi> ---
This added an untranslatable "Print receipt" button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 08:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 07:49:54 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-BZYEYEhkTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Michal Denar from comment #11)
> Hi,
> I really like this feature. It's works. But itsn't "user friendly". I prefer
> to apply discout directly at "Pay an amount toward all fines" or "Pay an
> individual fine" window. 
> 
> Thank you for opinions.

Thanks for the quick testing, and my apologies for the lack of test plan..
seems I forgot to paste it into the commit message after drafting it.. oops.

As for the feedback, that's great. I wanted to get the foundation in with this
bug and then build on top of them.  I'll open some further bugs with your
idea's as their foundation, as I have done for Tomas when he QA'd the parallel
'Refund' bug requesting similar options.

I also intend to migrate some of the existing automated discounting
functionality to using this model of record for auditability which has been
sorely missed in the past.

Thanks again,

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:25:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:25:45 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-lmy51m8Hbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #98)
> Created attachment 100014 [details] [review]
> Bug 23355: Split tests for Line vs Lines
> 
> This patch simply splits the existing tests for accountlines into two
> test files, one for the singular object and one for the set.

Did we really decided that? I do not see the point to multiplicate the number
of test files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:32:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:32:09 +0000
Subject: [Koha-bugs] [Bug 24795] Password change  at first login
In-Reply-To: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24795-70-BY3f1Ao6S6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
                 CC|                            |dpavlin at rot13.org
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org
            Product|Koha security               |Koha
          Component|Koha                        |Authentication
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:36:14 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-D1ZZHY6SJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100074|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100084&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:36:17 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-PMTaCA4UTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100075|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100085&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:36:20 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-6FhErCL6Ze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100076|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100086&action=edit
Bug 24081: Add discount action to boraccount

This patch adds the ability to apply discounts to existing patron
charges from the boraccount page.

Test plan
1/ Carry out some accounting actions that end up with debts on the
patron record. (Add a manual invoice for example)
2/ Note a new 'Apply discount' action button on the unpaid debt
3/ Paid debts do not display the action button
4/ Click the button
5/ Enter an amount into the resulting modal and click confirm
6/ Confirm that the outstanding debt has been reduced by the amount you
specified.
7/ Confirm that a new 'Discount' line appears on the patrons account
8/ Confirm that in the 'details' view of the debt that the discount line
was used against the debt to create the reduction.
9/ Signoff

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:49:26 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-KMwR59awQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100084|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100087&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:49:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:49:29 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-L2M9V5cCM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100085|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100088&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:49:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:49:32 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-zZ6hIETqEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100086|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100089&action=edit
Bug 24081: Add discount action to boraccount

This patch adds the ability to apply discounts to existing patron
charges from the boraccount page.

Test plan
1/ Carry out some accounting actions that end up with debts on the
patron record. (Add a manual invoice for example)
2/ Note a new 'Apply discount' action button on the unpaid debt
3/ Paid debts do not display the action button
4/ Click the button
5/ Enter an amount into the resulting modal and click confirm
6/ Confirm that the outstanding debt has been reduced by the amount you
specified.
7/ Confirm that a new 'Discount' line appears on the patrons account
8/ Confirm that in the 'details' view of the debt that the discount line
was used against the debt to create the reduction.
9/ Signoff

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:49:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:49:50 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0doBc2kh8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100090&action=edit
Bug 23355: Make "Print receipt" translatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:52:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:52:39 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-21ae9MsX9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 08:56:10 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-M2qKKh53SA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #109)
> (In reply to Tomás Cohen Arazi from comment #98)
> > Created attachment 100014 [details] [review] [review]
> > Bug 23355: Split tests for Line vs Lines
> > 
> > This patch simply splits the existing tests for accountlines into two
> > test files, one for the singular object and one for the set.
> 
> Did we really decided that? I do not see the point to multiplicate the
> number of test files.

Personally.. I find it much clearer to have a test file per class.. we made the
decision to not go the DBIx::Class by splitting our result classes in two.. one
for plural one for singular.. we should do the exact same thing in the tests
otherwise it gets difficult to find where a function is tested.

Also, from a debugging and code reading perspective, I find it hard to find a
test in a really really really long single test file.. it's much easier to find
the relevant test in a shorted file ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:12:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 09:12:40 +0000
Subject: [Koha-bugs] [Bug 24791] Point of Sale module is missing from the
 'more' menu
In-Reply-To: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24791-70-weMR9YWmXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:12:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 09:12:40 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-ND0CXzlF38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791
[Bug 24791] Point of Sale module is missing from the 'more' menu
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 09:42:46 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-JN9m0UN4ut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #113 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am sure you can use '/' in your editor, and git grep when you are in a shell.
H
ard to find is not a valid answer :D
Let's have this discussion later, somewhere else, but please do not consider
that everybody agreed on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:51:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 09:51:44 +0000
Subject: [Koha-bugs] [Bug 24796] New: No test coverage for getting
 translations from templates
Message-ID: <bug-24796-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24796

            Bug ID: 24796
           Summary: No test coverage for getting translations from
                    templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

There are two different code paths for getting translatable strings out of
templates: 1) extract_messages_from_templates() in LangInstaller.pm which
handles js-files and the templates that use i18n.inc, 2) tmpl_process3.pl which
uses misc/translation/xgettext.pl to parse and extract strings out of tt-files.

The t/LangInstaller.t only tests the first one, there are no tests whatsoever
for the second.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:04:03 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-0USUOl93y1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:04:08 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-jz6QhOwfGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99881|0                           |1
        is obsolete|                            |
  Attachment #99882|0                           |1
        is obsolete|                            |
  Attachment #99883|0                           |1
        is obsolete|                            |
  Attachment #99884|0                           |1
        is obsolete|                            |
  Attachment #99885|0                           |1
        is obsolete|                            |

--- Comment #20 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100091&action=edit
Bug 22806: CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:04:26 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-29G0Khx5BO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #21 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100092&action=edit
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

As CanBookBeReserved() was failing as $patron and and $biblio were not
instantiated I fixed that up.

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Sponsored-By: Catalyst IT
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:04:49 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-Nt3XqUEmts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #22 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100093&action=edit
Bug 22806: Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:06:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:06:06 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-t0YSttDyRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #23 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi David,
My apologizes, the patch was rebased on another branch than master...
Now ready to test (ahem)
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:25:49 +0000
Subject: [Koha-bugs] [Bug 24797] New: xx-XX-messages.po line numbers are not
 correct
Message-ID: <bug-24797-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24797

            Bug ID: 24797
           Summary: xx-XX-messages.po line numbers are not correct
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Running ./translate update xx-XX, then looking at po/xx-XX-message.po that
contains the i18n.inc t(), tx(), tnx() etc translatable strings, the line
numbers in the files where the message appears in are not correct:


#: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:1
#: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:2
msgctxt "purchase suggestion created by"
msgid "Created by:"
msgstr ""

The comments say that message appears on line 1 and on line 2, but this is not
correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:39:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:39:38 +0000
Subject: [Koha-bugs] [Bug 24798] New: smart-rules.tt has erroneous comments
Message-ID: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

            Bug ID: 24798
           Summary: smart-rules.tt has erroneous comments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#% Default
branch %#]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#%
Branch-specific %#]

but TT comments are [%#

Go to admin/smart-rules.pl and search the page source, you'll find those
strings in there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:40:23 +0000
Subject: [Koha-bugs] [Bug 24768] "Return claims" column is missing from
 column configuration page
In-Reply-To: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24768-70-rdJ2h1ORUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24768

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:40:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:40:36 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-jM4frIpdU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:45:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:45:52 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
 status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-t5pTNT9Agz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:49:14 +0000
Subject: [Koha-bugs] [Bug 24791] Point of Sale module is missing from the
 'more' menu
In-Reply-To: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24791-70-pyKV2dblcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
         Resolution|---                         |DUPLICATE

--- Comment #1 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---


*** This bug has been marked as a duplicate of bug 24790 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:49:14 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-ya2lXZLh1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
*** Bug 24791 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:49:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:49:15 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-Tv1nFGLzCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
Bug 13985 depends on bug 24791, which changed state.

Bug 24791 Summary: Point of Sale module is missing from the 'more' menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24791

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:51:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:51:22 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-HpS8WUm57h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:51:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:51:25 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-BYsmUwfANb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100041|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100094&action=edit
Bug 24741: (bug 21674 follow-up) Fix destructive update DB 19.12.00.017

Previous version of the SQL query did not deal correctly with subgroup.

Test plan:
checkout the following commit to be just before 017
  commit 715da06db557edc4b1baa51cc278fdac362c01c4
  Bug 22868: DBRev 19.12.00.016
reset_all # recreate the DB
Create a complex tree of library groups, with several groups, subgroups,
etc.
When you add a new library, refresh the page to add it several time.
When ready, git checkout master, restart all the things, execute the
updatedatabase script, then go to the library groups page.
You should see that the duplicated entries have been removed, but
subgroups have not been deleted

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested with duplicated entries on groups and subgroups,
going back to the right commit and doing clean install.
Patch works, subgroups are preserved. No errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:57:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:57:46 +0000
Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields
 in C4/Heading/MARC21.pm, Generated authorities are missing subfields
In-Reply-To: <bug-24675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24675-70-gEfOVxeXt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
The reference here is to the MARC bibliographic records - $e is not a subfield
that is supposed to be recorded in authorities - that would end up creating a
different record for each relator terms for the same individual.

Check here, under the 'LC Guidelines' link near the bottom - LC has a list of
subfields not to use, including e

We might need an update here, but I think we need to get an authoritative list
with some cataloger input before moving it ahead

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:59:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 10:59:52 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-fsCpQU2Uif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bernardo, I am letting here the QA notes for the whole stack (I rebased my
remote branch btw, there were 2 minor conflicts due to copyright changes).

1. There are some QA issues:
 FAIL  
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml 
   FAIL   yaml_valid                                                           
                                                                               
                                                                   YAML Error:
Inconsistent indentation level                                                  
                                                                               
                                                                               
                                                    FAIL  
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml 
   FAIL   yaml_valid                                                           
                                                                               
                                                                   YAML Error:
Inconsistent indentation level                                                  
                                                                               
                                                                               
                                                    FAIL  
installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.yml 
   FAIL   yaml_valid                                                           
                                                                               
                                                                   YAML Error:
Inconsistent indentation level                                                  
                                                                               
                                                                               
                                                    FAIL  
installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.yml 
   FAIL   yaml_valid                                                           
                                                                               
                                                                   YAML Error:
Inconsistent indentation level                                                  
                                                                               
                                                                               
                                                    FAIL  
installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.yml 
   FAIL   yaml_valid                                                           
                                                                               
                                                                   YAML Error:
Inconsistent indentation level    

2. I did an install 'en' before and after the patchset, I mysqldump --tab to
generate 2 files per table, then compared the 2 generated directories with
`diff -r --brief` (and also a `perl -p -i -e "s/.*Dump completed.*//" **/*` to
remove timestamp of the dump).
Most of them are wrong diff because of different timestamps, but some of them
are either weird, or caught issues:

a) When a row is on several lines, I get, for instance with letter
"TO_PROCESS":
652,657c652,657
\ suggestions   TO_PROCESS              Notify fund owner       0       A
suggestion is ready to be processed   Dear <<borrowers.firstname>>
<<borrowers.surname>>,
\ 
\ A new suggestion is ready to be processed: <<suggestions.title>> by
<<suggestions.author>>.
\ 
\ Thank you,
\ 
---
> suggestions	TO_PROCESS		Notify fund owner	0	A suggestion is ready to be processed	Dear <<borrowers.firstname>> <<borrowers.surname>>,\
> \
> A new suggestion is ready to be processed: <<suggestions.title>> by <<suggestions.author>>.\
> \
> Thank you,\
> \

Without the patch:
656 Thank you,\
With the patch:
656 Thank you,^M\

I am not sure how relevant is this, the UI looks correct.

b) matcher_matchpoints is different:
without:
1 1
2 2
3 3
with:
3 1
3 2
3 3

c) false positive: search_field, search_marc_to_field and search_marc_map
(because of id loaded in a different way), this is coming from:
installer/install.pl:       
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings;
Not related to this patchset.


d) subscription_numberpatterns (to investigate)

1c1
< 1     Number  1       Simple Numbering method No. {X} Number  1       1      
99999   1       \N              \N      \N      \N      \N      \N             
\N      \N      \N      \N      \N
---
> 1	Number	1	Simple Numbering method	No. {X}	Number	1	1	99999	1	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N
3,4c3,4
< 3     Volume, Number  3       Volume Number 1 Vol. {X}, No. {Y}       Volume 
1       12      99999   1       \N      Number  1       1       12      1      
\N              \N      \N      \N      \N      \N
< 4     Seasonal        4       Season Year     {X} {Y} Season  1       1      
3       0       season  Year    1       4       99999   1       \N             
\N      \N      \N      \N      \N
---
> 3	Volume, Number	3	Volume Number 1	Vol. {X}, No. {Y}	Volume	1	12	99999	1	\N	Number	1	1	12	1	\N	\N	\N	\N	\N	\N	\N
> 4	Seasonal	4	Season Year	{X} {Y}	Season	1	1	3	0	season	Year	1	4	99999	1	\N	\N	\N	\N	\N	\N	\N

e) systempreferences (to ignore)
There is an obvious change here on "FrameworksLoaded", the list of sql files is
replaced with a list of yml files.
I did not know this pref existed, it seems to be used to make sure we are not
going to load twice the same files.
We can ignore this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:11:23 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-5Z2T5CIzPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99680|0                           |1
        is obsolete|                            |

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100095&action=edit
Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()

This patch replaces the CGI "http" object method with its equivalent
class method, which doesn't require object instantiation and thus skips
global initialization and premature handling of the incoming HTTP request.

Test plan:
0. Disable Plack if it is enabled
1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1
2. Clear Memcached
3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
4. Note that form below "Upload progress" never appears and errors show
in browser console
5. Apply the patch
6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
7. Note that form appears below "Upload progress"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:12:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:12:00 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-w7GecsAaQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Signed alternate patch, works as described, leaving as 'signed off' to get a
second qa check here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:18:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:18:33 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-Q6fqeAm1OK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100042|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100096&action=edit
Bug 22529: Use new C4::Auth::haspermission from svc/members/search

The svc/members/search script can be used to retrieve patrons with a
specific permission. This feature is only used once, to link patrons to
funds.
The code in the script is duplicated from what we have in
C4::Auth::haspermission, and it makes sense to clean it.

Test plan:
Create a fund and add users to this fund.
When you search for users you must only have a list of patrons with the
acquisition.order_manage permission.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works as described. No errors
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:19:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:19:32 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-Z8wf5EIxsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Took me a short while to wrap my head back around this one.. sorry it's
languished so long..

I'm confident in the change, thanks for taking it on Jonathan.

PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:32:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:32:58 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-pQTX98XoxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #114 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #109)
> (In reply to Tomás Cohen Arazi from comment #98)
> > Created attachment 100014 [details] [review] [review]
> > Bug 23355: Split tests for Line vs Lines
> > 
> > This patch simply splits the existing tests for accountlines into two
> > test files, one for the singular object and one for the set.
> 
> Did we really decided that? I do not see the point to multiplicate the
> number of test files.

When I saw how big the tests file got due to previous additions and having
plural vs. singular classes tests all mixed I thought of filing a bug to split
this myself. I was really happy when I saw Martin did it! LOL

As you say, worth discussing somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:57:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:57:31 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-NoIcf4IOOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:57:33 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-d3M1BRB8sU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100004|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 11:57:52 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-2HvvcZ8Ufg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100097&action=edit
Bug 24540: Prevent add button being triggered on enter

This patch prevents the add button being triggered by hitting return
from inside the collected from patron form input.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:00:25 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-bt3G5xH4iN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:00:27 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-QNHko11WNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99999|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:00:46 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-nEIJxU7aEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100098&action=edit
Bug 24775: Add ID to POS submit payment button

This patch simply adds an ID to the submit button to make it easier to
overide styling and functionality.

Test Plan:
0/ Inspect the element on page and note there is no id
1/ Apply patch
2/ Refresh page
3/ Inspect the element on page and note there is now an id

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:06:00 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-g5tQQ4Kr0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:06:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:06:02 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-ByP6v3KuYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100037|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:06:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:06:30 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-2liBI4quVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100099&action=edit
Bug 24479: Use $Price filters for '0' amounts

This patch adds the use of the $Price TT filter to properly format '0'
amounts in the POS system.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:06:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:06:46 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-ZqIENBgo8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > I am running koha-testing-docker with KOHA_IMAGE=master with
> > docker-compose.yml and docker-compose.mariadb_d9.yml
> 
> I am using docker-compose.mariadb_d10.yml

For the record: Nick is using Debian 9 with mariaDB for Debian 10

Owen, what about you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:06:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:06:50 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-jbH089mSx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:07:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:07:28 +0000
Subject: [Koha-bugs] [Bug 24479] POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-zFrTLH39O5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New POS doesn't follow      |POS doesn't follow
                   |CurrencyFormat              |CurrencyFormat
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:09:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:09:53 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-h4uORAMV67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why do you pass the branchcode's checkout and do not let
renewal_branchcode/OpacRenewalBranch does the job?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:09 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-U3V060wQrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99910|0                           |1
        is obsolete|                            |
  Attachment #99911|0                           |1
        is obsolete|                            |
  Attachment #99912|0                           |1
        is obsolete|                            |
  Attachment #99913|0                           |1
        is obsolete|                            |
  Attachment #99914|0                           |1
        is obsolete|                            |
  Attachment #99915|0                           |1
        is obsolete|                            |
  Attachment #99916|0                           |1
        is obsolete|                            |
  Attachment #99917|0                           |1
        is obsolete|                            |

--- Comment #60 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100100&action=edit
Bug 23112: Add CirculateILL syspref

Sponsored-by: Loughborough University
Signed-off-by: Chris Walton <C.J.Walton at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:13 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-1gf0ZTil2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #61 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100101&action=edit
Bug 23112: Add circulation to ILL requests

This patch adds the ability to circulate ILL requests. Once a request has a
suitable status, a "Check out" button is displayed on the "Manage request"
toolbar. Clicking this will enable the user to check out the item either to the
user who made the request or an in-house statistical  user. A due date can be
specified, but if not circ rules are used.

Prior to the check out, an item is created which is attached to the biblio
record that was created when the request was added

This development has been carried out according to the originally stated
requirements of the customer that sponsored it, detailed here:
https://wiki.koha-community.org/wiki/ILL_Circulation_RFC

Test plan:

1. Ensure the FreeForm ILL backend is available
2. Enable the "CirculateILL" syspref
3. Ensure you have a statistical patron category defined (patron category type
"Statistical")
4. Ensure you have at least one patron in your statistical patron category
5. Create a new FreeForm request (make a note of the library you select when
creating it)
6. Mark the new request as confirmed by clicking the "Confirm request" button
on the "Manage ILL request" page
7. TEST: Observe that a "Check out" button is now displayed in the request
toolbar
8. Click the "Check out" button in the "Manage ILL request" page
9. In the "Issue requested item to..." screen:
  a. Do not select a statistical patron at this time
  b. You can at this point choose an item type, this will determine the type of
the item that will be created for this request
  c. TEST: Observe that the default selected "Library" matches that that was
defined when creating the request
  d. Do not select a due date at this time
10. Click "Submit"
11. TEST: Observe that the "Item checked out" screen displays, issued to the
requesting patron with a due date corresponding to appropriate circ rules
12. Click "Return to request"
13. TEST: Observe that the request's status is now "Checked out"
14. Click the "Bibliographic record ID" link
15. TEST: Observe that the bibliographic record now has one item attached to it
which is checked out
16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID
17. Return to step 5., however, this time select a statistical patron and test
that the item use is recorded and the item is not issued
18. Return to step 5., however, this time manually select a due date and test
that the item's due date is set correctly on check out
19. Check in the item
20. TEST: Observe that the request's status is updated to "Returned to library"
21. Now implement a restriction on the patron (perhaps a fine) which would
prevent them from checking out an item
22. Return to step 5. follow the instructions to step 10.
23. TEST: Observe that a banner is displayed at the top of the screen informing
you that there was a problem checking the item out, containing a link to the
patron's account page
24. Resolve the problem with the patron's account
25. Return to step 8.
26. TEST: Observe that the item is now successfully checked out
27. Disable the "CirculateILL" syspref
28. Return to step 5. at step 7. Observe that the "Check out" button is NOT
displayed

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:16 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-yNrg9jOU6M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #62 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100102&action=edit
Bug 23112: Add permission checks

We only want the ILL circulation functionality to be available if the
appropriate syspref and perm are available, this patch adds those
checks.

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:20 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-6BR48PwE1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #63 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100103&action=edit
Bug 23112: Update request status on return

This patch updates a request's status to RET upon return

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:23 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-88JnigbErt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #64 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100104&action=edit
Bug 23112: Add unit tests

This patch adds unit test for the new Koha::Illrequest::check_out method

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:27 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-HXWVXNILKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #65 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100105&action=edit
Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues

In response to the problem Magnus was experiencing in comment #28 & #29
we now call GetAuthorisedValues by it's full path

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:30 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-oExBSBD4Pk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #66 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100106&action=edit
Bug 23112: (follow-up) Address QA feedback

As per comment #46

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:34 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-EuC3QOVFmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #67 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100107&action=edit
Bug 23112: (follow-up) Fix test as per feedback

As per comment #48

https://bugs.koha-community.org/show_bug.cgi?id=23113

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:11:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:11:37 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-eLt1hcjdJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #68 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100108&action=edit
Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs

Looks like the atomicupdate and sysprefs.sql changes were lost at some point.

Don't forget to run QA tools on your patches before submitting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:13:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:13:09 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-fytJqYiwAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
This all works as expected and is a great enhancement.

I added a follow-up to address a few minor issues.

The one complaint I have is that if I create a 'chapter' request there is no
biblio created but I still get a 'checkout' button on the request, but have no
way to attach/create a biblio - we should not show the button in this case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:21:01 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-NDayGTL2GH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:21:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:21:10 +0000
Subject: [Koha-bugs] [Bug 24768] "Return claims" column is missing from
 column configuration page
In-Reply-To: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24768-70-R8EAuS6jAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24768

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:26:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:26:41 +0000
Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents
 template display
In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23980-70-LqJTrGEcUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:26:44 +0000
Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents
 template display
In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23980-70-x2V8Wj0942@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99567|0                           |1
        is obsolete|                            |
  Attachment #99568|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100109&action=edit
Bug 23980: Revert "Bug 23229: (QA follow-up) Fix indentation"

This reverts commit d4676ff4532f41abec87ba2d1128e3f219d9c920.

https://bugs.koha-community.org/show_bug.cgi?id=23980

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed commit title

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:26:47 +0000
Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents
 template display
In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23980-70-RvnNmocybP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100110&action=edit
Bug 23980: Revert "Bug 23229: Only load ILL table JS when needed"

This reverts commit f95749a66bb5dad53fa2cf00224fc38f52c1e788.

https://bugs.koha-community.org/show_bug.cgi?id=23980

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed commit title, no errors

Revised test plan:
- Do not apply the patch
- View koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
- TEST: Verify that it includes a "jsinclude" block near the bottom of the
template
- Apply the patch
- Re-open the template
- TEST: Verify that the "jsinclude" block is now gone

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:27:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:27:55 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-PLeUsrz0a5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #70 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Thanks for this Nick, it is much appreciated. Many thanks for the follow up, I
do wish my editor would not randomly switch to tabs sometimes! Good point about
the Checkout button, I'll create a follow up shortly and re-submit :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:31:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:31:42 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-pCZH8MtZNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] Date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:31:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:31:42 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-lq70M0CeRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:32:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:32:00 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-4UBkEnkPn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Acquisitions
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:39:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:39:03 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-Dj8ac2iaR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
The question is only whether or not the value returned by the system preference
check is going to trigger the error or not. If the value for AmazonCoverImages
is '', the error will happen. If it's 0 or 1 it won't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:44:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:44:32 +0000
Subject: [Koha-bugs] [Bug 24793] TinyMCE for HTML notices
In-Reply-To: <bug-24793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24793-70-rpEzOcNoA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24793

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think this would be tricky... Bug 24764 for instance, especially with regard
to placeholders and Template Toolkit markup. This interface and the news
interface could probably be improved with a user-selectable choice between
WYSIWYG and CodeMirror.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:45:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:45:29 +0000
Subject: [Koha-bugs] [Bug 24795] Password change  at first login
In-Reply-To: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24795-70-sSxltD7xEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 12:45:49 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-sl0BXaHE2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #14)
> The question is only whether or not the value returned by the system
> preference check is going to trigger the error or not. If the value for
> AmazonCoverImages is '', the error will happen. If it's 0 or 1 it won't.

It's more about fixing this specific error or other possible occurrences where
prefs can be an empty strings (when 0 is expected).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:06:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:06:57 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-JQ42YHvcRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
When I edit I pick 23:59 but 22:59 is saved. Then edit again, save without
modifying anything, 21:59 is saved, and so on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:08:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:08:24 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-DDTTFweaFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If I edit the date and remove the time page, save, it's loading endlessly.
Which means 1. errors are not handled correctly, and 2. date only formatted
dates are not taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:09:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:09:10 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-M21jWmINrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #27)
> If I edit the date and remove the time part, save, it's loading endlessly.
> Which means 1. errors are not handled correctly, and 2. date only formatted
> dates are not taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:15:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:15:20 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-dFNbCYEK6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is something that annoy me with adding such routes.
We have lot of switches in Koha (syspref, permissions) that are not taken into
account with them.

Do we really want to allow anybody with circulate_remaining_permissions to
modify a checkout, and so bypassing sysprefs and circulation rules?

That sounds a bit wrong to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:39:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:39:11 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-LlT70k2ukt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Michal Denar from comment #11)
> Hi,
> I really like this feature. It's works. But itsn't "user friendly". I prefer
> to apply discout directly at "Pay an amount toward all fines" or "Pay an
> individual fine" window. 
> 
> Thank you for opinions.

I agree with you! I tried testing it without reading the test plan (following
my intuition) as I saw your comment. And it felt like:
- Discount could be a percentage as well
- It should be cool to have it (also) on the Make payment flow

Anyway, good job and really clean implementation. I'm happy where the accounts
code is now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:05 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-zLBoA5oiCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:09 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-axPbPRiKYi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100088|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:12 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-c3y9yG3b4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100089|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:15 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-I3o4zj5zmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100087|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:50 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-ZHLn2xiMOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100111&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:55 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-UYyNflESYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100112&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:40:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:40:59 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-WN6uXUvgN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100113&action=edit
Bug 24081: Add discount action to boraccount

This patch adds the ability to apply discounts to existing patron
charges from the boraccount page.

Test plan
1/ Carry out some accounting actions that end up with debts on the
patron record. (Add a manual invoice for example)
2/ Note a new 'Apply discount' action button on the unpaid debt
3/ Paid debts do not display the action button
4/ Click the button
5/ Enter an amount into the resulting modal and click confirm
6/ Confirm that the outstanding debt has been reduced by the amount you
specified.
7/ Confirm that a new 'Discount' line appears on the patrons account
8/ Confirm that in the 'details' view of the debt that the discount line
was used against the debt to create the reduction.
9/ Signoff

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:41:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:41:03 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-3ber1vURZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100114&action=edit
Bug 24081: (QA follow-up) Fix small typo

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:41:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:41:40 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-SS2dlXsjuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:41:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:41:44 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-ymB22ditWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98629|0                           |1
        is obsolete|                            |
  Attachment #98630|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100115&action=edit
Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:42:08 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-PYDz72pP81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100115|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100116&action=edit
Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:42:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:42:16 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-WUQeqT8R9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100117&action=edit
Bug 20936: Add patron's hold history menu in OPAC

This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)

To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
        => Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.

Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.

Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:44:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:44:00 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-bHinz1BUUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
+        [%- IF ( patron.get_age ) %] ([% patron.get_age | html %] years)
+        [%- ELSIF ( patron.age ) %] ([% patron.age | html %] years)[% END -%]

That smells.
You should either test for the type of patron, or pass another variable
  patron_object vs patron
or
  patron vs borrower (that reads wrong but it is what is usually done in
controllers)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:51:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:51:58 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-YooUz5TgE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100118&action=edit
Bug 15400: Clarify usage of patron-age.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:13 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-2xgJfB3rtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:16 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-P0XMqdTztZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99869|0                           |1
        is obsolete|                            |
  Attachment #99870|0                           |1
        is obsolete|                            |
  Attachment #99871|0                           |1
        is obsolete|                            |
  Attachment #99872|0                           |1
        is obsolete|                            |
  Attachment #99873|0                           |1
        is obsolete|                            |
  Attachment #99875|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100119&action=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:35 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-UajT1Lrr0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100120&action=edit
Bug 24455: Add moment library in staff

This patch adds koha-tmpl/intranet-tmpl/lib/moment/moment.min.js in order to
use the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:37 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Bt7225fJhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100121&action=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:40 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-rTcmFJHg6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100122&action=edit
Bug 24455: Add moment-timezone library in staff

This patch adds
koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:43 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Qlw9XxSI8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100123&action=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the a js-date-format.inc file on each opac and staff interface
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:47 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-uKFWc72jCf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100124&action=edit
Bug 24455: [DO NOT PUSH] test timezone

This is just a test.. I added the .inc file to adimn's main page

To test:

1. go to Koha main page and open chrome or firefox console
2. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'America/Argentina/Buenos_Aires'})

   and you should get

   "02/18/2020 09:46"

   because America/Argentina/Buenos_Aires is -03:00

3. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'Asia/Shanghai'})

   and you should get

   "02/18/2020 20:46"

   because Asia/Shanghai is +08:00

4. type

   $datetime('2020-02-18T12:46:05Z')

   and it should be translated to your koha instance configured timezone.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:52:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:52:50 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-UES0vBBWwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100125&action=edit
Bug 24455: Add Moment.js to About page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:53:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:53:54 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-vkX5ICdKUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This generally seems to work.. but I'm no SIP expert and the code is hard to
follow at the best of times.

I would love to see the actually logging statements look more like elsewhere in
Koha... this will be the third form for calling a Koha::Logger based log and is
more confusing by the fact it keeps the 'syslog' name so if someone is keen to
add more statements they may go looking for Sys::Syslog documentation and get
mislead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:55:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:55:02 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-xkt0NQZoHj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #57)
> +        [%- IF ( patron.get_age ) %] ([% patron.get_age | html %] years)
> +        [%- ELSIF ( patron.age ) %] ([% patron.age | html %] years)[% END
> -%]
> 
> That smells.
> You should either test for the type of patron, or pass another variable
>   patron_object vs patron
> or
>   patron vs borrower (that reads wrong but it is what is usually done in
> controllers)

Sorry, I was reading the patch and not the final change. I added a follow-up.

However I still think it's lot of info that could be considered not needed by
some.
Especially in the circ autocomplete.

Letting someone else adding the QA stamp.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:57:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:57:46 +0000
Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter
 features to datatables api wrapper
In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24561-70-WvKM9t4MSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 13:57:49 +0000
Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter
 features to datatables api wrapper
In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24561-70-ZT8ldn3dwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100039|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100126&action=edit
Bug 24561: Datatables api wrapper also filter and order embedded columns

This patch adds the ability to filter and order by embedded columns.

To use it you must in JS:

$('datatable_selector').api({datatables_options})

where datatables_options are all datatables options plus:

1. embed: [list of embeddable tables]
   This option adds x-koha-embed header to request.

2. header_filter: true|false
   This option if true sets x-koha-query header with stringyfied json of
filters

Oderable and searchable columns must define data option as string, otherwise
filter and order won't be possible.
If you must custom the output, use the render function.

For example:

* Don't

> $('.table_selector').api({
>   columns: [
>     {
>       data: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

* Do

> $('.table_selector').api({
>   columns: [
>     {
>       data: 'holds.patron.firstname',
>       render: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

To test you must implement and test bug 20936, where it will be used.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:00:28 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-n2lTXS9pDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #11)
> Should not it be named get_effective_to_email (or something saying we should
> not use it for from)?

Agreed.. I just struggled to come up with a method name and wanted to submit
something ;).

Lets ask in the dev meeting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:05:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-cad8u1R2P8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is not ready at all, diff looks wrong, please double check the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:06:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:06:27 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-BHyec7t86W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
And tests, pretty please.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:14:23 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-oIrgnjxXhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:21:23 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-tj2EaUnp5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945
[Bug 13945] Multiple dialogs for item that needs transferred and hold captured
at checkin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:21:23 +0000
Subject: [Koha-bugs] [Bug 13945] Multiple dialogs for item that needs
 transferred and hold captured at checkin
In-Reply-To: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13945-70-jifrJJqF3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790
[Bug 24790] POS missing from the 'More' dropdown
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:21:32 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-SGpunoQGBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13945                       |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945
[Bug 13945] Multiple dialogs for item that needs transferred and hold captured
at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:21:32 +0000
Subject: [Koha-bugs] [Bug 13945] Multiple dialogs for item that needs
 transferred and hold captured at checkin
In-Reply-To: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13945-70-trl5c5ipIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24790                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790
[Bug 24790] POS missing from the 'More' dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:21:32 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-RMZV5GWuVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790
[Bug 24790] POS missing from the 'More' dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:29:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:29:02 +0000
Subject: [Koha-bugs] [Bug 24799] New: add withdrawn status for issues
Message-ID: <bug-24799-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24799

            Bug ID: 24799
           Summary: add withdrawn status for issues
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mbarham at birzeit.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

add new issue status 'withdrawn'

or even connect it with authorized value, rather than hardcoded.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:29:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:29:27 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-ScmoDbSbgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95557|0                           |1
        is obsolete|                            |

--- Comment #59 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100127&action=edit
Bug 23051: Add RenewAccruingItemWhenPaid syspref

This patch adds the new syspref "RenewAccruingItemWhenPaid"

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:29:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:29:31 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-u5Z5peDjiH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95558|0                           |1
        is obsolete|                            |

--- Comment #60 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100128&action=edit
Bug 23051: Add unit tests

This patch adds unit tests for all modules affected by this bug

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:29:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:29:34 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-U7x5Y27zUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95559|0                           |1
        is obsolete|                            |

--- Comment #61 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100129&action=edit
Bug 23051: Renew items when fines paid off

When the RenewAccruingItemWhenPaid syspref is enabled and all the fines
on an item that is accruing fines are paid, we automatically renew that
item to prevent it from starting to accrue fines again.

This patch adds an additional argument to C4::Circulation::AddRenewal
which allows us to skip the calculation of fines upon renewal, which we
don't want to do if the fines on that item have just been paid. Existing
calls to AddRenewal have not been amended because there seems to be a
convention of only passing undef when adding arguments that require
their positioning to be maintained. Since the new argument is the last
one, this is not the case with any existing call.

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:29:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:29:38 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-n3dZvubAe3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95560|0                           |1
        is obsolete|                            |

--- Comment #62 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100130&action=edit
Bug 23051: Squash of sign off follow-ups

Rebasing was a nightmare, so I'm squashing the sign off follow-ups to
ease the pain with any future rebases

Includes:

Bug 23051: (follow-up) Refactor renewal code
As per Nick's first point in comment #20, the code that tests for
renewability and renews items has been refactored into it's own
function.

Bug 23051: (follow-up) Provide feedback
For renewals that fail when a fine is being paid off, this patch causes
any errors to be passed back to the template for display.
Addresses the second point in Nick's comment #20

Bug 23051: (follow-up) Fix unit tests
As raised by Nick in comment #35

Bug 23051: (follow-up) Fix/improve feedback
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- it would be nice to get feedback on what was successfully renewed as
well
- In general I think I would prefer to see 'ok' and 'not_ok' returned as
a single 'renewal_results' array
- There is no listing of errors if I use the 'pay' button on an
individual fine

Bug 23051: (follow-up) Refactor methods
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I don't really like that the functions are internal functions and then
exported
- I think the pref description should highlight that if
'RenewalPeriodBase'
is set to due date, there may be doubled charges

Bug 23051: (follow-up) Add SIP summary
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- Ideally SIP would get feedback in a screen message

Bug 23051: (follow-up) Renewing in OPAC
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I am also not sure about the code path if a patron paid fines on the
opac (via paypal etc.) but renewals are not allowed on the opac.

We've introduced the syspref RenewAccruingItemInOpac (default is off)
which, when enabled, will cause items attached to fines that are paid
off in the OPAC (via payment plugins), to be automatically renewed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:30:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:30:05 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-AEGYydqwm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #63 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Another monster rebase done. Good lord I hope this one gets into master soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:31:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:31:20 +0000
Subject: [Koha-bugs] [Bug 24800] New: Koha does incomplete checkin when no
 return date is provided
Message-ID: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

            Bug ID: 24800
           Summary: Koha does incomplete checkin when no return date is
                    provided
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com,
                    kyle at bywatersolutions.com,
                    martin.renvoize at ptfs-europe.com

We found that when a checkin is requested by the self check without a return
date, Koha will check the item in, but fails to send a checkin response and
crashes and create inconsistent/invalid data:

- It will remove the issue from the patron account and move to old_issues. BUT:
- the old_issues.returndate will be an invalid date: 0000-00-00
- there is no return recorded in action_logs
- there is no reutrn recorded in statistics
- The reading history will show an empty return date.

We found this in the context of an 'cancel checkout' feature in a lot of
libraries using hardware and software by one of the big international RFID
providers. We identified several 100 of those over a period of 1.5 years.

What happens?
- Self check requests checkout
- Koha responds that item was checked out
- Self check tries to desensitize
- Item has been removed from the self check already!
- Self check requests checkin with cancel flag set to Y and return date empty
- Koha doesn't respond, but dies

This all happens within a second or less.

>From the logs:
Sip::MsgType::_initialize('Checkin',
 'N20200303    151300                  APXXXX|AOXXXX|ABb00000057|ACxxxxxx|BIY',
'CA18A18', '37', ...)
Mar  3 15:13:00 xxxx xxxx[16798]: new ILS::Item('b00000057'): found with title
'Irrlicht und Feuer :'
Mar  3 15:13:00 xxxx xxxx[16798]: raw_transport: shutting down

Note the BIY in the Checkin request.

In some older 3M documentation I found the following explanation about the
cancel functionality:

"Checkin, Message 09
Cancel (Y or N) This field is set to N when a normal checkin of materials is
being requested. This field shoudl be set to Y when a previous Checkout message
failed. It is possible for a checkout command to fail. This problem occurs when
a patron removes the item from the 3M selfCheck system creadle after it has
been checked out by the ACS software but before the item has been desensitized
by the 3M selfCheck system. If this happens, the 3M SelfCheck system would
cancel the Checkout by sending a Checkin message with the cancel field set to
Y. The ACS software can also use this feld process the checkin differently (for
example don't count it in the Checkin statistics and possibly decrement the
Checkout statistics, also) ...

Return date
In current applications this field is not used."

The last bit is strange as other documentation I found clearly list it as a
required field in the Checking message:

Some possible solutions:

1) Deny checkin, keep the item on the account. 
- We don't support cancel checkout.
- The patron might have items on their account, that they have left in the
library.

2) Check-in item and use server time for return date
- The patron might leave with an item not checkout out, especially if the
library has no gates.
- We wil have entries of this happening in like a split second, which will help
diagnose the problem.

3) Implement the cancel checkin
- This would probably be the hardest to do - we'd need to set some kind of flag
that it was a cancelled checkout to indicate that there might have been an
issue on the self check machine (maybe 2) + note in the logs?)

It would be interesting if someone can tell if they also had issues with this
and what they think the best solution would be. Koha SIP2 crashing and making
incomplete database entries doesn't appear the right behaviour atm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:31:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:31:34 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-PZOFaEntgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ulrich.kleiber at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:32:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:32:25 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-H9fDDPP9xB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100127|0                           |1
        is obsolete|                            |
 Attachment #100128|0                           |1
        is obsolete|                            |
 Attachment #100129|0                           |1
        is obsolete|                            |
 Attachment #100130|0                           |1
        is obsolete|                            |

--- Comment #64 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100131&action=edit
Bug 23051: Add RenewAccruingItemWhenPaid syspref

This patch adds the new syspref "RenewAccruingItemWhenPaid"

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:32:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:32:29 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-mB0DoGwynx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #65 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100132&action=edit
Bug 23051: Add unit tests

This patch adds unit tests for all modules affected by this bug

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:32:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:32:32 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-jv4o71yq2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #66 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100133&action=edit
Bug 23051: Renew items when fines paid off

When the RenewAccruingItemWhenPaid syspref is enabled and all the fines
on an item that is accruing fines are paid, we automatically renew that
item to prevent it from starting to accrue fines again.

This patch adds an additional argument to C4::Circulation::AddRenewal
which allows us to skip the calculation of fines upon renewal, which we
don't want to do if the fines on that item have just been paid. Existing
calls to AddRenewal have not been amended because there seems to be a
convention of only passing undef when adding arguments that require
their positioning to be maintained. Since the new argument is the last
one, this is not the case with any existing call.

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:32:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:32:36 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-7jf4O2dmzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #67 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100134&action=edit
Bug 23051: Squash of sign off follow-up

Rebasing was a nightmare, so I'm squashing the sign off follow-ups to
ease the pain with any future rebases

Includes:

Bug 23051: (follow-up) Refactor renewal code
As per Nick's first point in comment #20, the code that tests for
renewability and renews items has been refactored into it's own
function.

Bug 23051: (follow-up) Provide feedback
For renewals that fail when a fine is being paid off, this patch causes
any errors to be passed back to the template for display.
Addresses the second point in Nick's comment #20

Bug 23051: (follow-up) Fix unit tests
As raised by Nick in comment #35

Bug 23051: (follow-up) Fix/improve feedback
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- it would be nice to get feedback on what was successfully renewed as well
- In general I think I would prefer to see 'ok' and 'not_ok' returned as
a single 'renewal_results' array
- There is no listing of errors if I use the 'pay' button on an
individual fine

Bug 23051: (follow-up) Refactor methods
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I don't really like that the functions are internal functions and then
exported
- I think the pref description should highlight that if 'RenewalPeriodBase'
is set to due date, there may be doubled charges

Bug 23051: (follow-up) Add SIP summary
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- Ideally SIP would get feedback in a screen message

Bug 23051: (follow-up) Renewing in OPAC
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I am also not sure about the code path if a patron paid fines on the
opac (via paypal etc.) but renewals are not allowed on the opac.

We've introduced the syspref RenewAccruingItemInOpac (default is off)
which, when enabled, will cause items attached to fines that are paid
off in the OPAC (via payment plugins), to be automatically renewed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:32:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:32:40 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-w1V88Ku30c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #68 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100135&action=edit
Bug 23051: (QA follow-up) Missing curly and tabs and fix test

Some rebase issues, accounttype no longer exists, circ rules make
CanBookBeRenewed fail, so we mock that too

interface must be passed as a hashref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:35:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:35:59 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-2ExXH6wk1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
SIP gives nice feedback, staff client does unless I click 'pay' next to the
individual fine, can you check that one?

I do wonder about write-offs and whether they should also trigger renewal, but
am calling that scope creep

I don't know about the call to 'GetFine' in the renew_item sub, seems an extra
DB hit. I am not sure either - how do you end up with more than one OVERDUE
fine on an item? if from an old checkout that was returned, do we care in this
instance? I may be overthinking - not a blocker, but curious about the
reasoning

Please check my work on rebasing and cleaning in the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:44:52 +0000
Subject: [Koha-bugs] [Bug 24677] [19.11] Wrong year picked in serials
In-Reply-To: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24677-70-o7S1yvm6q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wrong year picked in        |[19.11] Wrong year picked
                   |serials                     |in serials

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:48:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:48:17 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-LneV8O1t5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:49:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:49:28 +0000
Subject: [Koha-bugs] [Bug 24751] REST API: CRUD endpoints for holdings
 records
In-Reply-To: <bug-24751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24751-70-a3QwQveBxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24751

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
This feature has been developed on top of Koha-Finland fork, find development
status and code here https://github.com/KohaSuomi/Koha/pull/159. The work on
Finnish fork was sponsored by the National Library of Finland.

Feel free to rebase it on top of master if you need it. Finnish fork is based
on 17.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:53:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:53:08 +0000
Subject: [Koha-bugs] [Bug 24801] New: selenium/administration_tasks.t
 failing if too many categories displayed
Message-ID: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

            Bug ID: 24801
           Summary: selenium/administration_tasks.t failing if too many
                    categories displayed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/selenium/administration_tasks.t .. 3/3
STRACE: /usr/share/perl5/Try/Tiny.pm:124 in Selenium::Remote::Driver::catch
{...}
        /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm:353 in
Try::Tiny::try
        (eval 1543):1 in Selenium::Remote::Driver::__ANON__
        (eval 1545):2 in Selenium::Remote::Driver::__ANON__
        /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm:1330 in
Selenium::Remote::Driver::_execute_command
        /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm:1330 in (eval)
        /kohadevbox/koha/t/lib/Selenium.pm:174 in
Selenium::Remote::Driver::find_element
        /kohadevbox/koha/t/lib/Selenium.pm:166 in
t::lib::Selenium::click_when_visible
        t/db_dependent/selenium/administration_tasks.t:189 in
t::lib::Selenium::click


SCREENSHOT: https://framapic.org/QV83HpBmIcxN/BAYggoYjgJGi
An element could not be located on the page using the given search parameters:
//div[@class="main container-fluid"]//a[contains(@href,
"/admin/categories.pl?op=delete_confirm&categorycode=PATRON_CAT")],xpath
at/kohadevbox/koha/t/lib/Selenium.pm line 174.
# Looks like your test exited with 255 just after 3.
t/db_dependent/selenium/administration_tasks.t .. Dubious, test returned 255
(wstat 65280, 0xff00)
All 3 subtests passed 

Test Summary Report
-------------------
t/db_dependent/selenium/administration_tasks.t (Wstat: 65280 Tests: 3 Failed:
0)
  Non-zero exit status: 255
Files=1, Tests=3, 61 wallclock secs ( 0.03 usr  0.01 sys +  2.73 cusr  0.29
csys =  3.06 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:26 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-Eh9nZlynqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:28 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-Dd2Gabgx5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:30 +0000
Subject: [Koha-bugs] [Bug 24479] POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-aBgXzyOjct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:31 +0000
Subject: [Koha-bugs] [Bug 24479] POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-8MGCbGQy6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:33 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-to7KJ8TfNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:35 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-kDuFgWHvO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:37 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-u12V6z1SnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:39 +0000
Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on
 library_groups erroneously removes rows
In-Reply-To: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24741-70-KW7AO9CYOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:40 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-hfosC6n70Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:42 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-WHT1X9VttJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:52 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-wmpj00wbSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:54:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:54:55 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-ZNexVusr70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100136&action=edit
Bug 24801: Display all the categories - Selenium fix

To make sure we are going to be able to click on the "Delete" button of
our newly created category PATRON_CAT, we are displaying them all.

Test plan:
Create several patron categories that will fill the first page:

use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
for my $i ( 1..20 ) {
    $builder->build_object({ class => 'Koha::Patron::Categories', value => {
description => "cat_$i" } });
}

Execute the selenium tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:56:36 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-A4taPOHXCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100136|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100137&action=edit
Bug 24801: Display all the categories - Selenium fix

To make sure we are going to be able to click on the "Delete" button of
our newly created category PATRON_CAT, we are displaying them all.

Test plan:
Create several patron categories that will fill the first page:

use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
for my $i ( 1..20 ) {
    $builder->build_object({ class => 'Koha::Patron::Categories', value => {
description => "cat_$i" } });
}

Execute the selenium tests.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:56:59 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-WTSx5byQln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
A clear and positive improvement.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:57:04 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-0zHn8V9Gs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:57:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:57:18 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-NPIt2C0M6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 14:57:19 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-n0PHlk3bvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:07:24 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-34fJbHQS2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:12:32 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-uy5dDDVHwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #70 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100138&action=edit
Bug 23051: (follow-up) Fix renew summary display

As mentioned in comment #69:

>staff client does unless I click 'pay' next to the individual fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:17:41 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-RRqnhx3gdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #71 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
This looks really great Nick, thanks very much for looking at this. It looks
like we were both rebasing the same bug at the same time! :-)

To respond to your comments:

>I don't know about the call to 'GetFine' in the renew_item sub, seems an extra
>DB hit. I am not sure either - how do you end up with more than one OVERDUE fine
>on an item?

It was a while ago, so I'm just speculating, but I suspect I did the call to
GetFine and checked the fine to ensure that the fine had been fully paid off
and no outstanding amount remained. Does that make sense?

Anyway, your rebasing work looks great! Many thanks again for your work on
this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:43:12 +0000
Subject: [Koha-bugs] [Bug 24795] Password change  at first login
In-Reply-To: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24795-70-dyyWT1TtyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #1 from George Williams (NEKLS) <george at nekls.org> ---
This is a really good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:54:42 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-elltT8qCez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
A few remarks:
- Some POD are wrong (koha_object_class for effective_itemtype?)
- You copied and pasted from other API controllers, but kept deprecated things
like _to_model that are not even used
- There's some debugging leftovers
- There are no tests for the controller

Please solve them and re-submit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 15:56:53 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-k92r2eq1gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100139&action=edit
Bug 24593: (followup) fix sql statements

Original inserted values depends on the order of insertion.
This patch rewrites the sql statements to make them order
independent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:04:23 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-XvIrjy8vZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Jonathan, my reply

(In reply to Jonathan Druart from comment #5)
> 1. There are some QA issues:
>  FAIL  
> installer/data/mysql/en/marcflavour/marc21/mandatory/
> authorities_normal_marc21.yml                                               
> 
>    FAIL   yaml_valid                                                        
> YAML Error: Inconsistent indentation level                                  

Yes, I was aware of this, I left notes on the commit messages.
Current QA test uses YAML.pm, it considers as valid this:
---
data:
  - "a b c d"
...
but not this:
---
data:
  - "a b 
     c d"
...
however it is valid :(

The problem arises in some multiline sql_statements. The solution is to put
them as long single lines. It makes readability difficult, but I can do it.
Using YAML::Sick or YAML::XS gives no error, but implies changes in QA tools.
As I said, I can change them if you prefer.


> 
> 2. I did an install 'en' before and after the patchset, I mysqldump --tab to
> generate 2 files per table, then compared the 2 generated directories with
> `diff -r --brief` (and also a `perl -p -i -e "s/.*Dump completed.*//" **/*`
> to remove timestamp of the dump).
> Most of them are wrong diff because of different timestamps, but some of
> them are either weird, or caught issues:
> 
> a) When a row is on several lines, I get, for instance with letter
> "TO_PROCESS":
> 652,657c652,657
> \ suggestions	TO_PROCESS		Notify fund owner	0	A suggestion is ready to be
> processed	Dear <<borrowers.firstname>> <<borrowers.surname>>,
> \ 
> \ A new suggestion is ready to be processed: <<suggestions.title>> by
> <<suggestions.author>>.
> \ 
> \ Thank you,
> \ 
> ---
> > suggestions	TO_PROCESS		Notify fund owner	0	A suggestion is ready to be processed	Dear <<borrowers.firstname>> <<borrowers.surname>>,\
> > \
> > A new suggestion is ready to be processed: <<suggestions.title>> by <<suggestions.author>>.\
> > \
> > Thank you,\
> > \
> 
> Without the patch:
> 656 Thank you,\
> With the patch:
> 656 Thank you,^M\
> 
> I am not sure how relevant is this, the UI looks correct.

Some of the sample notices where clearly generated in Windows, I assume this
because they have '\r\n' for newlines. Some others not.
So I decided to join all multiline fields with both chars. I left a comment on
the last patch of Bug 13897
"'\r\n' is used for correct display in Windows clients."
in the code 
"? join "\r\n", @{$row->{$col}}                # join multiline values"

The diff you see comes from those notices that originally have only '\n' for
newlines.

> 
> b) matcher_matchpoints is different:
> without:
> 1 1
> 2 2
> 3 3
> with:
> 3 1
> 3 2
> 3 3

Yes, my bad. The sql_statements make use of MAX() to insert values, then the
result depends on the order of insertions.
I will add a followup to Bug 24593 to fix the problem.

> 
> d) subscription_numberpatterns (to investigate)
> 
> 1c1
> < 1	Number	1	Simple Numbering method	No. {X}	Number	1	1	99999	1	\N		\N	\N	\N
> \N	\N		\N	\N	\N	\N	\N
> ---
> > 1	Number	1	Simple Numbering method	No. {X}	Number	1	1	99999	1	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N	\N
...
> 

The difference in this case comes from the values of label2 & label3 fields.
In the SQL files some of these fields are NULL, in YAML they can't because they
are translated, and the translate script will fail, so I put on them an empty
string "". I think that this change does not affect the numbered patterns.
If a NULL value is needed, then I must change the translate script
(LangInstaller.pm)


> e) systempreferences (to ignore)
> There is an obvious change here on "FrameworksLoaded", the list of sql files
> is replaced with a list of yml files.
> I did not know this pref existed, it seems to be used to make sure we are
> not going to load twice the same files.
> We can ignore this one.

Ok!

Summary:
1) Can be rewritten to single lines if needed
2a) I think is not a problem
2b) Followup uploaded to Bug 24593
2d) Waiting your opinion

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:13:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:13:31 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-88VR8ynHdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:13:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:13:33 +0000
Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of
 haspermission
In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22529-70-1hdbZ6k2jb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:13:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:13:34 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-P7bKbuiq7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:13:36 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-hUcUWB86dc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:17:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:17:50 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-lSOEjmzgNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100040|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100140&action=edit
Bug 24790: Add POS to the 'More' dropdown on the staff client

This trivial patch adds 'Point of sale' to the dropdown.

To test:
1. Notice there is no 'Point of sale' entry in the staff dropdown
=> FAIL: No dropdown
2. Apply this patch and reload
=> SUCCESS: Point of sale displays and works
3. Play with enabling/disabling the feature and removing permissions
=> SUCCESS: The entry in the dropdown respects the configured
permissions and settings.
4. Sign off :-D

Signed-off-by: George Williams <george at nekls.org>
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:19:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:19:10 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-30WThihIte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Wow, super quick signoff guys, thanks to all for following up and getting this
added before I had a chance to do it and then great teamwork SO..

Passing QA and Pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:19:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:19:26 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-HrAsgSUOEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:19:28 +0000
Subject: [Koha-bugs] [Bug 24790] POS missing from the 'More' dropdown
In-Reply-To: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24790-70-FbBYEEV5Fg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 16:42:07 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-jiB5xkUG8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #68 from Nick Clemens <nick at bywatersolutions.com> ---
Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any fields
in items, either individually or via batch edit - things like 'onloan' and
'itemlost_on' are successfully nulled as they should be.

Two test failures:

#   Failed test 'Syntax check misc/migration_tools/fix_onloan.pl'
#   at /usr/share/perl5/Test/Strict.pm line 423.
# Unmatched right curly bracket at misc/migration_tools/fix_onloan.pl line 20,
at end of line
# syntax error at misc/migration_tools/fix_onloan.pl line 20, near "}"
# misc/migration_tools/fix_onloan.pl had compilation errors.
# Looks like you failed 1 test of 706.


    #   Failed test 'reference if positive itemtype notforloan value'
    #   at t/db_dependent/XSLT.t line 57.
    #                   '<items
xmlns="http://www.koha-community.org/items"><item><homebranch>FwkGdaAK</homebranch><holdingbranch>FwkGdaAK</holdingbranch><location></location><ccode></ccode><status>available</status><itemcallnumber></itemcallnumber><stocknumber></stocknumber></item></items>'
    #     doesn't match '(?^u:<status>reference</status>)'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:07:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:07:09 +0000
Subject: [Koha-bugs] [Bug 24802] New: Updating holds can cause suspensions
 to apply to wrong hold
Message-ID: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

            Bug ID: 24802
           Summary: Updating holds can cause suspensions to apply to wrong
                    hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

On request.pl, the table of holds shows a suspend_until date picker for each
hold, *unless* that hold is waiting or in transit. The script
reserve/modrequest.pl assumes that there will be a suspend_until input for each
hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of
them are waiting or in transit. If you were to then set the suspend until date
on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions
would apply to the 10 found holds and not the holds they should apply to!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:07:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:07:14 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-b87qSso2ag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:11:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:11:04 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-SDfzcSLSC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:11:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:11:06 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-BQ4ThcAUvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100141&action=edit
Bug 24802: Updating holds can cause suspensions to apply to wrong hold

On request.pl, the table of holds shows a suspend_until date picker for each
hold, *unless* that hold is waiting or in transit. The script
reserve/modrequest.pl assumes that there will be a suspend_until input for each
hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of
them are waiting or in transit. If you were to then set the suspend until date
on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions
would apply to the 10 found holds and not the holds they should apply to!

Test Plan:
1) Place two holds on a record
2) Check in an item and trap it for the first hold
3) Now that one hold is waiting and the other is not, attempt to set
   a suspension date using the "Update hold(s)" button
4) Note your hold does not get suspended!
5) Apply this patch
6) Restart all the things!
7) Repeat steps 1-3
8) Your hold should now be suspended!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:15:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:15:29 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-7qAnbcUec7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
QA script fixes awaiting merge, but we wanted to get the rmaints to pull in the
translation js bug first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:35:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 17:35:19 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-PsIvnGbvYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:29:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:29:20 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-0PKhbzRAtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99727|0                           |1
        is obsolete|                            |

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100142&action=edit
Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:35:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:35:55 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-D5Dbf3BLVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:35:58 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-JqeDP9VP5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100143&action=edit
Bug 24798: smart-rules.tt has erroneous comments

This patch corrects a couple of invalid Template Toolkit comments in the
Circulation and Fines rules template.

To test, apply the patch and log into the staff client as an
administrator.

On the Circulation and Fines Rules page "View source" and look for
instances of the text "[#% Default branch %#]" There should be none.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:41:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:41:14 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-jeC8R3Dvpr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:41:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:41:17 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-tENuNC8NSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97298|0                           |1
        is obsolete|                            |
  Attachment #97299|0                           |1
        is obsolete|                            |
  Attachment #97300|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100144&action=edit
Bug 24369: Add AccessControlAllowOrigin syspref

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:41:25 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-BqhAjrWoT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100145&action=edit
Bug 24369: Add CORS support to output_with_http_headers()

This patch adds CORS support to output_with_headers(). It will use the
AccessControlAllowOrigin syspref to pick the value and set the
Access-Control-Allow-Origin header.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Output.t
SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:41:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:41:28 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-xtMkwGGXvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100146&action=edit
Bug 24369: Add CORS support to the API

This patch adds CORS support for API requests. It uses the
AccessControlAllowOrigin syspref. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass!
3. Set the AccessControlAllowOrigin to any string (for example, *)
4. Use any API testing tool (Postman?) to place a request on the API
=> SUCCESS: The response headers include Access-Control-Allow-Origin,
    containing what you set on the syspref
5. Sign off :-D

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:42:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:42:39 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-CzbFfww4ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:42:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:42:42 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-8u7VPk8S5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98921|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100147&action=edit
Bug 24662: Remove global variables MSG_* from datatables.inc

Now that bug 21156 is pushed, we don't need to have global variables in
.inc or .tt files for translation in .js file. We can simply declare our
translatable strings where they are used.

This patch removes all global variables used in DataTables configuration

Test plan:
1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR
4. Go to the staff interface, in english, and check that DataTables
tables are still working. You should check at least the following pages:
    - catalogue/detail.pl
    - circ/circulation.pl
    - tools/quotes.pl
    - tools/letter.pl
5. Switch to french and check again DataTables tables, and verify that
   strings are translated

This patch depends on bug 24661

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested using es-ES or de-DE (build compendium, update, translate, install)
cd misc/translator
msgcat --use-first -o de.po po/de-DE-*.po
./translate update de-DE
msgmerge de.po po/de-DE-messages-js.po -o - | msgattrib --no-obsolete -o
po/de-DE-messages-js.po
./translate install de-DE

DataTables works, and are translated.
There are some messages from qa-tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:43:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:43:36 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-MmENy8HYx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
> QA script fixes awaiting merge, but we wanted to get the rmaints to pull in
> the translation js bug first.

Ok!
It works, so I signed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:50:18 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-i4Qzw9N81y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:50:21 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-taAI3c2jrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97742|0                           |1
        is obsolete|                            |
  Attachment #97743|0                           |1
        is obsolete|                            |
  Attachment #97744|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100148&action=edit
Bug 22615: Add /ill_backends endpoint

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:50:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:50:52 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-fu4ieW5Q5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100149&action=edit
Bug 22615: Add endpoint for getting one ill backend

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:50:55 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-I7rUt9dCTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100150&action=edit
Bug 22615: Fix perlcritic

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:55:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:55:56 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-sxGZU7NDwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Whoops, the "#" turned my CSS into a commented line in the commit message :(

Also my test plan depended on Bug 24746 still existing!

Now to verify the bug you have to look at the page source for a couple of empty
<div>s in the header, right after '</div> <!-- /navbar -->'

<div class="container-fluid">
    <div class="row-fluid">
    </div>
</div>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:57:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 18:57:51 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-w1AvjMAmCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99708|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100151&action=edit
Bug 24745: OPAC news block plugin should evaluate as false if there are no
items

This patch changes the way news is returned from GetNewsToDisplay in
KohaNews.pm so that the template variable will evaluate as false instead
of simply being an empty data structure.

To verify the bug, remove your opacheader news entry and view source on
any page in the OPAC. You should find some empty markup right after
'</div> <!-- /navbar -->'

<div class="container-fluid">
    <div class="row-fluid">
    </div>
</div>

To test the fix, apply the patch and reload the OPAC page. The empty
divs should be gone. Add content to the opacheader news item and confirm
that it displays correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:15:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 19:15:25 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-GoKqRQmxti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:15:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 19:15:28 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-30vZrY1dDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100151|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100152&action=edit
Bug 24745: OPAC news block plugin should evaluate as false if there are no
items

This patch changes the way news is returned from GetNewsToDisplay in
KohaNews.pm so that the template variable will evaluate as false instead
of simply being an empty data structure.

To verify the bug, remove your opacheader news entry and view source on
any page in the OPAC. You should find some empty markup right after
'</div> <!-- /navbar -->'

<div class="container-fluid">
    <div class="row-fluid">
    </div>
</div>

To test the fix, apply the patch and reload the OPAC page. The empty
divs should be gone. Add content to the opacheader news item and confirm
that it displays correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Divs gone, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 19:58:29 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-8hvWkl1goS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:16:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:16:13 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-M3oi7u2k1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:16:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:16:15 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-RFqp2E8Ty7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98019|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100153&action=edit
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:16:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:16:24 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-23N1BL4JIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100154&action=edit
Bug 24492: Update GPL license

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:55:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:55:56 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-DvW3rrFGiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:55:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:55:59 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-xnNDCheg7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100141|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100155&action=edit
Bug 24802: Updating holds can cause suspensions to apply to wrong hold

On request.pl, the table of holds shows a suspend_until date picker for each
hold, *unless* that hold is waiting or in transit. The script
reserve/modrequest.pl assumes that there will be a suspend_until input for each
hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of
them are waiting or in transit. If you were to then set the suspend until date
on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions
would apply to the 10 found holds and not the holds they should apply to!

Test Plan:
1) Place two holds on a record
2) Check in an item and trap it for the first hold
3) Now that one hold is waiting and the other is not, attempt to set
   a suspension date using the "Update hold(s)" button
4) Note your hold does not get suspended!
5) Apply this patch
6) Restart all the things!
7) Repeat steps 1-3
8) Your hold should now be suspended!

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 21:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 20:56:36 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-bkKvu71x8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:08:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 22:08:03 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-0buBg1JWcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #34 from Michal Denar <black23 at gmail.com> ---
Hi Ere,
I get some errors for prove -v t/db_dependent/Koha/Item.t  

  # Looks like you failed 6 tests of 79.
not ok 3 - as_marc_field() tests

ok 5 - move_to_biblio() tests
# Looks like you failed 1 test of 5.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests



Test Summary Report
-------------------
t/db_dependent/Koha/Item.t (Wstat: 256 Tests: 5 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
Files=1, Tests=5,  4 wallclock secs ( 0.03 usr  0.02 sys +  2.70 cusr  0.32
csys =  3.07 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 22:10:26 +0000
Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using
 defined fields is broken under ES
In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23719-70-C9Erk2VPjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|19.11.00                    |19.11.00, 19.05.09
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

thanks for the rebase kidclamp!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:10:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 22:10:35 +0000
Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using
 defined fields is broken under ES
In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23719-70-M3ulP1XJNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:25:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:25:23 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-6ui4pN0ZiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
Is there an easy way to update the uploaded file names? I think that second
patch has lost its "Alternate" flag.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:29:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:29:48 +0000
Subject: [Koha-bugs] [Bug 24803] New: Clicking "Log in to your account"
 throws fatal Javascript error
Message-ID: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

            Bug ID: 24803
           Summary: Clicking "Log in to your account" throws fatal
                    Javascript error
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Clicking "Log in to your account" throws a fatal Javascript error, because the
link has a href of "/cgi-bin/koha/opac-user.pl" and Bootstrap passes the href
to Jquery as if it were a CSS ID selector.

In the past, Jquery didn't throw a fatal error for this mistake, so it was
fine. But now Jquery appears to be stricter with the upgrade to 3.4.1.

This error causes Javascript to fail and could lead to unexpected behaviour. 

(I have an idea for a patch that I'll be trying out very soon.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:30:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:30:14 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-h4KDMw9KIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:33:15 +0000
Subject: [Koha-bugs] [Bug 24804] New: Koha
Message-ID: <bug-24804-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24804

            Bug ID: 24804
           Summary: Koha
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: evaleyva30 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hi!
I´m trying to understand how Khoa works cus I´m trying to understand if it is
possible to used it in some privet company.
I have some questions and I really need to understand this so we can decide if
Koha will work for us.
The first thing I  need to know it´s where I can find the privicy policies.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:34:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:34:32 +0000
Subject: [Koha-bugs] [Bug 24804] Koha
In-Reply-To: <bug-24804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24804-70-YFgbSzwgIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24804

Eva <evaleyva30 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:47:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:47:29 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-fjUdpw3I7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
My first idea is to replace "/cgi-bin/koha/opac-user.pl" with #loginModal (as
per https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp), and that
works (after disabling our Koha click handler for showing/hiding the modal).

But... now I'm wondering if we had the "href" as "/cgi-bin/koha/opac-user.pl"
for a reason. Maybe so the link would still work if Javascript wasn't working?

So I'm going to work on an alternative idea suggested by Jonathan too...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:49:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:49:46 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-YcHrpfRd9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #1)
> So I'm going to work on an alternative idea suggested by Jonathan too...

Oh except the alternative idea won't retain a usable link either... well I
might provide it anyway, and let the community decide which they prefer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:55:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2020 23:55:45 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-J0zY5HrOet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #33 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:01:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:01:23 +0000
Subject: [Koha-bugs] [Bug 23784] Show subtitle,
 number and parts in course reserves list of items in OPAC
In-Reply-To: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23784-70-doFSg9LXjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:04:23 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-5aVEjJ653R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:04:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:04:25 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-C4FKTj001O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Created attachment 100156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100156&action=edit
Bug 24803: Remove JS error by following Bootstrap instructions

This patch patches #lodinModal to Bootstrap's click.modal.data-api event
handler
for the '[data-toggle="modal"] selector, so Bootstrap can handle the
hide/show behaviour of the login modal.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:04:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:04:44 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-cmQbiZpt1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Created attachment 100157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100157&action=edit
Bug 24803: [Alternate patch] bypass Bootstrap click handler by using "#"

This patch bypasses Bootstrap's click.modal.data-api event handler
for the '[data-toggle="modal"] selector by using a "#" as the "href"

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:05:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:05:17 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-dnA9fRJTcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:05:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:05:35 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-6vlYAw7ief@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:07:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:07:15 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
 information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-0IHxooU47l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #30 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:12:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:12:23 +0000
Subject: [Koha-bugs] [Bug 24602] The fallback value for onshelfholds should
 be 0
In-Reply-To: <bug-24602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24602-70-BPoWzIKZic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
not pushed to 19.11.x branch due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:13:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:13:11 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-XGNuvbfoer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
not pushed to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:13:12 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-FjgCIVwW7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
Bug 23355 depends on bug 24482, which changed state.

Bug 24482 Summary: Purchase Items broken by costs containing a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:13:12 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-6PcsHoEESO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519
Bug 24519 depends on bug 24482, which changed state.

Bug 24482 Summary: Purchase Items broken by costs containing a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:13:12 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-WWeAiaAz9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540
Bug 24540 depends on bug 24482, which changed state.

Bug 24482 Summary: Purchase Items broken by costs containing a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:20:07 +0000
Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server
In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23640-70-M0NG5WHyJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #41 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:20:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:20:35 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-A23FcUJfcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #14 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:25:51 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
 to_api
In-Reply-To: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24554-70-6wk4mQBHOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Not pushed to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:25:51 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-dp7IeXFj4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
Bug 20212 depends on bug 24554, which changed state.

Bug 24554 Summary: Only embed relations from Koha::Biblio in to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:26:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:26:21 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-7l7l1eHLrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
not pushed to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:26:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:26:21 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-lAJe4OTVz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
Bug 20212 depends on bug 24366, which changed state.

Bug 24366 Summary: Merging biblioitems should happen in Koha::Biblio->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:26:22 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
 to_api
In-Reply-To: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24554-70-YREth5tDUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
Bug 24554 depends on bug 24366, which changed state.

Bug 24366 Summary: Merging biblioitems should happen in Koha::Biblio->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:27:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:27:55 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-lmB2RqTh7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #66 from Joy Nelson <joy at bywatersolutions.com> ---
I am hesitant to push this to 19.11.x branch as a point release.  This is a fix
to a bug, but seems like a major change for a point release.  I'm not
backporting unless a strong case can be made for it.

<also, my systems team might kill me in my sleep if i snuck this in on a point
release :D >

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:27:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:27:55 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-9hd5JSIciZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642
Bug 24642 depends on bug 13193, which changed state.

Bug 13193 Summary: Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:34:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:34:59 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-IVJH5efivZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:35:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:35:00 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-iJGXav9whk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
Bug 20212 depends on bug 24462, which changed state.

Bug 24462 Summary: Adjust K::A::Invoice API mapping to voted RFC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:36:30 +0000
Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in
 misc/devel/update_dbix_class_files.pl
In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21177-70-ZOGCVMQ84m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:37:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:37:50 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-GHMC9mc2Aa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:37:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:37:54 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-3OxqCcumc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89994|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100158&action=edit
Bug 22969: fix biblionumber on 001 in UNIMARC XSLT

In UNIMARC default configuration the 001 is linked to biblio.biblionumber.
In some XSLT files, 090$a is used.
This is by default biblioitems.biblionumber so it usually works but it may not
be the same and var biblionumber is used to create hyperlinks to record detail
page.

Test plan :
1) Use UNIMARC database
2) Set default in all XSLT system preferences
3) At OPAC, perform a search and click on a result
4) Check displayed page shows the correct biblio record
5) Same at intranet

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on clean UNIMARC install.
Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5"
Added two records, with result:
+--------------+------------------+
| biblionumber | biblioitemnumber |
+--------------+------------------+
|            1 |                5 |
|            2 |                6 |
+--------------+------------------+
Without patch, OPAC results shows for first record
  http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong!
with patch result is correct

Works, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:38:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:38:23 +0000
Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe'
 attribute mapping defeats database constraints
In-Reply-To: <bug-16719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16719-70-8bVzqFmjc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:38:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:38:39 +0000
Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor
In-Reply-To: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13305-70-XhE6aLg6yP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:39:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:39:01 +0000
Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return
 Date
In-Reply-To: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24516-70-iFgdnx19tW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:39:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:39:18 +0000
Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not
 remove all data it created
In-Reply-To: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22860-70-Jxv6V44i41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:39:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:39:32 +0000
Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting
 pickup' tables allowing to print both tables separately
In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11281-70-4dqUIwUOUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:42:48 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-3mnu6klgBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:42:49 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-Sb0DjZuvRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Bug 15522 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:42:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:42:50 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-rHPO5PKbw8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661
Bug 24661 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:42:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:42:51 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-HWrGVAVn8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725
Bug 24725 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:43:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:43:31 +0000
Subject: [Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns
 to suggestions tab in patron account in staff
In-Reply-To: <bug-24585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24585-70-8y048Hz28b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:49:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:49:20 +0000
Subject: [Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a
 hashref in parameters
In-Reply-To: <bug-14711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14711-70-KPBKmSoXP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:50:08 +0000
Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and
 subfields
In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8643-70-cdS9n7bysz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #101 from Joy Nelson <joy at bywatersolutions.com> ---
featurehancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:53:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:53:53 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-ZU2qvQEobl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #73 from Joy Nelson <joy at bywatersolutions.com> ---
Does not apply to 19.11.x branch.  please rebase if needed in 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:54:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:54:28 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-4AgUlWRAPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #23 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:55:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:55:21 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-dXYy1xaN1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement - not pushed to 19.11.x  (see notes on 13193)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:55:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:55:54 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-m4XJQrvtxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100156|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100159&action=edit
Bug 24803: Remove JS error by following Bootstrap instructions

This patch patches #lodinModal to Bootstrap's click.modal.data-api event
handler
for the '[data-toggle="modal"] selector, so Bootstrap can handle the
hide/show behaviour of the login modal.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
JS error verified, and corrected. No qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:56:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:56:22 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-kSvcZfzZ1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #56 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:58:05 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-nCMnLjYkfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:58:09 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-XXQrZOeQTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100157|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100160&action=edit
Bug 24803: [Alternate patch] bypass Bootstrap click handler by using "#"

This patch bypasses Bootstrap's click.modal.data-api event handler
for the '[data-toggle="modal"] selector by using a "#" as the "href"

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
JS error verified, and corrected. No qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:59:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:59:09 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-tjzAnHv4zt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to David Cook from comment #2)
> (In reply to David Cook from comment #1)
> > So I'm going to work on an alternative idea suggested by Jonathan too...
> 
> Oh except the alternative idea won't retain a usable link either... well I
> might provide it anyway, and let the community decide which they prefer.

Both works :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 01:59:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 00:59:17 +0000
Subject: [Koha-bugs] [Bug 24611] Wrong budget_id query parameter in
 /acquisitions/orders
In-Reply-To: <bug-24611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24611-70-AxOWMOkcPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Does not apply to 19.11.x branch.  Please Rebase if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:01:49 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-40aLjo9LA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

--- Comment #67 from David Cook <dcook at prosentient.com.au> ---
(In reply to Joy Nelson from comment #66)
> I am hesitant to push this to 19.11.x branch as a point release.  This is a
> fix to a bug, but seems like a major change for a point release.  I'm not
> backporting unless a strong case can be made for it.
> 

It would be great to get it in since it's a major fix, but I can understand
your reluctance. Would additional testing help? I'd be happy to apply 24642 and
13191 to 19.11.x, build a package, and test an install and an upgrade. 

> <also, my systems team might kill me in my sleep if i snuck this in on a
> point release :D >

Are they using Debian packages? It should automagically work if they are,
although I could see it being a bit fraught if they're not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:02:21 +0000
Subject: [Koha-bugs] [Bug 24592] Clarify LOST_RETURN process by using FOUND
 over RETURNED
In-Reply-To: <bug-24592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24592-70-uOdNOhJ91c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:02:21 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-U36Ug9tghl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
Bug 24474 depends on bug 24592, which changed state.

Bug 24592 Summary: Clarify LOST_RETURN process by using FOUND over RETURNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:03:22 +0000
Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339
 cannot handle high precision seconds
In-Reply-To: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24643-70-S6dCfrEh74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:05:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:05:58 +0000
Subject: [Koha-bugs] [Bug 15352] Use URLLinkText instead of URL for item
 links
In-Reply-To: <bug-15352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15352-70-TW2Pi9xoh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #28 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:06:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:06:55 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-nCpayZ0zTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #21 from Joy Nelson <joy at bywatersolutions.com> ---
not pushed to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:06:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:06:56 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-LgMDcsEnIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662
Bug 24662 depends on bug 24661, which changed state.

Bug 24661 Summary: Inclusion of locale-related javascript files is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:09:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:09:01 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-0xcwJ46HKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x
please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:10:47 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-xlMS5Zbfvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #23 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:10:47 +0000
Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
In-Reply-To: <bug-19384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19384-70-2ynFKYc9aj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384
Bug 19384 depends on bug 22898, which changed state.

Bug 22898 Summary: Selenium tests for placing holds from the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:18:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:18:09 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-DcnaWaZrW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99521|0                           |1
        is obsolete|                            |

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100161&action=edit
Bug 24131: Move the print statement to a new subroutine

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:18:12 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-G1V3GkOokz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99522|0                           |1
        is obsolete|                            |

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100162&action=edit
Bug 24131: Handle several descriptions

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:18:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:18:16 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-HZvpXBVNw8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99523|0                           |1
        is obsolete|                            |

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100163&action=edit
Bug 24131: (follow-up) Fix and rebase

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:18:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:18:20 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-Tu0vsJe4kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99524|0                           |1
        is obsolete|                            |

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100164&action=edit
Bug 24131: (follow-up) Another rebase

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested loading 19.11 database, then running updatedatabase.pl
on cli, or using webinstaller. Looks better on cli :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:22:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:22:06 +0000
Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a <li> tag
In-Reply-To: <bug-24649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24649-70-VxOKnsWgBS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:22:23 +0000
Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show
 correctly in MARC view (OPAC and staff)
In-Reply-To: <bug-13574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13574-70-v03anbsCNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:22:37 +0000
Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with
 ElasticSearch
In-Reply-To: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24506-70-AgY6D2xB22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:23:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:23:06 +0000
Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to
 255 characters
In-Reply-To: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20882-70-wGjmtSA5Zj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:27:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:27:14 +0000
Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_}
In-Reply-To: <bug-23084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23084-70-Zz7bXmERhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #29 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x.  not backporting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:28:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:28:45 +0000
Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js
In-Reply-To: <bug-15850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15850-70-YXytDon63g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x.  not backported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:29:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:29:26 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-CIATepV7Sb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #54 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:31:04 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs of opac detail page
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-PwuCTv6dbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #20 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:31:04 +0000
Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail
 (following 24530)
In-Reply-To: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24617-70-YRFqJyonSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617
Bug 24617 depends on bug 24530, which changed state.

Bug 24530 Summary: Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:35:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:35:34 +0000
Subject: [Koha-bugs] [Bug 24576] `StoreLastBorrower` preference is in the
 wrong tab and is confusing
In-Reply-To: <bug-24576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24576-70-aOOUsrj7ZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24576

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:36:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:36:39 +0000
Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce
 the chance of re-processing very old, already capped, fines.
In-Reply-To: <bug-24651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24651-70-s4LW2GZlxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:37:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:37:12 +0000
Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic
 record on staff client
In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23592-70-gmkcnQcaGx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:38:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:38:06 +0000
Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple
 holds on the same item
In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19718-70-OlO0mgkvNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:39:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:39:47 +0000
Subject: [Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50
 search form
In-Reply-To: <bug-21921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21921-70-bfWFy35ELH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:44:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:44:36 +0000
Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen
 uses the default classification source rather than the item specific source
In-Reply-To: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18499-70-YfHKXizuZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:44:52 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-DDtS6mQboK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:45:06 +0000
Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks
In-Reply-To: <bug-24619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24619-70-z1bu22rkj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:45:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:45:20 +0000
Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC
 editor
In-Reply-To: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24621-70-1NaIp6fplc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:54:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:54:45 +0000
Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b
 on OPAC XSLT
In-Reply-To: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24654-70-eFmY8bdwsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:55:09 +0000
Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL
In-Reply-To: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24640-70-3PKNTQE0UO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:55:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:55:23 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
 escaped characters by template, rendering it invalid
In-Reply-To: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23527-70-gCYbfWA5Kv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:58:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 01:58:31 +0000
Subject: [Koha-bugs] [Bug 24647] PDF::API2::Simple is declared as a required
 dependency but it is not used
In-Reply-To: <bug-24647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24647-70-T9KksU2ENA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x 
cpanfile does not contain the lines indicated to be removed anyways!
not backporting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:00:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 02:00:56 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-u4dxRpJEnc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #68 from Joy Nelson <joy at bywatersolutions.com> ---
David-
I spent some time thinking about this one.  Let me get some input from our
DevOps team here and see what their thoughts are.  We meet tomorrow. My
preference is to push this if I can.  
Thanks!
joy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:00:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 02:00:57 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-zPdCXmS6dC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642
Bug 24642 depends on bug 13193, which changed state.

Bug 13193 Summary: Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:01:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 02:01:55 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-f1NjtKEG4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
Thanks, Bernardo!

I'm curious to see what QA and RM think about the best approach.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:02:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 02:02:56 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-KantRdpHmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

--- Comment #69 from David Cook <dcook at prosentient.com.au> ---
(In reply to Joy Nelson from comment #68)
> David-
> I spent some time thinking about this one.  Let me get some input from our
> DevOps team here and see what their thoughts are.  We meet tomorrow. My
> preference is to push this if I can.  
> Thanks!
> joy

Awesome! Thanks, Joy! The library that brought me to this issue originally is
moving on to 19.11 soon, so fingers crossed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 07:17:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 06:17:49 +0000
Subject: [Koha-bugs] [Bug 24805] New: Provide easier plugin configuration
 method via YAML pref file
Message-ID: <bug-24805-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24805

            Bug ID: 24805
           Summary: Provide easier plugin configuration method via YAML
                    pref file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Plugin architecture
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

Currently, if a plugin has configurable settings, the plugin author implements
the "configure" method, adds a TT template and handles all that, which is quite
complex.

In addition to that method, there should be a way to make easier plugin
configs:

If there is a "configure.pref" file in the plugin, use that in the same way we
use *.pref files for making system preferences, so the plugin author doesn't
need to implement anything else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 07:30:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 06:30:21 +0000
Subject: [Koha-bugs] [Bug 24370] Editing Purchase Suggestion changes the
 Acquisition Library
In-Reply-To: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24370-70-yyGzKgrS4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 07:50:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 06:50:57 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-jIx14DFqxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this be master in the version?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 08:50:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 07:50:41 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-vN0SQtfS1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96563|0                           |1
        is obsolete|                            |

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100165&action=edit
Bug 23531: fix ILSDI non-implemented but documented parameters

test plan :
1/ Submit a hold through ILSDI with start_date and expiry_date parameters
2/ Verify in Koha those parameters are not applied to the newly created
reserve. Delete reserve.
3/ Apply patch and repeat 1.
4/ Verify the reserve created by same request as 1 now has both dates
applied and visible in Koha.

Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com>

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 08:53:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 07:53:35 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-TPbnovriM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi David,
I've rebased the patch on master so patch should apply now.
I've also renamed the parameters according to comment 5 from Katrin.
The functionality works for real but not the automated tests, I'll check it out
with a colleague today, probably it's just me not being good at writing tests
scripts (ILSDI_Service.t)
Kr,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:20:36 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-n72OtCSzWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96564|0                           |1
        is obsolete|                            |

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100166&action=edit
Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:22:12 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-mBTkNbBFhT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi David,
tests are now green thanks to Julian :)
patch ready for testing!
(was previously signed off by christophe)
have a nice one,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:30:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:30:27 +0000
Subject: [Koha-bugs] [Bug 24806] New: Syspref ILLOpacbackends can not be
 disbled
Message-ID: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

            Bug ID: 24806
           Summary: Syspref ILLOpacbackends can not be disbled
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hans.palsson at hkr.se

The syspref ILLOpacbackends allows admin to choose which ILL-backends that
should be available to the user in the OPAC. However, there is no way of _not_
having any backends, even the syspref is described as "If left empty, all
installed backends will be enabled".

A syspref should not behave like this, if the field is left empty no backends
should be available in the OPAC (?).
An alternative solution is to set another syspref that enables/disables use of
ILL in OPAC. Libraries that do not allow ordering of ILL from the OPAC must be
able to hide this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:30:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:30:59 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-MVNEU4DAZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:31:04 +0000
Subject: [Koha-bugs] [Bug 23487] Utf8mb4 collation causes problems with
 missing tables when upgrading the database
In-Reply-To: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23487-70-r4TtpZax5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:34:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:34:38 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-RagjmvYXXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
> An alternative solution is to set another syspref that enables/disables use of > ILL in OPAC.

This sounds like the cleanest way to do it to me. Then you could hide all
traces of ILL in the OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:41:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:41:48 +0000
Subject: [Koha-bugs] [Bug 23487] Utf8mb4 collation causes problems with
 missing tables when upgrading the database
In-Reply-To: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23487-70-5gFiUaWcFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:54:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:54:20 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-Ev1tzA1lWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #165 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100167&action=edit
Bug 23354: (RM follow-up) Correction for cash register selection

The form element for selectin cash register override at point of sale was
misnamed and as such one could not actually override the cash register.

This patch corrects the form element name and updates the logic very
slighlty to ensure we still fall back to the defualt no the subsequent
page load.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:55:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 08:55:07 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-ZNepdDvVuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Joy Nelson from comment #17)
> does not apply to 19.11.x
> please rebase if needed

This patchset fixes the _evaRule sub which was added in Bug 21520. Looking into
code I think that in 19.11.x series this bug exist also, but the patch need to
be rework because of refactoring made in Bug 21520.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:07:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:07:14 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-4YZrIaL92G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #35 from Ere Maijala <ere.maijala at helsinki.fi> ---
Mike,

I can't reproduce. Can you provide more insight on which tests failed? And is
it an empty database or does it have existing data?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:14:11 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-DVnVLNoetR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98249|0                           |1
        is obsolete|                            |

--- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 100168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100168&action=edit
Bug 24552: Be compatible with Search::Elasticsearch 6.00

There is no need to specify the `client` param here because
'5_0::Direct' is the default value for Search::Elasticsearch 5.x and it
breaks when Search::Elasticsearch 6.x is installed

Test plan:
1. Apply the patch
2. Make sure you have Search::Elasticsearch 5.x
3. Reload starman
4. Verify that search works
5. Install Search::Elasticsearch 6.x
6. Reload starman
7. Verify that search works

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:14:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:14:59 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-OeXUAJhKXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

--- Comment #2 from Hans Pålsson <hans.palsson at hkr.se> ---
Just to make clear, this is to not allow patrons to make ILL requests from the
OPAC. Patrons should still be able to see their ILL-loans "as usual" when
logged in the OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:30:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:30:14 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-cnMPcPwNuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:30:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:30:17 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-u5wjBxtQo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #71 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100169&action=edit
Bug 23051: (follow-up) Conditionally prevent checkout

As mentioned by Nick in comment #69, the checkout button displays even
for requests without a biblio attached (such as chapters). This patch
fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:36:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:36:36 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-wPEZPDYEq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:40:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 09:40:55 +0000
Subject: [Koha-bugs] [Bug 24807] New: Add "year" type to improve sorting by
 publication date
Message-ID: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

            Bug ID: 24807
           Summary: Add "year" type to improve sorting by publication date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

When sorting on date-of-publication (a year, field 008, positions 7-10), the
current behavior when the field contains an invalid year (containing word
characters like "uuuu" or just whitespace), these results appear first when
sorting in descending order. Invalid values like these should really not be
indexed at all. If so (having null values instead) they will always appear last
when sorting, regardless of sort order. This fix adds a "year" search field
type, that will reject any non-year values, resulting in a more user friendly
sorting behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:01:40 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-IJSA6CaMHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it would be nice if we had both options - totally disable and only
disable adding new.

Maybe a multi-select pref or one with 3 possible values in the drop down?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:05:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:05:39 +0000
Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by
 publication date
In-Reply-To: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24807-70-2lvf6pODWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100170&action=edit
Bug 24807: Add "year" type to improve sorting behaviour

Add a "year" search field type. Fields with this type will only
retain values that looks like years, so invalid values such as
whitespace or word characters will not be indexed.
This for instance improves the behaviour when sorting by
"date-of-publication". If all values are indexed, records with
junk data instead of valid years will appear first among the search
results, drowing out relevant hits. If assigning this field the
"year" type these records will instead always appear last,
regarless of sort order.

To test:

1) Have at least two biblios, one with a valid year in 008 (pos 7-10)
and another with an invalid one ("uuuu" for example)
2) Perform a wildcard search (*) and sort results by publication date.
3) The record with invalid year of pulication in 008 should appear first
4) Apply patch and run database updates
5) Reindex ElasticSearch
6) Perform the same search as in 2)
7) The record with the invalid year should now appear last

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:06:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:06:44 +0000
Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by
 publication date
In-Reply-To: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24807-70-1GKSP6Zhdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100170|0                           |1
        is obsolete|                            |

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100171&action=edit
Bug 24807: Add "year" type to improve sorting behaviour

Add a "year" search field type. Fields with this type will only
retain values that looks like years, so invalid values such as
whitespace or word characters will not be indexed.
This for instance improves the behaviour when sorting by
"date-of-publication". If all values are indexed, records with
junk data instead of valid years will appear first among the search
results, drowning out more relevant hits. If assigning this field
the "year" type these records will instead always appear last,
regarless of sort order.

To test:

1) Have at least two biblios, one with a valid year in 008 (pos 7-10)
and another with an invalid one ("uuuu" for example)
2) Perform a wildcard search (*) and sort results by publication date.
3) The record with invalid year of pulication in 008 should appear first
4) Apply patch and run database updates
5) Reindex ElasticSearch
6) Perform the same search as in 2)
7) The record with the invalid year should now appear last

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:25:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:25:14 +0000
Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by
 publication date
In-Reply-To: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24807-70-ioueBIw5LY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:28:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:28:31 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-Q7aQ4Cqx4P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:28:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:28:34 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-DpHPSqqQ35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #72 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100172&action=edit
Bug 23051: (follow-up) Remove call to GetFines

As mentioned by Nick in comment #69 and subsequently discussed on Slack,
the call to GetFines in renew_item was unnececcesary. It has now been
removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:31:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:31:13 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-bF58xS2VET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #24 from David Nind <david at davidnind.com> ---
Notes from testing:

- Step 5 of the test plan: message should be "itemAlreadyOnLoan", not
"NotHoldable"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:34:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:34:00 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-vryaxXV7O4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100091|0                           |1
        is obsolete|                            |

--- Comment #25 from David Nind <david at davidnind.com> ---
Created attachment 100173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100173&action=edit
Bug 22806: CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "itemAlreadyOnLoan"

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:34:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:34:04 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-ZwM81xPpRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100092|0                           |1
        is obsolete|                            |

--- Comment #26 from David Nind <david at davidnind.com> ---
Created attachment 100174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100174&action=edit
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

As CanBookBeReserved() was failing as $patron and and $biblio were not
instantiated I fixed that up.

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

Sponsored-By: Catalyst IT
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:34:08 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-DtewqpDtaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100093|0                           |1
        is obsolete|                            |

--- Comment #27 from David Nind <david at davidnind.com> ---
Created attachment 100175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100175&action=edit
Bug 22806: Unit Tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:36:19 +0000
Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by
 publication date
In-Reply-To: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24807-70-R5eUP3jsOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100176&action=edit
Bug 24807: Add database update script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:37:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:37:23 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-J72tXzoBVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

--- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Thanks for this Jonathan.

I guess that then raises the question of whether that logic should go in the
route controller? Or whether there should be a centralised location (probably
the route spec), which would enable the creator to specify all the conditions
that must be met before the route can be accessed. I guess extending what
x-koha-authorization does.

Having it in the controller feels haphazard and prone to omission, having it a
required part of the route spec would be better. But how you would go about
defining a way for any arbitrary logic to be specified in a json file would
need some thought.

Anyway, it feels like this is a question that's bigger than just the addition
of this route, do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:50:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:50:29 +0000
Subject: [Koha-bugs] [Bug 24808] New: Untranslatable strings in results.js
Message-ID: <bug-24808-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808

            Bug ID: 24808
           Summary: Untranslatable strings in results.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Untranslatable "No cover image available" twice in
koha-tmpl/intranet-tmpl/prog/js/pages/results.js:

$(this).parent().html('<span class="no-image">No cover image
available</span>');

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:53:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:53:21 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-FBCoIuI9A5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from David Nind <david at davidnind.com> ---
Thanjs for fixing the database update.

Two things from testing:

1) After applying the patch this text appears on the Z39.50/SRU servers
administration page, and the header row for the table is repeated:

Z39.50/SRU servers administration
<<<<<<< f7630d746947b82b40098be4cbac266e4a494553 ======= >>>>>>> Bug11361 -
opac z3950 search <<<<<<< f7630d746947b82b40098be4cbac266e4a494553 =======
>>>>>>> Bug11361 - opac z3950 search <<<<<<<
f7630d746947b82b40098be4cbac266e4a494553 ======= >>>>>>> Bug11361 - opac z3950
search <<<<<<< f7630d746947b82b40098be4cbac266e4a494553 ======= >>>>>>>
Bug11361 - opac z3950 search <<<<<<< f7630d746947b82b40098be4cbac266e4a494553
======= >>>>>>> Bug11361 - opac z3950 search <<<<<<<
f7630d746947b82b40098be4cbac266e4a494553 ======= >>>>>>> Bug11361 - opac z3950
search

2) On the search results when you click on the "Show" link it comes up as "this
page cannot be reached" in the main browser window for the URL
http://cgi-bin/koha/opac-detail.pl?biblionumber=  (MARC and Card links work
fine as pop-ups in the Z39.50 search results window).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:53:47 +0000
Subject: [Koha-bugs] [Bug 24809] New: OAI PMH can fail on fetching deleted
 records
Message-ID: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

            Bug ID: 24809
           Summary: OAI PMH can fail on fetching deleted records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When calling GetRecord if we pass a deleted biblionumber that has a deleted
item we can end up thinking a record that is deleted is not deleted and so fail
on getting the record

The problem is here:
 48             UNION
 49             SELECT timestamp from deleteditems
 50             WHERE biblionumber=?

If you delete an item from a record, then delete the record, the first query
gets a timestamp and then attempts to get the record as if it is not deleted


To recreate:
1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml
2 - Set sysprefs:
  OAI-PMH => Enable
  OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml
3 - View a record with items and confirm the items show:
 
http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4
4 - Delete the items, then delete the record
5 - Reload the URL from step 3
6 - Internal Server Error:
    Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58.
 at /usr/share/perl/5.24/Carp.pm line 167

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:59:48 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-qFNSrB1vcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 10:59:51 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-EreOZj2KPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100143|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100177&action=edit
Bug 24798: smart-rules.tt has erroneous comments

This patch corrects a couple of invalid Template Toolkit comments in the
Circulation and Fines rules template.

To test, apply the patch and log into the staff client as an
administrator.

On the Circulation and Fines Rules page "View source" and look for
instances of the text "[#% Default branch %#]" There should be none.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:01:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:01:58 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-msVLjaQrso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:02:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:02:00 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-GCrBDoEQrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100178&action=edit
Bug 24809: Get only timestamp of deleted items attached to existing bibs when
check if bib deleted

To test:
 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml
 2 - Set sysprefs:
  OAI-PMH => Enable
  OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml
 3 - View a record with items and confirm the items show:
 
http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4
 4 - Delete the items, then delete the record
 5 - Reload the URL from step 3
 6 - Internal Server Error:
  Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58.
    at /usr/share/perl/5.24/Carp.pm line 167
 7 - Apply patch
 8 - restart_all
 9 - Repeat
10 - Reload URL from step 3
11 - Success

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:04:31 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-ivzhidlym3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Authentication              |Architecture, internals,
                   |                            |and plumbing
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:06:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:06:02 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-YLkCCNCp1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #6)

> Summary:
> 1) Can be rewritten to single lines if needed

Nope, that makes sense!

> 2a) I think is not a problem

If I am not wrong, the ^W appeared *with* the patches.

> 2b) Followup uploaded to Bug 24593

Thanks!

> 2d) Waiting your opinion

How big would it be to allow NULL for translated value? If it can be a quick
fix I guess it's better to have it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:29:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:29:07 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-XeQUNSBct7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:29:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:29:10 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-gUoIJFKqH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100168|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100179&action=edit
Bug 24552: Be compatible with Search::Elasticsearch 6.00

There is no need to specify the `client` param here because
'5_0::Direct' is the default value for Search::Elasticsearch 5.x and it
breaks when Search::Elasticsearch 6.x is installed

Test plan:
1. Apply the patch
2. Make sure you have Search::Elasticsearch 5.x
3. Reload starman
4. Verify that search works
5. Install Search::Elasticsearch 6.x
6. Reload starman
7. Verify that search works

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:59:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:59:33 +0000
Subject: [Koha-bugs] [Bug 24810] New: French SQL files for "news" contain
 "Welcome into Koha 3!"
Message-ID: <bug-24810-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810

            Bug ID: 24810
           Summary: French SQL files for "news" contain "Welcome into Koha
                    3!"
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

installer/data/mysql/fr-CA/facultatif/sample_news.sql
installer/data/mysql/fr-FR/2-Optionel/sample_news.sql

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 11:59:41 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-v39w85iA7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #26)

Hi Jonathan

> When I edit I pick 23:59 but 22:59 is saved. Then edit again, save without
> modifying anything, 21:59 is saved, and so on.

I can't replicate this. So, you're selecting a date, default time is 23:59, but
when you save, 22:59 is saved? Is that the value sent by the API call, or the
value that's returned by the API? As I say, I can't replicate this, it works
fine for me.

> If I edit the date and remove the time page, save, it's loading endlessly.
> Which means 1. errors are not handled correctly, and 2. date only formatted
> dates are not taken into account.

The "loading endlessly" is actually the JS falling over because the call to
DateTime_from_syspref is failing because DateTime_from_syspref doesn't check
what it's got before trying to split it. So it splits the received string by "
", then tries to split the second part of that by ":" which of course fails
because the second part is null.

Having considered this for a while, I'm not clear of the best way forward, it
potentially opens a can of worms. We could say that DateTime_from_syspref
should validate what it's got before working with it, and if it fails
validation, it should error. We have date validation with accompanying errors
in the form of calendar.inc's validate_date, so it would be reasonable to say
we need similar time validation. However, if we're doing that, should we not be
adding that to the upcoming moment.js work in Bug 24455 since that uses
moment.js for date formatting, it should probably be leveraging moment.js' date
& time validation. But if we do that with the time component, should we not
also switch the date validation that's currently in calendar.inc to using
moment.js.

Maybe I'm overcomplicating, but that was my thought process. I don't want to
just put a hack in, but at the same time, doing it "properly" could be a pain
in the ass.

Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:00:12 +0000
Subject: [Koha-bugs] [Bug 24810] French SQL files for "news" contain
 "Welcome into Koha 3!"
In-Reply-To: <bug-24810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24810-70-HNxoC6wUfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"Bienvenue dans Koha 3, la toute nouvelle version du système intégré de gestion
de bibliothèque (SIGB) open source de référence"

The brand new version of Koha! yeah...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:00:25 +0000
Subject: [Koha-bugs] [Bug 24810] French SQL files for "news" contain
 "Welcome into Koha 3!"
In-Reply-To: <bug-24810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24810-70-DxMFAm8X1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:02:21 +0000
Subject: [Koha-bugs] [Bug 24811] New: French SQL files for "news" contain
 broken link to the wiki
Message-ID: <bug-24811-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24811

            Bug ID: 24811
           Summary: French SQL files for "news" contain broken link to the
                    wiki
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

installer/data/mysql/fr-CA/facultatif/sample_news.sql
installer/data/mysql/fr-FR/2-Optionel/sample_news.sql

http://wiki.koha-community.org/doku.php?id=en:development:git_usage returns 404

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:02:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:02:25 +0000
Subject: [Koha-bugs] [Bug 24811] French SQL files for "news" contain broken
 link to the wiki
In-Reply-To: <bug-24811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24811-70-Zi5VXyTtvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24811

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:03:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:03:52 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-VLKtbB2i9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100180&action=edit
Bug 19014: [19.11.x] Prevent auto_renew notices form sending if too early to
renew

Bug 19014: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 19014: Return auto_too_soon before on_reserve

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 19014: on_reserve blocks auto_renew

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:19:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:19:21 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-gKQ6gaJgRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100095|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100181&action=edit
Bug 24719: [Alternate PATCH] Remove use of CGI object in
C4::Context::set_remote_address()

This patch replaces the CGI "http" object method with its equivalent
class method, which doesn't require object instantiation and thus skips
global initialization and premature handling of the incoming HTTP request.

Test plan:
0. Disable Plack if it is enabled
1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1
2. Clear Memcached
3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
4. Note that form below "Upload progress" never appears and errors show
in browser console
5. Apply the patch
6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
7. Note that form appears below "Upload progress"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:13 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-O0RqtdCTvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:16 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-WbmjEqIie3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100131|0                           |1
        is obsolete|                            |

--- Comment #73 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100182&action=edit
Bug 23051: Add RenewAccruingItemWhenPaid syspref

This patch adds the new syspref "RenewAccruingItemWhenPaid"

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:19 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-TUeADawSJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100132|0                           |1
        is obsolete|                            |

--- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100183&action=edit
Bug 23051: Add unit tests

This patch adds unit tests for all modules affected by this bug

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:23 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-YdPR1dyFx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100133|0                           |1
        is obsolete|                            |

--- Comment #75 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100184&action=edit
Bug 23051: Renew items when fines paid off

When the RenewAccruingItemWhenPaid syspref is enabled and all the fines
on an item that is accruing fines are paid, we automatically renew that
item to prevent it from starting to accrue fines again.

This patch adds an additional argument to C4::Circulation::AddRenewal
which allows us to skip the calculation of fines upon renewal, which we
don't want to do if the fines on that item have just been paid. Existing
calls to AddRenewal have not been amended because there seems to be a
convention of only passing undef when adding arguments that require
their positioning to be maintained. Since the new argument is the last
one, this is not the case with any existing call.

Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:26 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-vIdYEMD8gn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100185&action=edit
Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and
test

Rebasing was a nightmare, so I'm squashing the sign off follow-ups to
ease the pain with any future rebases

Includes:

Bug 23051: (follow-up) Refactor renewal code
As per Nick's first point in comment #20, the code that tests for
renewability and renews items has been refactored into it's own
function.

Bug 23051: (follow-up) Provide feedback
For renewals that fail when a fine is being paid off, this patch causes
any errors to be passed back to the template for display.
Addresses the second point in Nick's comment #20

Bug 23051: (follow-up) Fix unit tests
As raised by Nick in comment #35

Bug 23051: (follow-up) Fix/improve feedback
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- it would be nice to get feedback on what was successfully renewed as well
- In general I think I would prefer to see 'ok' and 'not_ok' returned as
a single 'renewal_results' array
- There is no listing of errors if I use the 'pay' button on an
individual fine

Bug 23051: (follow-up) Refactor methods
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I don't really like that the functions are internal functions and then
exported
- I think the pref description should highlight that if 'RenewalPeriodBase'
is set to due date, there may be doubled charges

Bug 23051: (follow-up) Add SIP summary
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- Ideally SIP would get feedback in a screen message

Bug 23051: (follow-up) Renewing in OPAC
This follow up patch addresses the following parts of Nick's feedback in
comment #35:
- I am also not sure about the code path if a patron paid fines on the
opac (via paypal etc.) but renewals are not allowed on the opac.

We've introduced the syspref RenewAccruingItemInOpac (default is off)
which, when enabled, will cause items attached to fines that are paid
off in the OPAC (via payment plugins), to be automatically renewed.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:30 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-G3ZibxPdWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100135|0                           |1
        is obsolete|                            |

--- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100186&action=edit
Bug 23051: (QA follow-up) Missing curly and tabs and fix test

Some rebase issues, accounttype no longer exists, circ rules make
CanBookBeRenewed fail, so we mock that too

interface must be passed as a hashref

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:33 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-NxU2qagqxv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100138|0                           |1
        is obsolete|                            |

--- Comment #78 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100187&action=edit
Bug 23051: (follow-up) Fix renew summary display

As mentioned in comment #69:

>staff client does unless I click 'pay' next to the individual fine

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:47:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:47:37 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-NJxNRm9aqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100172|0                           |1
        is obsolete|                            |

--- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100188&action=edit
Bug 23051: (follow-up) Remove call to GetFines

As mentioned by Nick in comment #69 and subsequently discussed on Slack,
the call to GetFines in renew_item was unnececcesary. It has now been
removed.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:55:35 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-rHoLkD2yLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #80 from Nick Clemens <nick at bywatersolutions.com> ---
OPAC renewals not tested (i don't have the plugins) but are syspref controlled
and should work similarly - passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:55:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:55:55 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-BTpxYqu5os@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100153|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100189&action=edit
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:55:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:55:58 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-feSWpxEKTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100154|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100190&action=edit
Bug 24492: Update GPL license

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:56:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 12:56:30 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-XxZOYpXooP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just a last rebase before pushing :).. Thanks for testing guys

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:12 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-9bY91y31Qg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:14 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-Pq4y3OdXcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:15 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-8KROjALdpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:18 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-QyyHw8C8Ip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:19 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-M65J9ShHMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:21 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-Nd5mnbXp8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:23 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-K242HK6cTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:06:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:06:25 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-bU98fnr5nR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:08:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:08:07 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-Pc2MFC0QH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:08:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:08:10 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-LFM6FsQQo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100191&action=edit
Bug 24803: [Alternate] Clicking "Log in to your account" throws fatal
Javascript error

This patch removes the "data-toggle" attribute from the login link in
order to avoid a JavaScript error. Since we have a custom click handler
to trigger the modal we don't need Bootstrap's "automatic" modal
handling.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:19:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:19:14 +0000
Subject: [Koha-bugs] [Bug 24812] New: Add permission for 'discount' process
Message-ID: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

            Bug ID: 24812
           Summary: Add permission for 'discount' process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: black23 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:20:15 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24252-70-gYGPmLOhM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:20:15 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24255-70-rT19LjSAGF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255
Bug 24255 depends on bug 24252, which changed state.

Bug 24252 Summary: Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:20:30 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24255-70-WDgSlEYjzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:20:31 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-JZSDdRZkU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
Bug 23442 depends on bug 24255, which changed state.

Bug 24255 Summary: Add totals methods Koha::Account::Lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:00 +0000
Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client
In-Reply-To: <bug-23013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23013-70-jSG4txzSaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:01 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-t4EW0kMWLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493
Bug 23493 depends on bug 23013, which changed state.

Bug 23013 Summary: Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:01 +0000
Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents
 view
In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24093-70-4TYi9FMg3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093
Bug 24093 depends on bug 23013, which changed state.

Bug 23013 Summary: Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:01 +0000
Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting
 the search results are missing
In-Reply-To: <bug-24169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24169-70-ki3XS0Wmld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169
Bug 24169 depends on bug 23013, which changed state.

Bug 23013 Summary: Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:17 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-VcT6Q3DUx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com
         Depends on|                            |24081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
[Bug 24081] Add a 'discount' process to accounts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:17 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-A4GidgD1a9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24812


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812
[Bug 24812] Add permission for 'discount' process
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:29 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-CGHhlHHxPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:21:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:21:29 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-NnAWVIPPIC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
Bug 23355 depends on bug 24477, which changed state.

Bug 24477 Summary: No permissions check for POS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:23:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:23:31 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-q2Xz5VYY78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

--- Comment #1 from Michal Denar <black23 at gmail.com> ---
If staff can make discount from payment, we need to give permission for it.
Because it's similar process as write-off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:25:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:25:44 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-UU5BvC9ucF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:25:46 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-0fXTDXSCrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99382|0                           |1
        is obsolete|                            |

--- Comment #15 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100192&action=edit
Bug 22774: New systempreferences for suggestions

Test plan:
1- Apply this patch
2- Run updatedatabase.pl
3- By default you may have max. 3 suggestions in last 30 days.
4- Go to purchase suggestion page from OPAC
5- If you exceed limits of suggestions in step 3 you will not able to add new
suggestions.
6- If you want to change the limits go to systempreferences and change 
MaxTotalSuggestions and NumberOfSuggestionDays parameters.
7- Test again from step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:30:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:30:28 +0000
Subject: [Koha-bugs] [Bug 24804] Koha
In-Reply-To: <bug-24804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24804-70-VV9SgGk99H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24804

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:36:29 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-eNIhhwomYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100192|0                           |1
        is obsolete|                            |

--- Comment #16 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100193&action=edit
Bug 22774: New systempreferences for suggestions

Test plan:
1- Apply this patch
2- Run updatedatabase.pl
3- By default you may have max. 3 suggestions in last 30 days.
4- Go to purchase suggestion page from OPAC
5- If you exceed limits of suggestions in step 3 you will not able to add new
suggestions.
6- If you want to change the limits go to systempreferences and change 
MaxTotalSuggestions and NumberOfSuggestionDays parameters.
7- Test again from step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:45:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:45:05 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-Rg1WL5mdpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:46:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:46:05 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-j0U03cjKlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100134|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:54:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:54:24 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-K6dkRY0s8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100194&action=edit
Bug 24262: (followup) admit null values on labels

This patch adds handling of null values on translatable
labels.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:56:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 13:56:08 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-VAeNKTLq97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100195&action=edit
Bug 24583: (followup) restore null values to labels

This patch adds null values to selected label2/3 in
sample numberpatterns

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:12:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:12:13 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-IojzGx71ZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Bernardo Gonzalez Kriegel from comment #6)
> 
> > Summary:
> > 1) Can be rewritten to single lines if needed
> 
> Nope, that makes sense!

Ok

> 
> > 2a) I think is not a problem
> 
> If I am not wrong, the ^W appeared *with* the patches.

You mean ^M?
Look for example the RENEWAL letter in your dump without patch.
It's a little notice with at least 4 ^M

In sample_notices.sql you can see that the first letter, ODUE, has '\n' for
newlines; the second one, ACQCLAIM, has '\r\n' for the same.
I need to use only one, and '\r\n' works for win/linux

> 
> > 2b) Followup uploaded to Bug 24593
> 
> Thanks!
> 
> > 2d) Waiting your opinion
> 
> How big would it be to allow NULL for translated value? If it can be a quick
> fix I guess it's better to have it.

Not a big problem :)
Followup added to Bug 24262 to skip null values
and followup added to Bug 24583 to restore nulls in labels

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:18:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:18:13 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-pord6YoFl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100196&action=edit
Bug 24492: (RM follow-up) Redirect to correct page after cashup

Cashup of a single register was resulting in a redirect to the register
details page. It should return to the branch details page instead.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:26:22 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-V9cTG7bInm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Did you test this Michal?

The original patchset was meant to add such a permission..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:28:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:28:39 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-iPTkgEufs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Aha.. I see.. the UI piece for actually setting the permission got lost in a
rebase!

Patch coming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:36:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:36:35 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-r8Gk2QPC4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100197&action=edit
Bug 24812: (bug 24081 follow-up) Add permission description

Bug 24081 added a discount permission to the accounts system but during
subsequent rebases, the description of that new permission got lot.

This patch restores the description.

Test plan
0/ Check that a checkbox without a description appears in the 'Manage
patrons patrons fines and fees' section of the 'Set permissions' page.
1/ Apply the patch
2/ Reload the page and note that the checkbox now preceeds a suitable
description.
3/ Signoff.

Bonus points: Check the permission works as described and hides the
'Discount' action button for staff who do not have the permission
enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:41:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:41:11 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-9cyc9YuQ1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:41:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:41:15 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-nmV4VodDRm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:51:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 14:51:11 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-N97cC39GrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Isherwood from comment #29)
> (In reply to Jonathan Druart from comment #26)
> 
> Hi Jonathan
> 
> > When I edit I pick 23:59 but 22:59 is saved. Then edit again, save without
> > modifying anything, 21:59 is saved, and so on.
> 
> I can't replicate this. So, you're selecting a date, default time is 23:59,
> but when you save, 22:59 is saved? Is that the value sent by the API call,
> or the value that's returned by the API? As I say, I can't replicate this,
> it works fine for me.

This is sent when I pick 23:59
{"date_due":"2020-03-18T22:59:00.000Z"}

My host and the server do not have the same timezone, that's why I see
something different.
What your patch does (and so the JS lib from bug 24455 I guess) is the expected
behavior, in an ideal world.
But it cannot be the only place in Koha where it works like that.
If such behavior is really needed, we need to redesign how we store and display
date/datetime.

> > If I edit the date and remove the time page, save, it's loading endlessly.
> > Which means 1. errors are not handled correctly, and 2. date only formatted
> > dates are not taken into account.
> 
> The "loading endlessly" is actually the JS falling over because the call to
> DateTime_from_syspref is failing because DateTime_from_syspref doesn't check
> what it's got before trying to split it. So it splits the received string by
> " ", then tries to split the second part of that by ":" which of course
> fails because the second part is null.
> 
> Having considered this for a while, I'm not clear of the best way forward,
> it potentially opens a can of worms. We could say that DateTime_from_syspref
> should validate what it's got before working with it, and if it fails
> validation, it should error. We have date validation with accompanying
> errors in the form of calendar.inc's validate_date, so it would be
> reasonable to say we need similar time validation. However, if we're doing
> that, should we not be adding that to the upcoming moment.js work in Bug
> 24455 since that uses moment.js for date formatting, it should probably be
> leveraging moment.js' date & time validation. But if we do that with the
> time component, should we not also switch the date validation that's
> currently in calendar.inc to using moment.js.
> 
> Maybe I'm overcomplicating, but that was my thought process. I don't want to
> just put a hack in, but at the same time, doing it "properly" could be a
> pain in the ass.
> 
> Any thoughts?

Looks like a quick change to DateTime_from_syspref could do the trick.
If the time part does not exist then add it with "23:59".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:00:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:00:15 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-I2dRtzj3HP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #31 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
OK, if we can assume the time should be 23:59, then I agree :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:03:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:03:25 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-dKu9ycApoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:03:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:03:27 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-WCWXRJdbaN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100197|0                           |1
        is obsolete|                            |

--- Comment #5 from Michal Denar <black23 at gmail.com> ---
Created attachment 100198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100198&action=edit
Bug 24812: (bug 24081 follow-up) Add permission description

Bug 24081 added a discount permission to the accounts system but during
subsequent rebases, the description of that new permission got lot.

This patch restores the description.

Test plan
0/ Check that a checkbox without a description appears in the 'Manage
patrons patrons fines and fees' section of the 'Set permissions' page.
1/ Apply the patch
2/ Reload the page and note that the checkbox now preceeds a suitable
description.
3/ Signoff.

Bonus points: Check the permission works as described and hides the
'Discount' action button for staff who do not have the permission
enabled.

Nice work.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:04:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:04:15 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be
 useful to see on OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-lD8XFNGBl8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:04:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:04:17 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be
 useful to see on OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-HE3GCYiZjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #6 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100199&action=edit
Bug 13547: Item field 3 (Materials specified) would be useful to see on OPAC

Test plan:
1- View a record with Materials specified (field 3) data in the opac
2- Apply patch
3- Log in to staff client
4- Home->Administration->Column Settings->OPAC->holdingst
5- Set item_materials visibility
6- Refresh OPAC page
7- Confirm that the materials specified column has been added after the Call
number column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:07:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:07:05 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-fsuZ5mnLFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:26:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:26:35 +0000
Subject: [Koha-bugs] [Bug 24813] New: api/v1/holds.t is failing randomly
Message-ID: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

            Bug ID: 24813
           Summary: api/v1/holds.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/api/v1/holds.t .. 3/8
    #   Failed test 'Hold suspension created'
    #   at t/db_dependent/api/v1/holds.t line 400.
    #          got: '400'
    #     expected: '201'

    #   Failed test 'Hold is suspended'
    #   at t/db_dependent/api/v1/holds.t line 405.

    #   Failed test 'Hold is suspended'
    #   at t/db_dependent/api/v1/holds.t line 418.

    #   Failed test 'Hold suspension has correct end date'
    #   at t/db_dependent/api/v1/holds.t line 419.
    #          got: undef
    #     expected: '2020-03-05'

    #   Failed test 'Hold suspension created'
    #   at t/db_dependent/api/v1/holds.t line 435.
    #          got: '400'
    #     expected: '201'

    #   Failed test 'exact match for JSON Pointer "/end_date"'
    #   at t/db_dependent/api/v1/holds.t line 435.
    #          got: undef
    #     expected: '2020-03-10'

    #   Failed test 'The Location header is set'
    #   at t/db_dependent/api/v1/holds.t line 435.
    #          got: undef
    #     expected: '/api/v1/holds/287/suspension'
    # Looks like you failed 7 tests of 24.
t/db_dependent/api/v1/holds.t .. 7/8 
#   Failed test 'suspend and resume tests'
#   at t/db_dependent/api/v1/holds.t line 464.
t/db_dependent/api/v1/holds.t .. 8/8 # Looks like you failed 1 test of 8.
t/db_dependent/api/v1/holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:26:46 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-G3AryQvD4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |22206
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206
[Bug 22206] Add routes to enable suspension or resumption of holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:26:46 +0000
Subject: [Koha-bugs] [Bug 22206] Add routes to enable suspension or
 resumption of holds
In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22206-70-zAVyTgyBtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24813


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
[Bug 24813] api/v1/holds.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:33:39 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-JCBnHHsnli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:33:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:33:42 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-GTrKKxUPlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100200&action=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly

Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
 90     if ( $self->is_found ) {    # We can't suspend found holds

So when TestBuilder generate a hold with found=W the test fail.

A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:35:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:35:12 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-V4qOSLF9q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100200|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100201&action=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly

Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
 90     if ( $self->is_found ) {    # We can't suspend found holds

So when TestBuilder generate a hold with found=W the test fail.

A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:37:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:37:47 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-K52Wr1i8kA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:41:08 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-PN5YlNJiBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:43:19 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
 Shelving Location,
 then deleting the same course reverts Course Reserve Values
In-Reply-To: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24772-70-809Rpk1tVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Hannah Olsen <holsen at duncanville.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |holsen at duncanville.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:53:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 15:53:33 +0000
Subject: [Koha-bugs] [Bug 24814] New: HTML forms set a minimal width for
 dropdown combo with empty set.
Message-ID: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

            Bug ID: 24814
           Summary: HTML forms set a minimal width for dropdown combo with
                    empty set.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

If there's no item, dropdown message "No matches found" is hard to read.

Affect:
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

To test:
- Select a catalogue notice in Koha intranet.
- Open add item form.
- Choose a dropdown combo with an empty set, 'j - Shelving control number' is a
good candidate.
- Apply the patch.
- Re select the compo in open add item form.


It's a bandaid, a proper solution would be to compute container width on actuel
message size.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:02:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:02:35 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-f1yFowQr49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

--- Comment #1 from didier <didier.gautheron at biblibre.com> ---
Created attachment 100202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100202&action=edit
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set.

If there's no item, dropdown message "No matches found" is hard to read.

Affect:
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

To test:
- Select a catalogue notice in Koha intranet.
- Open add item form.
- Choose a dropdown combo with an empty set, 'j - Shelving control number' is a
good candidate.
- Apply the patch.
- Re select the compo in open add item form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:05:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:05:31 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-2MbdeUkQVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:09:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:09:16 +0000
Subject: [Koha-bugs] [Bug 24815] New: Koha::Cash::Register relations should
 return sets not undef
Message-ID: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

            Bug ID: 24815
           Summary: Koha::Cash::Register relations should return sets not
                    undef
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The cash register class contains a bad pattern of returning 'undef' for
relations instead of an empty resultset.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:09:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:09:37 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-Gzw2woQn2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:09:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:09:37 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23321-70-yUhvfQCjkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
[Bug 24815] Koha::Cash::Register relations should return sets not undef
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:13:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:13:14 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-thu40eOAA8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100203&action=edit
Bug 24815: Correct return values of Koha::Cash::Register relations

This patch correct all cases of return undef to instead return an empty
resultset.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:13:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:13:56 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-zdPGG9Y3Es@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:13:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:13:56 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-uuxA1b3jGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
[Bug 24815] Koha::Cash::Register relations should return sets not undef
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:55:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:55:49 +0000
Subject: [Koha-bugs] [Bug 24816] New: Test suite execution time
Message-ID: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

            Bug ID: 24816
           Summary: Test suite execution time
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Quick note, from Jenkins:
D8 -  Took 38 min on Docker_1
D9 -  Took 53 min on Docker_1

That needs to be investigated, and recreated in a proper benchmarking env.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:56:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:56:18 +0000
Subject: [Koha-bugs] [Bug 24816] Test suite execution time
In-Reply-To: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24816-70-z1fjunXLIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:58:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 16:58:24 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-dhlOdEbAOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I will double check tomorrow but I think the following one is not correct:

@@ -86,7 +84,6 @@ sub last_cashup {
         { order_by => { '-desc' => [ 'timestamp', 'id' ] }, rows => 1 }
     )->single;

-    return unless $rs;
     return Koha::Cash::Register::Action->_new_from_dbic($rs);
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:06:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 17:06:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-jBrm07tW3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #18 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #16)
> And tests, pretty please.

How can I refuse if you ask so nicely XD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:06:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 17:06:14 +0000
Subject: [Koha-bugs] [Bug 24816] Test suite execution time
In-Reply-To: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24816-70-Ymo7XtoOtL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It is for sure because of our dependencies madness (i.e. things like OAuth
don't currently work unless you cpan CryptX) and the same must be happening to
other libs that make tests skip.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:06:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 17:06:50 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-lJYdS1bigS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #19 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Tomás Cohen Arazi from comment #17)
> A few remarks:
> - Some POD are wrong (koha_object_class for effective_itemtype?)
> - You copied and pasted from other API controllers, but kept deprecated
> things like _to_model that are not even used
> - There's some debugging leftovers
> - There are no tests for the controller
> 
> Please solve them and re-submit

I was too eager to get this going.. I'll attend them ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:14:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:14:59 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-4bWviLi6H2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a new
      release notes|                            |'branch details' page to
                   |                            |the POS system which
                   |                            |displays a summary of the
                   |                            |cash register transactions
                   |                            |for a branch since each
                   |                            |register was last cashed
                   |                            |up. It also allows for
                   |                            |cashing up individual
                   |                            |registers or cashing up all
                   |                            |registers at a given branch
                   |                            |in one transaction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:26:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:26:34 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-IIZmfP2jt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #14 from David Nind <david at davidnind.com> ---
Sorry Arthur, patch no longer applies!

Applying: Bug 23531: fix ILSDI non-implemented but documented parameters
Using index info to reconstruct a base tree...
M       C4/ILSDI/Services.pm
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
M       opac/ilsdi.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/ilsdi.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Auto-merging C4/ILSDI/Services.pm
CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23531: fix ILSDI non-implemented but documented
parameters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:33:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:33:20 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-Im30fMXJ9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:33:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:33:22 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-PJGXZ8kg0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100201|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 100204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100204&action=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly

Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
 90     if ( $self->is_found ) {    # We can't suspend found holds

So when TestBuilder generate a hold with found=W the test fail.

A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:34:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:34:16 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-WvCLIqwx8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
For me, the tests passed both before and after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:53:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 18:53:46 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-7ZWh6Ojev3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> I will double check tomorrow but I think the following one is not correct:
> 
> @@ -86,7 +84,6 @@ sub last_cashup {
>          { order_by => { '-desc' => [ 'timestamp', 'id' ] }, rows => 1 }
>      )->single;
>  
> -    return unless $rs;
>      return Koha::Cash::Register::Action->_new_from_dbic($rs);
>  }

You are right. We return undef on the singular case

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 19:09:23 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
 Shelving Location,
 then deleting the same course reverts Course Reserve Values
In-Reply-To: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24772-70-TKsVVOnEPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #1 from Hannah Olsen <holsen at duncanville.com> ---
At my library we use Course Reserves regularly to manage our displays so that
we can change the shelving location and have it change back automatically. We
found the bug while trying to figure out why things that had been on display
weren't moving back to their original shelving locations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:28:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 19:28:44 +0000
Subject: [Koha-bugs] [Bug 19676] Debian 9 vs. Plack vs. /tmp -- attention to
 PrivateTmp for apache2
In-Reply-To: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19676-70-FdPm15Vnlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676

John Sterbenz <jsterben at umich.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsterben at umich.edu

--- Comment #4 from John Sterbenz <jsterben at umich.edu> ---
I second this big thanks.

An OS upgrade to ubuntu 18.04 (koha 18.11) started a problem in which staging
MARC records for load would upload the file but then cause failure after
options were set and "Stage for import" was clicked ("Failed to submit form:
error").  Bug 15032 seemed like the right place to start--it wasn't.  Someone
graciously pointed me here and this appears to be the fix I needed (with
Philippe's directory modification).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:38:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 20:38:05 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-wzjKuucwBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sowder at andrews.edu

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 12731 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:38:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 20:38:05 +0000
Subject: [Koha-bugs] [Bug 12731] Mulitiple setspecs that use the same MARC
 tag only work for the first setspec
In-Reply-To: <bug-12731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12731-70-flGdjMJzOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12731

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---


*** This bug has been marked as a duplicate of bug 24531 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:42:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 20:42:22 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-gwIRibH7h9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:46:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 20:46:54 +0000
Subject: [Koha-bugs] [Bug 21970] Scan and Go functionality
In-Reply-To: <bug-21970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21970-70-0kk8OCTQR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21970

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:58:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 20:58:20 +0000
Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of
 records and check 001 uniqueness on save to batch
In-Reply-To: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19266-70-RUkZa5RXKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:48:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 21:48:06 +0000
Subject: [Koha-bugs] [Bug 22182] Advanced editor - Rancor - Create item
 record
In-Reply-To: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22182-70-aknOlyczBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:35:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 22:35:54 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-I2ifXZWAE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 22:35:58 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-l7uKiQuVMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100116|0                           |1
        is obsolete|                            |
 Attachment #100117|0                           |1
        is obsolete|                            |

--- Comment #20 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100205&action=edit
Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:36:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 22:36:03 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-xZ3d0Mynnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #21 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100206&action=edit
Bug 20936: Add patron's hold history menu in OPAC

This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)

To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
        => Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.

Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.

Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:36:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 22:36:08 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-zY0QFCEHnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #22 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100207&action=edit
Bug 20936: Add test

Add test to /api/v1/public/patrons/:patron_id/holds endpoint

To test:
1. prove t/db_dependent/api/v1/patrons_holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:33:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:33:59 +0000
Subject: [Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref
In-Reply-To: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22622-70-0Gg7cuwWgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Does not apply, seems easy to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:37:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:37:46 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-ckY3hotIG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
Interesting approach! I was surprised you didn't handle it at the reverse proxy
level, but interesting to allow libraries to configure their own header.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:41:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:41:16 +0000
Subject: [Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory
 for js files
In-Reply-To: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24734-70-LiRnWV7Oyx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:42:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:42:10 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-SxSabzGUmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
Correction-
Pushed to 19.11.x branch for 19.11.04

Thanks martin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:42:11 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-sgLyjY47MK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Bug 15522 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:42:12 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-C7hloR28ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725
Bug 24725 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:42:12 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-9eWgGRY3qA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661
Bug 24661 depends on bug 21156, which changed state.

Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:44:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:44:27 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-Cd6lhNXNNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|RESOLVED                    |REOPENED

--- Comment #22 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:44:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:44:28 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-XCWe1IY94H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662
Bug 24662 depends on bug 24661, which changed state.

Bug 24661 Summary: Inclusion of locale-related javascript files is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:46:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:46:09 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-m0qfx9I7m6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100191|0                           |1
        is obsolete|                            |

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
Created attachment 100208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100208&action=edit
Bug 24803: [Alternate] Clicking "Log in to your account" throws fatal
Javascript error

This patch removes the "data-toggle" attribute from the login link in
order to avoid a JavaScript error. Since we have a custom click handler
to trigger the modal we don't need Bootstrap's "automatic" modal
handling.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:47:52 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-3aW8u6TpcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
Nice one, Owen. 

I think I prefer Owen's patch best, since it keeps a usable link.

But will leave it up to QA/RM.

(Also, as Jonathan noted on koha-devel, GoogleOpenIDConnect will be affected by
the same issue, so whatever approach we choose here should be applied there as
well.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:52:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:52:12 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-kbCcRLzGZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

--- Comment #70 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:52:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:52:47 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-DZUFYX9M1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:55:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:55:36 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-zYXkJZqsp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #12)
> Interesting approach! I was surprised you didn't handle it at the reverse
> proxy level, but interesting to allow libraries to configure their own
> header.

On small shops, it's easier to just carry the config from the DB and use stock
configurations for the rest of the stack. Power to the users!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 00:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2020 23:55:48 +0000
Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin
 choose which letter codes to keep
In-Reply-To: <bug-21214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21214-70-k8vBQ8I3Cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, there is a problem in the code

->  243     my $quoted_codes = '';
    244     if ($letter_codes) {
    245         my @codes = map { "'$_'" } split(',', $letter_codes);
->  246         my $quoted_codes = join(',', @codes);
    247     }

Two "my $quoted_codes", in lines 243 and 246.
$quoted_codes passed to execute will always be empty.
Remove the second 'my'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 01:38:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 00:38:18 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-5Rv8mKjHTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #13)
> 
> On small shops, it's easier to just carry the config from the DB and use
> stock configurations for the rest of the stack. Power to the users!

Yeah it's interesting! Honestly, the more time goes by, the more carrying
config from the DB makes sense. Much easier than trying to mess with a bunch of
files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 01:46:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 00:46:55 +0000
Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does
 not lift restrictions caused by long overdues
In-Reply-To: <bug-24413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24413-70-8abW0N0TKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 01:47:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 00:47:10 +0000
Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue
 should be removed when the offending item is returned
In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16882-70-5qWOlBVvef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 01:54:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 00:54:20 +0000
Subject: [Koha-bugs] [Bug 24677] [19.11] Wrong year picked in serials
In-Reply-To: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24677-70-mRAzG1yLmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.11.04
        released in|                            |
             Status|Passed QA                   |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 07:57:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 06:57:30 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-tndSyGxkH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 07:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 06:57:33 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-pU53JvrcP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100209&action=edit
Bug 24803: [PASSED_QA] Clicking "Log in to your account" throws fatal
Javascript error

This patch removes the "data-toggle" attribute from the login link in
order to avoid a JavaScript error. Since we have a custom click handler
to trigger the modal we don't need Bootstrap's "automatic" modal
handling.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

Signed-off-by: David Cook <dcook at prosentient.com.au>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 07:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 06:57:55 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-41Ktgy5jRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
 Attachment #100208|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 07:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 06:58:42 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-ARMmKs5Hxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
RM: I prefer Owen's patch too, marked as PASSED_QA. If you agree, obsolete the
other two.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 07:58:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 06:58:56 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-ibb5WnKPEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:18:12 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-1TiNHvSAcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:18:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:18:15 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-h3TJLTZOc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100204|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100210&action=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly

Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
 90     if ( $self->is_found ) {    # We can't suspend found holds

So when TestBuilder generate a hold with found=W the test fail.

A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:18:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:18:26 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-wQQQOsGRJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:18:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:18:57 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-hiFEtyGzPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:33:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:33:38 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-5RV6hpg53n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> Test plan:
> 0. Disable Plack if it is enabled

I am having the impression that this bug has nothing to do with Plack. It is
about creating another CGI object that "steals the upload".

> 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl

See debian/templates/apache-shared-intranet-plack.conf
ProxyPass "/cgi-bin/koha/tools/stage-marc-import.pl" "!"
This script does not even function under Plack, it is handled by Apache!

But it is clear to me that preventing the CGI->new call and calling http as a
class method resolves the situation. So passing QA on the second patch. Note
that the first patch does the same thing, but lets keep that shuffling of env
vars in the module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:35:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:35:12 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-7RrlemhJ5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:35:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:35:15 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-2oFuuXLRBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100211&action=edit
Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()

This patch replaces the CGI "http" object method with its equivalent
class method, which doesn't require object instantiation and thus skips
global initialization and premature handling of the incoming HTTP request.

Test plan:
0. Disable Plack if it is enabled
1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1
2. Clear Memcached
3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
4. Note that form below "Upload progress" never appears and errors show
in browser console
5. Apply the patch
6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
7. Note that form appears below "Upload progress"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
See comment18 on Bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:35:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:35:57 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-F44fCUE8vS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99594|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:35:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:35:59 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-o8Z5vnT0wt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100181|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:36:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:36:12 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-2l9Yt4jB0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:44:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:44:01 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-9NZrgksaWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:44:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:44:04 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-Yoznk0uIKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100177|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100212&action=edit
Bug 24798: smart-rules.tt has erroneous comments

This patch corrects a couple of invalid Template Toolkit comments in the
Circulation and Fines rules template.

To test, apply the patch and log into the staff client as an
administrator.

On the Circulation and Fines Rules page "View source" and look for
instances of the text "[#% Default branch %#]" There should be none.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT] There is a theoretical difference between [% # and [%#. The latter
marks the whole directive as a comment and not just until EOL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:44:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:44:15 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-UcXNJ8yeAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:47:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:47:59 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-2n0S2zmbZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:48:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:48:02 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-MvIbofMQa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100158|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100213&action=edit
Bug 22969: fix biblionumber on 001 in UNIMARC XSLT

In UNIMARC default configuration the 001 is linked to biblio.biblionumber.
In some XSLT files, 090$a is used.
This is by default biblioitems.biblionumber so it usually works but it may not
be the same and var biblionumber is used to create hyperlinks to record detail
page.

Test plan :
1) Use UNIMARC database
2) Set default in all XSLT system preferences
3) At OPAC, perform a search and click on a result
4) Check displayed page shows the correct biblio record
5) Same at intranet

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on clean UNIMARC install.
Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5"
Added two records, with result:
+--------------+------------------+
| biblionumber | biblioitemnumber |
+--------------+------------------+
|            1 |                5 |
|            2 |                6 |
+--------------+------------------+
Without patch, OPAC results shows for first record
  http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong!
with patch result is correct

Works, no errors

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:48:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:48:12 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-c8FlypLEy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:52:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 07:52:09 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-CtPmh6GSUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi David,
last patch i can see on master is 22816, is it the same on your side?...
I use gitlab as my remote : https://gitlab.com/koha-community/Koha
I guess I'm doing smthg wrong but can't figure out what.
I'll try to check around with my colleagues.
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:07:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:07:14 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-64W49jmLO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:20:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:20:50 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-T2CdK3XUyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|BLOCKED                     |Failed QA

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The title of this report and the code changes in C4::Reserves do not match. I
expect changes in ISLDI and I see them in C4::Reserves themselves. Please
explain.

Since you change code in Reserves, it amazes me too to see only tests in a
ILSDI script. What about Holds.t and Reserves.t ?

If this is not only about ILSDI, the title is misleading?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:22:31 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-ngLX9nGpdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:23:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:23:35 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-sqgoV47JH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at outlook.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #2 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100214&action=edit
Bug 19475: Don't copy holiday if it already exists in target calendar

Calendars copy tool created duplicate values to database.
Holidays in target calendar weren't checked before
inserting new holidays. This patch fixes this.

To test:
1. Add holidays for branch A
2. Copy branch A calendar to branch B
3. Repeat copy to branch B
=> Check database, branch B has now duplicate holidays
4. Delete holidays from branches A and B
5. Apply patch
6. Repeat steps 1-3
=> Check database, no duplicates

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:25:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:25:30 +0000
Subject: [Koha-bugs] [Bug 24817] New: Add sleep calls to
 Koha::Cash::Register test
Message-ID: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

            Bug ID: 24817
           Summary: Add sleep calls to Koha::Cash::Register test
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: martin.renvoize at ptfs-europe.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The tests can run at sub-second speeds, but add_cashup and
outstanding_accountlines expect as this is a human interaction upon a cash
register then we cannot end up with overlapping actions.

We cannot use Time::Fake here as the timestamps are being added at the database
trigger level.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:29:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:29:14 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-gDD6EMEggF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100215&action=edit
Bug 24817: Add sleep between db create actions

We need to allow some time to pass between calls that add cash register
lines to accountlines or cash_register_actions. We use database level
triggers to maintain the timestamp fields, so cannot use Time::Fake, and
the methods we are testing assume that, as human interactions, there
will be at least a second between the last 'sale' on a cash register and
the 'cashup' of that same cash register.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:30:07 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-8cxN4mBeYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:34:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:34:22 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-IUr6aRu8OR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:34:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:34:24 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-TdWTwtfXFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100155|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100216&action=edit
Bug 24802: Updating holds can cause suspensions to apply to wrong hold

On request.pl, the table of holds shows a suspend_until date picker for each
hold, *unless* that hold is waiting or in transit. The script
reserve/modrequest.pl assumes that there will be a suspend_until input for each
hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of
them are waiting or in transit. If you were to then set the suspend until date
on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions
would apply to the 10 found holds and not the holds they should apply to!

Test Plan:
1) Place two holds on a record
2) Check in an item and trap it for the first hold
3) Now that one hold is waiting and the other is not, attempt to set
   a suspension date using the "Update hold(s)" button
4) Note your hold does not get suspended!
5) Apply this patch
6) Restart all the things!
7) Repeat steps 1-3
8) Your hold should now be suspended!

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:40:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:40:00 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-HiaX5fFfeH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         Depends on|                            |19735


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735
[Bug 19735] Move Perl deps definitions into a cpanfile
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:40:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:40:00 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-FcxNCacDXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24573


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573
[Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from
cpanfile
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:42:07 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-O5ksEIueEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #4)
> I think it's enough to `git grep Catmandu::MARC` and `git grep
> Catmandu::Store::ElasticSearch` to see that they are used in Koha (thus they
> must appear in cpanfile)

git grep Catmandu::MARC
cpanfile:requires 'Catmandu::MARC', '1.241';

Only used in the cpanfile ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:48:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:48:13 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-5qwbwUEXUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> Catmandu::Store::ElasticSearch is required for search,
> and Catmandu::MARC is required for indexation

No, we still have Zebra. I think it should be a recommend then?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:48:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:48:29 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-jIJ5xnCcmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
                   |ity.org                     |
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:53:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:53:05 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-wzoCKhkJ2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    } else {
+        return 0;
+    }

Wouldnt it be better to return undef or empty string in case of template use?
If it is concatenated somewhere, we get a 0 in between ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:53:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:53:16 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-QwvoZrW0YY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:54:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:54:37 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-29qaux9ZnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100159|0                           |1
        is obsolete|                            |
 Attachment #100160|0                           |1
        is obsolete|                            |
 Attachment #100209|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100217&action=edit
Bug 24803: Remove JS error when clicking "Log in to your account"

This patch removes the "data-toggle" attribute from the login link in
order to avoid a JavaScript error. Since we have a custom click handler
to trigger the modal we don't need Bootstrap's "automatic" modal
handling.

Test plan:
1. Apply patch
2. Open F12 dev tools
3. Click "Log in to your account" on OPAC
4. Observe no Javascript errors in console

Signed-off-by: David Cook <dcook at prosentient.com.au>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:55:39 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-DU9rRdyvw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:55:40 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-pq3P7KXSWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #13)
> RM: I prefer Owen's patch too, marked as PASSED_QA. If you agree, obsolete
> the other two.

I am not RM, but everybody prefers Owen's patch ;)
I planned to QA those patches this morning, done!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:55:43 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-LuGWRRRpxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99631|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100218&action=edit
Bug 24713: JavaScript error on staff client catalog search results page

This patch modifies the output of template toolkit variables so that
values in the in-page JavaScript are quoted. This avoids JavaScript
errors when the template variable is empty.

To test, apply the patch and perform a catalog search in the staff
client. Use the browser's developer tool to check for JavaScript errors
in the console. There should be none.

Test with AmazonCoverImages both on and off.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:55:55 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-neZStanR41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:56:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 08:56:35 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-2VQux5UeLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Julian Maurice from comment #4)
> > I think it's enough to `git grep Catmandu::MARC` and `git grep
> > Catmandu::Store::ElasticSearch` to see that they are used in Koha (thus they
> > must appear in cpanfile)
> 
> git grep Catmandu::MARC
> cpanfile:requires 'Catmandu::MARC', '1.241';
> 
> Only used in the cpanfile ?

We use Catmandu::Importer::MARC, which is part of Catmandu::MARC distribution

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:00:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:00:14 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-DBWeyXvQ2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #7)
> > Catmandu::Store::ElasticSearch is required for search,
> > and Catmandu::MARC is required for indexation
> 
> No, we still have Zebra. I think it should be a recommend then?

There is no rule yet for deciding when a module should be required or
recommended.
I think it should be required because when you turn on the feature, Koha will
die if these modules are not installed, and there is nothing preventing you to
turn on the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:15 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-eZN9O4EqYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100203|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100219&action=edit
Bug 24815: Correct return values of Koha::Cash::Register relations

This patch correct all cases of return undef to instead return an empty
resultset.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:18 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-HW5yfsZ613@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100220&action=edit
Bug 24815: Add additional tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:33 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-heQlcxnBZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
git grep -l -E "parseInt\(\s*\[%"
Before
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

After
Nothing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:48 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-KvqZ9izMDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24817


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817
[Bug 24817] Add sleep calls to Koha::Cash::Register test
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:48 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-H0IvG3tZQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
[Bug 24815] Koha::Cash::Register relations should return sets not undef
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:53 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-9d7nisSU0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:04:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:04:57 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-QM1RJyI3H8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:06:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:06:46 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-1uwKQ3xSNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:07:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:07:20 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-mBFK5GCnlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #12)
> Why do you pass the branchcode's checkout and do not let
> renewal_branchcode/OpacRenewalBranch does the job?

Please change status if there is something with the patch and it needs an
answer. This helps us to skip such patches. It is the responsibility of the
author to respond.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:09:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:09:43 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-OliHyzY4z7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hoping to get an answer from Tomas on this one regarding Jonathan's question..
we would like to know if the API should really be returning the actual
exception error in the 500 response.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:12:27 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-ucCh7VVVr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100165|0                           |1
        is obsolete|                            |
 Attachment #100166|0                           |1
        is obsolete|                            |

--- Comment #16 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100221&action=edit
Bug 23531: fix ILSDI non-implemented but documented parameters

test plan :
1/ Submit a hold through ILSDI with start_date and expiry_date parameters
2/ Verify in Koha those parameters are not applied to the newly created
reserve. Delete reserve.
3/ Apply patch and repeat 1.
4/ Verify the reserve created by same request as 1 now has both dates
applied and visible in Koha.

Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com>

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:12:47 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-GHl71q9WI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:12:50 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-sHpDmnGbAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #17 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 100222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100222&action=edit
Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:14:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:14:09 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-5hyjRWrFMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to David Nind from comment #14)
> Sorry Arthur, patch no longer applies!

Yup, had some issues with my remotes configuration, just got to learn that one
shall not use gitlab anymore.
Patch should apply now.
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:15:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:15:41 +0000
Subject: [Koha-bugs] [Bug 24818] New: Accountline creation dates should be
 datetimes
Message-ID: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

            Bug ID: 24818
           Summary: Accountline creation dates should be datetimes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: martin.renvoize at ptfs-europe.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The resolution of the 'date' field in accountlines is just a date. It should be
helpful if it were a full timestamp and also nice if it were maintained by the
database rather than a DEFAULT NULL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:15:49 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-fFZGkUylo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #9)
> (In reply to Marcel de Rooy from comment #7)
> > > Catmandu::Store::ElasticSearch is required for search,
> > > and Catmandu::MARC is required for indexation
> > 
> > No, we still have Zebra. I think it should be a recommend then?
> 
> There is no rule yet for deciding when a module should be required or
> recommended.
> I think it should be required because when you turn on the feature, Koha
> will die if these modules are not installed, and there is nothing preventing
> you to turn on the feature.

It seems to be that they should not be required now, since we did not require
them before in PerlDependencies. In one of the tests we are mocking the module
for such a reason iirc.

In Discussion? Please mail to the dev list? Or dev meeting agenda point?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:17:53 +0000
Subject: [Koha-bugs] [Bug 24819] New: Allow the librarian to choose a patron
 when entering a purchase suggestion
Message-ID: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

            Bug ID: 24819
           Summary: Allow the librarian to choose a patron when entering a
                    purchase suggestion
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matthias.meusburger at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Sometimes librarians are creating purchase suggestions that came from patrons
which didn't use the opac (but sent an email, or told the librarian
verbally...)

This patch allows the librarian to change the creator of the purchase
suggestion when entering it.

This way, the patron will be able to receive notifications during the purchase
suggestion workflow.

Test plan:

     - Apply the patch

     - Check that you can change the default creator of the purchase suggestion
when
       creating a new suggestion by clicking on 'Set to patron'
       (Home > Acquisitions > Suggestions management > New purchase suggestion)

     - Check that you can also change the creator of the purchase suggestion
when
       editing an existing suggestion

This is a rewrite of Bug 14376.

Since it has been rewritten from scratch, I thought it would be cleaner to
create a new Bug, but let me know otherwise.

This rewrite now uses the common way to select a patron, as requested in Bug
14376.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:19:28 +0000
Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-14376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14376-70-nCgOha8nXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Failed QA                   |RESOLVED

--- Comment #23 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 24819 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:19:28 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-sSSIhYFTYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
*** Bug 14376 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:19:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:19:47 +0000
Subject: [Koha-bugs] [Bug 24820] New: The cashup workflow should use the
 static 'date' field rather than the transient 'timestamp' field in
 accountlines
Message-ID: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

            Bug ID: 24820
           Summary: The cashup workflow should use the static 'date' field
                    rather than the transient 'timestamp' field in
                    accountlines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: martin.renvoize at ptfs-europe.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The 'cashup' process introduced in bug 23355 assumes that once set, the
timestamp of an accountline is fixed.  This assumption is incorrect as the
timestamp is a 'last updated' time and as such is transient. We should be using
the 'date' field for comparisons instead as this field is a fixed 'created on'
record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:19:58 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-0eFeOvM61l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:03 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-KuvZuOrvhR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24818


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818
[Bug 24818] Accountline creation dates should be datetimes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:03 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-CeNdgGIIDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24820


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820
[Bug 24820] The cashup workflow should use the static 'date' field rather than
the transient 'timestamp' field in accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:15 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-yzWHCcfFib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:15 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-YN4SswOj4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24820


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820
[Bug 24820] The cashup workflow should use the static 'date' field rather than
the transient 'timestamp' field in accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:30 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-MJIcII5vOs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:30 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-gnIyFYhvAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24820


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820
[Bug 24820] The cashup workflow should use the static 'date' field rather than
the transient 'timestamp' field in accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:56 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-K8EvOWXGLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:56 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-KDY4y2f6C9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24818


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818
[Bug 24818] Accountline creation dates should be datetimes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:20:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:20:59 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-4AHCdIaZBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

--- Comment #2 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 100223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100223&action=edit
Bug 24819: Allow the librarian to choose a patron when entering a purchase
suggestion

Sometimes librarians are creating purchase suggestions that came from patrons
which didn't use the opac (but sent an email, or told the librarian
verbally...)

This patch allows the librarian to change the creator of the purchase
suggestion
when entering it.

This way, the patron will be able to receive notifications during the purchase
suggestion workflow.

Test plan:

 - Apply the patch

 - Check that you can change the default creator of the purchase suggestion
when
   creating a new suggestion by clicking on 'Set to patron'
   (Home > Acquisitions > Suggestions management > New purchase suggestion)

 - Check that you can also change the creator of the purchase suggestion when
   editing an existing suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:21:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:21:24 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-U75eIEZr0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:23:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:23:45 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-pAqjIzes7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clemens.elmlinger at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:25:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:25:13 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-r2VSepTQEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Gustafsson from comment #0)
> Koha::Object->store accesse sDBIx::Class::Row columns as $self->$col, using
> AUTOLOAD, which in effect makes column names and methods share the same
> namespace. I'm no security expert, but I think this should be considered bad
> practice and could be an attack vector. It also has huge potential for
> causing strange bugs, which happened in Bug 14957 where a column is named
> "delete", calling the "delete" method instead of fetching the column value
> as intended. Here is patch to fix this using a separate namespace for
> setting/getting columns through get_column/set_column instead.

In this case it comes from:
my $columns_info = $self->_result->result_source->columns_info;
just a few lines earlier.
So I guess the security argument does not really apply here. And the "huge
potential for bugs" is a bit overkill.
But the change looks good to me :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:30:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:30:18 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-osz1vFxKaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:30:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:30:18 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-MPWvE6eZ9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
[Bug 24815] Koha::Cash::Register relations should return sets not undef
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:36:24 +0000
Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs
In-Reply-To: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24208-70-3EWuEnWYze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:36:24 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-bTLKL0bn6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24208                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208
[Bug 24208] Remove change calculation for writeoffs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:36:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:36:51 +0000
Subject: [Koha-bugs] [Bug 19489] Detailed description of charges on
 Accounting tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-Vr4GSisBKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:36:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:36:51 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-QJCBjI6YTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19489                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
[Bug 19489] Detailed description of charges on Accounting tab
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:37:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:37:05 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-JnDZP0xxsk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #72 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100224&action=edit
Bug 23112: (follow-up) Conditionally prevent checkout

As mentioned by Nick in comment #69, the checkout button displays even
for requests without a biblio attached (such as chapters). This patch
fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:37:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:37:09 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-wjowiNBlnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #73 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100225&action=edit
Bug 23112: (follow-up) Unit test fixes

As requested by Nick, fixes unit tests and added a test for the new
Koha::Illrequest::biblio method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:37:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:37:26 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-5lq9lKb1bf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100169|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:39:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:39:43 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-1uiyQupuEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #10)
> It seems to be that they should not be required now, since we did not
> require them before in PerlDependencies. In one of the tests we are mocking
> the module for such a reason iirc.

They were totally missing from PerlDependencies.pm. I think it was more a
mistake than a real willingness to make it optional.

> In Discussion? Please mail to the dev list? Or dev meeting agenda point?

If you think it's better to make it optional, that's fine by me.
The important part of the patch is the version requirements. I will change
requires to recommends

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:11 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-q4RuQ3tCiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99959|0                           |1
        is obsolete|                            |

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 100226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100226&action=edit
Bug 24573: Add missing dependencies to cpanfile

When using Elasticsearch, Catmandu::Store::ElasticSearch is required for
search, and Catmandu::MARC is required for indexation

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:21 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-yeNC8FEvX6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:28 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-jVbZ4GMPUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:39 +0000
Subject: [Koha-bugs] [Bug 24821] New: Add percentage handling to discount
 process
Message-ID: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821

            Bug ID: 24821
           Summary: Add percentage handling to discount process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

During the implementation of bug 24081 it was suggested that adding handling
for inputting discounts by a percentage would be a great enhancement.

I see this as being a clientside function allowing for entering a percentage
and it being used to calculate and display the 'amount'.. and perhaps
vica-versa.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:49 +0000
Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process
In-Reply-To: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24821-70-iAzXRp3FJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
[Bug 24081] Add a 'discount' process to accounts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:49 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-bGPCL8tmWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821
[Bug 24821] Add percentage handling to discount process
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:57 +0000
Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process
In-Reply-To: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24821-70-7CqgL9TScm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:42:57 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-zwTqkGZcbv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821
[Bug 24821] Add percentage handling to discount process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:43:15 +0000
Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process
In-Reply-To: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24821-70-hHaJDBnau5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |17596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client [OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:43:15 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-IPoNcdHkcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24821                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821
[Bug 24821] Add percentage handling to discount process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:43:15 +0000
Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client
 [OMNIBUS]
In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17596-70-db0l70n01G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821
[Bug 24821] Add percentage handling to discount process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:45:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:45:35 +0000
Subject: [Koha-bugs] [Bug 24822] New: Add discount processing to paycollect
Message-ID: <bug-24822-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822

            Bug ID: 24822
           Summary: Add discount processing to paycollect
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 24081
            Blocks: 17596

During the implementation of bug 24081 it was suggested that adding handling
for accepting a discount on the paycollect flow would be a great enhancement.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
[Bug 24081] Add a 'discount' process to accounts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:45:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:45:35 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-8fyeINSYia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822
[Bug 24822] Add discount processing to paycollect
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:45:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:45:35 +0000
Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client
 [OMNIBUS]
In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17596-70-uneF0wO76N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822
[Bug 24822] Add discount processing to paycollect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:46:18 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-hdzHhFSMl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:46:18 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-cAJazoKFro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24081                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
[Bug 24081] Add a 'discount' process to accounts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:46:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:46:59 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-pp6jdmGTdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:47:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:47:02 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-mwvEnmFiyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100226|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100227&action=edit
Bug 24573: Add missing dependencies to cpanfile

When using Elasticsearch, Catmandu::Store::ElasticSearch is required for
search, and Catmandu::MARC is required for indexation

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:50:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 09:50:59 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-QhDdJvPvf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing
Looking at Object.t now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:02:21 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-fNt2a5oRor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #17)
> git grep -l -E "parseInt\(\s*\[%"
> Before
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
> 
> After
> Nothing

You should also search for
var xxx = [% Koha.Preference('xxx') %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:45 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-RojRSynE1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:47 +0000
Subject: [Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
In-Reply-To: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22969-70-ZhOM5wlDgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:49 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-OMEWtmnzz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:51 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-pXku3r0DP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:53 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-nOUmKFPPXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:55 +0000
Subject: [Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and
 Catmandu::MARC are missing from cpanfile
In-Reply-To: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24573-70-MM47MbqxnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:57 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-RGxmLqPxWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:04:59 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-XoYh25At9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:01 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-P1ujgDDsaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:03 +0000
Subject: [Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents
 file upload for non-Plack Koha
In-Reply-To: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24719-70-FuH55vQuif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:05 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-HTUd7OA72u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:07 +0000
Subject: [Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
In-Reply-To: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24798-70-4jkDxKGrfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:09 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-NjXFfqzOqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:10 +0000
Subject: [Koha-bugs] [Bug 24802] Updating holds can cause suspensions to
 apply to wrong hold
In-Reply-To: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24802-70-C8RAKrbaM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:12 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-U3MuAHptLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:14 +0000
Subject: [Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws
 fatal Javascript error
In-Reply-To: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24803-70-oBYz4yT5wO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:16 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-sSRXe8YHPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:05:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:05:18 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-x6Kw8iEAcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:06:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:06:32 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-LEZgYOYEFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nope, using sleep in tests is wrong.
Why do not you force the timestamp (NOW-1h for instance) for the account lines?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:12:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:12:43 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-6OGeQEsGQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:12:46 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-xRsparlWKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100064|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100228&action=edit
Bug 24788: Remove autoloaded column accessors in Koha::Object->store

Columns are accessed as methods, relying on AUTOLOAD, in
Koha::Object->store. This has security implications and could also be a
source of strange bugs.

To test:

1) Apply patches for Bug 14957
2) Follow the testing instructions, when saving a new marc rule and
error is thrown.
3) Apply patch
4) Try saving a new rule once again, this should now work

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:15:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:15:32 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-kbpn9BOcJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98673|0                           |1
        is obsolete|                            |

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100229&action=edit
Bug 24474: Add tests

This does the following using the interface:
- Unselect all the options from MarkLostItemsAsReturned except for
  'onpayment'
- Check an item out
- Create a manual invoice LOST for the checked in item
- Renew the item
- Check that the item was not returned

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:15:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:15:35 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-lDxZ0Us3dE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98674|0                           |1
        is obsolete|                            |

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100230&action=edit
Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:15:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:15:39 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-A1cKzUW5t5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98675|0                           |1
        is obsolete|                            |

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100231&action=edit
Bug 24474: Filter out LOST_FOUND

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:15:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:15:43 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-Y826vG9Sha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98676|0                           |1
        is obsolete|                            |

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100232&action=edit
Bug 24474: (follow-up) Add onpayment to sysprefs file

This patch adds the required line to the circulation.pref file to
dispaly the onpayment option in the MarkLostItemReturned preference

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:15:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:15:46 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-gBzGTtsQXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98923|0                           |1
        is obsolete|                            |

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100233&action=edit
Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay

This patch adds the same updated logic as found in
Koha::Account::Line->apply to handle LOST_FOUND credits being applied
against their associated LOST debit.

Currently a 'LOST_FOUND' credit is never created via the pay method and
so the additional test will always pass, but the addition here accounts
for possible future uses.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:17:32 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-Kqaw2XM0fE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #100 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:20:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:20:56 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-WILTirTHrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased again.. please test this Aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:22:34 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22818-70-pZoDA3wQQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92898|0                           |1
        is obsolete|                            |

--- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100234&action=edit
Bug 22818: Add notices sysprefs and DB column

This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and
a new column to the
branches table called 'branchillemail'. It also adds five ILL related
notices.

Here we are providing the ability for a branch to have a dedicated email
address for it's ILL staff, the idea being that any notices sent by ILL
to staff need to go to specific staff, rather than the general branch
email address. If no branch specific address is defined, the address
specified in the ILLDefaultEmail syspref is used.

We're also providing a syspref 'ILLSendStaffNotices' to allow the user to
specify which
notices should be sent to staff upon certain events.

We are also providing patron messaging preferences for the two patron
bound notices

We are also providing five notices for various ILL related events.

Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at it-tallaght.ie>
Sponsored-by: PTFS Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:22:37 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22818-70-PAYaHZ4ZWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92899|0                           |1
        is obsolete|                            |

--- Comment #30 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100235&action=edit
Bug 22818: Add support for ILL notices

Here we're just adding ILL notices to the existing "letters"
infrastructure so notices can be displayed and edited

Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at it-tallaght.ie>
Sponsored-by: PTFS Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:22:41 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22818-70-nvDDC6YmBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92900|0                           |1
        is obsolete|                            |

--- Comment #31 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100236&action=edit
Bug 22818: Add generation and sending of notices

This patch adds the ability for ILL to send notices, both triggered by
staff and triggered by events.

Staff can trigger notices to patrons from the "Manage ILL request" screen:
- ILL request ready for pickup
- ILL request unavailable
- Place request with partners

The following notices to staff are triggered automatically:
- Request has been modified by patron
- Request has been cancelled by patron

Branches can now specify an "ILL email" address to which notices
intended to inform staff of changes to requests by patrons can be sent.

The sending of notices is controlled by a few new sysprefs:
- "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices
to be sent to in the absence of a branch address
- "ILLSendStaffNotices" - To specify which staff notices should be sent
automatically when requests are manipulated by patrons

Patron notices are also controlled by the patron's messaging
preferences

Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at it-tallaght.ie>
Sponsored-by: PTFS Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:22:44 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22818-70-SjLsBCuvMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92901|0                           |1
        is obsolete|                            |

--- Comment #32 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100237&action=edit
Bug 22818: Add MessageAttribut{e,es}.pm

We need to be able to access individual message attributes in tests, so
adding accessors for them

Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at it-tallaght.ie>
Sponsored-by: PTFS Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:22:48 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22818-70-WDaTGFoF9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92902|0                           |1
        is obsolete|                            |

--- Comment #33 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100238&action=edit
Bug 22818: Unit tests

This patch adds unit tests for the new methods in Illrequest.pm

Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at it-tallaght.ie>
Sponsored-by: PTFS Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:27:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:27:56 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-XqRYrFobHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Yes you are correct, I was incorrect about being security issues since only
existing columns are looped over. I for some reason got it in my head that it
was the columns passed to the store method. I will remove this remark from the
commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:28:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:28:38 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-o7iHkDUrKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95888|0                           |1
        is obsolete|                            |

--- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100239&action=edit
Bug 23971 - Add logging for basket related actions

This patch adds logging for the following Acq actions:

- Basket creation
- Basket editing
- Basket approval (via EDI)
- Basket closure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:28:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:28:41 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-Dk9CFWT9P7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100240&action=edit
Bug 23971: (follow-up) Remove data duplication

In response to Séverine observations in comment #10, this patch removes
the duplicate logging of the borrowernumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:28:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:28:45 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-UTbZR8xTkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96064|0                           |1
        is obsolete|                            |

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100241&action=edit
Bug 23971: (follow-up) Add additional basket logging

This patch adds additional basket logging as discussed in comment #14

- Basket reopening
- Basket users (manager) modification
- Basket header modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:29:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:29:04 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-xAk2GdoNDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96063|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:31:41 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-qf1ZgsywZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100228|0                           |1
        is obsolete|                            |

--- Comment #7 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100242&action=edit
Bug 24788: Remove autoloaded column accessors in Koha::Object->store

Columns are accessed as methods, relying on AUTOLOAD, in
Koha::Object->store. This could be a source of strange bugs
if a column name clashes with an existing method name.

To test:

1) Apply patches for Bug 14957
2) Follow the testing instructions, when saving a new marc rule and
error is thrown.
3) Apply patch
4) Try saving a new rule once again, this should now work

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:33:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:33:32 +0000
Subject: [Koha-bugs] [Bug 24762] Statuses that should not be manually changed
In-Reply-To: <bug-24762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24762-70-ja4OlZwbhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24762

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:51:12 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-XqMIOxZVKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #101 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Sorry, but I cannot pass QA on this patch set:

You add changes to Reserves.pm but you only change a test script for updating
or inserting age restriction in marc subfields. We need solid test cases for
the changes you make.

But looking further, do we really want this change here? We already check for
maxreserves in opac-reserve.pl and reserve/request.pl. So if you would need it
for ILS-DI, I would expect you add it there? If we want the check in the
module, we should also consider the scripts mentioned. And what about
performance? If you come from CanBook, why would you test it again and again in
CanItem? This check is only needed for the first item?

+         { status => alreadyReserved }, if the borrower has already reserved
this item.
Where do you find that one ?

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:53:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:53:06 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-0ub4L2IiIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96369|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100243&action=edit
Bug 24190 - Add acquisition logging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:54:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:54:25 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-3sYEXqW7FG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
           Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
                   |ity.org                     |
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:59:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:59:56 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-ikYT5V819N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98765|0                           |1
        is obsolete|                            |

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100244&action=edit
Bug 24083: Required atomic updates & DB update

This patch adds:

- An "UnseenRenewals" circulation syspref that enables/disables the
  functionality added in this bug

- Add unseen_renewals_allowed to circulation_rules

- A change to the issues & old_issues table schemas and corresponding
  database upgrades to add issues.unseen_renewals &
  old_issues.unseen_renewals

- An update for the renewals letter to include a message for unseen
  renewals

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:59:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 10:59:59 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-LkVes2FWvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98766|0                           |1
        is obsolete|                            |

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100245&action=edit
Bug 24083: Add circ rules management

This patch adds the ability to set the "Unseen renewals allowed" value
in the circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:00:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:00:02 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-xPUNX8CLI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98767|0                           |1
        is obsolete|                            |

--- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100246&action=edit
Bug 24083: Add support for unseen_renewals

This patch adds support for unseen renewals.

Here we retrofit knowledge of unseen renewals and add the display of unseen
renewal counts and warnings, in addition to adding the ability to
specify a renewal as being "unseen".

The functionality added here is goverened by the UnseenRenewals syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:00:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:00:06 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-IsKmEoFgm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98768|0                           |1
        is obsolete|                            |

--- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100247&action=edit
Bug 24083: Add unit tests

This patch adds unit tests for unseen renewals

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:13:25 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-y8N9ZaOFmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #96)

Thanks Julian!

> A few complaints from QA script:
> 
>  FAIL   Koha/Schema/Result/AuthorisedValueLocalization.pm
>    FAIL   pod coverage
>                 POD coverage was greater before, try perl
> -MPod::Coverage=PackageName -e666

=> False positive, there is no sub there.

>  FAIL   installer/data/mysql/atomicupdate/bug_20307.sql
>    FAIL   git manipulation
>                 The file has been added and deleted in the same patchset
> 
> So, maybe patches should be squashed.

Different authors.

> Also:
> 1) The value stored in localization.code is a concatenation of the AV
> category code, a '_', and the AV code. Which means that if we have a
> category A with a value B_C, and a category A_B with a value C, they will
> share their translations.

I can pick something else than '_', but the problem will exist for any
characters.
% or $ would fit better?

> 2) It feels weird to have the ability to translate for all languages. I
> mean, the original description is already written in one of those languages,
> right ? So if I add a translation for each language, the original
> description will never be used. Not really a problem though, as it allows to
> have the original description in the language we want, and we can just not
> add a translation for that language.

This development basically mimic what is done for item types. So if there is a
change to do in the way they are translated, that should be done before or
after this development to affect both screen.
I do not think it's a problem anyway. The "default" (the one in the
authorised_value table) is used when there is no translation available.

> 3) There is some places where translated descriptions are not used (the
> items table in cataloguing/additem.pl for instance) but that can be added
> later (not blocking)

I can commit on fixing any bugs we are going to find after those patches are
pushed.
I will take a look at additem.

> 4) The new column 'interface' will be only useful for authorized value,
> right ? Why not append the interface to the entity name instead of adding a
> new column ("authorised_values:opac" for instance) ? Actually, the AV
> category code could be added there too to avoid (1)
> ("authorised_values:opac:CCODE").

I think it makes sense to have the interface. The idea is to provide an
interface in the admin module to have a global view of the different entities
that are translated. So we could imagine a filter to display only opac/staff.
Also it could make sense to have the interface for some of the system
preferences.
As the feature is here, I prefer to keep it and see how it could be useful that
add work to drop it then re-add it later. Do not you agree?

> 5) Please add a test plan :) Even if it's not exhaustive it really helps to
> have one.

As I said already, a test plan is hard to provide.
One could be:
- Pick an authorised value that is displayed in lot of places (LOST/DAMAGED for
instance)
- Provide a translation for some of the values
- Go to different pages where the AV is displayed (opac and staff) and make
sure the values you translated is the one that is displayed.


> 6) Koha::AuthorisedValues::search_with_localization does something really
> strange : it sets package variables
> $Koha::Schema::Result::AuthorisedValue::LANGUAGE and
> $Koha::Schema::Result::AuthorisedValue::INTERFACE. I understand that they
> are then used in the has_many subroutine for 'localization', and that the
> same thing is done for itemtypes, but that feels wrong to use global
> variables like that. Can't we use a "normal" join in
> search_with_localization ? And why has_many ? An authorised value should
> have only 1 (or 0) translation, given a particular language and interface.

They are used actually in the view
(Koha/Schema/Result/AuthorisedValueLocalization.pm).
Take a look at this commit where I tried to explain it
  commit 80018625cf03ccd00957035f99065ed5793b80e3
  Bug 17835: Create a ItemtypeLocalization view
I spent quite a lot of time to find a correct solution when I implemented bug
17835.
Maybe there is a better way to do it, but here I am following an existing
pattern, that works so far.

I think the description also answer why 1-N (has_many): 1 entry in
authorised_value has several entries in the view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:16:05 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-ElQ1fsVCog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:16:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:16:08 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-AFth0HHLyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99968|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100248&action=edit
Bug 24760: Use C4::BackgroundJob->fetch in tests

Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless
loaded objects by default. This is not a problem as
C4::BackgroundJob->fetch bless them anyway.

So, instead of testing what's in the session, test the result of
C4::BackgroundJob->fetch, which is what's used everywhere else

Test plan:
1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not
installed)
2. prove t/db_dependent/BackgroundJob.t => should FAIL
3. Apply patch
4. prove t/db_dependent/BackgroundJob.t => should PASS
5. Verify that background jobs are still working (for instance,
tools/batchMod.pl)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:16:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:16:12 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-aFRm4WmXzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100249&action=edit
Bug 24760: (follow-up) Add a neighboring test messsage

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:22:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:22:14 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-H4vXyVRIlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100250&action=edit
Bug 24818: Update database accountlines.date to timestamp

This update increases the resolution for the 'date' field, used for
'creation date' in accountlines from a 'date' to a 'timestamp'.

This matches other tables where both a created and updated field are
included.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:24:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:24:20 +0000
Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create
In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24031-70-sSWZMsN3jp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
if (C4::Context->preference('UseKohaPlugins') &&
C4::Context->config('enable_plugins')) {
+        my @plugins = $class->new({ enable_plugins => 1 })->GetPlugins({
method => $method });
+        my @responses;
+        foreach my $plugin (@plugins) {
+            my $response = $plugin->$method(@args);
+            push @responses, $response;
+        }
+
+        return @responses;
+    }

No error checking?
What if one of the plugins fails, should you continue? Should you use eval?
Should $method be checked somehow before calling it rightaway?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:26:22 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-GYq6TlxEDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
=POD
See also
=cut

Great! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:26:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:26:34 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-IACKDTPWaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:27:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:27:00 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-9ThBgwdKrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:27:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:27:03 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-jeSHhxLFme@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99673|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100251&action=edit
Bug 24066: Add missing POD for has_permission

To test:
1) do perldoc Koha/Patron.pm
   search has_permission

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed (removed) space before 'my $permission' to make it similar to
other entries.
No errors

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:33:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:33:26 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-uPqweH5s78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:04 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-lbW9HcyFZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:07 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-5cVBtf8Jww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100100|0                           |1
        is obsolete|                            |

--- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100252&action=edit
Bug 23112: Add CirculateILL syspref

Sponsored-by: Loughborough University
Signed-off-by: Chris Walton <C.J.Walton at lboro.ac.uk>

https://bugs.koha-community.org/show_bug.cgi?id=23112

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:11 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-QSR2OXPWMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100101|0                           |1
        is obsolete|                            |

--- Comment #75 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100253&action=edit
Bug 23112: Add circulation to ILL requests

This patch adds the ability to circulate ILL requests. Once a request has a
suitable status, a "Check out" button is displayed on the "Manage request"
toolbar. Clicking this will enable the user to check out the item either to the
user who made the request or an in-house statistical  user. A due date can be
specified, but if not circ rules are used.

Prior to the check out, an item is created which is attached to the biblio
record that was created when the request was added

This development has been carried out according to the originally stated
requirements of the customer that sponsored it, detailed here:
https://wiki.koha-community.org/wiki/ILL_Circulation_RFC

Test plan:

1. Ensure the FreeForm ILL backend is available
2. Enable the "CirculateILL" syspref
3. Ensure you have a statistical patron category defined (patron category type
"Statistical")
4. Ensure you have at least one patron in your statistical patron category
5. Create a new FreeForm request (make a note of the library you select when
creating it)
6. Mark the new request as confirmed by clicking the "Confirm request" button
on the "Manage ILL request" page
7. TEST: Observe that a "Check out" button is now displayed in the request
toolbar
8. Click the "Check out" button in the "Manage ILL request" page
9. In the "Issue requested item to..." screen:
  a. Do not select a statistical patron at this time
  b. You can at this point choose an item type, this will determine the type of
the item that will be created for this request
  c. TEST: Observe that the default selected "Library" matches that that was
defined when creating the request
  d. Do not select a due date at this time
10. Click "Submit"
11. TEST: Observe that the "Item checked out" screen displays, issued to the
requesting patron with a due date corresponding to appropriate circ rules
12. Click "Return to request"
13. TEST: Observe that the request's status is now "Checked out"
14. Click the "Bibliographic record ID" link
15. TEST: Observe that the bibliographic record now has one item attached to it
which is checked out
16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID
17. Return to step 5., however, this time select a statistical patron and test
that the item use is recorded and the item is not issued
18. Return to step 5., however, this time manually select a due date and test
that the item's due date is set correctly on check out
19. Check in the item
20. TEST: Observe that the request's status is updated to "Returned to library"
21. Now implement a restriction on the patron (perhaps a fine) which would
prevent them from checking out an item
22. Return to step 5. follow the instructions to step 10.
23. TEST: Observe that a banner is displayed at the top of the screen informing
you that there was a problem checking the item out, containing a link to the
patron's account page
24. Resolve the problem with the patron's account
25. Return to step 8.
26. TEST: Observe that the item is now successfully checked out
27. Disable the "CirculateILL" syspref
28. Return to step 5. at step 7. Observe that the "Check out" button is NOT
displayed

Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:14 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-NIR2KLsUQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100102|0                           |1
        is obsolete|                            |

--- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100254&action=edit
Bug 23112: Add permission checks

We only want the ILL circulation functionality to be available if the
appropriate syspref and perm are available, this patch adds those
checks.

Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:18 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-5SQ2dDeDxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100103|0                           |1
        is obsolete|                            |

--- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100255&action=edit
Bug 23112: Update request status on return

This patch updates a request's status to RET upon return

Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:21 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-6o9vpCAy3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100104|0                           |1
        is obsolete|                            |

--- Comment #78 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100256&action=edit
Bug 23112: Add unit tests

This patch adds unit test for the new Koha::Illrequest::check_out method

Sponsored-by: Loughborough University

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:25 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-w1YH3fMpp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100105|0                           |1
        is obsolete|                            |

--- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100257&action=edit
Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues

In response to the problem Magnus was experiencing in comment #28 & #29
we now call GetAuthorisedValues by it's full path

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:28 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-NAvlsdT3W1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100106|0                           |1
        is obsolete|                            |

--- Comment #80 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100258&action=edit
Bug 23112: (follow-up) Address QA feedback

As per comment #46

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:32 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-0kBtF2bwGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100107|0                           |1
        is obsolete|                            |

--- Comment #81 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100259&action=edit
Bug 23112: (follow-up) Fix test as per feedback

As per comment #48

https://bugs.koha-community.org/show_bug.cgi?id=23113

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:36 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-Rm4bzGUYcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100108|0                           |1
        is obsolete|                            |

--- Comment #82 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100260&action=edit
Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs

Looks like the atomicupdate and sysprefs.sql changes were lost at some point.

Don't forget to run QA tools on your patches before submitting

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:39 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-WeJnhY2WUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100224|0                           |1
        is obsolete|                            |

--- Comment #83 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100261&action=edit
Bug 23112: (follow-up) Conditionally prevent checkout

As mentioned by Nick in comment #69, the checkout button displays even
for requests without a biblio attached (such as chapters). This patch
fixes that.

https://bugs.koha-community.org/show_bug.cgi?id=23112

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:43 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-QX7yQx5CT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100225|0                           |1
        is obsolete|                            |

--- Comment #84 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100262&action=edit
Bug 23112: (follow-up) Unit test fixes

As requested by Nick, fixes unit tests and added a test for the new
Koha::Illrequest::biblio method

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:37:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:37:47 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-jI4L0Ia4cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #85 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100263&action=edit
Bug 23112: (QA follow-up) Clean up tests, catch warnings

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:39:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:39:24 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-UomZnPwEbk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:39:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:39:27 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-4Z9reCNN7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100264&action=edit
Bug 23384: Fix use statement order for ArticleRequest::Status

Koha::ArticleRequest is used by Koha::ArticleRequests so
Koha::ArticleRequest::Status should not be needed in
Koha::ArticleRequest.
Also Koha::ArticleRequest::Status must be loaded before
Koha::ArticleRequest

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:39:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:39:59 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-WfQTZ1rKuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100265&action=edit
Bug 24820: Use 'date' instead of 'timestamp' for cashup

Prior to this patch we were comparing cash register action timestamp to
accountlines date fields to fetch the list of outstanding accountlines.

accountlines.date is a transient field used as 'updated_on' and so this
was a logical mistake. We should be using the 'date' field which is
fixed 'created_on' time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:40:13 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-xX0Umqv4uu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:40:17 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-fktLeXRhVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Tested with bug 23112, all works as expected, small change, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:40:17 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-iNmIVjgJTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:40:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:40:31 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-b4t4dX0C9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:40:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:40:43 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-bL4YYD7FIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:42:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:42:31 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disbled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-LesgTDo7DY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

--- Comment #4 from Hans Pålsson <hans.palsson at hkr.se> ---
(In reply to Katrin Fischer from comment #3)
> I think it would be nice if we had both options - totally disable and only
> disable adding new.
> 
> Maybe a multi-select pref or one with 3 possible values in the drop down?

Any solution will do, but right now the syspref forces libraries into an
unwanted function. An empty field should equal no possibilty for a patron to
submit an ILL-request through the OPAC. But that's not really how it works (i
think) so a syspref as "Allow OPAC ILL-request submission" is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:56:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:56:48 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-STq5CO5eKH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:56:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:56:51 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-Zwz634TxQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99847|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100266&action=edit
Bug 24219: Preserve sort order when returning to result list

There is a mismatch between sort_cgi, sort and sort_by variables.

 * sort_cgi
I did not find relevant occurrences of sort_cgi in the git log of both
search.pl and results.tt. So it seems that it never worked correctly.
 * sort
It is the JS variable use in browser.js
 * sort_by is the search.pl parameter to set the sort_by option

Test plan:
1. Perform a search in the staff client
2. Change the sort order to something different (try Author A-Z)
3. Click on a result to view the record
4. Click on "Results" button on left side to return to result list
=> Without this patch the result list is sorted by relevancy
=> With this patch applied the Author A-Z is kept

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:58:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 11:58:57 +0000
Subject: [Koha-bugs] [Bug 24823] New: Drop Catmandu dependency
Message-ID: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

            Bug ID: 24823
           Summary: Drop Catmandu dependency
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

This is a follow up of Bug 19893 where most of, but not all, of the
dependencies on Catmandu was replaced with our own code. Since there is not
much left it would be nice to get rid of the Catmandu dependency altogether.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:03:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:03:44 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-F7VRfF0yxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #6)
> Hoping to get an answer from Tomas on this one regarding Jonathan's
> question.. we would like to know if the API should really be returning the
> actual exception error in the 500 response.

The usual pattern is:

        unless ( blessed $_ && $_->can('rethrow') ) {
            return $c->render(
                status  => 500,
                openapi => {
                    error =>
                      "Something went wrong, check Koha logs for details."
                }
            );
        }
        return $c->render(
            status  => 500,
            openapi => { error => "$_" }
        );

So if it is not showing the exception info it is because it is not an
exception. In both cases I'd feel comfortable with a change to send the
exception to the logs, unless debugging is set (i.e. no need to give the
consumer details about the internal problems in Koha). So I vote for all
unhandled exceptions to return a generic internal server error and warn the
exception info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:04:47 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-2sRahw2ig6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #8)
> (In reply to Martin Renvoize from comment #6)
> > Hoping to get an answer from Tomas on this one regarding Jonathan's
> > question.. we would like to know if the API should really be returning the
> > actual exception error in the 500 response.
> 
> The usual pattern is:

I forgot to say I'm sure there's probably not 100% consistency on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:11:50 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-BIp0YcXnxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:12:04 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-uuyhOh1HOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99977|0                           |1
        is obsolete|                            |

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100267&action=edit
Bug 23925: Value builder plugin to check ISBN validity

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Nice plugin.
Tested for both 13 and 10 digits ISBNs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:13:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:13:47 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-E7d3fqdHiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100268&action=edit
Bug 24823: Drop Catmandu dependency

Replace remaining Catmandu dependant code with the Search::Elasticsearch
equivalent.

To test:
1) Apply patch
2) Run tests in t/Koha/SearchEngine/Elasticsearch.t,
t/Koha/SearchEngine/ElasticSearch/*
and t/db_dependent/Koha/SearchEngine/*
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:15:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:15:36 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-fzCItGqPgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:16:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:16:50 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-4bu8TC9iaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:16:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:16:53 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-IHlqfwGwiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99773|0                           |1
        is obsolete|                            |
 Attachment #100006|0                           |1
        is obsolete|                            |
 Attachment #100035|0                           |1
        is obsolete|                            |

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100269&action=edit
Bug 24754: Set userenv for ilsdi requests

Currently ILSDI scripts do not have a userenv set. This affects both
action_logs and statistics.

For action_logs we either get no user or, if there is an active session, we use
that one. This can have unintended consequences and we should explicitly set
the env so that system user (0) is recorded

For statistics we need to specify a branch to record for actions like renewals.
With bug 24759 we add an items method for this. We should take advantage of
this method and use the 'opac' interface as the ilsdi scripts live there.

To test:
1 - Enable ILSDI in systempreferences
2 - Checkout an item to a patron
3 - Enable Renewal logs
4 - Ensure you will be able to renew the item several times
5 - Open an incognito/private browser
6 - Renew item via ilsdi:
   
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
7 - Check action logs, interface may be random, user should be 0, if not make
sure the user in step 9 is a different one
8 - In private browser open a new tab
9 - Sign in to staff client
10 - Return to other tab
11 - Refresh page to repeat renewal
12 - Check action_logs
13 - The second renewal indicates it was renewed via intranet by logged in
staff member
14 - Apply patch
15 - restart_all
16 - Ensure staff client still signed in
17 - Repeate renewal again
18 - Check logs, renewal now indicates opac again (as it should), user is 0
even if logged in on other tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:17:24 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-g4DhRdGnzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #12)
> Why do you pass the branchcode's checkout and do not let
> renewal_branchcode/OpacRenewalBranch does the job?

Old code, was before dependency.

Patch updated, back to NSO

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:32:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:32:44 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-PNccRFTgZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's not related to 500 but 400. There is a
Koha::Exceptions::Hold::CannotSuspendFound that is raised and we need to see it
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:35:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:35:13 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-qBR4DGnY6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ok but then it will explode in some cases Nick. For instance the logged in user
does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:55:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 12:55:55 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-u1c34n4Cf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marcel de Rooy from comment #6)
> Wouldnt it be better to return undef or empty string in case of template use?
> If it is concatenated somewhere, we get a 0 in between ?

Returning undef triggered this error in the QA tool:

"# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s)."

I don't think there is a scenario where this variable would be concatenated
with something else, but if you think it's worth preparing for I would be happy
to sign off on a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:03:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:03:09 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-omMIxuQYwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:09:23 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-WMUNlkWJxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100270&action=edit
Bug 22771: Fix mistakes in list of nonfiling character fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:10:15 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-yFortp1TBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #16)
> Ok but then it will explode in some cases Nick. For instance the logged in
> user does not exist.

Scratch that, it won't reach that code for "opac"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:15:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:15:12 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-Q71CytbLMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100271&action=edit
Bug 23051: (RM follow-up) Fix rebase error

Looks like at some point during reworking/rebasing the signature for
Koha::Account::Line->apply changed and was then reverted but one case of
the reversion got lost.

The error was highlighted in the patrons_accounts credit api tests.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:15:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:15:29 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-Sa5op40uC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:22:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:22:51 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-TuuQYRUifc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
In case someone else comes for QA before me, see bug 24608 comment 26 and see
if the problem exists in this feature as well.


Agustin, a couple of things I spot:
 * authnotrequired needs to be removed (there is a new check in the QA script)
 * Schema files should be in a separate patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:25:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:25:20 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-5JYt2ubwJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
WARNING: This must NOT be pushed before I have a better clarity of the needs.
This does not need to be pushed before one of the 2 dependent bugs anyway.

See for instance bug 24608 comment 26.

(This bug does not need to be marked as blocked, the dep is the other way
around)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:34:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:34:44 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-ZCXkA0YsUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
how about '->inbound_email_address' ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:55:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:55:34 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-tgGzrFFsHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd love to see this one start moving again..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:55:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:55:38 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-jOXE8Z6dgO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> It's not related to 500 but 400. There is a
> Koha::Exceptions::Hold::CannotSuspendFound that is raised and we need to see
> it somewhere.

My gut feeling is we should somehow overload Test::Mojo so it does ->or( sub {
diag $t->tx->res->to_string } ), or just add it everywhere and enforce it as a
coding guideline.

This would give us more light on handled exceptions, but we still need
something for unhandled exceptions, in the lines of bug 18206 (probably making
use of a helper instead, but you get the point).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:55:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 13:55:42 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-2ciuHocEhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
I tested the following, let me know if i missed elsewhere:
  editing patron satff
  editing patron opac
  importing patron
  patron creation/update via ldap

Branch limitations do not save

Cannot load patron if attribute value not in authorized values (OK, but should
have a way to identify)

Opac update of attributes fails, blank value passed to update request

Patron import with 'replace only included attributes' fails
Can't use string ("Koha::Patron::Attribute") as a HASH ref while "strict refs"
in use at /kohadevbox/koha/Koha/Object.pm line 625

Attributes in ILSDI shows some extra info:
borrowernumber, authorised_value_category - is noisier than without patch


Test failures:
Test Summary Report
-------------------
t/00-testcritic.t                 (Wstat: 256 Tests: 1020 Failed: 1)
  Failed test:  732
  Non-zero exit status: 1
t/00-valid-xml.t                  (Wstat: 512 Tests: 135 Failed: 2)
  Failed tests:  1-2
  Non-zero exit status: 2
t/Logger.t                        (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:00:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:00:58 +0000
Subject: [Koha-bugs] [Bug 24824] New: updated_on should be a read-only field
 via the api
Message-ID: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824

            Bug ID: 24824
           Summary: updated_on should be a read-only field via the api
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When updating a patron via the api we should write protect the updated_on field
and ensure it is updated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:01:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:01:07 +0000
Subject: [Koha-bugs] [Bug 24824] updated_on should be a read-only field via
 the api
In-Reply-To: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24824-70-nZWZfmkOC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:21:19 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-9ZS7Ui4XK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:21:22 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-OmQwp79HS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59560|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100272&action=edit
Bug 17996 - longoverdue.pl should not set 'datereturned' when --mark-returned
option is used

When longoverdue.pl returns items, it sets old_issues.returndate to the
current date. This means that when staff look at the borrowers'
circulation history, they see a returndate displayed, which is
confusing.

We don't lose information by not setting old_issues.returndate, because
items.itemlost_on will contain the date that the item was lost.

Test Plan:
1) Apply this patch
2) Mark an item lost using longoverdue.pl with --mark-returned
3) Note the item's old_issues line does not have a returndate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:21:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:21:51 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-4uIw8utRRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:21:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:21:55 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-EIrqmmdK0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:22:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:22:25 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-ga6wvt3bx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
          Component|Command-line Utilities      |Circulation
           Assignee|kyle at bywatersolutions.com   |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:22:30 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-5eRZhqXTZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Command-line Utilities

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:22:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:22:58 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-m4euVjIWKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Rebased, but this needs test coverage - the pod is explicit that we set the
date, so maybe we have moved on from here

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:27:35 +0000
Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to
 ReservesControlBranch
In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22562-70-1Cyiftp4mp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86906|0                           |1
        is obsolete|                            |

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100273&action=edit
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:33:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:33:14 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-S84fORdm9e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #2)
> Nope, using sleep in tests is wrong.
> Why do not you force the timestamp (NOW-1h for instance) for the account
> lines?

Because I don't want to change add_cashup to accept a timestamp to be passed
just to pass the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:33:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:33:22 +0000
Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to
 ReservesControlBranch
In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22562-70-djhCou0hL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
We have changed some conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:36:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:36:03 +0000
Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to
 ReservesControlBranch
In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22562-70-G2W18G812e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:36:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:36:06 +0000
Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to
 ReservesControlBranch
In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22562-70-sWrUEyYPV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100273|0                           |1
        is obsolete|                            |

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100274&action=edit
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.

Signed-off-by: Devinim <nazli at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:47:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:47:32 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-x3ixi4zoG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100275&action=edit
Bug 24817: Horrible cludge date setting to remove sleep

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:48:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 14:48:24 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-iYqwHk8PFW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That second patch does the trick.. but in my opinion feels much worse than
using a sleep.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:01:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:01:12 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-UHK4MEUN3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
  Attachment #99191|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:33 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-DP9qFTzkkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:35 +0000
Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without
 "use" in Patron.pm can cause breakage
In-Reply-To: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23384-70-bD0EL4URLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:37 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-l3UZSDxIGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:39 +0000
Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort
 preference when returning to result list
In-Reply-To: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24219-70-228NVKlH38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:41 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-WQ2Rtuk4HS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:42 +0000
Subject: [Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest
 versions of YAML or YAML::Syck
In-Reply-To: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24760-70-QqkQppCpJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:44 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-ZmVck663qR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:02:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:02:46 +0000
Subject: [Koha-bugs] [Bug 24788] Koha::Object->store calls column names as
 methods, relying on AUTOLOAD, with possibly surprising results
In-Reply-To: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24788-70-3NpP6yLveT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:04:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:04:21 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-sBX8ujkyKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:04:23 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-oojsiLxzgi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:14:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:14:46 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-r0XxnbiLTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:14:48 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-3lgCtE5Ee2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99926|0                           |1
        is obsolete|                            |

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100276&action=edit
Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt

In return page return.tt, when there is an hold message, patron is said as
restricted even if restriction end date is in the past.

Test plan :
1) For a patron Jon Doe create a manual restriction with end date in the past
2) Create an hold for this patron on an item
3) Check in this item => You don't see message "Patron is RESTRICTED"
4) For a patron Kevin Doe create a manual restriction with end date in the
future
5) Create an hold for this patron on an item
6) Check in this item => You see message "Patron is RESTRICTED"
7) Repeate 1-6 with system preference HoldsAutoFill enabled
8) Repeate 1-6 with a waiting hold

Signed-off-by: Devinim <nazli at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:47:52 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-nXWNawSITr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:47:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:47:54 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-GXcf2JaUcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92032|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100277&action=edit
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs

Use of patron-title.inc on the checkin page is inconsistent, resulting
in patron names being displayed differently under different
circumstances. This patch makes it more consistent.

To test, apply the patch and check in items with the following statuses:

 - On hold for a patron at your library
 - On hold for a patron not at your library
 - On hold and already marked 'Waiting'
 - On hold while HoldsAutoFill preference is enabled
 - An item which has been marked with a LOST status in the
   'ClaimReturnedLostValue' system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:56:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:56:40 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-kbaVpbdW1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97623|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100278&action=edit
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup

This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup
class.

To test:
1. Compare the mapping with the one on the RFC
=> SUCCESS: They match
2. Sigh off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 15:56:57 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-QVZ5X2ftIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looking good to me.. SO

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:20:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:20:39 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be
 useful to see on OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-dBelwEbnmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:20:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:20:42 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be
 useful to see on OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-pWn5lJBRkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100199|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100279&action=edit
Bug 13547: Add item field 3 (Materials specified) to the OPAC holdings table

Test plan:

1- View a record with Materials specified (field 3) data in the opac
2- Apply patch
3- Log in to staff client
4- Home->Administration->Column Settings->OPAC->holdingst
5- Set item_materials visibility
6- Refresh OPAC page
7- Confirm that the materials specified column has been added after the
   Call number column.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:48:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:48:43 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-EopPvpKpn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:48:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:48:45 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-NYC19Z86n6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99860|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100280&action=edit
Bug 24774: Set JSON indentation of 2 spaces in .editorconfig

To test:
1. Start an editor that supports .editorconfig
2. Open or create a JSON file
3. Observe identation is set to 2 spaces by default

Sponsored-by: Hypernova Oy

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:59:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:59:21 +0000
Subject: [Koha-bugs] [Bug 24665] Add ability to Run Cash Register report
 with New Cash register feature
In-Reply-To: <bug-24665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24665-70-5wm26oiRio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985
         Depends on|                            |23321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:59:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:59:21 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-qG1BIBVQfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24665


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665
[Bug 24665] Add ability to Run Cash Register report with New Cash register
feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:59:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 16:59:21 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23321-70-RO7Oihwitj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24665


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665
[Bug 24665] Add ability to Run Cash Register report with New Cash register
feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:01:59 +0000
Subject: [Koha-bugs] [Bug 24665] Add ability to Run Cash Register report
 with New Cash register feature
In-Reply-To: <bug-24665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24665-70-G5ZzcvsIpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
What did you have in mind Kelly...

I must admit, I've never really used that report.  Having just taken a look at
it, are you simply suggesting adding the ability to limit the results by a
particular cash register via a select menu?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:02:04 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-nDvg5IP6K1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:02:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:02:06 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-e7dcsF9O5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100223|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100281&action=edit
Bug 24819: Allow the librarian to choose a patron when entering a purchase
suggestion

Sometimes librarians are creating purchase suggestions that came from patrons
which didn't use the opac (but sent an email, or told the librarian
verbally...)

This patch allows the librarian to change the creator of the purchase
suggestion
when entering it.

This way, the patron will be able to receive notifications during the purchase
suggestion workflow.

Test plan:

 - Apply the patch

 - Check that you can change the default creator of the purchase suggestion
when
   creating a new suggestion by clicking on 'Set to patron'
   (Home > Acquisitions > Suggestions management > New purchase suggestion)

 - Check that you can also change the creator of the purchase suggestion when
   editing an existing suggestion

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:03:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:03:56 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-bnebzD6fEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:09:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:09:19 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-0fgRZseYKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:09:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:09:22 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-bvCYt3XyPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100202|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100282&action=edit
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set.

If there's no item, dropdown message "No matches found" is hard to read.

Affect:
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

To test:
- Select a catalogue notice in Koha intranet.
- Open add item form.
- Choose a dropdown combo with an empty set, 'j - Shelving control number' is a
good candidate.
- Apply the patch.
- Re select the compo in open add item form.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:31:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:31:44 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-czyVkTA7pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:34:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:34:57 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-bgxUQOFtJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:52:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 17:52:57 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-QKNsBpNBPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io

--- Comment #32 from Agustín Moyano <agustinmoyano at theke.io> ---
seems timezone is not saved in date_due column, because it's a datetime rather
than timestamp

https://stackoverflow.com/questions/19843203/how-to-store-a-datetime-in-mysql-with-timezone-info

Maybe we can alter that column to timestamp, so timezone is saved, or I can add
a flag to the JS function in 24455 to use timezone or not

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 19:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 18:04:54 +0000
Subject: [Koha-bugs] [Bug 24824] updated_on should be a read-only field via
 the api
In-Reply-To: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24824-70-4NZyKDcfMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:24 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-12Zyo8ooEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98651|0                           |1
        is obsolete|                            |
  Attachment #98652|0                           |1
        is obsolete|                            |
  Attachment #98653|0                           |1
        is obsolete|                            |
  Attachment #98654|0                           |1
        is obsolete|                            |
  Attachment #98655|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100283&action=edit
Bug 24157: New permission - reopen_closed_invoices

New permission to reopen a closed invoice.

Test plan:
- Remove the new permission "reopen_closed_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, close it
=> You are not able to reopen the invoice
- Add the permission
=> You are able to reopen the invoice

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:27 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-XyFq8swtu5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100284&action=edit
Bug 24157: New permission - edit_invoices

Add a new permission to edit invoices

Test plan:
- Remove the new permission "edit_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, edit it (click "detail")
=> You can see the detail of the invoice, but cannot edit it. It's a read-only
view.
- Add the permission
=> The form is back and you can modify the invoices and save the changes.
Also, you are able to create adjustments.

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:30 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-TUHMi2HhbC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100285&action=edit
Bug 24157: Add new method Acq::Invoice::Adjustement->fund

Moving to its own commit in case we want to cherry-pick or move it to
its own bug report.

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:33 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-Zc8rpg36nf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100286&action=edit
Bug 24157: New permission - delete_invoices

Add a new permission to delete invoices

Test plan:
- Remove the new permission "delete_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the invoice

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:36 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-aT0FrS3WuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100287&action=edit
Bug 24157: New permission - delete_baskets

Add a new permission to delete acquisition baskets

Test plan:
- Remove the new permission "delete_basket" for a given patron,
use it to log in into Koha
- Create basket, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the basket

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:19:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:19:38 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-SwbtPsgKq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100288&action=edit
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice

This follow-up makes minor changes to the template so that the checkbox
for reopening or closing an invoice are not displayed when the user
doens't have the correct permissions.

To test, apply the patch and try the process of viewing or editing an
invoice as a user with these various permissions:

 - edit_invoices ON
 - edit_invoices OFF
 - reopen_closed_invoices ON
 - reopen_closed_invoices OFF

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:24:48 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-sDodiJOkWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92650|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:48:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:48:43 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-IC57VLkMnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97101|0                           |1
        is obsolete|                            |

--- Comment #53 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100289&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
    * The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
https://bugs.koha-community.org/show_bug.cgi?id=17835

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:48:52 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-jTe9qj02xe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97102|0                           |1
        is obsolete|                            |

--- Comment #54 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100290&action=edit
Bug 17385: Add tests for CustomXSLTExportList

+ Added tests for CustomXSLTExportList to C4::XSLT
+ Added an eval block in CustomXSLTExportList to handle invalid XML.

* Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent

+ Added "Custom" option to OPACExportOptions preference.

Tested with invalid XML (not originally on purpose, but...) and then
added a new field to add to the simple export.

Walked through the testing steps.

Question: should this also apply to the cataloging page as an export
option? It doesn't now.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:49:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:49:00 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-tWamJvyF0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97103|0                           |1
        is obsolete|                            |

--- Comment #55 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100291&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:49:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:49:06 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-JOwIG2Awus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97104|0                           |1
        is obsolete|                            |

--- Comment #56 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100292&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:49:12 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-CB4dxpIPSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97105|0                           |1
        is obsolete|                            |

--- Comment #57 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100293&action=edit
Bug 17385: QA Critics Fixed and added Missing Filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:50:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 19:50:35 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-p1ymBu2NSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:16:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:16:42 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-EwEJqMcWXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100221|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 100294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100294&action=edit
Bug 23531: Fix ILS-DI non-implemented but documented parameters

Koha's ILS-DI service does not implement the "needed_before_date" and
"pickup_expiry_date" parameters for holds, although they are documented.

This patch changes the parameter names and implements them:
- needed_before_date => start_date
- pickup_expiry_date => expiry_date

Test plan:
1) Enable the ISL-DI system preference.
2) Submit a hold request using ILS-DI with "needed_before_date" and
"pickp_expiry_date" parameters, for example (change the bib_id, item_id, and
dates as appropriate):
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&needed_before_date=2020-03-12&pickup_expiry_date=2020-03-31&pickup_location=CPL
3) Check that the dates in the request are NOT shown for the hold (go to the
item record and then the holds section):
- Date: will show the current date, rather than the needed_before_date entered
- Expiration: will be empty, rather than the pickup_expiry_date entered
4) Delete the hold.
5) Apply the patch.
6) Resubmit the hold request in step 2 using "start_date" and "expiry_date"
parameters, for example:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&start_date=2020-03-12&expiry_date=2020-03-31&pickup_location=CPL
7) Check that dates shown for the hold are now correct:
- Date: will show the start_date entered
- Expiration: will show the expiry_date entered
8) Check that the tests pass (prove t/db_dependent/ILSDI_Services.t)
9) Sign off!

Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com>

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:16:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:16:45 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-6aqDkEBzjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100222|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <david at davidnind.com> ---
Created attachment 100295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100295&action=edit
Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:19:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:19:00 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-iPljz9EpIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #21 from David Nind <david at davidnind.com> ---
(In reply to Arthur Suzuki from comment #18)
> Yup, had some issues with my remotes configuration, just got to learn that
> one shall not use gitlab anymore.
> Patch should apply now.
> Arthur

Thanks Arthur for fixing _ I'm not sure I would have been much help working out
what was wrong 8-) I also updated the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:20:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:20:39 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-3gzMI6gPwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #22 from David Nind <david at davidnind.com> ---
In the test plan "the ISL-DI system preference" should be "the ILS-DI system
preference"!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:23:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:23:14 +0000
Subject: [Koha-bugs] [Bug 24713] JavaScript error on staff client catalog
 search results page
In-Reply-To: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24713-70-BxP51b0Ozu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch modifies the
      release notes|                            |output of template toolkit
                   |                            |variables so that values in
                   |                            |the in-page JavaScript are
                   |                            |quoted. This avoids
                   |                            |JavaScript errors when the
                   |                            |template variable is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:38:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:38:20 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-PFMNAB4ERq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100267|0                           |1
        is obsolete|                            |

--- Comment #5 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100296&action=edit
Bug 23925: Value builder plugin to check ISBN validity

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:40:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:40:19 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-vBrGf3dMPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99696|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 100297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100297&action=edit
Bug 22771: Respect nonfiling indicators for search fields

Strip initial characters from search fields in accordance with
nonfiling character indicators.

To test:

1) Apply patch
2) Run tests in t/Koha/SearchEngine/Elasticsearch.t
3) All tests should pass

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:40:23 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-G7xKGYEWXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100270|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 100298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100298&action=edit
Bug 22771: Fix mistakes in list of nonfiling character fields

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:43:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:43:49 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-bdClH6VuLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

--- Comment #6 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100299&action=edit
incorrect display of input field when the ISBN is wrong

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:44:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:44:36 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-UPQfI91anf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

--- Comment #7 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100300&action=edit
correct display of input field when the ISBN is wrong

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:49:54 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-tOQYeGKiCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr

--- Comment #8 from Andreas Roussos <a.roussos at dataly.gr> ---
I've tested the plugin on both a MARC21 and a UNIMARC installation
and it works fine, except for a minor hiccup in the display of the
highlighted input field when the ISBN is incorrect (see attached
screenshots).

This is due to a couple of missing CSS classes for the HTML <input>
element. I will provide a follow-up that addresses this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:55:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:55:41 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-fkN3ZLYFpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 22:55:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 21:55:44 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-tOX58BIRVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

--- Comment #9 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100301&action=edit
Bug 23925: (follow-up) Add missing CSS classes

The highlighted input field for an incorrect ISBN was displayed
incorrectly -- this patch fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 23:44:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 22:44:45 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-VsVf0v9Lvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #58 from David Nind <david at davidnind.com> ---
Thanks Gabriel, the patch now applies!

I've changed the status to Failed QA as:
- The test plan indicates it should be available for carts and lists: carts
work, for lists there is no option to download (only shows RIS, BibTeX, ISBD,
MARC as options).
- The tests don't pass for me.

root at ffb0d824040d:koha(bz17385)$ prove t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. Global symbol "$builder" requires explicit package
name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line
28.
Global symbol "$builder" requires explicit package name (did you forget to
declare "my $builder"?) at t/db_dependent/XSLT.t line 77.
Global symbol "$builder" requires explicit package name (did you forget to
declare "my $builder"?) at t/db_dependent/XSLT.t line 85.
Global symbol "$builder" requires explicit package name (did you forget to
declare "my $builder"?) at t/db_dependent/XSLT.t line 95.
Execution of t/db_dependent/XSLT.t aborted due to compilation errors.
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/XSLT.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests 

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
Files=1, Tests=0,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.87 cusr  0.09
csys =  0.99 CPU)
Result: FAIL

root at ffb0d824040d:koha(bz17385)$ prove t/XSLT.t
t/XSLT.t .. 2/12 
#   Failed test 'CustomXSLTExportList finds custom XSLTs'
#   at t/XSLT.t line 107.

#   Failed test 'Title is specified in root node'
#   at t/XSLT.t line 108.
Use of uninitialized value in string eq at t/XSLT.t line 109.

#   Failed test 'Title is filename if not specified'
#   at t/XSLT.t line 109.
# Looks like you failed 3 tests of 12.
t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/12 subtests 

Test Summary Report
-------------------
t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3)
  Failed tests:  10-12
  Non-zero exit status: 3
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  3.63 cusr  0.14
csys =  3.79 CPU)
Result: FAIL

Notes from testing:
- Need to enable 'Custom' option for OpacExportOptions system preference.
- Naming:
  . For cart shows as: XSL - Simple Export
  . System preference OpacExportOptions shows as: Custom
  . Staff interface save shows as: Simple Export (from the sample .xsl file)
  . OPAC save record shows as: Simple Export (from the sample .xsl file)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 00:35:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 23:35:15 +0000
Subject: [Koha-bugs] [Bug 24825] New: circulation-home.tt is missing [% SET
 footerjs = 1 %]
Message-ID: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

            Bug ID: 24825
           Summary: circulation-home.tt is missing [% SET footerjs = 1 %]
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

circulation-home.tt does not have [% SET footerjs = 1 %], therefore
javascript/jQuery are impossible on this page.

TO RECERATE:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 00:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 23:42:07 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-SKp4Y7X6vo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 00:42:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2020 23:42:09 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-HK46I87qbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100302&action=edit
Bug 24825: Add [% SET footerjs = 1 %] to circulation-home.tt

TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 04:38:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 03:38:22 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-bfDaq8ixrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 04:38:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 03:38:24 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-XXnOKV66MY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100215|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 100303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100303&action=edit
Bug 24817: Add sleep between db create actions

We need to allow some time to pass between calls that add cash register
lines to accountlines or cash_register_actions. We use database level
triggers to maintain the timestamp fields, so cannot use Time::Fake, and
the methods we are testing assume that, as human interactions, there
will be at least a second between the last 'sale' on a cash register and
the 'cashup' of that same cash register.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 04:38:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 03:38:27 +0000
Subject: [Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-vfqkfZJxFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100275|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 100304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100304&action=edit
Bug 24817: Horrible cludge date setting to remove sleep

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 06:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 05:22:31 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-QEvXIWaNql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 06:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 05:22:35 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-y2AGjtM8C2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100269|0                           |1
        is obsolete|                            |

--- Comment #18 from David Nind <david at davidnind.com> ---
Created attachment 100305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100305&action=edit
Bug 24754: Set userenv for ilsdi requests

Currently ILSDI scripts do not have a userenv set. This affects both
action_logs and statistics.

For action_logs we either get no user or, if there is an active session, we use
that one. This can have unintended consequences and we should explicitly set
the env so that system user (0) is recorded

For statistics we need to specify a branch to record for actions like renewals.
With bug 24759 we add an items method for this. We should take advantage of
this method and use the 'opac' interface as the ilsdi scripts live there.

To test:
1 - Enable ILS-DI in systempreferences
2 - Checkout an item to a patron
3 - Enable Renewal logs (RenewalLog system preference)
4 - Ensure you will be able to renew the item several times
5 - Open an incognito/private browser
6 - Renew item via ilsdi:
   
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
7 - Check action logs, interface may be random, user should be 0, if not make
sure the user in step 9 is a different one
8 - In private browser open a new tab
9 - Sign in to staff client
10 - Return to other tab
11 - Refresh page to repeat renewal
12 - Check action_logs
13 - The second renewal indicates it was renewed via intranet by logged in
staff member
14 - Apply patch
15 - restart_all
16 - Ensure staff client still signed in
17 - Repeate renewal again
18 - Check logs, renewal now indicates opac again (as it should), user is 0
even if logged in on other tab

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:10:25 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-SPG7ekDra8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:10:28 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-jhKGCTw3qw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100043|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 100306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100306&action=edit
Bug 24627: Correct style of clubs search results during hold process

This patch updates some markup and CSS so that the process of selecting
a club from search results during the hold process looks the same as
when selecting a patron: Club names should be links (like patron
names are) and the table row should have a hover color to help indicate
that it is clickable.

This patch also changes the markup of the Patrons/Clubs tabs a little
bit to make the information clearer: Superfluous Bootstrap-related tab
markup has been removed, and the patron and club search results have
been moved into their respective tab containers. This means that if you
search for a patron but then switch to the clubs tab the patron list
doesn't still display.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - You should have more than one patron club defined.
 - Begin the process of placing a hold on a title.
 - Test the process of searching for both patrons and clubs.
   - In each case the name (patron or club) should be an active link.
   - Hovering your mouse over the table rows should change the row
     background to yellow.
   - Clicking the other tab at this stage should hide the search results
     from your last search.
   - Whether you click the linked name or elsewhere in the table row
     you should be correctly redirected to the next step in the holds
     process.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:34:10 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-WCtrA4Jf6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #23 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
\o/
Many thanks for your help and fixing typo :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:52:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:52:34 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-kkfTFbEQbr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:52:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:52:37 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-yY22iyKK3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100302|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100307&action=edit
Bug 24825: Add [% SET footerjs = 1 %] to circulation-home.tt

TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 07:55:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 06:55:33 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-7jcwFSbrKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Hi Lucas.

I have signed this off as this fixes the issue on the circulation page, however
the same thing occurs on these pages:

- Tools
- Tools > Patron card creator
- Reports
- Reports > Items with no checkouts
- Circulation > Set library
- Circulation > Transfer
- Circulation > Overdues with fines

Not sure whether these should be fixed in this bug, or a new bug(s) created.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 10:14:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 09:14:09 +0000
Subject: [Koha-bugs] [Bug 20576]
 t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t fails if
 Elasticsearch is configured but not running
In-Reply-To: <bug-20576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20576-70-UhNvXtCdxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20576

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Patch no longer applies:

Applying: Bug 20576: Skip gracefully with a meaningful message
Using index info to reconstruct a base tree...
M       t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
CONFLICT (content): Merge conflict in
t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20576: Skip gracefully with a meaningful message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 10:43:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 09:43:53 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-eBjyMkNHT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 10:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 09:43:56 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-y3JAXoEkWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100268|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100308&action=edit
Bug 24823: Drop Catmandu dependency

Replace remaining Catmandu dependant code with the Search::Elasticsearch
equivalent.

To test:
1) Apply patch
2) Run tests in t/Koha/SearchEngine/Elasticsearch.t,
t/Koha/SearchEngine/ElasticSearch/*
and t/db_dependent/Koha/SearchEngine/*
3) All tests should pass

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 16:03:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 15:03:00 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-B6xwYiVDha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100309&action=edit
Bug 24378: Correct wording in AUTO_RENEWAL notice

Test Plan:
- install patch
- update databse
- confirm notice name is now in sentence-case
- confirm too-many error text now reads "reached" rather than "reach"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 16:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 15:05:05 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-ZWYvY1aqmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Easy fix to change that word, and I also adjusted the notice name while I was
in there. But I'm not putting this to needs signoff yet because for some reason
this notice isn't actually getting created in master and I'm not sure why. Will
get some wiser eyes on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 16:05:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2020 15:05:16 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-ok2cmkIvcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 02:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 01:07:24 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-Aq4lcLc4CI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

George Veranis <gveranis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gveranis at gmail.com

--- Comment #1 from George Veranis <gveranis at gmail.com> ---
That happen as a side-effect of bug 14570 "Make it possible to add multiple
guarantors to a record" . The truth is when we have only one guarantor would be
helpful to have some fields pre-filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 07:58:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 06:58:12 +0000
Subject: [Koha-bugs] [Bug 24826] New: Use of uninitialized value $mail{"Cc"}
 in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
Message-ID: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

            Bug ID: 24826
           Summary: Use of uninitialized value $mail{"Cc"} in substitution
                    (s///) at /usr/share/perl5/Mail/Sendmail.pm
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mjnkml at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In my cron email for Cron <root at koha> koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl:


Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16.
U
.
.
.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 07:58:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 06:58:33 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-8X0WsXraKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

mjnkml at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjnkml at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:42:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:42:01 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-dKVZXRqUwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100310&action=edit
Bug 24402: About template corrections

With the 20.05 team we introduced and expanded some roles.  This patch
adds support for:

* removal of the release maintainer for development releases
* a list of documentation managers
* a list of packaging manager

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:50:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:50:31 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-eKC91eTaQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100311&action=edit
Screenshot of 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:52:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:52:08 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-IbDo4NxH3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100312&action=edit
Screenshot of 19.12 (20.05 Development Version)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:52:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:52:51 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-6wKcYF5nUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch needs testing in both 19.11 and master as the resultant output is
different between the two.. screenshots included to show results as I see them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:54:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:54:47 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-kmSY4TK5Mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The patch corrects the behaviour for documentation and packaging roles, which
both change from a single field to an array with the creation of the 20.05
team.

It also removes the 'Release maintainer' title from the 'Current team' block
when we are 'in development' as at this stage there is not release maintainer
for the branch (it's in development, so the responsibility lies with the
release manager)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 09:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 08:55:17 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-8HqxiDys0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 12:24:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 11:24:25 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-2mPwwpYFJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Catmandu::Store::ElasticSearch is still used in
Koha/SearchEngine/Elasticsearch/Browse.pm. So either this code should be
replaced too, or it can be done in another bug but the commit message should be
updated to clarify that.

In any case, please update the cpanfile accordingly.

Also, QA script returns 1 spelling error in
Koha/SearchEngine/Elasticsearch/Indexer.pm: 
occured  ==> occurred

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 19:32:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 18:32:57 +0000
Subject: [Koha-bugs] [Bug 24827] New: MARC preview fails when staged record
 contains items with UTF-8 characters
Message-ID: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

            Bug ID: 24827
           Summary: MARC preview fails when staged record contains items
                    with UTF-8 characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: a.roussos at dataly.gr
        QA Contact: testopia at bugs.koha-community.org

The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not specify 'UTF-8' as the optional encoding to use.

In intranet-error.log you'll get messages such as:
showmarc.pl: XSLT_Handler: :63: parser error : PCDATA invalid Char value 27
showmarc.pl:     <subfield code="o">889.3 \x1b(SVAU\x1bs</subfield>

I suggest we fix this by explicitly specifying 'UTF-8' as the encoding
to use whenever a call to new_from_xml() is made across the codebase.

For consistency, I also propose to standardise on the encoding name in
direct calls to new_from_xml(), and use 'UTF-8' from now on instead of
'utf8' or 'utf-8'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 19:36:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 18:36:56 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-5om2ne3O7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr
                   |ity.org                     |

--- Comment #1 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100313&action=edit
MARC preview failure

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 19:38:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 18:38:13 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-iQvzPoEVLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100314&action=edit
MARC preview working OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 19:40:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 18:40:40 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-cAzDW22GQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #3 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100315&action=edit
test record with embedded items containing UTF-8 data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:40:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:40:11 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-nTlLfAXoDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:40:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:40:56 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-3vbM63EKi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:41:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:41:00 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-DHbgU2m5zj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99379|0                           |1
        is obsolete|                            |

--- Comment #36 from Michal Denar <black23 at gmail.com> ---
Created attachment 100316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100316&action=edit
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

This patch allows merging of records with many items without the web server
timing out.

Test plan:

Without the patch:

- Create 2 records (one with e.g. 1000 items).
- Do a cataloguing search that displays both records, select them and click
"Merge selected".
- Choose the record with many items as the one to be eliminated.
- Start the merging.
- After a while the web server should give you a timeout error (the merging
process may still continue)

With the patch:
- Do the same as above
- This time verify that the records are merged without timeout
- Create a new biblio with an item
- Add with the item:
  * acquisition order
  * hold (reserve)
- Merge the biblio to another one
- Verify that the item and its related data was moved
- Verify that tests pass:
  prove -v t/db_dependent/Koha/Item.t
  prove -v t/db_dependent/Items/MoveItemFromBiblio.t

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:49:52 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-J82lE3vvLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:49:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:49:55 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-2wq0ANCxPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100178|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Denar <black23 at gmail.com> ---
Created attachment 100317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100317&action=edit
Bug 24809: Get only timestamp of deleted items attached to existing bibs when
check if bib deleted

To test:
 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml
 2 - Set sysprefs:
  OAI-PMH => Enable
  OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml
 3 - View a record with items and confirm the items show:
 
http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4
 4 - Delete the items, then delete the record
 5 - Reload the URL from step 3
 6 - Internal Server Error:
  Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58.
    at /usr/share/perl/5.24/Carp.pm line 167
 7 - Apply patch
 8 - restart_all
 9 - Repeat
10 - Reload URL from step 3
11 - Success

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:50:27 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-rTFehxK1FI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:51:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:51:55 +0000
Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization
 logic
In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24067-70-nPv17r93D2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:53:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:53:16 +0000
Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization
 logic
In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24067-70-bMOl15GPM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067

--- Comment #7 from Michal Denar <black23 at gmail.com> ---
Hi Lari,
can you rebase this patch?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:53:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:53:59 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-PdP8RDS879@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:54:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:54:17 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-YbvAdlB6ts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:58:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:58:48 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-9Y1RK78OAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:58:52 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-ulLdwNZgIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100296|0                           |1
        is obsolete|                            |
 Attachment #100301|0                           |1
        is obsolete|                            |

--- Comment #10 from Michal Denar <black23 at gmail.com> ---
Created attachment 100318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100318&action=edit
Bug 23925: Value builder plugin to check ISBN validity

This patch adds a new value builder plugin ISBN.pl, which should
be attached to field 020a. The plugin will perform a simple
checksum checking when trying to save the record, and inform the
user that the ISBN is illegal if the checksum doesn't match.

The ISBN plugin is a test case for additional value builder plugin
functionality that lets the plugins check field values and
prevent saving if so desired. The example plugin has been updated
with information on how to write a pre-save check function.

To test:
1) Add the ISBN.pl plugin to the field 020a in MARC subfield
   structure admin.
2) Go to cataloguing and try to save the record, no complaints
   about the ISBN (Because the plugin will not complain about
   empty field)
3) Enter something in the 020a field and try to save, you should
   receive a complaint about illegal ISBN.
4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save,
   there should be no complaints about the ISBN.

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 22:58:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 21:58:55 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-s5NAHWuEJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

--- Comment #11 from Michal Denar <black23 at gmail.com> ---
Created attachment 100319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100319&action=edit
Bug 23925: (follow-up) Add missing CSS classes

The highlighted input field for an incorrect ISBN was displayed
incorrectly -- this patch fixes that.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:00:17 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-ez6jCCLYXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:12:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:12:45 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-AvwGdOdHFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:12:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:12:48 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-nWG6aSLuKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #4 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100320&action=edit
Bug 24827: Specify UTF-8 as encoding in new_from_xml()

The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not explicitly specify 'UTF-8' as the optional encoding to use.

This patch fixes that, and also standardises the encoding name used in
direct calls to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'.

Test plan (in a MARC21 instance):
0) Stage for import the test record attached to this bug report (make
   sure that 'Check for embedded item record data?' is set to 'Yes'),
   then go to Home > Tools > Manage staged MARC records and click on
   the filename you've just staged.
1) In the 'Citation' column, click on the hyperlink to launch the MARC
   preview -- notice how it fails to produce any output apart from the
   modal heading.
2) Apply the patch, and restart Plack if necessary.
3) Re-launch the MARC preview: this time the output should include the
   whole record, including the embedded item data in field 952.
4) Run the unit tests to ensure nothing was broken inadvertently:
   $ prove t
   $ prove xt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:28:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:28:30 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-t7x7L6cnsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:28:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:28:33 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-XVQwJiRgbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98941|0                           |1
        is obsolete|                            |
  Attachment #99549|0                           |1
        is obsolete|                            |

--- Comment #9 from Michal Denar <black23 at gmail.com> ---
Created attachment 100321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100321&action=edit
Bug 8595: Rename 'host item' to 'host record'

To test:

1) Enable the syspref EasyAnalyticalRecords
2) Find a biblio record, go to the detail page
3) Click the Edit dropdown and notice the option "Link to host item"
4) Apply patch and refresh page
5) Click the Edit dropdown and confirm the renamed "Link to host record"
button

Sponsored-by: Catalyst IT

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Change makes sense, no errors.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 23:28:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2020 22:28:36 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-LDAoETmAib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

--- Comment #10 from Michal Denar <black23 at gmail.com> ---
Created attachment 100322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100322&action=edit
Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host
record'

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 01:08:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 00:08:11 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-meh5rukxrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

--- Comment #71 from David Cook <dcook at prosentient.com.au> ---
Should this one be marked as "Pushed to stable" now?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 08:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 07:39:02 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-Qh7MXxEHop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > Wouldnt it be better to return undef or empty string in case of template use?
> > If it is concatenated somewhere, we get a 0 in between ?
> 
> Returning undef triggered this error in the QA tool:
> 
> "# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s)."

This has to do with syntax. You should not write "return undef" but you write
"return;". In scalar context you return undef, in list context empty list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:27:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 08:27:43 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-XtNuj6Pf0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add sleep calls to          |Fix timing issues in
                   |Koha::Cash::Register test   |t/db_dependant/Koha/Cash/Re
                   |                            |gister.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:19:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:19:49 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-oL5JKlRNlc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #33 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Agustín Moyano from comment #32)
> seems timezone is not saved in date_due column, because it's a datetime
> rather than timestamp

Good spot Agustín! Since we're wanting to take into account the timezone during
storage and display, I think you're right, a timestamp column would make more
sense.

> Maybe we can alter that column to timestamp, so timezone is saved, or I can
> add a flag to the JS function in 24455 to use timezone or not

Modifying the column seems the proper way to do this. Since the data stored in
a datetime / timestamp column is the same (it's just whether it's considered to
be UTC or not that varies).

However, it's not clear to me how the migration would work though. Currently
everything in date_due is stored in whatever the client's timezone was and
displayed as-is. However, if we convert it to timestamp, it will then be
considered to be UTC and adjusted as appropriate for display at the client. But
because it wasn't stored as UTC, this will lead to incorrect times being
displayed. Since we've no way of knowing the timezone of the client storing the
value, I'm not sure how we can compensate for this.

Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:20:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:20:08 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-7yDG1OboFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90100|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100323&action=edit
Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth

Bug 14407 introduced a new system preference to allow limiting the
online self checkout system to an IP or IP Range. The function that
handles this is called in_ipset, which is the name of a linux tool. To
stop confusion, this patch renames the function to 'in_iprange', and the
variable 'ipset' within it to 'iprange'.

To test, follow the test plans outlined in Bug 14407 and confirm that
everything works as expected.

Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:20:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:20:11 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-ZH0frqf4gS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100324&action=edit
Bug 22943: (QA follow-up) Add new cases

A few additional cases were introduced since the original bug was
authored. This patch simply catches those cases and makes the same
change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:20:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:20:40 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-QJlulVYvlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
My apologies, I'd missed that you had submitted a patch here Hayley... Signing
off :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:31:16 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-NaCx9JsveS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91693|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100325&action=edit
Bug 23357: Check if generating a duplicate print notice before generating
notice

To test:
 1 - Check out an overdue to a patron
 2 - Set a notice trigger for the same number of days overdue for the patrons
patron type
 3 - Set the trigger to send via email and sms
     You may need to define SMSSendDriver preference to enable SMS, you can put
'Email'
 4 - perl misc/cronjobs/overdue_notices.pl -v -t
 5 - Check the patrons record, 1 notice generated
 6 - Check the db:
     SELECT * FROM message_queue;
 7 - Note the message 'Overdue notices' contains a doulbed content for the
notice
 8 - DELETE * FROM message_queue;
 9 - Apply patch
10 - perl misc/cronjobs/overdue_notices.pl -v -t
11 - Chekc the patron's account, 1 message in 'Notices'
12 - Check the DB
     SELECT * FROM message_queue;
13 - The 'Overdue notices' notice is not doubled

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:31:55 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-C3Je5EHRgY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Code scans well and test plan passes.  No obvious regressions, signing off.

Thanks Nick

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:34:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:34:48 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-H8UXgRLvyD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:34:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:34:51 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-82HVfPVecr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100303|0                           |1
        is obsolete|                            |
 Attachment #100304|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100326&action=edit
Bug 24817: Add sleep between db create actions

We need to allow some time to pass between calls that add cash register
lines to accountlines or cash_register_actions. We use database level
triggers to maintain the timestamp fields, so cannot use Time::Fake, and
the methods we are testing assume that, as human interactions, there
will be at least a second between the last 'sale' on a cash register and
the 'cashup' of that same cash register.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:34:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:34:55 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-GBEwmeEuTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100327&action=edit
Bug 24817: Horrible cludge date setting to remove sleep

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:35:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:35:48 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-pCtbmQXfUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not think that's horrible. It's basically what we really want to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:37:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:37:00 +0000
Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and
 syspref values to help understand why a hold is possible or not
In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23732-70-UlW9dVOeWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|victor at tuxayo.net           |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:43:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:43:47 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-n8EpzuvSx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95898|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100328&action=edit
Bug 19288: Don't show patron info for item level holds on details.pl unless
hold is waiting

This persists after bug 20948 - we can still display patron information even if
this patron is not the one
who will receive the item upon checkin. The holds tab can give an overview of
holds and information - I think
on the details page the only info we need is whether there might be a item
level hold, not who it is for

To test:
1 - Place an item level hold for delivery at a branch not matching home branch
of item
2 - Place a record level hold for delivery at homebranch of item placed on hold
above
3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home
library'
4 - View the details for the page, it says the item has a hold for the patron
with an item level hold
5 - Check in the item, the hold triggered is for the next available patron,
ignore the hold
6 - Apply patch
7 - Check details page, 'There is an item-level hold (priority=1)' with no
patron info
8 - Check in, next available hold is still the one triggered

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:44:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:44:19 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-OKGHHpUYWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Had to rebase this to apply it.. works as expected.. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:46:46 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-8T4hkvGXgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Signed off as it does what's described.. would be interested in an update from
Andrew or Kelly regarding the requirements however prior to a QA run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:48:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:48:28 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-4Bcou20tuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91812|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100329&action=edit
Bug 23383: fix IdRef syspref test in XSLT

IdRef link is displayed via XSLT.
There is a test of syspref with just if value is defined.
But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by
default, which is true in XPATH.
We should test that pref is 1.

Test plan :
1) Create a fresh UNIMARC database
2) You have pref IdRef disabled
3) Simulate a SUDOC record:
  Fill a 7..$3 field with a ppn (032581270 for example).
  Fill the 009 field with an integer
4) Go to the opac detail page of the record => You don't see IdRef link
5) Enable IdRef syspref
6) Go to the opac detail page of the record => You see IdRef link
7) Disable IdRef syspref
8) Go to the opac detail page of the record => You don't see IdRef link

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:50:15 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-0P3C0PSlXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice catch Fridolin,

Code scans well and I believe would do as expected.  I agree, looking at the
code Bernardo's point makes sense.. I don't have  Unimarc test set here so
haven't directly tested but I can't see that though would cause a negative
regression so am signing off anyway to let it move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:52:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:52:47 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-SYUEKrNKa4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, 

I think I thought the ITS format may be marginally more functional that our own
so I wondered if rather than removal we should fully document it.

Were there copyright issues that required it's removal perhaps.. if so I'd love
to see any missing functionality added into our own macro format as part of a
removal?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:53:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:53:23 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-PXlbER6D2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 09:53:47 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-vgw3KExmtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Adding Kyle to the CC list as one of the few other people out there able to
work on and test EDI patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:02:54 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-yWPTuhFYnF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95455|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100330&action=edit
Bug 19279: performance of linked items in search

When catalog has fields 773 (461 in UNIMARC), those linked items are fetched
for display in search results.
Looks like the code could be more performant by replacing item search by $9
with direct call with GetMarcItem().

Test plan :
1) Enable system preference EasyAnalyticalRecords
2) Get a record A with a lot of items, it will be the 'Host record'
3) Click on 'Analytics' on this record
4) On one of its items (say item A1) click on 'Create analytics' to
create record B
5) Enter the same title as record A and all mandatory fields
6) Edit field 773 (461 in UNIMARC)
6) Check that $0 contains the biblionumber of record A
7) Check that $9 contains the itemnumber of item A1
8) Perform a search on record A title, be sure you see record B with
other results
=> Compare execution times with and without patch

Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:04:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:04:34 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-ursIO4RAMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Digging deeper into the code here I'm confident in this not creating
regressions.. My fear was that it may produce regressions for non EasyAnalytics
systems, but as the changed code in question is inside a block that is only
triggered when EasyAnalytics is enabled we are safe on that front.

Otherwise, the code is pretty clear and makes sense.. following the plan it all
works as expected. 

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:08:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:08:37 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-6JnqkGCEpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95996|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100331&action=edit
Bug 24172: Allow translation of seasons in serials-edit.tt and
subscription-detail.tt

Seasons are not handled by locales.  Those generated are stored in
English in the database, and the display in serials-collection.tt is
translating them.  But once you click on "Edit serials" or if you go
straight to the subscription's display, those are displayed as in the
database: in English.

This patch reproduces the same trick as in serial-collection.tt and
allow for the display to be translated.

NOTE: this patch's testing require knowledge of translation tools.

Reproducing Caroline's test:
0- Make sure you have at least one language other than English installed
1- With staff interface in English, create a subscription with a seasonal
numbering pattern and frequency, with locale in your other language
2- Check the prediction pattern, note that the season names are in English not
the locale language
3- Change the staff interface to other language, redo the prediction pattern
test with locale in other language, note that the season names are in other
language
4- Save the subscription
5- Receive an issue, note that the season name in the "Numbered" column on
serials-edit.pl is in English
6- Save your issue
7- Switch interface in other language
8- Note that the season name on serials-collection is in other language
9- If you check the database, you will see the season name is in English, even
though the subscription.locale is something else
10- validate the different pages:
- serials-collection.pl: display is translated
- serials-edit.pl: name pulled directly from db
- subscription-detail.pl: name pulled directly from db
- detail.pl: name pulled directly from db
- opac-detail.pl: name pulled directly from db
11- APPLY THE PATCH
12- translate the string
  a) ./translate update <some locale>
  b) find the strings, translate them
  c) ./translate install <same locale>
13- restart Plack ?
14- validate the pages again.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:08:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:08:40 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-gWPzdfAVYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96051|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100332&action=edit
Bug 24172: Allow translation of seasons in details.tt and opac-details.tt

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:10:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:10:37 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-iju38cgPxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This works as expected so I'm signing it off...

But.. I would really like to see the logic factored out into an include file.
It seems ripe for such a factoring task and would lead to less code to maintain
and thus a lower likelihood of future mistakes in this area.

I'd really like to see the above addressed as part of QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:21:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:21:59 +0000
Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql
 portnumber
In-Reply-To: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23141-70-uV73pEx3sb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, mtj at kohaaloha.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:22:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:22:19 +0000
Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql
 portnumber
In-Reply-To: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23141-70-nSzTGIDLjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Adding a few more people to the cc list to get some fresh eyes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:25:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:25:22 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-vyutMSEx9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96360|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100334&action=edit
Bug 24250: Do not duplicate debarred comment in patron screen message AF field

Caused by
  commit bddfed75913a2302c19c00b00a6fe86538af6f9f
  Bug 19933: Remove patronflags - tricky ones

Test plan:
1 - Setup SIP in your testing environment
    https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
2 - Set a patron to have a restriction
3 - Send a patron status request or patron information command via
    the SIP cli emulator (see link above)
4 - Note the comment on the restriction is sent only once

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:25:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:25:41 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-PIv4DLzkPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as described.. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:29:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:29:16 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-P3957oHHVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:30:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:30:55 +0000
Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages
In-Reply-To: <bug-15860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15860-70-BX6W2EqGwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |WONTFIX

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> We come up with a totally different approach to this with bug 22835. While
> this is still valid for legacy plugins, I suggest we push everyone into
> updating their plugins.

Agreed.. marking this as WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:37:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:37:44 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-pGjSFtD1ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #10)
> I do not think that's horrible. It's basically what we really want to test.

Thanks Jonathan.. think I'll reword the commit message on push.. I was in a
down mood by the end of Friday..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:39:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:39:30 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-5zS1epvfvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100326|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100335&action=edit
Bug 24817: Add sleep between db create actions

We need to allow some time to pass between calls that add cash register
lines to accountlines or cash_register_actions. We use database level
triggers to maintain the timestamp fields, so cannot use Time::Fake, and
the methods we are testing assume that, as human interactions, there
will be at least a second between the last 'sale' on a cash register and
the 'cashup' of that same cash register.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:39:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:39:33 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-19QEeqcNbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100336&action=edit
Bug 24817: Replace sleep calls with date setting in test data

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:39:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:39:47 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-asE1EHCWDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100327|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:40:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:40:12 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-Z12Zydbd7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:40:14 +0000
Subject: [Koha-bugs] [Bug 24817] Fix timing issues in
 t/db_dependant/Koha/Cash/Register.t
In-Reply-To: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24817-70-yZLd6fkKy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:47:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:47:34 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-bjAxGHLujK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Thanks for pointing this out, I was working with a slightly outdated master not
containing the cpanfile and Browse.pm changes. Have now rebased against latest
master and fixed the spelling error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:49:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 10:49:22 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-0TaobUhbbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100337&action=edit
Bug 24823: Fix spelling error and remove last of Catmandu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:02:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:02:09 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-HqgSddK0N8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #3)
> Adding Kyle to the CC list as one of the few other people out there able to
> work on and test EDI patches.

This change will not affect the EDI plugins I maintain. In fact, in my plugins
I made the GIR subfield limit configurable, as some vendors require the 5 field
limit and so do not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:19:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:19:21 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-lD4DnAebTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:19:24 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-kT6CoT9VpL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94874|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100338&action=edit
Bug 23926 Limit GIR segment to 5 pieces of info

Strictly if a GIR segment contains more than 5 pieces
of information the it should be encoded in repeated
segments each of 5 elements or less each sharing the same
copy sequence number

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:21:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:21:05 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-cvHxczG5HG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #22)

So basically nothing was working, thanks for having caught that Nick!

> I tested the following, let me know if i missed elsewhere:
>   editing patron satff
>   editing patron opac
>   importing patron
>   patron creation/update via ldap
> 
> Branch limitations do not save

Fixed.

> Cannot load patron if attribute value not in authorized values (OK, but
> should have a way to identify)

Fixed, I will also open a bug report.

> Opac update of attributes fails, blank value passed to update request

Fixed.

> Patron import with 'replace only included attributes' fails
> Can't use string ("Koha::Patron::Attribute") as a HASH ref while "strict
> refs" in use at /kohadevbox/koha/Koha/Object.pm line 625

Fixed.

> Attributes in ILSDI shows some extra info:
> borrowernumber, authorised_value_category - is noisier than without patch

Yes, I let a FIXME in the code (which refers to bug 14257 comment 15). I would
be happy to fix it you have an idea about what's best here.

> Test failures:
> Test Summary Report
> -------------------
> t/00-testcritic.t                 (Wstat: 256 Tests: 1020 Failed: 1)
>   Failed test:  732
>   Non-zero exit status: 1
> t/00-valid-xml.t                  (Wstat: 512 Tests: 135 Failed: 2)
>   Failed tests:  1-2
>   Non-zero exit status: 2
> t/Logger.t                        (Wstat: 256 Tests: 1 Failed: 1)
>   Failed test:  1
>   Non-zero exit status: 1

They pass for me. Maybe not related to this patchset?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:31:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:31:06 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-5KgpuaPzca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92649|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100339&action=edit
Bug 23562: Only one authorities search in header

In authorities module, header contains 4 authorities search, from "main heading
$a" to "entire record".
This is more a search option than really different searches.
I propose to merge them into only one with a select for where to search.
This allow to always keep current search options.

This patch also adds title arguemnt on comboboxes to say what the represent.
Also changes submit button text with "Search" like in many places.

Since there is a new combobox, a CSS rule need to be added to have an input
text of 20em instead of 30em.

Test plan :
1) Go to Authorities module
2) Choose a value different from fist in all comboboxes of header
3) Enter a text in input
4) Click on submit
5) Check that all values and text are kept
6) Perform search with each value of "Where" combobox and check results are OK

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:31:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:31:30 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-ryeP67ZO5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice little enhancement, Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:33:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:33:52 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-XTXcBH7OWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #102 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree about the tests, but with all the API work - Doesn't it makes sense to
centralize all the checks needed instead of repeating (and forgetting them) all
over the place? The general idea makes sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:39:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:39:27 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-p8MhbLBZNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to Owen Leonard from comment #4)
> > I think this patch makes perfectly logical sense but is a step backwards in
> > terms of usability. The tabs allow for a more compact form, whereas with
> > this patch the browser window needs to be fairly wide to accommodate it.
> 
> OK.
> Do you think it will be better if we add the hiding/show of some options,
> like in patron search (the little [+]) ?

Hmm, I see both sides of this.. I wonder if the 'sort order' could be removed..
it's not so much to do with the search itself but the results and as such feels
to me like it doesn't entirely belong here anyway.

That would help reduce the width of the field search element somewhat... I sort
of like the [+] option as an alternative too, but though I'd throw this idea
into the mix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:44:56 +0000
Subject: [Koha-bugs] [Bug 24828] New: Add cash register support to SIP2
Message-ID: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

            Bug ID: 24828
           Summary: Add cash register support to SIP2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 23321
            Blocks: 13985

We add support for defining cash registers with bug 23321, however, these
registers are currently only available for transactions via the staff client.
We should also be able to add a register definition for a SIP client and assign
transactions to it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:44:56 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23321-70-mg2CcLHTSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828
[Bug 24828] Add cash register support to SIP2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:44:56 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-UN1PFilJj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828
[Bug 24828] Add cash register support to SIP2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:45:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 11:45:02 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-9T0qb8abOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:17:41 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-vX6Rs1l72Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm going to knock this one up to PQA as the two people most authoritative
about EDI have now been involved :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:17:41 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-9EN9JKCKjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:17:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:17:48 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-SHE6ScD0tC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99392|0                           |1
        is obsolete|                            |
  Attachment #99393|0                           |1
        is obsolete|                            |
  Attachment #99394|0                           |1
        is obsolete|                            |
  Attachment #99395|0                           |1
        is obsolete|                            |

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100340&action=edit
Bug 13897: Use YAML files for installer data

This patch modifies C4/Installer.pm to add support
for loading YAML files into database.

As an example of the functionality, optional
auth_val.sql file is replaced by auth_val.yml

The rationale behind this feature is to enable the
translation of the data that is loaded into the
database. That will be addressed in another bug.

But taking into account that goal, translatable
values are declared in the YAML files, to ease
identification by translate script.

Also file description is moved into the yaml
file.

To test:
0) Do a clean install with all optional data,
   then dump authorised_values table, reserve.
1) Apply the patch
2) Do a clean install in English (marc21/unimarc)
3) On optional data check for description of auth_val
   "Some basic default authorised values for ..."
4) Select all optional data
5) Finish installation
6) Dump again authorised_values table and compare with that
   of point '0'.
   No differences should be found.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:17:53 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-6wksJ8k5mG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100341&action=edit
Bug 13897: Catch the error and warn it

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:17:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:17:57 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-FAZhtMaEJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100342&action=edit
Bug 13897: Process description, multiline values and SQL statements in YAML
files

This patch adds 3 features:
1) Display description of YAML files at install time
   for frameworks, and fixes it's encoding.
2) Enable use of multiline values, field required
3) Process SQL statements declared in YAML files

With this features we can process files with the
following generic YAML strucure:

  ---
  description:
    - "File description"

  tables:
    - table_name:
        translatable: [ title, content ]
        multiline: [ content ]
        rows:
          - title: "Example title"
            content:
              - "Content:"
              - ""
              - "This is the content."
            id: 1
            value: ~

  sql_statements:
    - "UPDATE table_name SET value ='empty' WHERE value IS NULL"
  ...

* file description is now inside the YAML, can have multiple
  lines.
  This attribute is expected in all YAML files.
* translatable attribute in table declare fields that can be
  translated
* multiline attribute in table declare fields that can have
  multiple lines of content, they are joined using '\r\n'
  before insert into database.
  This is useful to express fields like 'news' content, and
  to simplify it's translation.
  '\r\n' is used for correct display in Windows clients.
* sql_statements allows to add multiple SQL sentences, not
  insertions normally, that are executed in order.

This features are not needed for the example file of this patch,
but will be used in new bugs.

To test:
1) Use the same test plan of first patch.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:18:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:18:02 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-xtyOI3p700@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100343&action=edit
Bug 13897: Surround columns with backticks

We have some column's names that need to be surrounded by ` as they are
protected keywords ('rows' for instance)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:18:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:18:47 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-PRq6o7bJo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:18:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:18:50 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-dVWTyLfeTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99396|0                           |1
        is obsolete|                            |
 Attachment #100194|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100344&action=edit
Bug 24262: Translate installer data in YAML format

This patch adds the ability to:
1) Create new translation files from yaml installer files
2) Create installer directory for a given language

It will not create a installer directory if it already exists.

New (possible) translation files:
  xx-YY-installer.po
  xx-YY-installer-MARC21.po
  xx-YY-installer-UNIMARC.po

Needs Bug 13897 (for yaml files)

NOTE: updated version adding ability to process multiline
fields, discard small ( < 2) strings, and discard strings
with pure html, TT or punctuation.

To test:
1) Apply patches from Bug 13897
2) Apply this patch
3) Go to misc/translation
4) Create translation files for a NEW language
   $ ./translate create xx-YY

   check new file 'xx-YY-installer.po'

5) Copy ../../installer/data/mysql/en/optional/auth_val.yml
   into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/
   and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/

   remove po/xx-YY*, then repeat creation

   check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po'
   and 'xx-YY-installer-UNIMARC.po'

   remove all new files

6) Create for xx-YY again and try update
   $ ./translate create xx-YY
   edit ../../installer/data/mysql/en/optional/auth_val.yml
   and change one char in one of the translatable values,
   also edit 'xx-YY-installer.po', translate the same
   string (in msgstr).

   Do an update
   $ ./translate update xx-YY

   check in 'xx-YY-installer.po' a fuzzy value for the
   translated value and the preservation of the translation
   Fix the translation, or add a new one.

7) Create an install dir for xx-YY
   ./translate install xx-YY

    Check new dir '../../installer/data/mysql/xx-YY/'
    Check files on it
    $ tree ../../installer/data/mysql/xx-YY/
    and compare with ../../installer/data/mysql/en/

    All installation files must be present

8) Try a new Koha install using this language in the
   usual way.
   Check in authorised_values table for the translated string.

9) Try create an install dir for an existing language
   (eg. es-ES, de-DE or fr-FR ), eg.
   ./translate install de-DE

   Install dir is detected and not changed, a note is printed.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:18:54 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-YI84EaJ0DH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100345&action=edit
Bug 24262: (followup) admit null values on labels

This patch adds handling of null values on translatable
labels.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:38 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-xMSCw9m7tk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:41 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-bA9AiDNVPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99397|0                           |1
        is obsolete|                            |
  Attachment #99398|0                           |1
        is obsolete|                            |
  Attachment #99399|0                           |1
        is obsolete|                            |
  Attachment #99400|0                           |1
        is obsolete|                            |
  Attachment #99401|0                           |1
        is obsolete|                            |
 Attachment #100195|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100346&action=edit
Bug 24583: Rewrite mandatory/auth_values to YAML

YAML version of mandatory auth_values.

To test:
1) Do a clean install, dump auth_values, reserve.

2) Apply this patch and it's dependencies

3) Do a clean install, dump again and compare
   No differences expected

4) Try translation
  a) Go to misc/translator
  b) create files for a new language
     ./translate create xx-YY
  c) Check new file po/xx-YY-instaler.po
     Verify strings from this file.
  d) Install new language
     ./translate install xx-YY
  e) Try clean install with new files

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:45 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-6uwUQfD8EF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100347&action=edit
Bug 24583: Rewrite mandatory/class_sources to YAML

YAML version of mandatory class_sources

To test:
1) Same test plan of first patch, only check tables
   class_sort_rules, class_split_rules and class_sources

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:48 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-Lb44ZiEpkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100348&action=edit
Bug 24583: Rewrite mandatory/sample_frequencies to YAML

YAML version of mandatory sample_frequencies

To test:
1) Same test plan of first patch, only check table
   subscription_frequencies

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:54 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-JcGbKfJNOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100349&action=edit
Bug 24583: Rewrite mandatory/sample_notices to YAML

YAML version of mandatory sample_notices

To test:
1) Same test plan of first patch, only check table
   letter

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:19:58 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-HHN2ZQTudV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100350&action=edit
Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML

YAML version of mandatory sample_numberpatterns

To test:
1) Same test plan of first patch, only check table
   subscription_numberpatterns

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:01 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-NN8DrYCca6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100351&action=edit
Bug 24583: (followup) restore null values to labels

This patch adds null values to selected label2/3 in
sample numberpatterns

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:42 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-bwQLkkR0ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:45 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-vHcHbYrhVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99402|0                           |1
        is obsolete|                            |
  Attachment #99403|0                           |1
        is obsolete|                            |
  Attachment #99404|0                           |1
        is obsolete|                            |
  Attachment #99405|0                           |1
        is obsolete|                            |
  Attachment #99406|0                           |1
        is obsolete|                            |
  Attachment #99407|0                           |1
        is obsolete|                            |
  Attachment #99408|0                           |1
        is obsolete|                            |
  Attachment #99409|0                           |1
        is obsolete|                            |
  Attachment #99410|0                           |1
        is obsolete|                            |
  Attachment #99411|0                           |1
        is obsolete|                            |
  Attachment #99412|0                           |1
        is obsolete|                            |
  Attachment #99413|0                           |1
        is obsolete|                            |
  Attachment #99414|0                           |1
        is obsolete|                            |
  Attachment #99415|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100352&action=edit
Bug 24584: Rewrite optional/csv_profiles to YAML

YAML version of optional csv_profiles.

To test:
1) Do a clean install with optional data,
   dump table export_format, reserve.

2) Apply this patch and it's dependencies

3) Do a clean install, dump again and compare
   No major differences expected

4) Try translation
  a) Go to misc/translator
  b) create files for a new language
     ./translate create xx-YY
  c) Check new file po/xx-YY-instaler.po
     Verify strings from this file.
  d) Install new language
     ./translate install xx-YY
  e) Try clean install with new files

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:49 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-y7p4cbzMbk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100353&action=edit
Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML

YAML version of optional marc21_holdings_coded_values

To test:
1) Same test plan of first patch, only check table
   authorised_values

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:54 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-OGYAfTavyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100354&action=edit
Bug 24584: Rewrite optional/marc21_relatorterms to YAML

YAML version of optional marc21_relatorterms

To test:
1) Same test plan of first patch, only check table
   authorised_values

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:20:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:20:57 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-ZrpJVmK4DT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100355&action=edit
Bug 24584: Rewrite optional/parameters to YAML

YAML version of optional parameters

To test:
1) Same test plan of first patch, only check table
   currency

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:01 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-G8bDmHykU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100356&action=edit
Bug 24584: Rewrite optional/patron_atributes to YAML

YAML version of optional patron_atributes

To test:
1) Same test plan of first patch, only check table
   borrower_attribute_types

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:05 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-kQsTs2T4JT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100357&action=edit
Bug 24584: Rewrite optional/patron_categories to YAML

YAML version of optional patron_categories

To test:
1) Same test plan of first patch, only check table
   categories

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:09 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-LyHjQ1NNfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100358&action=edit
Bug 24584: Rewrite optional/sample_creator_data to YAML

YAML version of optional sample_creator_data

To test:
1) Same test plan of first patch, only check tables
   creator_layouts, creator_templates and printers_profile

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:13 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-kYFR6LlSEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100359&action=edit
Bug 24584: Rewrite optional/sample_itemtypes to YAML

YAML version of optional sample_itemtypes

To test:
1) Same test plan of first patch, only check table
   itemtypes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:17 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-GOFnTxWiPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100360&action=edit
Bug 24584: Rewrite optional/sample_libraries to YAML

YAML version of optional sample_libraries

To test:
1) Same test plan of first patch, only check table
   branches

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:20 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-Fx1zDoJUfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100361&action=edit
Bug 24584: Rewrite optional/sample_libraries_holidays to YAML

YAML version of optional sample_libraries_holidays

To test:
1) Same test plan of first patch, only check table
   repeatable_holidays

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:24 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-wyI4AMKW8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100362&action=edit
Bug 24584: Rewrite optional/sample_news to YAML

YAML version of optional sample_news

To test:
1) Same test plan of first patch, only check table
   opac_news

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:28 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-Uk4bdeHyUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100363&action=edit
Bug 24584: Rewrite optional/sample_patrons to YAML

YAML version of optional sample_patrons

To test:
1) Same test plan of first patch, only check table
   borrowers

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:33 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-YFm9pqSK0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100364&action=edit
Bug 24584: Rewrite optional/sample_quotes to YAML

YAML version of optional sample_quotes

To test:
1) Same test plan of first patch, only check table
   quotes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:21:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:21:37 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-7GhxHqdmGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100365&action=edit
Bug 24584: Rewrite optional/sample_z3950_servers to YAML

YAML version of optional sample_z3950_servers

To test:
1) Same test plan of first patch, only check table
   z3950servers

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:22:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:22:10 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-RzLV5jqiJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:22:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:22:13 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-mZz5uCskaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99416|0                           |1
        is obsolete|                            |
  Attachment #99417|0                           |1
        is obsolete|                            |
  Attachment #99418|0                           |1
        is obsolete|                            |
 Attachment #100139|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100366&action=edit
Bug 24593: Rewrite marc21_default_matching_rules to YAML

YAML version of marc21 optional marc21_default_matching_rules.

To test:
1) Do a clean install with optional data,
   dump table marc_matchers, reserve.

2) Apply this patch and it's dependencies

3) Do a clean install, dump again and compare
   No major differences expected

4) Try translation
  a) Go to misc/translator
  b) create files for a new language
     ./translate create xx-YY
  c) Check new file po/xx-YY-instaler-MARC21.po
     Verify strings from this file.
  d) Install new language
     ./translate install xx-YY
  e) Try clean install with new files

NOTE: This patch fails with qa tools!
Reason is that qa tools use YAML.pm module to
check files, but Installer.pm or LangInstaller.pm
are using YAML::Syck, using that module gives
no error, check for example:

perl -e 'use YAML::Syck qw( LoadFile ); $y =
LoadFile("marc21_default_matching_rules.yml");'
No error!

perl -e 'use YAML qw( LoadFile ); $y =
LoadFile("marc21_default_matching_rules.yml");'
Error!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:22:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:22:16 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-icEqet48Z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100367&action=edit
Bug 24593: Rewrite marc21_sample_fastadd_framework to YAML

YAML version of marc21_sample_fastadd_framework

To test:
1) Same test plan of first patch

NOTE: Same problem as first patch with qa tools
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:22:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:22:21 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-fjXfD7X2gq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100368&action=edit
Bug 24593: Rewrite marc21_simple_bib_frameworks to YAML

YAML version of marc21_simple_bib_frameworks

To test:
1) Same test plan of first patch

NOTE: Same problem as first patch with qa tools
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:22:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:22:25 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-708ZUPUL1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100369&action=edit
Bug 24593: (followup) fix sql statements

Original inserted values depends on the order of insertion.
This patch rewrites the sql statements to make them order
independent

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:23:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:23:12 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-O1vOlF7E6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 13:24:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 12:24:37 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-4oGpG1jBGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have PQAed the whole stack, see the remote branch.
Signed off patched for this bug report are there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:07:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:07:44 +0000
Subject: [Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref
In-Reply-To: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22622-70-moIgEK7fhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:07:46 +0000
Subject: [Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref
In-Reply-To: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22622-70-0dSxJcJpb1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87317|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100370&action=edit
Bug 22622: Add Koha::Object method _new_from_hashref

It may be useful to be able to instantiate a Koha::Object from data already
fetched from the database. This might be used for compatibility with legacy
code, or perhaps for use with optimized queries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:21 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-lXpaSYFfdR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99686|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100371&action=edit
Bug 24052: Rename XSLT_Handler

Should be XSLT::Base now.
Removes old XSLT_Handler stub too (from bug 23290).
Result of a git grep | sed statement.

Test plan:
Run qa tools (so modules compile).
Run t/db_dependent/Breeding.t
Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch
has been applied; see subsequent patch.)
Enable XSLT use on results and details display. Check search results and
detail view on OPAC and staff.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:25 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-2S3ja84V70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99687|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100372&action=edit
Bug 24052: Fix Koha/XSLT/Base.t

Moving the separate small attachments into the test script.
Creating them now as temporary files or code fragments.
Deleting original files.

Since Breeding.t also used one of these files, a similar change was made in
that script.

Test plan:
Run t/db_dependent/Koha/XSLT/Base.t. Should pass now.
Run t/db_dependent/Breeding.t again.
Git grep on XSLT_Handler. You should only find release notes.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:29 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-SmkGEvVofm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100373&action=edit
Bug 24052: Catch warning between test 5 and 6

Resolve:
ok 5 - Engine returns error on undefined text
XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214.
ok 6 - Engine returns error on empty string

Test plan:
Run perl Base.t and verify that this warning is no longer printed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:34 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-76r7pjpcVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99689|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100374&action=edit
Bug 24052: Add koha_xslt_security to koha-conf.xml

The line for enabling the unsafe expand_entities option is commented
and includes a warning to keep it like that ;)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:45 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-glwj4kEe6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
I also played around with some structural template changes that could be
applied more globally. This is one area where we need better responsive
layouts. I think this patch can move forward without a "solution," but I did
notice one other thing while I was tinkering:

Now that we're not using tabs to switch between searches we really should add
the other tabs which are generally found there: Check out, Check in, Renew,
Search the catalog.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:10:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:10:59 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-m14UwFyDz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:11:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:11:01 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-HSo8zaJufC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99688|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:13:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:13:00 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-XCPPLxsMDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #3)
> Should this be master in the version?

IIRC I reproduced the bug on master. Does in no longer happen on master for
you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:13:36 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-2446ZqSlfJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Martin,

In our (DGI's) experience, the ITS functionality in Koha isn't completely
compatible with a macro exported out of ITS. 

In all cases I was able to create a Koha macro functionally the same as the ITS
macro (albeit in multiple lines where the ITS version may have had 1).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:13:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:13:39 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-KDikPzmuLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:16:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:16:09 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-UKQ7dfTUBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23787

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:16:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:16:09 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-oIa2y9ROSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24378

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:17:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:17:59 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-n08h6YIRUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm editing the wording of this notice in updatedatabse over in Bug 24378. The
English version has some grammatical errors and other issues. We should make
sure those changes get reflected in both places.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:28:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:28:02 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-w3U6NoaVKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #19 from Frank Hansen <frank.hansen at ub.lu.se> ---
Hi,

> 0/ It would be useful to test the update DB entry on a big and old
> production DB, to make sure the constraints will be added correctly.

Here in Lund we have tested your fix on a clone of our production DB with over
90000 subscriptions and the short story is that we are satisfied of what the
fix accomplish. 

> 2/ Make sure you can upgrade from a master install
This step went well, no errors.
I think it is good that orphaned entries is removed before creating the FK
constraints. It turned out in our case there were data that were migrated from
our previous system by mistake. So the subscription was actually deleted in the
old system. So, we didn't lose any important data anyway.

> 3/ Create a subscription, serial, etc. and delete the biblio
> => The subscription/serials should have been deleted from the DB
The fix does what it should. And the performance has also improved
significantly which is important from my perspective.

> 4/ Create a subscription, serial, etc. and delete the subscription
> => The serials should have been deleted from the DB
The fix does what it should. Works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:33:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:33:48 +0000
Subject: [Koha-bugs] [Bug 24829] New: ClaimReturnedWarningThreshold is
 always triggered if patron has one or more claims
Message-ID: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

            Bug ID: 24829
           Summary: ClaimReturnedWarningThreshold is always triggered if
                    patron has one or more claims
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has
more than the number of claims specified in the system preference. Currently
the warning is displayed for any number of claims over zero.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:33:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:33:58 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-WGGlw4PGQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:35:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:35:49 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-dzuJsWHDer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That's good to know Cori, sounds like we can indeed nuke it then. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:37:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:37:11 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-BXyrvfqFjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:37:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:37:13 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-eMB7A479nu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100375&action=edit
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one
or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has
more than the number of claims specified in the system preference. Currently
the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:38:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:38:32 +0000
Subject: [Koha-bugs] [Bug 23562] Only one authorities search in header
In-Reply-To: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23562-70-OveyPc7jES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good call Owen.. I did wonder about the inconsistency in the lack of tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:39:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:39:46 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-YX5l17iH1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:42:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:42:45 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-qSYFpqWYik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #50)
> This generally seems to work.. but I'm no SIP expert and the code is hard to
> follow at the best of times.
> 
> I would love to see the actually logging statements look more like elsewhere
> in Koha... this will be the third form for calling a Koha::Logger based log
> and is more confusing by the fact it keeps the 'syslog' name so if someone
> is keen to add more statements they may go looking for Sys::Syslog
> documentation and get mislead.

I would be happy to change the subroutine name. We kept it up to this point
just to make fewer cuts and reduce merge conflicts!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:46:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:46:27 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-QJ8BG7hE5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96510|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100376&action=edit
Bug 24276: First change indent

No other changes than whitespace, guys.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:46:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:46:31 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-HZDDySzRXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96511|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100377&action=edit
Bug 24276: Add FillWithDefaultValues call in neworderempty

Apply mandatory defaults from the ACQ framework to records from external
source in Acquisition.

Test plan:
[1] Add 'BK' as mandatory default in ACQ framework for 942$c.
[2] Add order to basket via external source.
[3] Check 942$c on detail page of new record, MARC tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:46:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:46:35 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-9HLh8e1a7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96513|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100378&action=edit
Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues

Test plan:
Run t/db_dependent/Acquisition/FillWithDefaultValues.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:46:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:46:55 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-HYCQFwAvuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased. Please test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:48:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:48:06 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-s9xMjVsO9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|caroline.cyr-la-rose at inlibr |andrew at bywatersolutions.com
                   |o.com                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:49:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:49:28 +0000
Subject: [Koha-bugs] [Bug 24830] New: dbic_merge_prefetch is not handling
 recursive cases correctly
Message-ID: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

            Bug ID: 24830
           Summary: dbic_merge_prefetch is not handling recursive cases
                    correctly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In the context of bug 20212, I noticed that requesting to embed basket and
basket.basket_group yields no basket is prefetch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:50:16 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-4AvO30hPud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24356
           Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
[Bug 24356] objects.search prefetch
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:50:16 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-YkMFR80Dt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830
[Bug 24830] dbic_merge_prefetch is not handling recursive cases correctly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:50:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:50:59 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-RDjmD9lpMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100379&action=edit
Bug 15253: Rename syslog() to log()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:51:41 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-aTm9fsaslQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:51:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:51:44 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-LoIyicpdwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100244|0                           |1
        is obsolete|                            |

--- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100380&action=edit
Bug 24083: Required atomic updates & DB update

This patch adds:

- An "UnseenRenewals" circulation syspref that enables/disables the
  functionality added in this bug

- Add unseen_renewals_allowed to circulation_rules

- A change to the issues & old_issues table schemas and corresponding
  database upgrades to add issues.unseen_renewals &
  old_issues.unseen_renewals

- An update for the renewals letter to include a message for unseen
  renewals

Signed-off-by: Sally Healey <sally.Healey at cheshirewestandchester.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:51:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:51:47 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-PFQAPrDKit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100245|0                           |1
        is obsolete|                            |

--- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100381&action=edit
Bug 24083: Add circ rules management

This patch adds the ability to set the "Unseen renewals allowed" value
in the circulation rules

Signed-off-by: Sally Healey <sally.Healey at cheshirewestandchester.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:51:51 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-t3ehNvs3yZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100246|0                           |1
        is obsolete|                            |

--- Comment #26 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100382&action=edit
Bug 24083: Add support for unseen_renewals

This patch adds support for unseen renewals.

Here we retrofit knowledge of unseen renewals and add the display of unseen
renewal counts and warnings, in addition to adding the ability to
specify a renewal as being "unseen".

The functionality added here is goverened by the UnseenRenewals syspref.

Signed-off-by: Sally Healey <sally.Healey at cheshirewestandchester.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:51:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:51:54 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-ng3oUDAMaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100247|0                           |1
        is obsolete|                            |

--- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100383&action=edit
Bug 24083: Add unit tests

This patch adds unit tests for unseen renewals

Signed-off-by: Sally Healey <sally.Healey at cheshirewestandchester.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 13:59:27 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-XT9XNxgAqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I also noticed the relation+count case is not being handled correctly (i.e. it
won't be prefetch).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:01:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:01:28 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-RAS77KC1Bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:08:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:08:54 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-2ETFzv0dia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:22 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-YRXH3DlWts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:24 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-gHa5j6IjED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:27 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-yI3djn9ytg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:28 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-KhAroZlpcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:30 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-bhfcXNcSXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:32 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-CYhVx2RJt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:34 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-D96tzhe6WR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:36 +0000
Subject: [Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
In-Reply-To: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24584-70-T7mWJSo0CQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:37 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-JPoTbpneNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:39 +0000
Subject: [Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
In-Reply-To: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24593-70-c5YWE0suJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:41 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-FtInoe9CgN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:12:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:12:43 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-i6Nrlj5PsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:26:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:26:25 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-FdF0J5YyKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100384&action=edit
Bug 21901: Add a warning if we removed entries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:27:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:27:05 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-zTnYOLDr8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have added a follow-up to display a warning message if entries are going to
be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:30:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:30:39 +0000
Subject: [Koha-bugs] [Bug 24831] New: deleting a bib with tag weight should
 decrease weight of tag
Message-ID: <bug-24831-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24831

            Bug ID: 24831
           Summary: deleting a bib with tag weight should decrease weight
                    of tag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If you have a record with a tag(s) and that biblio gets deleted it should
trigger fix_tags_weight.pl to decrease that tag

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:30:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:30:54 +0000
Subject: [Koha-bugs] [Bug 24831] deleting a bib with tag weight should
 decrease weight of tag
In-Reply-To: <bug-24831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24831-70-4CCaIan0U4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24831

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:32:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:32:39 +0000
Subject: [Koha-bugs] [Bug 24832] New: superlibrarian should have tools to
 delete notices
Message-ID: <bug-24832-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24832

            Bug ID: 24832
           Summary: superlibrarian should have tools to delete notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

It would be helpful if the superlibrarian had the ability to delete one, some,
or all of the notices in a user account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:55:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:55:33 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-Zngyiejjqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Which report, do you have an example?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:56:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:56:16 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-hOZOCyzAGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100385&action=edit
Bug 24828: Add ability to specify cash register in SIP config

This patch adds the ablity to specify a cash register id to link to
payments taken via SIP2 clients.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 14:56:36 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-TU8YImGZNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:00:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:00:24 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-GZKp9KugAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100386&action=edit
Bug 24545: Cannot return outside of sub

We must die instead

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:01:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:01:15 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-du5TGhMSFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:01:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:01:15 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-FKiqL6ESOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830
[Bug 24830] dbic_merge_prefetch is not handling recursive cases correctly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:05:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:05:59 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-JR7biWFlvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:06:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:06:02 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-XuR3odevhw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100387&action=edit
Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it

This patch adds the adds the JS Footer to all the pages which lack it:
TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden. Check these other pages to make
sure the logo is hidden here to:
- Tools
- Tools > Patron card creator
- Reports
- Reports > Items with no checkouts
- Circulation > Set library
- Circulation > Transfer
- Circulation > Overdues with fines

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:06:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:06:29 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-TJwFrqSdzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100307|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:07:36 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-xnKNTkEDTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Thanks for looking David, I have added a new patch that encompasses all the
pages you discovered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:10:21 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-yLLDIPC19b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100388&action=edit
Bug 24594: Fix license statements

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:15:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:15:18 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-roazXAMdMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100389&action=edit
Bug 24583: adjust xt/sample_notices.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:18:12 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-gpDgyI6508@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100388|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100390&action=edit
Bug 24594: Fix license statements

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:19:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:19:23 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-g5RFFnrxc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100389|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100391&action=edit
Bug 24583: adjust xt/sample_notices.t

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:19:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:19:49 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-zsVW50rRwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:19:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:19:52 +0000
Subject: [Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
In-Reply-To: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24583-70-EZ9WpfZdz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:19:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:19:55 +0000
Subject: [Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
In-Reply-To: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24594-70-R5RajZHyIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:21:27 +0000
Subject: [Koha-bugs] [Bug 24816] Test suite execution time
In-Reply-To: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24816-70-NkB0l11PAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
On D8:
koha_1       | [10:55:44] t/db_dependent/api/v1/oauth.t
........................................... ok     2013 ms

On D9:
15:35:25 koha_1       | [14:35:25] t/db_dependent/api/v1/oauth.t
........................................... skipped:
Net::OAuth2::AuthorizationServer not available

It's 2 seconds, and it's the reverse :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:23:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:23:47 +0000
Subject: [Koha-bugs] [Bug 24816] Test suite execution time
In-Reply-To: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24816-70-EZITmUHN6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> On D8:
> koha_1       | [10:55:44] t/db_dependent/api/v1/oauth.t
> ........................................... ok     2013 ms
> 
> On D9:
> 15:35:25 koha_1       | [14:35:25] t/db_dependent/api/v1/oauth.t
> ........................................... skipped:
> Net::OAuth2::AuthorizationServer not available
> 
> It's 2 seconds, and it's the reverse :)

It was just an example.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:29:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:29:25 +0000
Subject: [Koha-bugs] [Bug 24816] Test suite execution time
In-Reply-To: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24816-70-4DLwdd1nZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I've activated the "timestamp in output log" for all Master jobs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:36:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 15:36:39 +0000
Subject: [Koha-bugs] [Bug 24833] New: Field ending punctuation needs to
 consider abrreviations and exceptions
Message-ID: <bug-24833-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833

            Bug ID: 24833
           Summary: Field ending punctuation needs to consider
                    abrreviations and exceptions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 24094 made some improvements to reconciling the ending punctuation form the
bibliographic record to the authority, however, it still lacks consistency.

>From comment 10 on bug 24094:
*If* one wanted to build a list of exceptions of authority punctuation that
would need to be kept, here are a few places to start (from an incomplete
U.S./Library of Congress perspective):
- etc.
- B.C.
- A.D.
- a period following a single letter (as in an initial)
- Dr.
- Jr.
- Mrs.
- Co.
- Dept.
- Inc.
- hyphen (-)
- closing parenthesis )
- question mark ?
- exclamation point !

If this is the path taken, I strongly recommend this list be expanded to be
inclusive of punctuation and abbreviations used in authority records of
languages other than American English. It could probably use a few more English
exceptions, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:06:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:06:54 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-jQwcLZcSxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

--- Comment #28 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100392&action=edit
Bug 24083: (follow-up) Fix params to AddRenewal

The merging of Bug 23051 has added a paramter that can be passed to
C4::AddRenewal. This bug does also, so the offset of this bug's new
paramter was wrong. This patch fixes it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:10:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:10:50 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-zvpeXjM7iV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #2 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100393&action=edit
Bug 24830: Fix parse_prefetch recursion and +count cases

When a child of a prefetched element wasn't found on element's
prefetch_whitelist, no prefetch element was returned.. including element
it self. Now we return element's name if no child was found.

Also, embeded keys that ended with +count where taken literaly. Now we
search the correct key by stripping _count of embedded element if it was
declared as "is_count"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:25:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:25:43 +0000
Subject: [Koha-bugs] [Bug 24834] New: Display report number after running
Message-ID: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834

            Bug ID: 24834
           Summary: Display report number after running
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: madamyk at ckls.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 100394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100394&action=edit
Some potential places to display report number

It would be helpful to have a report display its number next to the report name
after running. Currently, this information can be taken from the URL but
displaying it directly would be great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:26:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:26:55 +0000
Subject: [Koha-bugs] [Bug 24834] Display report number after running
In-Reply-To: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24834-70-utWea63Yb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834

--- Comment #1 from madamyk at ckls.org ---
This is my first bug submission, so please let me know if I haven't followed
correct protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:32:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:32:25 +0000
Subject: [Koha-bugs] [Bug 24559] Elasticsearch - add support for 'year'
 fields
In-Reply-To: <bug-24559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24559-70-8iecSx8Nzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Elasticsearch - add support |Elasticsearch - add support
                   |for 'date' fields           |for 'year' fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:33:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:33:16 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-tuWzydUEtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:45:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:45:26 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-17QvDwAs3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:45:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:45:29 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-OyDM2uRjHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97974|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100395&action=edit
Bug 24518: Fix IE11 partner filtering

This patch adopts the approach detailed in comment #1.

It also fixes a couple of additional minor bugs relating to the ILL
partner list:
- Exclude partners with no email address, we cannot use them
- Quote the "value" attribute to avoid warnings displayed by IE, they
should be quoted anyway!

Test plan: USE IE11
- Apply the patch
- Define 3 ILL partner patrons (patrons in the category that has a code
that matches the <partner_code> value in the ILL config). One patron
should have no email address, the other two should have an email address
- Navigate to "Place request with partners" for an ILL request
- TEST: Observe that the patron with no email address is not displayed
- Try filtering the list
- TEST: Observe that the list filters correctly

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:59:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 16:59:59 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-vHFzzIY5xu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79598|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100396&action=edit
Bug 17845: Remove unused code related to printers

There is some quite old and unused code in Koha related
to printer configuration and network printing. These code
hasn't been functional in a long time and should be removed.

This patch:

- Removes printcirculationslips system preference
- Removes table printers
- Removes branchprinter column from branches

Check that:
- Go to administration
- Open any age there, but change the last bit to: printers.pl
- Apply patch, run the database update
- Verify the hidden page no longer exists
- Verify that logging in and out still works correctly
- Verify that checkout and returns work correctly
- Switch to another branch using the "Set library" option

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:00:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:00:02 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-Nwh1A6FJhz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100397&action=edit
Bug 17845: Update atomic update for new format

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:00:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:00:05 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-qgoe17keVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100398&action=edit
Bug 17845: (QA follow-up) Remove commented line

A commented line still refered to the removed page from the
admin-menu.inc

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:00:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:00:08 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-zAKe9bC02z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100399&action=edit
Bug 17845: (QA follow-up) Remove hidden print input

As highlighted by Jonathan, the hidden 'print' form field is no longer
read and thus no longer required in the template.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:00:12 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-7rA0NeaAPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100400&action=edit
Bug 17845: Remove some missed references to branchprinter

Remove a few last references to branchprinter, mostly from tests.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:00:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:00:32 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-qqabLD2PCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:02:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:02:06 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-KFJt6WflS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work Katrin!

It would be great to see this one finished off.. I've added a few followups to
fix the missing parts, address QA concerns and bring it up to date.. and as
such didn't feel I should PQA as part of it..

Back to you Jonathan (or any other friendly QA person)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:02:15 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-103OrxQcTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:07:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:07:38 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-lVwgsFTtZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:11:48 +0000
Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter
 features to datatables api wrapper
In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24561-70-yvLIANM6eJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100126|0                           |1
        is obsolete|                            |

--- Comment #9 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100401&action=edit
Bug 24561: Datatables api wrapper also filter and order embedded columns

This patch adds the ability to filter and order by embedded columns.

To use it you must in JS:

$('datatable_selector').api({datatables_options})

where datatables_options are all datatables options plus:

1. embed: [list of embeddable tables]
   This option adds x-koha-embed header to request.

2. header_filter: true|false
   This option if true sets x-koha-query header with stringyfied json of
filters

Oderable and searchable columns must define data option as string, otherwise
filter and order won't be possible.
If you must custom the output, use the render function.

For example:

* Don't

> $('.table_selector').api({
>   columns: [
>     {
>       data: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

* Do

> $('.table_selector').api({
>   columns: [
>     {
>       data: 'holds.patron.firstname',
>       render: function(row, type, val, meta) {
>         return '<a href="'+row.link+'">'+row.holds.patron.firstname+'</a>';
>       },
>       orderable: true,
>       searchable: true
>     }
>   ]
> });

To test you must implement and test bug 20936, where it will be used.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:11:51 +0000
Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a
 request in staff client
In-Reply-To: <bug-20708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20708-70-3mpGCnVlEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Doesnt apply clean to 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:14:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:14:41 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-uVOHf1GdGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
doesnt apply clean to 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:19:24 +0000
Subject: [Koha-bugs] [Bug 24590] Koha/Object.t is failing on MySQL 8
In-Reply-To: <bug-24590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24590-70-BcHTWaUvEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.03          |20.05.00, 19.11.03,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:22:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:22:49 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-P6ttw3pj1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.03          |20.05.00, 19.11.03,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:29:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:29:30 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-9Kiy4dIcP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #34 from Lucas Gass <lucas at bywatersolutions.com> ---
Does not cleanly apply to 19.05, will not backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:37:37 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-08hgyzOnkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
I have discussed this with the sponsor of the original development and we agree
that a syspref does not provide fine enough control. Instead, it makes sense to
include this control in the itemtype where the daily/hourly fees are also set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:37:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:37:55 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-GSt3hR5UxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:37:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:37:58 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-xLsHJbIaUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100402&action=edit
Bug 21443: Update database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:38:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:38:07 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-uWzhNPw29T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100403&action=edit
Bug 21443: Update Schema [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:38:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:38:10 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-4zOetYBrCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100404&action=edit
Bug 21443: Add ability to exclude holidays when calculating rentals fees by
time period

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:38:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:38:12 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-wHRphyJTNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100405&action=edit
Bug 21443: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:40:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:40:07 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-0E8Z5jD0Mn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:40:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:40:10 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-aQpVIOIXf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100371|0                           |1
        is obsolete|                            |
 Attachment #100372|0                           |1
        is obsolete|                            |
 Attachment #100373|0                           |1
        is obsolete|                            |
 Attachment #100374|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100406&action=edit
Bug 24052: Rename XSLT_Handler

Should be XSLT::Base now.
Removes old XSLT_Handler stub too (from bug 23290).
Result of a git grep | sed statement.

Test plan:
Run qa tools (so modules compile).
Run t/db_dependent/Breeding.t
Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch
has been applied; see subsequent patch.)
Enable XSLT use on results and details display. Check search results and
detail view on OPAC and staff.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:40:13 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-5GlYjGDrht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100407&action=edit
Bug 24052: Fix Koha/XSLT/Base.t

Moving the separate small attachments into the test script.
Creating them now as temporary files or code fragments.
Deleting original files.

Since Breeding.t also used one of these files, a similar change was made in
that script.

Test plan:
Run t/db_dependent/Koha/XSLT/Base.t. Should pass now.
Run t/db_dependent/Breeding.t again.
Git grep on XSLT_Handler. You should only find release notes.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:40:16 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-ialk2ygx2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100408&action=edit
Bug 24052: Catch warning between test 5 and 6

Resolve:
ok 5 - Engine returns error on undefined text
XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214.
ok 6 - Engine returns error on empty string

Test plan:
Run perl Base.t and verify that this warning is no longer printed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:40:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:40:19 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-5FsOj3WC1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100409&action=edit
Bug 24052: Add koha_xslt_security to koha-conf.xml

The line for enabling the unsafe expand_entities option is commented
and includes a warning to keep it like that ;)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:43:27 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-5Y1V1dGxuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Test Plan:
1) Apply this patch set
2) Restart all the things!
3) Set finesCalendar to 'noFinesWhenClosed'
4) Set up daily/hourly rental fees for an itemtype
5) Add a holiday during the rental period
4) Verify the rental fee by checking out an item
5) Uncheck the "Daily/Hourly rental fees use calendar" checkbox
6) Perform another checkout
7) This time, the rental fee should be increased by one day's fee, as it will
not longer include the holiday.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:49:54 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
 information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-ku6edgfmv5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #31 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:51:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:51:24 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-QEW4HDB3aG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:55:15 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-cxedWvqMrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:55:17 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-JyToWyIleG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100320|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100410&action=edit
Bug 24827: Specify UTF-8 as encoding in new_from_xml()

The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not explicitly specify 'UTF-8' as the optional encoding to use.

This patch fixes that, and also standardises the encoding name used in
direct calls to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'.

Test plan (in a MARC21 instance):
0) Stage for import the test record attached to this bug report (make
   sure that 'Check for embedded item record data?' is set to 'Yes'),
   then go to Home > Tools > Manage staged MARC records and click on
   the filename you've just staged.
1) In the 'Citation' column, click on the hyperlink to launch the MARC
   preview -- notice how it fails to produce any output apart from the
   modal heading.
2) Apply the patch, and restart Plack if necessary.
3) Re-launch the MARC preview: this time the output should include the
   whole record, including the embedded item data in field 952.
4) Run the unit tests to ensure nothing was broken inadvertently:
   $ prove t
   $ prove xt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:56:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 17:56:39 +0000
Subject: [Koha-bugs] [Bug 23784] Show subtitle,
 number and parts in course reserves list of items in OPAC
In-Reply-To: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23784-70-NlR2evujue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Actually, I did push this to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:00:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:00:01 +0000
Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server
In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23640-70-qyrJY2HEta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com

--- Comment #42 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:04:31 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-JbyBzaLg03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:04:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:04:33 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-BPWlyypl5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99921|0                           |1
        is obsolete|                            |
  Attachment #99922|0                           |1
        is obsolete|                            |
  Attachment #99925|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100411&action=edit
Bug 24776: Remove Borrowers.HasOverdues call

Borrowers Template Toolkit plugin contains method HasOverdues that can be
directly called from Koha::Patron object.

Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:04:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:04:36 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-Ww3ORWOCT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100412&action=edit
Bug 24776: Remove Borrowers.IsDebarred call

Borrowers Template Toolkit plugin contains method IsDebarred that can be
directly called from Koha::Patron object.

Also in template circ/returns.tt, when patron is restricted and checkin was
backdated, var "patron" is undefined, should be "issue.patron".

Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should
still be restricted."

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:04:38 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-NKBOr3WV8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100413&action=edit
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:07:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:07:15 +0000
Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe'
 attribute mapping defeats database constraints
In-Reply-To: <bug-16719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16719-70-xPsFK7RnT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:18:31 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-Ltoat8J8xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:18:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:18:33 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-RxI7By8XI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98281|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100414&action=edit
Bug 24565: Add patron profile to ILL list pages

We need the API call to get ILL requests on the patron profile page,
this commit allows this.

Test plan:
- Do not apply the patch.
- Go to the "Ill requests history" page for a patron who has made ILL
  requests
- TEST: Observe that no requests are displayed
- Apply the patch
- Refresh the page
- TEST: Observe that requests are displayed
- Go to the main "ILL requests" page
- TEST: Observe that requests are displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:36:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:36:03 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-HpfwkEsmIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:36:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 18:36:41 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-8uZU95ncXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 19:14:29 +0000
Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor
In-Reply-To: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13305-70-BkacNt87o6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:18:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 19:18:38 +0000
Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return
 Date
In-Reply-To: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24516-70-oaZHA18sgX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04.
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:30:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 19:30:32 +0000
Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not
 remove all data it created
In-Reply-To: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22860-70-mrdSphkQ6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 19:30:45 +0000
Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not
 remove all data it created
In-Reply-To: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22860-70-IW7NvaCbKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:05:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:05:13 +0000
Subject: [Koha-bugs] [Bug 11281] Add column configuration to 'Holds awaiting
 pickup' tables allowing to print both tables separately
In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11281-70-5I3RGCB9Yi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:11:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:11:38 +0000
Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339
 cannot handle high precision seconds
In-Reply-To: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24643-70-yx3SjyP4PY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:29:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:29:23 +0000
Subject: [Koha-bugs] [Bug 24649] Cloning item subfields misses a <li> tag
In-Reply-To: <bug-24649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24649-70-oySZprmEb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24649

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:33:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:33:56 +0000
Subject: [Koha-bugs] [Bug 13574] Repeatable item subfields don't show
 correctly in MARC view (OPAC and staff)
In-Reply-To: <bug-13574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13574-70-zQs8gYjvDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:38:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:38:12 +0000
Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with
 ElasticSearch
In-Reply-To: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24506-70-4nJfXnECbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:41:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:41:03 +0000
Subject: [Koha-bugs] [Bug 19930] Dropbox mode statistical report
In-Reply-To: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19930-70-83RsMLkECF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19930

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:42:33 +0000
Subject: [Koha-bugs] [Bug 24315] Set flag "Book drop" in check-in statistics
In-Reply-To: <bug-24315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24315-70-ZP2L38Z97h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24315

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Michal Denar <black23 at gmail.com> ---


*** This bug has been marked as a duplicate of bug 19930 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:42:33 +0000
Subject: [Koha-bugs] [Bug 19930] Dropbox mode statistical report
In-Reply-To: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19930-70-8KiTHFIhs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19930

--- Comment #1 from Michal Denar <black23 at gmail.com> ---
*** Bug 24315 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 20:42:57 +0000
Subject: [Koha-bugs] [Bug 19930] Dropbox mode statistical report
In-Reply-To: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19930-70-8sciyCfcMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19930

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 22:14:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 21:14:47 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-qdeEr0c2OW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thx Owen !
Shall I add your signoff line or would you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 22:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 21:16:05 +0000
Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to
 255 characters
In-Reply-To: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20882-70-JkgsCiCdWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 23:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 22:08:19 +0000
Subject: [Koha-bugs] [Bug 24835] New: Bad PCDATA explodes search with a
 Software ERROR.
Message-ID: <bug-24835-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24835

            Bug ID: 24835
           Summary: Bad PCDATA explodes search with a Software ERROR.
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Lisa.Beinhoff at ttuhsc.edu
        QA Contact: testopia at bugs.koha-community.org

Searching in the public library catalog for a record with bad PCDATA, causes
the following error to appear:

Software error:
Invalid data, cannot decode object (id=75430, format=marcxml, schema=MARC21,
decoding_error=':94: parser error : PCDATA invalid Char value 27
construction of the Metacarpal Hand -- 21. The Mutilated Wrist -- 22.
Krukenberg
                                                                               
^
:94: parser error : PCDATA invalid Char value 27
struction of the Metacarpal Hand -- 21. The Mutilated Wrist -- 22.
Krukenbergb2
                                                                               
^')
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.


Error generated in staff view is:

There is an error with this bibliographic record, the view may be degraded.
Error: Invalid data, cannot decode object (id=75430, format=marcxml,
schema=MARC21, decoding_error=':94: parser error : PCDATA invalid Char value 27
construction of the Metacarpal Hand -- 21. The Mutilated Wrist -- 22.
Krukenberg ^ :94: parser error : PCDATA invalid Char value 27 struction of the
Metacarpal Hand -- 21. The Mutilated Wrist -- 22. Krukenbergb2 ^')


Editing the record and saving the bibliographic error seems to clear the error,
for some unknown reason.  But I need a way to identify the bad records, so they
can be corrected.  About 1 in 20 records in our databases is generating this
error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 23:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 22:13:25 +0000
Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents
 template display
In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23980-70-sm8XLlFWfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to oldoldstable
         Version(s)|                            |18.11.15
        released in|                            |

--- Comment #18 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:01:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:01:57 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-nJAOshVv88@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:02:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:02:13 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-WEKtEyOfGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:02:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:02:25 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-DrKlmSxZU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:02:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:02:49 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-k0hazaf1gU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to stable

--- Comment #72 from Joy Nelson <joy at bywatersolutions.com> ---
had to cycle through :all the things: to get it there.  :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:03:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:03:28 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-p1zjGN1lby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:30:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2020 23:30:23 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-SjIzVqnY62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

--- Comment #2 from Margaret <margaret at bywatersolutions.com> ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 01:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 00:12:35 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-65h7tc91t4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> ---
Hi Jonathan,
I can give you examples; this one was uploaded 4/27/2017 and named "All Orders"
- I am pasting the sql that gets imported into the report box:



select v.name as Vendor, concat(c.basketname, ' (', c.basketno, ')') as Basket,
      c.creationdate as Ordered,  concat(p.firstname, ' ',       p.surname) as
'Managed by', b.title,       ExtractValue(bi.marcxml,
'//datafield[@tag="245"]/subfield[@code="b"]') as subtitle,       b.author,
bi.isbn, bi.publishercode,       o.rrp as RRP, o.ecost as EST, o.quantity as
Qty,       format(o.listprice*o.quantity,2) as Total, f.budget_name as Fundfrom
aqorders oleft join aqbudgets f using (budget_id)left join biblio b using
(biblionumber)left join biblioitems bi using (biblionumber)left join aqbasket c
using (basketno)left join aqbooksellers v on (c.booksellerid=v.id)left join
borrowers p on (c.authorisedby=p.borrowernumber)order by v.name, c.basketno asc

As you can see there are odd spaces, and letters are joined to words, for
example ojoin in line 6 .  The from is usually the hardest to find as it will
be merged with the word right before it in the sql. 

I will also attach a screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 01:13:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 00:13:00 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-NUEmgxdtsG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

--- Comment #4 from Kelly McElligott <kelly at bywatersolutions.com> ---
Created attachment 100415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100415&action=edit
Importing report with Mana

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 01:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 00:13:25 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-yoRq4yl9w8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 01:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 00:59:22 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice
 template
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-7qvLycB0pZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100309|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100416&action=edit
Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity

Test plan:
- install patch
- update databse
- confirm notice name is now in sentence-case
- confirm too-many error text now reads "reached" rather than "reach"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:06:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:06:06 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-I1P6Ibo36o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Change wording on           |Change wording on
                   |AUTO_RENEWALS notice        |AUTO_RENEWALS notice in
                   |template                    |updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:12:01 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-29g7OLKmUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100417&action=edit
Bug 24378: atomicupdate for new wording

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:12:32 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-GRdDanvfO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:42:33 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-kozfsbOA9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:42:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:42:36 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-1wHBmW9jCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93937|0                           |1
        is obsolete|                            |
  Attachment #94968|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100418&action=edit
Bug 23787: Add AUTO_RENEWALS in sample_notices.sql

This patch adds the AUTO_RENEWALS notice SQL insert query that was only
available in the updatedatabase script into all the language-specific
sample_notices.sql files in the installer (de-DE, en, es-ES, fr-CA, fr-FR,
it-IT, nb-NO, pl-PL, ru-RU, uk-UA).

To test, make a fresh install in a language listed above, do NOT run
updatedatabase, make sure the AUTO_RENEWALS is in the available notices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:43:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:43:42 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-zoILaB5AhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 01:45:06 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-G7aOsIhMSG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

--- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Updated Caroline's work to reflect wording changes I made over in bug 24378,
folded it-IT and atomicupdate all into one patch. Fingers crossed I didn't mess
it up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 05:49:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 04:49:04 +0000
Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return
 Date
In-Reply-To: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24516-70-ekco8pVMga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes an issue where
      release notes|                            |hiding the return date
                   |                            |column for the "Pay Fines"
                   |                            |and "Account Fines" screens
                   |                            |does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 05:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 04:56:17 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-HD4SJ2PsQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 05:56:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 04:56:20 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-521n0DkSih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100387|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 100419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100419&action=edit
Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it

This patch adds the adds the JS Footer to all the pages which lack it:
TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden. Check these other pages to make
sure the logo is hidden here to:
- Tools
- Tools > Patron card creator
- Reports
- Reports > Items with no checkouts
- Circulation > Set library
- Circulation > Transfer
- Circulation > Overdues with fines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 06:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 05:27:34 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-G5462wiNJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
Patch doesn't apply:

Applying: Bug 23787: Add AUTO_RENEWALS in sample_notices.sql
Using index info to reconstruct a base tree...
A       installer/data/mysql/en/mandatory/sample_notices.sql
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): installer/data/mysql/en/mandatory/sample_notices.sql
deleted in HEAD and modified in Bug 23787: Add AUTO_RENEWALS in
sample_notices.sql. Version Bug 23787: Add AUTO_RENEWALS in sample_notices.sql
of installer/data/mysql/en/mandatory/sample_notices.sql left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23787: Add AUTO_RENEWALS in sample_notices.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:29:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 08:29:56 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-ACLVa8Cw32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40077|0                           |1
        is obsolete|                            |
  Attachment #44756|0                           |1
        is obsolete|                            |
  Attachment #44760|0                           |1
        is obsolete|                            |
  Attachment #48310|0                           |1
        is obsolete|                            |
                 CC|                            |emmi.takkinen at outlook.com

--- Comment #21 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100420&action=edit
Bug 9525: Group floating rules

Rebased with latest version from https://github.com/KohaSuomi/kohasuomi. Patch
combines all previously made patches for this feature.

To test follow test plan in comment 13.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 08:46:42 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-YJyNjc9zjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #22 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100421&action=edit
Bug 9525: Fixing floating on return

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 08:49:13 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-WuOkbrwKXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #23 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100422&action=edit
Bug 9525: Add support for regexps in conditional floating clauses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 08:49:41 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-D8KDaHl7Li@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:17:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:17:02 +0000
Subject: [Koha-bugs] [Bug 24836] New: (Optionally) Trigger
 MARC-Modification-Templates after record has been saved
Message-ID: <bug-24836-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24836

            Bug ID: 24836
           Summary: (Optionally) Trigger MARC-Modification-Templates after
                    record has been saved
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: simon.hohl at dainst.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

This is somewhat a followup on:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

The solution using a Plugin for creating 001 values works, but I wondered if it
could be achieved by, for example, copying over the 999c biblionumber to 001
after the record has been saved. This would basically solve the initial problem
described in #9921.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:18:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:18:07 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-NSMgxQmVGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Simon Hohl <simon.hohl at dainst.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.hohl at dainst.org

--- Comment #35 from Simon Hohl <simon.hohl at dainst.org> ---
Are there any plans to add this functionality to the web interface?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:21:26 +0000
Subject: [Koha-bugs] [Bug 24836] (Optionally) Trigger
 MARC-Modification-Templates after record has been saved
In-Reply-To: <bug-24836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24836-70-lBCUJzb6if@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24836

--- Comment #1 from Simon Hohl <simon.hohl at dainst.org> ---
The same functionality (trigger modification template copying 999c to 001, if
001 is still empty), would also be nice when staging records (like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974, but I suspect
you would have to trigger the template later that described in #14974).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:21:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:21:35 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-8EJq46YJpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:21:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:21:41 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-1lRuI3Rs51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:21:48 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-WwMWAMb5uL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:21:57 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-bjUkGiGCNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:31:16 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-PBHWBXsM3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96561|0                           |1
        is obsolete|                            |

--- Comment #8 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100423&action=edit
Bug 23011: Add new tests (AuthenticatePatron error codes)

This bug add new tests to the AuthenticatePatron ILS-DI service.
It tests new error codes patron might get when successfully connecting
but with a password which doesn't match Koha security rules.

Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:31:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:31:20 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-grEpUHImVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

--- Comment #9 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100424&action=edit
Bug 23011: Have AuthenticatePatron method send more information

We want AuthenticatePatron to send some more information upon
successful login, especially in the case where password is not safe
and should be renewed.
The goal is to let a third-party app catch thoses codes and
display a warning to the users.

Test plan :
1 / apply tests patch
2 / run tests, verify failure
3 / apply C4/ILSDI/Service.pm patch
4 / run tests again, verify green

Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:33:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:33:25 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-Bo9O44Yhvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96562|0                           |1
        is obsolete|                            |
 Attachment #100423|0                           |1
        is obsolete|                            |
 Attachment #100424|0                           |1
        is obsolete|                            |

--- Comment #10 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100425&action=edit
Bug 23011: Add new tests (AuthenticatePatron error codes)

This bug add new tests to the AuthenticatePatron ILS-DI service.
It tests new error codes patron might get when successfully connecting
but with a password which doesn't match Koha security rules.

Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:33:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:33:29 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-OLwxzimgJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

--- Comment #11 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100426&action=edit
Bug 23011: Have AuthenticatePatron method send more information

We want AuthenticatePatron to send some more information upon
successful login, especially in the case where password is not safe
and should be renewed.
The goal is to let a third-party app catch thoses codes and
display a warning to the users.

Test plan :
1 / apply tests patch
2 / run tests, verify failure
3 / apply C4/ILSDI/Service.pm patch
4 / run tests again, verify green

Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:37:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 09:37:01 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-ZJmGnnhIrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at outlook.com
             Status|Needs Signoff               |Signed Off

--- Comment #12 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Forgot to obsolete last patch when signing off first time. 

But patch works as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:12:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:12:40 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-jYJJbhw38p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #36 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
(In reply to Simon Hohl from comment #35)
> Are there any plans to add this functionality to the web interface?

Not by me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:12:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:12:51 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-BWdf9j9X2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:12:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:12:55 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-4KvqVA2KnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100396|0                           |1
        is obsolete|                            |
 Attachment #100397|0                           |1
        is obsolete|                            |
 Attachment #100398|0                           |1
        is obsolete|                            |
 Attachment #100399|0                           |1
        is obsolete|                            |
 Attachment #100400|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100427&action=edit
Bug 17845: Remove unused code related to printers

There is some quite old and unused code in Koha related
to printer configuration and network printing. These code
hasn't been functional in a long time and should be removed.

This patch:

- Removes printcirculationslips system preference
- Removes table printers
- Removes branchprinter column from branches

Check that:
- Go to administration
- Open any age there, but change the last bit to: printers.pl
- Apply patch, run the database update
- Verify the hidden page no longer exists
- Verify that logging in and out still works correctly
- Verify that checkout and returns work correctly
- Switch to another branch using the "Set library" option

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:12:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:12:59 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-FvqXoK10dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100428&action=edit
Bug 17845: Update atomic update for new format

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:03 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-MUwGNBPwwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100429&action=edit
Bug 17845: (QA follow-up) Remove commented line

A commented line still refered to the removed page from the
admin-menu.inc

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:06 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-hepT9g2m0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100430&action=edit
Bug 17845: (QA follow-up) Remove hidden print input

As highlighted by Jonathan, the hidden 'print' form field is no longer
read and thus no longer required in the template.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:10 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-e9z8WU00XU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100431&action=edit
Bug 17845: Remove some missed references to branchprinter

Remove a few last references to branchprinter, mostly from tests.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:14 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-PESMfrtTow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100432&action=edit
Bug 17845: Adjust few other occurrences

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:18 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-jxSa9U1uOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100433&action=edit
Bug 17845: Remove the column if it exists

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:13:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:13:21 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-zlt8GO4HD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100434&action=edit
Bug 17845: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:14:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:14:54 +0000
Subject: [Koha-bugs] [Bug 24837] New: selectbranchprinter needs to be renamed
Message-ID: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

            Bug ID: 24837
           Summary: selectbranchprinter needs to be renamed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

script and template selectbranchprinter[.pl|.tt] should be renamed.
Bug 17845 removed the branchprinter feature, so the script should be named
select_library or equivalent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:15:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:15:39 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-56vvbQlxcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24837

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #9)

> TODO later: rename selectbranchprinter(.pl|.tt)

I opened bug 24837.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837
[Bug 24837] selectbranchprinter needs to be renamed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:15:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:15:39 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-E5pwMxrafz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845
[Bug 17845] Remove printer related code
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:25:51 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-cZHjTZWxU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Michal.

However I am switching it back to Needs Signoff as the patches needs a signoff
from the sponsor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:07 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-fT7zreVeZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97248|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:10 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-rbkj4AGBQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97249|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:12 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-0bvhpspcuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97250|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:14 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-f5VUGN3WgX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97251|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:17 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-ZGN1sBUcKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97252|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:20 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-fzmKse6TSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97240|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:23 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-MnqbiGL84j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97241|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:25 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-7TdUAfsMLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97242|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:28 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-Zv9H9avbqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97243|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:31 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-Fix7WVPvcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97244|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:34 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-6CzRNaPVWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97245|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:37 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-ibKBZ69aF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97246|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:27:40 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-TuSo1xyDDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97247|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:28:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:28:17 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-hNHruo9mLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Up-to-date patches are on the remote branch:
https://gitlab.com/joubu/Koha/commits/bug_24151

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:33:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:33:28 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-KsoW9o4j0J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99291|0                           |1
        is obsolete|                            |

--- Comment #2 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100435&action=edit
Bug 24688: Check the priority of the fulfilled hold when fixing priorities

Currently when fixing priorities of existing holds, priorities aren't
fixed when checking out a middle priority hold because the hold has been
fulfilled and deleted. This patch adds a check for, if the hold can't be
found, an old hold with the required reserve_id.

To test:
1. Place at least four holds on a biblio for different borrowers
2. Check out an item to the 3rd priority borrower
3. Check the existing holds table for the biblio. The priorities might be
out of order, or try clicking the dropdowns and there might be an empty
dropdown option, or open the browser developer tools and notice the option
values in the select are missing value=3.
4. Apply patch and restart memcached
5. Check out an item to the 2nd priority borrower
6. Check the existing holds table for the biblio. Confirm the priorities
have been fixed and are now consecutive with no gaps.

Sponsored-by: Chartered Accountants Australia and New Zealand
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:33:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:33:40 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-oTivQLt08m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |emmi.takkinen at outlook.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:48:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:48:35 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-SI9JM0afBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:48:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:48:45 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-N54OlB6X1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96341|0                           |1
        is obsolete|                            |
  Attachment #96342|0                           |1
        is obsolete|                            |
  Attachment #96343|0                           |1
        is obsolete|                            |
  Attachment #96679|0                           |1
        is obsolete|                            |
  Attachment #98106|0                           |1
        is obsolete|                            |
  Attachment #98478|0                           |1
        is obsolete|                            |

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100436&action=edit
Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown

This patch preserves the current dropdown choices for patron search and adds
fields from
the DefaultPatronSearchFields system preference

To test:
1 - View the regular patron search and note fields in dropdown
2 - Apply patch, ensure dropdown has not changed
3 - Add fields to DefaultPatronSearchFields, note they are available in
dropdown
4 - Ensure existing and new fields search properly

Signed-off-by: Kelly <kelly at bywatersolutions.com>
Signed-off-by: Maxime Dufresne <maxime.dufresne at inlibro.com>

Bug 17374: (follow-up) Remove all spaces from include file

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:48:52 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-2KWsRI4DJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100437&action=edit
Bug 17374: (follow-up) Remove spaces from include file

Bug 17374: Fix another occurrence

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:49:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:49:00 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-jfnCzxdQGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100438&action=edit
Bug 17374: (follow-up) Unit tests

Signed-off-by: Maxime Dufresne <maxime.dufresne at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:49:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:49:06 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-Hn0TQhZ4Dc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100439&action=edit
Bug 17374: (QA follow-up) Make search labels match with patron record

Makes some small changes to the patronfields.inc to make sure the
search labels match with the labels in the patron record.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:52:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 10:52:48 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-iE6UHoKHFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I cleaned the patches a bit (squash and remove warn, whitespaces, etc.).


After this patch, columns.def and
koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc list the borrowers
fields.

And bug 22844 is going to introduce a third one
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json). We
will need to centralize all of them in a single file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:01:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:01:27 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-7Ik6VnMwEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:01:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:01:34 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-iEkzsupd1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98145|0                           |1
        is obsolete|                            |
  Attachment #98146|0                           |1
        is obsolete|                            |
  Attachment #98147|0                           |1
        is obsolete|                            |
  Attachment #98148|0                           |1
        is obsolete|                            |
  Attachment #98149|0                           |1
        is obsolete|                            |
  Attachment #98150|0                           |1
        is obsolete|                            |
  Attachment #98151|0                           |1
        is obsolete|                            |
  Attachment #98297|0                           |1
        is obsolete|                            |
  Attachment #98298|0                           |1
        is obsolete|                            |

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100440&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:01:40 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-TuckH7dt5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100441&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:01:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:01:46 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-Zdptn7NP1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100442&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:01:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:01:52 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-sZO2yRsIYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100443&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:02:02 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-jHhpqd5Wxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100444&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david at davidnind.com>

Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:02:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:02:09 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-4NekClW1JL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100445&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:02:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:02:16 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-cRiXSajCOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100446&action=edit
Bug 22844: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:02:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:02:23 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-MR5ebmuuZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100447&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:06:01 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-Lq4MxrGk8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, did not you forget to remove the existing call to _koha_notify_reserve 2
lines before?

now we have:

1140     _koha_notify_reserve( $hold->reserve_id )
1141       if ( !$transferToDo && !$already_on_shelf );
1142 
1143     if( !$transferToDo ){
1144         _koha_notify_reserve( $hold->reserve_id ) unless
$already_on_shelf;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:09:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:09:02 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-2RDbYOnG2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Also:
1. ->store not needed on ->build_object
2. DateTime->now should not be used directly (or add arguments)
3. Tests are failing:
t/db_dependent//Circulation.t .. 45/47     # Looks like you planned 4 tests but
ran 1.

#   Failed test 'Filling a hold should cancel existing transfer'
#   at t/db_dependent//Circulation.t line 3783.
Can't use string ("ZSpzGDUl") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Reserves.pm line 175.
# Looks like your test exited with 255 just after 47.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:12:49 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-5ElzbaW425@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:12:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:12:51 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-ICDzdELAFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100448&action=edit
Bug 24620: Remove original call to notify reserve

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:13:36 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-rO6NOeF9yC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:17:20 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-8AQKAZIBHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:22:48 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-K3zir9CsbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98971|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100449&action=edit
Bug 18127: Add batch modified records to an existing list

To test:
1) Start by having no (zero) lists
2) Go to Tools -> Batch record modification
3) Go through the batch record modification process, confirm everything
works as normal and there is a link to do a new batch record
modification at the end
4) In another tab, go to Lists and create a new list
5) Go back to the first tab and start a new batch modification process
6) At the end of the process, there should be a new option to add
modified records to an existing list
7) Select a list from the dropdown and confirm you are able to save your
modified records to the list as expected
8) Start a new batch modification process, this time for authorities
records
9) At the end confirm there is no option to add modified records to a
list, because authorities cannot be added to lists

Sponsored-by: Catalyst IT

Signed-off-by: Jessica Zairo <jzairo at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:22:52 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-CqVNzYgRQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100450&action=edit
Bug 18127: Add missing html filters

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:23:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:23:38 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-P7YwKdDLss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
That works, and could be considered a first step. IMO the ergonomic should be
improved on a follow-up bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:25:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:25:28 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-1KSN2k95Pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:25:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:25:31 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-pnssxU3OWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100448|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100451&action=edit
Bug 24620: Fix test, remove replaced code, use dt_from_string

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:37:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:37:29 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-9M234xixXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:37:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:37:31 +0000
Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items
In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23112-70-f0CtKw5yXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:49:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 11:49:20 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-7030e7vvgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What if branchtransfers.tobranch is not the logged in user's library?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:00:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:00:57 +0000
Subject: [Koha-bugs] [Bug 9181] Add patron messaging preference to Batch
 Patrons Modification tool
In-Reply-To: <bug-9181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9181-70-Ux54ff2cCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181

verolencinas <verolencinas at yahoo.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |verolencinas at yahoo.com.ar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:03:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:03:55 +0000
Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to
 select past date
In-Reply-To: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23268-70-53bz5LyVzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:03:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:03:59 +0000
Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to
 select past date
In-Reply-To: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23268-70-DGfriKyBeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91400|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100452&action=edit
Bug 23268: Make "Suspend all holds" calendar select a date from tomorrow

This patch removes "circulation" and moremember" templates functions
for Datepicker plugin. They now use options common for all inputs with
"datepicker" class and get "minDate" option from class "futuredate" assigned
function in "calender.inc".

To test:
- Apply patch
- Add holds for patron
- Use "Suspend all holds" calendar
=>Calendar greys out dates past from today

Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Align .futuredate in calendar.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:04:23 +0000
Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to
 select past date
In-Reply-To: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23268-70-2DIiLCCp4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note: the value still can be forced if the input is edited manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:06:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:06:49 +0000
Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in
 holdings_table
In-Reply-To: <bug-24176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24176-70-7WI2nE0Q7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. It's not configurable, as you advertised in comment 0
2. The class is wrong (- vs =):
+                <th class-"title-string">Date last borrowed</th>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:17:45 +0000
Subject: [Koha-bugs] [Bug 24835] Bad PCDATA explodes search with a Software
 ERROR.
In-Reply-To: <bug-24835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24835-70-glH8dTatP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24835

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Lisa,

Which exact version of Koha are you using?

Since bug 23846 you should see the "degraded view" at the staff interface, with
the message you see. And the error correctly handled OPAC-side (which means no
crash).

The patches from bug 23846 also add a new check to the
misc/maintenance/search_for_data_inconsistencies.pl script. If you run it it
will tell you which records are affected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:24:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:24:28 +0000
Subject: [Koha-bugs] [Bug 24794] On Adding a book using any framework in
 cataloging Error : Tag "" is not a valid tag. at
 /usr/share/koha/lib/C4/Biblio.pm line 2316
In-Reply-To: <bug-24794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24794-70-ERbbSj75kG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
           Severity|blocker                     |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hello Abhi,

Are you using the default framework that is installed along with Koha?
Have you done some modifications to this framework?

999$c should be mapped to biblio.biblionumber, and 999$d to
biblioitems.biblioitemnumber. But that are the default values.

This is a support question and should be asked on the mailing list.
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs

Closing this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:29:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:29:45 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-u3KzUZKP9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have the feeling that what you need here is a password_policy method that
would return the different rules.

For instance only checking for minPasswordLength is wrong, there is a default
to 3 if the pref is not set (or < 3)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:33:57 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-ltVGwJOkii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #9)
> What if branchtransfers.tobranch is not the logged in user's library?

Then $transferToDo should be true and the code should not be called

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:35:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:35:22 +0000
Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check
 if patron is restricted
In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17247-70-9U45HflC63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #24 from Magnus Enger <magnus at libriotech.no> ---
Has this been considered for the 19.05.x branch? I have seen problems caused by
this there too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:37:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:37:10 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-w2EiPiyrWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:37:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:37:42 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-70Q93CM1bO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] [OMNIBUS] Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:37:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:37:42 +0000
Subject: [Koha-bugs] [Bug 17858] [OMNIBUS] Move staff client JavaScript to
 the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-r6GDiJqDZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825
[Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:39:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:39:39 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-aYAHS85PBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lucas, how did you generate the list of the files you modified?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:40:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:40:02 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-mziPHxDo0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100406|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100453&action=edit
Bug 24052: Rename XSLT_Handler

Should be XSLT::Base now.
Removes old XSLT_Handler stub too (from bug 23290).
Result of a git grep | sed statement.

Test plan:
Run qa tools (so modules compile).
Run t/db_dependent/Breeding.t
Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch
has been applied; see subsequent patch.)
Enable XSLT use on results and details display. Check search results and
detail view on OPAC and staff.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:40:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:40:07 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-R4N2YIbHko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100407|0                           |1
        is obsolete|                            |

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100454&action=edit
Bug 24052: Fix Koha/XSLT/Base.t

Moving the separate small attachments into the test script.
Creating them now as temporary files or code fragments.
Deleting original files.

Since Breeding.t also used one of these files, a similar change was made in
that script.

Test plan:
Run t/db_dependent/Koha/XSLT/Base.t. Should pass now.
Run t/db_dependent/Breeding.t again.
Git grep on XSLT_Handler. You should only find release notes.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:40:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:40:11 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-Ckk4pTkPsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100408|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100455&action=edit
Bug 24052: Catch warning between test 5 and 6

Resolve:
ok 5 - Engine returns error on undefined text
XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214.
ok 6 - Engine returns error on empty string

Test plan:
Run perl Base.t and verify that this warning is no longer printed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:40:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:40:15 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-huPHdDqBk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100409|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100456&action=edit
Bug 24052: Add koha_xslt_security to koha-conf.xml

The line for enabling the unsafe expand_entities option is commented
and includes a warning to keep it like that ;)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:40:42 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-eTlhYGtvnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #16)
> Thx Owen !
> Shall I add your signoff line or would you?

Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:41:08 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-u1qHAP8bK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Learned an important lesson about grabbing the latest version of master before
writing a patch. Will try to get back to this today. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:42:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:42:18 +0000
Subject: [Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET
 footerjs = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-4YnbquLTh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
grep -L "SET footerjs" **/*.tt

All of them are not valid. But some are, for instance acqui/basketgroup.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:46:18 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-hJ5xQy6xGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #10)
> (In reply to Jonathan Druart from comment #9)
> > What if branchtransfers.tobranch is not the logged in user's library?
> 
> Then $transferToDo should be true and the code should not be called

circ/branchtransfers.pl
102     ModReserveAffect( $item, $borrowernumber );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:50:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:50:09 +0000
Subject: [Koha-bugs] [Bug 24825] Some templates are missing [% SET footerjs
 = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-mb2mbdILXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|circulation-home.tt is      |Some templates are missing
                   |missing [% SET footerjs = 1 |[% SET footerjs = 1 %]
                   |%]                          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:56:05 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-SduuB9TbOu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:56:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:56:09 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-DlgIyBaQS5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100276|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100457&action=edit
Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt

In return page return.tt, when there is an hold message, patron is said as
restricted even if restriction end date is in the past.

Test plan :
1) For a patron Jon Doe create a manual restriction with end date in the past
2) Create an hold for this patron on an item
3) Check in this item => You don't see message "Patron is RESTRICTED"
4) For a patron Kevin Doe create a manual restriction with end date in the
future
5) Create an hold for this patron on an item
6) Check in this item => You see message "Patron is RESTRICTED"
7) Repeate 1-6 with system preference HoldsAutoFill enabled
8) Repeate 1-6 with a waiting hold

Signed-off-by: Nazlı Çetin <nazli at devinim.com.tr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:58:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 12:58:56 +0000
Subject: [Koha-bugs] [Bug 18191] Add endpoint to list valid pickup locations
In-Reply-To: <bug-18191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18191-70-l2ob97cxnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Duplicate of 23449?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:02:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:02:30 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-eRFFMbEWuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:02:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:02:34 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-6U4PXPkB7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100198|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100458&action=edit
Bug 24812: (bug 24081 follow-up) Add permission description

Bug 24081 added a discount permission to the accounts system but during
subsequent rebases, the description of that new permission got lot.

This patch restores the description.

Test plan
0/ Check that a checkbox without a description appears in the 'Manage
patrons patrons fines and fees' section of the 'Set permissions' page.
1/ Apply the patch
2/ Reload the page and note that the checkbox now preceeds a suitable
description.
3/ Signoff.

Bonus points: Check the permission works as described and hides the
'Discount' action button for staff who do not have the permission
enabled.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:04:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:04:11 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-QK9cWPJNAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
% git grep updatecharges|grep discount
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt:        [% IF
CAN_user_updatecharges_discount && account.is_debit && (
account.amountoutstanding == account.amount ) && !(account.debit_type_code ==
'PAYOUT') %]


There is no check on the discount subperm, only hide/show a button.
Without a test in the controller that can be forced.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:08:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:08:51 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-LpRvOXurdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Yeay, thanks for signing off this patch Emmi =)
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:14:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:14:38 +0000
Subject: [Koha-bugs] [Bug 24838] New: Help link from patron categories
 should go to relevant manual page
Message-ID: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

            Bug ID: 24838
           Summary: Help link from patron categories should go to relevant
                    manual page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

>From categories.pl, the help link just goes to the manual home page. It should
go to https://koha-community.org/manual//[YOUR
VERSION]/en/html/administration.html#patron-categories

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:14:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:14:47 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-K4UufwGG1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:17:24 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-fP4oltGU4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #103 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to Katrin Fischer from comment #102)
> I agree about the tests, but with all the API work - Doesn't it makes sense
> to centralize all the checks needed instead of repeating (and forgetting
> them) all over the place? The general idea makes sense to me.

Thanks for the +1 Katrin, that was definitely the idea behind this patch.
While working with library frontend software we (@BibLibre) have stumbled
across several checks and behaviors which are different from OPAC to ILS-DI.

Centralizing those checks and behaviors makes a lot of sense to me as well with
also the Rest API coming if we want to have a bit of coherence across the
different entry points of Koha.

Also makes the whole thing much easier to maintain I guess.

Still I do have a bit of work ahead for the tests.
I will try to solve this before the NoHackFest / CanceledHackFest

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:37:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:37:14 +0000
Subject: [Koha-bugs] [Bug 24839] New: branchtransfers does not deal with
 holds
Message-ID: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

            Bug ID: 24839
           Summary: branchtransfers does not deal with holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This code looks to have been broken for some time, we check reserves, but we
don't pass the variable back to the script

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:37:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:37:36 +0000
Subject: [Koha-bugs] [Bug 18191] Add endpoint to list valid pickup locations
In-Reply-To: <bug-18191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18191-70-2Zodlb14nT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
I've done something similar for ILS-DI in bug 23015, if that can be of any help
:)
Glad to see this will exist in Rest API!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:45:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:45:42 +0000
Subject: [Koha-bugs] [Bug 24835] Bad PCDATA explodes search with a Software
 ERROR.
In-Reply-To: <bug-24835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24835-70-1AUTC5zAoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24835

--- Comment #2 from Lisa Beinhoff <Lisa.Beinhoff at ttuhsc.edu> ---
We are running 19.05.05.000.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:59:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:59:43 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-c9IxVRi0uc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:59:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:59:45 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-ErU48TmhO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100459&action=edit
Bug 24839: Return hold info to transfer script and set borrowernumber

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:59:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:59:48 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-6EWkerRWjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100460&action=edit
Bug 24839: unit tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:59:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 13:59:58 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-Kn5fdU2Hl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:02:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:02:38 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-7dnPEVnv2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100459|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100461&action=edit
Bug 24839: Return hold info to transfer script and set borrowernumber

To test:
1 - Place a hold on an item
2 - Go to Circulation->Transfers
3 - Attempt to transfer item to a branch it is not expected at
4 - No warning
5 - Apply patches
6 - Repeate
7 - You get a notice that there is a hold and must deal with the hold (or
ignore)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:03:31 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-MEro1hT4mL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24839


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839
[Bug 24839] branchtransfers does not deal with holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:03:31 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-MlbFIQP2s5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24620


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620
[Bug 24620] Existing transfers not closed when hold is set to waiting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:13:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:13:20 +0000
Subject: [Koha-bugs] [Bug 24840] New: Datetime issues in automatic_renewals
 / CanBookBeReserved
Message-ID: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

            Bug ID: 24840
           Summary: Datetime issues in automatic_renewals /
                    CanBookBeReserved
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I cannot recreate this, however, we have sites that experience
automatic_renewals.pl crashing with:
Invalid local time for date in time zone: America/New_York

It seems to happen around the daylight savings change
There is:
DateTime->now( time_zone => C4::Context->tz() ) 
In C4::Circulation::CanBookBeRenewed but I can't purposely make that fail

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:13:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:13:33 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-eDaD4TFRPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:20:02 +0000
Subject: [Koha-bugs] [Bug 24841] New: REST API should check if patron is
 restricted/debarred
Message-ID: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

            Bug ID: 24841
           Summary: REST API should check if patron is restricted/debarred
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no

Bug 17247 "ILS-DI HoldTitle and HoldItem should check if patron is restricted"
adds checks to see if the patron is restricted before a hold is placed. These
checks are added to C4::ILSDI::Services::HoldItem() and
C4::ILSDI::Services::HoldTitle(). 

As far as I can tell, the same checks are missing from the REST API,
specifically for "POST /api/v1/holds". 

Koha::REST::V1::Holds::add() does call C4::Reserves::CanItemBeReserved() and
C4::Reserves::CanBookBeReserved(), but as far as I can tell, those subs do not
check if the patron in question is debarred. 

Am I missing something or is this a bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:20:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:20:35 +0000
Subject: [Koha-bugs] [Bug 24842] New: Automatic serials missing list feeding
 does not work when the numbering sequence includes regexp specific
 characters
Message-ID: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

            Bug ID: 24842
           Summary: Automatic serials missing list feeding does not work
                    when the numbering sequence includes regexp specific
                    characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: koha at univ-lyon3.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

We can encounter this issue, when we choose to automatically feed the serials
missing list of a subscription (Manual history is uncheck in the subcription
planning form).
When setting or removing the missing status to a serial issue in the staff
interface, the process in the code of adding the issue numering sequence or
removing it from  the missinglist is based on some regular expression.
It's not uncommon that librarians use characters like parenthesis in this
sequence, for exemple to add year detail :
No 236 (2019)
We can even fall upon + or * characters.
The consequence is that they are interpreted by the regexp as capturing
characters rather then litterals and this causes the process to fail. The
result is the creation of multiple doubles in the missing list.

This patch aims to solve the problem

Test plan :

To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value 
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Go to check the missing list in the summary tab of subscription :
   you can see that the issue had not been added to the list.

Install the patch

1) go back to Receive page and set the expected issue as missing.
2) go back to check the missing list : now the issue number is in the list
3) go back to Receive page and set the last missing issue as arrived.
4) go back to missing list : the issue had been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:33:57 +0000
Subject: [Koha-bugs] [Bug 24842] Automatic serials missing list feeding does
 not work when the numbering sequence includes regexp specific characters
In-Reply-To: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24842-70-alMunXrOoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #1 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 100462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100462&action=edit
Bug 24842 Regexp issue create doubles in the serial missing list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:34:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:34:47 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-3LXDhk3qiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

--- Comment #21 from Arthur Bousquet <arthur.bousquet at inlibro.com> ---
Created attachment 100463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100463&action=edit
Bug 11361 - Fixing z3950servers.tt problems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:38:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:38:09 +0000
Subject: [Koha-bugs] [Bug 24842] Automatic serials missing list feeding does
 not work when the numbering sequence includes regexp specific characters
In-Reply-To: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24842-70-cZnzv1Dfcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Priority|P5 - low                    |P2

--- Comment #2 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I have to add that this bug is already present in 18.11 and maybe in previuous
ones

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:22 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-VMfnJhxeGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100161|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100464&action=edit
Bug 24131: Move the print statement to a new subroutine

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:25 +0000
Subject: [Koha-bugs] [Bug 24825] Some templates are missing [% SET footerjs
 = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-jXVbMHo88K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan,

I got the list of files from David, who discovered pages where jQuery does not
work. 

I don't understand what you mean by 'All of them are not valid.' Are there some
cases where I should not add [% SET footerjs %]? Then there is no way to use
jQuery on that particular page?

Also, do I have to get every single instance where the template does NOT
include [% SET footerjs %]?


Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:26 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-3H5urTNWoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100162|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100465&action=edit
Bug 24131: Handle several descriptions

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:29 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-Viudjd4S6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100163|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100466&action=edit
Bug 24131: (follow-up) Fix and rebase

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:32 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-TCjeEQMrQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100164|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100467&action=edit
Bug 24131: (follow-up) Another rebase

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:39:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 14:39:35 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-eSR40kZqn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100468&action=edit
Bug 24131: (QA follow-up) Formatting in web client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:10:10 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-pIs3poaoHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:10:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:10:44 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-1s2rUSvcsy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83365|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:12:38 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-sAjTvnEPmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:12:41 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-yKC11NYl8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100469&action=edit
Bug 21708: Sort MARC fields in TransformHtmlToMarc

Instead of pushing 999 in the front :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:13:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:13:45 +0000
Subject: [Koha-bugs] [Bug 24842] Automatic serials missing list feeding does
 not work when the numbering sequence includes regexp specific characters
In-Reply-To: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24842-70-ODG3LqYfeW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

--- Comment #3 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Sorry, an error in my test plan

NEW TEST PLAN :

Test plan :

To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value 
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Modify the missing status to another missing status.
3) Go to check the missing list in the summary tab of subscription :
   the issue had been added to the list. You could think, it's ok but the
reason is that the list was empt.
4) If you go back to set the same issue to another type of missing status, you
will discover that it had been added a second time to the list.
4) if you set the missing status to "arrived", you will see that the sequences
had not been removed from the missing list.

Install the patch

1) go back to Receive page and set the expected issue as missing.
2) go back to check the missing list : now the issue number is in the list
3) go back to Receive page and set the last missing issue as arrived.
4) go back to missing list : the issue had been removed

Olivier

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:13:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:13:47 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-RPLIE0ZyXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still adding small test and benchmarking

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:25 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-hQN7zsBrcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:27 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-7XiOCWEeVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:29 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-IHYLBKBDWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:31 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-f3UenYPJxy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:33 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-aWzUXLO046@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:35 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-CLpsBhlHBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:37 +0000
Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to
 select past date
In-Reply-To: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23268-70-auzD1wWiSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:38 +0000
Subject: [Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to
 select past date
In-Reply-To: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23268-70-uqN0J62LAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:40 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-tIwRftAhEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:42 +0000
Subject: [Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five
 pieces of information
In-Reply-To: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23926-70-nqOBptSBdq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:44 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-QhLvLfuZpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:17:45 +0000
Subject: [Koha-bugs] [Bug 24777] Use patron.is_debarred instead of
 patron.debarred in return.tt
In-Reply-To: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24777-70-8DXfG28MlG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:21:56 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-YQbBwW2ABH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Syspref ILLOpacbackends can |Syspref ILLOpacbackends can
                   |not be disbled              |not be disabled

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 15:23:32 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-7rwj33HjKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Record with 25 fields: 0.000038 sec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:00:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 16:00:21 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-T9AuwXShUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to paxed from comment #0)
> This is due to TransformHtmlToMarc in C4/Biblio.pm, specifically the $param
> eq 'biblionumber' case, which pushes the param in the array first, and then
> the sub uses $record->append_field()
> 
> Perhaps the array should be sorted by field tag before appending the fields?

Yes, I saw that too :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:02:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 17:02:08 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-VQqmTuWUrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 17:35:42 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-IoDohkZ1fY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Arthur Bousquet <arthur.bousquet at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100077|0                           |1
        is obsolete|                            |
 Attachment #100463|0                           |1
        is obsolete|                            |

--- Comment #22 from Arthur Bousquet <arthur.bousquet at inlibro.com> ---
Created attachment 100470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100470&action=edit
Bug 11361 - Fixing database and merge conflicts

Bug 11361 - Fixing z3950servers.tt problems

Bug 11361 - Re-adding the 'Attributes' column

Bug 11361 - Fixing z3950servers.tt problems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:32:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:32:41 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-nehCP1uUo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100205|0                           |1
        is obsolete|                            |
 Attachment #100206|0                           |1
        is obsolete|                            |
 Attachment #100207|0                           |1
        is obsolete|                            |

--- Comment #24 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100471&action=edit
Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:32:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:32:46 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-V1zAQZeUWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #25 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100472&action=edit
Bug 20936: Add koha_object_class and koha_objects_class methods to Schema
classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:32:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:32:50 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-M6zlUL0nKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #26 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100473&action=edit
Bug 20936: Add patron's hold history menu in OPAC

This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)

To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
        => Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.

Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.

Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:32:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:32:55 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-PtQfxkYAKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #27 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100474&action=edit
Bug 20936: Add test

Add test to /api/v1/public/patrons/:patron_id/holds endpoint

To test:
1. prove t/db_dependent/api/v1/patrons_holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:37:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:37:08 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-78ADxHSNRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #28 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Jonathan

(In reply to Jonathan Druart from comment #23)
> In case someone else comes for QA before me, see bug 24608 comment 26 and
> see if the problem exists in this feature as well.

I don't believe you'll have the same problem.. in this operation there is no
save method, only retrieves holds history.

> 
> Agustin, a couple of things I spot:
>  * authnotrequired needs to be removed (there is a new check in the QA
> script)

Weird that when I did qa, the script didn't mention anything about
authnotrequired, but I removed it anyway.

>  * Schema files should be in a separate patch.

Done.

Cheers!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:44:02 +0000
Subject: [Koha-bugs] [Bug 24825] Some templates are missing [% SET footerjs
 = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-OnT3aDNPvf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Lucas,

The grep command will list all the template (.tt) files where "SET footerjs"
does not exist. In some case it's expected (for instance
serials/tables/members_results.tt, or virtualshelves/downloadshelf.tt).

I pointed out basketgroup.tt, but actually this file should not set footerjs to
1 (however the logo does not hide(?)).

Actually I think the bug is somewhere else. Those files should not need to set
footerjs to have IntranetUserJS executed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:46:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:46:50 +0000
Subject: [Koha-bugs] [Bug 24825] Some templates are missing [% SET footerjs
 = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-Qv7g1ClAis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
ha, my bad.
Lucas, this is not a bug, you must have you code inside $(document).ready

Put the following code inside IntranetUserJS and it will work:

$(document).ready(function(){
    $('#logo').hide();
});

I think this should be marked as invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:53:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:53:09 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-rS29NPx3y2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 18:57:27 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-GE7zlBLwE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We should not use DateTime directly, but dt_from_string from Koha::DateUtils
instead.

See also bug 23079 for more info.

To recreate:

use DateTime;
say DateTime->new(year => 2020, month => 3, day => 8, hour => 2, time_zone =>
'America/New_York');


I guess your auto renew cronjob run at 2am.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:23:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:23:30 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-yZBQ37odNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:23:33 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ocSNyNYe4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99724|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:23:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:23:36 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-fQWDcrEj16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100142|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:24:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:24:05 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-tGrUThVnyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100475&action=edit
Bug 20212: Add missing entried on schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:24:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:24:09 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-OIZgaKyIYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100476&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:24:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:24:14 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-FaWBsoDaBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100477&action=edit
Bug 20212: Allow filtering orders on ISBN

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn are correctly translated into search on the
  biblioitems table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:24:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:24:19 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-7E8p4wvdHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100478&action=edit
Bug 20212: Use API to render orders datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:28:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:28:01 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-q5AXL9RUA8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I've set it NSO to gather some attention. This is not ready yet (cleanup is
required for that). But The only way I found of testing it is displaying both
tables (the original and the API-driven so the behaviour can be compared).

The patchset touches histsearch.pl but only the table displayed when adding an
invoice is complete-ish.

The only missing feature is the in-column filtering, but the main technical
challenge is solved (filtering on bilbioitems.isbn).

Please test and provide feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:29:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:29:22 +0000
Subject: [Koha-bugs] [Bug 24825] Some templates are missing [% SET footerjs
 = 1 %]
In-Reply-To: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24825-70-ITsPfcobOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|Failed QA                   |RESOLVED

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan, the bad is mine. :( 

Marking as invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:29:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:29:22 +0000
Subject: [Koha-bugs] [Bug 17858] [OMNIBUS] Move staff client JavaScript to
 the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-D083Pb9VXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 24825, which changed state.

Bug 24825 Summary: Some templates are missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:38:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:38:34 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-OfzcQs3xbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:38:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:38:38 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-NRqoJST1m3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100416|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 100479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100479&action=edit
Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity

Test plan:
- install patch
- update databse
- confirm notice name is now in sentence-case
- confirm too-many error text now reads "reached" rather than "reach"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:38:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:38:41 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-f4Sp4QlEW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100417|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 100480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100480&action=edit
Bug 24378: atomicupdate for new wording

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:40:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:40:35 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-z3zkWtYqbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
After signing off, I though maybe that:

"You have reached the maximum of checkouts possible."

should be:

"You have reached the maximum number of checkouts possible."

(number added after maximum)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:41:08 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-Ht3s5NzDKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Arthur Bousquet <arthur.bousquet at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #23 from Arthur Bousquet <arthur.bousquet at inlibro.com> ---
Thanks for testing !
Solved the first problem
The "Show" button is here if we do a Z3950 search in our own database. We could
remove it or make it invisible if it leads to nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:41:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:41:43 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-G2xobkbgv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Applying: Bug 24131: (follow-up) Another rebase    
error: sha1 information is lacking or useless
(installer/data/mysql/updatedatabase.pl).
error: could not build fake ancestor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:48:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:48:06 +0000
Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and
 biblio level
In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21591-70-e9VFo9FfiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:56:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:56:54 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-fc38oPsSdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:56:59 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-biDLd4d87i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100460|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 100481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100481&action=edit
Bug 24839: unit tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:57:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 19:57:03 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-yYeZLuYkYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100461|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 100482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100482&action=edit
Bug 24839: Return hold info to transfer script and set borrowernumber

To test:
1 - Place a hold on an item
2 - Go to Circulation->Transfers
3 - Attempt to transfer item to a branch it is not expected at
4 - No warning
5 - Apply patches
6 - Repeate
7 - You get a notice that there is a hold and must deal with the hold (or
ignore)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 21:12:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 20:12:31 +0000
Subject: [Koha-bugs] [Bug 15869] Change framework on overlay
In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15869-70-fEzNkYpKv1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 21:40:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 20:40:27 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-tCPjNcT6aJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Should this be needs signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 21:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 20:57:53 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-1PdfQUb3Xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 21:58:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 20:58:46 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-2PMxLdf58z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:02:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:02:47 +0000
Subject: [Koha-bugs] [Bug 24843] New: Allow batch change of framework
Message-ID: <bug-24843-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24843

            Bug ID: 24843
           Summary: Allow batch change of framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Koha should give users some method to change the framework of multiple records
at once. Batch record modification cannot currently do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:05:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:05:04 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-Ah31KIuL6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:05:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:05:07 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-jmlXy4yz2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100214|0                           |1
        is obsolete|                            |

--- Comment #3 from Michal Denar <black23 at gmail.com> ---
Created attachment 100483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100483&action=edit
Bug 19475: Don't copy holiday if it already exists in target calendar

Calendars copy tool created duplicate values to database.
Holidays in target calendar weren't checked before
inserting new holidays. This patch fixes this.

To test:
1. Add holidays for branch A
2. Copy branch A calendar to branch B
3. Repeat copy to branch B
=> Check database, branch B has now duplicate holidays
4. Delete holidays from branches A and B
5. Apply patch
6. Repeat steps 1-3
=> Check database, no duplicates

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:08:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:08:55 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-WdoPYMGvlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:08:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:08:59 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-3GxQjTg4pV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100310|0                           |1
        is obsolete|                            |

--- Comment #7 from Michal Denar <black23 at gmail.com> ---
Created attachment 100484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100484&action=edit
Bug 24402: About template corrections

With the 20.05 team we introduced and expanded some roles.  This patch
adds support for:

* removal of the release maintainer for development releases
* a list of documentation managers
* a list of packaging manager

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:09:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:09:48 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-AzeZf3RcDQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #4 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #3)
> Should this be needs signoff?

Hi Martin, not yet.. I still have to design how to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:11:44 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-Lz9IZf7eVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:55:28 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-GqUEz4Bdem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:56:05 +0000
Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE notices to take
 calendar into account
In-Reply-To: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19762-70-VVKyUiJWP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:56:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 21:56:41 +0000
Subject: [Koha-bugs] [Bug 17291] Add <item>...</item> syntax to
 advance_notices.pl
In-Reply-To: <bug-17291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17291-70-FzNs4NhrEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:17:42 +0000
Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen
 uses the default classification source rather than the item specific source
In-Reply-To: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18499-70-qs4WpAtccX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:24:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:24:17 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-rcFgKplIX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:25:51 +0000
Subject: [Koha-bugs] [Bug 24619] Phase out jquery.cookie.js: MARC Frameworks
In-Reply-To: <bug-24619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24619-70-skzicapgnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:30:13 +0000
Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC
 editor
In-Reply-To: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24621-70-qsDY4YCebJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:30:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:30:26 +0000
Subject: [Koha-bugs] [Bug 24621] Phase out jquery.cookie.js: Basic MARC
 editor
In-Reply-To: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24621-70-QVghJr3Hsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:35:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:35:29 +0000
Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b
 on OPAC XSLT
In-Reply-To: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24654-70-fRI7TqEkQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:43:56 +0000
Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL
In-Reply-To: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24640-70-eHR8Nkia8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:44:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:44:09 +0000
Subject: [Koha-bugs] [Bug 24640] quotes.timestamp should default to NULL
In-Reply-To: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24640-70-kTaqS9qRCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2020 22:48:20 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
 escaped characters by template, rendering it invalid
In-Reply-To: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23527-70-tgYk3ucFty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:21:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:21:45 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-R4cvygFg04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100479|0                           |1
        is obsolete|                            |
 Attachment #100480|0                           |1
        is obsolete|                            |

--- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100485&action=edit
Bug 24378: Change wording of auto_renewals notice in updatedatabase

Test plan:
- install patch
- update databse
- confirm changes to notice name and wording

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:22:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:22:32 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-rrJHP1kOYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Good catch! Added "number" as suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:46:23 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-iyihARm5tT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:46:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:46:26 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-nuDIN67t1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100418|0                           |1
        is obsolete|                            |

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100486&action=edit
Bug 23787: add AUTO_RENEWALS to sample_notices

To test:
- create a new install
- confirm presence of auto renewal notice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:47:46 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-39XDuzHanH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

--- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Adapted to new yaml format. It's my understanding that means one need not copy
the notice into all the separate languages, so I only put it in the one yaml
file. Please let me know if I'm mistaken in that. Thaanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:57:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:57:37 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-XHK2epCQ5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 01:57:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 00:57:40 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-GSal0IUfNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100487&action=edit
Bug 24838: fix help link for patron categories

To test:
- go to admin/categories.pl
- click Help, confirm it takes you to manual main page
- apply patch
- restart all
- click Help, confirm it takes you to patron categories in manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:12:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:12:59 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
 medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-aNiMqByOXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #243 from David Cook <dcook at prosentient.com.au> ---
Turns out the database update for this change causes unexpected changes to the
"Koha to MARC mapping" (via the MARC frameworks) if you had additional
non-standard "Koha to MARC mapping" entries.

Personally, I wouldn't have updated the marc_subfield_structure automatically.

Here's the query used:
UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND
subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE
fieldmapping.frameworkcode=''"

This would be a better query:
UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND
subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE
fieldmapping.frameworkcode=''" and field='subtitle'

Now I have a lot of different MARC fields mapped to biblio.subtitle 😅

Of course, even the modified query wouldn't be great, because in my case 245$h
would get mapped to biblio.title too which isn't what we'd want.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:13:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:13:58 +0000
Subject: [Koha-bugs] [Bug 24748] Workaround to enable installation of 19.11
 on Debian 9 is missing from install docs
In-Reply-To: <bug-24748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24748-70-WQ1Q9SpDsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24748

Dwight Tuinstra <dwight.tuinstra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
I signed up for wiki access and changed the "Koha on Debian" document so it now
has instructions for including stretch backports.

Marking this RESOLVED as it fixes a documentation bug; however the underlying
problem in bug 23128 is still out there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:18 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-ezN2GmuVhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99933|0                           |1
        is obsolete|                            |

--- Comment #74 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100488&action=edit
Bug 4461: (follow-up) Creating sample notice and other fixes

- filters
- capitalisation
- atomic update

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:24 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-wNIDNd0chf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99934|0                           |1
        is obsolete|                            |

--- Comment #75 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100489&action=edit
Bug 4461: Rename report date with created_on

And make it a timestamp type column

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:31 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-UtRjIqTMaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99935|0                           |1
        is obsolete|                            |

--- Comment #76 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100490&action=edit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:38 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-4VdoufxtcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99936|0                           |1
        is obsolete|                            |

--- Comment #77 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100491&action=edit
Bug 4461: Use our local_referer instead of HTTP_REFERER

Cannot remember why exactly, but it seems that we should not use
HTTP_REFERER directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:44 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-4ca6HQvnSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99937|0                           |1
        is obsolete|                            |

--- Comment #78 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100492&action=edit
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:51 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-vcnsFqmYHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99938|0                           |1
        is obsolete|                            |

--- Comment #79 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100493&action=edit
Bug 4461: Simplify recipients code

As the feature is now turned off without KohaAdminEmailAddress, we only
need to check if the email address of the library if defined.
Not that we should not check for $library->branchreplyto or
ReplytoDefault, but only $library->branchemail, as we do everywhere else
(I think)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:17:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:17:57 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-UQADe1S3iQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99939|0                           |1
        is obsolete|                            |

--- Comment #80 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100494&action=edit
Bug 4461: Better error handling

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-LZ7nSqSyUZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99940|0                           |1
        is obsolete|                            |

--- Comment #81 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100495&action=edit
Bug 4461: Remove hard requirement on OpacKohaUrl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:11 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-wf6hdAi66t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99941|0                           |1
        is obsolete|                            |

--- Comment #82 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100496&action=edit
Bug 4461: Drop 'from_address' use 'reply_address'

This patch adds support for using the reply-to field added in bug 10269
and drops 'from_address' as it will get defined at a later stage in the
emailing process anyway.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:18 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-49orkqyV2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99942|0                           |1
        is obsolete|                            |

--- Comment #83 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100497&action=edit
Bug 4461: Use get_effective_email from bug 22823

Use the get_effective_email from Koha::Library to get an appropriate
inbound address for the branch as aposed to using branchemail directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:25 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-dHNpl8Uf0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #84 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100498&action=edit
Bug 4461: Adding user flags for managing OPAC problem reports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:31 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-NBc9zeetHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #85 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100499&action=edit
Bug 4461: Add problem reports link to mainpage and admin home

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:37 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-bTALLPAKQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #86 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100500&action=edit
Bug 4461: Manage problem reports on the staff client

Test plan:

- Update database and upgrade schema files (if you haven't already).
Restart memcached
- Check your user's permissions and ensure the 'problem_reports'
permission is ticked. Confirm the OPACReportProblem syspref is enabled
- Log into the OPAC and submit a problem report
- Log into the staff client
- You should see a box at the bottom of the main page showing your
pending problem report
- Click the link and confirm it takes you to the new page for managing
problem reports
- Go to Administration
- Confirm you can see a link to 'OPAC problem reports' under the
'Additional parameters' heading
- Click 'OPAC problem reports'
- Confirm your problem report is showing in the table
- Open the OPAC in another tab and submit at least two more problem
reports (so you should have at least three in the table after
refreshing)
- Try the different buttons
    - selecting multiple problem reports and using the big 'mark
    viewed', 'mark closed', 'mark new' buttons. Confirm there are no
    failures and that the number of selected problem reports is correct
    - select all, clear all, hide viewed, hide closed, hide new, show
    all
    - individual 'mark viewed', 'mark closed', 'mark new' buttons for
    each problem report. Confirm the status shows and the correct button
    is disabled while others are enabled
- Confirm the problem page link works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:18:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 02:18:57 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-L4WeQGZSke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:09:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:09:40 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-fr3rijuW7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:09:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:09:43 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-HksHEOQ63T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100501&action=edit
Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:38:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:38:39 +0000
Subject: [Koha-bugs] [Bug 24844] New: Focus on the system preferences
 searchbar when going to admin home
Message-ID: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

            Bug ID: 24844
           Summary: Focus on the system preferences searchbar when going
                    to admin home
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Every time I go to the Administration main page I have to click into the
syspref search bar. Would be nice if I didn't have to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:40:16 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-ky3Xi6xmxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:40:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:40:19 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-FrOXLyTAv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100502&action=edit
Bug 24844: Focus syspref searchbar

To test:
1) Go to Administration
2) Notice neither of the syspref search bars are focussed so you have to
click inside one to begin searching
3) Apply patch and refresh page
4) Notice the header syspref search bar is now focussed so you can begin
typing straight away

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:40:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 03:40:27 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-Na5egdiA6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 05:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 04:05:06 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-WEUez13loE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 05:05:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 04:05:10 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-LUDwy9VTam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100503&action=edit
Bug 3137: (follow-up) Rename using 'collapse', remove syspref lettering and fix
guarantor section collapsing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 07:29:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 06:29:42 +0000
Subject: [Koha-bugs] [Bug 24845] New: Web-based installer consistently fails
 while creating database tables.
Message-ID: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

            Bug ID: 24845
           Summary: Web-based installer consistently fails while creating
                    database tables.
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dwight.tuinstra at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 100504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100504&action=edit
indexer-output.log, showing table-doesn't exist errors before web installer is
run.

Installation by following the wiki document "Koha on Debian" fails. 

I am able to successfully get through the preliminary steps leading up to the
web-based installer, and the first handful of screens in that installer. The
problem occurs after clicking on the button to create the database
tables. After several minutes of no activity, the brower reports
"'Gateway Timeout' The gateway did not receive a timely response from the
upstream server or application." At this point, table creation in mysql/mariadb
stops, after a varying number of tables (around 160 to 180) have been created.

There are two possible causes that I've been able to see so far:

POSSIBILITY 1:
There is an indexer problem that occurs even before the point where the web
installer is run. The file /var/log/koha/biblioteca/indexer-output.log begins
to fill up with error messages -- see attached files. After this, the log
continues to grow with the last two lines constantly added over and over.
Curiously, though, this stops about the time that the web installer is run.

POSSIBILITY 2:
The creation of database tables takes so long that the browser or installer
times out, or race conditions arise. I watched table creation in another
window as the web installer was running. Table creation seemed to go slow
(roughly a table every second) even though there was plenty of free memory,
free disk space (with low disk activity), and the CPUs were over 95% idle.
Table creation stopped at 162 tables, at almost the exact same moment that
the browser gave the timeout message, so I'm not sure if that's all the
tables or if there are supposed to be more.

What's odd here is that the web installer writes a good number of messages
to /var/log/koha/biblioteca/intranet-error.log, each saying that one of these
database tables do not exist: language_descriptions,
language_subtag_registry, or systempreferences. However, all of these
tables *do* exist in the database when one examines it later, which
suggests a race condition.

This problem is perfectly repeatable -- I've gone so far as to script the
manual steps from the wiki documentation to ensure all steps are done, and done
as specified. 

This problem is preventing Koha from being installed and used.

OTHER INFO:
- Virtualization: VirtualBox 5.2.34_Ubuntu r133883, 2 i7 CPUs,
pre-allocated fixed disk (32Gb), 2GB RAM
- Debian version: 4.9.0-12-686-pae #1 SMP Debian 4.9.210-1 (2020-01-20) i686
- Koha version: 19.11
- Following: stable
- Database: mysql  Ver 15.1 Distrib 10.1.44-MariaDB, for debian-linux-gnu
(i686) using readline 5.2
- During WebUI installer:
    - All Perl dependencies installed and OK
    - All DB settings look reasonable, connection established, and database
exists and can be accessed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 07:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 06:31:19 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-KOCxsgILEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

Dwight Tuinstra <dwight.tuinstra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwight.tuinstra at gmail.com

--- Comment #1 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
Created attachment 100505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100505&action=edit
intranet-error.log, showing table-doesn't exist errors generated during
web-installer run.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 07:35:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 06:35:18 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-0OK5a4DMKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

Dwight Tuinstra <dwight.tuinstra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 09:23:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 08:23:12 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-4fnv3haigs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269
[Bug 10269] add a way to define a specific replyto email address for some
notice
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 09:23:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 08:23:12 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-35EetjM9mH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |4461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
[Bug 4461] Context-sensitive report a problem screen
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 09:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 08:23:32 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-hryvsatzJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22823


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823
[Bug 22823] Koha::Library needs a method for obtaining the inbound email
address
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 09:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 08:23:32 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-02bLbPcexp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |4461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
[Bug 4461] Context-sensitive report a problem screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:05:09 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-4D1zROB7KP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|nick at bywatersolutions.com   |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:11:51 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-3AdvMtOTtm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99929|0                           |1
        is obsolete|                            |

--- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100506&action=edit
Bug 4461: Database and syspref changes

adding problem_reports table and OPACReportProblem syspref

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:11:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:11:55 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-daxtt3BBOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99930|0                           |1
        is obsolete|                            |

--- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100507&action=edit
Bug 4461: Problem Report Koha objects

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:11:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:11:59 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-DjCQRJQkwY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99931|0                           |1
        is obsolete|                            |

--- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100508&action=edit
Bug 4461: Submit a problem report

To test:
1) Apply patch, update database, rebuild schema file
2) Restart koha-common and memcached
3) Confirm that your user has an email address.
4) Confirm that your library does NOT have an email address.
5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are
not filled. Enable the OPACReportProblem syspref.
6) Log into OPAC
7) Click the 'Report a problem' link at the bottom of whatever page
you're on
8) Notice that there is no form is and there is an error message alerting that
reports cannot be submitted
9) Add an email address for your library (in either the email field or the
replyto field). Refresh the OPAC problem report page. The form should now show,
and the recipient field should say 'library'.
10) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is correct. Confirm there is a success message.
11) Add an email address for the syspref KohaAdminEmailAddress and refresh the
OPAC problem report page again. The recipient field should now be a dropdown.
Select the Koha Administrator option.
12) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is
a success message.
13) Ensure all details in the message_queue are correct.
14) Log out of the OPAC
15) Click the Report a problem link again and confirm you are forced to log in

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-jxTAsTo4XN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99932|0                           |1
        is obsolete|                            |

--- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100509&action=edit
Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:08 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-K9hWTjHk5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100488|0                           |1
        is obsolete|                            |

--- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100510&action=edit
Bug 4461: (follow-up) Creating sample notice and other fixes

- filters
- capitalisation
- atomic update

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:12 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-kxLc1roN5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100489|0                           |1
        is obsolete|                            |

--- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100511&action=edit
Bug 4461: Rename report date with created_on

And make it a timestamp type column

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:16 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Xjha6jdCl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100490|0                           |1
        is obsolete|                            |

--- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100512&action=edit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:21 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-9cQQ1fL878@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100491|0                           |1
        is obsolete|                            |

--- Comment #94 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100513&action=edit
Bug 4461: Use our local_referer instead of HTTP_REFERER

Cannot remember why exactly, but it seems that we should not use
HTTP_REFERER directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:25 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-kQuaWg0cCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100492|0                           |1
        is obsolete|                            |

--- Comment #95 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100514&action=edit
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:29 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-HLFeNkLmnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100493|0                           |1
        is obsolete|                            |

--- Comment #96 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100515&action=edit
Bug 4461: Simplify recipients code

As the feature is now turned off without KohaAdminEmailAddress, we only
need to check if the email address of the library if defined.
Not that we should not check for $library->branchreplyto or
ReplytoDefault, but only $library->branchemail, as we do everywhere else
(I think)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:33 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Iel3OAwCwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100494|0                           |1
        is obsolete|                            |

--- Comment #97 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100516&action=edit
Bug 4461: Better error handling

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:37 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-vJjYd9f4c2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100495|0                           |1
        is obsolete|                            |

--- Comment #98 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100517&action=edit
Bug 4461: Remove hard requirement on OpacKohaUrl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:41 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-KI0s7JI0ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100496|0                           |1
        is obsolete|                            |

--- Comment #99 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100518&action=edit
Bug 4461: Drop 'from_address' use 'reply_address'

This patch adds support for using the reply-to field added in bug 10269
and drops 'from_address' as it will get defined at a later stage in the
emailing process anyway.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:46 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-SaGTvjSIVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100497|0                           |1
        is obsolete|                            |

--- Comment #100 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100519&action=edit
Bug 4461: Use get_effective_email from bug 22823

Use the get_effective_email from Koha::Library to get an appropriate
inbound address for the branch as aposed to using branchemail directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:50 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-ozmoZzDXim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100498|0                           |1
        is obsolete|                            |

--- Comment #101 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100520&action=edit
Bug 4461: Adding user flags for managing OPAC problem reports

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:54 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Ra3Q091f7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100499|0                           |1
        is obsolete|                            |

--- Comment #102 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100521&action=edit
Bug 4461: Add problem reports link to mainpage and admin home

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:12:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:12:59 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-3ZX6fRspVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100500|0                           |1
        is obsolete|                            |

--- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100522&action=edit
Bug 4461: Manage problem reports on the staff client

Test plan:

- Update database and upgrade schema files (if you haven't already).
Restart memcached
- Check your user's permissions and ensure the 'problem_reports'
permission is ticked. Confirm the OPACReportProblem syspref is enabled
- Log into the OPAC and submit a problem report
- Log into the staff client
- You should see a box at the bottom of the main page showing your
pending problem report
- Click the link and confirm it takes you to the new page for managing
problem reports
- Go to Administration
- Confirm you can see a link to 'OPAC problem reports' under the
'Additional parameters' heading
- Click 'OPAC problem reports'
- Confirm your problem report is showing in the table
- Open the OPAC in another tab and submit at least two more problem
reports (so you should have at least three in the table after
refreshing)
- Try the different buttons
    - selecting multiple problem reports and using the big 'mark
    viewed', 'mark closed', 'mark new' buttons. Confirm there are no
    failures and that the number of selected problem reports is correct
    - select all, clear all, hide viewed, hide closed, hide new, show
    all
    - individual 'mark viewed', 'mark closed', 'mark new' buttons for
    each problem report. Confirm the status shows and the correct button
    is disabled while others are enabled
- Confirm the problem page link works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:13:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:13:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-rCmMTkN0tZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100523&action=edit
Bug 4461: (follow-up) Add missing relationship accessor

I think this was a simple case of Aliesha missing a file when commiting.

So I could proceed with testing I just quickly re-implimented the patron
relationship accessor.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:13:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:13:07 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-naJWMMcEop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100524&action=edit
Bug 4461: DBIC Schema Files

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:15:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:15:34 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-cpUoCZZ2s5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is looking great now Aliesha, thankyou for the addition of a UI, it makes
is significantly easier to test and more of a complete feature.

I feel we've hit minimum viable product here now and would love to get this go
through.. I added a couple of followups simply to aid in testing.. firstly I
think you just missed adding the file to the commit for the patron
relationships accessor and then I added a commit with the dbic schema changes
so this can be tested on sandboxes and the likes.

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:16:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:16:14 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-nk9xLVWAar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:18:54 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-nFCcgJWVa9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |17247

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looks like the check must be moved to CanItemBeReserved


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247
[Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:18:54 +0000
Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check
 if patron is restricted
In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17247-70-v1acYAYt4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24841


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841
[Bug 24841] REST API should check if patron is restricted/debarred
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:19:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:19:56 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-za6oiVmsOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/mrenvoiz
                   |                            |e/Koha/-/tree/bug_24131

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:20:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-JiKbLPMuMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gitlab.com/mrenvoiz |
                   |e/Koha/-/tree/bug_24131     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:20:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:20:13 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-LYeGOvgZIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/mrenvoiz
                   |                            |e/Koha/-/tree/bug_24131

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:20:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:20:42 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-L3lHZX2gUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. not sure why we're getting sha1 issue here.. as an alternative I've
pushed a branch to my gitlab:
https://gitlab.com/mrenvoize/Koha/-/tree/bug_24131

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:20:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:20:53 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-e4tRMdw0Rw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #1)
> Looks like the check must be moved to CanItemBeReserved

Or not, see 17247 comment 13

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:21:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:21:00 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-CCnwwYaCDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:21:48 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-4QGme9f4Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/mrenvoiz
                   |                            |e/Koha/-/tree/bug_24696

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:25:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:25:34 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-mCFEMTfolA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You can ignore the indexed output log, it is run every minute even if the DB
structure is not created yet.

Is MySQL on a remote server?

Did you try to increase Apache timeout?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:38:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:38:51 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-uy7G5g5jLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Jonathan Druart from comment #2)
> Or not, see 17247 comment 13

Sorry, not sure I understand those comments. 

Are you saying the check should not be moved to CanItemBeReserved, because that
would break the way things work in the staff client? 

If so, I assume you still agree there should be a check on debarred for the
REST API, similar to what was added for ILS-DI?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:53:39 +0000
Subject: [Koha-bugs] [Bug 24797] xx-XX-messages.po line numbers are not
 correct
In-Reply-To: <bug-24797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24797-70-8PQzzmZrkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24797

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |15395


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Internationalization: plural forms, context, and more
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:53:39 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
 and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-tsHXPnKBef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24797


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24797
[Bug 24797] xx-XX-messages.po line numbers are not correct
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:54:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:54:16 +0000
Subject: [Koha-bugs] [Bug 24768] "Return claims" column is missing from
 column configuration page
In-Reply-To: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24768-70-fDbHUTA07V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24768

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14697                       |
         Depends on|                            |14697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[Bug 14697] Extend and enhance "Claims returned" lost status
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:54:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 09:54:16 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
 status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-7ZVrEtJkE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24768
         Depends on|24768                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24768
[Bug 24768] "Return claims" column is missing from column configuration page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:03:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:03:40 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-Wvp9EzCuBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The first implementation of bug 17247 added the check to CanItemBeReserved.

On bug 17247 comment 13 I noticed that it had a behavior that was not
advertised (the change was not only modifying ILSDI, but also placing a hold
from the interface, and also the REST API finally).

Then Arthur moved the check out of CanItemBeReserved.

This bug report shows that the initial check was correctly placed, the check
must be put at lower (C4::Reserves) module. But in that case the different
behaviors must be advertised, functionaly tested, validated, and covered by
testes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:06:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:06:21 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-Q900E057RN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Can you be more specific? If the syspref ClaimReturnedLostValue is empty, the
feature should be disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:16:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:16:38 +0000
Subject: [Koha-bugs] [Bug 24808] Untranslatable strings in results.js
In-Reply-To: <bug-24808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24808-70-ML03KYqagz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23885
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885
[Bug 23885] Move staff client search results JavaScript into separate file
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:16:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:16:38 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-tGvPXVhlJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808
[Bug 24808] Untranslatable strings in results.js
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:19:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:19:23 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-hjf3JyRWFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:19:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:19:29 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-ueV8rM2rgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:19:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:19:37 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-M1bWELmELH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:19:46 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-pz3du3CZtt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:19:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:19:54 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-huolTmQRku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:20:03 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-qKB5FbXxc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:20:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:20:11 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-jUylEwr3JK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:20:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:20:19 +0000
Subject: [Koha-bugs] [Bug 24661] Inclusion of locale-related javascript
 files is broken
In-Reply-To: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24661-70-OKyzLazxCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:31:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:31:42 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-08HKZezulM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100147|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100525&action=edit
Bug 24662: Remove global variables MSG_* from datatables.inc

Now that bug 21156 is pushed, we don't need to have global variables in
.inc or .tt files for translation in .js file. We can simply declare our
translatable strings where they are used.

This patch removes all global variables used in DataTables configuration

Test plan:
1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR
4. Go to the staff interface, in english, and check that DataTables
tables are still working. You should check at least the following pages:
    - catalogue/detail.pl
    - circ/circulation.pl
    - tools/quotes.pl
    - tools/letter.pl
5. Switch to french and check again DataTables tables, and verify that
   strings are translated

This patch depends on bug 24661

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:31:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:31:59 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-Pbj8SV6UFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
A nice clarification of the code here.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:35:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:35:04 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-8cWX4gJ3GD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:35:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:35:08 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-jX94n88USt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100486|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 100526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100526&action=edit
Bug 23787: Add AUTO_RENEWALS to sample_notices

To test:
- create a new install
- confirm presence of auto renewal notice

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:40:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:40:21 +0000
Subject: [Koha-bugs] [Bug 24846] New: It would be helpful to have a bulk
 edit of due dates tool
Message-ID: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

            Bug ID: 24846
           Summary: It would be helpful to have a bulk edit of due dates
                    tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

With events sometimes leading to unforeseen branch closures (think Coronavirus
as an example), it would be helpful to have a tool that would allow librarians
to update due dates in bulk based on branch and current due date of the
material.

We envisage this tool as a simple form whereby the user can filter checkouts by
a due date window and branch and then either set a fixed new due date for all
such items or roll the due date on by X days.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:40:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:40:36 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-Z90w6XCo7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:40:42 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-Jn9fWooVrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:47:12 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-oq4wWNhua4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:54:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:54:02 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-TgHO1bzjTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:54:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:54:05 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-DcVah9Ux6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99671|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 100527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100527&action=edit
Bug 5103: Format dates in MARC detail using dateformat syspref

This patch fixes the formatting of dates on the following pages:
- catalogue/MARCdetail.pl (staff)
- cataloguing/additem.pl (staff)
- opac-MARCdetail.pl (opac)

To test:
1) Ensure that the following fields are visible in the opac, intranet
and editor. You may need to edit the subfields in your default
bibliographic framework
952$d date accessioned
952$q date due/on loan
952$r date last seen
952$s date last borrowed
952$w replacement price date

Also ensure you have dateformat system preference set

2) Go to cataloguing/additem.pl for a biblio. Fill in the fields above
if required. Save
3) Remain on cataloguing/additem.pl. Notice the items table at the top
of the page, the dates are in the generic yyyy-mm-dd format
4) Go to catalogue/MARCdetail.pl for that biblio. Notice dates in wrong
format
5) View this biblio in the opac opac-MARCdetail.pl. Scroll to bottom to
items table. Notice dates in wrong format.
6) Apply patch, restart memcached and plack and refresh pages
7) Dates should now be formatted according to dateformat preference
8) Confirm that changing the preference changes the format of the dates

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:54:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:54:09 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-KeDKffxOg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100501|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 100528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100528&action=edit
Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:59:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 10:59:11 +0000
Subject: [Koha-bugs] [Bug 24847] New: select AND by default in items search
Message-ID: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

            Bug ID: 24847
           Summary: select AND by default in items search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In items search form, when clicking on "New field" a new conjunction and search
field are added.
It would save time to select AND conjunction by default, like it is in advanced
search.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:02:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:02:57 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-yS9up6oCsW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:03:01 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-Dn6lD9ASW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 100529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100529&action=edit
Bug 24847 - select AND by default in items search

In items search form, when clicking on "New field" a new conjunction and search
field are added.
It would save time to select AND conjunction by default, like it is in advanced
search.

Test plan:
1) Go to items search
2) Click on  "New field"
3) Check that AND is selected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:04:31 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-oIBR8iIOod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100530&action=edit
Bug 24131: Remove bullet points for secondary descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:28 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-FoG1U9Ke2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100464|0                           |1
        is obsolete|                            |
 Attachment #100465|0                           |1
        is obsolete|                            |
 Attachment #100466|0                           |1
        is obsolete|                            |
 Attachment #100467|0                           |1
        is obsolete|                            |
 Attachment #100468|0                           |1
        is obsolete|                            |
 Attachment #100530|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100531&action=edit
Bug 24131: Move the print statement to a new subroutine

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:32 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-XPeRVrQRNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100532&action=edit
Bug 24131: Handle several descriptions

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:36 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-23KrUYztc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100533&action=edit
Bug 24131: (follow-up) Fix and rebase

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:39 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-aANvivG9F5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100534&action=edit
Bug 24131: (follow-up) Another rebase

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:43 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-tzVANOluIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100535&action=edit
Bug 24131: (QA follow-up) Formatting in web client

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:05:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:05:46 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-isYEWlLYD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100536&action=edit
Bug 24131: Remove bullet points for secondary descriptions

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:08:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:08:32 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-gSbU4Ex6iO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Here is how it looks: https://snipboard.io/QG3c8A.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:09:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:09:31 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
 libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-ux1YKblb4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Alex, are you planning on rebasing this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:15:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:15:04 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-YuvNG12nn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100529|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100537&action=edit
Bug 24847 - select AND by default in items search

In items search form, when clicking on "New field" a new conjunction and search
field are added.
It would save time to select AND conjunction by default, like it is in advanced
search.

Test plan:
1) Go to items search
2) Click on  "New field"
3) Check that AND is selected

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:15:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:15:19 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-RYO9nP6PAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:18:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:18:45 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-qRlk4egTLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100538&action=edit
Bug 24131: Always display bug numbers on 5 characters

To correctly align bug numbers < 10000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:18:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:18:52 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-9s126IdsOJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100502|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100539&action=edit
Bug 24844: Focus syspref searchbar

To test:
1) Go to Administration
2) Notice neither of the syspref search bars are focussed so you have to
click inside one to begin searching
3) Apply patch and refresh page
4) Notice the header syspref search bar is now focussed so you can begin
typing straight away

Sponsored-by: Catalyst IT

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:19:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:19:04 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-mXWr1CiAuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:19:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:19:06 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-3KxVEL2zWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99736|0                           |1
        is obsolete|                            |
  Attachment #99737|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100540&action=edit
Bug 24696: Add completion times to updatedatabase

This patch adds completion times to the print statements in
updateadatabase.pl.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on top of Bug 24131
Work Ok, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:19:09 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-yU9dUsGb6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100541&action=edit
Bug 24696: Use strftime

Seems easier to me.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:23:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:23:13 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-JGSp3jIirV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
transferbook is also called in rotating collections.. should the return value
be used there too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:24:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:24:32 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-Xo8THu3kcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100481|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100542&action=edit
Bug 24839: unit tests

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:24:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:24:35 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-ZFsJD7IK4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100482|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100543&action=edit
Bug 24839: Return hold info to transfer script and set borrowernumber

To test:
1 - Place a hold on an item
2 - Go to Circulation->Transfers
3 - Attempt to transfer item to a branch it is not expected at
4 - No warning
5 - Apply patches
6 - Repeate
7 - You get a notice that there is a hold and must deal with the hold (or
ignore)

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:26:04 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-LLCL0SOx24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #6)
> transferbook is also called in rotating collections.. should the return
> value be used there too?

I think this can be handled in a follow-up bug report as currently Rotating
Collections just ignores the response from transfer book entirely.

At some point soon I'd really like to actually see transferbook removed and the
Koha Objects alternative used.. but that's down the line..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:28:46 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-Y1B3nBJugY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100544&action=edit
Bug 24839: (QA follow-up) Remove unused variables

Whilst QAing I spotted a couple of unused variables in the test.. no
harm in removing them ;)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:32:19 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-SlMxKE5rJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:32:19 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-JvOXtk7TIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24620


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620
[Bug 24620] Existing transfers not closed when hold is set to waiting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:51:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:51:49 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-8LsmPSZ9ID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98177|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100545&action=edit
Bug 21901: Add FK on subscription and serial tables

In order to improve performance in the serial modules and add DB constraints,
this patch is going to add missing foreign key on the following columns:
 * serial.biblionumber
 * serial.subscription
 * subscriptionhistory.biblionumber
 * subscriptionhistory.subscriptionid
 * subscription.biblionumber

Once done, some code can be removed from the Del* subroutines, as the ON
CASCASE clause will make the RDBMS handles the deletions.

Test plan:
0/ It would be useful to test the update DB entry on a big and old
production DB, to make sure the constraints will be added correctly.
We could remove the entries before creating the constraints, but it can
be unecessary
1/ Make sure you can recreate a fresh install with the kohastructure.sql
from this patch
2/ Make sure you can upgrade from a master install
3/ Create a subscription, serial, etc. and delete the biblio
=> The subscription/serials should have been deleted from the DB
4/ Create a subscription, serial, etc. and delete the subscription
=> The serials should have been deleted from the DB

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:51:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:51:52 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-hHKNnfQBOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98231|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100546&action=edit
Bug 21901: (QA follow-up) Ensure consistent data before adding keys

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:51:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:51:55 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-XHDAov0GdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100384|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100547&action=edit
Bug 21901: Add a warning if we removed entries

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:52:36 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-p3Y1MILz0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This seems to cover all the bases to me now.. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:56:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 11:56:44 +0000
Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be
 centralized (use of filter_by)
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-yFJLxqbJ8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target,
                   |                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:00:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:00:43 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-wTXXXUBzPY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100414|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100548&action=edit
Bug 24565: Add patron profile to ILL list pages

We need the API call to get ILL requests on the patron profile page,
this commit allows this.

Test plan:
- Do not apply the patch.
- Go to the "Ill requests history" page for a patron who has made ILL
  requests
- TEST: Observe that no requests are displayed
- Apply the patch
- Refresh the page
- TEST: Observe that requests are displayed
- Go to the main "ILL requests" page
- TEST: Observe that requests are displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:01:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:01:05 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-sM6a35fAk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Clear and trivial code fix.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:12:04 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-W4MJ2nuZL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:12:07 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-sn4yMcayRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100549&action=edit
Bug 24800: Add tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:12:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:12:11 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-Q4yuIqy4U4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100550&action=edit
Bug 24800: Handle inexistent return date on self checking

See bug 24800 comment 0 for a description of the problem.

We do not want the SIP server to crash if it receives a checkin request
with a return date that is not given.

The option this patch chose is to parse it only if provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:12:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:12:36 +0000
Subject: [Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return
 date is provided
In-Reply-To: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24800-70-zf1vnIRxBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Katrin, do you think this patch fix correctly the problem you faced?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:17:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:17:14 +0000
Subject: [Koha-bugs] [Bug 24848] New: Help link from label creator
 batch/layout/template points to card creator in manual
Message-ID: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

            Bug ID: 24848
           Summary: Help link from label creator batch/layout/template
                    points to card creator in manual
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Clicking the help button from various points within label-manage.pl takes one
to the patron card creator area of the manual. It should point to the relevant
label bits instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:17:20 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-fP30wNedSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:20:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:20:25 +0000
Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be
 centralized (use of filter_by)
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-F81osuRWLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|andrew.isherwood at ptfs-europ |
                   |e.com                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:35:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:35:18 +0000
Subject: [Koha-bugs] [Bug 24758] Allow folding sections in patron edition
 form
In-Reply-To: <bug-24758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24758-70-ZyeIk4gsut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24758

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Indeed looks a lot like it, thanks a lot Owen

*** This bug has been marked as a duplicate of bug 3137 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:35:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:35:18 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-vnL68M1lzL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
*** Bug 24758 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:49:35 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-uVgSpXPIFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100487|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100551&action=edit
Bug 24838: fix help link for patron categories

To test:
- go to admin/categories.pl
- click Help, confirm it takes you to manual main page
- apply patch
- restart all
- click Help, confirm it takes you to patron categories in manual

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 12:50:17 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-GUm2Gsajc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:21:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:21:52 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-iN2z34eDPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #24 from Owen Leonard <oleonard at myacpl.org> ---
I got a couple of conflicts when applying these patches but was able to resolve
them. However, I get an error when running the database update:

ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' (errno:
150)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:26:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:26:52 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-zOARkQzZar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Owen Leonard from comment #24)
> ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix'
> (errno: 150)

Is this because I was supposed to apply the last three patches on top of the
remote github branch? 

> Look for commits starting with the tag "Bug 9525 - "

Sorry I don't know what this means. I'm accustomed to seeing a separate testing
branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:28:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:28:34 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-j4IenalYkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:15 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-blNDHe9AQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100475|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:18 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-wpjqnzlSxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100476|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:20 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-bckNynKv5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100477|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:23 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-lTxP6hNOPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100478|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:52 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-RE50QbJDSu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100552&action=edit
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:37:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:37:56 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-sdTeu1I7yw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100553&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:38:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:38:01 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-oIaxmZqzsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100554&action=edit
Bug 20212: Allow filtering orders on ISBN

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn are correctly translated into search on the
  biblioitems table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:38:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:38:05 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-pDvUiZs02q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100555&action=edit
Bug 20212: Use API to render orders datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:38:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:38:28 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-axZoQMQ8y7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:38:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:38:32 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-7263urZHxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100469|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100556&action=edit
Bug 24544: Add script to insert persistent identifiers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:39:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:39:22 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-Hhulve4rGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100556|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 100556
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100556
Bug 24544: Add script to insert persistent identifiers

Wrong report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:40:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:40:10 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-a6JQ6fIzqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100557&action=edit
Bug 21708: Add a few tests in TransformHtmlToMarc.t

Test plan:
Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change
patch. Verify that the test fails on the order of fields.
Go to test plan of the second patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:40:14 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-vC0rvLrf8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100558&action=edit
Bug 21708: Sort MARC fields in TransformHtmlToMarc

Instead of pushing 999 in the front :)

Test plan:
Do not yet apply this patch.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field (MARC21 999) follows leader.
Apply this patch. Restart Plack.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field is in right position.
Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:00 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-SlNlQ41aFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:15 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-npaX50MgB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:20 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-NQxF1PRDfs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96757|0                           |1
        is obsolete|                            |
  Attachment #96758|0                           |1
        is obsolete|                            |
  Attachment #96759|0                           |1
        is obsolete|                            |
  Attachment #96760|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100559&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:23 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-xZRQ1kiq52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100560&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:27 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-wYbGIZBqBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100561&action=edit
Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:30 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-FGKUoAFuFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100562&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:33 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-eLt7FRsrdT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100563&action=edit
Bug 17268: (follow-up) Fix licenses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:37 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-pOSASrlSfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100564&action=edit
Bug 17268: DO NOT PUSH: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:41:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:41:40 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-JIPVWAE8Md@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #25 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100565&action=edit
Bug 17268: Set Booleaa for shared column in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:46:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:46:59 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-Wp9MYuG9ly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:47:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:47:01 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-XGTc9spYHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100250|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100566&action=edit
Bug 24818: Update database accountlines.date to timestamp

This update increases the resolution for the 'date' field, used for
'creation date' in accountlines from a 'date' to a 'timestamp'.

This matches other tables where both a created and updated field are
included.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:47:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:47:09 +0000
Subject: [Koha-bugs] [Bug 24849] New: Permissions checks are missing in
 borracount controller
Message-ID: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

            Bug ID: 24849
           Summary: Permissions checks are missing in borracount
                    controller
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Three actions are available withing the borraccount controller.. they all have
sub-permissions checks to restrict the visibility of the buttons leading to
those actions, but the controller itself lacks such checks and as such the
permissions can be subverted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:47:33 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-wB2LyXCExg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
[Bug 24081] Add a 'discount' process to accounts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:47:33 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-HQbGNRhSgS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:48:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:48:02 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-0KNzHbD9M4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' process to accounts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:48:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:48:02 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-OW39OTSV5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24812


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812
[Bug 24812] Add permission for 'discount' process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:45 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-7r7NU0ufq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:47 +0000
Subject: [Koha-bugs] [Bug 24565] ILL requests do not display in patron
 profile in intranet
In-Reply-To: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24565-70-PPA96efHZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24565

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:49 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-NDbA6YfIkv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:51 +0000
Subject: [Koha-bugs] [Bug 24662] Remove global variables MSG_* from
 datatables.inc
In-Reply-To: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24662-70-7ONdYwR97r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:52 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-AaICfPEtgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:54 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-4U6pZe5opt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:56 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-agVuzbtwOs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:49:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:49:58 +0000
Subject: [Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
In-Reply-To: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24839-70-0s8ojYbpad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:50:55 +0000
Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process
In-Reply-To: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24812-70-Tf3adziICE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23442                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' process to accounts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:50:55 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-ufyOCJoSjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24812                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812
[Bug 24812] Add permission for 'discount' process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:51:51 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-MTOzn9GIBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:51:51 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-o6N5nDOTCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:53:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:53:15 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-ArEsjUTLIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' process to accounts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:53:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:53:15 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-hmob7kfeSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:56:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:56:15 +0000
Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using
 defined fields is broken under ES
In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23719-70-OovWbATMC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:56:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:56:31 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-yPze1wecVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
[Bug 18790] Add ability to void payments
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:56:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:56:31 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-FcvcZrZSM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:56:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:56:40 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-L4MDM2vfhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:58:05 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-I53tbKvjOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:59:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:59:01 +0000
Subject: [Koha-bugs] [Bug 17473] Permission for voiding payments
In-Reply-To: <bug-17473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17473-70-WESroYtpt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |18790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
[Bug 18790] Add ability to void payments
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:59:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:59:01 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-sbDhasJRq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473
[Bug 17473] Permission for voiding payments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:59:41 +0000
Subject: [Koha-bugs] [Bug 17473] Permission for voiding payments
In-Reply-To: <bug-17473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17473-70-UyxqQvvvOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24849


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 13:59:41 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-ZhENh6mzEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473
[Bug 17473] Permission for voiding payments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:01:20 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-URPoOxG0y4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:01:23 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-v8fnTA3u61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99955|0                           |1
        is obsolete|                            |
  Attachment #99956|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100567&action=edit
Bug 23695: Set holding branch to transferring branch when manually initiating a
transfer

To test:
 1 - Go to Circulation->Transfer
 2 - Note your signed in branch
 3 - Find an item from your branch and create a transfer to branch B
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to brnach B
 7 - Confirm the item is held at your current branch and is being transferred
to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:01:26 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-EiQzDiFbg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100568&action=edit
Bug 23695: Alter transferbook to take a hash of params and specify from_branch

To test:
 1 - Go to Circulation->Transfer
 2 - Find an item from your branch and create a transfer to branch B
 3 - Note you can specify the origin and default is 'Item's holding library'
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to branch B from branch D
 7 - Confirm the item is held at branch D and is being transferred to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:01:37 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-XmsOBA8ru8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24849                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849
[Bug 24849] Permissions checks are missing in borracount controller
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:01:37 +0000
Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in
 borracount controller
In-Reply-To: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24849-70-mxZTuwp9Qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|18790                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
[Bug 18790] Add ability to void payments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:02:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:02:57 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-mliVdwRNo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100559|0                           |1
        is obsolete|                            |
 Attachment #100560|0                           |1
        is obsolete|                            |
 Attachment #100561|0                           |1
        is obsolete|                            |
 Attachment #100562|0                           |1
        is obsolete|                            |
 Attachment #100563|0                           |1
        is obsolete|                            |
 Attachment #100564|0                           |1
        is obsolete|                            |
 Attachment #100565|0                           |1
        is obsolete|                            |

--- Comment #26 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100569&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:01 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-ySns7UMfND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100570&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:05 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-BUMAFWTVsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100571&action=edit
Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:08 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-qaWKEWBM6q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100572&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:11 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-80ZJM68N4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100573&action=edit
Bug 17268: (follow-up) Fix licenses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:15 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-NGDbjWN4q2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100574&action=edit
Bug 17268: DO NOT PUSH: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:03:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:03:18 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-3FuJAKp2qv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #32 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100575&action=edit
Bug 17268: Set Booleaa for shared column in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:10:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:10:48 +0000
Subject: [Koha-bugs] [Bug 23875] Elasticsearch - ES - When sorting by score
 we should provide a tiebreaker
In-Reply-To: <bug-23875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23875-70-Scsa8yvie3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Are you intending on continuing here with the requested followup Nick?

I think the suggestion was to have a fixed biblionumber index which is numeric
and use that for the tie-breaker by default.. as aposed to using the existing
'local-number' index which can be re-mapped?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:13:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:13:06 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-yDYlOM5zId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Strange to call files suggestion_search.pl and suggestion_search.tt since its a
patron search no ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:13:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:13:50 +0000
Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make
 the search inaccurate
In-Reply-To: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23521-70-YQfoE9ehhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
With comments (and subsequent signoffs) from all ES experts already I'm going
to go for PQA on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:19:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:19:42 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-OsA6QxrEC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:28:19 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-fL4ICmp2VN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

--- Comment #5 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Well, not that strange according to me: 

common/patron_search.tt is the basecode for patrons search

If you look at what's existing:

Since:

guarantor_search.(pl||tt) using patron_search.tt

 => using patron search in a guarantor context


Seems pretty consistent that:

suggestion_search.(pl||tt) using patron_search.tt

 => using patron search in a suggestion context


Don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:30:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:30:16 +0000
Subject: [Koha-bugs] [Bug 24824] updated_on should be a read-only field via
 the api
In-Reply-To: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24824-70-QEdlOu8OxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |REST API
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:32:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:32:32 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-zuPy7JGcan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:32:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:32:35 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-rDnRvqF66W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97316|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100576&action=edit
Bug 22987: Add biblioimages.timestamp

This patch adds the timestamp column to the biblioimages table.
To test:
1. Apply this patch
2. Run:
   $ updatedatabase
   $ koha-mysql kohadev
   > SHOW CREATE TABLE biblioimages;
=> SUCCESS: Notice the new column is there with the right settings
3. Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:35:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:35:20 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-tpK7wuKiGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> Hi,
> with this code
> 
> 40	if ( $want_help || !$confirm ) {
> 
> you need to confirm even to do a test. 
> Is that the intended behavior?
> 
> May be "if ( $want_help || !($test || $confirm) ) {"
> 
> Otherwise the script works well (tested using zebra)

Indeed, good idea

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:46:46 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-K6kq95o9xk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 100577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100577&action=edit
Bug 21865: allow test arg alone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:52:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 14:52:08 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-VWdKnzrMkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Matthias Meusburger from comment #5)
> Well, not that strange according to me: 
> 
> common/patron_search.tt is the basecode for patrons search
> 
> If you look at what's existing:
> 
> Since:
> 
> guarantor_search.(pl||tt) using patron_search.tt
> 
>  => using patron search in a guarantor context
> 
> 
> Seems pretty consistent that:
> 
> suggestion_search.(pl||tt) using patron_search.tt
> 
>  => using patron search in a suggestion context
> 
> 
> Don't you think?

Ah i see.

In my opinion :
guarantor_search limits search to patrons that can be a garantor so its
correct.
In our case its simply patron search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:09:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:09:25 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-jWwqB060ga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:09:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:09:28 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-CkUjINKsGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Kelly,

I contacted Alex (@biblibre) who has access to the mana server.

This report (id=254 for the record) is incorrect in the DB of the server, new
lines have been deleted.
It seems that something went wrong during the import.

We also found other weirdnesses, like values not in the correct field -
https://snipboard.io/UwKyYq.jpg

He will have a look during the (no)hackfest week and get back to us :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:09:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:09:28 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-8WYCYP0xz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100005|0                           |1
        is obsolete|                            |

--- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100578&action=edit
Bug 24789: Remove ITS macro format

To test:
1 - Apply patches
2 - Confirm you can save, load, and run macros
3 - Confirm you have no choice of format

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:19:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:19:14 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-2Igrqbta9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

--- Comment #3 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
MySQL (Mariadb, actually) is on the same server. The initial pages of the web
installer say that the database connection and permissions are correct.

I have not tried adjusting the Apache timeout. How do I do that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:21:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:21:49 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-G1PmH4RNeS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100579&action=edit
Bug 24826: Remove warnings from Sendmail

Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm

This is just a guess, I did not try this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:22:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:22:36 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-ypNo89QUUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |Needs Signoff
            Version|19.11                       |master
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi, are you able to test this patch?

I do not have Sendmail configured in my test environment so cannot recreate the
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:23:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:23:15 +0000
Subject: [Koha-bugs] [Bug 24850] New: Koha::DateUtils ignored offsets in
 RFC3339 datetimes
Message-ID: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

            Bug ID: 24850
           Summary: Koha::DateUtils ignored offsets in RFC3339 datetimes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24643

The final test added in bug 24643 incorrectly tests RFC3339 timezone handling.

If an offset is passed it should be applied to the given time to return an
epoch relative to UTC and then the koha timezone config value should be applied
against that to give us a koha instance relative time.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643
[Bug 24643] Koha::DateUtils::dt_from_string rfc3339 cannot handle high
precision seconds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:23:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:23:15 +0000
Subject: [Koha-bugs] [Bug 24643] Koha::DateUtils::dt_from_string rfc3339
 cannot handle high precision seconds
In-Reply-To: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24643-70-zeEtZmV8pv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24850


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850
[Bug 24850] Koha::DateUtils ignored offsets in RFC3339 datetimes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:27:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:27:36 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-usxHGJxexT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:27:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:27:39 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-6qBgh0uDP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100411|0                           |1
        is obsolete|                            |
 Attachment #100412|0                           |1
        is obsolete|                            |
 Attachment #100413|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100580&action=edit
Bug 24776: Remove Borrowers.HasOverdues call

Borrowers Template Toolkit plugin contains method HasOverdues that can be
directly called from Koha::Patron object.

Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:27:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:27:42 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-bQF1nDxTB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100581&action=edit
Bug 24776: Remove Borrowers.IsDebarred call

Borrowers Template Toolkit plugin contains method IsDebarred that can be
directly called from Koha::Patron object.

Also in template circ/returns.tt, when patron is restricted and checkin was
backdated, var "patron" is undefined, should be "issue.patron".

Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should
still be restricted."

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:27:46 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-jXB92y36Dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100582&action=edit
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:28:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:28:02 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-X05wU9NyK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:30:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:30:40 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-BAYIERktjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
In the apache config file (/etc/apache2/apache2.conf), there is a "Timeout"
variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:31:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:31:21 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-S43iCRNj19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:32:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:32:49 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-0qOZEzkHPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you provide tests to cover this change please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:37:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:37:49 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-lvsioHZzyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21708

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Adding a see also to 21708. It helps to insert the 003/024/035 fields for PIDs
at the right position in the MARC record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:37:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:37:49 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-S9g6WvhwPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24544

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:38:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:38:26 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-3Wv1XLYRDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why not "release manager" at the top?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:50:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:50:42 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-UvQJ81VAxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Andrew, you are adding a new notice template, but one can already exist. You
should update existing ones, only if they have not been modified yet, and add
it if does not exist yet.

It seems that the template does not exist for new install, we should add it to
the installer file (installer/data/mysql/en/mandatory/sample_notices.yml).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:52:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:52:56 +0000
Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for
 loan or reference not working
In-Reply-To: <bug-11677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11677-70-bDyLulO3Ta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at koha-us.org        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:53:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:53:16 +0000
Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice
In-Reply-To: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8838-70-hVOZ8VrsuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #8 from AspenCat Team <aspencatteam at clicweb.org> ---
This would be beneficial for the AspenCat Consortium - Bob Bennhoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:55:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:55:59 +0000
Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid
 for by patron"
In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19919-70-d1mmnKgHF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at koha-us.org        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:56:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:56:40 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
 on one record transferring first hold causes next hold to become item level
In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18958-70-u4r9vamJn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:57:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:57:17 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22284-70-hukb09uvL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at koha-us.org        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:57:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:57:50 +0000
Subject: [Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal
In-Reply-To: <bug-23007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23007-70-F6Y39wPWfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at koha-us.org        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:58:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:58:07 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-j0EjOWSleC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:58:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:58:10 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-L8p8fZsEUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100551|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100583&action=edit
Bug 24838: fix help link for patron categories

To test:
- go to admin/categories.pl
- click Help, confirm it takes you to manual main page
- apply patch
- restart all
- click Help, confirm it takes you to patron categories in manual

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Fix whitespace to keep alignment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:58:47 +0000
Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip
In-Reply-To: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22507-70-ec08Q6zcbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:59:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:59:09 +0000
Subject: [Koha-bugs] [Bug 23145] Confirming transfer during checkin clears
 the table of previously checked-in items
In-Reply-To: <bug-23145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23145-70-JSo0uzLzwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at koha-us.org        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:59:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 15:59:20 +0000
Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip
In-Reply-To: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22507-70-h3irRyloVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507

--- Comment #5 from Jessie Zairo <jzairo at bywatersolutions.com> ---
This can be accomplished with template toolkit. Example below:

[% USE Branches %]
[% loggedinbranchname = Branches.GetName( Branches.GetLoggedInBranchcode() ) %]
[% IF loggedinbranchname == branch.branchname%]
This is the branch 
[% ELSE %]
Transfer this to branch
[% END %]

Marking resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:00:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:00:57 +0000
Subject: [Koha-bugs] [Bug 24370] Editing Purchase Suggestion changes the
 Acquisition Library
In-Reply-To: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24370-70-FR0aQKHraR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

--- Comment #1 from koha-US bug tracker <bugzilla at koha-us.org> ---
This could be a big problem for a couple of our libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:01:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:01:18 +0000
Subject: [Koha-bugs] [Bug 24370] Editing Purchase Suggestion changes the
 Acquisition Library
In-Reply-To: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24370-70-VYRbyBybzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:01:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:01:45 +0000
Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
In-Reply-To: <bug-21329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21329-70-QhUBd0rnzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:04:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:04:15 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-BSeh7w3Dz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Andreas, I agree with the changes. But could split the patch into 2 parts: 1
for the bugfix, 1 for the enhancement. That way the backport will not cause
conflict (only the bugfix could be backported).

Switch back the status to "Signed Off" when done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:04:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:04:41 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-w1htmEVpKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:04:54 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-Uo4FkpnLyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6520


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520
[Bug 6520] Items don't display when viewing staged records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:04:54 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
 records
In-Reply-To: <bug-6520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-owYUuaugMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827
[Bug 24827] MARC preview fails when staged record contains items with UTF-8
characters
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:05:38 +0000
Subject: [Koha-bugs] [Bug 24834] Display report number after running
In-Reply-To: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24834-70-uMyTHC14PK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:07:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:07:23 +0000
Subject: [Koha-bugs] [Bug 24834] Display report number after running
In-Reply-To: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24834-70-PGW1N2bXx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

--- Comment #2 from Lisette Scheer <lisetteslatah at gmail.com> ---
This could be very helpful to show on printed reports. 
Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:07:46 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-iyMycZc2VC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #33 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm failing out around step 7. I've applied patches and updated database. When
I go to adv editor as either a superlibrarian or a user with all cataloging
permissions, when I click Macros I don't see a Convert button. Also, when I
click New Macro, give it a name, and click OK I get this error: 

Failed to create macro:{"errors":[{"message":"anyOf failed: Expected string or
null, got boolean.","path":"\/shared"}],"status":500}

Jumping over to the database, I see the macro name in advanced_editor_macros,
but it doesn't list on the macros page.

If leave adv editor, come back in, click Macros again I get the error:

Failed to load macros:{"errors":[{"message":"anyOf failed: Expected string or
null, got boolean.","path":"\/0\/shared"}],"status":500}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:08:28 +0000
Subject: [Koha-bugs] [Bug 22182] Advanced editor - Rancor - Create item
 record
In-Reply-To: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22182-70-EFkGNaymCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:09:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:09:33 +0000
Subject: [Koha-bugs] [Bug 22182] Advanced editor - Rancor - Create item
 record
In-Reply-To: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22182-70-Jw5IwGV4L6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

--- Comment #1 from Heather <heather_hernandez at nps.gov> ---
I would just LOVE this--it would save SO much time if I could just directly key
952 fields in the advanced bib editor ("rancor")!!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:12:46 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-L6J9FSbB6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:19:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:19:10 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-PgniGQY0Tw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:19:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:19:13 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-mhYgj5n9by@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100584&action=edit
Bug 17268: (follow-up) wqUpdate API field definition to boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:22:31 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-DbEeetGoQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100585&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:22:34 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-jnsItj90GB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100586&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:22:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:22:36 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-B3qyoqpTV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100587&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:28:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:28:03 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-74QiTEAA7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #35 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Am now getting a slightly different error in the same place:

Failed to create macro:{"errors":[{"message":"anyOf failed: Expected boolean or
null, got number.","path":"\/body\/shared"}],"status":400}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:29:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:29:02 +0000
Subject: [Koha-bugs] [Bug 24851] New: No sample libraries for UNIMARC
 installations
Message-ID: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

            Bug ID: 24851
           Summary: No sample libraries for UNIMARC installations
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

I am trying to make koha-testing-docker UNIMARC compabible.
In order to have koha-misc4dev insert all the data correctly (users, etc.) we
need at least 1 library.
I am suggesting to reuse the usual library list for UNIMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:36:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:36:23 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-PBbRf8gHFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:36:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:36:26 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-2XjKqqJBNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100329|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100588&action=edit
Bug 23383: fix IdRef syspref test in XSLT

IdRef link is displayed via XSLT.
There is a test of syspref with just if value is defined.
But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by
default, which is true in XPATH.
We should test that pref is 1.

Test plan :
1) Create a fresh UNIMARC database
2) You have pref IdRef disabled
3) Simulate a SUDOC record:
  Fill a 7..$3 field with a ppn (032581270 for example).
  Fill the 009 field with an integer
4) Go to the opac detail page of the record => You don't see IdRef link
5) Enable IdRef syspref
6) Go to the opac detail page of the record => You see IdRef link
7) Disable IdRef syspref
8) Go to the opac detail page of the record => You don't see IdRef link

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:40:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:40:28 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-3RZjBlPeXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #8)
> Why not "release manager" at the top?

At the time when we first added the two column approach I felt the most
important person on the 'Maintanence team' side was the current RMaint for the
version you are running.. hence swapping the order of rmaints vs rms in the two
teams.. that's much clearer in a 'stable' release than in the 'development'
stage though..

Happy to change it if people feel there is a better order?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:40:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:40:47 +0000
Subject: [Koha-bugs] [Bug 24852] New: XSLT paths not adjusted for dev
 installs
Message-ID: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

            Bug ID: 24852
           Summary: XSLT paths not adjusted for dev installs
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We are building the XSLT paths with intrahtdocs, it should be intranetdir (and
assume that have the usual git structure)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:42:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:42:37 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-zcJHY5aA50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:44:02 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-P6iGspPEvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think the timezone issues are actually to do with a lack of offset handling
in dt_from_string: See bug 24850

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:44:10 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-3qzzxvaEfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24850

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:44:10 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-QxF6cu8Qyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24608

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:54:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:54:57 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-0fIol3n7LD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:55:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:55:01 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-r12z0ajSF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100589&action=edit
Bug 24852: Adjust XSLT paths for dev installs

We are building the XSLT paths with intrahtdocs, it should be intranetdir
(and assume that have the usual git structure).

For instance, on a dev box, the XSLT base path was outside of the git
repo:
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/

Now it will be:
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/

Test plan:
0. Do not apply the patch, set dev_install to 1 in $KOHA_CONF
1. Modify a xslt in the git repo, and in the "htdocs" path, in a
different way:
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
2. Restart all the things and refresh a bibliographic record detail
page
Notice that you see the change from the "htdocs", outside of the git
repo
3. Apply the patch
4. Repeat 2.
Notice that you now see the change you made on the file from the git
repo
5. Set dev_install to 0 in $KOHA_CONF
6. Repeat 2.
Notice that you now see the change from htdocs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:55:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 16:55:51 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-pZo5QSgfkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We need that, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:02:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:02:23 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-R6e8kSW4n8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:02:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:02:27 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-Oyo1MHPHlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100590&action=edit
Bug 24851: Insert libraries sample data for "UNIMARC"

I am trying to make koha-testing-docker UNIMARC compabible.
In order to have koha-misc4dev insert all the data correctly (users, etc.) we
need at least 1 library.
I am suggesting to reuse the usual library list for UNIMARC.

misc4dev will use fr-FR sample data for "UNIMARC"
This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29

Test plan:
outside your box, in koha-testing-docker (up-to-date), edit .env and set
 KOHA_MARC_FLAVOUR=unimarc
 DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git
 DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc

Then start the koha container
When the misc4dev will start its job, the scripts will have the expected
data to continue.

Without this patch you will get
koha_1       | Not enough data in the database, library and/or patron category
does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31.

And plenty of errors will follow.

Also, the sample data used in misc4dev will use CPL
(/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:14:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:14:02 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-U5gzYAKIrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> We need that, right?

Yes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:19:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:19:26 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-D5VNymxhil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > Why not "release manager" at the top?
> 
> At the time when we first added the two column approach I felt the most
> important person on the 'Maintanence team' side was the current RMaint for
> the version you are running.. hence swapping the order of rmaints vs rms in
> the two teams.. that's much clearer in a 'stable' release than in the
> 'development' stage though..
> 
> Happy to change it if people feel there is a better order?

First should be the one you blame if you face issues, so RM ;)

Rmaint should stay first for stable, I agree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:34:10 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-B3Dhijy5P0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:34:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:34:13 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-EElzglIxJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44979|0                           |1
        is obsolete|                            |

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 100591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100591&action=edit
Bug 15214: bulkmarcimport should log if an authority has been updated

When importing with bulkmarcimport, authorities may or may not be updated based
on which authority is newer (005 are compared).
This patch allows to keep track in the result yaml file if an authority has
been updated or not:

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:56:52 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-RnDh2yTtY7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100585|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100592&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:56:55 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-yblnOsgVmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100586|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100593&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:56:57 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-3yyRLXqU4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100587|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100594&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:57:00 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-9vOAYTpCdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100595&action=edit
Bug 24850: Don't fallback when rfc3339 format is passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:57:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:57:30 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-qeGTqthRpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:57:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:57:58 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-e99h4Awqk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |colin.campbell at ptfs-europe.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:58:14 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-6XysGcdhUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:58:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:58:17 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-YbbnXAqox3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100590|0                           |1
        is obsolete|                            |

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 100596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100596&action=edit
Bug 24851: Insert libraries sample data for "UNIMARC"

I am trying to make koha-testing-docker UNIMARC compabible.
In order to have koha-misc4dev insert all the data correctly (users, etc.) we
need at least 1 library.
I am suggesting to reuse the usual library list for UNIMARC.

misc4dev will use fr-FR sample data for "UNIMARC"
This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29

Test plan:
outside your box, in koha-testing-docker (up-to-date), edit .env and set
 KOHA_MARC_FLAVOUR=unimarc
 DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git
 DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc

Then start the koha container
When the misc4dev will start its job, the scripts will have the expected
data to continue.

Without this patch you will get
koha_1       | Not enough data in the database, library and/or patron category
does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31.

And plenty of errors will follow.

Also, the sample data used in misc4dev will use CPL
(/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql)

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:58:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 17:58:49 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-LOKelaNl3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not sure about the final followup.. it scares me that we're always falling
back to a relatively loose regex at the moment; even if a date_format is passed
in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:09:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:09:24 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-1O0h25nkmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #6 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Trying it on an up-to-date koha-testing-docker with a clean branch off the
current origin/master the tests don't apply:

$ git bz apply  24815
Bug 24815 - Koha::Cash::Register relations should return sets not undef

100219 - Bug 24815: Correct return values of Koha::Cash::Register relations
100220 - Bug 24815: Add additional tests

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24815: Correct return values of Koha::Cash::Register relations
Applying: Bug 24815: Add additional tests
Using index info to reconstruct a base tree...
M       t/db_dependent/Koha/Cash/Register.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Cash/Register.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/Cash/Register.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24815: Add additional tests
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-24815-Add-additional-tests-XWf3eu.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:10:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:10:08 +0000
Subject: [Koha-bugs] [Bug 24853] New: Add a tab in System Preferences for
 Accounting
Message-ID: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

            Bug ID: 24853
           Summary: Add a tab in System Preferences for Accounting
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Can we have a tab in the System preferences dedicated to fines and accounting
stuff?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:12:35 +0000
Subject: [Koha-bugs] [Bug 17845] Remove printer related code
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-j7m9GBfIUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx a lot for finishing this one!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:22:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:22:56 +0000
Subject: [Koha-bugs] [Bug 24854] New: Remove IDreamBooks integration
Message-ID: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

            Bug ID: 24854
           Summary: Remove IDreamBooks integration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

It looks like IDreamBooks is not operational anymore. As far as I can tell they
haven't added any data since sometime in 2018.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:23:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:23:18 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-S5p9sZFzYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

--- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Katrin Fischer from comment #2)
> Alexandre, if the problem is that the shown location might belong to the
> home library instead of the current library than I am not sure how we can
> solve this.
> 
> There is no way to tell if the location applies to the current or the home
> library.
> 
> Examples that come to mind:
> It could also be "CART" or "PROC" which are correct independent from the
> library setting. Or it might be part of course reserves and the current
> library has set the location to a specific "course reserves" location.
> 
> What solution would you prefer?

Hi Katrin,

Alexandre no longer works for our company now.

What he wanted to mention in this ticket is that the location of an item in the
mail was displayed under the code of the authorized value and not by its opac
description.

Example of the screenshot "no_home_library"
*Campus de Québec  LIMOI.QUEBEC.CAV (DVD C154)

should rather be written
*Campus de Québec Comptoir du prêt (Enregistrements vidéo) (DVD C154)

Is it clearer for you?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:23:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:23:56 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-nfyt7M02Ik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

--- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100597&action=edit
authorized value

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:29:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:29:24 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-Xp7CJM9sRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99606|0                           |1
        is obsolete|                            |

--- Comment #24 from David Nind <david at davidnind.com> ---
Created attachment 100598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100598&action=edit
Bug 3137: CollapseFieldsPatronAddForm system preference

This patches adds a syspref - CollapseFieldsAddPatronFrom - that
controls which fieldsets are hidden by default in the add patron form.

To test:
1) Apply patch and update database
2) Go to System preferences and confirm CoolapseFieldsPatronAddForm 
has no fields selected
3) Go to add a patron / edit an existing patron (any patron category).
confirm everything still works as expected.
4) Tick some of the fields in the system prefereence to hide them in 
the form
5) Go back to the add patron form.
6) Confirm these fields are hidden and listed at the top of the page
7) Toggle the check box and confirm the hidden fields show or hide as
expected.
8) Go back to the CollapseFieldsPatronAddForm system preference and
ensure the Main address option is checked to be hidden
9) Go to the patron's details page
10) Click to edit the Contact Information section
11) Confirm the Main address option shows and the checkbox to show
hidden fields is not present.
12) Confirm you can click the legend of each section to show and hide
sections

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:29:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:29:28 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-BWuNpoIUST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100503|0                           |1
        is obsolete|                            |

--- Comment #25 from David Nind <david at davidnind.com> ---
Created attachment 100599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100599&action=edit
Bug 3137: (follow-up) Rename using 'collapse', remove syspref lettering and fix
guarantor section collapsing

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:43:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:43:34 +0000
Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the MySQL
 port number
In-Reply-To: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23141-70-bKiparxy1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr
            Summary|The Debian scripts do not   |The Debian scripts do not
                   |use the myql portnumber     |use the MySQL port number

--- Comment #16 from Andreas Roussos <a.roussos at dataly.gr> ---
Fixed a small typo (myql -> MySQL) in the Bug Summary and split "portnumber" in
two words -- all in the name of making it easier to locate this bug in future
searches ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:48:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:48:05 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-a2iHkQJ0mB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100552|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:48:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:48:08 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-h9O9FlRBTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100553|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:48:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:48:11 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ftZ4v9vlTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100554|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:48:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:48:17 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-sZYbdOL50L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100555|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:49:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:49:23 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-JrJbzH42Kf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100600&action=edit
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:49:26 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-rcC829Okzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100601&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:49:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:49:30 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-j9zRRAo9ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100602&action=edit
Bug 20212: Allow filtering orders on biblioitems fields

This patch adapts the code from the list() sub so it manipulates the
query parameters and the embed header so:
- the biblioitem relationship is prefetch
- any queries on biblio.isbn and biblio.ean are correctly translated into
search on the
  biblioitems table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 18:49:35 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-lRQLEagP8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100603&action=edit
Bug 20212: Use API to render orders datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:09:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 19:09:45 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-oc48ErKGMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100604&action=edit
Bug 17268: Handle booleans in JS as such

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 19:10:49 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-2idKIxihh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #36)
> Created attachment 100604 [details] [review]
> Bug 17268: Handle booleans in JS as such
> 
> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Andrew, I submitted a follow-up so you can properly test the feature.
Nick, squash it if you feel like :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 19:16:44 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-E3DqTrTjvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> ---
The ability to claim an item "claim returned" is not there if the syspref is
empty, however, the Claim Returned tab is stil present on the patrons detail
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:10:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:10:36 +0000
Subject: [Koha-bugs] [Bug 24855] New: Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
Message-ID: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

            Bug ID: 24855
           Summary: Lost items not marked returned when floating-point
                    math causes amountoutstanding to be not-quite-zero
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Floating point math and a strict "if amountoutstand=0" result in things not
getting marked as returned when they should. I've had a hard time figuring out
exactly when this will go wrong, so I've got some very specific steps to
recreate. 

To test:
- set MarkLostItemsAsReturned to never mark items returned
- turn on Fines log
- find/create a patron with no outstanding fees or fines
- manually apply 8 overdue charges of $4.10
- create an item with a replacement cost of 6.99
- check item out to patron
- mark item lost, generating 6.99 lost fee for patron
- pay off entire balance using the Pay Amount button
- confirm patron no longer owes any fees, but item has not been marked as
returned when fee was paid off
- check fines log, see that the accountline for this lost fee recorded a
payment of "6.98999999999999" and a new amountoutstanding of
"7.105427357601e-15"

While we round these values to 4 decimal places in accountlines, that rounding
happens *after* Koha checks if amountoutstanding=0 when deciding whether or not
to mark the lost item returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:10:40 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-DRFT1ytN1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100603|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:10:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:10:52 +0000
Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
In-Reply-To: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24855-70-smeIUOE4ke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:11:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:11:01 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-mzgGqXkMKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #38 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100605&action=edit
Bug 20212: Use API to render orders datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:11:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:11:06 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-eDV8bKpJLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100606&action=edit
Bug 20212: Clean parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:11:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:11:52 +0000
Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's
 Account When Charge is Paid
In-Reply-To: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18895-70-LbtjgrkhFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Filed a new more specific bug, pushing this into that one.

*** This bug has been marked as a duplicate of bug 24855 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:11:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:11:52 +0000
Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
In-Reply-To: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24855-70-kq2LjQfpkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
*** Bug 18895 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:13:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:13:26 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-Why8ViKLs7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #40 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
So this is ready for real testing. I cleaned the code related to listing the
pending orders from parcel.pl as well. If we agree on this approach, the same
API and code can be reused in all places that display orders! YAY

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:14:40 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-5gr0YdNsqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #107 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Martin Renvoize from comment #106)
> This is looking great now Aliesha, thankyou for the addition of a UI, it
> makes is significantly easier to test and more of a complete feature.
> 
> I feel we've hit minimum viable product here now and would love to get this
> go through.. I added a couple of followups simply to aid in testing..
> firstly I think you just missed adding the file to the commit for the patron
> relationships accessor and then I added a commit with the dbic schema
> changes so this can be tested on sandboxes and the likes.
> 
> Signing off.

Thanks I did forget to attach that file!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:52:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:52:12 +0000
Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization
 logic
In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24067-70-tbVuumJcH3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 21:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 20:58:21 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-XOgbxnPEpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

--- Comment #5 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
I was finally able to get the table-creation part of the install to work by
setting the apache2 Timeout value to 30 minutes. To try to speed up mariadb, I
also set innodb_buffer_pool_size to 40M (it was not set initially). I don't
know if that made any difference, I haven't had time to run a comparison. I
also bumped up the virtual machine's memory to 4GB and dedicated 4 CPUs to it.

Actual creation of all 209 tables took over *20 minutes*, or roughly 6 seconds
(an eternity in CPU cyles and disk seek time) per table. Once this was done,
the "Selecting default settings" page took 20 to 30 minutes to finish.

Creating tables and filling in values should not take this long. I'm guessing
there is a problem with the mariadb configuration itself, or some kind of
interaction with the OS (or virtual machine manager) that is slowing down
mariadb. Either way, the documentation or the installer should make the
necessary adjustments or advise the user to do so. A person who runs into these
problems is likely to just abandon their project and spend time looking for
alternatives.

Database performance issues during install also suggest there will be similar
problems during operation.

If the performance issues during install are inescapable, then the installer
should at least give "percent-complete" progress feedback to the user. This
would reassure them and also keep the web session alive.

I am attaching a script for automating the manual, pre-web-installer steps, in
hopes this will make it easier for someone else to duplicate the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:19:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:19:23 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-fE1oT1GT5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

--- Comment #6 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
Created attachment 100607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100607&action=edit
Shell script to automate the manual, pre-web-installer steps for 19.11 on
Debian 9

This script automates most of the manual, pre-web-installer steps given in the
"Koha on Debian" wiki documentation. See the comments near the top for the
initial steps that still need to be done by hand. There are also some variables
there that you may wish to change.

The script takes a fresh Debian 9 install and runs up through starting the
web-based installer. It's meant as an assist for looking into problems, not as
a script for general use by people installing Koha (it lacks error checking and
other user-friendliness for such use).

The parts that ask the user to take a snapshot are for anyone running it in VM
and who wish to take snapshots. If you're not running in a VM or don't care to
take a snapshot, just hit "Enter" and the script will continue.

Step 02 installs VirtualBox Guest Additions. If you're not running Vbox, you
might want to do the Step 01 commands by hand, then start the script at Step
03.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:21:14 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-q0h9bGaTQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Hi Jonathan! I added it to sample-notices.yaml over in bug 23787. I'd already
started work on this one before I found the other. What's the best way to
link/merge the two?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:27:34 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-omtMdPlaFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Kyle M Hall from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Should this be master in the version?
> 
> IIRC I reproduced the bug on master. Does in no longer happen on master for
> you?

The bug is filed for 19.11 - was just checking if we need to change this as it
sounded like master. Did not test myself :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:33:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:33:47 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-ElI8YP9QyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:34:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:34:13 +0000
Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
In-Reply-To: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24855-70-7eGqsYzF7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:34:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:34:37 +0000
Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by
 publication date
In-Reply-To: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24807-70-Za3jVgEHW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 22:53:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2020 21:53:20 +0000
Subject: [Koha-bugs] [Bug 24824] updated_on should be a read-only field via
 the API
In-Reply-To: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24824-70-nd0fqTcNU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|updated_on should be a      |updated_on should be a
                   |read-only field via the api |read-only field via the API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 07:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 06:29:57 +0000
Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API
In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22132-70-XnMdfx9pw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #33 from David Cook <dcook at prosentient.com.au> ---
Unfortunately, RESTBasicAuth doesn't work with CGI. 

Admittedly, it would be an unfortunate idea to use the API with CGI, but it's
worth noting. 

To test (w/ koha-testing-docker):
1. koha-plack --disable kohadev
2. restart_all
3. curl -u koha:koha http://localhost:8080/api/v1/patrons
4. Observe the following response:
{"error":"Authentication failure."}

After a bit of debugging, it appears that Mojolicious doesn't detect the
Authorization header. It'll just have the accept, user-agent, and host headers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 07:35:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 06:35:21 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-ueaxN1EKEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Right, I had not seen the other bug.

I would change the wording before adding it to the installer file.

A good plan would be to:
* Fix the wording for existing installs (you need to make sure it has not been
modified or translated!)
* Add the updated template for new installs (yml file)
* Add the updated template for existing installs, if not exists yet (atomic
update file)

Maybe we could drop the first step, what do you think? The query would be quite
ugly...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 07:36:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 06:36:00 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-dkAztLQuyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You should insert the template notice for existing installs only if it does not
exist yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:05:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:05:37 +0000
Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23787-70-W9Ws5URxOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #14)
> You should insert the template notice for existing installs only if it does
> not exist yet.

I would recommend against adding the notice to existing installations. If you
are using auto renewals they will be activated immediately. It might come as an
unwanted surprise to libraries that have deleted it on purpose as they don't
want to use it. (it seems we added it before, but might still want to handle
this differently here?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:07:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:07:44 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-U5JQoxbeWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:18:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:18:24 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-aIjUPLHpB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:18:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:18:48 +0000
Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated
 Mojolicious version
In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22522-70-QXQAkN8ylj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au
           Priority|P5 - low                    |P1 - high

--- Comment #52 from David Cook <dcook at prosentient.com.au> ---
Cheers Ere and Martin! 

(In reply to Blou from comment #9)
> I changed it to master.
> 
> We applied the patch to our own 19.05

I've patched our own 18.11 and 19.11 with Ere's fix, so I wouldn't be surprised
if it affects 18.05 as well. 

(How far back are we supporting these days?)

It would be good to see this get pushed to the stable branches ASAP. While this
problem shouldn't affect anyone using Debian packages, I'm sure there are lots
of people around the world who aren't using them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:44:08 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22381-70-5CKLvWOILe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think there is something wrong:

About the pref ExcludeHolidaysFromMaxPickUpDelay, we switch "yes" (value=1)
from "Allow Closed days to be taken into account in reserves max pickup delay"
to "Ignore the calendar when calculating the period for reserves max pickup
delay."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 07:47:33 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-JCXioMnCX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Do we need more?

For a gitify I am doing this for koha-conf:

s/koha\/opac\/cgi-bin\/opac/koha\/opac/
s/koha\/opac\/htdocs/koha\/koha-tmpl/
s/koha\/intranet\/cgi-bin/koha/
s/koha\/intranet\/htdocs/koha\/koha-tmpl/
s/doc\/koha-common/koha\/docs/
s/bin\/cronjobs/misc\/cronjobs/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:02:21 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-Dwwz72kqgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #26 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
(In reply to Owen Leonard from comment #25)
> (In reply to Owen Leonard from comment #24)
> > ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix'
> > (errno: 150)
Hm, it seems I missed that in kohastructure.pl there was: 
ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci

instead of:
ENGINE = InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci

That's likely the issue here. I'll recheck patches for any other possible
problems and reattach them later.    

> Is this because I was supposed to apply the last three patches on top of the
> remote github branch? 
> > Look for commits starting with the tag "Bug 9525 - "
> 
> Sorry I don't know what this means. I'm accustomed to seeing a separate
> testing branch.
No need to use remote branch or look commits related to this, all latest code
is included here and should work after I fix this issue with database.  

>I got a couple of conflicts when applying these patches but was able to resolve them.
Anything I could look into?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:09:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:09:24 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-2OQxoBMPKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99758|0                           |1
        is obsolete|                            |
  Attachment #99759|0                           |1
        is obsolete|                            |
  Attachment #99760|0                           |1
        is obsolete|                            |
  Attachment #99761|0                           |1
        is obsolete|                            |
  Attachment #99762|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100608&action=edit
Bug 24159: Move useDaysMode pref to circulation rules

Moving the useDaysMode system preference to a circulation rule will add
much more flexibility in the calculation of the due date.

The initial request was to make hourly loan returned on closed when
(when checked out on the same close day).
To do so we do not want to take into account the calendar.
However the calendar need to be taken into account for other loan item types.

Other scenarios are possible, for instance depending on the branch.

This patchset will add a new "Days mode" column (next to "Loan period")
to the circulation rules page, with the different values of the
"useDaysMode" system preference + a "default" value, to default to the
system preference value.

Test plan:
- Define a long loan item type (like 10 days) that will use the calendar
(or default to the pref value, if the pref is not set to "ignore the
calendar")
- and a hourly loan (like 2 hours) that will ignore the calendar
- Create items with those item types
- Mark today as a closed day
- Check the items out
=> The hourly loan is due the same day
=> The other loan is due on an open day

QA note:
There is the need to force the "days_mode" option when Koha::Calendar is
initiated for the due date calculation. To make sure devs will not
forget it, the methods that need have it defined will throw an
exception.

Sponsored-by: Institute of Technology Carlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:09:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:09:31 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-ymse6OIJWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100609&action=edit
Bug 24159: Throw an exception if days_mode option is not given when needed

Sponsored-by: Institute of Technology Carlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:09:39 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-8sgvjoXY2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100610&action=edit
Bug 24159: Add UI changes

Sponsored-by: Institute of Technology Carlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:09:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:09:47 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-yNPXjAahWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100611&action=edit
Bug 24159: Adjust tests

Sponsored-by: Institute of Technology Carlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:09:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:09:57 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-ZT2fnzd6uk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100612&action=edit
Bug 24159: Add new tests for get_useDaysMode_effective_value

Sponsored-by: Institute of Technology Carlow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:10:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:10:06 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-QJNNUjzOJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100613&action=edit
Bug 24159: Set days_mode according to circ rules in 3 other places

There are 3 other occurrences where the new circ rule can be used:
 * C4::Circulation::checkHighHolds
 * Koha::Hold->set_waiting
 * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl

Test plan:
* checkHighHolds
Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration
Setup things to hit a "high demand" alert with a shortened due date
Check an item out
=> The due date must be recalculated depending on the circ rule useDaysMode.

* set_waiting
Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently
a bug in the description of the syspref, see bug 22381 comment 19)
Mark a hold waiting
The expiration date should have been set depending on the value of the
circ rule.

* TalkingTech cronjob
Cannot test this

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:10:15 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-CNu5vqvlah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100614&action=edit
Bug 24159: Use days_mode circ rule to calculate the dropbox date

Calculate the drop box date depending on the circ rule. Note that only
the branchcode is taken into account here. Is that correct?

Test plan:
Use the drop box date feature and confirm that it takes into account the
calendar, depending on the circ rule.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:10:26 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-4TTwH7aTnk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100615&action=edit
Bug 24159: Fix one occurrence in updatedatabase.pl

Here we just want to get the value from the syspref, the circ rule does
not exist yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:11:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:11:14 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-zIRFaUsyKZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Short loan collection       |Short loan collection
                   |issues on a day marked as   |issues on a day marked as
                   |closed                      |closed (move useDaysMode to
                   |                            |circ rules)
             Blocks|                            |15523


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523
[Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:11:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:11:14 +0000
Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation
 rules (Omnibus)
In-Reply-To: <bug-15523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15523-70-vbTzbNiIQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24159


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159
[Bug 24159] Short loan collection issues on a day marked as closed (move
useDaysMode to circ rules)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:25:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:25:00 +0000
Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let
 members search for records on remote Koha instances
In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11361-70-nbDaqsMJgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

--- Comment #24 from David Nind <david at davidnind.com> ---
Hi Arthur.

I can confirm that issue 1 is now solved!

For issue 2, where should the 'Show' link go to?

For me, the 'Show' link is trying to link to
http://cgi-bin/koha/opac-detail.pl?biblionumber=

Is it supposed to link to the record in the remote Koha instance?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:35:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 08:35:25 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-zUUnoawjep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maybe, I do not know exactly what is missing.
In debian scripts we are testing the dev_install config flag, so I think it
makes sense to test it from the code as well.

Or we go backward, remove the specific paths and adjust KOHA_CONF?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:00:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:00:43 +0000
Subject: [Koha-bugs] [Bug 24856] New: invalid itemtypes.imageurl in fr-FR
 sample data
Message-ID: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

            Bug ID: 24856
           Summary: invalid itemtypes.imageurl in fr-FR sample data
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and
installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of
imageurl point to non-existent images.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:01:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:01:56 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-iwdwoXEscK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:01:59 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-WBWkzDo4xc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100616&action=edit
Bug 24856: Remove itemtypes.imageurl in fr-FR sample data

in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and
installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of
imageurl point to non-existent images.

Test plan:
Insert the 2 sql file and confirm that imageurl is not empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:19:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:19:40 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-EW8mIDjMXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Dwight,

I confirm that the installation process takes less than few minutes, and the
insert of the DB structure less than a minute.

Did you try to insert kohastructure.sql into a fresh DB manually?

Why are not you using a 64bit linux kernel? I guess your host has a 64bit
architecture, so why not the VM?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:25:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:25:05 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-Ul3WhsWYAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Thanks Jonathan for doing this, and Jon for testing. It will be great to be
able to test UNIMARC related bugs using koha-testing-docker!

I was trying to test this earlier, and I couldn't get it to work by following
the test plan - so I'm probably doing something wrong!

What I did and the results:

1) git pull for the koha-testing-docker repository (so that is up-to-date) and 
docker-compose pull so that all the images are up-to-date as well.
2) Started up, kshell, applied patch, shut down
3) Made the changes to the .env file
4) Started up koha-testing-docker
5) Get these messages during start up:

Not enough data in the database, library and/or patron category does not exist
at /kohadevbox/misc4dev/create_superlibrarian.pl line 31.
...
...
C4::Installer::load_sql returned the following errors while attempting to load
/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql:
koha_1       | DBD::mysql::st execute failed: Cannot add or update a child row:
a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT
`items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`)
ON UPDATE CASCADE) at /usr/share/perl5/DBIx/RunSQL.pm line 273.
koha_1       | Something went wrong loading file
/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql ([SQL ERROR]:
INSERT INTO `items` ( `itemn...
.....
.....
error retrieving biblio 1 at
/kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 681.

^^^^ that message repeats - trying to retrieve all the biblio entries (number
after changes)

Use of uninitialized value in string eq at
/kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 663.

^^^^ line number changes between 86, 92, and 663

6) When I go to 127.0.0.1:8081 I get the web installer

Not sure what I'm doing wrong here, but I'm sure it is something simple and
obvious to you! The patch is applied, so I shouldn't be getting all the errors
above!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:44:02 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-2c97pjtSuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24856

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:44:02 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-4dKO35oGXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24851

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:56:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:56:35 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-dX3pteOFri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:57:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:57:02 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-Lf6uB5bwaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24455

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:57:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 09:57:02 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-0paYTWrRpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24850

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 11:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 10:01:49 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-3EHksseMR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Yes David, that's exactly the purpose of this patch here :)
I have just done a pull request on koha-misc4dev:
https://gitlab.com/koha-community/koha-misc4dev/-/issues/29

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 11:02:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 10:02:18 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-DWEXaY1M2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Finally.. I think we also need to add some handling into the
DateTime::Format::MySQL datetime_parser that we are using via DBIx::Class.. it
does not take into account offsets/timezones in the format_datetime method.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 11:10:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 10:10:29 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-lbKRF461mF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you retry using the test plan I let on the pull request?
What you tried should have worked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 11:57:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 10:57:12 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-DRnnMmNvSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 100617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100617&action=edit
Bug 24823: Remove unused parameters

Remove unused Elasticsearch parameters 'key_prefix' and 'request_timeout'.
Refactor so that get_elasticsearch_params only returns parameters used
by Search::Elasticsearch, add class accessor for index_name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:11:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:11:19 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-wluRXBUBAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:11:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:11:22 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-elmftvvHcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100618&action=edit
Bug 24767: "Claim returned" feature cannot be turned off

The ability to claim an item "claim returned" is not there if the syspref is
empty, however, the Claim Returned tab is stil present on the patrons detail
page.

Test Plan:
1) Ensure ClaimReturnedLostValue is not set
2) Note the claims tabs on the circulation and patron details pages
3) Apply this patch
4) Refresh those pages
5) The claims tabs should be gone!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:11:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:11:35 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-1EqLTiAFse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:11:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:11:41 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-L0M6QaBbwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:51:51 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-ZqRPU92gWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #108 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100619&action=edit
Bug 4461: Update license statements

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:52:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:52:23 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-H1C29YuVHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
report_problems.borrowernumber defaults to NULL. Should not it be NOT NULL
instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:56:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 11:56:19 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-e8hLPFHQyf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
When the form is sent, the success message appears but with the form bellow.

Should not we hide it?

https://snipboard.io/HJKtdp.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:08:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:08:45 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-l59P4NgZmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #111 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
- I would prefer status to be a varchar and have a readable status, instead of
N, V, C
- The "hide viewed" and  "hide closed" filters does not work if the page is not
reloaded
- Why do not we see the recipient of the report in the table?
We see the reports sent to the administrator, is that expected?
- I think there is a missing test in the controller (minor)
If recipient is forced to "librarian" but the library does not have an email
address defined, then the message will be enqueued anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:13:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:13:53 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22381-70-gQIvzcI2iM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

--- Comment #20 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Just testing this and Jonathan is correct.
To verify in master:
- mark your library closed today and tomorrow
- set ReservesMaxPickUpDelay to 1 day
- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
- place hold, capture hold
- hold expiration date is set to the day after tomorrow (skips closed days)

- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
- Place hold, capture hold
- hold expiration date is set to tomorrow (doesn't skip closed days)

This is 100% my error, thanks for catching it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:14:40 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-X6yeowYD8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100618|0                           |1
        is obsolete|                            |

--- Comment #4 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 100620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100620&action=edit
Bug 24767: "Claim returned" feature cannot be turned off

The ability to claim an item "claim returned" is not there if the syspref is
empty, however, the Claim Returned tab is stil present on the patrons detail
page.

Test Plan:
1) Ensure ClaimReturnedLostValue is not set
2) Note the claims tabs on the circulation and patron details pages
3) Apply this patch
4) Refresh those pages
5) The claims tabs should be gone!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:14:52 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-18GmUA2upM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:15:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:15:45 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-24Es3LQQBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:15:49 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-7uUWCgC0cZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99781|0                           |1
        is obsolete|                            |
  Attachment #99782|0                           |1
        is obsolete|                            |
  Attachment #99783|0                           |1
        is obsolete|                            |
  Attachment #99784|0                           |1
        is obsolete|                            |

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100621&action=edit
Bug 24298: Add return enums to branchstransfer triggers

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
updatedabase runs Ok

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:15:53 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-CCwT36u8Oo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100622&action=edit
Bug 24298: Record transfer triggers for returns

This patch adds handling to catch transfers that may have been triggered
on item return.

Test Plan:

1) Enable AutomaticItemReturn and accompanying system preference
2) Return an item to the wrong branch and note the transfer
3) Check the database for the new trigger value

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Added test plan. Works Ok, trigger saved in database.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:15:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:15:56 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-jzOVC8E2bA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100623&action=edit
Bug 24298: Add tests for ModItemTransfer

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All 8 tests in 'ModItemTransfer tests' pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:15:59 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-M4AIfJ307T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #25 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100624&action=edit
Bug 24298: (follow-up) Add missing filter!

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:16:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:16:02 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-x13GG1n6Ez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #26 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100625&action=edit
Bug 24298: Update test count and use build_sample_item

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:25:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:25:27 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-s8kCSryMha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:25:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:25:30 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-HggssxgQLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98295|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100626&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:25:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:25:33 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-OpcTnyBaa5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98296|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100627&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:26:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:26:09 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-Z5z78UlvjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:27:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:27:07 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-6Qv7kmh2na@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
One note here: AddIssue closes existing transfers but doesn't update the reason
- probably 'Checkout' should be a transfer reason - this can be done on another
bug I think

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:28:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:28:10 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-KsnsqnLByb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Test coverage for transferbook and TransferCollection wouldn't hurt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:52:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:52:07 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-iMQCMmwPKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:52:10 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-Rbx7313xWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97539|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100628&action=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:52:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:52:12 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-kiZO1vrDNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97540|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100629&action=edit
Bug 24436: Add handling for reserve transfer triggers

To test:
1 - Place a hold for pickup at a different branch than you are signed in at on
an item owned by current branch
2 - Check in the item
3 - Confirm the transfer
4 - Check the branchtransfers table and note the reason is 'Reserve'
5 - Set the preference CanMarkHoldsToPullAsLost to allow
6 - Place a hold on an item at branch you are singed in at
7 - Ensure you are not using strict sql modes (bug 22431)
8 - Go to Circulation->Holds to pull
9 - Mark hold as lost
10 - Check branchtransfers and confirm reason is "LostReserve"
11 - Check in item from step 1 at the correct branch
12 - Go to Circulation->Holds awaiting pickup
13 - Cancel the reserve
14 - Check branchtransfers and confirm reason is "CancelReserve"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:55:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:55:32 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-ak3Anmc76J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:55:35 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-6emazrOlLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97541|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100630&action=edit
Bug 24297: Record 'Manual' trigger transfers

To test:
1 - Apply patches, restart_all
2 - Gi to Circulation->Transfer
3 - Transfer an item
4 - Check the branch transfers table
5 - The reason is set to 'Manual'

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:55:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:55:58 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-dMliNJzV5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Teensy patch in the chain, PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:58:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:58:16 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-nMvZ7RvU49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:58:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 12:58:19 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-DAt3WZBE7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97542|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100631&action=edit
Bug 23092: Add 'daterequested' to branchtransfers table

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:15:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:15:47 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22381-70-x40TUTynOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Andrew, did you open a bug report?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:25:57 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-QCGAzqMUr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:26:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:26:01 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-5AKDzQaUp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100328|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100632&action=edit
Bug 19288: Don't show patron info for item level holds on details.pl unless
hold is waiting

This persists after bug 20948 - we can still display patron information even if
this patron is not the one
who will receive the item upon checkin. The holds tab can give an overview of
holds and information - I think
on the details page the only info we need is whether there might be a item
level hold, not who it is for

To test:
1 - Place an item level hold for delivery at a branch not matching home branch
of item
2 - Place a record level hold for delivery at homebranch of item placed on hold
above
3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home
library'
4 - View the details for the page, it says the item has a hold for the patron
with an item level hold
5 - Check in the item, the hold triggered is for the next available patron,
ignore the hold
6 - Apply patch
7 - Check details page, 'There is an item-level hold (priority=1)' with no
patron info
8 - Check in, next available hold is still the one triggered

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:27:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:27:47 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-CnLdi9jJti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100632|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100633&action=edit
Bug 19288: Don't show patron info for item level holds on details.pl unless
hold is waiting

This persists after bug 20948 - we can still display patron information even if
this patron is not the one
who will receive the item upon checkin. The holds tab can give an overview of
holds and information - I think
on the details page the only info we need is whether there might be a item
level hold, not who it is for

To test:
1 - Place an item level hold for delivery at a branch not matching home branch
of item
2 - Place a record level hold for delivery at homebranch of item placed on hold
above
3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home
library'
4 - View the details for the page, it says the item has a hold for the patron
with an item level hold
5 - Check in the item, the hold triggered is for the next available patron,
ignore the hold
6 - Apply patch
7 - Check details page, 'There is an item-level hold (priority=1)' with no
patron info
8 - Check in, next available hold is still the one triggered

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:38:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:38:07 +0000
Subject: [Koha-bugs] [Bug 24857] New: Add ability to create "Volumes" for
 records, and assign items to volumes
Message-ID: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

            Bug ID: 24857
           Summary: Add ability to create "Volumes" for records, and
                    assign items to volumes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

We have a partner that needs Volume Level Holds. This is a feature that some
ILSs have that allows the creation of volumes at the bibliographic level, with
items being optionally assigned to a given volume. This facilitates the ability
to place holds at a volume level, rather than on a specific item or any
available item on a record.

This but is to add just the volume management itself, which no functionality
tied to volumes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:38:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:38:12 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-HTkEMYwjxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:39:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:39:20 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-mmHh555XZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, what about this change:

                         unless ( $effective_mtt eq 'print' and $print_sent ==
1 ) {
-                            if ( ($mtt eq 'email' and not scalar
@emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) {
+                            if ( $effective_mtt eq 'print' and not $print_sent
) {
                                 push @output_chunks,
It makes the code more readable and less error prone, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:42:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:42:29 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-R09a7qALY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100634&action=edit
Bug 23357: [ALTERNATIVE PATH] Do not generate twice the same print notice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:43:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:43:34 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-RFpSbFrGIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It avoid to repeat the same test:

683                     if ( ($mtt eq 'email' and not scalar @emails_to_use) or
($mtt eq 'sms' and not $data->{smsalertnumber}) ) {
684                         # email or sms is requested but not exist, do a
print.
685                         $effective_mtt = 'print';
686                     }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:48:56 +0000
Subject: [Koha-bugs] [Bug 24858] New: Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
Message-ID: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

            Bug ID: 24858
           Summary: Incorrect labels on wording in
                    ExcludeHolidaysFromMaxPickUpDelay system preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The wording of the two options in ExcludeHolidaysFromMaxPickUpDelay is
reversed. This error was introduced in bug 22381.

- mark your library closed today and tomorrow
- set ReservesMaxPickUpDelay to 1 day
- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
- place hold, capture hold
- hold expiration date is set to the day after tomorrow (skips closed days)

- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
- Place hold, capture hold
- hold expiration date is set to tomorrow (doesn't skip closed days)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:49:09 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-cWC5Xtx8BZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381
[Bug 22381] Wording on Calendar-related system preferences not standardized
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:49:09 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22381-70-5MbsgvwSev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858
[Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay
system preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:49:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:49:49 +0000
Subject: [Koha-bugs] [Bug 24842] Automatic serials missing list feeding does
 not work when the numbering sequence includes regexp specific characters
In-Reply-To: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24842-70-fMEPg3SP8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100462|0                           |1
        is obsolete|                            |

--- Comment #4 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 100635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100635&action=edit
Bug 24842 Regexp issue create doubles in the serial missing list

the "delete issue" aspect (sub DelIssue) of the process was still uncorrectly
handled. I synchronized it with the rest.
... and redo my test plan again (...)

FINAL TEST PLAN (I hope so !) :
-------------------------------
To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value 
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Go to check the missing list in the summary tab of subscription :
   the issue had been added to the list.
4) If you go back to set the same issue to another type of missing status, you
will discover that it had been added a second time to the list.
5) if you set the missing status to "arrived", you will see that the sequences
had not been removed from the missing list.

Install the patch
clear manually the missing list from added issues.
redo 1 to 5 steps
You 'll see that issues are correctly added (and only one time) when tey have
to and correctly repoved.

If you delete an issue with missing status, you'll see that it's deleted from
the list as well


Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:50:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 13:50:00 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22381-70-ZcOZ1kv0bc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

--- Comment #22 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I have now. Bug 24858.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:06:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:06:27 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-yFxp10bbc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)
> Maybe, I do not know exactly what is missing.
> In debian scripts we are testing the dev_install config flag, so I think it
> makes sense to test it from the code as well.
> 
> Or we go backward, remove the specific paths and adjust KOHA_CONF?

I am open for both solutions.
>From a maintenance perspective it may be easier to adjust some koha-conf paths
in a Dockerfile or so than duplicating code in various places.
Note that the dev_install flag helped us to run the debian scripts as-is
without gitifying them as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:09:23 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-S1gjPCGNts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:09:27 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-FDpGJ92sx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100527|0                           |1
        is obsolete|                            |
 Attachment #100528|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100636&action=edit
Bug 5103: Format dates in MARC detail using dateformat syspref

This patch fixes the formatting of dates on the following pages:
- catalogue/MARCdetail.pl (staff)
- cataloguing/additem.pl (staff)
- opac-MARCdetail.pl (opac)

To test:
1) Ensure that the following fields are visible in the opac, intranet
and editor. You may need to edit the subfields in your default
bibliographic framework
952$d date accessioned
952$q date due/on loan
952$r date last seen
952$s date last borrowed
952$w replacement price date

Also ensure you have dateformat system preference set

2) Go to cataloguing/additem.pl for a biblio. Fill in the fields above
if required. Save
3) Remain on cataloguing/additem.pl. Notice the items table at the top
of the page, the dates are in the generic yyyy-mm-dd format
4) Go to catalogue/MARCdetail.pl for that biblio. Notice dates in wrong
format
5) View this biblio in the opac opac-MARCdetail.pl. Scroll to bottom to
items table. Notice dates in wrong format.
6) Apply patch, restart memcached and plack and refresh pages
7) Dates should now be formatted according to dateformat preference
8) Confirm that changing the preference changes the format of the dates

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:09:30 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-x61vL5peGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100637&action=edit
Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:09:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:09:34 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-QiuYqzxiQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100638&action=edit
Bug 5103: Refactor the code to avoid repetition

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:14:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:14:42 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-bgxDR0M0PY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100639&action=edit
Bug 23357: (follow-up) Do not generate twice the same print notice

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:14:48 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-6Ur2r4xBqR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:14:52 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-lyiO84w4xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100620|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100640&action=edit
Bug 24767: Hide the "Claim returned" tab if the feature is turned off

The ability to claim an item "claim returned" is not there if the syspref is
empty, however, the Claim Returned tab is stil present on the patrons detail
page.

Test Plan:
1) Ensure ClaimReturnedLostValue is not set
2) Note the claims tabs on the circulation and patron details pages
3) Apply this patch
4) Refresh those pages
5) The claims tabs should be gone!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Commit title amended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:15:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:15:04 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-mOPg9csOFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100634|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:15:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:15:37 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-7iwgPyjkNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #5)
> Created attachment 100634 [details] [review]
> Bug 23357: [ALTERNATIVE PATH] Do not generate twice the same print notice

This is a followup yes? I applied both and tested, works well, I can't see any
issue in the code. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:16:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:16:22 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-cxTy1bWclw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I never liked the way we specify things in the koha-conf.xml file :-D

If we did that, we would need:
intrahtdocs
intracgidir
opachtdocs
opaccgidir
and why not something for the API as well...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:22:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:22:18 +0000
Subject: [Koha-bugs] [Bug 24859] New: Items are returned when checking out a
 lost item that has been paid to the patron that lost it
Message-ID: <bug-24859-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24859

            Bug ID: 24859
           Summary: Items are returned when checking out a lost item that
                    has been paid to the patron that lost it
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Edge case, found while trying to recreate bug 24855:

To recreate:
1 - Check out an item with a replacement cost to a patron
2 - Ensure fees are charged when lost
3 - Mark the item lost
4 - Pay the fee
5 - Check out the item to the patron
6 - Item is not checked out
7 - Credit is issued

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:32:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:32:11 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-23WA3qnQr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #7)
> I never liked the way we specify things in the koha-conf.xml file :-D
> 
> If we did that, we would need:
> intrahtdocs
> intracgidir
> opachtdocs
> opaccgidir
> and why not something for the API as well...

I have the impression that you did not understand me or vice versa :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:41:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:41:06 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-EWE0DgqMje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Situation 1 - Overdue 3 days for Patron: email + print

A. No email defined, overdue -t generates

* on master, 2 notices OK
  1 print for patron
  1 email for staff

* on 23357 (only first patch)
  1 print for patron

* on 23357_2 (2 patches) OK
  1 print for patron
  1 email for staff

B. With email defined
* on master, 2 notices
  1 print for patron
  1 email for patron

* on 23357 (only first patch)
  1 print for patron
  1 email for patron

* on 23357_2 (2 patches) OK
  1 print for patron
  1 email for patron
  1 email for staff



Situation 2 - Overdue 3 days for Patron: email only

A. No email defined, overdue -t generates

* on master, 2 notices OK
  1 print for patron
  1 email for staff

* on 23357 (only first patch) OK
  1 print for patron
  1 email for staff

* on 23357_2 (2 patches) OK
  1 print for patron
  1 email for staff

B. With email defined
* on master, 2 notices
  1 email for patron

* on 23357 (only first patch)
  1 email for patron

* on 23357_2 (2 patches)
  1 email for patron

There is no OK in Situation 2 for B

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 14:46:46 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-xMEiaYOGwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have the feeling that we are going to far. I would go for this patch, it's
simple and written. Then we can discuss something bigger on a separate bug
report?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:01:22 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-iLGK8QPrfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Tomás Cohen Arazi from comment #7)
> > I never liked the way we specify things in the koha-conf.xml file :-D
> > 
> > If we did that, we would need:
> > intrahtdocs
> > intracgidir
> > opachtdocs
> > opaccgidir
> > and why not something for the API as well...
> 
> I have the impression that you did not understand me or vice versa :)

I understand what you propose and I like it. I just took the chance to say I
never liked our current config. And I love the dev_install thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:02:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:02:25 +0000
Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when
 item has been renewed
In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22539-70-4UBr4rU9pG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:02:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:02:37 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-DE0gFxkR1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Previous comment is not correct, -t does not mean "trigger an email for staff"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:04:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:04:10 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-hgh2lpj1WN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Situation 1 - Overdue 3 days for Patron: email + print

A. No email defined, overdue -t generates

* on master, 2 notices OK
  1 print for patron
  1 email for staff

* on 23357 (only first patch)
  1 print for patron

* on 23357_2 (2 patches) OK
  1 print for patron
  1 email for staff

B. With email defined
* on master, 2 notices OK
  1 print for patron
  1 email for patron

* on 23357 (only first patch) OK
  1 print for patron
  1 email for patron

* on 23357_2 (2 patches)
  1 print for patron
  1 email for patron
  1 email for staff



Situation 2 - Overdue 3 days for Patron: email only

A. No email defined, overdue -t generates

* on master, 2 notices OK
  1 print for patron
  1 email for staff

* on 23357 (only first patch) OK
  1 print for patron
  1 email for staff

* on 23357_2 (2 patches) OK
  1 print for patron
  1 email for staff

B. With email defined
* on master, 2 notices OK
  1 email for patron

* on 23357 (only first patch) OK
  1 email for patron

* on 23357_2 (2 patches) OK
  1 email for patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:04:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:04:40 +0000
Subject: [Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled
 emails for patrons with no email/sms if both transports enabled
In-Reply-To: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23357-70-p6bYkaL23m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
So situation 1 does not pass with our patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:11:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:11:13 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-O5Yazx1QBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why 99?

Should not this be a min-width CSS attribute instead? That would let us give a
value in em.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:14:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:14:01 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-WzVJo7b3ZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72540|0                           |1
        is obsolete|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100641&action=edit
Bug 15668: Add column configuration to the items table in staff detail pages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:16:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:16:09 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-ZdSJJxBm0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
This still doesn't work with the otherholdings table but I rebased, added
missing filters and column config yml. 

Can't seem to figure out why the otherholdings won't work. The console error
is:

TypeError: b.settings(...)[0].aoColumns[d] is undefined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:20:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:20:06 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-I8jDmQmkYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100641|0                           |1
        is obsolete|                            |

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100642&action=edit
Bug 15668: Add column configuration to the items table in staff detail pages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:25:51 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-CSBVI83iPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100605|0                           |1
        is obsolete|                            |

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100643&action=edit
Bug 20212: Use API to render orders datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:36:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:36:44 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-ZDO9dEkEza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

--- Comment #4 from John Sterbenz <jsterben at umich.edu> ---
This was discussed at the koha-US general meeting yesterday and I examined it
again.

It looks as though the problem reported in this bug was corrected as observed
in the 18.11 release sequence (we're running 18.11.14).  Looking for additional
verification of (unintentional?) squashing in this release sequence, 19.05,
19.11, and master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:39:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:39:17 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-vPoD7tnjrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

--- Comment #5 from Heather <heather_hernandez at nps.gov> ---
We're on 19.05.07.000 and I edited a map record and an online "computer file"
(database) record in Rancor, and neither one had their material types revert to
Book--their material types remained correct!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:45:49 +0000
Subject: [Koha-bugs] [Bug 24860] New: Add ability to place volume level holds
Message-ID: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

            Bug ID: 24860
           Summary: Add ability to place volume level holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This feature builds upon bug 24857 and allows placing holds that target a
specific volume of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:46:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:46:02 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-R8mHQG6lHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to create "Volumes" for records, and assign items to
volumes
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:46:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:46:02 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-rUd3Ojgrgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24860


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
[Bug 24860] Add ability to place volume level holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:13 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-P9d3USOG1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:15 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-XrA6Cmea17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100644&action=edit
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a
specific volume of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item
level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:24 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-98jAu1hs5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100645&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:26 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-c1KENnwVyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100646&action=edit
Bug 24860: Add new syspref EnableVolumeHolds

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:29 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-qipQq2gSRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100647&action=edit
Bug 24860: Implement reserves.volume_id

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:32 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-edWa9xJuzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100648&action=edit
Bug 24860: Add ability to select a volume when placing a hold

TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl
      Requires embedding volume in hold API

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:34 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-9ksLyp1R7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100649&action=edit
Bug 24860: Add ability to select a volume when placing a hold - OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:37 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-Ienz1DRgUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100650&action=edit
Bug 24860: Skip non-matching volume holds in CheckReserves

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:58:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 15:58:39 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-pXMoy1DFFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100651&action=edit
Bug 24860: Skip non-matching volume holds in HoldsQueue

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:01 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-eOtr22WtAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-eHmLDWkJxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100652&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-3bRYgjiBM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100653&action=edit
Bug 24857: Add Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:18 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-OZWQ7HrZeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100654&action=edit
Bug 24857: Add Koha Object(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:20 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-BFBR9cKuhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100655&action=edit
Bug 24857: Add Object Methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-KY7SE9tnXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100656&action=edit
Bug 24857: API spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:25 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-cJaeuGyZuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100657&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:28 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-13xjanq0OP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100658&action=edit
Bug 24857: Implement volume related controllers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-g9JZe9NmjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100659&action=edit
Bug 24857: Add volume management to detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-YaqD50xiDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100660&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:36 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-LPzTrtSGGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100661&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:09:39 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Eui6sEt42a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100662&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:20:03 +0000
Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
In-Reply-To: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24855-70-YGZHlCn8uV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
I did some testing here, the fines log issue is easily recreated by adding a
few fines of $0.10 and then a 6.99 fine, but the checkout is still returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:22:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:22:18 +0000
Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when
 floating-point math causes amountoutstanding to be not-quite-zero
In-Reply-To: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24855-70-VXMLnzjuRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Interesting! I tried it with a few fines of $1.00 and a 6.99 lost item and it
didn't recreate. Makes sense that even dollars v. some cents would make the
difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 16:36:14 +0000
Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes
 in search queries
In-Reply-To: <bug-20334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20334-70-CBero8viq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 18:28:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 17:28:43 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-jYpQxUeva8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, should the status here be Signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 19:01:42 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-rlJRWZvuWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:33:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 19:33:51 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-dLny5DxXf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #27 from David Nind <david at davidnind.com> ---
Thanks Katrin for spotting! It should have been, have changed now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:54:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 19:54:08 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-iUpZKwfIDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #6 from David Nind <david at davidnind.com> ---
Thanks Jonathan! I'll have another go at it this evening.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:26:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 20:26:18 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-9x6Zm71uun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #59 from Gabriel DeCarufel <gabriel.decarufel at inlibro.com> ---
Created attachment 100663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100663&action=edit
Bug 17385: Added download option in list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:27:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 20:27:48 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-1mobBPrGQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel <gabriel.decarufel at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 22:49:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 21:49:08 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-lJkRdLAykz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100393|0                           |1
        is obsolete|                            |

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100664&action=edit
Bug 24830: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 22:49:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 21:49:11 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-OIWIOGcgqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100665&action=edit
Bug 24830: Fix parse_prefetch recursion and +count cases

When a child of a prefetched element wasn't found on element's
prefetch_whitelist, no prefetch element was returned.. including element
it self. Now we return element's name if no child was found.

Also, embeded keys that ended with +count where taken literaly. Now we
search the correct key by stripping _count of embedded element if it was
declared as "is_count"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 22:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 21:55:17 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-HZlsQBkK9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 22:55:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 21:55:21 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-G2vtLKRb3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100665|0                           |1
        is obsolete|                            |

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 100666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100666&action=edit
Bug 24830: Fix parse_prefetch recursion and +count cases

When a child of a prefetched element wasn't found on element's
prefetch_whitelist, no prefetch element was returned.. including element
it self. Now we return element's name if no child was found.

Also, embeded keys that ended with +count where taken literaly. Now we
search the correct key by stripping _count of embedded element if it was
declared as "is_count"

To test:
1. Apply test patch but not this one
2. prove t/Koha/REST/Plugin/Query.t
CHECK => tests shoul fail
3. Apply this patch
4. prove t/Koha/REST/Plugin/Query.t
SUCCESS => tests pass
5. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 23:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 22:20:38 +0000
Subject: [Koha-bugs] [Bug 24861] New: Unable to setPatronPasswordPublic
 using REST API
Message-ID: <bug-24861-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24861

            Bug ID: 24861
           Summary: Unable to setPatronPasswordPublic using REST API
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au

I've tried POST /api/v1/public/patrons/{patron_id}/password with RESTPublicAPI
enabled (using koha-testing-docker with Plack enabled), but I keep getting 401
errors.

curl http://localhost:8080/api/v1/public/patrons/42/password -d
'{"old_password":"OLD","password":"NEW","password_repeated":"NEW"}'

{"error":"Authentication failure."}

With RESTBasicAuth enabled and using the username and password for patron #42:

curl -u <username:password>
http://localhost:8080/api/v1/public/patrons/42/password -d
'{"old_password":"OLD","password":"NEW","password_repeated":"NEW"}'

{"error":"Authorization failure. Missing required
permission(s).","required_permissions":null}

Perhaps I'm doing something wrong but this looks like a bug to me?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 23:29:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 22:29:00 +0000
Subject: [Koha-bugs] [Bug 24862] New: REST API throws 500 errors for browser
 after logout
Message-ID: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

            Bug ID: 24862
           Summary: REST API throws 500 errors for browser after logout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au

It looks like the REST API might not be handling cookies correctly.

To test:
0. Use koha-testing-docker
1. Login to http://localhost:8080/
2. Go to http://localhost:8080/api/v1/libraries
3. Observe a 200 OK HTTP code and JSON output
4. Logout from http://localhost:8080/
5. Go to http://localhost:8080/api/v1/libraries
6. Observe a 500 Internal Server Error and the following JSON output:
{"error":"Something went wrong, check the logs."}

It seems to me that really that should be returning a 401 and the following
JSON output:
{"error":"Authentication failure."}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 23:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 22:40:42 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-bie2hxdxEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 23:40:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 22:40:44 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-fCY5aZSbvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100667&action=edit
Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay

TO TEST:
- Apply patch
- mark your library closed today and tomorrow
- set ReservesMaxPickUpDelay to 1 day
- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
- place hold, capture hold
- hold expiration date is set to tomorrow (doesn't skip closed days)

- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
- Place hold, capture hold
- hold expiration date is set to the day after tomorrow (skips closed days)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:45:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 23:45:33 +0000
Subject: [Koha-bugs] [Bug 24727] Typo in circulation.js
In-Reply-To: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24727-70-6Ek1KnesTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24727

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #14 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:46:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 23:46:31 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-JPdCRoGZxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 23:56:17 +0000
Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for
 login-dependent operations
In-Reply-To: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24249-70-YlETEgsEWd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 23:56:17 +0000
Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages
In-Reply-To: <bug-24247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24247-70-r5Rysfwz4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247
Bug 24247 depends on bug 24249, which changed state.

Bug 24249 Summary: OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2020 23:59:22 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: <bug-24367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24367-70-YFHOyvlSvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #21 from Joy Nelson <joy at bywatersolutions.com> ---
not backported due to missing dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:03:31 +0000
Subject: [Koha-bugs] [Bug 24549] Cookies for last patron link are always set
 - even if showLastPatron is turned off
In-Reply-To: <bug-24549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24549-70-qVAI20yv9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:03:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:03:47 +0000
Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt
In-Reply-To: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24388-70-yapgoyRL6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:04:08 +0000
Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging
 preferences to empty
In-Reply-To: <bug-18933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18933-70-xvVYKILES6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:04:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:04:25 +0000
Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title
 before surname
In-Reply-To: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24514-70-oUDbF4mTEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:04:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:04:51 +0000
Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered
 when dumped
In-Reply-To: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24110-70-4NgPwzHmkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:12:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:12:05 +0000
Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when
 total holds unlimited
In-Reply-To: <bug-24669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24669-70-yALzkZEVXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
not backporting to 19.11.x due to missing dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:16:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:16:24 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-PzgUHYjLNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #44 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:16:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:16:39 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-eRSW0dcmPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:16:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:16:53 +0000
Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on
 English PDF order templates
In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5016-70-uq1J60WRSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:17:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:17:08 +0000
Subject: [Koha-bugs] [Bug 24666] Non Koha Guarantors should be able to be
 seen from the Patron Detail page
In-Reply-To: <bug-24666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24666-70-8MmSlySUTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:17:20 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-wDLrJsFT3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:36:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:36:10 +0000
Subject: [Koha-bugs] [Bug 24051] batchMod.pl:
 DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated
In-Reply-To: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24051-70-5G6kc77S82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:36:19 +0000
Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to
 circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-3bQVJeCcGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:36:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:36:29 +0000
Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to
 circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-VLwCBIUTg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:36:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:36:42 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-nZzIc6236O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:36:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:36:55 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
 linking to correct records
In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24094-70-ROEPxNuFtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:37:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:37:10 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-Nrn2jqaBor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:40:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:40:47 +0000
Subject: [Koha-bugs] [Bug 24648] Contextualization of past tense "Created"
In-Reply-To: <bug-24648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24648-70-CLmQXALZKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:41:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:41:15 +0000
Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic
 record on OPAC
In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23593-70-gVfqJ57IoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:41:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:41:46 +0000
Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to
 templates
In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24103-70-MbVriwsXAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #14 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:42:11 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-ppZjmkAbeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #35 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:42:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:42:37 +0000
Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item
 search
In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18433-70-QD0GHqrXya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #46 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:43:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:43:06 +0000
Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines &
 Charges' on tab of the same name
In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6508-70-rWpvNXAXYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #24 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:43:48 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-7xdr0qWVo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #124 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:43:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:43:50 +0000
Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA
 installation file
In-Reply-To: <bug-24708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24708-70-TwD2h25Fbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708
Bug 24708 depends on bug 11297, which changed state.

Bug 11297 Summary: Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:46:51 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-dI8HXQm4hv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:47:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:47:24 +0000
Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on
 exporting records
In-Reply-To: <bug-14647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14647-70-mvVun7QqQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #22 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:47:52 +0000
Subject: [Koha-bugs] [Bug 14898] Add 'Save and pay' button to use after
 adding a manual invoice
In-Reply-To: <bug-14898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14898-70-JI3424NHtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #14 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:49:09 +0000
Subject: [Koha-bugs] [Bug 24670] Circulation and fine rules page has
 performance issues since issuingrules change
In-Reply-To: <bug-24670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24670-70-3sqoLMpBce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #21 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:50:16 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14567-70-RanlLAriEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #66 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:50:17 +0000
Subject: [Koha-bugs] [Bug 24691] OpacBrowseSearch: Show number of results
 behind each list entry
In-Reply-To: <bug-24691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24691-70-8Cj09KU90o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691
Bug 24691 depends on bug 14567, which changed state.

Bug 14567 Summary: Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:50:17 +0000
Subject: [Koha-bugs] [Bug 24692] OpacBrowseSearch: enable navigating result
 list with arrow keys
In-Reply-To: <bug-24692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24692-70-9wyLb4WXQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692
Bug 24692 depends on bug 14567, which changed state.

Bug 14567 Summary: Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:50:48 +0000
Subject: [Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup
 locations for holds
In-Reply-To: <bug-24657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24657-70-DvXZMHNIQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:51:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:51:21 +0000
Subject: [Koha-bugs] [Bug 17702] Create configuration for account credit
 types
In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17702-70-aAvH9rTIOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #36 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:51:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:51:21 +0000
Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and
 accountlines.credit_type should be merged
In-Reply-To: <bug-23894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23894-70-wgXwRojQvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894
Bug 23894 depends on bug 17702, which changed state.

Bug 17702 Summary: Create configuration for account credit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:53:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:53:30 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-RdPEaMYUkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:53:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:53:48 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
 $0
In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17510-70-mpXcTC00Av@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #20 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:54:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:54:09 +0000
Subject: [Koha-bugs] [Bug 22655] Onboarding tool should offer to add Hold
 rule in addition to Circulation rule
In-Reply-To: <bug-22655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22655-70-MI55ye8Dbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:54:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:54:35 +0000
Subject: [Koha-bugs] [Bug 24588] Set `Mailer-X` and `MessageID` mail headers
 to reduce the likelihood of Koha mail being marked as spam
In-Reply-To: <bug-24588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24588-70-1MVLkp3Vik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 01:56:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 00:56:29 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-6iVvOGSCTO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:12:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:12:10 +0000
Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if
 koha_trusted_proxies contains invalid value
In-Reply-To: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24538-70-T94GDBwpb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:12:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:12:27 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-Nln14VgBzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:21:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:21:43 +0000
Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error
In-Reply-To: <bug-24676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24676-70-urG1mpF5E9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:21:48 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-eGWQbzLYKk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #51 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:22:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:22:10 +0000
Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in the
 OPAC
In-Reply-To: <bug-17896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17896-70-aJmY6Qo23i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #19 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:22:37 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-Gp2dUBmgpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #41 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x branch cleanly.
please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:23:43 +0000
Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
In-Reply-To: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23482-70-jUSF0CWanB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x branch
please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:25:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:25:32 +0000
Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in
 preference
In-Reply-To: <bug-24646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24646-70-yON9ngipt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x
please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:25:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 01:25:48 +0000
Subject: [Koha-bugs] [Bug 24706] Toolbar not rendered correctly when a list
 is empty
In-Reply-To: <bug-24706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24706-70-SYcHeTZYDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24706

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
does not apply to 19.11.x branch  
please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 03:41:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 02:41:51 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-mDUk5YNdP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 04:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 03:36:20 +0000
Subject: [Koha-bugs] [Bug 24845] Web-based installer consistently fails
 while creating database tables.
In-Reply-To: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24845-70-IXe6RnjUOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24845

Dwight Tuinstra <dwight.tuinstra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #8 from Dwight Tuinstra <dwight.tuinstra at gmail.com> ---
Ooops!! My bad. Didn't notice the Debian ISO was 32-bit, and I've been away
from Debian too long and didn't realize that i686 wasn't the 64-bit version.

So ... I redid everything with a 64-bit Debian guest VM. Ran into the same
problems when the VM only had 1 CPU and 1GB of memory. Bumping that up to 4
CPUs,  2GB of memory, and enabling the guest SATA controller to "Use host I/O
cache" did the trick -- all steps finished quickly. Not sure which change made
the difference. Might be good to have a System Requirements section in the
install docs.

Marking this as RESOLVED - INVALID.

Thank you for your help!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 07:48:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 06:48:57 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-VmFxaT35ja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #5 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100668&action=edit
Bug 19475: Add unit tests

To test prove:
t/db_dependent/Holidays.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 07:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 06:49:14 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-fO7BRmH1bA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 09:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 08:11:44 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set.
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-lgEdhjm2Nz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

--- Comment #4 from didier <didier.gautheron at biblibre.com> ---

99 is 100% arbitrary.

Using min-width is another option, but I'm not sure it'd be smaller
patch/cleaner though.

I'll look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 09:41:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 08:41:01 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-bWOoSKvLtf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 09:41:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 08:41:04 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-WjC9tV5HL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100667|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100669&action=edit
Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay

TO TEST:
- Apply patch
- mark your library closed today and tomorrow
- set ReservesMaxPickUpDelay to 1 day
- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
- place hold, capture hold
- hold expiration date is set to tomorrow (doesn't skip closed days)

- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
- Place hold, capture hold
- hold expiration date is set to the day after tomorrow (skips closed days)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:02 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-kHK1ia6M9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:07 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-H3AIJAf6ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100289|0                           |1
        is obsolete|                            |

--- Comment #60 from David Nind <david at davidnind.com> ---
Created attachment 100670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100670&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
    * The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Enable XSL - Simple Export option for system preference OpacExportOptions
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found XSL - Simple Export.
  - Click XSL - Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
https://bugs.koha-community.org/show_bug.cgi?id=17835

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:12 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-TTXQv8MBzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100290|0                           |1
        is obsolete|                            |

--- Comment #61 from David Nind <david at davidnind.com> ---
Created attachment 100671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100671&action=edit
Bug 17385: Add tests for CustomXSLTExportList

+ Added tests for CustomXSLTExportList to C4::XSLT
+ Added an eval block in CustomXSLTExportList to handle invalid XML.

* Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent

+ Added "Custom" option to OPACExportOptions preference.

Tested with invalid XML (not originally on purpose, but...) and then
added a new field to add to the simple export.

Walked through the testing steps.

Question: should this also apply to the cataloging page as an export
option? It doesn't now.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:17 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-IjF5TCsIYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100291|0                           |1
        is obsolete|                            |

--- Comment #62 from David Nind <david at davidnind.com> ---
Created attachment 100672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100672&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:21 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-uqtLf0vkXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100292|0                           |1
        is obsolete|                            |

--- Comment #63 from David Nind <david at davidnind.com> ---
Created attachment 100673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100673&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:26 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-yvjtOthRua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100293|0                           |1
        is obsolete|                            |

--- Comment #64 from David Nind <david at davidnind.com> ---
Created attachment 100674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100674&action=edit
Bug 17385: QA Critics Fixed and added Missing Filters

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:02:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 09:02:31 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-qpIoiqXHFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100663|0                           |1
        is obsolete|                            |

--- Comment #65 from David Nind <david at davidnind.com> ---
Created attachment 100675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100675&action=edit
Bug 17385: Added download option in list

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 10:02:54 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-MVT1oL4zfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:02:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 10:02:58 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-cx6U5yHRWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100669|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100676&action=edit
Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay

TO TEST:
- Apply patch
- mark your library closed today and tomorrow
- set ReservesMaxPickUpDelay to 1 day
- set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar"
- place hold, capture hold
- hold expiration date is set to tomorrow (doesn't skip closed days)

- Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar"
- Place hold, capture hold
- hold expiration date is set to the day after tomorrow (skips closed days)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 10:03:11 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-TRQ4mFziUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 10:11:51 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-3uCMn5idmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #9)
> I have the feeling that we are going to far. I would go for this patch, it's
> simple and written. Then we can discuss something bigger on a separate bug
> report?

Well, this would be the first occurrence in a perl module. So it is not only a
matter of "I wrote it already".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:21:40 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-BLOv9H7CHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:21:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:21:43 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-BWHEsRRj8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99470|0                           |1
        is obsolete|                            |

--- Comment #8 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100677&action=edit
Bug 24701: Add column config to course_items_table

This patch adds course_items_table to the column config tool
TEST PLAN:
1. Have some course reserves
2. Add some items to that course reserve and browse to opac-course-details
2. See all the unconfigurable columns
3. Apply patch
4. Browse to column config > OPAC > opac-course-details
5. Try hiding each column and make sure the correct column is hidden on
opac-course-details.pl

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:30:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:30:47 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-butFEPeTml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
                   |ommunity.org                |ity.org
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:30:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:30:54 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-stu0pcNhna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:33:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:33:14 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-fkRxLnNzZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Comment #12 is|1                           |0
            private|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:41:08 +0000
Subject: [Koha-bugs] [Bug 24863] New: QueryFuzzy syspref says it requires
 Zebra but Elasticsearch has some support
Message-ID: <bug-24863-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

            Bug ID: 24863
           Summary: QueryFuzzy syspref says it requires Zebra but
                    Elasticsearch has some support
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

The QueryFuzzy syspref affects zebra in that a fuzziness value is passed to the
query, however, it simply allows or disallows the use of the fuzzy search
option

To activate fuzziness on a term one must add '~'

Should turning on fuzziness do this automatically?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:41:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:41:16 +0000
Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra
 but Elasticsearch has some support
In-Reply-To: <bug-24863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24863-70-LkZFEYnEz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 11:50:18 +0000
Subject: [Koha-bugs] [Bug 19616] Formatted Contents Note (Marc 21 505),
 subfield g isn't visible in the OPAC
In-Reply-To: <bug-19616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19616-70-IOUOMaclLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to verolencinas from comment #0)
> The 505 field in Marc 21, Formatted Contents Note, includes subfield g
> "Miscellaneous information". According to the Marc 21 format for
> bibliographic data, it is used to record "volume, part, page numbering or
> other extent information such as dates". If you use it in Koha, this
> information isn't visible in the OPAC.

Verónica, this should be dependent on ind2=0, right? What about $u?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:03:11 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-oLTRCs99wA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100592|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100678&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:03:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:03:14 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-fliKu1k8V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100593|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100679&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:03:17 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-lD64mtPyCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100594|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100680&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:03:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:03:20 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-jtdED9Hk0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100681&action=edit
Bug 24850: Don't fallback when date_format is passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:03:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:03:54 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-7hF7uLC3vN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100595|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:04:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:04:27 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-csknjuxPWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #8)
> I'm not sure about the final followup.. it scares me that we're always
> falling back to a relatively loose regex at the moment; even if a
> date_format is passed in.

Corrected in final followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:22:52 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-ujG7IznNUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:22:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:22:55 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-H5qsNRG9Cs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 100682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100682&action=edit
Bug 23236 - Remove 'its items may still be processed' in action if no match is
found

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 12:30:24 +0000
Subject: [Koha-bugs] [Bug 10161] rebuild_zebra.pl should (at least) exit 1
 on error
In-Reply-To: <bug-10161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10161-70-HYhRf2KhXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10161

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:18:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 13:18:08 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-HryLvV9f0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Good catch, David. Thanks for reporting it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:34:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 13:34:34 +0000
Subject: [Koha-bugs] [Bug 24864] New: No rental fee alert if item has
 accompanying material (952$3)
Message-ID: <bug-24864-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24864

            Bug ID: 24864
           Summary: No rental fee alert if item has accompanying material
                    (952$3)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the item has a value in 952$3 and a rental fee, only the accompanying
material message pops-up upon checkout. The charge is added to the patron's
accounting, but there is no alert.

To replicate:
1- Create an item type with a rental fee
2- Catalog an item with that item type and enter a value in subfield 3 -
materials specified
3- To compare, also catalog an item with that item type and no value in
subfield 3
4- Loan the item with materials specified to a patron; notice only the
materials specified message appears
5- To compare, loan the item without materials specified to a patron; notice
the rental fee alert

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:59:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 13:59:59 +0000
Subject: [Koha-bugs] [Bug 24864] No rental fee alert if item has
 accompanying material (952$3)
In-Reply-To: <bug-24864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24864-70-EiZHhiijul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24864

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Hm, I think I misunderstood the behaviour. The fee message only appears if the
patron already has fees in their file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:06:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 14:06:17 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-uKUyoyrOYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #8 from Magnus Enger <magnus at libriotech.no> ---
Had another look at this, and it looks like the "Argument "" isn't numeric in
numeric" is triggered for culumns that have a default_value of 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:23:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 14:23:22 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-tklFvcrT0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

--- Comment #3 from mjnkml at gmail.com ---
(In reply to Jonathan Druart from comment #2)
> Hi, are you able to test this patch?
> 
> I do not have Sendmail configured in my test environment so cannot recreate
> the problem.

Hi,

Just to clarify: I'm using postfix.

The patch seems to work really well. Some output:

before patching:

$ sudo koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/overdue_notices_borrower_1_only.pl -t
$ sudo koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl -v
sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line
980.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16.
sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line
980.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16.
$

after patching:


$ sudo koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/overdue_notices_borrower_1_only.pl -t
$ sudo koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl -v
sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line
980.
sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line
980.
$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:43:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 14:43:20 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-smRhwWdQlP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:06:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:06:22 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-AUEsrn4Wfe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The patch does this:
+# Set the userenv
+C4::Context->_new_userenv(1);
+C4::Context->set_userenv(
+    undef, undef, undef, 'ILSDI', 'ILSDI', undef,
+    undef, undef, undef, undef,  undef
+);
+C4::Context->interface('opac');

For comparison, misc/commit_file.pl does this:
# FIXME dummy user so that logging won't fail
# in future, probably should tie to a real user account
C4::Context->set_userenv(0, 'batch', 0, 'batch', 'batch', 'batch', 'batch');

And Koha::Script does this:
        C4::Context->_new_userenv(1);
        C4::Context->set_userenv(
            undef, undef, undef, 'CRON', 'CRON',
            undef, undef, undef, undef,  undef
        );
Might be that the author copied this part of the code? (I think it should be
adapted; see below.)

The sub _new_userenv stores a sessionID in activeuser (which is quite
confusing). I would not recommend to always use session 1. (Session id is a
varchar(32) btw.) Why not use "ILSDI_session", possibly followed by a few
digits or so?

Another note: 11 parameters are passed in ilsdi.pl and Koha::Script. I only
count 10. We're copy&pasting an error here.
    shift @_; # this is the object
    my ($usernum, $userid, $usercnum, $userfirstname, $usersurname,
$userbranch, $branchname, $userflags, $emailaddress, $shibboleth)= [etc]  #
these are 10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:09:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:09:16 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-BAab5Ab25t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:09:23 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-BaD6moHB5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:12:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:12:23 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-TyB3bQJqLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |julian.maurice at biblibre.com
                   |                            |,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:13:12 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-xvjrS4wzc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:13:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:13:57 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-78VzpFx47H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100683&action=edit
Bug 24862: Regression tests

This patch introduces tests for the expected behaviour on API routes
that expect a logged in user, but the request is made with an anonymous
session cookie.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail because the situation is not handled correctly in
the code

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:14:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:14:00 +0000
Subject: [Koha-bugs] [Bug 24862] REST API throws 500 errors for browser
 after logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-uQrhdB0njN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100684&action=edit
Bug 24862: Handle annonymous sessions gracefuly

This patch introduces code to detect (cookie) annonymous sessions and
act as expected.

Right now, as check_cookie_auth is not passed the required permissions
(because there aren't always required permissions, and the code to check
permissions is shared with other authentication mechanisms) it returns
'ok' and the session id. This use case was overlooked when this was
coded, and yeilds unexpected error codes (500) when the user logs out
and the annonymous session cookie is used to hit the API. The end result
doesn't pose any security issue (i.e. the resource access is rejected)
but the returned error code is not correct and should be fixed.

This patch verifies for an anonymous session (and avoids querying the
corresponding patron) and then verifies if there is an authorization
config on the route and if the patron object is defined.

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail, 500 instead of the expected 401
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Repeat the original 'steps to reproduce' from the bug report using
   the browser
=> SUCCESS: Problem solved!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:28:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:28:43 +0000
Subject: [Koha-bugs] [Bug 24862] API throws 500 errors for browser after
 logout
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-IKsTC6uYGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API throws 500 errors  |API throws 500 errors for
                   |for browser after logout    |browser after logout

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:30:31 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-bRmBsHwpO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I am not able to reproduce this problem.
Probably a config issue. The commit message is incomplete?
Where do I insert that items should be included? I now only see the biblio
record and have the impression that the yaml file is ignored.
Should I add the created yaml file in the prefs? etc. If I add    
include_items: 1 and add the yaml file in the pref, I am seeing error:
Dissemination as 'marcxml' is not supported.

Please provide more info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:30:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:30:40 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-lCyeQgoFAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:40:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:40:55 +0000
Subject: [Koha-bugs] [Bug 24646] RoundFinesAtPayment is not a self check in
 preference
In-Reply-To: <bug-24646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24646-70-Pbpe8JlVr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100685&action=edit
Bug 24646: [19.11.x] Move RoundFinesAtPayment to 'Fines policy' section

To test:
 - Search Admin->System preferences for 'RoundFinesAtPayment'
 - Note it is listed under self-check
 - Apply patch
 - Restart/refresh
 - Note it is now under Accounting -> Policy

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:41:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:41:39 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-tGPMbdSBKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
'/var/lib/koha/master/OAI.yaml' is empty or non-existent at
/usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/Syck.pm line 129.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:43:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:43:25 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-rdn29b5j4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
ok, copied something from bug 12252 (create a yaml file is not very helpful in
this message here)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:44:48 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-uCzI9f5AHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
ah reproduced finally:
Empty String at /usr/share/koha/Koha/OAI/Server/Record.pm line 58.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:50:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:50:30 +0000
Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
In-Reply-To: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23482-70-SVr9QZTIVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100686&action=edit
Bug 23482: [19.11.x] Fix BakerTaylor cover images on lists

While this needs a username/pass to fully test, it should be possible to
verify the code changes by comparing to opac-results code

To test:
1 - Enable BakerTaylor images
2 - Enter your usernme and password
3 - Do not fill the BookStore URL
4 - Verify OPAC covers are working
5 - Save some times with covers to a public list
6 - Verify they do not display in list
7 - Apply patch
8 - Verify images now work

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:52:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:52:51 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-cule3HNIK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still not getting the point of the change completely:

        $sql .= "
            UNION
            SELECT deleteditems.timestamp FROM deleteditems JOIN biblio USING
(biblionumber)
            WHERE biblionumber=?
            UNION
            SELECT timestamp from items
            WHERE biblionumber=?
        ";

Ambiguous now for biblionumber when adding the left join?
Why do you add the left join if you only want deleteditems ?

Please provide feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:56:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:56:33 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-GhvqaZiwGx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:56:36 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-gZg1pyNKrq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100317|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100687&action=edit
Bug 24809: Get only timestamp of deleted items attached to existing bibs when
check if bib deleted

To test:
 1 - Edit/create a file in the koha home dir
'/var/lib/koha/{instance}/OAI.yaml' with content like below:
format:
  marcxml:
    metadataPrefix: marcxml
    metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
    schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
    include_items: 1
 2 - Set the systempreferences below to indicated values:
  OAI-PMH => Enable
  OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml
 3 - View a record with items and confirm the items show:
 
http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4
 4 - Delete the items, then delete the record
 5 - Reload the URL from step 3
 6 - Internal Server Error:
  Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58.
    at /usr/share/perl/5.24/Carp.pm line 167
 7 - Apply patch
 8 - restart_all
 9 - Repeat
10 - Reload URL from step 3
11 - Success

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:58:14 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-QSgyw3CvKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12252
           Severity|enhancement                 |normal


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252
[Bug 12252] OAI-PMH GetRecord result doesn't include item data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 15:58:14 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
 item data
In-Reply-To: <bug-12252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12252-70-YtZ09k5NVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24809


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809
[Bug 24809] OAI PMH can fail on fetching deleted records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:14:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:14:34 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-bQh0LZsDwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #7)
> Still not getting the point of the change completely:
> 
>         $sql .= "
>             UNION
>             SELECT deleteditems.timestamp FROM deleteditems JOIN biblio
> USING (biblionumber)
>             WHERE biblionumber=?
>             UNION
>             SELECT timestamp from items
>             WHERE biblionumber=?
>         ";

The goal of the query is the get the latest change for a record and return
undef if record is deleted. We need to check deleted items because deleting an
item will not update the biblioitems timestamp. We need to limit to deleted
items where the bib is not deleted. 

> Ambiguous now for biblionumber when adding the left join?1
> Why do you add the left join if you only want deleteditems ?

Where is the LEFT JOIN?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:22:53 +0000
Subject: [Koha-bugs] [Bug 24865] New: Customize the Accountlines Description
Message-ID: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865

            Bug ID: 24865
           Summary: Customize the Accountlines Description
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lisetteslatah at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be great if we could customize what information was added to the
"Description of charges" field when a fine was made so data could be stored
even when the item is deleted. 

For example if you would like to be able to store the home library code, title,
and barcode even if the item was deleted, you could have it e entered
automatically when the fine was created. 

This would be very helpful to us.  
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:27:49 +0000
Subject: [Koha-bugs] [Bug 24866] New: (bug 16123 update) Display budget
 hierarchy in the budget dropdown menu used when placing a new order
Message-ID: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

            Bug ID: 24866
           Summary: (bug 16123 update) Display budget hierarchy in the
                    budget dropdown menu used when placing a new order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The rendering of SELECT elements is up to the browser but Bug 16123 CSS code
'style="padding-left: xx' doesn't work on modern browsers (firefox, chrome).

This patch replace CSS style attribute with &emsp; html entity.

On supported platforms
TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2020)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2020
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Select a vendor and create a new basket
7. Place an order
8. Check the budget dropdown menu

BEFORE PATCH
Book
Adult fiction

OR

Book
   Adult fiction


AFTER PATCH
Book
   Adult fiction

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:32:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:32:31 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-9tkQsnSH8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #20)
> Koha::Script does this:
> Might be that the author copied this part of the code?

Yes, copied from there

> The sub _new_userenv stores a sessionID in activeuser (which is quite
> confusing). I would not recommend to always use session 1. (Session id is a
> varchar(32) btw.) Why not use "ILSDI_session", possibly followed by a few
> digits or so?
Any recommendation on the digits? Use a timestamp or the same for each?


> Another note: 11 parameters are passed in ilsdi.pl and Koha::Script. I only
> count 10. We're copy&pasting an error here.
>     shift @_; # this is the object
>     my ($usernum, $userid, $usercnum, $userfirstname, $usersurname,
> $userbranch, $branchname, $userflags, $emailaddress, $shibboleth)= [etc]  #
> these are 10

Koha Script appears to be right, just a typo when changing to cron I think

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:44:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:44:42 +0000
Subject: [Koha-bugs] [Bug 24866] (bug 16123 update) Display budget hierarchy
 in the budget dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-kY7y7DwkPe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

--- Comment #1 from didier <didier.gautheron at biblibre.com> ---
Created attachment 100688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100688&action=edit
Bug 24866 - Display budget hierarchy in the budget dropdown menu used when
placing a new order

The rendering of SELECT elements is up to the browser.
But Bug 16123 CSS code 'style="padding-left: xx' doesn't work on modern
browsers.

This patch replace CSS style attribute with &emsp; html entity.

On supported platforms
TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2020)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2020
 |____ Book
         |_____ Adult fiction

5. Go to the Acquisition module
6. Select a vendor and create a new basket
7. Place an order
8. Check the budget dropdown menu

BEFORE PATCH
Book
Adult fiction

OR

Book
   Adult fiction

AFTER PATCH
Book
   Adult fiction

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:49:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:49:50 +0000
Subject: [Koha-bugs] [Bug 24867] New: Keep CircControl /
 ReservesControlBranch / HomeOrHolding together in sysprefs
Message-ID: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

            Bug ID: 24867
           Summary: Keep CircControl / ReservesControlBranch /
                    HomeOrHolding together in sysprefs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be great if these three sysprefs were linked so that they appear
together and a search for one always bring up the others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:50:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 16:50:01 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-bpevCeubop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:08:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:08:50 +0000
Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC
 standards for Area Subarrangments of cataloged maps
In-Reply-To: <bug-17269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17269-70-JhGaoY3V8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269

--- Comment #1 from Heather <heather_hernandez at nps.gov> ---
We just got Elasticsearch, and these call numbers with colons in them appear to
be sorting correctly:
https://keys.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=callnum%2Cphr%3Ag4364&offset=40&sort_by=call_number_asc

Our Koha version is 19.05.07.000
--h2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:20:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:20:21 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-ccEbGCHgHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|API throws 500 errors for   |Wrong behaviour on
                   |browser after logout        |anonymous sessions
                 CC|                            |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:40:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:40:34 +0000
Subject: [Koha-bugs] [Bug 24868] New: When CircControl or
 ReservesControlBranch are enforced based on item location limits are
 enforced per library
Message-ID: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

            Bug ID: 24868
           Summary: When CircControl or ReservesControlBranch are enforced
                    based on item location limits are enforced per library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Here's the situation:
- Library has Branch A and Branch B
- Library has ReservesControlBranch set to enforce based on item home library
- Library has circ rule for all branches / all patrons / itype DVD that has max
of 1 hold allowed
- Patron is allowed to place 1 hold on a DVD from Branch A AND 1 hold on a DVD
from Branch B

This same logic applies to other parts of the circ and fine rules that are
enforcing counts - holds per day, current checkouts allowed, total current
checkouts allowed, maximum holds allowed, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:40:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:40:46 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-jReXyncm8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:41:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:41:32 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item, location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-3ePfVm2hoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When CircControl or         |When CircControl or
                   |ReservesControlBranch are   |ReservesControlBranch are
                   |enforced based on item      |enforced based on item,
                   |location limits are         |location limits are
                   |enforced per library        |enforced per library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:48:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:48:27 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-5WtTmYXsMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Needs Signoff               |In Discussion

--- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
We are reviewing this one internally and plan to demo it to the sponsoring
library to get some feedback before this continues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:49:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:49:38 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item, location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-2KN4g9b8KY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:51:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:51:42 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item, location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-Y7j090mdXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:54:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 17:54:23 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item, location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-BYdG6DJt8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Clarifying a bit, we at ByWater have talked this one back and forth and are
fairly uncertain about it. We agree that this behavior isn't really what one
would logically assume based on how rules are presented. But is this behavior
correct? Is it what libraries want? There may not be a universal agreement to
be found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:04:38 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-08JGe8PQpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:04:42 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-Ab3qp8SL3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100664|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:04:47 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-snZMO5p4d2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100666|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:05:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:05:44 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-FAKJDFU9za@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100689&action=edit
Bug 24830: Add tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:05:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:05:52 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-DGwziKcxR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 100690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100690&action=edit
Bug 24830: Fix parse_prefetch recursion and +count cases

When a child of a prefetched element wasn't found on element's
prefetch_whitelist, no prefetch element was returned.. including element
it self. Now we return element's name if no child was found.

Also, embeded keys that ended with +count where taken literaly. Now we
search the correct key by stripping _count of embedded element if it was
declared as "is_count"

To test:
1. Apply test patch but not this one
2. prove t/Koha/REST/Plugin/Query.t
CHECK => tests shoul fail
3. Apply this patch
4. prove t/Koha/REST/Plugin/Query.t
SUCCESS => tests pass
5. Sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:13:28 +0000
Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-0ztyOR2vxv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|(bug 16123 update) Display  |Display budget hierarchy in
                   |budget hierarchy in the     |the budget dropdown menu
                   |budget dropdown menu used   |used when placing a new
                   |when placing a new order    |order
         Depends on|                            |16123


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123
[Bug 16123] Display budget hierarchy in the budget dropdown menu used when
placing a new order
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 18:13:28 +0000
Subject: [Koha-bugs] [Bug 16123] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16123-70-7GfSKO3vIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866
[Bug 24866] Display budget hierarchy in the budget dropdown menu used when
placing a new order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 22:11:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2020 21:11:39 +0000
Subject: [Koha-bugs] [Bug 24869] New: When Marc Record uses brackets in the
 publication Year the value is stored in the database as null
Message-ID: <bug-24869-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24869

            Bug ID: 24869
           Summary: When Marc Record uses brackets in the publication Year
                    the value is stored in the database as null
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

For multiple reasons are < or [ used in cataloging dates that are either
unknown or with a range.

These are three examples that do not work or get stored properly in Koha and
the database.

[19--]

<1981->

[1981]

Currently, if a publication year has the hard brackets or the hungry alligators
with a year, the date does not get stored in the database as a value, but it
stored as null.  

It would be nice if Koha were to display the year regardless of the < or [ . 
If a year is presented like this [19--], Koha should use the value of the year
with 1900 in the database, and in a case such as this <1981->, it should be
1981.


The database holds these values as NULL.  When an item search in Koha is done
with a record with one of these values, the publication year will display as 0,
which is not helpful to a library when needing the publication date stored in
the Marc Record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 07:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 06:26:45 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-Gyq58pDi4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 100691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100691&action=edit
Bug 24851: UNIMARC - koha-testing-docker start up

I had another go.

Bug 24851 and Bug 24856 seem to have applied successfully, and it seems to have
picked up the changes from
https://gitlab.com/joubu/koha-misc4dev/-/tree/issue_29

I've attached the log of the koha-testing-docker start up - I've removed the
repeating error lines at 14346 and 14385, and the insertion of reocords and
authorities.

End result for me = web installer appears when you go to 127.0.0.1:8081

I'll let someone else have a go - they may be more successful in getting this
working!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 09:47:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 08:47:07 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-LXOXoHFvBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 09:47:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 08:47:11 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-2wPgBN6dZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100683|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 100692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100692&action=edit
Bug 24862: Regression tests

This patch introduces tests for the expected behaviour on API routes
that expect a logged in user, but the request is made with an anonymous
session cookie.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail because the situation is not handled correctly in
the code

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 09:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 08:47:14 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-fIRwYZHsiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100684|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 100693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100693&action=edit
Bug 24862: Handle annonymous sessions gracefuly

This patch introduces code to detect (cookie) annonymous sessions and
act as expected.

Right now, as check_cookie_auth is not passed the required permissions
(because there aren't always required permissions, and the code to check
permissions is shared with other authentication mechanisms) it returns
'ok' and the session id. This use case was overlooked when this was
coded, and yeilds unexpected error codes (500) when the user logs out
and the annonymous session cookie is used to hit the API. The end result
doesn't pose any security issue (i.e. the resource access is rejected)
but the returned error code is not correct and should be fixed.

This patch verifies for an anonymous session (and avoids querying the
corresponding patron) and then verifies if there is an authorization
config on the route and if the patron object is defined.

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail, 500 instead of the expected 401
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Repeat the original 'steps to reproduce' from the bug report using
   the browser
=> SUCCESS: Problem solved!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Sponsored-by: ByWater Solutions

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 21:09:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 20:09:41 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-zUPKQGVG9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr
             Status|Needs Signoff               |In Discussion

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Indeed, the biblio number doesn't mean much when used as a cover tooltip.

I'm keen to Sign Off on your patch and have the following points to make:

1) "Author: Didier GAutheron" <- unless you want to be credited this way
   in the Koha release notes and in the About page timeline you may want
   to redo your git config and make a small change to your surname.

2) "BUG 24740: [...]": as per the official guidelines in the Koha wiki
   (https://wiki.koha-community.org/wiki/Commit_messages#Subject_line)
   the word "Bug" should be capitalised, and not be in all uppercase,
   otherwise the QA tools will complain.

3) The QA tools will also flag the missing filters at the lines where
   you've added [% img_title %], this is due to the coding guidelines'
   requirement that _all_ template variables must be filtered:
  
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_template_variables

   You should probably remove the filters from the assignments inside
   the IF-ELSE blocks and use the "html" filter whenever the img_title
   variable is used later on in the TT code:

   [% IF ( SEARCH_RESULT.title ) %]
       [% img_title = SEARCH_RESULT.title %]
   [% ELSE %]
       [% img_title = SEARCH_RESULT.biblionumber %]
   [% END %]

   [% IF ( itemsloo.title ) %]
       [% img_title = itemsloo.title %]
   [% ELSE %]
       [% img_title = itemsloo.biblionumber %]
   [% END %]

   <span title="[% img_title | html %]" ... ></span>

4) You have used hard tabs to indent some of the code in your patch,
   the QA tools will notice this. I suggest you change them to soft
   tabs (spaces). The offending lines are:

   254 and 256 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   327 and 329 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt

5) Should we take this opportunity and fix the cover tooltip in the biblio
   details page as well? And the shelf browser, too?

   The relevant TT files are:
   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
   koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 00:59:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2020 23:59:54 +0000
Subject: [Koha-bugs] [Bug 24870] New: Translate installer data label
Message-ID: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

            Bug ID: 24870
           Summary: Translate installer data label
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

At install time the different files are grouped as 'Mandatory' or 'Optional',
or other names depending on the language of installation. 
Those labels correspond to the names of the installation directories.

Those labels must be translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 08:49:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 07:49:40 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-j1YfkwEIzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100410|0                           |1
        is obsolete|                            |

--- Comment #7 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100694&action=edit
Bug 24827: Standardise on 'UTF-8' as the encoding name

This patch standardises the encoding name used in direct calls
to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 08:49:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 07:49:43 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-dcGGWl2wdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #8 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100695&action=edit
Bug 24827: Specify UTF-8 as encoding in new_from_xml()

The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not explicitly specify 'UTF-8' as the optional encoding to use.

This patch fixes that.

Test plan (in a MARC21 instance):
0) Stage for import the test record attached to this bug report (make
   sure that 'Check for embedded item record data?' is set to 'Yes'),
   then go to Home > Tools > Manage staged MARC records and click on
   the filename you've just staged.
1) In the 'Citation' column, click on the hyperlink to launch the MARC
   preview -- notice how it fails to produce any output apart from the
   modal heading.
2) Apply the patch, and restart Plack if necessary.
3) Re-launch the MARC preview: this time the output should include the
   whole record, including the embedded item data in field 952.
4) Run the unit tests to ensure nothing was broken inadvertently:
   $ prove t
   $ prove xt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 08:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 07:58:44 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-XjSc7Hhapk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #9 from Andreas Roussos <a.roussos at dataly.gr> ---
Thanks for your feedback, Jonathan. I've split my initial patch in two,
hopefully I got this right ;-) Setting Status to "Signed Off".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:44:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:44:11 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-mhjH8C2dJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|In Discussion               |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andreas, please use "Failed QA" if you run into problems when testing - the
developers will usually check and reply. In Discussion should be used only if
there is a disagreement that cannot be resolved without getting more people
involved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:48:31 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-DGIAnZGX2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:48:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:48:34 +0000
Subject: [Koha-bugs] [Bug 24847] select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-aFVLhTSMht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100537|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100696&action=edit
Bug 24847: Select AND by default in items search

In items search form, when clicking on "New field" a new conjunction and search
field are added.
It would save time to select AND conjunction by default, like it is in advanced
search.

Test plan:
1) Go to items search
2) Click on  "New field"
3) Check that AND is selected

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:49:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:49:06 +0000
Subject: [Koha-bugs] [Bug 24847] Select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-R7QnsBYaJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|select AND by default in    |Select AND by default in
                   |items search                |items search

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fixed the commit title (Bug xxx - vs. Bug xxx:)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:52:10 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-vileA9tT7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:52:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 13:52:13 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-pU3LYOhD9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100539|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100697&action=edit
Bug 24844: Focus syspref searchbar

To test:
1) Go to Administration
2) Notice neither of the syspref search bars are focussed so you have to
click inside one to begin searching
3) Apply patch and refresh page
4) Notice the header syspref search bar is now focussed so you can begin
typing straight away

Sponsored-by: Catalyst IT

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:03:46 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-sKKaZG9MEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:03:50 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-Qr7U8VRX9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100677|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100698&action=edit
Bug 24701: Add column config to course_items_table

This patch adds course_items_table to the column config tool
TEST PLAN:
1. Have some course reserves
2. Add some items to that course reserve and browse to opac-course-details
2. See all the unconfigurable columns
3. Apply patch
4. Browse to column config > OPAC > opac-course-details
5. Try hiding each column and make sure the correct column is hidden on
opac-course-details.pl

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:08:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:08:53 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-n0ciZAREde@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Only one thing here:
+++ b/installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt

I think this should be in French!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:11:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:11:53 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-AX6yCveAze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:11:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:11:56 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-VHsNO1b3H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100484|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100699&action=edit
Bug 24402: About template corrections

With the 20.05 team we introduced and expanded some roles.  This patch
adds support for:

* removal of the release maintainer for development releases
* a list of documentation managers
* a list of packaging manager

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:14:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:14:51 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-rxF1RN5n1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:14:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:14:55 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-rUeIGMKXvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100578|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100700&action=edit
Bug 24789: Remove ITS macro format

To test:
1 - Apply patches
2 - Confirm you can save, load, and run macros
3 - Confirm you have no choice of format

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:15:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:15:16 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-aYQtf3Zi57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please update text to go into release notes for this one!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:19:28 +0000
Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if holds are
 blocked due to fines
In-Reply-To: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15775-70-CwZN90GNAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like I missed changing status here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:20:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:20:43 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-tAbgt6kped@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When Placing a Hold, cursor |When placing a hold, cursor
                   |doesn't focus on Patron     |doesn't focus on patron
                   |Name                        |name
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:23:52 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-8GlfEEU2Qi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am getting a QA test tool fail here, please check:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
   FAIL   filters
                missing_filter at line 982 (                active: [% active
%],)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:34:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:34:54 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-eCefSPbGWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:34:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:34:59 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-BcJeQDSCdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100306|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100701&action=edit
Bug 24627: Correct style of clubs search results during hold process

This patch updates some markup and CSS so that the process of selecting
a club from search results during the hold process looks the same as
when selecting a patron: Club names should be links (like patron
names are) and the table row should have a hover color to help indicate
that it is clickable.

This patch also changes the markup of the Patrons/Clubs tabs a little
bit to make the information clearer: Superfluous Bootstrap-related tab
markup has been removed, and the patron and club search results have
been moved into their respective tab containers. This means that if you
search for a patron but then switch to the clubs tab the patron list
doesn't still display.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - You should have more than one patron club defined.
 - Begin the process of placing a hold on a title.
 - Test the process of searching for both patrons and clubs.
   - In each case the name (patron or club) should be an active link.
   - Hovering your mouse over the table rows should change the row
     background to yellow.
   - Clicking the other tab at this stage should hide the search results
     from your last search.
   - Whether you click the linked name or elsewhere in the table row
     you should be correctly redirected to the next step in the holds
     process.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:36:43 +0000
Subject: [Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown
 combo with empty set
In-Reply-To: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24814-70-rQbOKA6Nuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |oleonard at myacpl.org
             Status|Signed Off                  |Failed QA
            Summary|HTML forms set a minimal    |HTML forms set a minimal
                   |width for dropdown combo    |width for dropdown combo
                   |with empty set.             |with empty set

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving to FQA for now, waiting for feedback from dev.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:55:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:55:42 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-SLZUebvXng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:55:48 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-mXUH9Xv581@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100323|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100702&action=edit
Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth

Bug 14407 introduced a new system preference to allow limiting the
online self checkout system to an IP or IP Range. The function that
handles this is called in_ipset, which is the name of a linux tool. To
stop confusion, this patch renames the function to 'in_iprange', and the
variable 'ipset' within it to 'iprange'.

To test, follow the test plans outlined in Bug 14407 and confirm that
everything works as expected.

Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:55:52 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-EVg0ryI6qQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100324|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100703&action=edit
Bug 22943: (QA follow-up) Add new cases

A few additional cases were introduced since the original bug was
authored. This patch simply catches those cases and makes the same
change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:55:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:55:56 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-gGgCYAq6ll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100704&action=edit
Bug 22943: Remove unused line from Auth.t

Removes an unnecessary variable declaration from Auth.t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:56:05 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-Gye7T1yngK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:56:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:56:49 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-Trx3HQ1lHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:57:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:57:29 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-e43t6J6Wiv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #98774|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:57:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 14:57:45 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-wjBzddaYYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr
                   |ity.org                     |o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 16:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 15:03:31 +0000
Subject: [Koha-bugs] [Bug 24853] Add a tab in System Preferences for
 Accounting
In-Reply-To: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24853-70-0RXiyc9wtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kelly, not sure when it was added, but I see this tab "Accounting" in
master. Can you check if you are missing any prefs there on a sandbox maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 16:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 15:03:50 +0000
Subject: [Koha-bugs] [Bug 24853] Add a tab in system preferences for
 accounting
In-Reply-To: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24853-70-cQgCHN4QVQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a tab in System         |Add a tab in system
                   |Preferences for Accounting  |preferences for accounting
            Version|19.05                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 16:06:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 15:06:32 +0000
Subject: [Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
In-Reply-To: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23914-70-Y37cN9KuwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we restart this? With all the problems we see with MySQL versions having
better data on what people use would be good (which was your initial goal, I
know!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:08:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:08:55 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-MSN9924X5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

--- Comment #4 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Katrin Fischer from comment #3)
> Hi Andreas, please use "Failed QA" if you run into problems when testing -
> the developers will usually check and reply. In Discussion should be used
> only if there is a disagreement that cannot be resolved without getting more
> people involved.
Hi Katrin, thanks for the clarification! I've taken the opportunity to include
the gist of your comment in the relevant page on the Wiki:
https://wiki.koha-community.org/wiki/Development_workflow#Failure_cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:15:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:15:06 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-rNYTnjwSs7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> Hi Katrin, thanks for the clarification! I've taken the opportunity to
> include
> the gist of your comment in the relevant page on the Wiki:
> https://wiki.koha-community.org/wiki/Development_workflow#Failure_cases

Great, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:16:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:16:04 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
 Shelving Location,
 then deleting the same course reverts Course Reserve Values
In-Reply-To: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24772-70-ghvkml9je7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23727

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:16:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:16:04 +0000
Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken
In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23727-70-meAYMFdQku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24772

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:17:34 +0000
Subject: [Koha-bugs] [Bug 24563] Internal Server error when clicking Tools
In-Reply-To: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24563-70-cgro8LCmjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24563

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Govind, this is likely to be aproblem with the installation and/or plugin.
Please bring this up on the mailing list if you still experience problems. We
will need more information to confirm if this is a bug or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:19:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:19:52 +0000
Subject: [Koha-bugs] [Bug 24779] Shibboleth login url double encodes "=" in
 query
In-Reply-To: <bug-24779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24779-70-jyoNQiTduo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:23:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:23:06 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-SX1rRcdz5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving back to signed off for now to help get more eyes on this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:24:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:24:30 +0000
Subject: [Koha-bugs] [Bug 24785] Search result column localization
In-Reply-To: <bug-24785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24785-70-tYJmCCJQ4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, sorry, I don't understand the bug from the description. Can you maybe add a
step by step or attach a screenshot pointing out the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:29:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:29:04 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-Q4ZtV3AGYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:33:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:33:13 +0000
Subject: [Koha-bugs] [Bug 24579] Add the ability to email the Cart contents
 without Logging into Account
In-Reply-To: <bug-24579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24579-70-Oq4Su6N8vj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24579

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kelly, 

this has been made impossible to avoid using Koha to send spam to arbitrary
email addresses. There is an older bug discussing this too - marking it
duplicate.

*** This bug has been marked as a duplicate of bug 4274 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:33:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:33:13 +0000
Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without
 requiring login
In-Reply-To: <bug-4274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4274-70-ouSqcyRxSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 24579 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:36:48 +0000
Subject: [Koha-bugs] [Bug 24581] DBIx::Class::Storage::DBI::_dbh_execute():
 Unknown column 'me.privacy_guarantor_fines' in 'field list' at
 /usr/share/koha/lib/Koha/Objects.pm line 92
In-Reply-To: <bug-24581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24581-70-kFHiZ56bbs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com,
                   |                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
          Component|bugs.koha-community.org     |Installation and upgrade
                   |                            |(web-based installer)

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As the reporter hasn't come back to this in over a month, I am marking RESOLVED
INVALID and encourage to continue discussion on the mailing list if the problem
still exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:40:14 +0000
Subject: [Koha-bugs] [Bug 24597] Add ability to add note on all payment
 screens
In-Reply-To: <bug-24597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24597-70-cODLeFmVB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lucas, I think this might be a duplicate of the old bug 8776 - which we
should probably update a bit. What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:42:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:42:14 +0000
Subject: [Koha-bugs] [Bug 24598] Hold not reset properly if checked out to
 another patron
In-Reply-To: <bug-24598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24598-70-qbIzBlYH40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This reads a bit similar to bug 11722, could these be duplicates?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:43:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:43:34 +0000
Subject: [Koha-bugs] [Bug 24550] Books renewals triggers item loan policies
 to revert to branch renewing item
In-Reply-To: <bug-24550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24550-70-zLAgd7S3oS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What are your settings for the prefs Lisette listed?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:48:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:48:38 +0000
Subject: [Koha-bugs] [Bug 20839] Edit as new (duplicate) doesn't work with
 advanced editor
In-Reply-To: <bug-20839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20839-70-J4iOdGwk5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20839

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I just tested this on master and it appears to have been fixed. Instead of
'save' I only have duplicate and the changes only appeared on the new record,
not the original. 

I am not sure what or when this was fixed, but it looks ok now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:50:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:50:02 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-GezIaZiilv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about comment 10, Katrin?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:50:43 +0000
Subject: [Koha-bugs] [Bug 24671] Unable to set a holiday as repeating going
 forward only
In-Reply-To: <bug-24671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24671-70-elr8IzKQ8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24671

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kelly, I am marking this as a duplicate of bug 22178 which is a bit older.
Hope you agree!

*** This bug has been marked as a duplicate of bug 22178 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:50:43 +0000
Subject: [Koha-bugs] [Bug 22178] Add start and end date for repeated holidays
In-Reply-To: <bug-22178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22178-70-PcL0XMoOqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22178

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 24671 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:54:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:54:20 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-Vra49HTdX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #12)
> What about comment 10, Katrin?

I think it feels like a separate issue to me - the order is not changed in this
bug, if I see it correctly. I think having the maints on top makes sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:55:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:55:44 +0000
Subject: [Koha-bugs] [Bug 21215] Saved SQL reports code improvements
 [Omnibus]
In-Reply-To: <bug-21215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21215-70-GRxa5f0Psr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24695
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|rel_18_11_candidate         |
            Summary|Saved SQL reports code      |Saved SQL reports code
                   |improvements                |improvements [Omnibus]

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to paxed from comment #12)
> Splitting this up into multiple parts. One is bug 24695

Splitting is a good idea - always a bit scared of 'enhancements to...' bugs :)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695
[Bug 24695] Improve SQL report validation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:55:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:55:44 +0000
Subject: [Koha-bugs] [Bug 24695] Improve SQL report validation
In-Reply-To: <bug-24695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24695-70-ZYxEE8ImWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21215


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215
[Bug 21215] Saved SQL reports code improvements [Omnibus]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:58:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 16:58:19 +0000
Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date
 by printing new hold slip
In-Reply-To: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21652-70-6AViPq8wWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:03:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:03:41 +0000
Subject: [Koha-bugs] [Bug 24742] Can't save news item in strict mode without
 value in number field
In-Reply-To: <bug-24742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24742-70-buLFjFvPQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17258
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:03:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:03:41 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-1achwtaqEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24742
[Bug 24742] Can't save news item in strict mode without value in number field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:05:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:05:41 +0000
Subject: [Koha-bugs] [Bug 24743] Selecting items to delete from the
 detail.pl page - when deleted provides a message in Error
In-Reply-To: <bug-24743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24743-70-RhdihmhLPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this was fixed by bug 24423.

*** This bug has been marked as a duplicate of bug 24423 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:05:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:05:41 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification or deletion
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-KwFzrHbWqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 24743 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:09:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:09:41 +0000
Subject: [Koha-bugs] [Bug 5695] Cart display should show proper item type
In-Reply-To: <bug-5695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5695-70-X4k7hlD0lF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #2)
> Created attachment 96822 [details]
> Screenshot of an idea
> 
> Is this something people would want?

Hi Owen, I quite like it and it would solve some reappearing requests of adding
more information there. Maybe it should be configurable? In consortia there
might be too many items on records to make this work nicely, but for smaller
libraries it would probably work well. Or we could show x items by default with
a link to show all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:26:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:26:19 +0000
Subject: [Koha-bugs] [Bug 24499] sys pref EnhancedMessagingPreferences if
 set to Don't Allow does not even show within Patron Categories
In-Reply-To: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24499-70-eKI2PPIMZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it actually works right now as the feature was intended - it started
out as a completely optional feature that was off by default. So all traces of
the feature are hidden, when the feature is off. Then we decided to make it on
by default - because everybody started using it.

So maybe it's actually the pref description that is misleading?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:30:04 +0000
Subject: [Koha-bugs] [Bug 7000] show home and holding branch on staff search
 results
In-Reply-To: <bug-7000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7000-70-dJb2IQtcoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7000

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:34:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:34:00 +0000
Subject: [Koha-bugs] [Bug 7000] show home and holding branch on staff search
 results
In-Reply-To: <bug-7000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7000-70-qQoWla7p2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7000

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this is a duplicate to another bug from Kelly I saw - but now I just
seem to be able to find it. Adding her to check.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:36:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:36:25 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-eOhyaQD2nZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Ed Veal from comment #4)
> I am ok with this bug being closed. I think it is an old issue that has
> evolved since my original submission is not a big deal. 
> 
> Ed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:46:23 +0000
Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include
 collection code
In-Reply-To: <bug-23706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23706-70-UleTsuGJzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:55:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:55:58 +0000
Subject: [Koha-bugs] [Bug 22798] Double quote included in Publisher search
 on tag 264
In-Reply-To: <bug-22798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22798-70-eqeVfqdv4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this was fixed by bug 24654

*** This bug has been marked as a duplicate of bug 24654 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:55:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:55:58 +0000
Subject: [Koha-bugs] [Bug 24654] Trailing double-quote in RDA 264 subfield b
 on OPAC XSLT
In-Reply-To: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24654-70-leegI2gT09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24654

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbutosi at gmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 22798 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:59:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 17:59:43 +0000
Subject: [Koha-bugs] [Bug 22968] Adding a column for collection editor name
 in search results
In-Reply-To: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22968-70-mOkmOXCIFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Alexandre, I believe this is for UNIMARC?
Could you add an example record or field and which search you want to be
changed? I am a little confused on where you want the info to appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:01:49 +0000
Subject: [Koha-bugs] [Bug 23306] fines amount showing zero
In-Reply-To: <bug-23306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23306-70-DSTYEMFA6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23306

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:01:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:01:54 +0000
Subject: [Koha-bugs] [Bug 23306] fines amount showing zero
In-Reply-To: <bug-23306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23306-70-QnAeB1Uoru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23306

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:03:50 +0000
Subject: [Koha-bugs] [Bug 24575] Search for locations and collections broken
 when using ICU
In-Reply-To: <bug-24575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24575-70-wWtJMD0rFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24575

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 23086 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:03:50 +0000
Subject: [Koha-bugs] [Bug 23086] Search for collection is broken
In-Reply-To: <bug-23086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23086-70-iCSaRgXVel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 24575 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:12:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:12:54 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-aK6t4YnMEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #51 from David Nind <david at davidnind.com> ---
Patch no longer applies:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8132: No changes but disable checkboxes
error: sha1 information is lacking or useless (tools/batchMod.pl).
error: could not build fake ancestor
Patch failed at 0001 Bug 8132: No changes but disable checkboxes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:59:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 18:59:38 +0000
Subject: [Koha-bugs] [Bug 23887] Add support for client-specified sort order
 in Z3950Responder
In-Reply-To: <bug-23887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23887-70-H2R0F0dQmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23887

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #6 from David Nind <david at davidnind.com> ---
Hi Ere.

Could you provide some more information on how to get the z3950responder.pl
working and I'd be happy to test?

I've looked at
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server but I
get an error when going koha-z3950-responder --enable kohadev (using
koha-testing-docker):

  cp: cannot stat '/etc/koha/z3950/*': No such file or directory

David Nind

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 20:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 19:19:24 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-WrtxlWmodX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 20:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 19:19:27 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-o0ccPrRDVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97095|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 100705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100705&action=edit
Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc

This patch makes the opac/svc/report script use output_with_http_headers
so it sets the Access-Control-Allow-Origin header.

To test:
1. Create a new public report and remember the report id
2. Use your favourite too to fetch the report in JSON by issuing:
   GET http://localhost:8080/cgi-bin/koha/svc/report?id=1
=> FAIL: There is no Access-Control-Allow-Origin header
3. Apply this patch
4. Restart Plack
   $ sudo koha-plack --restart kohadev
5. Set the AccessControlAllowOrigin to anything (for example,
   https://koha-community.org)
6. Repeat 2
=> SUCCESS: On the response headers you find
Access-Control-Allow-Origin: https://koha-community.org
7. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 21:52:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 20:52:52 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
 on opac-detail.tt
In-Reply-To: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24473-70-OlzJukuIL2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Wonder if there is any technical documentation on the Syndectics API we could
check - maybe there is a way to receive data without HTML? Or there are hints
on what can be included.

Not sure we should block this tho - You pay for Syndetics services, so it seems
reasonable to assume the data will be ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:07:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:07:49 +0000
Subject: [Koha-bugs] [Bug 24871] New: Add new *-installer-*.po translation
 files
Message-ID: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

            Bug ID: 24871
           Summary: Add new *-installer-*.po translation files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

After Bug 24262 we need new translation files,

*-installer-MARC21.po for MARC21 installer files (Bug 24593 and Bug 24584)
*-installer.po for common files (Bug 24583 and Bug 24584)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:44:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:44:38 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-tlGQQvd9YX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:44:43 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-5jQ9haGUmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100706&action=edit
Bug 3137: HideFieldsPatronAddForm syspref

This patches adds a syspref - HideFieldsAddPatronFrom - that controls
which fieldsets are hidden by default in the add patron form.

To test:
1) Apply patch and update database
2) Go to System preferences and confirm HideFieldsPatronAddForm has no
fields selected
3) Go to add a patron / edit an existing patron (any patron category).
confirm everything still works as expected.
4) Tick some of the fields in the syspref to hide them in the form
5) Go back to add patron form.
6) Confirm these fields are hidden and listed at the top of the page
7) Toggle the checkbox and confirm the hidden fields show or hide as
expected.
8) Go back to the HideFieldsPatronAddForm system preference and ensure
the Main address option is checked to be hidden
9) Go to the patron's details page
10) Click to edit the Contact Information section
11) Confirm the Main address option shows and the checkbox to show
hidden fields is not present.
12) Confirm you can click the legend of each section to show and hide
sections

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:44:48 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-5PvADKqbt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100599|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100707&action=edit
Bug 3137: (follow-up) Rename using 'collapse', remove syspref lettering and fix
guarantor section collapsing

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:44:52 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-z3Mhav9YIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100708&action=edit
Bug 3137: (QA follow-up) Switch hidden for collapsed in text

Changes the text and tooltip on top of the add/edit patron screen
to use collapsed instead of hidden.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:45:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:45:45 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-WrfNcS62aN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Aleisha! Added a small follow-up, hope you agree.

First and second patch could be squashed by RM, as both have same
author/sign-offer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:53:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 21:53:09 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-T5KttViWpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Appears to work well and passes QA tools.

I got a suggestion for the file naming: suggestor_search

Would this work?

I agree with Frido that suggestion_search is misleading and makes it sounds
like a search for suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:00:25 +0000
Subject: [Koha-bugs] [Bug 24717] Koha should set a referrer policy
In-Reply-To: <bug-24717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24717-70-KLmjaevVG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24717

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is one feature I know in Koha that relies on the referrer:
RestrictedPage*
We use this page to add links to databases and other paid services that allow
for authentication by referrer. If we change the default in Koha, it would be
good if we could make an exception for links on that page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:02:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:02:38 +0000
Subject: [Koha-bugs] [Bug 24626] error en RunSQL.pm line 273.
In-Reply-To: <bug-24626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24626-70-4k7obfS8qZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24626

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, it could be related to dbms or OS version. You might want to post on the
mailing list as well to see if people have seen similar.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:02:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:02:45 +0000
Subject: [Koha-bugs] [Bug 24626] error en RunSQL.pm line 273.
In-Reply-To: <bug-24626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24626-70-d3ppbKty6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24626

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:06:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:06:25 +0000
Subject: [Koha-bugs] [Bug 24728] Short Last Name Search Issue
In-Reply-To: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24728-70-UUrLLCdB9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24728

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher,
I just tested this on master with a user 'lo' and it worked on the patron and
circulation searches for me.

Maybe the behaviour seen is that the auto-suggest feature requires more
characters? If you 'enter' the search lo, the search works as expected for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:08:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:08:55 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-39ohig6HZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100709&action=edit
Bug 24871: xz compressed patch

Bug 24871: Add new *-installer*.po translation files

This patch simply adds new po files for each supported
language.

The are not created on update, so the need to add this files.

To test:
1) Update your preferred language
2) Check missing *installer*po files
3) Create new translation files:
   cd /misc/translation
   ./translate create xx-YY

   check *installer*po files
4) Apply patch
5) Repeat 1, verify installer files are updated
   see last modification time

Pre-filled translations for some languages
(https://translate.koha-community.org/projects/marc21/)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:11:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:11:07 +0000
Subject: [Koha-bugs] [Bug 24684] Adding text "Address: 1" as circulation
 note makes field disappear - moremember.pl
In-Reply-To: <bug-24684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24684-70-yIpoK1Glc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24684

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Bernard,

I just tested this on master and our 18.11.13 test installation and cannot
replicate:

- Edited an existing patron
- Added "Address: 1" to the circulation note field
- Saved
- Note is shown on the checkouts and details tabs
- Editing the patron and the note works as expected

Could there be some custom JavaScript be at play in your installation?

Please reopen if I am wrong and the problem still persists for you.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:13:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:13:04 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-lMVc6vOFYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100710&action=edit
Bug 24870: Translate installer data label

This patch enable the translation of the
labels 'Mandatory' or 'Optional' present at install time
for groups of installer files.

To test:
1) Try install using de-DE language,
   at step3 verify 'Mandatory' and 'Optional'
   labels
2) Apply this patch
3)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:15:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:15:32 +0000
Subject: [Koha-bugs] [Bug 24730] Allow patrons to cancel waiting holds in
 OPAC
In-Reply-To: <bug-24730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24730-70-nD7TgGsC8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24730

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Enhancing hold              |Allow patrons to cancel
                   |cancellations               |waiting holds in OPAC
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it was deactivated for this reason: there was no way to tell which
items to pull from the pickup shelf as staff will not be notified. I like both
ideas of a new status and an email. I think email only would not work so well,
we should have something on the dashboard too.

Behaviour should also be optional.

That said... this is a duplicate of bug 22456. It's common to let the 'older'
bug survive.

*** This bug has been marked as a duplicate of bug 22456 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:15:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:15:32 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-SJH6FwpOS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 24730 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:27:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:27:24 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-5mtoo1eIgf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100710|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100711&action=edit
Bug 24870: Translate installer data label

This patch enable the translation of the
labels 'Mandatory' or 'Optional' present at install time
for groups of installer files.

To test:
1) Try install using de-DE language,
   at step3 verify 'Mandatory' and 'Optional'
   labels for marc21 or other data checklist
   Do not close this window!
2) Apply this patch
3) Update de-DE translation files, reinstall lang files
   cd misc/translator
   ./translate update de-DE
   ./translate install de-DE
4) Reload page at step3, now 'Mandatory' label
is translated to 'Pflichtfeld'
5) Verify strings in translation file
Search for
^msgid \"Mandatory\"
^msgid \"Optional\"
in po/de-DE-staff-prog.po.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:28:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:28:38 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-uo1rx6EXoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:45:43 +0000
Subject: [Koha-bugs] [Bug 24872] New: Set languages system preferences after
 web install
Message-ID: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

            Bug ID: 24872
           Summary: Set languages system preferences after web install
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

After doing a web install, in a language other than English, it is necessary to
explicitly activate the 'language' and 'opaclanguages' system preferences using
the intranet in English!

We could set those preferences using the install language.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:52:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 22:52:32 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-u80zyAk3y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Item field 3 (Materials     |Item field 'Materials
                   |specified) would be useful  |specified' would be useful
                   |to see on OPAC              |to see in OPAC

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This patch works as expected, but there is a little catch: For libraries, that
have used this field to add information that is patron privacy relevant (like
the name of someone), this change might be problematic. I have seen this
happening, as the field will show up on checkout/checkin in a prominent way.
(When returned, hand over to X next or something like that).

Even when the materials column is hidden, it's still fully visible in the
source code.

Would it be possible not to pass it to the template if the column configuration
is set to not display it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:07:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:07:42 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-hhJXG7CNOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Myka, 

I think there might be some possible misunderstanding there:

>The expected/desired behavior is for Koha to start the prediction pattern based on the subscription start date, listing the number of issues based on the subscription length value. Koha will need to calculate the issue number based on the numbering pattern and the first issue publication date. 

>What is presently happening is the prediction pattern is based on the first date of publication and length of subscription. This is a problem for libraries that start a new subscription in the middle of a publication, need to predict issues from the starting point of their subscription, and want to preserve the first date of publication in Koha.

In Koha, it was always documented: "In ‘First issue publication date’ you want
to enter the date of the issue you have in your hand, the date from which the
prediction pattern will start". See:
https://koha-community.org/manual/19.11/en/html/serials.html?highlight=first%20publication

So I wonder how changing that would affect libraries already using
subscriptions for a long time. At the moment, it could look something like this
for a lot of libraries:

Subscription start date: January 1st
First issue publication: March 15th (the first issue that was tracked when
starting to use the serials module)

It's possible to start in the middle of a prediction pattern - if you give me
an example that you are not sure about, I'd be happy to help and see if we can
make it work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:08:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:08:48 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-lPwkVib2jZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:10:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:10:42 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-Qls0ML8L1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Last blog entries are from 7 years ago - can't see an official statement, but
it looks very dead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:20:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:20:34 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-USRSUOYEQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100712&action=edit
Bug 24872: Set languages prefererences after install

This patch set 'languages' and 'opaclanguages' system
preferences with the language used during install.

To test:
1. Apply the patch
2. Do a clean install in a language other than english
3. Verify that 'languages' and 'opaclanguages' system
preferences show the language code used during install,
besides english.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:21:40 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-CvQgQZUqc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:26:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:26:42 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-50FWVZsA9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:26:45 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-7pooV6HsyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100713&action=edit
Bug 24854: Remove IDreamBooks integration

The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.

To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
  as expected
- Run t/db_dependent/UsageStats.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:54:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:54:19 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-TDofTJFX5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:54:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:54:22 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-MpV6A0eU1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100714&action=edit
Bug 24848: Improve manual links for the label creator

Some of the manual links in the label creator tool were
not working correctly or pointing to the wrong pages.

A problem is the label-manage.pl file. This can show
different data depending on an added parameter. Example:
/cgi-bin/koha/labels/label-manage.pl?label_element=template

But it appears that parameters will be ignored when creating
links to the manual. So this patch links to the beginning
of the label creator section in the manual for now.

To test:
- Go to the lable creator
- Try the various pages of the tool
  - Note: All 'New ...' links should point to the
    correct section in the manual (batches, templates, ...)
    Except: Barcode range. This feature is new and not
    yet documented in the manual. Link goes to label creator section.
  - Note: All 'Manage ...' links should point to the
    beginning of the 'label creator' section in the manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:54:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:54:58 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-RqtLxEfNZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The solution is not perfect - label-manage.pl is a problem still (see patch
description).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:55:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:55:38 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-eVJKoFscLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrew at bywatersolutions.com |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry Andrew for stealing this one - noticed too late. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:58:21 +0000
Subject: [Koha-bugs] [Bug 24873] New: Linking between files and manual pages
 should support URL parameters (label-manage.pl)
Message-ID: <bug-24873-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24873

            Bug ID: 24873
           Summary: Linking between files and manual pages should support
                    URL parameters (label-manage.pl)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24848

When linking to different sections of the manual, you currently can only map
the name of a file to the corresponding section in the manual.

In the label creator, this proves to be a problem:
/cgi-bin/koha/labels/label-manage.pl?label_element=template

This should link to the templates section, while

/cgi-bin/koha/labels/label-manage.pl?label_element=batch

should link to the batches.

It would be nice, if the mapping also supported URL parameters.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848
[Bug 24848] Help link from label creator batch/layout/template points to card
creator in manual
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2020 23:58:21 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-I6mUrPxr78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24873


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24873
[Bug 24873] Linking between files and manual pages should support URL
parameters (label-manage.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:00:12 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-yWG5hvwhhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:10:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:10:32 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-uFaHkiI6G9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.03,         |20.05.00, 19.11.03,
        released in|19.05.08                    |19.05.08, 18.11.15
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:13:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:13:15 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-wb0bjFzDyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:13:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:13:21 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-UsVg0yy3Sm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100715&action=edit
Bug 24837: Rename selectbranchprinter.pl to set-library.pl

This renames the selectbranchprinter.pl file to the more
fitting set-library.pl.

To test:
- Change the library with "Set library" from
  - The menu in the top navigation bar
  - The circulation start page
- Verify the help link on page leads to the correct
  section in the manual
- Read the code... and verify all occurences have been caught

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:17:29 +0000
Subject: [Koha-bugs] [Bug 24378] Change wording on AUTO_RENEWALS notice in
 updatedatabase
In-Reply-To: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24378-70-7wOntcFbnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we should not run an updatedatabase here as suggested as the notice
could have been translated or removed on purpose (the library not wanting to
send it). 

We could do a replace on the string if the notice exists instead?

There are some examples for this in the updatedatabase.pl file:

UPDATE saved_sql SET savedsql = REPLACE(savedsql, 'wthdrawn', 'withdrawn');

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:48:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:48:40 +0000
Subject: [Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch
 mappings
In-Reply-To: <bug-24678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24678-70-opG8AUTkzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tried to provide a patch for 264, but ran into a mismatch between Zebra
and Elasticsearch:

  pl:
    label: pl
    mappings:
      - facet: ''
        marc_field: '008_/15-17'
        marc_type: marc21
        sort: ~
        suggestible: ''
      - facet: ''
        marc_field: '008_/15-17'
        marc_type: normarc
        sort: ~
        suggestible: ''

The Zebra files are also confusing:

  <index_control_field tag="008" offset="15" length="3">
    <target_index>pl:w</target_index>
  </index_control_field>

  <!-- RDA 264$a      pl:w,pl:p-->
  <index_subfields tag="264" subfields="a">
    <target_index>pl:w</target_index>
    <target_index>pl:p</target_index>
  </index_subfields>

  <!--Index for RDA 264 field-->
  <index_data_field tag="264">
    <target_index>pl:w</target_index>
    <target_index>Provider:w</target_index>
  </index_data_field>

  <!--record.abs line 119: melm 260$a      pl:w,pl:p-->
  <index_subfields tag="260" subfields="a">
    <target_index>pl:w</target_index>
    <target_index>pl:p</target_index>
  </index_subfields>

  <index_data_field tag="260">
    <target_index>pl:w</target_index>
    <target_index>Provider:w</target_index>
  </index_data_field>

At the moment it's kind of a mix up between place of publication (26x$a) and
date of publication (008 pos.15... and 26x$c).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 00:56:10 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-8Fckm917lq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

--- Comment #9 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
This patch in the 18.11 build has caused two tests to fail:

_db_dependent_selenium_regressions_t.Display circulation table correctly (476)
t_db_dependent_Circulation_t.AddReturn + suspension_chargeperiod (500)

Is anyone able to fix these tests for 18.11? Alternatively I can revert the
patches for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:46:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:46:26 +0000
Subject: [Koha-bugs] [Bug 24874] New: Printing is broken on opac-results.pl
 page (19.11.x)
Message-ID: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

            Bug ID: 24874
           Summary: Printing is broken on opac-results.pl page (19.11.x)
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

The printing is broken on opac-results.pl page

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:46:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:46:44 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-FLMnUc1S7I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:46:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:46:58 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-GwuTzYrt8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:52:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:52:56 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-G9omz7jCP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100716&action=edit
pic1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:54:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:54:03 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-yDO1uyzOg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
When I follow the test plan backporting for 18.11.x, I get to step 3 (without
having applied the patch) and the claim does not go through and I get a warning
'This vendor has no email'.

If I've missed something let me know, otherwise not backporting this one to
18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:54:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:54:09 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-EET3jBind8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100716|pic1                        |pic2
        description|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:54:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:54:20 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-oH5SBZ1DDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100717&action=edit
pic1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:56:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:56:58 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-3f9a0GSlqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:57:00 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-SR4JoLeFQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100718&action=edit
The printing is broken on opac-results.pl page

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:57:39 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-nu6MBs81dh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:57:39 +0000
Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in
 OPAC
In-Reply-To: <bug-5287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5287-70-R4DiczA8Pe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24874

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 03:58:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 02:58:50 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-B6gYINCtln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100718|0                           |1
        is obsolete|                            |

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100719&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:45:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:45:26 +0000
Subject: [Koha-bugs] [Bug 24875] New: Remvoe extra punctuation from tools
 home page
Message-ID: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

            Bug ID: 24875
           Summary: Remvoe extra punctuation from tools home page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:51:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:51:05 +0000
Subject: [Koha-bugs] [Bug 24875] Remvoe extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-dfjI0b7RHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:51:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:51:08 +0000
Subject: [Koha-bugs] [Bug 24875] Remvoe extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-RCsNzaXDQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100720&action=edit
Bug 24875: Remove extra punctuation from tools start page

The patron clubs note was ending with .., but patch also removed
some single . to be consistent with the majority of entries on the
tools page.

To test:
- Check the tools start page for ending . in the notes
- Apply patch
- Verify the punctuation is now consistent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:51:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:51:21 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-c9EaFpownm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remvoe extra punctuation    |Remove extra punctuation
                   |from tools home page        |from tools home page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:52:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:52:30 +0000
Subject: [Koha-bugs] [Bug 24876] New: Fix capitalization on patron search
 for holds (Search Patrons...)
Message-ID: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

            Bug ID: 24876
           Summary: Fix capitalization on patron search for holds (Search
                    Patrons...)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:52:36 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds (Search Patrons...)
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-xzYMJTP2nQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:57:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:57:57 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds (Search Patrons...)
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-q6Jwuf6PjE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:58:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:58:01 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds (Search Patrons...)
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-6cWnR9NZ4Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100721&action=edit
Bug 24876: Fix capitalization on patron search for holds

When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons...  instead.
Also changes club id to club ID.

To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:58:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 06:58:23 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-UHppje5j2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix capitalization on       |Fix capitalization on
                   |patron search for holds     |patron search for holds
                   |(Search Patrons...)         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:00:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:00:21 +0000
Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause
 biblios to lose authority information
In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22437-70-hhtNU0IxxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:02:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:02:29 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-72wFfTAtgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I loved the initial typo 😅

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:07:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:07:53 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-Tc73fCGkrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100721|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100722&action=edit
Bug 24876: Fix capitalization on patron search for holds

When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons...  instead.
Also changes club id to club ID.

To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:09:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:09:45 +0000
Subject: [Koha-bugs] [Bug 24877] New: Add link from vendor to linked
 subscriptions
Message-ID: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

            Bug ID: 24877
           Summary: Add link from vendor to linked subscriptions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

We show the number of subscriptions linked to a vendor on the vendor details
page, but there is no way to see the subscriptions. We should have a link to
search for them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:13:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:13:57 +0000
Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause
 biblios to lose authority information
In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22437-70-0ZEE5S8kOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Good catch, Pedro. I will be looking into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:14:49 +0000
Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause
 biblios to lose authority information
In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22437-70-rQ8njGASeD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Severity|minor                       |normal
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |pjamorim91 at gmail.com
                   |ity.org                     |
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:15:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:15:16 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-jjeWnh6Rmn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:15:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:15:19 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-yYnlAytJDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100723&action=edit
Bug 24877: Add link from vendor to linked subscriptions

Koha shows the number of subscriptions linked to a vendor,
but there is no way to look them up. This adds a link to the
subscription search with the vendor name, so there is an easy way
to find the subscriptions.

To test:
- Be superlibrarian or have serials permission
- Make sure you have one or more subscriptions linked to vendors
- Go to the vendor's detail page in acquisitions
- Verify the number of subscriptions is now a link
- Verify the search results are correct when clicking on it
- Remove permissions (no serials, not superlibrarian)
- Verify now the number shows, but is not linked

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 07:15:59 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-bs9NrRhC0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It would be better to link by ID, but we have no search option by vendor ID in
serials right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 09:51:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 08:51:45 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-80qHP6utYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|david.roberts at ptfs-europe.c |jonathan.druart at bugs.koha-c
                   |om                          |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Will try to work on that today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:12:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 09:12:58 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
 sources prior to request creation
In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23173-70-gudUWy4M0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99083|0                           |1
        is obsolete|                            |

--- Comment #34 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100724&action=edit
Bug 23173: (follow-up) Allow for customisable display name

We now allow for the service to return a name that can be specified in
the plugin config. This patch switches to using that, rather than just
the plugin name defined in the plugin's metadata hashref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:15:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 09:15:42 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
 sources prior to request creation
In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23173-70-Zlj81DNm0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100724|0                           |1
        is obsolete|                            |

--- Comment #35 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100725&action=edit
Bug 23173: (follow-up) Allow for customisable display name

We now allow for the service to return a name that can be specified in
the plugin config. This patch switches to using that, rather than just
the plugin name defined in the plugin's metadata hashref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:35:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 09:35:25 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-GT3AKWOA48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks like InLibro have a plugin to do some of this.. I've not investigated it
fully yet, but it's on my list:
https://inlibro.com/en/koha-plugins/#changeduedate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 09:58:14 +0000
Subject: [Koha-bugs] [Bug 24846] It would be helpful to have a bulk edit of
 due dates tool
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-Y87syCUvGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Sponsored                   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:20:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:20:39 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-8fxRz21Hnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |During the initial Rancor
      release notes|                            |(advanced cataloging
                   |                            |editor) development an
                   |                            |existing macro language was
                   |                            |copied. As development
                   |                            |continued a Rancor macro
                   |                            |language was developed. The
                   |                            |new language accomplished
                   |                            |all needs of the prior
                   |                            |language. The old macro
                   |                            |language was intended to be
                   |                            |removed before submission
                   |                            |to community, but was
                   |                            |missed. These patches
                   |                            |remove the legacy support
                   |                            |in favour of the Koha
                   |                            |specific model.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:21:26 +0000
Subject: [Koha-bugs] [Bug 22968] Adding a column for collection editor name
 in search results
In-Reply-To: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22968-70-phpGRoCwiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

--- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100726&action=edit
authorities results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:21:40 +0000
Subject: [Koha-bugs] [Bug 22968] Adding a column for collection editor name
 in search results
In-Reply-To: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22968-70-8COqxWKGTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

--- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Katrin Fischer from comment #1)
> Hi Alexandre, I believe this is for UNIMARC?
> Could you add an example record or field and which search you want to be
> changed? I am a little confused on where you want the info to appear.

Hi Katrin,
Alexandre no longer works for our company now.
The display concerns Marc21.
In a search result in the Authorities module (and also when cataloguing) if two
authorities of the Uniform Title type have the same title, they cannot be
easily distinguished without consulting field 643.
I attach 3 screenshots.
If we could have in the search result a configurable column like
AdditionalFieldsInZ3950ResultSearch, this would be perfect for adding
additional information.
Do not hesitate to contact me if you need more information

Regards
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:22:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:22:07 +0000
Subject: [Koha-bugs] [Bug 22968] Adding a column for collection editor name
 in search results
In-Reply-To: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22968-70-zJvdcMJknR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

--- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100727&action=edit
643field

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:22:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:22:33 +0000
Subject: [Koha-bugs] [Bug 22968] Adding a column for collection editor name
 in search results
In-Reply-To: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22968-70-KxSx2DTPg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22968

--- Comment #5 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100728&action=edit
643field_2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:50:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:50:58 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-o06eAKoibM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
I think the issue here has been for bringing in subscriptions from another
system, so you are setting the first issue to the first one held, but then
adding the start date and wanting to see the issues from that date forward?

Either way, maybe a better solution is to preserve existing behaviour and add
an option (radio button) to select generating from the sub start date instead
of first issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:53:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 10:53:38 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-BwDVxzjUPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|It would be helpful to have |Add a tool to bulk edit due
                   |a bulk edit of due dates    |dates
                   |tool                        |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:02:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:02:56 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-rVpcGJ0tdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:02:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:02:58 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-6fuTYK9Ucq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:00 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-zLbHIJjXR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:03 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-TzeJ0bNVap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:05 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-6SZepF9IqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:07 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-AoOpzvAnja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:08 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-4PN6FzRtBu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:10 +0000
Subject: [Koha-bugs] [Bug 23383] IdRef link appears even with syspref is off
In-Reply-To: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23383-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23383-70-1kQ4vOkyTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:12 +0000
Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make
 the search inaccurate
In-Reply-To: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23521-70-yTJJhbAqsy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:14 +0000
Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make
 the search inaccurate
In-Reply-To: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23521-70-iRP0uAvS6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:17 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-y4JVpaAZlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:18 +0000
Subject: [Koha-bugs] [Bug 24402] Some roles missing from about page
In-Reply-To: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24402-70-GjC3LetpEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:20 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-yHxo5Ecr4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:22 +0000
Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results
 during hold process
In-Reply-To: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24627-70-irmvsWMVDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:24 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-h3Mr3U9cF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:26 +0000
Subject: [Koha-bugs] [Bug 24767] "Claim returned" feature cannot be turned
 off
In-Reply-To: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24767-70-pZZMauhWQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24767

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:28 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-ATLZOPA2ca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:30 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-pPXyzb2cOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:32 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-Syw634WqcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:33 +0000
Subject: [Koha-bugs] [Bug 24838] Help link from patron categories should go
 to relevant manual page
In-Reply-To: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24838-70-dBQDCAyJFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24838

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:35 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-FFsODyfsLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:03:37 +0000
Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in
 ExcludeHolidaysFromMaxPickUpDelay system preference
In-Reply-To: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24858-70-rPPK732oYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:04:02 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-lJ1mUiHaDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:04:06 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-hevtJRDzsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100729&action=edit
Bug 24846: Add new permission batch_extend_due_dates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:04:10 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-amFUR7hiyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100730&action=edit
Bug 24846: Add new tool to batch extend due dates

With events sometimes leading to unforeseen branch closures (think Coronavirus
as
an example), it would be helpful to have a tool that would allow librarians to
update due dates in bulk based on branch and current due date of the material.

It allows to select checkouts given the following parameters:
 * libraries
 * patron's categories
 * range of the due date

You can set a hard due date, or define a number of days to extend the
due date.

Test plan:
Check some items out
Use the new tool to extend the due dates
Test the different filters to make sure they all work

Note: What about holidays?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:04:13 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-XoMDZUNWjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100731&action=edit
Bug 24846: Link to the new tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:09:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:09:42 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-W7PJ8S63S3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:09:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:09:44 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-sRwkOxcd2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100705|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100732&action=edit
Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc

This patch makes the opac/svc/report script use output_with_http_headers
so it sets the Access-Control-Allow-Origin header.

To test:
1. Create a new public report and remember the report id
2. Use your favourite too to fetch the report in JSON by issuing:
   GET http://localhost:8080/cgi-bin/koha/svc/report?id=1
=> FAIL: There is no Access-Control-Allow-Origin header
3. Apply this patch
4. Restart Plack
   $ sudo koha-plack --restart kohadev
5. Set the AccessControlAllowOrigin to anything (for example,
   https://koha-community.org)
6. Repeat 2
=> SUCCESS: On the response headers you find
Access-Control-Allow-Origin: https://koha-community.org
7. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:16:44 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-fpZUgQPtrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:16:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:16:48 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-L1Scs353Fb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100733&action=edit
Bug 24510: Add missing filter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:22:35 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-pqFk3QOhTp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:22:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:22:38 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-qBSmwC3M0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100692|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100734&action=edit
Bug 24862: Regression tests

This patch introduces tests for the expected behaviour on API routes
that expect a logged in user, but the request is made with an anonymous
session cookie.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail because the situation is not handled correctly in
the code

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:22:41 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-WgtfsAiU4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100693|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100735&action=edit
Bug 24862: Handle annonymous sessions gracefuly

This patch introduces code to detect (cookie) annonymous sessions and
act as expected.

Right now, as check_cookie_auth is not passed the required permissions
(because there aren't always required permissions, and the code to check
permissions is shared with other authentication mechanisms) it returns
'ok' and the session id. This use case was overlooked when this was
coded, and yeilds unexpected error codes (500) when the user logs out
and the annonymous session cookie is used to hit the API. The end result
doesn't pose any security issue (i.e. the resource access is rejected)
but the returned error code is not correct and should be fixed.

This patch verifies for an anonymous session (and avoids querying the
corresponding patron) and then verifies if there is an authorization
config on the route and if the patron object is defined.

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail, 500 instead of the expected 401
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Repeat the original 'steps to reproduce' from the bug report using
   the browser
=> SUCCESS: Problem solved!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Sponsored-by: ByWater Solutions

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:23:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:23:05 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-hDC1gYVYux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Nind from comment #51)
> Patch no longer applies:
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 8132: No changes but disable checkboxes
> error: sha1 information is lacking or useless (tools/batchMod.pl).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 8132: No changes but disable checkboxes

It depends on bug 23463. It's FQA but you can still test this patchset if you
like.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:25:46 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-JJvmVX5B6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |5287
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287
[Bug 5287] Add floating toolbar to search results in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:25:46 +0000
Subject: [Koha-bugs] [Bug 5287] Add floating toolbar to search results in
 OPAC
In-Reply-To: <bug-5287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5287-70-QQpKv3pVL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24874


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874
[Bug 24874] Printing is broken on opac-results.pl page (19.11.x)
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:36:16 +0000
Subject: [Koha-bugs] [Bug 24742] Can't save news item in strict mode without
 value in number field
In-Reply-To: <bug-24742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24742-70-8vhs1WX2S5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24742

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22544

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Will certainly be fixed by bug 22544

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:36:16 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22544-70-zO0cfDXmES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24742

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:39:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:39:54 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-p30oeaday3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:39:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:39:58 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-KDxsgKXjCl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100736&action=edit
Bug 24851: Translate the .txt in French

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:50:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 11:50:31 +0000
Subject: [Koha-bugs] [Bug 24853] Add a tab in system preferences for
 accounting
In-Reply-To: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24853-70-i9yzFnw1aD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

--- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> ---
Hi Katrin.
Yes, I can see it on master.  Do you know what version this comes in?  These
sys prefs that appear here are all relatively new, we would like to see all sys
prefs that deal with fines, accounting, etc to be housed in one location, so I
will submit a bug to move some others such as, finesmode, finecalendar,
allfinesoverride, calculatefines

thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:03:30 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-GRiBScCtBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:03:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:03:34 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-u22Rrtf4NE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100694|0                           |1
        is obsolete|                            |
 Attachment #100695|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100737&action=edit
Bug 24827: Standardise on 'UTF-8' as the encoding name

This patch standardises the encoding name used in direct calls
to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:03:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:03:37 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-23D6CiDioO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100738&action=edit
Bug 24827: Specify UTF-8 as encoding in new_from_xml()

The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not explicitly specify 'UTF-8' as the optional encoding to use.

This patch fixes that.

Test plan (in a MARC21 instance):
0) Stage for import the test record attached to this bug report (make
   sure that 'Check for embedded item record data?' is set to 'Yes'),
   then go to Home > Tools > Manage staged MARC records and click on
   the filename you've just staged.
1) In the 'Citation' column, click on the hyperlink to launch the MARC
   preview -- notice how it fails to produce any output apart from the
   modal heading.
2) Apply the patch, and restart Plack if necessary.
3) Re-launch the MARC preview: this time the output should include the
   whole record, including the embedded item data in field 952.
4) Run the unit tests to ensure nothing was broken inadvertently:
   $ prove t
   $ prove xt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:03:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:03:41 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-XtVJsTKJ6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100739&action=edit
Bug 24827: Add a test

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:04:23 +0000
Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in
 substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
In-Reply-To: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24826-70-aEhwZlBE9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you attach a signed-off patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:07:36 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
 sources prior to request creation
In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23173-70-hN9PiMQn6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

--- Comment #36 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 100740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100740&action=edit
Bug 23173: (follow-up) Display available partners

When selecting partners for search during the "Place request with
partner libraries" workflow, there was no indication of which partners
could actually be searched (i.e. are attached to a Z target and enabled
for partner search). We now list them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:13:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:13:07 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-0gDfwNLSeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100420|0                           |1
        is obsolete|                            |

--- Comment #27 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100741&action=edit
Bug 9525: Group floating rules

+-----------------------------+
| USAGE TIPS (sorry didn't document these in the GUI |
+-----------------------------+

When modifying a floating route rule, pressing "%" accepts the modification and
pressing "V" cancels the modifications and reverts the old rule.
The empty text box in the center of the route rule (under the floating type
dropdown list) is the box for conditional rules, where you put the logical
expression.

+-----------------------------+
| SETTING UP THE TEST CONTEXT |
+-----------------------------+

-1. Find an Item, which can be circulated freely, and has homebranch B and
    any holdingbranch.
0. Read the instructions at admin/floating-matrix.pl.

+-----------+
| TEST PLAN: Disabled floating:
+-----------+

0. Make sure that the floating rules from branch A to branch B (A -> B) are
   "Disabled" and vice versa (B -> A).
1. Set your current library to A.
2. Check-in the Item.
3. Observe the started transport to branch B.
4. Set your current library to B.
5. Check-in to receive the transfer.

+-----------+
| TEST PLAN: Always floating:
+-----------+

0. Make sure that the floating rules from branch A to branch B (A -> B) are
   "Allowed".
1. Set your current library to A.
2. Check-in the Item.
3. Observe that there is not transport prompt to branch B and the Item is not
   "in-transit" -state.

+-----------+
| TEST PLAN: Possibly floating:
+-----------+

0. Make sure that the floating rules from branch A to branch B (A -> B) are
   "Possible".
1. Set your current library to A.
2. Check-in the Item.
3. Observe that there is a transport prompt to branch B. You can decide if you
   want to transfer or no.

+-----------+
| TEST PLAN: Conditional floating:
+-----------+

0. Same as Always floating if the given condition matches. See the feature
description at admin/floating-matrix.pl explaining Conditional floating.

+-----------+
| TEST PLAN: Floating rule tester:
+-----------+

0. Add some floating rules between libraries
1. Choose origin library, destination library and give barcode for the item you
want to test
2. Hit "Test"
3. Make sure box next to the "Test" button changes color according rules you
made
4. Also for conditional floating use barcode for item that doesn't match given
condition

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:13:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:13:39 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-HSGHcDB3ZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100421|0                           |1
        is obsolete|                            |

--- Comment #28 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100742&action=edit
Bug 9525: Fixing floating on return

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:14:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:14:21 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-Y1j2e3B3nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100422|0                           |1
        is obsolete|                            |

--- Comment #29 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100743&action=edit
Bug 9525: Add support for regexps in conditional floating

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:14:49 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-CHFNlJzHMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:57:27 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-TWNZJrPuyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:57:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:57:29 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-RwAn7uT77z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100402|0                           |1
        is obsolete|                            |
 Attachment #100403|0                           |1
        is obsolete|                            |
 Attachment #100404|0                           |1
        is obsolete|                            |
 Attachment #100405|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100744&action=edit
Bug 21443: Update database

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:59:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:59:14 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-Y0nf0ZrSH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100744|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100745&action=edit
Bug 21443: Update database

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:59:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:59:23 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-EBv6gSSsEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100746&action=edit
Bug 21443: Update Schema [DO NOT PUSH]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:59:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:59:26 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-4g85dk8scm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100747&action=edit
Bug 21443: Add ability to exclude holidays when calculating rentals fees by
time period

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:59:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 12:59:29 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-x6UqWUsFIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 100748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100748&action=edit
Bug 21443: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:12:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 13:12:02 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-9Z8ncyKVJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, works

This variables:
    # List all records to process
    my ( @records, @record_ids );

are declared but not used, qa-tools complains.
It's ok?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 13:27:59 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-z5f8MbWpLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #38 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Macros I had in my cache before applying patches are not visible after patch,
so I cannot convert them. Failing QA for this.

I also got a weird error that I cannot seem to recreate:
- create user with only "catalogue" and "editcatalogue" permissions
- open incognito window, log in as your user
- create a new macro, mark it public
- click away from your new macro
- click back to your new macro to edit it, get this error:
"Failed to load macros:{"error":"This macro is shared, you must access it via
advancededitormacros\/shared"}"

But it lets you edit the macro anyway? And it still shows and works for other
users?
And then once I'd logged out and back in again, the error stopped. As I said, I
haven't been able to make it happen again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:02:02 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-JufFP4raZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #68)
> Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any
> fields in items, either individually or via batch edit - things like
> 'onloan' and 'itemlost_on' are successfully nulled as they should be.

Fixed, see "Use new method Koha::Object->set_or_blank"

> Two test failures:
> 
> #   Failed test 'Syntax check misc/migration_tools/fix_onloan.pl'
> #   at /usr/share/perl5/Test/Strict.pm line 423.
> # Unmatched right curly bracket at misc/migration_tools/fix_onloan.pl line
> 20, at end of line
> # syntax error at misc/migration_tools/fix_onloan.pl line 20, near "}"
> # misc/migration_tools/fix_onloan.pl had compilation errors.
> # Looks like you failed 1 test of 706.

Fixed!

>     #   Failed test 'reference if positive itemtype notforloan value'
>     #   at t/db_dependent/XSLT.t line 57.
>     #                   '<items
> xmlns="http://www.koha-community.org/items"><item><homebranch>FwkGdaAK</
> homebranch><holdingbranch>FwkGdaAK</holdingbranch><location></
> location><ccode></ccode><status>available</status><itemcallnumber></
> itemcallnumber><stocknumber></stocknumber></item></items>'
>     #     doesn't match '(?^u:<status>reference</status>)'

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:12:03 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-RFlKVsSBLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100730|0                           |1
        is obsolete|                            |
 Attachment #100731|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100749&action=edit
Bug 24846: Add new tool to batch extend due dates

With events sometimes leading to unforeseen branch closures (think Coronavirus
as
an example), it would be helpful to have a tool that would allow librarians to
update due dates in bulk based on branch and current due date of the material.

It allows to select checkouts given the following parameters:
 * libraries
 * patron's categories
 * range of the due date

You can set a hard due date, or define a number of days to extend the
due date.

Test plan:
Check some items out
Use the new tool to extend the due dates
Test the different filters to make sure they all work

Note: What about holidays?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:12:07 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-MPIVREc8l2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100750&action=edit
Bug 24846: Link to the new tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:12:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:12:27 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-qttZiuuSId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #6)
> Hi, works
> 
> This variables:
>     # List all records to process
>     my ( @records, @record_ids );
> 
> are declared but not used, qa-tools complains.
> It's ok?

Nope, unused vars. I fixed it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:16:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:16:11 +0000
Subject: [Koha-bugs] [Bug 15688] Renew item that is on hold: Display
 information about hold's patron
In-Reply-To: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15688-70-jc2DO7tOPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100751&action=edit
Bug 15688: Count index relative to specific table

We simply add the selector to the 'th' index to ensure we count only the table
in question

This should not affect any other pages, but is necessary for detail.tt which
has two tables
on the same page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:20:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:20:58 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-a2jbSA9WOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Isherwood from comment #8)
> Anyway, it feels like this is a question that's bigger than just the
> addition of this route, do you agree?

It's definitely bigger than this route, do we have already such routes that
could be problematic?

I have asked Tomas to let a comment with his thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:37:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:37:24 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-Tu4Sb3EuYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100729|0                           |1
        is obsolete|                            |

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100752&action=edit
Bug 24846: Add new permission batch_extend_due_dates

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:37:28 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-tHd5r9iKJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100749|0                           |1
        is obsolete|                            |

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100753&action=edit
Bug 24846: Add new tool to batch extend due dates

With events sometimes leading to unforeseen branch closures (think Coronavirus
as
an example), it would be helpful to have a tool that would allow librarians to
update due dates in bulk based on branch and current due date of the material.

It allows to select checkouts given the following parameters:
 * libraries
 * patron's categories
 * range of the due date

You can set a hard due date, or define a number of days to extend the
due date.

Test plan:
Check some items out
Use the new tool to extend the due dates
Test the different filters to make sure they all work

Note: What about holidays?

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, tried hard new date and number of days.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:37:32 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-8ZM5L8qcf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100750|0                           |1
        is obsolete|                            |

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100754&action=edit
Bug 24846: Link to the new tool

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:37:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:37:47 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-yOTJ6gwDo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:38:00 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-d4tQwdUm1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:46:42 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-vagRFxb47k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:46:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:46:47 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-MPxc48EI2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100755&action=edit
Bug 22025: Add a regression test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:46:51 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-Z4xydbdO3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100756&action=edit
Bug 22025: Remove warnings when importing patrons

The following warning is raised when importing patrons
Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1018

if one of the following headers is passed but does not have a value:
 * privacy
 * privacy_guarantor_fines
 * privacy_guarantor_checkouts
 * anonymized

Test plan:
- Do not apply the patch
- Generated a csv file with at least one those headers
- Import it using the import_patrons.pl script (or using the GUI)
- Notice the warnings without the patch
- Apply the patch
- Confirm that the warnings do not longer appear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:55:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:55:57 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-KJDo52DaQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:55:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:55:59 +0000
Subject: [Koha-bugs] [Bug 24776] Remove useless Borrowers Template Toolkit
 plugin
In-Reply-To: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24776-70-wxMwDZxmuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:56:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:56:01 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-oJZKk8IR2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:56:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:56:03 +0000
Subject: [Koha-bugs] [Bug 24827] MARC preview fails when staged record
 contains items with UTF-8 characters
In-Reply-To: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24827-70-NnLf7QFrek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24827

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:56:05 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-qmeCpZh8QR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:56:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:56:07 +0000
Subject: [Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions
In-Reply-To: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24862-70-66ATFLW5b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:57:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:57:23 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-4368GyhDPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100757&action=edit
Bug 24789: [follow-up] Fix saving of macros

Saving was accidentally commented out in patches, this restores that

To test:
1 - Create a new macro
2 - Add some content
3 - Reload the macro, no content
4 - Apply patch
5 - Repeat
6 - Macro saves/loads correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:57:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 14:57:36 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-cekNB5620w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:08:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:08:31 +0000
Subject: [Koha-bugs] [Bug 24789] Remove 'ITS' macro format
In-Reply-To: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24789-70-2dlpoyAQKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:36 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-B97SwGqEZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:40 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-1iS8dOq8rb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100569|0                           |1
        is obsolete|                            |
 Attachment #100570|0                           |1
        is obsolete|                            |
 Attachment #100571|0                           |1
        is obsolete|                            |
 Attachment #100572|0                           |1
        is obsolete|                            |
 Attachment #100573|0                           |1
        is obsolete|                            |
 Attachment #100574|0                           |1
        is obsolete|                            |
 Attachment #100575|0                           |1
        is obsolete|                            |
 Attachment #100584|0                           |1
        is obsolete|                            |
 Attachment #100604|0                           |1
        is obsolete|                            |

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100758&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:44 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-sBD4bHw9FG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100759&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

Bug 17268: (follow-up) Update API field definition to boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:48 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-0VkSpKOzzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100760&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:51 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-ouz3P0osDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100761&action=edit
Bug 17268: (follow-up) Fix licenses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:55 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-f64AilN9SB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100762&action=edit
Bug 17268: DO NOT PUSH: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:16:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:16:59 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-0P6SwYfPFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #44 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100763&action=edit
Bug 17268: Set boolean for shared column in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:32:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:32:17 +0000
Subject: [Koha-bugs] [Bug 24728] Short Last Name Search Issue
In-Reply-To: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24728-70-5pQHugD31W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24728

--- Comment #2 from Christofer Zorn <christofer.zorn at ajaxlibrary.ca> ---
I just ran it again and found the "Lo" last name on page 86 of our search
results. I've given our staff a work around, so let's leave it at that then and
close this off.

Thanks Katrin!

Christofer

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:34:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:34:02 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-TELAdlGCXA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:34:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:34:09 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-6z9pt8KEYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:54:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:54:46 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-APIaEvBHp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Hayley Mapley from comment #9)
> This patch in the 18.11 build has caused two tests to fail:
> 
> _db_dependent_selenium_regressions_t.Display circulation table correctly
> (476)
> t_db_dependent_Circulation_t.AddReturn + suspension_chargeperiod (500)
> 
> Is anyone able to fix these tests for 18.11? Alternatively I can revert the
> patches for now.

Hi Hayley,
I do recreate the selenium failure locally, not Circulation.t
The checkouts table does not display correctly because of a missing
columns_settings variable.

The following commit is part of 19.05 but 18.11:
  commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc
  Bug 17353: Add phone number column to checkout search


-        columns_settings = [% ColumnsSettings.GetColumns( 'circ',
'circulation', 'issues-table', 'json' ) | $raw %]
+        columns_settings_issues_table = [% ColumnsSettings.GetColumns( 'circ',
'circulation', 'issues-table', 'json' ) | $raw %]
+        columns_settings_borrowers_table = [% ColumnsSettings.GetColumns(
'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:34 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-gFQOutw6uz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100765&action=edit
Bug 21296: [18.11.x] Fix wrong resolution conflict

On
  commit a230878b6f3d3afa5d7f33c9d816bd6272c5b1a1
  Bug 21296: suspend hold ignores system preference on intranet

See comment 10.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:40 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-dFKwu0QYf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100758|0                           |1
        is obsolete|                            |
 Attachment #100759|0                           |1
        is obsolete|                            |
 Attachment #100760|0                           |1
        is obsolete|                            |
 Attachment #100761|0                           |1
        is obsolete|                            |
 Attachment #100762|0                           |1
        is obsolete|                            |
 Attachment #100763|0                           |1
        is obsolete|                            |

--- Comment #45 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100766&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:44 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-QyUCnwfyqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #46 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100767&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

Bug 17268: (follow-up) Update API field definition to boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:48 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-rDx5zdz6RF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100768&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:52 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-v0LOYC6O70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #48 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100769&action=edit
Bug 17268: (follow-up) Fix licenses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:55 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-9ZZ91DRTKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100770&action=edit
Bug 17268: DO NOT PUSH: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:57:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 15:57:59 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-cgotBvsSzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #50 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100771&action=edit
Bug 17268: Set boolean for shared column in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:00:12 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-mXSLREHg53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Mason,

I cannot clean apply this to the 19.11.x branch:

.git/rebase-apply/patch:32: trailing whitespace.
@page { margin: 1cm }
warning: 1 line adds whitespace errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:34 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-2HAyVJ8tAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100766|0                           |1
        is obsolete|                            |
 Attachment #100767|0                           |1
        is obsolete|                            |
 Attachment #100768|0                           |1
        is obsolete|                            |
 Attachment #100769|0                           |1
        is obsolete|                            |
 Attachment #100770|0                           |1
        is obsolete|                            |
 Attachment #100771|0                           |1
        is obsolete|                            |

--- Comment #51 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100772&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:38 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-4IaATOci2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #52 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100773&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

Bug 17268: (follow-up) Update API field definition to boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:42 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-apsXcnXjrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #53 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100774&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:46 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-q5YQtZcrse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #54 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100775&action=edit
Bug 17268: (follow-up) Fix licenses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:50 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-3cIX5jPm0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #55 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100776&action=edit
Bug 17268: DO NOT PUSH: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:05:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:05:53 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-dUFHHZfAJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #56 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100777&action=edit
Bug 17268: Set boolean for shared column in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:19:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:19:08 +0000
Subject: [Koha-bugs] [Bug 24881] New: Circulation.t still fails if tests are
 ran slowly
Message-ID: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

            Bug ID: 24881
           Summary: Circulation.t still fails if tests are ran slowly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 22917

Bug 22917 - Circulation.t fails if tests are ran slowly

Not fixed, or regression added after.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917
[Bug 22917] Circulation.t fails if tests are ran slowly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:19:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:19:08 +0000
Subject: [Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
In-Reply-To: <bug-22917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22917-70-v0kKTxbAVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24881


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881
[Bug 24881] Circulation.t still fails if tests are ran slowly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:20:07 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-tp3DLtAdqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100778&action=edit
Bug 24881: [19.05.x] Try to fix random failure from Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:32:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:32:04 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-63YBAyDnCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lucas, if you can recreate that one, could you confirm this patch fixes the
failures on 19.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:45:43 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-TLDqQRiKsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan, I still get this: 

# Subtest: CanBookBeRenewed tests
    1..71
DBD::mysql::st execute failed: Unknown column 'me.guarantorid' in 'field list'
[for Statement "SELECT `me`.`borrowernumber`, `me`.`cardnumber`,
`me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`,
`me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`,
`me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`,
`me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`,
`me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`,
`me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`,
`me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`,
`me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`,
`me`.`date_renewed`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`,
`me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`,
`me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`,
`me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`,
`me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`,
`me`.`altcontactfirstname`, `me`.`altcontactsurname`,
`me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`,
`me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`,
`me`.`login_attempts`, `me`.`overdrive_auth_token`, `me`.`anonymized` FROM
`borrowers` `me` WHERE ( `me`.`borrowernumber` = ? )" with ParamValues: 0='84']
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # No tests run!
not ok 15 - No tests run for subtest "CanBookBeRenewed tests"

#   Failed test 'No tests run for subtest "CanBookBeRenewed tests"'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 998.
DBD::mysql::st execute failed: Unknown column 'me.guarantorid' in 'field list'
[for Statement "SELECT `me`.`borrowernumber`, `me`.`cardnumber`,
`me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`,
`me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`,
`me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`,
`me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`,
`me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`,
`me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`,
`me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`,
`me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`,
`me`.`date_renewed`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`,
`me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`,
`me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`,
`me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`,
`me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`,
`me`.`altcontactfirstname`, `me`.`altcontactsurname`,
`me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`,
`me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`,
`me`.`login_attempts`, `me`.`overdrive_auth_token`, `me`.`anonymized` FROM
`borrowers` `me` WHERE ( `me`.`borrowernumber` = ? )" with ParamValues: 0='84']
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
# Looks like your test exited with 11 just after 15.
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 32/46 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:47:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:47:45 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-qLG5y6flie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

--- Comment #1 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 100779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100779&action=edit
Bug 20648:  Attribute option 'Display in check-out' should be renamed

This patch rewords the 'Display in check-out' option in the patron
attribute policy

To test:

1) Apply patch
2) Go to /cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
3) Check that the 8th line down has been renamed to "Display in patron's
brief information:"
4) Check the description of this same option has been changed to "Check
to show this attribute in the brief information panel in the patron's
record (staff client)."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 16:48:20 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-JIUIR0Cdhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:14:58 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-B0IeF9nElg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100772|0                           |1
        is obsolete|                            |

--- Comment #57 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100780&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:15:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:15:04 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-zuIMLMeINY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100773|0                           |1
        is obsolete|                            |

--- Comment #58 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100781&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

Bug 17268: (follow-up) Update API field definition to boolean

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:15:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:15:08 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-RKdkSso8dt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100774|0                           |1
        is obsolete|                            |

--- Comment #59 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100782&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:15:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:15:12 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-CN8SmmhkPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100775|0                           |1
        is obsolete|                            |

--- Comment #60 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100783&action=edit
Bug 17268: (follow-up) Fix licenses

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:15:15 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-IzmUJVzvYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100776|0                           |1
        is obsolete|                            |

--- Comment #61 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100784&action=edit
Bug 17268: DO NOT PUSH: Schema update

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:15:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:15:19 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-GIJkEfxY6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100777|0                           |1
        is obsolete|                            |

--- Comment #62 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100785&action=edit
Bug 17268: Set boolean for shared column in schema

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:21:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:21:29 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-2XGtjQFXab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:33:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:33:59 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-bugbDFRAFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi I'm sorry for the delay to comment on this one.

As a general comment, our (current) controller/permissions logic doesn't allow
to specify complex conditions. We only check for permissions/ownership, before
we reach the controller. [1]

So the general rule is that any syspref check or combination of
permissions+sysprefs (that can be found in many places in our
codebase/templates) should be done either in a high level method (ModIssue?) or
the controller itself (e.g. that's why we stash the current user, accesible
through $c->stash('koha.user') so we can ask further questions about it. Any
authentication method stashes the user for that purpose.

That said, changing the date due on a checkout might be something worth having
a method in Koha::Checkout->update_due_date so any logic is encapsulated there
and, more importantly, the method can be used in other places.

Speaking of the current endpoint, we've been observant of the current
implementations on the UI to catch all the conditions and prevent misuses of
endpoints. This doesn't mean there were no mistakes, but speaking for my
contributions, I usually look at the .pl, the .tt and try to put all that logic
on the enpdoint.

[1] And I'm not sure we should add such a thing to our project as the API
hasn't been a target for the refactorings specifically, and so moving existing
logic into a (cool) new high level config layer on the spec would mean
maintaining two codebases right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:42:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:42:09 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-S3RCMlLlEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100786&action=edit
Bug 15668: Add column configuration to the items table in staff detail pages

To test:
1 - Apply patches
2 - View biblio details in staff client
3 - Should be able to toggle columns
4 - Go to admin columns settings
5 - Change some settings, verify they work
6 - Enable SeparateHoldings
7 - Go to a record that has holdings from 2 different branches 
8 - Change some settings, verify they work. 
9 - Check the Other Holdings Tabs, change some settings make sure they work.
10. - Test all the dataTable functions like the search box, columns, export.
make sure they on both tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:43:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:43:39 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-vqaLdt0U3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:43:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:43:42 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-TKtWjnNbJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100787&action=edit
Bug 15668: Add column configuration to the items table in staff detail pages

To test:
1 - Apply patches
2 - View biblio details in staff client
3 - Should be able to toggle columns
4 - Go to admin columns settings
5 - Change some settings, verify they work
6 - Enable SeparateHoldings
7 - Go to a record that has holdings from 2 different branches
8 - Change some settings, verify they work.
9 - Check the Other Holdings Tabs, change some settings make sure they work.
10. - Test all the dataTable functions like the search box, columns, export.
make sure they on both tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:44:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:44:12 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-etS5zmhI4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100642|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:44:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:44:31 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-04gsQF3LtP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100786|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:06 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-MvIu821imx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:13 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-I30JhfVaQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98119|0                           |1
        is obsolete|                            |
  Attachment #98120|0                           |1
        is obsolete|                            |
  Attachment #98121|0                           |1
        is obsolete|                            |
  Attachment #98122|0                           |1
        is obsolete|                            |
  Attachment #98123|0                           |1
        is obsolete|                            |
  Attachment #98124|0                           |1
        is obsolete|                            |
  Attachment #98126|0                           |1
        is obsolete|                            |
  Attachment #98127|0                           |1
        is obsolete|                            |
  Attachment #98128|0                           |1
        is obsolete|                            |
  Attachment #98129|0                           |1
        is obsolete|                            |
  Attachment #98130|0                           |1
        is obsolete|                            |
  Attachment #98131|0                           |1
        is obsolete|                            |
  Attachment #98240|0                           |1
        is obsolete|                            |
  Attachment #98268|0                           |1
        is obsolete|                            |
  Attachment #98279|0                           |1
        is obsolete|                            |

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100788&action=edit
Bug 23590: Add ability to edit the manager of a suggestion

Prior to this patch there was an hidden behavior that set the manager to
the logged in user when a suggestion was edited. This patch proposes to
let the librarian pick another manager.
Other small adjustements will be added to polish this new behavior:
 * Create 2 new DB columns: suggestions.lastmodificationby and
 suggestion.lastmodificationdate
 * Choose a manager when editing a suggestion
 * Batch modify suggestions and set a manager for them
 * Let notify the new manager using the TO_PROCESS letter
 * Display the manageddate, lastmodificationby and lastmodificationdate
 info where appropriate

This first patch adds a new "Select manager" link when editing a
suggestion.

Test plan for the whole patchset:
0/
  a. Execute the update DB entry, generate the new DBIC file and restart all
  b. Create at least 2 patrons with the suggestions_manage permission
1/ Submit a new suggestion (OPAC or staff, not important)
2/ Accept it
3/ Edit it
=> "Last modification by" is empty
=> You see that you are the manager of this suggestion
4/ Click "Select manager" and search for a new manager
=> The patron search will only display patrons with the
suggestions_manage permission
5/ Save
6/ Edit again
=> The manager is set to you, but there is a note saying that previously
it was the patron you picked
=> The "Last modification by" is set to you
7/ Click "Keep existing manager"
=> The manager is now set to the previous manager
8/ Select another manager (which has a valid email address defined)
9/ Click the "notify" checkbox
10/ Save
11/ Confirm that a TO_PROCESS notice has been generated into the
message_queue table
12/ Create at least one other suggestion
13/ List the suggestions
=> There is a 4th action column to assign a manager to several
suggestions in one go.
14/ Use this new button and confirm that it works as expected
15/ Go to your purchase suggestion list (OPAC and staff)
=> You see the "managed date" displayed in a new column

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:18 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-gEql8RHIbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100789&action=edit
Bug 23590: Clean TT variables for patrons

Just a bit of cleaning

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:23 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-0DfOAP86aK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100790&action=edit
Bug 23590: Cleaning - Remove op_* vars

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:28 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-zLE7g5n2BN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100791&action=edit
Bug 23590: Batch update manager for suggestions

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:33 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-qJZ5npV7J5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100792&action=edit
Bug 23590: Only return patrons that have the suggestions_manage permission

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:37 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-jICMtWFOAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100793&action=edit
Bug 23590: Add the ability to notify a new manager

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:42 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-JHE1vGulX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100794&action=edit
Bug 23590: Add lastmodification by and date columns

No tests are provided for the changes made to SearchSuggestion. It is
going to be remove very soon as it is super ugly...

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:47 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-3N335WxTTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100795&action=edit
Bug 23590: Add atomic update file

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:52 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-1dYa0ESPrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100796&action=edit
Bug 23590: Remove JS error on the suggestion list

The notify option is only available from the edit view

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:49:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:49:57 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-3qoHgA0jFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100797&action=edit
Bug 23590: Fix select manager on list for all tabs

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:02 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-JXMXf0dB0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100798&action=edit
Bug 23590: DBIC Changes

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:07 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-3F7X6HbnCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100799&action=edit
Bug 23590: (QA follow-up) Add missing filters and drop script type

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:13 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-pPOTTjIKCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100800&action=edit
Bug 23590: (QA follow-up) Fix some problems created by recent changes and
updatedatabase statement

- Ensure that the sequence of columns will be the same for new
  and updated installations (add AFTER ...)
- Fix permissions (see bug 22868)
- Fix column configuration (see 16784)
- Remove '- ' displying before the date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:18 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-rJDfeywffP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100801&action=edit
Bug 23590: remove unused variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:23 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-8xHIq9QQD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100802&action=edit
Bug 23590: Update new fields with relevant values

We are filling lastmodificationdate and lastmodificationby depending on
the max dates between manageddate, accepteddate and rejecteddate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:29 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-QCZ5fcRdVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100803&action=edit
Bug 23590: Fix ergonomic issue if last modification by is empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:50:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:50:34 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-IizOOSUMWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100804&action=edit
Bug 23590: Create a separate template notice NOTIFY_MANAGER

To separate the two feature we want to create a distinct template
notice.
A new NOTIFY_MANAGER notice is added.
A follow-up patch will be added for other languages, when this one will
be approved by QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:51:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:51:45 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-jla0ZHhgyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100787|0                           |1
        is obsolete|                            |

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100805&action=edit
Bug 15668: (follow up) add selector to th

follow up add a selector to the <th> to ensure we count the table in questions.
Should not affect other pages but is needed on detail.tt where there are two
tables to configure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:52:10 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-IGtU7qAAjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100787|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:56:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:56:54 +0000
Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in
 holdings_table
In-Reply-To: <bug-24176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24176-70-iRzyi8w8IH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Yes, I will redo this patch once/if bz15668 makes it into master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:57:27 +0000
Subject: [Koha-bugs] [Bug 15688] Renew item that is on hold: Display
 information about hold's patron
In-Reply-To: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15688-70-6qwbQlePVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
 Attachment #100751|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:57:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:57:59 +0000
Subject: [Koha-bugs] [Bug 15688] Renew item that is on hold: Display
 information about hold's patron
In-Reply-To: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15688-70-m6BGRknazV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Obsoleting Nick's patch as it is attached to the wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:58:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 17:58:50 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-HFzvgZbaAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow to modify the manager |Allow to modify and notify
                   |of a suggestion             |the manager of a suggestion
  Text to go in the|                            |This new feature adds the
      release notes|                            |ability to modify the
                   |                            |manager of a suggestion.
                   |                            |When assigning a suggestion
                   |                            |to a new manager, a notice
                   |                            |NOTIFY_MANAGER could be
                   |                            |sent to the manager to
                   |                            |alert them.
                   |                            |
                   |                            |To keep track
                   |                            |of the different
                   |                            |modification, 2 new columns
                   |                            |are added to the suggestion
                   |                            |table: lastmodificationby
                   |                            |and lastmodificationdate,
                   |                            |which will be updated
                   |                            |automatically when a
                   |                            |suggestion is edited.

--- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #71)
> (In reply to Katrin Fischer from comment #69)
> > Notes & questions
> > 
> > 1) We might want to modify the bug title a little - in addition to allow
> > changing the manager, this will also store the last person to change and
> > date. Also gives a checkbox for TO_PROCESS. We really needs some release
> > notes :)
> 
> Any suggestions? :)
> 
> > 2) lastmodificationdate and lastmodificationby are quite long. It might be
> > nicer to used something more readable like: last_modified_on and
> > last_modified_by. Not blocker for me, but putting the thought out there.
> 
> I followed the existing pattern As there were already 4 of those I thought
> it was better to keep names consistent.
> 
> > 3) Is there a reason why we don't let the db update thelastmodificationdate?
> 
> We can pick the max date of suggesteddate, manageddate, accepteddate,
> rejecteddate,  is that was you have in mind?
> 
> > 4) Please check my follow-up
> 
> They look good, thanks!
> 
> > Blockers
> > 
> > 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?
> 
> > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> > for the manager. I believe this should be handled separately. ( Bug 13014:
> > Notify budget owner on new suggestion - cronjob)
> 
> That was part of the original specification.
> It makes sense to have 2 different notice templates. Something to suggest?
> UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
> 
> > 3)
> > +            if ( $notify ) {
> > +                my $patron = Koha::Patrons->find(
> > $suggestion_only->{managedby} );
> > +                my $email_address = $patron->notice_email_address;
> > +                if ($patron->notice_email_address) {
> > +                    my $budget = C4::Budgets::GetBudget(
> > $suggestion_only->{budgetid} );
> > $budget appears not to be used - possibly a copy&paste because of 2).
> 
> Indeed, follow-up coming.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:01:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:01:35 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-MyfueQzqNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #71)
> (In reply to Katrin Fischer from comment #69)
> > Notes & questions
> > 
> > 1) We might want to modify the bug title a little - in addition to allow
> > changing the manager, this will also store the last person to change and
> > date. Also gives a checkbox for TO_PROCESS. We really needs some release
> > notes :)
> 
> Any suggestions? :)

Done, hope that makes sense.

> > 3) Is there a reason why we don't let the db update thelastmodificationdate?
> 
> We can pick the max date of suggesteddate, manageddate, accepteddate,
> rejecteddate,  is that was you have in mind?

I added a follow-up to update the 2 new columns.

> > Blockers
> > 
> > 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?

Still waiting for an answer here, but I think we could fix that on a follow-up
if needed. The change will be minor compared to the work needed to keep this
patchset up-to-date with master.

> > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> > for the manager. I believe this should be handled separately. ( Bug 13014:
> > Notify budget owner on new suggestion - cronjob)
> 
> That was part of the original specification.
> It makes sense to have 2 different notice templates. Something to suggest?
> UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?

Done, a new template notice "NOTIFY_MANAGER" has been added.

Sending back to the QA queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:10 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-6cam9AIym8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:15 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-QZsnittkTf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96900|0                           |1
        is obsolete|                            |
  Attachment #96901|0                           |1
        is obsolete|                            |
  Attachment #96902|0                           |1
        is obsolete|                            |
  Attachment #96903|0                           |1
        is obsolete|                            |
  Attachment #96904|0                           |1
        is obsolete|                            |
  Attachment #96905|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100806&action=edit
Bug 22784: DB Changes

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:20 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-y3Un0fmqe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100807&action=edit
Bug 22784: DBIC Changes

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:25 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-KxjuApcbzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100808&action=edit
Bug 22784: Add the ability to archive/unarchive a purchase suggestions

There are performance issues when searching suggestions if there are
thousands of suggestions.
To prevent that we are going to add the ability to archive purchase
suggestions, in order to remove them from the search list (by default).

Test plan:
0. Apply all the patches, execute the updatedatabase.pl script, restart
all
1. Create some suggestions
2. Search for them
3. Use the "Archive" action button for one of them
4. Restart the search
=> The archived suggestion does no longer appear in the list
5. Use the filter "Included archived" in the "Suggestion information"
filter box
=> The archived suggestion is now displayed
6. Use other filters
=> The "archived" filter is kept from one search to another
7. Use one of the action at the bottom of the suggestion list (change
the status for instance)
=> The "archived" filter is still kept

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:29 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-TCAnxZMghA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100809&action=edit
Bug 22784: Bugfix - do not modify #description build Debian packages from a git
repository

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:33 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-qOhlgfS8lF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100810&action=edit
Bug 22784: Do not display an empty table

This is terrible and highlight that the whole script must be rewrite.
GetDistinctValues does not handle the "archived" flag (and we do not
want to put our hands there), so let's hack that and plan to rewrite the
whole script.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:07:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:07:37 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-alzCJvFgTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100811&action=edit
Bug 22784: Add a cronjob to archive suggestions given age or status criteria

In order to deal automatically with suggestions that need to be
archived, this cronjob will help to add the "archived" flag following
their age or status.

Test plan:
- Execute the script with the --help parameter and read the documentation.
- Does it make sense?
- Use it without the --confirm flag and try several combination

For instance you will want to archive suggestions that have been
rejected for more than a week:
  perl misc/cronjobs/archive_purchase_suggestions.pl
  --age-date-field=rejecteddate --age=weeks:1

or even suggestion that have been suggested for more than a year and
have a ORDERED status:
  perl misc/cronjobs/archive_purchase_suggestions.pl
  --age-date-field=suggesteddate --age=years:1 --status=ORDERED

- Use it with the --confirm flag and make sure the suggestions have been
archived.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:15:59 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-fkMWzkhjXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:16:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:16:06 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-jlfH3Td2Bm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95600|0                           |1
        is obsolete|                            |
  Attachment #95601|0                           |1
        is obsolete|                            |
  Attachment #95602|0                           |1
        is obsolete|                            |
  Attachment #95603|0                           |1
        is obsolete|                            |
  Attachment #95604|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100812&action=edit
Bug 23591: Add some useful methods to Koha::Suggestions

Those are methods initially written for bug 23991. I finally need them
before than expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:16:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:16:16 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-j7bdcjCgS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100813&action=edit
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page

This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.

Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:16:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:16:25 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-eMHC8JA2QB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100814&action=edit
Bug 23591: Use same css for suggestion notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:16:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:16:38 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-xObpkGiiTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100815&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:16:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:16:46 +0000
Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on
 bibliographic record
In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23591-70-oE7bo8gTtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100816&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:23:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:23:15 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-BUVVMFilRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lucas, this means that you are using a master DB on a 19.05.x branch.
reset_all on 19.05.x and you should not get that error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:44:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:44:45 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for getting and setting checkout
 due date
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-0Rbn8L2C8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The code for update() is missing a ->discard_changes() call before returning
$checkout->to_api, so the timestamp does not look updated on the response,

Regarding the logic in it, I'm worried about the simplicity and how this might
need some round actions to trigger things like account fixes, etc.I'm not
saying it is wrong, but it looks suspiciously simple without having dug too
much into the area recently (i.e. I would accept an 'is safe' from you, if you
say so).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 19:58:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 18:58:11 +0000
Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at
 First issue date, not Subscription start date
In-Reply-To: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15148-70-JGFJtMFRtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Nick Clemens from comment #10)
> I think the issue here has been for bringing in subscriptions from another
> system, so you are setting the first issue to the first one held, but then
> adding the start date and wanting to see the issues from that date forward?
> 
> Either way, maybe a better solution is to preserve existing behaviour and
> add an option (radio button) to select generating from the sub start date
> instead of first issue?

Sounds good to me! I'd also be interested in being able to compare to
understand the differences pointed out here better

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:10:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:10:36 +0000
Subject: [Koha-bugs] [Bug 24728] Short Last Name Search Issue
In-Reply-To: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24728-70-Gf9HQQvQxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24728

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:16:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:16:12 +0000
Subject: [Koha-bugs] [Bug 24853] Add a tab in system preferences for
 accounting
In-Reply-To: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24853-70-E85rfUpICY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kelly, looks like this bug is to blame: 
Bug 23321 - Add 'cash registers' to the accounts system (19.11)

We could also reuse this bug by changing the bug title :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:31:16 +0000
Subject: [Koha-bugs] [Bug 24582] Cloning circ rules does not maintain
 checkouts allowed or on-site checkouts allowed
In-Reply-To: <bug-24582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24582-70-KTXWCWS00y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24582

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05
        released in|                            |
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:46:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:46:14 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-2t3l8Gdhh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
ahh, of course. Thanks Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:48:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:48:29 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-PFgWP7X1I1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:50:17 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-1P3W9jtV7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:50:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:50:26 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-9BTprla4AV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:50:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:50:36 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-60lUaHyiCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:51:12 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-XlkUV0vnBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.05.09
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:51:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:51:45 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-NbaRCosQHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:52:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:52:26 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-URbJVFDChW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:55:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:55:25 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-2zZ2W6SlSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen <bin.wen at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96432|0                           |1
        is obsolete|                            |

--- Comment #178 from Bin Wen <bin.wen at inlibro.com> ---
Created attachment 100817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100817&action=edit
Bug 11879 - Add a new field to patron record: main contact method

Fixed the problem mentioned above.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:56:55 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-hx0lBqPqU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Lucas Gass from comment #6)
> backported to 19.05.x for 19.05.09

Can you confirm this patch did fix something?

Which error did you get?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:57:13 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-uMWAECRBMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen <bin.wen at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 20:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 19:58:29 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-OCBKFIhNVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan, no errors. This makes Circulation.t pass all tests. TY.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 21:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 20:02:54 +0000
Subject: [Koha-bugs] [Bug 22789] Establish non-priority holds
In-Reply-To: <bug-22789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22789-70-LMEsQPjbSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #2 from Donna <bwsdonna at gmail.com> ---
This is a functionality libraries request on a regular basis. Great idea!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 21:21:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 20:21:44 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-ZcObNZzKfR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:08:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:08:17 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-Wxwynrr2EF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, I have given this another test run, but I still have issues:

- Add 2 holidays as 'repeated holidays on a range'
- Try to delete them using 'Delete the repeated holidays on a range.'
- Holidays are not deleted

With the patch applied, I am not able to delete them.

Emmi, can you pleas re-check?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:10:14 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-nBH6EvHJAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:10:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:10:17 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-Zsv9ArtlgO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100596|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100818&action=edit
Bug 24851: Insert libraries sample data for "UNIMARC"

I am trying to make koha-testing-docker UNIMARC compabible.
In order to have koha-misc4dev insert all the data correctly (users, etc.) we
need at least 1 library.
I am suggesting to reuse the usual library list for UNIMARC.

misc4dev will use fr-FR sample data for "UNIMARC"
This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29

Test plan:
outside your box, in koha-testing-docker (up-to-date), edit .env and set
 KOHA_MARC_FLAVOUR=unimarc
 DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git
 DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc

Then start the koha container
When the misc4dev will start its job, the scripts will have the expected
data to continue.

Without this patch you will get
koha_1       | Not enough data in the database, library and/or patron category
does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31.

And plenty of errors will follow.

Also, the sample data used in misc4dev will use CPL
(/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql)

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:11:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:11:04 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-AuG8YoSZuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100818|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100819&action=edit
Bug 24851: Insert libraries sample data for "UNIMARC"

I am trying to make koha-testing-docker UNIMARC compabible.
In order to have koha-misc4dev insert all the data correctly (users, etc.) we
need at least 1 library.
I am suggesting to reuse the usual library list for UNIMARC.

misc4dev will use fr-FR sample data for "UNIMARC"
This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29

Test plan:
outside your box, in koha-testing-docker (up-to-date), edit .env and set
 KOHA_MARC_FLAVOUR=unimarc
 DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git
 DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc

Then start the koha container
When the misc4dev will start its job, the scripts will have the expected
data to continue.

Without this patch you will get
koha_1       | Not enough data in the database, library and/or patron category
does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31.

And plenty of errors will follow.

Also, the sample data used in misc4dev will use CPL
(/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql)

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>


Current status: Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:11:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:11:08 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-rlJFfu6TLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100736|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100820&action=edit
Bug 24851: Translate the .txt in French

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:15:49 +0000
Subject: [Koha-bugs] [Bug 24882] New: Date updated and Date/time of change
 are the same on payment/fee details
Message-ID: <bug-24882-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882

            Bug ID: 24882
           Summary: Date updated and Date/time of change are the same on
                    payment/fee details
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When looking at the fee details, there are 2 columns in the table:
- date updated
- date/time of change
Both columns appear to show the same information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:18:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:18:14 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-CW0ciluiAV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:18:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:18:17 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-Rllp0AmwU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100566|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100821&action=edit
Bug 24818: Update database accountlines.date to timestamp

This update increases the resolution for the 'date' field, used for
'creation date' in accountlines from a 'date' to a 'timestamp'.

This matches other tables where both a created and updated field are
included.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:25:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:25:11 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-AdNrzW2cx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems ok. Only wondering: should we be changing old_reserves as well? The
table still has:
  `priority` smallint(6) default NULL, -- where in the queue the patron sits

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:25:49 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-wzN59kR3fQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:25:53 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-KEuxsGwZj4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99595|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100822&action=edit
Bug 24722: Enforce NOT NULL constraint on reserves.priority

This field is never NULL and must always be equal to an integer.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:25:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:25:56 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-o0wrt5rZFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99596|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100823&action=edit
Bug 24722: Add test

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:26:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:26:00 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-c7nbRu7RCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99597|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100824&action=edit
Bug 24722: DBIC changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:26:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:26:03 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-ejhCm6enUX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99642|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100825&action=edit
Bug 24722: Add atomicupdate file

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:29:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:29:12 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-7VTT0K0H64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:29:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:29:15 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-iihbrLVL0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100280|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100826&action=edit
Bug 24774: Set JSON indentation of 2 spaces in .editorconfig

To test:
1. Start an editor that supports .editorconfig
2. Open or create a JSON file
3. Observe identation is set to 2 spaces by default

Sponsored-by: Hypernova Oy

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:33:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:33:05 +0000
Subject: [Koha-bugs] [Bug 24883] New: Command line utility to load yaml files
Message-ID: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

            Bug ID: 24883
           Summary: Command line utility to load yaml files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Now that the installation files are in YAML, a tool to load them would be
handy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:34:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:34:12 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-SCJMdOXRco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:34:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:34:16 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-WDRfl5tyMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99661|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100827&action=edit
Bug 24510: Add focus to Patron/club input

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:34:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:34:19 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-Q8XH1cx4k1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99665|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100828&action=edit
Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name

This alternate patch tries to implement a fix in a more "correct" way by
tying the cursor focus to the initialization of the jQueryUI tabs. By
configuring both the "create" and "activate" events we can make sure the
correct input field is focused.

I think the only advantage of this patch over the other one is that
tying the focus to the tabs activation makes it a little more obvious
where in the DOM loading sequence the focus is being set.

To test, follow the original patch's test plan:

TEST PLAN:
1. Go to Biblio Record
2. Place Hold (request.pl) - either the Hold above the Bib or the Hold
   on the left, it does the same thing.
3. Note that the cursor does not go to Patron Name (for whom to place
   the hold for), it goes to the Top Search bar under Checkout.
4. Apply patch and reload the page.
5. The focus should now be correctly set.
6. Toggle between 'Patrons' and 'Club' tabs.
7. Focus should stay set.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:34:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:34:23 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-2avFERKctc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99666|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100829&action=edit
Bug 24510: Code cleaning

Additional test plan:
Create 3 clubs: abc adf axy
place a hold for on of those club, search for a club 'a'
you will get the focus on the "Clubs" tab

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:34:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:34:28 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-nPVHpjLZT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100733|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100830&action=edit
Bug 24510: Add missing filter

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 21:59:04 +0000
Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST
 does NOT send sms, just e-mail
In-Reply-To: <bug-24235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24235-70-A5hlrO0y8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #14 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Hi,

Backporting this to 18.11.x resulted in conflicts which I don't know how to
resolve. Can somebody please rebase for 18.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:01:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:01:54 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-R8Owd24gsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

--- Comment #12 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Many thanks Jonathan!

I must have removed it in error during the merge.

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:06:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:06:22 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-5BsG4Vcg1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100831&action=edit
Bug 24883: Command line utility to load yaml files

This patch adds a command line utility to load
yaml files.

To test:
1) Apply the patch
2) Try loading a file, e.g. sample notices
 a) mysql -e "delete from letter"
 b) misc/load_yaml.pl -f installer/data/mysql/en/mandatory/sample_notices.yml
3) Try loading a file with a syntax error,
   edit previous file adding ':' at the end of a field without quotes
   then load again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:06:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:06:54 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-iSY0tTMudw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:18:35 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-uzKihpKkvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100832&action=edit
Bug 24266: (alternate patch) Only use defined borrowernumbers in
reconcile_balances.pl cron

I believe the error is triggered when borrowernumbers are left empty in
the accountlines table. Not sure why this would happen, but it appears
to be what causes the problem.

Do not apply the first patch if testing this patch.

To test:
1) sudo koha-mysql INSTANCENAME
2) if you don't have any accountlines where the borrowernumber is null,
    update one of your accountlines where the amountoutstanding is more
than zero, and make the borrowernumber NULL
3) ensure the AccountAutoReconcile syspref is disabled
4) Go to [borrowernumber]'s accounting tab
5) Create a manual credit or debit. Confirm this shows in the 'Make a
payment' tab as an amount that COULD be applied, but isn't automatically
applied
6) in your terminal, run the reconcile_balances.pl script
7) Confirm the error does not show in the logs and the balance for
[borrowernumber] is correctly reconciled.

Sponsored-by: Horowhenua District Council

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:18:54 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-lSESLCGcPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
  Change sponsored?|---                         |Sponsored
           Assignee|tomascohen at gmail.com        |aleisha at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:22:41 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-HTj7Zcpxmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100713|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100833&action=edit
Bug 24854: Remove IDreamBooks integration

The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.

To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
  as expected
- Run t/db_dependent/UsageStats.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:32:19 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-v4V00ll9Q7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #92 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Almost there - thx for the work on the notice.

1) I think this slipped in from another feature in the tree (22784):

+                            <label for="archived" style="display:
inline;">Include archived:</label>
+                            <input type="checkbox" id="archived"
name="filter_archived" value="archived" title="Include archived suggestions in
the search" />
+                      </li>
+                      <li>

2) From comment#91

> > 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?

Still waiting for an answer here, but I think we could fix that on a follow-up
if needed. The change will be minor compared to the work needed to keep this
patchset up-to-date with master.
--

This one is confusing to me and I keep wondering if this should have been more
than one bug :) So at the moment, in suggestions we got:

  `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update
CURRENT_TIMESTAMP,  -- date and time the suggestion was updated

   lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian
who edit the suggestion for the last time
   lastmodificationdate date default NULL, -- date of the last modification

So date is actually always updated and should probably be renamed 'datetime' or
similar. What is the use case for the additional lastmodificationdate?
>From the description it's not clear to me. Do we really need it if we have
date?

Please feel free to get others to look at this - 1) should be a quick fix, 2)
is a bit puzzling to me right now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:36:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:36:57 +0000
Subject: [Koha-bugs] [Bug 24884] New: Remove 'New list' button in 'Public
 lists' tab if OpacAllowPublicListCreation is disabled
Message-ID: <bug-24884-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884

            Bug ID: 24884
           Summary: Remove 'New list' button in 'Public lists' tab if
                    OpacAllowPublicListCreation is disabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When OpacAllowPublicListCreation is disabled (i.e. patrons are not allowed to
create public lists from the OPAC), there shouldn't be a 'New list' button in
the 'Public lists' tab. 

I am aware this does not enable patrons to create public lists, but it can be
confusing, since it is in the 'Public lists' tab.

To replicate:
1) In Administration > Global system preferences, search for
OpacAllowPublicListCreation
2) Choose "Don't allow" and Save
3) Go to the OPAC and log into an account
4) In your account go to "your lists"
5) Click on the "Public lists" tab

Note there is a 'New list' button.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:50:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:50:42 +0000
Subject: [Koha-bugs] [Bug 24882] Date updated and Date/time of change are
 the same on payment/fee details
In-Reply-To: <bug-24882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24882-70-bAQPGpv2D1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 100834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100834&action=edit
Screenshot of fee details

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:51:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 22:51:15 +0000
Subject: [Koha-bugs] [Bug 24882] Date updated and Date/time of change are
 the same on payment/fee details
In-Reply-To: <bug-24882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24882-70-syY9FXZd7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24882

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, looking at it again, type and type of change match up as well - I wonder if
there is something wrong with the template or if this is intentional.

Adding Kyle and a screenshot in hope of help! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:19:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:19:30 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-rYcWgiADpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I totally forgot about this one. Sorry.

Borrowernumbers get emptied when the patron gets deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:21:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:21:02 +0000
Subject: [Koha-bugs] [Bug 24885] New: Remove guided reports
Message-ID: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885

            Bug ID: 24885
           Summary: Remove guided reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The guided reports feature was never fully developed and isn't useful. SQL
reports  are clearly the focus of development moving forward and should be the
center of the reports module instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:21:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:21:15 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-mXmmzswInX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Ah that totally makes sense.

Perhaps instead of going into the database in the test plan, create a test
borrower, add some accountline, then delete the borrower. The script should
know to skip past them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:21:22 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-oO82UBOgCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100833|0                           |1
        is obsolete|                            |

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 100835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100835&action=edit
Bug 24854: Remove IDreamBooks integration

The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.

To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
  as expected
- Run t/db_dependent/UsageStats.t

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:29:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:29:27 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-wy9tLStWYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
I think there is still one more under Comments > Moderate patron comments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:29:47 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-oevt0Xf8ni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:37:37 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-mysHz2IdIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
I guess returns.tt is a moving target, sadly this again doesn't apply cleanly.
:(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:52:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:52:21 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-KPJKPGovYs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #6 from Mason James <mtj at kohaaloha.com> ---
(In reply to Lucas Gass from comment #5)
> Mason,
> 
> I cannot clean apply this to the 19.11.x branch:
> 
> .git/rebase-apply/patch:32: trailing whitespace.
> @page { margin: 1cm }
> warning: 1 line adds whitespace errors.

aah, good catch Lucas, i'll correct the patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:52:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:52:54 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-WOxKmHXDL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100719|0                           |1
        is obsolete|                            |

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100836&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 00:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2020 23:54:42 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-vzRB7Na4vs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100836|0                           |1
        is obsolete|                            |

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100838&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 01:51:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 00:51:53 +0000
Subject: [Koha-bugs] [Bug 24886] New: Reindent reports template
Message-ID: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

            Bug ID: 24886
           Summary: Reindent reports template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I propose to reformat the reports template (guided_reports_start.tt) so that it
has consistent spacing and indentation.

Let this bug race with Bug 24885

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 04:23:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 03:23:00 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-FRXihcv131@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100839&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields if no relationship (existing
guarantor data exists) and a guarantorid is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section of the memberentry.pl
page

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' section of memberentry.pl
pre-filled is the 'patron #' (borrowernumber), surname, firstname

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Searcg to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Libraries, NZ

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 04:23:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 03:23:38 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-2cHhz8wt45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
           Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 04:29:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 03:29:26 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-p0EKtkqtMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 04:30:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 03:30:48 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-gVctqNEagF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100840&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields if no relationship (existing
guarantor data exists) and a guarantorid is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section of the memberentry.pl
page

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' section of memberentry.pl
pre-filled is the 'patron #' (borrowernumber), surname, firstname

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Libraries, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 04:59:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 03:59:55 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-GQq4HxxhWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100840|0                           |1
        is obsolete|                            |

--- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100841&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields if no relationship (existing
guarantor data exists) and a guarantorid is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section of the memberentry.pl
page

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' section of memberentry.pl
pre-filled is the 'patron #' (borrowernumber), surname, firstname

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Libraries, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:16:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:16:10 +0000
Subject: [Koha-bugs] [Bug 24598] Hold not reset properly if checked out to
 another patron
In-Reply-To: <bug-24598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24598-70-9Ufb4yMwuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #1)
> This reads a bit similar to bug 11722, could these be duplicates?

Not sure.  That was 6 years ago.  This gives a better explanation, if it is.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:23:43 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-dnovi6613W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
This could be resolved in a combination of ways.  One way would be to send an
e-mail to specific addresses when the hold is cancelled.  Another would be to
have an alert on the staff screen, along with the moderation alerts.

It should give several pieces of information about the item, the patron it was
on hold for, when it was placed on hold, when it was to expire, and when it was
cancelled.  Most of this information is for tracking the item down, depending
on how the library shelved it.

I am for having a way for the patron to cancel the hold.  And I don't think it
is optics.  Before, if the hold was cancelled, it was on the hold shelf and
just sat there.  That was the optics.  Here, if staff are notified in some way,
it moves back into circulation faster.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:31:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:31:03 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-sFEUy2l04m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #8)
> This patch works as expected, but there is a little catch: For libraries,
> that have used this field to add information that is patron privacy relevant
> (like the name of someone), this change might be problematic. I have seen
> this happening, as the field will show up on checkout/checkin in a prominent
> way. (When returned, hand over to X next or something like that).
> 
> Even when the materials column is hidden, it's still fully visible in the
> source code.
> 
> Would it be possible not to pass it to the template if the column
> configuration is set to not display it?

Is it fair to withhold this functionality because some might be using it for
something it wasn't intended for?  How many other fields are used in a similar
fashion?  I can understand this caution on a field that was meant to hold
sensitive information, but I am not sure about this one.  Maybe it could be
suppressed with column configuration, but unless we treat other fields the same
way, this suppression might get lost in future upgrades because it doesn't
coincide with other column practices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:52:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:52:17 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-c0be0sENwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:52:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:52:37 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-42I2J1gs0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100842&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section of the memberentry.pl
page

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' section of memberentry.pl
pre-filled is the 'patron #' (borrowernumber), surname, firstname

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Libraries, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:56:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:56:00 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-8bI4tBo8Ge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
  Change sponsored?|---                         |Sponsored
            Version|18.11                       |master

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi all, 

I have replicated the bug behaviour George mentioned in comment #1 on master.
Which is slightly different to what Kelly mentioned in 'Description'.

Currently in master if you 'Add guarantee' from Adult's patron form then the
guarantor/adults details are not pre-filled in the 'Guarantor information'
section of memberentry.pl

I've written a patch fix to solve that. 

Please have a test and let me know how you get on.

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:56:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:56:58 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-cRtZXA92dN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 05:57:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 04:57:03 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-0Y3z738AU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100817|0                           |1
        is obsolete|                            |

--- Comment #179 from David Nind <david at davidnind.com> ---
Created attachment 100843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100843&action=edit
Bug 11879: Add a new field to patron record: main contact method

Fixed the problem mentioned above.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 06:56:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 05:56:18 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-KRx8X6vVzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100844&action=edit
Bug 23808: Added missing filter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 07:55:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 06:55:42 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-b11QnLFpxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 07:55:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 06:55:51 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-YBCPQ0CSeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100844|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 07:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 06:56:57 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-fauAstHQON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100845&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the
guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of
memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 07:57:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 06:57:25 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-MRxcvPBRXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Sorry for the noise on this ticket with the patch fixes. I think it's finally
ready to test :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:00:19 +0000
Subject: [Koha-bugs] [Bug 5103] Dates in MARC details not formatted correctly
In-Reply-To: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5103-70-t3ZkW3cCFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes how dates are
      release notes|                            |displayed for the list of
                   |                            |items on the MARC view
                   |                            |pages (in the OPAC and
                   |                            |staff interface) and the
                   |                            |add item page (staff
                   |                            |interface) so that they use
                   |                            |the 'dateformat' system
                   |                            |preference.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:05:05 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-BhadoCFSUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher,

I am not withholding anything - I've not set this to Failed QA even. Only
checking if we might be able to fix it in an easy way before we push this.

The problem is, we only have one field right now that is not visible in the
OPAC and shows up on checkin/circulation - so I wouldn't blame anyone using it
for different purposes. I won't block this, but I felt it was worth asking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:07:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:07:21 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-BceFJZSCMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Lucas! Can this be set to signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:09:55 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-abVWx18CR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:49:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:49:45 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-qy1O7gg3Y7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100797|0                           |1
        is obsolete|                            |

--- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100846&action=edit
Bug 23590: Fix select manager on list for all tabs

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:49:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:49:48 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-KQvx5DEEwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100798|0                           |1
        is obsolete|                            |

--- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100847&action=edit
Bug 23590: DBIC Changes

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:49:52 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-KdEdkFdBFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100799|0                           |1
        is obsolete|                            |

--- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100848&action=edit
Bug 23590: (QA follow-up) Add missing filters and drop script type

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:49:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:49:56 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-CQDNpyFE16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100800|0                           |1
        is obsolete|                            |

--- Comment #96 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100849&action=edit
Bug 23590: (QA follow-up) Fix some problems created by recent changes and
updatedatabase statement

- Ensure that the sequence of columns will be the same for new
  and updated installations (add AFTER ...)
- Fix permissions (see bug 22868)
- Fix column configuration (see 16784)
- Remove '- ' displying before the date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:50:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:50:00 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-H0VoswyY3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100801|0                           |1
        is obsolete|                            |

--- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100850&action=edit
Bug 23590: remove unused variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:50:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:50:04 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-4JTk1uR6WW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100802|0                           |1
        is obsolete|                            |

--- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100851&action=edit
Bug 23590: Update new fields with relevant values

We are filling lastmodificationdate and lastmodificationby depending on
the max dates between manageddate, accepteddate and rejecteddate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:50:08 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-gc827NWHeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100803|0                           |1
        is obsolete|                            |

--- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100852&action=edit
Bug 23590: Fix ergonomic issue if last modification by is empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:50:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:50:12 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-Z7I7GU2DCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100804|0                           |1
        is obsolete|                            |

--- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100853&action=edit
Bug 23590: Create a separate template notice NOTIFY_MANAGER

To separate the two feature we want to create a distinct template
notice.
A new NOTIFY_MANAGER notice is added.
A follow-up patch will be added for other languages, when this one will
be approved by QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:50:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:50:44 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-A86GDEM6HM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #101 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #92)
> Almost there - thx for the work on the notice.
> 
> 1) I think this slipped in from another feature in the tree (22784):
> 
> +                            <label for="archived" style="display:
> inline;">Include archived:</label>
> +                            <input type="checkbox" id="archived"
> name="filter_archived" value="archived" title="Include archived suggestions
> in the search" />
> +                      </li>
> +                      <li>

Oops, fixed.

> 2) From comment#91
> 
> > > 1) When I change the manager, the lastmodification* are not updated.
> > 
> > That was expected (I think). The field lastmodification* are only updated
> > when the suggestion is edited via the edit form. If we want to update it
> > whenever the table is updated, the change must be moved to ModSuggestion.
> > 
> > Séverine, can you confirm the behavior you expect?
> 
> Still waiting for an answer here, but I think we could fix that on a
> follow-up if needed. The change will be minor compared to the work needed to
> keep this patchset up-to-date with master.
> --
> 
> This one is confusing to me and I keep wondering if this should have been
> more than one bug :) So at the moment, in suggestions we got:
> 
>   `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update
> CURRENT_TIMESTAMP,  -- date and time the suggestion was updated
> 
>    lastmodificationby INT(11) default NULL, -- borrowernumber for the
> librarian who edit the suggestion for the last time
>    lastmodificationdate date default NULL, -- date of the last modification
> 
> So date is actually always updated and should probably be renamed 'datetime'
> or similar. What is the use case for the additional lastmodificationdate?
> From the description it's not clear to me. Do we really need it if we have
> date?

suggestions.date must be renamed timestamp, I agree with that. I can commit on
renaming it on a separate bug report.

The lastmodificationdate is the date when lastmodificationby has been updated.
And they are updated when a suggestion is modified, explicitly from the UI.
It's not set when the suggestion is created, but only when modified.
Also not updated when the status is set to ORDERED, for instance.
As said early, one advantage is also to follow the same pattern of the 4
existing fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:38 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-C6dayQ4XLs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100806|0                           |1
        is obsolete|                            |
 Attachment #100807|0                           |1
        is obsolete|                            |
 Attachment #100808|0                           |1
        is obsolete|                            |
 Attachment #100809|0                           |1
        is obsolete|                            |
 Attachment #100810|0                           |1
        is obsolete|                            |
 Attachment #100811|0                           |1
        is obsolete|                            |

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100854&action=edit
Bug 22784: DB Changes

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:42 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-oGYeW9f9f6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100855&action=edit
Bug 22784: DBIC Changes

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:45 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-UFRP3ZiKRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100856&action=edit
Bug 22784: Add the ability to archive/unarchive a purchase suggestions

There are performance issues when searching suggestions if there are
thousands of suggestions.
To prevent that we are going to add the ability to archive purchase
suggestions, in order to remove them from the search list (by default).

Test plan:
0. Apply all the patches, execute the updatedatabase.pl script, restart
all
1. Create some suggestions
2. Search for them
3. Use the "Archive" action button for one of them
4. Restart the search
=> The archived suggestion does no longer appear in the list
5. Use the filter "Included archived" in the "Suggestion information"
filter box
=> The archived suggestion is now displayed
6. Use other filters
=> The "archived" filter is kept from one search to another
7. Use one of the action at the bottom of the suggestion list (change
the status for instance)
=> The "archived" filter is still kept

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:49 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-6gKbIlzpRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100857&action=edit
Bug 22784: Bugfix - do not modify #description build Debian packages from a git
repository

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:53 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-mlFJJlMue2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100858&action=edit
Bug 22784: Do not display an empty table

This is terrible and highlight that the whole script must be rewrite.
GetDistinctValues does not handle the "archived" flag (and we do not
want to put our hands there), so let's hack that and plan to rewrite the
whole script.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 08:57:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 07:57:57 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-O1dwEAG2TX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100859&action=edit
Bug 22784: Add a cronjob to archive suggestions given age or status criteria

In order to deal automatically with suggestions that need to be
archived, this cronjob will help to add the "archived" flag following
their age or status.

Test plan:
- Execute the script with the --help parameter and read the documentation.
- Does it make sense?
- Use it without the --confirm flag and try several combination

For instance you will want to archive suggestions that have been
rejected for more than a week:
  perl misc/cronjobs/archive_purchase_suggestions.pl
  --age-date-field=rejecteddate --age=weeks:1

or even suggestion that have been suggested for more than a year and
have a ORDERED status:
  perl misc/cronjobs/archive_purchase_suggestions.pl
  --age-date-field=suggesteddate --age=years:1 --status=ORDERED

- Use it with the --confirm flag and make sure the suggestions have been
archived.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:01:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 08:01:14 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-yF9dm436ZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Lucas Gass from comment #8)
> Jonathan, no errors. This makes Circulation.t pass all tests. TY.

I do not understand what happened here.

What are the failing tests this patch fixed? It's not supposed to fix the
failures you reported on comment 3.

If other tests are fixed we need to have the patch into master as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 08:04:54 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-ervrSuIiT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100860&action=edit
Bug 24722: Same change for old_reserves.priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:05:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 08:05:17 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-2AeJoUpqte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #10)
> This seems ok. Only wondering: should we be changing old_reserves as well?
> The table still has:
>   `priority` smallint(6) default NULL, -- where in the queue the patron sits

Yes of course, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:13:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 08:13:14 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-PAa5eCGpAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha, double check your patch, you have "1=" instead of "!="

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:29:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 08:29:48 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-guUEOE0W1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Hayley Mapley from comment #10)
> When I follow the test plan backporting for 18.11.x, I get to step 3
> (without having applied the patch) and the claim does not go through and I
> get a warning 'This vendor has no email'.
> 
> If I've missed something let me know, otherwise not backporting this one to
> 18.11.x

Indeed, you must fill an invalid aqbooksellers.bookselleremail value, which is
not used anywhere. I remember I got that error with the data generated by
reset_all, maybe it does not appear in real life.
There is a case that is not taken into account anyway, and I feel like it's
safer to have the patch. Do not backport it if you are not confident however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:19 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-g3qmOY6qBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:22 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-PlhCXlY0kO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100861&action=edit
Bug 18177: remove aqbooksellers.othersupplier

This patchset removes some columns from the aqbooksellers table that are
not used:
 * booksellerfax
 * booksellerurl
 * bookselleremail
 * currency

The first 3 ones are certainly leftover from bug 10402.

Test plan:
For each for these fields you will make sure that they cannot be edited
from the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:25 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-qnZthLtN58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100862&action=edit
Bug 18177: remove aqbooksellers.booksellerfax

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:28 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-Lyja7V6uTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100863&action=edit
Bug 18177: remove aqbooksellers.booksellerurl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:32 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-ZWdyE2ifOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100864&action=edit
Bug 18177: remove aqbooksellers.bookselleremail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:35 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-2FFPbyKNxv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100865&action=edit
Bug 18177: remove aqbooksellers.currency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:38 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-TseDivBGK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100866&action=edit
Bug 18177: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:00:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:00:41 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-7CjgMf9Sic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100867&action=edit
Bug 18177: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:01:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:01:52 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-ldrZuR7NkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100861|0                           |1
        is obsolete|                            |
 Attachment #100862|0                           |1
        is obsolete|                            |
 Attachment #100863|0                           |1
        is obsolete|                            |
 Attachment #100864|0                           |1
        is obsolete|                            |
 Attachment #100865|0                           |1
        is obsolete|                            |
 Attachment #100866|0                           |1
        is obsolete|                            |
 Attachment #100867|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100868&action=edit
Bug 18177: remove aqbooksellers.othersupplier

This patchset removes some columns from the aqbooksellers table that are
not used:
 * booksellerfax
 * booksellerurl
 * bookselleremail
 * othersupplier
 * currency

The first 3 ones are certainly leftover from bug 10402.

Test plan:
For each for these fields you will make sure that they cannot be edited
from the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:01:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:01:56 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-YoC0RJlAji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100869&action=edit
Bug 18177: remove aqbooksellers.booksellerfax

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:01:59 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-KvbbzXfSSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100870&action=edit
Bug 18177: remove aqbooksellers.booksellerurl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:02:02 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-l9KNpPPD8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100871&action=edit
Bug 18177: remove aqbooksellers.bookselleremail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:02:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:02:05 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-LzkM6f7u7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100872&action=edit
Bug 18177: remove aqbooksellers.currency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:02:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:02:08 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-O8b90o0iUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100873&action=edit
Bug 18177: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:02:12 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-VS6XmAmxmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100874&action=edit
Bug 18177: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:03:30 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-9KMVka3bCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The 4 fields address[1-4] are built from the "Physical address" input.
However, if the address entered has more than 4 lines, the following ones are
dropped.
That is for a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:04:53 +0000
Subject: [Koha-bugs] [Bug 21126] Vendor Physical address: Interface fields
 does not correspond to db colums
In-Reply-To: <bug-21126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21126-70-1E6mQdWmbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21126

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 15272 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:04:53 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-CFprdZbNTf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 21126 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:05:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:05:02 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-XS1yMk6mk2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15272

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:05:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:05:02 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-B8d6y20i0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18177

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:11:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:11:56 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-6rooXA6WSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:57:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:57:46 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-YZt5a6mJhO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:57:49 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-1GDA5CZnc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100875&action=edit
Bug 15272: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:57:52 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-ppsxExlZBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100876&action=edit
Bug 15272: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:57:55 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-3GXhc70xIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100877&action=edit
Bug 15272: Merge aqbooksellers addressX columns

The physical address of a vendor is stored in 4 different DB columns:
address1, address2, address3 and address4
The are concatenated and split for storage/display purpose.

If you enter an address on more than 4 lines, the other lines are
truncated: data loss

To avoid such weird behavior, we could simplify the code and get more
flexibility (like address as long as you wish) merging those 4 columns
into 1, address

Test plan:
0. Do not apply the patches
1. Create a vendor and enter more than 4 lines in the physical address,
save
=> Notice that the lines has been stored in the 4 columns, and that you
lost the end of the address
2. Apply the patches and execute the updatedatabase script
3. Edit the vendor's address
=> Notice that the address is displayed correctly
4. Add more lines, save
=> Notice that the extra lines are kept
5. Generate a ACQCLAIM or ACQORDER notice for this vendor
=> Confirm that the address is displayed correctly in the generated
notice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:57:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:57:59 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-mLxHcEGMx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100878&action=edit
Bug 15272: Update notice templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:58:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:58:02 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-kCGwAr0PFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100879&action=edit
Bug 15272: Update notice templates for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:58:52 +0000
Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into
 "physical address" field
In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15272-70-I9ni7tvKyA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18177
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18177                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177
[Bug 18177] Many unused columns in aqbooksellers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 09:58:52 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-JJ0RIYwwlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15272
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15272                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272
[Bug 15272] aqbookseller addresses are combined into "physical address" field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:10:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:10:37 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-TN71K7N6r1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:10:40 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-4sjp4fHUx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98565|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100880&action=edit
Bug 4985: Edit a calendar entry for all branches

This patch adds functionality to calendar tool to
make edits or deletes to all branches at once.

To test:
-Apply patch
-Add holiday for a library and copy it to all or some
libraries
-Edit previosly made holiday (edit, delete etc.) and
check out "Copy changes to all libraries." checkbox
=> Changes are made to all libraries sharing changed
holiday

Sponsored by: Koha-Suomi Oy

Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:11:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:11:29 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-dMoiYlgYzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Signed Off

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Oops, did not see Katrin's comment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:14:23 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-1CdNjT5AfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #15)
> I am sorry, I have given this another test run, but I still have issues:
> 
> - Add 2 holidays as 'repeated holidays on a range'
> - Try to delete them using 'Delete the repeated holidays on a range.'
> - Holidays are not deleted
> 
> With the patch applied, I am not able to delete them.
> 
> Emmi, can you pleas re-check?

Confirmed. Everything else works great!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:23:43 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-5z2qPLZ3hj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100881&action=edit
Bug 24850: Always return 'instance' local time

This patch adds handling to ensure we always convert a passed in time to
the instance configured timezone..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:59:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 10:59:47 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-xaH67Owulo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61210|0                           |1
        is obsolete|                            |

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 100886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100886&action=edit
Bug 13345: Allow patrons to choose format on sending basket/list by email

It is already possible to download a basket(cart) or a list using
different format.
But by email, only iso2709 is possible.

This patch adds the ability to select a format for the file attached to
the email when sending the basket/list content.

Test plan:
1/ At the OPAC, add some records to your basket and send it by email
using different formats (RIS, BibTeX, MARC and the CSV profiles defined).
2/ At the OPAC, add some records to a list and send it by email using
the different formats.
3/ Redo step 1 at the intranet
4/ Redo step 2 at the intranet

Note that subtitles are not displayed in all these cases.

Note for QA: This patch refactors 3 main things:
1/ Template side: the dropdown list to select the format is now in an
include file (indeed, this list is used in 4 templates, this will make
easier further changes).
The include files are named 'download-export-available-formats.inc',
feel free to suggest something better.
The are used in:
[opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and
[opac-]downloadshelf.tt.

2/ Build records data and the records file
This job was done in 4 scripts:
 - opac/opac-sendbasket.pl
 - opac/opac-sendshelf.pl
 - basket/sendbasket.pl
 - virtualshelves/sendshelf.pl
Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are
provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t
Not that a similar job is done in [opac-]downloadcart.pl and
[opac-]downloadshelf.pl

3/ Build the subject and body of the email sent
Same as before, the job was done at the same places.
Now it's done in Koha::Email->fill_body_for_sending (feel free to
suggestion a better name) and tests are provided in t/Koha_Email.t

Sponsored-by: Mines Paristech
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:00:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:00:51 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-qhYRlTPr36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:18:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:18:22 +0000
Subject: [Koha-bugs] [Bug 24853] Add more Accounting type system preferences
 in this tab
In-Reply-To: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24853-70-tvM9JVbIhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24853

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a tab in system         |Add more Accounting type
                   |preferences for accounting  |system preferences in this
                   |                            |tab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:19:09 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-sHe7PsQltK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:19:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:19:12 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-pFXJuzHWcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100682|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100887&action=edit
Bug 23236: Remove 'its items may still be processed' in action if no match is
found

When importing records and looking for duplicate records using record matching
rules,
there is an option if NO match is found to "ignore incoming record (its items
may
still be processed)". This doesn't make any sense. Where would the items go if
there
is no match?

To test:
1) Go to Tools > Stage MARC for import
2) Browse and choose a file with at least one record that is not already in
your
catalog and click on Upload file
3) Fill out the first section with the appropriate information
4) In the Look for existing records in catalog? section, choose a record
matching
rule
5) In the Action if no match is found drop-down menu, choose Ignore incoming
record
(its items may still be processed)
6) Click on Stage for import
7) Click on Manage staged records
8) Click Import this batch in the catalog
9) In the table, the record status should say Ignore
10) Apply patch
11) Redo steps 1-9, notice the option Ignore incoming records does not mention
items
12) Make sure the tool still works and still ignores the record

Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:19:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:19:43 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-mTE08PJdSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
           Severity|enhancement                 |trivial
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:46:48 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-PSDeuWkmvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:48:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:48:54 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-ZVNsId4yUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100888&action=edit
Bug 24172: Move duplicated code to an include file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:55:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:55:31 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-p0BK84ZWmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I should have tested the patches before writing the follow-up.
I do not understand what is done here, why do we want to modify the value on
editing?
It means we are going to have "Winter" and "Hiver" at the same time in the DB?

The serial will be created with "Winter" before receiving, then "Hiver" once
they are received?
That does not seem correct to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:57:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:57:18 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-eMJMFYgg1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:59:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 11:59:11 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-5KJGsjJpPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|tomascohen at gmail.com        |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:05:06 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-xMUfUNCKLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #102 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Lately, we've been sticking to:

created_on
created_by
updated_on
updated_by

I understand this is not exactly the same as updated_on but...
lastmodificationdate? I would stick to updated_on and find something else for
the status change (e.g. status_updated_on)

My 2 cents

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:09:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:09:37 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-sRNah3fMaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #103 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would like to stick with the existing pattern:

`suggestedby` int(11) DEFAULT NULL,                                            
                                                                               
                                                   `suggesteddate` date NOT
NULL,                                                                          
                                                                               
                          `managedby` int(11) DEFAULT NULL,                    
                                                                               
                                                                            
`manageddate` date DEFAULT NULL,                                               
                                                                               
                                                   `acceptedby` int(11) DEFAULT
NULL,                                                                          
                                                                               
                      `accepteddate` date DEFAULT NULL,                        
                                                                               
                                                                        
`rejectedby` int(11) DEFAULT NULL,                                             
                                                                               
                                                   `rejecteddate` date DEFAULT
NULL,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:11:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:11:25 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-QPZZOSW7Pr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #104 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If they need to be reworded, they will be reworded on a follow-up bug report.
But all at once. I will do if requested.

Do not you think it's better than having 2 different patterns for the same
table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:13:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:13:01 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-yld34pcUBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #105 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #104)
> If they need to be reworded, they will be reworded on a follow-up bug
> report. But all at once. I will do if requested.
> 
> Do not you think it's better than having 2 different patterns for the same
> table?

I'm fine with doing it on a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:27:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:27:10 +0000
Subject: [Koha-bugs] [Bug 24836] (Optionally) Trigger
 MARC-Modification-Templates after record has been saved
In-Reply-To: <bug-24836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24836-70-EaQeTfYaaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9921
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:27:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:27:10 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-f8uf5YnlGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24836

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:56:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:56:02 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-LpB3Es9lYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24887


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24887
[Bug 24887] columns of suggestions need to be renamed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:56:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:56:02 +0000
Subject: [Koha-bugs] [Bug 24887] New: columns of suggestions need to be
 renamed
Message-ID: <bug-24887-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24887

            Bug ID: 24887
           Summary: columns of suggestions need to be renamed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23590

suggestedby          => suggested_by
suggesteddate        => suggested_on
managedby            => managed_by
manageddate          => managed_on
acceptedby           => accepted_by
accepteddate         => accepted_on
rejectedby           => rejected_by
rejecteddate         => rejected_on
lastmodificationby   => updated_by (from bug 23590)
lastmodificationdate => updated_on (from bug 23590)

And date must be renamed timestamp


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
[Bug 23590] Allow to modify and notify the manager of a suggestion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:56:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 12:56:26 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-Izc07v6NuM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #106 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have opened bug 24887.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:20:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:20:19 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-ERj8scejGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:20:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:20:22 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-u9iY7Pwq8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100845|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100889&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the
guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of
memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki Distict Council, NZ

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:26:50 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-iP5Wl5EF61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:26:54 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-R530gqDBxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100576|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100890&action=edit
Bug 22987: Add biblioimages.timestamp

This patch adds the timestamp column to the biblioimages table.
To test:
1. Apply this patch
2. Run:
   $ updatedatabase
   $ koha-mysql kohadev
   > SHOW CREATE TABLE biblioimages;
=> SUCCESS: Notice the new column is there with the right settings
3. Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:27:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:27:48 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-mTNnGlQFDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:28:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:28:18 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-yPpYo7vWX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:28:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:28:21 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-gdoRHm11Ln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99592|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100891&action=edit
Bug 24553: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:28:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:28:23 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-52dklemnU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99593|0                           |1
        is obsolete|                            |

--- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100892&action=edit
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron

The drop_hold routine was using the wrong parameter for item info in the
patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both
waiting and unavailable
holds

To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!

You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling
a hold
and check the messages, test coverage is improved by this patch and should be
sufficient
for testing

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 13:55:39 +0000
Subject: [Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
In-Reply-To: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23925-70-BQyrC8v2GC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"Illegal ISBN" will not be translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:08:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:08:14 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-3ImTuJ2Prm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:08:19 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-BAFXCyGebq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100755|0                           |1
        is obsolete|                            |

--- Comment #11 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 100893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100893&action=edit
Bug 22025: Add a regression test

Signed-off-by: Magnus Enger <magnus at libriotech.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:08:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:08:22 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-Yd6vqvpOaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100756|0                           |1
        is obsolete|                            |

--- Comment #12 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 100894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100894&action=edit
Bug 22025: Remove warnings when importing patrons

The following warning is raised when importing patrons
Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1018

if one of the following headers is passed but does not have a value:
 * privacy
 * privacy_guarantor_fines
 * privacy_guarantor_checkouts
 * anonymized

Test plan:
- Do not apply the patch
- Generated a csv file with at least one those headers
- Import it using the import_patrons.pl script (or using the GUI)
- Notice the warnings without the patch
- Apply the patch
- Confirm that the warnings do not longer appear

Signed-off-by: Magnus Enger <magnus at libriotech.no>
Applied the patch on a live server and the warnings went away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:12:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:12:18 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-uA5i3lokyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #13 from Magnus Enger <magnus at libriotech.no> ---
I do get a bunch of errors when I try to run the tests in kohadevbox, but that
might be caused by bad data in my instance? 

$ sudo koha-shell -c "prove t/db_dependent/Koha/Patrons/Import.t" kohadev
t/db_dependent/Koha/Patrons/Import.t .. 1/157 
#   Failed test 'Got the expected 0 size error array from import_patrons with
no matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 105.
#          got: '2'
#     expected: '0'

#   Failed test 'Got the expected second feedback from import_patrons with no
matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 111.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected last imported name from import_patrons with
no matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 112.
#          got: undef
#     expected: 'lastimported'

#   Failed test 'Got the expected second header row value from import_patrons
with no matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 113.
#                   undef
#     doesn't match '(?^u:^Nancy / \d+)'

#   Failed test 'Got the expected 1 imported result from import_patrons with no
matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 115.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 0 invalid result from import_patrons with no
matchpoint defined'
#   at t/db_dependent/Koha/Patrons/Import.t line 116.
#          got: '1'
#     expected: '0'

#   Failed test 'Got the expected 1000 card number from import patrons with
invalid card number'
#   at t/db_dependent/Koha/Patrons/Import.t line 130.
#          got: undef
#     expected: '1000'

#   Failed test 'Got the expected invalid card number from import patrons with
invalid card number'
#   at t/db_dependent/Koha/Patrons/Import.t line 131.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected 1 already_in_db from import_patrons with
duplicate userid'
#   at t/db_dependent/Koha/Patrons/Import.t line 150.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 0 invalid result from import_patrons'
#   at t/db_dependent/Koha/Patrons/Import.t line 159.
#          got: '1'
#     expected: '0'

#   Failed test 'Got the expected 0 invalid result from import_patrons'
#   at t/db_dependent/Koha/Patrons/Import.t line 180.
#          got: '1'
#     expected: '0'

#   Failed test 'Got the expected 1 overwritten result from import_patrons that
matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 181.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected duplicate userid error from import patrons
with duplicate userid'
#   at t/db_dependent/Koha/Patrons/Import.t line 193.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected userid error from import patrons with
duplicate userid'
#   at t/db_dependent/Koha/Patrons/Import.t line 194.
#          got: undef
#     expected: 'jjenkins0'
t/db_dependent/Koha/Patrons/Import.t .. 57/157 
#   Failed test 'Got the expected 0 size error array from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 220.
#          got: '2'
#     expected: '0'

#   Failed test 'Got the expected third feedback from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 230.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected last imported name from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 231.
#          got: undef
#     expected: 'lastimported'

#   Failed test 'Got the expected third feedback value from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 232.
#                   undef
#     doesn't match '(?^u:^Donna / \d+)'

#   Failed test 'Got the expected 1 imported result from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 234.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 0 invalid result from import_patrons with
extended user'
#   at t/db_dependent/Koha/Patrons/Import.t line 235.
#          got: '1'
#     expected: '0'

#   Failed test 'Got the expected 1 already_in_db from import_patrons with
extended user matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 240.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 0 size error array from import_patrons with
extended user matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 241.
#          got: '2'
#     expected: '0'

#   Failed test 'Got the expected already_in_db from import_patrons with
extended user matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 251.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected third feedback value from import_patrons with
extended user matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 252.
#                   undef
#     doesn't match '(?^u:^Donna / \d+)'

#   Failed test 'Got the expected 0 invalid result from import_patrons with
extended user matched'
#   at t/db_dependent/Koha/Patrons/Import.t line 255.
#          got: '1'
#     expected: '0'

#   Failed test 'Got the expected undef borrower number error from import
patrons for branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 282.
#          got: undef
#     expected: 'UNDEF'

#   Failed test 'Got the expected 1 branchmap error from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 283.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected branch code key from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 284.
#          got: undef
#     expected: 'branchcode'

#   Failed test 'Got the expected 4 line number error from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 285.
#          got: undef
#     expected: '4'

#   Failed test 'Got the expected lineraw error from import patrons for branch
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 286.
Wide character in print at /usr/share/perl5/Test2/Formatter/TAP.pm line 105,
<$handle_5> line 4.
#          got: undef
#     expected:
'1005,Chloé❤,Greene,Mr,Michael,RG,3,Avenue,Grim,Peoria,Jacksonville,Illinois,61614,United
States,mgreene5 at seesaa.net,3-(941)565-5752,1-(483)885-8138,4-(979)577-6908,02/09/1957,ZZZ,ST,04/02/2015,07/01/2015,mgreene5,or4ORT6JH
# '

#   Failed test 'Got the expected surname error from import patrons for branch
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 287.
Wide character in print at /usr/share/perl5/Test2/Formatter/TAP.pm line 105,
<$handle_5> line 4.
#          got: undef
#     expected: 'Chloé❤'

#   Failed test 'Got the expected ZZZ value error from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 288.
#          got: undef
#     expected: 'ZZZ'

#   Failed test 'Got the expected 1 feedback from import_patrons for branch
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 294.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected lastimported name from import_patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 295.
#          got: undef
#     expected: 'lastimported'

#   Failed test 'Got the expected last imported value from import_patrons with
for branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 296.
Wide character in print at /usr/share/perl5/Test2/Formatter/TAP.pm line 105,
<$handle_5> line 4.
#                   undef
#     doesn't match '(?^u:^Chloé❤ / \d+)'

#   Failed test 'Got the expected 1 imported result from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 298.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 2 invalid result from import patrons for
branch tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 299.
#          got: '3'
#     expected: '2'

#   Failed test 'Got the expected undef borrower number error from import
patrons for category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 323.
#          got: undef
#     expected: 'UNDEF'

#   Failed test 'Got the expected 1 category_map error from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 324.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected category code key from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 325.
#          got: undef
#     expected: 'categorycode'

#   Failed test 'Got the expected 4 line number error from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 326.
#          got: undef
#     expected: '4'

#   Failed test 'Got the expected lineraw error from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 327.
#          got: undef
#     expected: '1008,Emily,Richards,Ms,Judy,ER,73,Way,Kedzie,Fort
Wayne,Phoenix,Indiana,46825,United
States,jrichards8 at arstechnica.com,5-(266)658-8957,3-(550)500-9107,7-(816)675-9822,08/09/1984,FFL,ZZ,11/09/2014,07/01/2015,jrichards8,D5PvU6H2R
# '

#   Failed test 'Got the expected surname error from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 328.
#          got: undef
#     expected: 'Emily'

#   Failed test 'Got the expected ZZ value error from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 329.
#          got: undef
#     expected: 'ZZ'

#   Failed test 'Got the expected 1 feedback from import_patrons for category
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 335.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected lastimported name from import_patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 336.
#          got: undef
#     expected: 'lastimported'

#   Failed test 'Got the expected last imported value from import_patrons with
for category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 337.
#                   undef
#     doesn't match '(?^u:^Peter / \d+)'

#   Failed test 'Got the expected 1 imported result from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 339.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 2 invalid result from import patrons for
category tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 340.
#          got: '3'
#     expected: '2'

#   Failed test 'Got the expected 1 error array size from import_patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 356.
#          got: '3'
#     expected: '1'

#   Failed test 'Got the expected 3 missing critical errors from import_patrons
for dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 357.
#          got: '0'
#     expected: '3'

#   Failed test 'Got the expected 1 bad_date error from import patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 359.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected undef borrower number error from import
patrons for dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 360.
#          got: undef
#     expected: 'UNDEF'

#   Failed test 'Got the expected dateofbirth key from import patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 361.
#          got: undef
#     expected: 'dateofbirth'

#   Failed test 'Got the expected 2 line number error from import patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 362.
#          got: undef
#     expected: '3'

#   Failed test 'Got the expected lineraw error from import patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 363.
#          got: undef
#     expected:
'1010,Ralph,Warren,Ms,Linda,RW,6,Way,Barby,Orlando,Albany,Florida,32803,United
States,lwarrena at multiply.com,7-(579)753-7752,6-(847)086-7566,9-(122)729-8226,26/01/2001,LPL,T,25/01/2001,24/01/2001,lwarrena,tJ56RD4uV
# '

#   Failed test 'Got the expected surname error from import patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 364.
#          got: undef
#     expected: 'Ralph'

#   Failed test 'Got the expected dateenrolled key from import patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 366.
#          got: undef
#     expected: 'dateenrolled'

#   Failed test 'Got the expected dateexpiry key from import patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 367.
#          got: undef
#     expected: 'dateexpiry'

#   Failed test 'Got the expected 2 feedback from import patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 369.
#          got: '1'
#     expected: '2'

#   Failed test 'Got the expected 1 feedback from import_patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 374.
#          got: undef
#     expected: '1'

#   Failed test 'Got the expected lastimported from import_patrons for dates
tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 375.
#          got: undef
#     expected: 'lastimported'

#   Failed test 'Got the expected lastimported value from import_patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 376.
#                   undef
#     doesn't match '(?^u:^Christina / \d+)'

#   Failed test 'Got the expected 1 imported result from import patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 378.
#          got: '0'
#     expected: '1'

#   Failed test 'Got the expected 1 invalid result from import patrons for
dates tests'
#   at t/db_dependent/Koha/Patrons/Import.t line 379.
#          got: '2'
#     expected: '1'
t/db_dependent/Koha/Patrons/Import.t .. 149/157 # Looks like you failed 65
tests of 157.
t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 65 (wstat 16640,
0x4100)
Failed 65/157 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Patrons/Import.t (Wstat: 16640 Tests: 157 Failed: 65)
  Failed tests:  10, 14-18, 22-23, 30, 37, 46-47, 49-50
                58, 65-69, 71-72, 79-80, 82, 90-96, 100-104
                112-118, 122-126, 129-139, 143-147
  Non-zero exit status: 65
Files=1, Tests=157,  8 wallclock secs ( 0.04 usr  0.02 sys +  6.90 cusr  0.36
csys =  7.32 CPU)
Result: FAIL

The test added by the current patch changes this to "Failed 65/158 subtests",
so at least it seems the added test is passing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:17:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:17:02 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-FTDokwA8sy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Not a problem at all! Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:17:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:17:25 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-WKsk5kOyVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
<HoldItem><code>IllegalParameter</code><message>The parameter
pickup_expiry_date is illegal.</message></HoldItem>

Why do I get that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:17:42 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-IzZFaajmOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100895&action=edit
Bug 23531: Simplify tests using build_object

And build_sample_item.
Also remove a debug statement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:20:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:20:27 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-1Ag9hNno20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #24)
> <HoldItem><code>IllegalParameter</code><message>The parameter
> pickup_expiry_date is illegal.</message></HoldItem>
> 
> Why do I get that?

Ok, forget that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:23:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:23:09 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-gSoqZbprGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100294|0                           |1
        is obsolete|                            |
 Attachment #100295|0                           |1
        is obsolete|                            |
 Attachment #100895|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100896&action=edit
Bug 23531: fix ILSDI non-implemented but documented parameters

test plan :
1/ Submit a hold through ILSDI with start_date and expiry_date parameters
2/ Verify in Koha those parameters are not applied to the newly created
reserve. Delete reserve.
3/ Apply patch and repeat 1.
4/ Verify the reserve created by same request as 1 now has both dates
applied and visible in Koha.

Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com>

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:23:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:23:17 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-p0ZzhwMkM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100897&action=edit
Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:23:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:23:21 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-tM5AGljgeI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100898&action=edit
Bug 23531: Simplify tests using build_object

And build_sample_item.
Also remove a debug statement

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:23:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:23:46 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-tRzDPquNU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ILS-DI doesn't implement    |ILS-DI doesn't implement
                   |needed_before_date and      |needed_before_date and
                   |pickup_expiry_date          |pickup_expiry_date
                   |parameters                  |parameters (renamed
                   |                            |start_date and expiry_date)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:24:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:24:18 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-yoIthPRUsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Not sure why we do not pick reserve_date here, but ok for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:25:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:25:07 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-7b8EWZUQ30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:25:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:25:10 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-uJhQKT1AlL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100714|0                           |1
        is obsolete|                            |

--- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100899&action=edit
Bug 24848: Improve manual links for the label creator

Some of the manual links in the label creator tool were
not working correctly or pointing to the wrong pages.

A problem is the label-manage.pl file. This can show
different data depending on an added parameter. Example:
/cgi-bin/koha/labels/label-manage.pl?label_element=template

But it appears that parameters will be ignored when creating
links to the manual. So this patch links to the beginning
of the label creator section in the manual for now.

To test:
- Go to the lable creator
- Try the various pages of the tool
  - Note: All 'New ...' links should point to the
    correct section in the manual (batches, templates, ...)
    Except: Barcode range. This feature is new and not
    yet documented in the manual. Link goes to label creator section.
  - Note: All 'Manage ...' links should point to the
    beginning of the 'label creator' section in the manual

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:36:30 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-EUvgC1o74L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #130 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I'd say you should not call DelItem directly, but DelItemCheck instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:40:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:40:33 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-8J7ckw6nu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100889|0                           |1
        is obsolete|                            |

--- Comment #11 from George Veranis <gveranis at dataly.gr> ---
Created attachment 100900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100900&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the
guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of
memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki District Council, NZ

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: George Veranis <gveranis at dataly.gr>
Followed the test plan, works as expected. The only failure was
t/DateUtils.t test which will be fixed by Bug 24850.
Also corrected a small typo in the sponsored-by trailer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:44:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:44:26 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-jBJawhForC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Sorry Jonathan,

It fixes Circulation.t tests for me, the problems in comment 3 were my own
problem. I wrongly assumed this one was for [19.05.x] only so I pushed to that
branch.

I will revert.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:45:43 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-6o2aHXZ621@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #131 from Maryse Simard <maryse.simard at inlibro.com> ---
(In reply to Jonathan Druart from comment #130)
> I'd say you should not call DelItem directly, but DelItemCheck instead.

This is what has been done in the follow up patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:46:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:46:10 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-NTOlXlb6vz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's much more than "hide"/"show". I think we should rename the pref and update
its description to explain a bit more this new enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:50:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:50:38 +0000
Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from
 moredetail.pl or additem.pl
In-Reply-To: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24279-70-6N1MnjdVzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:52:27 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-YTUgm9qHCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100678|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100901&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:52:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:52:30 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-mY3Hs4yEYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100679|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100902&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:52:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:52:34 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-MqyAYwWdsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100680|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100903&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:52:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:52:37 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-gafWLdw9jU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100681|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100904&action=edit
Bug 24850: Don't fallback when date_format is passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:52:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:52:40 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-EDQLze5q1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100881|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100905&action=edit
Bug 24850: Always return 'instance' local time

This patch adds handling to ensure we always convert a passed in time to
the instance configured timezone..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:54:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:54:57 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-eLVueQFs9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24850


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850
[Bug 24850] Koha::DateUtils ignored offsets in RFC3339 datetimes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:54:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 14:54:57 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-BtxZDHnmHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608
[Bug 24608] Allow modification of checkout due date
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:04:53 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-1gtPwC5iyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've been digging here..

dt_from_string did indeed ignore offsets which is bad.. but it also assumed a
timezone that matches the configured instance timezone rather than respecting
the 'Z' or '+0000' to mean 'UTC'.

As such.. whatever you passed in via the API would be stored 'as is', as a
string with an assumed offset matching your instances configured timezone.

This patchset uses the js date function .toISOString which always returns a
zero offset UTC string (and compensates for local timezone of the browser so
our widget which returns a string of local time results in a date object with
the local offset and as such when the ISO call is called above the offset is
applied to get UTC time).

I've now updated bug 24850 to handle rfc3339 dates correctly and to always
localise as to the instance config time for the output datetime object.. this
will mean that if we pass in a rfc3339 string with or without an offset the
resulting datetime will get properly localised to the instance time with the
difference in offsets applied.

I believe this will resolve the issue face by Jonathan but would like to see
some tests using hourly loans.  I think for a realistic case we should be
setting instance time and browser locale to match.. I don't believe it's a fair
case work with multiple timezones for a single library branch.. or is it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:16:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:16:50 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-pZpBU71TsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:16:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:16:58 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-4NCrR2uyp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99944|0                           |1
        is obsolete|                            |
  Attachment #99945|0                           |1
        is obsolete|                            |

--- Comment #132 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100906&action=edit
Bug 17674: Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Test plan :
- Apply patch.
- Create at least four serials with items.
- Notice that new items have a numbering pattern and a date in the enumchron
field.
- Use the button Delete selected issues for the following steps.
- Delete a serial and its associated item.
- Confirm the serial and item are gone.
- Delete a serial and not its item.
- Confirm the serial is gone.
- Confirm the item is still there and the date part in the enumchron field is
gone.
- Delete the two lasts serials.
- Confirm they are gone.

Sponsored by : CCSR

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: sonia <sonia.bouis at univ-lyon3.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:17:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:17:05 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-JrBAJpJtC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #133 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100907&action=edit
Bug 17674: Handling of special cases

This patch adds handling for those 2 particular cases:
1. Deleting the expected issue
2. Deleting a serial and it's item, but one item cannot be deleted

To test:

1.1 Create a subscription that creates items
1.2 Receive two issues
1.3 Use the new button to delete the 'Expected' issue
1.4 The issue is correctly deleted, but the new expected issue created
to replace the one which has been deleted don't have a published or
received date and is show in it's own tab.
1.5 Apply patch
1.6 Repeat steps 1.1 through 1.4
    => The new expected issue is created correctly

2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2
2.2 Check out one of the items
2.3 Delete the corresponding serial and check box to delete items
2.4 The serial is deleted, but not the item.
    => No feedback is show to the user
2.5 Apply patch
2.6 Repeat step 2.1 through 2.4
    => As before, the serial is deleted, but not the item
    => This time, an error is shown to inform the user

Signed-off-by: sonia <sonia.bouis at univ-lyon3.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:17:35 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-e6jdN1hvEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #134 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Maryse Simard from comment #131)
> (In reply to Jonathan Druart from comment #130)
> > I'd say you should not call DelItem directly, but DelItemCheck instead.
> 
> This is what has been done in the follow up patch.

Indeed! I forgot to squash before reviewing them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:24:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:24:22 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-FNm73xL9FR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96213|0                           |1
        is obsolete|                            |

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100908&action=edit
Bug 13775: Set main headings to mandatory in authority frameworks

For MARC21 we need to set the following tags as mandatory:
  CHRON_TERM => 148
  CORPO_NAME => 110
  GENRE/FORM => 155
  GEOGR_NAME => 151
  MEETI_NAME => 111
  PERSO_NAME => 100
  TOPIC_TERM => 150
  UNIF_TITLE => 130

Note that it also fixes an error on the UI, which was initially reported
on bug 13775.

Test plan:
- Create a fresh install in the language of your choice.
- Confirm that when you create a new authority you cannot save without
entering a value for the main heading

- Edit marc record's field 648 -> chronological term
- Try to add there one by clicking a link on the left side of the field.
>From there it opens me to a new window, click "Create a new authority"
Click on the authority creating fields randomly, save.
=> Without this patch an error occurred "Can't call method "subfields"
on an undefined value at authorities/blinddetail-biblio-search.pl line 88."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed conflict in english version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:24:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:24:26 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-WwMPerLEsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96214|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100909&action=edit
Bug 13775: Set main headings to mandatory in authority frameworks (UNIMARC)

Same as previously, for UNNIMARC

For unimarc_complet:
CLASS => 245
CO => 210
CO_UNI_TI => 235
EXP => 232
FAM => 220
GENRE/FORM => 280
NAME_COL => 245
NP => 200
NTEXP => 242
NTWORK => 241
PA => 260
PERS => 223
PUB => 217
SAUTTIT => 240
SNC => 250
SNG => 215
TM => 216
TU => 230
WORK => 231

For unimarc_lecture_pub:
CO => 210
NP => 200
SAUT => 200
SAUTTIT => 240
SCO => 210
SNC => 250
SNG => 215
STU => 230
TU => 230

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:24:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:24:47 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-LNUPjp04lx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:25:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:25:26 +0000
Subject: [Koha-bugs] [Bug 24620] Existing transfers not closed when hold is
 set to waiting
In-Reply-To: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24620-70-n5oiVeMl3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Nick Clemens from comment #10)
> > (In reply to Jonathan Druart from comment #9)
> > > What if branchtransfers.tobranch is not the logged in user's library?
> > 
> > Then $transferToDo should be true and the code should not be called
> 
> circ/branchtransfers.pl
> 102     ModReserveAffect( $item, $borrowernumber );

see bug 24839 - that code is intended to allow the transfer of a waiting hold -
so cancelling when setting to waiting doesn't affect that workflow (that
workflow may be problematic on its own) - the hold is set waiting, active
transfers closed, then a new transfer generated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:36:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:36:53 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-eB8efviXeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:36:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:36:56 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-5d4QGPdUvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100720|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100910&action=edit
Bug 24875: Remove extra punctuation from tools start page

The patron clubs note was ending with .., but patch also removed
some single . to be consistent with the majority of entries on the
tools page.

To test:
- Check the tools start page for ending . in the notes
- Apply patch
- Verify the punctuation is now consistent

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:41:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:41:02 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-5okc93KvIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23427
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427
[Bug 23427] Better sorting of previous checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:41:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:41:02 +0000
Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts
In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23427-70-mVBuGGfLvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456
[Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder
sort incorrectly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:42:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:42:06 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-DFf4fpdVc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:42:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:42:09 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-fuRjL4wYZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98103|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100911&action=edit
Bug 24456: change default sort orders/make wording clearer

TEST PLAN:
1. Apply patch
2. Have some checkout from today and some from multiple previous days.
3. Set  todaysIssuesDefaultSortOrder &  previousIssuesDefaultSortOrder to
'earliest to latest' and confirm it sorts correctly.
4. Reverse the 2 system preferences and see that it is now sorting the opposite
way.
5. Also look at the wording of each system prefence and make sure it makes
sense

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:48:56 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-1jS2hg91ir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not we also update items.onloan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:50:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:50:35 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-7n8w7H8Hm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|martin.renvoize at ptfs-europe |jonathan.druart at bugs.koha-c
                   |.com                        |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:57:19 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-sJwyuMYcxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:57:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:57:22 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-qsB9YAYM92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99046|0                           |1
        is obsolete|                            |
  Attachment #99381|0                           |1
        is obsolete|                            |
 Attachment #100193|0                           |1
        is obsolete|                            |

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100912&action=edit
Bug 22774: New systempreferences for suggestions added to sysprefs.sql

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:57:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 15:57:26 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-GTx9xNuWdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100913&action=edit
Bug 22774: Limit Purchase Suggestion in a specified Time period

Test plan:
 1 - Apply this patch
 2 - Run updatedatabase.pl
 3 - By default the preferences are blank and do not limit.
 4 - Set the limits to 3 in 30 days
 5 - Go to purchase suggestion page from OPAC as a logged in patron
 6 - Place 3 suggestions and confirm you cannot place any more
 7 - Alter one of the suggestions to have been made more than 30 days ago
    UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3;
 8 - Confirm you can place another suggestion
 9 - Log out of OPAC
10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set
11 - Confirm anonymous suggestions are not limited by the syspref
12 - Confirm that a blank value in either  MaxTotalSuggestions  or 
NumberOfSuggestionDays  does not limit suggestions

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:00:17 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-hEejt5EelY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100753|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100914&action=edit
Bug 24846: Add new tool to batch extend due dates

With events sometimes leading to unforeseen branch closures (think Coronavirus
as
an example), it would be helpful to have a tool that would allow librarians to
update due dates in bulk based on branch and current due date of the material.

It allows to select checkouts given the following parameters:
 * libraries
 * patron's categories
 * range of the due date

You can set a hard due date, or define a number of days to extend the
due date.

Test plan:
Check some items out
Use the new tool to extend the due dates
Test the different filters to make sure they all work

Note: What about holidays?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:00:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:00:21 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-S1UL9kNQGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100915&action=edit
Bug 24846: Update items.onloan with the new due date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:00:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:00:37 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-5XMTUTXDlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:00:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:00:40 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-lsZwLTPkBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100277|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100916&action=edit
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs

Use of patron-title.inc on the checkin page is inconsistent, resulting
in patron names being displayed differently under different
circumstances. This patch makes it more consistent.

To test, apply the patch and check in items with the following statuses:

 - On hold for a patron at your library
 - On hold for a patron not at your library
 - On hold and already marked 'Waiting'
 - On hold while HoldsAutoFill preference is enabled
 - An item which has been marked with a LOST status in the
   'ClaimReturnedLostValue' system preference.
 - An item which was checked out to a manually-restricted patron and
   checked in with a back-dated checkin date. See test plan on Bug
   24776.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:02:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:02:52 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-e2ORtOokx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |didier.gautheron at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:04:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:04:05 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-L7lpb3bIsE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:32:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:32:41 +0000
Subject: [Koha-bugs] [Bug 5695] Cart display should show proper item type
In-Reply-To: <bug-5695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5695-70-uAEgmw4WtM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5695

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #3)
> Maybe it should be configurable? In consortia
> there might be too many items on records to make this work nicely

 XSLTCartDisplay ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:58:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:58:46 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-js3T8tBrU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:58:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 16:58:49 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-qKeovEYQrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100616|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100917&action=edit
Bug 24856: Remove itemtypes.imageurl in fr-FR sample data

in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and
installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of
imageurl point to non-existent images.

Test plan:
Insert the 2 sql file and confirm that imageurl is not empty

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
I confirm that imageurl IS empty
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:09:27 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-HLRvDWBzDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |a.roussos at dataly.gr

--- Comment #12 from Andreas Roussos <a.roussos at dataly.gr> ---
Would it make sense to reword the somewhat ambiguous "Patron #:" bit to read
"Patron card number:" and also change the hyperlink to print the card number
instead of the borrowernumber (leaving the link destination pointing to the
borrowernumber)? From the point of view that it makes more sense for a Staff
Interface user to view patrons' card numbers instead of a borrowernumber which
is just a primary key in the DB and conveys little meaning to a regular user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:15:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:15:41 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-i5O20TPydB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82558|0                           |1
        is obsolete|                            |

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100918&action=edit
Bug 21865: improve remove_unused_authorities.pl script

remove_unused_authorities.pl script can be improved.

This patch changes changes verbosity so than test mode can be used
to know the autorities that are used and those that can be deleted.
It also writes a line in output if limited authority type(s).

This patch also removes the unused vars $thresholdmin and $thresholdmax.

It also changes the query to use SQL with parameters for authority types.

Test plan :
1) On a catalog create a new authority
2) Be sure catalog is well indexed
3) Run misc/migration_tools/remove_unused_authorities.pl -t
4) You will see the line :
   *** Testing only, authorities will not be deleted. ***
5) You will see lines of :
   authid=x type=y : used X time(s)
6) You will see the line for the authority created in 1) :
   authid=x type=y : can be deleted
7) You will see at the end :
   x authorities parsed
   y can be deleted because unused
   z unchanged because used
8) Run misc/migration_tools/remove_unused_authorities.pl
9) You don't see the line :
   *** Testing only, authorities will not be deleted. ***
10) You will see lines of :
   authid=x type=y : used X time(s)
11) You will see the line for the authority created in 1) :
   authid=x type=y : deleted
12) You will see at the end :
   x authorities parsed
   y deleted because unused
   z unchanged because used
13) Run misc/migration_tools/remove_unused_authorities.pl --auth NP --auth CO
14) You see the line :
    Restricted to authority type(s) : NP,CO.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:15:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:15:44 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-6QlCJxdtR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82559|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100919&action=edit
Bug 21865: ES compatiblity of remove_unused_authorities.pl

The script misc/migration_tools/remove_unused_authorities.pl directly checks if
Zebra search is OK.

This patch changes so that this test is only if Zebra is the search engine.
It also adds a test on the search off any authority number indexed (index
'an').
With Zebra its : an,alwaysmatches=''
With ES its : an:*
This test ensure that biblios records are indexed and that not all autorities
will be deleted.

Test plan:
1) On a catalog create a new authority
2) Use Zebra in systempreference SearchEngine
3) Stop Zebra server
4) Run misc/migration_tools/remove_unused_authorities.pl -c
5) The script does nothing and says :
   Zebra server seems not to be available. This script needs Zebra runs.
6) Restart Zebra server
7) Delete biblio index base
8) Run misc/migration_tools/remove_unused_authorities.pl -c
9) The script does nothing and says :
   Searching authority number in biblio records seems not to be available :
an,alwaysmatches=''
10) Use ElasticSearch in systempreference SearchEngine
11) Delete biblio index base
12) Run misc/migration_tools/remove_unused_authorities.pl -c
13) The script does nothing and says :
    Searching authority number in biblio records seems not to be available :
an:*

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:15:48 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-6fm6iISYw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82560|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100920&action=edit
Bug 21865: add confirm to remove_unused_authorities.pl script

Like in most scripts in misc, add confirm argument
to ensure script is not run without knowing what it does.

Test plan:
1) Run misc/migration_tools/remove_unused_authorities.pl -h
2) You see help line for confirm
3) Run misc/migration_tools/remove_unused_authorities.pl
4) You see help and script does nothing
5) Run misc/migration_tools/remove_unused_authorities.pl -c
6) Script runs like wanted

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:15:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:15:51 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-FnssAC1GXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100577|0                           |1
        is obsolete|                            |

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100921&action=edit
Bug 21865: allow test arg alone

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:16:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:16:34 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-DMovXQz8pW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Tested with zebra, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:33:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:33:00 +0000
Subject: [Koha-bugs] [Bug 23871] data inconsistencies - check title exists
In-Reply-To: <bug-23871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23871-70-rTOioXW4Og@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:33:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 17:33:03 +0000
Subject: [Koha-bugs] [Bug 23871] data inconsistencies - check title exists
In-Reply-To: <bug-23871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23871-70-yB40BW4DZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94545|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100922&action=edit
Bug 23871: data inconsistencies - check title exists

In biblio records, a field must be linked to biblio.title.
200$a in UNIMARC, 100$a MARC21 (and other).

If this field is undefined, some pages like checkouts table can fail.

Test plan :
1) Remove biblio title in SQL :
   UPDATE biblio SET title='' WHERE biblionumber=XXX
2) Run misc/maintenance/search_for_data_inconsistencies.pl
3) You see the record as an inconsistency
4) Reset a title
   UPDATE biblio SET title='50 shades of Grey' WHERE biblionumber=XXX
5) Run misc/maintenance/search_for_data_inconsistencies.pl
6) Record is no longer an inconsistency

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed merge conflict, works as described. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:10:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:10:22 +0000
Subject: [Koha-bugs] [Bug 24885] Remove guided reports
In-Reply-To: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24885-70-u8Kv5g5fQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Guided reports are a pretty useful feature for new users, even if they
eventually move on to full SQL. I'd hate to see it go.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:14:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:14:37 +0000
Subject: [Koha-bugs] [Bug 24885] Remove guided reports
In-Reply-To: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24885-70-QhUCHHnbly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885

--- Comment #2 from Donna <bwsdonna at gmail.com> ---
I disagree.  There are a lot of users who do not know SQL and need the
assistance of guided reports to create reports.  They find it very useful.  If
this is removed, what alternative will users have to help them in creating
reports?  The reports library/mana is not sufficient.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:16:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:16:16 +0000
Subject: [Koha-bugs] [Bug 24885] Remove guided reports
In-Reply-To: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24885-70-XdiND6H4dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:43:08 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection template
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-nNx8MSUG8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove the use of "onclick" |Remove the use of "onclick"
                   |from serial collection and  |from serial collection
                   |serial edit templates       |template
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:43:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:43:22 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection template
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-ns6HHISeJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59181|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:59:27 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection template
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-gxPRSML3PQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 18:59:30 +0000
Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial
 collection template
In-Reply-To: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16962-70-iy3jNMngv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100923&action=edit
Bug 16962: Remove the use of "onclick" from serial collection template

This patch removes the use of event attributes like "onclick" from the
serial collection template. Events are now defined in JavaScript.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
    "Multi receiving" button works correctly.
  - For any subscription, test that the "Generate next" button works
    correctly.
  - In each tab, test that the "select all" and "clear all" links work
    correctly and affect only that tab.
  - On a subscription which has expired, test that the "Renew" button
    works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 20:17:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 19:17:19 +0000
Subject: [Koha-bugs] [Bug 24888] New: Remove the use of "onclick" from
 serials edit template
Message-ID: <bug-24888-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24888

            Bug ID: 24888
           Summary: Remove the use of "onclick" from serials edit template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com
            Blocks: 17858

+++ This bug was initially created as a clone of Bug #16962 +++

There are many uses of "onclick" and other event attributes in the Serials
module templates. This bug will track changes to serials-edit.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] [OMNIBUS] Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 20:17:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 19:17:19 +0000
Subject: [Koha-bugs] [Bug 17858] [OMNIBUS] Move staff client JavaScript to
 the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-pS7d2X9x6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24888


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24888
[Bug 24888] Remove the use of "onclick" from serials edit template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:28:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 20:28:58 +0000
Subject: [Koha-bugs] [Bug 24889] New: Sort subscription in opac view :
 closed vs open
Message-ID: <bug-24889-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24889

            Bug ID: 24889
           Summary: Sort subscription in opac view : closed vs open
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Hi,

When a record has two serial subscriptions, one of which is open and one
closed, the closed subscription appears first in the Subscriptions tab.

A bug or an enhancement to choose the sort of appearance of subscriptions ?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:29:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 20:29:19 +0000
Subject: [Koha-bugs] [Bug 24889] Sort subscription in opac view : closed vs
 open
In-Reply-To: <bug-24889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24889-70-YIyp8Tfke8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24889

--- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100924&action=edit
closed open

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:38:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 20:38:49 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-5z6UpI180T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

--- Comment #12 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Hi Jonathan,

Thank you for clarifying, it would be useful if this information had been
updated in the test plan but as I'm the last contact it hardly matters now.

I will test again with that value inputted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:03:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:03:13 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-Kmg0hJuoIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
These all display the name as (surname, firstname) except when I turn on
HoldsAutoFill. It then displays (firstname, surname). Not sure if that matters
but wanted to point that out before signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:18:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:18:21 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-bimIpwO60f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #53 from Lari Taskula <lari.taskula at hypernova.fi> ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:19:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:19:01 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 (Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-0EcitGp3TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #30 from Lari Taskula <lari.taskula at hypernova.fi> ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:20:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:20:11 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-XIonE8e9rY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #33 from Lari Taskula <lari.taskula at hypernova.fi> ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:20:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:20:50 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
 notices
In-Reply-To: <bug-14791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14791-70-RbauYygHjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #14 from Lari Taskula <lari.taskula at hypernova.fi> ---
Blocked by Bug 14723.

I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:25:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:25:15 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
 namespace
In-Reply-To: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17712-70-j46QTvlg4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #70 from Lari Taskula <lari.taskula at hypernova.fi> ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

We've been running it in production since 2017 and it's used by VuFind instance
of National Library of Finland together with Bug 16826. There are some fixes
and improvements (that need rebasing) available at
https://github.com/KohaSuomi/Koha/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:25:53 +0000
Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access
In-Reply-To: <bug-17479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17479-70-Okere1rP5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #13 from Lari Taskula <lari.taskula at hypernova.fi> ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:26:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:26:03 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-jYEiy86RZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100925&action=edit
Bug 23808: (follow-up) Display card number in 'Guarantor information' in
memberentry.pl

Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber
in 'Guarantor information' we should display 'Patron card number:' with
the cardnumber displayed as that value is more meaningful to librarians.
The hyperlink containing the borrowernumber should stay the same so that
librarians can easily visit the patron record of existing guarantor
patrons.

Test plan:

1. Apply first patch and follow it's test plan

2. On an Adult patrons record select 'Add guarantee'

3. In 'Guarantor information' section of memberentry.pl observe in the
pre-filled guarantor information there is
a line 'Patron #:' with a link displaying a borrowernumber (not card number)
and when you click on the link it takes you to the adult/guarantors patron
account

4. Select 'Search to add' and search and add another guarantor

5. Observe in the added guarantor 'Patron #:' is displayed along with
the borrowernumber (not card number). The borrowernumber displayed in
not a link.

6. Apply this patch

7. On a adults patron select 'Add guarantee'

8. Observe in 'Guarantor information' section the pre-filled guarantor
now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link
now displays the guarantors cardnumber.
Clicking on the link still takes you to the guarantors patron account

9. Repeat step 4

10. Observe in the added guarantor they also have 'Patron card number:'
(instead of 'Patron #:'). A cardnumber rather than borrowernumber is
displayed. The cardnumber is not a link.

11. Confirm tests still pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:26:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:26:43 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-DlnZpKnJ9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi all, 

Thanks very much everyone for testing!

I agree Andreas displaying the card number would be more useful to librarians.
I have attached a follow-up patch which does that. 

Please test and let me know what you think :)

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:33:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:33:45 +0000
Subject: [Koha-bugs] [Bug 17424] System preference to control access to own
 objects without permission
In-Reply-To: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17424-70-TYEu6Xowco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17424

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:36:14 +0000
Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification
 verification_token in ->new
In-Reply-To: <bug-18230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18230-70-ItGT1XvjJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lari.taskula at hypernova.fi   |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:47:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 21:47:48 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-rIYBQ0o5xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04,         |20.05.00, 19.11.04,
        released in|19.05.09                    |19.05.09, 18.11.15
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #13 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:14:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 22:14:03 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-6NHrwyxccv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24751
                 CC|                            |lari.taskula at hypernova.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:14:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 22:14:03 +0000
Subject: [Koha-bugs] [Bug 24751] REST API: CRUD endpoints for holdings
 records
In-Reply-To: <bug-24751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24751-70-fy5EtjR1o3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24751

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17371

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:32:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 22:32:14 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-eJFwsqtzo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100832|0                           |1
        is obsolete|                            |

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100926&action=edit
Bug 24266: (alternate patch) Only use defined borrowernumbers in
reconcile_balances.pl cron

I believe the error is triggered when borrowernumbers are left empty in
the accountlines table. Not sure why this would happen, but it appears
to be what causes the problem.

Do not apply the first patch if testing this patch.

To test:
1) sudo koha-mysql INSTANCENAME
2) Create a test borrower, add any payment etc to create an accountline,
    then delete this borrower
3) ensure the AccountAutoReconcile syspref is disabled
4) Go to another borrower's accounting tab
5) Create a manual credit or debit. Confirm this shows in the 'Make a
payment' tab as an amount that COULD be applied, but isn't automatically
applied
6) in your terminal, run the reconcile_balances.pl script
7) Confirm the error does not show in the logs and the balance for
the borrower is correctly reconciled.

Sponsored-by: Horowhenua District Council

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:41:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2020 22:41:42 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-5gEixQBVPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98368|0                           |1
        is obsolete|                            |

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100927&action=edit
Bug 24194: Add DisableReserveExpiration system preference to hide expiration
date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration
system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:08:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 00:08:14 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-4zX4KsvWhf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100925|0                           |1
        is obsolete|                            |

--- Comment #15 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100928&action=edit
Bug 23808: (follow-up) Display card number in 'Guarantor information' in
memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',
'Secondary email', 'Fax' have been pre-filled from the guarantor's
record

5. Fill out the rest of the memberentry.pl and 'Save' and observe that those
contact
details are successfully saved

6. Repeat step 4 and alter the 'Primary phone' and 'Primary email'
fields and save and observe that those altered values are saved

7. Run tests and confirm they pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:08:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 00:08:52 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-dJBnJTTXoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100928|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:09:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 00:09:10 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-7wW96PIT3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100925|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:10:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 00:10:32 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-u5vvFcwvfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #16 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 100929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100929&action=edit
Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor
patron in memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',
'Secondary email', 'Fax' have been pre-filled from the guarantor's
record

5. Fill out the rest of the memberentry.pl and 'Save' and observe that those
contact
details are successfully saved

6. Repeat step 4 and alter the 'Primary phone' and 'Primary email'
fields and save and observe that those altered values are saved

7. Run tests and confirm they pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:16:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:16:20 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-8ae4UCo7x8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:16:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:16:24 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-1rXEzuEou7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98595|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100930&action=edit
Bug 24495: Reword change collection feature

This patch changes the text of the "Collect from patron" field to read "Amount
tendered"

To Test:

1) In the Point of Sale screen, check that the text inside the "Collect
payment" box reads "Collect from patron"
2) Go into a patron record, and create a manual invoice.
3) Go to Make a payment, and select to "Pay an amount". Check the text reads
"Collect from patron".
4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to
the individual invoice)
5) Install the patch
6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of
"Collect from patron" in all payment options in the patron record, and in the
Point of Sale screen.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:40:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:40:29 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-ickVhvmEH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:40:30 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-WRwb6A6AoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:40:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:40:32 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-Udc2w1JbPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:40:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:40:34 +0000
Subject: [Koha-bugs] [Bug 24851] No sample libraries for UNIMARC
 installations
In-Reply-To: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24851-70-zbFE07KXPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:43:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:43:09 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-qylnwLhejM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:43:27 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-vEuEuvo6Kb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:38 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-1fb4Az9Yol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:40 +0000
Subject: [Koha-bugs] [Bug 23236] Remove 'its items may still be processed'
 in action if no match is found
In-Reply-To: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23236-70-4l2nVkiLWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23236

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:41 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-7QT61j3q4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:43 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-9z4gWeZgdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:45 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-imYeM6n6Pl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:47 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-nthmW9N923@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:49 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-wKGuPSiaZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:45:51 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-uUUsYvccBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:48:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:48:16 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-lT0K1CcJug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Sorry but I am not convince by the code.

If what we want is to not send a SMS notice if there is not SMS template, why
are not we written that explicitly in the code?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:59:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 08:59:00 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-5nKxx2UVAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #32 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Yipee! awesome, thanks joubu & martin \o/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:02:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:02:19 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-2WdTGMsbhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Think I'm missing where this requires bug 24455?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:02:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:02:50 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-He6y9CJXST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is blocked by bug 24841. Both implementations must be identical.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:16:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:16:57 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-HHkA7AwsUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22823                   |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:16:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:16:57 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-rt7jjKl1Le@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22821                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:17:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:17:11 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-0HG9evRW1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:17:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:17:26 +0000
Subject: [Koha-bugs] [Bug 24890] New: drag and trop tag when add or modify
 notice
Message-ID: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24890

            Bug ID: 24890
           Summary: drag and trop tag when add or modify notice
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stephane.delaye at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In the page /cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=

body html id :#cat_addbiblio

it's missing the id sortable for each tag ..may be an oversight when js
sortable it's ok whit koha
///////////
$(document).ready(function() {
  if ($('#cat_addbiblio').size() > 0) {
$("div.tag").each(function(){
  $(this).attr("id","sortable");
})
    $(function  () {
  $("div#sortable").sortable(
    {axis:'y',
    containment : 'parent',
    revert : true});
});
  }
}) 

/////////

I'm looking for someone to implement this/
Thank

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:17:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:17:57 +0000
Subject: [Koha-bugs] [Bug 24890] drag and trop tag when add or modify notice
In-Reply-To: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24890-70-14Rw2wRZbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24890

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:38:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:38:23 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-IfQ8CQ1d6l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 84             my $to_address = $branch->branchemail || $branch->branchreplyto
|| C4::Context->ReplytoDefault ||
C4::Context->preference('KohaAdminEmailAddress');

The C4::Context->ReplytoDefault was super wrong!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:47:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:47:37 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-XSEkwDTw5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:47:52 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-bLEpr9il93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:05 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-XHp2m5RCfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:08 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-CIDQP27f8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99905|0                           |1
        is obsolete|                            |
  Attachment #99906|0                           |1
        is obsolete|                            |
  Attachment #99907|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100931&action=edit
Bug 10269: Add reply_address field to message_queue table

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:12 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-PgMHSHCE74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100932&action=edit
Bug 10269: Schema Update

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:15 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-wpqz6qaqa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100933&action=edit
Bug 10269: Use 'reply-to' address if passed to EnqueueLetter

This patch updates the EnqueueLetter method to allow passing a reply_to
address. This allows for passing in arbitrary addresses for the reply
address which will not override the from address. This improves the
chances of your email getting past spam filters.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:45 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-Kj0dWlcBue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:48 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-2GDKGkXnr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99726|0                           |1
        is obsolete|                            |
  Attachment #99728|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100934&action=edit
Bug 22823: Add unit tests for get_effective_email

This patch adds unit tests for the newly introduced get_effective_email
method in the Koha::Library class.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:52 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-QacNyLcOYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100935&action=edit
Bug 22823: Add get_effective_email method to Koha::Library

Add a `get_effective_email` method to the Koha::Library object which
returns the email address for the library which they are most likely to
have access to.

This method falls back through preferences `branchreplyto`, `branchemail`,
`ReplytoDefault`, `KohaAdminEmailAddress`.

This bug simply introduces a new utility function to return the most effective
email address for a branch to be emailed on.

Test plan
1/ Read the new test and verify it makes sense
2/ Run the tests and verify they all pass.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tests seems ok and test pass Ok.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:55 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-AYDgmBuTB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100936&action=edit
Bug 22823: Rename method with ->inbound_email_address

Make the name obvious it's not an email address for "from"

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:48:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:48:59 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-pQ2sDCkyLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100937&action=edit
Bug 22823: return undef if KohaAdminEmailAddress not exist

I have the feeling that we should return undef here, but can be ignored
if someone disagrees.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:49:33 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-wm1XZvbEPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:49:36 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-dScInQSrx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99908|0                           |1
        is obsolete|                            |
  Attachment #99909|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100938&action=edit
Bug 22821: Use 'reply-to' address in issue notes

This patch updates the issue notices to not pass from_address and so
default to the branch email of the user for from_address. We now pass
the patrons email (cascading through email, emailpro, B_email) into the
reply_address field so mail servers are less likely to report emails as
spam and mail clients still have access to the patron address via the
reply-to header when staff want to hit 'reply' and have the email go to
the user.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:49:40 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-mQSPa2XPoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100939&action=edit
Bug 22821: Correct to_address for issue notes

This patch updates the controller and service code to use the newly
introduced 'get_effective_email' routine from bug 22823 to obtain the
branches most appropriate email address.

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:49:44 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-qzCgkJez1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100940&action=edit
Bug 22821: Rename method with ->inbound_email_address

The method has been renamed in the previous bug report.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:52:36 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->get_effective_email
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-FHYQgIDsMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99571|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100941&action=edit
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address

This patch updates the emailLibrarianWhenHoldIsPlaced functionality to
use the inbound_email_address method to obtain the correct email address
for a branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:52:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:52:59 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-2GJgE5DxRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Summary|emailLibrarianWhenHoldIsPla |emailLibrarianWhenHoldIsPla
                   |ced should use              |ced should use
                   |Koha::Library->get_effectiv |Koha::Library->inbound_emai
                   |e_email                     |l_address

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The method has been renamed in a previous bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:53:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:53:40 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->get_effective_email when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-wasyqJhElX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99573|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100942&action=edit
Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address

This patch updates the EmailPurchaseSuggestions functionality to
use the inbound_email_address method to obtain the correct email address
for a branch when it is set to BranchEmail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:54:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:54:27 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-zbG0mKWCpt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|EmailPurchaseSuggestions    |EmailPurchaseSuggestions
                   |should use                  |should use
                   |Koha::Library->get_effectiv |Koha::Library->inbound_emai
                   |e_email when set to         |l_address when set to
                   |'BranchEmailAddress'        |'BranchEmailAddress'
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The method has been renamed in a previous bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:55:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:55:26 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->get_effective_email
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-SStaLMDMaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99580|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100943&action=edit
Bug 24726: Update overdue_notices to use inbound_email_address

This patch updates the overdue_notices functionality to use the
inbound_email_address method to obtain the correct email address
for a branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 09:55:48 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-5H5G5JrJvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|overdue_notices.pl should   |overdue_notices.pl should
                   |use                         |use
                   |Koha::Library->get_effectiv |Koha::Library->inbound_emai
                   |e_email                     |l_address
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The method has been renamed in a previous bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:08:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:08:15 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-rOGLbqfy03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100944&action=edit
Bug 24722: reserves.priority must default to 1 at DB level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:09:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:09:04 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-kEEbWJZgLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100945&action=edit
Bug 24722: reserves.priority must default to 1 at DB level

https://bugs.koha-community.org/show_bug.cgi?id=22821

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:10:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:10:31 +0000
Subject: [Koha-bugs] [Bug 24722] reserves.priority must be NOT NULL
In-Reply-To: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24722-70-1asOyTSoq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24722

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100945|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100946&action=edit
Bug 24722: reserves.priority must default to 1 at DB level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:22:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:22:40 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-8IcaYY7EOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:22:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:22:43 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-CiN5M8apQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100941|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100947&action=edit
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address

This patch updates the emailLibrarianWhenHoldIsPlaced functionality to
use the inbound_email_address method to obtain the correct email address
for a branch.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:22:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:22:58 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-WbV4MT4aYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:23:01 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-a66RqMNXbU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100942|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100948&action=edit
Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address

This patch updates the EmailPurchaseSuggestions functionality to
use the inbound_email_address method to obtain the correct email address
for a branch when it is set to BranchEmail

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:23:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:23:28 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-61seYx5W6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:23:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:23:31 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-TpcNxop2yZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100943|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100949&action=edit
Bug 24726: Update overdue_notices to use inbound_email_address

This patch updates the overdue_notices functionality to use the
inbound_email_address method to obtain the correct email address
for a branch.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:23:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:23:34 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-ht4ipoPJjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100950&action=edit
Bug 24726: Replace one occurrence in print statement

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:24:06 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-Luzz6BuOjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Trivial patch, tested on top of the whole stack. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:24:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:24:12 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-N1Cm4vYjWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Trivial patch, tested on top of the whole stack. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:24:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:24:23 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-z5P7WKUddH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Trivial patch, tested on top of the whole stack. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:28:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:28:10 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-Y0CpBjBJJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
This patch makes a very small change in the case that we cannot send our notice
directly because the patron doesn't have a valid address to send to.

Current logic:
If we don't have an email address, send a print notice - if we can't find a
print template use the email template
If we don't have an SMS number, send a print notice - if we can't find a print
template use the email template

New logic:
If we don't have an email address, send a print notice - if we can't find a
print template use the email template
If we don't have an SMS number, send a print notice - if we can't find a print
template use the SMS template


(In reply to Jonathan Druart from comment #5)
> If what we want is to not send a SMS notice if there is not SMS template,
> why are not we written that explicitly in the code?

If I set a notice to have a print version and no email version, and I trigger
it as an email, no message is sent. We get an error:
No circulation CHECKOUT letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 608.

Why do we not do the same for SMS?

This code is not changing that anyways, it simply changes that if we try to
send an SMS but cannot and are going to send a 'print' then we should use the
SMS template if there is no print template. This affects the @output_chunks of
the code - the notice that gets sent to libraries saying "These messages were
not sent directly to the patron"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:28:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:28:42 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-3zJ63HJQYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|SMS messages should not     |SMS messages sent as print
                   |fall back to 'email'        |should not fall back to
                   |                            |'email'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:43:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:43:26 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-mrtVzwtsIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Missing signoff here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:46:08 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-ZbBp43SxTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100951&action=edit
Bug 16787: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:47:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 10:47:28 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-RHjF8Abwgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Adding the DBIC changes to help testing in a sandbox.


AM123, Lyon3, are you still interested in this bugfix?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:04:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:04:48 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-G7DegwFmda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm facing similar challenges here as I did with bug 24454.

Now I'm wrapping my head around it, there seems to be a fair bit of duplicate
code introduced here that already exists in
koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc

I'm by no means against introducing moment.js, I like the idea of using well
maintained and thought out third party libraries and the was of accessing the
functions written here is nice and elegant.. much like the way you introduced
elegant accessors for currency handling in bug 24454 (I'd like to see some of
those idea's taken forward too).

But.. I don't like that we're duplicating logic and making it somewhat less
clear which functions should be used for the job so would like some form of
merge/aggregation of such functionality and a clear documentation somewhere for
how to use it before I'm happy pushing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:05:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:05:56 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-YsCmqk39N9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:10:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:10:44 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-N3KA5CanzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:10:47 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-ZDTiHK94cU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100330|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100952&action=edit
Bug 19279: performance of linked items in search

When catalog has fields 773 (461 in UNIMARC), those linked items are fetched
for display in search results.
Looks like the code could be more performant by replacing item search by $9
with direct call with GetMarcItem().

Test plan :
1) Enable system preference EasyAnalyticalRecords
2) Get a record A with a lot of items, it will be the 'Host record'
3) Click on 'Analytics' on this record
4) On one of its items (say item A1) click on 'Create analytics' to
create record B
5) Enter the same title as record A and all mandatory fields
6) Edit field 773 (461 in UNIMARC)
6) Check that $0 contains the biblionumber of record A
7) Check that $9 contains the itemnumber of item A1
8) Perform a search on record A title, be sure you see record B with
other results
=> Compare execution times with and without patch

Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:12:03 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-QWf6pp5gSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Missing tests and benchmark, but I spent some time reading and stressing the
code and it makes perfect sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:24:48 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-82P14UV4Mt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Examples on things that need clarifying..

1) Is the intention to always pass in a 'String' (and if so, of what format) to
the new $date, $datetime and $time window functions.. or are you deliberately
allow Date prototypes to be passed?
2) You allow to pass in a timezone in the options, but the string value may
also include an offset if it's a RFC3339 so how are the two being ratified..?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:29:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:29:01 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-ketgPsYpmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd be tempted to have some clearer function names.. like fromkohadate which
would take a syspref formatted date string and return a moment prototype and
tokohadate which would take a moment and return a string formatted per koha
sysprefs ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:31:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:31:29 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-gnp2CjdK5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:31:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:31:32 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-UqRyOOmWpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100395|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100953&action=edit
Bug 24518: Fix IE11 partner filtering

This patch adopts the approach detailed in comment #1.

It also fixes a couple of additional minor bugs relating to the ILL
partner list:
- Exclude partners with no email address, we cannot use them
- Quote the "value" attribute to avoid warnings displayed by IE, they
should be quoted anyway!

Test plan: USE IE11
- Apply the patch
- Define 3 ILL partner patrons (patrons in the category that has a code
that matches the <partner_code> value in the ILL config). One patron
should have no email address, the other two should have an email address
- Navigate to "Place request with partners" for an ILL request
- TEST: Observe that the patron with no email address is not displayed
- Try filtering the list
- TEST: Observe that the list filters correctly

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Did not test on I11, but regression tested ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:40:23 +0000
Subject: [Koha-bugs] [Bug 24891] New: Column Config does not hide Date Due
 in Account_Fine table
Message-ID: <bug-24891-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24891

            Bug ID: 24891
           Summary: Column Config does not hide Date Due in Account_Fine
                    table
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

24515, 24516
A patch was just added to the 19.05.08 version to fix the column configuration
for the Pay Fines tables, however, the Date Due column is still not hiding when
setting to hidden in this column config: pay_fines_table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:40:23 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-ONJkg8YEcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:40:23 +0000
Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return
 Date
In-Reply-To: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24516-70-fgKNPFUKhz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:45:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:45:17 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-IcUNce3QmJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Appeared once again on Koha_Master_D8/759

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:50:43 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-VKCCP1pQCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24455                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] Date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 11:50:43 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-XbV51pSxR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|20212                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:44:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 12:44:22 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-x8D7rjfLSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100954&action=edit
Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t

2 other occurrences where missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:44:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 12:44:38 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-RkJZwUJCa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:44:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 12:44:44 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-kbRhgxpVsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:44:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 12:44:51 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-sgpZ19LTur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:45:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 12:45:03 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-rDaPysOYGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Martin, can you push the second patch please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:40:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:40:37 +0000
Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of
 too_much reserves
In-Reply-To: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19540-70-aVgJgAspm8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:51:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:51:14 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-xTnNt9V5ty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100944|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:53:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:53:11 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-zMJ2utgMfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:53:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:53:12 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-HI3eovsvnO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:53:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:53:43 +0000
Subject: [Koha-bugs] [Bug 24892] New: Resolve some warnings in
 opac-memberentry
Message-ID: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

            Bug ID: 24892
           Summary: Resolve some warnings in opac-memberentry
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Resolve things like:

Use of uninitialized value $new_data{"sort2"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value $new_data{"overdrive_auth_token"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value $new_data{"streettype"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:54:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:54:53 +0000
Subject: [Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
In-Reply-To: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21865-70-fmNdug8TMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #11)
> Tested with zebra, no errors.

And tested with Elasticsearch, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:58:05 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-yu4KCoBsn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:58:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:58:08 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-N7iF1i3KW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100955&action=edit
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.

Trivial fix.

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:58:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 13:58:39 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-8M1FkwO7h5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl
           Severity|enhancement                 |trivial
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Trivial: self signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:00:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:00:29 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-yv6vRuhTpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:06:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:06:30 +0000
Subject: [Koha-bugs] [Bug 24893] New: Too many fields shown on "writeoff
 selected" screen
Message-ID: <bug-24893-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24893

            Bug ID: 24893
           Summary: Too many fields shown on "writeoff selected" screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 100956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100956&action=edit
Screenshot of writeoff selected view

If you create some fines and click 'writeoff selected' and you have payment
types defined in your system they show on this screen, but are not really
relevant to a writeoff. Change options are also available with 'Writeoff
amount' which again does not make sense as a write off does not involve
collecting money

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:06:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:06:48 +0000
Subject: [Koha-bugs] [Bug 24893] Too many fields shown on "writeoff
 selected" screen
In-Reply-To: <bug-24893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24893-70-87nSM0Saa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24893

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:08:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:08:13 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-92hlbwmFHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:08:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:08:15 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-gkJQrlF4bi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100925|0                           |1
        is obsolete|                            |
 Attachment #100929|0                           |1
        is obsolete|                            |

--- Comment #17 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100957&action=edit
Bug 23808: (follow-up) Display card number in 'Guarantor information' in
memberentry.pl

Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber
in 'Guarantor information' we should display 'Patron card number:' with
the cardnumber displayed as that value is more meaningful to librarians.
The hyperlink containing the borrowernumber should stay the same so that
librarians can easily visit the patron record of existing guarantor
patrons.

Test plan:

1. Apply first patch and follow it's test plan

2. On an Adult patrons record select 'Add guarantee'

3. In 'Guarantor information' section of memberentry.pl observe in the
pre-filled guarantor information there is
a line 'Patron #:' with a link displaying a borrowernumber (not card number)
and when you click on the link it takes you to the adult/guarantors patron
account

4. Select 'Search to add' and search and add another guarantor

5. Observe in the added guarantor 'Patron #:' is displayed along with
the borrowernumber (not card number). The borrowernumber displayed in
not a link.

6. Apply this patch

7. On a adults patron select 'Add guarantee'

8. Observe in 'Guarantor information' section the pre-filled guarantor
now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link
now displays the guarantors cardnumber.
Clicking on the link still takes you to the guarantors patron account

9. Repeat step 4

10. Observe in the added guarantor they also have 'Patron card number:'
(instead of 'Patron #:'). A cardnumber rather than borrowernumber is
displayed. The cardnumber is not a link.

11. Confirm tests still pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:08:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:08:18 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-A9OpVmEJ0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #18 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 100958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100958&action=edit
Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor
patron in memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',
'Secondary email', 'Fax' have been pre-filled from the guarantor's
record

5. Fill out the rest of the memberentry.pl and 'Save' and observe that those
contact
details are successfully saved

6. Repeat step 4 and alter the 'Primary phone' and 'Primary email'
fields and save and observe that those altered values are saved

7. Run tests and confirm they pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:15:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:15:01 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-4CL5mAFZwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #19 from Andreas Roussos <a.roussos at dataly.gr> ---
Alex, many thanks for following up on this so quickly! I have tested your new
patches and they look good to me, so I signed them off.

I also took the liberty of tagging some of the comments as obsolete, in order
to unclutter the flow of the discussion in this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:18:43 +0000
Subject: [Koha-bugs] [Bug 24893] Too many fields shown on "writeoff
 selected" screen
In-Reply-To: <bug-24893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24893-70-vKs1xcDTW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24893

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 24208 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:18:43 +0000
Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs
In-Reply-To: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24208-70-aEFkwsNg65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 24893 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:28:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:28:02 +0000
Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to
 Advanced search
In-Reply-To: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24155-70-O7kRrjDMXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:28:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:28:05 +0000
Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to
 Advanced search
In-Reply-To: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24155-70-LWnBjRi0pS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99667|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100959&action=edit
Bug 24155: Make wieghting an option on advanced search

Currently we apply weighting to all searches except advanced search. The theory
being that when selecting indexes we don't want to apply weights. When
searching
in ES weights are only applied to relevant results so it doesn't matter.

i.e. if weighting author*100 but searching subject, a term matching the subject
search in author
is not boosted.

Given this, we should always apply weights, unless the user wishes not to

To test:
1 - Set some weighting
2 - Do some searches
3 - Note your terms and results, try advanced and regular searches specifying
indexes or not
4 - Apply patch
5 - Note that opac and staff advanced search have option to apply weights
6 - Compare searches after the patch to see how weighting affects, it should be
beneficial or not at all

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:18 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-mKrvMu4ZMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92022|0                           |1
        is obsolete|                            |

--- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100960&action=edit
Bug 23204: script for exporting Elasticsearch mappings

Test plan:

  - launch perl misc/search_tools/export_elasticsearch_mappings.pl >
    /path/to/my_mappings.yaml
  - set koha-conf.elasticsearch_index_mappings to
    /path/to/my_mappings.yaml,
  - go to admin -> Search engine configuration,
  - click on "Reset mappins",
  - check that your search fields and mappings are as expected

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:22 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-kdkdXltYxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92023|0                           |1
        is obsolete|                            |

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100961&action=edit
Bug 23204: move code in a unit tested sub

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:25 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-HqvRQr2wtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92024|0                           |1
        is obsolete|                            |

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100962&action=edit
Bug 23204: export field weights

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:29 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-nYCNe5qXJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92174|0                           |1
        is obsolete|                            |

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100963&action=edit
Bug 23204: add exec permission on the script

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:32 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-MKIOQnVbTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93524|0                           |1
        is obsolete|                            |

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100964&action=edit
Bug 23204: sort search fields by name

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:32:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:32:35 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-x4pgcv5V86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95986|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100965&action=edit
Bug 23204: (follow-up) also sort by marc field

Test plan :
Launching script several times and see that marc field is alway ordered
increasing

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Same order between runs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:34:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:34:19 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-tJjbKPps6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:37:02 +0000
Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types:
 rules for holds allowed are not applied correctly if any item type is
 available
In-Reply-To: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24683-70-bCCbdXTVKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:37:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:37:05 +0000
Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types:
 rules for holds allowed are not applied correctly if any item type is
 available
In-Reply-To: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24683-70-RwWCGfNmuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 100966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100966&action=edit
Bug 24683: Add description of QueryFuzzy support in ES to syspref description

To test:
Apply patch
Find QueryFuzzy in sysprefs
Verify the new text makes sense

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:38:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:38:29 +0000
Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types:
 rules for holds allowed are not applied correctly if any item type is
 available
In-Reply-To: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24683-70-9KC7LXkr57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
Nick: Wrong bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:44:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:44:45 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-Nfkr9AQ2P7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I tried to SO.

There is one use left in test suite :
  $ git grep _get_itype
  t/db_dependent/Reserves.t:my $itype = C4::Reserves::_get_itype($item);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:47:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:47:50 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-taigXUkJxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:47:53 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-Fo1vtTxSoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100955|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 100967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100967&action=edit
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:48:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 14:48:16 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-OPrfw1dqoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:03:46 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-yzq1mH62on@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:03:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:03:49 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-vFW4R6kDwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97668|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100968&action=edit
Bug 24468: Remove unused C4::Reserves::_get_itype subroutine

Since bug 21206, C4::Reserves::_get_itype is not longer used and should
be removed.

  commit 31c29fd31f557306233e6a2936148a5bb10b89a1
  Bug 21206: Replace C4::Items::GetItem

UPDATE: In the meanwhile another occurrence was added to Reserves.t, but
easy to replace

Test plan:
  % git grep _get_itype
must not return any occurrences.

If one needs it, Koha::Item->effective_itemtype must be used instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:06:23 +0000
Subject: [Koha-bugs] [Bug 20384] Elasticsearch rebuild script improvements -
 options for indexing
In-Reply-To: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20384-70-aNTqUGaAwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Please rebase, does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:18:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:18:40 +0000
Subject: [Koha-bugs] [Bug 24894] New: Allow configuration of search dropdowns
Message-ID: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24894

            Bug ID: 24894
           Summary: Allow configuration of search dropdowns
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Currently, we can customize the indices included in the basic and advances
search dropdowns via jQuery. It'd be great to have some more user-friendly
interface for this. It might make sense to tie it into the Elastic search
engine config page, or to make it its own system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:18:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:18:51 +0000
Subject: [Koha-bugs] [Bug 24894] Allow configuration of search dropdowns
In-Reply-To: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24894-70-pNipAxI5ZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24894

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:21:18 +0000
Subject: [Koha-bugs] [Bug 24895] New: CCL searching with phr modifier
 doesn't work
Message-ID: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

            Bug ID: 24895
           Summary: CCL searching with phr modifier doesn't work
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To test:
- enable DumpSearchQueryTemplate so you can easily check the contents of your
query
- enter a CCL search of ti,phr:batman
- confirm the query gets processed as just ti:batman

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:21:27 +0000
Subject: [Koha-bugs] [Bug 24895] CCL searching with phr modifier doesn't work
In-Reply-To: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24895-70-SJ1oMj3Wij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:30:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:30:19 +0000
Subject: [Koha-bugs] [Bug 24896] New: Transport Cost Matrix
Message-ID: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24896

            Bug ID: 24896
           Summary: Transport Cost Matrix
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In hindsight of the Covid-19 outbreak, it would be good to have a way to turn
off part or all of the transport cost matrix without having to rewrite the
entire grid and track settings that have changed.

We ended up saving and disabling every cell so we could do holds without
transfers while some of the libraries were closed and we had no courier.  With
that said, I recommend:

* To have the ability to disable a cell, but not lose the value in the cell.
* Have a master switch that would disable all cells, but not lose the value in
the cells.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:42:46 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-crc1f3ZC3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Fanny Mion Mouton <fanny.mion-mouton at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fanny.mion-mouton at bulac.fr

--- Comment #107 from Fanny Mion Mouton <fanny.mion-mouton at bulac.fr> ---
Dear All, very sorry for the delayed answer on this : Séverine is not currently
working so we left it unanswered...
I will try to answer it, but please don't hesitate to ask for more precisions
if needed : 

 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?


Still waiting for an answer here, but I think we could fix that on a follow-up
if needed. The change will be minor compared to the work needed to keep this
patchset up-to-date with master.

> Yes it was the expected behavior. We don't need the last modification to be updated as long as it is not updated with the edit form. We consider that the suggestion has not really begun to be processed as long as the edit form has not beeing used : the relevant librarian to process it was not "manager" of the suggestion. Regarding statistics for delay of suggestion management, it will be more useful not to consider this as a last date of modification.
Does it make sense ? 

Thanks again and sorry for the delay !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:43:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:43:32 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-vvdz0ktrHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/print.css

You should not modify print.css but css/src/print.scss instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:44:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:44:51 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-RLwSzzrEwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:44:53 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-Xlnrk9KNfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:44:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:44:55 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-JV1Qia5ZiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:44:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:44:57 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-jDQ6RFPW1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:44:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:44:59 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-6Toqunh6Nv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:45:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:45:01 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-jZi6sovN20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:45:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:45:04 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-Js4QoFQdEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:46:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:46:07 +0000
Subject: [Koha-bugs] [Bug 24897] New: Remove es-ES installer data
Message-ID: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897

            Bug ID: 24897
           Summary: Remove es-ES installer data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Now we can translate all installer data, then the es-ES directory is no longer
needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:47:08 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-aQwUekRnyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100915|0                           |1
        is obsolete|                            |

--- Comment #16 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 100969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100969&action=edit
Bug 24846: Update items.onloan with the new due date

Signed-off-by: Donna Bachowski <donna at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:48:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:48:21 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-IY2ukjmkxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:58:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 15:58:01 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-QXTjhd8eig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #42 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #39)
> I'm facing similar challenges here as I did with bug 24454.
> 
> Now I'm wrapping my head around it, there seems to be a fair bit of
> duplicate code introduced here that already exists in
> koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
> 
> I'm by no means against introducing moment.js, I like the idea of using well
> maintained and thought out third party libraries and the was of accessing
> the functions written here is nice and elegant.. much like the way you
> introduced elegant accessors for currency handling in bug 24454 (I'd like to
> see some of those idea's taken forward too).
> 
> But.. I don't like that we're duplicating logic and making it somewhat less
> clear which functions should be used for the job so would like some form of
> merge/aggregation of such functionality and a clear documentation somewhere
> for how to use it before I'm happy pushing this.

Hello Martin, functions in calendar.inc has similar logic, but they do the
oposite job of this functions.

calendar.inc function's inputs are date/datetime strings as specified by
dateformat preference and returns a JS Date object.

This function's inputs are date/datetime string as returned from the api
(RFC3339) and returns a date/datetime/time string as specified by dateformat
preference, and translated to corresponding timezone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:00:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:00:11 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-yh3WxDTfQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #43 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #42)
> (In reply to Martin Renvoize from comment #39)
> > I'm facing similar challenges here as I did with bug 24454.
> > 
> > Now I'm wrapping my head around it, there seems to be a fair bit of
> > duplicate code introduced here that already exists in
> > koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
> > 
> > I'm by no means against introducing moment.js, I like the idea of using well
> > maintained and thought out third party libraries and the was of accessing
> > the functions written here is nice and elegant.. much like the way you
> > introduced elegant accessors for currency handling in bug 24454 (I'd like to
> > see some of those idea's taken forward too).
> > 
> > But.. I don't like that we're duplicating logic and making it somewhat less
> > clear which functions should be used for the job so would like some form of
> > merge/aggregation of such functionality and a clear documentation somewhere
> > for how to use it before I'm happy pushing this.
> 
> Hello Martin, functions in calendar.inc has similar logic, but they do the
> oposite job of this functions.
> 
> calendar.inc function's inputs are date/datetime strings as specified by
> dateformat preference and returns a JS Date object.
> 
> This function's inputs are date/datetime string as returned from the api
> (RFC3339) and returns a date/datetime/time string as specified by dateformat
> preference, and translated to corresponding timezone.

I believe Calendar.inc functions are used to get a date from tt variable, and
put that date into a jquery calendar input.

This functions should be used to format dates from the api

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:05:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:05:35 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-JKPXuxxjOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:05:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:05:43 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-wu9VRb2IDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:07:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:07:56 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-AwU2mNjIWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I forgot if this test was really failing. Holding on for now, until it
reappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:09:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:09:04 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-vTxzzPgFW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #44 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #40)
> Examples on things that need clarifying..
> 
> 1) Is the intention to always pass in a 'String' (and if so, of what format)
> to the new $date, $datetime and $time window functions.. or are you
> deliberately allow Date prototypes to be passed?

It was designed to transform dates from the api, so input is always RFC3339

> 2) You allow to pass in a timezone in the options, but the string value may
> also include an offset if it's a RFC3339 so how are the two being ratified..?

For example, if you pass the following value '2020-03-18T07:00:00-03:00' and
you set the timezone for an equivalent of +03:00 the result of calling
$datetime should be '2020-03-18T13:00:00+03:00' each one being equivalent to
'2020-03-18T10:00:00Z'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:17:34 +0000
Subject: [Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory
 for js files
In-Reply-To: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24734-70-bycc6ViS7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
This patch will not apply cleanly to 19.05.x, not backporting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:20:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:20:34 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-9rjvJptO4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:20:38 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-pXjRfZZnCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 100970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100970&action=edit
Bug 24881: Try to fix random failure from Circulation.t

This is a follow-up of bug 22917.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:21:26 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-FBu9kdqgKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:21:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:21:50 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-ZdqojOvQ8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Sending to RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:26:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:26:38 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13193-70-ogjHMO0EEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #73 from Lucas Gass <lucas at bywatersolutions.com> ---
missing 19.05.x dependencies, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:27:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:27:58 +0000
Subject: [Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked
 as mandatory
In-Reply-To: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24642-70-MYumL6NA2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
choosing not to backport these to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:29:57 +0000
Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-NWkvs655IX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:30:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:30:00 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-LAeevp1Ah4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:30:04 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-YLLueRdio3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:30:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:30:08 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-4uHg0ZF51b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:30:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:30:09 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-WHcccyMAZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.05.09                    |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:30:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:30:11 +0000
Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran
 slowly
In-Reply-To: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24881-70-SEy2JsDvig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:37:02 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-Ui7A1ZEUd4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:39:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:39:47 +0000
Subject: [Koha-bugs] [Bug 24677] [19.11] Wrong year picked in serials
In-Reply-To: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24677-70-bUpKkeWJYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
missing dependency for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:41:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:41:34 +0000
Subject: [Koha-bugs] [Bug 24727] Typo in circulation.js
In-Reply-To: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24727-70-SilZQ6E7Dt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24727

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
missing 19.05.x dependency, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:42:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:42:10 +0000
Subject: [Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template
 literals
In-Reply-To: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24725-70-6HzM9QS4lJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
missing 19.05.x dependencies, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:47:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:47:10 +0000
Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt
In-Reply-To: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24388-70-cOQNiIzWiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:54:01 +0000
Subject: [Koha-bugs] [Bug 18933] Unable to set SMS number in OPAC messaging
 preferences to empty
In-Reply-To: <bug-18933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18933-70-iVTl4mNRIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:57:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 16:57:08 +0000
Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title
 before surname
In-Reply-To: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24514-70-3idYVWvE6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:01:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:01:04 +0000
Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered
 when dumped
In-Reply-To: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24110-70-MCRJuLJQ4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:05:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:05:39 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-EMrDLbylc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #45 from Lucas Gass <lucas at bywatersolutions.com> ---
this patchset does not cleanly apply to 19.05.x, no backport 

if this is wanted/needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:11:23 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-5P9T8JU7Uw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch changes the text
      release notes|                            |"Collect from patron" to
                   |                            |"Amount tendered" for all
                   |                            |payment options in the
                   |                            |patron record, and in the
                   |                            |Point of Sale screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:16:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:16:56 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-pssYDmuJJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:18:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:18:45 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-6xGDEaPP3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:19:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:19:02 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-w5Zna3WsTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:19:05 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-8nzUXA3CnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 100971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100971&action=edit
Bug 16457: Remove the use of "onclick" from the patron entry form

This patch removes several event attributes from the patron entry form
and replaces them with event handlers in the <script> block.

Some event attributes were removed altogether because they weren't
functional: Onchange events on jQueryUI datepickers don't work, and they
would have been redundant even if they did work.

To test you should have some patron attributes configured
(Administration -> Patron attribute types). At least one attribute
should be configured to apply to one particular patron category.

Apply the patch and begin the process of adding a new patron.

1. Try to add a patron with details matching a patron which already
   exists. You should get a confirmation message on screen which asks if
   the patron is a duplicte. Test the link which shows the existing
   record. It should trigger a popup window with details about the
   patron.

2. Test the process of setting a patron's date of birth. Selecting a
   date should trigger the display of the patron's age immedately below
   the field.

3. Test that you cannot set a patron's expiration to a date which
   precedes the date in the registration date field.

4. Test that you can add a manual restriction's expiration date, and
   that the "Clear date" link works correctly.

5. Test that the "clear" and "new" controls links work with additional
   attributes and identifiers.

6. Test that changing the patron's category correctly affects the
   display of available attributes and identifiers: The attribute you
   have associated with a particular patron category should only show if
   that category is selected under "Category."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:23:07 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters (renamed start_date and expiry_date)
In-Reply-To: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23531-70-VzDin9ej6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch implements the
      release notes|                            |documented "start_date" and
                   |                            |"expiry_date" parameters
                   |                            |for hold requests using
                   |                            |Koha's ILS-DI service.
                   |                            |
                   |                            |Note: the previously
                   |                            |documented but not
                   |                            |implemented parameter names
                   |                            |were changed:
                   |                            |-
                   |                            |needed_before_date =>
                   |                            |start_date
                   |                            |-
                   |                            |pickup_expiry_date =>
                   |                            |expiry_date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:26:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:26:55 +0000
Subject: [Koha-bugs] [Bug 16763] Remove the use of "onclick" from record
 matching rules form
In-Reply-To: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16763-70-QzRoFZQCYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53004|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:52:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:52:51 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-wdYAWIE5oB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:52:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:52:53 +0000
Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search
In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19279-70-87xi4oEz8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:52:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:52:55 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-XbTUGfyJRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 18:52:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 17:52:57 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-eJpdawesjb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:22:20 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-LSVXgyRKYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:31:41 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-soYYBUaCi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Currently, if you don't specify any Accept header you get a 406, and the
following response body (application/json):

[
    "application/json",
    "application/marcxml+xml",
    "application/marc-in-json",
    "application/marc"
]

I followed what is described here on the Mozilla site [1]. Now that I re-read
it they suggest the site usually just skips the error and returns a fallback
(the default response). It then mentions if you want to return 406, give the
consumer a list of accept-able mime types.

I am open to any change. Let's discuss it in more detail.


[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/406

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:33:15 +0000
Subject: [Koha-bugs] [Bug 24238] GET /biblios does not default to
 accept:application/json
In-Reply-To: <bug-24238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24238-70-tV9hYehF32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24238

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---


*** This bug has been marked as a duplicate of bug 24237 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:33:15 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-OvpvuHCO2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 24238 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:34:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:34:42 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-KLAMff9KWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I am all for returning application/json as default, as suggested by Jonathan in
24238.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:36:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:36:23 +0000
Subject: [Koha-bugs] [Bug 6664] Allow to set a weekly holiday for a given
 data range
In-Reply-To: <bug-6664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6664-70-1451YkQ0vQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:38:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 18:38:24 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-UjYZ8IINry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Angela <angela.oconnordesmond at staff.ittralee.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |angela.oconnordesmond at staff
                   |                            |.ittralee.ie

--- Comment #19 from Angela <angela.oconnordesmond at staff.ittralee.ie> ---
The development which adds multiple claim dates is available for testing on
the following sandbox:

http://staff-bug24161.sandboxes.ptfs-europe.co.uk. To ensure it is working
correctly please follow these steps:

1. Create multiple orders against two or more vendors and close the baskets
2. On the late orders page, claim some of the orders
3. The date of the claim will be displayed in the "Claimed date" column
4. Make more claims against the same items
5. You should now see multiple dates listed in the "Claimed date" column

Nothing happens when claim button on late orders page clicked.  Error message
"connect to localhost failed (Connection refused) connect to localhost failed
connect to localhost failed (Connection refused) no (more) retries!"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:06:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:06:47 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-za6RRhHOmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #27)
> One note here: AddIssue closes existing transfers but doesn't update the
> reason - probably 'Checkout' should be a transfer reason - this can be done
> on another bug I think

Hmm, yeah, I remember spotting that and pondering how to handle it.

I think I opted at the time to defer that work.. the 'reason' is really all
about what triggered the transfer in the first place rather than if/why it may
have been cancelled.  It's pretty bad that we wipe out all trace of where the
item as meant to be getting transferred to in my opinion.. even if we cancel it
we aught to really record where it was meant to go in case we want to restore
it later.

I think, as you say, I'll open another bug to work no this however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:10:14 +0000
Subject: [Koha-bugs] [Bug 24898] New: AddIssue destructively changes
 transfers
Message-ID: <bug-24898-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898

            Bug ID: 24898
           Summary: AddIssue destructively changes transfers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24298

As highlighted in a comment on bug 24298, AddIssue can destructively cancel
transfers.  The transferto field is forcefully overriden and the reason isn't
recorded.

We should handle this in a clearer way..


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:10:14 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-XIj1Nkbnv1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24898


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898
[Bug 24898] AddIssue destructively changes transfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:10:21 +0000
Subject: [Koha-bugs] [Bug 24898] AddIssue destructively changes transfers
In-Reply-To: <bug-24898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24898-70-xoNxTn3UFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:14:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:14:08 +0000
Subject: [Koha-bugs] [Bug 24899] New: Reindent record matching rules template
Message-ID: <bug-24899-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24899

            Bug ID: 24899
           Summary: Reindent record matching rules template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 16763

I propose to reformat the record matching rules template (matching-rules.tt) so
that it has consistent spacing and indentation.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763
[Bug 16763] Remove the use of "onclick" from record matching rules form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:14:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:14:08 +0000
Subject: [Koha-bugs] [Bug 16763] Remove the use of "onclick" from record
 matching rules form
In-Reply-To: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16763-70-mROXmtZdPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24899
[Bug 24899] Reindent record matching rules template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:42:57 +0000
Subject: [Koha-bugs] [Bug 23574] Adding a suggestion to a basket when
 UseACQFrameworkForBiblioRecords is use publication date is not copied
In-Reply-To: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23574-70-5eQTk7CuU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23574

--- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Katrin Fischer from comment #3)
> Hi Patrick,
> I just tested on master with the default ACQ framework and my 260c ended up
> in copyrightdate correctly as mapped. Can you retest and tell us the exact
> version you are testing with?

Hi Katrin,
I tested it today with 18.05.03 and i have still the problem.

I notice that there is no mapping for publicationyear, is this a problem?

There is a mapping for copyrightdate. See attached file.

Regards
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:43:24 +0000
Subject: [Koha-bugs] [Bug 23574] Adding a suggestion to a basket when
 UseACQFrameworkForBiblioRecords is use publication date is not copied
In-Reply-To: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23574-70-wNqLGCLHJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23574

--- Comment #5 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100981&action=edit
acq_

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 19:43:44 +0000
Subject: [Koha-bugs] [Bug 23574] Adding a suggestion to a basket when
 UseACQFrameworkForBiblioRecords is use publication date is not copied
In-Reply-To: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23574-70-ydghJwFVK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23574

--- Comment #6 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Created attachment 100982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100982&action=edit
mapping

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:10 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-Y3tfGfkUDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100780|0                           |1
        is obsolete|                            |

--- Comment #63 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100983&action=edit
Bug 17268: Add macros table and permissions

Bug 17268: Change public to shared

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:16 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-Hqpw7InVjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100781|0                           |1
        is obsolete|                            |

--- Comment #64 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100984&action=edit
Bug 17268: Advanced cataloging editor macros - add endpoint

Bug 17268: Make shared macros use their own path

Bug 17268: Update API to use shared instead of public

Bug 17268: (follow-up) Update API field definition to boolean

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:19 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-OPWBFxr0F6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100782|0                           |1
        is obsolete|                            |

--- Comment #65 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100985&action=edit
Bug 17268: Use API to store/retrieve values

To test:
 1  - Enable AdvancedCatalogingEditor
 2  - Add some macros (they don't need to be valid, just have content)
 3  - Apply patches
 4  - updatedatabase
 5  - Set user to have 'create_shared_macros' and 'delete_shared_macros'
 6  - Load the advanced editor (Cataloging->Advanced editor)
 7  - Click on 'Macros'
 8  - Previous macros should not show, but you should have a 'Convert' button
 9  - Convert old macros and confirm they show
10  - Edit the macros, changing content and the public checkbox, confirm
'Saved' shows in the top right of editor when updating
11  - Have at least on valid macro and run it, e.g.:
    new 100=Testing this out
12  - Run the macro, confirm it runs
13  - Try a macro with gibberish, confirm there is an error when running
14  - Ensure you have a few macros marked public
15  - In a private browser window sign in as a patron with neither shared macro
permission
16  - Confirm the public macros load, but cannot be edited
17  - Grant create_shared_macros permission to this patron
18  - Reload editor, they should now be able to edit shared macros
19  - Confirm they cannot delete shared macros
20  - Grant delete_shared_macros permission
21  - Reload editor
22  - Confirm they can now delete shared macros

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:23 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-bTGIUuhfEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100783|0                           |1
        is obsolete|                            |

--- Comment #66 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100986&action=edit
Bug 17268: (follow-up) Fix licenses

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:27 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-ktD7CQIViQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100784|0                           |1
        is obsolete|                            |

--- Comment #67 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100987&action=edit
Bug 17268: DO NOT PUSH: Schema update

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:43:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:43:31 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-v4XBqfhAjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100785|0                           |1
        is obsolete|                            |

--- Comment #68 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 100988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100988&action=edit
Bug 17268: Set boolean for shared column in schema

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 21:51:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 20:51:45 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-DpsK9AeJ4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #69 from Heather <heather_hernandez at nps.gov> ---
I'm so happy to have had a chance to help this along--this would save me SO
MUCH time in cataloging and would allow me to create macros for others
cataloging at my institution to use so would not only save them time but would
enhance the quality and accuracy of our cataloging records immensely.  Anything
that anyone can do to help this along would be most appreciated!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:32:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:32:03 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-llfXBni6ii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:32:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:32:35 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-gnDHgJNZOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #20 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Thanks very much Andreas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:39:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:39:22 +0000
Subject: [Koha-bugs] [Bug 24051] batchMod.pl:
 DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated
In-Reply-To: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24051-70-o89qPZCljm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x. for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:43:24 +0000
Subject: [Koha-bugs] [Bug 19791] Patron Modification log redirects to
 circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-Cp2rt2YQbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:51:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:51:31 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-6BEN2x29VT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 22:57:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2020 21:57:47 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
 linking to correct records
In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24094-70-V7F6w6os81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:02:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 00:02:56 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-seEXOGGm3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 00:03:01 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-Cxxfg6clwp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #112 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100989&action=edit
Bug 4461: Fix status and borrowernumber fields in problem_reports and more

status varchar(6) with readable statuses
borrowernumber not null default 0
hide form if message successfully sent
fixing hide viewed and hide closed filters
adding recipient column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 00:27:40 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-78vWNuQ25z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #113 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100990&action=edit
Bug 4461: Checks on library email before enqueuing letter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 02:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 01:36:31 +0000
Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or
 change indicators
In-Reply-To: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21860-70-F7D65SbZwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n
                   |ity.org                     |z
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 02:36:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 01:36:52 +0000
Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or
 change indicators
In-Reply-To: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21860-70-ne70gtoqns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 02:57:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 01:57:23 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-Z9VXrWs9Ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 03:39:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 02:39:37 +0000
Subject: [Koha-bugs] [Bug 24664] Add missing *-messages-js.po
In-Reply-To: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24664-70-Q1WtGg4e3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #9 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
I cannot replicate the error message, so not backporting.
If you think this needs to be backported to 18.11.x please let me know and
provide steps to replicate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 05:45:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 04:45:21 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
 and fudge flavors
In-Reply-To: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5158-70-N8lxW8PsmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100991&action=edit
test attachment

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 05:45:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 04:45:56 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
 and fudge flavors
In-Reply-To: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5158-70-PXWDMp8vlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
 Attachment #100991|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 05:48:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 04:48:51 +0000
Subject: [Koha-bugs] [Bug 24900] New: 'MARC modification templates' does not
 delete all fields if there is a condition in template
Message-ID: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

            Bug ID: 24900
           Summary: 'MARC modification templates' does not delete all
                    fields if there is a condition in template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Created attachment 100992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100992&action=edit
test record

To reproduce:

Download the attached biblio record (try right-clicking -> save link as)
Create a MARC modification template with the following action:
Delete field 020 if field 020$z exists
Import the record (Tools -> Stage MARC record for import)
Under Use MARC modification template, select your template to modify the record
Stage for import
Once complete, go to Manage staged records
Click the staged record to view the MARC
Confirm only the 020$z field was deleted, even though we wanted all 020 fields
to be deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 05:55:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 04:55:10 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-jkqYu9xG2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100993&action=edit
Bug 24900: If condition in template, check for existence of from fields in MARC
record

This patch checks the existence of 'from fields' in the record, as
defined in the template, if the template includes a condition.

To test:
Follow plan to reproduce the bug
Apply the patch and go back to import the record (Tools -> Stage MARC record
for import)
Under Use MARC modification template, select your template to modify the record
Stage for import
Once complete, go to Manage staged records
Click the staged record to view the MARC
Confirm all 020 fields were deleted, as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 05:55:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 04:55:34 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-iCSK6Cd82N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Tests coming

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 07:09:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 06:09:05 +0000
Subject: [Koha-bugs] [Bug 23696] build_oai_sets.pl should take biblios from
 deletedbiblio_metadata too
In-Reply-To: <bug-23696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23696-70-HPMpwECN57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23696

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:25:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:25:54 +0000
Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or
 change indicators
In-Reply-To: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21860-70-z5TqG0J2Ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:26:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:26:25 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-G9VcTCVv9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:26:45 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-kK6Y08Ld2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

--- Comment #19 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 100994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100994&action=edit
Bug 4985: Add missing parameters

Subroutine edit_holiday was missing parameter.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:31:54 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-EUvKBdC63N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel the description of the bug is not correct on this one, but not sure what
it should be changed to - Martin, could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:36:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:36:11 +0000
Subject: [Koha-bugs] [Bug 24901] New: C4::Circulation::transferbook lacks
 tests
Message-ID: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

            Bug ID: 24901
           Summary: C4::Circulation::transferbook lacks tests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 24299

The transferbook method in C4::Circulation is lacking allot of tests.. I'd like
to remove this method entirely at some point, but before we do that I think we
need thorough tests adding to prevent refressions.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:36:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:36:11 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-AnbJVLcq1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24901


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901
[Bug 24901] C4::Circulation::transferbook lacks tests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:36:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:36:22 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-8JbLE7que0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:39:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:39:01 +0000
Subject: [Koha-bugs] [Bug 24894] Allow configuration of search dropdowns
In-Reply-To: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24894-70-yZPnV5Yy8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
When doing this, please keep translatability in mind :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:39:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:39:49 +0000
Subject: [Koha-bugs] [Bug 24895] CCL searching with phr modifier doesn't work
In-Reply-To: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24895-70-S9U7NxCyj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew, have you tried with more than one word?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:41:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:41:29 +0000
Subject: [Koha-bugs] [Bug 24896] Transport Cost Matrix
In-Reply-To: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24896-70-CH6HCz2FA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher, have you tried to turn off the matrix by using the
UseTransportCostMatrix system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:42:12 +0000
Subject: [Koha-bugs] [Bug 24896] Add option to disable transport cost matrix
 in part or fully
In-Reply-To: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24896-70-64E0jNjL3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Transport Cost Matrix       |Add option to disable
                   |                            |transport cost matrix in
                   |                            |part or fully

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:43:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:43:06 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-s4Q1nx4XEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #9)
> CONFLICT (content): Merge conflict in
> koha-tmpl/opac-tmpl/bootstrap/css/print.css
> 
> You should not modify print.css but css/src/print.scss instead.

ah yes.. ill fix that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:43:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:43:25 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-JrQ3IXDc23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:43:27 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-DC42yQA004@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100838|0                           |1
        is obsolete|                            |

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Created attachment 100995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100995&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:55:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 07:55:08 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-P5JfgkeIdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #20 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Hopefully latest patch resolved this delete issue. Since deletes still (?!)
work for me without it I'm unable to be totally sure. Still I'll change status
back to Needs Signoff to get feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:13:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:13:57 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-fqKlVizg8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100996&action=edit
Bug 24901: Minor refactor of tests

Test plan:
0/ Read the change and verify it makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:14:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:14:00 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-QekAhHlrFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100997&action=edit
Bug 24901: Add tests for transferbook

Test plan:
0/ Read the commit and confirm the new tests make sence
1/ Run the tests and verify they pass
2/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:14:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:14:12 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-yIPYXCN3Zy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:14:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:14:26 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-krY4AJXNee@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:45:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:45:47 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-GyzQvzdl2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #11)
> Test coverage for transferbook and TransferCollection wouldn't hurt

Added bug 24901 to add basic test coverage for transferbook.. would be great to
get a second pair of eyes as I was rather surprised by how the functionality of
the method actually worked once I started writing tests :(.. The POD is
completely wrong.

I'll add a little followup here to catch the additional field being populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:50:40 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-hMQHhfRBa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100752|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100998&action=edit
Bug 24846: Add new permission batch_extend_due_dates

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:50:43 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-QH7CGTEzkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100754|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 100999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100999&action=edit
Bug 24846: Link to the new tool

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:50:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:50:46 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-qLzWlxkb9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100914|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101000&action=edit
Bug 24846: Add new tool to batch extend due dates

With events sometimes leading to unforeseen branch closures (think Coronavirus
as
an example), it would be helpful to have a tool that would allow librarians to
update due dates in bulk based on branch and current due date of the material.

It allows to select checkouts given the following parameters:
 * libraries
 * patron's categories
 * range of the due date

You can set a hard due date, or define a number of days to extend the
due date.

Test plan:
Check some items out
Use the new tool to extend the due dates
Test the different filters to make sure they all work

Note: What about holidays?

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:50:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:50:50 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-IqmEcouWPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100969|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101001&action=edit
Bug 24846: Update items.onloan with the new due date

Signed-off-by: Donna Bachowski <donna at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:51:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:51:48 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-caTwI0VUTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This works well and resolves a problem many may be facing right now.  Passing
QA as is.. we can always revisit it and add polish and holiday handling at a
later date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:56:53 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-8ANMgdE0zA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:56:55 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-vUD40mOs20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:56:57 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-oMh6R2hYv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 08:56:59 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-hpvdvT7Z5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:14:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:14:47 +0000
Subject: [Koha-bugs] [Bug 24894] Allow configuration of search dropdowns
In-Reply-To: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24894-70-chJI2appUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24894

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:26 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-bVU0ro5ZYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:28 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-vZuB6GHLwp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:30 +0000
Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if holds are
 blocked due to fines
In-Reply-To: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15775-70-PnuaK6r0qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:32 +0000
Subject: [Koha-bugs] [Bug 15775] Show message on OPAC summary if holds are
 blocked due to fines
In-Reply-To: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15775-70-KipSeqTCnR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:35 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-t5QnenP4GG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:37 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-nwCeuPB99j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:39 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24384-70-eiq8lwEcdf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:41 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-ryYYqEAbDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:43 +0000
Subject: [Koha-bugs] [Bug 24701] Add column configuration to
 course_items_table in the OPAC
In-Reply-To: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24701-70-Z077hRcz8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:45 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-yVAi2HGXI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:46 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-vifpbielYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:48 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-15VTnxZFsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:49 +0000
Subject: [Koha-bugs] [Bug 24844] Focus on the system preferences searchbar
 when going to admin home
In-Reply-To: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24844-70-meId3IQtBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24844

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:51 +0000
Subject: [Koha-bugs] [Bug 24847] Select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-7JEbqaklex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:23:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:23:53 +0000
Subject: [Koha-bugs] [Bug 24847] Select AND by default in items search
In-Reply-To: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24847-70-opGKdtb2o9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24847

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:25:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:25:15 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-8LWLOgUVrP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:27 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-aJLChB7G0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:30 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-SxBqVL98AT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #135 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:33 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-3kzvJqEy8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:35 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-5DXpQLe58y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:36 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-toXBJbvZoB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:38 +0000
Subject: [Koha-bugs] [Bug 24510] When placing a hold,
 cursor doesn't focus on patron name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-KnL2XuwW3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:40 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-iUeb5EBrkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:42 +0000
Subject: [Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24721-70-ObthTjoG2U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:44 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-LFBkdC5XkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:45 +0000
Subject: [Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use
 Koha::Library->inbound_email_address when set to 'BranchEmailAddress'
In-Reply-To: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24723-70-iOKigWKgp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:47 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-wF0eogytSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:49 +0000
Subject: [Koha-bugs] [Bug 24726] overdue_notices.pl should use
 Koha::Library->inbound_email_address
In-Reply-To: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24726-70-qRS65mXnZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:51 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-5xh9e2vsTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:39:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:39:52 +0000
Subject: [Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files
 in .editorconfig
In-Reply-To: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24774-70-EtlP6l5wrh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:56:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:56:26 +0000
Subject: [Koha-bugs] [Bug 24902] New: Elasticsearch - different limits are
 joined with OR instead of AND
Message-ID: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

            Bug ID: 24902
           Summary: Elasticsearch - different limits are joined with OR
                    instead of AND
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com

In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections).
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.

For instance, if you select:
    Itemtypes:
        ✓ Book
        ✓ DVD
    Location:
        ✓ Child
        ✓ Adult

instead of:
    itype:Book OR itype:DVD OR location:Child OR location:Adult
it should search:
    itype:(Book OR DVD) AND location:(Child OR Adult)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:58:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:58:18 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-uzETp5wT4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101002&action=edit
Bug 24902: Join different mc- limits with AND (elasticsearch)

In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.

For instance, if you select:
    Itemtypes:
        ✓ Book
        ✓ DVD
    Location:
        ✓ Child
        ✓ Adult

it should search:
    itype:(Book OR DVD) AND location:(Child OR Adult)

Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
   and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
   location, another biblio with the new collection, and again another
   biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
   "advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
   collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
   all criteria
9. Verify that if you select more than one
   {itemtype|location|collection} it still returns results that
   satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:58:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 09:58:27 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-ou6afQiUF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:29:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:29:19 +0000
Subject: [Koha-bugs] [Bug 24897] Remove es-ES installer data
In-Reply-To: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24897-70-2ZrOGm6x8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:29:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:29:48 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-LvMiU5Syua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98291|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101003&action=edit
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with
checked_in_ok enabled

If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted
on in the same way as LocalUse and thus should be removed in the same fashion.

Test Plan:
1) Enable UpdateItemLocationOnCheckin and set it up to trigger at
checkin for an item
2) Return that item via SIP2
3) Note the alert flag is set
4) Apply this patch
5) Repeat steps 1 and 2
6) The alert flag should not be set

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kevin Cook <ILS at cedarparktexas.gov>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:29:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:29:49 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-9Je4FtCVk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:22 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-JDZmFLHPfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13897
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:22 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-nJoWPkYcqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24872

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:24 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-645AbLvBfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:24 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-HZ6inDQWgP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24870

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:26 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-9VOMOVCJRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:26 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-DYpgXPD5y5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24871

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:50 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-NGSS8dzpLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:51 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-0pvoz5kvk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:30:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:30:51 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-lVngAtLZhI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24883

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:31:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:31:11 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-z9BBH1qBaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial and clear fix.. no QA script failures..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:31:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:31:17 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-clyZLz8PzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:33:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:33:12 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-uS1A39fbt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|jonathan.druart at bugs.koha-c |testopia at bugs.koha-communit
                   |ommunity.org                |y.org
           Assignee|bgkriegel at gmail.com         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Needs Signoff               |ASSIGNED

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Moving out of NSO queue, I am trying something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:47:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:47:30 +0000
Subject: [Koha-bugs] [Bug 24903] New: Special characters like parentheses in
 numbering pattern cause duplication in recievedlist
Message-ID: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903

            Bug ID: 24903
           Summary: Special characters like parentheses in numbering
                    pattern cause duplication in recievedlist
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Just an example

2016 (No. 12); 2017 (No. 3); 2017 (No. 2); 2017 (No. 1); 2017 (No. 4); 2017
(No. 5); 2017 (No. 6); 2017 (No. 7); 2017 (No. 8); 2017 (No. 9); 2017 (No. 10);
2017 (No. 11); 2017 (No. 12); 2018 (No. 1); 2018 (No. 2); 2018 (No. 3); 2018
(No. 4); 2018 (No. 5); 2018 (No. 6); 2018 (No. 7); 2018 (No. 12); 2018 (No. 9);
2018 (No. 10); 2018 (No. 11); 2019 (No. 1); 2019 (No. 2); 2019 (No. 2); 2019
(No. 4); 2019 (No. 3); 2019 (No. 5); 2019 (No. 6); 2019 (No. 7); 2019 (No. 11);
2019 (No. 7); 2019 (No. 8); 2019 (No. 8); 2019 (No. 9); 2019 (No. 9); 2019 (No.
11); 2019 (No. 9); 2019 (No. 8); 2019 (No. 7); 2019 (No. 6); 2019 (No. 5); 2019
(No. 4); 2019 (No. 3); 2019 (No. 2); 2019 (No. 1); 2018 (No. 12); 2019 (No. 9);
2019 (No. 8); 2019 (No. 1); 2018 (No. 12)

Each edit adds at the end since the parentheses break the regex.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:51:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:51:07 +0000
Subject: [Koha-bugs] [Bug 24903] Special characters like parentheses in
 numbering pattern cause duplication in recievedlist
In-Reply-To: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24903-70-KasbxCuicf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:57:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:57:14 +0000
Subject: [Koha-bugs] [Bug 24897] Remove es-ES installer data
In-Reply-To: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24897-70-Pcy3EEUNUv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101004&action=edit
Bug 24897: xz compressed patch

With installer data in YAML format and it's translations,
there are no need for localized installer files.

This patch removes es-ES installer files.

To test on top of Bug 24871
1) Apply the patch
2) Translate to spanish
   cd misc/translator
   ./translate update es-ES
   -/translate install es-ES
3) Do a clean install using es-ES,
   check no problems during install
4) Verify MARC21 frameworks, they must
   be translated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:58:06 +0000
Subject: [Koha-bugs] [Bug 24897] Remove es-ES installer data
In-Reply-To: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24897-70-08J7dnOZMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24871
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871
[Bug 24871] Add new *-installer-*.po translation files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 10:58:06 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-E84LKarkqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897
[Bug 24897] Remove es-ES installer data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:09:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 11:09:41 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
 fallback order is incorrect
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-3xOLxgKlf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Prior to this patch when a
      release notes|                            |patron added an item note
                   |                            |the system would send a
                   |                            |notification email to the
                   |                            |branchemail with a from
                   |                            |address of the patrons
                   |                            |email.
                   |                            |
                   |                            |This patch updates
                   |                            |the notification system to
                   |                            |use the 'reply-to' address
                   |                            |in preference to the
                   |                            |'branchemail' if it is
                   |                            |defined and it also sets
                   |                            |the 'from' address to the
                   |                            |'branchemail' and adds the
                   |                            |patron email as a
                   |                            |'reply-to' as this was the
                   |                            |intended functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 11:44:48 +0000
Subject: [Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr
 modifier doesn't work
In-Reply-To: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24895-70-dAQm0a1v3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CCL searching with phr      |Elasticsearch CCL searching
                   |modifier doesn't work       |with phr modifier doesn't
                   |                            |work
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Searching                   |Searching - Elasticsearch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:51:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 11:51:22 +0000
Subject: [Koha-bugs] [Bug 24904] New: New YAML files for installer are slow
 to insert
Message-ID: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

            Bug ID: 24904
           Summary: New YAML files for installer are slow to insert
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We are generating/executing 1 query per row, which is much more slower than
before. We should generate 1 query per table to get back to the previous
execution time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 11:51:32 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-3onbcAB9Zg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897
[Bug 13897] Use YAML files for installer data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 11:51:32 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-YHEg7lcVBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24904


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904
[Bug 24904] New YAML files for installer are slow to insert
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:06 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-DpsrFeX7pL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:08 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-NVY4fLRAkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101005&action=edit
Bug 24904: DO NOT PUSH - benchmark script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:11 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-YNAdL4sfaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101006&action=edit
Bug 24904: Speed up installer process - 1 query per table

Since bug 13897 we are using YAML file to store the installer data.
We are generating/executing 1 query per row, which is much more slower than
before.
We should generate 1 query per table to get back to the previous execution
time.

With this patch we are going to generate a single one big SQL query per
table.

Test plan:
1/ Checkout a commit before bug 13897:
git checkout -b before_13897 0706922221dcdf9fa8ed7fcf86245c5622f33a3c
2/ Execute the following commands (several times, to get a median!):
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl sql" kohadev;
Note the different times displayed in the output, especially the first 2
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
They are the number of seconds took to insert them
3/ checkout master
git checkout -B master origin/master # Will reset your master branch!
4/ Execute the previous commands but without the 'sql' parameter passed
to the benchmark script
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl" kohadev;
Note the different times.
5/ Apply this patch and retry 4

Please post the execution times when you signoff on this patch.

Spoiler: total time goes from 21s to 4s.
marc21_framework_DEFAULT.yml from 12s to .5s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:40 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-8BxvWDUd7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:58 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-64H8OKfMD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883
[Bug 24883] Command line utility to load yaml files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:02:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:02:58 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-1l8Kcqexft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24904


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904
[Bug 24904] New YAML files for installer are slow to insert
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:12:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:12:53 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-tCHHnXfC6X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #43 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #42)
> Think I'm missing where this requires bug 24455?

It doesn't, removed the dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:20:28 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-7bzlYZIysH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:20:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:20:31 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-MsZmjj5yet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100996|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101007&action=edit
Bug 24901: Minor refactor of tests

Test plan:
0/ Read the change and verify it makes sense

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:20:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:20:34 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-RmpqIwylIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100997|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101008&action=edit
Bug 24901: Add tests for transferbook

Test plan:
0/ Read the commit and confirm the new tests make sence
1/ Run the tests and verify they pass
2/ Signoff

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:21:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:21:30 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-OBrALBovT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Tests only, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:33 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-5qAK1rw7DC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:35 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-7BOAPPFbN3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100831|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101009&action=edit
Bug 24883: Command line utility to load yaml files

This patch adds a command line utility to load
yaml files.

To test:
1) Apply the patch
2) Try loading a file, e.g. sample notices
 a) mysql -e "delete from letter"
 b) misc/load_yaml.pl -f installer/data/mysql/en/mandatory/sample_notices.yml
3) Try loading a file with a syntax error,
   edit previous file adding ':' at the end of a field without quotes
   then load again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:38 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-3Q8tNO5NdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101010&action=edit
Bug 24883: Centralize code to load YAML installer files to a sub

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:42 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-ZN9ZM2Jaj4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101011&action=edit
Bug 24883: Move to a flat array with all values to an array of arrayref

For the following SQL query:
INSERT INTO cities(city_name, city_country) VALUES ('Madrid', 'Spain'),
('Buenos Aires', 'Argentina');

We move from:
[ 'Madrid', 'Spain', 'Buenos Aires', 'Argentina' ]
to:
[ [ 'Madrid', 'Spain' ], [ 'Buenos Aires', 'Argentina' ] ]

Which make more sense to split, build and construct the queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:45 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-aZBYvW3i1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101012&action=edit
Bug 24883: Add a new yml2sql sub to C4::Installer

It will allow us to generate sql code from the yml files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:24:48 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-yD6nM9uzdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101013&action=edit
Bug 24883: Move new sub from load_yaml.pl

Use the sub from C4::Installer to avoid dup of code.
Also add an option to convert the yml file to SQL queries

Note:
We are going to modify the script and so will do more stuffs.
We may want to rename it, maybe installer_utilities.pl,
misc/installer/yaml_utility.pl, any suggestions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:25:49 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-eRoznaP21p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bernardo, what about those follow-ups? Do they make sense of I went to far?

More work needed:
 - Use Pod2Usage
 - Write tests for the new subroutines

But I'd like you to agree first before I continue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:26:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:26:09 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-NjDBTHuNNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:26:22 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-OGyw7rZ8NO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:32:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:32:30 +0000
Subject: [Koha-bugs] [Bug 24905] New: log4perl.conf.in missing entries for
 the z39.50 server
Message-ID: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

            Bug ID: 24905
           Summary: log4perl.conf.in missing entries for the z39.50 server
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Bug 13937 introduced new log4perl.conf changes, but missed to tweak the
packages' log4perl.conf.in template.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:32:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:32:48 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl.conf.in missing entries for the
 z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-PILP8NJKwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Packaging                   |Installation and upgrade
                   |                            |(command-line installer)
         Depends on|                            |13937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:32:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:32:48 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
 daemon
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-pFR8l0j1XZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24905


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905
[Bug 24905] log4perl.conf.in missing entries for the z39.50 server
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:45:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 12:45:22 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-SCrZ5fraz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:00:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:00:31 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-Ckz7H3KQKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87050|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101014&action=edit
Bug 22589: Remove C4::Overdues::BorType

Test plan:
0) Apply patch
1) try to run affected scripts and ensure the amounts are corectly
calculated for different patron categories:
    installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl
    misc/cronjobs/fines.pl
    misc/cronjobs/staticfines.pl

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:01:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:01:04 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-la0Z6WqQym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Looks fine to me.
Less code is less bugs ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:04:53 +0000
Subject: [Koha-bugs] [Bug 24906] New: Problems with automatic saving the
 name and id of creator and who modifies the catolog
Message-ID: <bug-24906-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24906

            Bug ID: 24906
           Summary: Problems with automatic saving the name and id of
                    creator and who modifies the catolog
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: darkdave26 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I want the name of the creator and whoever modifies the catalogs in specific
fields automatically.
So i changed the system switched the system preferences MarcFieldForCreatorId,
MarcFieldForCreatorName, MarcFieldForModifierId, MarcFieldForModifierName, to
the following fields 991 $ b, 991 $ c, 992 $ b and 992 $ c respectively.
However, when I create a new catalog, field 992 is filled in instead of field
991, and when when I modify the catalog, field 992 is modified for the new
data, deleting the old data.
I can manually create multiple 992 fields.

Someone having the same problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:07:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:07:47 +0000
Subject: [Koha-bugs] [Bug 24818] Accountline creation dates should be
 datetimes
In-Reply-To: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24818-70-7fkbkiuJ0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:17:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:17:47 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-4Q9oZO8Euh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #8)
> Bernardo, what about those follow-ups? Do they make sense of I went to far?
> 
> More work needed:
>  - Use Pod2Usage
>  - Write tests for the new subroutines
> 
> But I'd like you to agree first before I continue.

Hi Jonathan,
trying this and Bug 24904.
I'm ok in general, I was also testing some changes of myself.

One change I tried (not related with this bug) was disabling AutoCommit after
the insertion loop and enabling it afterwards. With that I got almost the same
time as with sql files. Have you explored that option?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:24:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:24:39 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-3Ux4eVQZFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maybe remove that before push:

+#subtest 'UseBranchTransferLimits tests' => sub {
+#    plan tests => 0;
+#};
+

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:31:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:31:07 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-WDRb8gUeYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Angela from comment #19)
Hello Angela,
You get this error because there is no MTA (mail system) configured on the
sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:31:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:31:18 +0000
Subject: [Koha-bugs] [Bug 24907] New: Optionally exclude suspended holds
 from holds ratio report
Message-ID: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

            Bug ID: 24907
           Summary: Optionally exclude suspended holds from holds ratio
                    report
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:33:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:33:56 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-S9NQKbcz0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I tried to execute all the queries in a transaction (using txn_do), but no gain
observed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:48:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:48:38 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-nE3i1zPSvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not we remove the files for LANG that are in installer/data/mysql/?
Thinking about fr-FR, there is no need (yet) to translate them, they won't be
used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:48:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:48:58 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-N4cl8LBn7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100917|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101015&action=edit
Bug 24856: Remove itemtypes.imageurl in fr-FR sample data

in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and
installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of
imageurl point to non-existent images.

Test plan:
Insert the 2 sql file and confirm that imageurl is not empty

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:49:14 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl.conf.in missing entries for the
 z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-DtjGcztszG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:49:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:49:34 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-q8p40piuvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as described.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:49:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:49:37 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-qQEYrZSK09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|log4perl.conf.in missing    |log4perl-site.conf.in
                   |entries for the z39.50      |missing entries for the
                   |server                      |z39.50 server

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:50:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:50:02 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-Nb4MQCPt2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:50:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:50:09 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-1UAs6rbq80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:55:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:55:26 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-5RLG354iCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:55:28 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-yWitf0CCsW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101016&action=edit
Bug 24907: Add 'include suspended' to holds ratio report

Some libraries would like the option to ignore suspended holds when using the
holds
ratio report

Note: this report fails with strict mode enabled, please disable to test

To test:
1 - Add enough holds to a record (3) to make it show on the holds ration report
2 - Browse to Circulation->Holds ratio
3 - Run with default settings and confirm the title shows up
4 - Suspend one of the holds
5 - Run report again and confirm title still shows
6 - Apply patch
7 - Reload the report
8 - Note new option
9 - Run report - title does not show
10 - Lower ratio to 2 and confirm the hold shows

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 13:55:48 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-Ou9XNaBKJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> I tried to execute all the queries in a transaction (using txn_do), but no
> gain observed.

With this diff in my original script

diff --git a/misc/load_yaml.pl b/misc/load_yaml.pl
index e670f56660..8eed5ab933 100755
--- a/misc/load_yaml.pl
+++ b/misc/load_yaml.pl
@@ -63,7 +63,7 @@ eval {
 if ($@){
     die "Something went wrong loading file $file ($@)";
 }
-
+$dbh->{'AutoCommit'} = 0;
 for my $table ( @{ $yaml->{'tables'} } ) {
     my $table_name   = ( keys %$table )[0];                          # table
name
     my @rows         = @{ $table->{$table_name}->{rows} };           #
@@ -86,3 +86,4 @@ for my $table ( @{ $yaml->{'tables'} } ) {
 for my $statement ( @{ $yaml->{'sql_statements'} } ) {               # extra
SQL statements
     $dbh->do($statement);
 }
+$dbh->{'AutoCommit'} = 1;

I see changes, form ~9s to ~1.3 for marc21_framework_DEFAULT.yml for example.

Of course I'm with you on putting the code in one place and other changes, just
want to share my results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:05:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:05:20 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-2xNtbMtGJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101017&action=edit
Bug 24905: Add missing entry in log4perl-site.conf.in

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:05:24 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-fSdV0B6jQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101018&action=edit
Bug 24905: Make installer update log4perl.conf for instances

This patch makes koha-common.postinst check if the log4perl.conf files
on the instances need tweaking. If they do, it appends the relevant
configuration text.

To test:
1. Install Koha 19.11 or earlier using the packages
2. Create an instance:
   $ koha-create --create-db test1
   $ koha-create --create-db test2
=> FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for
z39.50
3. Apply this patch and run:
   $ docker run \
      --volume=/path/to/your/clone:/koha \
      --volume=/dest/path/for/debs:/debs \
      --privileged
      --env VERSION=19.12.00.047 \
      koha/koha-dpkg:master
Note: Paths need to be adjusted
4. Grab the .deb files and put them on the machine you're testing this
5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text
   at the bottom: log4perl.logger.z3950
6. Install the debs:
   $ sudo dpkg -i koha-perldeps koha-deps koha-common
=> SUCCESS: Install process doesn't explode due to the addition
=> SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for
log4perl.logger.z3950
=> SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for
log4perl.logger.z3950
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:07:58 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-ianiRCHQrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:16:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:16:40 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-VwP8wf4QpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:16:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:16:43 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-ZIf0rvRXfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100711|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101019&action=edit
Bug 24870: Translate installer data label

This patch enable the translation of the
labels 'Mandatory' or 'Optional' present at install time
for groups of installer files.

To test:
1) Try install using de-DE language,
   at step3 verify 'Mandatory' and 'Optional'
   labels for marc21 or other data checklist
   Do not close this window!
2) Apply this patch
3) Update de-DE translation files, reinstall lang files
   cd misc/translator
   ./translate update de-DE
   ./translate install de-DE
4) Reload page at step3, now 'Mandatory' label
is translated to 'Pflichtfeld'
5) Verify strings in translation file
Search for
^msgid \"Mandatory\"
^msgid \"Optional\"
in po/de-DE-staff-prog.po.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:17:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:17:23 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-mtpIoLmO1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
That's a bit dirty but it works :)
Trivial, Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:21:56 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-tDQZAu7m6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Kyle, your patches are missing entries for log4perl-site.conf.in, and you
should probably make it dependent on bug 24905, and patch koha-common.postinst
as well, otherwise people with configured SIP servers will end up seeing it
broken on upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:23:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:23:25 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-E4BoXFRPHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We got problems with AutoCommit=0 and transactions, and decided to use DBIC
transactions only. I am surprised however do not have the same results between
both.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:24:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:24:30 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-5EONJFOPWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101018|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101020&action=edit
Bug 24905: Make installer update log4perl.conf for instances

This patch makes koha-common.postinst check if the log4perl.conf files
on the instances need tweaking. If they do, it appends the relevant
configuration text.

To test:
1. Install Koha 19.11 or earlier using the packages
2. Create an instance:
   $ koha-create --create-db test1
   $ koha-create --create-db test2
=> FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for
z39.50
3. Apply this patch and run:
   $ docker run \
      --volume=/path/to/your/clone:/koha \
      --volume=/dest/path/for/debs:/debs \
      --privileged
      --env VERSION=19.12.00.047 \
      koha/koha-dpkg:master
Note: Paths need to be adjusted
4. Grab the .deb files and put them on the machine you're testing this
5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text
   at the bottom: log4perl.logger.z3950
6. Install the debs:
   $ sudo dpkg -i koha-perldeps koha-deps koha-common
=> SUCCESS: Install process doesn't explode due to the addition
=> SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for
log4perl.logger.z3950
=> SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for
log4perl.logger.z3950
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:28:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:28:47 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-wdFAdPEQGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> Should not we remove the files for LANG that are in installer/data/mysql/?
> Thinking about fr-FR, there is no need (yet) to translate them, they won't
> be used.

Yes you are right, no need of them if lang dir exists.
But if new bugs are filed to remove dirs they will be needed.
For example Bug 24897 for es-ES.

Perhaps we can wait until late April, at that moment I can remove all unneeded
files in another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:38:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:38:49 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-h2tjUmYyfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:38:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:38:55 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-uohjZlcj6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101021&action=edit
Bug 20415: add Koha.Config Template Toolkit method

In order to remove UseKohaPlugins syspref, adds to Koha Template Toolkit
plugin a method Config() that calls C4::Context->config().

Test plan:
1) Set syspref UseKohaPlugins enabled
2) Set config enable_plugins=1
3) Check you see "Tool plugins" in "Tools" home page and menu
4) Check you see "Manage plugins" in "Koha administration" home page
5) Check you see "Report plugins" in "Reports" home page and menu
6) Set config enable_plugins=0
7) Check you don't see in 3) 4) 5)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:39:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:39:23 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-SALnbQzae0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101022&action=edit
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already
multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use
of plugins.
>>

Test plan :
1) Install kitchen sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:39:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:39:55 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-QG1AboKuMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:39:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:39:58 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-xhifV0mNqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100723|0                           |1
        is obsolete|                            |

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 101023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101023&action=edit
Bug 24877: Add link from vendor to linked subscriptions

Koha shows the number of subscriptions linked to a vendor,
but there is no way to look them up. This adds a link to the
subscription search with the vendor name, so there is an easy way
to find the subscriptions.

To test:
- Be superlibrarian or have serials permission
- Make sure you have one or more subscriptions linked to vendors
- Go to the vendor's detail page in acquisitions
- Verify the number of subscriptions is now a link
- Verify the search results are correct when clicking on it
- Remove permissions (no serials, not superlibrarian)
- Verify now the number shows, but is not linked

Signed-off-by: Devinim <nazli at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:43:21 +0000
Subject: [Koha-bugs] [Bug 20414] Remove COinSinOPACResults system preference
 and make it always on
In-Reply-To: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20414-70-KVKBc7vioX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:45:43 +0000
Subject: [Koha-bugs] [Bug 24903] Special characters like parentheses in
 numbering pattern cause duplication in recievedlist
In-Reply-To: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24903-70-kT1nq2MbYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:45:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:45:46 +0000
Subject: [Koha-bugs] [Bug 24903] Special characters like parentheses in
 numbering pattern cause duplication in recievedlist
In-Reply-To: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24903-70-ycvGWFuCj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101024&action=edit
Bug 24903: Special characters like parentheses in numbering pattern cause
duplication in recievedlist

Test plan:
Use serial with a numbering pattern with parentheses like "2018 (No. 1)".
Mark serial issue as arrived, check receivedlist on summary.
Edit issue again, check if not duplicated on receivedlist.
Mark issue as missing or not available, check missinglist.
Mark missing issue as not missing, check list again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:45:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:45:50 +0000
Subject: [Koha-bugs] [Bug 24903] Special characters like parentheses in
 numbering pattern cause duplication in recievedlist
In-Reply-To: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24903-70-vZ1uepy9xm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101025&action=edit
Bug 24903: Add tests for _handle_seqno

Trivial tests.

Test plan:
Run t/Serials/ModSerialStatus.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:48:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:48:11 +0000
Subject: [Koha-bugs] [Bug 24896] Add option to disable transport cost matrix
 in part or fully
In-Reply-To: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24896-70-MFK8w43XiM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24896

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Correct me if I am wrong, but I believe that would only stop the use that
method of transfers (using the matrix).  It wouldn't stop transfers.  Keeping
the matrix active, but disabling the cells stops transfers to specific or all
branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:49:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:49:30 +0000
Subject: [Koha-bugs] [Bug 20408] Remove the availability facet and filter
In-Reply-To: <bug-20408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20408-70-M58WrhDOKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 11677 is now resolved, I think we can close this one as invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:49:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:49:31 +0000
Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature
 creep
In-Reply-To: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20396-70-bZATpVrekR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396
Bug 20396 depends on bug 20408, which changed state.

Bug 20408 Summary: Remove the availability facet and filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20408

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:55:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:55:27 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-7Ag5ZOQaWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95989|0                           |1
        is obsolete|                            |

--- Comment #4 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 101026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101026&action=edit
Bug 24108: Advanced Editor: Save .mrc save with a configurable value

Creates a new systempref "SaveRecordbyControlNumber" which is initially
set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the
biblionumber.

To test:

    Apply the patches.
    1. Open a record in the advanced editor
    2. Save the record using the drop down box selecting "Save as MARC
    (.mrc) file.
    3. Note that the file saved is the same as the biblionumber at the top
    of the Advanced Editor interface.
    <Repeat steps 1-3 for the .xml save option>

    4. Update the database:
    update systempreferences set value = '1' where variable =
    'SaveRecordbyControlNumber';

    5. Restart Koha

    6. Verify that there is not a 001 field in the record (delete it if
            there is)

    Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should
still be saved as the
            biblionumber if there is no control field)

    7. Add a 001 field to the record such as "001  abc00012345"

    Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved
    are named abc00012345.mrc and abc00012345.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:59:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:59:39 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-wcD235LyU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add routes for biblios      |Add routes for biblios
                   |                            |[OMNIBUS]
             Status|Patch doesn't apply         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:59:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 14:59:54 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-FNVLO2qR0m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58995|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:00:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:00:07 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-kocADrDfZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58996|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:00:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:00:21 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-ncjXdJalXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:00:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:00:33 +0000
Subject: [Koha-bugs] [Bug 20413] Remove the "template" system preference
In-Reply-To: <bug-20413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20413-70-HWARNqCHce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:00:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:00:33 +0000
Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature
 creep
In-Reply-To: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20396-70-HxiUeGfDyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396
Bug 20396 depends on bug 20413, which changed state.

Bug 20413 Summary: Remove the "template" system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20413

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:01:22 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-2gPaoIeTKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23677
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=23677                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:01:22 +0000
Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record
In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23677-70-MMtqrrK8RN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17371
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=17371                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371
[Bug 17371] Add routes for biblios [OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:01:37 +0000
Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature
 creep
In-Reply-To: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20396-70-Nnny2hoe9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |24735


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735
[Bug 24735] Remove QueryParser-related code
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:01:37 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-BYvT80AzjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20396


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396
[Bug 20396] Omnibus: Cleanup Koha and fight feature creep
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:01:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:01:56 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-3gadZEPDTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:03:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:03:41 +0000
Subject: [Koha-bugs] [Bug 24908] New: Allow fetching text-formatted MARC data
Message-ID: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

            Bug ID: 24908
           Summary: Allow fetching text-formatted MARC data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

As used in several places (import diff, MARC detail), the /biblios/:biblio_id
route should handle the 'text/plain' format and output the
$record->as_formatted result.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:03:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:03:58 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-Vyjqpk1QH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |23677
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:03:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:03:58 +0000
Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record
In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23677-70-nYKK9Ejd4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908
[Bug 24908] Allow fetching text-formatted MARC data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:07:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:07:37 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-ArjpwTRr5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:07:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:07:39 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-GS6BjHLXYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101026|0                           |1
        is obsolete|                            |

--- Comment #5 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 101027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101027&action=edit
Changed indentation.

See tests above.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:08:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:08:58 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-URKVHgKTlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101028&action=edit
Bug 24908: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:09:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:09:03 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-rapi0hbqp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101029&action=edit
Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id}

This patch makes the route support requesting (through the Accept
header) the MARC record to be output as formatted text as in
$record->as_formatted.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Try the route with your favourite API testing tool (Postman?)
=> SUCCESS: Accept: text/plain returns the expected results
=> SUCCESS: Wrong Accept header returns a list of valid formats, and
includes 'text/plain'.
6. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:09:27 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-4FUSdbaE7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:10:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:10:07 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-yyTDKghKGF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101027|0                           |1
        is obsolete|                            |

--- Comment #6 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Comment on attachment 101027
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101027
Changed indentation.

GAH, why is this so hard??

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:11:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:11:40 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-TBayBJEpHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101026|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:17:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:17:39 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-DwNAkJztyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101027|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:19:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:19:15 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-6kk4Ab73r4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101027|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:27:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:27:33 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-vdeAPd6sgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101005|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101030&action=edit
Bug 24904: DO NOT PUSH - benchmark script

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:27:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:27:36 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-5FIFRsUpin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101006|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101031&action=edit
Bug 24904: Speed up installer process - 1 query per table

Since bug 13897 we are using YAML file to store the installer data.
We are generating/executing 1 query per row, which is much more slower than
before.
We should generate 1 query per table to get back to the previous execution
time.

With this patch we are going to generate a single one big SQL query per
table.

Test plan:
1/ Checkout a commit before bug 13897:
git checkout -b before_13897 0706922221dcdf9fa8ed7fcf86245c5622f33a3c
2/ Execute the following commands (several times, to get a median!):
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl sql" kohadev;
Note the different times displayed in the output, especially the first 2
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
They are the number of seconds took to insert them
3/ checkout master
git checkout -B master origin/master # Will reset your master branch!
4/ Execute the previous commands but without the 'sql' parameter passed
to the benchmark script
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl" kohadev;
Note the different times.
5/ Apply this patch and retry 4

Please post the execution times when you signoff on this patch.

Spoiler: total time goes from 21s to 4s.
marc21_framework_DEFAULT.yml from 12s to .5s

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
My numbers, 99.99% confidence

3.906 ±0.252    SQL files
15.516 ±0.772   YAML wo/patch
3.324 ±0.193    YAML w/patch

Very good!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:27:59 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-KuIaqzmXJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:29:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:29:51 +0000
Subject: [Koha-bugs] [Bug 24909] New: Add public route to get a
 bibliographic record
Message-ID: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

            Bug ID: 24909
           Summary: Add public route to get a bibliographic record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:29:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:29:54 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-qUHfb7s6W1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101026|0                           |1
        is obsolete|                            |

--- Comment #7 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 101032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101032&action=edit
Bug 24108: Advanced Editor: Save .mrc save with a configurable value

Creates a new systempref "SaveRecordbyControlNumber" which is initially
set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the
biblionumber.

To test:

    Apply the patches.
    1. Open a record in the advanced editor
    2. Save the record using the drop down box selecting "Save as MARC
    (.mrc) file.
    3. Note that the file saved is the same as the biblionumber at the top
    of the Advanced Editor interface.
    <Repeat steps 1-3 for the .xml save option>

    4. Update the database:
    update systempreferences set value = '1' where variable =
    'SaveRecordbyControlNumber';

    5. Restart Koha

    6. Verify that there is not a 001 field in the record (delete it if
            there is)

    Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should
still be saved as the
            biblionumber if there is no control field)

    7. Add a 001 field to the record such as "001  abc00012345"

    Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved
    are named abc00012345.mrc and abc00012345.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:30:50 +0000
Subject: [Koha-bugs] [Bug 24909] Add public route to get a bibliographic
 record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-q1OexP8AV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17371
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |23677

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It would be a handy addition so we can use JQuery to display more info on the
biblios, and/or remove some old CGI scripts as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371
[Bug 17371] Add routes for biblios [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:30:50 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-pe50wnHcU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
[Bug 24909] Add public route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:30:50 +0000
Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record
In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23677-70-dl9XqbGcXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
[Bug 24909] Add public route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:31:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:31:20 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-q7T0KZTlMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add public route to get a   |Add unprivileged route to
                   |bibliographic record        |get a bibliographic record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 15:58:47 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-hcU086ymwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #12)
> We got problems with AutoCommit=0 and transactions, and decided to use DBIC
> transactions only. I am surprised however do not have the same results
> between both.

Understood.

Works well, nice to load multiple file in one go, a few qa errors.

Now, the conversion part. 
The problem here is that all values are printed as strings, producing
INSERT INTO marc_tag_structure (
`authorised_value`,`frameworkcode`,`liblibrarian`,`libopac`,`mandatory`,`repeatable`,`tagfield`
) VALUES 
('', '', 'LEADER', 'LEADER', '1', '0', '000'),

instead of
('', '', 'LEADER', 'LEADER', 1, 0, '000'),

A file like this will fail to load with strict mode.

This could be fixed if we declare on each table which fields are numeric, and
take that into account when doing the conversion.
What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:02:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:02:36 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-cMbvMb9YTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Signed Off

--- Comment #37 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I've tested for Association KohaLa.
I've followed the test plan and everything is Ok.
I've played to check / uncheck borrowers/transaction information in the
PseudonymizationPatronFields and PseudonymizationTransactionFields and data
saved in the pseudonymized_transactions are consistent.
I've also checked /unckecked "Keep for pseudonymization" for borrowers
attributes and data in pseudonymized_borrower_attributes are also consistent.

The data are keeped after deleting borrowers and cleaning deletedborrowers.

Thank you for this job!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:11:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:11:49 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-MVbUhItOhp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95295|0                           |1
        is obsolete|                            |

--- Comment #36 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101033&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. you now have desks links in admin-home and admin-menu
5. click the link
6. add a desk
7. add another one
8. delete one
9. you should have a fair list of all current desks defined
10. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:18:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:18:05 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-eq4FGYxIew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We have svc/records/preview already

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:23:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:23:58 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-e0I1x9rTln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101034&action=edit
Bug 24151: DB changes

1 new table:
 * pseudonymized_transactions

3 new sysprefs:
 * Pseudonymization
 * PseudonymizationPatronFields
 * PseudonymizationTransactionFields

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:01 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-PWxSkhUxTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101035&action=edit
Bug 24151: DBIC changes

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:05 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-FqDixJb5Kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101036&action=edit
Bug 24151: Copy info to the pseudonymized table when a transaction is done

This is the commit where you will find useful information about this
development.

The goal of this new feature is to add a way to pseudonymize patron's
data, in a way they could not be personally identifiable.
https://en.wikipedia.org/wiki/Pseudonymization

There are different existing way to anonymize patron's information in
Koha, but we loose the ability to make useful report.
This development proposes to have 2 different tables:
  * 1 for transactions and patrons data (pseudonymized_transactions)
  * 1 for patrons' attributes (pseudonymized_borrower_attributes)
Entries to pseudonymized_transactions are added when a new transaction
(checkout, checkin, renew, on-site checkout) is done.
Also, anonymized_borrower_attributes is populated if patron's attributes are
marked as "keep for pseudonymization".

To make those informations not identifiable to a patron, we are having a
hashed_borrowernumber column in pseudonymized_transactions. This hash will be
generated (Blowfish-based crypt) using a key stored in the Koha
configuration.

To make things configurable, we are adding 3 sysprefs and 1 new DB
column:
  * syspref Pseudonymization to turn on/off the whole feature
  * syspref PseudonymizationPatronFields to list the informations of the
  patrons to sync
  * syspref PseudonymizationTransactionFields to list the informations
  of the transactions to copy
  * DB column borrower_attribute_types.keep_for_pseudonymization that is a
  boolean to enable/disable the copy of a given patron's attribute type.

Test plan:
1/ Turn on Pseudonymization
2/ Define in PseudonymizationPatronFields and
PseudonymizationTransactionFields the different fields you want to copy
3/ Go to the about page
=> You will see a warning about a missing config entry
4/ You need to generate a key and put it in the koha-conf.xml file. The
following command will generate one:
  % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'
Then edit $KOHA_CONF and add it before of the end of the config section
(</config)
  it should be something like:
    <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key>
5/ Restart memcached then plack (alias restart_all)
=> Everything is setup!
6/ Create a new transaction (checkin for instance)
=> Confirm that a new entry has been added to pseudonymized_transaction with
the data
you expect to be copied
7/ Edit some patron attribute types and tick "Keep for pseudonymization"
8/ Create a new transaction
=> Confirm that new entries have been added to
pseudonymized_borrower_attributes
11/ Delete the patrons
=> Confirm that the entries still exist in the pseudonymized_* tables
12/ Purge the patrons (ie. use cleanup_database.pl to remove them from
the deleted_borrowers table)
=> Confirm that the entries still exist in the pseudonymized_* tables

See bug 24152 to remove data from the anonymized_* tables

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:09 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-7aLVdpyJ9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101037&action=edit
Bug 24151: Add tests

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:13 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-iUSLKf5XMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101038&action=edit
Bug 24151: Add tests - if config does not exist

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:17 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-kigwDVKZoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101039&action=edit
Bug 24151: Add warning to the about page if key is missing in the config

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:21 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-MsuWL3PLNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101040&action=edit
Bug 24151: Add key to the config

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:25 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-1xhLwNOKH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101041&action=edit
Bug 24151: DB changes - pseudonymized_borrower_attributes

Add a new DB table pseudonymized_borrower_attributes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:29 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-lkcyTPJbMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101042&action=edit
Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:33 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-OA2Xdo007F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101043&action=edit
Bug 24151: Adding keep_for_anonymized to the UI

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:37 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-yY2ioVXdvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101044&action=edit
Bug 24151: Sync patron's attributes

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:41 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-8NUnafd2a7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101045&action=edit
Bug 24151: DBIC changes

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:45 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-V8pF7Y5LvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101046&action=edit
Bug 24151: Add boolean flag for has_cardnumber

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:49 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-ETg1bEJM2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101047&action=edit
Bug 24151: Fix location on return

The item's location where not passed to UpdateStat

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:53 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-b5Jy5nkMXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101048&action=edit
Bug 24151: Add items.homebranch to the list

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:24:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:24:57 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-UXHcfMqnC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101049&action=edit
Bug 24151: DBIC changes

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:34:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:34:24 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-dAnIT2hfxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101033|0                           |1
        is obsolete|                            |

--- Comment #37 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101050&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. you now have desks links in admin-home and admin-menu
5. click the link
6. add a desk
7. add another one
8. delete one
9. you should have a fair list of all current desks defined
10. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:45:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:45:13 +0000
Subject: [Koha-bugs] [Bug 23137] Elasticsearch - should have command line
 tool to reset mappings
In-Reply-To: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23137-70-lqfmQOAnqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:45:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:45:16 +0000
Subject: [Koha-bugs] [Bug 23137] Elasticsearch - should have command line
 tool to reset mappings
In-Reply-To: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23137-70-3H6B4CD2ek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23137

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101051&action=edit
Bug 23137: Add reset option to rebuild_elasticsearch.pl

Setup:
1 - Be using Elasticsearch
2 - Reload mappings from the db
    Admin->Search configuration
    Reset Mappings
3 - Reindex ES and confirm searching is working

To test:
1 - Apply patch
2 - Alter your mappings file for elastic (just change a description for a
field)
3 - perl misc/search_tools/rebuild_elasticsearch.pl -r -v
    Verbose not necessary, but good for letting you know things are progressing
4 - Confirm the mapping change shows in the interface
5 - Confirm reindex worked and searching is working

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:45:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:45:18 +0000
Subject: [Koha-bugs] [Bug 23137] Elasticsearch - should have command line
 tool to reset mappings
In-Reply-To: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23137-70-la0NU3i93U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23137

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101052&action=edit
Bug 23137: Add reset and delete to koha-elasticsearch

Same as previous test, but use the script to run the reindex
reset_all to update the scripts or use
misc4dev/cp_debian_files.pl

sudo koha-elasticsearch --rebuild -r -v

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 16:46:46 +0000
Subject: [Koha-bugs] [Bug 23137] Elasticsearch - should have command line
 tool to reset mappings
In-Reply-To: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23137-70-DrUI7txOqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23137

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         QA Contact|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:06:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:06:40 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-P2HqPVaCwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.thornton at educampus.ie

--- Comment #14 from Paul Thornton <paul.thornton at educampus.ie> ---
Created attachment 101053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101053&action=edit
Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:07:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:07:11 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-WYxPV7SKk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #15 from Paul Thornton <paul.thornton at educampus.ie> ---
Created attachment 101054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101054&action=edit
Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:08:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:08:39 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-PY1xvuTOLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #16 from Paul Thornton <paul.thornton at educampus.ie> ---
Hello Jonathan
I'm coordinating testing with Simon Perry, and he raised the following issue:

"I’ve hit problems with this bug. I created a test bibliographic record with
two items records attached (one as an hourly loan and one as a long loan – see
attachment for details), set yesterday as a closed day in the calendar and
issued both items to a patron. I hadn’t changed the UseDaysMode syspref, so I
wanted to check the items in, change the syspref and then reissue. I’ve found
that I can’t check either item in and am getting a string of error messages
when I try to check in (attached). Note that I deleted the closed day entry in
the calendar for yesterday to see if it would make a difference to checkin – it
didn’t work.
Do you want to investigate or create a new sandbox so that I can retest?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:10:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:10:02 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-2uhMHM5Fza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Paul Thornton <paul.thornton at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.perry at itcarlow.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:39:42 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-0DQScCx8YW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:39:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:39:45 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-OlAmMQ3ZRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100967|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101055&action=edit
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:40:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 17:40:31 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-UJDq5S9mPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This one is about the OPAC. I think you mean the other bug (24908).

But you are right about that. I want to introduce new things to the API and
deprecate the old scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:01:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 18:01:29 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-t3bFlrtZ9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Paul,

Can you confirm you were testing with all the patches applied?

Mark reported me this error by email, but that should have been fixed by the
patches I attached here on March 12th.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:03:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 18:03:14 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-3TG0UAW9xB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #180 from Owen Leonard <oleonard at myacpl.org> ---
> 2) In the staff client, edit a patron's contact info. There should be a new
> dropdown select to choose the main contact method

I see this during the edit process but I don't see the information on the
patron detail page (moremember.pl). It looks like only the template was
changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 20:26:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 19:26:13 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-PPbsHjIOvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 20:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 19:40:14 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-VMV4RFdhG4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101032|0                           |1
        is obsolete|                            |

--- Comment #8 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 101056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101056&action=edit
Bug 24108: Advanced Editor: Save .mrc save with a configurable value

Creates a new systempref "SaveRecordbyControlNumber" which is initially
set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the
biblionumber.

To test:

    Apply the patches.
    1. Open a record in the advanced editor
    2. Save the record using the drop down box selecting "Save as MARC
    (.mrc) file.
    3. Note that the file saved is the same as the biblionumber at the top
    of the Advanced Editor interface.
    <Repeat steps 1-3 for the .xml save option>

    4. Update the preference:
        Search for "SaveRecordbyControlNumber" in system preferences. Change to
"Save by ControlNumber"

    5. Restart Koha

    6. Verify that there is not a 001 field in the record (delete it if
            there is)

    Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should
still be saved as the
            biblionumber if there is no control field)

    7. Add a 001 field to the record such as "001  abc00012345"

    Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved
    are named abc00012345.mrc and abc00012345.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 20:41:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 19:41:37 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-QNNs7T6MZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Dies on importing wrong attribute
 To recreate:
   Create an import file like:
surname,firstname,categorycode,branchcode,patron_attributes,cardnumber
Acosta,Edna,T,FFL,"NOT_EXIST:1",23529001000463
   Attempt to import
   Kaboom

"Replace only included patron attributes" deletes all
   To test:
      Define attributes TEST1, TEST2, TEST3
      Assign values to these for a patron, Edna for example
      Import a file like:
surname,firstname,categorycode,branchcode,patron_attributes,cardnumber
Acosta,Edna,T,FFL,"TEST1:1",23529001000463
      All attributes deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 21:17:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 20:17:40 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-73h2Va8eFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 21:20:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 20:20:01 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-YlERxcFXIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101057&action=edit
Bug 24909: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 21:20:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 20:20:08 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-VNiy1H4wOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101058&action=edit
Bug 24909: Route spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 21:20:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 20:20:14 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
 bibliographic record
In-Reply-To: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24909-70-VSLYqSoGyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101059&action=edit
Bug 24909: Add unprivileged route to get a bibliographic record

This patch adds a route to get bibliographic records without privileged
access. This needs to match the OPAC expected behaviour.

Some things were considered on the implementation:
- The ViewPolicy filter that hides/shows things based on the frameworks
  needded to be used, as in the OPAC.
- OpacHiddenItems and OpacHiddenItemsExceptions need to be considered
  for hiding records the same way the OPAC is expected to.
- Avoid using OpacHiddenItemsExceptions, but rely on the patron category
  instead (use Koha::Patron::Category->override_hidden_items abstraction
  is used instead so it should keep working once 22547 is moved
  forward).
- Tests should cover all the use cases:
  * logged in user
  * anonymous user
  * logged in with category that overrides
  * logged in with category that doesn't override

This is all implemented on the tests.

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Route not implemented
3. Apply the rest of the patches
4. Repeat 2
=> SUCCESS: Tests pass!
5. Try it with your favourite API tool (Postman?)
6. Sign off :-D

Note: please notice there isn't a default fallback behaviour for when
you don't specify the Accept header, so testing this on a regular
browser will just print the accepted mime types instead of the record
itself.

To test this with a tool (like Postman) you should enable
RESTBasicAuthe and make the tool use Basic authentication with valid
credentials. And you need to specify any of the following strings on the
Accept header:
- application/marcxml+xml
- application/marc-in-json
- application/marc
- text/plain

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:23:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:23:27 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-4dCuF7De1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101021|0                           |1
        is obsolete|                            |
 Attachment #101022|0                           |1
        is obsolete|                            |

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101060&action=edit
Bug 20415: add Koha.Config Template Toolkit method

In order to remove UseKohaPlugins syspref, adds to Koha Template Toolkit
plugin a method Config() that calls C4::Context->config().

Test plan:
1) Set syspref UseKohaPlugins enabled
2) Set config enable_plugins=1
3) Check you see "Tool plugins" in "Tools" home page and menu
4) Check you see "Manage plugins" in "Koha administration" home page
5) Check you see "Report plugins" in "Reports" home page and menu
6) Set config enable_plugins=0
7) Check you don't see in 3) 4) 5)

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:23:32 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-uoX5z1yRCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101061&action=edit
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already
multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use
of plugins.
>>

Test plan :
1) Install kitchen sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:27:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:27:02 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-fPdBUBTTqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
I wanted to add my signoff to these because they're working well following the
test plan. However there is one problem highlighted by the QA tool:

 FAIL   Koha/Template/Plugin/Koha.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for Config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:45:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:45:21 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-iEoaTola59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:45:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:45:24 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-UcQpONl5s6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101016|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101062&action=edit
Bug 24907: Add 'include suspended' to holds ratio report

Some libraries would like the option to ignore suspended holds when using the
holds
ratio report

Note: this report fails with strict mode enabled, please disable to test

To test:
1 - Add enough holds to a record (3) to make it show on the holds ration report
2 - Browse to Circulation->Holds ratio
3 - Run with default settings and confirm the title shows up
4 - Suspend one of the holds
5 - Run report again and confirm title still shows
6 - Apply patch
7 - Reload the report
8 - Note new option
9 - Run report - title does not show
10 - Lower ratio to 2 and confirm the hold shows

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:46:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:46:27 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-CTPHNzBDeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 00:57:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2020 23:57:21 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-gGPRcgZt2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 01:10:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 00:10:32 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-SbHPyN4IN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100995|0                           |1
        is obsolete|                            |

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101063&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 01:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 00:10:49 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-z9ghsh0TZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 01:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 00:12:03 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-voM4GS8CBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
I signed off and this looks good but it should be noted that testers must run:
yarn build --view opac 

to regenerate the CSS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 01:15:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 00:15:27 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
 (19.11.x)
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-aLcRVDywsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
Upon further looking, it appears that this problem is in master too, not just
19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 07:38:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 06:38:43 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-S1zI0l1wng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Isn't it a little dangerous to give access to all of koha-conf.xml inside
templates ? This could be used to retrieve sensitive information like mysql
password, or the REST API's secret passphrase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:06:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:06:09 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-IkEeJ9frpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #18)
> Isn't it a little dangerous to give access to all of koha-conf.xml inside
> templates ? This could be used to retrieve sensitive information like mysql
> password, or the REST API's secret passphrase.

You can already retrieve that information using Perl though. What scenario do
you see someone using it maliciously?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:07:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:07:44 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-EMGNmQKoZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to David Cook from comment #19)
> You can already retrieve that information using Perl though. What scenario
> do you see someone using it maliciously?

Templates can be used in "Tools » Notices & Slips", they can be written by
users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:13:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:13:07 +0000
Subject: [Koha-bugs] [Bug 22821] Use reply-to address for item notes
 notifications if available to avoid being flagged as spam
In-Reply-To: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22821-70-wp6ThYKHNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron notes about item     |Use reply-to address for
                   |email notification fallback |item notes notifications if
                   |order is incorrect          |available to avoid being
                   |                            |flagged as spam

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Given it a go with what I think it does - feel free to correct :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:16:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:16:29 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-AAVeHnszr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Printing is broken on       |Printing is broken on
                   |opac-results.pl page        |opac-results.pl page
                   |(19.11.x)                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:38:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:38:06 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-iFc0x5P4NV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #4)
> Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Thanks Owen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 08:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 07:43:04 +0000
Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types:
 rules for holds allowed are not applied correctly if any item type is
 available
In-Reply-To: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24683-70-bawKxBKFOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from Hans Pålsson <hans.palsson at hkr.se> ---
(In reply to Nick Clemens from comment #2)
> Created attachment 100966 [details] [review]
> Bug 24683: Add description of QueryFuzzy support in ES to syspref description
> 
> To test:
> Apply patch
> Find QueryFuzzy in sysprefs
> Verify the new text makes sense

Nick: this is not the bug you are looking for.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 09:33:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 08:33:47 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-KcctYc5dNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101050|0                           |1
        is obsolete|                            |

--- Comment #38 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101064&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. you now have desks links in admin-home and admin-menu
5. click the link
6. add a desk
7. add another one
8. delete one
9. you should have a fair list of all current desks defined
10. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 09:04:08 +0000
Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the
 cleanup_database.pl cronjob
In-Reply-To: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24153-70-vSHF6hgdUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #3 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I've tested for Association KohaLa.
If you launch cleanup_database. pl without the --confirm flag, nothing is done,
but with the confirm flag, it works.
Sonia BOUIS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:24:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 09:24:46 +0000
Subject: [Koha-bugs] [Bug 24782] Calendar edit only applies to first day
In-Reply-To: <bug-24782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24782-70-kaA5UiMJ48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Holidays

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:31:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 09:31:17 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-g18NHD699X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #20)
> (In reply to David Cook from comment #19)
> > You can already retrieve that information using Perl though. What scenario
> > do you see someone using it maliciously?
> 
> Templates can be used in "Tools » Notices & Slips", they can be written by
> users.

I agree, that's definitely wrong.

Fridolin, you should pass the variable the dirty way, from C4::Auth.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:34:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 09:34:59 +0000
Subject: [Koha-bugs] [Bug 24910] New: Make it possible to choose see
 also-authorities in authority finder
Message-ID: <bug-24910-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24910

            Bug ID: 24910
           Summary: Make it possible to choose see also-authorities in
                    authority finder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When searching for authorities, sometimes you may see the result you want to
select in a see also, but it is not possible to *choose* that one. You have to
do another search to get it into the results list of auth finder.

Wouldnt it be nice if we could somehow add a link to choose them too? The
current link allows you to open them, but this seems less useful at least in
our case.

Would a preference be useful to switch between choosing or opening ?
Or should we add a small link? How could we address that best in terms of
styling etc?

Your feedback is appreciated !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 09:44:48 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-GaRo0jnrzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Revisiting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:01:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:01:54 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-zcAYgVNmoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #24)
> Dies on importing wrong attribute
>  To recreate:
>    Create an import file like:
> surname,firstname,categorycode,branchcode,patron_attributes,cardnumber
> Acosta,Edna,T,FFL,"NOT_EXIST:1",23529001000463
>    Attempt to import
>    Kaboom
> 
> "Replace only included patron attributes" deletes all
>    To test:
>       Define attributes TEST1, TEST2, TEST3
>       Assign values to these for a patron, Edna for example
>       Import a file like:
> surname,firstname,categorycode,branchcode,patron_attributes,cardnumber
> Acosta,Edna,T,FFL,"TEST1:1",23529001000463
>       All attributes deleted

Thanks Nick, good catch!
I fixed these two and add more tests to cover them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:08:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:08:30 +0000
Subject: [Koha-bugs] [Bug 24911] New: Exception holidays treated as unique
 holidays in calendar
Message-ID: <bug-24911-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911

            Bug ID: 24911
           Summary: Exception holidays treated as unique holidays in
                    calendar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Holidays
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at outlook.com
        QA Contact: testopia at bugs.koha-community.org

When exception holiday is made it's still treated as unique holiday. Only days
that aren't holidays but are included in the range of "Generate exceptions on a
range of dates" are exceptions. To test:

1. Create holidays on a range e.g 23-24/3
2. Create exceptions on a range of 24-25/3
3. When editing: 
=> 24/3 has label "Unique holiday" and is listed both in "Unique holidays" and
"Exception holidays" lists
=> 25/3 has label "Holiday exception" and is listed only in "Exception
holidays"

Problems this is causing:

1. If you edit title and description of 24th day, you'll notice from holiday
lists that edit only applies to unique holiday. In "Exception holidays" title
and description remain the same.  
2. When trying to delete 24th, only option "Delete this holiday" is given, not
"Delete this exception" as it should. And if you use "Delete this holiday",
unique holiday "beneath" exception gets deleted but day remains as exception
holiday. Of course "Delete exceptions on range" still works and single
exceptions can be deleted with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:22:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:22:08 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-BZpYgd2vdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Andrew, that makes sense to me, thanks for the excellent writing of these
patches (split, comments and commit messages are perfect!).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:23:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:23:16 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-siUv84xBiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:07 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-fCCq9BHarh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:09 +0000
Subject: [Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2
 alert flag, even with checked_in_ok enabled
In-Reply-To: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24566-70-yaKQTyLBEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:11 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-qOuqbQjL76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:12 +0000
Subject: [Koha-bugs] [Bug 24856] invalid itemtypes.imageurl in fr-FR sample
 data
In-Reply-To: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24856-70-0U5UgchrR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24856

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:14 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-Or0AyALdl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:16 +0000
Subject: [Koha-bugs] [Bug 24870] Translate installer data label
In-Reply-To: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24870-70-2rn9s0ph8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:17 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-idvTpvN7Q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:25:19 +0000
Subject: [Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
In-Reply-To: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24901-70-u48zVtURpb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:28:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:28:11 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-VvUaZZ2Bli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #9)
> Where is the LEFT JOIN?

Scratch that. It is an INNER join.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:28:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:28:22 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-IpPrpPVuHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:28:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:28:25 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-24liYvnyLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101064|0                           |1
        is obsolete|                            |

--- Comment #39 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101065&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. prove t/db_dependent/Koha/Desks.t
5. you now have desks links in admin-home and admin-menu
6. click the link
7. add a desk
8. add another one
9. delete one
10. you should have a fair list of all current desks defined
11. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:31:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:31:45 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-D7IoSGsXrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #40 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Katrin Fischer from comment #34)
> Hi Nicolas,
> 
> starting with QA review here:

Oups! From now on, I won't attach anything without running first qa-tools!
Sorry! 

I've get rid of most of them, but not this one:

> 
> 1) QA test tools
> 
> Possibly a false positive:
>  FAIL	Koha/Desk.pm
>    FAIL	  pod coverage
> 		POD coverage was greater before, try perl  -MPod::Coverage=PackageName
> -e666

I don't really understand what the problem is...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:34:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:34:03 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-sSqHbckGjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:34:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:34:03 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-PLg1frVHcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #41 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Katrin Fischer from comment #35)
> Also missing tests!

done also, based on t/db_dependent/Koha/Cities.t and
t/db_dependent/Koha/Suggestions.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:34:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:34:06 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-BLhHGN4DLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100687|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101066&action=edit
Bug 24809: Get only timestamp of deleted items attached to existing bibs when
check if bib deleted

To test:
 1 - Edit/create a file in the koha home dir
'/var/lib/koha/{instance}/OAI.yaml' with content like below:
format:
  marcxml:
    metadataPrefix: marcxml
    metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
    schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
    include_items: 1
 2 - Set the systempreferences below to indicated values:
  OAI-PMH => Enable
  OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml
 3 - View a record with items and confirm the items show:
 
http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4
 4 - Delete the items, then delete the record
 5 - Reload the URL from step 3
 6 - Internal Server Error:
  Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58.
    at /usr/share/perl/5.24/Carp.pm line 167
 7 - Apply patch
 8 - restart_all
 9 - Repeat
10 - Reload URL from step 3
11 - Success

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:34:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:34:12 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-QrmS3tEBYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101067&action=edit
Bug 24809: (QA follow-up) Add prefix to prevent disambiguity

This seems not to be needed. Just at the safe side.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:38:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:38:49 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-O13E8JtSK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Coming back here now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:40:17 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-jqBdmJ2fyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:40:30 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-p3N2rIpY5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101068&action=edit
Bug 22987: (RM follow-up) Schema Update

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:47:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:47:47 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-9QGDU1MRoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:47:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:47:50 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-Afe7hFXXRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101056|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 101069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101069&action=edit
Bug 24108: Advanced Editor - Save .mrc save with a configurable value

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber.

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
    file.
5)  Note that the file saved is the same as the biblionumber at the top of
    the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
    change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
    there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
    be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
    saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:55:35 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-3mbGozArje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:55:39 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-YbQMt4Szor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101070&action=edit
Bug 20307: Replace separator with #

To avoid colision we replace the separator with something that is
supposed to be less used than underscore

The problematic case was explaing by Julian on comment 96:
"""
The value stored in localization.code is a concatenation of the AV
category code, a '_', and the AV code. Which means that if we have a
category A with a value B_C, and a category A_B with a value C, they will
share their translations.
"""

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:58:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:58:20 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-xdBtPuI9iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:58:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 10:58:23 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-XF6pArAYdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101031|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101071&action=edit
Bug 24904: Speed up installer process - 1 query per table

Since bug 13897 we are using YAML file to store the installer data.
We are generating/executing 1 query per row, which is much more slower than
before.
We should generate 1 query per table to get back to the previous execution
time.

With this patch we are going to generate a single one big SQL query per
table.

Test plan:
1/ Checkout a commit before bug 13897:
git checkout -b before_13897 0706922221dcdf9fa8ed7fcf86245c5622f33a3c
2/ Execute the following commands (several times, to get a median!):
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl sql" kohadev;
Note the different times displayed in the output, especially the first 2
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
They are the number of seconds took to insert them
3/ checkout master
git checkout -B master origin/master # Will reset your master branch!
4/ Execute the previous commands but without the 'sql' parameter passed
to the benchmark script
mysql -h db -u koha_kohadev -ppassword -e"DROP DATABASE koha_kohadev";
mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev";
koha-shell -p -c "perl benchmark_installer.pl" kohadev;
Note the different times.
5/ Apply this patch and retry 4

Please post the execution times when you signoff on this patch.

Spoiler: total time goes from 21s to 4s.
marc21_framework_DEFAULT.yml from 12s to .5s

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
My numbers, 99.99% confidence

3.906 ±0.252    SQL files
15.516 ±0.772   YAML wo/patch
3.324 ±0.193    YAML w/patch

Very good!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:04:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:04:39 +0000
Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database
 fields
In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23900-70-UDhWT4PbIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:04:42 +0000
Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database
 fields
In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23900-70-xboh1KULw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95307|0                           |1
        is obsolete|                            |
  Attachment #99641|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101072&action=edit
Bug 23900: Teach label maker to concat database fields

Test plan:
- define a label layout with this field list: "100a 245s","enumchron
copynumber"
- find or create a record with values for all of those fields
- generate a label for that record
- the 100a and 245s successfully display on one line
- the enumchron and copynumber are displayed and separated by a space

Try other combinations

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:04:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:04:52 +0000
Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database
 fields
In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23900-70-CYsPWVY186@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101073&action=edit
Bug 23900: Add tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:10:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:10:37 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-EjZmDMzpeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:10:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:10:39 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-S2aHeeDmkX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100334|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101074&action=edit
Bug 24250: Do not duplicate debarred comment in patron screen message AF field

Caused by
  commit bddfed75913a2302c19c00b00a6fe86538af6f9f
  Bug 19933: Remove patronflags - tricky ones

Test plan:
1 - Setup SIP in your testing environment
    https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
2 - Set a patron to have a restriction
3 - Send a patron status request or patron information command via
    the SIP cli emulator (see link above)
4 - Note the comment on the restriction is sent only once

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:11:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:11:16 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-AOTeOgoIZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|jonathan.druart at bugs.koha-c |testopia at bugs.koha-communit
                   |ommunity.org                |y.org

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #22)
> Coming back here now

Unassigning me as QA contact then. I was waiting for dependent bug to be ready
actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:12:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:12:52 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-rO9xxULcC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #26 from Nick Clemens <nick at bywatersolutions.com> ---
Last changes fixed the issues, everything I have thought to test works well,
tests pass, code looks good.

Passing QA, let's get this in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:16:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:16:53 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-M9vnJmVzVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100626|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101075&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

This patch adds the RotatingCollection value to the database enum for
branchtransfer.reason

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:16:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:16:56 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-aCLlSByfAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100627|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101076&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

This patch adds support for passing a trigger to
C4::Circulation::transferbook and passes 'RotatingCollection' to it when
called inside the rotating collections routine.

Test plan:
1/ Perform a rotating collection transfer operations
2/ Check the database for instances of 'RotatingCollection' in the
branchtransfers.reason field.
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:16:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:16:59 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-in3CEPNNrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101077&action=edit
Bug 24299: Add Unit test for 'reason' in transferbook

Test plan
1/ Run test and verify it passes
2/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:17:20 +0000
Subject: [Koha-bugs] [Bug 24912] New: Generate sql from yaml installer files
Message-ID: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

            Bug ID: 24912
           Summary: Generate sql from yaml installer files
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 24883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883
[Bug 24883] Command line utility to load yaml files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:17:20 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-RfXoIIVUJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912
[Bug 24912] Generate sql from yaml installer files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:17:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:17:20 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-3Ua829fXrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24912

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:18:31 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-JD9TFeUgEk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:18:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:18:33 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-WNnZ4Rwets@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101010|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:18:35 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-7rJGrW6688@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101011|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:18:37 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-tRiNnzZW1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101012|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:18:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:18:39 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-nUL5KMb1Wo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101013|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:20:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:20:09 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-cG7XleBX97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101078&action=edit
Bug 24912: Centralize code to load YAML installer files to a sub

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:20:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:20:12 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-stFtrGt5YO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101079&action=edit
Bug 24912: Move to a flat array with all values to an array of arrayref

For the following SQL query:
INSERT INTO cities(city_name, city_country) VALUES ('Madrid', 'Spain'),
('Buenos Aires', 'Argentina');

We move from:
[ 'Madrid', 'Spain', 'Buenos Aires', 'Argentina' ]
to:
[ [ 'Madrid', 'Spain' ], [ 'Buenos Aires', 'Argentina' ] ]

Which make more sense to split, build and construct the queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:20:15 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-PelzTggnLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101080&action=edit
Bug 24912: Add a new yml2sql sub to C4::Installer

It will allow us to generate sql code from the yml files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:20:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:20:18 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-SSAKV10enw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101081&action=edit
Bug 24912: Move new sub from load_yaml.pl

Use the sub from C4::Installer to avoid dup of code. Also add an option to
convert the yml file to SQL queries

Note:
We are going to modify the script and so will do more stuffs.
We may want to rename it, maybe installer_utilities.pl,
misc/installer/yaml_utility.pl, any suggestions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:20:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:20:44 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-CgRULEzgWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I moved my patches to a separate bug report, see bug 24912.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:21:27 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-t1uKDKmw0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
>From bug 24883 comment 13:
"""
Now, the conversion part. 
The problem here is that all values are printed as strings, producing
INSERT INTO marc_tag_structure (
`authorised_value`,`frameworkcode`,`liblibrarian`,`libopac`,`mandatory`,`repeatable`,`tagfield`
) VALUES 
('', '', 'LEADER', 'LEADER', '1', '0', '000'),

instead of
('', '', 'LEADER', 'LEADER', 1, 0, '000'),

A file like this will fail to load with strict mode.

This could be fixed if we declare on each table which fields are numeric, and
take that into account when doing the conversion.
What do you think?
"""

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:25:53 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-wTENFo8FXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:25:53 +0000
Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record
In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23677-70-7LXKHSYHTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24237


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237
[Bug 24237] The 406 response on the biblios end point should be more
discoverable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:25:59 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-E1gFJorIuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:26:54 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-2Q9EJQjyqf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908
[Bug 24908] Allow fetching text-formatted MARC data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:26:54 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-jrf1cYTKnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24237


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237
[Bug 24237] The 406 response on the biblios end point should be more
discoverable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:27:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:27:03 +0000
Subject: [Koha-bugs] [Bug 24237] The 406 response on the biblios end point
 should be more discoverable
In-Reply-To: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24237-70-AWlFQgyjRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:36:43 +0000
Subject: [Koha-bugs] [Bug 24911] Exception holidays treated as unique
 holidays in calendar
In-Reply-To: <bug-24911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24911-70-zAioeqebu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911

--- Comment #1 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Just to make clear, this only happens if exception is made for unique holidays.
Exceptions for holidays repeating weekly and yearly work properly. And now when
I looked closer, hint for option "Generate exceptions on a range of dates" says
"You can make an exception on a range of dates repeated yearly." and there
isn't option to make single exception for unique holidays like there is with
repeatable holidays. So... there shouldn't even be option to add exceptions for
unique holidays? How should this be handled, make exceptions work properly with
unique holidays or hide option "Generate exceptions on a range of dates" if
holiday is unique?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:44:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:44:15 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-0oobw337T6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101077|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101083&action=edit
Bug 24299: Add Unit test for 'reason' in transferbook

Test plan
1/ Run test and verify it passes
2/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 12:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 11:57:19 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-99I6BJQtOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bernardo, I have no idea how to fix that, but having the datatype in the yml
sounds wrong to me.
We could retrieve it from the DBIC schema, but that will make the process
heavier (time)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:00:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:00:14 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-fiKLIhOMZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101075|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101084&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

This patch adds the RotatingCollection value to the database enum for
branchtransfer.reason

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:00:17 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-cuEPcg6Ca0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101076|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101085&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

This patch adds support for passing a trigger to
C4::Circulation::transferbook and passes 'RotatingCollection' to it when
called inside the rotating collections routine.

Test plan:
1/ Perform a rotating collection transfer operations
2/ Check the database for instances of 'RotatingCollection' in the
branchtransfers.reason field.
3/ Signoff

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:00:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:00:20 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-RwTrjaMMeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101083|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101086&action=edit
Bug 24299: Add Unit test for 'reason' in transferbook

Test plan
1/ Run test and verify it passes
2/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:01:37 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-buPjogHkne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100628|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101087&action=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:01:40 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-6pN4E1u78S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100629|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101088&action=edit
Bug 24436: Add handling for reserve transfer triggers

To test:
1 - Place a hold for pickup at a different branch than you are signed in at on
an item owned by current branch
2 - Check in the item
3 - Confirm the transfer
4 - Check the branchtransfers table and note the reason is 'Reserve'
5 - Set the preference CanMarkHoldsToPullAsLost to allow
6 - Place a hold on an item at branch you are singed in at
7 - Ensure you are not using strict sql modes (bug 22431)
8 - Go to Circulation->Holds to pull
9 - Mark hold as lost
10 - Check branchtransfers and confirm reason is "LostReserve"
11 - Check in item from step 1 at the correct branch
12 - Go to Circulation->Holds awaiting pickup
13 - Cancel the reserve
14 - Check branchtransfers and confirm reason is "CancelReserve"

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:01:53 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-GPZGquHbtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:18:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:18:23 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-KhRPWQqFta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:18:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:18:26 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-gRuaQgALXA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100689|0                           |1
        is obsolete|                            |
 Attachment #100690|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101089&action=edit
Bug 24830: Add tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:18:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:18:40 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-5tlvGqDBwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101090&action=edit
Bug 24830: Fix parse_prefetch recursion and +count cases

When a child of a prefetched element wasn't found on element's
prefetch_whitelist, no prefetch element was returned.. including element
it self. Now we return element's name if no child was found.

Also, embeded keys that ended with +count where taken literaly. Now we
search the correct key by stripping _count of embedded element if it was
declared as "is_count"

To test:
1. Apply test patch but not this one
2. prove t/Koha/REST/Plugin/Query.t
CHECK => tests shoul fail
3. Apply this patch
4. prove t/Koha/REST/Plugin/Query.t
SUCCESS => tests pass
5. Sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:24:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:24:11 +0000
Subject: [Koha-bugs] [Bug 19642] If autoMemberNum is enabled,
 we should just ignore cardnumber entry in BorrowerMandatoryField
In-Reply-To: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19642-70-JpqszLiqQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Nick, are you proposing not showing the cardnumber field on member entry if
automembernum is on? That would create a problem for  libraries that want to
use automembernum for online self-reg patrons but not for registrations
performed by staff. Unless we split automembernum into two sysprefs, one for
intranet and one for staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:26:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:26:35 +0000
Subject: [Koha-bugs] [Bug 22707] Allow manual definition of AutoMemberNum
 range
In-Reply-To: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22707-70-H8FeSpPNak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22707

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Our current flood of libraries trying to set up online self-reg is highlighting
the problems with AutoMemberNum as it exists now. Giving this a bump.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:26:44 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-8XOt08UB6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:28:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:28:45 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-bYgz7qQFU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:28:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:28:48 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-GAlM9Jceva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99511|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101091&action=edit
Bug 23411: Do not fall back to 'email' for SMS messages

To test:
 1 - Have a patron wiht an sms number, but no email
 2 - Enable sms by setting SMSDriver syspref to Email
 3 - Set Notice triggers to send an overdue via sms and email
 4 - Ensure the selected notice is defined only for 'email'
 5 - Checkout an overdue to the patron above
    You can set a specify a due date in the past
 6 - perl misc/cronjobs/overdue_notices.pl -t
 7 - Check the patron notices tab, they have a print notice and an SMS notice
pending
 8 - The SMS notice used the 'email' template
 9 - Apply patch
10 - sudo koha-mysql kohadev
11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above};
12 - Run the cron again
13 - Patron should have a print notice queued, no sms
14 - Define an SMS notice
15 - delete the message queue
16 - Run again
17 - The patron should have a print and an SMS

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:29:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:29:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-1uxAYaDF6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #69)
> (In reply to Nick Clemens from comment #68)
> > Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any
> > fields in items, either individually or via batch edit - things like
> > 'onloan' and 'itemlost_on' are successfully nulled as they should be.
> 
> Fixed, see "Use new method Koha::Object->set_or_blank"

Batch modification to blank fields is still now working. Individual edits do
work.

Importing and replacing items does not work - the process hangs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:29:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:29:16 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-zuMRVLonmv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I still have the feeling that something is not 100% correct here, but cannot
find what, so passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:29:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:29:50 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-myG9Q8dW9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101091|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101092&action=edit
Bug 23411: Do not fall back to 'email' for SMS messages

To test:
 1 - Have a patron wiht an sms number, but no email
 2 - Enable sms by setting SMSDriver syspref to Email
 3 - Set Notice triggers to send an overdue via sms and email
 4 - Ensure the selected notice is defined only for 'email'
 5 - Checkout an overdue to the patron above
    You can set a specify a due date in the past
 6 - perl misc/cronjobs/overdue_notices.pl -t
 7 - Check the patron notices tab, they have a print notice and an SMS notice
pending
 8 - The SMS notice used the 'email' template
 9 - Apply patch
10 - sudo koha-mysql kohadev
11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above};
12 - Run the cron again
13 - Patron should have a print notice queued, no sms
14 - Define an SMS notice
15 - delete the message queue
16 - Run again
17 - The patron should have a print and an SMS

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:31:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:31:56 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-QTwlPBenO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100631|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101093&action=edit
Bug 23092: Add 'daterequested' to branchtransfers table

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:33:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:33:08 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-v93wtSqOvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> Bernardo, I have no idea how to fix that, but having the datatype in the yml
> sounds wrong to me.
> We could retrieve it from the DBIC schema, but that will make the process
> heavier (time)

Jonathan, yeah, sounds wrong but inevitable I think.
I was faced with the same problem a couple of years ago, when I wrote a script
to build sql from xml.
I was thinking now in something like

tables:
  - marc_tag_structure:
      translatable: [ liblibrarian, libopac ]
      numeric: [ repeatable, mandatory ]
      multiline: []
      rows:
        - tagfield: "999"
          liblibrarian: "SYSTEM CONTROL NUMBERS (KOHA)"
          libopac: "SYSTEM CONTROL NUMBERS (KOHA)"
          repeatable: 1
          mandatory: 0
          authorised_value: ""
          frameworkcode: ""

added 'numeric' to list those fields.
That will be ignored everywhere except for yml2sub

Anyway, I liked your other modifications to Bug 24883.
Could you consider to re-add your patches except yml2sql sub?
Let that sub live here until we found a clean way to make it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:35:58 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-8goXw1nvpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #23)
> (In reply to Marcel de Rooy from comment #22)
> > Coming back here now
> 
> Unassigning me as QA contact then. I was waiting for dependent bug to be
> ready actually.

Sorry for that. If you want to, go ahead. But I was wondering if we need to
define these two as dependent actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:36:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:36:47 +0000
Subject: [Koha-bugs] [Bug 19958] Allow the system preference AutoMemberNum
 to include a combination of numbers and letters when creating a new barcode
In-Reply-To: <bug-19958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19958-70-rPhAISDmH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19958

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22707

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:36:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:36:47 +0000
Subject: [Koha-bugs] [Bug 22707] Allow manual definition of AutoMemberNum
 range
In-Reply-To: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22707-70-JlAw4Jz4t5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22707

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19958

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:37:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:37:33 +0000
Subject: [Koha-bugs] [Bug 19958] Allow the system preference AutoMemberNum
 to include a combination of numbers and letters when creating a new barcode
In-Reply-To: <bug-19958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19958-70-beofHcgOj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19958

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Added a see also to a bug I filed about allowed manual definition of
automembernum's values

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:39:42 +0000
Subject: [Koha-bugs] [Bug 24911] Exception holidays treated as unique
 holidays in calendar
In-Reply-To: <bug-24911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24911-70-xyZOSvEnBu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911

--- Comment #2 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Ok, did some digging and I might have answered to my question myself. Patch
with an option to generate exceptions on range for unique holidays was
introduced in bug 7351. So it is where it should be, text in the hint just
confused me. Sorry about this monologue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:39:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:39:59 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-M42PqUEl8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101094&action=edit
Bug 24754: (QA follow-up) Add timestamp, remove 11th parameter

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:45:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:45:17 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-lmfnvKeYHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100891|0                           |1
        is obsolete|                            |
 Attachment #100892|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101095&action=edit
Bug 24553: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:45:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:45:27 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-mZej3dFD1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101096&action=edit
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron

The drop_hold routine was using the wrong parameter for item info in the
patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both
waiting and unavailable
holds

To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!

You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling
a hold
and check the messages, test coverage is improved by this patch and should be
sufficient
for testing

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:58:07 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-t4MxO903vL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:58:09 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-dHY0uuXh9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101086|0                           |1
        is obsolete|                            |

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101097&action=edit
Bug 24299: Add Unit test for 'reason' in transferbook

Test plan
1/ Run test and verify it passes
2/ Signoff

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:59:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 12:59:11 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-vLovyGlZZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Small patchset in this chain, works as expected and tested, passing QA.

Don't forget to pull the Schema changes out of first patch and regenerate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:00:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:00:57 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To: <bug-8868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8868-70-pkzrlw2uSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Have to say (after such a long time) that item_id is a misleading parameter. It
would be easier to use a biblionumber, itemnumber or reserve_id.
Reason to open a new report ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:01:42 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-LwtSsd62K6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:01:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:01:45 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-9E1gcBopuR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100900|0                           |1
        is obsolete|                            |
 Attachment #100957|0                           |1
        is obsolete|                            |
 Attachment #100958|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101098&action=edit
Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the
guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of
memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki District Council, NZ

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: George Veranis <gveranis at dataly.gr>
Followed the test plan, works as expected. The only failure was
t/DateUtils.t test which will be fixed by Bug 24850.
Also corrected a small typo in the sponsored-by trailer.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:01:53 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-WYe5U7uL82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101099&action=edit
Bug 23808: (follow-up) Display card number in 'Guarantor information' in
memberentry.pl

Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber
in 'Guarantor information' we should display 'Patron card number:' with
the cardnumber displayed as that value is more meaningful to librarians.
The hyperlink containing the borrowernumber should stay the same so that
librarians can easily visit the patron record of existing guarantor
patrons.

Test plan:

1. Apply first patch and follow it's test plan

2. On an Adult patrons record select 'Add guarantee'

3. In 'Guarantor information' section of memberentry.pl observe in the
pre-filled guarantor information there is
a line 'Patron #:' with a link displaying a borrowernumber (not card number)
and when you click on the link it takes you to the adult/guarantors patron
account

4. Select 'Search to add' and search and add another guarantor

5. Observe in the added guarantor 'Patron #:' is displayed along with
the borrowernumber (not card number). The borrowernumber displayed in
not a link.

6. Apply this patch

7. On a adults patron select 'Add guarantee'

8. Observe in 'Guarantor information' section the pre-filled guarantor
now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link
now displays the guarantors cardnumber.
Clicking on the link still takes you to the guarantors patron account

9. Repeat step 4

10. Observe in the added guarantor they also have 'Patron card number:'
(instead of 'Patron #:'). A cardnumber rather than borrowernumber is
displayed. The cardnumber is not a link.

11. Confirm tests still pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:01:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:01:56 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-8vDGCaBVzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101100&action=edit
Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor
patron in memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',
'Secondary email', 'Fax' have been pre-filled from the guarantor's
record

5. Fill out the rest of the memberentry.pl and 'Save' and observe that those
contact
details are successfully saved

6. Repeat step 4 and alter the 'Primary phone' and 'Primary email'
fields and save and observe that those altered values are saved

7. Run tests and confirm they pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:01:59 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-ag69WitR4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101101&action=edit
Bug 23808: (follow-up) Object methods can be used directly, no need for
unblessed

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:06:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:06:15 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-STOn9m1fTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:06:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:06:18 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-mrCSgoHZ6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100321|0                           |1
        is obsolete|                            |
 Attachment #100322|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101102&action=edit
Bug 8595: Rename 'host item' to 'host record'

To test:

1) Enable the syspref EasyAnalyticalRecords
2) Find a biblio record, go to the detail page
3) Click the Edit dropdown and notice the option "Link to host item"
4) Apply patch and refresh page
5) Click the Edit dropdown and confirm the renamed "Link to host record"
button

Sponsored-by: Catalyst IT

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Change makes sense, no errors.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:06:28 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-EeY9Iz74qa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101103&action=edit
Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host
record'

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:20:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:20:26 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-6VnDOHgJ9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:20:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:20:29 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-9EtYeNxzSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100908|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101104&action=edit
Bug 13775: Set main headings to mandatory in authority frameworks

For MARC21 we need to set the following tags as mandatory:
  CHRON_TERM => 148
  CORPO_NAME => 110
  GENRE/FORM => 155
  GEOGR_NAME => 151
  MEETI_NAME => 111
  PERSO_NAME => 100
  TOPIC_TERM => 150
  UNIF_TITLE => 130

Note that it also fixes an error on the UI, which was initially reported
on bug 13775.

Test plan:
- Create a fresh install in the language of your choice.
- Confirm that when you create a new authority you cannot save without
entering a value for the main heading

- Edit marc record's field 648 -> chronological term
- Try to add there one by clicking a link on the left side of the field.
>From there it opens me to a new window, click "Create a new authority"
Click on the authority creating fields randomly, save.
=> Without this patch an error occurred "Can't call method "subfields"
on an undefined value at authorities/blinddetail-biblio-search.pl line 88."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed conflict in english version.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:20:38 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-xm4zxScXX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100909|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101105&action=edit
Bug 13775: Set main headings to mandatory in authority frameworks (UNIMARC)

Same as previously, for UNNIMARC

For unimarc_complet:
CLASS => 245
CO => 210
CO_UNI_TI => 235
EXP => 232
FAM => 220
GENRE/FORM => 280
NAME_COL => 245
NP => 200
NTEXP => 242
NTWORK => 241
PA => 260
PERS => 223
PUB => 217
SAUTTIT => 240
SNC => 250
SNG => 215
TM => 216
TU => 230
WORK => 231

For unimarc_lecture_pub:
CO => 210
NP => 200
SAUT => 200
SAUTTIT => 240
SCO => 210
SNC => 250
SNG => 215
STU => 230
TU => 230

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:24:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:24:01 +0000
Subject: [Koha-bugs] [Bug 24913] New: Self registration: Ask users to enter
 email address twice
Message-ID: <bug-24913-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24913

            Bug ID: 24913
           Summary: Self registration: Ask users to enter email address
                    twice
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

A number of patrons don't enter their email address correctly in the self
registration form in the OPAC and don't receive the verification emails. 
It would be nice if Koha asked for the email address to be entered twice (with
no copy allowed?) to help avoid typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:27:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:27:51 +0000
Subject: [Koha-bugs] [Bug 24914] New: Saving a record as MARC (Unicode/UTF-8,
 Standard) remove items
Message-ID: <bug-24914-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24914

            Bug ID: 24914
           Summary: Saving a record as MARC (Unicode/UTF-8, Standard)
                    remove items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In catalogue/export.pl for this one format 'marcstd' we call the subroutine
marc2marc

This subroutine builds a list of 'private_fields' - which is any field with 9
in the tag. These are then removed from the record. This includes all item tags

To recreate:
1 - Find a record with some items and view the details page
2 - Save record -> MARC (Unicode/UTF-8, Standard)
3 - Open record in marcedit, or stage for import into koha
4 - Note all 9 fields and items are gone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:28:46 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-3hZSKv4dYP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Having doubts if we should add userenv if there is already a login. If there is
no login, the current approach seems fine to me. But if we have a login (by
cookie from opac or intranet login), we loose the information which user
triggered the action. Currently, such actions are saved into action_logs with
the current user.

|      2646 | 2020-03-20 13:05:58 |    0 | HOLDS            | CANCEL |    181 |
=> This patch causes 0
|      2648 | 2020-03-20 13:17:12 |   51 | HOLDS            | CANCEL |    182 | 
=> Without patch, login from intranet
|      2652 | 2020-03-20 13:23:29 |   51 | HOLDS            | CANCEL |    183 | 
=> Without patch, login from opac

Keeping in FQA. Needs feedback

Please add why we need the dependency. Only for the test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:30:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:30:01 +0000
Subject: [Koha-bugs] [Bug 24914] Saving a record as MARC (Unicode/UTF-8,
 Standard) remove items
In-Reply-To: <bug-24914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24914-70-m1NGYI11kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24914

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7345


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7345
[Bug 7345] Should be possible to export MARC records without private fields
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:30:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:30:01 +0000
Subject: [Koha-bugs] [Bug 7345] Should be possible to export MARC records
 without private fields
In-Reply-To: <bug-7345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7345-70-KbhwSGxw2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7345

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24914


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24914
[Bug 24914] Saving a record as MARC (Unicode/UTF-8, Standard) remove items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:30:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:30:34 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-9ZI95Tkc1L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:30:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:30:36 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-YGA5tIJoc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100893|0                           |1
        is obsolete|                            |
 Attachment #100894|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101106&action=edit
Bug 22025: Add a regression test

Signed-off-by: Magnus Enger <magnus at libriotech.no>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:30:45 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-Q1VUUyMlD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101107&action=edit
Bug 22025: Remove warnings when importing patrons

The following warning is raised when importing patrons
Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1018

if one of the following headers is passed but does not have a value:
 * privacy
 * privacy_guarantor_fines
 * privacy_guarantor_checkouts
 * anonymized

Test plan:
- Do not apply the patch
- Generated a csv file with at least one those headers
- Import it using the import_patrons.pl script (or using the GUI)
- Notice the warnings without the patch
- Apply the patch
- Confirm that the warnings do not longer appear

Signed-off-by: Magnus Enger <magnus at libriotech.no>
Applied the patch on a live server and the warnings went away.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:36:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:36:04 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-iFfIJQMO7s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:36:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:36:07 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-aItRMTPhRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100899|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101108&action=edit
Bug 24848: Improve manual links for the label creator

Some of the manual links in the label creator tool were
not working correctly or pointing to the wrong pages.

A problem is the label-manage.pl file. This can show
different data depending on an added parameter. Example:
/cgi-bin/koha/labels/label-manage.pl?label_element=template

But it appears that parameters will be ignored when creating
links to the manual. So this patch links to the beginning
of the label creator section in the manual for now.

To test:
- Go to the lable creator
- Try the various pages of the tool
  - Note: All 'New ...' links should point to the
    correct section in the manual (batches, templates, ...)
    Except: Barcode range. This feature is new and not
    yet documented in the manual. Link goes to label creator section.
  - Note: All 'Manage ...' links should point to the
    beginning of the 'label creator' section in the manual

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:36:17 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-3l3VFJwrZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:40:30 +0000
Subject: [Koha-bugs] [Bug 24915] New: rrr
Message-ID: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24915

            Bug ID: 24915
           Summary: rrr
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bajoe619 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 101109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101109&action=edit
fff

gggggg

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:41:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:41:42 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-BnkbLdiAiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101108|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101110&action=edit
Bug 24848: Improve manual links for the label creator

Some of the manual links in the label creator tool were
not working correctly or pointing to the wrong pages.

A problem is the label-manage.pl file. This can show
different data depending on an added parameter. Example:
/cgi-bin/koha/labels/label-manage.pl?label_element=template

But it appears that parameters will be ignored when creating
links to the manual. So this patch links to the beginning
of the label creator section in the manual for now.

To test:
- Go to the lable creator
- Try the various pages of the tool
  - Note: All 'New ...' links should point to the
    correct section in the manual (batches, templates, ...)
    Except: Barcode range. This feature is new and not
    yet documented in the manual. Link goes to label creator section.
  - Note: All 'Manage ...' links should point to the
    beginning of the 'label creator' section in the manual

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:41:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:41:59 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-rbXaipJYim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Julian Maurice from comment #20)
> > (In reply to David Cook from comment #19)
> > > You can already retrieve that information using Perl though. What scenario
> > > do you see someone using it maliciously?
> > 
> > Templates can be used in "Tools » Notices & Slips", they can be written by
> > users.
> 
> I agree, that's definitely wrong.
> 
> Fridolin, you should pass the variable the dirty way, from C4::Auth.

Maybe we can find something better than the dirty way and the security-hole
way, like a method ArePluginsEnabled in Koha::Template::Plugin::Koha ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:42:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:42:04 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-bfiKLhIEiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:42:07 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-jtTaWtivE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101095|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101111&action=edit
Bug 24553: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:42:12 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-tVgsRw3jw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101096|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101112&action=edit
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron

The drop_hold routine was using the wrong parameter for item info in the
patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both
waiting and unavailable
holds

To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!

You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling
a hold
and check the messages, test coverage is improved by this patch and should be
sufficient
for testing

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:42:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:42:32 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-OPieFsAPem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:43:21 +0000
Subject: [Koha-bugs] [Bug 24916] New: zzzz
Message-ID: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24916

            Bug ID: 24916
           Summary: zzzz
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: bajoe619 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101113&action=edit
szz

szs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:43:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:43:38 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-RR5mMcQIXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Kyle: we're clashing now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:44:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:44:44 +0000
Subject: [Koha-bugs] [Bug 24917] New: ddd
Message-ID: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24917

            Bug ID: 24917
           Summary: ddd
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bajoe619 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 101114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101114&action=edit
sss

ddd

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:45:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:45:56 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-8K2M7rmE9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:45:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:45:58 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-tjVcIt6JKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101055|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101115&action=edit
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at
/usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:52:36 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-Vq6BDz0vmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #26)
> Having doubts if we should add userenv if there is already a login. If there
> is no login, the current approach seems fine to me. But if we have a login
> (by cookie from opac or intranet login), we loose the information which user
> triggered the action. Currently, such actions are saved into action_logs
> with the current user.

ILSDI does not depend on user authentication, the permissions of the user to
edit  items or place holds etc do not match. ILSDI is its own way to interact
with KOha - I think in these instances it is more correct to indicate a system
user as opposed to sign in user.

The trigger for this patch was actually the Aspen discovery system. The ILSDI
calls are routed from a central server which is also passing other calls to
Koha. We began to see holds being manipulated by random patrons - because
without a session set explicitly for ILSDI any other session from the server
was being picked. It was causing logging issues and confusion

> Please add why we need the dependency. Only for the test plan?

Yes, I think there were small differences in logs with those patches, so they
are related

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:53:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:53:03 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-pqMbbNui4d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

--- Comment #6 from didier <didier.gautheron at biblibre.com> ---
Hi, thanks for you reply.

(In reply to Andreas Roussos from comment #2)
> 1) "Author: Didier GAutheron" <- unless you want to be credited this way
Oops, thanks.

> 
> 2) "BUG 24740: [...]": as per the official guidelines in the Koha wiki
>    (https://wiki.koha-community.org/wiki/Commit_messages#Subject_line)
>    the word "Bug" should be capitalised, and not be in all uppercase,
>    otherwise the QA tools will complain.
Will do.

> 
> 3) The QA tools will also flag the missing filters at the lines where
>    you've added [% img_title %], this is due to the coding guidelines'
>    requirement that _all_ template variables must be filtered:
>
Same.

> 4) You have used hard tabs to indent some of the code in your patch,
>    the QA tools will notice this. I suggest you change them to soft
>    tabs (spaces). The offending lines are:
Note:
Tips in wiki guidlines seem to be wrong, 
You can fix tabs by using 
git config --global core.whitespace trailing-space,space-before-tab
git config --global apply.whitespace fix

Don't replace tab, I have it but still get tab.

> 
>    254 and 256 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>    327 and 329 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
> 
> 5) Should we take this opportunity and fix the cover tooltip in the biblio
>    details page as well? And the shelf browser, too?
> 
>    The relevant TT files are:
>    koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>    koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
I'll look at it.

Regards
Didier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:54:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:54:11 +0000
Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with
 delete_patrons.pl
In-Reply-To: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18414-70-x0HCxy0efw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:54:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 13:54:14 +0000
Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with
 delete_patrons.pl
In-Reply-To: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18414-70-EFgox8Sw4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96574|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101116&action=edit
Bug 18413: Allow to use other select criteria with delete_patrons.pl

Adds the ability to specify a file with the --file flag that
should be a list of borrowernumbers for deletion.
If used without other flags it will delete the list of borrowers,
if used with other flags it will treat the other criteria
as filters for the list.

To Test:
1) Specify a list, e.g. borrowers.txt, of borrowernumbers in the database and
put them in a text file with one per line
2) Invoke the script like ./delete_patrons.pl --file borrowers.txt to delete
those patrons
3) Populate the list with a mix of borrowers in a category and those not, say
categoryfoo
4) Invoke the scirpt as ./delete_patrons.pl --category_code categoryfoo --file
borrowers.txt
5) Only the borrowers in the file that have the specified category will be
deleted

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=18414

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:07:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:07:08 +0000
Subject: [Koha-bugs] [Bug 24916] zzzz
In-Reply-To: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24916-70-pAiAV0SLZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24916

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101113|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:07:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:07:20 +0000
Subject: [Koha-bugs] [Bug 24916] SPAM
In-Reply-To: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24916-70-efNId8jCI8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24916

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|zzzz                        |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:07:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:07:55 +0000
Subject: [Koha-bugs] [Bug 24917] ddd
In-Reply-To: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24917-70-RjILD19cwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24917

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101114|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:08:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:08:09 +0000
Subject: [Koha-bugs] [Bug 24917] SPAM
In-Reply-To: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24917-70-VOzE0C49Hf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24917

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ddd                         |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:09:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:09:21 +0000
Subject: [Koha-bugs] [Bug 24915] SPAM
In-Reply-To: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24915-70-vmAOiFoftu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|rrr                         |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:09:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:09:36 +0000
Subject: [Koha-bugs] [Bug 24915] SPAM
In-Reply-To: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24915-70-RFuAwcaqGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101109|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:09:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:09:50 +0000
Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout
 history
In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18795-70-i2TmpqeuEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:17:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:17:33 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-3kXta3r0Xa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #70)
> (In reply to Jonathan Druart from comment #69)
> > (In reply to Nick Clemens from comment #68)
> > > Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any
> > > fields in items, either individually or via batch edit - things like
> > > 'onloan' and 'itemlost_on' are successfully nulled as they should be.
> > 
> > Fixed, see "Use new method Koha::Object->set_or_blank"
> 
> Batch modification to blank fields is still now working. Individual edits do
> work.


I fixed that one.

> Importing and replacing items does not work - the process hangs.

I am not sure about that one.
I got "DBD::mysql::st execute failed: Incorrect integer value: 'duplicate item
barcode' for column 'itemnumber'" But not sure it's a bug from master or not.

Could you retry the import? If it fails, can you remove 
334         close STDOUT;
335         close STDERR;
from tools/manage-marc-import.pl
To get the error in the logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:19:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:19:49 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-4cXyXfag5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:22:20 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-9Mi1foAm76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:22:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:22:22 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-qgdsppuyP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100435|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101117&action=edit
Bug 24688: Check the priority of the fulfilled hold when fixing priorities

Currently when fixing priorities of existing holds, priorities aren't
fixed when checking out a middle priority hold because the hold has been
fulfilled and deleted. This patch adds a check for, if the hold can't be
found, an old hold with the required reserve_id.

To test:
1. Place at least four holds on a biblio for different borrowers
2. Check out an item to the 3rd priority borrower
3. Check the existing holds table for the biblio. The priorities might be
out of order, or try clicking the dropdowns and there might be an empty
dropdown option, or open the browser developer tools and notice the option
values in the select are missing value=3.
4. Apply patch and restart memcached
5. Check out an item to the 2nd priority borrower
6. Check the existing holds table for the biblio. Confirm the priorities
have been fixed and are now consecutive with no gaps.

Sponsored-by: Chartered Accountants Australia and New Zealand
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:24:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:24:19 +0000
Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout
 history
In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18795-70-WBJuVBG3yy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:25:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:25:03 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-OtOnkjlsoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:31:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:31:10 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-oLtZD6uJqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #8 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I've tested for Association KohaLa.
The data in the tables pseudonymized_transactions and
pseudonymized_borrower_attributes are correctly deleted when using
--pseudo-transactions flag for cleanup_database.pl
I tried it with a number of days and also with the choice of dates :
--pseudo-transactions --pseudo-transactions-from YYYY-MM-DD
--pseudo-transactions-to YYYY-MM-DD 
and both work correctly.

Thanks!

Sonia BOUIS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:33:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:33:02 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-neIooW2FVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:33:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:33:05 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-3zlnAwuhI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100453|0                           |1
        is obsolete|                            |
 Attachment #100454|0                           |1
        is obsolete|                            |
 Attachment #100455|0                           |1
        is obsolete|                            |
 Attachment #100456|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101118&action=edit
Bug 24052: Rename XSLT_Handler

Should be XSLT::Base now.
Removes old XSLT_Handler stub too (from bug 23290).
Result of a git grep | sed statement.

Test plan:
Run qa tools (so modules compile).
Run t/db_dependent/Breeding.t
Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch
has been applied; see subsequent patch.)
Enable XSLT use on results and details display. Check search results and
detail view on OPAC and staff.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:33:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:33:14 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-k5OLnSlyNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101119&action=edit
Bug 24052: Fix Koha/XSLT/Base.t

Moving the separate small attachments into the test script.
Creating them now as temporary files or code fragments.
Deleting original files.

Since Breeding.t also used one of these files, a similar change was made in
that script.

Test plan:
Run t/db_dependent/Koha/XSLT/Base.t. Should pass now.
Run t/db_dependent/Breeding.t again.
Git grep on XSLT_Handler. You should only find release notes.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:33:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:33:17 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-HTJfKEUDlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101120&action=edit
Bug 24052: Catch warning between test 5 and 6

Resolve:
ok 5 - Engine returns error on undefined text
XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214.
ok 6 - Engine returns error on empty string

Test plan:
Run perl Base.t and verify that this warning is no longer printed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:33:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:33:19 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-hs0cXnALmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101121&action=edit
Bug 24052: Add koha_xslt_security to koha-conf.xml

The line for enabling the unsafe expand_entities option is commented
and includes a warning to keep it like that ;)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:35:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:35:31 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Anso2XcWTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #72 from Nick Clemens <nick at bywatersolutions.com> ---
Last follow-up fixes those issues, everything else I tried worked well.

Passing QA, excellent work here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:46:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:46:57 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-eZ3DOngHAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101122&action=edit
Bug 20443: Revert some stuffs from 12159

These methods have been added to Koha::Patron::Attribute but are wrong, see bug
18339

We should use ->type->$method instead

Moreover the tests exist in another subtest, we do not need them.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:01 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-7r2NhkWLBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101123&action=edit
Bug 20443: Remove opac_display and opac_editable from Patron::Attribute

Same as previously for methods that have been added by bug 17792.
It's better to be explicite and tell we are fetch the related attribute's type

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:04 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-f81v62eNlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101124&action=edit
Bug 20443: Move GetBorrowerAttributeValue to
Koha::Patron->get_extended_attribute_value

We want to retrieve a specific patron's attribute for a given patron.
We then add a new method to Koha::Patron.

This patch add a getter method ->get_extended_attribute_value
to use the DBIx::Class relation

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:08 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-w57cVkz65o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101125&action=edit
Bug 20443: Move GetBorrowerAttributes to Koha::Patron - ILSDI

FIXME See comment

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:12 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-tAtxSzyPMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101126&action=edit
Bug 20443: Move GetBorrowerAttributes to Koha::Patron->extended_attributes

The GetBorrowerAttributes subroutine return the attributes for a given
patron.

Using get_extended_attributes we can acchieve it easily. The problematic
here is to restore the method's name (value vs attribute,
value_description vs description of the authorised value, as well as
display_checkout that should not be a method of Attribute, but
Attribute::Type instead)

value_description was used when the attribute types were attached to an
authorised value category. To avoid the necessary test in template and
controller there is now a $attribute->description method that will
display either the attribute's value OR the value of the authorised
value when needed. We should certainly use this one from few other
places.

Notes:
* This patch rename Koha::Patron->attributes with
Koha::Patron->get_extended_attributes.
It will be renamed with Koha::Patron->extended_attributes in ones of the next
patches when it will become a setter as well.
* GetBorrowerAttributes did not care about the library limits, we still
do not
* The opac_only flag was not used outside of test, we drop it off.
* To maintain the existing behavior we add a default order-by clause to
the search method [code, attribute]
* From C4::Letters::_parseletter we always display the staff description
of the AV, There is now a FIXME to warn about it
* FIXMEs are not regressions, existing behaviors must be kept
* TODO add a new check to bug 21010 to search for inconsistencies in
patron's attributes attached to non-existent authorised values
* One test has been updated in Modifications.t, order_by is now
by default set to ['code', 'attribute']

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:16 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-Rie2aYCOf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101127&action=edit
Bug 20443: Improve filtering method

Koha::Patron::Attributes->search mimicks what is done in
Koha::AuthorisedValues->search.
But actually it should be more explicit when the caller use it.
For instance filter_by_branch_limitation (see discussion on bug 11983).

This will be useful for the following patches as we will need a way to
replace the $no_branch_limit flag.
When the $no_branch_limit flag is called, a simple ->search call should
be done.
When we want to limit on a specific library we can pass the branchcode
in paramter of filter_by_branch_limitation (this is not used yet).
If not passed the logged-in user library will be used by default.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:19 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-tMJgWb6pmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101128&action=edit
Bug 20443: Remove DeleteBorrowerAttributes

This subroutine was only used once, easy to replace.
SetBorrowerAttributes must replace the attributes for the ones logged-in
user is allowed to edit, that's why we filter by the library limits

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:23 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ZlvBjgm7wq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101129&action=edit
Bug 20443: Remove DeleteBorrowerAttribute

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:27 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ZD7eu9djVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101130&action=edit
Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttributes

This patch replace Koha::Patron->get_extended_attributes with
->extended_attributes
It's now a getter a setter method.

It permits to replace UpdateBorrowerAttribute and use
create_related from DBIx::Class

Notes:
* We face the same variable names difference than in a previous patch
(value vs attribute)

Bug 20443: Remove SetBorrowerAttributes

squash  + RM get_extended_attributes

 RM get_extended_attributes

SQUASH Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttribute

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:30 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-KRpIXTWGKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101131&action=edit
Bug 20443: Remove CheckUniqueness

There is already a method in Koha::Patron::Attribute to check the
uniqueness constraint, let us it to replace CheckUniqueness

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:34 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-4IwEi2YbUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101132&action=edit
Bug 20443: Move C4::Members::AttributeTypes::GetAttributeTypes to
Koha::Patron::Attribute::Types

We can then now start to move methods from C4::Members::AttributeTypes
as well.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:38 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-JGkXC2FqGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101133&action=edit
Bug 20443: Remove num_patron

Replace C4::Members::AttributeTypes->num_patron with
Koha::Patrons->filter_by_attribute_type

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:42 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-t8JO9P5wvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101134&action=edit
Bug 20443: Remove C4::Members::AttributeTypes

We do no longer need this package, we can use
Koha::Patron::Attribute::Types directly instead.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:45 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-3wdxVOgfOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101135&action=edit
Bug 20443: Remove SearchIdMatchingAttribute - prove we are not cheating

Tests are still passing that way, we can continue

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:49 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-XnYXQjqWv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101136&action=edit
Bug 20443: Remove SearchIdMatchingAttribute

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:53 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-gujYiqCv85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101137&action=edit
Bug 20443: Remove extended_attributes_merge

TODO We need tests here!

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:47:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:47:57 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-365GSTp2Bb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101138&action=edit
Bug 20443: Remove extended_attributes_code_value_arrayref AND
C4::Members::Attributes

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:00 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-TPCy0bdKlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101139&action=edit
Bug 20443: (follow-up) Move GetBorrowerAttributes to Koha::Patron - ILSDI

Either we display everything, or only the info from the attribute itself
(i.e. not its type)

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:04 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-CCxnBeHIlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101140&action=edit
Bug 20443: (follow-up) Fix t/db_dependent/Koha/Patrons.t

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:08 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-MT1DQjk3ND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101141&action=edit
Bug 20443: Fix Auth_with_ldap.t

Must be a hashref

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:12 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-NTWrClK8mp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101142&action=edit
Bug 20443: Use search_with_library_limits for attribute types

Dealt with that previously in the module during the rebase.
It conflicted with bug 23281.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:16 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-hk6MWEc2ZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101143&action=edit
Bug 20443: Fix Patrons/Import.t

->get_patrons has been removed but not replaced!

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:20 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ZfsYK2gCzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101144&action=edit
Bug 20443: Fix add/edit for checkboxes

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:24 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-r0AwjEgeFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101145&action=edit
Bug 20443: Fix POD

Fixes the following failures:

 FAIL   Koha/Patron/Attribute.pm
   FAIL   pod
                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attribute.pm

                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attribute.pm

 FAIL   Koha/Patron/Attributes.pm
   FAIL   pod
                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attributes.pm

   FAIL   pod coverage
                POD is missing for merge_with
                POD is missing for object_class

 FAIL   Koha/Patrons.pm
   FAIL   spelling
                 paramter  ==> parameter

except the missing pod for object_class, not needed.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:27 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-i6iqrVY8f3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101146&action=edit
Bug 20443: Fix creation of new patron with attributes

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:31 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-qj0ik0Ta2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101147&action=edit
Bug 20443: Do not explode if attribute does not have a valid av

Template process failed: undef error - Can't call method "lib" on an undefined
value at /kohadevbox/koha/Koha/Patron/Attribute.pm line 109.                   
                                                     at
/kohadevbox/koha/C4/Templates.pm line 122

We should not crash as it if the attribute is linked to an invalid
authorised value (for instance the AV has been deleted)

We must provide a check in the search_for_data_inconsistencies.pl script

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:35 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-6uSOfoaTK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101148&action=edit
Bug 20443: Fix patron modification approval

There was a mismatch between "value" and "attribute". Before this
patchset, "value" was sometimes used, but then it comes "attribute" to
match the DB column's name.
We must keep both here, when an upgrade is done we could have "value"
that is still in the borrower_modifications.extended_attributes JSON

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:39 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ogBmawIkbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101149&action=edit
Bug 20443: Handle non existent attribute when importing patrons

There is much more to do here, but this patch has the same behavior than
before: a warn is displayed in the log, the UI is not aware of it

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:48:42 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-kAOiApENNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101150&action=edit
Bug 20443: Fix merge_with behavior

merge_with were returning Koha::Patron::Attribute for existing attribute
and hashref for new attribute.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:07 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-TTLBJpvVvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101151&action=edit
Bug 23463: Replace SearchItemsByField by SearchItems

The subroutine SearchItemsByField is only called once and can be
replaced easily with SearchItems

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-qRZypm8n77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101152&action=edit
Bug 23463: Remove uneeded SearchItemsByField subroutine

It is no longer used.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-oAurzeg0hP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101153&action=edit
Bug 23463: fix for testbuilder - set default value items.damaged=0

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:18 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-AEEk0DdaHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-VW1YuHyALY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101154&action=edit
Bug 23463: Replace AddItem calls with Koha::Item->store

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:21 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-28Tlz3Lwb7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100531|0                           |1
        is obsolete|                            |
 Attachment #100532|0                           |1
        is obsolete|                            |
 Attachment #100533|0                           |1
        is obsolete|                            |
 Attachment #100534|0                           |1
        is obsolete|                            |
 Attachment #100535|0                           |1
        is obsolete|                            |
 Attachment #100536|0                           |1
        is obsolete|                            |
 Attachment #100538|0                           |1
        is obsolete|                            |

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101155&action=edit
Bug 24131: Move the print statement to a new subroutine

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:23 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NWyGbB895o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101156&action=edit
Bug 23463: Remove _set_defaults_for_add

_set_defaults_for_add is no longer needed as it is handled by dbic and
koha::object->store

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:28 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-4xOjCab0wS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101157&action=edit
Bug 23463: Replace _set_derived_columns_for_add

Remove the unique call to _set_derived_columns_for_add
Even if design to deal with other values it only dealts with cn_sort

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:32 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-BmUJUAncbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101158&action=edit
Bug 23463: AddItem removing

We are done with AddItem, only need to log and index.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:33 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-d0UHrEc16a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101159&action=edit
Bug 24131: Handle several descriptions

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:36 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-6rmG3Ov2J6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101160&action=edit
Bug 24131: (follow-up) Fix and rebase

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:36 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-gcO4vBApgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101161&action=edit
Bug 23463: Replace ModItem with Koha::Item->store

Starting to replace the ModItem calls with Koha::Item->store

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:39 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-8NvA3hgsEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101162&action=edit
Bug 24131: (follow-up) Another rebase

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:40 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-d1PeUpOEc8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101163&action=edit
Bug 23463: remove trivial UpdateHoldingbranch sub

We do not need this subroutine, moving it where it is used.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:41 +0000
Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout
 history
In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18795-70-0cf4gSpILB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi Johanna. Nice and clean work!

A few remarks from the QA POV:
- Our API design mojo is: 'As RESTful as we can'. In this context, we should
consider the 'checkout history of a patron' a resource, and as such it feels
more appropriate to put the patron id on the path, like in:

DELETE /patrons/{patron_id}/checkouts/history

Then we can reserve this route you were using for batch anonymizing :-D like in

DELETE /checkouts/history?q=more_complex_query_on_patrons

- There are some response definitions missing on the spec, (503 for maintenance
mode, 500 for internal server error, and so on).

- Put the tests on a separate subtest please to avoid interference if some
changes are made to the previous tests/data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:42 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-qk1Xdesu4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101164&action=edit
Bug 24131: (QA follow-up) Formatting in web client

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:45 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-PMjqaVn2rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101165&action=edit
Bug 23463: Move plugin hook

>From C4::Items to Koha::Item

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:46 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-OEGu3lHEKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101166&action=edit
Bug 24131: Remove bullet points for secondary descriptions

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:49 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-Rsc39lNmKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101168&action=edit
Bug 24131: Always display bug numbers on 5 characters

To correctly align bug numbers < 10000

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:49 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-czvWwtW50V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101167&action=edit
Bug 23463: _set_derived_columns_for_mod was only used for cn_sort

Same as _set_defaults_for_add

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:52 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-eeKYcHT6E0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101169&action=edit
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp
moved

That's done in Koha::Item->store, and Koha::Object->store for integers.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:50:56 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Mb2AYWjgrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101170&action=edit
Bug 23463: Remove _mod_item_dates

We did not do anything useful here.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:00 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ZcIOhaKd1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101171&action=edit
Bug 23463: Remove ModItem

There should not be any calls left

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-R813DX8I3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101172&action=edit
Bug 23463: Remove DelItem

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:07 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ZKE2hjxFFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101173&action=edit
Bug 23463: Remove DelItemCheck and ItemSafeToDelete

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Q7w32lYflh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101174&action=edit
Bug 23463: Remove no longer needed subs related to default values

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-s3TJoRgs7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101175&action=edit
Bug 23463: Fix CancelReceipt.t

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-jJ7byZCC36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101176&action=edit
Bug 23463: Fix failing tests

And adding a FIXME about discard_changes

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:24 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-MssNYhp2ep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101177&action=edit
Bug 23463: Getting less item-level_itypes warnings (?)

So, we get less warnings. I do not really understand why...

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:27 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Yf7sFY1Wnq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101178&action=edit
Bug 23463: Fix AutomaticItemModificationByAge.t

We do not want to log if nothing changed

How could we do that better?

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:31 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-cWtn6U66uD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101179&action=edit
Bug 23463: update permanent_location if location has been updated

This change to Koha::Item->store seems correct here, but tests from
/db_dependent/Items.t is failing now.

Adjusting them to make them pass.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:35 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-yIRlyWLpHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101180&action=edit
Bug 23463: Fix items.cn_source vs cn_source

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:40 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-yxCOg6BT7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #96 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101181&action=edit
Bug 23463: build cn_sort only if needed

No need to calculate cn_sort if not dirty when we store

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-o66DBC1pmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101182&action=edit
Bug 23463: Replace recently added occurrences

Few occurrences have been added since this patchset has been originaly
written

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:47 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-aKtH7qtZS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101183&action=edit
Bug 23463: cn_sort needs to be updated if cn_source changed

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:51 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-8yBrrb9noN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101184&action=edit
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete

Wrong replacement in additem.pl

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:55 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-HoyBQNXHwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101185&action=edit
Bug 23463: Fix timestamp default value

This sounds wrong as we should let the DBMS do that, but it was failing.
Here we are doing the same as Koha::Patron->store for dateenrolled

To recreate the failure, prove t/db_dependent/Koha/Item.t without this
patch:
DBD::mysql::st execute failed: Column 'timestamp' cannot be null [for
Statement "UPDATE `items` SET `more_subfields_xml` = ?, `timestamp` = ?
WHERE ( `itemnumber` = ? )" with ParamValues: 0='<?xml version="1.0"
encoding="UTF-8"?>

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:51:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:51:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-iRWldkL4Nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #101 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101186&action=edit
Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t
subtest

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:02 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-iHG7kH4tJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101187&action=edit
Bug numbers don't align

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:03 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-KRjtfkyNez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101188&action=edit
Bug 23463: (follow-up) Fix timestamp default value

For discussion, this patch revert the changes made previously.

This line exists in Koha::Item->store as it is the translation of:
    if (exists $item->{'timestamp'}) {
        delete $item->{'timestamp'};
    }
that was coming from _do_column_fixes_for_mod (called from ModItem)

To preserve existing behavior I would be in favor of keeping it like that to
avoid regression, and deal with it separately if we want to improve/remove it.

So basically here we are setting it to undef in Koha::Item->store to make it
handle correctly by the parent Koha::Object->store. I agree that's kind of
weird
and must be improved.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:06 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-MGe6LxBdOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #103 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101189&action=edit
Bug 23463: Fix safe_return return value in deletion tools

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:10 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-SN8mlpkyXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #104 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101190&action=edit
Bug 23463: Fix tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:14 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-XVNuAohrRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #105 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101191&action=edit
Bug 23463: Fix IsItemIssued.t

It seems that some of those tests could be removed as safe_delete is
widely tested in Koha/Item.t

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:18 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-KsYibVFDoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #106 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101192&action=edit
Bug 23463: Fix cn_source for new item

get_dirty_columns only work for existing items.

This fixes t/db_dependent/ShelfBrowser.t

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:22 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-v2X0UtRdMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #107 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101193&action=edit
Bug 23463: Fix XSLT.t

>From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0
     Bug 23463: Replace AddItem calls with Koha::Item->store

in build_sample_item:
-    my $itype = delete $args->{itype}
-      || $self->build_object( { class => 'Koha::ItemTypes' } )->itemtype;
+    # If itype is not passed it will be picked from the biblio (see
Koha::Item->store)

So before we generated a new itemtype if not passed, now we pick the one from
biblioitem->itemtype.

For this specific test we need to make sure they are different.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:26 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-MW6IErDR1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #108 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101194&action=edit
Bug 23463: Replace new occurrence of AddItem

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:30 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-hINTLbQNk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101195&action=edit
Bug 23463: Use new method Koha::Object->set_or_blank

This patch fixes an issue when editing items.

* The issue
Cannot blank a subfield when editing an item.
If you have an item with itemcallnumber=42, then edit it, blank it and
save. The itemcallnumber is still 42

* Why? (line numbers from https://gitlab.com/joubu/Koha/-/tree/bug_23463)
additem (and other item's edition forms) receives a list of tags,
subfields and values, generates a MARC::Record::XML then calls
ModItemFromMarc:

717     my $itemtosave=MARC::Record::new_from_xml($xml, 'UTF-8');
727         my $newitem = ModItemFromMarc($itemtosave, $biblionumber,
$itemnumber);

And ModItemFromMarc:
 282     my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
 283     $item->{cn_source} = delete $item->{'items.cn_source'}; #
Because of C4::Biblio::_disambiguate
 284     $item_object->set($item);

ModItemFromMarc never knows that the field has been blank.
Prior to bug 23463 we had a map of default values, and ModItemFromMarc
was doing:
 426     my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
 427     my $default_values = _build_default_values_for_mod_marc();
 428     foreach my $item_field ( keys %$default_values ) {
 429         $item->{$item_field} = $default_values->{$item_field}
 430           unless exists $item->{$item_field};
 431     }

I do not want to reinsert that list of default values.

Here I wrote a generic method in Koha::Object to set the value passed in
parameter,
or "blank" if not passed.
It's nulled if can be set to null in DB, or the default value is retrieved from
the schema info.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:34 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ebiv1G35YM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101196&action=edit
Bug 23463: (follow-up 2) Fix timestamp default value

Removing previous change, again.
But this time in Object.pm
It fixes t/db_dependent/Koha/Object.t and t/db_dependent/Koha/Item.t is
still passing.

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:38 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-hWGXfWtUp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #111 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101197&action=edit
Bug 23463: Fix items.cn_sort vs cn_sort

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:52:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:52:55 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-VI7m5meJzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Just a note that 4 character bug numbers won't align due to browsers collapsing
whitespace. Not a blocker IMO. Could be solved with CSS or just non-breaking
spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:40 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-Ci8cThPR51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:44 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-lw93HOY0qw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100440|0                           |1
        is obsolete|                            |
 Attachment #100441|0                           |1
        is obsolete|                            |
 Attachment #100442|0                           |1
        is obsolete|                            |
 Attachment #100443|0                           |1
        is obsolete|                            |
 Attachment #100444|0                           |1
        is obsolete|                            |
 Attachment #100445|0                           |1
        is obsolete|                            |
 Attachment #100446|0                           |1
        is obsolete|                            |
 Attachment #100447|0                           |1
        is obsolete|                            |

--- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101198&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:48 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-AE1UBjCWwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101199&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:52 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-0RLOENmIuw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101200&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:56 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-jut30rvyx1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101201&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:54:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:54:59 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-QcQIcsTCo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101202&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david at davidnind.com>

Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:55:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:55:04 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-BbJQ58EwbU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101203&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:55:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:55:07 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-JWC3JYX6t3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101204&action=edit
Bug 22844: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:55:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:55:11 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-wbsWM8OEaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101205&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:59:02 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-aHX6Zd7o8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:59:04 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-7zeFjzGKEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100540|0                           |1
        is obsolete|                            |
 Attachment #100541|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101206&action=edit
Bug 24696: Add completion times to updatedatabase

This patch adds completion times to the print statements in
updateadatabase.pl.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on top of Bug 24131
Work Ok, no errors.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:59:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 14:59:50 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-XuZJNFcZtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101207&action=edit
Bug 24696: Use strftime

Seems easier to me.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:02:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:02:45 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-0cPJIQOV7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101208&action=edit
Bug 20399: Remove "did you mean" for the staff interface

The amdin page for the "did you mean" feature has two block for setting it up
in the staff interface, and a note saying this isn't implemented on the staff
interface yet.
We remove the part about the staff interface until it actually is implemented.

Test plan :
1) Apply patch
2) Go to Administration > Did you mean?
3) See there is only the OPAC block

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:02:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:02:40 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-WVZugAYoPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:04:54 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ZPkGjUuLOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101122|0                           |1
        is obsolete|                            |
 Attachment #101123|0                           |1
        is obsolete|                            |
 Attachment #101124|0                           |1
        is obsolete|                            |
 Attachment #101125|0                           |1
        is obsolete|                            |
 Attachment #101126|0                           |1
        is obsolete|                            |
 Attachment #101127|0                           |1
        is obsolete|                            |
 Attachment #101128|0                           |1
        is obsolete|                            |
 Attachment #101129|0                           |1
        is obsolete|                            |
 Attachment #101130|0                           |1
        is obsolete|                            |
 Attachment #101131|0                           |1
        is obsolete|                            |
 Attachment #101132|0                           |1
        is obsolete|                            |
 Attachment #101133|0                           |1
        is obsolete|                            |
 Attachment #101134|0                           |1
        is obsolete|                            |
 Attachment #101135|0                           |1
        is obsolete|                            |
 Attachment #101136|0                           |1
        is obsolete|                            |
 Attachment #101137|0                           |1
        is obsolete|                            |
 Attachment #101138|0                           |1
        is obsolete|                            |
 Attachment #101139|0                           |1
        is obsolete|                            |
 Attachment #101140|0                           |1
        is obsolete|                            |
 Attachment #101141|0                           |1
        is obsolete|                            |
 Attachment #101142|0                           |1
        is obsolete|                            |
 Attachment #101143|0                           |1
        is obsolete|                            |
 Attachment #101144|0                           |1
        is obsolete|                            |
 Attachment #101145|0                           |1
        is obsolete|                            |
 Attachment #101146|0                           |1
        is obsolete|                            |
 Attachment #101147|0                           |1
        is obsolete|                            |
 Attachment #101148|0                           |1
        is obsolete|                            |
 Attachment #101149|0                           |1
        is obsolete|                            |
 Attachment #101150|0                           |1
        is obsolete|                            |

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101209&action=edit
Bug 20443: Revert some stuffs from 12159

These methods have been added to Koha::Patron::Attribute but are wrong, see bug
18339

We should use ->type->$method instead

Moreover the tests exist in another subtest, we do not need them.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:04:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:04:58 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-dEmdlwq303@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101210&action=edit
Bug 20443: Remove opac_display and opac_editable from Patron::Attribute

Same as previously for methods that have been added by bug 17792.
It's better to be explicite and tell we are fetch the related attribute's type

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:03 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-9U5lCtl8GH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101211&action=edit
Bug 20443: Move GetBorrowerAttributeValue to
Koha::Patron->get_extended_attribute_value

We want to retrieve a specific patron's attribute for a given patron.
We then add a new method to Koha::Patron.

This patch add a getter method ->get_extended_attribute_value
to use the DBIx::Class relation

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:07 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-YWvtRW3ZGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101212&action=edit
Bug 20443: Move GetBorrowerAttributes to Koha::Patron - ILSDI

FIXME See comment

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:11 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-i9pylWIWSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101213&action=edit
Bug 20443: Move GetBorrowerAttributes to Koha::Patron->extended_attributes

The GetBorrowerAttributes subroutine return the attributes for a given
patron.

Using get_extended_attributes we can acchieve it easily. The problematic
here is to restore the method's name (value vs attribute,
value_description vs description of the authorised value, as well as
display_checkout that should not be a method of Attribute, but
Attribute::Type instead)

value_description was used when the attribute types were attached to an
authorised value category. To avoid the necessary test in template and
controller there is now a $attribute->description method that will
display either the attribute's value OR the value of the authorised
value when needed. We should certainly use this one from few other
places.

Notes:
* This patch rename Koha::Patron->attributes with
Koha::Patron->get_extended_attributes.
It will be renamed with Koha::Patron->extended_attributes in ones of the next
patches when it will become a setter as well.
* GetBorrowerAttributes did not care about the library limits, we still
do not
* The opac_only flag was not used outside of test, we drop it off.
* To maintain the existing behavior we add a default order-by clause to
the search method [code, attribute]
* From C4::Letters::_parseletter we always display the staff description
of the AV, There is now a FIXME to warn about it
* FIXMEs are not regressions, existing behaviors must be kept
* TODO add a new check to bug 21010 to search for inconsistencies in
patron's attributes attached to non-existent authorised values
* One test has been updated in Modifications.t, order_by is now
by default set to ['code', 'attribute']

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:15 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-98BoQOYhdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101214&action=edit
Bug 20443: Improve filtering method

Koha::Patron::Attributes->search mimicks what is done in
Koha::AuthorisedValues->search.
But actually it should be more explicit when the caller use it.
For instance filter_by_branch_limitation (see discussion on bug 11983).

This will be useful for the following patches as we will need a way to
replace the $no_branch_limit flag.
When the $no_branch_limit flag is called, a simple ->search call should
be done.
When we want to limit on a specific library we can pass the branchcode
in paramter of filter_by_branch_limitation (this is not used yet).
If not passed the logged-in user library will be used by default.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:19 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-XhCq241Yv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101215&action=edit
Bug 20443: Remove DeleteBorrowerAttributes

This subroutine was only used once, easy to replace.
SetBorrowerAttributes must replace the attributes for the ones logged-in
user is allowed to edit, that's why we filter by the library limits

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:23 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-JygOqSoJft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101216&action=edit
Bug 20443: Remove DeleteBorrowerAttribute

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:27 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ZYotNYsPxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101217&action=edit
Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttributes

This patch replace Koha::Patron->get_extended_attributes with
->extended_attributes
It's now a getter a setter method.

It permits to replace UpdateBorrowerAttribute and use
create_related from DBIx::Class

Notes:
* We face the same variable names difference than in a previous patch
(value vs attribute)

Bug 20443: Remove SetBorrowerAttributes

squash  + RM get_extended_attributes

 RM get_extended_attributes

SQUASH Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttribute

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:31 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-hEGkcMOWF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101218&action=edit
Bug 20443: Remove CheckUniqueness

There is already a method in Koha::Patron::Attribute to check the
uniqueness constraint, let us it to replace CheckUniqueness

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:35 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-NSLZ9a0T0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101219&action=edit
Bug 20443: Move C4::Members::AttributeTypes::GetAttributeTypes to
Koha::Patron::Attribute::Types

We can then now start to move methods from C4::Members::AttributeTypes
as well.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:39 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-GDUqKxQVAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101220&action=edit
Bug 20443: Remove num_patron

Replace C4::Members::AttributeTypes->num_patron with
Koha::Patrons->filter_by_attribute_type

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:43 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-zO1IqSl69t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101221&action=edit
Bug 20443: Remove C4::Members::AttributeTypes

We do no longer need this package, we can use
Koha::Patron::Attribute::Types directly instead.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:47 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-jJzB3u5025@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101222&action=edit
Bug 20443: Remove SearchIdMatchingAttribute - prove we are not cheating

Tests are still passing that way, we can continue

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:51 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-GprjPS9wzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101223&action=edit
Bug 20443: Remove SearchIdMatchingAttribute

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:55 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-sdsRIqgCvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101224&action=edit
Bug 20443: Remove extended_attributes_merge

TODO We need tests here!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:05:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:05:59 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-q1ZTFWyYso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101225&action=edit
Bug 20443: Remove extended_attributes_code_value_arrayref AND
C4::Members::Attributes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:03 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-h9mWQvU1my@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101226&action=edit
Bug 20443: (follow-up) Move GetBorrowerAttributes to Koha::Patron - ILSDI

Either we display everything, or only the info from the attribute itself
(i.e. not its type)

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:08 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-Oo623jtQlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101227&action=edit
Bug 20443: (follow-up) Fix t/db_dependent/Koha/Patrons.t

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:11 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-MWM5DYRLpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101228&action=edit
Bug 20443: Fix Auth_with_ldap.t

Must be a hashref

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:16 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-V77xzTraO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101229&action=edit
Bug 20443: Use search_with_library_limits for attribute types

Dealt with that previously in the module during the rebase.
It conflicted with bug 23281.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:20 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-cdpLHdX1g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101230&action=edit
Bug 20443: Fix Patrons/Import.t

->get_patrons has been removed but not replaced!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:23 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-t5RBtG57aG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101231&action=edit
Bug 20443: Fix add/edit for checkboxes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:28 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-CrwkfEKQuJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101232&action=edit
Bug 20443: Fix POD

Fixes the following failures:

 FAIL   Koha/Patron/Attribute.pm
   FAIL   pod
                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attribute.pm

                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attribute.pm

 FAIL   Koha/Patron/Attributes.pm
   FAIL   pod
                *** ERROR:
                empty =head3

                 in file Koha/Patron/Attributes.pm

   FAIL   pod coverage
                POD is missing for merge_with
                POD is missing for object_class

 FAIL   Koha/Patrons.pm
   FAIL   spelling
                 paramter  ==> parameter

except the missing pod for object_class, not needed.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:32 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-VhZaI1xAKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101233&action=edit
Bug 20443: Fix creation of new patron with attributes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:35 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-FDcuAdHBYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101234&action=edit
Bug 20443: Do not explode if attribute does not have a valid av

Template process failed: undef error - Can't call method "lib" on an undefined
value at /kohadevbox/koha/Koha/Patron/Attribute.pm line 109.                   
                                                     at
/kohadevbox/koha/C4/Templates.pm line 122

We should not crash as it if the attribute is linked to an invalid
authorised value (for instance the AV has been deleted)

We must provide a check in the search_for_data_inconsistencies.pl script

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:39 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-HIOJNIJzW1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101235&action=edit
Bug 20443: Fix patron modification approval

There was a mismatch between "value" and "attribute". Before this
patchset, "value" was sometimes used, but then it comes "attribute" to
match the DB column's name.
We must keep both here, when an upgrade is done we could have "value"
that is still in the borrower_modifications.extended_attributes JSON

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:44 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-6YMOYDpG3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101236&action=edit
Bug 20443: Handle non existent attribute when importing patrons

There is much more to do here, but this patch has the same behavior than
before: a warn is displayed in the log, the UI is not aware of it

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:06:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:06:48 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-TRGAITkzvG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101237&action=edit
Bug 20443: Fix merge_with behavior

merge_with were returning Koha::Patron::Attribute for existing attribute
and hashref for new attribute.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:08:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:08:13 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-uXZeHvztYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101238&action=edit
Bug 24759: (follow-up) Fix tests

Earlier tests delete borrowers before issues, can cause a constraint failure

Wrong test count

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:23 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-PqmJZMpM6l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:26 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-YRZMEH7EdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99763|0                           |1
        is obsolete|                            |

--- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101239&action=edit
Bug 24759: Move OpacRenewalBranch code to Koha::Item

This patchset moves all code to calculate the correct renewal branch into
Koha::Item.pm

When interface is opac we follow the syspref, otherwise we use the current
userenv, or pass through
a defined branch

To test:
1 - Check out an item to a patron
2 - Set allowed renewals in the circ rules to 100 (just so you can keep
testing)
3 - Renew the item in staff interface, confirm it is recorded correctly in
statistics table (as signed in branch)
4 - Renew via the opac, testing with each setting of OpacRenewalbranch
5 - prove -v t/db_dependent/Koha/Item.t

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:29 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-pe6a3f4jS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99764|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101240&action=edit
Bug 24759: CleanUp OpacRenewalBranch values

We had a unique behvaiour where the syspref was set to string 'NULL'
as opposed to undef, we need to clean that up

To test:
1 - Set OpacRenewalBranch to 'NULL' in staff interface
2 - Renew via opac
3 - Check statistics to ensure branch is blank

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:32 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-K8HTGxD2qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99780|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101241&action=edit
Bug 23165: Unit tests for AddRenewal

https://bugs.koha-community.org/show_bug.cgi?id=24759

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:35 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-NiIiSlyi6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99953|0                           |1
        is obsolete|                            |

--- Comment #15 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101242&action=edit
Bug 24759: Rename renewalbranch to renewal_branchcode

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:38 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-Py0kQAlwPB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100002|0                           |1
        is obsolete|                            |

--- Comment #16 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101243&action=edit
Bug 24759: Simplify tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:41 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-ZEj28OCYaE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100003|0                           |1
        is obsolete|                            |

--- Comment #17 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101244&action=edit
Bug 24759: Test intranet at the same time

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:11:44 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-b9JNA1ezPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101238|0                           |1
        is obsolete|                            |

--- Comment #18 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101245&action=edit
Bug 24759: (follow-up) Fix tests

Earlier tests delete borrowers before issues, can cause a constraint failure

Wrong test count

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:12:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:12:45 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-7aS7y2Bw4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101151|0                           |1
        is obsolete|                            |
 Attachment #101152|0                           |1
        is obsolete|                            |
 Attachment #101153|0                           |1
        is obsolete|                            |
 Attachment #101154|0                           |1
        is obsolete|                            |
 Attachment #101156|0                           |1
        is obsolete|                            |
 Attachment #101157|0                           |1
        is obsolete|                            |
 Attachment #101158|0                           |1
        is obsolete|                            |
 Attachment #101161|0                           |1
        is obsolete|                            |
 Attachment #101163|0                           |1
        is obsolete|                            |
 Attachment #101165|0                           |1
        is obsolete|                            |
 Attachment #101167|0                           |1
        is obsolete|                            |
 Attachment #101169|0                           |1
        is obsolete|                            |
 Attachment #101170|0                           |1
        is obsolete|                            |
 Attachment #101171|0                           |1
        is obsolete|                            |
 Attachment #101172|0                           |1
        is obsolete|                            |
 Attachment #101173|0                           |1
        is obsolete|                            |
 Attachment #101174|0                           |1
        is obsolete|                            |
 Attachment #101175|0                           |1
        is obsolete|                            |
 Attachment #101176|0                           |1
        is obsolete|                            |
 Attachment #101177|0                           |1
        is obsolete|                            |
 Attachment #101178|0                           |1
        is obsolete|                            |
 Attachment #101179|0                           |1
        is obsolete|                            |
 Attachment #101180|0                           |1
        is obsolete|                            |
 Attachment #101181|0                           |1
        is obsolete|                            |
 Attachment #101182|0                           |1
        is obsolete|                            |
 Attachment #101183|0                           |1
        is obsolete|                            |
 Attachment #101184|0                           |1
        is obsolete|                            |
 Attachment #101185|0                           |1
        is obsolete|                            |
 Attachment #101186|0                           |1
        is obsolete|                            |
 Attachment #101188|0                           |1
        is obsolete|                            |
 Attachment #101189|0                           |1
        is obsolete|                            |
 Attachment #101190|0                           |1
        is obsolete|                            |
 Attachment #101191|0                           |1
        is obsolete|                            |
 Attachment #101192|0                           |1
        is obsolete|                            |
 Attachment #101193|0                           |1
        is obsolete|                            |
 Attachment #101194|0                           |1
        is obsolete|                            |
 Attachment #101195|0                           |1
        is obsolete|                            |
 Attachment #101196|0                           |1
        is obsolete|                            |
 Attachment #101197|0                           |1
        is obsolete|                            |

--- Comment #112 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101246&action=edit
Bug 23463: Replace SearchItemsByField by SearchItems

The subroutine SearchItemsByField is only called once and can be
replaced easily with SearchItems

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:12:49 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-MVyvUgFz6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #113 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101247&action=edit
Bug 23463: Remove uneeded SearchItemsByField subroutine

It is no longer used.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:12:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:12:53 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-21nDgxS5Kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #114 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101248&action=edit
Bug 23463: fix for testbuilder - set default value items.damaged=0

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:12:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:12:57 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-cTwCaukoao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #115 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101249&action=edit
Bug 23463: Replace AddItem calls with Koha::Item->store

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:01 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-oOFvB9Kyas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #116 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101250&action=edit
Bug 23463: Remove _set_defaults_for_add

_set_defaults_for_add is no longer needed as it is handled by dbic and
koha::object->store

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:05 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-5wMBVveCuR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #117 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101251&action=edit
Bug 23463: Replace _set_derived_columns_for_add

Remove the unique call to _set_derived_columns_for_add
Even if design to deal with other values it only dealts with cn_sort

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:08 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-HN5kVnhyxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #118 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101252&action=edit
Bug 23463: AddItem removing

We are done with AddItem, only need to log and index.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:13 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ifl9PFC72h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #119 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101253&action=edit
Bug 23463: Replace ModItem with Koha::Item->store

Starting to replace the ModItem calls with Koha::Item->store

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:16 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-akRVW2o7Og@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #120 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101254&action=edit
Bug 23463: remove trivial UpdateHoldingbranch sub

We do not need this subroutine, moving it where it is used.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:20 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-nHkLHlVQdT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #121 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101255&action=edit
Bug 23463: Move plugin hook

>From C4::Items to Koha::Item

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:24 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-CnZPFXsEQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #122 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101256&action=edit
Bug 23463: _set_derived_columns_for_mod was only used for cn_sort

Same as _set_defaults_for_add

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:28 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-PnJ4te2Sh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #123 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101257&action=edit
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp
moved

That's done in Koha::Item->store, and Koha::Object->store for integers.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:32 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-vwZf8OmaDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #124 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101258&action=edit
Bug 23463: Remove _mod_item_dates

We did not do anything useful here.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:36 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-d4QTGheGOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #125 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101259&action=edit
Bug 23463: Remove ModItem

There should not be any calls left

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-z0JHZPZW9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #126 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101260&action=edit
Bug 23463: Remove DelItem

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:43 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NYo8i8xYYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #127 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101261&action=edit
Bug 23463: Remove DelItemCheck and ItemSafeToDelete

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:47 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-4M3roqW77A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #128 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101262&action=edit
Bug 23463: Remove no longer needed subs related to default values

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:51 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-kdGvIERjAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #129 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101263&action=edit
Bug 23463: Fix CancelReceipt.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:55 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ZHZSXc8HX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #130 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101264&action=edit
Bug 23463: Fix failing tests

And adding a FIXME about discard_changes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:13:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-286V9sH5xG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #131 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101265&action=edit
Bug 23463: Getting less item-level_itypes warnings (?)

So, we get less warnings. I do not really understand why...

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:03 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-zoZa0XqrfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #132 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101266&action=edit
Bug 23463: Fix AutomaticItemModificationByAge.t

We do not want to log if nothing changed

How could we do that better?

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:07 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-W9cRJGdL5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #133 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101267&action=edit
Bug 23463: update permanent_location if location has been updated

This change to Koha::Item->store seems correct here, but tests from
/db_dependent/Items.t is failing now.

Adjusting them to make them pass.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-8pPgCc6u9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #134 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101268&action=edit
Bug 23463: Fix items.cn_source vs cn_source

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-xujXmIGgo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #135 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101269&action=edit
Bug 23463: build cn_sort only if needed

No need to calculate cn_sort if not dirty when we store

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-N7Z1TKTACT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #136 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101270&action=edit
Bug 23463: Replace recently added occurrences

Few occurrences have been added since this patchset has been originaly
written

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:23 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-uAsO2djlFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #137 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101271&action=edit
Bug 23463: cn_sort needs to be updated if cn_source changed

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:27 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-XQmihhQyep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #138 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101272&action=edit
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete

Wrong replacement in additem.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:31 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-1bXQZgDbSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #139 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101273&action=edit
Bug 23463: Fix timestamp default value

This sounds wrong as we should let the DBMS do that, but it was failing.
Here we are doing the same as Koha::Patron->store for dateenrolled

To recreate the failure, prove t/db_dependent/Koha/Item.t without this
patch:
DBD::mysql::st execute failed: Column 'timestamp' cannot be null [for
Statement "UPDATE `items` SET `more_subfields_xml` = ?, `timestamp` = ?
WHERE ( `itemnumber` = ? )" with ParamValues: 0='<?xml version="1.0"
encoding="UTF-8"?>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:35 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-dblS7pTR7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #140 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101274&action=edit
Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t
subtest

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-a40KaL3Zm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #141 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101275&action=edit
Bug 23463: (follow-up) Fix timestamp default value

For discussion, this patch revert the changes made previously.

This line exists in Koha::Item->store as it is the translation of:
    if (exists $item->{'timestamp'}) {
        delete $item->{'timestamp'};
    }
that was coming from _do_column_fixes_for_mod (called from ModItem)

To preserve existing behavior I would be in favor of keeping it like that to
avoid regression, and deal with it separately if we want to improve/remove it.

So basically here we are setting it to undef in Koha::Item->store to make it
handle correctly by the parent Koha::Object->store. I agree that's kind of
weird
and must be improved.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:43 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-sH9HcbC8Z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #142 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101276&action=edit
Bug 23463: Fix safe_return return value in deletion tools

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:47 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-lm2jgjNySl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #143 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101277&action=edit
Bug 23463: Fix tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:51 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-maq9j53iHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #144 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101278&action=edit
Bug 23463: Fix IsItemIssued.t

It seems that some of those tests could be removed as safe_delete is
widely tested in Koha/Item.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:55 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-m7qc0JElpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #145 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101279&action=edit
Bug 23463: Fix cn_source for new item

get_dirty_columns only work for existing items.

This fixes t/db_dependent/ShelfBrowser.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:14:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:14:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-8mONbu0QdN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #146 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101280&action=edit
Bug 23463: Fix XSLT.t

>From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0
     Bug 23463: Replace AddItem calls with Koha::Item->store

in build_sample_item:
-    my $itype = delete $args->{itype}
-      || $self->build_object( { class => 'Koha::ItemTypes' } )->itemtype;
+    # If itype is not passed it will be picked from the biblio (see
Koha::Item->store)

So before we generated a new itemtype if not passed, now we pick the one from
biblioitem->itemtype.

For this specific test we need to make sure they are different.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:15:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:15:03 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OX7uKSQmrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #147 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101281&action=edit
Bug 23463: Replace new occurrence of AddItem

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:15:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:15:07 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-zdIhlHHSc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #148 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101282&action=edit
Bug 23463: Use new method Koha::Object->set_or_blank

This patch fixes an issue when editing items.

* The issue
Cannot blank a subfield when editing an item.
If you have an item with itemcallnumber=42, then edit it, blank it and
save. The itemcallnumber is still 42

* Why? (line numbers from https://gitlab.com/joubu/Koha/-/tree/bug_23463)
additem (and other item's edition forms) receives a list of tags,
subfields and values, generates a MARC::Record::XML then calls
ModItemFromMarc:

717     my $itemtosave=MARC::Record::new_from_xml($xml, 'UTF-8');
727         my $newitem = ModItemFromMarc($itemtosave, $biblionumber,
$itemnumber);

And ModItemFromMarc:
 282     my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
 283     $item->{cn_source} = delete $item->{'items.cn_source'}; #
Because of C4::Biblio::_disambiguate
 284     $item_object->set($item);

ModItemFromMarc never knows that the field has been blank.
Prior to bug 23463 we had a map of default values, and ModItemFromMarc
was doing:
 426     my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
 427     my $default_values = _build_default_values_for_mod_marc();
 428     foreach my $item_field ( keys %$default_values ) {
 429         $item->{$item_field} = $default_values->{$item_field}
 430           unless exists $item->{$item_field};
 431     }

I do not want to reinsert that list of default values.

Here I wrote a generic method in Koha::Object to set the value passed in
parameter,
or "blank" if not passed.
It's nulled if can be set to null in DB, or the default value is retrieved from
the schema info.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:15:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-gAgMW8TJfe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #149 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101283&action=edit
Bug 23463: (follow-up 2) Fix timestamp default value

Removing previous change, again.
But this time in Object.pm
It fixes t/db_dependent/Koha/Object.t and t/db_dependent/Koha/Item.t is
still passing.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:15:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ArC9yYJHKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #150 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101284&action=edit
Bug 23463: Fix items.cn_sort vs cn_sort

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:20:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:20:57 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-1bgLVIIf1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:01 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-JOm5xaIbVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101239|0                           |1
        is obsolete|                            |
 Attachment #101240|0                           |1
        is obsolete|                            |
 Attachment #101241|0                           |1
        is obsolete|                            |
 Attachment #101242|0                           |1
        is obsolete|                            |
 Attachment #101243|0                           |1
        is obsolete|                            |
 Attachment #101244|0                           |1
        is obsolete|                            |
 Attachment #101245|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101285&action=edit
Bug 24759: Move OpacRenewalBranch code to Koha::Item

This patchset moves all code to calculate the correct renewal branch into
Koha::Item.pm

When interface is opac we follow the syspref, otherwise we use the current
userenv, or pass through
a defined branch

To test:
1 - Check out an item to a patron
2 - Set allowed renewals in the circ rules to 100 (just so you can keep
testing)
3 - Renew the item in staff interface, confirm it is recorded correctly in
statistics table (as signed in branch)
4 - Renew via the opac, testing with each setting of OpacRenewalbranch
5 - prove -v t/db_dependent/Koha/Item.t

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:04 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-xJlJc9lWUZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101286&action=edit
Bug 24759: CleanUp OpacRenewalBranch values

We had a unique behvaiour where the syspref was set to string 'NULL'
as opposed to undef, we need to clean that up

To test:
1 - Set OpacRenewalBranch to 'NULL' in staff interface
2 - Renew via opac
3 - Check statistics to ensure branch is blank

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:08 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-Ni0IvoJ9Iw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101287&action=edit
Bug 23165: Unit tests for AddRenewal

https://bugs.koha-community.org/show_bug.cgi?id=24759

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:11 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-C2JrqBfcUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101288&action=edit
Bug 24759: Rename renewalbranch to renewal_branchcode

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:15 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-YKOXe29Oud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101289&action=edit
Bug 24759: Simplify tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:19 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-egCN70D4OL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101290&action=edit
Bug 24759: Test intranet at the same time

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:21:22 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-H09JCbtw2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101291&action=edit
Bug 24759: (follow-up) Fix tests

Earlier tests delete borrowers before issues, can cause a constraint failure

Wrong test count

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:25:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:25:58 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-UW96MfjHHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101292&action=edit
Bug 24883: Centralize code to load YAML installer files to a sub

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:26:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:26:01 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-UJBVeMR4XT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101293&action=edit
Bug 24883: Move to a flat array with all values to an array of arrayref

For the following SQL query:
INSERT INTO cities(city_name, city_country) VALUES ('Madrid', 'Spain'),
('Buenos Aires', 'Argentina');

We move from:
[ 'Madrid', 'Spain', 'Buenos Aires', 'Argentina' ]
to:
[ [ 'Madrid', 'Spain' ], [ 'Buenos Aires', 'Argentina' ] ]

Which make more sense to split, build and construct the queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:26:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:26:05 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-z3m1J628t2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101294&action=edit
Bug 24883: Move new sub from load_yaml.pl

Use the sub from C4::Installer to avoid dup of code.

Note:
We are going to modify the script and so will do more stuffs.
We may want to rename it, maybe installer_utilities.pl,
misc/installer/yaml_utility.pl, any suggestions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:29:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:29:09 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-XFFFx3CGZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101078|0                           |1
        is obsolete|                            |
 Attachment #101079|0                           |1
        is obsolete|                            |
 Attachment #101080|0                           |1
        is obsolete|                            |
 Attachment #101081|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101295&action=edit
Bug 24912: Add a new yml2sql sub to C4::Installer

It will allow us to generate sql code from the yml files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:29:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:29:12 +0000
Subject: [Koha-bugs] [Bug 24912] Generate sql from yaml installer files
In-Reply-To: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24912-70-lUBRNqsOkz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24912

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101296&action=edit
Bug 24912: Add the ability to convert yaml installer files to SQL queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:36:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:36:40 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-qADSUWZRLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
In my understanding, these links are those created by EasyAnalytics and I
thought those linked on itemnumber... 

Having said that.. it's a simple string change and I'm not going to delve deep
enough to disagree as there's a series of signoffs and agreement here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:09 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-29RzK420iL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:11 +0000
Subject: [Koha-bugs] [Bug 8595] Link to 'host item' confusing
In-Reply-To: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8595-70-VaDEaFx3xe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:13 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-eaSN4G3uvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:15 +0000
Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority
 frameworks
In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13775-70-uofRUrc2ok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:17 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-BzdbrnENnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:19 +0000
Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq
 (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for
 /usr/share/koha/bin/import_patrons.pl
In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22025-70-vA9r1dBeuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:21 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-SbMhEcKOOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:22 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages sent as print should not fall
 back to 'email'
In-Reply-To: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23411-70-MhKnbS3avj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:24 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-J2gZqT9sdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:26 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-BG1MkA04LW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:28 +0000
Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database
 fields
In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23900-70-7Zjfb2MEko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:30 +0000
Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database
 fields
In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23900-70-VM7HUVB9V7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:32 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-MhuyYvHWg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:34 +0000
Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in
 patron screen message AF field
In-Reply-To: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24250-70-X4MITENlxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:36 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-VuLcnS61KN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:38 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-3SX6FNiLXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:40 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-SaFvm9C2Eg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:42 +0000
Subject: [Koha-bugs] [Bug 24688] Hold priority isn't adjusted correctly if
 checking out a middle priority hold
In-Reply-To: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24688-70-h3S9L1E1e1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:44 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-kBjyozWTSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:46 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24809-70-4N1j7HEdZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:47 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-uW8BgZm1RY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:49 +0000
Subject: [Koha-bugs] [Bug 24830] dbic_merge_prefetch is not handling
 recursive cases correctly
In-Reply-To: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24830-70-EdMxMZnkMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:51 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-D7RXnYKPXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:53 +0000
Subject: [Koha-bugs] [Bug 24848] Help link from label creator
 batch/layout/template points to card creator in manual
In-Reply-To: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24848-70-JUllnxb1EZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:55 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-HKKGcCSMRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:56 +0000
Subject: [Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
In-Reply-To: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24892-70-K6lz2ocYhi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:43:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:43:58 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-noyGtxJrVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:44:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:44:00 +0000
Subject: [Koha-bugs] [Bug 24904] New YAML files for installer are slow to
 insert
In-Reply-To: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24904-70-gfv1AVVXcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24904

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:59:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 15:59:00 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-YsuIVRVGef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:02:54 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-zzSwv4ceLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97253|0                           |1
        is obsolete|                            |
  Attachment #97254|0                           |1
        is obsolete|                            |
  Attachment #97255|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101297&action=edit
Bug 24152: Add method Koha::Objects->filter_by_last_update

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:02:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:02:57 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-rZjWA038lB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101298&action=edit
Bug 24152: Add a warning about the delete of statistics's table entries

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:03:01 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-YyGDQY2eO9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101299&action=edit
Bug 24152: Add the ability to purge pseudonymized tables

anonymized_* tables have been added by bug 24151, this patch adds the
usual way to purge data from them.

The cleanup_database.pl script has been adjusted to take new parameters
that will help to delete pseudonymized data.

Test plan:
Call the scrip with the new parameter to remove pseudonymized data
* --pseudo-transactions DAYS will remove entries from
pseudonymized_transactions older
than DAYS day
* --pseudo-transactions can be used without the parameter DAYS but with
-- pseudo-transactions-from and/or --pseudo-transactions-to instead, to provide
a
range of date

You can use the patch from bug 24153 to make the tests easier, data will
not be deleted if the new --confirm flag is not passed.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:03:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:03:49 +0000
Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the
 cleanup_database.pl cronjob
In-Reply-To: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24153-70-UsDmmr8FoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97256|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101300&action=edit
Bug 24153: Add a confirm flag to cleanup_database

How handy this will be, right?

This patch will change the behavior of this script as the --confirm flag
will now be required for effective changes.
Without --confirm and with --verbose you will see what could have done
the script in non dry-run mode.

Test plan:
Use different options of the script without the --confirm flag and have
a look at the output. It now tells you what would have been deleted if
the flag was passed.
Now use the --confirm flag and confirm that the changes are now
effective.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:47 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-dcu0vVuSzM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:49 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-O9IosLheCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:50 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-kCvflCepjH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:52 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-t0UqJqJG8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:54 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-uUock7mxo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:04:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:04:56 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-iZOcK0pcFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:37:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:37:35 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-wuPA6m1A7G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:39:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:39:41 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-q7gbfAAr0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:39:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 16:39:44 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-TN4jt0Nc1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100591|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101301&action=edit
Bug 15214: bulkmarcimport should log if an authority has been updated

When importing with bulkmarcimport, authorities may or may not be updated based
on which authority is newer (005 are compared).
This patch allows to keep track in the result yaml file if an authority has
been updated or not:

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:13:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:13:19 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-3MjVzGzPxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
prove t/db_dependent/Biblio/BuildBiblioDataForExport.t
t/db_dependent/Biblio/BuildBiblioDataForExport.t .. 1/4 Use of uninitialized
value in numeric ne (!=) at /kohadevbox/koha/C4/Ris.pm line 833.
Use of uninitialized value in numeric ne (!=) at /kohadevbox/koha/C4/Ris.pm
line 833.

    #   Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line
68.
    #          got: 'TY  - BOOK
    # AU  - Knuth,Donald Ervin
    # TI  - The art of computer programming
    # KW  - Computer programming
    # KW  - Computer algorithms
    # ER  -
    # '
    #     expected: 'TY  - BOOK
    # AU  - Knuth, Donald Ervin
    # TI  - The art of computer programming
    # KW  - Computer programming
    # KW  - Computer algorithms
    # ER  -
    # '
    # Looks like you failed 1 test of 1.

#   Failed test 'ris'
#   at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 69.

    #   Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line
77.
    #          got: '@book{440,
    #   author = {Knuth, Donald Ervin},
    #   title = {The art of computer programming}
    # }
    # '
    #     expected: '@book{440,
    #     author = {Knuth, Donald Ervin},
    #     title = {The art of computer programming}
    # }
    # '
    # Looks like you failed 1 test of 1.

#   Failed test 'bibtex'
#   at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 82.
# Looks like you failed 2 tests of 4.
t/db_dependent/Biblio/BuildBiblioDataForExport.t .. Dubious, test returned 2
(wstat 512, 0x200)
Failed 2/4 subtests

Test Summary Report
-------------------
t/db_dependent/Biblio/BuildBiblioDataForExport.t (Wstat: 512 Tests: 4 Failed:
2)
  Failed tests:  3-4
  Non-zero exit status: 2
Files=1, Tests=4,  3 wallclock secs ( 0.02 usr  0.01 sys +  1.46 cusr  0.27
csys =  1.76 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:29:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:29:32 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-h5K93VgaHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
> Changes to to_api_mapping should not be part of this patchset.

Would you accept a follow-up patch here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:29:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:29:48 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-gF0fJWS7jW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> Also, I think the method should reflect the lack of FK, something like:
> sub creator {
>     my ($self) = @_; 
>     my $borrowernumber = $self->authorisedby; # FIXME missing FK here
>     return unless $borrowernumber;
>     return Koha::Patrons->find( $self->authorisedby );
> }

Ok, will do.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:35:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:35:03 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-Z51anfMe9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:35:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:35:07 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-JSoXReFMfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101198|0                           |1
        is obsolete|                            |
 Attachment #101199|0                           |1
        is obsolete|                            |
 Attachment #101200|0                           |1
        is obsolete|                            |
 Attachment #101201|0                           |1
        is obsolete|                            |
 Attachment #101202|0                           |1
        is obsolete|                            |
 Attachment #101203|0                           |1
        is obsolete|                            |
 Attachment #101204|0                           |1
        is obsolete|                            |
 Attachment #101205|0                           |1
        is obsolete|                            |

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101302&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:44:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:44:42 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-JKrDBuUo2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96404|0                           |1
        is obsolete|                            |

--- Comment #10 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101303&action=edit
Bug 23403: Remove cardnumber from SIP

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:45:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:45:31 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-C3k70CpdC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:45:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 17:45:34 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-cnx0m1Y1Yh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101303|0                           |1
        is obsolete|                            |

--- Comment #11 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101304&action=edit
Bug 23403: Remove cardnumber from SIP

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:06:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:06:33 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-aQEMrrIHFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98244|0                           |1
        is obsolete|                            |

--- Comment #48 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101305&action=edit
Bug 21357: Add elision filtering to default ES index config

To test:

1. Rebuild Elasticsearch index with the new config
2. Add a record with "l'avion" in the title
3. Verify that the record can be found with both "l'avion" and "avion"

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:06:39 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-lbui8NuiVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98245|0                           |1
        is obsolete|                            |

--- Comment #49 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101306&action=edit
Bug 21357: Case-insensive articles to the elision filter

Test with :
GET index/_analyze
{
  "filter": ["elision"],
  "text": "qu'ils"
}

With different cases :
QU'ILS
Qu'ils
qu'ils
qU'ILS

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:06:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:06:46 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-JhkGupEoLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98246|0                           |1
        is obsolete|                            |

--- Comment #50 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101307&action=edit
Bug 21357: Allow to use multiple ES language analyzers

Test plan:
1. Apply this patch
2. If you have a custom `field_config.yaml` report the diff in your
custom config
3. Create biblios in english and french
4. misc/search_tools/rebuild_elasticsearch.pl
5. Test biblio search at intranet with stemming and ellision in mind

Examples of test queries:
- "journal actualité" => should return results with "Journaux
d'actualités" in it
- "lord lady" => should return results with "Lords and Ladies" in it

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:14:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:14:39 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
 item field in CR instead of collection code
In-Reply-To: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21979-70-xKbZe5uBKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98066|0                           |1
        is obsolete|                            |

--- Comment #10 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101308&action=edit
Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead
of collection code

Some libraries need to send a different field as the collection code,
depending on how the library catalogs items. We should allow any arbitrary
item field to be used as the value for the CR field.

Test Plan:
1) Apply this patch
2) Set the new option cr_item_field to 'shelving_location'
3) Restart the SIP server
3) Perform a checkin via SIP
4) Note the CR field contains the shelving location code in the response
5) Perform an item information request
6) Note the CR field contains the shelving location code in the response

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:19:05 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-2qWlpoHOaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #51 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101309&action=edit
Bug 19482 - DB changes

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:19:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:19:14 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-HEHSBAkUaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #52 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101310&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings

To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at
bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and
not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single
entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one
you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools -
attempt to save and should be warned of missing mandatory mapping

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:19:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:19:20 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-202yDamCQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #53 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101311&action=edit
Bug 19482: SCHEMA CHANGES _ DO NOT PUSH

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:20:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:20:57 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-4LEb2QgpZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bouzid.fergani at inlibro.com
 Attachment #101309|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:21:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:21:12 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-jgZkS0Blx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101310|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:21:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:21:39 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-lHoUi6GuZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101311|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:24:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:24:15 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-OAVpn9Tx4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97226|0                           |1
        is obsolete|                            |

--- Comment #39 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101312&action=edit
Bug 19482 - DB changes

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=21357

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:24:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:24:21 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-bJXoiaCAlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97227|0                           |1
        is obsolete|                            |

--- Comment #40 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101313&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings

To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at
bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and
not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single
entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one
you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools -
attempt to save and should be warned of missing mandatory mapping

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=21357

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:24:27 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-W4I5S3QV8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97228|0                           |1
        is obsolete|                            |

--- Comment #41 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 101314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101314&action=edit
Bug 19482: SCHEMA CHANGES _ DO NOT PUSH

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

https://bugs.koha-community.org/show_bug.cgi?id=21357

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:43:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:43:57 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-wn4XlrR6s0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:44:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:44:00 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-CmJNi2Cc4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100968|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 101315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101315&action=edit
Bug 24468: Remove unused C4::Reserves::_get_itype subroutine

Since bug 21206, C4::Reserves::_get_itype is not longer used and should
be removed.

  commit 31c29fd31f557306233e6a2936148a5bb10b89a1
  Bug 21206: Replace C4::Items::GetItem

UPDATE: In the meanwhile another occurrence was added to Reserves.t, but
easy to replace

Test plan:
  % git grep _get_itype
must not return any occurrences.

If one needs it, Koha::Item->effective_itemtype must be used instead.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:57:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 18:57:42 +0000
Subject: [Koha-bugs] [Bug 24918] New: Wrong attribute mappings in
 Koha::Acquisition::Basket
Message-ID: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

            Bug ID: 24918
           Summary: Wrong attribute mappings in Koha::Acquisition::Basket
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

Some attribute mappings from the RFC were missed on bug 18731:

        authorisedby            => 'creator_id',
        deliveryplace           => 'delivery_library_id',
        billingplace            => 'billing_library_id',

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:02:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:02:49 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-C9IXeggBi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:02:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:02:52 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-kBicPGBqNi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98276|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:03:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:03:24 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-mhxVzzexxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101316&action=edit
Bug 24464: Add K::A::Basket->creator

This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.

Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:03:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:03:29 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-dfjh2m9JSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101317&action=edit
Bug 24464: (QA follow-up) Make the method reflect the lack of FK

This patch makes it super obvious to understand by reading the code that
there's originally no foreign key.

To test:
1. Run the tests and notice they pass
2. Spot the # FIXME
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:05:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:05:11 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-j1i3wtA6vm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:05:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:05:23 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-Q3gSju0nUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:08:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:08:16 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-sSqDJefPVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101318&action=edit
Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket

When bug 18731 was written, the official vote on the RFC hadn't been
held yet. Once it got voted, the mappings were adapted and all the
dependent work fixed as well. But three attribute names were overlooked
and they become evident on developing 20212 which required them.

This patch fixes this really tiny mistake.

To test:
1. Just verify the voted attribute names.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:09:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:09:49 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-roozOIQDR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:09:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:09:53 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-Qpvf1RRH3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101318|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101319&action=edit
Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket

When bug 18731 was written, the official vote on the RFC hadn't been
held yet. Once it got voted, the mappings were adapted and all the
dependent work fixed as well. But three attribute names were overlooked
and they become evident on developing 20212 which required them.

This patch fixes this really tiny mistake.

To test:
1. Just verify the voted attribute names.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:10:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:10:13 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-3CqbTNkF84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:10:25 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-X186CuNrcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:11:48 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-8xOCAVjHQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24918


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918
[Bug 24918] Wrong attribute mappings in Koha::Acquisition::Basket
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:11:48 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-bYvzWZ48Wd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:12:01 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-SaMhZVu11h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24918


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918
[Bug 24918] Wrong attribute mappings in Koha::Acquisition::Basket
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:12:01 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-w6yKUZ8PY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:17:54 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ETTQtg5Zgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24464                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:17:54 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-z2PQKuU9hB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|20212                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:19:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:19:37 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-jEyTCVBRpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:28:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2020 19:28:00 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-HH4PDAQQrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100600|0                           |1
        is obsolete|                            |

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101320&action=edit
Bug 20212: Add missing entries on schema files

This patch adds the missing koha_object(s)_class methods to the related
schema files. It also adds a 'bilbioitem' relationship to the Biblio
class as required for being able to prefetch that table information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 02:43:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 01:43:07 +0000
Subject: [Koha-bugs] [Bug 24919] New: Hacked By LinuXploit
Message-ID: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919

            Bug ID: 24919
           Summary: Hacked By LinuXploit
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: l1nux3r69 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101321&action=edit
hackd

Hackdx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 03:45:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 02:45:47 +0000
Subject: [Koha-bugs] [Bug 24920] New: Hacked by darksec
Message-ID: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920

            Bug ID: 24920
           Summary: Hacked by darksec
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Wildananshori44 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101322&action=edit
Hckd darksec

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 04:28:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 03:28:35 +0000
Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha
 namespace
In-Reply-To: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17712-70-P2OZx6xN38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 04:28:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 03:28:39 +0000
Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item
 availability and holdability
In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16826-70-IAKtAuQnQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 04:29:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 03:29:40 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-aEQ1iG6ygC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:16:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:16:35 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-EvtUjcYDE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:16:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:16:40 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-9wAMun29RZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80561|0                           |1
        is obsolete|                            |

--- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101323&action=edit
Bug 21503: Tests for the existing behavior

This patch introduces 7 tests for the current behaviour for the
AuthorisedValues template plugin.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t
=> SUCCESS: Tests pass, all green!

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:17:04 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-3v9QgSLXqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80563|0                           |1
        is obsolete|                            |

--- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101324&action=edit
Bug 21503: Fix AV to fail to other values

To Test (Test both detail.pl and opac-detail.pl for functionality):
    1) Apply patch (restart_all)
    2) Look up an item that has a shelving location with a description
        defined (opac description too).
    3) Remove opac description from shelving location.  Refresh
        opac-detail.pl and note that description fails back to the
        regular description.  Refresh detail.pl and note no change.
    4) Remove regular description from shelving location.  Refresh
        opac-detail.pl and detail.pl.  Note that both default to the
        shelving location code.
    5) Remove the shelving location from the LOC table all together.
        Refresh opac-detail.pl and detail.pl.  Note that both default to
        the requested shelving location code.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:17:34 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-JlnQ1Hp6Pj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80601|0                           |1
        is obsolete|                            |

--- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101325&action=edit
Bug 21503: Tests cleanup and highlight a missing case

This patch does the following changes:
- Use build_object to create the MSS
- Store the generate AVs. That was not the case before and so we were
not testing the right things
- Split the tests into 2 parts: staff and OPAC, for readability
- Update the tests' descriptions
- Highlight a problem: If descriptions are missing for both OPAC and
staff, undef is returned. Is that what we expect? It seems that it is
not what were expecting the tests.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:17:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:17:52 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-waH9wHdg9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80758|0                           |1
        is obsolete|                            |

--- Comment #26 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101326&action=edit
Bug 21503: Tests clarification for debugging

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:18:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:18:11 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-WYnHbqtYzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80759|0                           |1
        is obsolete|                            |

--- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101327&action=edit
Bug 21503: Changed logic for checking values

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:18:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:18:33 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-igVhuk0Naa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80762|0                           |1
        is obsolete|                            |

--- Comment #28 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101328&action=edit
Bug 21503: Simplify If Else logic

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:21:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:21:11 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-xngVdXPJCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #29 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Works as expected. This behavior makes sense to me.

Note for QA :

Some lines are missing ending ";"non ? Like : 
  return $av_check

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:57:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:57:02 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-3yc0UmfFjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:57:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:57:07 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-3tyUCkJsFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83776|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101329&action=edit
Bug 22098: Update stocknumberAV cataloguing plugin to use objects

This patch:
- changes SQL to Koha::AuthorisedValues
- remove type param from script tag
- fixes the plugin description

0) Do not apply the patch
1) Set the plugin
1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item
subfield
1.2) Add authorised values category called "INVENTORY"
1.3) Add some authorised values: authorised value is prefix and
description is a current stock/inventory number
2) Add an item and try to use this plugin to ensure you set it
correctly
2.1) Use a defined prefix to see if the number is correct
2.2) Ensure the number is correctly incremented in authorised values
2.3) Use not defined prefix to see the error message
2.4) Insert a not prefix string (eg number) to see it is not changed
3) Apply the patch
4) Repeat 2) and see it is working the same
5) Look into patch and confirm the description does make sense and is
rigth according to what you see in UI
6) Sign off :D

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:57:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:57:26 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-6o59TNhgbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91421|0                           |1
        is obsolete|                            |

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101330&action=edit
Bug 22098: (follow-up) fix grammar/formating Perldoc

- nubers => numbers
- some vertical spacing
- !}fmt -w65
- "contains of letters" => "containing letters"

TEST PLAN
---------
perldoc cataloguing/value_builder/stocknumberAV.pl
apply patch
perldoc cataloguing/value_builder/stocknumberAV.pl
-- after the patch is more readable.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:59:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 11:59:36 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-QrqLg51sJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Looks good, nice job

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:04:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:04:29 +0000
Subject: [Koha-bugs] [Bug 24833] Field ending punctuation needs to consider
 abrreviations and exceptions
In-Reply-To: <bug-24833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24833-70-UnMWnEg40M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101331&action=edit
Bug 24883: Add POD entry and remove unused variable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:09:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:09:16 +0000
Subject: [Koha-bugs] [Bug 24833] Field ending punctuation needs to consider
 abrreviations and exceptions
In-Reply-To: <bug-24833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24833-70-XWrhRGzGMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
 Attachment #101331|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Comment on attachment 101331
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101331
Bug 24883: Add POD entry and remove unused variable

Sorry, wrong bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:09:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:09:20 +0000
Subject: [Koha-bugs] [Bug 24724] Add plugin hook for new SQL report export
 formats
In-Reply-To: <bug-24724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24724-70-gYT8V3gXgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24724

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I propose you to depend on Bug 20415 that removes UseKohaPlugins system
preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:11:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:11:11 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-FBqd0hPbcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101332&action=edit
Bug 24883: Add POD entry and remove unused variable

https://bugs.koha-community.org/show_bug.cgi?id=24833

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:12:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:12:09 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-2cGzKgj9Ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101332|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101333&action=edit
Bug 24883: Add POD entry and remove unused variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:29:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:29:00 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-RdeDaWMB2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100557|0                           |1
        is obsolete|                            |

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101334&action=edit
Bug 21708: Add a few tests in TransformHtmlToMarc.t

Test plan:
Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change
patch. Verify that the test fails on the order of fields.
Go to test plan of the second patch.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test fails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:29:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:29:05 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-K1TvM97Rr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100558|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101335&action=edit
Bug 21708: Sort MARC fields in TransformHtmlToMarc

Instead of pushing 999 in the front :)

Test plan:
Do not yet apply this patch.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field (MARC21 999) follows leader.
Apply this patch. Restart Plack.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field is in right position.
Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass, correct tag order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 13:29:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 12:29:27 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-lyDxPW50lz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 14:54:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 13:54:43 +0000
Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many
 subfields
In-Reply-To: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21958-70-zAq4SwZF73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi,
this patch does not apply.

Some comments:
* If want to add new auth types then we need to add some definitions in
authorities_normal_marc21.yml, I can help with that
* For the new auth types we need new codes, you are using the same as existing
ones, perhaps we can use
  147 NAME_EVENT Named event
  162 MED_PERFRM Medium of Performance Term
  180 GENRL_SUBD General Subdivision
  181 GEOGR_SUBD Geographic Subdivision
  182 CHRON_SUBD Chronological Subdivision
  185 FORM_SUBD  Form Subdivision

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 15:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 14:33:39 +0000
Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for
 Vufind and for xnciptoolkit drivers
In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16652-70-dKXk32wPkf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mail at jkozlovsky.cz          |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:40:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 15:40:53 +0000
Subject: [Koha-bugs] [Bug 24919] SPAM
In-Reply-To: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24919-70-FfPDkEsfkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Hacked By LinuXploit        |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:41:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 15:41:06 +0000
Subject: [Koha-bugs] [Bug 24919] SPAM
In-Reply-To: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24919-70-nVIsSunBdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101321|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 15:42:33 +0000
Subject: [Koha-bugs] [Bug 24920] SPAM
In-Reply-To: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24920-70-4gOlQSEuqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Hacked by darksec           |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:43:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 15:43:03 +0000
Subject: [Koha-bugs] [Bug 24920] SPAM
In-Reply-To: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24920-70-LtGbiODUcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101322|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:50:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 17:50:52 +0000
Subject: [Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
In-Reply-To: <bug-23789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23789-70-2F2xxN5uLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry, does not apply.
Perhaps you can try removing fr-CA install dir as in Bug 24897 (for es-ES),
unless you have sample data specific for fr-CA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:27:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:27:41 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-FWIxmWWAJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Please rebase

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:35:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:35:38 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-fyDlh2unew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:35:42 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-fa6brDt2BR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101208|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101336&action=edit
Bug 20399: Remove "did you mean" for the staff interface

The amdin page for the "did you mean" feature has two block for setting it up
in the staff interface, and a note saying this isn't implemented on the staff
interface yet.
We remove the part about the staff interface until it actually is implemented.

Test plan :
1) Apply patch
2) Go to Administration > Did you mean?
3) See there is only the OPAC block

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:51:23 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-XiAHMusi9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:51:28 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-BAvK4cLDYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96808|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101337&action=edit
Bug 24324: Resolve error with delete_records_via_leader.pl

To test:

Have a record with the 000 position 5 set to "deleted" (record status)
Use koha-shell to run the job with the -i flag: perl
misc/cronjobs/delete_records_via_leader.pl -c -i -v
* items and the record should be deleted
Mark another record with the 000 position 5 set to deleted (record status)
Use koha-shell to run the job without the -i flag: perl
misc/cronjobs/delete_records_via_leader.pl -c -v
* if the record had items, it will not be deleted
* if the record did not have items, it will be deleted.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works ok. Fixed tab char in line 98, no more errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 21:52:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 20:52:40 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-hons6Niluy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |wizzyrea at gmail.com
                   |ity.org                     |
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 22:01:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 21:01:33 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-LP1mwU3w6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 22:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 21:01:37 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-tqdVZjmOH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100835|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101338&action=edit
Bug 24854: Remove IDreamBooks integration

The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.

To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
  as expected
- Run t/db_dependent/UsageStats.t

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Prefs gone. Fixed missing 'r' in atomic update message.
Test pass, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 22:42:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2020 21:42:43 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-6Jb1x1Zl7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Marcel,
current ACQ framework does not have tag 942.
Do you think we need to add it and it's subfields?

Patches applies cleanly, test pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 02:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 01:39:06 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-jQ6CtqiwJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I've got an interesting DB with lots of real-life acq data, and:
- There are some use cases that I didn't consider
- Some combinations of the data produce error 500.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 06:32:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 05:32:26 +0000
Subject: [Koha-bugs] [Bug 24921] New: 000
Message-ID: <bug-24921-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24921

            Bug ID: 24921
           Summary: 000
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pterodactylxploit at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101339&action=edit
Hacked By Pterodactyl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 06:34:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 05:34:43 +0000
Subject: [Koha-bugs] [Bug 24922] New: 000
Message-ID: <bug-24922-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24922

            Bug ID: 24922
           Summary: 000
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pterodactylxploit at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101340&action=edit
Hacked By Pterodactyl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:50:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 06:50:04 +0000
Subject: [Koha-bugs] [Bug 24923] New: H
Message-ID: <bug-24923-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24923

            Bug ID: 24923
           Summary: H
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: okokaris10 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101341&action=edit
V

V

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:51:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 06:51:42 +0000
Subject: [Koha-bugs] [Bug 24924] New: 8080
Message-ID: <bug-24924-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24924

            Bug ID: 24924
           Summary: 8080
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Project website
          Assignee: wizzyrea at gmail.com
          Reporter: e77699786 at gmail.com

Created attachment 101342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101342&action=edit
Emon27

Laughsec was here..!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:07:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 07:07:09 +0000
Subject: [Koha-bugs] [Bug 24925] New: C
Message-ID: <bug-24925-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24925

            Bug ID: 24925
           Summary: C
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: QA tools
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: okokaris10 at gmail.com

Created attachment 101343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101343&action=edit
B

Ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:10:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 07:10:56 +0000
Subject: [Koha-bugs] [Bug 24926] New: C
Message-ID: <bug-24926-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926

            Bug ID: 24926
           Summary: C
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: QA tools
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: okokaris10 at gmail.com

Ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 07:12:03 +0000
Subject: [Koha-bugs] [Bug 24926] C
In-Reply-To: <bug-24926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24926-70-KIu6oeanuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926

--- Comment #1 from Aris <okokaris10 at gmail.com> ---
Created attachment 101344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101344&action=edit
Kon

X

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:35:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 07:35:45 +0000
Subject: [Koha-bugs] [Bug 24927] New: Sons
Message-ID: <bug-24927-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24927

            Bug ID: 24927
           Summary: Sons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: danurmy433 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 101345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101345&action=edit
Sons

Sons

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 09:09:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 08:09:56 +0000
Subject: [Koha-bugs] [Bug 24928] New: Sus
Message-ID: <bug-24928-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24928

            Bug ID: 24928
           Summary: Sus
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: danurmy433 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101346&action=edit
Sus

Sus

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 09:41:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 08:41:20 +0000
Subject: [Koha-bugs] [Bug 24929] New: Nakagan
Message-ID: <bug-24929-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24929

            Bug ID: 24929
           Summary: Nakagan
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: mamakheked at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101347&action=edit
Kontol

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 09:45:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 08:45:19 +0000
Subject: [Koha-bugs] [Bug 24930] New: Nakagan
Message-ID: <bug-24930-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930

            Bug ID: 24930
           Summary: Nakagan
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mamakheked at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101348&action=edit
Haruka

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 09:45:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 08:45:50 +0000
Subject: [Koha-bugs] [Bug 24930] Nakagan
In-Reply-To: <bug-24930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24930-70-opjgaLrHPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930

Ramdans <mamakheked at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mamakheked at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 10:10:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 09:10:06 +0000
Subject: [Koha-bugs] [Bug 24931] New: Ler
Message-ID: <bug-24931-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24931

            Bug ID: 24931
           Summary: Ler
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: throvinusp at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101349&action=edit
G

Gghh

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 10:10:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 09:10:51 +0000
Subject: [Koha-bugs] [Bug 24932] New: Throvinus
Message-ID: <bug-24932-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24932

            Bug ID: 24932
           Summary: Throvinus
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: throvinusp at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101350&action=edit
Purba

Gggghjnb

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:43:19 +0000
Subject: [Koha-bugs] [Bug 24921] SPAM
In-Reply-To: <bug-24921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24921-70-oYvNzvVcO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|000                         |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:44:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:44:03 +0000
Subject: [Koha-bugs] [Bug 24922] SPAM
In-Reply-To: <bug-24922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24922-70-3YLCkvWuBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|000                         |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:44:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:44:39 +0000
Subject: [Koha-bugs] [Bug 24923] SPAM
In-Reply-To: <bug-24923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24923-70-4dROPTb2Q2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24923

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
            Summary|H                           |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:45:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:45:15 +0000
Subject: [Koha-bugs] [Bug 24924] SPAM
In-Reply-To: <bug-24924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24924-70-1S1gewpGwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24924

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|8080                        |SPAM
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:46:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:46:07 +0000
Subject: [Koha-bugs] [Bug 24925] SPAM
In-Reply-To: <bug-24925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24925-70-uzckarIqjF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24925

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|C                           |SPAM
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:46:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:46:41 +0000
Subject: [Koha-bugs] [Bug 24926] SPAM
In-Reply-To: <bug-24926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24926-70-ZvODM2YGnO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24926

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|C                           |SPAM
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:47:12 +0000
Subject: [Koha-bugs] [Bug 24927] SPAM
In-Reply-To: <bug-24927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24927-70-CbgxWBhTTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24927

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Sons                        |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:47:49 +0000
Subject: [Koha-bugs] [Bug 24928] SPAM
In-Reply-To: <bug-24928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24928-70-XpsvOAnaoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
            Summary|Sus                         |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:48:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:48:15 +0000
Subject: [Koha-bugs] [Bug 24929] SPAM
In-Reply-To: <bug-24929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24929-70-zwS2T4B8OV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24929

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
            Summary|Nakagan                     |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:48:44 +0000
Subject: [Koha-bugs] [Bug 24930] SPAM
In-Reply-To: <bug-24930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24930-70-DkBqBRO84J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24930

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|Nakagan                     |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:49:09 +0000
Subject: [Koha-bugs] [Bug 24931] SPAM
In-Reply-To: <bug-24931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24931-70-ttYteaAoyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24931

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Ler                         |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:49:35 +0000
Subject: [Koha-bugs] [Bug 24932] SPAM
In-Reply-To: <bug-24932-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24932-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24932-70-YmofKxwmCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24932

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Throvinus                   |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:51:28 +0000
Subject: [Koha-bugs] [Bug 24920] SPAM
In-Reply-To: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24920-70-RFWPCfdznm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:52:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:52:08 +0000
Subject: [Koha-bugs] [Bug 24915] SPAM
In-Reply-To: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24915-70-NpErX3Va0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24915

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:52:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:52:26 +0000
Subject: [Koha-bugs] [Bug 24916] SPAM
In-Reply-To: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24916-70-HoCuZzID48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24916

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:52:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:52:56 +0000
Subject: [Koha-bugs] [Bug 24917] SPAM
In-Reply-To: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24917-70-iMBXl0xp4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24917

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 11:53:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 10:53:19 +0000
Subject: [Koha-bugs] [Bug 24919] SPAM
In-Reply-To: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24919-70-EOIrS88JYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:04:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:04:35 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-ZKUyF0CjLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101351&action=edit
Bug 24875: (follow-up) Remove ending . from Comments

Removes another extra ending . from the Comments section
of the tools start page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:04:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:04:57 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-p6AmZ5sqER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #3)
> I think there is still one more under Comments > Moderate patron comments.

Thx for the sign-off and pointing this out - added a tiny follow-up with the
fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:11:31 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-KD1GsysxLW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:11:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:11:34 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-hdNOpw5Tgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100722|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101352&action=edit
Bug 24876: Fix capitalization on patron search for holds

When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons...  instead.
Also changes club id to club ID.

To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:11:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:11:59 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-YNxXwNHVI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Sorry

No need to - new patch attached :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:28:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:28:58 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-BPwdUMTcGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:29:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:29:15 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-acIU8eAONB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101002|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101353&action=edit
Bug 24902: Join different mc- limits with AND (elasticsearch)

In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.

For instance, if you select:
    Itemtypes:
        ✓ Book
        ✓ DVD
    Location:
        ✓ Child
        ✓ Adult

it should search:
    itype:(Book OR DVD) AND location:(Child OR Adult)

Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
   and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
   location, another biblio with the new collection, and again another
   biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
   "advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
   collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
   all criteria
9. Verify that if you select more than one
   {itemtype|location|collection} it still returns results that
   satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works nice, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:34:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:34:58 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-7NbKXopcId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:35:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:35:09 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-kix8xkOLex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101352|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101354&action=edit
Bug 24876: Fix capitalization on patron search for holds

When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons...  instead.
Also changes club id to club ID.

To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:39:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:39:22 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-L2ReHE6C0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97375|0                           |1
        is obsolete|                            |
  Attachment #97376|0                           |1
        is obsolete|                            |
  Attachment #97377|0                           |1
        is obsolete|                            |
  Attachment #97378|0                           |1
        is obsolete|                            |

--- Comment #19 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 101355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101355&action=edit
Bug 24185: Make holds page faster - improved "if"

`$can_item_be_reserved eq 'OK'` moved in `&&` before
`IsAvailableForItemLevelRequest`
to cut away with static known values before calling to more resource consuming
subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:40:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:40:04 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-MV2Jzhsw57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #20 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 101356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101356&action=edit
Bug 24185: Make holds page faster - call to subroutine moved below "if"

`$on_shelf_holds` was assigned before "return .. if" but not used in that code
piece,
so sometimes it was useless. Moved assignment after "return .. if".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:40:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:40:32 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-nzvr7lwk0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #21 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 101357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101357&action=edit
Bug 24185: Make holds page faster: preparatory refactoring

This is just refactoring. extracting logically independent code
to separate sub + tests update. No logic change yet.

Searching for "any_available" item among all biblionumber items was done
inside of "elsif on_shelf_holds == 2", and it is logically very independent
piece of code (this "@items" loop), it needs just biblionumber and patron
as parameters so it can be extracted into separate subroutine, and
later also called/reused from somewhere else.

This ability to call from another place also made for future patch
to remove O(n^2) problem with nested loops.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:41:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:41:27 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-rj5VOsCjyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:41:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:41:30 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-M8iQbx4wa3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #22 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 101358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101358&action=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'

When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.

It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.

Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.

This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.

How to reproduce:

1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,

2) add 100 items for that book for some library,

3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,

4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).

5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353

6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.

I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:

(old code):
  100 items:    50 seconds
  200 items:   3.2 minutes
  300 items:   7.3 minutes

(version with fix):
  100 items:   4.4 seconds
  200 items:   7.5 seconds
  300 items:  10.4 seconds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 12:46:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 11:46:01 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-3lCtC05hzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I see that this is the start of a tree of patches - Joubu, can we continue
here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:14:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:14:26 +0000
Subject: [Koha-bugs] [Bug 24933] New: wadimor
Message-ID: <bug-24933-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24933

            Bug ID: 24933
           Summary: wadimor
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: vbdlkrs13 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101359&action=edit
wadimor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:18:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:18:45 +0000
Subject: [Koha-bugs] [Bug 24934] New: or
Message-ID: <bug-24934-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24934

            Bug ID: 24934
           Summary: or
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: xploitnet2 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101360&action=edit
ok

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:28:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:28:24 +0000
Subject: [Koha-bugs] [Bug 24933] SPAM
In-Reply-To: <bug-24933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24933-70-L2JqIzFNXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24933

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wadimor                     |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:28:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:28:55 +0000
Subject: [Koha-bugs] [Bug 24934] SPAM
In-Reply-To: <bug-24934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24934-70-W8OfU2aW5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|or                          |SPAM
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:46:23 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-j5xx7anqla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:46:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:46:26 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-O3n08QkOvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101062|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101362&action=edit
Bug 24907: Add 'include suspended' to holds ratio report

Some libraries would like the option to ignore suspended holds when using the
holds
ratio report

Note: this report fails with strict mode enabled, please disable to test

To test:
1 - Add enough holds to a record (3) to make it show on the holds ration report
2 - Browse to Circulation->Holds ratio
3 - Run with default settings and confirm the title shows up
4 - Suspend one of the holds
5 - Run report again and confirm title still shows
6 - Apply patch
7 - Reload the report
8 - Note new option
9 - Run report - title does not show
10 - Lower ratio to 2 and confirm the hold shows

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:47:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:47:42 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-SFhcQAq63c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This follows the existing pattern so I think a slight behaviour change is ok in
that case (default is now to exclude suspended holds).

Wondering if on a separate report we could reformat the checkboxes:
[checkbox] Text

And maybe:
Include instead of included?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:59:27 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-gMvGAy6nqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 12:59:30 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-tGk1bUKvJn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101353|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101363&action=edit
Bug 24902: Join different mc- limits with AND (elasticsearch)

In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.

For instance, if you select:
    Itemtypes:
        ✓ Book
        ✓ DVD
    Location:
        ✓ Child
        ✓ Adult

it should search:
    itype:(Book OR DVD) AND location:(Child OR Adult)

Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
   and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
   location, another biblio with the new collection, and again another
   biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
   "advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
   collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
   all criteria
9. Verify that if you select more than one
   {itemtype|location|collection} it still returns results that
   satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works nice, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:08:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:08:02 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-T2AxV0l5X3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tested with Firefox in Ubuntu and can't replicate the issue. What I see is
good alignment of the text on the left without the patch and a bit too much
whitespace with the patch. 
I think we might want to investigate more to nail down when the problem appears
and maybe browser differences?
Sending back to sign off for additional testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:10:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:10:07 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-xPJbAL8AyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |julian.maurice at biblibre.com
                 CC|                            |ere.maijala at helsinki.fi,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |nick at bywatersolutions.com

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Julian, do you plan to continue here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:21:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:21:30 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-8b7lTlzQGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:21:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:21:34 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-UjHiTBqdXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99517|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101364&action=edit
Bug 21800: Add tests for repeatable subfields

Test plan:
Do not apply the second patch [note 1].
Run t/db_dependent/Biblio/TransformKohaToMarc.t
Run t/db_dependent/Biblio/TransformMarcToKoha.t
Apply the second patch and run them again. Both tests should pass now.

Note 1: The TransformKohaToMarc test should fail with something like:
    #   Failed test 'Check 260e'
    #   at t/db_dependent/Biblio/TransformKohaToMarc.t line 60.
    #          got: 'A'
    #     expected: 'A | B'

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:21:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:21:37 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-ezXWbe4Qnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99518|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101365&action=edit
Bug 21800: Make TransformKohaToMarc aware of non-repeatable subfields

If a kohafield (in Koha to MARC mappings) contains a pipe char (say A | B),
we split it up into two subfields A and B in MARC.
We will only do that for repeatable subfields now. If the field is not
repeatable, the value will just be 'A | B'.

Note 1: As bug 10306 and its friends (19096) made the Default framework
authoritative, we do no longer have the frameworkcode in this routine.
Formally, we should check the corresponding framework.

Note 2: Does this impact the reverse operation in TransformMarcToKoha?
No, the check on repeatable subfields is done in the interface and not
in TransformMarcToKoha. This routine simply translates two instances of the
same subfield, say A and B, into the value 'A | B' for a kohafield. Not
allowing two instances of a non-repeatable subfield is not in the scope of
this report.

Test plan:
[1] Mark an item field as repeatable in the Default framework.
    Edit an item. Insert A|B in this field and another not-repeatable
    field. Save and reopen. Verify that the repeatable field is duplicated
    and the other one contains the pipe character in the text box.
[2] Look for a repeatable subfield in MARC like e.g. 260$c.
    Go to the cataloguing editor and add A|B in this field.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:21:40 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-E9uMt1JR7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99519|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101366&action=edit
Bug 21800: Check the correct framework for the repeatable tag

This depends on the framework parameter. Which should be added back to
the call in C4::Items.

Test plan:
[1] Mark in Default framework one subfield A repeatable and B not repeatable.
Go to item editor. (Work on a biblio in Default framework.)
Check saving and reopening these subfields with VAL1 | VAL2.
Subfield A should be cloned, B should be glued as entered.

[2] Mark in another Framework A not repeatable and B repeatable.
Change framework for this biblio.
Go to item editor again. Reopen item. Behavior subfields in reverse?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:21:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:21:44 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-T3tfLbrW2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99520|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101367&action=edit
Bug 21800: Add tests for _check_split

This new subroutine supports checking the repeatable tag from another
framework. (It will be useful for the item editor.)

Test plan:
Run t/db_dependent/Biblio/TransformKohaToMarc.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:36:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:36:01 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-6Sy1QgpoM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
                   |                            |, katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Don't understand the code well enough to QA here - still gave it a go to
provoke some movement. 

Might be my data, but I have failing tests with and without the patch:

Test Summary Report
-------------------
t/db_dependent/Koha/REST/Plugin/PluginRoutes.t (Wstat: 65280 Tests: 2 Failed:
1)
  Failed test:  2
  Non-zero exit status: 255

#   Failed test 'No tests run for subtest "Disabled plugins tests"'
#   at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 121.
Can't locate Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm in @INC (you may
need to install the Koha::Plugin::Com::ByWaterSolutions::KitchenSink module)
(@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
t/db_dependent/Koha/REST/Plugin/../../../../lib) at
/usr/share/perl/5.24/Module/Load.pm line 77.
Can't locate Koha/Plugin/Com/ByWaterSolutions/KitchenSink in @INC (@INC
contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
t/db_dependent/Koha/REST/Plugin/../../../../lib) at
/usr/share/perl/5.24/Module/Load.pm line 77.
# Looks like your test exited with 255 just after 2.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/2 subtests 


t/db_dependent/api/v1/acquisitions_orders.t          (Wstat: 256 Tests: 5
Failed: 1)
  Failed test:  1
  Non-zero exit status: 1

[Sun Mar 22 13:31:12 2020] [debug] GET "/api/v1/acquisitions/orders"
[Sun Mar 22 13:31:12 2020] [debug] Routing to controller "Koha::REST::V1::Auth"
and action "under"
[Sun Mar 22 13:31:12 2020] [debug] 400 Bad Request (0.027112s, 36.884/s)
    ok 6 - GET
//W0txdhLojIJjsOm41yB0E6aNafhS1vdorHkDUn9Z17KvscSt:thePassword123@/api/v1/acquisitions/orders?order_blah=blah
    ok 7 - 400 Bad Request
    ok 8 - exact match for JSON Pointer ""
    # Looks like you failed 2 tests of 8.
not ok 1 - list() tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:44:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:44:05 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-y5ODFjLoAy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:44:08 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-XNRcYtd2sO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101337|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101370&action=edit
Bug 24324: Resolve error with delete_records_via_leader.pl

To test:

Have a record with the 000 position 5 set to "deleted" (record status)
Use koha-shell to run the job with the -i flag: perl
misc/cronjobs/delete_records_via_leader.pl -c -i -v
* items and the record should be deleted
Mark another record with the 000 position 5 set to deleted (record status)
Use koha-shell to run the job without the -i flag: perl
misc/cronjobs/delete_records_via_leader.pl -c -v
* if the record had items, it will not be deleted
* if the record did not have items, it will be deleted.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works ok. Fixed tab char in line 98, no more errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:44:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:44:25 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-wglDhBxYPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:45:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:45:00 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-lyhcbWSZod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:53:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 13:53:15 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-qTAEx6HlK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think there is a problem here with this minimalistic approach:

- Go to the did you mean admin page
- Make changes to sequence and check/uncheck something
- Save
- Check system preference / local use / INTRAdidyoumean, it will contain only ]
- Access the did you mean page again - BOOM

malformed JSON string, neither tag, array, object, number, string or atom, at
character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171

I had a follow-up ready to remove the note form the intro text as well - it
appears unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:05:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:05:21 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-2sWwaRDknW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:05:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:05:25 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-P7tTsM2YlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100715|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101371&action=edit
Bug 24837: Rename selectbranchprinter.pl to set-library.pl

This renames the selectbranchprinter.pl file to the more
fitting set-library.pl.

To test:
- Change the library with "Set library" from
  - The menu in the top navigation bar
  - The circulation start page
- Verify the help link on page leads to the correct
  section in the manual
- Read the code... and verify all occurences have been caught

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works ok, fixed tab char in circ/branchtransfers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:08:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:08:12 +0000
Subject: [Koha-bugs] [Bug 24938] New: Mr.Jenskins
Message-ID: <bug-24938-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24938

            Bug ID: 24938
           Summary: Mr.Jenskins
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: reuspaul5656 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101372&action=edit
Hacked by Mr.Jenskins

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:08:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:08:52 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-YRuyjtHj1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:08:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:08:56 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-eCiCHIjZMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101329|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101373&action=edit
Bug 22098: Update stocknumberAV cataloguing plugin to use objects

This patch:
- changes SQL to Koha::AuthorisedValues
- remove type param from script tag
- fixes the plugin description

0) Do not apply the patch
1) Set the plugin
1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item
subfield
1.2) Add authorised values category called "INVENTORY"
1.3) Add some authorised values: authorised value is prefix and
description is a current stock/inventory number
2) Add an item and try to use this plugin to ensure you set it
correctly
2.1) Use a defined prefix to see if the number is correct
2.2) Ensure the number is correctly incremented in authorised values
2.3) Use not defined prefix to see the error message
2.4) Insert a not prefix string (eg number) to see it is not changed
3) Apply the patch
4) Repeat 2) and see it is working the same
5) Look into patch and confirm the description does make sense and is
rigth according to what you see in UI
6) Sign off :D

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:10:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:10:07 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-HAt178r2iu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101373|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101374&action=edit
Bug 22098: Update stocknumberAV cataloguing plugin to use objects

This patch:
- changes SQL to Koha::AuthorisedValues
- remove type param from script tag
- fixes the plugin description

0) Do not apply the patch
1) Set the plugin
1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item
subfield
1.2) Add authorised values category called "INVENTORY"
1.3) Add some authorised values: authorised value is prefix and
description is a current stock/inventory number
2) Add an item and try to use this plugin to ensure you set it
correctly
2.1) Use a defined prefix to see if the number is correct
2.2) Ensure the number is correctly incremented in authorised values
2.3) Use not defined prefix to see the error message
2.4) Insert a not prefix string (eg number) to see it is not changed
3) Apply the patch
4) Repeat 2) and see it is working the same
5) Look into patch and confirm the description does make sense and is
rigth according to what you see in UI
6) Sign off :D

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:10:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:10:11 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-rINz2LAf9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101330|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101375&action=edit
Bug 22098: (follow-up) fix grammar/formating Perldoc

- nubers => numbers
- some vertical spacing
- !}fmt -w65
- "contains of letters" => "containing letters"

TEST PLAN
---------
perldoc cataloguing/value_builder/stocknumberAV.pl
apply patch
perldoc cataloguing/value_builder/stocknumberAV.pl
-- after the patch is more readable.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:10:15 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-E6r7DEgHDQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101376&action=edit
Bug 22098: (QA follow-up) Improving documentation

Improves the documentation of the script a bit, but makes one
important change:

-If no prefix is submitted, or prefix does not contain only
-numbers, it returns the inserted code (= keep a field unchanged)
+If no prefix is submitted, or the prefix does contain only
+numbers, it returns the inserted code (= keep the field unchanged).

To test:
- Add an authorised INVENTORY value with 2020 as prefix
- After linking the stocknumberAV.pl to the 952$i in the frameworks
- Edit an item
- Add 2020 in the stocknumber field
- Trigger plugin
- Verify nothing happens

If the prefix contains only numbers... nothing happens.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:12:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:12:56 +0000
Subject: [Koha-bugs] [Bug 24938] SPAM
In-Reply-To: <bug-24938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24938-70-82m6soFBTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Mr.Jenskins                 |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:19:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:19:04 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-Cp6EmPWUvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:19:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:19:08 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-4E4wF1Gtzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101334|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101377&action=edit
Bug 21708: Add a few tests in TransformHtmlToMarc.t

Test plan:
Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change
patch. Verify that the test fails on the order of fields.
Go to test plan of the second patch.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test fails

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:19:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:19:13 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-ibYW8guqFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101335|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101378&action=edit
Bug 21708: Sort MARC fields in TransformHtmlToMarc

Instead of pushing 999 in the front :)

Test plan:
Do not yet apply this patch.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field (MARC21 999) follows leader.
Apply this patch. Restart Plack.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field is in right position.
Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass, correct tag order.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:33:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:33:09 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-0ccRTipXMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:33:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:33:13 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-NlflOC96Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101315|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101379&action=edit
Bug 24468: Remove unused C4::Reserves::_get_itype subroutine

Since bug 21206, C4::Reserves::_get_itype is not longer used and should
be removed.

  commit 31c29fd31f557306233e6a2936148a5bb10b89a1
  Bug 21206: Replace C4::Items::GetItem

UPDATE: In the meanwhile another occurrence was added to Reserves.t, but
easy to replace

Test plan:
  % git grep _get_itype
must not return any occurrences.

If one needs it, Koha::Item->effective_itemtype must be used instead.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:57:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:57:05 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-ceIVtoI0NC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 15:57:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 14:57:09 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-uEtziwUeIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101014|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101380&action=edit
Bug 22589: Remove C4::Overdues::BorType

Test plan:
0) Apply patch
1) try to run affected scripts and ensure the amounts are corectly
calculated for different patron categories:
    installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl
    misc/cronjobs/fines.pl
    misc/cronjobs/staticfines.pl

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:34:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:34:13 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-BCd0p1c87I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101381&action=edit
Bug 24108: Advanced Editor: Save .mrc save with a configurable value

Creates a new systempref "SaveRecordbyControlNumber" which is initially
set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the
biblionumber.

To test:

    Apply the patches.
    1. Open a record in the advanced editor
    2. Save the record using the drop down box selecting "Save as MARC
    (.mrc) file.
    3. Note that the file saved is the same as the biblionumber at the top
    of the Advanced Editor interface.
    <Repeat steps 1-3 for the .xml save option>

    4. Update the preference:
        Search for "SaveRecordbyControlNumber" in system preferences. Change to
"Save by ControlNumber"

    5. Restart Koha

    6. Verify that there is not a 001 field in the record (delete it if
            there is)

    Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should
still be saved as the
            biblionumber if there is no control field)

    7. Add a 001 field to the record such as "001  abc00012345"

    Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved
    are named abc00012345.mrc and abc00012345.xml

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:34:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:34:16 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-PjFJvQRO1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101382&action=edit
Bug 24108: (follow-up) Fix capitalization of sys pref description

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:34:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:34:21 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-Tzo4qrZnVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101383&action=edit
Bug 24108: Alternativ phrasing of the system preference decription

Suggestion:
When exporting a record in the advanced editor (Rancor), use the
[biblionumber|control number] in the file name. Default is by biblionumer.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:35:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:35:07 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a
 configurable value
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-BnBwvT0e42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101383|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101384&action=edit
Bug 24108: (follow-up) Alternative phrasing of the system preference decription

Suggestion:
When exporting a record in the advanced editor (Rancor), use the
[biblionumber|control number] in the file name. Default is by biblionumer.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:38:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:38:09 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber
 or control number is used for saved files
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-wH9L3nIuKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Advanced Editor: Save .mrc  |Advanced editor: configure
                   |save with a configurable    |if biblionumber or control
                   |value                       |number is used for saved
                   |                            |files
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Cori,

i added 2 follow-ups:
- A fix for the capitalization in your pref description (this would be a QA
blocker)
- A suggestion for rephrasing it - I think it might be easier to understand
(hopefully).

There is still a blocker for me. If 001/biblionumer (for a new record) is
missing, we now get .mrc or .xml as file name. Before there was record.mrc
record.xml. I think we should keep this behaviour - a fallback for missing
values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:38:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:38:27 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber
 or control number is used for saved files
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-praoEO4deH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101069|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 16:38:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 15:38:50 +0000
Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber
 or control number is used for saved files
In-Reply-To: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24108-70-PTSDJ1JKmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 17:00:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 16:00:27 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-O6K3kPE9Ya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, 

giving this a go:

1) QA Tools fail:

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   tinyint_has_boolean_flag
                The new column itemtypes.rentalcharge_daily_calendar is using
TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline
                The new column itemtypes.rentalcharge_hourly_calendar is using
TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline


2) Usability

I am a bit worried about usability:

Say: finescalender is set to ignore holidays.
And on the itemtype I check:
Daily rentals use calendar

But, if I understand correctly, they won't - because it falls back to
finescalendar which is set to ignore holidays. 

This seems potentially confusing to me, as you can't see what finescalendar is
set to and you have to read the 'fine print' (hint) and look it up to determine
the actual behaviour.

Instead, maybe we could label it:
Use finescalendar setting. If not checked, holidays will be excluded when
calculating rental charges. (please feel free to rephrase!)

We could also include the value of finescalendar somewhere in the template
maybe?

Alternatively... should we remove the dependeny on finescalendar and make just
the itemtype setting relevant?

then we could just have:
- ignore calendar
- exclude holidays

And it would be immediately visible from the item type configuration page, what
rule will apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 17:04:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 16:04:24 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-XuoUkWpjbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Currently blocked by bug 24455 - please reset once dependencies have cleared
up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 17:17:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 16:17:15 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15400-70-63kNm8IveB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Applying these patches, patron search does no longer work for me:
SyntaxError: JSON.parse: bad control character in string literal at line 22
column 20 of the JSON data

Please double check!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:17:24 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-EZGRQB13Hv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101385&action=edit
Bug 24476 Standardize on 'auto renew(al)' and improve db update

There were several versions: auto renew, auto-renew, autorenew
I've decided to use auto renew (from automatic renewal) to keep
things a bit more consistent.

The DB update was missing AFTER and IGNORE for the sys pref.
Also fixed a tiny typo (tp > to)
Also changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:19:46 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-0wpFWQCPHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am stuck on this one :( 

The schema update patch would not apply, so I skipped it.
Tried running DBIC:

Koha::Schema::Result::Zebraqueue->set_primary_key("id");
DBIx::Class::ResultSource::column_info(): No such column autorenew_checkouts at
(eval 1297) line 1656


Tried running the updatedatabase script (with and without my patch):

$ updatedatabase 
{UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column
autorenew_checkouts at /home/vagrant/kohaclone/Koha/Schema/Result/Borrower.pm
line 1656
Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm
line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155
Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm line
50.

Can you please check and rabase? Also added a follo-up, please have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:36:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:36:01 +0000
Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing
In-Reply-To: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23415-70-V3A0h8Jn4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am wondering if noissuecharge is the right value here.

We got: 
OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff
specifically.

noissuecharge = fine limit for checkouts (as name says). It's used in this
patch set, but there are other complications with this one:

noissuescharge  
Prevent patrons from checking out books if they have more than EUR in fines.

HoldsInNoissuesCharge   
[Don't include|Include] hold charges when summing up charges for
noissuescharge.
ManInvInNoissuesCharge  
[Don't include|Include] custom debit type charges when summing up charges for
noissuescharge.
RentalsInNoissuesCharge         
[Don't include|Include]  rental charges when summing up charges for
noissuescharge. 
NoIssuesChargeGuarantees        
Prevent a patron from checking out if the patron has guarantees owing in total
more than EUR in fines.

So I think this is not covering it:

+  my $amountlimit = C4::Context->preference("noissuescharge");
+  var fines = "[% fines | html %]

We'd need the amount calculated taking all noissues* prefs into account.

I think I'd prefer not using noissuecharge here, as it only speaks of checkouts
and we have a distinct one for renewals. Using OPACFineNoRenewals would make
sense to me, as you can still override in the staff interface. So having a
'hint' there would work.


Also a little worried that this adds a confirm step - but as none of the
testers complained, I think it's probably ok :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:47:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:47:16 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-XMqbzBEDV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The tests are failing for me:

t/XSLT.t ............... 
1..12
ok 1 - use C4::XSLT;
ok 2 - Found test/en
ok 3 - Found test/es-ES
ok 4 - Found test/en
ok 5 - Found test/es-ES
ok 6 - Fell back to test/en for test/fr-FR
ok 7 - Fell back to prog/es-ES for nope/es-ES
ok 8 - Fell back to prog/en for nope/fr-FR
ok 9 - singleBranchMode has a value of 0
Use of uninitialized value in pattern match (m//) at
/home/vagrant/kohaclone/C4/XSLT.pm line 422.
not ok 10 - CustomXSLTExportList finds custom XSLTs

#   Failed test 'CustomXSLTExportList finds custom XSLTs'
#   at t/XSLT.t line 107.
Use of uninitialized value in string eq at t/XSLT.t line 108.
not ok 11 - Title is specified in root node

#   Failed test 'Title is specified in root node'
#   at t/XSLT.t line 108.
Use of uninitialized value in string eq at t/XSLT.t line 109.
not ok 12 - Title is filename if not specified

#   Failed test 'Title is filename if not specified'
#   at t/XSLT.t line 109.
# Looks like you failed 3 tests of 12.
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/12 subtests 

Test Summary Report
-------------------
t/XSLT.t             (Wstat: 768 Tests: 12 Failed: 3)
  Failed tests:  10-12
  Non-zero exit status: 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:52:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:52:21 +0000
Subject: [Koha-bugs] [Bug 23409] Show circulation note and OPAC note with
 line feeds
In-Reply-To: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23409-70-tiUhV6QgkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:52:25 +0000
Subject: [Koha-bugs] [Bug 23409] Show circulation note and OPAC note with
 line feeds
In-Reply-To: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23409-70-Y5UYZDczjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99712|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101386&action=edit
Bug 23409: show borrowernotes and opacnote's lines feeds

Test plan:
  - Fill borrowernotes and opacnote with lines separated by lines
    endings,
  - save and check the content is displayed on a single line,
  - apply this patch,
  - check lines endings are displayed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:52:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:52:28 +0000
Subject: [Koha-bugs] [Bug 23409] Show circulation note and OPAC note with
 line feeds
In-Reply-To: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23409-70-G6DXQRNu5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99713|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101387&action=edit
Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in
OPAC user account

This patch makes 2 changes:
- bug 22702 allowed adding HTML to the circulation note, so this patch
  restores that ability.
- display OPAC note and messages as multi-line in OPAC

To test:
- Add a circulation and an OPAC note with line breaks and HTML tags
  to the patron account
- Add a message with line breaks to the patron account
- Check line breaks don't show on
  - OPAC > patron account > my summary page
  - Staff > patron account > details
- Apply patches
- Repeat test

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Notes and messages show line breaks in OPAC, Notes on staff
HTML tags are processed in circulation notes
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:54:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:54:12 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-MhH4OaDw1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, could you add a copyright message?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:54:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:54:43 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-GM1v1x9tWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #29)
> Currently blocked by bug 24455 - please reset once dependencies have cleared
> up!

You can QA it anyways. I think Martin and Agustín has a conversation about this
but the status wasn't updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 18:56:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 17:56:32 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-jNyUcjQfxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
QA tools fail:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
   FAIL   filters
                missing_filter at line 308 (                    <option
value="[% active_currency.rate %]" selected="selected">[%
active_currency.currency %] ([% active_currency.symbol %])</option>)
                missing_filter at line 308 (                    <option
value="[% active_currency.rate %]" selected="selected">[%
active_currency.currency %] ([% active_currency.symbol %])</option>)
                missing_filter at line 308 (                    <option
value="[% active_currency.rate %]" selected="selected">[%
active_currency.currency %] ([% active_currency.symbol %])</option>)
                missing_filter at line 310 (                        <option
value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol
%])</option>)
                missing_filter at line 310 (                        <option
value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol
%])</option>)
                missing_filter at line 310 (                        <option
value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol
%])</option>)

I know this will bounce back quickly :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:01:49 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22890-70-bmCTCkhLgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101388&action=edit
Bug 22890: Add CHANGELOG.md and display it in About page

CHANGELOG.md was generated by the following command:

ls misc/release_notes/*.md \
    | sort --reverse -V \
    | xargs cat \
    | sed -e 's/^#/##/' -e '1 i\# Changelog\n' > CHANGELOG.md

Releases notes before 16.05 were not generated in markdown, so they are
not included in CHANGELOG.md

Markdown to HTML conversion is done in the browser, using Showdown
(http://showdownjs.com/)

I also tested Text::Markdown from CPAN
(https://metacpan.org/pod/Text::Markdown) but it was very slow.
Text::Markdown from https://daringfireball.net/projects/markdown/ was
faster but cannot be found on CPAN.
I also considered pandoc but it was a bit slow too and required
more additional dependencies.

Converting in the browser is slow too but has the benefit of allowing
the reader to have access to the raw changelog before it is correctly
rendered (so they can start reading it)
On the other side, converting on the server side we would be able to
put the resulting html in cache.
Suggestions welcome :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:10:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:10:29 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-i9APgWzHfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Katrin, I'm not very familiar with the ES code yet, I just pointed out the
obvious problems. It's probably better if someone else review the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:21:20 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-Povolxg33d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98448|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101389&action=edit
Bug 24591: Add developer script to preview a letter

The script is very simple, it just calls GetPreparedLetter with
arguments given on command line and print the resulting letter content

Usage example:

misc/devel/get-prepared-letter.pl --module circulation \
    --letter_code ODUE --tables '{"borrowers":1,"branches":"CPL"}' \
    --repeat '{"item":[{"biblio":1,"items":1}]}' \
    --loops '{"overdues":[1]}'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:21:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:21:44 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-aDVW0uHYfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Hi, could you add a copyright message?

Done ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:28:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:28:14 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24823-70-trNk67sveB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|julian.maurice at biblibre.com |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Julian Maurice from comment #8)
> Katrin, I'm not very familiar with the ES code yet, I just pointed out the
> obvious problems. It's probably better if someone else review the patches.

Thx Julian for the feedback. Ere or Nick, could one of you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:55:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:55:29 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-6iKjbcem52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:55:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 18:55:32 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-DhWrRQ0Qrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101389|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101390&action=edit
Bug 24591: Add developer script to preview a letter

The script is very simple, it just calls GetPreparedLetter with
arguments given on command line and print the resulting letter content

Usage example:

misc/devel/get-prepared-letter.pl --module circulation \
    --letter_code ODUE --tables '{"borrowers":1,"branches":"CPL"}' \
    --repeat '{"item":[{"biblio":1,"items":1}]}' \
    --loops '{"overdues":[1]}'

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works for the example and other cases.
Correct option is 'letter-code', with dash, not underscore.
An usage message would be nice.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:34:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 19:34:00 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-Y8zv6fB6jw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #26 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Thanks very much everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 20:04:23 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-y0UvX5rrLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:04:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 20:04:27 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-BxXlO8BzWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100971|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101391&action=edit
Bug 16457: Remove the use of "onclick" from the patron entry form

This patch removes several event attributes from the patron entry form
and replaces them with event handlers in the <script> block.

Some event attributes were removed altogether because they weren't
functional: Onchange events on jQueryUI datepickers don't work, and they
would have been redundant even if they did work.

To test you should have some patron attributes configured
(Administration -> Patron attribute types). At least one attribute
should be configured to apply to one particular patron category.

Apply the patch and begin the process of adding a new patron.

1. Try to add a patron with details matching a patron which already
   exists. You should get a confirmation message on screen which asks if
   the patron is a duplicte. Test the link which shows the existing
   record. It should trigger a popup window with details about the
   patron.

2. Test the process of setting a patron's date of birth. Selecting a
   date should trigger the display of the patron's age immedately below
   the field.

3. Test that you cannot set a patron's expiration to a date which
   precedes the date in the registration date field.

4. Test that you can add a manual restriction's expiration date, and
   that the "Clear date" link works correctly.

5. Test that the "clear" and "new" controls links work with additional
   attributes and identifiers.

6. Test that changing the patron's category correctly affects the
   display of available attributes and identifiers: The attribute you
   have associated with a particular patron category should only show if
   that category is selected under "Category."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Easy to follow test plan, all works, but on point 5. I found one 'clear'
but no 'new' control link, it's my only comment.
No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:21:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:21:53 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
 to news block
In-Reply-To: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23794-70-N3Q0Lq0S5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:21:57 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
 to news block
In-Reply-To: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23794-70-IAgxNqUOqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99704|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101392&action=edit
Bug 23794: Convert OpacMainUserBlock system preference to news block

This patch builds on Bug 22318 to move the OpacMainUserBlock system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the OpacMainUserBlock system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and confirm that the content which was previously in
   the OpacMainUserBlock system preference now displays correctly where
   it was before.
 - In the staff client, go to Tools -> News and verify that the content
   from OpacMainUserBlock is now stored in news items. There should be
   one entry for each of the enabled translations in your system, for
   instance 'opacmainuserblock_en', 'opacmainuserblock_fr-FR',
   'opacmainuserblock_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   OpacMainUserBlock preference has been removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works like a charm.
Don't forget to run ./translate update/install for your language(s)
after the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:25:46 +0000
Subject: [Koha-bugs] [Bug 24939] New: Labels in system preferences not
 following capitalization rules
Message-ID: <bug-24939-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24939

            Bug ID: 24939
           Summary: Labels in system preferences not following
                    capitalization rules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When looking at the section headings in the system preferences editor under
administration, you can spot some 'capitalization rules' violations:

Examples:
Administration tab: Search Engine => Search engine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:26:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:26:01 +0000
Subject: [Koha-bugs] [Bug 24939] Labels in system preferences not following
 capitalization rules
In-Reply-To: <bug-24939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24939-70-PJNMYWwAUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24939

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Putting this on the Trello as an academy bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:33:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:33:51 +0000
Subject: [Koha-bugs] [Bug 24940] New: Serials statistics wizard: order
 vendor list alphabetically
Message-ID: <bug-24940-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24940

            Bug ID: 24940
           Summary: Serials statistics wizard: order vendor list
                    alphabetically
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Currently the vendor pull down in the serials statistics wizard appears to be
ordered by vendor id instead of sorting alphabetically by vendor name. This is
quite confusing for a longer list.

To test:
- Add at least 2 vendors: 
 - First: Zzzz
 - Second: Aaaa
- Add subscriptions for each of the vendors
- Check the pull down in the serials statistics wizard
- Verify it lists them as Zzzz, Aaaa

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:37:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 22:37:29 +0000
Subject: [Koha-bugs] [Bug 24941] New: Serials: Link to basket in acqusition
 details is broken
Message-ID: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

            Bug ID: 24941
           Summary: Serials: Link to basket in acqusition details is
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When using 'order from a subscription', acquisition details will show in the
serials module on the subscription detail page.

The basketnumber is linked, but the URL is broken:
http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=

It's missing the basketno parameter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 23:21:57 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-BNBnCh7zhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24942
[Bug 24942] Pre-fill guarantee altcontactdetails from guarantor record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 23:21:57 +0000
Subject: [Koha-bugs] [Bug 24942] New: Pre-fill guarantee altcontactdetails
 from guarantor record
Message-ID: <bug-24942-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24942

            Bug ID: 24942
           Summary: Pre-fill guarantee altcontactdetails from guarantor
                    record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: alexbuckley at catalyst.net.nz
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 23808

If you're adding a guarantee to a adult/guarantor record (using the 'Add a
guarantee' button) then the guarantor's details should pre-fill the guarantee
alternate contact fields.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808
[Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 23:22:12 +0000
Subject: [Koha-bugs] [Bug 24942] Pre-fill guarantee altcontactdetails from
 guarantor record
In-Reply-To: <bug-24942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24942-70-jTqqIgafjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24942

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2020 23:23:33 +0000
Subject: [Koha-bugs] [Bug 23795] Convert OpacCredits system preference to
 news block
In-Reply-To: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23795-70-INnaBO4eUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Owen,
patch works ok, but:

* Commit message references Bug 23794 instead of 23795 (easy)
* QA tools complains
 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                koha_news_block: not found

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 01:08:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 00:08:02 +0000
Subject: [Koha-bugs] [Bug 1145] In basket.tmpl,
 man nav extends beyond left-hand nav
In-Reply-To: <bug-1145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1145-70-o5g2rBW81k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1145

Deni mardiansyah <denimardiansyah551 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |denimardiansyah551 at gmail.co
                   |                            |m

--- Comment #1 from Deni mardiansyah <denimardiansyah551 at gmail.com> ---
Created attachment 101393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101393&action=edit
Qimack

Touched by me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 01:09:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 00:09:12 +0000
Subject: [Koha-bugs] [Bug 24943] New: Hand
Message-ID: <bug-24943-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24943

            Bug ID: 24943
           Summary: Hand
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: denimardiansyah551 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101394&action=edit
Qimack

Touched by me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:32:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:32:10 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-Bxwf1xvITo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
                   |ity.org                     |
                 CC|                            |alexbuckley at catalyst.net.nz
             Status|NEW                         |ASSIGNED

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Caroline, 

This sounds like a really great enhancement. I'd love to work on this. 

Thanks,
Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:36:17 +0000
Subject: [Koha-bugs] [Bug 18501] Automatic refunds need protection from
 failure
In-Reply-To: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18501-70-OBUqQRueC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun
                   |                            |ity.org
             Status|ASSIGNED                    |NEW

--- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Martin, 

So sorry! I completely forgot about this patch. I'll un-assign myself now, as I
currently don't have enough time to work on it. 

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:39:06 +0000
Subject: [Koha-bugs] [Bug 18715] Enhance Koha feature release change tool by
 making sysprefs searchable,
 and announce the new version in staff client with translatable news item
In-Reply-To: <bug-18715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18715-70-tMK4mtXi9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18715

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Unassigning myself as I currently do not have time to work on this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:43:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:43:02 +0000
Subject: [Koha-bugs] [Bug 19359] Reporting module selenium test
In-Reply-To: <bug-19359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19359-70-VwAPhjW8jk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz

--- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
As I don't have time to work on this at present I am unassigning myself in case
someone else can take it on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:49:13 +0000
Subject: [Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item
 selenium test
In-Reply-To: <bug-18974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18974-70-PjaTz7Jxrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
As I don't have time to work on this at present I am unassigning myself in case
someone else wants to take it on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:49:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:49:31 +0000
Subject: [Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium
 test
In-Reply-To: <bug-19182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19182-70-UTjzh8ch49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz

--- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
As I don't have time to work on this at present I am unassigning myself in case
someone else wants to take it on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:50:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:50:24 +0000
Subject: [Koha-bugs] [Bug 19184] Purchase workflow selenium test
In-Reply-To: <bug-19184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19184-70-PmV70k9zbN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
As I don't have time to work on this at present I am unassigning myself in case
someone else wants to take it on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 02:50:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 01:50:53 +0000
Subject: [Koha-bugs] [Bug 19183] Acquisition module setup selenium test
In-Reply-To: <bug-19183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19183-70-KK9Co5ny2J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 03:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 02:00:25 +0000
Subject: [Koha-bugs] [Bug 24942] Pre-fill guarantee altcontactdetails from
 guarantor record
In-Reply-To: <bug-24942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24942-70-bS2kuQnjER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24942

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Actually I think this would be better handled in bug 22534 , as library staff
would have more control over what fields are pre-filled in guarantee record
from guarantor. 

So will close this ticket and work on 22534 instead.

*** This bug has been marked as a duplicate of bug 22534 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 03:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 02:00:25 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-MsuTEOxvtq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
*** Bug 24942 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 04:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 03:01:40 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-sh0TiPLFCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #23 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #20)
> Templates can be used in "Tools » Notices & Slips", they can be written by
> users.

I admit that I hadn't inspected that code. I had expected that we weren't
letting users use plugins.

However, looking at C4::Letters::_process_tt, it does look like we're using
"Koha::Template::Plugin" for a PLUGIN_BASE.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 04:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 03:03:31 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-Z6mErhClYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #22)
> Maybe we can find something better than the dirty way and the security-hole
> way, like a method ArePluginsEnabled in Koha::Template::Plugin::Koha ?

That sounds reasonable to me. 

(Alternatively, we can use multiple PLUGIN_BASE values for system templates (ie
templates that can't be manipulated by a user), but that could be easy to screw
up too.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 05:17:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 04:17:50 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-IyO2Ytqo0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
Created attachment 101395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101395&action=edit
ubuntu 19.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 05:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 04:18:25 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-nxqZZle34i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #17 from Mason James <mtj at kohaaloha.com> ---
Created attachment 101396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101396&action=edit
ubuntu 19.10 (2)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 05:19:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 04:19:07 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-zxebU9IDsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #18 from Mason James <mtj at kohaaloha.com> ---
(In reply to Katrin Fischer from comment #15)
> I tested with Firefox in Ubuntu and can't replicate the issue. What I see is
> good alignment of the text on the left without the patch and a bit too much
> whitespace with the patch. 
> I think we might want to investigate more to nail down when the problem
> appears and maybe browser differences?
> Sending back to sign off for additional testing.

hi Cait
heres an pic of the problem on ubuntu 19.10, with firefox 69.0.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 06:33:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 05:33:09 +0000
Subject: [Koha-bugs] [Bug 24944] New: Yaya
Message-ID: <bug-24944-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24944

            Bug ID: 24944
           Summary: Yaya
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hea
          Assignee: chris at bigballofwax.co.nz
          Reporter: mrkucing35 at gmail.com
        QA Contact: jonathan.druart at bugs.koha-community.org

Created attachment 101397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101397&action=edit
Yaayay

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 06:58:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 05:58:01 +0000
Subject: [Koha-bugs] [Bug 24945] New: Beesaandidi
Message-ID: <bug-24945-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24945

            Bug ID: 24945
           Summary: Beesaandidi
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hea
          Assignee: chris at bigballofwax.co.nz
          Reporter: apriapri271 at gmail.com
        QA Contact: jonathan.druart at bugs.koha-community.org

Created attachment 101398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101398&action=edit
./apribees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 06:22:23 +0000
Subject: [Koha-bugs] [Bug 24946] New: Awokaoqi
Message-ID: <bug-24946-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24946

            Bug ID: 24946
           Summary: Awokaoqi
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jessenaota at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101399&action=edit
Awokaowk

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:32:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 06:32:43 +0000
Subject: [Koha-bugs] [Bug 1145] In basket.tmpl,
 man nav extends beyond left-hand nav
In-Reply-To: <bug-1145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1145-70-WJtgCxsakp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:00:12 +0000
Subject: [Koha-bugs] [Bug 24943] SPAM
In-Reply-To: <bug-24943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24943-70-3gOdW1QABt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
            Summary|Hand                        |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:00:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:00:48 +0000
Subject: [Koha-bugs] [Bug 24944] SPAM
In-Reply-To: <bug-24944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24944-70-agTLC0RWDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Yaya                        |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:01:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:01:15 +0000
Subject: [Koha-bugs] [Bug 24945] SPAM
In-Reply-To: <bug-24945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24945-70-ExGtUgXFtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Beesaandidi                 |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:01:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:01:41 +0000
Subject: [Koha-bugs] [Bug 24946] SPAM
In-Reply-To: <bug-24946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24946-70-HflD0UBq3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24946

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
            Summary|Awokaoqi                    |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:01:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:01:43 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-H0dkE8hSZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thx Bernardo and Katrin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:12:07 +0000
Subject: [Koha-bugs] [Bug 24947] New: Beesaandidi
Message-ID: <bug-24947-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24947

            Bug ID: 24947
           Summary: Beesaandidi
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hea
          Assignee: chris at bigballofwax.co.nz
          Reporter: apriapri271 at gmail.com
        QA Contact: jonathan.druart at bugs.koha-community.org

Created attachment 101400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101400&action=edit
./apribees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:15:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:15:07 +0000
Subject: [Koha-bugs] [Bug 24947] SPAM
In-Reply-To: <bug-24947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24947-70-t7BQHSN149@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
            Summary|Beesaandidi                 |SPAM
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:24:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:24:15 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22890-70-he0DOgu9Ip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:28:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 07:28:45 +0000
Subject: [Koha-bugs] [Bug 24948] New: medan
Message-ID: <bug-24948-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24948

            Bug ID: 24948
           Summary: medan
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Bugzilla
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: medancybertersakititeam at gmail.com

Created attachment 101401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101401&action=edit
medan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:18:35 +0000
Subject: [Koha-bugs] [Bug 24949] New: Show password in staff login screen on
 user's demand
Message-ID: <bug-24949-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949

            Bug ID: 24949
           Summary: Show password in staff login screen on user's demand
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

A lot of applications allow you to see the password you typed in on demand,
often requiring you to click on an "eye" symbol or similar. 

This would also be helpful for the staff interface to help people check for
typos when trying to log into Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:30:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:30:20 +0000
Subject: [Koha-bugs] [Bug 24949] Provide password visibility toggle / icon
 to unmask password on staff login screen
In-Reply-To: <bug-24949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24949-70-GSlNqsD39Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show password in staff      |Provide password visibility
                   |login screen on user's      |toggle / icon to unmask
                   |demand                      |password on staff login
                   |                            |screen

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:33:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:33:58 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-xVAKXdHV3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:34:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:34:02 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-Zhi3jbr5Dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101402&action=edit
Bug 24158: Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:40:13 +0000
Subject: [Koha-bugs] [Bug 24937] SPAM
In-Reply-To: <bug-24937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24937-70-fIewMYwWla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24937

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
              Group|Koha security               |
            Summary|Yeps                        |SPAM
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
            Product|Koha security               |Koha
         Resolution|---                         |INVALID
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:41:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:41:28 +0000
Subject: [Koha-bugs] [Bug 24936] SPAM
In-Reply-To: <bug-24936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24936-70-wJfqt7WpPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
              Group|Koha security               |
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
            Product|Koha security               |Koha
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
             Status|NEW                         |RESOLVED
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 09:41:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 08:41:57 +0000
Subject: [Koha-bugs] [Bug 24935] SPAM
In-Reply-To: <bug-24935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24935-70-B85R5rucP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24935

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org
            Summary|Hahahwhw                    |SPAM
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
            Product|Koha security               |Koha
         Resolution|---                         |INVALID
              Group|Koha security               |
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:14:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:14:32 +0000
Subject: [Koha-bugs] [Bug 24948] SPAM
In-Reply-To: <bug-24948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24948-70-XGPiAkiwrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24948

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Bugzilla                    |Architecture, internals,
                   |                            |and plumbing
            Product|Project Infrastructure      |Koha
         Resolution|---                         |INVALID
           Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
                   |ommunity.org                |ity.org
            Summary|medan                       |SPAM
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:14:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:14:45 +0000
Subject: [Koha-bugs] [Bug 24948] SPAM
In-Reply-To: <bug-24948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24948-70-vo1YN7QJ0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24948

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:15:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:15:32 +0000
Subject: [Koha-bugs] [Bug 24950] New: hoakkas
Message-ID: <bug-24950-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24950

            Bug ID: 24950
           Summary: hoakkas
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Bugzilla
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: 9maissacerisef at snapfishvaluepass.com

Created attachment 101403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101403&action=edit
heriko

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:20:07 +0000
Subject: [Koha-bugs] [Bug 24950] SPAM
In-Reply-To: <bug-24950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24950-70-DaRvn2COH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24950

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
            Summary|hoakkas                     |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:23:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:23:17 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-EiPdaKItgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:23:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OF37wT7EXP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #151 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:44:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:44:31 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
 the inbound email address
In-Reply-To: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22823-70-t2Cjp8JvLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds a new
      release notes|                            |`inbound_email_address`
                   |                            |method to the Koha::Library
                   |                            |class. This allows for a
                   |                            |consistent way of getting a
                   |                            |libraries branch email
                   |                            |address for incoming mail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:46:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:46:19 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
 from GitHub
In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23975-70-LGK0t2UDkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:46:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:46:40 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-nPwnFwsBSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98694|0                           |1
        is obsolete|                            |
  Attachment #98695|0                           |1
        is obsolete|                            |
  Attachment #98696|0                           |1
        is obsolete|                            |
  Attachment #98697|0                           |1
        is obsolete|                            |

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101404&action=edit
Bug 8132: No changes but disable checkboxes

When the list of items is displayed we already know if there will be a
problem during the deletion. So let's disable the checkbox to tell the
user in advance that items cannot be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:46:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:46:45 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-XjaaVScQHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101405&action=edit
Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion

If an item is the last one of a biblio that have biblio-level hold
placed on it, we should block the deletion.
It takes effect if the hold is found (W or T), to follow existing
behavior for item-level holds.
If we want to block deletion for any holds we should deal with it on a
separate bug report.

Test plan:
0/ Setup
Create Biblio B1 with 1 item
Create Biblio B2 with 2 items
Create Biblio B3 with 1+ item
Create Biblio B4 with 1+ item
Create Biblio B5 with 1+ item
Place a biblio-level hold on B1 and B2
Place an item-level hold on B3 and B4
Confirm the item-level hold for the items of B3 to mark it waiting.

1/ Delete those 6 items in a batch
=> delete of item from B1 is blocked on first screen - only 1 item left
and there is a biblio-level hold on the record
=> delete of items from B2 is *not* blocked on first screen - One of
them will block the deletion, but so far we are not aware of that
situation
=> delete of item from B3 is blocked on first screen - there is a
waiting item-level hold placed on the item
=> delete of item from B4 is *not* blocked - there is a hold but it is
not found
=> delete of item from B5 is *not* - there is no reason to block its
deletion

Note that you can only select items from B2, B4 and B5

2/ Select them and confirm the deletion
=> Nothing happened and you get a message saying that one of the 2 items
from B2 is blocking the whole deletion process

3/ Remove the biblio-level hold
4/ Repeat 1
=> The deletion has been effective!

=> Note that there is something a bit weird as we are blocking items
from a biblio that has biblio-level holds on it (not found), but we
do not blocking the deletion of an item with a waiting item-level hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:46:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:46:54 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-5EL1IhssEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101406&action=edit
Bug 8132: Delete the items in a transaction and rollback if something wrong

The last_item_for_hold case cannot be guessed (easily), and so we are going to
delete the items in a transaction. If something wrong happened we
rollback and display a list of items that caused the rollback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:47:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:47:00 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-DXelAFb5vx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101407&action=edit
Bug 8132: Adding message when deleting from the UI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:47:12 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-PqQHybWn6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gitlab.com/joubu/Ko |
                   |ha/commits/bug_8132         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:51:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:51:36 +0000
Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when
 all fines on item are paid off
In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23051-70-GDifQjNp1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With the addition of a new
      release notes|                            |`RenewAccruingItemWhenPaid`
                   |                            |system preference, we gain
                   |                            |the ability to
                   |                            |automatically renew items
                   |                            |with accruing fines at the
                   |                            |point of payment of those
                   |                            |fines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:53:39 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-nXPESyIuPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With the addition of the
      release notes|                            |`reason` field to the
                   |                            |`branchtransfers` table
                   |                            |this allows us to track
                   |                            |what triggered a transfer
                   |                            |which is helpful both for
                   |                            |later audit and for later
                   |                            |use in code where we may
                   |                            |want to cancel or replace
                   |                            |existing transfers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:02 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-4LHbanvakm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:06 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-9t9iZzFYM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98273|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101408&action=edit
Bug 24463: Add a basket_group relationship for baskets

This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:35 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-NHLRhWgnc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:39 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-61sJTK854K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98275|0                           |1
        is obsolete|                            |
 Attachment #101316|0                           |1
        is obsolete|                            |
 Attachment #101317|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101409&action=edit
Bug 24464: Unit tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:43 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-I6Y7slcE3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101410&action=edit
Bug 24464: Add K::A::Basket->creator

This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.

Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:55:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:55:47 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-b1KgN63MIE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101411&action=edit
Bug 24464: (QA follow-up) Make the method reflect the lack of FK

This patch makes it super obvious to understand by reading the code that
there's originally no foreign key.

To test:
1. Run the tests and notice they pass
2. Spot the # FIXME
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:56:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:56:56 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-1KPWQmfiJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:57:00 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-Jkr1YNvYv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101319|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101412&action=edit
Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket

When bug 18731 was written, the official vote on the RFC hadn't been
held yet. Once it got voted, the mappings were adapted and all the
dependent work fixed as well. But three attribute names were overlooked
and they become evident on developing 20212 which required them.

This patch fixes this really tiny mistake.

To test:
1. Just verify the voted attribute names.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 10:57:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 09:57:29 +0000
Subject: [Koha-bugs] [Bug 24651] Add --maxdays option to fines.pl to reduce
 the chance of re-processing very old, already capped, fines.
In-Reply-To: <bug-24651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24651-70-SQTl2sfeWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24651

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Improve the performances of
      release notes|                            |the fines.pl cronjob by
                   |                            |reducing the number of
                   |                            |accountlines it targets by
                   |                            |this new `--maxdays`
                   |                            |option.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:07:58 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22890-70-IY5d7ZsLVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hello Julian,

I do not understand, I though we wanted something different from the release
notes and more dev oriented, "what was pushed in the last weeks?". Where are
the deprecated, new sysprefs, etc. we talked about earlier?

I do not see the difference with
https://gitlab.com/koha-community/koha-release-notes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:22:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:22:00 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22890-70-LdQ0frEDYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi,

Sorry for not making it clear: the patch is only a first step of displaying a
CHANGELOG.md in Koha about page and I took the contents of release notes only
as an example. What we want to put in CHANGELOG.md is still to be discussed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:35:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:35:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-1ZFa2qA7bz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #152 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101413&action=edit
Bug 23463: Replace a new occurrence of ModItem

This new script have been pushed just before 23463.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:35:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:35:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-70ZaBZmClP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #153 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101414&action=edit
Bug 23463: Fix CourseReserves/CourseItems.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:36:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:36:38 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OndYzrMLak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #154 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101415&action=edit
Bug 23463: (RM follow-up) Add try block around Illrequest item creation

The recently introduced Ill item creation for circulation feature was
not properly handling the move from AddItem to Koha::Item->new()->store.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:37:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:37:24 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-k3agee05L5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #155 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101416&action=edit
Bug 23463: Fix wrong variable name

Fix for t/db_dependent/Labels/t_Batch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:50:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:50:09 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-h1KNJloM5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93319|0                           |1
        is obsolete|                            |
  Attachment #93869|0                           |1
        is obsolete|                            |
  Attachment #94369|0                           |1
        is obsolete|                            |
  Attachment #94370|0                           |1
        is obsolete|                            |
  Attachment #95949|0                           |1
        is obsolete|                            |
  Attachment #97625|0                           |1
        is obsolete|                            |

--- Comment #25 from delaye <stephane.delaye at biblibre.com> ---
Created attachment 101417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101417&action=edit
xslt opac

new xslt opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:51:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:51:30 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-t6IODGqVcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

--- Comment #26 from delaye <stephane.delaye at biblibre.com> ---
Created attachment 101418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101418&action=edit
xslt intranet

new xslt intranet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:51:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:51:44 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-Ayer4Is2VT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:59:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 10:59:35 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-4ht7LxMzZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bernardo Gonzalez Kriegel from comment #13)
> Hi Marcel,
> current ACQ framework does not have tag 942.
> Do you think we need to add it and it's subfields?
> 
> Patches applies cleanly, test pass.

Thx for testing, Bernardo.
No I do not think we should add it on this report per se. Surely, it could be
done on its own. But it is a just an example of how we can apply mandatories.
Another existing field could be used too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:49:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:49:39 +0000
Subject: [Koha-bugs] [Bug 24890] drag and trop tag when add or modify notice
In-Reply-To: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24890-70-ReUkeAetAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24890

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:50:48 +0000
Subject: [Koha-bugs] [Bug 24890] drag and trop tag when add or modify notice
In-Reply-To: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24890-70-u2IBdrCHYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24890

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Note drag and drop added by Bug 7882

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:50:56 +0000
Subject: [Koha-bugs] [Bug 11073] Reorder subfields using drag and drop in
 cataloguing
In-Reply-To: <bug-11073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11073-70-6icDcL79cd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11073

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 7882 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:50:56 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
 MARC editor
In-Reply-To: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-0NCOOaz60j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

--- Comment #67 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
*** Bug 11073 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:57:49 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-yv0u9cgXmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:57:52 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-jP8gY5tJMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100022|0                           |1
        is obsolete|                            |
 Attachment #100023|0                           |1
        is obsolete|                            |
 Attachment #100024|0                           |1
        is obsolete|                            |
 Attachment #100025|0                           |1
        is obsolete|                            |
 Attachment #100026|0                           |1
        is obsolete|                            |
 Attachment #100027|0                           |1
        is obsolete|                            |
 Attachment #100028|0                           |1
        is obsolete|                            |
 Attachment #100029|0                           |1
        is obsolete|                            |
 Attachment #101385|0                           |1
        is obsolete|                            |

--- Comment #51 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101419&action=edit
Bug 24476: Database updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:57:55 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-5N6vGBK6R0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #52 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101420&action=edit
Bug 24476: API Updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:57:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:57:58 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-8GV21rNyHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #53 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101421&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:02 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-jHwqilg4AK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #54 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101422&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:05 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-ATGwZ9i9FI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #55 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101423&action=edit
Bug 24476: Rename autorenewal to autorenew_checkouts

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:08 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-XMTwiI3P24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #56 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101424&action=edit
Bug 24476: Allow direct editing of autorenew_checkouts by patron

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:11 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-d9j64KbjTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #57 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101425&action=edit
Bug 24476: (QA follow-up) Standardize on 'auto renew(al)' and improve db update

There were several versions: auto renew, auto-renew, autorenew
I've decided to use auto renew (from automatic renewal) to keep
things a bit more consistent.

The DB update was missing AFTER and IGNORE for the sys pref.
Also fixed a tiny typo (tp > to)
Also changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:14 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-XkmrcTSct4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #58 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101426&action=edit
Bug 24476: DO NOT PUSH - Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:58:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:58:17 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-WEP36N2XuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #59 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101427&action=edit
Bug 24476: Add boolean for TINYINT

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 11:59:55 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-znGI40CAuM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #60 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #50)
> I am stuck on this one :( 
> 
> The schema update patch would not apply, so I skipped it.
> Tried running DBIC:

The patch after DBIC relies on that one, I rebased them - I left as separate
patch as reminder to RM

> Tried running the updatedatabase script (with and without my patch):

Above should fix that

> Can you please check and rabase? Also added a follo-up, please have a look.

Follow-up is good, tests pass so things appear to work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:00:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:00:06 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22890-70-BZjDWfeXci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
I created a new discussion on
https://framavox.org/d/UkADlcT6/add-a-chronological-changelog to gather
opinions. Feel free to add new polls, or new options to existing polls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:00:25 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-83ZqCC6pGx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Julian Maurice from comment #22)
> (In reply to Jonathan Druart from comment #21)
> > (In reply to Julian Maurice from comment #20)
> > > (In reply to David Cook from comment #19)
> > > > You can already retrieve that information using Perl though. What scenario
> > > > do you see someone using it maliciously?
> > > 
> > > Templates can be used in "Tools » Notices & Slips", they can be written by
> > > users.
> > 
> > I agree, that's definitely wrong.
> > 
> > Fridolin, you should pass the variable the dirty way, from C4::Auth.
> 
> Maybe we can find something better than the dirty way and the security-hole
> way, like a method ArePluginsEnabled in Koha::Template::Plugin::Koha ?

Exactly what I was going to propose.
I'm on a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:00:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:00:54 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-PywZDFFBFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Failing QA until the above is responded to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:09:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:09:13 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-ZtJe8NCmzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:09:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:09:16 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-1nLbdsYWuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101428&action=edit
Bug 21443: Mark new column as boolean in schema file

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:09:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:09:45 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-iU9VrvEGWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101429&action=edit
Bug 21443: Remove the dependency on finesCalendar

Considering that the the use of finesCalendar for this calculation is
already a binary choice, it makes sense to remove the use of
finesCalendar here. It is an uneccessary complication that could
introduce confusion. Allowing this new setting to directly control
the behavior makes it clear and obvious what is going on.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:10:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:10:30 +0000
Subject: [Koha-bugs] [Bug 24890] Drag and drop tag when add or modify record
In-Reply-To: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24890-70-yaABfCxiMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24890

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|drag and trop tag when add  |Drag and drop tag when add
                   |or modify notice            |or modify record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:11:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:11:52 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-Yk4onmjzcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101428|0                           |1
        is obsolete|                            |
 Attachment #101429|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101430&action=edit
Bug 21443: Mark new columns as boolean in schema file

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:12:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:12:02 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-i6wqHZF5Dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101431&action=edit
Bug 21443: Remove the dependency on finesCalendar

Considering that the the use of finesCalendar for this calculation is
already a binary choice, it makes sense to remove the use of
finesCalendar here. It is an uneccessary complication that could
introduce confusion. Allowing this new setting to directly control
the behavior makes it clear and obvious what is going on.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:12:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:12:42 +0000
Subject: [Koha-bugs] [Bug 24951] New: Payout modal confirm button should
 have an ID
Message-ID: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

            Bug ID: 24951
           Summary: Payout modal confirm button should have an ID
 Change sponsored?: Sponsored
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: andrew at bywatersolutions.com, katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    mark.gavillet at ptfs-europe.com,
                    martin.renvoize at ptfs-europe.com,
                    sally.healey at cheshiresharedservices.gov.uk,
                    testopia at bugs.koha-community.org, tomascohen at gmail.com
        Depends on: 24775, 23354
            Blocks: 13985

Sometimes people wish to override the payout confirmation button, for example
to open a cash register via JS.. as such it's helpful to have an ID for the
button.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775
[Bug 24775] Payment submit button on POS page should have an ID
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:12:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:12:42 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-wN7Gjf1bvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:12:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:12:42 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-E4LB7BX8J0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:12:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:12:42 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-TGD67LstRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:11 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-oNxaa04HKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24775, 23354                |24080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080
[Bug 24080] Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775
[Bug 24775] Payment submit button on POS page should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:11 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-h0oodjZy3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24951                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:11 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24080-70-eAuKfgiYFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:11 +0000
Subject: [Koha-bugs] [Bug 24775] Payment submit button on POS page should
 have an ID
In-Reply-To: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24775-70-WibFCpnIyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24951                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951
[Bug 24951] Payout modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:44 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-pQWLTZSwnm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Sponsored                   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:45 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-LxOyrq29ZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #156 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101432&action=edit
Bug 23463: Fix selenium tests (highlight a bug in date management)

There is something wrong, and a regression has been caught by those
tests:
If an invalid date is passed from the add item form, the app now
crashes.
Before:
 * if the date was completely invalid, the field was blanked
silently
 * DateTime::Format::MySQL was used to convert dates, and it's not
 strict at all. For instance, what happened in the selenium tests for
 dateaccessionned: %Y-%m-%d was prefilled by the framework plugin, then
 the biblionumber was added, we ended with something like (eg for today)
 2020-03-234242 (with biblionumber=4242). DateTime::Format::MySQL
 converts that to 2020-03-23

We must deal with invalid dates, but I do not think it is good to add it
back to Koha::Item->store, we will prefer to raise the error to the end
user, saying that something went wrong (and more specifically the
dates).

The (ugly) trick was in C4::Items::_mod_item_dates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:14:52 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-l9AfRAt2av@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:15:48 +0000
Subject: [Koha-bugs] [Bug 24952] New: Refund modal confirm button should
 have an ID
Message-ID: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

            Bug ID: 24952
           Summary: Refund modal confirm button should have an ID
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: andrew at bywatersolutions.com, katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    mark.gavillet at ptfs-europe.com,
                    martin.renvoize at ptfs-europe.com,
                    sally.healey at cheshiresharedservices.gov.uk,
                    testopia at bugs.koha-community.org, tomascohen at gmail.com
        Depends on: 23442
            Blocks: 13985

Sometimes people wish to override the refund confirmation button, for example,
to open a cash register via JS.. as such it's helpful to have an ID for the
button.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' process to accounts
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:15:48 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-0JIEZhcG92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952
[Bug 24952] Refund modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:15:48 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-Ypo3yOJTuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952
[Bug 24952] Refund modal confirm button should have an ID
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:15:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:15:51 +0000
Subject: [Koha-bugs] [Bug 24953] New: Minor corrections to hold ratios
 report sidebar
Message-ID: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

            Bug ID: 24953
           Summary: Minor corrections to hold ratios report sidebar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    nick at bywatersolutions.com,
                    testopia at bugs.koha-community.org
        Depends on: 24907

Addressing this comment from Bug 24907:

(In reply to Katrin Fischer from comment #4)

> Wondering if on a separate report we could reformat the checkboxes:
> [checkbox] Text
> 
> And maybe:
> Include instead of included?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907
[Bug 24907] Optionally exclude suspended holds from holds ratio report
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:15:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:15:51 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-tJPkK67DqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24953


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953
[Bug 24953] Minor corrections to hold ratios report sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:19:46 +0000
Subject: [Koha-bugs] [Bug 10269] Add a way to define a specific replyto
 email address for some notice
In-Reply-To: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10269-70-saKjkYrap6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|add a way to define a       |Add a way to define a
                   |specific replyto email      |specific replyto email
                   |address for some notice     |address for some notice
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:22:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:22:27 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-WYqJheHZvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
I will add the "Auto generate credit number" parameter, and the exception
(probably better to have an error rather than a silent overwrite).
Changing status to ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:24:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:24:31 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-CNDYVJXLYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101060|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:24:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:24:53 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-wP1uza894U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101061|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:27:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:27:13 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-gwvloIddNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:27:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:27:13 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-ZIeNvNn6MI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #99 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #97)
> I can pick something else than '_', but the problem will exist for any
> characters.

That's why I suggested appending the AV code to the entity name, instead of
prepending it to the AV value. Have you considered this ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:27:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:27:18 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-ryLTQRxiVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #26 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101433&action=edit
Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method

In order to remove UseKohaPlugins syspref, adds to Koha Template Toolkit
plugin a method ArePluginsEnabled().

Test plan:
1) Set syspref UseKohaPlugins enabled
2) Set config enable_plugins=1
3) Check you see "Tool plugins" in "Tools" home page and menu
4) Check you see "Manage plugins" in "Koha administration" home page
5) Check you see "Report plugins" in "Reports" home page and menu
6) Set config enable_plugins=0
7) Check you don't see in 3) 4) 5)
8) Run prove t/Koha_Template_Plugin_Koha.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:27:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:27:39 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-9TJcoii4z0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101434&action=edit
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already
multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use
of plugins.
>>

Test plan :
1) Install kitchen sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:29:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:29:17 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-AmS0HiON64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #28 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
TT plugin changed + Unit test added
Main patch rebased on master with conflic on _after_item_action_hooks move.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:33:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:33:33 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-bik65Opohg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #4)
> I think there is a problem here with this minimalistic approach:
> 
> - Go to the did you mean admin page
> - Make changes to sequence and check/uncheck something
> - Save
> - Check system preference / local use / INTRAdidyoumean, it will contain
> only ]
> - Access the did you mean page again - BOOM
> 
> malformed JSON string, neither tag, array, object, number, string or atom,
> at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171
> 
> I had a follow-up ready to remove the note form the intro text as well - it
> appears unnecessary.

Do we remove INTRAdidyoumean syspref and related code ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:35:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:35:44 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-V0iZ5uiQAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:35:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:35:47 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-63CUsPbR1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101435&action=edit
Bug 24953: Minor corrections to hold ratios report sidebar

This patch makes some minor corrections to the sidebar form on the hold
ratios report page:

 - Correct markup errors
 - Change the text of labels from "included" to "include"
 - Move checkboxes to the left of labels

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Go to Circulation -> Hold ratios
 - In the sidebar, confirm that the labels "Include ordered" and
   "Include suspended" appear to the right of their associated
   checkboxes.
 - Validate the source of the page. There should be no errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:36:19 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-O3VyxRfcsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101436&action=edit
Bug 24952: Add id to refund modals confirm buttons

This patch adds an ID to the refund confirmation modals for both
borrower account and point of sale register details pages.

Test plan:
1/ Apply patch
2/ Attempt to issue a refund to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button,
4/ Attempt to issue a refund via point of sale register details page
5/ Inspect the page and note the presence of an ID for the confirm
   button.
6/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:37:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:37:26 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-KhKWrpxwoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:37:34 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-H9adzQSvn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:42:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-3gE3TB4WHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #157 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Congratulations, Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:42:44 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-sn6MxYbJxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100376|0                           |1
        is obsolete|                            |

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101437&action=edit
Bug 24276: First change indent

No other changes than whitespace, guys.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:42:49 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-XI5yMC8CEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100377|0                           |1
        is obsolete|                            |

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101438&action=edit
Bug 24276: Add FillWithDefaultValues call in neworderempty

Apply mandatory defaults from the ACQ framework to records from external
source in Acquisition.

Test plan:
[1] Add 'BK' as mandatory default in ACQ framework for 942$c.
[2] Add order to basket via external source.
[3] Check 942$c on detail page of new record, MARC tab.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
First added 942 field and subfields to ACQ fw, then followed test plan.
wo/patch 942 is not added, w/patch it is.
Work as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:42:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:42:52 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-hC6D9BnvA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100378|0                           |1
        is obsolete|                            |

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101439&action=edit
Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues

Test plan:
Run t/db_dependent/Acquisition/FillWithDefaultValues.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:43:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:43:11 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-im9E96IGzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:47:14 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-Ptp8m9FrDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24951

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:47:14 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-UpukgGay84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24952

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:49:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:49:38 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-0f3BOXCXOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101440&action=edit
Bug 24951: Add id to payout modal confirm button

This patch adds an ID to the payout confirmation modal on the
borrower account details page.

Test plan:
1/ Apply patch
2/ Attempt to issue a payout to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button
4/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:49:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:49:47 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-VtGcTiRgQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:49:52 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-Sg0faIPnup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:49:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:49:58 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-FblkE1Asuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:50:27 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-Gwnz9DX9JU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
And would it be interesting to differentiate between no context (from that
server) and with context from a logged-in user?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:51:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:51:47 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-25D6hhc5rh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:51:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:51:50 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-rO1mbq3cO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100567|0                           |1
        is obsolete|                            |
 Attachment #100568|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101441&action=edit
Bug 23695: Set holding branch to transferring branch when manually initiating a
transfer

To test:
 1 - Go to Circulation->Transfer
 2 - Note your signed in branch
 3 - Find an item from your branch and create a transfer to branch B
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to brnach B
 7 - Confirm the item is held at your current branch and is being transferred
to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:51:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:51:53 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-qV95gppql1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101442&action=edit
Bug 23695: Alter transferbook to take a hash of params and specify from_branch

To test:
 1 - Go to Circulation->Transfer
 2 - Find an item from your branch and create a transfer to branch B
 3 - Note you can specify the origin and default is 'Item's holding library'
 4 - Confirm the item is marked as held at your current branch and is being
transferred to B
 5 - Find an item from a third branch, branch C
 6 - Transfer that item to branch B from branch D
 7 - Confirm the item is held at branch D and is being transferred to B
 8 - prove -v t/db_dependent/Circulation.t
 9 - prove -v t/db_dependent/Koha/Items.t
10 - prove -v t/db_dependent/RotatingCollections.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:51:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:51:56 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
 originating library when generating a manual transfer
In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23695-70-3dJGIn6eb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101443&action=edit
Bug 23695: (follow-up) Adjust for addition of transfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:55:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:55:29 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-mGhowmHhfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:55:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:55:32 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-zMgWkURr1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101436|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101444&action=edit
Bug 24952: Add id to refund modals confirm buttons

This patch adds an ID to the refund confirmation modals for both
borrower account and point of sale register details pages.

Test plan:
1/ Apply patch
2/ Attempt to issue a refund to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button,
4/ Attempt to issue a refund via point of sale register details page
5/ Inspect the page and note the presence of an ID for the confirm
   button.
6/ Signoff

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:58:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:58:48 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-e6R5uX52Wz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101445&action=edit
Bug 23403: Fix whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:59:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 12:59:32 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-AeiIGJRgc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
prove t/db_dependent/SIP/*
t/db_dependent/SIP/ILS.t .......... 2/10     # Looks like you planned 5 tests
but ran 2.
t/db_dependent/SIP/ILS.t .......... 10/10
#   Failed test 'cancel_hold'
#   at t/db_dependent/SIP/ILS.t line 124.
Cannot access 'borrowernumber' field of class 'C4::SIP::ILS::Patron' at
/kohadevbox/koha/C4/SIP/ILS/Transaction/Hold.pm line 81.
# Looks like your test exited with 255 just after 10.
t/db_dependent/SIP/ILS.t .......... Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 1/10 subtests
t/db_dependent/SIP/Message.t ...... 2/4
    #   Failed test 'Check screen msg'
    #   at t/db_dependent/SIP/Message.t line 507.
    #          got: 'Item not checked out'
    #     expected: 'Checkin failed'
    # Looks like you failed 1 test of 29.
t/db_dependent/SIP/Message.t ...... 3/4
#   Failed test 'Checkin V2'
#   at t/db_dependent/SIP/Message.t line 74.
# Looks like you failed 1 test of 4.
t/db_dependent/SIP/Message.t ...... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests
t/db_dependent/SIP/Patron.t ....... ok
t/db_dependent/SIP/SIPServer.t .... ok
t/db_dependent/SIP/Transaction.t .. 4/7 RECORD:69::100 at
/kohadevbox/koha/C4/SIP/ILS/Transaction/FeePayment.pm line 55.
t/db_dependent/SIP/Transaction.t .. 5/7     # Looks like you planned 7 tests
but ran 5.

#   Failed test 'cancel_hold'
#   at t/db_dependent/SIP/Transaction.t line 210.
Cannot access 'borrowernumber' field of class 'C4::SIP::ILS::Patron' at
/kohadevbox/koha/C4/SIP/ILS/Transaction/Hold.pm line 81.
# Looks like your test exited with 255 just after 6.
t/db_dependent/SIP/Transaction.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 2/7 subtests

Test Summary Report
-------------------
t/db_dependent/SIP/ILS.t        (Wstat: 65280 Tests: 10 Failed: 1)
  Failed test:  10
  Non-zero exit status: 255
t/db_dependent/SIP/Message.t    (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/db_dependent/SIP/Transaction.t (Wstat: 65280 Tests: 6 Failed: 1)
  Failed test:  6
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 7 tests but ran 6.
Files=5, Tests=26, 21 wallclock secs ( 0.04 usr  0.02 sys + 11.47 cusr  2.11
csys = 13.64 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:15:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:15:26 +0000
Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup
 list
In-Reply-To: <bug-14654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14654-70-bbgeSo12nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:24:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:24:54 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-tfEsPhVXmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:24:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:24:57 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-YAij95CrxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100712|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101446&action=edit
Bug 24872: Set languages prefererences after install

This patch set 'languages' and 'opaclanguages' system
preferences with the language used during install.

To test:
1. Apply the patch
2. Do a clean install in a language other than english
3. Verify that 'languages' and 'opaclanguages' system
preferences show the language code used during install,
besides english.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:26:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:26:28 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-DrMELqpIVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > I think there is a problem here with this minimalistic approach:
> > 
> > - Go to the did you mean admin page
> > - Make changes to sequence and check/uncheck something
> > - Save
> > - Check system preference / local use / INTRAdidyoumean, it will contain
> > only ]
> > - Access the did you mean page again - BOOM
> > 
> > malformed JSON string, neither tag, array, object, number, string or atom,
> > at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171
> > 
> > I had a follow-up ready to remove the note form the intro text as well - it
> > appears unnecessary.
> 
> Do we remove INTRAdidyoumean syspref and related code ?

I guess we could - it's not been implemented in years and I suppose you can
still easily add it back if you intend to develop it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:29:47 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-Ildwprm9R8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100385|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101447&action=edit
Bug 24828: Add ability to specify cash register in SIP config

This patch adds the ablity to specify a cash register id to link to
payments taken via SIP2 clients.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:32:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:32:46 +0000
Subject: [Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified
 time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-dKhWrk90n2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

--- Comment #19 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 101448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101448&action=edit
Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period

We changed the code to satisfy new methods:
we used Koha::Suggestions->search()->count instead of scalar search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:47:46 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-ecYeg2WHdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:47:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:47:48 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-foQ4Szgfyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:50:17 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-8Y6Y4HWeeg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 13:50:19 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-E89pdCew7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101447|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101449&action=edit
Bug 24828: Add ability to specify cash register in SIP config

This patch adds the ablity to specify a cash register id to link to
payments taken via SIP2 clients.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:02:12 +0000
Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of
 records and check 001 uniqueness on save to batch
In-Reply-To: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19266-70-61dv97HxMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |BLOCKED
           Assignee|nick at bywatersolutions.com   |carnold at dgiinc.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Dependencies blocked

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:18:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:18:55 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-971DjN2Bvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ohhh

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:24:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:24:17 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-ZYO8RDxEYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101450&action=edit
Bug 20307: Move av.category to loc.entity

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:24:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:24:45 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-pl40AUA9HQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #101 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #99)
> (In reply to Jonathan Druart from comment #97)
> > I can pick something else than '_', but the problem will exist for any
> > characters.
> 
> That's why I suggested appending the AV code to the entity name, instead of
> prepending it to the AV value. Have you considered this ?

I failed to make it work, see last patch. Maybe there is something obvious I
missed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:25:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:25:21 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-YToweQ9m3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101450|Bug 20307: Move av.category |[DO NOT APPLY/PUSH] Bug
        description|to loc.entity               |20307: Move av.category to
                   |                            |loc.entity

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:30:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:30:55 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-oBkQ1mvJYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:31:00 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-KEJCCQKu9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101444|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101451&action=edit
Bug 24952: Add id to refund modals confirm buttons

This patch adds an ID to the refund confirmation modals for both
borrower account and point of sale register details pages.

Test plan:
1/ Apply patch
2/ Attempt to issue a refund to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button,
4/ Attempt to issue a refund via point of sale register details page
5/ Inspect the page and note the presence of an ID for the confirm
   button.
6/ Signoff

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:36:43 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-sadpeVN5ZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96166|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101452&action=edit
Bug 24201: Attach desk to intranet session

When Desks are defined, a librarian can attach a desk to its session.

Test plan:

1. apply 13881 and create some desks
2. you should see “NO DESK SET” in the intranet header
3. go to circulation > Set desk
4. you should see your desk name in the header, whatever the page
5. you can also set desk with the header menu

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:51:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:51:03 +0000
Subject: [Koha-bugs] [Bug 24954] New: Bro
Message-ID: <bug-24954-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24954

            Bug ID: 24954
           Summary: Bro
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fikriazmi09 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101453&action=edit
Hacked by:./Tn.Dew4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:51:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:51:35 +0000
Subject: [Koha-bugs] [Bug 24954] SPAM
In-Reply-To: <bug-24954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24954-70-oKvxOzOV14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24954

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Bro                         |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:52:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:52:53 +0000
Subject: [Koha-bugs] [Bug 24955] New: Bro
Message-ID: <bug-24955-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24955

            Bug ID: 24955
           Summary: Bro
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fikriazmi09 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101454&action=edit
Hacked by:./Tn.Dew4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:53:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:53:16 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-4hQaQEBIUv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #102 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #98)
> Created attachment 101070 [details] [review]
> Bug 20307: Replace separator with #
> 
> To avoid colision we replace the separator with something that is
> supposed to be less used than underscore
> 
> The problematic case was explaing by Julian on comment 96:
> """
> The value stored in localization.code is a concatenation of the AV
> category code, a '_', and the AV code. Which means that if we have a
> category A with a value B_C, and a category A_B with a value C, they will
> share their translations.
> """

It sounds unlikely as our categories should be unique enough, aren't they?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:53:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:53:55 +0000
Subject: [Koha-bugs] [Bug 24955] SPAM
In-Reply-To: <bug-24955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24955-70-vbMPZI79lR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24955

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
            Summary|Bro                         |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:58:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:58:35 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-oDW07fE0Hx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #18 from Paul Thornton <paul.thornton at educampus.ie> ---
Hello Jonathan
I touched base with Simon and he says the best thing would be if PTFS can
re-send the link to the sandbox for this bug and he can retest. Can you
organise that please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:58:42 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-aomi8XqMAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #103 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #102)
> It sounds unlikely as our categories should be unique enough, aren't they?

But users can create their own categories.

I agree that it is unlikely, but it is still possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:59:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 14:59:13 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-wdcUWuGIjW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I agree ILSDI should set its own userenv as it is really not dependent on the
current cookie. This is a nasty side effect of our coding practices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:02:04 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-l7lgkLz6cB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:02:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:02:07 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-5nJmWL6csu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101435|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101455&action=edit
Bug 24953: Minor corrections to hold ratios report sidebar

This patch makes some minor corrections to the sidebar form on the hold
ratios report page:

 - Correct markup errors
 - Change the text of labels from "included" to "include"
 - Move checkboxes to the left of labels

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Go to Circulation -> Hold ratios
 - In the sidebar, confirm that the labels "Include ordered" and
   "Include suspended" appear to the right of their associated
   checkboxes.
 - Validate the source of the page. There should be no errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:03:11 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-FgZmIjwEBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101456&action=edit
Bug 23403: List borrowernumber in the ILS::Patron fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:03:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:03:51 +0000
Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is
 missing
In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23403-70-9fb9dWBghk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is still one test missing, I do not manage to fix it.

Could I get some help?

t/db_dependent/SIP/Message.t .. 1/4
    #   Failed test 'Check screen msg'
    #   at t/db_dependent/SIP/Message.t line 507.
    #          got: 'Item not checked out'
    #     expected: 'Checkin failed'
    # Looks like you failed 1 test of 29.
t/db_dependent/SIP/Message.t .. 3/4

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:04:47 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-f9MbKNFdSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Treating this as a follow-up for bug 24907 - thx Owen!


Btw... the filters on the funds page look a bit ill-formatted too ;)
http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:11:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:11:01 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-ASFmWEyKCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Julian Maurice from comment #17)
> I will add the "Auto generate credit number" parameter

In fact, it's not that simple. "system" credit types cannot be modified :/
Should I add the possibility to edit them but only allow this parameter to be
modifiable ? Or should I find another way (another syspref for example) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:19:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:19:48 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-C1uBIyHaD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:19:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:19:51 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-J2WZh0pkyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101371|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101457&action=edit
Bug 24837: Rename selectbranchprinter.pl to set-library.pl

This renames the selectbranchprinter.pl file to the more
fitting set-library.pl.

To test:
- Change the library with "Set library" from
  - The menu in the top navigation bar
  - The circulation start page
- Verify the help link on page leads to the correct
  section in the manual
- Read the code... and verify all occurences have been caught

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works ok, fixed tab char in circ/branchtransfers.pl

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:31 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-0K5tcMy1jF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:35 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-9UMjEHI6yO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100745|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101458&action=edit
Bug 21443: Update database

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:39 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-0WuMjRTauZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100746|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101459&action=edit
Bug 21443: Update Schema [DO NOT PUSH]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:44 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-Pta0Xuy5E5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100747|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101460&action=edit
Bug 21443: Add ability to exclude holidays when calculating rentals fees by
time period

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:48 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-lfMMWVfe51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100748|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101461&action=edit
Bug 21443: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:53 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-SkWfT45DAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101430|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101462&action=edit
Bug 21443: Mark new columns as boolean in schema file

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:22:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:22:56 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-j1oCOEUCdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101431|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101463&action=edit
Bug 21443: Remove the dependency on finesCalendar

Considering that the the use of finesCalendar for this calculation is
already a binary choice, it makes sense to remove the use of
finesCalendar here. It is an uneccessary complication that could
introduce confusion. Allowing this new setting to directly control
the behavior makes it clear and obvious what is going on.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:38 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-BM7dil5mje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101458|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101464&action=edit
Bug 21443: Update database

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:42 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-z325FjS3jg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101459|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101465&action=edit
Bug 21443: Update Schema [DO NOT PUSH]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:45 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-uBFrgu6iqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101460|0                           |1
        is obsolete|                            |

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101466&action=edit
Bug 21443: Add ability to exclude holidays when calculating rentals fees by
time period

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:48 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-JTFQVrM3K8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101461|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101467&action=edit
Bug 21443: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:52 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-PuGpRKK2f3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101462|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101468&action=edit
Bug 21443: Mark new columns as boolean in schema file

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:23:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:23:55 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-NMiCZNBWSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101463|0                           |1
        is obsolete|                            |

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101469&action=edit
Bug 21443: Remove the dependency on finesCalendar

Considering that the the use of finesCalendar for this calculation is
already a binary choice, it makes sense to remove the use of
finesCalendar here. It is an uneccessary complication that could
introduce confusion. Allowing this new setting to directly control
the behavior makes it clear and obvious what is going on.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:25:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:25:35 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-a119P3PJd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could the custom CSS be interfering?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:26:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:26:12 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-WEFwSkIQq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:37:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:37:57 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-K9mRMXtOc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101470&action=edit
Before (master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:38:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:38:20 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-SahVRlTlTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101471&action=edit
After (master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:43:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:43:51 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-k8ifUl1cjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> ---
Without patch:
If I set  IDreamBooksReadometer,  IDreamBooksResults,  IDreamBooksReviews to
ADD: all looks well.

If I set them to DON'T ADD: 
My printed results look bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 15:48:20 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-Vi5Mi0dvlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101472&action=edit
Bug 20443: Add missing use statement

This is a follow-up for commit 836e950d25148ca04ed0561c487772e3b0f7f8ee
    Bug 20443: Remove SearchIdMatchingAttribute

We removed the use of C4::Members::Attributes, that was using Text::CSV

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:21:16 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-hNiSxtQ29K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:21:19 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-vqBpeA835y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99949|0                           |1
        is obsolete|                            |
  Attachment #99950|0                           |1
        is obsolete|                            |
 Attachment #100951|0                           |1
        is obsolete|                            |

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101473&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

This patch also fixes a FIXME about using effective_itemtype to fetch item
rules

To test:
1 - Set one itemtype to allow no holds
2 - Set 'Holds per record' to 0 for another itemtype/patron combination
3 - Create or find 2 records, each with items only of the itemtypes above
3 - Attempt to place a hold for a patron on each record above
4 - The message will be 'Too many holds'
5 - Apply patch and repeat
6 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
7 - Try placing a multihold with either record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"
8 - prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:21:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:21:23 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-D0Dhn4ImXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101474&action=edit
Bug 16787: Add noReservesAllowed to club holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:21:27 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-t2kL2twrY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101475&action=edit
Bug 16787: DO NOT PUSH - Shcema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:24:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:24:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-XDiZQTAcq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #158 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101476&action=edit
Bug 23463: (follow-up 3) Fix timestamp default value

This is the only situation I found where:
 * t/db_dependent/Koha/Item.t is passing
 * t/db_dependent/Koha/Object.t is passing
 * MySQL 8 is happy (and not fail with "Column 'timestamp' cannot be null"),
which is certainly what I missed in the previous follow-up

I think we should remove the lines from the overloaded ->store method
(Item and Patron), but then we need Object.t to be adjusted.
I do not understand why we would need to set updated_on, maybe the test
is wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:24:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 16:24:26 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-kgx87Rbgd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:22:34 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-iGSY1qD1X1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:22:37 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-soD1gzEoYs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101063|0                           |1
        is obsolete|                            |

--- Comment #23 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101477&action=edit
Bug 24874: Printing is broken on opac-results.pl page (19.11.x)

to test in 19.11.x...

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:23:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:23:28 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-ztccvxeiV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #24 from Owen Leonard <oleonard at myacpl.org> ---
I'm adding my signoff because I can reproduce the problem in both 19.11.x and
master in both Firefox and Chrome (OSX), and the patch fixes it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:26:22 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-sEwCW8pW7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:26:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:26:25 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-AN1gFzqbFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101440|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101478&action=edit
Bug 24951: Add id to payout modal confirm button

This patch adds an ID to the payout confirmation modal on the
borrower account details page.

Test plan:
1/ Apply patch
2/ Attempt to issue a payout to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button
4/ Signoff

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 17:26:54 +0000
Subject: [Koha-bugs] [Bug 24738] Online registration
 confirmation/clarification
In-Reply-To: <bug-24738-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24738-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24738-70-a3IIw6twlC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:16:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:16:15 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-QIeXIdr2wO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:16:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:16:18 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-mivEiuSIOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101065|0                           |1
        is obsolete|                            |

--- Comment #42 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101479&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. prove t/db_dependent/Koha/Desks.t
5. you now have desks links in admin-home and admin-menu
6. click the link
7. add a desk
8. add another one
9. delete one
10. you should have a fair list of all current desks defined
11. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:17:53 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-6jVG2LSQKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101302|0                           |1
        is obsolete|                            |

--- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101480&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:09 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-3jHlKZ3FuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101480|0                           |1
        is obsolete|                            |

--- Comment #61 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101481&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:22 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-FPiGaugeQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101482&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:25 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-gPAnuGtyXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101483&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:28 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-RIfNpgv33x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101484&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:31 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-qGTBS53rcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101485&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david at davidnind.com>

Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:35 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-bIc7xsAcpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #66 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101486&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:39 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-GVBvMmb7uf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101487&action=edit
Bug 22844: DBIC Schema changes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:18:43 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-u7WkEvfS05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101488&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:24:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:24:09 +0000
Subject: [Koha-bugs] [Bug 24956] New: Add ability to define
 emergency/override circ rules
Message-ID: <bug-24956-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956

            Bug ID: 24956
           Summary: Add ability to define emergency/override circ rules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When there are library closings or adjustments due to unforeseen circumstances
it would be nice to have a way to 'override' current circ rules, without
needing to adjust individual circ rules and to preserve regular behaviour while
allowing for large scale changes

Idea would be like:
1 - Add new checkbox for  'Activate Emergency rules"
2 - Checking this box would make visible a new row in the circ table (colored
red? bold?)
3 - The rules in the row would have _emergency appended to name (or be upper
case, something to mark them as different
4 - These rules (if set and active) would override all other branch rules
5 - Code would be adjusted to pick these rules first if the branch is set to
'emergency' mode

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:27:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:27:50 +0000
Subject: [Koha-bugs] [Bug 24957] New: OpenLibrarySearch doesnt return result
 correctly on OPAC
Message-ID: <bug-24957-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957

            Bug ID: 24957
           Summary: OpenLibrarySearch doesnt return result correctly on
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If you turn on OpenLibrarySearch results are often not returned and only the
text "Open Library:" displays.

Firstly, if there is nothing to return we should display nothing.

Secondly, it does look like any of these records do return data but the API has
changed, I think. Koha checks to see if "items: []" has length and returns
false if this is true.

But I am finding many records where the data seems to be present:
(https://openlibrary.org/api/volumes/brief/json/id:0;isbn:067002662X;lccn:__2012035454)
but items contains nothing. 

I don't know anything about the OpenLibrary API, but perhaps it has changed.

TO RECREATE:
1. turn on OpenLibrarySearch
2. go to the opac results page and opac details page and see many records that
just display "Open Library: " and nothing else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:36:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:36:08 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-8juK5WyoAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:58:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:58:17 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-VQZyhnpUwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:58:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:58:20 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-GymqefBoPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101338|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101489&action=edit
Bug 24854: Remove IDreamBooks integration

The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.

To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
  as expected
- Run t/db_dependent/UsageStats.t

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Prefs gone. Fixed missing 'r' in atomic update message.
Test pass, no errors.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 19:58:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 18:58:27 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-oVNDUPcijV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 20:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 19:03:17 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-uHsjk9qjRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 20:03:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 19:03:20 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-R7l6NAbtcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101354|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101490&action=edit
Bug 24876: Fix capitalization on patron search for holds

When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons...  instead.
Also changes club id to club ID.

To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 20:23:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 19:23:09 +0000
Subject: [Koha-bugs] [Bug 24958] New: Remember last selected tab in SQL
 reports
Message-ID: <bug-24958-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958

            Bug ID: 24958
           Summary: Remember last selected tab in SQL reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I think it would be useful for the saved reports page to remember which tab the
user last suggested. I propose to set a cookie to store the information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 20:24:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 19:24:46 +0000
Subject: [Koha-bugs] [Bug 24957] OpenLibrarySearch doesnt return result
 correctly on OPAC
In-Reply-To: <bug-24957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24957-70-Niw6ojsIIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

--- Comment #1 from Heather <heather_hernandez at nps.gov> ---
This search in our 19.05 catalog shows several items with the text "Open
Library:       " where OpenLibrary actually has the item:
https://keys.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=cachalot

E.g., also, these records:
https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=13955&query_desc=cachalot

https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=13954&query_desc=fiction

>From those records in our catalog you can select "More searches," and the "Open
Library..." search, you are taken to the Open Library where there are copies to
borrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 20:45:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 19:45:19 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
 not update last seen date for check-ins
In-Reply-To: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15751-70-y4GoI7He6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #6 from Magnus Enger <magnus at libriotech.no> ---
Looking at signing off this. 

Tempted to set it to "in discussion" because of comment 5, but I think Martin
sort of answered it in comment 3?

Then I see there are no tests for ProcessOfflineReturn, and not for
ProcessOfflineIssue or ProcessOfflinePayment either. But asking for that might
be a bit too much on this bug?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:01:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:01:22 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-zc0jstx2xj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:01:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:01:25 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-ysYjuc9iFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101491&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:01:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:01:28 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-SEfd0AGAzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101492&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:04:53 +0000
Subject: [Koha-bugs] [Bug 24959] New: Fix id/label pairs in saved reports
 table
Message-ID: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

            Bug ID: 24959
           Summary: Fix id/label pairs in saved reports table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24886

In the table of saved reports the number in the 'ID' column is wrapped in a
<label> tag, but clicking it doesn't check the corresponding checkbox because
the "for" attribute doesn't match the ID of the checkbox.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886
[Bug 24886] Reindent reports template
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:04:53 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-d2is50OrZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24959


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959
[Bug 24959] Fix id/label pairs in saved reports table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:06:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:06:46 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-jiBevnmMcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101491|0                           |1
        is obsolete|                            |
 Attachment #101492|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101493&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:06:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:06:49 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-PFxbIUkcQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101494&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:15:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:15:21 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-XokcCKnFvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:15:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:15:24 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-AdCPUzt9sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101495&action=edit
Bug 24959: Fix id/label pairs in saved reports table

This patch adds a unique id attribute to each checkbox in the table of
saved reports. Also updated is the corresponding <label>'s "for"
attribute so that clicking the report id will toggle the checkbox.

To reproduce, go to Reports -> Use saved and click a number in the ID
column. Nothing happens.

After applying the patch clicking the number should check or uncheck the
corresponding checkbox.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 20:30:04 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-YuqzPyfdoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Martin,
t/DateUtils.t fails always. 
An special setup is needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:00:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:00:48 +0000
Subject: [Koha-bugs] [Bug 24425] Remove utf8 as an export option
In-Reply-To: <bug-24425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24425-70-4d8iyZCaAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:15:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:15:42 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-oc74ZjND4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:17:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:17:16 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-tgUJnMNvw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101496&action=edit
Bug 24874: Printing is broken on opac-results.pl page

to test:

- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)

- apply patch

- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)

it seems this issue was introduced by bug 5287

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:37:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:37:19 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-ILXP0g61XD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101493|0                           |1
        is obsolete|                            |
 Attachment #101494|0                           |1
        is obsolete|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101497&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:38:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:38:40 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-r9zNXWdd0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
 Attachment #101497|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:38:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:38:54 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-mBdX96UJeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101493|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:39:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:39:05 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-LnZIInU5h1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101494|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:42:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:42:21 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-KJQClgWN6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101493|0                           |1
        is obsolete|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101498&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:52:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 22:52:04 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-15GrYzudHV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 00:43:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2020 23:43:05 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-2SpR6YrQw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #23 from Joy Nelson <joy at bywatersolutions.com> ---
Pushing to 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:55:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 00:55:33 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-NR4PbwyHjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 101499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101499&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what fields in 'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship')) select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* None of the fields in 'Alternate contact' are pre-filled
from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

7. Observe this syspref is empty

8. Repeat step 1 and observe none of the fields in 'Main address'
, 'Contact' or 'Alternate address' are prefilled from guarantor

9. Add the following content into PrefillGuaranteeField syspref and save:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

10. Repeat step 1 and observe all fields in 'Main address',
'Alternate contact', and (except 'Guarantor surname', 'Guarantor
first name', and 'relationship') in 'Contact' are pre-filled from
guarantor

11. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved as have the values you haven't altered

12. Amend PrefillGuaranteeField syspref to be:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added a invalid column field 'drfregfre')

13. Repeat step 1 and observe no internal server errors and all fields
listed in step 10 are still pre-filled

14. Amend PrefillGuarantee field syspref to be:
phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added contactfirstname which is what the 'Guarantor first
 name' field in 'Contact' section of member entry form is)

15. Repeat step 1 and observe all fields defined in step 10 are filled
and 'Guarantor first name' is not filled even though it was listed in
PrefillGuarantorField because contactfirstname (along with
contactsurname and relationship are meant for non Koha patrons and so
should not pre-fill from a Koha patron)

16. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:57:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 00:57:31 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-9pAiDBfJ6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
  Change sponsored?|---                         |Sponsored
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23808

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi all, 

Patch finished. Please test when you are able to and let me know what you think
:)

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:57:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 00:57:31 +0000
Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate
 Guarantor Information
In-Reply-To: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23808-70-Th9TLpydo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22534

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 04:35:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 03:35:21 +0000
Subject: [Koha-bugs] [Bug 24960] New: 8080
Message-ID: <bug-24960-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24960

            Bug ID: 24960
           Summary: 8080
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: e77699786 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 101500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101500&action=edit
Join

Join

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 04:38:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 03:38:10 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-72zpu2IN6q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101499|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 04:38:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 03:38:35 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-gVqpAK02hk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 101501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101501&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what fields in 'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship')) select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* None of the fields in 'Alternate contact' are pre-filled
from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

7. Observe this syspref containing the following:
phone|email|streetnumber|address|city|state|zipcode|country

8. Repeat step 1 and observe the following fields are prefilled from guarantor:
streetnumber
address
city
state
zipcode/postal code
country
Primary phone
Primary email

9. Add the following content into PrefillGuaranteeField syspref and save:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

10. Repeat step 1 and observe all fields in 'Main address',
'Alternate contact', and (except 'Guarantor surname', 'Guarantor
first name', and 'relationship') in 'Contact' are pre-filled from
guarantor

11. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved as have the values you haven't altered

12. Amend PrefillGuaranteeField syspref to be:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added a invalid column field 'drfregfre')

13. Repeat step 1 and observe no internal server errors and all fields
listed in step 10 are still pre-filled

14. Amend PrefillGuarantee field syspref to be:
phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added contactfirstname which is what the 'Guarantor first
 name' field in 'Contact' section of member entry form is)

15. Repeat step 1 and observe all fields defined in step 10 are filled
and 'Guarantor first name' is not filled even though it was listed in
PrefillGuarantorField because contactfirstname (along with
contactsurname and relationship are meant for non Koha patrons and so
should not pre-fill from a Koha patron)

16. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 04:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 03:40:13 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-DcyEqzCa3F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Sorry I had missed in my test plan that the new PrefillGuaranteeField syspref
has the default value of
phone|email|streetnumber|address|city|state|zipcode|country

Which was suggested as defaults in the description of this bug report. 

All ready to test :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 06:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 05:01:59 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-Na6AXUIoTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 06:02:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 05:02:01 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-YgSLTFRhQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99090|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 06:02:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 05:02:20 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-f02z53zLvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101502&action=edit
Bug 24672: (bug 24430 follow-up) Do not get active orders on deleted biblio
record

On bug 24430 we replaced the call to CountBiblioInOrders with
Koha::Biblio->active_orders
In case the bibliographic record is deleted, the count must be set to 0.

This prevent the app to crash with:
Can't call method "active_orders" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 244

Test plan:
Create 2+ orders
Receive one, delete it, delete the bibliographic record
Receive the order one
=> Without this patch, on the parcel page you should get the error
=> With this patch applied you must be allowed to finish the receive

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 06:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 05:03:11 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-bZr0aze1ET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I was about to submit the same patch and found you filed it, Katrin. Thanks for
the patch Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 07:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 06:55:48 +0000
Subject: [Koha-bugs] [Bug 24960] SPAM
In-Reply-To: <bug-24960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24960-70-I7xOzN55ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|8080                        |SPAM
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:39:02 +0000
Subject: [Koha-bugs] [Bug 24961] New: dwdjwlkdjw
Message-ID: <bug-24961-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24961

            Bug ID: 24961
           Summary: dwdjwlkdjw
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Bugzilla
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: zfaissal.ell at xn--fiq06l2rdsvs.site

Created attachment 101503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101503&action=edit
dkhdkhwkd

dwdwdw

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:39:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:39:28 +0000
Subject: [Koha-bugs] [Bug 24961] SPAM
In-Reply-To: <bug-24961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24961-70-a83FuAx1Hi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24961

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
            Summary|dwdjwlkdjw                  |SPAM
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:41:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:41:49 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-Gg83LnaSEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:41:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:41:52 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-WMX7Ynq9FU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101478|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101504&action=edit
Bug 24951: Add id to payout modal confirm button

This patch adds an ID to the payout confirmation modal on the
borrower account details page.

Test plan:
1/ Apply patch
2/ Attempt to issue a payout to a patron
3/ Inspect the page and note the presence of an ID for the confirm
   button
4/ Signoff

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:47:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:47:36 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-QMoI9Cbt4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:56:52 +0000
Subject: [Koha-bugs] [Bug 24962] New: With a duplicate message,
 the floating toolbar buttons are no longer visible
Message-ID: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

            Bug ID: 24962
           Summary: With a duplicate message, the floating toolbar buttons
                    are no longer visible
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When you create a new patron with the same information than an existing patron,
you will get a duplicate message (the name matching will be usually enough). If
the duplicate message appears, the floating toolbar gets pushed further to the
top and the buttons cannot be clicked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:57:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 07:57:10 +0000
Subject: [Koha-bugs] [Bug 24962] With a duplicate message,
 the floating toolbar buttons are no longer visible
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-wZC0BCN7PL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:00:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:00:58 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-B5LHRnGHA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
> Easy to follow test plan, all works, but on point 5. I found one 'clear'
> but no 'new' control link, it's my only comment.
> No errors.

The 'new' button will be visible for repeatable attributes. Thanks to the note
I tested this and found that when you click on 'new' for a second time to add a
third field you are thrown to the top of the screen.

It depends on which 'new' link you use.

Owen, can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:03:46 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-KyfBo3qmXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:20:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:20:42 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-MqLoLCDULf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+If the parameter only_mandatory => 1 is passed via $params, only the mandatory
+defaults are being applied to the record.

For the cataloguing editor it does not matter if the field is mandatory or not.
As soon as you set a default, the value will appear in the record. So we are
handling things differently here - but we also don't open the record for
editing, so this makes sense to me.

I have another issue tho: We apply the default from the ACQ framework, while we
can specifically choose a framework to import the record in on the Z39.50/SRU
form - this is not caused by this bug, but doesn't make sense to me. Especially
for 942$c it would make a lot of sense to me to set different default for
different frameworks and use them. What do you think, Marcel?

Still passing as this is pre-bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:21:14 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-cm7sqZIEPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:21:18 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-3NY9MgMP3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101437|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101505&action=edit
Bug 24276: First change indent

No other changes than whitespace, guys.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:21:21 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-6gl5HgLanA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101438|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101506&action=edit
Bug 24276: Add FillWithDefaultValues call in neworderempty

Apply mandatory defaults from the ACQ framework to records from external
source in Acquisition.

Test plan:
[1] Add 'BK' as mandatory default in ACQ framework for 942$c.
[2] Add order to basket via external source.
[3] Check 942$c on detail page of new record, MARC tab.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
First added 942 field and subfields to ACQ fw, then followed test plan.
wo/patch 942 is not added, w/patch it is.
Work as described.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:21:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:21:25 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-e0kYRynATQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101439|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101507&action=edit
Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues

Test plan:
Run t/db_dependent/Acquisition/FillWithDefaultValues.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:42:57 +0000
Subject: [Koha-bugs] [Bug 24962] With a duplicate message,
 the floating toolbar buttons are no longer visible
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-DW5kSrrfgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:43:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:43:00 +0000
Subject: [Koha-bugs] [Bug 24962] With a duplicate message,
 the floating toolbar buttons are no longer visible
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-CclcXLBPOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101508&action=edit
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:43:08 +0000
Subject: [Koha-bugs] [Bug 24962] With a duplicate message,
 the floating toolbar buttons are no longer visible
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-NVI3X22WNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:43:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:43:54 +0000
Subject: [Koha-bugs] [Bug 24962] With a duplicate message,
 the floating toolbar buttons are no longer visible
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-I2HEAytGYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You caught me - I was missing the point :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:45:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:45:54 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-6iXzepJK20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|With a duplicate message,   |Don't show floating toolbar
                   |the floating toolbar        |when duplicate patron
                   |buttons are no longer       |record was detected
                   |visible                     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:50:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:50:38 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-Uv7lD60HV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98152|0                           |1
        is obsolete|                            |

--- Comment #3 from didier <didier.gautheron at biblibre.com> ---
Created attachment 101509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101509&action=edit
Attachment to Bug 24541 - Database cleanups, purge messages

Bug 24541: Purge old messages

misc/cronjobs/cleanup_database.pl provides some database cleanup.

This patch adds cleanup for messages table.

Test plan :
- Count messages : select count(*),date(message_date) from  messages group by
date(message_date);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365
- Recount messages

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:51:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 08:51:48 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-PrvkBwnxV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:05:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:05:52 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-OuKVwvMpSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #205 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101510&action=edit
Screenshot of option placement in OPAC

I think the placement of the new option in the OPAC is not ideal, it appears in
a very prominent spot, even atop of our warnings and other messages. I'd
suggest to move it lower, even below the checkouts table maybe, but below the
warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:10:15 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-q0p7mFma8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101510|0                           |1
        is obsolete|                            |

--- Comment #206 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 101510
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101510
Screenshot of option placement in OPAC

Wrong bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:11:44 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-bnKLYIQX0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101511&action=edit
Auto-renew setting in the OPAC

I think the placement of the new option in the OPAC is not ideal, it appears in
a very prominent spot, even atop of our warnings and other messages. I'd
suggest to move it lower, even below the checkouts table maybe, but below the
warnings.

It will also appear for all patron categories independent of if they are set up
to have auto-renewals or not. That's out of the scope of this bug - adding for
documentation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:16:44 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-wsYFEsFGW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Small patch                 |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:16:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:16:48 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-tyaOcLc2cu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101419|0                           |1
        is obsolete|                            |

--- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101512&action=edit
Bug 24476: Database updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:16:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:16:52 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-MMF66iBCIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101420|0                           |1
        is obsolete|                            |

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101513&action=edit
Bug 24476: API Updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:16:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:16:56 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-pBi4zz1rp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101421|0                           |1
        is obsolete|                            |

--- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101514&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:01 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-bld600QI0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101422|0                           |1
        is obsolete|                            |

--- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101515&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

Signed-off-by: Andrew <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:05 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-8DjNIznHki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101423|0                           |1
        is obsolete|                            |

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101516&action=edit
Bug 24476: Rename autorenewal to autorenew_checkouts

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:10 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-XmAn2qPZX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101424|0                           |1
        is obsolete|                            |

--- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101517&action=edit
Bug 24476: Allow direct editing of autorenew_checkouts by patron

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:14 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-LiXefoAKfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101425|0                           |1
        is obsolete|                            |

--- Comment #68 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101518&action=edit
Bug 24476: (QA follow-up) Standardize on 'auto renew(al)' and improve db update

There were several versions: auto renew, auto-renew, autorenew
I've decided to use auto renew (from automatic renewal) to keep
things a bit more consistent.

The DB update was missing AFTER and IGNORE for the sys pref.
Also fixed a tiny typo (tp > to)
Also changed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:18 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-KgvGMjPnYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101426|0                           |1
        is obsolete|                            |

--- Comment #69 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101519&action=edit
Bug 24476: DO NOT PUSH - Schema changes

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:23 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-ozV6ClTgjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101427|0                           |1
        is obsolete|                            |

--- Comment #70 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101520&action=edit
Bug 24476: Add boolean for TINYINT

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:17:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:17:27 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-5lwkELbAo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #71 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101521&action=edit
Bug 24476: (QA follow-up) Move new option below warnings and messages in OPAC
account

This makes it so the new option appears right above the table of checkouts etc.
but below any warnings, messages or dialogs.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:18:25 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-qxN4CRINNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #72 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #61)
> Created attachment 101511 [details]
> Auto-renew setting in the OPAC
> 
> I think the placement of the new option in the OPAC is not ideal, it appears
> in a very prominent spot, even atop of our warnings and other messages. I'd
> suggest to move it lower, even below the checkouts table maybe, but below
> the warnings.
> 
> It will also appear for all patron categories independent of if they are set
> up to have auto-renewals or not. That's out of the scope of this bug -
> adding for documentation.

Added a follow up to move it lower (right above the table still) - RM/Nick,
please check!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:19:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:19:29 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-J5pd8vyNIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow patrons to opt-out of |Allow patrons to opt-out of
                   |Auto-renewal                |auto-renewal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:21:18 +0000
Subject: [Koha-bugs] [Bug 24963] New: Terminology: auto renewal,
 auto-renewal or autorenewal?
Message-ID: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963

            Bug ID: 24963
           Summary: Terminology: auto renewal, auto-renewal or
                    autorenewal?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

I've encountered all three forms, plus automatic renewal in Koha and wonder, if
we can pick one to standardize on? Which is the 'most correct' spelling?

- auto renewal
- auto-renewal
- autorenewal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:22:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:22:06 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-t1MdcXgDIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:22:09 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-gj3CiGYHVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101446|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101522&action=edit
Bug 24872: Set languages prefererences after install

This patch set 'languages' and 'opaclanguages' system
preferences with the language used during install.

To test:
1. Apply the patch
2. Do a clean install in a language other than english
3. Verify that 'languages' and 'opaclanguages' system
preferences show the language code used during install,
besides english.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Note: We could even move it first in the list (those prefs are now ordered)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:24:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:24:11 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-pJDP1JHF9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:28:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:28:35 +0000
Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name
 in the database
In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24172-70-Qtu9qRRZPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Waiting for an answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:29:57 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-yHtsosssAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:29:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:29:59 +0000
Subject: [Koha-bugs] [Bug 21708] Editing a record moves field 999 to first
 in the marcxml
In-Reply-To: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21708-70-OV22835Z8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:01 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-z4rqaQ88Mc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:03 +0000
Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error
 with item deletion
In-Reply-To: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24324-70-Jf1k4KdXty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:05 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-OcQcvmWWNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:07 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-Gt4RdQ84wF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:08 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-hF6jae59eS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:10 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-uDrWSRHL7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:12 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-ewKmGbEVdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:14 +0000
Subject: [Koha-bugs] [Bug 24672] Error on receiving orders when there is an
 order with a deleted record
In-Reply-To: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24672-70-R1SMDy3Wt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:16 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-74uFRv0lsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:18 +0000
Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration
In-Reply-To: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24854-70-atv0vsOrDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:20 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-0DXsvu6rXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:22 +0000
Subject: [Koha-bugs] [Bug 24872] Set languages system preferences after web
 install
In-Reply-To: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24872-70-TyaJbHXeLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:24 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-CifxgJVaD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:25 +0000
Subject: [Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
In-Reply-To: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24874-70-slFGvTmw8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:27 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-mKBodkyrGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:29 +0000
Subject: [Koha-bugs] [Bug 24876] Fix capitalization on patron search for
 holds
In-Reply-To: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24876-70-AwT2OIXtlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:31 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-Z700D0qkU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:32 +0000
Subject: [Koha-bugs] [Bug 24902] Elasticsearch - different limits are joined
 with OR instead of AND
In-Reply-To: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24902-70-8UOM6Yh0Xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24902

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:34 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-HnRlrl8oB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:30:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:30:36 +0000
Subject: [Koha-bugs] [Bug 24918] Wrong attribute mappings in
 Koha::Acquisition::Basket
In-Reply-To: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24918-70-KZcxMUwGJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:38:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:38:52 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-33lrrCQ1Df@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, do we have precedents for adding stuffs REST API side only?
Here you are adding permission checks in Koha/REST/V1, not in the regular Koha
object class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:40:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:40:26 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-nr34Zx0AtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
On another note I think the error messages are not translatable (but I did not
test, that may be wrong).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:43:15 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-dfFSnYVgFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It seems that we need it for 19.11 as well

19.11_D9 (79)

koha_1       | #   Failed test 'Remote import does not fail on read_net'
koha_1       | #   at t/db_dependent/Koha/XSLT/Security.t line 124.
koha_1       | # found warning: XSLT_Handler: I/O warning : failed to load HTTP
resource
koha_1       | # expected to find warning: (?^u:I/O warning : failed to load
external entity)
koha_1       | # Looks like you failed 1 test of 7.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:51:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:51:03 +0000
Subject: [Koha-bugs] [Bug 24591] Add developer script to preview a letter
In-Reply-To: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24591-70-YR3FHQ1yTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Julian, please add usage (Pod::Usage) and perltidy the script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:52:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:52:58 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-svK7fiuA9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:53:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 09:53:01 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-pJgnMRXwWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100910|0                           |1
        is obsolete|                            |
 Attachment #101351|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101523&action=edit
Bug 24875: Remove extra punctuation from tools start page

The patron clubs note was ending with .., but patch also removed
some single . to be consistent with the majority of entries on the
tools page.

To test:
- Check the tools start page for ending . in the notes
- Apply patch
- Verify the punctuation is now consistent

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 24875: (follow-up) Remove ending . from Comments

Removes another extra ending . from the Comments section
of the tools start page.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Patches squashed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:06:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:06:43 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-wvY73xLmPz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:06:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:06:46 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-BPNkNmyRFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101323|0                           |1
        is obsolete|                            |
 Attachment #101324|0                           |1
        is obsolete|                            |
 Attachment #101325|0                           |1
        is obsolete|                            |
 Attachment #101326|0                           |1
        is obsolete|                            |
 Attachment #101327|0                           |1
        is obsolete|                            |
 Attachment #101328|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101524&action=edit
Bug 21503: Tests for the existing behavior

This patch introduces 7 tests for the current behaviour for the
AuthorisedValues template plugin.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t
=> SUCCESS: Tests pass, all green!

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:06:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:06:50 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-9TUQZzdlU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101525&action=edit
Bug 21503: Fix AV to fail to other values

To Test (Test both detail.pl and opac-detail.pl for functionality):
    1) Apply patch (restart_all)
    2) Look up an item that has a shelving location with a description
        defined (opac description too).
    3) Remove opac description from shelving location.  Refresh
        opac-detail.pl and note that description fails back to the
        regular description.  Refresh detail.pl and note no change.
    4) Remove regular description from shelving location.  Refresh
        opac-detail.pl and detail.pl.  Note that both default to the
        shelving location code.
    5) Remove the shelving location from the LOC table all together.
        Refresh opac-detail.pl and detail.pl.  Note that both default to
        the requested shelving location code.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:06:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:06:54 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-cBrtEpmsDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101526&action=edit
Bug 21503: Tests cleanup and highlight a missing case

This patch does the following changes:
- Use build_object to create the MSS
- Store the generate AVs. That was not the case before and so we were
not testing the right things
- Split the tests into 2 parts: staff and OPAC, for readability
- Update the tests' descriptions
- Highlight a problem: If descriptions are missing for both OPAC and
staff, undef is returned. Is that what we expect? It seems that it is
not what were expecting the tests.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:06:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:06:58 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-TcjmmX0d1i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101527&action=edit
Bug 21503: Tests clarification for debugging

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:07:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:07:00 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-KaSoyOQsSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works for me, but I have some big question marks about the currency
calculation on receive:

If you have set 'invoice prices' to another currency than standard in the
vendor, this is not visible anywhere in the receive form. And it doesn't appear
to be taken into account?

I set 'invoice price' to USD and the rate to 3. Then entered 10 on receive and
expected it to be converted to 30, but it didn't happen :(

Where is this setting used and how will it possibly affect this change here?

My impression was that you will enter the price in the currency set in the
vendor, like you do for the ordering price and it will recalculate, but that
doesn't seem to happen.

I'd like this to be cleared up, before we move on with this to make sure we
don't step on toes/workflows.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:07:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:07:02 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-W8XvW9nxaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101528&action=edit
Bug 21503: Changed logic for checking values

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Bug 21503: Simplify If Else logic

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:07:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:07:07 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-tzfnaG2iys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101529&action=edit
Bug 21503: Restore existing ternary operator logic

This syntax is much more readable IMO. Precendent patch also missed the
case where the parameter was undef.
I think we are good now.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:07:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:07:32 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-HyWzNjjmAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101508|0                           |1
        is obsolete|                            |

--- Comment #3 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101530&action=edit
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:11:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:11:17 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-8Y5dWynxka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:13:25 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-CHoegnqvzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:13:28 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-ru1fiLKhIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101530|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101531&action=edit
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:20:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:20:08 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-eMqzQEYZl7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:20:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:20:12 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-fvHrLb3aCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101023|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101532&action=edit
Bug 24877: Add link from vendor to linked subscriptions

Koha shows the number of subscriptions linked to a vendor,
but there is no way to look them up. This adds a link to the
subscription search with the vendor name, so there is an easy way
to find the subscriptions.

To test:
- Be superlibrarian or have serials permission
- Make sure you have one or more subscriptions linked to vendors
- Go to the vendor's detail page in acquisitions
- Verify the number of subscriptions is now a link
- Verify the search results are correct when clicking on it
- Remove permissions (no serials, not superlibrarian)
- Verify now the number shows, but is not linked

Signed-off-by: Nazlı Çetin <nazli at devinim.com.tr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:21:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:21:41 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-LyLtK2l1u3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tested on 18.11 as well - not sure what the invoice price setting is used for
still :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:25:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:25:24 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-RIb00LAKV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101527|0                           |1
        is obsolete|                            |
 Attachment #101528|0                           |1
        is obsolete|                            |
 Attachment #101529|0                           |1
        is obsolete|                            |

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101533&action=edit
Bug 21503: Tests clarification for debugging

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:25:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:25:28 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-FCQPAzf1M6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101534&action=edit
Bug 21503: Changed logic for checking values

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Bug 21503: Simplify If Else logic

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:25:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:25:32 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-n3TrcEGCub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101535&action=edit
Bug 21503: Restore existing ternary operator logic

This syntax is much more readable IMO. Precendent patch also missed the
case where the parameter was undef.
I think we are good now.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:27:40 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-XK49O8smgk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #4)
> Created attachment 101531 [details] [review]
> Bug 24962: Do not display the toolbar when editing a patron and dup is found
> 
> Whe a duplicate patron is found, the toolbar to save is display without
> the button.
> We must hide it completely, user has to use the 2 buttons from the dup
> message "Editing existing" or "Save as new".
> 
> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
> 
> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Thx for the quick test Sally!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:39:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:39:57 +0000
Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password
 is not safe
In-Reply-To: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23011-70-Nau8IwNwgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Waiting for an answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:38 +0000
Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with
 delete_patrons.pl
In-Reply-To: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18414-70-gcNVCmgnFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:40 +0000
Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with
 delete_patrons.pl
In-Reply-To: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18414-70-9zALJmbq2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:41 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-jPNSWHC66E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:43 +0000
Subject: [Koha-bugs] [Bug 24052] Koha::XSLT housekeeping for bug 23290
 (follow-up)
In-Reply-To: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24052-70-EaMmoeRizJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:45 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-lLInUWAQvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:47 +0000
Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of
 updatedatabase
In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24131-70-nsSaiOHaWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:49 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-AlLgWcOcuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:42:51 +0000
Subject: [Koha-bugs] [Bug 24696] We should output completion times in the
 updatedatabase output.
In-Reply-To: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24696-70-moCG1nEJBe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:44:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:44:03 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-hRZ2deSf5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:44:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:44:07 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-UzxjTNQHn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100278|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101536&action=edit
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup

This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup
class.

To test:
1. Compare the mapping with the one on the RFC
=> SUCCESS: They match
2. Sigh off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: remove extra lines between methods koha_object[s]_class.
That's how they are in other modules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:46:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:46:12 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-H3WcTuZTPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101536|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101537&action=edit
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup

This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup
class.

To test:
1. Compare the mapping with the one on the RFC
=> SUCCESS: They match
2. Sigh off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: remove extra lines between methods koha_object[s]_class.
That's how they are in other modules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:52:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:52:04 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-y8w0pOVzki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
One step closer, sorry, found another thing:

In the patron search for new manager, I can only find patrons with
superlibrarian, but not with manage_suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:57:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:57:16 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-OCLO3lwGYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Lucas,
please re-upload in correct order (git bz gives false conflict)
and set to Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:57:39 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-zFrxyqUbTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:57:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:57:51 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-T9KTS5wwec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not on IRC? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 10:58:06 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-tNmtVnAN81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #21 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Hi Emmi,

I have the same issue as Katrin.  This scenario works:

- Add single holiday on a range and copy to all libraries
- Use 'delete this holiday' to delete one day from the range and copy to all
libraries

As does this:

- Add repeated holiday on a range and copy to all libraries
- Use 'delete this holiday' to delete one day from the range and copy to all
libraries

But this doesn't work:

- Add single holiday on a range and copy to all libraries
- Use 'delete the single holidays on a range' to delete multiple or all days
from the range and copy to all libraries

Nor does this:  

- Add repeated holiday on a range and copy to all libraries
- Use 'delete the repeated holidays on a range' to delete multiple or all days
from the range and copy to all libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:04:28 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-nN4HjP8EhE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:04:31 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-jgKETyn7UC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101495|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101538&action=edit
Bug 24959: Fix id/label pairs in saved reports table

This patch adds a unique id attribute to each checkbox in the table of
saved reports. Also updated is the corresponding <label>'s "for"
attribute so that clicking the report id will toggle the checkbox.

To reproduce, go to Reports -> Use saved and click a number in the ID
column. Nothing happens.

After applying the patch clicking the number should check or uncheck the
corresponding checkbox.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:04:58 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-N3sQZrT6Li@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:00 +0000
Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority
 has been updated
In-Reply-To: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15214-70-7sY2kBW6SU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:02 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-izz29zpb80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:04 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-047winQP8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:06 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-TDLWTzKl4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:08 +0000
Subject: [Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
In-Reply-To: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22098-70-NpC6CB2EV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:10 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-kCHYrUAgQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:11 +0000
Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType
In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22589-70-3OzWEpNOrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:13 +0000
Subject: [Koha-bugs] [Bug 23409] Show circulation note and OPAC note with
 line feeds
In-Reply-To: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23409-70-pR9N9UFiAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:15 +0000
Subject: [Koha-bugs] [Bug 23409] Show circulation note and OPAC note with
 line feeds
In-Reply-To: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23409-70-e5YAcyBxon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:17 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-5g757uYyQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:19 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-77ocqkMSdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:21 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-xu4QIwxncQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:22 +0000
Subject: [Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a
 Koha::Item method
In-Reply-To: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24759-70-CkCKOxH3UA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:24 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-Tu9otONx6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:26 +0000
Subject: [Koha-bugs] [Bug 24907] Optionally exclude suspended holds from
 holds ratio report
In-Reply-To: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24907-70-aY4YPCqcFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24907

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:28 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-grZq6jz6TE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:30 +0000
Subject: [Koha-bugs] [Bug 24952] Refund modal confirm button should have an
 ID
In-Reply-To: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24952-70-aJA70gGNsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:32 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-nHwHx4KfT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:05:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:05:33 +0000
Subject: [Koha-bugs] [Bug 24953] Minor corrections to hold ratios report
 sidebar
In-Reply-To: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24953-70-uUg4zslKuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:07:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:07:52 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-e5imLsXi9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for grabbing this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:09:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:09:38 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13961-70-ZZYypDDhgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:12:49 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-jmALw4WZS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101539&action=edit
Bug 23590: Fix 'select manager' when creation a suggestion

On creating the TT var managedby_patron does not exist yet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:18:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:18:44 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-8YhCY7w21e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101540&action=edit
Bug 24541: Purge old messages

misc/cronjobs/cleanup_database.pl provides some database cleanup.

This patch adds cleanup for messages table.

Test plan :
- Count messages : select count(*),date(message_date) from  messages group by
date(message_date);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365
- Recount messages

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:19:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:19:51 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-D7ucXawS41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101540|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Comment on attachment 101540
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101540
Bug 24541: Purge old messages

Sorry, wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:20:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:20:21 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-SZxRmzyKzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry guys.. this one no longer applies.. I think the rebase is fairly trivial
but I'd be more confident if it was done by someone closer to the working code
here..

Jonathan or Owen perhaps?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:22:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:22:29 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-OSMEM5aWib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:22:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:22:32 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-M1nnZc7KTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101509|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101541&action=edit
Bug 24541: Purge old messages

misc/cronjobs/cleanup_database.pl provides some database cleanup.

This patch adds cleanup for messages table.

Test plan :
- Count messages : select count(*),date(message_date) from  messages group by
date(message_date);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365
- Recount messages

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok, no errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:23:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:23:00 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-ZQc9kHpQO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101521|0                           |1
        is obsolete|                            |

--- Comment #73 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101542&action=edit
Bug 24476: (QA follow-up) Move new option below warnings and messages in OPAC
account

This makes it so the new option appears right above the table of checkouts etc.
but below any warnings, messages or dialogs.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:24:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:24:07 +0000
Subject: [Koha-bugs] [Bug 24964] New: Remove pagination when searching for
 patrons with permissions
Message-ID: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

            Bug ID: 24964
           Summary: Remove pagination when searching for patrons with
                    permissions
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 12648

There are several places where we are searching for patrons with given
permissions, like adding a user to a fund, basket or suggestion (from bug
23590).

>From svc/members/search:
 88 # It is not recommanded to use the has_permission param if you use the
pagination
 89 # The filter is done AFTER requested the data

See also bug 12648.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
[Bug 12648] Link patrons to an order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:24:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:24:07 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-z9rDECO4Lg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24964


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964
[Bug 24964] Remove pagination when searching for patrons with permissions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:24:48 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-fZExhuHcvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24964

--- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #108)
> One step closer, sorry, found another thing:
> 
> In the patron search for new manager, I can only find patrons with
> superlibrarian, but not with manage_suggestions

That's a known bug, see bug 24964.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:24:48 +0000
Subject: [Koha-bugs] [Bug 24964] Remove pagination when searching for
 patrons with permissions
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-kvrHCUuHG4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23590

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:29:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:29:42 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-6TxkPyMWSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Patch doesn't apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:37 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-OHVAcYVt4P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:39 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-iDSGl623GN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:41 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-oKktCxrqof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:42 +0000
Subject: [Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to
 code if description doesn't exist
In-Reply-To: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21503-70-NED38qwGTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:44 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-KNFUFIUolT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:46 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-ZNznopD9tF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:48 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-W3Kk9LCg3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:50 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-DyO0iz9vl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:52 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-vuoI6vLYYP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:54 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-gwvjSgd0Nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:56 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-9xa68lfc6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:57 +0000
Subject: [Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
In-Reply-To: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24837-70-2OIk4KSIJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:33:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:33:59 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-wXgAc97kcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:01 +0000
Subject: [Koha-bugs] [Bug 24875] Remove extra punctuation from tools home
 page
In-Reply-To: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24875-70-g9aKEcccG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:03 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-KFUgdEzLN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:04 +0000
Subject: [Koha-bugs] [Bug 24877] Add link from vendor to linked subscriptions
In-Reply-To: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24877-70-Y60t0dvado@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24877

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:06 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-yVRc8ynzbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:08 +0000
Subject: [Koha-bugs] [Bug 24951] Payout modal confirm button should have an
 ID
In-Reply-To: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24951-70-yAZdOujj7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:10 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-e5tw04qo1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:34:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:34:12 +0000
Subject: [Koha-bugs] [Bug 24962] Don't show floating toolbar when duplicate
 patron record was detected
In-Reply-To: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24962-70-J08gXW1FLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24962

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:01 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-b8OwXGC5da@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:06 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-i8S70nlydl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95293|0                           |1
        is obsolete|                            |

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101543&action=edit
Bug 13881: Schema file DO NOT PUSH!

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:10 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-g2PGXWQ2tD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95294|0                           |1
        is obsolete|                            |

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101544&action=edit
Bug 13881: kohastructure and atomic update

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:15 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-5d6wDTNO8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101479|0                           |1
        is obsolete|                            |

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101545&action=edit
Bug 13881: Add desk management

Add a desk and linked it to a library (branch). That's it. In the
future it'll have super features like being able to link waiting
reserve to a specific desk.

Test plan:

1. go to the administration page and notice there isn't any mention of
desk whatsoever
2. apply patches
3. ./installer/data/mysql/updatedatabase.pl
4. prove t/db_dependent/Koha/Desks.t
5. you now have desks links in admin-home and admin-menu
6. click the link
7. add a desk
8. add another one
9. delete one
10. you should have a fair list of all current desks defined
11. Done

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:19 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-Bp3SpiX1G1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101546&action=edit
Bug 13881: (QA follow-up) Check for manage_libraries permission

The .pl was checking for a new permission desks_management not
(yet) added. As the templates already checked for manage_libraries
the .pl was changed accordingly to also use it.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:36:24 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-KVdEUeBPPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101547&action=edit
Bug 13881: (QA follow-up) Some documentation and terminology fixes

- Branchcode = Library
- Desk id = Desk ID
- Show library name on desk list and when deleting desk instead of code
- Some small changes to the database documentation.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:56:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 11:56:38 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-B0FxqmF9Vf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I will!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:01:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:01:11 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-GPpwuEnji0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:01:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:01:47 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-bXKHAyVvUX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #111 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #109)
> Created attachment 101539 [details] [review]
> Bug 23590: Fix 'select manager' when creation a suggestion
> 
> On creating the TT var managedby_patron does not exist yet

That's for another bug I found when trying again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:05:38 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-5saJrCX82o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100847|0                           |1
        is obsolete|                            |

--- Comment #112 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101548&action=edit
Bug 23590: DBIC Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:06:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:06:40 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-hpT1MfAa81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99676|0                           |1
        is obsolete|                            |

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101549&action=edit
Bug 19036: Add ability to auto generate a number for account credits

In some areas it's required to sequentially number payment slips /
receipts.

This patch adds a database column accountlines.credit_number and a
system preference AutoCreditNumber to control how this number will be
generated.  The following options are available:

- Do not automatically generate credit numbers.
  This is the current behaviour and the default syspref value.

- Automatically generate credit numbers in the form <year>-0001 (annual)

- Automatically generate credit numbers in the form
  <branchcode>yyyymm0001 (branchyyyymmincr)
  where <branchcode> is the branch where the user (staff member) is
  logged in

- Automatically generate credit numbers in the form 1, 2, 3
  (incremental)

It also adds a column (hidden by default) in the table under
Transactions tab to display this number.

Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
   column credit_number in table account-fines. It will be easier for
   testing
2. Create a manual credit for a borrower. Verify in Transactions tab
   that this credit has no number generated
3. Change syspref 'AutoCreditNumber' to 'incremental'
4. Create more manual credits, and verify that the numbers generated are
   1, 2, 3, ...
5. Change syspref 'AutoCreditNumber' to 'annual'
6. Create more manual credits, and verify that the numbers generated are
   '2020-0001', '2020-0002', ...
7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
8. Create more manual credits, and verify that the numbers generated are
   'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are
   connected to library BRANCHA, and it's February 2020)
9. Set library to another one, say BRANCHB
10. Create more manual credits, and verify that the numbers generated are
    'BRANCHB2020020001', 'BRANCHB2020020002', ...
11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
    somewhere. Go back to Transactions tab and click on 'Print' for one
    line that has a credit number. Make sure the number is there.
12. prove t/db_dependent/Koha/Account.t

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:06:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:06:45 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-YI8m9szrGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101550&action=edit
Bug 19036: Add ability to enable credit number for only some credit types

This feature is disabled by default for all credit types. To enable it
you have to set the syspref AutoCreditNumber to the value of your choice
and then enable the feature for each credit type you want.
System credit types can be modified too (but only this particular field
can be modified)

Also, throw an exception when the feature is enabled and a value for
credit_number has already been set

Updated test plan:
Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
   column credit_number in table account-fines. It will be easier for
   testing
2. Create a manual credit for a borrower. Verify in Transactions tab
   that this credit has no number generated
3. In Admin » Credit types:
  a. edit the FORGIVEN type and enable credit number generation
  b. create a new type A, check "can be manually added" and "enable
     credit number"
  c. create a new type B, check "can be manually added". Do NOT enable
     credit number
4. Change syspref 'AutoCreditNumber' to 'incremental'
5. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
6. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are 1, 2, 3, ...
7. Change syspref 'AutoCreditNumber' to 'annual'
8. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
9. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are '2020-0001', '2020-0002', ...
10. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
11. Create more manual credits with types CREDIT and B, and verify that
    the numbers are not generated
12. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHA2020020001',
    'BRANCHA2020020002', ... (assuming you are connected to library
    BRANCHA, and it's February 2020)
13. Set library to another one, say BRANCHB
14. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHB2020020001',
    'BRANCHB2020020002', ...
15. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
    somewhere. Go back to Transactions tab and click on 'Print' for one
    line that has a credit number. Make sure the number is there.
16. prove t/db_dependent/Koha/Account.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:06:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:06:58 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-5lAtkG0TFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:13:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:13:49 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-zyZ7ejCswE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.hansen at ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:19:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:19:18 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-OcdmrL2Bhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:19:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:19:21 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-9wn7SRG0oe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100297|0                           |1
        is obsolete|                            |
 Attachment #100298|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101551&action=edit
Bug 22771: Respect nonfiling indicators for search fields

Strip initial characters from search fields in accordance with
nonfiling character indicators.

To test:

1) Apply patch
2) Run tests in t/Koha/SearchEngine/Elasticsearch.t
3) All tests should pass

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:19:24 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-n4LR3u4JBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101552&action=edit
Bug 22771: Fix mistakes in list of nonfiling character fields

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:19:27 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-zjXWWEd1nW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101553&action=edit
Bug 22771: (QA follow-up) Fix POD

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:20:36 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-n0SIZDMY2J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:20:38 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-h8qFFENnEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101554&action=edit
Bug 16457: (follow-up) Enable click event on dynamically-created elements

This patch moves the click handler for patron attribute actions ("new",
"clear") from the links themselves to the container. This allows jQuery
to correctly target dynamically-created copies of the links.

To test you should have extended patron attributes enabled and you
should have some repeatable attributes defined.

 - Create or edit a patron record
 - In the "Additional attributes and identifiers" section, test the
   "Clear" and "New" links. Confirm that the controls work with both the
   original instance of the field and those created by clicking "New."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:21:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:21:05 +0000
Subject: [Koha-bugs] [Bug 24965] New: Koha::Object->to_api should handle
 undef counts
Message-ID: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

            Bug ID: 24965
           Summary: Koha::Object->to_api should handle undef counts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If to_api is requested to embed the count on a relation that might be undef
(for example, if the relation is not just a FK on another table but linking
table:

sub current_item_level_holds {
    my ($self) = @_;

    my $items_rs     = $self->_result->aqorders_items;
    my @item_numbers = $items_rs->get_column('itemnumber')->all;

    return unless @item_numbers;

    my $biblio = $self->biblio;
    return unless $biblio;

    return $biblio->current_holds->search(
        {
            itemnumber => {
                -in => \@item_numbers
            }
        }
    );
}

it is possible to get exceptions for calling ->count on an undefined object. We
should catch this situation and return zero.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:21:17 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-ki60FGacqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Blocks|                            |20212
         Depends on|                            |24528


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
[Bug 24528] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:21:17 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-BBMfXvzxby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965
[Bug 24965] Koha::Object->to_api should handle undef counts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:21:17 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-VSWWHz8FYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965
[Bug 24965] Koha::Object->to_api should handle undef counts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:23:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:23:34 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-aJzyp0P1IV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:23:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:23:42 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-UFk58U1tV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:23:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:23:50 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-wihw11rVRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #17 from Frank Hansen <frank.hansen at ub.lu.se> ---
When we migrated from your previous ILS (Virtua), I kept some vendor contact
information in booksellerfax, bookselleremail and currency. This means that we
are will lose this information when you drop them from DB.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:26:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:26:10 +0000
Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items
In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24023-70-wWCqrlRinl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95331|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101555&action=edit
Bug 24023: Add ability to create bundles of items

This patch adds the ability to link items to a biblio to create bundles
of items that can be reserved and checked out like a regular item.
A withdrawn status will be set to linked items so that they can't be
checked out while they are part of a bundle.
When returning a bundle, the list of items that are part of this bundle
will be displayed, allowing the librarian to verify that all items are
there.
Bundles can also be used in the inventory tool as a filter.

Test plan:
0. Apply the patch, run updatedatabase + update_dbix_class_files
1. Create a biblio record with at least a title. Create an item for this
   biblio record
2. In the biblio 'Edit' menu you have a new option: 'Link elements'.
   Click on it
3. Enter a list of valid and invalid barcodes in the textarea, select a
   withdrawn status and click on 'Continue'
4. Verify that new fields have been added to the MARC record (462 for
   UNIMARC, 774 otherwise)
5. Verify that the withdrawn status has been correctly set for the items
   you have linked
6. Verify that, for item created at step 1, items.materials has been
   updated with the number of items contained in the bundle
7. Edit the biblio record and remove one of the 462/774 fields
8. Verify that the corresponding item's withdrawn status has been reset
9. Checkout and checkin the item created at step 1
10. You should see the list of items contained in the bundle. Click on
    'Confirm checkin without verifying'. Verify that the item has been
    returned
11. Checkout and checkin the item created at step 1 again
12. Now click on 'Verify items bundle contents'. A textarea lets you
    enter barcodes. Enter some (but not all) barcodes that are in the
    bundle. Select a 'lost' status and click on 'Confirm checkin and
    mark missing items as lost'
13. Verify that the items corresponding to barcodes you did not type in
    the textarea are now marked as lost with the lost status you chose
14. Go to the inventory tool, use the bundle filter and verify that it
    works

Sponsored-by: Bibliothèque Départementale de l'Yonne

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:28:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:28:15 +0000
Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items
In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24023-70-UVWBe9VMFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
I removed the parts that were modifying items.uri. The idea was to easily jump
from the item to its bundle, but it may not be the best way. It can be added in
another bug if needed.

Back to needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:28:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:28:25 +0000
Subject: [Koha-bugs] [Bug 24963] Terminology: auto renewal,
 auto-renewal or autorenewal?
In-Reply-To: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24963-70-Gv8uCDiY7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I vote "auto-renewal." It is used consistently in this article, for example:
https://en.wikipedia.org/wiki/Automatic_renewal_clause

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:38:00 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-hKqvYha7ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #19 from Simon Perry <simon.perry at itcarlow.ie> ---
Created attachment 101556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101556&action=edit
Test 24/3/20

Attached is testing completed today. I tested all 4 options available in the
useDaysMode syspref. Only for the Ignore and Use calendar to push due date to
next pen matching weekday.... syspref settings did the checkout due date/hour
remain on the days of checkout. This wouldn't work for our live system settings
as noted.
Regards, Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:49:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:49:44 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-J0xZWmfno7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100078|0                           |1
        is obsolete|                            |

--- Comment #10 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101557&action=edit
Bug 24710: patron-title.inc should have seperate span classes for names

This patch adds some <span> elements with classes to patron-title.inc for both
the staff client and OPAC
TEST PLAN:
1. Have a patron with a firstname, surname, and othername and title
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS  to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
    .patron-firstname {display: none;}
    .patron-othernames {display:none};
    .patron-surname{display:none}
    .patron-title{display:none}
5. On the OPAC navigate to /cgi-bin/koha/opac-user.pl and check the names by
adding the same CSS to OPACUserCSS
6. Sign-off

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:49:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:49:59 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-uuzJdIlBgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:51:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:51:18 +0000
Subject: [Koha-bugs] [Bug 24966] New: Fix calls to maybe_add where method
 call does not return a value
Message-ID: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

            Bug ID: 24966
           Summary: Fix calls to maybe_add where method call does not
                    return a value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.

One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.

What is actually received is: 'CY', and a SIPServer object.

We ingest the parameters like so:
--
sub maybe_add {
    my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!

This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324    063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'---

I do not know why this is happening, but there are a couple solutions:
1) Move the $server parameter to be the first parameter of the subroutine call
2) Check the value of $value and swap $value and $server if it is the server
object.

I will write a patch implementing the latter solution, as it is a two line
change, versus a many line change for the former.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:51:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:51:56 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-rxxutbdznI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:52:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:52:42 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-Okr7YvPtYc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:52:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:52:46 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-nSqYqhfAVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101558&action=edit
Bug 24745: (follow-up) Correct perl syntax

Subroutine should "return;" instead of "return 0;"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:53:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:53:06 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-JJbjUaEmKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:54:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:54:11 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-dmVt7DOx5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:54:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 12:54:14 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-zJPUHMhifZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101559&action=edit
Bug 24966: Fix calls to maybe_add where method call does not return a value

For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.

One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.

What is actually received is: 'CY', and a SIPServer object.

We ingest the parameters like so:
--
sub maybe_add {
    my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!

This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324    063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'
--

Test Plan:
1) On master, perform a checkin of an item not on hold using the sip cli tester
2) Note some fields contain something like 'C4::SIP::SIPServer=HASH(0x1ea0e58)'
3) Apply this patch
4) Restart the SIP server
5) Perform the SIP checkin again
6) Those fields from step 2 should be gone!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:00:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:00:22 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-gASJ3AP76e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #6)
> (In reply to Fridolin SOMERS from comment #5)
> > 
> > Do we remove INTRAdidyoumean syspref and related code ?
> 
> I guess we could - it's not been implemented in years and I suppose you can
> still easily add it back if you intend to develop it?

Indeed, by looking at code for OPAC I'd say

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:04:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:04:05 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-EplYcMl4pH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:04:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:04:27 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-Ynmypi5rVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101560&action=edit
Bug 24965: Regression tests

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail with "Can't call method "count" on an undefined
value..."

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:04:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:04:30 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-Qn8FD0RSVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101561&action=edit
Bug 24965: Make Koha::Object->to_api handle undef counts

In some cases where we write a class method that is not directly tied to
a DBIC relationship (maybe it should) we are following the following
pattern:

   my $related_object = Koha::RelatedObjects->find($params,$attributes);
   return unless $related_object;
   return $related_object->some_iterator_on_other_class;

While this is not highly consistent (design-wise, because it would be
great if we could return an empty iterator instead of undef) we use this
broadly and consistently.

The to_api method +count handling is not failsafe to those undef cases.
And we should make it return 0 instead of trying to get ->count on
undefined objects.

This patch makes to_api fallback to 0 when it is requested to embed a
count.

To test:
1. Apply the regression test patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Test fails with an error about ->count on undefined variable.
3. Apply this patch
4. Repeat 2
=> SUCCESS: The patch adds the simple fallback to 0 on counts
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:19:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:19:22 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-LNKKnOL16E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:19:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:19:29 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-WMGTXlKfs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101336|0                           |1
        is obsolete|                            |

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101562&action=edit
Bug 20399: Remove "did you mean" for the staff interface

The amdin page for the "did you mean" feature has two block for setting it up
in the staff interface, and a note saying this isn't implemented on the staff
interface yet.
We remove the part about the staff interface until it actually is implemented.

Test plan :
1) Apply patch
2) Go to Administration > Did you mean?
3) See there is only the OPAC block
4) Change some checkboxes
5) Save configuration
6) Check that configuration is saved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:21:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:21:41 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-LyfxphqINJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101501|0                           |1
        is obsolete|                            |

--- Comment #8 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101563&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what fields in 'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship')) select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* None of the fields in 'Alternate contact' are pre-filled
from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

7. Observe this syspref containing the following:
phone|email|streetnumber|address|city|state|zipcode|country

8. Repeat step 1 and observe the following fields are prefilled from guarantor:
streetnumber
address
city
state
zipcode/postal code
country
Primary phone
Primary email

9. Add the following content into PrefillGuaranteeField syspref and save:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

10. Repeat step 1 and observe all fields in 'Main address',
'Alternate contact', and (except 'Guarantor surname', 'Guarantor
first name', and 'relationship') in 'Contact' are pre-filled from
guarantor

11. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved as have the values you haven't altered

12. Amend PrefillGuaranteeField syspref to be:
phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added a invalid column field 'drfregfre')

13. Repeat step 1 and observe no internal server errors and all fields
listed in step 10 are still pre-filled

14. Amend PrefillGuarantee field syspref to be:
phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

(Note: Have added contactfirstname which is what the 'Guarantor first
 name' field in 'Contact' section of member entry form is)

15. Repeat step 1 and observe all fields defined in step 10 are filled
and 'Guarantor first name' is not filled even though it was listed in
PrefillGuarantorField because contactfirstname (along with
contactsurname and relationship are meant for non Koha patrons and so
should not pre-fill from a Koha patron)

16. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:22:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:22:08 +0000
Subject: [Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
In-Reply-To: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24756-70-wDDsDbX4Cn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #18)
> It seems that we need it for 19.11 as well
> 
> 19.11_D9 (79)
> 
> koha_1       | #   Failed test 'Remote import does not fail on read_net'
> koha_1       | #   at t/db_dependent/Koha/XSLT/Security.t line 124.
> koha_1       | # found warning: XSLT_Handler: I/O warning : failed to load
> HTTP resource
> koha_1       | # expected to find warning: (?^u:I/O warning : failed to load
> external entity)
> koha_1       | # Looks like you failed 1 test of 7.

This should be backported, yes. The RMaints look in this queue, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:24:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:24:26 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-qPZWNhVB1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #9 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I've tested 1-15 on a sandbox and it works well.

If someone else could test 16, then I'm happy to add my sign off line to the
patch:

16. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:25:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:25:00 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-aeDm5j2cwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #18)
> I have another issue tho: We apply the default from the ACQ framework, while
> we can specifically choose a framework to import the record in on the
> Z39.50/SRU form - this is not caused by this bug, but doesn't make sense to
> me. Especially for 942$c it would make a lot of sense to me to set different
> default for different frameworks and use them. What do you think, Marcel?

Sounds valid, have to check. Getting back to it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:37:34 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-PXHaAVPLfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101452|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101564&action=edit
Bug 24201: Attach desk to intranet session

When Desks are defined, a librarian can attach a desk to its session.

Test plan:

1. apply 13881 and create some desks
2. you should see “NO DESK SET” in the intranet header
3. go to circulation > Set desk
4. you should see your desk name in the header, whatever the page
5. you can also set desk with the header menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:38:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:38:04 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-wXdfWIVr7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:15 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-brJIQQq7Zq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96084|0                           |1
        is obsolete|                            |
  Attachment #96096|0                           |1
        is obsolete|                            |

--- Comment #119 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101565&action=edit
Bug 15326: Add CMS feature

INCOMPLETE - For evaluation purposes only!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:20 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-VMzxjSYrjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96085|0                           |1
        is obsolete|                            |

--- Comment #120 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101566&action=edit
Bug 15326: (follow-up) Add CMS feature

This patch builds on Martin Persson's patch. I made a few changes that
improve the patch and make this feature functional.
The only thing I am not completely satisfied with (and doesn't reliably
        work) is the navigation for the CMS pages on both the staff side
and the
OPAC side. This needs work. Otherwise the CMS feature works.

- Make sure you update database after applying patch
- After adding a few pages, confirm that filtering results works (play
         with different combinations of display location, library and
         language)
- Confirm that pages with specific locations ONLY show up in those
locations, i.e. OPAC pages can only be accessed in OPAC and staff
interface
pages can only be accessed on staff client
- Confirm that table is showing correct data, particularly language,
    location and library
    - Confirm that if page has not been published and user does not have
    permission to edit pages, page content will not display on OPAC
    side. On
    staff side, a message will show saying that page has not been
    published
    - Confirm pagination for table shows and works
    - Confirm deleting pages works as expected (confirm message before
            delete)
    - Confirm link title must be unique when adding new pages
    - Confirm that editing the details of an existing page works
    - Confirm that adding a child page will only work if the location of
    child page matches location of parent page, i.e., if parent page is
    an
    OPAC page then child page must also be OPAC page. if parent page is
    in
    all locations then child page can be in all or either interface(s)
    - Confirm Select All/Clear All toggle works
    - Confirm viewing of CMS pages in OPAC and in staff client works and
    looks nice

    Sponsored-by: Region Halland

    Bug 15326: [FOLLOW-UP] Many fixes

    This patch:
    - moves action buttons into a dropdown, adds a delete button to
    dropdown
    - fixes the tests (they should now all pass)
    - fixes qa tool problems
    - removes the Koha::CmsPages->remove() method (unnecessary)
    - makes changes to the Koha::CmsPages->add() method (now simpler,
            easier
            to test)

    This is now ready to test.

    Sponsored-by: Catalyst IT

    Bug 15326: [FOLLOW-UP] More fixes

    This patch removes the t/Pages.t file because it isn't required, and
    other unused methods.

    This patch is ready to test. The appropriate tests are in
    t/db_dependent/Pages.t

    Bug 15326: [FOLLOW-UP] adding and editing fixes

    Sorry, did not see the second half of your comment. This patch
    should
    fix the adding and editing issues in Comment 16.

    Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing

    Fixes issues from Comment 19, please test

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Michal Denar <black23 at gmail.com>

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:25 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-0BYzFBmnHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96086|0                           |1
        is obsolete|                            |

--- Comment #121 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101567&action=edit
Bug 15326: (follow-up) utf8 to utf8mb4

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:31 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-nuUNKdmyRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96087|0                           |1
        is obsolete|                            |

--- Comment #122 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101568&action=edit
Bug 15326: (follow-up) Move js to footer, use Asset plugin

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:36 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-y7gWfS75PK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96088|0                           |1
        is obsolete|                            |

--- Comment #123 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101569&action=edit
Bug 15326: (follow-up) Don't make links to unpublished pages in opac

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:42 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-CtIz5ZFIUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96089|0                           |1
        is obsolete|                            |

--- Comment #124 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101570&action=edit
Bug 15326: (follow-up) Fix tools menu highlighting

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:47 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-uE68upQy3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96090|0                           |1
        is obsolete|                            |

--- Comment #125 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101571&action=edit
Bug 15326: (follow-up) Code review fixes

Addresses the following issues:

b) In opac-cmspages there is:
+        flagsrequired   => { borrow => 1 },
The borrow permission has been removed since. (blocker)

c) Comment was removed unnecessarily, just needs to be moved into
its right spot below again:
-# If GoogleIndicTransliteration system preference is On Set
parameter to load Google's javascript in OPAC search screens

d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 );  (blocker)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:53 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-Ju98I6Drvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96091|0                           |1
        is obsolete|                            |

--- Comment #126 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101572&action=edit
Bug 15326: (follow-up) Interface fixes

This patch addresses the following:

a) I feel we don't need the "Pages" heading. It only takes up space and
states the obvious. (non-blocker... but navigation needs work, see
below)

b) OpacMainUserBlock should not show on the pages in my opinion.
Libraries use it to place text on the start page instead of using the
news feature, which means it repeats on all pages. I'd really like to
see this changed.

c) Personally I'd change "Location" to "Interface" to avoid confusion
with the item value in translations. But I see it's the same on news. So
out of scope here.

d) Parent pages can be deleted without warning. Childs will be moved to
top level. This is acceptable behaviour as they are not left orphaned.
But it might be something to improve on in the future.

e) In the test plan and in the code I see there should be a confirmation
message on deleting a single or multiple entries, but this doesn't work.
(blocker)

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:39:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:39:58 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-cILKt4T7rF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96092|0                           |1
        is obsolete|                            |

--- Comment #127 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101573&action=edit
Bug 15326: (follow-up) Pages navigation fixes

This is the best I've managed to do with the navigation. Would be happy
for someone else to give it a go because I'm aware that some parent
links repeat.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Rebased-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:03 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-7Y1fB5MQhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96093|0                           |1
        is obsolete|                            |

--- Comment #128 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101574&action=edit
Bug 15326: (follow-up) Redindent new CMS page templates

This patch is an opinionated reindent of new and changed templates
related to the CMS feature. I think it would be nice for these templates
to start out with good indentation.

To test, apply the patch and test the CMS feature. There should be no
visible change to the way it looks or the way it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:08 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-yZG3OaL1AW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96094|0                           |1
        is obsolete|                            |

--- Comment #129 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101575&action=edit
Bug 15326: (follow-up) Corrections to staff client templates

This patch makes some corrections to the staff client's CMS-related
templates:

 - Add missing Template Toolkit filters.
 - Remove JavaScript from tools-menu.inc. This must have crept in during
   a rebase.
 - Add navigation link highlighting to tools-menu.js instead.
 - Convert tools/cmspages.tt to Bootstrap grid.
 - Correct toolbar button class.
 - Move some column sorting configuration out of JS and into table
   markup.
 - Move "Select all" / "Clear all" links to the top of the table to
   match similar interfaces.
 - Change the Action menu's "Intranet" and "OPAC" links to be "View" and
   "View in OPAC." The OPAC view now opens a new window.

To test, apply the patches and test the Pages feature in the staff
client: Adding, editing, deleting, viewing. For each view, test that the
page layout adjusts to various browser widths.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:14 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-mdwlkb9OVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96095|0                           |1
        is obsolete|                            |

--- Comment #130 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101576&action=edit
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters

Previous versions of this patch set adds a LESS file to the OPAC, which
is now obsolete. It should be removed.

In addition, the change made to opac.less contained CSS which didn't
apply to any existing markup, so it need not be added to opac.scss.

The patch also adds missing Template Toolkit filters to template files.

None of these changes should be visible in testing. OPAC CMS pages
should function as usual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:19 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-OQAXti2lhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96097|0                           |1
        is obsolete|                            |

--- Comment #131 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101577&action=edit
Bug 15326: Fix QA errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:24 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-rJbV9Qgkr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #132 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101578&action=edit
Bug 15326: Fix filters and adjust tiny_mce assets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:30 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-A5WMFZb8IN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97237|0                           |1
        is obsolete|                            |

--- Comment #133 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101579&action=edit
Bug 15326: (follow-up) Template tweaks

This patch makes some tweaks to the staff-side template:

 - Fix some indentation
 - Add some markup comments
 - Fix some HTML validation errors: Eliminate duplicate id attributes
 - Expand the descriptiveness of <title>, breadcrumbs, and form legend
 - Increase size of link and title fields; Add maxlength attribute to
   title field.
 - Move title and link fields to the second column of the table -- more
   consistent with other tables where the main link is in the first
   column.
 - Link parent page information to corresponding edit page
 - Correct incorrectly filtered action links
 - Correct default table sort
 - Fix TinyMCE configuration - I copied some configuration code from
   another page which was updated more recently.

 To test, apply the patch and test the process of adding, editing, and
 deleting pages. Test all the options in the "Actions" menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:40:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:40:35 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-sjW9b6giJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #134 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101580&action=edit
Bug 15326: DO NOT PUSH - Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:44:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:44:11 +0000
Subject: [Koha-bugs] [Bug 24956] Add ability to define emergency/override
 circ rules
In-Reply-To: <bug-24956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24956-70-a5WW4NqHj2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:47:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:47:55 +0000
Subject: [Koha-bugs] [Bug 23795] Convert OpacCredits system preference to
 news block
In-Reply-To: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23795-70-Ca6L1A1tF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99706|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101581&action=edit
Bug 23795: Convert opaccredits system preference to news block

This patch builds on Bug 22318 to move the opaccredits system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the opaccredits system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and confirm that the content which was previously in
   the opaccredits system preference now displays correctly where
   it was before.
 - In the staff client, go to Tools -> News and verify that the content
   from opaccredits is now stored in news items. There should be
   one entry for each of the enabled translations in your system, for
   instance 'opaccredits_en', 'opaccredits_fr-FR',
   'opaccredits_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   opaccredits preference has been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:49:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:49:08 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-KyFQZpxKVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #135 from Nick Clemens <nick at bywatersolutions.com> ---
Rebased, found issues:

Parent child links are a confusing:
 List display parent name needlessly
 Cannot see children from parent in breadcrumbs

Can access unpublished pages

Library specific pages are listed for all branches

Staff side link should use link title not page title

Can view staff pages on opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:53:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:53:26 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-FLGSVLcQmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100375|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101582&action=edit
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one
or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has
more than the number of claims specified in the system preference. Currently
the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:53:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:53:40 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-hNChwxDcMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:55:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:55:01 +0000
Subject: [Koha-bugs] [Bug 24967] New: Allow final user to choose ordering
 column
Message-ID: <bug-24967-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24967

            Bug ID: 24967
           Summary: Allow final user to choose ordering column
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pascale.nalon at mines-paristech.fr
        QA Contact: testopia at bugs.koha-community.org

It would be fine, if members of staff, who have not permissions to modify a SQL
requests, but only to run them, could choose the column and the way (ASC or
DESC) to order the pre-builded request

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:58:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:58:16 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-gksDlIOzgt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

--- Comment #8 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 101583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101583&action=edit
Bug 24819: (follow-up) Rename suggestion_search to suggestor_search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:58:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:58:35 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-X2du3R771U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:58:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:58:38 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-px5uDKu6lo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100305|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101584&action=edit
Bug 24754: Set userenv for ilsdi requests

Currently ILSDI scripts do not have a userenv set. This affects both
action_logs and statistics.

For action_logs we either get no user or, if there is an active session, we use
that one. This can have unintended consequences and we should explicitly set
the env so that system user (0) is recorded

For statistics we need to specify a branch to record for actions like renewals.
With bug 24759 we add an items method for this. We should take advantage of
this method and use the 'opac' interface as the ilsdi scripts live there.

To test:
1 - Enable ILSDI in systempreferences
2 - Checkout an item to a patron
3 - Enable Renewal logs
4 - Ensure you will be able to renew the item several times
5 - Open an incognito/private browser
6 - Renew item via ilsdi:
   
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
7 - Check action logs, interface may be random, user should be 0, if not make
sure the user in step 9 is a different one
8 - In private browser open a new tab
9 - Sign in to staff client
10 - Return to other tab
11 - Refresh page to repeat renewal
12 - Check action_logs
13 - The second renewal indicates it was renewed via intranet by logged in
staff member
14 - Apply patch
15 - restart_all
16 - Ensure staff client still signed in
17 - Repeate renewal again
18 - Check logs, renewal now indicates opac again (as it should), user is 0
even if logged in on other tab

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:58:42 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-EhwxHC6Ged@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101094|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101585&action=edit
Bug 24754: (QA follow-up) Add timestamp, remove 11th parameter

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 13:59:30 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-gcjqy2L7xV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
@RM: There is a dependency ! But note that it is imo not strictly needed to
wait for it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:02:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:02:30 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-n1ODs2FIi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:06:20 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-jQp9SejGcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:06:23 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-R6hwnUQItX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100152|0                           |1
        is obsolete|                            |
 Attachment #101558|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101586&action=edit
Bug 24745: OPAC news block plugin should evaluate as false if there are no
items

This patch changes the way news is returned from GetNewsToDisplay in
KohaNews.pm so that the template variable will evaluate as false instead
of simply being an empty data structure.

To verify the bug, remove your opacheader news entry and view source on
any page in the OPAC. You should find some empty markup right after
'</div> <!-- /navbar -->'

<div class="container-fluid">
    <div class="row-fluid">
    </div>
</div>

To test the fix, apply the patch and reload the OPAC page. The empty
divs should be gone. Add content to the opacheader news item and confirm
that it displays correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Divs gone, no errors.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:06:28 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-8LAvo1sOAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101587&action=edit
Bug 24745: (follow-up) Correct return statement in news plugin

Subroutine should "return;" instead of "return 0;"
We also prevent ProhibitExplicitReturnUndef by not returning "undef"
explicitly.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Commit message edited.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:07:36 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-dF9Q1pcLvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:16:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:16:59 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-aHHvxIfpHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:19:28 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-tzRJx8Qm1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:19:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-xTUzxJFfcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:26:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:26:57 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-SGtVIfUsGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sally from comment #9)
> I've tested 1-15 on a sandbox and it works well.
> 
> If someone else could test 16, then I'm happy to add my sign off line to the
> patch:
> 
> 16. Run tests:
> sudo koha-shell <instancename>
> prove xt
> prove t

Hi Sally, don't worry about those, we will cover tests during QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:28:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:28:29 +0000
Subject: [Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system
 preference to news block
In-Reply-To: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23797-70-vxsgFSz5um@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:29:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:29:44 +0000
Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on
 bibliosubtitle in SQL files
In-Reply-To: <bug-21047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21047-70-fcLRsv0xY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Now that there is Bug 11529 do we replace instead of removing ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:31:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:31:35 +0000
Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy
In-Reply-To: <bug-19261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19261-70-Uq0HZdGq6q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:34:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:34:11 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-xgyP9cb8mG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101498|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:34:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:34:31 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-iPIxH3QML0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101493|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:39:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:39:45 +0000
Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on
 bibliosubtitle in SQL files
In-Reply-To: <bug-21047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21047-70-B9qwThySft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #6)
> Now that there is Bug 11529 do we replace instead of removing ?

I think the bug took care of that already - and if you do it for existing
installations, it will be incomplete - only new/edited will fill the column. 

I think it would still be worthwhile to remove the false mapping, if there are
any left.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:52:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:52:12 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-xPgBWLoJvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm looking to add a followup of my own here to clarify the situation..
struggled to put it into words when talking to Agustin so I'm going to let code
speak ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:01 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-3dYMyFIUE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:05 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-4TiYqgO9F8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100788|0                           |1
        is obsolete|                            |

--- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101588&action=edit
Bug 23590: Add ability to edit the manager of a suggestion

Prior to this patch there was an hidden behavior that set the manager to
the logged in user when a suggestion was edited. This patch proposes to
let the librarian pick another manager.
Other small adjustements will be added to polish this new behavior:
 * Create 2 new DB columns: suggestions.lastmodificationby and
 suggestion.lastmodificationdate
 * Choose a manager when editing a suggestion
 * Batch modify suggestions and set a manager for them
 * Let notify the new manager using the TO_PROCESS letter
 * Display the manageddate, lastmodificationby and lastmodificationdate
 info where appropriate

This first patch adds a new "Select manager" link when editing a
suggestion.

Test plan for the whole patchset:
0/
  a. Execute the update DB entry, generate the new DBIC file and restart all
  b. Create at least 2 patrons with the suggestions_manage permission
1/ Submit a new suggestion (OPAC or staff, not important)
2/ Accept it
3/ Edit it
=> "Last modification by" is empty
=> You see that you are the manager of this suggestion
4/ Click "Select manager" and search for a new manager
=> The patron search will only display patrons with the
suggestions_manage permission
5/ Save
6/ Edit again
=> The manager is set to you, but there is a note saying that previously
it was the patron you picked
=> The "Last modification by" is set to you
7/ Click "Keep existing manager"
=> The manager is now set to the previous manager
8/ Select another manager (which has a valid email address defined)
9/ Click the "notify" checkbox
10/ Save
11/ Confirm that a TO_PROCESS notice has been generated into the
message_queue table
12/ Create at least one other suggestion
13/ List the suggestions
=> There is a 4th action column to assign a manager to several
suggestions in one go.
14/ Use this new button and confirm that it works as expected
15/ Go to your purchase suggestion list (OPAC and staff)
=> You see the "managed date" displayed in a new column

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:11 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-DcwTZlYzKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100789|0                           |1
        is obsolete|                            |

--- Comment #114 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101589&action=edit
Bug 23590: Clean TT variables for patrons

Just a bit of cleaning

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:15 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-AmONsFUUuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100790|0                           |1
        is obsolete|                            |

--- Comment #115 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101590&action=edit
Bug 23590: Cleaning - Remove op_* vars

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:20 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-M1sRReQQ8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100791|0                           |1
        is obsolete|                            |

--- Comment #116 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101591&action=edit
Bug 23590: Batch update manager for suggestions

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:25 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-ekZIJNN3X1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100792|0                           |1
        is obsolete|                            |

--- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101592&action=edit
Bug 23590: Only return patrons that have the suggestions_manage permission

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:30 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-E2cI49jlsq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100793|0                           |1
        is obsolete|                            |

--- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101593&action=edit
Bug 23590: Add the ability to notify a new manager

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:34 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-ypLUebfGqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100794|0                           |1
        is obsolete|                            |

--- Comment #119 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101594&action=edit
Bug 23590: Add lastmodification by and date columns

No tests are provided for the changes made to SearchSuggestion. It is
going to be remove very soon as it is super ugly...

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:39 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-d3bUTGK0sL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100795|0                           |1
        is obsolete|                            |

--- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101595&action=edit
Bug 23590: Add atomic update file

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:44 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-MKLIv2uxSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100796|0                           |1
        is obsolete|                            |

--- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101596&action=edit
Bug 23590: Remove JS error on the suggestion list

The notify option is only available from the edit view

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:49 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-eCZ4i9Yqzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100846|0                           |1
        is obsolete|                            |

--- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101597&action=edit
Bug 23590: Fix select manager on list for all tabs

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:54 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-fm9qRSMRNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100848|0                           |1
        is obsolete|                            |

--- Comment #123 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101598&action=edit
Bug 23590: (QA follow-up) Add missing filters and drop script type

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:55:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:55:59 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-7RKcCXk4Q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100849|0                           |1
        is obsolete|                            |

--- Comment #124 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101599&action=edit
Bug 23590: (QA follow-up) Fix some problems created by recent changes and
updatedatabase statement

- Ensure that the sequence of columns will be the same for new
  and updated installations (add AFTER ...)
- Fix permissions (see bug 22868)
- Fix column configuration (see 16784)
- Remove '- ' displying before the date

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:04 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-STAu40VXXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100850|0                           |1
        is obsolete|                            |

--- Comment #125 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101600&action=edit
Bug 23590: remove unused variable

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:09 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-AdxToPL3yt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100851|0                           |1
        is obsolete|                            |

--- Comment #126 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101601&action=edit
Bug 23590: Update new fields with relevant values

We are filling lastmodificationdate and lastmodificationby depending on
the max dates between manageddate, accepteddate and rejecteddate

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:14 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-h8GKRqGxd8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100852|0                           |1
        is obsolete|                            |

--- Comment #127 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101602&action=edit
Bug 23590: Fix ergonomic issue if last modification by is empty

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:20 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-niUC1hlez1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100853|0                           |1
        is obsolete|                            |

--- Comment #128 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101603&action=edit
Bug 23590: Create a separate template notice NOTIFY_MANAGER

To separate the two feature we want to create a distinct template
notice.
A new NOTIFY_MANAGER notice is added.
A follow-up patch will be added for other languages, when this one will
be approved by QA.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:25 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-F73QdYqDZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101539|0                           |1
        is obsolete|                            |

--- Comment #129 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101604&action=edit
Bug 23590: Fix 'select manager' when creation a suggestion

On creating the TT var managedby_patron does not exist yet

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:30 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-JUsDBVdai1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101548|0                           |1
        is obsolete|                            |

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101605&action=edit
Bug 23590: DBIC Changes

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:56:36 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-eRQSG8D3rV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #131 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101606&action=edit
Bug 23590: (QA follow-up) Fix links to patron records (TT variable confusion)

Fixes links to the patron accounts from the edit and list view of
suggestions.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:59:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 14:59:29 +0000
Subject: [Koha-bugs] [Bug 24968] New: Add Syspref controls for cronjobs
Message-ID: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

            Bug ID: 24968
           Summary: Add Syspref controls for cronjobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

At the simplest it would be nice to have an on/off switch for any cronjob so
that libraries can disable cronjobs as needed (during emergency closings etc.)

At the most advanced, it could offer the option of controlling all of the
parameters for the cronjob, either using a syntax or a new administration area

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:01:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:01:14 +0000
Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
In-Reply-To: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24968-70-LMYbdRKn3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1
With mulitple instances on one server I'd really love that. Turning things off
for just one instance is painful otherwise if you are using for-each.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:09:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:09:22 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-AQozf084n2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:09:30 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-maeVC4gOm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101355|0                           |1
        is obsolete|                            |

--- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101607&action=edit
Bug 24185: Make holds page faster - improved "if"

`$can_item_be_reserved eq 'OK'` moved in `&&` before
`IsAvailableForItemLevelRequest`
to cut away with static known values before calling to more resource consuming
subroutine.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:10:26 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-GdHk1peAGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101356|0                           |1
        is obsolete|                            |

--- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101608&action=edit
Bug 24185: Make holds page faster - call to subroutine moved below "if"

`$on_shelf_holds` was assigned before "return .. if" but not used in that code
piece,
so sometimes it was useless. Moved assignment after "return .. if".

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:10:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:10:57 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-evBXL9IYfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101357|0                           |1
        is obsolete|                            |

--- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101609&action=edit
Bug 24185: Make holds page faster: preparatory refactoring

This is just refactoring. extracting logically independent code
to separate sub + tests update. No logic change yet.

Searching for "any_available" item among all biblionumber items was done
inside of "elsif on_shelf_holds == 2", and it is logically very independent
piece of code (this "@items" loop), it needs just biblionumber and patron
as parameters so it can be extracted into separate subroutine, and
later also called/reused from somewhere else.

This ability to call from another place also made for future patch
to remove O(n^2) problem with nested loops.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:15:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:15:22 +0000
Subject: [Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system
 preference to news block
In-Reply-To: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23797-70-oSvvVSIQf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:15:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:15:25 +0000
Subject: [Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system
 preference to news block
In-Reply-To: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23797-70-6Y7onlXh3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101610&action=edit
Bug 23797: Convert OpacLoginInstructions system preference to news block

This patch builds on Bug 22318 to move the OpacLoginInstructions system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the OpacLoginInstructions system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and click the login link.
 - In the login modal, confirm that the content which was previously in
   the OpacLoginInstructions system preference displays correctly
   below the login form.
 - While not logged in to the OPAC, navigate directly to
   /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should
   display correctly here as well.
 - In the staff client, go to Tools -> News and verify that the content
   from OpacLoginInstructions is now stored in news items. There
   should be one entry for each of the enabled translations in your
   system, for instance 'OpacLoginInstructions_en',
   'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   OpacLoginInstructions preference has been removed.
 - To test the correct selection of language-specific content you must
   run the translation update/install process for the languages you're
   updating.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:16:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:16:09 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-qOZTwvRXk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #26 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Rebased on current master with an obvious conflict because of Bug 24468.

Performance is really better, tested on my laptop :
100 items => 54 seconds without patch, 8 seconds with patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:16:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:16:17 +0000
Subject: [Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system
 preference to news block
In-Reply-To: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23798-70-75KO7uvHVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:17:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:17:01 +0000
Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
In-Reply-To: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24968-70-eptLZheEAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |, bwsdonna at gmail.com,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:17:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:17:47 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-qf2GDWrfSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #27 from Andrew Nugged <nugged at gmail.com> ---
oh, thanks for REBASE! In a case, if another assistance needed – I am
monitoring this actively.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:20:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:20:21 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-LRoSGPcgTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

e.betemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:21:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:21:33 +0000
Subject: [Koha-bugs] [Bug 14992] New options and clarification for authority
 search modes dropdown
In-Reply-To: <bug-14992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14992-70-91YqiudngN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Should be considered behavior with Elasticsearch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:24:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:24:22 +0000
Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is
 alphabetical
In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13976-70-qb0DCdUzbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I bet its solved with Elasticsearch. Can someone confirm ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:25:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:25:20 +0000
Subject: [Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error
In-Reply-To: <bug-24676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24676-70-grS489Tse5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:26:45 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-1u4EHnrXzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101358|0                           |1
        is obsolete|                            |

--- Comment #28 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101611&action=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'

When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.

It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.

Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.

This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.

How to reproduce:

1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,

2) add 100 items for that book for some library,

3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,

4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).

5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353

6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.

I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:

(old code):
  100 items:    50 seconds
  200 items:   3.2 minutes
  300 items:   7.3 minutes

(version with fix):
  100 items:   4.4 seconds
  200 items:   7.5 seconds
  300 items:  10.4 seconds

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:27:54 +0000
Subject: [Koha-bugs] [Bug 23755] Inventory.pl should have a texbox for
 direct barcode scanning
In-Reply-To: <bug-23755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23755-70-eucU5leptQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23755

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 23114 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:27:54 +0000
Subject: [Koha-bugs] [Bug 23114] Inventory: allow to scan barcodes
In-Reply-To: <bug-23114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23114-70-XIUKIDo2Tu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #7 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
*** Bug 23755 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:28:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:28:33 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-Vt5f0b8g8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #29 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Andrew Nugged from comment #27)
> oh, thanks for REBASE! In a case, if another assistance needed – I am
> monitoring this actively.

Your welcome, please check its OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:29:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:29:20 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-ZwQZks94YI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101612&action=edit
Bug 18177: Do not remove columns if at least one value exists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:30:13 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-ARw0HjJe4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Frank Hansen from comment #17)
> When we migrated from your previous ILS (Virtua), I kept some vendor contact
> information in booksellerfax, bookselleremail and currency. This means that
> we are will lose this information when you drop them from DB.

Thanks Frank for this feedback?
What about this last patch? We are going to remove the column only if there is
no data, otherwise a warning will be displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:30:45 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-cqi95o6uFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Frank Hansen from comment #17)
> When we migrated from your previous ILS (Virtua), I kept some vendor contact
> information in booksellerfax, bookselleremail and currency. This means that
> we are will lose this information when you drop them from DB.

Thanks Frank for this feedback!

What about this last patch? We are going to remove the column only if there is
no data, otherwise a warning will be displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:30:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:30:47 +0000
Subject: [Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and
 issues tables
In-Reply-To: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6271-70-emv8x2Tlua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Obsolete since Bug 17679 and Bug 17680

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:40:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:40:54 +0000
Subject: [Koha-bugs] [Bug 3642] New information in overdues CSV export
In-Reply-To: <bug-3642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3642-70-jNPgx4WMhi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I quit this bug, feel free to take it ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:47:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:47:43 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-ds4xVCzY97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:47:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:47:47 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-vPBxEsYNzo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101607|0                           |1
        is obsolete|                            |
 Attachment #101608|0                           |1
        is obsolete|                            |
 Attachment #101609|0                           |1
        is obsolete|                            |
 Attachment #101611|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101613&action=edit
Bug 24185: Make holds page faster - improved "if"

`$can_item_be_reserved eq 'OK'` moved in `&&` before
`IsAvailableForItemLevelRequest`
to cut away with static known values before calling to more resource consuming
subroutine.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:47:52 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-fAd0L7bQbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101614&action=edit
Bug 24185: Make holds page faster - call to subroutine moved below "if"

`$on_shelf_holds` was assigned before "return .. if" but not used in that code
piece,
so sometimes it was useless. Moved assignment after "return .. if".

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:47:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:47:57 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-wNiSTolRdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101615&action=edit
Bug 24185: Make holds page faster: preparatory refactoring

This is just refactoring. extracting logically independent code
to separate sub + tests update. No logic change yet.

Searching for "any_available" item among all biblionumber items was done
inside of "elsif on_shelf_holds == 2", and it is logically very independent
piece of code (this "@items" loop), it needs just biblionumber and patron
as parameters so it can be extracted into separate subroutine, and
later also called/reused from somewhere else.

This ability to call from another place also made for future patch
to remove O(n^2) problem with nested loops.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch, I moved up the last line of the test, sounds more logical
to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:48:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:48:01 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-NNPF5uX7DA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101616&action=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'

When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.

It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.

Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.

This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.

How to reproduce:

1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,

2) add 100 items for that book for some library,

3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,

4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).

5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353

6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.

I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:

(old code):
  100 items:    50 seconds
  200 items:   3.2 minutes
  300 items:   7.3 minutes

(version with fix):
  100 items:   4.4 seconds
  200 items:   7.5 seconds
  300 items:  10.4 seconds

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:48:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:48:35 +0000
Subject: [Koha-bugs] [Bug 24969] New: ILSDI allows cancellation of waiting
 holds
Message-ID: <bug-24969-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24969

            Bug ID: 24969
           Summary: ILSDI allows cancellation of waiting holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1 - Place a hold for a patron
2 - Checkin the item/confirm the hold to set it to waiting
3 - Enable ILSDI
4 - Cancel the hold via ILSDI
    item_id means the reserve_id
   
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=CancelHold&patron_id=5&item_id=193
5 - Successfully canceled

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:50:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:50:36 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-cOiBgl2fSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.04          |20.05.00, 19.11.04,
        released in|                            |19.05.09

--- Comment #24 from Lucas Gass <lucas at bywatersolutions.com> ---
Although this is a feature it is an important one to backport to older versions
at this time.

backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:50:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:50:51 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-84AMeeXcAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Katrin,
I think we should probably open a new report for some of the inconsistencies
between the various acquisitions routes and the use of the ACQ framework.

It is rather trivial to pass the frameworkcode parameter of acqui/z3950_search
to FillWithDefaults to overrule ACQ. But are we bitten later on by the
preference UseACQFrameworkForBiblioRecords ? The code in Acquisition is not
completely clear as to that preference?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:55:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:55:08 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-YZd1lxymVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #24)
> Katrin,
> I think we should probably open a new report for some of the inconsistencies
> between the various acquisitions routes and the use of the ACQ framework.
> 
> It is rather trivial to pass the frameworkcode parameter of
> acqui/z3950_search to FillWithDefaults to overrule ACQ. But are we bitten
> later on by the preference UseACQFrameworkForBiblioRecords ? The code in
> Acquisition is not completely clear as to that preference?

Hi Marcel, certainly a new bug. The handling of frameworks (ACQ vs the one
selected on import) is not very clear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:59:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 15:59:42 +0000
Subject: [Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system
 preference to news block
In-Reply-To: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23798-70-iGZTPUIyJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Reconsidered this: Since it's tied to the OpacMaintenance system preference
it's probably better to leave it be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:02:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:02:13 +0000
Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items
In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24023-70-YXmzWWg8SM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |bwsdonna at gmail.com

--- Comment #6 from Donna <bwsdonna at gmail.com> ---
Test plan fails at step 10.  Deleting a 774 field has the following impact:
a) the materials specified in the top level bib is removed
b) items are still showing as attached in the 774, but the individual item
records no longer show the withdrawn status and are instead showing as
available.

If you continue with the test plan and check out the item from step 1, none of
the attached items show as checked out, and upon checking in the item from step
one, no list of titles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:03:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:03:04 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-KEnrLwSBg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:08:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:08:41 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-h3kjSkpxSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101481|0                           |1
        is obsolete|                            |
 Attachment #101482|0                           |1
        is obsolete|                            |
 Attachment #101483|0                           |1
        is obsolete|                            |
 Attachment #101484|0                           |1
        is obsolete|                            |
 Attachment #101485|0                           |1
        is obsolete|                            |
 Attachment #101486|0                           |1
        is obsolete|                            |
 Attachment #101487|0                           |1
        is obsolete|                            |
 Attachment #101488|0                           |1
        is obsolete|                            |

--- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101617&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:08:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:08:46 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-dc9t9lONMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101618&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:08:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:08:52 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-0uGwXWheCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101619&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:08:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:08:57 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-S66SctPpTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101620&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:09:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:09:03 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-Pn0oeg7zfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101621&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david at davidnind.com>

Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:09:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:09:09 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-N2ifXKroGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101622&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:09:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:09:15 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-cUTgcdm7ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101623&action=edit
Bug 22844: DBIC Schema changes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:09:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:09:20 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-p3FSWzKRtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101624&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:12:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:12:00 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-dmRYrhKtKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97328|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101625&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:12:03 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-ki0D9oMJXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97329|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101626&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:12:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:12:06 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-UZr7tIvgMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97330|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101627&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:18:35 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-IsgiJFFci1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Switching this back to PQA, but I have the feeling that we are missing
something.
Regarding the commit message from patch "Bug 22844: Make the attribute
mandatory when editing a patron", there are still some stuffs missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:23:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:23:42 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-qR6lLxe997@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101625|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101628&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:23:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:23:45 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-VEAiUBhYhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101626|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101629&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:23:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:23:49 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-jA4WIVAH3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101627|0                           |1
        is obsolete|                            |

--- Comment #9 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101630&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:25:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:25:14 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-6mRLuDt0V7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:28:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:28:31 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-chKe3tWe69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101631&action=edit
Bug 21443: (RM follow-up) Fix failing tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:29:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:29:32 +0000
Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when
 calculating rentals fees by time period
In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21443-70-kFtDMqIRO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:37:28 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-OtEGwOns4f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:37:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:37:30 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-j7EtZlhWq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101559|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101632&action=edit
Bug 24966: Fix calls to maybe_add where method call does not return a value

For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.

One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.

What is actually received is: 'CY', and a SIPServer object.

We ingest the parameters like so:
--
sub maybe_add {
    my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!

This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324    063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'
--

Test Plan:
1) On master, perform a checkin of an item not on hold using the sip cli tester
2) Note some fields contain something like 'C4::SIP::SIPServer=HASH(0x1ea0e58)'
3) Apply this patch
4) Restart the SIP server
5) Perform the SIP checkin again
6) Those fields from step 2 should be gone!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Barbara Johnson <Barbara.Johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:43:21 +0000
Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-ZDjPALIP5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101633&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:43:24 +0000
Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-FPZptmIiO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101634&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:43:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:43:26 +0000
Subject: [Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system
 preference to news block
In-Reply-To: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23798-70-L87tidJcrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, not sure - but I think the need for multi-lingual is valid for this one as
well. When you need to turn the catalog off, it's good to let everyone know :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:44:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:44:04 +0000
Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-d1X19XeSo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
 Attachment #101633|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Comment on attachment 101633
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101633
Bug 24886: Reindent reports template

Sorry, wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:44:48 +0000
Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24866-70-GDLeJyTiFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101634|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Comment on attachment 101634
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101634
Bug 24886: (follow-up) Add markup comments

wrong bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:46:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:46:12 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-nOhzo4BlkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101493|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101635&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:46:16 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-Megtos8CNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101494|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101636&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:46:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:46:33 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-MFXuHhmvWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:57:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:57:54 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-fCu2LoI83J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100652|0                           |1
        is obsolete|                            |
 Attachment #100653|0                           |1
        is obsolete|                            |
 Attachment #100654|0                           |1
        is obsolete|                            |
 Attachment #100655|0                           |1
        is obsolete|                            |
 Attachment #100656|0                           |1
        is obsolete|                            |
 Attachment #100657|0                           |1
        is obsolete|                            |
 Attachment #100658|0                           |1
        is obsolete|                            |
 Attachment #100659|0                           |1
        is obsolete|                            |
 Attachment #100660|0                           |1
        is obsolete|                            |
 Attachment #100661|0                           |1
        is obsolete|                            |
 Attachment #100662|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101637&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-1SxXnDFGRe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101638&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:09 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-WhqrpV015P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101639&action=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-sWcbOpq6tb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101640&action=edit
Bug 24857: Add Koha Object(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:17 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-0ry7j6D64j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101641&action=edit
Bug 24857: Add Object Methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:21 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Fr6sZfDzBO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101642&action=edit
Bug 24857: API spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:24 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-baWPJkKEqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101643&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:28 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-uodw198DLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101644&action=edit
Bug 24857: Implement volume related controllers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-xqURDcxf38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101645&action=edit
Bug 24857: Add volume management to detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-e2tyxmWDda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101646&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-oXgYEnQlhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101647&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 16:58:44 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-OlQFjiKVkB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101648&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:02:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 17:02:35 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-eUnhJVX6P8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> (In reply to Frank Hansen from comment #17)
> > When we migrated from your previous ILS (Virtua), I kept some vendor contact
> > information in booksellerfax, bookselleremail and currency. This means that
> > we are will lose this information when you drop them from DB.
> 
> Thanks Frank for this feedback!
> 
> What about this last patch? We are going to remove the column only if there
> is no data, otherwise a warning will be displayed.

Maybe we can give some advise for migrating that data?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:02:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 17:02:41 +0000
Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more
 than one item from bib on hold
In-Reply-To: <bug-24612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24612-70-XCdceE91v8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #8 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I've tested and I can't get the patch to solve the problem.

This is what I did:  

TEST PLAN:

1.  Add some content to HOLD_SLIP notice, e.g.

<h2>[% branch.branchname %]</h2>
<div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %]
<ul><li> Reserve ID:  [% hold.reserve_id %]</li>
<li>Expiration date: [% hold.expirationdate %]</li></ul>

2.  Add 2 holds for 1 patron to a single record
3.  Check the reserve IDs in the reserves table - on a clean sandbox, they will
be 1 and 2 
4.  Check in one of the items from the record and print the slip
5.  Note that the reserve ID on the slip is 2 and the expiration date is blank
6.  Repeated check ins do not change this
7.  Check in a second item from the record
8.  Note that the reserve ID for this hold is also 2, but this time the
expiration date is filled in
9.  Check in the first item again - the reserve ID stays as 2, but this time
the expiration date is filled in

I repeated this several times, and the odd numbered holds (1, 3, 5, 7 etc)
never appear - but the even ones appear for all items (2, 4, 6, 8).  

I set the bug as Failed QA because it doesn't seem to solve the problem - is
that the correct status?  Or should I have chosen Patch Doesn't Apply?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:13:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 17:13:04 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-1gMnrsxEV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hello Simon,

This development moves the system preference to the circulation rules, for more
granularity.

On the circulation rules you should see a new column "Days mode" with 5
different options.

In your case, I think what you need is:
Set the syspref to "Push the due date to next open day"
Define a circulation rule for Hourly loan and select "Ignore the Calendar" in
the "Days mode" column.

Note that there is a small cosmetic bug on the circulation table, the header of
the table says "Unit" instead of "Days mode". The footer is correct but there
is a shift in the header.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:13:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 17:13:59 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-PqU6PS1Pho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101649&action=edit
Bug 24159: Fix shift in the header

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:17:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 17:17:38 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-yD78o5YYi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Talked with Katrin.
We may want to preselect the new dropdown list to the value of the
invoiceprice's vendor. But that would be for a follow-up bug anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 19:17:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 18:17:51 +0000
Subject: [Koha-bugs] [Bug 22707] Allow manual definition of AutoMemberNum
 range
In-Reply-To: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22707-70-JnqdqChOwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22707

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:26 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-usKjg3quhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101637|0                           |1
        is obsolete|                            |
 Attachment #101638|0                           |1
        is obsolete|                            |
 Attachment #101639|0                           |1
        is obsolete|                            |
 Attachment #101640|0                           |1
        is obsolete|                            |
 Attachment #101641|0                           |1
        is obsolete|                            |
 Attachment #101642|0                           |1
        is obsolete|                            |
 Attachment #101643|0                           |1
        is obsolete|                            |
 Attachment #101644|0                           |1
        is obsolete|                            |
 Attachment #101645|0                           |1
        is obsolete|                            |
 Attachment #101646|0                           |1
        is obsolete|                            |
 Attachment #101647|0                           |1
        is obsolete|                            |
 Attachment #101648|0                           |1
        is obsolete|                            |

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101650&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:36 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-R0yorIdnA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101651&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:40 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ijrWgcprT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101652&action=edit
Bug 24857: Add Koha Object(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:43 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-xWQgjnhQPe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101653&action=edit
Bug 24857: Add Object Methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:47 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-HtajKkk0I4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101654&action=edit
Bug 24857: API spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:50 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Vs5LkFcstM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101655&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:54 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-clJLrTFkMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101656&action=edit
Bug 24857: Implement volume related controllers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:01:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:01:57 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-TJgkBkpPBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101657&action=edit
Bug 24857: Add volume management to detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:02:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:02:00 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-QHb8TyjAg7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101658&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:02:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:02:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-MDdipukVJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101659&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:02:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:02:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-hP3axE2UJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101660&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:02:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:02:10 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-6QKszhfVXb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101661&action=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:09:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:09:34 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-0XG2mb4gHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Excellent work, thanks everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:22:20 +0000
Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a
 non-existing date
In-Reply-To: <bug-7806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7806-70-RB9Ftf5r9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've recently spotted a fair few errors during upgrades where we have these bad
dates.. I'll try to draw up a list of where I've seen it.. versions being
upgraded and tables affected etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:26:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:26:20 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-GUcychdY5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |koha at univ-lyon3.fr

--- Comment #57 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
I've tested following the test plan and I added a case when a items is in
transit (T status in reserves table) for an hold.
When you are in the first table in the deletion items tool, there's the column
called "holds" where you can see :
1/1 : if there's an item-level-hold on this item OR if the item is waiting to
serve a hold OR the item is in transit to serve a hold
0/1 : if there's a biblio-level-hold but that this item isn't waiting or in
transit for this hold
0 : if there's no hold

It's not a really clear notation, but I have nothing better to offer..

In this table, you can't tick nor the items with the waiting or transit status
nor the one where is a biblio-level-hold but only one item on this biblio.

When you confirm the deletion, you have an alert for the case of the
biblio-level-hold with 2 items that were selected for deletion : "Last item for
bibliographic record wich biblio-level hold on it" and another message saying
"At least one item blocked the deletion. The operation rolled back and nothing
happened! "
So the deletion is cancelled for all the items selected.

It works as described in the test plan but, for me, it isn't consistent to
block the deletion of an item because there's a biblio-level-hold on it but not
block the deletion of an item with a item-level-hold on it.

Could we not prevent to tick all the 1/1 case in the first table in addition of
what exists already?

I must admit that I haven't read all the comments above but I can't see a good
reason to allow deletion of item with an item-level-hold if you don't allow the
deletion of a biblio-level-hold.

I hope that my explanations are clear..

Sonia BOUIS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:29:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:29:16 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-f4hh48Iitk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:29:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 19:29:20 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-GxOVU5dS6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101562|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101662&action=edit
Bug 20399: Remove "did you mean" for the staff interface

The amdin page for the "did you mean" feature has two block for setting it up
in the staff interface, and a note saying this isn't implemented on the staff
interface yet.
We remove the part about the staff interface until it actually is implemented.

Test plan :
1) Apply patch
2) Go to Administration > Did you mean?
3) See there is only the OPAC block
4) Change some checkboxes
5) Save configuration
6) Check that configuration is saved

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Save works, syspref removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:35:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 20:35:27 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-2saLGLF0xT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101433|0                           |1
        is obsolete|                            |

--- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101663&action=edit
Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method

In order to remove UseKohaPlugins syspref, adds to Koha Template Toolkit
plugin a method ArePluginsEnabled().

Test plan:
1) Set syspref UseKohaPlugins enabled
2) Set config enable_plugins=1
3) Check you see "Tool plugins" in "Tools" home page and menu
4) Check you see "Manage plugins" in "Koha administration" home page
5) Check you see "Report plugins" in "Reports" home page and menu
6) Set config enable_plugins=0
7) Check you don't see in 3) 4) 5)
8) Run prove t/Koha_Template_Plugin_Koha.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:35:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 20:35:32 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-J1B8Tr99tO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101434|0                           |1
        is obsolete|                            |

--- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 101664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101664&action=edit
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already
multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use
of plugins.
>>

Test plan :
1) Install kitchen sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:36:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 20:36:06 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-nasQPhKKQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:25:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 21:25:16 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-MwYsaGngEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24745


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745
[Bug 24745] OPAC news block plugin should evaluate as false if there are no
items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:25:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2020 21:25:16 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-KkZBXzZZZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24223


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
[Bug 24223] Convert OpacNav system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 03:04:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 02:04:44 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-ZwIE30rNGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100993|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101665&action=edit
Bug 24900: Some fixes to how MARC modification template actions work

CASE 1: Delete field 020 if field 020$z exists
BROKEN BEHAVIOUR (before patch): 020$z field was deleted, even though we
                                 wanted all 020 fields to be deleted
EXPECTED BEHAVIOUR (corrected by patch): all 020 fields are deleted

CASE 2: Delete 1st field 020 if 651$z exists
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
                                 of 1st
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 3: Delete 1st field 020 if 020$z exists
BROKEN BEHAVIOUR (before patch): deletes the 3rd instance of 020 which
                                 contains subfield z
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 4: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 5: Delete 1st field 020 if 020$z matches 9781460708385
BROKEN BEHAVIOUR (before patch): deletes the 3rd instance of 020 which
                                 contains subfield z
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 06:00:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 05:00:20 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-VP5b70c4BH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 06:00:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 05:00:23 +0000
Subject: [Koha-bugs] [Bug 24900] 'MARC modification templates' does not
 delete all fields if there is a condition in template
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-8gY34FVepI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101665|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101666&action=edit
Bug 24900: Checks in MARC mod templates for when from field does not equal
conditional field

When MARC modification template actions are applied, they assume that
the from field is the same as the conditional field. This patch adds
checks for this, as well as tests to confirm the behaviour is correct.

CASE 1: Delete 1st field 020 if 651$z exists
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
                                 of 1st
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 3: Delete field 020 if 650$2 does not match fast
BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though
                                 650$2 does match fast
EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields

Confirm tests pass: t/db_dependent/MarcModificationTemplates.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 06:01:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 05:01:33 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-C8LFaTHk9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|'MARC modification          |Fix 'MARC modification
                   |templates' does not delete  |templates' to not assume
                   |all fields if there is a    |that 'from field' will
                   |condition in template       |match 'conditional field'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 08:06:00 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-ExTcY63t7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101667&action=edit
Bug 21800: (RM follow-up) Fix unit tests

We were not setting the repeatable flag for the default framework in the
Item2Marc tests and we also needed to flush the cash to get our
framework changes to be recognised.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:06:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 08:06:19 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-nXAe8xjY8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:33:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 08:33:43 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-wnEL257vui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #22 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Jonathan Druart from comment #20)
> (In reply to Frank Hansen from comment #17)
> > When we migrated from your previous ILS (Virtua), I kept some vendor contact
> > information in booksellerfax, bookselleremail and currency. This means that
> > we are will lose this information when you drop them from DB.
> 
> Thanks Frank for this feedback!
> 
> What about this last patch? We are going to remove the column only if there
> is no data, otherwise a warning will be displayed.

Yes, this will at least keep the data in those columns so they're not getting
lost. But is the plan to remove those fields completely from UI as well? If
that is the case, we have no use for them. We can probably live without those
columns anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:54:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 08:54:56 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-PpLYtwtHoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Unused should not be in the GUI - if they are, we might need to keep some!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:00:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:00:10 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-wHPnrwMbFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #11 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Ah brilliant, thanks for letting me know, Katrin!  :)

I've updated the status to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:22:53 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-mOf9FSHLTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
They are not displayed (view or edit) anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:18 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-wTChMmngja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:20 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-qtQqVuflYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:22 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-omHf1hSiRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:25 +0000
Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not
 considerate second indicator of field 245 (marc21)
In-Reply-To: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22771-70-czGig63ejL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:27 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-isIDOPWIYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:29 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-JW4ki3O3Qs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #132 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:31 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-oaYh2n3S01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:33 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-KnGzOCpEcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:34 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-hjxyonhgFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:36 +0000
Subject: [Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as
 false if there are no items
In-Reply-To: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24745-70-fc4JmOUaMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:38 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-WCmmlEoPOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 09:43:40 +0000
Subject: [Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
In-Reply-To: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24754-70-jNHSpkxKJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:00:19 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-uZXTJ22wIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #25 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Jonathan Druart from comment #24)
> They are not displayed (view or edit) anywhere.

When I dig a little deeper into how we migrated, it turned out that we copied
the same value to multiple columns. For example, currency is the same as
invoiceprice; booksellerfax is the same as fax; and bookselleremail was also
inserted in aqcontacts.email. So this means that we will not lose any data at
all. The columns othersupplier and booksellerurl is not used here at Lund
University.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:07:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:07:20 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-ijiFd8GKq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:31:19 +0000
Subject: [Koha-bugs] [Bug 24964] Remove pagination when searching for
 patrons with permissions
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-xi0UC07t9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:31:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:31:22 +0000
Subject: [Koha-bugs] [Bug 24964] Remove pagination when searching for
 patrons with permissions
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-3lATeTXLMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101668&action=edit
Bug 24964: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:31:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:31:25 +0000
Subject: [Koha-bugs] [Bug 24964] Remove pagination when searching for
 patrons with permissions
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-BZ6LOIwHo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101669&action=edit
Bug 24964: Do not filter patrons after they have been fetched

The svc/members/search script is called in different places.
In some places (Set owner for a fund, add users to a fund, or set a
manager to a suggestion), we need patrons to be filtered depending on
the permissions they have.
For instance you can only set a fund's owner with a patron that has
acquisition.order_manage.

Currently we have fetching X (default 20) patrons, then filter them
depending on their permission.
Says you have 3 patrons that have the correct permissions but are not in
the 20 first patrons, if you do not define a search term, the search
result will be empty.

This is not ideal and we should filter when requesting the DB.

Test plan:
- Have more than 20 patrons, remove them their permissions
- Create 3 more:
1 superlibrarian
1 with the full acq permission
1 with acquisition.order_manage
- Create a fund and set a owner
- Search for patrons, without specifying a search term (to get them all)
=> Without this patch the new patrons you created are not displayed
=> With this patch they are!

Same test plan apply to set a manager to a suggestion (freshly pushed,
see bug 23590), with suggestions and suggestions.suggestions_manage

Note: The code has been written that way to rely on
C4::Auth::haspermission, but the SQL query is quite trivial and the gain
is important.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:31:55 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-zLd8ucTvBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove pagination when      |Do not filter patrons AFTER
                   |searching for patrons with  |they have been fetched from
                   |permissions                 |the DB (when searching with
                   |                            |permissions)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:32:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:32:00 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-Fz9naSwtl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:33:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:33:10 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-AdRizMsPpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Laurence Rault <laurence.rault at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurence.rault at biblibre.com
             Status|Signed Off                  |Patch doesn't apply

--- Comment #9 from Laurence Rault <laurence.rault at biblibre.com> ---
When testing on sandbox : 
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:36:31 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-JwPLUAmUMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7804


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804
[Bug 7804] Add Koha Plugin System
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:36:31 +0000
Subject: [Koha-bugs] [Bug 7804] Add Koha Plugin System
In-Reply-To: <bug-7804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7804-70-hCd479pqQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20415


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415
[Bug 20415] Remove UseKohaPlugins system preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:42:13 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-aeiSRD1nRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:42:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:42:24 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-H7n1T9yglI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:42:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:42:34 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-b30rv6ridI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:45:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:45:57 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-cyx1jwAZkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have a patch that is enhancing greatly this script. By any chances could base
yours on top of it?

See bug 24153.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:46:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:46:26 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-U60fsEgeop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #5)
> I have a patch that is enhancing greatly this script. By any chances could
> base yours on top of it?
> 
> See bug 24153.

Nevermind, I will do it later.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:46:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 10:46:40 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-Gc29t5PFun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:01:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:01:52 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-ZKYcWnIqbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lucas, that will not work for all places where patron-title.inc is used,
because of the no_html flag.
Not against the approach but, because of the above, I am wondering if this
really answer the need.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:01:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:01:58 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-3VUksX4eA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101650|0                           |1
        is obsolete|                            |
 Attachment #101651|0                           |1
        is obsolete|                            |
 Attachment #101652|0                           |1
        is obsolete|                            |
 Attachment #101653|0                           |1
        is obsolete|                            |
 Attachment #101654|0                           |1
        is obsolete|                            |
 Attachment #101655|0                           |1
        is obsolete|                            |
 Attachment #101656|0                           |1
        is obsolete|                            |
 Attachment #101657|0                           |1
        is obsolete|                            |
 Attachment #101658|0                           |1
        is obsolete|                            |
 Attachment #101659|0                           |1
        is obsolete|                            |
 Attachment #101660|0                           |1
        is obsolete|                            |
 Attachment #101661|0                           |1
        is obsolete|                            |

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101670&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:08 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-9zdXcs9QTv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101671&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:11 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-PGvQBQdJNK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101672&action=edit
Bug 24857: Add Koha Object(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-YafApCIcyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101673&action=edit
Bug 24857: Add Object Methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:18 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ojyxBh8IPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101674&action=edit
Bug 24857: API spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:21 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-32u23W2mL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101675&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:25 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-1u52ujmhWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101676&action=edit
Bug 24857: Implement volume related controllers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:28 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-UvHO6154xi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101677&action=edit
Bug 24857: Add volume management to detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:31 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-wqbiLBkC6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101678&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:34 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-1ZkX7c33EI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101679&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-C5h1mAtcnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101680&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:02:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:02:40 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-y0V6U7ztjy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101681&action=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:05:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:05:04 +0000
Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span
 classes for firstname, othername, surname
In-Reply-To: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24710-70-NouysiDXQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This include file is getting too complex. We should move that the logic to a
module.

I am not asking that for now, but that needs to be taken into account for
future changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:14:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:14:17 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-HqtiOnTuOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Generally, this patch appears to work as expected so I'll sign it off.

However, I have some feedback:
1/ I'd like to see the whole 'Desks' functionality behind a system preference
so libraries not interested in using the feature don't see it.
2/ If there are not desks defined for the logged-in library then a trailing `|`
is left in the header menu
3/ Should you not be able to set a Desk from the Login screen?
4/ Jury is out regarding adding the Desk into the header bar menu title.. I
like that it's immediately obvious, but for narrow screens, this could cause
issues?

Copying in a few more people to get opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:14:29 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-u0hQcUGk9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:14:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:14:46 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-fzrjOaxY7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:14:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:14:50 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-m1D1zLu9VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99766|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101682&action=edit
Bug 24158: Convert actual cost in an other currency when receiving

This patch adds a currency dropdown list to the Actual cost field when
receiving items in the acquisition module.
The idea is to let the librarian entered a price in a foreign currency
that will automatically be converted in the local currency ('active').
This converted value will be use as the actual cost once the form is
submitted.

Test plan:
- Create several currencies with different rates
- Create an order, close the basket and receive
- On the receipt page you will notice a new "change currency" checkbox
right close to the 'Actual cost' input.
- Check it
=> The 'Actual cost' input is readonly and a new line appears at the
bottom.
- Enter a number and select a currency
=> The 'Actual cost' input is automatically filled with the converted
value
- Save
=> The converted Actual cost has been inserted in the database.

Sponsored-by: Athlone Institute of Technology

Signed-off-by: Devinim <nazli at devinim.com.tr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:14:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:14:53 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-kO9X1vZUqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101402|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101683&action=edit
Bug 24158: Add missing html filters

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:15:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:15:54 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-NbveaEDuP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101564|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101684&action=edit
Bug 24201: Attach desk to intranet session

When Desks are defined, a librarian can attach a desk to its session.

Test plan:

1. apply 13881 and create some desks
2. you should see “NO DESK SET” in the intranet header
3. go to circulation > Set desk
4. you should see your desk name in the header, whatever the page
5. you can also set desk with the header menu

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:29:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:29:28 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24157-70-nnPsckhEv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup looks good to me.. Setting to signedoff :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:32:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:32:29 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-NFmmf42Wyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #115 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101685&action=edit
Bug 23355: (RM follow-up) Make DB update idempotent

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:34:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:34:33 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-8gC9HHxeut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #9 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Martin Renvoize from comment #7)
> Generally, this patch appears to work as expected so I'll sign it off.
> 
> However, I have some feedback:

Thank you!

> 1/ I'd like to see the whole 'Desks' functionality behind a system
> preference so libraries not interested in using the feature don't see it.

I thought about not adding another syspref. If there is no desk defined it
should not be seen apart from the links “desks” in admin home page and menu. If
it's too much anyway I can surely add a syspref.

> 2/ If there are not desks defined for the logged-in library then a trailing
> `|` is left in the header menu

Oups, that should not happen, I'll fix it.

> 3/ Should you not be able to set a Desk from the Login screen?

Sure, but I wasn't sure how to do it, because it's necessary to change the desk
menu when switching libraries, and I wasn't sure how to do it. I better liked
the idea to attach IP addresses to a desk to automatically set a desk at
logged-in.

> 4/ Jury is out regarding adding the Desk into the header bar menu title.. I
> like that it's immediately obvious, but for narrow screens, this could cause
> issues?

Ho, I'm terrible at web things. We are used to this display, but we certainly
will conform to what suits best the community.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:37:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:37:03 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-lxmqxOlLTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101669|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101686&action=edit
Bug 24964: Do not filter patrons after they have been fetched

The svc/members/search script is called in different places.
In some places (Set owner for a fund, add users to a fund, or set a
manager to a suggestion), we need patrons to be filtered depending on
the permissions they have.
For instance you can only set a fund's owner with a patron that has
acquisition.order_manage.

Currently we have fetching X (default 20) patrons, then filter them
depending on their permission.
Says you have 3 patrons that have the correct permissions but are not in
the 20 first patrons, if you do not define a search term, the search
result will be empty.

This is not ideal and we should filter when requesting the DB.

Test plan:
- Have more than 20 patrons, remove them their permissions
- Create 3 more:
1 superlibrarian
1 with the full acq permission
1 with acquisition.order_manage
- Create a fund and set a owner
- Search for patrons, without specifying a search term (to get them all)
=> Without this patch the new patrons you created are not displayed
=> With this patch they are!

Same test plan apply to set a manager to a suggestion (freshly pushed,
see bug 23590), with suggestions and suggestions.suggestions_manage

Note: The code has been written that way to rely on
C4::Auth::haspermission, but the SQL query is quite trivial and the gain
is important.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:39:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:39:08 +0000
Subject: [Koha-bugs] [Bug 24842] Automatic serials missing list feeding does
 not work when the numbering sequence includes regexp specific characters
In-Reply-To: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24842-70-3gVu9QhuDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
 Attachment #100635|0                           |1
           is patch|                            |
 Attachment #100635|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:38 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-MD3HcbMZw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100868|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101687&action=edit
Bug 18177: remove aqbooksellers.othersupplier

This patchset removes some columns from the aqbooksellers table that are
not used:
 * booksellerfax
 * booksellerurl
 * bookselleremail
 * othersupplier
 * currency

The first 3 ones are certainly leftover from bug 10402.

Test plan:
For each for these fields you will make sure that they cannot be edited
from the interface.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:42 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-EMb37BiLb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100869|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101688&action=edit
Bug 18177: remove aqbooksellers.booksellerfax

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:45 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-cuwtUc8FER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100870|0                           |1
        is obsolete|                            |

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101689&action=edit
Bug 18177: remove aqbooksellers.booksellerurl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:48 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-pcYvgcCqye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100871|0                           |1
        is obsolete|                            |

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101690&action=edit
Bug 18177: remove aqbooksellers.bookselleremail

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:51 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-HFmz0VLrG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100872|0                           |1
        is obsolete|                            |

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101691&action=edit
Bug 18177: remove aqbooksellers.currency

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:54 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-gyPVAUqLYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100873|0                           |1
        is obsolete|                            |

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101692&action=edit
Bug 18177: DB changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:40:57 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-IIIhePFGWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100874|0                           |1
        is obsolete|                            |

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101693&action=edit
Bug 18177: DBIC changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:41:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:41:00 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-jMew9mhsDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101612|0                           |1
        is obsolete|                            |

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101694&action=edit
Bug 18177: Do not remove columns if at least one value exists

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:43:48 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-UTZzNSPy9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks like I overlapped with incoming comments.. really pleased to see this
cleanup being done.

I've signed off as the patches all do as intended and I'm happy to agree that
these fields have not been used in the codebase for some time.  The final patch
is nice to have in cases where people have migrated data as a 'just in case'.. 

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:45:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:45:34 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a
 suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-OgBv4iroCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #133 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101695&action=edit
Bug 23590: Add notice template for translated installer files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:50:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:50:25 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-s9EZFx6E0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
About IP adresses: I am not sure if that will always work. What if you have a
hosted Koha but you only got one outgoing IP address instead of individual by
workstation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:54:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 11:54:29 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-cl0vb0jYZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:00:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:00:55 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-X8cMTxg2vi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Nicolas Legrand from comment #9)

> I thought about not adding another syspref. If there is no desk defined it
> should not be seen apart from the links “desks” in admin home page and menu.

I think this mostly works. The goal of the system preferences is to prevent
confusion from users about options they have which aren't relevant. In that
sense this works as it should. The only problem I see right now is that the
page is still accessible. It's still possible to navigate to
/circ/selectdesk.pl and have no options. I would consider that a minor issue
though.

> > 3/ Should you not be able to set a Desk from the Login screen?

I agree, this would be a logical and useful finishing touch. My idea of how
this feature is useful is with libraries where there are multiple desks in one
location and it's necessary to distinguish between them. In that situation the
user wouldn't be using the change library option at all.

> > but for narrow screens, this could cause issues?

I think it's logical to display the desk if it is set. We can adjust the
responsive behavior of the menu as a whole if necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:02:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:02:16 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-t3fPWQOafQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
In test :
+    is_deeply(
+        [ map { $_->{borrowernumber} } @{ $search_results->{patrons} } ],
+        [
+            $superlibrarian->borrowernumber,
+            $librarian_with_full_permission->borrowernumber,
+            $librarian_with_subpermission->borrowernumber
+        ],
+        'We got the 3 patrons we expected'
+    );

I get an error because $search_results->{patrons} may not be ordered like
expected array.
Test is OK when adding sort on both arrays.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:09:27 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-KgmJ9KQF8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #116 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #115)
> Created attachment 101685 [details] [review]
> Bug 23355: (RM follow-up) Make DB update idempotent
> 
> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

We use if ( !TableExists() )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:10:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:10:38 +0000
Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
In-Reply-To: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24968-70-P5h7FJO4ot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:10:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:10:46 +0000
Subject: [Koha-bugs] [Bug 23795] Convert OpacCredits system preference to
 news block
In-Reply-To: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23795-70-htIIQDwayc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101581|0                           |1
        is obsolete|                            |

--- Comment #4 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101696&action=edit
Bug 23795: Convert opaccredits system preference to news block

This patch builds on Bug 22318 to move the opaccredits system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the opaccredits system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and confirm that the content which was previously in
   the opaccredits system preference now displays correctly where
   it was before.
 - In the staff client, go to Tools -> News and verify that the content
   from opaccredits is now stored in news items. There should be
   one entry for each of the enabled translations in your system, for
   instance 'opaccredits_en', 'opaccredits_fr-FR',
   'opaccredits_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   opaccredits preference has been removed.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:11:48 +0000
Subject: [Koha-bugs] [Bug 24971] New: Select invoice currency from vendor on
 receive
Message-ID: <bug-24971-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971

            Bug ID: 24971
           Summary: Select invoice currency from vendor on receive
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24158

With the new feature from bug 24158 you can enter the price of the items you
receive in a different currency than your active one. At the moment, the
currency pull down preselects the active currency.

I think it would be a nice enhancement to select it to the currency from the
vendor for 'invoice prices'. 

At the moment, it appears this setting has no effect, but this way it would
have a useful purpose.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158
[Bug 24158] Receive items in multiple currencies
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:11:48 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-UQp7EA8VP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24971


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971
[Bug 24971] Select invoice currency from vendor on receive
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:12:49 +0000
Subject: [Koha-bugs] [Bug 21800] TransformKohaToMarc should respect
 non-repeatability of item subfields
In-Reply-To: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21800-70-xV1UmpmlIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thx for following up, Martin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:14:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:14:32 +0000
Subject: [Koha-bugs] [Bug 7972] GUI for Crons
In-Reply-To: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7972-70-eeDjsdr3tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:14:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:14:35 +0000
Subject: [Koha-bugs] [Bug 24972] New: Remove de-DE installer data
Message-ID: <bug-24972-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972

            Bug ID: 24972
           Summary: Remove de-DE installer data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: bgkriegel at gmail.com, gmcharlt at gmail.com,
                    testopia at bugs.koha-community.org
        Depends on: 24871

+++ This bug was initially created as a clone of Bug #24897 +++

Now we can translate all installer data, then the de-DE directory is no longer
needed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871
[Bug 24871] Add new *-installer-*.po translation files
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:14:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:14:35 +0000
Subject: [Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
In-Reply-To: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24871-70-IQ3Py3Ehrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24972


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972
[Bug 24972] Remove de-DE installer data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:16:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:16:11 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-DUtmVnQIKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #13)
> Did not we display old issues prior to this patch?

Yes indeed, C4::Circulation::GetBiblioIssues() makes issues UNION old_issues.

This is not the purpose of this patch, but isn't it a performance killer ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:17:32 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-7Q8jsVBRxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:17:35 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-gupKrwFyyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101697&action=edit
Bug 24201: (follow-up) Show desk information at lower screen widths

The staff client header menu adjusts responsively to narrower viewport
widths, but for the logged-in-user menu this requires showing and hiding
part of the template which duplicates information. This patch adds a
copy of the current desk information to the part of the template shown
at narrower widths.

To test, apply the patch and view any page in the staff client.

 - Narrow your browser so that the viewport is less than 800px wide.
 - The logged-in-user menu should change from text to a single "user"
   icon.
 - Clicking the icon should display a menu which includes labeled
   information about the current desk.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:18:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:18:00 +0000
Subject: [Koha-bugs] [Bug 24973] New: Allow to localize and translate system
 preferences with new yaml based installer
Message-ID: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

            Bug ID: 24973
           Summary: Allow to localize and translate system preferences
                    with new yaml based installer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
            Blocks: 24972

In the de-DE installer a sysprefs.sql file is used to make some changes to the
system preferences for a smoother installation experience. The file can be
found here:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/de-DE/mandatory/system_preferences.sql;h=2692f02b02da9100630a92c4f89fe7caba8ac786;hb=7ce4122131a6c3d7f0fe7c953dc95fd5d831bf7f

It's a mix of:
- Translating prefs content (HTML prefs, they might go away to news sometime)
- Localization settings (date format, currency format, time format)
- Translating pref options (borrower titles and relationships)

It would be great if there was a way to keep this kind of modifications when
switching to the new yaml based installer files.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972
[Bug 24972] Remove de-DE installer data
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:18:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:18:00 +0000
Subject: [Koha-bugs] [Bug 24972] Remove de-DE installer data
In-Reply-To: <bug-24972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24972-70-iDzgmKdvyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24973


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973
[Bug 24973] Allow to localize and translate system preferences with new yaml
based installer
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:18:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:18:08 +0000
Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
In-Reply-To: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24968-70-f0PYmQBIM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Nick Clemens from comment #0)
> At the most advanced, it could offer the option of controlling all of the
> parameters for the cronjob, either using a syntax or a new administration
> area

Or just use sysprefs for the parameters? Anyway, +1000 for this! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:18:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:18:22 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-mzkZg6wzT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:18:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:18:51 +0000
Subject: [Koha-bugs] [Bug 24971] Select invoice currency from vendor on
 receive
In-Reply-To: <bug-24971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24971-70-zsWcpUwyhC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:19:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:19:22 +0000
Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
In-Reply-To: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24968-70-seRimdQTOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

--- Comment #4 from Magnus Enger <magnus at libriotech.no> ---
Duplicate of "Bug 7972 - GUI for Crons"?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:19:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:19:43 +0000
Subject: [Koha-bugs] [Bug 23795] Convert OpacCredits system preference to
 news block
In-Reply-To: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23795-70-smBkx2cmYF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I tested this on a sandbox and it works for the English language.  
I couldn't find an option to install alternative languages on the newer sandbox
environments.

I attempted to test on Biblibre's sandboxes which allow alternative languages.
I couldn't find a way to add content to the opaccredits and then add the patch
to test if the content carries over.
However, I can confirm that the other language drop downs are visible in the
news section if the patch is applied.

I've added my sign off, but I understand how important additional languages
are.  Another person may want to test on a dev environment to double check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:21:16 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-38xHKQPWpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #22 from Simon Perry <simon.perry at itcarlow.ie> ---
Created attachment 101698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101698&action=edit
Test 25/3/20

Hi Jonathan, thanks for clarification. I just retested with today set as closed
day in Calendar, Days mode in hourly circulation rule set to 'Calendar' (the
dropdown menu for the Days Mode only says 'Calendar' not 'Ignore the Calendar'
btw) and useDaysMode syspref set to 'Use the Calendar to push the due date to
next due day.' When I checked out an hourly loan item, the due date was moved
on to tomorrow, not retained as today's. Please see screenshot attachment for
details. Do you want me to test with other options set for useDaysMode etc.?
Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:26:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:26:41 +0000
Subject: [Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system
 preference to news block
In-Reply-To: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23797-70-qEJemVmJdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101610|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101699&action=edit
Bug 23797: Convert OpacLoginInstructions system preference to news block

This patch builds on Bug 22318 to move the OpacLoginInstructions system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the OpacLoginInstructions system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and click the login link.
 - In the login modal, confirm that the content which was previously in
   the OpacLoginInstructions system preference displays correctly
   below the login form.
 - While not logged in to the OPAC, navigate directly to
   /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should
   display correctly here as well.
 - In the staff client, go to Tools -> News and verify that the content
   from OpacLoginInstructions is now stored in news items. There
   should be one entry for each of the enabled translations in your
   system, for instance 'OpacLoginInstructions_en',
   'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   OpacLoginInstructions preference has been removed.
 - To test the correct selection of language-specific content you must
   run the translation update/install process for the languages you're
   updating.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:27:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:27:52 +0000
Subject: [Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system
 preference to news block
In-Reply-To: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23797-70-raVU5L1abv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Very similar commentary to my testing on 23795.

I tested this on a sandbox and it works perfectly for the English language.  
I couldn't find an option to install alternative languages on the newer sandbox
environments.

I attempted to test on Biblibre's sandboxes which allow alternative languages.
I couldn't find a way to add content to the opaccredits and then add the patch
to test if the content carries over.
However, I can confirm that the other language drop downs are visible in the
news section if the patch is applied.

I've added my sign off, but I understand how important additional languages
are.  Another person may want to test on a dev environment to double check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:30:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:30:06 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-wXeveyCvsG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
they should be returned depending on the bug number. Which order do you get?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:30:30 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-sSEpZAIbdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
They should be returned depending on their borrowernumber. Which order do you
get?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:34:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:34:36 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-MDTG9NZH0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Marcel de Rooy from comment #8)
> 
> Is this really a privacy issue? In order to identify the person associated
> with borrowernumber 5, you'll need additional information.
> So if this is just theoretical, then removing the borrowernumber might not
> be enough ;) If I have biblionumber and reservedata or timestamp, I might
> also be able to find the associated borrower?
> 
> No blocker, just pushing a bit..

Valid question yep.

In my opinion removing borrowernumber is also to avoid using some scripts
vulnerability with a valid DB id that may allow SQL injection or data leaking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:35:26 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-4CW663PovT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Marcel de Rooy from comment #9)
> 
> If you are concerned about borrowernumber in hold, then you should be for
> issue too. Inconsistent !

Oh good catch, I'll fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:38:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:38:40 +0000
Subject: [Koha-bugs] [Bug 24963] Terminology: auto renewal,
 auto-renewal or autorenewal?
In-Reply-To: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24963-70-m69UJ2cTnn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

--- Comment #2 from Holly <hc at interleaf.ie> ---
I discussed this with a few colleagues and they agree that "auto-renewal" would
be the most appropriate. I had a look at some of the questions submitted by our
clients and "auto-renewal" seems to be the most commonly used phrase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:43:15 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-Ond9kgEBxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #6)
> They should be returned depending on their borrowernumber. Which order do
> you get?

By adding debug to t/db_dependent/Utils/Datatables_Members.t :
-        'We got the 3 patrons we expected'
+        'We got the 3 patrons we expected'.Data::Dumper::Dumper(map {
$_->{borrowernumber} } @{ $search_results->{patrons} })

I get :
# $VAR1 = 7888;
# $VAR2 = 7886;
# $VAR3 = 7887;

I confirm failing is random.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:48:44 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-sDfxPe0ZIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98714|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101700&action=edit
Bug 24614: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:48:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:48:46 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-0LySUevMpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98715|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101701&action=edit
Bug 24614: Use Koha::Reports from save_report and update_sql

In order to get the default value defined at DBMS level, we use
Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit
methods of C4::Reports::Guided.
A second step would be to remove completely those CRUD subroutines and
use directly Koha::Reports instead.

Test plan:
1. Add and edit some reports
2. Disable memcached, create a report, edit it
=> Should not crash
3. Make sure the tests make sense and that they pass after the second
patch.

The error was:
DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for
Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(),
report_name = ?, report_group = ?, report_subgroup = ?, notes = ?,
cache_expiry = ?, public = ? WHERE id = ? "] at
/kohadevbox/koha/C4/Reports/Guided.pm line 633.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:49:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:49:00 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-QjeoXMbRRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Does the trick, Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:51:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:51:16 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-yJk9pt0aM8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:51:19 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-nUe35B7iIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101702&action=edit
Bug 24964: Prevent random failures sorting by borrowernumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:53:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 12:53:45 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-xd4eLTwgUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Fridolin SOMERS from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > Did not we display old issues prior to this patch?
> 
> Yes indeed, C4::Circulation::GetBiblioIssues() makes issues UNION old_issues.
> 
> This is not the purpose of this patch, but isn't it a performance killer ?

Yes, but it's a change that is not advertised by the patch. What is the
expected behavior?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:00:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:00:22 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-DvsLH0Yjhm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:06:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:06:29 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-YcQIKkJl2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
         Depends on|                            |13897

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bernardo, could we imagine having the sysprefs' values translatable?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897
[Bug 13897] Use YAML files for installer data
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:06:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:06:29 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-PRFeXS28yn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24973


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973
[Bug 24973] Allow to localize and translate system preferences with new yaml
based installer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:12:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:12:14 +0000
Subject: [Koha-bugs] [Bug 24974] New: Add Elastic Search to the Manual
Message-ID: <bug-24974-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24974

            Bug ID: 24974
           Summary: Add Elastic Search to the Manual
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We need to add some documentation about Elastic Search in the Manual. Also in
Administration for Search Engine Configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:21:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:21:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-VDc5NPbo2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #48 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Getting an ISE because volume info is not cleared from items when volume is
deleted

-add items to volume
-delete volume
-see that items still show as in deleted volume
-select items, see you still have volume-related links even though there are no
volumes
-click "add/modify volume" and receive ISE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:21:21 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-SWq2gCT9rq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:22:35 +0000
Subject: [Koha-bugs] [Bug 24975] New: Refactor database translations
Message-ID: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

            Bug ID: 24975
           Summary: Refactor database translations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr,
                    jonathan.druart at bugs.koha-community.org

This is an attempt to make the process of translating database strings (like
itemtype descriptions) easier for developers and translators.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:24:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:24:53 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-GIlOPCTQmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101703&action=edit
Bug 24975: Refactor database translations

This is an attempt to make the process of translating database strings
(like itemtype descriptions) easier for developers and translators.

For developers by reducing the amount of code needed to enable
translations for a new kind of object (authorised values, letters, news,
...).
For translators by providing a single entry point for all translatable
strings

Table `localization` is replaced by two new tables `l10n_source` and
`l10n_target`. `l10n_source` contains the original text while
`l10n_target` contains the corresponding translations

`l10n_source` is automatically updated whenever an itemtype is
inserted, updated, or deleted, so it is always up to date (this is done
in Koha::Schema::Result::ItemType).
It means that if you delete an itemtype, translations get deleted too.
It also means that if you change an itemtype's description, translations
are lost (not sure if this should be fixed, since if description
changes, translations should probably be changed too)

It adds a new subroutine in Koha::I18N, `db_t`, which returns the
translation for a given context and string, according to the current
language. Translations are stored in memcached (if enabled).

So instead of having to declare a new subroutine
Koha::ItemType::translated_description, you can write
    db_t('itemtype', $itemtype->description)

In templates you can write
    [% ItemTypes.t(itemtype.description) %]

There's also a new page, accessible from the administration main page,
"Localization". It displays all translatable strings and allow to
translate them for all enabled languages.

Test plan:
1. Before applying the patch, make sure you have translated some
   itemtypes. Translations should be kept by the updatedatabase script.
   Before applying the updatedatabase you may want to comment the
   'DROP TABLE localization' statement if you want to keep this table
2. Apply patch, run updatedatabase.pl, run update_dbix_class_files.pl
   and reload starman
3. Go to Admin » Localization, verify that you have your itemtypes and
   their translations.
4. Verify that the filter is working (it filters on the source column
   only).
5. Translate some strings by clicking on one of the 'Translate' link,
   entering some text and clicking on the 'Save' button. You can remove
   a translation by emptying the text box.
6. Add a new item type. Verify that it appears in the Localization page
7. Change the description of this item type. Verify that the new
   description appears in Localization page and that the old description
   is gone
8. Delete this item type and verify that its description no longer
   appears in Localization page
9. Navigate through Koha (intranet and opac) in multiple languages and
   verify that item types are translated (if not, please verify in
   master too, not all occurrences were translated)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:25:06 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-PqHcYfGAVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:26:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:26:08 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-0w0E4DZNu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101684|0                           |1
        is obsolete|                            |

--- Comment #13 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101704&action=edit
Bug 24201: Attach desk to intranet session

When Desks are defined, a librarian can attach a desk to its session.

Test plan:

1. apply 13881 and create some desks
2. you should see “NO DESK SET” in the intranet header
3. go to circulation > Set desk
4. you should see your desk name in the header, whatever the page
5. you can also set desk with the header menu

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:26:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:26:11 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-Q0FRGfTBm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101697|0                           |1
        is obsolete|                            |

--- Comment #14 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101705&action=edit
Bug 24201: (follow-up) Show desk information at lower screen widths

The staff client header menu adjusts responsively to narrower viewport
widths, but for the logged-in-user menu this requires showing and hiding
part of the template which duplicates information. This patch adds a
copy of the current desk information to the part of the template shown
at narrower widths.

To test, apply the patch and view any page in the staff client.

 - Narrow your browser so that the viewport is less than 800px wide.
 - The logged-in-user menu should change from text to a single "user"
   icon.
 - Clicking the icon should display a menu which includes labeled
   information about the current desk.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:26:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:26:33 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-phzb3qYfC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
  Text to go in the|                            |This development will allow
      release notes|                            |a patron to opt-out of
                   |                            |auto-renewals -the cron
                   |                            |will ignore these checkouts
                   |                            |and items will be renewable
                   |                            |both via the staff and
                   |                            |opac.
                   |                            |
                   |                            |Patrons will be able
                   |                            |to set this flag
                   |                            |themselves, staff will also
                   |                            |be able to.
                   |                            |
                   |                            |There is one
                   |                            |new system preference:
                   |                            |AllowPatronToControlAutoren
                   |                            |ewal The options are: allow
                   |                            |only staff or allow patrons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:26:54 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-gEyXanBTAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #15 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Martin Renvoize from comment #7)

> preference so libraries not interested in using the feature don't see it.
> 2/ If there are not desks defined for the logged-in library then a trailing
> `|` is left in the header menu

fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:28:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:28:09 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-nzdDMK6xp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #16 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Owen Leonard from comment #12)
> Created attachment 101697 [details] [review]
> Bug 24201: (follow-up) Show desk information at lower screen widths
> 
> The staff client header menu adjusts responsively to narrower viewport
> widths, but for the logged-in-user menu this requires showing and hiding
> part of the template which duplicates information. This patch adds a
> copy of the current desk information to the part of the template shown
> at narrower widths.
> 
> To test, apply the patch and view any page in the staff client.
> 
>  - Narrow your browser so that the viewport is less than 800px wide.
>  - The logged-in-user menu should change from text to a single "user"
>    icon.
>  - Clicking the icon should display a menu which includes labeled
>    information about the current desk.

Nice! Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:32:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:32:01 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-E2QbnhBn1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
That looks like a great idea.
What about the interface (for AVs)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:32:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:32:22 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-j2UIBmLTD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20307

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:32:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:32:22 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-xAnH1y5PRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24975

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:33:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:33:38 +0000
Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron
 add by default
In-Reply-To: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3137-70-XP15ZBc1Ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds a syspref -
      release notes|                            |CollapseFieldsAddPatronForm
                   |                            |- that controls which
                   |                            |fieldsets are hidden by
                   |                            |default in the add patron
                   |                            |form.
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:35:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:35:51 +0000
Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch
 are enforced based on item, location limits are enforced per library
In-Reply-To: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24868-70-4WXlxAz8u3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868

Martha Fuerst <mfuerst at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mfuerst at hmcpl.org

--- Comment #2 from Martha Fuerst <mfuerst at hmcpl.org> ---
I could come up with scenarios where a consortium using one instance of Koha
may want this to behave as is, but speaking from the perspective of a system
with multiple locations, it's not how we would interpret it "should" behave.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:39:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:39:39 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-gvfEFWHaho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:39:42 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-yWX0HY5axn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101635|0                           |1
        is obsolete|                            |
 Attachment #101636|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101706&action=edit
Bug 24886: Reindent reports template

This patch reindents the template for saved reports, replacing tabs with
spaces and making indentation consistent. Some lines have been split up.

To test, apply the patch and go to Reports -> Use saved.

 - Test adding, editing, viewing, and running reports
 - Test filtering by group and subgroup
 - Test the process of adding a guided report

 Everything should work as expected.

 Use your preferred method for checking the differences between files
 while ignoring whitespace. I use diff with the  "-w" flag, but I'm not
 your dad. The only changes you see should be split lines.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:39:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:39:46 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-nK5WbKDJkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101707&action=edit
Bug 24886: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:33 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-sHCpenwcgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100119|0                           |1
        is obsolete|                            |

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101708&action=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:36 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-hMbgtSXGbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100120|0                           |1
        is obsolete|                            |

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101709&action=edit
Bug 24455: Add moment library in staff

This patch adds koha-tmpl/intranet-tmpl/lib/moment/moment.min.js in order to
use the moment library (https://momentjs.com/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:40 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-5fuHOFltuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100121|0                           |1
        is obsolete|                            |

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101710&action=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:44 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-lPNWJ6JQ2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100122|0                           |1
        is obsolete|                            |

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101711&action=edit
Bug 24455: Add moment-timezone library in staff

This patch adds
koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:47 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-JjAcGZqyBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100123|0                           |1
        is obsolete|                            |

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101712&action=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the a js-date-format.inc file on each opac and staff interface
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:50 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-iUAo72qc1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100124|0                           |1
        is obsolete|                            |

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101713&action=edit
Bug 24455: [DO NOT PUSH] test timezone

This is just a test.. I added the .inc file to adimn's main page

To test:

1. go to Koha main page and open chrome or firefox console
2. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'America/Argentina/Buenos_Aires'})

   and you should get

   "02/18/2020 09:46"

   because America/Argentina/Buenos_Aires is -03:00

3. type

   $datetime('2020-02-18T12:46:05Z', {tz: 'Asia/Shanghai'})

   and you should get

   "02/18/2020 20:46"

   because Asia/Shanghai is +08:00

4. type

   $datetime('2020-02-18T12:46:05Z')

   and it should be translated to your koha instance configured timezone.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:54 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-KDkKMi8xtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100125|0                           |1
        is obsolete|                            |

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101714&action=edit
Bug 24455: Add Moment.js to About page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:42:57 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-hn2we2AJ0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101715&action=edit
Bug 24455: (follow-up) Document function

This patch just adds some minimal documentation to the main exported JS
function.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:46:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:46:28 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-LNwtmyScYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:47:12 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-ocAAFmj7wD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Back to PQA.. I've added a followup which documents the main function.

I'm happy to add moment.js as it's not a huge library and is pretty much the
defacto library used in the wild for datetime manipulation.

I still think it's somewhat unclear how Calendar.inc and this include differ
from the end developers perspective and would love to see something akin to
'date_inputs.inc' and 'date_outputs.inc' to make it clear how the two relate to
each other.. and perhaps even have some of the functionality shared.

I'll try to work out some followup bugs for these parts however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:47:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:47:20 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-XsPomUwmEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Database tables have
      release notes|                            |changed.
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:47:53 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-mUDk2nx2cZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Fridolin SOMERS from comment #14)
> > (In reply to Jonathan Druart from comment #13)
> > > Did not we display old issues prior to this patch?
> > 
> > Yes indeed, C4::Circulation::GetBiblioIssues() makes issues UNION old_issues.
> > 
> > This is not the purpose of this patch, but isn't it a performance killer ?
> 
> Yes, but it's a change that is not advertised by the patch. What is the
> expected behavior?

Do we create another patch and this one will depend on it ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:04 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-whLIho32cL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:06 +0000
Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies
In-Reply-To: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24158-70-CrDun4Ea7l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:08 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-gNTtmByUeg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:10 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-1SyFFgHNet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:12 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-SDPjDweVcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:14 +0000
Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2
In-Reply-To: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24828-70-EysQBUTUjH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:15 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-QU2xlq7zpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:55:17 +0000
Subject: [Koha-bugs] [Bug 24886] Reindent reports template
In-Reply-To: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24886-70-Onlw2x57JS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:56:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:56:42 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-OMesbMlh6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #104 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marked as blocked by bug 24975 that offers a more elegant way to localize our
DB strings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:58:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 13:58:59 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-KHSqzYXsUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > Did not we display old issues prior to this patch?
> 
> Yes indeed, C4::Circulation::GetBiblioIssues() makes issues UNION old_issues.
> 
> This is not the purpose of this patch, but isn't it a performance killer ?

In my opinion it's useful to get current issues but if we want previous
checkout there are Rest API routes to query patrons checkouts.

I'd say, we don't need nor want GetRecords to show previous issues.
Also, removing the borrowernumber is still very useful, any script, having the
borrowernumber could easily grab borrower information from GetPatron.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:05:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:05:53 +0000
Subject: [Koha-bugs] [Bug 23229] "Get all requests" API call fired when
 loading any ILL page
In-Reply-To: <bug-23229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23229-70-rgoR7nMGwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:06:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:06:17 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-WozFXKEqoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:07:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:07:11 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-v6oYao5WNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100281|0                           |1
        is obsolete|                            |

--- Comment #10 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 101716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101716&action=edit
Bug 24819: Allow the librarian to choose a patron when entering a purchase
suggestion

Sometimes librarians are creating purchase suggestions that came from patrons
which didn't use the opac (but sent an email, or told the librarian
verbally...)

This patch allows the librarian to change the creator of the purchase
suggestion
when entering it.

This way, the patron will be able to receive notifications during the purchase
suggestion workflow.

Test plan:

 - Apply the patch

 - Check that you can change the default creator of the purchase suggestion
when
   creating a new suggestion by clicking on 'Set to patron'
   (Home > Acquisitions > Suggestions management > New purchase suggestion)

 - Check that you can also change the creator of the purchase suggestion when
   editing an existing suggestion

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:08:19 +0000
Subject: [Koha-bugs] [Bug 24976] New: Guided report - "Save" button on last
 step is misleading
Message-ID: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

            Bug ID: 24976
           Summary: Guided report - "Save" button on last step is
                    misleading
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

"Save" button on last step does not save (!)
It should be renamed "Next" instead

https://snipboard.io/gXntf8.jpg

Next step has a "Save report" button that actually saves.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:08:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:08:21 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-ReThp2sQNz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #11 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:11:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:11:45 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-uHyszxRFHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #1)
> Bernardo, could we imagine having the sysprefs' values translatable?

It's in my TODO list, but to translate explanations column.

In this case it's the values that must be translated.
Proposal:
* Split sysprefs.sql into localizable and not localizable parts
  eg. sysprefs localsysprefs, our choice
* Put them in /en/ dir
* rewrite them as yaml, on syspref only translate explanation, on localsysprefs
explanation and value
* add strings from sysprefs in xx-YY-installer.po
* add strings from localsysprefs in it's own po file.
  This file should contain useful comments so that the translators know what
values are valid.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:25:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:25:05 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-dzi9KzedyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:29:38 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-QQwN2Yjutn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:29:42 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-TgQ8AMSZBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101663|0                           |1
        is obsolete|                            |
 Attachment #101664|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101717&action=edit
Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method

In order to remove UseKohaPlugins syspref, adds to Koha Template Toolkit
plugin a method ArePluginsEnabled().

Test plan:
1) Set syspref UseKohaPlugins enabled
2) Set config enable_plugins=1
3) Check you see "Tool plugins" in "Tools" home page and menu
4) Check you see "Manage plugins" in "Koha administration" home page
5) Check you see "Report plugins" in "Reports" home page and menu
6) Set config enable_plugins=0
7) Check you don't see in 3) 4) 5)
8) Run prove t/Koha_Template_Plugin_Koha.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:29:54 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-29tY4VUA31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101718&action=edit
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already
multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use
of plugins.
>>

Test plan :
1) Install kitchen sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:29:58 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-fbKWtTtVTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101719&action=edit
Bug 20415: Add POD

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:31:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:31:49 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-3EJfGkz1xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks for testing Sonia!

What this change does basically is:
* Improve feedback to the end user: why this item cannot be deleted
* Block deletion of the last item for a biblio on which a hold is placed on, to
avoid phantom holds (original issue reported)

(In reply to Koha Team University Lyon 3 from comment #57)
> When you confirm the deletion, you have an alert for the case of the
> biblio-level-hold with 2 items that were selected for deletion : "Last item
> for bibliographic record wich biblio-level hold on it" and another message
> saying "At least one item blocked the deletion. The operation rolled back
> and nothing happened! "
> So the deletion is cancelled for all the items selected.

Yes, the problem is that we cannot (easily) know that we are going to remove
the last item on the biblio if we are going to remove several items from this
biblio. We only know it when we remove the last one. That is why everything is
rollbacked and no deletion was effective.

> Could we not prevent to tick all the 1/1 case in the first table in addition of > what exists already?

If we want to change the behavior on item's level holds, I think it should be
decided on a separate bug report, unless everybody agrees.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:35:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:35:34 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-56SYrXgzsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:45:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:45:09 +0000
Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template
 in export tool
In-Reply-To: <bug-24679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24679-70-DW4EZ7WRZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Julian, tests are failing for me.

    #   Failed test 'Export XML: marc modification template should have added
999$9'
    #   at t/db_dependent/Exporter/Record.t line 483.
    #          got: undef
    #     expected: 'Foobar'
    # Looks like you failed 1 test of 2.

#   Failed test 'export xml with marc modification template'
#   at t/db_dependent/Exporter/Record.t line 484.

    #   Failed test 'Export ISO2709: marc modification template should have
added 999$9'
    #   at t/db_dependent/Exporter/Record.t line 508.
    #          got: undef
    #     expected: 'Foobar'
    # Looks like you failed 1 test of 2.

#   Failed test 'export iso2709 with marc modification template'
#   at t/db_dependent/Exporter/Record.t line 509.
# Looks like you failed 2 tests of 9.

Certainly coming from bug 21708.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:51:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:51:01 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-nKf2mRtYSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think the exported file must export exactly the same file as the one we embed
with Koha.

% perl misc/search_tools/export_elasticsearch_mappings.pl > /tmp/mappings.yaml
% diff admin/searchengine/elasticsearch/mappings.yaml /tmp/mappings.yaml
Should return no change.

Don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:56:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 14:56:44 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-MP8jjAeEMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patchset lays the
      release notes|                            |foundations for applying
                   |                            |date formatting as
                   |                            |described in the koha
                   |                            |system preferences to
                   |                            |datetimes returned by the
                   |                            |API in RFC3339 format.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:03:05 +0000
Subject: [Koha-bugs] [Bug 24977] New: Enable translations for authorised
 values (POC)
Message-ID: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

            Bug ID: 24977
           Summary: Enable translations for authorised values (POC)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 24975

Only a proof of concept to illustrate what's needed to enable translation for a
new kind of object.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
[Bug 24975] Refactor database translations
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:03:05 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-gnUNrgv9BL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24977


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977
[Bug 24977] Enable translations for authorised values (POC)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:04:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:04:34 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-KmZXmHaaX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101720&action=edit
Bug 24977: Enable translations for authorised values (POC)

Only a proof of concept to illustrate what's needed to enable
translation for a new kind of object.

Only authorised values retrieved with
Koha::AuthorisedValues->get_descriptions_by_koha_field are translated.
This is used for instance for shelving locations in
catalogue/itemsearch.pl

Test plan:
1. Run updatedatabase && update_dbix_class_files && reload starman
2. Go to Admin » Localization
3. Find a LOC authorised value and translate it
4. Go to Item search form and verify that it is translated

Requires bug 24975

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:04:54 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-tj4TFEAJ89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:05:00 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-3PuRtP8yKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:09:30 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-0K9LvEwZsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
https://snipboard.io/qrCmGP.jpg

MariaDB [koha_kohadev]> select * from old_reserves\G
*************************** 1. row ***************************
      reserve_id: 1
  borrowernumber: 5
     reservedate: 2020-03-25
    biblionumber: 1
      branchcode: CPL
notificationdate: NULL
    reminderdate: NULL
cancellationdate: NULL
    reservenotes:
        priority: 0
           found: F
       timestamp: 2020-03-25 15:07:18
      itemnumber: 1
     waitingdate: 2020-03-25
  expirationdate: 2020-03-26
  lowestPriority: 0
         suspend: 0
   suspend_until: NULL
        itemtype: NULL
 item_level_hold: 0


Compare date values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:13:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:13:34 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-uLuoxCwyya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
So, 2020-03-25 in DB is displayed 24/03

server time is Wed Mar 25 15:12:57 UTC 2020
Client time is Wed 25 Mar 16:12:54 CET 2020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:21:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:21:47 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-6746N8MT5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:21:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:21:49 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-JZMMGzJUzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101628|0                           |1
        is obsolete|                            |

--- Comment #10 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101721&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:21:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:21:53 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-XY4b6SE5oi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101629|0                           |1
        is obsolete|                            |

--- Comment #11 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101722&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:21:56 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-MqXBPcrK3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101630|0                           |1
        is obsolete|                            |

--- Comment #12 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101723&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:49:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:49:47 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-VXyzj97FKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:49:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:49:51 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-S8wkpbKkCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100471|0                           |1
        is obsolete|                            |
 Attachment #100472|0                           |1
        is obsolete|                            |
 Attachment #100473|0                           |1
        is obsolete|                            |
 Attachment #100474|0                           |1
        is obsolete|                            |

--- Comment #33 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101724&action=edit
Bug 20936: Add OPACHoldsHistory syspref

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:49:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:49:56 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-MixZX2HW8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #34 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101725&action=edit
Bug 20936: Add koha_object_class and koha_objects_class methods to Schema
classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:50:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:50:01 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-WyCg0h8YVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #35 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101726&action=edit
Bug 20936: Add patron's hold history menu in OPAC

This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)

To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
        => Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.

Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.

Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:50:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:50:05 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-zS3R9RKn8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #36 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101727&action=edit
Bug 20936: Add test

Add test to /api/v1/public/patrons/:patron_id/holds endpoint

To test:
1. prove t/db_dependent/api/v1/patrons_holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:50:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:50:35 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-UsS988HwDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:53:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:53:10 +0000
Subject: [Koha-bugs] [Bug 24978] New: Hahahaahaahhahahaahah
Message-ID: <bug-24978-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24978

            Bug ID: 24978
           Summary: Hahahaahaahhahahaahah
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: maman.firmansyah6666 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101728&action=edit
Jqhqqhqhq

bugg

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:58:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 15:58:34 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-btvsC9zgGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Agustin, please do not amend patches that have been signed off yet, submit
follow-ups instead. They can be squashed later if needed.

Still not correct: https://snipboard.io/0QNHgX.jpg
There is one non formatted string, I guess that is what you modified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:07:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:07:35 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-Ld9zqkVGdV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Also found:
Search "foo", nothing is displayed, info is "showing page 1 of 0"
https://snipboard.io/stcEuY.jpg

Then remove "foo", you need to hit enter to see the unfiltered result, not sure
it's the expected behavior as filtering works without hitting enter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:11:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:11:42 +0000
Subject: [Koha-bugs] [Bug 24979] New: Dit
Message-ID: <bug-24979-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24979

            Bug ID: 24979
           Summary: Dit
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dhittamvan60 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101729&action=edit
999

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:40:16 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-Rk8mSUitrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #39 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #37)
> Agustin, please do not amend patches that have been signed off yet, submit
> follow-ups instead. They can be squashed later if needed.

Ok, will rememeber that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:49:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:49:59 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-JqjyEc0KZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-L69aKDGyjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101670|0                           |1
        is obsolete|                            |
 Attachment #101671|0                           |1
        is obsolete|                            |
 Attachment #101672|0                           |1
        is obsolete|                            |
 Attachment #101673|0                           |1
        is obsolete|                            |
 Attachment #101674|0                           |1
        is obsolete|                            |
 Attachment #101675|0                           |1
        is obsolete|                            |
 Attachment #101676|0                           |1
        is obsolete|                            |
 Attachment #101677|0                           |1
        is obsolete|                            |
 Attachment #101678|0                           |1
        is obsolete|                            |
 Attachment #101679|0                           |1
        is obsolete|                            |
 Attachment #101680|0                           |1
        is obsolete|                            |
 Attachment #101681|0                           |1
        is obsolete|                            |

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101730&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-PC0JeglMtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101731&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:19 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-mrwwg4g0or@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101732&action=edit
Bug 24857: Add Koha Object(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:22 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-nw15Pf2mQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101733&action=edit
Bug 24857: Add Object Methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:26 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-xUElscXlGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101734&action=edit
Bug 24857: API spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ua7jO9CMn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101735&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-4t33TmdAr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101736&action=edit
Bug 24857: Implement volume related controllers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2EDej9LAzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101737&action=edit
Bug 24857: Add volume management to detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ogL1m3OEzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101738&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:44 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-FN3mGe3PbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101739&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:47 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-TOXgPzs5Zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101740&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:50:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:50:51 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-FHWOMv5gGu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101741&action=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:55:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:55:03 +0000
Subject: [Koha-bugs] [Bug 24978] SPAM
In-Reply-To: <bug-24978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24978-70-yQDZwWZ46x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24978

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hahahaahaahhahahaahah       |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:55:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:55:26 +0000
Subject: [Koha-bugs] [Bug 24978] SPAM
In-Reply-To: <bug-24978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24978-70-s03iV4MGKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24978

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:56:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 16:56:02 +0000
Subject: [Koha-bugs] [Bug 24979] SPAM
In-Reply-To: <bug-24979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24979-70-ew82wD1qHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24979

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
            Summary|Dit                         |SPAM
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:05:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:05:32 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-UjnxRXobNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 101726
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101726
Bug 20936: Add patron's hold history menu in OPAC

Review of attachment 101726:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20936&attachment=101726)
-----------------------------------------------------------------

::: api/v1/swagger/paths/public_patrons.json
@@ +301,5 @@
> +                  {
> +                    "name": "timestamp",
> +                    "in": "query",
> +                    "description": "Time of latest update",
> +                    "type": "string"

This feels wrong.. surely this needs a `format: date-time` entry

@@ +313,5 @@
> +                  {
> +                    "name": "waiting_date",
> +                    "in": "query",
> +                    "description": "Date the item was marked as waiting for the patron",
> +                    "type": "string"

This feels wrong.. surely this needs a `format: date-time` entry

@@ +319,5 @@
> +                  {
> +                    "name": "expiration_date",
> +                    "in": "query",
> +                    "description": "Date the hold expires",
> +                    "type": "string"

This feels wrong.. surely this needs a `format: date-time` entry

@@ +337,5 @@
> +                  {
> +                    "name": "suspended_until",
> +                    "in": "query",
> +                    "description": "Suspended until",
> +                    "type": "string"

This feels wrong.. surely this needs a `format: date-time` entry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:11:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:11:06 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-Q5QkyoIZ5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101742&action=edit
Bug 23204: Fix ordering of fields in exported file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:13:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:13:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-e6wDsCSdjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Indeed, dropping the use of the call to `date` for formatting breaks it
entirely.. i.e we don't format using the sysprefs at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:17:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:17:07 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-6djfB57a1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #20)
> I think the exported file must export exactly the same file as the one we
> embed with Koha.
> 
> % perl misc/search_tools/export_elasticsearch_mappings.pl >
> /tmp/mappings.yaml
> % diff admin/searchengine/elasticsearch/mappings.yaml /tmp/mappings.yaml
> Should return no change.
> 
> Don't you think?

Yes and no - ordering fixed most, and not adding undefined weights or
facet_order, but there are some remaining differences:
1 - Facet order not set in default file
2 - LC-card-number - comes out in lower case because we have it twice, once for
authorities and once for biblios - these get combined when adding to DB because
they all go in to 'search_field' which doesn't separate bibs/auths - I don't
think the matters. There does seem to be convention of Auth fields being
capitalized and bibs fields not, but I don't believe we rely on this or need to
3 - Default mapping file is not strictly alphabetized - date-of-publication
moves on export

Probably a good compromise is to generate the mapping file from this bug once
it passes QA and use the exported file as the default from now on. Consider it
a cleanup of the file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:27:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:27:04 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-RM08kr0nJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:31:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:31:32 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-UqBDUuxWam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. this issue here is that the js code in bug 24455 does not distinguish
between the perfectly valid 'full-date' and 'date-time' resolutions of RFC3339.

Both are valid formats, but one includes a time offset whilst the other does
not.  The 'full-date' option does not include time resolution and as such also
does not include an offset.  When moment parses this, it 'upgrades' the
internal representation from full-date (2020-03-25) to date-time
(2020-03-25T00:00:00+00:00) internally.. When you then apply a timezone to that
(say +0300 for Argentina I believe), we end up with an internal date of
2020-03-24T21:00:00-03:00.. spot the day change.. formating this back down to
just 'date' will loose the day.

Hope that makes sense.. so.. what we need to do is detect if we're parsing a
date-time vs a full-date and only apply timezone maths to the former

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:47:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:47:50 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-xTItBdrCg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 17:47:53 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-GoGfYx3ie8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101743&action=edit
Bug 12187: (follow-up) Reindent new include file

This patch re-indents the new include file so that it is consistent with
coding guidelines. Taking this opportunity to add a full test plan:

Instead of duplicating the code for serial statuses in multiple
files, move all of them into single include file, and use that.

To test, apply the patch and go to Serials.

 - Search for a subscription which has multiple issues.
   - On the subscription detail page, open the "Issues" tab.
     - Statuses in the "Status" column should display correctly.
   - Click the "Serial collection" link in the sidebar.
     - In the table of issues, the "Status" colunn should display the
       correct information.
   - Select some isues and click the "Edit serials" button.
     - In the "Status" column, the options should display correctly.
     - Test setting various statuses and saving. The statuses should
       save correctly.
   - Click "Claims" in the sidebar menu and select a vendor.
     - In the list of missing issues the "Status" column should show the
       correct information.
  - In the catalog, locate the bibliographic record for a subscription
    with issues.
    - Under the "Subscriptions" tab check the "Status" column. Status
      information should be displayed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:23 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-mEWy6YA1jr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100644|0                           |1
        is obsolete|                            |
 Attachment #100645|0                           |1
        is obsolete|                            |
 Attachment #100646|0                           |1
        is obsolete|                            |
 Attachment #100647|0                           |1
        is obsolete|                            |
 Attachment #100648|0                           |1
        is obsolete|                            |
 Attachment #100649|0                           |1
        is obsolete|                            |
 Attachment #100650|0                           |1
        is obsolete|                            |
 Attachment #100651|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101744&action=edit
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a
specific volume of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item
level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:32 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-jBYpWwxZag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101745&action=edit
Bug 24860: Add new syspref EnableVolumeHolds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:34 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-fmGgws39tn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101746&action=edit
Bug 24860: Implement reserves.volume_id

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:37 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-tBZnhBMEE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101747&action=edit
Bug 24860: Add ability to select a volume when placing a hold

TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl
      Requires embedding volume in hold API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:40 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-oKpiAC3ij6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101748&action=edit
Bug 24860: Add ability to select a volume when placing a hold - OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:42 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-ZWvTh4o0me@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101749&action=edit
Bug 24860: Skip non-matching volume holds in CheckReserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:45 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-vT4nvXvh3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101750&action=edit
Bug 24860: Skip non-matching volume holds in HoldsQueue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:00:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:00:48 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-sd6rgXWi2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101751&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:29:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:29:49 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-w9kelsS1MK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:29:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:29:53 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-zJbOj5ODmx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101730|0                           |1
        is obsolete|                            |

--- Comment #61 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101752&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:29:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:29:56 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-WNAxoA4od4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101731|0                           |1
        is obsolete|                            |

--- Comment #62 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101753&action=edit
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:00 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-qHER3dHYs2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101732|0                           |1
        is obsolete|                            |

--- Comment #63 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101754&action=edit
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-HkeStyBdh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101733|0                           |1
        is obsolete|                            |

--- Comment #64 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101755&action=edit
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:07 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-zJwyeWmy3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101734|0                           |1
        is obsolete|                            |

--- Comment #65 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101756&action=edit
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:10 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-yrgr40njfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101735|0                           |1
        is obsolete|                            |

--- Comment #66 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101757&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-J4o6CMLd7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101736|0                           |1
        is obsolete|                            |

--- Comment #67 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101758&action=edit
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:17 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-qWIpWatG8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101737|0                           |1
        is obsolete|                            |

--- Comment #68 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101759&action=edit
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:20 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-uayphic1pR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101738|0                           |1
        is obsolete|                            |

--- Comment #69 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101760&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:24 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-e5RGrTQfbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101739|0                           |1
        is obsolete|                            |

--- Comment #70 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101761&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:27 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2461re8QIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101740|0                           |1
        is obsolete|                            |

--- Comment #71 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101762&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:30:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-3mAZgaGTSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101741|0                           |1
        is obsolete|                            |

--- Comment #72 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101763&action=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:52:33 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-BlROB4fTy5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:54:37 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-Ghwc97ZyeD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:54:42 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-FxJESXoUFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|kyle at bywatersolutions.com   |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 18:55:28 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-JeJ4M7mw90@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
           Assignee|jonathan.druart at bugs.koha-c |kyle at bywatersolutions.com
                   |ommunity.org                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:00:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:00:41 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-yiBzKgBV0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:00:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:00:43 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-xre5101Rmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101700|0                           |1
        is obsolete|                            |
 Attachment #101701|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101764&action=edit
Bug 24614: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:00:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:00:54 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-RRluMCkybd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101765&action=edit
Bug 24614: Use Koha::Reports from save_report and update_sql

In order to get the default value defined at DBMS level, we use
Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit
methods of C4::Reports::Guided.
A second step would be to remove completely those CRUD subroutines and
use directly Koha::Reports instead.

Test plan:
1. Add and edit some reports
2. Disable memcached, create a report, edit it
=> Should not crash
3. Make sure the tests make sense and that they pass after the second
patch.

The error was:
DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for
Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(),
report_name = ?, report_group = ?, report_subgroup = ?, notes = ?,
cache_expiry = ?, public = ? WHERE id = ? "] at
/kohadevbox/koha/C4/Reports/Guided.pm line 633.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:12:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:12:14 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-Ni9WN9uVLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #43 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #40)
> Comment on attachment 101726 [details] [review]
> Bug 20936: Add patron's hold history menu in OPAC
> 
> Review of attachment 101726 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: api/v1/swagger/paths/public_patrons.json
> @@ +301,5 @@
> > +                  {
> > +                    "name": "timestamp",
> > +                    "in": "query",
> > +                    "description": "Time of latest update",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +313,5 @@
> > +                  {
> > +                    "name": "waiting_date",
> > +                    "in": "query",
> > +                    "description": "Date the item was marked as waiting for the patron",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +319,5 @@
> > +                  {
> > +                    "name": "expiration_date",
> > +                    "in": "query",
> > +                    "description": "Date the hold expires",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +337,5 @@
> > +                  {
> > +                    "name": "suspended_until",
> > +                    "in": "query",
> > +                    "description": "Suspended until",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry

These are input parameters.. these are for search, including partial search..
so you cannot put 'format: date-time' if you plan to search by all dates from
year 2020, for example.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:35:40 +0000
Subject: [Koha-bugs] [Bug 24980] New: Date formatting from JS - use timezone
 only with dates with offset
Message-ID: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

            Bug ID: 24980
           Summary: Date formatting from JS - use timezone only with dates
                    with offset
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: agustinmoyano at theke.io
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24455
            Blocks: 20936

Bug 24455 uses timezone to format any date that comes.. even dates like
'2020-04-04' that specifies no offset.

That date gets translated to '2020-04-04T00:00:00Z', and if you've got a
timezone with -NN:NN if you ask for the date, you may get '2020-04-03' which is
wrong.

This bug will try to fix that.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] Date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:35:40 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-C4jO0tVwg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
[Bug 24980] Date formatting from JS - use timezone only with dates with offset
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 19:35:40 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-jQ347d0exU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
[Bug 24980] Date formatting from JS - use timezone only with dates with offset
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:15:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:15:00 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-RihbTtXDMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha::DateUtils ignored     |Koha::DateUtils ignores
                   |offsets in RFC3339          |offsets in RFC3339
                   |datetimes                   |datetimes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:19:58 +0000
Subject: [Koha-bugs] [Bug 24981] New: Dit gans
Message-ID: <bug-24981-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24981

            Bug ID: 24981
           Summary: Dit gans
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dhittamvan60 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101766&action=edit
Ganss

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:23:01 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-RGqxKkhLgY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:23:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:23:05 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-b6G2EIIuoD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101538|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101767&action=edit
Bug 24959: Fix id/label pairs in saved reports table

This patch adds a unique id attribute to each checkbox in the table of
saved reports. Also updated is the corresponding <label>'s "for"
attribute so that clicking the report id will toggle the checkbox.

To reproduce, go to Reports -> Use saved and click a number in the ID
column. Nothing happens.

After applying the patch clicking the number should check or uncheck the
corresponding checkbox.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works Ok, no errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:37:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:37:07 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-ZPn1WLYILm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:37:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:37:12 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-WDxDm3wdaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101662|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101768&action=edit
Bug 20399: Remove "did you mean" for the staff interface

The amdin page for the "did you mean" feature has two block for setting it up
in the staff interface, and a note saying this isn't implemented on the staff
interface yet.
We remove the part about the staff interface until it actually is implemented.

Test plan :
1) Apply patch
2) Go to Administration > Did you mean?
3) See there is only the OPAC block
4) Change some checkboxes
5) Save configuration
6) Check that configuration is saved

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Save works, syspref removed.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:37:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:37:16 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-9FVpllBIyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101769&action=edit
Bug 20399: (QA follow-up) Remove mention of INTRAdidyoumean from text and
delete commented code

Removes some last "remains" of INTRAdidyoumean.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:42:44 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-O0pCqeoRtm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:42:48 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-UDujzcQ0Lv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101391|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101770&action=edit
Bug 16457: Remove the use of "onclick" from the patron entry form

This patch removes several event attributes from the patron entry form
and replaces them with event handlers in the <script> block.

Some event attributes were removed altogether because they weren't
functional: Onchange events on jQueryUI datepickers don't work, and they
would have been redundant even if they did work.

To test you should have some patron attributes configured
(Administration -> Patron attribute types). At least one attribute
should be configured to apply to one particular patron category.

Apply the patch and begin the process of adding a new patron.

1. Try to add a patron with details matching a patron which already
   exists. You should get a confirmation message on screen which asks if
   the patron is a duplicte. Test the link which shows the existing
   record. It should trigger a popup window with details about the
   patron.

2. Test the process of setting a patron's date of birth. Selecting a
   date should trigger the display of the patron's age immedately below
   the field.

3. Test that you cannot set a patron's expiration to a date which
   precedes the date in the registration date field.

4. Test that you can add a manual restriction's expiration date, and
   that the "Clear date" link works correctly.

5. Test that the "clear" and "new" controls links work with additional
   attributes and identifiers.

6. Test that changing the patron's category correctly affects the
   display of available attributes and identifiers: The attribute you
   have associated with a particular patron category should only show if
   that category is selected under "Category."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Easy to follow test plan, all works, but on point 5. I found one 'clear'
but no 'new' control link, it's my only comment.
No errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:42:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:42:53 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-FABph56Zkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101554|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101771&action=edit
Bug 16457: (follow-up) Enable click event on dynamically-created elements

This patch moves the click handler for patron attribute actions ("new",
"clear") from the links themselves to the container. This allows jQuery
to correctly target dynamically-created copies of the links.

To test you should have extended patron attributes enabled and you
should have some repeatable attributes defined.

 - Create or edit a patron record
 - In the "Additional attributes and identifiers" section, test the
   "Clear" and "New" links. Confirm that the controls work with both the
   original instance of the field and those created by clicking "New."

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:44:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:44:41 +0000
Subject: [Koha-bugs] [Bug 24981] SPAM
In-Reply-To: <bug-24981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24981-70-JVQToDLyhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
            Summary|Dit gans                    |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:45:49 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-C4tsoywZn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Totally makes sense.. your right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:46:13 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-ciIhqtM9bN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101772&action=edit
Bug 20936: (QA follow-up) Only add timezone if date-time

This patch prevents a timezone from being assigned to the js moment if
the input string is only at the full-date and not date-time resolution

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:47:12 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-TsRL1UfPW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Agustin, could you take a look at my followup and confirm that it makes sense?

I think I should probably push it as an RM follow-up to bug 24455 rather than
here.. but would like a sanity check from you first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:56:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:56:33 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-md1VhsZwRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

--- Comment #1 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 101773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101773&action=edit
Bug 24976: Guided report - "Save" button on last step is misleading

This patch changes the text of the save button on the final step.

To test:

1) Build a guided report (the selections are immaterial)
2) Note that after you have been through the six stages, the button on
the "Confirm custom report" screen should be labelled "Save"
3) Install patch
4) Repeat Step 1. Note that on the "Confirm custom report" screen, the
button is now labelled "Next".
5) Run the report to check that the functionality still works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:57:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 20:57:29 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-BIgVv0bAcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:05:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:05:54 +0000
Subject: [Koha-bugs] [Bug 24561] Add embedded column order by and filter
 features to datatables api wrapper
In-Reply-To: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24561-70-eYAZipxBJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:08:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:08:48 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-a5cDXuO88Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch ensures MARC
      release notes|                            |modification template
                   |                            |actions work as expected
                   |                            |when the 'from field'
                   |                            |doesn't match the
                   |                            |'conditional field'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:15:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:15:19 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-k93ubX2pyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100779|0                           |1
        is obsolete|                            |

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 101774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101774&action=edit
Bug 20648:  Attribute option 'Display in check-out' should be renamed

This patch rewords the 'Display in check-out' option in the patron
attribute policy

To test:

1) Apply patch
2) Go to /cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
3) Check that the 8th line down has been renamed to "Display in patron's
brief information:"
4) Check the description of this same option has been changed to "Check
to show this attribute in the brief information panel in the patron's
record (staff client)."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:16:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:16:30 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-4gqLIVQX2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from David Roberts <david.roberts at ptfs-europe.com> ---
I've fixed the patch, please try again! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:38:16 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-OKtwV0BG9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #106 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>3) It appears to break when Elasticsearch is activated in a non-good way. >Switching the number of results made the OPAC load forever for me showing a >white page. Then it started to work, but the number of pages doesn't change.
>Can you please check? If we can't make this work, we should at least add a note >to the pref and keep it from showing up with Elasticsearch active. 

I have retested and can't find any issues with Elasticsearch - I think the
problems I found earlier were probably an issue in my installation. I am
proposing a PQA with a follow-up removing the code that makes this Zebra only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:40:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:40:35 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-mahb98xURu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:40:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:40:44 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-jTmOoBAgny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99684|0                           |1
        is obsolete|                            |

--- Comment #107 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101775&action=edit
Bug 14715: Results per page dropdown for catalogue search

This patch utilises an unused search facet to handle results shown per
page.

Sponsored-by: Region Halland
Signed-off-by: Gabriel DeCarufel <gabriel at inlibro.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:40:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:40:54 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-4yzT3FbRYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99685|0                           |1
        is obsolete|                            |

--- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101776&action=edit
Bug 14715: (follow-up) Keep results per page setting when selecting facets and
sorting results

Also adding missing filters

ALSO ensuring you can switch back to library default on staff side

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:41:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:41:01 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-EqJGF1P01v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #109 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101777&action=edit
Bug 14715: (QA follow-up) Add missing filters

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:41:08 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-iuk46elKRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #110 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101778&action=edit
Bug 14715: (QA follow-up) Remove limit on Zebra

Found in testing that this appears to work well for Elasticsearch -
so removing everything that made this Zebra only.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:44:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:44:15 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-1BbwXQoBHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 21:44:18 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-c4OkEzlYRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101582|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 101779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101779&action=edit
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one
or more claims

ClaimReturnedWarningThreshold is supposed to display a warning if a patron has
more than the number of claims specified in the system preference. Currently
the warning is displayed for any number of claims over zero.

Test Plan:
1) Make 3 return claims for a patron
2) Set ClaimReturnedWarningThreshold to 4
3) Note the claims warning displays for the patron on circulation.pl
4) Apply this patch
5) Reload circulation.pl, the warning should go away
6) Set ClaimReturnedWarningThreshold to 2
7) Reload the page, the warning should reappear

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:01:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 22:01:28 +0000
Subject: [Koha-bugs] [Bug 24982] New: Use checkboxes in Log Viewer instead
 of select dropdowns
Message-ID: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

            Bug ID: 24982
           Summary: Use checkboxes in Log Viewer instead of select
                    dropdowns
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

The Log Viewer uses select dropdowns. You are able to select more than one
option at a time but it isn't clear that you can do this. Also the size of the
dropdown means options are squashed and you have to scroll to see all of your
options/selections.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:02:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 22:02:10 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-81KdeRri7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97984|0                           |1
        is obsolete|                            |

--- Comment #15 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 101780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101780&action=edit
Bug 24475: Reword FinesMode system preference

This patch changes the wording of the FinesMode and
CalculateFinesOnReturn system preferences explanations

1) Install Patch
2) Check that the wording of the FinesMode system preference has changed
to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
and final fines will be calculated when the cron runs and accruing fines
will be finalized when an item is returned. If CalculateFinesOnReturn is
enabled, final fines will be calculated when an item is returned."
3) Check that the wording of the CalculateFinesOnReturn system
preference has changed to add "NOTE: This system preference requires
FinesMode to be set to 'Calculate and charge.'" to the existing note.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:02:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 22:02:53 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-hwKNOWm4cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:03:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2020 22:03:28 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-1N9WUWgTR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #16 from David Roberts <david.roberts at ptfs-europe.com> ---
Third time lucky (hopefully!).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:09:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 00:09:11 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ohuCmcVGku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Claudio <costalc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costalc at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:22:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 00:22:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-I42VuknNqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #73 from David Cook <dcook at prosentient.com.au> ---
This sounds odd. What's a volume mean in this context?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:13:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:13:29 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-QLFGySY9en@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:13:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:13:33 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-ZJzXRw41Nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101781&action=edit
Bug 24982: Use checkboxes in Log Viewer

So we can see all options at once, and more easily select more than one
option.

Test plan:
1) Go to Tools -> Log viewer
2) Notice the new checkboxes under Modules, Actions and Interface. 'All'
should be selected by default for all three options
3) Confirm you can deselect 'All' and the other options are enabled.
Confirm selection all of the other options automatically selects 'All'
and disables the options again.
4) Confirm the results still work as expected when clicking 'Submit'
button

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:17:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:17:37 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-wMPzm6htGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Who signed the|                            |This patch changes the
          patch off|                            |dropdowns in the Log Viewer
                   |                            |to checkboxes so that the
                   |                            |user can see all of their
                   |                            |available options and
                   |                            |select multiple options
                   |                            |more easily.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:17:53 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-LAOtHbU321@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch changes the
      release notes|                            |dropdowns in the Log Viewer
                   |                            |to checkboxes so that the
                   |                            |user can see all of their
                   |                            |available options and
                   |                            |select multiple options
                   |                            |more easily.
     Who signed the|This patch changes the      |
          patch off|dropdowns in the Log Viewer |
                   |to checkboxes so that the   |
                   |user can see all of their   |
                   |available options and       |
                   |select multiple options     |
                   |more easily.                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:44:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:44:05 +0000
Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by
 librarian
In-Reply-To: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20453-70-nZWFOyQASd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
The patch doesn't apply in my test environment :-(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:46:23 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-ta2d5IuE3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101781|0                           |1
        is obsolete|                            |

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101782&action=edit
Bug 24982: Use checkboxes in Log Viewer

So we can see all options at once, and more easily select more than one
option.

Test plan:
1) Go to Tools -> Log viewer
2) Notice the new checkboxes under Modules, Actions and Interface. 'All'
should be selected by default for all three options
3) Confirm you can deselect 'All' and the other options are enabled.
Confirm selection all of the other options automatically selects 'All'
and disables the options again.
4) Confirm the results still work as expected when clicking 'Submit'
button

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:58:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 01:58:40 +0000
Subject: [Koha-bugs] [Bug 24320] Remove ending . from XSLT result templates
In-Reply-To: <bug-24320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24320-70-fP34qTczQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24320

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 04:16:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 03:16:24 +0000
Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions
 dropdown menu in Z39.50 search to decrease clicks
In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22579-70-BKIub14Y6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86997|0                           |1
        is obsolete|                            |

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101783&action=edit
Bug 22579: Split actions in z3950 search results into a split button

Where 'Import' is the main button and the two card previews are in the
dropdown

Also show Card preview when clicking on title of record

To test:
1) Go to Cataloguing -> New from Z39.50/SRU
2) Search for a term that will produce results
3) Once results are shown, notice the split button
4) Click anywhere on results rows. Confirm the dropdown menu still shows
when you click anywhere, as normal
5) Confirm clicking the title pops up the Card preview
6) Confirm Import is the main button in the actions and still works as
expected

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 04:18:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 03:18:05 +0000
Subject: [Koha-bugs] [Bug 22579] Split actions in z3950 search results so
 Import is the main action and make clicking title pop up Card Preview
In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22579-70-NnyTg6W82z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add syspref to toggle       |Split actions in z3950
                   |expanding Actions dropdown  |search results so Import is
                   |menu in Z39.50 search to    |the main action and make
                   |decrease clicks             |clicking title pop up Card
                   |                            |Preview
  Change sponsored?|---                         |Sponsored
                 CC|                            |aleisha at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 04:18:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 03:18:48 +0000
Subject: [Koha-bugs] [Bug 22579] Split actions in z3950 search results so
 Import is the main action and make clicking title pop up Card Preview
In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22579-70-qIPhfaLDcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

--- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
This is almost ready, but I am struggling to get rid of the whitespace showing
between the two buttons in the button group. If anyone knows what I'm doing
wrong here please let me know!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 05:05:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 04:05:29 +0000
Subject: [Koha-bugs] [Bug 24984] New: ZED TERSAKITI
Message-ID: <bug-24984-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24984

            Bug ID: 24984
           Summary: ZED TERSAKITI
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dayudandi72 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101784&action=edit
TERSAKITI

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 05:14:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 04:14:05 +0000
Subject: [Koha-bugs] [Bug 24985] New: ZED TERSAKITI
Message-ID: <bug-24985-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24985

            Bug ID: 24985
           Summary: ZED TERSAKITI
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dayudandi72 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101785&action=edit
TERSAKITI

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:28:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 08:28:08 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-qEFziuw1yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101786&action=edit
Bug 24975: Keep the translations, prevent duplicates, and other fixes

Translations are no longer lost when you change an itemtype's
description, thanks to a new `l10n_source.key` column which must be
unique within it's "text group" ('itemtype' is a text group)
This also prevent duplicate entries in l10n_source

Columns were renamed to better match their purpose:
* context -> group
* source -> text

Use Koha::Cache::Memory::Lite if other caching systems are not available

Prepend 'l10n:' to the cache key to avoid conflicts

Test plan:
1. DROP TABLE IF EXISTS l10n_target, l10n_source
2. Follow the test plan from previous patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:34:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 08:34:02 +0000
Subject: [Koha-bugs] [Bug 24983] SPAM
In-Reply-To: <bug-24983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24983-70-3hkJHQpSJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24983

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org
              Group|Koha security               |
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:34:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 08:34:50 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-YztwrhwShW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle at bywatersolutions.com   |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:40:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 08:40:45 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-hv7CRXYORx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:01:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:01:05 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-s6SqezCSc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101787&action=edit
Bug 24801: Display all the libraries - Selenium fix

Same as for categories.

22:41:28 koha_1       | STRACE: /usr/share/perl5/Try/Tiny.pm:104 in
Selenium::Remote::Driver::catch {...}
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:353 in Try::Tiny::try
22:41:28 koha_1       |         (eval 1337):1 in
Selenium::Remote::Driver::__ANON__
22:41:28 koha_1       |         (eval 1339):2 in
Selenium::Remote::Driver::__ANON__
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in
Selenium::Remote::Driver::_execute_command
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in (eval)
22:41:28 koha_1       |         /kohadevbox/koha/t/lib/Selenium.pm:174 in
Selenium::Remote::Driver::find_element
22:41:28 koha_1       |         /kohadevbox/koha/t/lib/Selenium.pm:166 in
t::lib::Selenium::click_when_visible
22:41:28 koha_1       |        
t/db_dependent/selenium/administration_tasks.t:128 in t::lib::Selenium::click
22:41:28 koha_1       |
22:41:28 selenium_1   | 14:41:28.273 INFO - Executing: [take screenshot])
22:41:28 selenium_1   | 14:41:28.873 INFO - Done: [take screenshot]
22:41:31 koha_1       |
22:41:31 koha_1       | SCREENSHOT:
https://framapic.org/0nvX5dhLHpU1/tAEnENSeLRXB
22:41:31 koha_1       | An element could not be located on the page using the
given search parameters: //div[@class="main
container-fluid"]//a[contains(@href,
"/admin/branches.pl?op=add_form&branchcode=UT_BC")],xpath at
/kohadevbox/koha/t/lib/Selenium.pm line 174.

The screenshot was obvious, the UT_BC was not on the first page.
There was a total of 33 libraries at this point, which is not expected,
maybe data not deleted from previous selenium tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:02:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:02:38 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories/libraries displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-jcIbhnwpUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|selenium/administration_tas |selenium/administration_tas
                   |ks.t failing if too many    |ks.t failing if too many
                   |categories displayed        |categories/libraries
                   |                            |displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:02:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:02:51 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories/libraries displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-RbbmEuPLCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:11:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:11:28 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-9MpEoWe891@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Blocks|                            |5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:11:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:11:28 +0000
Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints
In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5334-70-QkD0HcittO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22887


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887
[Bug 22887] authorised_values is missing a unique constraint on category +
authorised_value
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:12:41 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-67XHzuO14s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
+1

But does the updatedb work if there are already duplicate values ?
installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql insert duplicate
values for instance (COUNTRY, CC)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:23:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:23:27 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-OVT0X6ZC4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|martin.renvoize at ptfs-europe |jonathan.druart at bugs.koha-c
                   |.com                        |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:25:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:25:32 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-cy1DCZPEvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101583|0                           |1
        is obsolete|                            |

--- Comment #12 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 101788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101788&action=edit
follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:26:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:26:20 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-P0YboqGrkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101788|0                           |1
        is obsolete|                            |

--- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 101789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101789&action=edit
Bug 24819: (follow-up) Rename suggestion_search to suggestor_search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:28:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:28:07 +0000
Subject: [Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when
 entering a purchase suggestion
In-Reply-To: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24819-70-q6q00nyhfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #14 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
I re-uploaded the follow-up, patch order is now correct in Bugzilla, git bz
applies the patches in the correct order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:29:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:29:35 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-dBjth0IWwx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101790&action=edit
Bug 22887: Warn if duplicates exist

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:29:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:29:38 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-9bLxBqKEsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101791&action=edit
Bug 22887: Rely on unique constraint in av admin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:37:06 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-H3hyTMZhno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101792&action=edit
Bug 22887: Remove dup in fr-FR av.sql

https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:47:33 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-YjUj6sGtR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:47:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:47:36 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-vJWmOGI07k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101791|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101793&action=edit
Bug 22887: Rely on unique constraint in av admin

Test plan:
Try to create 2 AV with the same code for the same category.
You should see a warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:48:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:48:08 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-EcF8fd46sL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #5)
> Created attachment 101792 [details] [review]
> Bug 22887: Remove dup in fr-FR av.sql
> 
> https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands

Other .sql files seem ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:48:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:48:59 +0000
Subject: [Koha-bugs] [Bug 24986] New: Maximum row size reached soon for
 borrowers and deletedborrowers
Message-ID: <bug-24986-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

            Bug ID: 24986
           Summary: Maximum row size reached soon for borrowers and
                    deletedborrowers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Running updatedatabase.pl I got the following error messages:

DBD::mysql::db do failed: Row size too large. The maximum row size for the used
table type, not counting BLOBs, is 8126. This includes storage overhead, check
the manual. You have to change some columns to TEXT or BLOBs [for Statement
"ALTER TABLE borrowers ADD COLUMN autorenew_checkouts TINYINT(1) NOT NULL
DEFAULT 1 AFTER anonymized"] at installer/data/mysql/updatedatabase.pl li
ne 21259

DBD::mysql::db do failed: Row size too large. The maximum row size for the used
table type, not counting BLOBs, is 8126. This includes storage overhead, check
the manual. You have to change some columns to TEXT or BLOBs [for Statement
"ALTER TABLE deletedborrowers ADD COLUMN autorenew_checkouts TINYINT(1) NOT
NULL DEFAULT 1 AFTER anonymized"] at installer/data/mysql/updatedatabas
e.pl line 21262.

After re-injecting an old clean dump and replaying the updatedatabase.pl errors
are gone, so it was probably   because of other columns coming from patches not
yet in master.
Maybe we should start moving some columns to other tables. An obvious candidate
is all the address fields that can be moved in a patron_addresses table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:50:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:50:44 +0000
Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers
 and deletedborrowers
In-Reply-To: <bug-24986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24986-70-FdXPQlQ2gy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:56:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:56:03 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-qVZB3B19ZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101772|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:57:13 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-9vlGZd9CcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101794&action=edit
Bug 24980: (RM follow-up) Only add timezone if passed a date-time

This patch prevents a timezone from being assigned to the js moment if
the input string is only at the full-date and not date-time resolution

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:57:27 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-Gmex0twJ2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:57:39 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-Ks3OmmOPZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:57:55 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-zmKxQFuVHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
How does that look to you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 09:58:42 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-IpuiXSkbSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Moved followup to bug 24980

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:00:35 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-xVdNjygAeH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:07:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:07:17 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-hBXWp0TDKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

--- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 101795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101795&action=edit
Bug 20648: Attribute option 'Display in check-out' should be renamed

This patch rewords the 'Display in check-out' option in the patron
attribute policy

To test:

1) Apply patch
2) Go to /cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
3) Check that the 8th line down has been renamed to "Display in patron's
brief information:"
4) Check the description of this same option has been changed to "Check
to show this attribute in the brief information panel in the patron's
record (staff client)."

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:07:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:07:54 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-gpWVxLVlBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
(In reply to David Roberts from comment #4)
> I've fixed the patch, please try again! :-)

Thanks for the quick fix!  Works perfectly - signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:08:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:08:15 +0000
Subject: [Koha-bugs] [Bug 24801] selenium/administration_tasks.t failing if
 too many categories/libraries displayed
In-Reply-To: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24801-70-tGNGSYILE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24801

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101787|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101796&action=edit
Bug 24801: Display all the libraries - Selenium fix

Same as for categories.

22:41:28 koha_1       | STRACE: /usr/share/perl5/Try/Tiny.pm:104 in
Selenium::Remote::Driver::catch {...}
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:353 in Try::Tiny::try
22:41:28 koha_1       |         (eval 1337):1 in
Selenium::Remote::Driver::__ANON__
22:41:28 koha_1       |         (eval 1339):2 in
Selenium::Remote::Driver::__ANON__
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in
Selenium::Remote::Driver::_execute_command
22:41:28 koha_1       |        
/usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in (eval)
22:41:28 koha_1       |         /kohadevbox/koha/t/lib/Selenium.pm:174 in
Selenium::Remote::Driver::find_element
22:41:28 koha_1       |         /kohadevbox/koha/t/lib/Selenium.pm:166 in
t::lib::Selenium::click_when_visible
22:41:28 koha_1       |        
t/db_dependent/selenium/administration_tasks.t:128 in t::lib::Selenium::click
22:41:28 koha_1       |
22:41:28 selenium_1   | 14:41:28.273 INFO - Executing: [take screenshot])
22:41:28 selenium_1   | 14:41:28.873 INFO - Done: [take screenshot]
22:41:31 koha_1       |
22:41:31 koha_1       | SCREENSHOT:
https://framapic.org/0nvX5dhLHpU1/tAEnENSeLRXB
22:41:31 koha_1       | An element could not be located on the page using the
given search parameters: //div[@class="main
container-fluid"]//a[contains(@href,
"/admin/branches.pl?op=add_form&branchcode=UT_BC")],xpath at
/kohadevbox/koha/t/lib/Selenium.pm line 174.

The screenshot was obvious, the UT_BC was not on the first page.
There was a total of 33 libraries at this point, which is not expected,
maybe data not deleted from previous selenium tests.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:10:25 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-4xxYIIPd2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101720|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101797&action=edit
Bug 24977: Enable translations for authorised values (POC)

Only a proof of concept to illustrate what's needed to enable
translation for a new kind of object.

Only authorised values retrieved with
Koha::AuthorisedValues->get_descriptions_by_koha_field and
Koha::AuthorisedValues->get_descriptions_by_koha_field are translated.
This is used for instance for shelving locations in
catalogue/itemsearch.pl

Test plan:
1. Run updatedatabase && update_dbix_class_files && reload starman
2. Go to Admin » Localization
3. Find a LOC authorised value and translate it
4. Go to Item search form and verify that it is translated
4. Verify that it is translated in results too

Requires bug 24975

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:10:58 +0000
Subject: [Koha-bugs] [Bug 24987] New: Duplicate code in calendar.inc and
 js-date-format.inc
Message-ID: <bug-24987-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24987

            Bug ID: 24987
           Summary: Duplicate code in calendar.inc and js-date-format.inc
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

At least one internal function is duplicated between the two.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:11:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:11:07 +0000
Subject: [Koha-bugs] [Bug 24987] Duplicate code in calendar.inc and
 js-date-format.inc
In-Reply-To: <bug-24987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24987-70-N8r6ikjn2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24987

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] Date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:11:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:11:07 +0000
Subject: [Koha-bugs] [Bug 24455] Date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-kZ1JEgDsh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24987


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24987
[Bug 24987] Duplicate code in calendar.inc and js-date-format.inc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:13:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:13:02 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-EWLy3kJNLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97830|0                           |1
        is obsolete|                            |
  Attachment #97830|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:13:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:13:44 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-mtxnAt87Nf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101417|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:14:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:14:08 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-N3YlKfSpem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101418|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:16:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:16:30 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-UH7yO9iqS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
As an aside, I still find it strange that we allow time granularly on loans
that are measured in days rather than hours.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:17:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:17:17 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-57xIFsz9Ws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101797|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101798&action=edit
Bug 24977: Enable translations for authorised values (POC)

Only a proof of concept to illustrate what's needed to enable
translation for a new kind of object.

Only authorised values retrieved with
Koha::AuthorisedValues->get_descriptions_by_koha_field and
Koha::AuthorisedValues->get_description_by_koha_field are translated.
This is used for instance for shelving locations in
catalogue/itemsearch.pl

Test plan:
1. Run updatedatabase && update_dbix_class_files && reload starman
2. Go to Admin » Localization
3. Find a LOC authorised value and translate it
4. Go to Item search form and verify that it is translated
4. Verify that it is translated in results too

Requires bug 24975

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:26:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:26:02 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-T2ifyhOT1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #80 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi Nick,
I've been testing the new interface, there are few things that I really like:

- filters (circulation, fines, holds) -> very useful for ease of reading when
lots of rules or when troubleshooting hold rules issues for example.

- remove duplicate rules -> got to spend a bit more time to try that one, does
it have a warning showing the duplicates before removal? that would be great if
there's not :)

- overall presentation is really nice.

Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:27:59 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-7vSGQINlTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #21)
> Martin,
> t/DateUtils.t fails always. 
> An special setup is needed?

Nope.. seems I forgot to check the tests again after than final patch.. looking
at it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:28:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:28:13 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-KuE5KqRW06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you provide a test? I did not manage to write one that fails without your
patch.
I suspect a place where we return () instead of undef

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:28:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:28:21 +0000
Subject: [Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call
 does not return a value
In-Reply-To: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24966-70-Imx7haISc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:42:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:42:56 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-k5RV1Vq7Vm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #81 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Just seen the disclaimer :
"This should not change any circulation behavior, but you will be able to
review these changes before saving."

Nice :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:46:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:46:35 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-VOWzkYhlrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101782|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101799&action=edit
Bug 24982: Use checkboxes in Log Viewer

So we can see all options at once, and more easily select more than one
option.

Test plan:
1) Go to Tools -> Log viewer
2) Notice the new checkboxes under Modules, Actions and Interface. 'All'
should be selected by default for all three options
3) Confirm you can deselect 'All' and the other options are enabled.
Confirm selection all of the other options automatically selects 'All'
and disables the options again.
4) Confirm the results still work as expected when clicking 'Submit'
button

Sponsored-by: Catalyst IT

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:46:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:46:47 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-sEW29Y6uct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:57:27 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-xQazFXV0O7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101780|0                           |1
        is obsolete|                            |

--- Comment #17 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101800&action=edit
Bug 24475: Reword FinesMode system preference

This patch changes the wording of the FinesMode and
CalculateFinesOnReturn system preferences explanations

1) Install Patch
2) Check that the wording of the FinesMode system preference has changed
to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
and final fines will be calculated when the cron runs and accruing fines
will be finalized when an item is returned. If CalculateFinesOnReturn is
enabled, final fines will be calculated when an item is returned."
3) Check that the wording of the CalculateFinesOnReturn system
preference has changed to add "NOTE: This system preference requires
FinesMode to be set to 'Calculate and charge.'" to the existing note.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:58:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:58:10 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-EoGhKQVNBP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:58:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:58:18 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-fM0i4aKlsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99003|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 10:59:25 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-TJUE6TGyrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #82 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Tried the "Cleanup rules" button this way :

Set rule by category (defaults) to 5, 5, 5
Created a new one for "School" with same values.

click on "cleanup rules" -> get the disclaimer, click ok.

after ok, the rule for school still appears with yellowish colors (enabled for
editing I guess?)

if I reload the page, it disappear from the view -> cleanup works.

If I don't reload the page but click on "save" instead, then the rule still
appears, until a full page reload. -> this might lead people to thinks the
rules has not been removed. (solved after a reload).

Overall, the stuff works but the process of reviewing the rules before actual
deletion is not so clear.

Maybe any click on the "save button" could trigger a full page reload to ensure
working with "fresh" data?

Happy to sign-off if this is the expected behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:04:47 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-QrchuzIW9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101773|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101801&action=edit
Bug 24976: Guided report - "Save" button on last step is misleading

This patch changes the text of the save button on the final step.

To test:

1) Build a guided report (the selections are immaterial)
2) Note that after you have been through the six stages, the button on
the "Confirm custom report" screen should be labelled "Save"
3) Install patch
4) Repeat Step 1. Note that on the "Confirm custom report" screen, the
button is now labelled "Next".
5) Run the report to check that the functionality still works.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:05:03 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-QGcCWl6gYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:10:21 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-VDKcIJDFi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:10:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:10:24 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-66EVABE2b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101802&action=edit
Bug 24840: Replace DateTime->now with dt_from_string

We should use Koha::DateUtils instead of Date::Time directly

This patch simplay replaces calls to now() with a call to dt_from_string()
which does effectively the same thing.

Probably reading the code and verifying changes is sufficient but...

To test:
1 - confirm the files all compile
2 - confirm all tests pass
3 - confirm Koha still works

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:13:25 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-ARrX7KTk85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #83 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Also just tried the "Rules per categories and itemtype" section.
When there are a lot of rules it's still tough to read which field one is
editing.
Would be great to reproduce something like this :
http://output.jsbin.com/AjiJIGA/1

Nice to have one edit button on each field though.

The interrogation mark helps to find out from which rules the value is
inherited, would be useful to have as well the field name in there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:20 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-DHDg50hwlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100901|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101803&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:23 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-7K0VWI0rFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100902|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101804&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:27 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-T0FVCYSmP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100903|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101805&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:30 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-6BzsdjFK2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100904|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101806&action=edit
Bug 24850: Don't fallback when date_format is passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:33 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-hMB6TFwkLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100905|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101807&action=edit
Bug 24850: Always return 'instance' local time

This patch adds handling to ensure we always convert a passed in time to
the instance configured timezone..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:14:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:14:36 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-wHKz1Q60Y4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101808&action=edit
Bug 24850: Continue to handle default time and daylight saving

This patch prevents the call to set_time_zone if we are handling a
dateonly datetime string or a DST time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:17:45 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-xcQ1jIlFVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #84 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Also just tried the "Rules per categories and itemtype" section.
When there are a lot of rules it's still tough to read which field one is
editing.
Would be great to reproduce something like this :
http://output.jsbin.com/AjiJIGA/1

Nice to have one edit button on each field though.

The interrogation mark helps to find out from which rules the value is
inherited, would be useful to have as well the field name in there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:21:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:21:47 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-tTuvmaEsc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:25:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:25:40 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-2PWt5GtkID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:25:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:25:43 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-SRI5Yh7GEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101801|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101809&action=edit
Bug 24976: Guided report - "Save" button on last step is misleading

This patch changes the text of the save button on the final step.

To test:

1) Build a guided report (the selections are immaterial)
2) Note that after you have been through the six stages, the button on
the "Confirm custom report" screen should be labelled "Save"
3) Install patch
4) Repeat Step 1. Note that on the "Confirm custom report" screen, the
button is now labelled "Next".
5) Run the report to check that the functionality still works.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:31:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:31:17 +0000
Subject: [Koha-bugs] [Bug 24487] build_query_params helper builds path
 parameter with matching criteria
In-Reply-To: <bug-24487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24487-70-gUL23GJqrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Koha                        |REST API
            Product|Koha security               |Koha
            Version|unspecified                 |master
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:31:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:31:49 +0000
Subject: [Koha-bugs] [Bug 24333] AutoSelfCheckPass needs to be masked
In-Reply-To: <bug-24333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24333-70-pxLyAtyu3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24333

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
                 CC|                            |dpavlin at rot13.org
          Component|Koha                        |Authentication
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:31:55 +0000
Subject: [Koha-bugs] [Bug 24333] AutoSelfCheckPass needs to be masked
In-Reply-To: <bug-24333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24333-70-GWezwh721i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24333

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:34:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:34:47 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-UFshBIqeYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:34:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:34:50 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-IJJgzl1Uhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101809|0                           |1
        is obsolete|                            |

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 101810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101810&action=edit
Bug 24976: Guided report - "Save" button on last step is misleading

This patch changes the text of the save button on the final step.

To test:

1) Build a guided report (the selections are immaterial)
2) Note that after you have been through the six stages, the button on
the "Confirm custom report" screen should be labelled "Save"
3) Install patch
4) Repeat Step 1. Note that on the "Confirm custom report" screen, the
button is now labelled "Next".
5) Run the report to check that the functionality still works.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:36:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:36:57 +0000
Subject: [Koha-bugs] [Bug 24878] Authentication check missing on calendar
 tools
In-Reply-To: <bug-24878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24878-70-oeLmlnaGPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24878

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org
          Component|Koha                        |Authentication
            Version|unspecified                 |master
            Product|Koha security               |Koha
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:37:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:37:16 +0000
Subject: [Koha-bugs] [Bug 24673] CSRF vulnerability in opac-messaging.pl
In-Reply-To: <bug-24673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24673-70-hDbWVKBwjp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24673

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
            Product|Koha security               |Koha
                 CC|                            |dpavlin at rot13.org
            Version|unspecified                 |master
          Component|Koha                        |Authentication

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:30 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-xAapjfVODX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:31 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-zBljep825Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:33 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-MltL8fZSnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:35 +0000
Subject: [Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always
 triggered if patron has one or more claims
In-Reply-To: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24829-70-sax8MOqNZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:37 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-OSBrFBcCQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:40:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:40:39 +0000
Subject: [Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
In-Reply-To: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24959-70-KTSqwyDrbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:42:48 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-lUeKC6NOrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:42:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:42:51 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-FnAnFLnXmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101800|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101811&action=edit
Bug 24475: Reword FinesMode system preference

This patch changes the wording of the FinesMode and
CalculateFinesOnReturn system preferences explanations

1) Install Patch
2) Check that the wording of the FinesMode system preference has changed
to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
and final fines will be calculated when the cron runs and accruing fines
will be finalized when an item is returned. If CalculateFinesOnReturn is
enabled, final fines will be calculated when an item is returned."
3) Check that the wording of the CalculateFinesOnReturn system
preference has changed to add "NOTE: This system preference requires
FinesMode to be set to 'Calculate and charge.'" to the existing note.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:43:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:43:02 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-3teN8mFhiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101812&action=edit
Bug 24475: Cronjobs don't always live in misc

In git installs, cronjobs live in misc, but for package installs, they
live under bin. Let's just still with 'misc/cronjobs' which is always
cromulent.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:43:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:43:54 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-Uq2tHJYI23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is it planned to put this in 18.11 as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:44:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:44:17 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-vpwpi5WRPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:52:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:52:07 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-ETQiZ5ZtTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:52:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:52:49 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-PiUzVrqyA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:52:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:52:52 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-EuCrWNEWF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101668|0                           |1
        is obsolete|                            |

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101813&action=edit
Bug 24964: Add tests

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:53:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:53:30 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-awuGhvI9Xl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101686|0                           |1
        is obsolete|                            |

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101814&action=edit
Bug 24964: Do not filter patrons after they have been fetched

The svc/members/search script is called in different places.
In some places (Set owner for a fund, add users to a fund, or set a
manager to a suggestion), we need patrons to be filtered depending on
the permissions they have.
For instance you can only set a fund's owner with a patron that has
acquisition.order_manage.

Currently we have fetching X (default 20) patrons, then filter them
depending on their permission.
Says you have 3 patrons that have the correct permissions but are not in
the 20 first patrons, if you do not define a search term, the search
result will be empty.

This is not ideal and we should filter when requesting the DB.

Test plan:
- Have more than 20 patrons, remove them their permissions
- Create 3 more:
1 superlibrarian
1 with the full acq permission
1 with acquisition.order_manage
- Create a fund and set a owner
- Search for patrons, without specifying a search term (to get them all)
=> Without this patch the new patrons you created are not displayed
=> With this patch they are!

Same test plan apply to set a manager to a suggestion (freshly pushed,
see bug 23590), with suggestions and suggestions.suggestions_manage

Note: The code has been written that way to rely on
C4::Auth::haspermission, but the SQL query is quite trivial and the gain
is important.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:53:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 11:53:48 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-4EKD0cbQJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101702|0                           |1
        is obsolete|                            |

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101815&action=edit
Bug 24964: Prevent random failures sorting by borrowernumber

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:00:19 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-eraurG61xf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100787|0                           |1
        is obsolete|                            |

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101816&action=edit
Bug 15668: Add column configuration to the items table in staff detail pages

To test:
1 - Apply patches
2 - View biblio details in staff client
3 - Should be able to toggle columns
4 - Go to admin columns settings
5 - Change some settings, verify they work
6 - Enable SeparateHoldings
7 - Go to a record that has holdings from 2 different branches
8 - Change some settings, verify they work.
9 - Check the Other Holdings Tabs, change some settings make sure they work.
10. - Test all the dataTable functions like the search box, columns, export.
make sure they on both tabs

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:00:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:00:22 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-JddkL12iWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100805|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101817&action=edit
Bug 15668: (follow up) add selector to th

follow up add a selector to the <th> to ensure we count the table in questions.
Should not affect other pages but is needed on detail.tt where there are two
tables to configure

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:00:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:00:47 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-qoZ7dWF0wg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:02:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:02:46 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-JfqwCaAi8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:02:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:02:48 +0000
Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by
 GetRecords ILS-DI service
In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21301-70-f1GhiZ4tMy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101818&action=edit
Bug 21301: (follow-up) Remove borrowernumber in issues for GetRecords ILS-DI
service

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:02:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:02:50 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-HrCFVo5qx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:02:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:02:52 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-CuYso2LSsl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:02:54 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-WM2JBCOf84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:03:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:03:55 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-bhj67TeoRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:04:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:04:00 +0000
Subject: [Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron
 entry form
In-Reply-To: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16457-70-h5N1peZZf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:04:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:04:02 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-8PXN7QsU5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:04:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:04:03 +0000
Subject: [Koha-bugs] [Bug 20399] Remove "did you mean" for the staff
 interface
In-Reply-To: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20399-70-PHkO729t34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:04:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:04:05 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-eOBbtWjoY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:04:08 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-OdRB8RjO53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:08:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:08:33 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-pyYTUuZCVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Small typo :

 =head2 ModReserveAffect

-  &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id);
+  &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id,
$desk);

 sub ModReserveAffect {
-    my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id ) = @_;
+    my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id, $desk_id )
= @_;

Doc line should say $desk_id instead of $desk right ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:10:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:10:05 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-qjwD2tD0KR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:10:14 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-aPMNKlCUWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:10:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:10:24 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-Vubdv9D4rL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:10:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:10:57 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-SxAFq7S8Ik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for picking this up Julian, it's looking great so far! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:13:36 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-x8MbSyFFPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:16:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:16:11 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-VjUr7mwucD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
In my opinion, we should avoid adding LoginDeskname to get_template_and_user
and use the template plugin Desks by adding GetLoggedInDeskName().

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:16:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:16:28 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-d0H3ndjNZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:16:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:16:31 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-uJfFjHlmib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101774|0                           |1
        is obsolete|                            |
 Attachment #101795|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101819&action=edit
Bug 20648: Attribute option 'Display in check-out' should be renamed

This patch rewords the 'Display in check-out' option in the patron
attribute policy

To test:

1) Apply patch
2) Go to /cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
3) Check that the 8th line down has been renamed to "Display in patron's
brief information:"
4) Check the description of this same option has been changed to "Check
to show this attribute in the brief information panel in the patron's
record (staff client)."

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:16:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:16:36 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-LyAm58kHQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:17:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:17:11 +0000
Subject: [Koha-bugs] [Bug 24499] sys pref EnhancedMessagingPreferences if
 set to Don't Allow does not even show within Patron Categories
In-Reply-To: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24499-70-oaDMS4A7Pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
The issue here is that when off a patron can still receive notifications if
their messaging preferences have been set, but you will not be able to see this
in the interface.

Additionally, the description implies that this simply prevents staff from
editing the preferences, however, if you set the defaults for a category, then
disable EnhancedMessagingPreferences the default are not respected/

Essentially, when this is disabled it can be hard to determine if a patron will
receive a notice or not.

Additionally - if EnhancedMessagingPreferencesOPAC is set to show, which also
grants editing, but staff side is set to don't allow, it does not show (or
allow editing)

I think a solution would be a new preference:
EnhancedMessaging - Send/Don't send patron circulation messages (holds, dues,
predues,checkin,checkout)

Reword other prefs to indicate they affect editing

Show the settings for patrons on the staff client whether they can be edited or
not and show default settings and allow their setting unless EnhancedMessaging
is disabled

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:20:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:20:50 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-lNVLOFqPWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:27:59 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-PHfuLOWXLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #74 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
A volume is a grouping of items within a bib. See bug 24860 for one
implementation (patrons can place hold on a volume, get first available item
within that volume). Imagine, say, a bib containing multiple copies of a
multi-volume series. Patron wants whichever copy of Book 1 comes in first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:35:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:35:19 +0000
Subject: [Koha-bugs] [Bug 24988] New: autorenew_checkouts should default to
 yes
Message-ID: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

            Bug ID: 24988
           Summary: autorenew_checkouts should default to yes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

TO recreate:
Create a new patron
Note that 'Allow auto-renewal of items' defaults to 'no'
This is a regression caused by bug 24476

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:38:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:38:17 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-gsip00RAWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:51:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:51:09 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-wAPj5MdwUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
There are 2 patches :
Bug 23888: Do not allow invalid vendor id on creating a subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:54:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:54:20 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-5REKVLAjVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:54:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:54:22 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-9WnNuanRLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101813|0                           |1
        is obsolete|                            |
 Attachment #101814|0                           |1
        is obsolete|                            |
 Attachment #101815|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101820&action=edit
Bug 24964: Add tests

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:54:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:54:33 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-nixfS34Q8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101821&action=edit
Bug 24964: Do not filter patrons after they have been fetched

The svc/members/search script is called in different places.
In some places (Set owner for a fund, add users to a fund, or set a
manager to a suggestion), we need patrons to be filtered depending on
the permissions they have.
For instance you can only set a fund's owner with a patron that has
acquisition.order_manage.

Currently we have fetching X (default 20) patrons, then filter them
depending on their permission.
Says you have 3 patrons that have the correct permissions but are not in
the 20 first patrons, if you do not define a search term, the search
result will be empty.

This is not ideal and we should filter when requesting the DB.

Test plan:
- Have more than 20 patrons, remove them their permissions
- Create 3 more:
1 superlibrarian
1 with the full acq permission
1 with acquisition.order_manage
- Create a fund and set a owner
- Search for patrons, without specifying a search term (to get them all)
=> Without this patch the new patrons you created are not displayed
=> With this patch they are!

Same test plan apply to set a manager to a suggestion (freshly pushed,
see bug 23590), with suggestions and suggestions.suggestions_manage

Note: The code has been written that way to rely on
C4::Auth::haspermission, but the SQL query is quite trivial and the gain
is important.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:54:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:54:36 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-ePU9PN6va1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101822&action=edit
Bug 24964: Prevent random failures sorting by borrowernumber

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:54:39 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-RZ1wXFVcpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101823&action=edit
Bug 24964: Fix perl critic warning

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:58:47 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-LczSqO20gm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101824&action=edit
Bug 24982: (follow-up) Give checkboxes more structured layout

This patch makes minor markup changes and adds some CSS so that the
module and actions checkboxes are laid out a little more clearly.

The patch includes some whitespace changes, so diff accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:59:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 12:59:12 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-rBM1AcZbh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |`UseKohaPlugins` system
      release notes|                            |preferences is removed,
                   |                            |Koha plugins now only
                   |                            |depends on config key
                   |                            |`enable_plugins`.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:00:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:00:11 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-3Ou3AtIYgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:00:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:00:18 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-XJ4BhOiXFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|`UseKohaPlugins` system     |`UseKohaPlugins` system
      release notes|preferences is removed,     |preferences is removed.
                   |Koha plugins now only       |Koha plugins now only
                   |depends on config key       |depends on config key
                   |`enable_plugins`.           |`enable_plugins`.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:03:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:03:35 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-vBDX5Z7WU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Nick Clemens from comment #22)
> 
> Probably a good compromise is to generate the mapping file from this bug
> once it passes QA and use the exported file as the default from now on.
> Consider it a cleanup of the file

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:05:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:05:12 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-cJ9YoSjlFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:07:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:07:23 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-zmK6y04mbr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95253|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:07:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:07:33 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-ilu4Z8yJaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95297|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:11:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:11:36 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-KuolJ22Wch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
This causes a behaviour change
 1 - This sets all patrons to want auto_renewal notices in digest form
 2 - The script requires '--digest' if the borrower wants digest or nothing is
sent
We should default to all patrons want auto_renewals but not digest
This could be combined too with bug 23787 where we add the 'AUTO_RENEWAL'
notice - if combined we could update borrowers to receive the notice if it
already exists, and insert it but do not set borrowers to receive the notice if
it does not exist

When running with the default notice the content is wrong, I think you want:
Dear [% borrower.firstname %] [% borrower.surname %],

        [% IF error %]
        There were [% error %] items that were not correctly renewed.
        [% END %]
        [% IF success %]
        There were [% success %] items that were correctly renewed.
        [% END %]


Additionally - the current code does not seem to allow for the inclusion of
item specific information in the notices, I would say this is a blocker.

Copyright line in auto-renewals is malformed in these patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:18:12 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-35PjP7wWyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101723|0                           |1
        is obsolete|                            |

--- Comment #14 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101825&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:18:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:18:52 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-7N5CSRRB0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #15 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Fridolin SOMERS from comment #13)
> Small typo :
> 
>  =head2 ModReserveAffect
>  
> - 
> &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id);
> + 
> &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend,$reserve_id,
> $desk);
> 
>  sub ModReserveAffect {
> -    my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id ) = @_;
> +    my ( $itemnumber, $borrowernumber, $transferToDo, $reserve_id, $desk_id
> ) = @_;
> 
> Doc line should say $desk_id instead of $desk right ?

right, thank you Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:25:09 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-QU2tyqcj84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:25:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:25:13 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-0Vpma9GbpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98964|0                           |1
        is obsolete|                            |

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101826&action=edit
Bug 23888: (follow-up) Wrap English string in translation function

This patch makes alert added in subscription-add.js translatable using
the new __() function.

To test, apply the patch and confirm that the alert still works
correctly when submitting the subscription edit form with an invalid
vendor id.

Test that the string can be translated (using fr-Fr for example):

1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR

Switch to the fr-FR translation and confirm the the alert shows your
translated string.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:38 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-MzVl9ywRtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101744|0                           |1
        is obsolete|                            |
 Attachment #101745|0                           |1
        is obsolete|                            |
 Attachment #101746|0                           |1
        is obsolete|                            |
 Attachment #101747|0                           |1
        is obsolete|                            |
 Attachment #101748|0                           |1
        is obsolete|                            |
 Attachment #101749|0                           |1
        is obsolete|                            |
 Attachment #101750|0                           |1
        is obsolete|                            |
 Attachment #101751|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101827&action=edit
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a
specific volume of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item
level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:45 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-EFuHsuB179@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #13)
> There are 2 patches :
> Bug 23888: Do not allow invalid vendor id on creating a subscription

Ok fixed thanks ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:47 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-UcptpzqcfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101828&action=edit
Bug 24860: Add new syspref EnableVolumeHolds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:49 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-IkMLEcgrjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101829&action=edit
Bug 24860: Implement reserves.volume_id

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:52 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-KnuImkirto@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101830&action=edit
Bug 24860: Add ability to select a volume when placing a hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:56 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-gkrT8pUdZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101831&action=edit
Bug 24860: Add ability to select a volume when placing a hold - OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:27:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:27:58 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-THufSr3xxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101832&action=edit
Bug 24860: Skip non-matching volume holds in CheckReserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:28:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:28:01 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-6qd3RMPEVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101833&action=edit
Bug 24860: Skip non-matching volume holds in HoldsQueue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:28:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:28:04 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-g9a1a2XZKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101834&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:28:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:28:06 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-LX9h5gQwXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101835&action=edit
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:28:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:28:15 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-UWjayDBUSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
New translation sysptem in JS files is great !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:29:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:29:54 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-6bFwXOMlhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #18 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Hoi Frido,

(In reply to Fridolin SOMERS from comment #17)
> In my opinion, we should avoid adding LoginDeskname to get_template_and_user
> and use the template plugin Desks by adding GetLoggedInDeskName().

I tried to mimic existing code and I'm not really confident on how it works and
how it should work. If there are others thinking the way you hint to is better,
I have nothing to say to oppose it and will be glad to adapt the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:37:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:37:58 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-mf1GKR9BIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kohadevinim at devinim.com.tr
                   |ity.org                     |
                 CC|                            |kohadevinim at devinim.com.tr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:39:36 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-lECrzPqTjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
At first glance I'd say you don't need the "unfiltered" param in the TT plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:39:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:39:41 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-FBI50U6KEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:39:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:39:44 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-dln3ExPm4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101836&action=edit
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:42:08 +0000
Subject: [Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals /
 CanBookBeReserved
In-Reply-To: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24840-70-v5ws3DS7lH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:43:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:43:00 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-aqc9DbpqMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101803|0                           |1
        is obsolete|                            |

--- Comment #29 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101837&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:44:02 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-BtzNiEq7h6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > Bernardo, could we imagine having the sysprefs' values translatable?
> 
> It's in my TODO list, but to translate explanations column.
> 
> In this case it's the values that must be translated.
> Proposal:
> * Split sysprefs.sql into localizable and not localizable parts
>   eg. sysprefs localsysprefs, our choice
> * Put them in /en/ dir
> * rewrite them as yaml, on syspref only translate explanation, on
> localsysprefs explanation and value
> * add strings from sysprefs in xx-YY-installer.po
> * add strings from localsysprefs in it's own po file.
>   This file should contain useful comments so that the translators know what
> values are valid.
> 
> What do you think?

We do not need to translate the explanation, it's not used. So no need to split
them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:44:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:44:12 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-pQ5Adajhrg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101837|0                           |1
        is obsolete|                            |

--- Comment #30 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101838&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:14 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-aDKd8IXBpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:17 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-nvNr49mEHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101804|0                           |1
        is obsolete|                            |
 Attachment #101805|0                           |1
        is obsolete|                            |
 Attachment #101806|0                           |1
        is obsolete|                            |
 Attachment #101807|0                           |1
        is obsolete|                            |
 Attachment #101808|0                           |1
        is obsolete|                            |
 Attachment #101838|0                           |1
        is obsolete|                            |

--- Comment #31 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101839&action=edit
Bug 24850: Correct tests for offset handling in RFC3339 dates

The tests were incorrectly passing for RFC3339 dates passed with an
offset.  This patch corrects the test.

Test plan:
1/ Read the change
2/ Agree the change adheres to the RFC
3/ Run the test and varify it now fails
3/ Signoff

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:21 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-NbBFnfb3LI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #32 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101840&action=edit
Bug 24850: Correct offset handling in dt_from_string

This patch adds correct handling for when an offset is passed within an
RFC3339 formatted datetime.

Test plan
1/ Run the DateUtils test and varify it now passes.

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:25 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-XOQlcQjHqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #33 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101841&action=edit
Bug 24850: Add tests for invalid RFC3339 dates

We should die on invalidly formatted dates being passed.  This patch
adds such a test case.

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:29 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-0ZM0Q1I1pl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #34 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101842&action=edit
Bug 24850: Don't fallback when date_format is passed

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:32 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-oZXESrGCls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #35 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101843&action=edit
Bug 24850: Always return 'instance' local time

This patch adds handling to ensure we always convert a passed in time to
the instance configured timezone..

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:45:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:45:36 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-XUnhqylk4N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #36 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101844&action=edit
Bug 24850: Continue to handle default time and daylight saving

This patch prevents the call to set_time_zone if we are handling a
dateonly datetime string or a DST time

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:46:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:46:22 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-vrZjQm0ZlL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #0)
> In the de-DE installer a sysprefs.sql file is used to make some changes to
> the system preferences for a smoother installation experience. The file can
> be found here:
> 
> http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/
> mysql/de-DE/mandatory/system_preferences.sql;
> h=2692f02b02da9100630a92c4f89fe7caba8ac786;
> hb=7ce4122131a6c3d7f0fe7c953dc95fd5d831bf7f
> 
> It's a mix of:
> - Translating prefs content (HTML prefs, they might go away to news sometime)
> - Localization settings (date format, currency format, time format)
> - Translating pref options (borrower titles and relationships)
> 
> It would be great if there was a way to keep this kind of modifications when
> switching to the new yaml based installer files.

We must split this bug report, there are 2 different requests:
1. Translate the default value of the sysprefs
2. Set predefined settings depending on the region/country/etc

Then it seems we need to define some options, but we need to list exhaustively
which ones are valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:49:18 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-CZPI4zXvQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101845&action=edit
Bug 24982: (follow-up) Move checkboxes to left side of label

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:50:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:50:00 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-m8XYTLD8rc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:50:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:50:05 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-YnlqXJcRGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100668|0                           |1
        is obsolete|                            |

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101846&action=edit
Bug 19475: Add unit tests

To test prove:
t/db_dependent/Holidays.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:50:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:50:34 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-Yp5ZfHzwzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100483|0                           |1
        is obsolete|                            |

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101847&action=edit
Bug 19475: Don't copy holiday if it already exists in target calendar

Calendars copy tool created duplicate values to database.
Holidays in target calendar weren't checked before
inserting new holidays. This patch fixes this.

To test:
1. Add holidays for branch A
2. Copy branch A calendar to branch B
3. Repeat copy to branch B
=> Check database, branch B has now duplicate holidays
4. Delete holidays from branches A and B
5. Apply patch
6. Repeat steps 1-3
=> Check database, no duplicates

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:51:32 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-Oab4QE7jFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101848&action=edit
Bug 24201: (follow-up) Use GetLoggedInDeskName

This patch updates the templates to use the new TT plugin instead of
adding additional variables to the already crouded get_template_and_user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:51:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:51:49 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-kPPzShGmXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Nice work, thanks a lot 🤗

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:52:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:52:23 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-NYqIkbXaFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101836|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101849&action=edit
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:52:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 13:52:34 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-bgymbuzC7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:04:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:04:28 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-kdIG6qCmkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
alternate patch ? Its more a follow-up no ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:14:27 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-qc4zVbbEEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So.. as yet the `Desks.GetName` and `Desks.all` functions aren't used within
this patchset so we could probably just introduce them when they start to be
used.

That could ease this through QA ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:18 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-zNWFDh6CEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100960|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101850&action=edit
Bug 23204: script for exporting Elasticsearch mappings

Test plan:

  - launch perl misc/search_tools/export_elasticsearch_mappings.pl >
    /path/to/my_mappings.yaml
  - set koha-conf.elasticsearch_index_mappings to
    /path/to/my_mappings.yaml,
  - go to admin -> Search engine configuration,
  - click on "Reset mappins",
  - check that your search fields and mappings are as expected

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed commit message

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:22 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-iHwYTHdYgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100961|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101851&action=edit
Bug 23204: move code in a unit tested sub

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:25 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-8hRRnRdqb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100962|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101852&action=edit
Bug 23204: export field weights

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:29 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-yiODKpAsnR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100963|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101853&action=edit
Bug 23204: add exec permission on the script

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:33 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-mKS1244MoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100964|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101854&action=edit
Bug 23204: sort search fields by name

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:37 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-GsAiZqDfyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100965|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101855&action=edit
Bug 23204: (follow-up) also sort by marc field

Test plan :
Launching script several times and see that marc field is alway ordered
increasing

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Same order between runs

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:40 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-tmHqtJnB1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101742|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101856&action=edit
Bug 23204: Fix ordering of fields in exported file

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:45 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-44De6yursD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101857&action=edit
Bug 23204: Update the mappings.yaml file with the output generated

We need to be consistent and provide the mappings.yaml file generated by
the script.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:16:49 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-ZUmI1YV8FX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101858&action=edit
Bug 23204: Adjust copyright and license

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:18:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:18:50 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-RnFmfCD5oX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #31)
> Created attachment 101857 [details] [review]
> Bug 23204: Update the mappings.yaml file with the output generated
> 
> We need to be consistent and provide the mappings.yaml file generated by
> the script.
> 
> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Alex, Nick, can you confirm you agree with that?

If so I think we need a test to make sure further changes will be put into the
correct place in the file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:25:06 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-1dJQQP2uX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:26:46 +0000
Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system
 preferences with new yaml based installer
In-Reply-To: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24973-70-WsSddOgqCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> 
> We do not need to translate the explanation, it's not used. So no need to
> split them.

Yes, I realized that and discarded my own idea.


(In reply to Jonathan Druart from comment #4)
> 
> We must split this bug report, there are 2 different requests:
> 1. Translate the default value of the sysprefs
> 2. Set predefined settings depending on the region/country/etc
> 
> Then it seems we need to define some options, but we need to list
> exhaustively which ones are valid.

My current approach is to rewrite in yaml format only a prefs subset (using
those from DE, but can be defined), then producing a PO file like 

#. Use this to SET sysprefs
#. variable: OpacNav
#. options: 70|10
#. explanation: Use HTML tags to add navigational links to the left-hand
navigational bar in OPAC
#: installer/data/mysql/en//sysprefs.yml:systempreferences:1:row:13:mul:1
msgid "Important links here."
msgstr ""

#. Use this to SET sysprefs
#. variable: BorrowersTitles
#. options: 
#. explanation: Define appropriate Titles for patrons
#: installer/data/mysql/en//sysprefs.yml:systempreferences:1:row:4:mul:1
msgid "Mr|Mrs|Miss|Ms"
msgstr ""

The text after '#.' is shown in pootle as comments to the left of the
translation boxes (see
https://translate.koha-community.org/es/19.11/translate/es-ES-staff-prog.po#unit=10916796)

With po entries like this strings, in it's own file, we cat 'set' values for a
selected group of sysprefs

I'm using a sysprefs.yml file in 'en/' dir, that give us (2.), and its
'translation' (1.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:28:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:28:51 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-Z95sJDraU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

--- Comment #3 from Devinim <kohadevinim at devinim.com.tr> ---
You are faster than us Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:29:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:29:45 +0000
Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in
 hold confirmation dialogs
In-Reply-To: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23433-70-fkNXDnY5cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Yes, I get the same.

When HoldsAutoFill is enabled, the 'hold-found1' modal isn't launched.

Instead, it's 'dialog alert hold-auto-filled' - and this patch doesn't seem to
update that part of returns.tt  

Once that's done, it'll work perfectly. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:37:52 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-zzxfozULIE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101799|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101860&action=edit
Bug 24982: Use checkboxes in Log Viewer

So we can see all options at once, and more easily select more than one
option.

Test plan:
1) Go to Tools -> Log viewer
2) Notice the new checkboxes under Modules, Actions and Interface. 'All'
should be selected by default for all three options
3) Confirm you can deselect 'All' and the other options are enabled.
Confirm selection all of the other options automatically selects 'All'
and disables the options again.
4) Confirm the results still work as expected when clicking 'Submit'
button

Sponsored-by: Catalyst IT

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:37:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:37:55 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-Oe0s6Kt5rZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101824|0                           |1
        is obsolete|                            |

--- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101861&action=edit
Bug 24982: (follow-up) Give checkboxes more structured layout

This patch makes minor markup changes and adds some CSS so that the
module and actions checkboxes are laid out a little more clearly.

The patch includes some whitespace changes, so diff accordingly.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:37:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:37:57 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-GQZww36Mvf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101845|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101862&action=edit
Bug 24982: (follow-up) Move checkboxes to left side of label

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:40:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:40:38 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-ASi6qDRA89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101849|0                           |1
        is obsolete|                            |

--- Comment #4 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 101863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101863&action=edit
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:47:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:47:09 +0000
Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on
 canceling a receipt
In-Reply-To: <bug-12555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12555-70-p64YG9lDC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20271

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:47:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:47:09 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-RturF4Q4Bv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12555

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:50:55 +0000
Subject: [Koha-bugs] [Bug 24990] New: 8080
Message-ID: <bug-24990-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24990

            Bug ID: 24990
           Summary: 8080
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: e77699786 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Created attachment 101864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101864&action=edit
Bct

Emon27 was here!!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:52:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:52:11 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-TWloingyd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101865&action=edit
Bug 24201: (follow-up) Rework Desks Plugin

This patch removes unused plugin methods (they can be re-introduced in
subsequent bugs where they are used) and merges the 'all' and 'defined'
methods into a ListForBranch method that returns a list of desks
associated with the logged in branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:53:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:53:05 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-CTCUA8XGCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hopefully, that'll help get this through the process for you Nicolas :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:55:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:55:54 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-HMKextKRJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #24 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Martin Renvoize from comment #23)
> Hopefully, that'll help get this through the process for you Nicolas :)

sure! thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:57:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:57:31 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-o2sg1Cd99E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kohadevinim at devinim.com.tr  |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:58:52 +0000
Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered
 during indexing on the command line
In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22828-70-Ph1DhxHF0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Waiting for an answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 14:59:04 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-z21YOLNEM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101865|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101866&action=edit
Bug 24201: (follow-up) Rework Desks Plugin

This patch removes unused plugin methods (they can be re-introduced in
subsequent bugs where they are used) and merges the 'all' and 'defined'
methods into a ListForBranch method that returns a list of desks
associated with the logged in branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:04:42 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-hc24Sn9dLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Did not we decided to have ->filter_by_* methods?
I do not think we should introduce this pattern (ie. having filter_by in
parameter), we may end up with huge and complex methods.

However I really like the idea of ->filter_by_* chained methods to filter a
set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:06:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:06:05 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-WgYqPTc500@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #11)
> Did not we decided to have ->filter_by_* methods?
> I do not think we should introduce this pattern (ie. having filter_by in
> parameter), we may end up with huge and complex methods.
> 
> However I really like the idea of ->filter_by_* chained methods to filter a
> set.

I repeated what I said few months ago in comment 6 actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:06:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:06:25 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-RJ67Omwvan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:07:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:07:08 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-zdYsjYEVKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99924|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101867&action=edit
Bug 24765: Updated on date in Claims returned starts off as 12/31/1969

When an item is claimed returned by staff, there is a column called Updated On
- this date field column should remain blank until this claimed returned has
been updated.  Currently, when an item has been claimed returned, the date in
the updated column states 12/31/1969. This date only shows up in the display,
it is doesn't show up in the database like this.

Test Plan:
1) Enable return claims
2) Make a claim
3) Note the 'updated on' column has the date 1969-12-31
4) Apply this patch
5) Reload the page ( you may need to clear your browser cache )
6) Note the field is now blank

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:07:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:07:32 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-4hQzN6V3Ma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98510|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101868&action=edit
Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods

To match PERL15 we change the behavior of Koha::Object methods to make
them use the DBIx::Class relationships.

Test plan:
- Create a vendor, basket and contact
- Edit the vendor => the contact must appears
- Go to the view of a vendor => you cannot delete the vendor, it has
a basket attached
- Create another vendor, without basket
- Go to the view of the vendor => You can delete it

Additionally:
 % prove t/db_dependent/Koha/Acquisition/Booksellers.t
must return green

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:07:58 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-RriYApZ0Ap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
            Version|19.11                       |master
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Confirmed as a bug on master (albeit with the date 01/01/1970).

The patch works, so signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:07:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:07:59 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-Wl7zrUM5mN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, passes QA script and is an obvious improvement.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:08:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:08:16 +0000
Subject: [Koha-bugs] [Bug 24991] New: make restart sip start sip if it isn't
 running
Message-ID: <bug-24991-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991

            Bug ID: 24991
           Summary: make restart sip start sip if it isn't running
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

koha-sip --restart should try to start sip if it is not running.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:10:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:10:09 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-3sJjjYCOVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm happy with this one.. it's important for us to see the errors being
thrown.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:14:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:14:42 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-bRmKFaol69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23204

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Changes to mappings.yaml will need to be rebuilt on top of bug 23204 (sorry!)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204
[Bug 23204] Script for exporting Elasticsearch mappings to YAML
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:14:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:14:42 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-YXVdrIXOvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:15:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:15:22 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-3ZN5VkBlAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:15:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:15:25 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-QbzClHeyoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101860|0                           |1
        is obsolete|                            |
 Attachment #101861|0                           |1
        is obsolete|                            |
 Attachment #101862|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101869&action=edit
Bug 24982: Use checkboxes in Log Viewer

So we can see all options at once, and more easily select more than one
option.

Test plan:
1) Go to Tools -> Log viewer
2) Notice the new checkboxes under Modules, Actions and Interface. 'All'
should be selected by default for all three options
3) Confirm you can deselect 'All' and the other options are enabled.
Confirm selection all of the other options automatically selects 'All'
and disables the options again.
4) Confirm the results still work as expected when clicking 'Submit'
button

Sponsored-by: Catalyst IT

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:16:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:16:13 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-E0FPDYEd9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101870&action=edit
Bug 24982: (follow-up) Give checkboxes more structured layout

This patch makes minor markup changes and adds some CSS so that the
module and actions checkboxes are laid out a little more clearly.

The patch includes some whitespace changes, so diff accordingly.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:16:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:16:16 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-kXFQXglvO2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101871&action=edit
Bug 24982: (follow-up) Move checkboxes to left side of label

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:16:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:16:19 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-dDuRviHISW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101872&action=edit
Bug 24982: (follow-up) Retain checkbox selections after for submit

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:17:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:17:26 +0000
Subject: [Koha-bugs] [Bug 24992] New: Hhjj
Message-ID: <bug-24992-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24992

            Bug ID: 24992
           Summary: Hhjj
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: danufragment at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 101873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101873&action=edit
Asssssss

Hhnbh

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:18:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:18:53 +0000
Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't
 running
In-Reply-To: <bug-24991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24991-70-mYhEnxdmav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:18:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:18:55 +0000
Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't
 running
In-Reply-To: <bug-24991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24991-70-gzzVpnTZZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 101874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101874&action=edit
Bug 24991: make koha-sip --restart start sip if it is not already running.

To test:

- make sure SIP is enabled
 sudo koha-sip --enable inst
- make sure SIP is running
 sudo koha-sip --start inst
 sudo koha-sip --status inst
- restart SIP, make sure it does this normally
 sudo koha-sip --restart inst
- stop SIP, make sure it does this normally
 sudo koha-sip --stop inst
- make sure SIP is not running (wild scenario: oomkiller or similar has killed
this or some other thing has happened)
 sudo koha-sip --status inst
- restart sip, make sure it starts SIP instead of silently failing
 sudo koha-sip --restart inst
- check SIP is now running, or that there is an error message if it can't start
 sudo koha-sip --status inst

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:20:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:20:45 +0000
Subject: [Koha-bugs] [Bug 24993] New: koha-sip --restart is too fast,
 doesn't always start sip
Message-ID: <bug-24993-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993

            Bug ID: 24993
           Summary: koha-sip --restart is too fast, doesn't always start
                    sip
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Sometimes doing koha-sip --restart inst happens too fast and start sip doesn't
start it. A pause in there to let SIP catch up would probably fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:26:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:26:34 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-uDov8fMtJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97106|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101875&action=edit
Bug 24386 - Prevent double form submission on adding orders to basket from a
file

To test:
 1 - Have a marc record file
 2 - Go to Acquisitions, find a vendor, then an open basket
 3 - Add to basket from a new file (if you already have one staged you can
choose that instead)
 4 - Import the file, then add to basket
 5 - On the page where you select the records and set info select a record, set
matching to 'Do not check' fill in the fund for the order
 6 - When ready, click save as many times as you can
 7 - When you go to the basket there are many copies of the order added
 8 - Don't despair, apply the patch
 9 - Repeat above
10 - When ready to add orders, click furiously
11 - The order is only added once!
12 - Success!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:27:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:27:44 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-febrLr9SyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:32:15 +0000
Subject: [Koha-bugs] [Bug 24993] koha-sip --restart is too fast,
 doesn't always start sip
In-Reply-To: <bug-24993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24993-70-m8NMMsXWnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:32:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:32:18 +0000
Subject: [Koha-bugs] [Bug 24993] koha-sip --restart is too fast,
 doesn't always start sip
In-Reply-To: <bug-24993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24993-70-EKf1qzfk0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 101876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101876&action=edit
Bug 24993: add a pause between stopping and starting sip on restart

To test:

- have SIP enabled and running
- issue a restart, make sure it restarts.
 sudo koha-sip --restart inst

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:36:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:36:56 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-1l7xUvYAzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101866|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101877&action=edit
Bug 24201: (follow-up) Rework Desks Plugin

This patch removes unused plugin methods (they can be re-introduced in
subsequent bugs where they are used) and merges the 'all' and 'defined'
methods into a ListForBranch method that returns a list of desks
associated with the logged in branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:44:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:44:39 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-fSrkyPI12a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Emmi, can you explain the changes a bit please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:45:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:45:48 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-zzcM0W9abT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #9)
> Emmi, can you explain the changes a bit please?

ie. it hurts my brain to make sure it will not introduce regression, it will
help me to PQA if you could show me you know what you are doing :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:48:44 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-agLv9qFzXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #117 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
ack.. I attached the followup to entirely the wrong bug.. and got the followup
wrong too!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:53:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:53:21 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-TaoZPlVyBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:53:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:53:24 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-ltwrMS6N4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101848|0                           |1
        is obsolete|                            |

--- Comment #27 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101878&action=edit
Bug 24201: (follow-up) Use GetLoggedInDeskName

This patch updates the templates to use the new TT plugin instead of
adding additional variables to the already crouded get_template_and_user.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:53:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:53:27 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-8vJAE7xF9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101877|0                           |1
        is obsolete|                            |

--- Comment #28 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101879&action=edit
Bug 24201: (follow-up) Rework Desks Plugin

This patch removes unused plugin methods (they can be re-introduced in
subsequent bugs where they are used) and merges the 'all' and 'defined'
methods into a ListForBranch method that returns a list of desks
associated with the logged in branch.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:54:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:54:16 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-7aqOUr3kR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101704|0                           |1
        is obsolete|                            |

--- Comment #29 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101880&action=edit
Bug 24201: Attach desk to intranet session

When Desks are defined, a librarian can attach a desk to its session.

Test plan:

1. apply 13881 and create some desks
2. you should see “NO DESK SET” in the intranet header
3. go to circulation > Set desk
4. you should see your desk name in the header, whatever the page
5. you can also set desk with the header menu

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:54:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:54:19 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-TKxFytEfEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101705|0                           |1
        is obsolete|                            |

--- Comment #30 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101881&action=edit
Bug 24201: (follow-up) Show desk information at lower screen widths

The staff client header menu adjusts responsively to narrower viewport
widths, but for the logged-in-user menu this requires showing and hiding
part of the template which duplicates information. This patch adds a
copy of the current desk information to the part of the template shown
at narrower widths.

To test, apply the patch and view any page in the staff client.

 - Narrow your browser so that the viewport is less than 800px wide.
 - The logged-in-user menu should change from text to a single "user"
   icon.
 - Clicking the icon should display a menu which includes labeled
   information about the current desk.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:54:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:54:23 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-WwffvYOKyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101878|0                           |1
        is obsolete|                            |

--- Comment #31 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101882&action=edit
Bug 24201: (follow-up) Use GetLoggedInDeskName

This patch updates the templates to use the new TT plugin instead of
adding additional variables to the already crouded get_template_and_user.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:54:26 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-tis6EDjiko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101879|0                           |1
        is obsolete|                            |

--- Comment #32 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 101883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101883&action=edit
Bug 24201: (follow-up) Rework Desks Plugin

This patch removes unused plugin methods (they can be re-introduced in
subsequent bugs where they are used) and merges the 'all' and 'defined'
methods into a ListForBranch method that returns a list of desks
associated with the logged in branch.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:55:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:55:47 +0000
Subject: [Koha-bugs] [Bug 24984] SPAM
In-Reply-To: <bug-24984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24984-70-U0bISfOGY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24984

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ZED TERSAKITI               |SPAM
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:56:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:56:45 +0000
Subject: [Koha-bugs] [Bug 24985] SPAM
In-Reply-To: <bug-24985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24985-70-KhC15NX8fs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24985

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ZED TERSAKITI               |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:57:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:57:46 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-E3qSCkoS6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Why are you using bKohaColumnsUseNames?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 15:59:04 +0000
Subject: [Koha-bugs] [Bug 24990] SPAM
In-Reply-To: <bug-24990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24990-70-MKsmyCBoJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
            Summary|8080                        |SPAM
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:01:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:01:10 +0000
Subject: [Koha-bugs] [Bug 24994] New: TableExists should be used instead of
 IF NOT EXISTS in updatedatabase
Message-ID: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

            Bug ID: 24994
           Summary: TableExists should be used instead of IF NOT EXISTS in
                    updatedatabase
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Ooops.. I introduced a series of these during my tenure as RM..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:01:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:01:31 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-tcsu0gWFHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101721|0                           |1
        is obsolete|                            |

--- Comment #16 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101884&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:01:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:01:35 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-Ca1FV6IR8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101722|0                           |1
        is obsolete|                            |

--- Comment #17 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101885&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:01:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:01:38 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-Iv3p37iLpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101825|0                           |1
        is obsolete|                            |

--- Comment #18 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 101886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101886&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:02:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:02:06 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-7OnQETmgGN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101887&action=edit
Bug 24994: Correct DB Updates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:02:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:02:29 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-p3UWaUZSlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I corrected the cases I introduced in this patch..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:02:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:02:44 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-v3Ym5la2J7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:02:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:02:55 +0000
Subject: [Koha-bugs] [Bug 24992] SPAM
In-Reply-To: <bug-24992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24992-70-Q5mm4QfaTI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Hhjj                        |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:08:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:08:47 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-9o69buz6pw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:08:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:08:50 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-mZBENZVXV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101863|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101888&action=edit
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:10:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:10:07 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-xd7mTMFA8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #32 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:11:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:11:54 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-Mi9wmI5SSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oooh.. great to see this one moving.. thanks for following through on it
Jonathan.. I clearly dropped the ball :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:13:28 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-FQMQk9h0KN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89550|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101889&action=edit
Bug 22887: Add unique constraint to authorised_values

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:13:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:13:31 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-RizX1443qT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101790|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890&action=edit
Bug 22887: Warn if duplicates exist

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:13:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:13:34 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-1QZp5JTaih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101792|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101891&action=edit
Bug 22887: Remove dup in fr-FR av.sql

https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:13:36 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-jnoeoZj5Zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101793|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101892&action=edit
Bug 22887: Rely on unique constraint in av admin

Test plan:
Try to create 2 AV with the same code for the same category.
You should see a warning

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:14:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:14:16 +0000
Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique
 constraint on category + authorised_value
In-Reply-To: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22887-70-UezblFzhRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks great to me, signing off :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:25:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:25:37 +0000
Subject: [Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
In-Reply-To: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23914-70-AXjlL7ZYOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I certainly feel this would still be a helpful addition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:27:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:27:17 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-Ra3WYHU7Wm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #34 from Alex Arnaud <alex.arnaud at biblibre.com> ---
> 
> Alex, Nick, can you confirm you agree with that?
> 
> If so I think we need a test to make sure further changes will be put into
> the correct place in the file.

I agree !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:28:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:28:16 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-7x0gnr09PI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101017|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101893&action=edit
Bug 24905: Add missing entry in log4perl-site.conf.in

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:28:19 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-4fChs2NDKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101020|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101894&action=edit
Bug 24905: Make installer update log4perl.conf for instances

This patch makes koha-common.postinst check if the log4perl.conf files
on the instances need tweaking. If they do, it appends the relevant
configuration text.

To test:
1. Install Koha 19.11 or earlier using the packages
2. Create an instance:
   $ koha-create --create-db test1
   $ koha-create --create-db test2
=> FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for
z39.50
3. Apply this patch and run:
   $ docker run \
      --volume=/path/to/your/clone:/koha \
      --volume=/dest/path/for/debs:/debs \
      --privileged
      --env VERSION=19.12.00.047 \
      koha/koha-dpkg:master
Note: Paths need to be adjusted
4. Grab the .deb files and put them on the machine you're testing this
5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text
   at the bottom: log4perl.logger.z3950
6. Install the debs:
   $ sudo dpkg -i koha-perldeps koha-deps koha-common
=> SUCCESS: Install process doesn't explode due to the addition
=> SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for
log4perl.logger.z3950
=> SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for
log4perl.logger.z3950
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:29:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:29:12 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-DDbBreksWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works well in testing.. clear code.. going for a straight QA on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:29:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:29:18 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-uSX0z7LIpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:35:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:35:30 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-qBZ2CumV2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is looking good so far.. and in testing seems to all work for me.

It looks like you are perhaps still working on it together.. or is it ready for
a signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:43:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:43:50 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-XSun9pAh0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan, 

Because that what I see was done in opac-detail.tt. Would you recommend that we
not use it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:47:23 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-4ae0LiAAkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:47:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:47:27 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-h3pK40SJhR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101475|0                           |1
        is obsolete|                            |

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101895&action=edit
Bug 16787: DO NOT PUSH - Schema updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:53:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 16:53:08 +0000
Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when
 adding to basket via file
In-Reply-To: <bug-24469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24469-70-GcafeLie9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #5 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:03:22 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-zNiPURMNtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101549|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101896&action=edit
Bug 19036: Add ability to auto generate a number for account credits

In some areas it's required to sequentially number payment slips /
receipts.

This patch adds a database column accountlines.credit_number and a
system preference AutoCreditNumber to control how this number will be
generated.  The following options are available:

- Do not automatically generate credit numbers.
  This is the current behaviour and the default syspref value.

- Automatically generate credit numbers in the form <year>-0001 (annual)

- Automatically generate credit numbers in the form
  <branchcode>yyyymm0001 (branchyyyymmincr)
  where <branchcode> is the branch where the user (staff member) is
  logged in

- Automatically generate credit numbers in the form 1, 2, 3
  (incremental)

It also adds a column (hidden by default) in the table under
Transactions tab to display this number.

Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
   column credit_number in table account-fines. It will be easier for
   testing
2. Create a manual credit for a borrower. Verify in Transactions tab
   that this credit has no number generated
3. Change syspref 'AutoCreditNumber' to 'incremental'
4. Create more manual credits, and verify that the numbers generated are
   1, 2, 3, ...
5. Change syspref 'AutoCreditNumber' to 'annual'
6. Create more manual credits, and verify that the numbers generated are
   '2020-0001', '2020-0002', ...
7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
8. Create more manual credits, and verify that the numbers generated are
   'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are
   connected to library BRANCHA, and it's February 2020)
9. Set library to another one, say BRANCHB
10. Create more manual credits, and verify that the numbers generated are
    'BRANCHB2020020001', 'BRANCHB2020020002', ...
11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
    somewhere. Go back to Transactions tab and click on 'Print' for one
    line that has a credit number. Make sure the number is there.
12. prove t/db_dependent/Koha/Account.t

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:03:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:03:26 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-TOLI8vA4Gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101550|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101897&action=edit
Bug 19036: Add ability to enable credit number for only some credit types

This feature is disabled by default for all credit types. To enable it
you have to set the syspref AutoCreditNumber to the value of your choice
and then enable the feature for each credit type you want.
System credit types can be modified too (but only this particular field
can be modified)

Also, throw an exception when the feature is enabled and a value for
credit_number has already been set

Updated test plan:
Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
   column credit_number in table account-fines. It will be easier for
   testing
2. Create a manual credit for a borrower. Verify in Transactions tab
   that this credit has no number generated
3. In Admin » Credit types:
  a. edit the FORGIVEN type and enable credit number generation
  b. create a new type A, check "can be manually added" and "enable
     credit number"
  c. create a new type B, check "can be manually added". Do NOT enable
     credit number
4. Change syspref 'AutoCreditNumber' to 'incremental'
5. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
6. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are 1, 2, 3, ...
7. Change syspref 'AutoCreditNumber' to 'annual'
8. Create more manual credits with types CREDIT and B, and verify that
   the numbers are not generated
9. Create more manual credits with types FORGIVEN and A, and verify that
   the numbers generated are '2020-0001', '2020-0002', ...
10. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
11. Create more manual credits with types CREDIT and B, and verify that
    the numbers are not generated
12. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHA2020020001',
    'BRANCHA2020020002', ... (assuming you are connected to library
    BRANCHA, and it's February 2020)
13. Set library to another one, say BRANCHB
14. Create more manual credits with types FORGIVEN and A, and verify
    that the numbers generated are 'BRANCHB2020020001',
    'BRANCHB2020020002', ...
15. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
    somewhere. Go back to Transactions tab and click on 'Print' for one
    line that has a credit number. Make sure the number is there.
16. prove t/db_dependent/Koha/Account.t

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:03:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:03:47 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-NGHFxHjgRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This works really nicely, thanks Julian!

Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:04:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:04:01 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-DfajB1SWNJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:04:08 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-FBrUdyZEXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:07:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:07:51 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-UjoM1wYyEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96098|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:14:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:14:26 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-tKTGHoCvPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Martin Renvoize from comment #20)
> This is looking good so far.. and in testing seems to all work for me.
> 
> It looks like you are perhaps still working on it together.. or is it ready
> for a signoff?

I'm using it, works Ok :)
My last patch was only to remove some complains from qa tools, don't know if
Jonathan agrees with the pod text, but can be amended in the future.

It's waiting a signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:42:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:42:42 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-UZmMItqL1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Laura Horgan <horganl at middlesex.mass.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |horganl at middlesex.mass.edu

--- Comment #75 from Laura Horgan <horganl at middlesex.mass.edu> ---
When will this be added to the system and will ther be a way to identify and
possibly migrate or create volumes for items in the system cuurently

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:47:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:47:11 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-rXGEdzoR7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101884|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101898&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:47:14 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-WrN5ZfcYxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101885|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101899&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:47:17 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-g8oF85J6uh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101886|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101900&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:47:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 17:47:47 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-0X6IIplqSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fixed up the schema change and kohastructure change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:05:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:05:16 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-a9hbvrLy3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> Did not we decided to have ->filter_by_* methods?
> I do not think we should introduce this pattern (ie. having filter_by in
> parameter), we may end up with huge and complex methods.
> 
> However I really like the idea of ->filter_by_* chained methods to filter a
> set.

I don't remember that discussion to evolve more than what was proposed on that
bug... what was it...

I think chaining filter_by_* could be really cool. I think Martin ended up
implementing this way because we didn't have a clear consensus.

But I missed many dev meetings as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:12:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:12:30 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-DWbUR6Pndq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
See bug 11983.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:13:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:13:54 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-vQvytBUZge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:15:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:15:47 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-gZi9W8Wo10@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101009|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101901&action=edit
Bug 24883: Command line utility to load yaml files

This patch adds a command line utility to load
yaml files.

To test:
1) Apply the patch
2) Try loading a file, e.g. sample notices
 a) mysql -e "delete from letter"
 b) misc/load_yaml.pl -f installer/data/mysql/en/mandatory/sample_notices.yml
3) Try loading a file with a syntax error,
   edit previous file adding ':' at the end of a field without quotes
   then load again

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:15:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:15:50 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-hmINTa2HiL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101292|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101902&action=edit
Bug 24883: Centralize code to load YAML installer files to a sub

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:15:53 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-ImzBTsHhPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101293|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101903&action=edit
Bug 24883: Move to a flat array with all values to an array of arrayref

For the following SQL query:
INSERT INTO cities(city_name, city_country) VALUES ('Madrid', 'Spain'),
('Buenos Aires', 'Argentina');

We move from:
[ 'Madrid', 'Spain', 'Buenos Aires', 'Argentina' ]
to:
[ [ 'Madrid', 'Spain' ], [ 'Buenos Aires', 'Argentina' ] ]

Which make more sense to split, build and construct the queries

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:15:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:15:56 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-keVhJkBhH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101294|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101904&action=edit
Bug 24883: Move new sub from load_yaml.pl

Use the sub from C4::Installer to avoid dup of code.

Note:
We are going to modify the script and so will do more stuffs.
We may want to rename it, maybe installer_utilities.pl,
misc/installer/yaml_utility.pl, any suggestions?

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:15:59 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-phSKxP1hNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101333|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101905&action=edit
Bug 24883: Add POD entry and remove unused variable

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:16:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:16:24 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-F6sOOdHVd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works well, passes QA scripts.. Signing off..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:16:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:16:32 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-MYm3nPlkgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:18:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:18:49 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-J02FcCDCIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've been trying to get back onto these two for ages.. bug 11983 is
mid-rebase..

I'd love to see a consensus and movement on that bug and have it unlock a few
patterns for us, but alas.. time is getting the better of me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:56:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:56:06 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-Rflq4ccXgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:56:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 18:56:32 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-ctLorsdubD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99320|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 20:24:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 19:24:10 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-ZaH3gniCWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 101906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101906&action=edit
Bug 24700: Avoid validating REST API spec multiple times

This patch changes the spec loading so that it is fully loaded and merged with
any plugin routes before validation. The individual parts are separately
validated only if the resulting complete spec is invalid. Note: the OpenAPI
plugin validates the spec given to it, so normally no manual validation is
necessary.

Test plan:
1. prove -v t/db_dependent/Koha/REST/*
2. prove -v t/db_dependent/api/v1/*

Sponsored-by: The National Library of Finland
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:17:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:17:11 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-fWQnRUnhTC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Fridolin SOMERS from comment #12)
> alternate patch ? Its more a follow-up no ?

Alternate patch, because in Comment 6 it was mentioned that the first patch
doesn't really fix the problem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:25:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:25:25 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-Ic9umn2pmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:32:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:32:43 +0000
Subject: [Koha-bugs] [Bug 22579] Split actions in z3950 search results so
 Import is the main action and make clicking title pop up Card Preview
In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22579-70-2leuOlQT7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Aleisha Amohia from comment #12)
> This is almost ready, but I am struggling to get rid of the whitespace
> showing between the two buttons in the button group. If anyone knows what
> I'm doing wrong here please let me know!

Sneakily adding Owen for advice....please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:35:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:35:35 +0000
Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match
In-Reply-To: <bug-14578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14578-70-NsBo355nIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle at bywatersolutions.com   |nick at bywatersolutions.com
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:37:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:37:33 +0000
Subject: [Koha-bugs] [Bug 24995] New: Add issuedate to table_account_fines
 and finest in Accounting tab
Message-ID: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995

            Bug ID: 24995
           Summary: Add issuedate to table_account_fines and finest in
                    Accounting tab
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Some librarians would find if useful if under the Transaction tab the tables
(#table_account_fines and #finest) included the issuedate. That information
becomes is important during fine disputes.

These two columns should also be configurable with the columns config tool.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:39:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:39:03 +0000
Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to
 linking to orders
In-Reply-To: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19358-70-y7NYSnnqXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:42:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:42:01 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-RQDsPi0NWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100219|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101907&action=edit
Bug 24815: Correct return values of Koha::Cash::Register relations

This patch correct all cases of return undef to instead return an empty
resultset.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:42:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:42:04 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-L6p7KNaheP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100220|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101908&action=edit
Bug 24815: Add additional tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:42:46 +0000
Subject: [Koha-bugs] [Bug 24815] Koha::Cash::Register relations should
 return sets not undef
In-Reply-To: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24815-70-irBqjEXdmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased, thanks for yesting Jon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:43:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:43:25 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-zdI9b7tFyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101794|0                           |1
        is obsolete|                            |

--- Comment #3 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101909&action=edit
[DO NOT PUSH] Bug 24980: This patch is only for test purposes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:43:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:43:29 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-BvSQ2Zcj2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #4 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101910&action=edit
Bug 24980: (RM follow-up) Only add timezone if passed a date-time

This patch prevents a timezone from being assigned to the js moment if
the input string is only at the full-date and not date-time resolution

To test:
1. Do not apply this patch
2. Set your system time zone to CET
3. Apply previous patch (It's just for test)
4. In your browser go to koha main page, open a console and type
$date('2020-03-25', {tz:
   'UTC'})
CHECK => you sould get '03/24/2020' (notice day is 24 instead of 25)
5. Apply this patch and reload the browser
6. repeat step 4
SUCCESS => now you get '03/25/2020' (day is correct)
7. Sing off

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:45:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:45:25 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-FV6Y4ZwRJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #2)
> How does that look to you?

Great, it was just what I was looking for.. it just lacked the actual execution
of creationData function.. too much Perl I guess, hehe

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:47:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:47:59 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-sFVZGThVPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Excellent, thanks Agustin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:49:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:49:02 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-KEANGP5ltR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:49:12 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-Dc2EHuG06c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #4)
> 4. In your browser go to koha main page, open a console and type
> $date('2020-03-25', {tz:
>    'UTC'})

Don't know why it added an enter.. in console you should type like this

$date(''2020-03-25', {tz:'UTC'})

without that enter after "tz:"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:49:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:49:39 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-8nAEmlaIVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:50:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:50:20 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-VxJdNOj51B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
With the new dependency added I believe we are unblocked again here.. resetting
to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:51:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:51:22 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-6QcoeqvU85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just spotted.. we need to add the `Sponsored-by: ` Line into at least one of
the patches for the release notes ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:52:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 20:52:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-jzwRzfBLON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:00:25 +0000
Subject: [Koha-bugs] [Bug 23224] Inconsistent behaviour between
 memberentry.pl and the update-child.pl when updating child patron to Adult
In-Reply-To: <bug-23224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23224-70-ZlzaKBSx5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I believe this patch is no longer required - in master, guarantors and
guarantees are stored in borrower_relationships in the database. the
relationship information is deleted when changing from child patron to adult
patron using memberentry.pl and child-update.pl. Closing bug report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:00:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:00:26 +0000
Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link
 to guarantor
In-Reply-To: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12949-70-zsHm1fjDvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949
Bug 12949 depends on bug 23224, which changed state.

Bug 23224 Summary: Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:01:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:01:32 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-VTBM1CJktv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could this also be used in context of bound serials (all issues of a year bound
into one volume)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:02:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:02:33 +0000
Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link
 to guarantor
In-Reply-To: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12949-70-g4phiW9klC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I believe this patch is no longer required - in master, guarantors and
guarantees are stored in borrower_relationships in the database. the
relationship information is deleted when changing from child patron to adult
patron using memberentry.pl and child-update.pl. Closing bug report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:09:55 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-uD9wuAP7Sz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #77 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Laura - It's hard to say when this will be in Koha, as it has not yet gone
through QA. This patch doesn't include a mechanism to automatically assign
items to volumes, but existing items can be added to volumes manually.

Katrin - Yes, absolutely! I can see ways in which defining volumes of
periodicals would be useful. Though the only functionality beyond the creation
of a volume that's currently being worked on is that in bug 24860.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:16:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:16:53 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-ct8YomPu30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:19:27 +0000
Subject: [Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and
 finest in Accounting tab
In-Reply-To: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24995-70-rHXrELE4NO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:19:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:19:30 +0000
Subject: [Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and
 finest in Accounting tab
In-Reply-To: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24995-70-zJ3i4gyQEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101911&action=edit
Bug 24995: Add issuedate to table_account_fines and finest

TO TEST:
1. Have a patron with some fines on an item. Try accruing fines.
2. Go to the accounting tab and look at both the Tranaction tab and Make a
payment Tab
3. No Issue Date
4. Apply patch
5. Check those tabs again and see the issue date displays.
6. Go to column configuration and try to hide the issuedate, make sure it hides
properly. Try this for both tables. Also make sure other columns hide properly.
7. Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:21:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:21:06 +0000
Subject: [Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and
 finest in Accounting tab
In-Reply-To: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24995-70-TPSzQV0CyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:26:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:26:53 +0000
Subject: [Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and
 finest in Accounting tab
In-Reply-To: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24995-70-JZsfezvgma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101911|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101912&action=edit
Bug 24995: Add issuedate to table_account_fines and finest

TO TEST:
1. Have a patron with some fines on an item. Try accruing fines.
2. Go to the accounting tab and look at both the Tranaction tab and Make a
payment Tab
3. No Issue Date
4. Apply patch
5. Check those tabs again and see the issue date displays.
6. Go to column configuration and try to hide the issuedate, make sure it hides
properly. Try this for both tables. Also make sure other columns hide properly.
7. Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:35:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:35:39 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-nWFkyGsIZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92165|0                           |1
        is obsolete|                            |

--- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101913&action=edit
Bug 23352: Default setting of item price, replacement price, ccode,
dateaccesioned in serials-edit.pl

This patch contains:
* Database and DBIx changes

* Setting 952g (items.price) and 952v (items.replacementprice) from
Acquisitions module order unitprice and replacment cost respectively

* Default setting of the 952d (items.dateaccessioned) on page load

* New input in serials/subscription-add.pl for librarian to select
default collection code for serial issues.

* 2 new sysprefs:

- DefaultToCreatingSerialIssuesOnReceival - Disabled by
default. When enabled it sets the 'Create an item record when
receiving this serial' to be ticked.

- PopulateNewItemDateAccessionedOnPageLoad - Disabled by default. When
enabled it populates the 952$d Date Acquired field in the item addition
page without the cataloguer having to click in the field.

Test plan:

1. Enter mysql terminal:
sudo koha-mysql <instancename>

2. Run the query: describe subscription;

3. Notice there is no 'ccode' column after the 'mana_id' column

4. In the staff client go to Serials > New subscription

5. Notice the 'Do not create an item record when receiving this serial'
radiobutton is ticked by default.

Click the 'Create an item record when receiving this serial' radiobutton

6. Fill out all the required serial fields, set the library branch to a
branch different to the library branch you are currently logged in as and click
'Save subscription'

7. Now go to the Acquisitions module.

Add a new basket to a vendor

Add to the basket and select 'From a subscription'

Search for the subscription you created in steps 5-6

Set a quantity, vendor price of 2 and replacement cost of 3

Save the order

8. Go back to Serials and recieve an item for the subscription and
notice that the item creation form that is loaded when you change the
status from 'Expected' to 'Arrived' does not set defaults for:

952$8 - Collection code
952$d - Date accessioned - You must click in the input box to load a
default value for this

952$g - Cost
952$v - Replacement price

Also note the 952$a and 952$b are set the library you set in the
subscription and not the branch you are currently logged in as

9. Exit mysql terminal and apply patch

10. Navigate to the installer/data/mysql
directory

11. Enter koha-shell: sudo koha-shell <instancename>

12. Run:
./updatedatabase.pl

13. Notice 2 atomicupdates run without errors

14. Exit koha-shell and re-enter mysql terminal and confirm the 'ccode'
column is in the subscription table now after mana_id column

Exit the MySQL terminal.

15. In the Koha staff client > Administration > Global System Preferences
and notice there is a new syspref in the 'Serials' system preferences
named 'DefaultToCreatingSerialIssuesOnReceival' and there is a new
syspref in the 'Cataloging' system preferences named -
PopulateNewItemDateAccessionedOnPageLoad

Notice both are disabled by default.

16. Repeat steps 4-8.

Notice there is now a new input in the subscription-add.pl page 2:
'Serial issue Collection' which populates with the contents of the ccode
authorised value

Notice upon receiving the item the
following fields do have a default value now:

952$8 - Collection code
952$g - Cost
952$v - Replacement price

17. Go back to Administration > Global System Preferences and set the
'DefaultToCreatingSerialIssuesOnReceival' and
'PopulateNewItemDateAccessionedOnPageLoad' syspref to 'Enabled'

18. Go back to Serials > New subscription and observe the 'Create an
item record when receiving this serial' radiobutton is now checked by
default

19. After creating the subscription repeat step 7 and now receive the
serial and notice that the 952d Date Acquired is set automatically to
todays date in the format: YYYY-MM-DD (i.e.
you don't have to click in the field).

20. Try clicking in the 952d and notice no second date is appended

21. Sign off :)

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:35:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:35:43 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-zTLCSUktXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92166|0                           |1
        is obsolete|                            |

--- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101914&action=edit
Bug 23352: Changes to unit tests

Changes to t/db_dependent/Serials.t unit tests to capture and
test the changes to NewSubscription() and ModSubscription() in
C4/Serials.pm

Test plan:
1. Follow test plan in first commit

2. From Koha home directory enter Koha shell and run:

prove t/db_dependent/Serials.t

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:45:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:45:33 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-OSb2nBmPG5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #72 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Having a look here too. Database update and permissions look good. Seems to
work well, although I have some concerns about macros working correctly in our
current version (see 5)

Found only some small stuff that needs fixing:

1) QA test tool fail
 FAIL   Koha/AdvancedEditorMacros.pm
   FAIL   pod coverage
                POD is missing for 'object_class'
   OK     spelling

2) Translatability

Jonathan, I think you are right, if these show in the GUI (which it looks like)
they won't be translatable.

openapi => { error => "To create shared macros you must use
advancededitor/shared" } );
openapi => { error => "To create private macros you must use advancededitor" }
);

There are also some other glitches in the Javascript code:
+            $convert = $( '<button class="btn btn-default" id="convert-macros"
title="Convert browser storage macros"><i class="fa fa-adjust"></i> Convert old
macros</button>' );

3) Should these API additions be voted on?

4) Capitalization

I've noticed lots of glitches there in patches recently - makes my inner
librarian unhappy:

+      "description": "Advanced Editor Macro internal identifier",

5) Testing went well, but I am wondering if there is an issue with our MACRO
language. A lot of the examples I tried from the wiki would not work:

https://wiki.koha-community.org/wiki/Advanced_editor_macros

Especially the RDA macros that add multiple subfields - only the first subfield
code will be recognized. I assume they used to work (trusting Heather), so what
happened there?

As this is so heavy on API it would be nice to get Tomas to have a look too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:47:19 +0000
Subject: [Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4985-70-kNZv4ZEGt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Setting FQA because Sally's testing confirms there is still some glitch with
the deletes.

I hope the problem can be fixed - this would make a nice addition!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 21:50:19 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-pY8tlQsFpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #50 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 101915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101915&action=edit
Bug 20936: (follow-up) use  modified by bug 24980, fix display of page info and
fix search without enter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:01:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:01:12 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-krAdpoS7en@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:04:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:04:28 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-FC2TSrq1MS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #73 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm sad to say, those RDA macros work in master without these patches. Just
tested this one on master and it made all three new fields:
new 336=‡atext ǂb txt ǂ2 rdacontent
new 337=‡aunmediated ǂb n ǂ2 rdamedia
new 338=‡avolume ǂb nc ǂ2 rdacarrier

If it's only making one of the three with these patches then that ain't good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:10:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:10:32 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-GHwKCcIycw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Koha developments most often (if not always) keep one eye towards current users
as well as future users.  At times it's hard to balance the needs of a library
(or libraries) and workflows that seem so important with the needs and
workflows of the many.  The things that seem obvious to me are not always
obvious to others.  I rely on the input of others in the community to give
perspective on how other libraries operate.  I believe someone once said "show
me a library with a mad scheme and I'll show you another with a madder one"! 

Speaking from someone with experience migrating thousands of libraries to Koha,
I can confidently say that libraries have indeed used this field with the
expectation that it was NOT visible in the OPAC.  There is the distinct
possibility that patron information (or staff information/direction) is
available in this field.  A number of libraries come to my mind who have been
using Koha for years in a way that is built upon the original design (not
visible in opac).  

If this is to be implemented and visible in the OPAC, it must be made so it is
optional/configurable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:11:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:11:58 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-HBGv7Lmja3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #78 from David Cook <dcook at prosentient.com.au> ---
(In reply to Andrew Fuerste-Henry from comment #74)
> A volume is a grouping of items within a bib. See bug 24860 for one
> implementation (patrons can place hold on a volume, get first available item
> within that volume). Imagine, say, a bib containing multiple copies of a
> multi-volume series. Patron wants whichever copy of Book 1 comes in first.

That's interesting. I wonder if we should use more generic terminology like
"item_group" instead of "volume". Perhaps each group could have a translatable
label assigned so you could choose "Volume", "Kit", etc. 

This might be useful for libraries that provide kits, toy bags, computers (with
peripherals). Individual pieces could be barcoded and be items in their own
right, but be grouped together.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:14:40 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-LUiw3QgDVn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #74 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The fact it relies on the API should be a good thing for everyone, no one wants
to add new CGI controller scripts that can only be tested with selenium :-D

About translatability, the JS libraries usually just detect faulty codes (4XX,
5XX, and so on). And the error message is not what gets presented to the end
user. That should be handled as usual in JS with translatability in mind. For
example, if we do

GET /a/resource/12

and get a 404, it doesn't matter the JSON that is returned (even though we try
to be consistent on the format and texts there). The code on the UI should
handle the fact that the requested resource doesn't exist, based on the 404
code.

That said, maybe Nick relied on those messages for the UI, and that should be
fixed. I haven't checked that myself.

Regarding the need for a vote, I'd say we should, yes. This patchset requires
something different than others: the resources (macros) can belong to a patron,
but can also be shared. And we can only specify AND conditions for resource
access. So we cannot say (on the spec) things like: 'you can edit this if you
are superlibrarian or the owner'. It could be worked out in a different way,
but I don't think we can avoid (at least) a minimum check in the controller,
and is just fine IMHO.

I will recheck this patchset in deep and provide more feedback ASAP. Specially
if some design change can make this cleaner to implement. I haven't found a
better option, thus adding Martin and Agustin to the conversation to gather
more ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:15:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:15:35 +0000
Subject: [Koha-bugs] [Bug 24996] New: Unwanted CSS change unhides OPAC
 results sorting button
Message-ID: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

            Bug ID: 24996
           Summary: Unwanted CSS change unhides OPAC results sorting
                    button
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23915

With JavaScript enabled the "Go" button associated with the OPAC search results
re-sort form should be hidden. Looks like I accidentally removed a line of CSS
with Bug 23915 which needs to get put back.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915
[Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:15:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:15:35 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-aVQWl0j1FJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996
[Bug 24996] Unwanted CSS change unhides OPAC results sorting button
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:18:37 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-F20XFUvRJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
In my opinion we should replace TinyMCE with CodeMirror here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:34:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:34:02 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-ujhMoqKUH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #3)
> In my opinion we should replace TinyMCE with CodeMirror here.

Making it an option like the WYSIQY editor for prefs is might be nice.
So you can switch if you want to do more elaborate things and keep the editor
for people not fond of code?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:34:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:34:59 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-lNSQBa1Y5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.04,         |20.05.00, 19.11.04,
        released in|19.05.09                    |19.05.09, 18.11.16
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #26 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:37:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:37:24 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-uIx9hml3KT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Hayley Mapley from comment #26)
> Backported to 18.11.x for 18.11.16

Thank you Hayley for looking into it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:38:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:38:30 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-70rFW2jW3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

--- Comment #28 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
> (In reply to Hayley Mapley from comment #26)
> > Backported to 18.11.x for 18.11.16
> 
> Thank you Hayley for looking into it!

Thanks for flagging it Katrin! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:48:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:48:25 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-5VHAUic4aL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:48:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:48:29 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-Y3kXxBz7BW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101916&action=edit
Bug 23352: (follow-up) Fix 952$g and location auto-population

Previously the cost (952$g) used unit price from the acquisition order,
           but this is not automatically calculated and is sometimes
           zero. We should use the individual item's budgeted cost
           instead.

This patch ensures the permanent location (952$a) and current location
(952$b) are set to the current logged in branch, not the subscription
branch

Also fixing a typo and amending syspref description to be more
user-friendly.

Sponsored-by: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:49:41 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-GoXGfd1Bql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #73)
> I'm sad to say, those RDA macros work in master without these patches. Just
> tested this one on master and it made all three new fields:
> new 336=‡atext ǂb txt ǂ2 rdacontent
> new 337=‡aunmediated ǂb n ǂ2 rdamedia
> new 338=‡avolume ǂb nc ǂ2 rdacarrier
> 
> If it's only making one of the three with these patches then that ain't good.

Do the subfield codes show up the right 'color' for you? I have the text added
by the macro, but only the first is a real 'subfield' delimeter somehow. When I
save and look at the record, they show in the record as ǂb and ǂ2 in normal
view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:49:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:49:58 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-u6lERcGqEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:50:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:50:04 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-OwrmHayg5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 101917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101917&action=edit
Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News
Feature

TEST PLAN:
1. Make a new news item and use the TinyMCE editor, click on the <> icon to go
to the Source code editor
2. Add some HTML like <i class="fa fa-facebook-official"
aria-hidden="true">TEST</i> and save it.
3. Go back in and notice that TinyMCE has changed it to: <p><em class="fa
fa-facebook-official">TEST</em></p>
4. It should not auto clean up and also it should not autowrap with <p> tag.
5. Apply patch patch, and repeat step 2. Save again.
6. It should not have automatiicly changed any HTML or added any <p> wrapper.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:51:41 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-MHKZF9vt7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
This patch fixes the automatic code clean up problem with tinyMCE. A discussion
of wether CodeMirror might be a better option (or ability to use either) is for
a different bug, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:52:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:52:00 +0000
Subject: [Koha-bugs] [Bug 22774] Limit number of purchase suggestions per
 patron in a specified time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-ALFo0YVVMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Limit purchase suggestion   |Limit number of purchase
                   |in a specified time period  |suggestions per patron in a
                   |                            |specified time period

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


1) QA test tools

Looks good, only got what looks like a false positive:

Processing additional checks
        * Email's author 'kohadevinim at devinim.com.tr' seems invalid

2) Capitalization

(Bug 22774 - Limit Purchase Suggestion in a specified Time period)

Please stick with our capitalization rules everywhere! :)

Still testing here, but won't finish tonight. Will fix 2) myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:52:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:52:05 +0000
Subject: [Koha-bugs] [Bug 22774] Limit number of purchase suggestions per
 patron in a specified time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-6Z6WDg8P7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:53:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:53:55 +0000
Subject: [Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in
 the news editor
In-Reply-To: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22660-70-TsrZeYrFtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Improve usability when      |Allow use of CodeMirror for
                   |editing HTML with the news  |editing HTML in the news
                   |editor                      |editor

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Lucas proposed a good idea on bug 24764: Use CodeMirror!

Changing the bug title to advertise the idea a bit more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:54:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:54:08 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-IfK1s3FHAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #6)
> This patch fixes the automatic code clean up problem with tinyMCE. A
> discussion of wether CodeMirror might be a better option (or ability to use
> either) is for a different bug, I think.

Agreed, I filed bug 22660 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:54:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:54:14 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-DMRzeTAutN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22660

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:54:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:54:14 +0000
Subject: [Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in
 the news editor
In-Reply-To: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22660-70-PNj7Pk6ahn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24764

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 22:58:42 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-GuccM7brNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #85 from Lari Taskula <lari.taskula at hypernova.fi> ---
Not applying. Patches have gone in wrong order. I'll attempt to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:01:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:01:57 +0000
Subject: [Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in
 the news editor
In-Reply-To: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22660-70-gngKkBo4VT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
With more system preferences like OPACHeader(bz22880) and OPACMainUserBlock
(bz23794) moving into the News feature there needs to be a robust way of
editing HTML, I think CodeMirror is appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:12:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-S9BSaOJvmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #79 from Laura Horgan <horganl at middlesex.mass.edu> ---
In our last system it was called parts and was used for books dvds kits, etc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:27:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:27:56 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-QFEOQOhl0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99148|0                           |1
        is obsolete|                            |
  Attachment #99211|0                           |1
        is obsolete|                            |

--- Comment #86 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101918&action=edit
Bug 15522: Add API for circulation rules

Test plan:
  1) Run t/db_dependent/api/v1/circ_rules.t .

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:28:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:28:21 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-rn8N8GiGqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99213|0                           |1
        is obsolete|                            |

--- Comment #87 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101919&action=edit
Bug 15522: Add JS build pipeline

This is not directly testable, but can be either used through the
Makefile:

$ make js-build

(This will automatically install all dependencies.)

Or by manually installing yarn:

$ sudo apt install nodejs npm
$ sudo npm install -g yarn
$ yarn install
$ yarn build

(There is also `make js-watch` and `yarn watch`, which automatically
recompile when files are changed.)

JD note: the make rule does not work

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:28:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:28:51 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-mXFO7779Yd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99214|0                           |1
        is obsolete|                            |

--- Comment #88 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920&action=edit
Bug 15522: New interface for updated circulation rules

Test plan:
  1) Make sure all dependencies are applied, and that their DB upgrades
     have been applied.
  2) Build JS (see previous patches for HOWTO).
  3) Load .../cgi-bin/koha/admin/policy.pl .
  4) Try changing an existing rule (one with a textbox or dropdown). Hit
     "Save rules", ensure that your changes are saved.
  5) Until changes are saved, all cells that are changed or affected by
     your changes should be highlighted in yellow.
  6) Same as above, but deleting a rule by hitting the "x" next to it.
  7) Add rows and columns using the "Choose rule..." and "Choose
     category/item type..." dropdowns.
  8) Add rules by clicking the pencil in a currently unset rule cell.
     Ensure changes are saved.
  9) Hit "Cleanup rules"; all redundant rules should be removed. As this
     only removes rules that are the same as the defaults, this should
     not change any effective rules.
 10) Use the filters at the top right ("Circulation", "Holds" and
     "Fines") to filter the kinds of rules that are shown.
 11) Ensure that any desired library can be shown, including (if
     selected) all at the same time.

JD edits: Removed the changes to filtered categories, will be done in a
follow-up

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:29:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:29:21 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-mayuFxCZ6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99206|0                           |1
        is obsolete|                            |

--- Comment #89 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101921&action=edit
Bug 15522: Remove old circulation rules interface

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:29:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:29:43 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-rSNttBOOdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99205|0                           |1
        is obsolete|                            |

--- Comment #90 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101922&action=edit
Bug 15522: Add yarn.lock (autogenerated)

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:30:04 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-8NErlArcuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99204|0                           |1
        is obsolete|                            |

--- Comment #91 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101923&action=edit
Bug 15522: Fix permission name manage_circ_rules_from_any_libraries

On 15520 followups have been provided to not use a negative permission.

Note that two api tests are failing (get 400). I would like some help to
investigate here why 400 is returned instead of 403.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:30:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:30:25 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-6NxRhPycLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99203|0                           |1
        is obsolete|                            |

--- Comment #92 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101924&action=edit
Bud 15522: Restore categories filtering

Mimicking what is done for Branches

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:30:45 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-ZsP5XvPkNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99202|0                           |1
        is obsolete|                            |

--- Comment #93 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101925&action=edit
Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:31:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:31:07 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-vpuVCb528I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99201|0                           |1
        is obsolete|                            |

--- Comment #94 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101926&action=edit
Bug 15522: Handle deprecated rules

For upgraded installs. Also add a log in the console if it happens.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:31:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:31:27 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-xh1m6CVASf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99215|0                           |1
        is obsolete|                            |

--- Comment #95 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101927&action=edit
Bug 15522: (follow-up) Handle deprecated rules

Previous use of inArray was wrong.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:32:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:32:30 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-WoUozQZ5nB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at hypernova.fi

--- Comment #96 from Lari Taskula <lari.taskula at hypernova.fi> ---
Fixed patch order, obsoleted duplicates, rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:41:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:41:21 +0000
Subject: [Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in
 the news editor
In-Reply-To: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22660-70-oa2DomGK9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Personally, I'd prefer to use CodeMirror. However, my librarians would rather
use a WYSIWYG editor I think, so I think being able to do an either/or would be
great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2020 23:42:33 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-4vSW97MLy5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
Awesome! I'm going to put this on my todo list. In the middle of something else
at the moment, but hoping to sign this off today. Been bitten by this issue
more often than I'd like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:10:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:10:37 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-pE71cl6RRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #34)
> Nice work everyone!
> 
> Pushed to master for 20.05

Ooops, I think you may have accidentally broken updatedatabase.pl:

diff --git a/installer/data/mysql/updatedatabase.pl
b/installer/data/mysql/updatedatabase.pl
index 65ecbb7169..3c62761737 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -21296,6 +21296,7 @@ if( CheckVersion( $DBversion ) ) {

         $dbh->do(q|
             ALTER TABLE suggestions ADD CONSTRAINT
`suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`)
REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE
+            A
         |);
     }

@@ -21335,6 +21336,15 @@ if( CheckVersion( $DBversion ) ) {
     NewVersion( $DBversion, 23590, "Add lastmodificationby and
lastmodificationdate to the suggestions table");
 }

+$DBversion = '19.12.00.056';
+if( CheckVersion( $DBversion ) ) {
+
+    $dbh->do( "DELETE FROM systempreferences WHERE variable='UseKohaPlugins'"
);
+
+    NewVersion( $DBversion, 20415, "Remove UseKohaPlugins preference");
+}
+
+
 # SEE bug 13068
 # if there is anything in the atomicupdate, read and execute it.
 my $update_dir = C4::Context->config('intranetdir') .
'/installer/data/mysql/atomicupdate/';

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:12:21 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-p7tfXU95dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #36 from David Cook <dcook at prosentient.com.au> ---
Oh wait. Maybe not broke. I forget we don't throw fatal errors for SQL errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:14:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:14:36 +0000
Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
In-Reply-To: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20415-70-LsMbiU2LAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415

--- Comment #37 from David Cook <dcook at prosentient.com.au> ---
Created attachment 101928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101928&action=edit
[Follow-up] Bug 20415: Fix typo causing SQL error in updatedatabase.pl

This patch just removes a typo that is causing a database update to fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:19:45 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-4A3uAB9C8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:19:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:19:48 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-dsBNbDlSWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101917|0                           |1
        is obsolete|                            |

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Created attachment 101929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101929&action=edit
Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News
Feature

TEST PLAN:
1. Make a new news item and use the TinyMCE editor, click on the <> icon to go
to the Source code editor
2. Add some HTML like <i class="fa fa-facebook-official"
aria-hidden="true">TEST</i> and save it.
3. Go back in and notice that TinyMCE has changed it to: <p><em class="fa
fa-facebook-official">TEST</em></p>
4. It should not auto clean up and also it should not autowrap with <p> tag.
5. Apply patch patch, and repeat step 2. Save again.
6. It should not have automatiicly changed any HTML or added any <p> wrapper.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:20:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:20:13 +0000
Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup
 when editing HTML in News Feature
In-Reply-To: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24764-70-4sg2gyBzjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:33:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 00:33:58 +0000
Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other
 content areas
In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22318-70-4yf6C96PeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
While I agree about moving the HTML system preferences out of the system
preferences, wouldn't it make sense to re-brand the "News" to "Customize user
interface" or "HTML Content Editor" or something like that?

I imagine putting things under the "News" banner might just confuse library
staff more than they're already confused.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:08:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:08:43 +0000
Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for
 each issue in subscription tab of /catalogue/detail.pl
In-Reply-To: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23450-70-FotNEDZwIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:08:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:08:47 +0000
Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for
 each issue in subscription tab of /catalogue/detail.pl
In-Reply-To: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23450-70-3nAaLy38f5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92148|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101930&action=edit
Bug 23450: Display subscription and issue cost in subscription interface of the
catalouge/detail.pl

Displays the serial issue price (from 952$g), and subscription cost
(calculated from the Acquisition order the subscription is linked to).

Test plan:
1. Create a subscription (making sure to select 'Create an item record when
receiving this serial') and then go to Acquisitions module and create
the following if they don't already exist:
* Currency
* Budget
* Fund
* Vendor
* Basket

2. Add to the basket: Add to basket > From a subscription

3. Search for and select the subscription made in step #1

4. Set quantity, vendor price, and replacement price and 'Save'

5. Search for the serial biblio and view its catalogue/detail.pl page

Click on the 'Subscriptions' tab and notice there is no 'Total cost of
the subscription' text

And no 'Issue price' and 'Subscription cost' columns in the issue table
in the subscription tab which is currently empty

6. Select the 'Subscription details' link and select 'Receive' changing
the status from 'Expected' to 'Arrived'

7. Repeat step 5 and notice the issues table in the Subscriptions tab
still does not have 'Issue price' or 'Subscription cost' columns

8. Apply patches on bug 23352 and 23450

9. Update your database and restart memcached and plack

10. Refresh the catalogue/detail.pl page you were on in step 7 and
notice the following has been added:

Total cost of the subscription is: <quantity * vendor price >

Issue price and Subscription cost columns in the issue table in the
subscription tab.

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:24:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:24:01 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
 in batch patron modification
In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23291-70-GRrmj2YSk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92666|0                           |1
        is obsolete|                            |

--- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101931&action=edit
Bug 23291: Find patrons by smsalertnumber in the batch patron modification

Add ability to paste in sms numbers (one per line) or upload a file of
sms numbers and find patrons with matching smsalertnumber values.

If an sms number is not found then this is displayed in a yellow box to
the librarian i.e. the batch patron modification tool will behave as it
does currently when a cardnumber is not found.

Test plan:
1. Go to Tools > Batch patron modification

2. Notice there is a file upload (for cardnumbers) and a text input area
(for cardnumbers)

3. Apply patch and restart memached and plack

4. Refresh the page and notice a file upload (for sms numbers) and file
text input area (for sms numbers) have been added

5. Create a file with valid sms numbers matching smsalertnumber values
of patrons (one per line)

6. Select/upload the file into the sms number file upload and submit the
form

7. Notice the patrons are found and you can batch modify them. Select a
date in the 'Restriction expiration' datepicker and submit and notice
this is added to the selected borrowers in the borrowers.debarred,
borrowers.debarredcomment fields and borrower_debarment table.

8. Create a file with some valid and some invalid sms numbers (i.e. some
smsnumbers belonging to patrons in their smsalertnumber field and some
not matching)

9. Upload your file from 8 in the SMS number file upload and notice that
error handling means the invalid/non-matching sms numbers are shown
below the yellow box at the top of the page whilst matching sms numbers
have returned patrons which you can edit

10. Confirm card number file upload still works by making a file of
valid cardnumbers and uploading it in the Batch patron modification tool
and noticing the patrons are successfully returned

11. In the batch patron modification tool paste valid sms numbers into the sms
number text area input (0ne
per line) and submit the batch patron modification. Notice that the
patrons are successfully returned and displayed.

12. Repeat step 11 but this time paste in valid and invalid sms numbers
and notice error handling means sms numbers which did not match
borrowers, smsalertnumber are shown under the yellow box at the top of
the page and patrons who matched sms numbers are shown below in the
table

13. Repeat step 11 this time input only invalid sms numbers and submit.

Notice that a page showing the yellow notice box and a list of all
smsnumbers which could not be found are returned.

14. Repeat step 11 submitting valid smsnumbers in the cardnumber text area
field and you will
notice that  a page showing the yellow notice box and a list of all non
matching cardnumbers.

15. In your Koha home directory run: sudo koha-shell <instancename>

Then run: prove xt

16. Confirm all test pass

17. Sign off

Sponsored-By: Brimbank Library, Australia

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:24:06 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
 in batch patron modification
In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23291-70-HOOzNFKsJg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92667|0                           |1
        is obsolete|                            |

--- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101932&action=edit
Bug 23291: Retrieve all patrons with given SMS number, and change inputs

This patch now handles situations where more than one patron has a given
SMS number.

The inputs are now more concise as radio buttons are now present for users
to indicate whether the file they are uploading or the list of numbers they
are entering are cardnumbers or SMS numbers.

Test plan same as first patch, although take into account slight changes
to inputs.
Also test an SMS number that more than one patron has and check that all
patrons with that number are displayed.

Sponsored-by: Brimbank Library, Australia
Authored-by: Alex Buckley and Hayley Mapley (Catalyst IT)

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:24:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:24:07 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-lRtunI37CB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #97 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lari Taskula from comment #87)
> Created attachment 101919 [details] [review]
> Bug 15522: Add JS build pipeline
> 
> This is not directly testable, but can be either used through the
> Makefile:
> 
> $ make js-build
> 
> (This will automatically install all dependencies.)
> 
> Or by manually installing yarn:
> 
> $ sudo apt install nodejs npm
> $ sudo npm install -g yarn
> $ yarn install
> $ yarn build
> 
> (There is also `make js-watch` and `yarn watch`, which automatically
> recompile when files are changed.)
> 
> JD note: the make rule does not work
> 
> Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

I had issues with this on Ubuntu 18.04, especially the step "yarn build".

koha at koha:~/Koha$ yarn build
yarn run v1.22.4
$ node_modules/.bin/gulp build
You are missing required Node modules; run `npm install`.

I did some digging and found a more detailed message:
ReferenceError: primordials is not defined

It worked when I explicitly chose to install node version 10.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:24:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:24:10 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
 in batch patron modification
In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23291-70-V61edh7W2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93859|0                           |1
        is obsolete|                            |

--- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 101933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101933&action=edit
Bug 23291: (follow-up) Fix capitalization on SMS

There was one sms hidden between all the SMS, fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:25:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:25:22 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-vKmBMSMSH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #98 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lisette Scheer from comment #62)
> (In reply to Jonathan Druart from comment #51)
> > Created attachment 99148 [details] [review] [review]
> > Bug 15522: Add API for circulation rules
> > 
> > Test plan:
> >   1) Run t/db_dependent/api/v1/circ_rules.t .
> 
> kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
> t/db_dependent/api/v1/circ_rules.t
> t/db_dependent/api/v1/circ_rules.t .. 1/5
>     #   Failed test '403 Forbidden'
>     #   at t/db_dependent/api/v1/circ_rules.t line 128.
>     #          got: '400'
>     #     expected: '403'
>     # Looks like you failed 1 test of 2.
> t/db_dependent/api/v1/circ_rules.t .. 3/5
> #   Failed test 'set_rules | unauthorized'
> #   at t/db_dependent/api/v1/circ_rules.t line 132.
> 
>     #   Failed test '200 OK'
>     #   at t/db_dependent/api/v1/circ_rules.t line 212.
>     #          got: '403'
>     #     expected: '200'
>     # Looks like you failed 1 test of 6.
> 
> #   Failed test 'set_rules | restricted'
> #   at t/db_dependent/api/v1/circ_rules.t line 223.
> # Looks like you failed 2 tests of 5.
> t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512,
> 0x200)
> Failed 2/5 subtests
> 
> Test Summary Report
> -------------------
> t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2)
>   Failed tests:  3, 5
>   Non-zero exit status: 2
> Files=1, Tests=5,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.86 cusr  0.23
> csys =  3.11 CPU)
> Result: FAIL
> 
> I got this message when I tried to do this step in my devbox. Everything
> else worked great for me.

I confirm this error. Will provide a patch to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:25:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:25:35 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
 in batch patron modification
In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23291-70-mHkUajRI1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #12)
> There is a QA script fail:
> 
>  FAIL	tools/modborrowers.pl
>    FAIL	  critic
> 		# Variables::RequireLexicalLoopIterators: Got 1 violation(s). 
> 
> Can you please check?

All qa tests pass for me. Rebased and ready for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:30:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 01:30:08 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-WVddekduJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #99 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 101920
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920
Bug 15522: New interface for updated circulation rules

Review of attachment 101920:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15522&attachment=101920)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
@@ +75,5 @@
> +        </div>;
> +    }
> +
> +    componentDidMount() {
> +        $( this.toolbarElem ).fixFloat();

Test plan step 3 fails, my browser (both FF and Chromium) console says:
TypeError: $(...).fixFloat is not a functionapp.js:79:30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 03:02:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 02:02:33 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-aWFaYN0ziT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #100 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lari Taskula from comment #98)
> (In reply to Lisette Scheer from comment #62)
> > (In reply to Jonathan Druart from comment #51)
> > > Created attachment 99148 [details] [review] [review] [review]
> > > Bug 15522: Add API for circulation rules
> > > 
> > > Test plan:
> > >   1) Run t/db_dependent/api/v1/circ_rules.t .
> > 
> > kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
> > t/db_dependent/api/v1/circ_rules.t
> > t/db_dependent/api/v1/circ_rules.t .. 1/5
> >     #   Failed test '403 Forbidden'
> >     #   at t/db_dependent/api/v1/circ_rules.t line 128.
> >     #          got: '400'
> >     #     expected: '403'
> >     # Looks like you failed 1 test of 2.
> > t/db_dependent/api/v1/circ_rules.t .. 3/5
> > #   Failed test 'set_rules | unauthorized'
> > #   at t/db_dependent/api/v1/circ_rules.t line 132.
> > 
> >     #   Failed test '200 OK'
> >     #   at t/db_dependent/api/v1/circ_rules.t line 212.
> >     #          got: '403'
> >     #     expected: '200'
> >     # Looks like you failed 1 test of 6.
> > 
> > #   Failed test 'set_rules | restricted'
> > #   at t/db_dependent/api/v1/circ_rules.t line 223.
> > # Looks like you failed 2 tests of 5.
> > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512,
> > 0x200)
> > Failed 2/5 subtests
> > 
> > Test Summary Report
> > -------------------
> > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2)
> >   Failed tests:  3, 5
> >   Non-zero exit status: 2
> > Files=1, Tests=5,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.86 cusr  0.23
> > csys =  3.11 CPU)
> > Result: FAIL
> > 
> > I got this message when I tried to do this step in my devbox. Everything
> > else worked great for me.
> 
> I confirm this error. Will provide a patch to fix it.

Already fixed by "Bug 15522: Fix permission name
manage_circ_rules_from_any_libraries", maybe squash this patch to the first
one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 03:11:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 02:11:30 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-uBCVAIKhUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #101 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lari Taskula from comment #99)
> Comment on attachment 101920 [details] [review]
> Bug 15522: New interface for updated circulation rules
> 
> Review of attachment 101920 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
> @@ +75,5 @@
> > +        </div>;
> > +    }
> > +
> > +    componentDidMount() {
> > +        $( this.toolbarElem ).fixFloat();
> 
> Test plan step 3 fails, my browser (both FF and Chromium) console says:
> TypeError: $(...).fixFloat is not a functionapp.js:79:30

Fixed by "Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky",
would be useful to squash this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:10:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:10:13 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-YMbByTy0zt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101918|0                           |1
        is obsolete|                            |

--- Comment #102 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934&action=edit
Bug 15522: Add API for circulation rules

Test plan:
  1) Run t/db_dependent/api/v1/circ_rules.t .

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:10:21 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-3JIAWA9OBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101919|0                           |1
        is obsolete|                            |

--- Comment #103 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101935&action=edit
Bug 15522: Add JS build pipeline

This is not directly testable, but can be either used through the
Makefile:

$ make js-build

(This will automatically install all dependencies.)

Or by manually installing yarn:

$ sudo apt install nodejs npm
$ sudo npm install -g yarn
$ yarn install
$ yarn build

(There is also `make js-watch` and `yarn watch`, which automatically
recompile when files are changed.)

JD note: the make rule does not work

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:10:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:10:30 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-lSe7YOFffO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101920|0                           |1
        is obsolete|                            |

--- Comment #104 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101936&action=edit
Bug 15522: New interface for updated circulation rules

Test plan:
  1) Make sure all dependencies are applied, and that their DB upgrades
     have been applied.
  2) Build JS (see previous patches for HOWTO).
  3) Load .../cgi-bin/koha/admin/policy.pl .
  4) Try changing an existing rule (one with a textbox or dropdown). Hit
     "Save rules", ensure that your changes are saved.
  5) Until changes are saved, all cells that are changed or affected by
     your changes should be highlighted in yellow.
  6) Same as above, but deleting a rule by hitting the "x" next to it.
  7) Add rows and columns using the "Choose rule..." and "Choose
     category/item type..." dropdowns.
  8) Add rules by clicking the pencil in a currently unset rule cell.
     Ensure changes are saved.
  9) Hit "Cleanup rules"; all redundant rules should be removed. As this
     only removes rules that are the same as the defaults, this should
     not change any effective rules.
 10) Use the filters at the top right ("Circulation", "Holds" and
     "Fines") to filter the kinds of rules that are shown.
 11) Ensure that any desired library can be shown, including (if
     selected) all at the same time.

JD edits: Removed the changes to filtered categories, will be done in a
follow-up

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:10:40 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-pvi7MpBOrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101921|0                           |1
        is obsolete|                            |

--- Comment #105 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101937&action=edit
Bug 15522: Remove old circulation rules interface

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:10:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:10:51 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-2eJRY78ag8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101922|0                           |1
        is obsolete|                            |

--- Comment #106 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101938&action=edit
Bug 15522: Add yarn.lock (autogenerated)

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:00 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-O6gsAsabCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101923|0                           |1
        is obsolete|                            |

--- Comment #107 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101939&action=edit
Bug 15522: Fix permission name manage_circ_rules_from_any_libraries

On 15520 followups have been provided to not use a negative permission.

Note that two api tests are failing (get 400). I would like some help to
investigate here why 400 is returned instead of 403.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:09 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-yZhPXEk379@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101924|0                           |1
        is obsolete|                            |

--- Comment #108 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101940&action=edit
Bud 15522: Restore categories filtering

Mimicking what is done for Branches

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:17 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-kUrt4XBh3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101925|0                           |1
        is obsolete|                            |

--- Comment #109 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101941&action=edit
Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:26 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-ZeX2htJFAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101926|0                           |1
        is obsolete|                            |

--- Comment #110 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101942&action=edit
Bug 15522: Handle deprecated rules

For upgraded installs. Also add a log in the console if it happens.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:34 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-VesdjrJK9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101927|0                           |1
        is obsolete|                            |

--- Comment #111 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101943&action=edit
Bug 15522: (follow-up) Handle deprecated rules

Previous use of inArray was wrong.

Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:42 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-IvGY6aeYWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #112 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101944&action=edit
Bug 15522: (follow-up) Fix circulation rules interface title inconsistency

Follow-up to "Bug 15522: Remove old circulation rules interface"

Instead of:
"Circulation, fines and holds rules", use
"Circulation, fines, and holds rules" for consistency

Latter form already used in commit Bug 15522: New interface for updated
circulation rules as follows

koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37:
<li><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds
rules</a></li>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88:
<dt><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds
rules</a></dt>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:50 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-WPmWWqAAG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #113 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101945&action=edit
Bug 15522: (follow-up) Add missing http return codes to api spec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:11:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:11:59 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-Nnnouiwkgy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #114 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101946&action=edit
Bug 15522: (follow-up) Fix 400 errors in circ_rules.t

Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries"
renames a permission by one that negates the previous.

However the commit above incorrectly negates more than is supposed to.

The test wants to check whether unauthorized and restricted user can store
circulation rules.

The libriarian is restricted (to their homebranch) when they are circ rules
authorized (by "manage_circ_rules" permission) but do not have permission
"manage_circ_rules_from_any_libraries".

To test:
1. prove t/db_dependent/api/v1/circ_rules.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:15:49 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-TrizpIGBWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101946|0                           |1
        is obsolete|                            |

--- Comment #115 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 101947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101947&action=edit
Bug 15522: (follow-up) Fix 400 errors in circ_rules.t

Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries"
renames a permission by one that negates the previous.

However the commit above incorrectly negates more than is supposed to.

The test wants to check whether unauthorized and restricted user can store
circulation rules.

The libriarian is restricted (to their homebranch) when they are circ rules
authorized (by "manage_circ_rules" permission) but do not have permission
"manage_circ_rules_from_any_libraries".

To test:
1. prove t/db_dependent/api/v1/circ_rules.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:39:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 03:39:39 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-OM9VECnAYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #116 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 101934
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934
Bug 15522: Add API for circulation rules

Review of attachment 101934:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15522&attachment=101934)
-----------------------------------------------------------------

::: api/v1/swagger/paths/circulation-rules.json
@@ +28,5 @@
> +          "schema": {
> +            "$ref": "../definitions.json#/error"
> +          }
> +        }
> +      }

No permissions required for GET?

@@ +40,5 @@
> +      ],
> +      "parameters": [{
> +        "name": "body",
> +        "in": "body",
> +        "description": "A JSON object containing rules to set; null for a rule_value means to delete the rule",

I think this wrong functionality for POST method that is supposed to create
resources.

Also, by definition POST is not idempotent, but here it seems to be. (If I
understand the API correctly, here making the same request twice is the same as
making it only once, right?)

It should then be PUT. But PUT requires the whole object as a parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 07:49:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 06:49:46 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-RT36r9MKap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #117 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lari, the remote branch needs to be used to testing. The patches were not
up-to-date on purpose, new rules have been added to the table, and need to be
added to the interface, did you deal with them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 07:56:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 06:56:09 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-Q85P0hTPqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100855|0                           |1
        is obsolete|                            |

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101948&action=edit
Bug 22784: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 07:56:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 06:56:23 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-2GH8Bvy8A8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #42)
> Hi Jonathan, can you please rebase?

The patches applied ok. The one that does not it DBIC changes, it can be done
this way:
 % git bz apply --skip
 % dbic

That's it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:01:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:01:26 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-Pwz8xj0aQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Upgrade to 19.12.00.054 done [07:00:32]: Bug 13881 - Add desk management
DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MariaDB server version for the right syntax to
use near 'A' at line 2 [for Statement "
            ALTER TABLE suggestions ADD CONSTRAINT
`suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`)
REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE
            A
        "] at installer/data/mysql/updatedatabase.pl line 21300.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:11:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:11:13 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-Eih3H2LiT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Simon, I think I understand where the confusion comes from.

The values in the circulation rules have the following meaning:

Days:     Ignore the calendar
Calendar: Use the calendar to skip days the library is closed
Datedue:  Use the calendar to push the due date to the next open day
Dayweek:  Use the calendar to push the due date to the next open matching
weekday for weekly loan periods, or the next open day otherwise

They are the "internal values" of the syspref.
It's not ideal but we cannot use the long descriptions in the dropdown list in
the circ rules table, that will be too wide.

It seems that it is not enough but to avoid the confusion there is a tooltip
that is displayed (over the cursor on the cell):
https://snipboard.io/We6flu.jpg it cannot be seen on the screenshot, but the
cursor is on "Days".

If you have anything else to suggest to make it less confusing, let me know!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:11:31 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-718chQbaby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:25:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:25:58 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-5n31oMamVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
When should we deal with tz when displaying dates?

What are the different possibilities offered by js-date-format.inc?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:33:53 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-ZmYmNIGZTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #74)
> The fact it relies on the API should be a good thing for everyone, no one
> wants to add new CGI controller scripts that can only be tested with
> selenium :-D

The problem is having all the logic in Koha::REST, how do you do if you want to
reuse this code outside of a REST API call?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:43:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:43:03 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-GYtjgaxegV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We have some filter_by_* methods already, and I wrote them few that are in the
pipe. What about moving the parameter to a new method? That seems a quite
trivial to get a PQA stamp :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:43:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:43:28 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-NPyPs38yi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We have some filter_by_* methods already, and I wrote few more that are in the
pipe. What about moving the parameter to a new method? That seems a quite
trivial to get a PQA stamp :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:47:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:47:41 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-HGGXPiXMfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:49:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:49:27 +0000
Subject: [Koha-bugs] [Bug 24997] New: Test to ensure mappings.yaml is in the
 correct order
Message-ID: <bug-24997-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997

            Bug ID: 24997
           Summary: Test to ensure mappings.yaml is in the correct order
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

With the script introduced by bug 23204, we have the mappings.yaml that is
generated using the data in DB.
When the yaml file is modified, we must ensure that the script will generate
exactly the same contain.
A test needs to be written.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:50:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:50:06 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-lZJccizGtU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24997

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #33)
> (In reply to Jonathan Druart from comment #31)
> > Created attachment 101857 [details] [review] [review]
> > Bug 23204: Update the mappings.yaml file with the output generated
> > 
> > We need to be consistent and provide the mappings.yaml file generated by
> > the script.
> > 
> > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
> 
> Alex, Nick, can you confirm you agree with that?
> 
> If so I think we need a test to make sure further changes will be put into
> the correct place in the file.

See bug 24997.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997
[Bug 24997] Test to ensure mappings.yaml is in the correct order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:50:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 07:50:06 +0000
Subject: [Koha-bugs] [Bug 24997] Test to ensure mappings.yaml is in the
 correct order
In-Reply-To: <bug-24997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24997-70-vDe9F3Lv8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23204


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204
[Bug 23204] Script for exporting Elasticsearch mappings to YAML
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:01:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:01:38 +0000
Subject: [Koha-bugs] [Bug 24998] New: tu4n private 404
Message-ID: <bug-24998-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24998

            Bug ID: 24998
           Summary: tu4n private 404
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: raflygans82 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 101949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101949&action=edit
one hat cyber team

hacked by tu4n private 404

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:22 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-V02knT3Tc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:25 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-sMoEPZJQcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101901|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101950&action=edit
Bug 24883: Command line utility to load yaml files

This patch adds a command line utility to load
yaml files.

To test:
1) Apply the patch
2) Try loading a file, e.g. sample notices
 a) mysql -e "delete from letter"
 b) misc/load_yaml.pl -f installer/data/mysql/en/mandatory/sample_notices.yml
3) Try loading a file with a syntax error,
   edit previous file adding ':' at the end of a field without quotes
   then load again

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:30 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-ahrdNehYlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101902|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101951&action=edit
Bug 24883: Centralize code to load YAML installer files to a sub

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:34 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-k3PxFMAUpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101903|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101952&action=edit
Bug 24883: Move to a flat array with all values to an array of arrayref

For the following SQL query:
INSERT INTO cities(city_name, city_country) VALUES ('Madrid', 'Spain'),
('Buenos Aires', 'Argentina');

We move from:
[ 'Madrid', 'Spain', 'Buenos Aires', 'Argentina' ]
to:
[ [ 'Madrid', 'Spain' ], [ 'Buenos Aires', 'Argentina' ] ]

Which make more sense to split, build and construct the queries

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:38 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-C4m9RUrg2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101904|0                           |1
        is obsolete|                            |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101953&action=edit
Bug 24883: Move new sub from load_yaml.pl

Use the sub from C4::Installer to avoid dup of code.

Note:
We are going to modify the script and so will do more stuffs.
We may want to rename it, maybe installer_utilities.pl,
misc/installer/yaml_utility.pl, any suggestions?

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:06:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:06:42 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-BD2zBVwmGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101905|0                           |1
        is obsolete|                            |

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101954&action=edit
Bug 24883: Add POD entry and remove unused variable

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:07:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:07:08 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-etxTSaifYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Great! Looks good to me.
No test for process_yml_table, but no blocker for me.
We could add some more helpful messages in the future?
E.g. If I am forgetting a : after tables, file is silently ignored. Could
probably think of more examples.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:12:15 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-cOqLq1Q8Pv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:17:04 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-SudNKqBxpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Alex, I do not understand the test plan, why do you suggest having both
altcontactphone and phone in the pref?

You should use the multiple options, like for CollapseFieldsPatronAddForm.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:20:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:20:54 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-fekJkKgiR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101898|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101955&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:20:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:20:57 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-C6bi35y2qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101899|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101956&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:21:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:21:00 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-J1pAo5y4sf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101900|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101957&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:21:56 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-ljCtcrD497@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #22)
> Fixed up the schema change and kohastructure change.

Now it's really fixed.. doh!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:25:49 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-VY8NPxHhDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:25:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:25:52 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-SVByZnufN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101687|0                           |1
        is obsolete|                            |

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101958&action=edit
Bug 18177: remove aqbooksellers.othersupplier

This patchset removes some columns from the aqbooksellers table that are
not used:
 * booksellerfax
 * booksellerurl
 * bookselleremail
 * othersupplier
 * currency

The first 3 ones are certainly leftover from bug 10402.

Test plan:
For each for these fields you will make sure that they cannot be edited
from the interface.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:25:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:25:56 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-EhNIcY5s3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101688|0                           |1
        is obsolete|                            |

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101959&action=edit
Bug 18177: remove aqbooksellers.booksellerfax

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:01 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-yS8R1coCAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101689|0                           |1
        is obsolete|                            |

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101960&action=edit
Bug 18177: remove aqbooksellers.booksellerurl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:05 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-dVSXCNDTui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101690|0                           |1
        is obsolete|                            |

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101961&action=edit
Bug 18177: remove aqbooksellers.bookselleremail

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:10 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-0tdIdwfOyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101691|0                           |1
        is obsolete|                            |

--- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101962&action=edit
Bug 18177: remove aqbooksellers.currency

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:15 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-R6NlVJiz41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101692|0                           |1
        is obsolete|                            |

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101963&action=edit
Bug 18177: DB changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:19 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-sVT1Yd2ciZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101693|0                           |1
        is obsolete|                            |

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101964&action=edit
Bug 18177: DBIC changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:26:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:26:24 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-t0FrXcw5Mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101694|0                           |1
        is obsolete|                            |

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101965&action=edit
Bug 18177: Do not remove columns if at least one value exists

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:27:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:27:12 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-OAoxkaezja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+                warn "Warning - Cannot remove column aqbooksellers.$column. At
least one value exists";


Does this warn find its way to the interface. Probably not. Print it ?
I will pass QA. Feel free to add follow-up.

@RM: Watch for DBIx changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:28:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:28:08 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-B3RAY5z2m4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi,

I played again, 1 year later, with this patchset and also with Minion.

The STOMP && RabbitMQ solution looks very powerful, but I think that it is a
little bit too much for our needs.

I made a POC with Minion for comparison.
https://gitlab.com/jajm/Koha/-/commits/bug/22417-minion
There are 2 commits, there's a test plan in each commit message.

About the packaging problems mentioned in comment 1
> I first tried Minion but found problematic issues for us (Koha):
> - The mysql backend requide Mojo::mysql which requires DBD::mysql 4.042
>   However Jessie has 4.028 and Stretch 4.041
This is still true, but buster is out for a while now and has a more recent
version of DBD::mysql, so it should not be a problem to package Mojo::mysql and
Minion::Backend::mysql.
Older distributions could use the SQLite backend which works well too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:30:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:30:33 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-O7THhdjbzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:36:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:36:04 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-90WYPDG6Hr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:36:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:36:07 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-qsUEijNISo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101875|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101966&action=edit
Bug 24386: Prevent double form submission on adding orders to basket from a
file

To test:
 1 - Have a marc record file
 2 - Go to Acquisitions, find a vendor, then an open basket
 3 - Add to basket from a new file (if you already have one staged you can
choose that instead)
 4 - Import the file, then add to basket
 5 - On the page where you select the records and set info select a record, set
matching to 'Do not check' fill in the fund for the order
 6 - When ready, click save as many times as you can
 7 - When you go to the basket there are many copies of the order added
 8 - Don't despair, apply the patch
 9 - Repeat above
10 - When ready to add orders, click furiously
11 - The order is only added once!
12 - Success!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:28 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-iFzsD30s27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Joonas Kylmälä from comment #8)
> The meeting notes in
> https://wiki.koha-community.org/wiki/
> Development_IRC_meeting_27_September_2017 state that "follow-up patches must
> be squashed if not signed-off yet, and the history is not needed". It really
> makes reading the history a lot easier if we don't have unnecessary commits.

Joonas: This is not day to day experience. When I want to read a larger patch
set, I can squash it myself. But quite exceptional, I will submit the squashed
patch in QA. Theory and practice?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:37 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-zltudyU2gM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:38 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
 the z39.50 server
In-Reply-To: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24905-70-A7Z6zHXsCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:40 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-IUePAyclUZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:42 +0000
Subject: [Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been
 fetched from the DB (when searching with permissions)
In-Reply-To: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24964-70-T2LUpqiiII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:44 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-P6WUuTU16b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:46 +0000
Subject: [Koha-bugs] [Bug 24976] Guided report - "Save" button on last step
 is misleading
In-Reply-To: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24976-70-reH0FUErJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:47 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-HibaMLj2zC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:38:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:38:49 +0000
Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes
In-Reply-To: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24988-70-CZUlny7OCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:47:08 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-eW7YFcVlZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.hansen at ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:47:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:47:57 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-J5mVQKHUxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Fridolin, you forgot signoff lines. No big deal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:48:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:48:24 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-FwblYlL6qR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:48:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:48:27 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-EynWJSsIXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98963|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101967&action=edit
Bug 23888: Do not allow invalid vendor id on creating a subscription

It will avoid crash and invalid data when creating/updating a
subscription.

This could have been done with a AJAX query but seems more convenient
this way.

Test plan:
- Create or update a subscription
- In the "Vendor" input try an empty string, a valid vendor's id, and
invalid one.
=> With an empty string you get the existing alert message
=> With a valid id you do not get any messages
=> With an invalid id you are not allowed to go to page 2

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:48:31 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-iAMHIxappb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101826|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101968&action=edit
Bug 23888: (follow-up) Wrap English string in translation function

This patch makes alert added in subscription-add.js translatable using
the new __() function.

To test, apply the patch and confirm that the alert still works
correctly when submitting the subscription edit form with an invalid
vendor id.

Test that the string can be translated (using fr-Fr for example):

1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR

Switch to the fr-FR translation and confirm the the alert shows your
translated string.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Still seeing a false negative in qa tools:
    FAIL Untranslatable string found (The vendor does not exist) - See coding
guideline JS5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:48:44 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-2etuQU4xdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:50:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:50:44 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-MEmW6l8jto@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>    This could have been done with a AJAX query but seems more convenient
>    this way.

Or just lazy programming? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:21 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-ONaMn09GOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:23 +0000
Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out"
 should be renamed
In-Reply-To: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20648-70-5OVQrvvcXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:24 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 12/31/1969
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-RZQFCjV4Ej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |major
         Depends on|                            |14697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[Bug 14697] Extend and enhance "Claims returned" lost status
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:25 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-XDhLX30c1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:24 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
 status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-hkrRMOM6xE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24765


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765
[Bug 24765] Updated on date in Claims returned starts off as 12/31/1969
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:27 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-P1ZbFytpM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:29 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-E4XT2vkd9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:31 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-bWjIPXCEtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:33 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-GSTteqMNX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:35 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-X4Hp7Pqm1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:53:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:53:46 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-WDeOAb4Uvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Updated on date in Claims   |Updated on date in Claims
                   |returned starts off as      |returned starts off as
                   |12/31/1969                  |01/01/1970

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:54:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:54:51 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-bccrEyIT7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:54:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:54:54 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-g3ufe9iWNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101867|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101969&action=edit
Bug 24765: Updated on date in Claims returned starts off as 12/31/1969

When an item is claimed returned by staff, there is a column called Updated On
- this date field column should remain blank until this claimed returned has
been updated.  Currently, when an item has been claimed returned, the date in
the updated column states 12/31/1969. This date only shows up in the display,
it is doesn't show up in the database like this.

Test Plan:
1) Enable return claims
2) Make a claim
3) Note the 'updated on' column has the date 1969-12-31
4) Apply this patch
5) Reload the page ( you may need to clear your browser cache )
6) Note the field is now blank

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:57:53 +0000
Subject: [Koha-bugs] [Bug 24999] New: Date not correctly formatted in claims
 table
Message-ID: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

            Bug ID: 24999
           Summary: Date not correctly formatted in claims table
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 14697

See the Resolution column: https://snipboard.io/cqMkex.jpg

"Returned by patron on 2020-03-27 08:54:19 by koha"


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[Bug 14697] Extend and enhance "Claims returned" lost status
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 08:57:53 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
 status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-J97mJXP9NZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999
[Bug 24999] Date not correctly formatted in claims table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:01:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:01:15 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-d9Cn2xxGDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:07:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:07:04 +0000
Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to
 IFLA updates doesn't respect existing tab
In-Reply-To: <bug-24564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24564-70-HxxfNBt1A0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:07:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:07:39 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-byUVyNpL70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

--- Comment #5 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Aleisha Amohia from comment #4)
> Created attachment 101666 [details] [review]
> Bug 24900: Checks in MARC mod templates for when from field does not equal
> conditional field
> 
> When MARC modification template actions are applied, they assume that
> the from field is the same as the conditional field. This patch adds
> checks for this, as well as tests to confirm the behaviour is correct.
> 
> CASE 1: Delete 1st field 020 if 651$z exists
> BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
>                                  of 1st
> EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020
> 
> CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
> BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
> EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020
> 
> CASE 3: Delete field 020 if 650$2 does not match fast
> BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though
>                                  650$2 does match fast
> EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields
> 
> Confirm tests pass: t/db_dependent/MarcModificationTemplates.t
> 
> Sponsored-by: Catalyst IT

What I can see, this patch does as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:09:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:09:11 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-HHOZCCEKos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101666|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 101970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101970&action=edit
Bug 24900: Checks in MARC mod templates for when from field does not equal
conditional field

When MARC modification template actions are applied, they assume that
the from field is the same as the conditional field. This patch adds
checks for this, as well as tests to confirm the behaviour is correct.

CASE 1: Delete 1st field 020 if 651$z exists
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
                                 of 1st
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 3: Delete field 020 if 650$2 does not match fast
BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though
                                 650$2 does match fast
EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields

Confirm tests pass: t/db_dependent/MarcModificationTemplates.t

Sponsored-by: Catalyst IT

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:06 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-9hbv0Lb2KL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98133|0                           |1
        is obsolete|                            |

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101971&action=edit
Bug 21190: Prepare Log.t for further changes

This patch only makes cosmetic changes:
[1] It moves the existing tests at 'root level' inside a new subtest.
[2] It obviously adds indentation for step 1.
[3] It fixes some whitespace (tabs, space before newline)

Test plan:
Run t/db../Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:11 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-mNc7Zn0xKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98134|0                           |1
        is obsolete|                            |

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101972&action=edit
Bug 21190: Add subtest to Log.t for GDPR logging

Apart from a new subtest, doing some more cleanup:
[1] Copyright statement
[2] Removing the (unneeded) flush
[3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays.
[4] $succes goes to the subtest, $schema and $dbh are global our vars.
    Not required but just what we should do if it would run under Plack.

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:17 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-ODYJ2inrzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98135|0                           |1
        is obsolete|                            |

--- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101973&action=edit
Bug 21190: Add interfaces parameter to POD in C4::Logs

Just fixing documentation along the way.
No test plan, just read the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:22 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-3Po1cYSOUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98136|0                           |1
        is obsolete|                            |

--- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101974&action=edit
Bug 21190: Remove t/Log.t

Since we have t/db../Log.t and t/Log.t simply does nothing, we would
better remove it.

No test plan either :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:27 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-4DCaGLFnB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98137|0                           |1
        is obsolete|                            |

--- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101975&action=edit
Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

Test plan:
Run atomic update.
Check the Logs tab of preferences.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:32 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-u1nOUqZmnR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98138|0                           |1
        is obsolete|                            |

--- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101976&action=edit
Bug 21190: Add authentication logging to checkpw

Add optional logging for successful and failing login attempts in
checkpw.

Test plan:
Enable the preferences
Perform a good login and a bad attempt
Check action_logs

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:38 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-3mts3IQqQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98139|0                           |1
        is obsolete|                            |

--- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101977&action=edit
Bug 21190: Allow browsing the system logs for AUTH events

Trivial change, adding AUTH to viewlog template only.

Test plan:
Look for the Authentication log lines in viewlog.pl (intranet tools).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:43 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-BWmZgysiNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98140|0                           |1
        is obsolete|                            |

--- Comment #65 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101978&action=edit
Bug 21190: Add tests for authentication success and failure

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:13:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:13:48 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-cE42i7rk1i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98141|0                           |1
        is obsolete|                            |

--- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101979&action=edit
Bug 21190: (follow-up) Save patron id in failure when available

The wrong password might belong to an existing user. If that is the case,
we have a $patron.
Note that logaction will save the object info but has no user in the
context environment for a failure.

Test plan:
Login with good user, bad pw and bad user, bad pw. Check logviewer.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:14:49 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-HXrS6kNn51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased after last signoff on 30-01. Please QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:18:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:18:27 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-ficQiHFgOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #22)
> >    This could have been done with a AJAX query but seems more convenient
> >    this way.
> 
> Or just lazy programming? :)

Not only, I think it's much more efficient this way.
I did it in AJAX for the biblio, as we do not want to embed an array of all
biblionumbers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:24:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:24:53 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-cx5iUU9FDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #32)
> Hi,
> 
> I played again, 1 year later, with this patchset and also with Minion.
> 
> The STOMP && RabbitMQ solution looks very powerful, but I think that it is a
> little bit too much for our needs.
> 
> I made a POC with Minion for comparison.
> https://gitlab.com/jajm/Koha/-/commits/bug/22417-minion
> There are 2 commits, there's a test plan in each commit message.

So you need an additional DB. 2 tables to store the jobs (one for our data, to
keep track of them, one internal for minion).

I do not think STOMP is "very powerful", I picked it for its simplicity. Having
the RabbitMQ option will let sysadmins decide the flexibility they want.

Back to In Discussion then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:28:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:28:12 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-QX42DwUp46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #44)
> +                warn "Warning - Cannot remove column aqbooksellers.$column.
> At least one value exists";
> 
> 
> Does this warn find its way to the interface. Probably not. Print it ?
> I will pass QA. Feel free to add follow-up.
> 
> @RM: Watch for DBIx changes

warnings should be seen from the interface, maybe at the bottom in the red
part?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:36:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:36:18 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-yE0a6Jlh1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7902

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tomas, why did you suggest that?
I cannot remember why we should not use "DROP IF EXISTS"

If we go that way, we need:
 * a guideline (and explain why)
 * a check to the QA script

See also https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7902#c3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:36:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:36:18 +0000
Subject: [Koha-bugs] [Bug 7902] Adding Function to Check for Existence of
 Tables
In-Reply-To: <bug-7902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7902-70-MUVPn2VIWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7902

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24994

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:37:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:37:35 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-dX6CjneAS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #33)
> So you need an additional DB. 2 tables to store the jobs (one for our data,
> to keep track of them, one internal for minion).

What ? No. You can use the same database, and you do not have to keep track of
jobs manually. Minion does that for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:42:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:42:23 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-Z0RCllkIiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Even if we choose to stick to IF EXISTS it may be nice to add a QA script check
for both ADD TABLE (IF NOT EXISTS) and DROP TABE (IF EXISTS).. I know I've
missed those on occasions myself.. I don't remember there being a QA check for
it as yet (probably because we had the TableExists function as an option).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:44:08 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-I82tEW51rk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
They will indeed be displayed at the bottom of the page in red when I tested :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:48:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:48:03 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-ZVphWdOj8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #33)
> I do not think STOMP is "very powerful", I picked it for its simplicity.
> Having the RabbitMQ option will let sysadmins decide the flexibility they
> want.

STOMP is very simple indeed. But combined with RabbitMQ it becomes a powerful
solution for dispatching messages. And that's not a bad thing of course, but I
think it adds a useless layer of complexity in our case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:48:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:48:58 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-fkhvCLejos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #11 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
(In reply to Jonathan Druart from comment #9)
> Emmi, can you explain the changes a bit please?
Previously copying holidays just simply took holidays from copied branch and
inserted them into target branch. This resulted as duplicated values in
database. With this patch applied, before inserting holidays, we check which of
them are already present in target calendar. First we get all e.g weekday
holidays for both copied branch and target branch. Then, while looping holidays
from copied branch, filter out each equally valued keys/values from them with
grep and insert rest to target branch. Check for single and exception holidays
works just like before and filters all holidays from past (all holidays past
todays date).

>ie. it hurts my brain to make sure it will not introduce regression, it will help me to PQA if you could show me you know what you are doing :)
Uum, I'm not sure if above is what you need but I hope it was explanatory
enough. And headache free :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:49:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:49:39 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-ZdomxEobss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #34)
> (In reply to Jonathan Druart from comment #33)
> > So you need an additional DB. 2 tables to store the jobs (one for our data,
> > to keep track of them, one internal for minion).
> 
> What ? No. You can use the same database, and you do not have to keep track
> of jobs manually. Minion does that for you.

Does it allow additional data? Will you manage to write the dashboard I
provided with my patches? When I did my different tries bug 15032 it was not
possible (not Minion).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:54:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:54:13 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-LBi89lyoEm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |m.de.rooy at rijksmuseum.nl
   Patch complexity|Trivial patch               |Small patch

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
t/db_dependent/Koha/Patrons/Import.t .. 2/159 Argument "" isn't numeric in
numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3>
line 2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:55:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 09:55:23 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-cLVKxirrE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:12:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:12:02 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-qiAgJOzqT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #36)
> Does it allow additional data?
Yes, there is a 'note' field for this purpose
https://mojolicious.org/perldoc/Minion/Job#note

> Will you manage to write the dashboard I  provided with my patches?
> When I did my different tries bug 15032 it was not possible (not
> Minion).

Here are some screenshots of the admin UI packaged with Minion:
https://snipboard.io/n0O6lf.jpg
https://snipboard.io/QNJrLC.jpg
https://snipboard.io/tiq5dI.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:14:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:14:32 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-dJBlVmDn9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can we have a link to the European legislation? I would like to correctly
understand the need we are trying to answer with this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:16:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:16:12 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-l4HXmHhEds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:40:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:40:10 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-Db17Rliv3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:40:14 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-dX5EYihBmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 101980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101980&action=edit
Bug 17268: (follow-up) Fix translatability

This patch moves the error messages to translatable strings

Also includes capitalization fixes and POD adjustment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:28 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-WJ1k6AQnPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:31 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-UvqsSi8B65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96998|0                           |1
        is obsolete|                            |

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101981&action=edit
Bug 23473: Allow overwrite of passwords during import

To test:
 1 - Have some patrons in your system
 2 - Export some of their info via reports
    SELECT cardnumber, userid, surname, firstname, password, branchcode,
categorycode
 3 - Edit the file from above, changing all the password lines
 4 - Import the file with overwrite
 5 - Confirm passwords have not changed (run the report again and confirm the
hashes are the same)
 6 - Apply patch
 7 - Restart all the things
 8 - Check the new box on import screen to overwrite passwrods
 9 - Import file again
10 - Confirm passwords have changed
11 - Signin using new password to verify the hash is the password as supplied
12 - Repeat via commandline import supplying --overwrite_passwords option
13 - Verify works as expected
14 - Prove -v t/db_dependent/Koha/Patrons/Import.t

Sponsored-by: ByWater Solutions

Signed-off-by: Ron Marion <ron.marion at goddard.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:35 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-rrwXi6NrBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96999|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101982&action=edit
Bug 23473: (follow-up) Make passwords 'secure' for tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:40 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-AdOH5sgtP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97000|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101983&action=edit
Bug 23473: (follow-up) check if overwrite_passwords is set

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:44 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-NyoRa65Yiw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97001|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101984&action=edit
Bug 23473: (follow-up) Catch and show password exceptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:48 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-5tajWhk4nG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97002|0                           |1
        is obsolete|                            |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101985&action=edit
Bug 23473: Don't allow setting blank passwords via import

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:52 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-V1esaII2kJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97003|0                           |1
        is obsolete|                            |

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101986&action=edit
Bug 23473: Don't allow staff password changes for imports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:43:56 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-NqozwLpyBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98382|0                           |1
        is obsolete|                            |

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101987&action=edit
Bug 23473: (follow-up) Fix QA complaints (tabs, filters, Dumper)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:44:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:44:01 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-LXzKABZLG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101988&action=edit
Bug 23473: (QA follow-up) Fix number of tests

=> Looks like you planned 158 tests but ran 159.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:44:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:44:24 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-EnfbffbN4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Several smaller things. No blockers on themselves. But struggled a bit before I
got everything as it should..

misc/import_patrons: overwrite_passwords not in usage
Might be helpful to include a warning if someone includes passwords in the csv
file but forgets the switch?
Are staff lines silently ignored ?
Although we skip staff, you can promote a normal user to staff when changing
his categorycode. Do we want that? We can even add flags with value 1 to
overwrite users to superlib. I would say that we should not do that. (This is
outside the scope of this report.)

Styling on tools import could be improved for password check box?

@RM: I am passing QA reluctantly on the patch set, but have the feeling that
patron import still needs further attention. Including some security issues.
Especially overwriting a regular user with import privs with superlibrarian
privs and after that taking over control is not nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:46:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:46:53 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-9HCzAEYGqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #69 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #68)
> Can we have a link to the European legislation? I would like to correctly
> understand the need we are trying to answer with this patch set.

Comment1. Vitor ?
Note that it is preference controlled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:48:44 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-OI7SGK2C6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23404
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:48:44 +0000
Subject: [Koha-bugs] [Bug 23404] Circulation::TooMany error on itemtype when
 at biblio level
In-Reply-To: <bug-23404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23404-70-8Kbh90ChXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23404

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16787

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:51:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:51:00 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-1krD8uYBpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #34 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 23404 also fixed a itemtype issue in holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:52:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:52:01 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-hLilZuKmiP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ok so we don't handle collision (on title or description for instance), but I
think that's correct as it.
Thanks for the explanation, looks like I was feeling lazy yesterday!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:56:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:56:27 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-op3UA6VziB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #78 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #72)
> 1) QA test tool fail

Fixed - new POD complaint is false positive

> 2) Translatability

Fixed

> There are also some other glitches in the Javascript code:

Fixed

> 3) Should these API additions be voted on?

https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC

> 4) Capitalization

Fixed

> 5) Testing went well, but I am wondering if there is an issue with our MACRO
> language. A lot of the examples I tried from the wiki would not work:

Several of the wiki examples had bad characters
ǂ != ‡ - fixing those made the macros work for me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:57:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:57:11 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-hsS1FFBm5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
2 things about the tests:
* Why do you use raw SQL queries to retrieve holidays, who not using existing
subroutines?
* It's better to flush the cache at the end of the tests, holidays are set in
cache. It would make sense to have a flush at the end of the test file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:59:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 10:59:32 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-yWg1oWfWFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #69)
> (In reply to Jonathan Druart from comment #68)
> > Can we have a link to the European legislation? I would like to correctly
> > understand the need we are trying to answer with this patch set.
> 
> Comment1. Vitor ?
> Note that it is preference controlled.

Sorry, I do not read Portuguese.

If we are going to implement/release a GDPR recommendation we should at least
point to the legislation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:03:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:03:24 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-TWlNGLVFjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #35 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
> This patch also fixes a FIXME about using effective_itemtype to fetch item rules

Looks like there are several places where GetBranchItemRule() is called with
$item->itype instead of $item->effective_itemtype.
Maybe we should create a new Bug for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:04:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:04:12 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-75IPRKRG0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not we make sure only superlibrarian is allowed to overwrite
superlibrarian's passwords?

Or maybe only enable the feature from the command line?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:06:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:06:52 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-6pJOy9A20i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> Tomas, why did you suggest that?
> I cannot remember why we should not use "DROP IF EXISTS"
> 
> If we go that way, we need:
>  * a guideline (and explain why)
>  * a check to the QA script
> 
> See also https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7902#c3

I pointed a case of table creation. Maybe my comment was too generic. I have no
opinion on the drop case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:08:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:08:58 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-P9mtK64TOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #76)
> (In reply to Tomás Cohen Arazi from comment #74)
> > The fact it relies on the API should be a good thing for everyone, no one
> > wants to add new CGI controller scripts that can only be tested with
> > selenium :-D
> 
> The problem is having all the logic in Koha::REST, how do you do if you want
> to reuse this code outside of a REST API call?

The logic in the API is mostly permission based, and pretty light in my
opinion. Why are you interacting with this code outside of the API, and what
are you trying to do?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:12:04 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-xzsBQ7nSzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #80 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #76)
> (In reply to Tomás Cohen Arazi from comment #74)
> > The fact it relies on the API should be a good thing for everyone, no one
> > wants to add new CGI controller scripts that can only be tested with
> > selenium :-D
> 
> The problem is having all the logic in Koha::REST, how do you do if you want
> to reuse this code outside of a REST API call?


Well, we try not to do that. In this case there's really no business logic
besides permission checking, which we traditionally do in the controllers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:13:28 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-NAUjmPrnGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #24 from Simon Perry <simon.perry at itcarlow.ie> ---
Thanks for clarification Jonathan, from your comments it looks like I should be
selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in
assuming that the DaysMode column in the Circulation rules table will override
what is set in the useDaysMode syspref? And therefore if the Days Mode column
in the Circ. rules table is set to 'Default' it will use whatever value is set
for the useDaysMode syspref?

Tooltip is useful and I guess the other thing is to ensure it is well
documented in the Koha circulation help. I'll retest and feedback results.
Regards, Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:14:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:14:21 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-bU6t1RGu5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101989&action=edit
Bug 22002: (RM follow-up) Allow RaiseError tests in Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:17:41 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-9pWs8sTjSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Aleisha Amohia from comment #13)
> (In reply to Fridolin SOMERS from comment #12)
> > alternate patch ? Its more a follow-up no ?
> 
> Alternate patch, because in Comment 6 it was mentioned that the first patch
> doesn't really fix the problem

Ah in this case set it obsolete or set status In Discussion :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:20:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:20:54 +0000
Subject: [Koha-bugs] [Bug 24773] Report spacing incorrect on import from Mana
In-Reply-To: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24773-70-1pIz4DSWds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24773

--- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Hello,

Borken reports in Mana came from bad formatted CSV file.

I removed all of this reports from DB, clear all related CSV and imported them
agsin.

deleted 1719 reports
re-imported 977

The difference is due to the bad formatted report i've removed from CSV. And
one CSV (656 lines )i could not fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:27:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:27:12 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-ZAdGQ6QAYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #37)
> Should not we make sure only superlibrarian is allowed to overwrite
> superlibrarian's passwords?
> 
> Or maybe only enable the feature from the command line?

See bug 23473 for follow-up patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:27:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:27:22 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-1d9rfw4aZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24375

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:32:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:32:04 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-e0fXae8V4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 101990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101990&action=edit
Bug 22001: (RM follow-up) Allow RaiseError tests in Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:32:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:32:30 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-dv9PvB7p2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:32:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:32:40 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-yUsOfM8Zoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101989|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:34:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:34:01 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-qFK1mIrDAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101991&action=edit
Bug 22001: Fix Reports/Guided.t tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:36:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:36:10 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-O54SgGfMwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:38:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:38:58 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-v4bGDsTlTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm....

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:42:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:42:42 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-It9X1i1waQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96484|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:43:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:43:07 +0000
Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
In-Reply-To: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24266-70-42hUnSqQiy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Let's try Aleisha patch and see if it fixes the original issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:44:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:44:35 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-a8jMpiNvw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #14 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
(In reply to Jonathan Druart from comment #13)
> 2 things about the tests:
> * Why do you use raw SQL queries to retrieve holidays, who not using
> existing subroutines?
Simply because calendars subroutines hide this bug. If you look at the
descriptions for them in C4::Calendar.pm it is stated that they return a hash
reference which use holidays as keys. So all duplicate values are (naturally)
ignored. I tried to use them but in the end only solution I could come up with
was those queries :/  

> * It's better to flush the cache at the end of the tests, holidays are set
> in cache. It would make sense to have a flush at the end of the test file.
You're right, missed that one. I'll add it at some point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:44:43 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-eEV4T9dFWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Simon Perry from comment #24)
> Thanks for clarification Jonathan, from your comments it looks like I should
> be selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in
> assuming that the DaysMode column in the Circulation rules table will
> override what is set in the useDaysMode syspref? And therefore if the Days
> Mode column in the Circ. rules table is set to 'Default' it will use
> whatever value is set for the useDaysMode syspref?

Yes, that's exactly how it is supposed to work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:48:04 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-66mVZS8b4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999
[Bug 24999] Date not correctly formatted in claims table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:48:04 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-IdjpryKSxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24765


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765
[Bug 24765] Updated on date in Claims returned starts off as 01/01/1970
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:51:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:51:29 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-nWE2Rf3UuG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:51:32 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-mqla8FcQRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99121|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101992&action=edit
Bug 16547: Do not display "multi holds" view if only one is selected

If a hold is selected from the result list, we should let the ability to
select an item-level hold.

Test plan:
I. Detail page
1/ Go to a bibliographic record detail page
2/ Click "Place hold"
3/ Select a patron
=> No change expected, you can select an item

II. Search result, multiple holds
1/ Search for an item with more than one search result
2/ Select several items, click 'Place hold'
3/ Enter a patron card number
=> No change expected, item level holds are not available.

III. Search result, single hold
1/ Search for an item with more than one search result
2/ Select only one item, click 'Place hold'
3/ Enter a patron card number
=> With this patch applied, item level hold is available. The screen is the
same
as when you place a hold from the bibliographic record detail page
=> Without this patch you cannot place an item-level hold

QA notes: We could go a bit further and remove the 2 biblionumbers and
biblionumber from hold script, as well as remove the checkMultiHold in
request.tt. We should not have a biblionumbers param that contain a list
of biblionumber separated by '/' but several biblionumber parameters
instead.

QA notes 2: About placerequest.pl, see bug 19618 comment 27.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:57:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:57:54 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-4ilQnynNL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #37)
> Should not we make sure only superlibrarian is allowed to overwrite
> superlibrarian's passwords?
> 
> Or maybe only enable the feature from the command line?

See bug 23473 for follow-up patches.(In reply to Jonathan Druart from comment
#37)
> Should not we make sure only superlibrarian is allowed to overwrite
> superlibrarian's passwords?
> 
> Or maybe only enable the feature from the command line?

See bug 24375 for follow-up patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 11:59:25 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-5iJRN5kfFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #37)
> Should not we make sure only superlibrarian is allowed to overwrite
> superlibrarian's passwords?
> 
> Or maybe only enable the feature from the command line?

See bug 24375 for follow-up patches.

(Sorry for the noise!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:08 +0000
Subject: [Koha-bugs] [Bug 25000] New: SQL report not updated
Message-ID: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

            Bug ID: 25000
           Summary: SQL report not updated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kohadevinim at devinim.com.tr
        QA Contact: testopia at bugs.koha-community.org

Database is not updated when sql reports was edited

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:30 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-8MpI0ZpC0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24614
           Assignee|koha-bugs at lists.koha-commun |kohadevinim at devinim.com.tr
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614
[Bug 24614] Can't edit reports if not using cache
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:30 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-l3hsGgFBpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25000


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000
[Bug 25000] SQL report not updated
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:44 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-1aJ5hqkt6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:46 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-rwAJwWIXQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:48 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-UoPqGNnGdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:50 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-aNWEMos3IH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:52 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-TXWZ4FA9kK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:54 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23473-70-J5SKqkoyMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:56 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-Qkcm0NAdVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:23:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:23:58 +0000
Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription
 creation causes internal server error
In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23888-70-OqABYvc9UA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:00 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-ppiNmxPPxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:02 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24386-70-1cg47OFOHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:04 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-hqwHhgsBf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:06 +0000
Subject: [Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
In-Reply-To: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24700-70-MPdq8NDVUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:08 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-8XrIUAQE8D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:10 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-dpzQeyU6mS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:12 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-2kbSJSpw5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:14 +0000
Subject: [Koha-bugs] [Bug 24883] Command line utility to load yaml files
In-Reply-To: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24883-70-dsMYKNBbNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:15 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-dUmI2Qd0QU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:24:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:24:17 +0000
Subject: [Koha-bugs] [Bug 24982] Use checkboxes in Log Viewer instead of
 select dropdowns
In-Reply-To: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24982-70-v8rU22NIQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24982

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:30:45 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-P1tA9GWnu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:30:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:30:48 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-FD33pSW9A6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

--- Comment #1 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 101993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101993&action=edit
Bug 25000: SQL report not updated

Test plan
1- Save and run sql report.
2- Then edit this report and run.
3- You will see that the change is not applied.
4- Apply this patch
5- Update the report and run it again.
6- You will see the updated version is working.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:35:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:35:01 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-07DpgLwYpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|25000                       |
             Blocks|                            |25000


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000
[Bug 25000] SQL report not updated
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:35:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:35:01 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-mUWdAcInEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24614                       |
         Depends on|                            |24614


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614
[Bug 24614] Can't edit reports if not using cache
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:35:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:35:29 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-R16kzz2yEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ooops.. trivial fix..

PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:35:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:35:30 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-V66U6WLEhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ISSN column in serials  |Always add ISSN in serials
                   |claims table - fix          |claims issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:35:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:35:33 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-ZKogHFHtso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:36:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:36:10 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-bB6915Ibsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:36:14 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-vRpnzsJZDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:36:14 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-UkBlj6POnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101994&action=edit
Bug 17703: Always add ISSN in serials claims issues

Bug 11861 added ISSN column in serials claims table and a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if $supplierid condition, the same change must be
done if $serialid to allow ISSN in CVS export of claims.

This patch rewrites the method to have a common SQL query with conditions only
on WHERE.
Removes the order input arg since it is never used, order in TT is managed by
DataTable and CSV export is generated with the order of selected rows.

Test plan:
- Make sure you have a subscription with some late or missing issues
- Go to Tool > CSV profils
- Create a profile :
  Profile name = Issues to claim
  Profile type = SQL
  Usage = Late serial issues claims
  Profile SQL fields =
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
- Go to serials claims page : /cgi-bin/koha/serials/claims.pl
- Choose a vendor and click OK
- You see serials to claim, with ISSN column filled with subscription's ISSN
- Check all lines
- Select "Issues to claim" CSV profile
- Click on "Download selected claims"
=> With patch you have ISSN value

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:36:16 +0000
Subject: [Koha-bugs] [Bug 25000] SQL report not updated
In-Reply-To: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25000-70-qGqnTKa54F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:39:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:39:56 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-eBElmfHpyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #9 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #8)
> When should we deal with tz when displaying dates?
> 
> What are the different possibilities offered by js-date-format.inc?

Hi Jonathan, with this patch, js-date-format can detect if incoming date is
just date only, or something else.. 

So, this functions should be used to transform date and datetime to Koha's
defined format. If the first, it's just transformed to the corresponding
format, if the later it will also be transformed to the corresponding timezone.

With Martin's bug 24850, datetimes from database has timezone now, so I don't
believe we will have more cases, but maybe I'm not seeing the big picture.

Do you have any other case in mind?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:41:08 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-sPnSZjHfJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:41:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:41:10 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-jvtXM1FXcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 101995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101995&action=edit
Bug 24996: Unwanted CSS change unhides OPAC results sorting button

This patch adds back a CSS selector which was incorrectly removed by Bug
23915. The "Go" button associated with the OPAC search results resort
operation should be hidden if JavaScript is enabled.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Perform a search in the OPAC
 - On the search results page, there should be no "Go" button next to
   the re-sort/results per page selection fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:43:21 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-GzJLEKSo9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66150|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:48:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:48:10 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-oxHp1NZ39M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. so my understanding of why we need to support timezone in this js function
at all is that we are effectively replacing the native toLocalDateString(). 
That function, in my understanding, does too things.. it converts Date
prototypes to a locale based formatted string and also ensures the output is in
the local timezone (if the original Date prototype has a timezone associated
with it upon creation).

Our function takes an RFC3339 formatted string, which is what the API returns.
These strings have timezones attached, if we used toLocalDateString to output
them, then we would get the timezone of the browser applied.. which may differ
from our koha instances configured timezone.. and thus the one that all our
templates currently output in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:48:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:48:17 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-ZbB6nEStsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101996&action=edit
Bug 17703: add unit test

Run : prove t/db_dependent/Serials/Claims.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:49:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:49:10 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-aNaKHoedqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101994|0                           |1
        is obsolete|                            |

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101997&action=edit
Bug 17703: Always add ISSN in serials claims issues

Bug 11861 added ISSN column in serials claims table and a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if $supplierid condition, the same change must be
done if $serialid to allow ISSN in CVS export of claims.

This patch rewrites the method to have a common SQL query with conditions only
on WHERE.
Removes the order input arg since it is never used, order in TT is managed by
DataTable and CSV export is generated with the order of selected rows.

Test plan:
- Make sure you have a subscription with some late or missing issues
- Go to Tool > CSV profils
- Create a profile :
  Profile name = Issues to claim
  Profile type = SQL
  Usage = Late serial issues claims
  Profile SQL fields =
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
- Go to serials claims page : /cgi-bin/koha/serials/claims.pl
- Choose a vendor and click OK
- You see serials to claim, with ISSN column filled with subscription's ISSN
- Check all lines
- Select "Issues to claim" CSV profile
- Click on "Download selected claims"
=> With patch you have ISSN value

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:49:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:49:24 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-ludp25t39n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100886|0                           |1
        is obsolete|                            |

--- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101998&action=edit
Bug 13345: Allow patrons to choose format on sending basket/list by email

It is already possible to download a basket(cart) or a list using
different format.
But by email, only iso2709 is possible.

This patch adds the ability to select a format for the file attached to
the email when sending the basket/list content.

Test plan:
1/ At the OPAC, add some records to your basket and send it by email
using different formats (RIS, BibTeX, MARC and the CSV profiles defined).
2/ At the OPAC, add some records to a list and send it by email using
the different formats.
3/ Redo step 1 at the intranet
4/ Redo step 2 at the intranet

Note that subtitles are not displayed in all these cases.

Note for QA: This patch refactors 3 main things:
1/ Template side: the dropdown list to select the format is now in an
include file (indeed, this list is used in 4 templates, this will make
easier further changes).
The include files are named 'download-export-available-formats.inc',
feel free to suggest something better.
The are used in:
[opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and
[opac-]downloadshelf.tt.

2/ Build records data and the records file
This job was done in 4 scripts:
 - opac/opac-sendbasket.pl
 - opac/opac-sendshelf.pl
 - basket/sendbasket.pl
 - virtualshelves/sendshelf.pl
Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are
provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t
Not that a similar job is done in [opac-]downloadcart.pl and
[opac-]downloadshelf.pl

3/ Build the subject and body of the email sent
Same as before, the job was done at the same places.
Now it's done in Koha::Email->fill_body_for_sending (feel free to
suggestion a better name) and tests are provided in t/Koha_Email.t

Sponsored-by: Mines Paristech
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:49:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:49:30 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-cf7pGgPdaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

--- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 101999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101999&action=edit
Bug 13345: Fix BuildBiblioDataForExport tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:49:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:49:48 +0000
Subject: [Koha-bugs] [Bug 22774] Limit number of purchase suggestions per
 patron in a specified time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-9XYhQC2vfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

--- Comment #21 from Devinim <kohadevinim at devinim.com.tr> ---
(In reply to Katrin Fischer from comment #20)
> 
> 1) QA test tools
> 
> Looks good, only got what looks like a false positive:
> 
> Processing additional checks
> 	* Email's author 'kohadevinim at devinim.com.tr' seems invalid

Hi Katrin,

I didn't understand that. It is one of our valid email address.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:50:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:50:01 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
 basket/list by email
In-Reply-To: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-knYU0sAwHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:52:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:52:38 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-nIZBohD78z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 102000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102000&action=edit
Bug 17703: Add unit tests

Run : prove t/db_dependent/Serials/Claims.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:52:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:52:44 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-efpjev3aIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101997|0                           |1
        is obsolete|                            |

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 102001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102001&action=edit
Bug 17703: Always add ISSN in serials claims issues

Bug 11861 added ISSN column in serials claims table and a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if $supplierid condition, the same change must be
done if $serialid to allow ISSN in CVS export of claims.

This patch rewrites the method to have a common SQL query with conditions only
on WHERE.
Removes the order input arg since it is never used, order in TT is managed by
DataTable and CSV export is generated with the order of selected rows.

Test plan:
- Make sure you have a subscription with some late or missing issues
- Go to Tool > CSV profils
- Create a profile :
  Profile name = Issues to claim
  Profile type = SQL
  Usage = Late serial issues claims
  Profile SQL fields =
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
- Go to serials claims page : /cgi-bin/koha/serials/claims.pl
- Choose a vendor and click OK
- You see serials to claim, with ISSN column filled with subscription's ISSN
- Check all lines
- Select "Issues to claim" CSV profile
- Click on "Download selected claims"
=> With patch you have ISSN value

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:53:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:53:23 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-TsocJFxS6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101996|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:54:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:54:25 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17703-70-2QSbQTDVEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #8)
> please provide a test.

Here it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:59:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 12:59:26 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-bZRXZTnajB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #37 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
We would really like this one in 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:04:53 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-1bfQD9Mq0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #50)
> Upgrade to 19.12.00.054 done [07:00:32]: Bug 13881 - Add desk management
> DBD::mysql::db do failed: You have an error in your SQL syntax; check the
> manual that corresponds to your MariaDB server version for the right syntax
> to use near 'A' at line 2 [for Statement "
>             ALTER TABLE suggestions ADD CONSTRAINT
> `suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`)
> REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE
> CASCADE
>             A
>         "] at installer/data/mysql/updatedatabase.pl line 21300.

Hi Marcel, I think that#s the wrong bug - that's changes to suggestions, not
desks. (see 23590)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:06:16 +0000
Subject: [Koha-bugs] [Bug 17915] warning in Stage MARC records for import
 when matching rule with offset
In-Reply-To: <bug-17915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17915-70-bMxZeQyHNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Owen Leonard from comment #3)
> I was able to reproduce this problem in master, and the patch does make the
> error go away. However, I'm seeing a different error now:
> 
> stage-marc-import.pl: DBIx::Class::Storage::DBI::select_single(): Query
> returned more than one row.  SQL that returns multiple rows is DEPRECATED
> for ->find and ->single at /home/vagrant/kohaclone/Koha/Objects.pm line 92
> 
> Is this error within the scope of this bug?

Oh could you test again please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:06:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:06:34 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-Tx8Hg7a78l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:06:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:06:37 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-02OihWtS5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101992|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 102002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102002&action=edit
Bug 16547: Do not display "multi holds" view if only one is selected

If a hold is selected from the result list, we should let the ability to
select an item-level hold.

Test plan:
I. Detail page
1/ Go to a bibliographic record detail page
2/ Click "Place hold"
3/ Select a patron
=> No change expected, you can select an item

II. Search result, multiple holds
1/ Search for an item with more than one search result
2/ Select several items, click 'Place hold'
3/ Enter a patron card number
=> No change expected, item level holds are not available.

III. Search result, single hold
1/ Search for an item with more than one search result
2/ Select only one item, click 'Place hold'
3/ Enter a patron card number
=> With this patch applied, item level hold is available. The screen is the
same
as when you place a hold from the bibliographic record detail page
=> Without this patch you cannot place an item-level hold

QA notes: We could go a bit further and remove the 2 biblionumbers and
biblionumber from hold script, as well as remove the checkMultiHold in
request.tt. We should not have a biblionumbers param that contain a list
of biblionumber separated by '/' but several biblionumber parameters
instead.

QA notes 2: About placerequest.pl, see bug 19618 comment 27.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:08:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:08:25 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-2HW9GAPMkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> Several of the wiki examples had bad characters
> ǂ != ‡ - fixing those made the macros work for me

That's a relief! Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:11:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:11:28 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-O2f2gpBKVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

--- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Leaving this for the moment in Tomas' and Nick's hands to resolve and hope to
see things move soon!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:13:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:13:20 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
 ccl.properties
In-Reply-To: <bug-10740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-OaqoV98WA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Marc Véron from comment #24)
> Still valid?

In ES the search field is without slash, see Bug 22524

But with Zebra the index is "1012    Date/time-last-modified" and
Date-time-last-modified is an alias.

Since it works I close.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:14:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:14:54 +0000
Subject: [Koha-bugs] [Bug 7029] searching : fuzzy et steming
In-Reply-To: <bug-7029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7029-70-Eg5PD8XhCZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:17:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:17:00 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-LntBWWFjI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #71 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The problem is, that GDPR does not describe technical measures - so all we
might have here is the Portugese guidelines. We can check if other
jurisdictions have done similar, but we will probably not find something
specific in the law itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:17:41 +0000
Subject: [Koha-bugs] [Bug 7029] searching : fuzzy et steming
In-Reply-To: <bug-7029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7029-70-CjrAuCOkz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Really too tricky bug, I move on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:19:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:19:25 +0000
Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values
In-Reply-To: <bug-9740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9740-70-via4SEdLGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:28:57 +0000
Subject: [Koha-bugs] [Bug 25001] New: 'News' should be renamed now we are
 migrating other content blocks to it
Message-ID: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

            Bug ID: 25001
           Summary: 'News' should be renamed now we are migrating other
                    content blocks to it
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We are in the process of migrating system preferences to the 'News' tool, but
many of these editable content blocks are not 'News'.. We should rename the
tool to reflect it's overall purpose.

'Blocks' or 'Content blocks' perhaps?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:29:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:29:17 +0000
Subject: [Koha-bugs] [Bug 25001] 'News' should be renamed now we are
 migrating other content blocks to it
In-Reply-To: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25001-70-n3nQ406NkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:29:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:29:36 +0000
Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other
 content areas
In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22318-70-SRroKWHq81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Bug added: 25001

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:29:47 +0000
Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other
 content areas
In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22318-70-lV3vbOUYDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001
[Bug 25001] 'News' should be renamed now we are migrating other content blocks
to it
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:29:47 +0000
Subject: [Koha-bugs] [Bug 25001] 'News' should be renamed now we are
 migrating other content blocks to it
In-Reply-To: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25001-70-mpKBwnfJwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22318


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:30:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:30:36 +0000
Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor -
 macros are lost when browser storage cleared
In-Reply-To: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17268-70-bodKL8Mzv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268

--- Comment #83 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Tomás Cohen Arazi from comment #80)
> (In reply to Jonathan Druart from comment #76)
> > (In reply to Tomás Cohen Arazi from comment #74)
> > > The fact it relies on the API should be a good thing for everyone, no one
> > > wants to add new CGI controller scripts that can only be tested with
> > > selenium :-D
> > 
> > The problem is having all the logic in Koha::REST, how do you do if you want
> > to reuse this code outside of a REST API call?
> 
> 
> Well, we try not to do that. In this case there's really no business logic
> besides permission checking, which we traditionally do in the controllers.

First of all, really great work Nick!

* About the endpoint path, if we are talking about patron's macros, I believe
it would make more sense to have something like

GET /api/v1/patrons/{patron_id}/advancededitormacros
GET /api/v1/patrons/{patron_id}/advancededitormacros/{advancededitormacro_id}
etc...

Meaning patron_id should be in the path

* An idea for having OR conditions for resources access is to have it specified
in x-koha-authorization, for example

"x-koha-authorization": {
    "permissions": {
        "editcatalogue": "advanced_editor"
    },
    "or-condition": {
        "shared": 1
    }
}

and have object.search build that dbic query whit the patron_id it founds in
the path.. permissions will always be checked before this in Auth.pm.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:42:33 +0000
Subject: [Koha-bugs] [Bug 22774] Limit number of purchase suggestions per
 patron in a specified time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-64c2KwSdP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 
> I didn't understand that. It is one of our valid email address.

Yep, was just noting it - we can safely ignore it in my opinion. Maybe it's not
aware of com.tr?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:43:16 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-NJxTOv57XV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #44)
> (In reply to Katrin Fischer from comment #42)
> > Hi Jonathan, can you please rebase?
> 
> The patches applied ok. The one that does not it DBIC changes, it can be
> done this way:
>  % git bz apply --skip
>  % dbic
> 
> That's it :)

I did that on one of Nick's patches recenlty and then he had some thing
dependent on it in the ohter patches - thought I'd play it safe here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:54:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:54:46 +0000
Subject: [Koha-bugs] [Bug 24994] TableExists should be used instead of IF
 NOT EXISTS in updatedatabase
In-Reply-To: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24994-70-3P5mkZwSlC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
DROP IF EXISTS could be bad for features we backported that include tables. The
data would be lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:55:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:55:10 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-JravLP7R9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #59 from Kelly McElligott <kelly at bywatersolutions.com> ---
I agree with Sonia.  Although yes the scope of the bug is to 

 Block deletion of the last item for a Biblio on which a hold is placed on, to
avoid phantom holds (original issue reported)


I would say we would want the same behavior on item level holds. Is this
another bug or the grand scope of batch item deletion? 

If I have 1 item level hold on a bib with 2 items, Koha will let me delete both
items with no problem. Koha should stop this behavior, in my opinion as well.
If Koha knows when I am deleting all the items off a record, shouldn't that be
able to stop it?

That being said, the test plan does work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 13:55:35 +0000
Subject: [Koha-bugs] [Bug 24998] SPAM
In-Reply-To: <bug-24998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24998-70-A1F3lDxAef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24998

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|tu4n private 404            |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:13:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:13:55 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-crlI8Wqd6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

pierre.genty02 at univ-paris8.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre.genty02 at univ-paris8.
                   |                            |fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:18:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:18:20 +0000
Subject: [Koha-bugs] [Bug 25001] 'News' should be renamed now we are
 migrating other content blocks to it
In-Reply-To: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25001-70-PwKkGOqC2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:21:16 +0000
Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in
 patron accounting
In-Reply-To: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24604-70-UxxYnmh4UG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:21:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:21:51 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-vAGeNazrOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:30:31 +0000
Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in
 patron accounting
In-Reply-To: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24604-70-72d7EkLKCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:30:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:30:34 +0000
Subject: [Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in
 patron accounting
In-Reply-To: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24604-70-fSuQlTAC9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98549|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102003&action=edit
Bug 24604: Add 'Pay' button under Transactions tab in patron accounting

It does the same thing as the 'Pay' button under 'Make a payment' tab.
It is nothing more than a shortcut.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:34:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:34:03 +0000
Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
In-Reply-To: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24603-70-tIy1311Yf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:42:57 +0000
Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write
 off' mode
In-Reply-To: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24610-70-lqmw23wpgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:51:38 +0000
Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
In-Reply-To: <bug-24699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24699-70-0YfI1r4rsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 14:51:41 +0000
Subject: [Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
In-Reply-To: <bug-24699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24699-70-N2ajnQbf4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99468|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102004&action=edit
Bug 24699: Split items.uri in OPAC detail view

Same change as in bug 24697 for staff. If there are more URIs in 952u,
we split them and show the real URL instead of Link to resource or the
value of pref URLLinkText.

I introduced a few template variables here to make the code a bit more
compact and readable.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no errors.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:05:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:05:53 +0000
Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
In-Reply-To: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24603-70-alnCPoCBET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98551|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 102005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102005&action=edit
Bug 24603: Allow to cancel charges in patron accounting

There is already a button to void a payment. It should be possible to
cancel a charge too.

This patch adds a button in patron's accounting section (Transactions
tab) that allow to cancel charges.
Charges that have been fully or partially paid cannot be cancelled.

It also fixes Koha::Account::Line::is_credit by looking at
credit_type_code instead of amount (amount can be 0 for voided payments)

It also fixes the tests for Koha::Account::Line::void when database does
not contain the borrowernumber 51 (the default in
t::lib::Mocks::mock_userenv)

Test plan:
1. Go to a patron's accounting section
2. Create a manual invoice
3. In Transactions tab, you should see a 'Cancel charge' button. Click
   on it. It should now be marked as cancelled
4. Create another manual invoice
5. Pay it (partially or fully)
6. Notice that the 'Cancel charge' button is not available
7. Void the payment
8. 'Cancel charge' button is available again. Click on it and verify
   that it still works
9. prove t/db_dependent/Koha/Account/Lines.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:06:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:06:05 +0000
Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
In-Reply-To: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24603-70-N41ZjxOYQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:09:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:09:35 +0000
Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write
 off' mode
In-Reply-To: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24610-70-whPGZfjBSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98566|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 102006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102006&action=edit
Bug 24610: Let user switch between 'Pay' and 'Write off' mode

In patron's accounting section, under 'Make a payment' tab, you have the
choice between 'Pay' and 'Write off'. It takes you to another form, but
once there you cannot change mode. You have to click on Cancel,
re-select the lines you had selected (if you made a selection) and click
on the right button.

This patch adds link above the form to easily switch between the two
modes.

Also fixes a CSS bug to be able to use Bootstrap's nav pills inside
.statictabs

Test plan:
1. Create some manual invoices
2. Go to 'Make a payment' tab
3. Click on the 'Pay' button in a table row
4. Above the form you should see two links ('Pay' and 'Write off').
   Click on 'Write off', confirm the write off and verify that it did
   make a 'write off'.
5. Go to 'Make a payment' tab
6. Click on the 'Write off' button in a table row
7. Click 'Pay', confirm the pay and verify that it did make a 'pay'
8. Go to 'Make a payment' tab
9. Select some lines and click on 'Pay selected'
10. Click on 'Write off', confirm the 'write off' and verify that it did
    make a 'write off'
11. Go to 'Make a payment' tab
12. Select some lines and click on 'Write off selected'
13. Click on 'Pay', confirm the pay and verify that it did make a 'pay'

Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:09:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:09:40 +0000
Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write
 off' mode
In-Reply-To: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24610-70-UDj30ScdJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98567|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 102007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102007&action=edit
Bug 24610: Compiled CSS

Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:09:55 +0000
Subject: [Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write
 off' mode
In-Reply-To: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24610-70-SPHovPRMIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:11:50 +0000
Subject: [Koha-bugs] [Bug 25002] New: JS Includes should be wrapped with
 template comments
Message-ID: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

            Bug ID: 25002
           Summary: JS Includes should be wrapped with template comments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When debugging, we are often faced with a nameless <script> area when it comes
to inspecting the page.. it would be helpful to have an HTML comment wrapping
these script in our includes so you can quickly identify where the JS is coming
from.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:14:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:14:30 +0000
Subject: [Koha-bugs] [Bug 25003] New: Clearly identify when JavaScript
 errors are caused by OPACUserJS/IntranetUserJS
Message-ID: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

            Bug ID: 25003
           Summary: Clearly identify when JavaScript errors are caused by
                    OPACUserJS/IntranetUserJS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When a page within Koha has been broken by code introduced via the UserJS
sysprefs, we should make that clear in the browser console.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:14:48 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-aJWTvhQiDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:15:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:15:28 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-LZFgIR6Dmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
See first few minutes of the `Koha Virtual Hackfest - Code Spaghetti` live
stream recording for further context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:18:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:18:27 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-zot3ipWcUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This patch is an enhancement in the sense that it displays useful info about
"deletion impossible", but can be considered as a bugfix (and so backported) as
it will prevent phantom holds.

I would deal with a behavior change on a separate bug report. IMO it's not
obvious that everybody wants to block items (that have holds) deletion (there
is an alert already to tell that holds will be deletion along with the item).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:19:05 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-AzIUvwHmWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Switching back to NSO.

Thanks for the feedback, Sonia and Kelly!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:27:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:27:28 +0000
Subject: [Koha-bugs] [Bug 25004] New: Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
Message-ID: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

            Bug ID: 25004
           Summary: Search results place hold button not enabled when
                    checking result checkboxes on opac-search.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
0 - Make sure ability to place holds on OPAC is enabled (RequestOnOpac)
1 - Search on the opac to get multipel results
2 - Note place hold button is disabled
3 - Check a box next to a result
4 - Note place hold button not enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:32:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:32:40 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
In-Reply-To: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25004-70-4JnofdeCjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:32:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:32:43 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
In-Reply-To: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25004-70-J5EEDyhwcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 102008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102008&action=edit
Bug 25004: Fix selector for checkboxes on results page

To recreate:
0 - Make sure ability to place holds on OPAC is enabled (RequestOnOpac)
1 - Search on the opac to get multipel results
2 - Note place hold button is disabled
3 - Check a box next to a result
4 - Note place hold button not enabled
5 - Apply patch
6 - Do a new search
7 - Check a checkbox
8 - Note the 'PLace hold' button is enabled
9 - Sign off! Do a happy dance! Hugs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:35:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:35:25 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-3tX0PzO2cH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #26 from Simon Perry <simon.perry at itcarlow.ie> ---
Created attachment 102009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102009&action=edit
testing 270320

Hi Jonathan,
I've now tested with UsedaysMode set to 'Push due date to next open day' and
Days Mode set to 'Days' for the hourly loan rule. Checkout for an hourly loan
item type with today set as a library closed day correctly retained today as
the due date with an hour's loan allowed. See screenshots of test. I'd like to
do some more testing with different useDaysMode syspref values before signing
off. Unfortunately the sandbox has got very slow for some reason this afternoon
(in fact I cannot connect to it right now). Maybe it could do with a refresh?
I'll check again on Monday.
Regards, Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:37:28 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-iwurrxoTYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102010&action=edit
Bug 23204: Fix tests swapping fields (they are not ordered)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:46:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:46:58 +0000
Subject: [Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
In-Reply-To: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18177-70-hX8WMBG7we@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102011&action=edit
Bug 18177: (follow-up) remove aqbooksellers.currency

There was an occurrence in tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:52:10 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-qyQsu7xBmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 25002 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:52:10 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-4IrqWMaKxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
*** Bug 25003 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:52:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:52:28 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-TgAMI7QJUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Martin beat me to it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:54:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:54:05 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
In-Reply-To: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25004-70-p4yAitHqtg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
git bisect points to the cause of the bug and to the solution:

Bug 14715, "Results per page dropdown for catalogue search" adds an extra
closing </div> tag which I'm assuming breaks the selector for the checkbox
because the DOM context is changed.

Removing the </div> at line 188 of opac-results.tt fixes the problem for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:54:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:54:50 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-2QTkFs7SRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #12 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Joy Nelson from comment #11)
> Koha developments most often (if not always) keep one eye towards current
> users as well as future users.  At times it's hard to balance the needs of a
> library (or libraries) and workflows that seem so important with the needs
> and workflows of the many.  The things that seem obvious to me are not
> always obvious to others.  I rely on the input of others in the community to
> give perspective on how other libraries operate.  I believe someone once
> said "show me a library with a mad scheme and I'll show you another with a
> madder one"! 
> 
> Speaking from someone with experience migrating thousands of libraries to
> Koha, I can confidently say that libraries have indeed used this field with
> the expectation that it was NOT visible in the OPAC.  There is the distinct
> possibility that patron information (or staff information/direction) is
> available in this field.  A number of libraries come to my mind who have
> been using Koha for years in a way that is built upon the original design
> (not visible in opac).  
> 
> If this is to be implemented and visible in the OPAC, it must be made so it
> is optional/configurable.

I guess then there should be a configuration.  Anything to move this forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:55:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:55:02 +0000
Subject: [Koha-bugs] [Bug 25001] 'News' should be renamed now we are
 migrating other content blocks to it
In-Reply-To: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25001-70-ifhSfwyfRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:56:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 15:56:23 +0000
Subject: [Koha-bugs] [Bug 22774] Limit number of purchase suggestions per
 patron in a specified time period
In-Reply-To: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22774-70-NwUN3wRjoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You can ignore it, IIRC I added a check on "*koha*", to catch example developer
emails (like the default from kohadevbox, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:00:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:00:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
 and assign items to volumes
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ZWa1mox9Bw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #80 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Y'all might have a look at bug 24023, which adds a way to group items to check
out all together.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:02:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:02:34 +0000
Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group
 Title rather than Description
In-Reply-To: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22937-70-VzeKU3M72Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:02:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:02:37 +0000
Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group
 Title rather than Description
In-Reply-To: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22937-70-rPNsFisyUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102012&action=edit
Bug 22937: Add hint to groups editor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:05:09 +0000
Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group
 Title rather than Description
In-Reply-To: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22937-70-kUPQYNu6cW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
It should be <div class="hint"> instead of <span> :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:12:01 +0000
Subject: [Koha-bugs] [Bug 22937] Searching by library groups uses group
 Title rather than Description
In-Reply-To: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22937-70-F9yNIwHqyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Lisette Scheer <lisetteslatah at gmail.com> ---
The hint only shows when you are editing an existing group, not when creating a
group. 
Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:12:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:12:14 +0000
Subject: [Koha-bugs] [Bug 24614] Can't edit reports if not using cache
In-Reply-To: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24614-70-uXAVCG48kf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102013&action=edit
Bug 24614: Fix Reports/Guided.t

DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement
"UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?,
`report_group` = ?, `report_name` = ?, `report_subgroup` = ?,
`savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04',
1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # Looks like you planned 17 tests but ran 6.

update_sql expect all the paramters to be set, otherwise it will be
nulled.

The best way to fix it is at test level. There is only 1 occurrence in
controller/module, and it sends all the parameters. That is the correct
way to do and will make things easier when we will removed them to use
Koha::Reports directly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:12:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:12:53 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-GFQ4Rb5GbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|DUPLICATE                   |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:13:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:13:29 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-774XzwWL4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I actually think I'll turn mine into more of a collector bug.. this one
describes one of the locations we need to fix :).. Re-opening.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:13:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:13:33 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-PW3p6wrPMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:13:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:13:42 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-jiXXprh0iD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002
[Bug 25002] JS Includes should be wrapped with template comments
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:13:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:13:42 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-BksLaOYdix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25003


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003
[Bug 25003] Clearly identify when JavaScript errors are caused by
OPACUserJS/IntranetUserJS
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:30:31 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-D9sI7zR3dl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #26 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Receiving an ISE:
- find/create bib with 3 items
- put item_1 and item_2 in volume
- place hold on volume
- check in item_3
- get error:
Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Reserves.pm
line 846

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:35:42 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-VJ2cTRgNRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24765


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765
[Bug 24765] Updated on date in Claims returned starts off as 01/01/1970
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:35:42 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-qPnKzmnXti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
[Bug 24980] Date formatting from JS - use timezone only with dates with offset
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:37:32 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-dIhtAWoxLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24765                       |24999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765
[Bug 24765] Updated on date in Claims returned starts off as 01/01/1970
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999
[Bug 24999] Date not correctly formatted in claims table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:37:32 +0000
Subject: [Koha-bugs] [Bug 24765] Updated on date in Claims returned starts
 off as 01/01/1970
In-Reply-To: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24765-70-DBlg8ptdnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24980                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
[Bug 24980] Date formatting from JS - use timezone only with dates with offset
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:37:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:37:32 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-y4bxP51mn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
[Bug 24980] Date formatting from JS - use timezone only with dates with offset
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:59:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:59:17 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-XdwvlOrLYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:59:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 16:59:21 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-2Wi9zDn8Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

--- Comment #13 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 102014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102014&action=edit
Bug 13547: (follow-up) Item field 'Materials specified' would be useful to see
in OPAC

We've changed the patch adding the possibility of control for its visibility at
opac-detail.tt with is_hidden function added to the
Koha/Template/Plugin/ColumnsSettings.pm file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:13:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 17:13:52 +0000
Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be
 useful to see in OPAC
In-Reply-To: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13547-70-uh2ovpnbF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102014|0                           |1
        is obsolete|                            |

--- Comment #14 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 102015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102015&action=edit
Bug 13547: (follow-up) Item field 'Materials specified' would be useful to see
in OPAC

We've changed the patch adding the possibility of control for its visibility at
opac-detail.tt with is_hidden function added to the
Koha/Template/Plugin/ColumnsSettings.pm file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:31:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 17:31:33 +0000
Subject: [Koha-bugs] [Bug 21661] EDI orders RT 48978
In-Reply-To: <bug-21661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21661-70-PZdogQk1Sx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21661

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 17:31:41 +0000
Subject: [Koha-bugs] [Bug 25005] New: Admin Rights issue for Suggestion to
 Purchase
Message-ID: <bug-25005-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005

            Bug ID: 25005
           Summary: Admin Rights issue for Suggestion to Purchase
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: christofer.zorn at ajaxlibrary.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hello All! I hope everyone staying safe during this time!

Yesterday I was trying to give a staff member permission to view and approve
the "Suggestions Pending Approval". I had given that user full rights to the
'Suggestion Management' permission, however the option did not appear until I
also provided the user with 'Moderate patron comments' under tools.

However, to continue testing this I removed the 'Suggestion Management' option
and it did remove it.

I think there is something wrong with the check of the suggestion management
piece that is preventing it from showing unless moderate comments option is
also selected.

Thanks for looking into this.

Christofer

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 18:30:04 +0000
Subject: [Koha-bugs] [Bug 23174] Default (OPAC)ISBD contains <br> tags that
 print in ISBD download
In-Reply-To: <bug-23174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23174-70-LJtGACa6fD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23174

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #1)
> Caused by:
>   commit 792b0f764e1f0641b33ff3dbbe6f99e91109af9e
>   Bug 13695: Add ISBD export option to OPAC (detail)

Well, 'caused' is relative, that bug allowed to download what we put there for
ISBD output, not the <br/>.

I suggest we use some 'verbatim' rendering in the opac-ISBD output, that keeps
the newlines, so there's no need to put a <br/> at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:48:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 18:48:19 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-zeVb0mHW6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:35:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:35:45 +0000
Subject: [Koha-bugs] [Bug 25006] New: Koha::Item->as_marc_field generates
 undef subfields
Message-ID: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

            Bug ID: 25006
           Summary: Koha::Item->as_marc_field generates undef subfields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Trying to use the EmbedItems RecordProcessor filter for an endpoint, I noticed
it got really noisy, and found it is generating subfields even for undefined
mapped attributes (on the framework).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:35:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:35:52 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-GWMu5O1pE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |23807


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807
[Bug 23807] Add Koha::Item->as_marc_field
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:35:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:35:52 +0000
Subject: [Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
In-Reply-To: <bug-23807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23807-70-WWXSVeFm9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006
[Bug 25006] Koha::Item->as_marc_field generates undef subfields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:35:58 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-I088mKw0jL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:53:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:53:01 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-xOEg9alFoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102016&action=edit
Bug 25006: Regression tests

This patch introduces regression tests for as_marc_field. It makes sure
there are empty subfields and then uses List::MoreUtils' all to verify
all generated MARC subfields contain something (i.e. the undef ones are
skipped).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:53:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:53:06 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-vhXN6jVt3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102017&action=edit
Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields

This patch makes as_marc_field skip subfields that don't have a value or
contains an empty string (replicating C4::Items:1021 logic).

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item.t
=> FAIL: Tests fail because the generated MARC::Field contains undef
subfields.
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass! Undefined and empty subfields are skipped!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:54:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 19:54:36 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-637BeiywgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:30:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:30:34 +0000
Subject: [Koha-bugs] [Bug 25007] New: Script to deal with Amazon images in
 detail.tt causes problem
Message-ID: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

            Bug ID: 25007
           Summary: Script to deal with Amazon images in detail.tt causes
                    problem
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In detail.tt there is a verify_images() function. It checks to see if images
from Amazon are 1px X 1px, if they are it removes the image but also updates
the bootstrap class from col-xs-9 to col-xs-12.

We build the Amazon cover images like this:
<img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn |
html %].01.MZZZZZZZ.jpg" alt="" />

Any record without a ISBN ends up looking like this:
https://images-na.ssl-images-amazon.com/images/P/.01.MZZZZZZZ.jpg

Which turns out to be a 1px X 1px image.

If you also have local images on it then forces the image down and into a weird
place.

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field. 
-Load detail page of that record and see that the local cover images is not on
the right hand side like it should be but forced underneath
'catalogue_detail_biblio' in an odd spot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:31:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:31:53 +0000
Subject: [Koha-bugs] [Bug 25007] Script to deal with Amazon images in
 detail.tt causes problem
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-uXnPz7BXMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Why is is necessary to change the Bootstrap class to col-xs-12?


$("#catalogue_detail_biblio").attr("class","col-xs-12");

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:32:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:32:14 +0000
Subject: [Koha-bugs] [Bug 25007] Script to deal with Amazon images in
 detail.tt causes problem
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-kedF8Guooz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:32:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:32:31 +0000
Subject: [Koha-bugs] [Bug 25007] Script to deal with Amazon images in
 detail.tt causes problem
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-KKBfIcwSvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:39:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:39:43 +0000
Subject: [Koha-bugs] [Bug 25007] Amazon link should check for
 normalized_isbn in details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-1iUjDMv4ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Script to deal with Amazon  |Amazon link should check
                   |images in detail.tt causes  |for normalized_isbn in
                   |problem                     |details.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:42:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:42:33 +0000
Subject: [Koha-bugs] [Bug 25007] Amazon link should check for
 normalized_isbn in details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-6JNPvyTr5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
We should probably just check for a normalized_isbn before building the
AmazonCoverImages bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:44:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:44:04 +0000
Subject: [Koha-bugs] [Bug 25007] Amazon link should check for
 normalized_isbn in details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-c1xDt7aObq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:44:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:44:07 +0000
Subject: [Koha-bugs] [Bug 25007] Amazon link should check for
 normalized_isbn in details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-yaE4TghzTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 102018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102018&action=edit
Bug 25007: Check for normaalized ISBN when building Amazon link

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field.
-Load detail page of that record and see that the local cover images is not on
the right hand side like it should be but forced underneath
'catalogue_detail_biblio' in an odd spot.
-Apply patch and reload page
-The image should be back in its normal spot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:46:08 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISNB in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-rrsyN4OGPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|oleonard at myacpl.org         |
            Summary|Amazon link should check    |AmazonCoverImages doesnt
                   |for normalized_isbn in      |check for ISNB in
                   |details.tt                  |details.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:53:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:53:16 +0000
Subject: [Koha-bugs] [Bug 25008] New: Koha::RecordProcessor->options doesn't
 refresh the filters
Message-ID: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

            Bug ID: 25008
           Summary: Koha::RecordProcessor->options doesn't refresh the
                    filters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

On testing something in opac-showmarc.pl I noticed it wasn't applying the
ViewPolicy filter! And it seems the way the record processor is used is to
blame.

I plan to submit a fix for opac-showmarc.pl but thought it was worth filing a
bug against Koha::RecordProcessor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 21:56:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 20:56:22 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-wZgmdIPjfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102019&action=edit
Bug 25008: Regression tests

This patch highlights a behaviour of Koha::RecordProcessor that is
unexpected: if you change the original options using ->options, the
loaded filters don't pick the change. That's because the filter objects
are loaded on ->new, and they are never updated.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/RecordProcessor.t
=> FAIL: Test prove ->options doesn't update the filters!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 22:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 21:05:24 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-Bz4hJQe9mD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 22:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 21:38:00 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-V8n0CXlMeS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---

Problematic uses:
$ git grep 'processor\->options'
opac/opac-basket.pl:    $record_processor->options({
opac/opac-downloadcart.pl:            $record_processor->options({
opac/opac-downloadshelf.pl:                $record_processor->options({
opac/opac-shelves.pl:                $record_processor->options({

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:06:20 +0000
Subject: [Koha-bugs] [Bug 25010] New: Fix typo in: rewewal
Message-ID: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

            Bug ID: 25010
           Summary: Fix typo in: rewewal
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:06:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:06:32 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-GwcSSkDwKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Severity|enhancement                 |minor
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:34:08 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-D20d9gh9Vf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:34:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:34:11 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-5SpOIwSQl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102021&action=edit
Bug 25010: Fix typo 'rewewal' in debit types

This fixes a typo in the debit type description of
RENT_DAILY_RENEW

1) Go to Administration > Debit types
2) Show all debit types
3) Check for the typo
4) Apply patch
5) Verify that the typo is gone
6) Check account_debit_types table for type:
   SELECT * FROM account_debit_types;
7) Run database update
8) Repeat and verify typo is gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:34:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:34:42 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-DHlDxO5mGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix typo in: rewewal        |Fix typo in debit type
                   |                            |description: rewewal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:46:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:46:31 +0000
Subject: [Koha-bugs] [Bug 25011] New: Add display of Production credits
 (MARC21 508) to staff detail page
Message-ID: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

            Bug ID: 25011
           Summary: Add display of Production credits (MARC21 508) to
                    staff detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13385

Bug 13385 added 508 to the OPAC XSLT detail page, but missed staff.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385
[Bug 13385] RDA: 508 display in XSLT
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:46:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:46:31 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-2eMmUdpAKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25011


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011
[Bug 25011] Add display of Production credits (MARC21 508) to staff detail page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:52:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:52:00 +0000
Subject: [Koha-bugs] [Bug 25011] Add display of Production credits (MARC21
 508) to staff detail page
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-gPUhXACHtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:52:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:52:04 +0000
Subject: [Koha-bugs] [Bug 25011] Add display of Production credits (MARC21
 508) to staff detail page
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-w18XXIvnGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102022&action=edit
Bug 25011: Add MARC21 508 - Production credits to staff detail page

Bug 13385 added 508 to the OPAC detail page, but missed the staff
side. This patch makes the display consistent again between staff
and OPAC.

Additional changes:
- Capitalization fix: Production Credits - Production credits
- Changes div to span avoiding display issues

To test:
- Catalog one or more records with none, one and multiple 508 $a
- Check and compare the staff and OPAC detail pages, both
  should display the production credits information now correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 23:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 22:52:10 +0000
Subject: [Koha-bugs] [Bug 25011] Add display of Production credits (MARC21
 508) to staff detail page
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-7mMSwogabu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:04:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:04:14 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-HM5BMySoum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102021|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102023&action=edit
Bug 25010: Fix typo 'rewewal' in debit types

This fixes a typo in the debit type description of
RENT_DAILY_RENEW

1) Go to Administration > Debit types
2) Show all debit types
3) Check for the typo
4) Apply patch
5) Verify that the typo is gone
6) Check account_debit_types table for type:
   SELECT * FROM account_debit_types;
7) Run database update
8) Repeat and verify typo is gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:06:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:06:31 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-6lLzSSffgn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add display of Production   |Improve display of
                   |credits (MARC21 508) to     |Production credits (MARC21
                   |staff detail page           |508) in OPAC and staff

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Someone must have already fixed staff side since I put this on my todo list
(ages ago). Fixing my patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:11:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:11:42 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-2sZMx5m2xL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102024&action=edit
Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC

Makes some tiny changes to improve display and consistency between
OPAC and staff:
- Capitalization fix: Production Credits - Production credits
- Changes div to span avoiding display issues
- Make sequence of fields in display match (505, 508, 586)

To test:
- Catalog one or more records with none, one and multiple 508 $a
- Check and compare the staff and OPAC detail pages, both
  should display the production credits information correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:14:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:14:17 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times.
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-TfIUcvdmCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|karenliang.student at wegc.sch |katrin.fischer at bsz-bw.de
                   |ool.nz                      |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:14:40 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-ek6m3Cbgd8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
            Summary|XSLT: if 583 is repeated,   |XSLT: if 583 is repeated,
                   |the label will appear       |the label will appear
                   |multiple times.             |multiple times
         Depends on|                            |5919


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5919
[Bug 5919] MARC21 fields 583 and 586 should display in OPAC Details
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:14:40 +0000
Subject: [Koha-bugs] [Bug 5919] MARC21 fields 583 and 586 should display in
 OPAC Details
In-Reply-To: <bug-5919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5919-70-4oOmvJMu4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938
[Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:16:05 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-ykjEifVAU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59204|1                           |0
         is private|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:36:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:36:36 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-kARbFRPhXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:37:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:37:41 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-MkeoiI2njb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:37:45 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-tW38e79VT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102025&action=edit
Bug 17983: Fix display of label for repeated MARC 583 - Action note fields

When there are mulitple 583 on a record, the label "Action note" will be
repeated for each. This fixes it, so that the label only appears once and
multiple fields are separated by | following the existing pattern.

Also makes sure there is a space between $z and other subfields.

Note:
Ind. 1 = private - These won't display in the OPAC
Ind. 1 = 0 or empty - These will display in the OPAC
Staff will display all 583 independent from indicator.

To test:
- Add one or more records with none, one and muliple 583, at least one
including $z
  For examples see:
  http://www.loc.gov/marc/bibliographic/bd583.html
- Verify display problems
- Apply patch
- Verify display is improved - one label and $z is followed by a space

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:45:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:45:45 +0000
Subject: [Koha-bugs] [Bug 25012] New: Fix class on OPAC view link in staff
 detail page
Message-ID: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

            Bug ID: 25012
           Summary: Fix class on OPAC view link in staff detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:49:35 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-ckpKb0ZMBO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:49:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:49:38 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-0HejGbPbIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102026&action=edit
Bug 25012: Fix class on OPAC view link in staff detail page

Probably a copy & paste error: the OPAC view link on the staff
detail page currently has the class succeeding_entry_note.

This patch changes it to opac_view to allow for independent
styling of the link.

Note: The link will only be visible when OPACBaseURL is set.

To test:
- Use the element inspector or check the source code for
  the class used on the OPAC view link on the staff detail page
- Apply patch
- Repeat and verify that the class has changed to opac_view

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:53:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:53:02 +0000
Subject: [Koha-bugs] [Bug 25013] New: Fix capitalization: Edit Items on
 batch item edit
Message-ID: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

            Bug ID: 25013
           Summary: Fix capitalization: Edit Items on batch item edit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:56:52 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-sAkA8cP0jX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2020 23:56:55 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-3wHETk91Zx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102027&action=edit
Bug 25013: Fix capitalization: Edit Items on batch item edit

Fixes a tiny string issue: Edit Items --> Edit items

To test:
- Go to tools / batch item edit
- Enter a barcode
- Check the heading above the edit item form
- Apply patch
- Verify the heading is now properly capitalized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:03:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:03:13 +0000
Subject: [Koha-bugs] [Bug 25014] New: Capitalization: Call Number in sort
 options in staff and OPAC
Message-ID: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

            Bug ID: 25014
           Summary: Capitalization: Call Number in sort options in staff
                    and OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:06:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:06:59 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-obJ2sRE1HI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:07:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:07:02 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-3cxQfetGvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102028&action=edit
Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options

There are some ocurrences of "Call Number" in the sort option lists in
staff and OPAC. The patch changes them to "Call number".

To test:
- Check the sort option list in staff and OPAC for the typo
- Apply patch
- Verify it's now all corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:25:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:25:17 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-GJtD6LHySR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:25:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:25:20 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-W7S9TK9Qi5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102029&action=edit
Bug 24941: Serials - Fix link to basket from acquisition details information

Adding orders from subscriptions makes acquisition information visible
in the serials module. In the table of acquisition data is a link back
to the basket - but this link is missing the basket number parameter -
it doesn't work. This patch fixes the TT variable to make it work.

To test:
- Add a subscription
- Add a new basket
- Add a order line using "Add from subscription"
- Go to the subscription details page, check the acquisitions tab
- Try the link to the basket - it should not work
- Apply patch
- Try the link again - now it should bring up the basket page with
  the order.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:25:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 00:25:37 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-ubHYscMt2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 03:06:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 02:06:57 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-ld3wAtryYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:33:54 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-LbshIdUyEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:33:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:33:58 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-GLrkvoiFSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102030&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in en installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:06 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-AXRYm9JQUv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102031&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in de-DE installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:10 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-xhOmMabZAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102032&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in es-ES installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:15 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-jCslrkSMNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102033&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in fr-FR installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:19 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-bEAlmGKpmJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102034&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in it-IT installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:23 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-EUT5XyL6fF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102035&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in pl-PL installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:27 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-HhAtmizmbL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102036&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in nb-NO installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 3avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:31 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-GobK9h9tbr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102037&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in ru-RU installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:34:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:34:36 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-kGGKnZQrWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102038&action=edit
Bug 7947: Update MARC21 440/490 mapping and visibility in uk-UA installer

440 has been obsoleted in the standard for a long time.
490 is now used for series information.

Changes made here only apply for new installations:
- Hide 440 subfields by default
- Make 490 avx visible by default
- Add mapping biblioitems.seriestitle to 490a
- Add mapping biblioitems.volume to 490v

To test:
- Run the web installer for this language and verify changes
  in all frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 11:35:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 10:35:38 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-XyeXDfB5ow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As we have some ongoing changes with the new yml syntax for installer files, I
kept the languages separate. This way it will be easy to adapt or leave them
out when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 12:57:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 11:57:05 +0000
Subject: [Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages
 syspref
In-Reply-To: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9422-70-QnhWI9IVvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 12:57:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 11:57:09 +0000
Subject: [Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages
 syspref
In-Reply-To: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9422-70-FOkYBYowZp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85021|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102039&action=edit
Bug 9422: Don't allow access to 'Upload patron images' when patronimages
syspref is off

In addition to checking the patron image upload permission, this
adds a check for the patronimages system preference to the tools
home page and sidebar.

To test:
- Check that the patron image upload tool only displays when
  - system preference patronimages is set to 'Allow'
    and user is either
  - superlibrarian or
  - has bath_upload_patron_images permission
- Save URL of patron image uploader page
- Turn off patronimages
- Verify you get redirected to the home page of Koha when trying
  to access the page

Note: this redirect is already used by the stock rotation feature.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 12:58:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 11:58:12 +0000
Subject: [Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages
 syspref
In-Reply-To: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9422-70-o8e7UZYTG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like to throw the rebased patch out there - I didn't find an example for a
page with a message in staff. Stock rotation for example behaves the same as
this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 12:59:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 11:59:16 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-nW1oBVZLOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 13:03:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 12:03:09 +0000
Subject: [Koha-bugs] [Bug 25015] New: Staff with Edit Items permission
 Currently Can Not Edit Items attached to a Fast Add Framework
Message-ID: <bug-25015-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015

            Bug ID: 25015
           Summary: Staff with Edit Items permission Currently Can Not
                    Edit Items attached to a Fast Add Framework
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If a staff has the permission has only the permission in Cataloging to "Edit
Items" currently, they can't edit items attached to a Fast Add bib.  

What should the change be?  

Does a staff member need to have Fast Cataloging and Edit Items to be able to
Edit Items attached to a Fast Added Bib?  And if that is the case, the bug lies
with the fact the staff member doesn't know that this bib is a Fast Add bib- 
the Edit option should not be visible to staff that only have "edit items" and
not "Fast Cataloging"


Or 

Is it a library's understanding that the permission "Edit Items" allows All
Items can be edited even the items attached to Fast Add Biblios? And if that is
the case, then the change lies with how the permissions are coded in Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 14:49:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 13:49:21 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-tXWgI24ZQO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 14:49:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 13:49:24 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-51oU593tNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102040&action=edit
Bug 4944: Add OpacNoItemTypeImages system preference

At the moment noItemTypeImages pref controls staff and OPAC
display. With this patch, there will be a separate OpacNoItemTypes
preference that allows to control display of each separately.

To test:
- Apply patch and run database update
In Administration:
- Search for 'noItemTypes' preferences
- Verify the settings of both prefs match
- Toggle prefs, verify everything works ok
- Go to the item types configuration page
- Try different settings for both prefs:
  - Both set to No: Only a message with a link to the prefs should show
  - Both set to Yes or either set to Yes: image configuration options
    should show
In the OPAC:
- Check the following pages with item-level_itypes = record
  - advanced search
  - detail page
  - place hold page
- Check the following pages with item-level_itypes = item
  - result list
  - a list (opac-shelves)
  - checkouts and overdues tabs in patron account
    (Note: this didn't work right before, but will now.)
  - reading history in patron account

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 14:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 13:51:19 +0000
Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be
 clearer
In-Reply-To: <bug-10561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10561-70-43ov4vWjrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:14:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:14:31 +0000
Subject: [Koha-bugs] [Bug 24099] Capitalization: Copier Fees
In-Reply-To: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24099-70-vOXEgwGhU8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we can leave this be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:22:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:22:02 +0000
Subject: [Koha-bugs] [Bug 24074] Access directory UX improvements
In-Reply-To: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24074-70-TEUTdTPKFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:22:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:22:08 +0000
Subject: [Koha-bugs] [Bug 24074] Access directory UX improvements
In-Reply-To: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24074-70-oDfSKcz3gN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Tools

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:27:59 +0000
Subject: [Koha-bugs] [Bug 24050] Limit Consecutive Issues
In-Reply-To: <bug-24050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24050-70-U9qoCC3d7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:28:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:28:27 +0000
Subject: [Koha-bugs] [Bug 24049] Limit for consecutive hold requests
In-Reply-To: <bug-24049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24049-70-KR0gO3DLtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
            Summary|Limit for Consecutive Hold  |Limit for consecutive hold
                   |Requests                    |requests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:30:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:30:10 +0000
Subject: [Koha-bugs] [Bug 24042] Select what items to print on a slip
In-Reply-To: <bug-24042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24042-70-sQfpsczxV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24042

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master
            Summary|Select what Items to Print  |Select what items to print
                   |on a slip                   |on a slip

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:30:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:30:32 +0000
Subject: [Koha-bugs] [Bug 24041] Renewal only slips
In-Reply-To: <bug-24041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24041-70-KXfIrFOulf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:31:37 +0000
Subject: [Koha-bugs] [Bug 24036] UpdateNotForLoanStatusOnCheckin preference
 requires space after colon (specify in manual)
In-Reply-To: <bug-24036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24036-70-WReWWpdoer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:41:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:41:33 +0000
Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus]
In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23996-70-sXdNyN5Qv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|MySQL 8 support             |MySQL 8 support [Omnibus]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:50:27 +0000
Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD
 cover images
In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23965-70-Mgp5C0TB7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |OPAC
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:53:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:53:58 +0000
Subject: [Koha-bugs] [Bug 23951] Sundry and Account management fee missing
 from manual fine pull down
In-Reply-To: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23951-70-Zww2js5mx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:58:09 +0000
Subject: [Koha-bugs] [Bug 23940] Create SQL report with Mana
In-Reply-To: <bug-23940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23940-70-QR9HYVdiu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23940

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
            Summary|Create SQL with mana in     |Create SQL report with Mana
                   |Reports                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:59:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:59:13 +0000
Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't
 work
In-Reply-To: <bug-23937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23937-70-cxW11jLlzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Kelly, would it be ok for you if we close the bug after the explanation?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 15:59:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 14:59:55 +0000
Subject: [Koha-bugs] [Bug 23936] Authenticating a patron without library
 card or ID
In-Reply-To: <bug-23936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23936-70-lt61rzT7K9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23936

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:02:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:02:01 +0000
Subject: [Koha-bugs] [Bug 23930] No permissions SSO login to staff client
 should redirect to a custom URL
In-Reply-To: <bug-23930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23930-70-Ax6kfCwica@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23930

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|17.11                       |master

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Alex, should this be updated (has a patch, but is Assigned)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:09:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:09:09 +0000
Subject: [Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel
 words
In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23918-70-Pdxe4YGy4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we mark this WONTFIX for now?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:19:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:19:28 +0000
Subject: [Koha-bugs] [Bug 24290] `_FixOverduesOnReturn` does not respect
 `AccountAutoReconcile`
In-Reply-To: <bug-24290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24290-70-WvFUCvFc5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:30:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:30:02 +0000
Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method
In-Reply-To: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24254-70-ISdKB0irXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:30:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:30:02 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-VvfhMPZ9Dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24254


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
[Bug 24254] Add Koha::Biblio get_visible_items method
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:36:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:36:23 +0000
Subject: [Koha-bugs] [Bug 24231] Create classes to the message that was
 created with sys pref UpdateItemLocationOnCheckin
In-Reply-To: <bug-24231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24231-70-Y98DZp4rhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24231

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|System Administration       |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:37:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:37:38 +0000
Subject: [Koha-bugs] [Bug 24227] System Preference: EmailPurchaseSuggestion
 missing from the 19.05 manual
In-Reply-To: <bug-24227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24227-70-8y8DvbHtql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24227

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 16:51:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 15:51:49 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-wjmgL2pTXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can you add a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:13:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:13:40 +0000
Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and
 accountlines.credit_type should be merged
In-Reply-To: <bug-23894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23894-70-q3nVm1b0VN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:26:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:26:51 +0000
Subject: [Koha-bugs] [Bug 23842] GUI for export/import patron permissions
In-Reply-To: <bug-23842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23842-70-MzOYGfkmf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23842

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|gui for export/import       |GUI for export/import
                   |Patron permissions          |patron permissions
            Version|19.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:42:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:42:55 +0000
Subject: [Koha-bugs] [Bug 23817] Searching by patron phone number is
 contingent on how it was entered
In-Reply-To: <bug-23817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23817-70-IZ4asrChEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:43:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:43:51 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-opY0KPoCwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:43:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:43:54 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-vv1rGOxfFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102041&action=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.

To test, apply the patch and view source on the following pages to
verify the presence of the comments:

Acquisitions home page:
  - acquisitions-toolbar.inc
  - validtor-strings.inc
  - js_includes.inc
  - format-price.inc
Cataloging -> Add/Edit item:
  - additem.js.inc
  - columns_settings.inc
  - strings.inc
  - select2.inc
  - calendar.inc
  - str/cataloging_additem.inc
Authorities home page:
  - authorities_js.inc
Bibliographic detail page:
  - catalog-strings.inc
Cataloging -> Advanced editor:
  - cateditor-ui.inc
  - cateditor-widgets-marc21.inc
Administration -> Item types:
  - greybox.inc
ILL requests:
  - ill-list-table-strings.inc
Web installer
  - installer-intranet-bottom.inc
Web installer -> Onboarding
  - installer-strings.inc
Lists -> List contents -> Merge records
  - merge-record-strings.inc
Patrons -> Patron -> Change password
  - password_check.inc
  - str/members-menu.inc
Patrons -> Patron -> Print summary
  - slip-print.inc
Circulation -> Check out
  - timepicker.inc
Administration -> System preferences:
  - str/tinymce_i18n.inc
  - wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
  - z3950_search.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:45:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:45:38 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-EMpLtUFOfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |---

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
I hope this patch is what you had in mind.

Going through the includes highlights the need to update and/or remove several
of them now that we have proper JS i18n, but I didn't think it hurt to update
them anyway in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:45:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:45:44 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-df9Y5HbOIZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:45:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:45:55 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-egKQd3DZwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Templates
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:54:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:54:15 +0000
Subject: [Koha-bugs] [Bug 23716] Batch item modification needs to let you
 continue with items
In-Reply-To: <bug-23716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23716-70-cPbAvzBIQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:54:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:54:40 +0000
Subject: [Koha-bugs] [Bug 23717] Login for Mana Content Knowledge Base
In-Reply-To: <bug-23717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23717-70-nwB6KCRvRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23717

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 17:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 16:58:47 +0000
Subject: [Koha-bugs] [Bug 23693] More Languages needed for OPAC advanced
 search Languages
In-Reply-To: <bug-23693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23693-70-5VO3xpo9iW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23693

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 17:04:38 +0000
Subject: [Koha-bugs] [Bug 22361] Not able to create Vendor
In-Reply-To: <bug-22361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22361-70-URBAkovAz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:07:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 17:07:20 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-iTC1C5AQCm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:07:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 17:07:23 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-5lQa1abZDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102023|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102042&action=edit
Bug 25010: Fix typo 'rewewal' in debit types

This fixes a typo in the debit type description of
RENT_DAILY_RENEW

1) Go to Administration > Debit types
2) Show all debit types
3) Check for the typo
4) Apply patch
5) Verify that the typo is gone
6) Check account_debit_types table for type:
   SELECT * FROM account_debit_types;
7) Run database update
8) Repeat and verify typo is gone

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:08:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 17:08:59 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-A93lpfxB1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|AmazonCoverImages doesnt    |AmazonCoverImages doesnt
                   |check for ISNB in           |check for ISBN in
                   |details.tt                  |details.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:30:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 17:30:08 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-pPsnlZackM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 22:06:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 21:06:07 +0000
Subject: [Koha-bugs] [Bug 25016] New: Coce should not return a 1-pixel
 Amazon cover image
Message-ID: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

            Bug ID: 25016
           Summary: Coce should not return a 1-pixel Amazon cover image
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

This might be something which should be addressed in the Coce server code, but
we can also address it in ours: If the Amazon cover image stored by Coce is a
single-pixel placeholder coce.js in the staff client should not return it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 22:48:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 21:48:33 +0000
Subject: [Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23781-70-bPiDRCkKPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, should this be "NSO"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 22:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 21:58:09 +0000
Subject: [Koha-bugs] [Bug 23756] Appendix for workflows
In-Reply-To: <bug-23756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23756-70-jvXMkAlmUZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 22:59:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 21:59:12 +0000
Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and
 resource discovery layer / open link resolver from any ILL backend
In-Reply-To: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23752-70-l3KCjavGei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:00:17 +0000
Subject: [Koha-bugs] [Bug 23750] Token cleaning script
In-Reply-To: <bug-23750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23750-70-k6bW4QJb8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23750

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|token cleaning script       |Token cleaning script

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:00:35 +0000
Subject: [Koha-bugs] [Bug 23749] Batch import mana-kb reports
In-Reply-To: <bug-23749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23749-70-mpSYaI15Ii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23749

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|batch import mana-kb        |Batch import mana-kb
                   |reports                     |reports
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:01:20 +0000
Subject: [Koha-bugs] [Bug 23748] Golden contributors can update Mana-kb
 entries
In-Reply-To: <bug-23748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23748-70-p9Rpqm9AVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23748

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|golden contributors can     |Golden contributors can
                   |update mana-kb entries      |update Mana-kb entries

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:02:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:02:03 +0000
Subject: [Koha-bugs] [Bug 23746] Create token in Mana-kb
In-Reply-To: <bug-23746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23746-70-kqzJKeJHHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23746

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|create token in Mana-kb     |Create token in Mana-kb

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:02:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:02:22 +0000
Subject: [Koha-bugs] [Bug 23745] Token management
In-Reply-To: <bug-23745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23745-70-0bRFTJwUqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23745

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|token management            |Token management
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:06:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:06:07 +0000
Subject: [Koha-bugs] [Bug 23684] Import items only with merging rule
In-Reply-To: <bug-23684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23684-70-iO1Ey41KaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 18757 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:06:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:06:07 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
 records
In-Reply-To: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18757-70-Sc1bVSTjz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viliam.polonec at snk.sk

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 23684 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:08:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:08:35 +0000
Subject: [Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default
 framework is missing LDR breaking encoding
In-Reply-To: <bug-23675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23675-70-sn3BpHxrU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:09:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:09:13 +0000
Subject: [Koha-bugs] [Bug 23674] Allowing editable notes when posting
 Payments/Writeoffs
In-Reply-To: <bug-23674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23674-70-eH53hqPQum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:10:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:10:41 +0000
Subject: [Koha-bugs] [Bug 23668] Manual on patron import: Information on
 syntax for patron attributes
In-Reply-To: <bug-23668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23668-70-eG8FzfvPtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:14:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:14:31 +0000
Subject: [Koha-bugs] [Bug 23659] Allow hold pickup location to default to
 item home branch
In-Reply-To: <bug-23659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23659-70-Pcoy9WejG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:37:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:37:11 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-J250KT3CTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
We talked this one over this morning, we think the idea of setting  preferences
by default is problematic, we would propose a workaround:
1 - Add a new system preference "SendAutoRenewalNotices"
2 - This syspref would replace the 'send-notices' switch on the cron, and would
be marked with deprecation
3 - It would allow libraries to review their messaging settings for
auto-renewal
4 - It should default to 'off' with a warning in the DB upgrade and release
notes and in the cron if set but the cron could enable the syspref if the
option is passed - to highlight the chnage
5 - the --digest option in the cron should be removed as the control should
rely on patron settings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:37:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:37:29 +0000
Subject: [Koha-bugs] [Bug 23628] Restrict Renewal when renewal period is not
 extending due date
In-Reply-To: <bug-23628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23628-70-A4UT6fLCet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23628

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|System Administration       |Circulation
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle.m.hall at gmail.com
            Version|18.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:48:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:48:18 +0000
Subject: [Koha-bugs] [Bug 20107] Editing a public note in Course Reserves
In-Reply-To: <bug-20107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20107-70-4Mf20qBfTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20107

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23727
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This could be a duplicate of bug 23727

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 23:48:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 22:48:18 +0000
Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken
In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23727-70-Kpe4kvqzZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20107

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 00:52:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 23:52:22 +0000
Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 -
 ES6
In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20196-70-8AmKkndewC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
All dependent bugs have been closed, can the omnibus bug be closed as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 00:55:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2020 23:55:45 +0000
Subject: [Koha-bugs] [Bug 20186] Problem printing batches
In-Reply-To: <bug-20186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20186-70-9o2xBLCfmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20186

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is not enough information here to figure out the problem the reporter had
- marking INVALID.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 01:42:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 00:42:03 +0000
Subject: [Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon
 cover image
In-Reply-To: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25016-70-RngV75qs7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007
[Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 01:42:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 00:42:03 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-D1ZkhZNcIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25016


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016
[Bug 25016] Coce should not return a 1-pixel Amazon cover image
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 01:56:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 00:56:07 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-sgMrKJVMbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #1 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 102043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102043&action=edit
Bug 22087: It would be helpful to have City and State visible in member.pl

This patch adds City, State and Zipcode to the display of a patron
search

To test:

1) Do a patron search that retrieves more than one user so you see the
results table
2) In the Names column, see that the patron address display without
city, state and zipcode.
3) Install the patch
4) Repeat the search. City, state and zipcode will now display in the
table.
5) Check that this is working from both member.pl and members-home.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 01:57:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 00:57:10 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-KD83Ktzo6M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
I've also added zipcode to this display, as there seemed little point in not
displaying it if we are displaying all of the other address fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 03:36:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 01:36:13 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
 (oldoldstable/17.11.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-JOUvfwmyR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

--- Comment #14 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 102044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102044&action=edit
Bug 20952- Automatic debian/control updates (oldoldstable/18.05.x)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 03:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 01:36:17 +0000
Subject: [Koha-bugs] [Bug 24940] Serials statistics wizard: order vendor
 list alphabetically
In-Reply-To: <bug-24940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24940-70-bntSirxyAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24940

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 03:57:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 01:57:28 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-iTYLi0cY7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
Test on my test environment - works exactly as promised.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 04:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 02:00:17 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-WwWmVHNtUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102026|0                           |1
        is obsolete|                            |

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 102045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102045&action=edit
Bug 25012: Fix class on OPAC view link in staff detail page

Probably a copy & paste error: the OPAC view link on the staff
detail page currently has the class succeeding_entry_note.

This patch changes it to opac_view to allow for independent
styling of the link.

Note: The link will only be visible when OPACBaseURL is set.

To test:
- Use the element inspector or check the source code for
  the class used on the OPAC view link on the staff detail page
- Apply patch
- Repeat and verify that the class has changed to opac_view

Signed-off-by: David Roberts <david at koha-ptfs.co.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 06:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 04:14:52 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-BzdYdIl874@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 06:14:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 04:14:55 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-soknZApHKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101995|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102046&action=edit
Bug 24996: Unwanted CSS change unhides OPAC results sorting button

This patch adds back a CSS selector which was incorrectly removed by Bug
23915. The "Go" button associated with the OPAC search results resort
operation should be hidden if JavaScript is enabled.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Perform a search in the OPAC
 - On the search results page, there should be no "Go" button next to
   the re-sort/results per page selection fields.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 06:17:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 04:17:40 +0000
Subject: [Koha-bugs] [Bug 24963] Terminology: auto renewal,
 auto-renewal or autorenewal?
In-Reply-To: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24963-70-4lsE4wTFY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
I'm leaning towards auto-renewal, but grammar is terrible!.

Otherwise, spell out in full as 'automatic renewal'.

Does auto-renewal create any problems with translation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 07:49:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 05:49:40 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-eLZzOUzdHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds JavaScript
      release notes|                            |to the list contents page
                   |                            |which converts the resort
                   |                            |form's <select> menu into a
                   |                            |Bootstrap dropdown menu.
                   |                            |This allows for a more
                   |                            |compact and consistent
                   |                            |display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 08:40:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 06:40:46 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-zxtWCigFpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |results per page dropdown
                   |                            |list to catalog search
                   |                            |results pages in the OPAC
                   |                            |and staff interface. This
                   |                            |lets you set the number of
                   |                            |results to show (20, 40,
                   |                            |60, 80, and so on).
                   |                            |
                   |                            |This
                   |                            |is enabled by two new
                   |                            |system preferences:
                   |                            |OPACnumSearchResultsDropdow
                   |                            |n for the OPAC, and
                   |                            |numSearchResultsDropdown
                   |                            |for the staff interface.
                   |                            |
                   |                            |The default number of
                   |                            |search results is set using
                   |                            |existing system
                   |                            |preferences:
                   |                            |OPACnumSearchResults for
                   |                            |the OPAC, and
                   |                            |numSearchResults for the
                   |                            |staff interface.
                   |                            |
                   |                            |This
                   |                            |enhancement works for both
                   |                            |Zebra and Elasticsearch
                   |                            |search engines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:37:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:37:38 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-mjtSTWANmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:37:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:37:42 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-tDwzey7DAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98966|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 102047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102047&action=edit
Bug 12187: Duplicate TT code for serial statuses

Instead of duplicating the code for serial statuses in multiple
files, move all of them into single include file, and use that.

Needs a test plan, but I haven't used serials.

Rebased

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:37:45 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-9LbWP4Livv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101743|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 102048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102048&action=edit
Bug 12187: (follow-up) Reindent new include file

This patch re-indents the new include file so that it is consistent with
coding guidelines. Taking this opportunity to add a full test plan:

Instead of duplicating the code for serial statuses in multiple
files, move all of them into single include file, and use that.

To test, apply the patch and go to Serials.

 - Search for a subscription which has multiple issues.
   - On the subscription detail page, open the "Issues" tab.
     - Statuses in the "Status" column should display correctly.
   - Click the "Serial collection" link in the sidebar.
     - In the table of issues, the "Status" colunn should display the
       correct information.
   - Select some isues and click the "Edit serials" button.
     - In the "Status" column, the options should display correctly.
     - Test setting various statuses and saving. The statuses should
       save correctly.
   - Click "Claims" in the sidebar menu and select a vendor.
     - In the list of missing issues the "Status" column should show the
       correct information.
  - In the catalog, locate the bibliographic record for a subscription
    with issues.
    - Under the "Subscriptions" tab check the "Status" column. Status
      information should be displayed correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:47:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:47:58 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-LqTRrtGDJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:48:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:48:01 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-EWIBDxvlgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102028|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102049&action=edit
Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options

There are some ocurrences of "Call Number" in the sort option lists in
staff and OPAC. The patch changes them to "Call number".

To test:
- Check the sort option list in staff and OPAC for the typo
- Apply patch
- Verify it's now all corrected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:56:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:56:24 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-VvoaJmXvqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 09:56:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 07:56:28 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-mfWwDIO3Hk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102027|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102050&action=edit
Bug 25013: Fix capitalization: Edit Items on batch item edit

Fixes a tiny string issue: Edit Items --> Edit items

To test:
- Go to tools / batch item edit
- Enter a barcode
- Check the heading above the edit item form
- Apply patch
- Verify the heading is now properly capitalized

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 10:54:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 08:54:30 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-xC6ke26pPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Hi Katrin.

In the staff interface 508 is already included, so when the patch is applied it
displays twice (around line 1026 in the patch file, after the 586 field).

The patch does fix the display of 508 in the OPAC.

One thing I noticed is that the 'Contents' heading for 505 displays in the
OPAC, but doesn't in the staff interface (this is the case before and after the
patch is applied).

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:02:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 09:02:55 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-hVIGPyt9kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:02:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 09:02:59 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-nOjj86N6MG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102016|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 102051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102051&action=edit
Bug 25006: Regression tests

This patch introduces regression tests for as_marc_field. It makes sure
there are empty subfields and then uses List::MoreUtils' all to verify
all generated MARC subfields contain something (i.e. the undef ones are
skipped).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:03:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 09:03:02 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-gECbSTyy3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102017|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 102052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102052&action=edit
Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields

This patch makes as_marc_field skip subfields that don't have a value or
contains an empty string (replicating C4::Items:1021 logic).

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item.t
=> FAIL: Tests fail because the generated MARC::Field contains undef
subfields.
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass! Undefined and empty subfields are skipped!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:22:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 09:22:06 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-DEy3ODsDo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Changed status to signed off - looks like Frank Hansen signed this on off to
me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 12:21:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 10:21:49 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-6UYO4lKt8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 12:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 10:22:23 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-CYLKQvL1ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 102053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102053&action=edit
Bug 17938: Fix display of label for repeated MARC 583 - Action note fields

When there are mulitple 583 on a record, the label "Action note" will be
repeated for each. This fixes it, so that the label only appears once and
multiple fields are separated by | following the existing pattern.

Also makes sure there is a space between $z and other subfields.

Note:
Ind. 1 = private - These won't display in the OPAC
Ind. 1 = 0 or empty - These will display in the OPAC
Staff will display all 583 independent from indicator.

To test:
- Add one or more records with none, one and muliple 583, at least one
including $z
  For examples see:
  http://www.loc.gov/marc/bibliographic/bd583.html
- Verify display problems
- Apply patch
- Verify display is improved - one label and $z is followed by a space

https://bugs.koha-community.org/show_bug.cgi?id=17938

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 12:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 10:23:43 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-2uJHRWAifc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
 Attachment #102025|1                           |0
           is patch|                            |
 Attachment #102025|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:01:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:01:10 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-czyMJH8dxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:01:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:01:45 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-kgU2D5UNVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102018|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 102054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102054&action=edit
Bug 25007: Check for normaalized ISBN when building Amazon link

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field.
-Load detail page of that record and see that the local cover images is not on
the right hand side like it should be but forced underneath
'catalogue_detail_biblio' in an odd spot.
-Apply patch and reload page
-The image should be back in its normal spot

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:04:42 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-ecJmQf0xAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Note from testing: Using Google Chrome or Chromium before the patch is applied:
the local image is not displayed on the detail page (it is in Firefox - in the
wrong position as per the test plan). After applying the patch it works the
same in Firefox as it does in Google Chrome or Chromium.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:33:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:33:56 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-mpCXP33CRm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:35:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:35:33 +0000
Subject: [Koha-bugs] [Bug 24963] Terminology: auto renewal,
 auto-renewal or autorenewal?
In-Reply-To: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24963-70-VaSasZjLlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24963

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Nind from comment #3)
> I'm leaning towards auto-renewal, but grammar is terrible!.
> 
> Otherwise, spell out in full as 'automatic renewal'.
> 
> Does auto-renewal create any problems with translation?

What we pick doesn't matter so much as consistency. Less different spellings =
less strings to translate and you can 'recognize' it as being the same thing
easier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:37:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:37:14 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-rR3OAPjwsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102022|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 13:38:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 11:38:11 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-WvXnxcXitA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, sorry, I had realized my mistake but missed to obsolete the first
patch. The patch attached now should be ok. Please file a bug for 505 - happy
to have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:20:15 +0000
Subject: [Koha-bugs] [Bug 23619] Serials title level opac display - show all
 issues even those not received
In-Reply-To: <bug-23619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23619-70-KL7AscbWvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23619

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:22:20 +0000
Subject: [Koha-bugs] [Bug 23617] Authorities mode: Add list of reports,
 or ability to add html links to same,
 re biblio and authority records needing editing, adding, deleting.
In-Reply-To: <bug-23617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23617-70-RYcuyYQpwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23617

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:31:19 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-6mvQrqEB3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I just tested and things seem to work ok now - please reopen if you can still
see the buggy behavior!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:36:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:36:07 +0000
Subject: [Koha-bugs] [Bug 23585] Hide Item Information tab when adding to
 basket from file without creating items
In-Reply-To: <bug-23585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23585-70-zDFZaCjUTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23585

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:37:06 +0000
Subject: [Koha-bugs] [Bug 23583] Handle OpacHiddenItems with yaml_preference
In-Reply-To: <bug-23583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23583-70-u93m5VVI0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:37:06 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-vo5HjkB6yr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23583


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583
[Bug 23583] Handle OpacHiddenItems with yaml_preference
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:39:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:39:49 +0000
Subject: [Koha-bugs] [Bug 23578] Koha ILL backends directory is not included
 in @INC
In-Reply-To: <bug-23578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23578-70-i1QLwFcJ7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Does this still require a fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:43:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:43:58 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-E5X37yxDRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23552

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 15:43:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 13:43:58 +0000
Subject: [Koha-bugs] [Bug 23552] Include ISSN in list and cart emails
In-Reply-To: <bug-23552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23552-70-JH1l1Di4up@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23552

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 17:00:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 15:00:28 +0000
Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method
In-Reply-To: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24254-70-pDUM7Qu6Ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 17:05:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 15:05:54 +0000
Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method
In-Reply-To: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24254-70-D2Z47W4gGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It needs tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 18:08:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 16:08:56 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-4hcmbra2Ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 18:08:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 16:08:59 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-Asi41kbuWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102054|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102056&action=edit
Bug 25007: Check for normaalized ISBN when building Amazon link

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field.
-Load detail page of that record and see that the local cover images is
 not on the right hand side like it should be but forced underneath
 'catalogue_detail_biblio' in an odd spot.
-Apply patch and reload page
-The image should be back in its normal spot

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 18:09:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 16:09:06 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-OWvrvexK9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102057&action=edit
Bug 25007: (follow-up) Fix the way image check alters layout

A question in the bug report asks: Why is is necessary to change the
Bootstrap class to col-xs-12? The JavaScript which checks for the
existence of an Amazon cover image is designed to remove the Amazon
cover's container if there is none. Changing the class of
cover image column is gone.

However, the check is incorrect because it doesn't account for Local
Covers. There might be both a 1 x 1 pixel Amazon image and a local cover
image, so the layout shouldn't be changed unless there are no images
present.

To test, apply the patch and view the bibliographic details page of
various titles including:
- Amazon cover present, no local cover
- No Amazon cover, local cover image present
- Both Amazon and local cover image

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 18:11:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 16:11:40 +0000
Subject: [Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon
 cover image
In-Reply-To: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25016-70-OalOynRJpG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 18:11:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 16:11:43 +0000
Subject: [Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon
 cover image
In-Reply-To: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25016-70-u5x7oyiz6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102058&action=edit
Bug 25016: Coce should not return a 1-pixel Amazon cover image

This patch adds an onload function to the JavaScript which loads images
from Coce. In the case where the image is 1 x 1 pixel the image should
be removed.

To test you should have Coce enabled and Amazon.com included in the list
of sources.

 - Apply the patch and view the bibliographic details page under a
  variety of conditions:
   - A title which has a matching Amazon image:
     - The image should load as expected.
   - A title which doesn't have a matching Amazon image
     - The image should not be found in the source at all after the page
       has loaded.
  - Test with local cover images enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 19:03:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 17:03:51 +0000
Subject: [Koha-bugs] [Bug 23546] Allow library to choose which language
 subscription pattern to search
In-Reply-To: <bug-23546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23546-70-cH8nq22vHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23546

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 19:14:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 17:14:46 +0000
Subject: [Koha-bugs] [Bug 23510] Allow QR codes to be used in
 label/patroncard creator
In-Reply-To: <bug-23510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23510-70-nHlqJHj9MM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Theodorus, is your patch ready for testing? If so, please switch to 'needs
sign-off' to alert testers!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 19:15:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 17:15:22 +0000
Subject: [Koha-bugs] [Bug 23511] Overdrive Advantage integration
In-Reply-To: <bug-23511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23511-70-ufb2vvxYKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23511

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 20:56:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 18:56:34 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-GYBGszf2B2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 20:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 18:56:36 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-hDWIcfoUz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102024|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 102059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102059&action=edit
Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC

Makes some tiny changes to improve display and consistency between
OPAC and staff:
- Capitalization fix: Production Credits - Production credits
- Changes div to span avoiding display issues
- Make sequence of fields in display match (505, 508, 586)

To test:
- Catalog one or more records with none, one and multiple 508 $a
- Check and compare the staff and OPAC detail pages, both
  should display the production credits information correctly

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 20:58:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 18:58:24 +0000
Subject: [Koha-bugs] [Bug 25011] Improve display of Production credits
 (MARC21 508) in OPAC and staff
In-Reply-To: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25011-70-O9XhtBZIdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to Katrin Fischer from comment #5)
> Hi David, sorry, I had realized my mistake but missed to obsolete the first
> patch. The patch attached now should be ok. Please file a bug for 505 -
> happy to have a look.

No problem! The contents is now displaying correctly in the staff interface, so
I'll pu that down to me! David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:22:31 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-67Eq8MmYkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102056|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 102060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102060&action=edit
Bug 25007: Check for normaalized ISBN when building Amazon link

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field.
-Load detail page of that record and see that the local cover images is
 not on the right hand side like it should be but forced underneath
 'catalogue_detail_biblio' in an odd spot.
-Apply patch and reload page
-The image should be back in its normal spot

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:22:34 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-MaSBoOpMC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102057|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 102061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102061&action=edit
Bug 25007: (follow-up) Fix the way image check alters layout

A question in the bug report asks: Why is is necessary to change the
Bootstrap class to col-xs-12? The JavaScript which checks for the
existence of an Amazon cover image is designed to remove the Amazon
cover's container if there is none. Changing the class of
cover image column is gone.

However, the check is incorrect because it doesn't account for Local
Covers. There might be both a 1 x 1 pixel Amazon image and a local cover
image, so the layout shouldn't be changed unless there are no images
present.

To test, apply the patch and view the bibliographic details page of
various titles including:
- Amazon cover present, no local cover
- No Amazon cover, local cover image present
- Both Amazon and local cover image

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:23:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:23:26 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-RqX7RSPWOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:23:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:23:29 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-JDN4Jswn13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102060|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 102062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102062&action=edit
Bug 25007: Check for normaalized ISBN when building Amazon link

TO RECREATE:
-Have Amazon images turned on and local images too.
-Have a record with a local cover image
-Make sure the record has no ISBN in 020 field.
-Load detail page of that record and see that the local cover images is
 not on the right hand side like it should be but forced underneath
 'catalogue_detail_biblio' in an odd spot.
-Apply patch and reload page
-The image should be back in its normal spot

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:23:32 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-IXtg0ipNRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102061|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 102063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102063&action=edit
Bug 25007: (follow-up) Fix the way image check alters layout

A question in the bug report asks: Why is is necessary to change the
Bootstrap class to col-xs-12? The JavaScript which checks for the
existence of an Amazon cover image is designed to remove the Amazon
cover's container if there is none. Changing the class of
cover image column is gone.

However, the check is incorrect because it doesn't account for Local
Covers. There might be both a 1 x 1 pixel Amazon image and a local cover
image, so the layout shouldn't be changed unless there are no images
present.

To test, apply the patch and view the bibliographic details page of
various titles including:
- Amazon cover present, no local cover
- No Amazon cover, local cover image present
- Both Amazon and local cover image

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:46:16 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-99MnSXK855@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:46:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 19:46:19 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-6vkjrbuerB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102043|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 102064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102064&action=edit
Bug 22087: It would be helpful to have City and State visible in member.pl

This patch adds City, State and Zipcode to the display of a patron
search

To test:

1) Do a patron search that retrieves more than one user so you see the
results table
2) In the Names column, see that the patron address display without
city, state and zipcode.
3) Install the patch
4) Repeat the search. City, state and zipcode will now display in the
table.
5) Check that this is working from both member.pl and members-home.pl

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:09:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 21:09:17 +0000
Subject: [Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23781-70-bDuFGPXvRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |BLOCKED

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Probably more appropriate to be BLOCKED as it depends on the recalls feature
that we currently use with our clients but still hasn't made it upstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 00:55:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 22:55:27 +0000
Subject: [Koha-bugs] [Bug 25002] JS Includes should be wrapped with template
 comments
In-Reply-To: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25002-70-n2z8JENNb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #6 from David Roberts <david.roberts at ptfs-europe.com> ---
I've been through this, and have a few comments.

Firstly, I can't see where the additem.js.inc displays - it doesn't seem to be
on the same page as all the other "Cataloging -> Add/Edit item:" comments that
you've added.

Secondly, <!-- / password_check.inc --> and <!-- password_check.inc --> seem to
render the wrong way round - i.e. the closing tag displays first.

Thirdly, str/tinymce_i18n.inc doesn't seem to have a closing comment.

I haven't been able to test the web installer pages yet, and I can't get to the
source on the Patrons -> Patron -> Print summary screen because the printer
dialogue blocks access to it.

Everything else seems perfect though :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:30:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:30:27 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-bxFovXRkp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88827|0                           |1
        is obsolete|                            |

--- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102065&action=edit
Bug 14367: Add MARC record history

This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.

The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.

If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.

Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.

At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.

The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.

Documentation of the functions/methods are also needed.

Icon is ugly and needs to be improved.

Sponsored-By: Halland County Library & Catalyst IT

Test plan:
* Run updatedatabase.pl
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
  a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
  to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
  clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:30:31 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-X0U3s1QtSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88828|0                           |1
        is obsolete|                            |

--- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102066&action=edit
Bug 14367: (follow-up) Fixing merge conflicts...

...and other fixes to make patch work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:31:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:31:48 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-4SBJD8kMzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:33:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:33:20 +0000
Subject: [Koha-bugs] [Bug 24288] Add wording to authorized value interface
 to indicate valid code length
In-Reply-To: <bug-24288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24288-70-KYOTIT9HBS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:40:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:40:31 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-E07M7vtVY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88829|0                           |1
        is obsolete|                            |

--- Comment #29 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102067&action=edit
Bug 14367: (follow-up) Rebasing to make patch work on master

Run through test plan and confirm everything still works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 01:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2020 23:49:13 +0000
Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and
 volumne information
In-Reply-To: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15436-70-d04njE8G4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 04:42:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 02:42:36 +0000
Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email
 notice fail
In-Reply-To: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23295-70-nwXFAjrVoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91471|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102068&action=edit
Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail

When the 'RestrictPatronsWithFailedNotices' syspref is enabled then
patrons with email and sms notices which failed sending (have a
message_queue.status field of 'failed') have a restriction (debarment)
applied to them.

Test plan:
1. In the Koha staff client > Tools > Overdue notice/status triggers and
create the 'First' rule for all patron categories as:

Delay: 1
Letter: Overdue Notice
SMS: ticked

Ensure you have an SMS notice for the ODUE letter.

2. In the system preferences make sure you enter dummy data into the
SMSSendUsername, SMSSendPassword and EmailSMSSendDriverFromAddress
sysprefs

2. Find two non-debarred patrons and make sure they have invalid SMS numbers
set. The SMS numbers must be INCORRECT, for example "123" as an SMS number.
Leaving this field empty will result in the message_transport_type defaulting
to 'print' instead of 'sms'.

3. Check one item out to each patron in step 2

4. Jump into the database and run the query:

UPDATE issues SET date_due=<2 days before current date> WHERE
borrowernumber=<borrower1>;

UPDATE issues SET date_due=<2 days before current date> WHERE
borrowernumber=<borrower2>;

5. Go to  misc/cronjobs directory and enter the Koha shell:

sudo koha-shell <instancename>

6. Run: ./overdue_notices.pl

7. Exit the shell and jump back into the database and run the query:

SELECT message_transport_type, status FROM message_queue WHERE
borrowernumber=<borrower1> OR borrowernumber=<borrower2>;

8. Confirm both new notice records have the message_transport_type is 'sms' and
the status of 'pending'

9. Exit the database and re-enter the Koha shell and run the command:
./process_message_queue.pl

10. Jump back into the database re-run the query from step 7 and confirm
the status is 'failed' for both

11. Also run the query:
SELECT * FROM borrower_debarments WHERE borrowernumber=<borrower1> OR
borrowernumber=<borrower2>;

Notice there is no added debarment to these two patrons

12. Apply patch, restart memcached and plack. In the
installer/data/mysql directory enter the Koha shell and run the command:
./update_database.pl

13. In the Administration > Global System Preferences interface of the
staff client notice there is a new system (set to "Don't" by default)
named 'RestrictPatronsWithFailedNotices'.

Enable it (i.e. select 'Do')

14. Create a new file in the /etc/cron.daily directory named koha-custom and
add the following line to it:

koha-foreach --chdir --enabled
/usr/share/koha/bin/cronjobs/restrict_patrons_with_failed_notices.pl

15. In the  misc/cronjobs directory enter the Koha shell and run the command:
./restrict_patrons_with_failed_notices.pl

16. The script should output text saying: There are borrowers with
failed SMS or email notices

However because you haven't given the script the argument -c it won't
apply debarments (restrictions) to any of the patrons with the failed
SMS or email notices.

16. Query the borrower_debarments table:

SELECT * FROM borrower_debarments WHERE borrowernumber=<borrower1> OR
borrowernumber=<borrower2>;

Notice they still have no restriction

17. Now in the Koha shell run the command:
./restrict_patrons_with_failed_notices.pl -c

18. Notice the script outputs the text:
There are borrowers with failed SMS or email notices
Applying restriction to patron <borrowernumber>: <borrower firstname>
<borrower surname>;

19. Repeat step 16 and notice both patrons now have 1 restriction each
with the borrower_debarments.type=SUSPENSION and comment=SMSnumber
invalid and expiration=NULL

20. Query the borrowers table:
SELECT debarred, debarredcomment FROM borrowers WHERE
borrowernumber=<borrower1> OR borrowernumber=<borrower2>;

21. Notice the values are:
debarred= 9999-12-31
debarredcomment= SMS number invalid

22. Repeat step 17 and notice the script outputs:
There are borrowers with failed SMS or email notices

Patron <borrowernumber>: <borrower firstname> <borrower surname> is currently
restricted due to having an invalid SMS number. No new restriction applied"

23. Repeat step 16 and notice no new debarment has been added to those
borrowers as they have already been restricted from having a failed SMS
notice.

24. In the Koha home directory run the command:
prove t/db_dependent/Koha/Notices.t

This unit test contains the tests for the new subroutines added to
Koha/Notice/Message.pm which are restrict_patron_when_notice_fails() and
get_failed_notices()

25. All tests should pass

26. Sign off

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 04:43:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 02:43:57 +0000
Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email
 notice fail
In-Reply-To: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23295-70-eS00r8UPeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
             Status|Patch doesn't apply         |ASSIGNED
           Assignee|alexbuckley at catalyst.net.nz |aleisha at catalyst.net.nz

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Rebased, however tests fail:

$ prove -v t/db_dependent/Koha/Notices.t 
t/db_dependent/Koha/Notices.t .. 
1..8
ok 1 - The template should have been added
ok 2 - Find a notice template by pk should return the correct template
ok 3 - Delete should have deleted the template
ok 4 - No failed notices currently exist
not ok 5 - One failed notice currently exists

#   Failed test 'One failed notice currently exists'
#   at t/db_dependent/Koha/Notices.t line 98.
#          got: '0'
#     expected: '1'
ok 6 - No failed notices currently existing, now the notice has been marked
pending
not ok 7 - Patron has a restriction placed on them

#   Failed test 'Patron has a restriction placed on them'
#   at t/db_dependent/Koha/Notices.t line 129.
#          got: '0'
#     expected: '1'
not ok 8 - No new restriction has been placed on the patron

#   Failed test 'No new restriction has been placed on the patron'
#   at t/db_dependent/Koha/Notices.t line 150.
#          got: '0'
#     expected: '1'
# Looks like you failed 3 tests of 8.
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/8 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Notices.t (Wstat: 768 Tests: 8 Failed: 3)
  Failed tests:  5, 7-8
  Non-zero exit status: 3
Files=1, Tests=8,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.08 cusr  0.11
csys =  1.21 CPU)
Result: FAIL

ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 04:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 02:47:52 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-C1QGzk09OC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan, 

Thanks for your question/suggestion.

I added both altcontactphone and phone simply to illustrate that all fields (in
Main address, contact, alternate address, and alternate contact) could be
filled.
So if a librarian wanted the main phone field to be filled from guarantor
record they could but they could equally choose to fill altcontactphone instead
- both of those fields will be filled if entered into the syspref. 

I'll make the changes you mentioned now 

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:04:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 06:04:26 +0000
Subject: [Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages
 syspref
In-Reply-To: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9422-70-JLGIsr7aHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This one has languished long enough, I think it's a reasonable patch and
trivial code.. upgrading my earlier signoff to a PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:13:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 06:13:18 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-2DMg6hf54H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd forgotten I'd written this.. but it's still just as relevant now..

Good question on requiring a test plan.  Short of writing a plugin that
utilizes it I'm really not sure how one can test this :( Ill try to come up
with something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:13:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 06:13:43 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-IP6l93Szgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:20:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 06:20:10 +0000
Subject: [Koha-bugs] [Bug 23951] Sundry and Account management fee missing
 from manual fine pull down
In-Reply-To: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23951-70-EJ26I10qwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It's intended.. ;)


You now have much finer grained control over what options are displayed in the
manual invoice dropdown via the account debit type management page.

The first one was certainly intended as a system maintained debit whilst the
second ended up as a catch all manual debit.

They will only not be present for new installs, though the former is still
present on the system, just not displayed in the dropdown (it is available in
the debit types management page).

For upgrades, they should both still be there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:12:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 07:12:44 +0000
Subject: [Koha-bugs] [Bug 23951] Sundry and Account management fee missing
 from manual fine pull down
In-Reply-To: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23951-70-DSCSg5DG9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:23:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 07:23:21 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-zmXWtEh9HG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
And "Unique holiday" are not copied!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:29:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 07:29:51 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-54v2CZ9oE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This really just corrects an error in the original bug 23355.  Because we were
using 'timestamp', which is the 'last updated' date, if a credit action was
later modified somehow.. partial application to a second debit perhaps, then
the cashup report would display it again.

Using the 'created on' date instead, means the data is more consistently
displayed in the correct cashup period.

I'm not really sure how to prove this in a test plan however... hmm.. perhaps a
new unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 07:31:37 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-XzIn8U7tiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another few weeks passed.. quickly thinking this isn't 'critical' at this
point. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:39:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 07:39:32 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-3NGbgZg8I4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

--- Comment #30 from David Nind <david at davidnind.com> ---
Hi Aleisha.

Everything works as expected for me.

Things I noted:

1. The first change doesn't record what was originally there. For example, if
the Title (245 tag a) was 'Abc' and I change it to 'XYZ' then the history
table/log shows as 'XYZ', rather than 'Abc'. Later changes are as expected in
the history, and can be restored.

2. The history recorded seems to be at the field level rather than the subfield
level. For example, if 245 has subfield a and c and I change a, c also shows
the change history. 

Happy to sign off if that is what is expected for the first iteration.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:14:52 +0000
Subject: [Koha-bugs] [Bug 25018] New: Jenkins is not running the test with
 $ENV{_} eq 'prove'
Message-ID: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

            Bug ID: 25018
           Summary: Jenkins is not running the test with $ENV{_} eq
                    'prove'
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

In some tests we want to know if we are in a testing environment.
When run the usual way, our trick works, the perl interpreter matches 'prove':
  $ENV{_} eq 'prove'

In other situations, we have the KOHA_NO_TABLE_LOCKS environment variables, for
the SendCirculationAlert race conditions (see bug 15854 and bug 18364).

For unknown reasons, Jenkins runs the tests with /usr/bin/perl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:21:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:21:11 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-u67BvOwKOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:21:14 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-reSiigNuWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102069&action=edit
Bug 25018: Use new KOHA_TESTING envvar to detect environment testing

In some tests we want to know if we are in a testing environment.
When run the usual way, our trick works, the perl interpreter matches 'prove':
  $ENV{_} eq 'prove'

In other situations, we have the KOHA_NO_TABLE_LOCKS environment variables, for
the SendCirculationAlert race conditions (see bug 15854 and bug 18364).

For unknown reasons, Jenkins runs the tests with /usr/bin/perl.

This patch suggests to rename KOHA_NO_TABLE_LOCKS and use KOHA_TESTING
instead, when prove is not used (or not correctly detected as it it the
case for Jenkins)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:22:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:22:11 +0000
Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 -
 ES6
In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20196-70-6IEksXtClD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> ---
Yes, thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:22:12 +0000
Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make
 the search inaccurate
In-Reply-To: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23521-70-0xrlLNw7ts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521
Bug 23521 depends on bug 20196, which changed state.

Bug 20196 Summary: [Omnibus] Prepare Koha to ElasticSearch6 - ES6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:27:34 +0000
Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe
In-Reply-To: <bug-18364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18364-70-QOYqvnaE0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Oldversions                 |---

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25018

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
KOHA_NO_TABLE_LOCKS is going to be renamed KOHA_TESTING by bug 25018.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:27:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:27:34 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-2ekqqWekoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18364

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:28:19 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-TDshSCrgFP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #52 from David Nind <david at davidnind.com> ---
Everything works as per the test plan.

However, there is still a failed test as before. Is there a system preference
or setting related to test 31? I haven't failed QA, but I haven't signed it off
yet either.

root at 8ca270a5fd09:koha(bz24474)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 30/47 
        #   Failed test 'Should have a single 10 days overdue fine and lost
charge'
        #   at t/db_dependent/Circulation.t line 2430.
        #          got: '27'
        #     expected: '17'
        # Looks like you failed 1 test of 3.

    #   Failed test 'bug 22877'
    #   at t/db_dependent/Circulation.t line 2433.
    # Looks like you failed 1 test of 5.
t/db_dependent/Circulation.t .. 31/47 
#   Failed test 'AddReturn | is_overdue'
#   at t/db_dependent/Circulation.t line 2433.
t/db_dependent/Circulation.t .. 47/47 # Looks like you failed 1 test of 47.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/47 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 47 Failed: 1)
  Failed test:  31
  Non-zero exit status: 1
Files=1, Tests=47, 30 wallclock secs ( 0.09 usr  0.00 sys + 24.44 cusr  2.49
csys = 27.02 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:28:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:28:22 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-PVc6oF1lXS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #16 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
(In reply to Jonathan Druart from comment #15)
> And "Unique holiday" are not copied!

If they're past dates then yes they're not copied. Or do you mean unique
holidays aren't copied at all?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:32:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:32:10 +0000
Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 -
 ES6
In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20196-70-yLoENE4P8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

--- Comment #4 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Katrin Fischer from comment #2)
> All dependent bugs have been closed, can the omnibus bug be closed as well?

I agree. Thx Katrin :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:35:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:35:22 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-0m3gMgWPWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works great for me.. going for a straight PQA.. thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:35:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:35:32 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-dSt9wPwH5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:36:17 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-MNoy23KyQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:36:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:36:19 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-s6MYZ3OgfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:56:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 08:56:27 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-WnZMaiURZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from David Nind <david at davidnind.com> ---
Patch no longer applies - was going to just check that the cashup process
worked.

Applying: Bug 24820: Use 'date' instead of 'timestamp' for cashup
Using index info to reconstruct a base tree...
M       Koha/Cash/Register.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Cash/Register.pm
CONFLICT (content): Merge conflict in Koha/Cash/Register.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24820: Use 'date' instead of 'timestamp' for cashup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:00:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:00:11 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-5Oldhd36Qa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Interesting read:
https://journal.code4lib.org/articles/14978

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:06:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:06:13 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-4K2T3tZwqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102070&action=edit
Bug 22001: Fix Object.t - handle correct RaiseError and PrintError

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:18:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:18:29 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-rifxIaNfKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ok, will retest later then. I might have clicked on March dates, so past!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:20:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:20:52 +0000
Subject: [Koha-bugs] [Bug 25018] Jenkins is not running the test with
 $ENV{_} eq 'prove'
In-Reply-To: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25018-70-pUMUQ7Q67X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:24:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:24:54 +0000
Subject: [Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
In-Reply-To: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24813-70-HsbjxfghFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > It's not related to 500 but 400. There is a
> > Koha::Exceptions::Hold::CannotSuspendFound that is raised and we need to see
> > it somewhere.
> 
> My gut feeling is we should somehow overload Test::Mojo so it does ->or( sub
> { diag $t->tx->res->to_string } ), or just add it everywhere and enforce it
> as a coding guideline.
> 
> This would give us more light on handled exceptions, but we still need
> something for unhandled exceptions, in the lines of bug 18206 (probably
> making use of a helper instead, but you get the point).

That's not only API related, it's exception related.

For instance I get that this morning:

t/db_dependent/Koha/Object.t .. 9/20     # No tests run!

#   Failed test 'No tests run for subtest "attributes_from_api() tests"'
#   at t/db_dependent/Koha/Object.t line 568.
[A bad parameter was given]# Looks like your test exited with 255 just after
14.

It's impossible to track down where it comes from...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:28:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:28:16 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-A6hZbHzKuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101476|0                           |1
        is obsolete|                            |

--- Comment #159 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102071&action=edit
Bug 23463: (follow-up 3) Fix timestamp default value

This is the only situation I found where:
 * t/db_dependent/Koha/Item.t is passing
 * t/db_dependent/Koha/Object.t is passing
 * MySQL 8 is happy (and not fail with "Column 'timestamp' cannot be null"),
which is certainly what I missed in the previous follow-up

About the change to Object.t: the next store was called without the
generated timestamp, so it is needed to call discard_changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:36:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:36:59 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-BC2PKkbLgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:37:02 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-35UPjlzd5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101846|0                           |1
        is obsolete|                            |
 Attachment #101847|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102072&action=edit
Bug 19475: Add unit tests

To test prove:
t/db_dependent/Holidays.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:37:06 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-THLiH82MJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102073&action=edit
Bug 19475: Don't copy holiday if it already exists in target calendar

Calendars copy tool created duplicate values to database.
Holidays in target calendar weren't checked before
inserting new holidays. This patch fixes this.

To test:
1. Add holidays for branch A
2. Copy branch A calendar to branch B
3. Repeat copy to branch B
=> Check database, branch B has now duplicate holidays
4. Delete holidays from branches A and B
5. Apply patch
6. Repeat steps 1-3
=> Check database, no duplicates

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Remove trailing whitespaces and add missing semicolon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:37:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:37:09 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-MXYuFewaXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102074&action=edit
Bug 19475: Clear the caches at the end of the tests

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:40:13 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-0WWOO0OTB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:40:16 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-3tYAZ7JUou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102040|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 102075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102075&action=edit
Bug 4944: Add OpacNoItemTypeImages system preference

At the moment noItemTypeImages pref controls staff and OPAC
display. With this patch, there will be a separate OpacNoItemTypes
preference that allows to control display of each separately.

To test:
- Apply patch and run database update
In Administration:
- Search for 'noItemTypes' preferences
- Verify the settings of both prefs match
- Toggle prefs, verify everything works ok
- Go to the item types configuration page
- Try different settings for both prefs:
  - Both set to No: Only a message with a link to the prefs should show
  - Both set to Yes or either set to Yes: image configuration options
    should show
In the OPAC:
- Check the following pages with item-level_itypes = record
  - advanced search
  - detail page
  - place hold page
- Check the following pages with item-level_itypes = item
  - result list
  - a list (opac-shelves)
  - checkouts and overdues tabs in patron account
    (Note: this didn't work right before, but will now.)
  - reading history in patron account

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:59:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 09:59:12 +0000
Subject: [Koha-bugs] [Bug 19475] Calendar copy creates duplicates
In-Reply-To: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19475-70-SQDbj1oHdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

--- Comment #21 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Thanks for adding caches Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:36:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:36:01 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-SutiWbo1Hi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The easiest for now seems to make it RO and modify the callers, what do you
think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:41:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:41:16 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-UxTBcOISwD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:41:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:41:19 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-S8s00qLRiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102051|0                           |1
        is obsolete|                            |
 Attachment #102052|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102077&action=edit
Bug 25006: Regression tests

This patch introduces regression tests for as_marc_field. It makes sure
there are empty subfields and then uses List::MoreUtils' all to verify
all generated MARC subfields contain something (i.e. the undef ones are
skipped).

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:41:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:41:23 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-MYVhHkRI11@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102078&action=edit
Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields

This patch makes as_marc_field skip subfields that don't have a value or
contains an empty string (replicating C4::Items:1021 logic).

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item.t
=> FAIL: Tests fail because the generated MARC::Field contains undef
subfields.
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass! Undefined and empty subfields are skipped!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:58:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:58:07 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-fyU4HRN4Ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:58:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:58:10 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-U15y0xE8xC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96048|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102079&action=edit
Bug 24183: Add before_send_messages hook

This patch adds a simple hook to the process_message_queue cronjob
to allow plugins to pre-process messages in the messaging queue before
they are sent.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:59:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 10:59:32 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-SmKJLFuLWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Trivial and safe plugin hook implementation following the existing standard
paradigm. Passing QA directly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:31:57 +0000
Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values
In-Reply-To: <bug-9740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9740-70-TvMPufw0if@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Looks like there is no side-effects actually so I close

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:31:57 +0000
Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all
 images on the OPAC
In-Reply-To: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7706-70-uqVyc09GCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706
Bug 7706 depends on bug 9740, which changed state.

Bug 9740 Summary: using XSLT modifies record authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:38:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:38:55 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-2Xd3FRog1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> The easiest for now seems to make it RO and modify the callers, what do you
> think?

I agree. I filled this bug so I don't forget about the problem. We want to be
able to update the options when processing lists of records (e.g. lists, carts,
etc) so we don't generate new objects only to change (say) the items. In those,
we should cache the objects on a per-framework basis.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:56:17 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-F4dSh0NfBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100265|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102080&action=edit
Bug 24820: Use 'date' instead of 'timestamp' for cashup

Prior to this patch we were comparing cash register action timestamp to
accountlines date fields to fetch the list of outstanding accountlines.

accountlines.date is a transient field used as 'updated_on' and so this
was a logical mistake. We should be using the 'date' field which is
fixed 'created_on' time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:56:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:56:30 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-DaGlTc2vps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:58:52 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-sPsTb9lZNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20639

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:58:52 +0000
Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for
 OPAC driven requests
In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20639-70-xrkDtbkGAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24806

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:59:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 11:59:52 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-Yj28qhotP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

--- Comment #5 from Magnus Enger <magnus at libriotech.no> ---
Some libraries might also want only some patron categories to have access to
creating new ILL requests from the OPAC. But that might be something for
another bug report...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:26:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:26:08 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-AGxPQhYeBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
How are you running the tests David?  They're all passing for me within
koha-testing-docker.. it feels like perhaps you have some data in your database
that the tests are not expecting..

I'll take a look at trying to improve them to prevent such failures.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:32:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:32:17 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-b1pejc7gla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. I can't see any obvious reason for this :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:37:06 +0000
Subject: [Koha-bugs] [Bug 25019] New: Non standard initialization in
 ViewPolicy filter
Message-ID: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

            Bug ID: 25019
           Summary: Non standard initialization in ViewPolicy filter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The ViewPOlicy filter has its own method for initializing its values, and then
using its variables. This should be homogeneous through the filters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:44:02 +0000
Subject: [Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy
 filter
In-Reply-To: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25019-70-BHy0j03Adh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102081&action=edit
Bug 25019: Make the ViewPolicy filter initialization standard

This patch makes the ViewPolicy filter use the 'params' accessor instead
of relying of ->{options} which has no accessor. This will allow
interacting with the filter object be similar through all the filters in
the chain.

To test, we just need to verify no behaviour change takes place:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:55:09 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-sgxT79SZEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
0. Dates look great now! :)

1. Why not having current holds in the table (behavior intranet-side,
members/holdshistory.pl)

2. Is there a plan to make existing intranet-side view using the REST API?
ie. only 1 code to maintain.

3. Why only 10 results displayed by default? Usually 20

4. Why no way to modify the number of results displayed? Basically, why
DataTable does not display as other table? (like no page number, search box,
etc.)
Is that the OPAC style?

5. Not translatable strings:
187                         if(row.cancelation_date) return 'Canceled';
188                         if (data == 'F') return 'Fulfilled';
189                         if (data == 'W') return 'Waiting';
190                         if (data == 'T') return 'In Transit';
191                         return 'Pending';

6. opac-holdsrecord.pl vs members/holdshistory.pl
Should not we use the same script names?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:56:21 +0000
Subject: [Koha-bugs] [Bug 22305] Add syspref to allow ILL to be hidden in
 OPAC
In-Reply-To: <bug-22305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22305-70-RD3AZ8UDRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22305

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24806

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:56:21 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-N9U7rI62T3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22305

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:58:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:58:36 +0000
Subject: [Koha-bugs] [Bug 22305] Add syspref to allow ILL to be hidden in
 OPAC
In-Reply-To: <bug-22305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22305-70-4l1R2vpltu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22305

--- Comment #2 from Hans Pålsson <hans.palsson at hkr.se> ---
As reported in bug 24806, in 19.11 (and onwards) this syspref is missing giving
users no option to hide OPAC ILL request forms if a backend is installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 12:59:04 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-35WhlJj49Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
7. Should not deal with that in js-date-format.inc?
  (data&&$date(data))||'';

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:06:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:06:47 +0000
Subject: [Koha-bugs] [Bug 25020] New: Extending due dates to a specified
 date should preserve time portion of original due date
Message-ID: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

            Bug ID: 25020
           Summary: Extending due dates to a specified date should
                    preserve time portion of original due date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When using the tool 'batch extend due dates' the time portion of a checkout is
lost when setting a specific date.

To recreate:
1 - Checkout an item
2 - Note the date due has time of 23:59
3 - Checkout an item and specify the time in the checkout
4 - Note it displays
5 - Use Tools->Batch extend due date
6 - Enter params to capture the two issues you just made
7 - Extend to a specified date
8 - Note checkouts are now due at 00:00:00

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:07:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:07:26 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-J1TrJ1LCqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24846
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kelly at bywatersolutions.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846
[Bug 24846] Add a tool to bulk edit due dates
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:07:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:07:26 +0000
Subject: [Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
In-Reply-To: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24846-70-PDiAL3EPnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25020


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020
[Bug 25020] Extending due dates to a specified date should preserve time
portion of original due date
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:31:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:31:06 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-TmNRw9hcIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102082&action=edit
Bug 25008: Tests for ->options

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:31:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:31:10 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-CDDubhumkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102083&action=edit
Bug 25008: Overload Koha::RecordProcessor->options to update filters

This patch overloads the 'options' accessor generated by Class:Accessor.
It does so the passed options are used to refresh the loaded filters.

Tests are added for this overloaded method as well.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/RecordProcessor.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:32:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:32:20 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-TLkvmbJ6Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 13:43:04 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-EZ1UCdtB6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:09:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:09:23 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-g7K4Ln2fn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:09:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:09:26 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-g6rRq0JXvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

--- Comment #1 from Devinim <kohadevinim at devinim.com.tr> ---
Created attachment 102084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102084&action=edit
Bug 24999: Date not correctly formatted in claims table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:09:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:09:41 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-dGIXyoMR4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

Devinim <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr
           Assignee|koha-bugs at lists.koha-commun |kohadevinim at devinim.com.tr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:15:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:15:21 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-uBvSoaCCu5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:15:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:15:24 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-zYBClGoQwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102085&action=edit
Bug 25020: Preserve time part when batch extending due dates

When selecting a new hard due date, we should keep the time part of the
original checkouts.

Test plan:
1 - Checkout an item specifying a date due
2 - Checkout an item without specifying a date due
3 - Use Tools->Batch extend due date
4 - Select a hard due date
5 - On the confirmation screen you should see that the time part has
been kept
6 - Confirm
7 - Make sure the correct values hava been inserted in DB
8 - Try now using the other option, give a number of days
9 - Repeat 4-7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:26:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:26:03 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-1dSSW2NrZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102019|0                           |1
        is obsolete|                            |
 Attachment #102082|0                           |1
        is obsolete|                            |
 Attachment #102083|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102086&action=edit
Bug 25008: Regression tests

This patch highlights a behaviour of Koha::RecordProcessor that is
unexpected: if you change the original options using ->options, the
loaded filters don't pick the change. That's because the filter objects
are loaded on ->new, and they are never updated.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/RecordProcessor.t
=> FAIL: Test prove ->options doesn't update the filters!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:26:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:26:07 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-OlaaxCUW2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102087&action=edit
Bug 25008: Tests for ->options

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:26:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:26:10 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-sOxu8VO5TY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102088&action=edit
Bug 25008: Overload Koha::RecordProcessor->options to update filters

This patch overloads the 'options' accessor generated by Class:Accessor.
It does so the passed options are used to refresh the loaded filters.

Tests are added for this overloaded method as well.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/RecordProcessor.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:31:37 +0000
Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping
In-Reply-To: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7947-70-IatGShSTAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.hansen at ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:47:08 +0000
Subject: [Koha-bugs] [Bug 25015] Staff with Edit Items permission Currently
 Can Not Edit Items attached to a Fast Add Framework
In-Reply-To: <bug-25015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25015-70-CYYGAixw1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015

--- Comment #1 from Kelly McElligott <kelly at bywatersolutions.com> ---
Working with a specific library that stumbled upon this bug, they feel that the
staff member with edit Items permission should be able to edit any items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:50:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:50:01 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-c6sZsV640d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

--- Comment #2 from Devinim <kohadevinim at devinim.com.tr> ---
Test plan.

1. Apply this patch
2. Look at the Resolution column will show the desired date format with other
columns.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:56:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 14:56:01 +0000
Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 -
 ES6
In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20196-70-vgVl5xySpn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Great job all of you.
Road to ES7 starts now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:03:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:03:45 +0000
Subject: [Koha-bugs] [Bug 23578] Koha ILL backends directory is not included
 in @INC
In-Reply-To: <bug-23578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23578-70-UXUaEbghWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23578

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
We have discussed moving the backends to be traditional Koha plugins, then
Tomas' solution works well. We have been using a version of the Koha-2-koha
plugin that functions this way and that has been a good workaround.

If we want to support the plugins as-is then this should be addressed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:05:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:05:22 +0000
Subject: [Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC
 view
In-Reply-To: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8331-70-z6vutpFwye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:06:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:06:07 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-6T1FXh75bK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |---

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Still happens for me

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:19:46 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-NvqPWq3MCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:19:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:19:49 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-uKdpy0O3fU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 102089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102089&action=edit
Bug 23601: Prevent default for auxclick

The issue appears to be that the default action is not prevented for middle
click because it registers
an 'auxclick' event as opposed to a 'click' event

To test:
1 - Perform a search in staff client
2 - Shift-click and hold on a result
3 - Note a new tab opens
4 - Release the click, no change
5 - Middle click and hold on a result
6 - New tab opens
7 - Release, a second new tab opens
8 - Apply patch
9 - Reload page
10 - Middle click and hold
11 - New tab opens
12 - Release
13 - No new tab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:25:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:25:40 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-xbcusNMQEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #13 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Jonathan,

(In reply to Jonathan Druart from comment #11)
> 0. Dates look great now! :)
> 
> 1. Why not having current holds in the table (behavior intranet-side,
> members/holdshistory.pl)

Controller uses object.search, and places order by in dbic.. to replicate
current behaviour in intranet I should one object.search for both current and
old holds, merge and sort both arrays depending on search column... I decided
to wait till requests and old_requests tables were merged to have current
intranet behaviour 

> 
> 2. Is there a plan to make existing intranet-side view using the REST API?
> ie. only 1 code to maintain.
> 

Once we can replicate current intranet behaviour, we can think on changing
intranet-side

> 3. Why only 10 results displayed by default? Usually 20
> 

ok, will change that

> 4. Why no way to modify the number of results displayed? Basically, why
> DataTable does not display as other table? (like no page number, search box,
> etc.)
> Is that the OPAC style?
> 

OPAC has no style for DataTables.. only intranet has. What you see in other
tables in OPAC was coded outside DataTables. I thought it best to have a search
box and page number, but I'm open to suggestions.

> 5. Not translatable strings:
> 187                         if(row.cancelation_date) return 'Canceled';
> 188                         if (data == 'F') return 'Fulfilled';
> 189                         if (data == 'W') return 'Waiting';
> 190                         if (data == 'T') return 'In Transit';
> 191                         return 'Pending';
> 

Good catch.. will fix that

> 6. opac-holdsrecord.pl vs members/holdshistory.pl
> Should not we use the same script names?

copied the name from opac-readingrecord, but it can be changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:33:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:33:41 +0000
Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 -
 ES6
In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20196-70-ZdUAstF8WX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for checking - a closed bug, is the best bug! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:35:46 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-IT45Mm7YkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Nick!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:36:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:36:33 +0000
Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
In-Reply-To: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24183-70-kjXG01UVeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am ok with this - little nudges work sometimes!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:53:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 15:53:20 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-yUIaSvi7Mg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #14 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #12)
> 7. Should not deal with that in js-date-format.inc?
>   (data&&$date(data))||'';

ok, it can be done

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:52:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 16:52:58 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-w6mGoqRC6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #55 from David Nind <david at davidnind.com> ---
I figured out what has happened:

1) If I leave MarkLostItemsAsReturned with only the 'when receiving payment for
the item' option selected (as per the test plan) then the tests fail.

2) If I change MarkLostItemsAsReturned back to the default (with all options
selected) then the tests pass.

If this is fine, then I will sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:32:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:32:56 +0000
Subject: [Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC
 view
In-Reply-To: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8331-70-JerWzteVTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> I think most important would be to fix the OPAC views - people want to hide
> things from patrons, staff views could be second priority.

I only reproduce on the svc/records/preview script. Can you please re-check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:34:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:34:55 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19382-70-NTzyIrq2AH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
The test plan worked exactly as stated so I will sign off on it.  

I have some additional observations.  The blocking message during checkout
showing the total amount owed by the family of four is great.  However, it
seems like it will take some time to locate who has the fines in order to make
payments and get the family below the threshold amount for blocking.

It would be helpful if the blocking message on circulation.pl could include a
summary on the screen that listed each family member with their associated
fines along with clickable links to make immediate payments.  I can open a new
buf that addresses this extra functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:36:30 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19382-70-1RrWKeHMrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99196|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 102090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102090&action=edit
Bug 19382: Add ability to block guarantees based on fees owed by guarantor and
other guarantees

Some libraries would like to not only block the circulation of a guarantor
based on fines owed by guarantees, but would also like to block circulation for
all guarantees as well. Basically, if a family as a whole reaches a certain
threshold of fines, the entire family will be blocked from checking out items.

Test Plan:
1) Apply this patch
2) Set NoIssuesChargeGuarantorsWithGuarantees to $14
3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents
guarantee both children
4) Give 3 of the 4 a $5 fine
5) None of them should be able to check out items

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:38:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:38:23 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
 calendar and possibility to renew on-site loans
In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24101-70-50Qr5Z5LGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 102091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102091&action=edit
Bug 24101: Enable renewals for on-site checkouts

To test:
1. Enable system preference OnSiteCheckouts
2. Set onsite_renewalsallowed circulation rule (regardless the choice of GUI)
by
   executing the following command on your Koha instance's shell

RENEWS=0; perl -e 'use Koha::CirculationRules; '\
'Koha::CirculationRules->set_rule({ branchcode => undef, categorycode =>
undef,'\
'itemtype => undef, rule_name => "onsite_renewalsallowed", rule_value => '\
"$RENEWS"' });'

3. Perform an on-site checkout
4. Try to renew the loan
5. Observe a similar error dialog:
"Cannot renew on-site checkout:

test / ( test ) has been renewed the maximum number of times by ( admin )"

6. Execute the following shell command

RENEWS=1; perl -e 'use Koha::CirculationRules; '\
'Koha::CirculationRules->set_rule({ branchcode => undef, categorycode =>
undef,'\
'itemtype => undef, rule_name => "onsite_renewalsallowed", rule_value => '\
"$RENEWS"' });'

7. Try to renew the loan
8. Observe success
9. Try to renew the loan
10. Observe the step 5 error dialog

Run unit tests:
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/OnSiteCheckouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:40:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:40:30 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
 calendar and possibility to renew on-site loans
In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24101-70-OInCkc4yT9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

--- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 102092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102092&action=edit
Bug 24101: (OLD CIRC RULES GUI) Add circulation rule onsite_renewalsallowed

For current testing purposes this patch adds onsite renewals count to
circulation
rules page.

We plan to block Bug 24101 by Bug 15522, so this patch will eventually be
dropped.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:41:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:41:55 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
 calendar and possibility to renew on-site loans
In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24101-70-Ra9VBY1eoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:42:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:42:06 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
 calendar and possibility to renew on-site loans
In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24101-70-qdgN1ZBCeJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:50:15 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-fmYr8SkNRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

--- Comment #10 from Eric Phetteplace <ephetteplace at cca.edu> ---
Yes this bug very much affects 19.05, we are on 19.05.08 and suffer from it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:50:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:50:57 +0000
Subject: [Koha-bugs] [Bug 25021] New: Add summary and links to each patron
 record when using block guarantors/guarantees based on fees owed
Message-ID: <bug-25021-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25021

            Bug ID: 25021
           Summary: Add summary and links to each patron record when using
                    block guarantors/guarantees based on fees owed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barbara.johnson at bedfordtx.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Expand the blocking message produced by bug #19382 (Add ability to block
guarantees based on fees owed by guarantor and other guarantees) on
circulation.pl to include a summary on the screen that lists each family member
with their associated fines along with clickable links to make immediate
payments. I think this would improve efficiency and clarity regarding what
fines are contributing to the blocking behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:54:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:54:53 +0000
Subject: [Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy
 filter
In-Reply-To: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25019-70-6Xf7f1Ichd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:55:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:55:22 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-7DKmwf7vDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25019

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:55:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:55:22 +0000
Subject: [Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy
 filter
In-Reply-To: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25019-70-URKaVymh87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25008

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:55:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 17:55:37 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-ck3DbkviED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 20:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 18:22:53 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-YMrQwheZsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|19.11.00                    |19.11.00, 19.05.10
        released in|                            |

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 20:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 18:36:30 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-5XHypE87My@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 19:39:36 +0000
Subject: [Koha-bugs] [Bug 23504] Allow forgiving fines on returned lost items
In-Reply-To: <bug-23504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23504-70-IjGgzFRqcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23504

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 20:15:53 +0000
Subject: [Koha-bugs] [Bug 23480] Improve usability of renewal/return columns
 in the checkouts table
In-Reply-To: <bug-23480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23480-70-wumLSfkvP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23480

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Check out screen            |Improve usability of
                   |(circulation.pl)            |renewal/return columns in
                   |                            |the checkouts table
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:21:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 20:21:37 +0000
Subject: [Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't
 refresh the filters
In-Reply-To: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25008-70-IZ2cjDc0hy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:50:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 20:50:29 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-BFozXJZrVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 20:50:33 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-R8UBZuB0bK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

--- Comment #1 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 102093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102093&action=edit
Bug 23820: Add checkout to default to patron's home branch on club hold

This patch adds a checkbox to make holds created by club hold to default to
patron's home branch if possible.

To test:
1. Apply this patch
2. Create a club, and add two patrons (from now on called patron A and patron
B) to it, each one form a different library..
3. Create a hold for the club, and in the details set pickup location different
from any of the patrons.
4. Check "Pickup at patron's home library when possible" checkbox
SUCCESS => when submitted, pickup location of holds defaults to patron's home
branch
5. Modify patron A's library and set pickup location to no.
6. Repeat steps 3 and 4.
SUCCESS => when submitted, patron A's hold now points to pickup location setted
on step 3, and patron B's hold still points to his home branch.
7. Sign off

Sponsored-by: Southeast Kansas Library - SEKLS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:52:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 20:52:11 +0000
Subject: [Koha-bugs] [Bug 23477] Alphabet error searching
In-Reply-To: <bug-23477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23477-70-mscHqJn7TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There haven't been any more information provided on this bug - closing for now.
Please reopen if this is still an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:00:35 +0000
Subject: [Koha-bugs] [Bug 23469] Update of fr-CA default MARC21 framework
In-Reply-To: <bug-23469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23469-70-fN63Rmri6q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23469

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Caroline, 
do you know that you can use translate
https://translate.koha-community.org/fr_CA/marc21/ and download the files here:
https://translate.koha-community.org/files/ ? :) The new YAML installer might
also be an option, but if you have extra data compared to standard installer,
this might work quicker for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:02:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:02:43 +0000
Subject: [Koha-bugs] [Bug 23461] Popup blockers triggered by option to
 automatically display payment receipt for printing after making a payment
In-Reply-To: <bug-23461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23461-70-cvNkiARolG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not sure if this one was forgotten? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:07:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:07:06 +0000
Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get
 overwritten by the next one
In-Reply-To: <bug-23454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23454-70-en51DWuzLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:29:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:29:29 +0000
Subject: [Koha-bugs] [Bug 23395] batch operations on biblios/items should be
 able to pass a list of plugins
In-Reply-To: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23395-70-Sh6rdWSrCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Plugin architecture
                   |and plumbing                |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:29:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:29:55 +0000
Subject: [Koha-bugs] [Bug 23393] Add Requestor to PO when basket created via
 Quotes
In-Reply-To: <bug-23393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23393-70-Gl4rk2b64R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:39:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:39:41 +0000
Subject: [Koha-bugs] [Bug 23347] Columns settings for items in OPAC should
 be according to the framework
In-Reply-To: <bug-23347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23347-70-I4dt7RziqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marjorie, do you mean that there should be an option to have different
configurations for different frameworks?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:40:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:40:38 +0000
Subject: [Koha-bugs] [Bug 24705] Holds placed via SIP will be given first
 priority
In-Reply-To: <bug-24705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24705-70-5A2i275zQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Does not apply to 19.11.x branch.  Please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:40:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:40:57 +0000
Subject: [Koha-bugs] [Bug 23343] Koha::Library->selected()
In-Reply-To: <bug-23343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23343-70-n4G1E3rmDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23343

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #3)
> What you are looking for is options_for_libraries from html_helpers.inc.

Should this be closed then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:41:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:41:43 +0000
Subject: [Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA
 installation file
In-Reply-To: <bug-24708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24708-70-UO6B2HOcwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:42:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:42:10 +0000
Subject: [Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50
 servers
In-Reply-To: <bug-24707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24707-70-IHSD8f1HWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not pushed to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:44:10 +0000
Subject: [Koha-bugs] [Bug 23337] Links without the protocol in the 856$u
 fail when using TrackClicks
In-Reply-To: <bug-23337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23337-70-CEfxWA7ZfE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23337

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 6892 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:44:10 +0000
Subject: [Koha-bugs] [Bug 6892] If a URL has been entered without http://,
 it isn't correctly linked
In-Reply-To: <bug-6892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6892-70-7mgB3Z8nMS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 23337 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:47:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:47:55 +0000
Subject: [Koha-bugs] [Bug 6892] If a URL has been entered without http://,
 it isn't correctly linked
In-Reply-To: <bug-6892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6892-70-mu9qarWhOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23423

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:47:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:47:55 +0000
Subject: [Koha-bugs] [Bug 23423] Online resource links which are OPAC
 retrieve file references are not correctly formatted in the OPAC detail
 view
In-Reply-To: <bug-23423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23423-70-9e2jUOyckS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:53:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:53:00 +0000
Subject: [Koha-bugs] [Bug 23323] Koha::RefundLostItemFeeRules->find() should
 require `branchcode`, `categorycode` and `itemtype`
In-Reply-To: <bug-23323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23323-70-P7yn9Whxo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can this be closed with bug 18936 pushed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:55:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:55:07 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_23312=5D_Add_ability_to_mark_an_ite?=
 =?utf-8?b?bSDigJhMb3N04oCZIGZyb20g4oCYSG9sZHMgUXVldWUgTGlzdA==?=
In-Reply-To: <bug-23312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23312-70-mGgcrflKdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:55:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:55:37 +0000
Subject: [Koha-bugs] [Bug 23311] Normalization Rules set up in Record
 Matching Rules in Administration Module
In-Reply-To: <bug-23311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23311-70-u08bmLXWnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:57:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 21:57:18 +0000
Subject: [Koha-bugs] [Bug 23303] When uninstalling a plugin we don't call
 any form of 'unload'
In-Reply-To: <bug-23303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23303-70-xGpy4bpfG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23303

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Architecture, internals,    |Plugin architecture
                   |and plumbing                |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:00:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:00:28 +0000
Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem
 with multiple items
In-Reply-To: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24527-70-9cW6FUjG4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.05
        released in|                            |

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:01:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:01:21 +0000
Subject: [Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if
 OpacPublic disabled
In-Reply-To: <bug-24711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24711-70-vJMeN93hIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.05
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
pushed to 19.11.x branch for 19.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:02:02 +0000
Subject: [Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref
 description and behaviour
In-Reply-To: <bug-24682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24682-70-W6RoJArAPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.05
        released in|                            |

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
PUshed to 19.11.x branch for 19.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:02:15 +0000
Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24114-70-PeWl1H65KZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.05
        released in|                            |

--- Comment #24 from Joy Nelson <joy at bywatersolutions.com> ---
PUshed to 19.11.x branch for 19.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:20:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:20:40 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-xVWG97Lj0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:20:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:20:44 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-ONvT4FFJGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93528|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:21:19 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-GQWMqmDwWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006
[Bug 25006] Koha::Item->as_marc_field generates undef subfields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:21:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:21:19 +0000
Subject: [Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef
 subfields
In-Reply-To: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25006-70-75o5l7mz1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23247


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
[Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:21:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:21:50 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-WQtE6dNxTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102094&action=edit
Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl

This patch uses the OO code, with prefetching and all, to make decisions
on visibility. It shouldn't change any behaviour, unless you are
counting DB queries, execution time, etc.

To test:
- Find a known record, go to the OPAC MARC page of it.
- Play with several options in OpacHiddenItems, refreshing it
- Play with OpacHiddenItemsExceptions as well
=> SUCCESS: Things work as expected
- Apply this patch
- Repeate the tests above
=> SUCCESS: Things work as expected!
- Sign off :-D

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:21:56 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-8tQZwcK5NS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102095&action=edit
Bug 23247: (QA follow-up) Restore embedding items in record

The original code called GetMarcBiblio with embeditems => 1, and I
overlooked it.

This patch makes it embed the items.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:23:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:23:46 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-qnS0aysmom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #12)
> Does this report obsolete the borcat parameter of GetMarcBiblio btw?
> If so, please provide a follow-up to get rid of it?

The plan is to get rid of GetMarcBiblio altogether. Gimme some more time to
align things :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:24:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:24:46 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-NftajXbBJK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> Tomas,
> See my comment13.
> I have a book with three items. One is CF.
> Without your patch, normal view and marc view show 2 items. Which is ok.
> With your patch, normal view shows still 2 items (of course), but marc view
> shows no available items. Should be 2.
> 
> Failed QA

Phew, it took me a while to be back here. Please re-test with the follow-up. I
rebased the first patch against master (IssuingRules vs CirculationRules)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:28:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:28:24 +0000
Subject: [Koha-bugs] [Bug 23395] batch operations on biblios/items should be
 able to pass a list of plugins
In-Reply-To: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23395-70-aEed8caXZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Why did I leave this one ASSIGNED?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:42:46 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-9JUZZ3qZ6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

--- Comment #7 from didier <didier.gautheron at biblibre.com> ---
Created attachment 102096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102096&action=edit
Bug 24740: Use biblio title rather than biblio number in OPAC search result
cover images tooltips

In OPAC biblionum doesn't mean much to patrons, use biblio title field if not
empty.

Test plan:
OPAC search
1) Apply the patch
2) For each cover images providers available to tester in:
/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover
OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets,
Coce provider.
3) Enable the provider.
4) Search a Library Catalog for a book with a cover image.
6) test mouse over cover image display biblio title.

OPAC Shelves
1) Enable OPAC virtualshelves preference
2) Create a list.
3) For each covers providers available.
4) Search the List
5) test mouse over cover image display biblio title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:45:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 22:45:57 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-WsU9XqMyLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99695|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:53:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 23:53:25 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-lGVBknii3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #35)
> STOMP is very simple indeed. But combined with RabbitMQ it becomes a
> powerful solution for dispatching messages. And that's not a bad thing of
> course, but I think it adds a useless layer of complexity in our case.

I am willing to try both Minion and RabbitMQ (and I keep telling myself I will
try them soon in my personal time since I'm staying home due to the pandemic).

But I want to say first that I don't think we'd be adding a useless layer of
complexity with RabbitMQ. Provided the implementation is well-architected, I
think message queues are an integral part of scaling up an application and
improving interoperability. 

Using a language agnostic protocol like STOMP, it could be easier to implement
higher performance workers in other languages. For instance, maybe we'd want to
implement some workers in Golang, which makes concurrent programming very easy
with its implementation of user threads as goroutines balanced against kernel
threads depending on resource demands. 

For my work on a OAI-PMH harvester, I have been thinking of rewriting it in
something like Golang instead of Perl, and then hooking into Koha using a
standard message queue (instead of my bespoke POE-based implementation) and/or
APIs. (Honestly though my Perl version is quite high performance in terms of
downloads but the bottleneck is importing into Koha. That's still slower than
I'd like. I occasionally think about how to optimally implement a scalable high
performance MARCXML record importer. But that's a whole other topic really.)

That said, RabbitMQ is a new dependency, and I think our collective fear of new
dependencies has kept us from implementing a message queue previously. 

I think we've arrived at a point where we *have* to have some kind of
job/message queue though. 

Anyway, sorry for the ramble. It's just a topic in which I have a strong
interest. I'm going to put it at the top of my personal to try pile.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:56:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 23:56:31 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-53IF1DF8Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #39 from David Cook <dcook at prosentient.com.au> ---
(As a side note, I am looking at packaging (as RPMs) newer versions of DBD::Pg
and DBI to provide access to new PostgreSQL versions for older OSes for a
different project, and it doesn't seem too challenging.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:57:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2020 23:57:24 +0000
Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other
 content areas
In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22318-70-KPrM1D2D9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

--- Comment #37 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #36)
> Bug added: 25001

Cheers, Martin. You're a legend :).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:10:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:10:59 +0000
Subject: [Koha-bugs] [Bug 25001] 'News' should be renamed now we are
 migrating other content blocks to it
In-Reply-To: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25001-70-KIXlK5KeLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Thanks for opening this issue, Martin. I think this is a great idea!

I am curious how we'll differentiate this functionality from the CMS
functionality in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326. 

It looks like the CMS will be advertised as "Pages" with a description of
"Create and edit additional content pages".

I personally like the sound of "Blocks", but I've asked one librarian so far
and they said that made no sense to them. They suggested something like
"Interface customization", "Home page customization", or something like that.
But they're also a more tech savvy person too. 

They did say that "Administration" would be a better place than "Tools" to put
this functionality and I'm inclined to agree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:27:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:27:26 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
 OAuth2 login
In-Reply-To: <bug-16892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16892-70-NO3EcyoS14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #55 from David Cook <dcook at prosentient.com.au> ---
We should've changed this title as it's actually really misleading in
hindsight, but oh well!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:37:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:37:39 +0000
Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in
 the staff client
In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20062-70-zwNri2zuh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Say what you will about Windows 10, but I think it has been instrumental in
eliminating the use of Internet Explorer 7 in government. 

I think I still maintain some of my older IE fixes, but I could probably drop
those local fixes and not have anyone notice anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:44:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:44:25 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-3BNjjEEFYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi all, 

I've amended my patch. 

I realised I was incorrectly assigning guatantors main address and guarantor
contact fields directly into guarantee alternate address and alternate contact.

In my new patch the pre-filling mapping is:

guarantor:main address = guarantee:main address
guarantor:contact = guarantee:contact
guarantor:Alternate address = guarantee:Alternate address
guarantor:Alternate contact = guarantee:Alternate contact

I've also changed the syspref to be 'multiple' like you requested Jonathan.
I've listed individual fields (ordered alphabetically based on the displayed
text) in the PrefillGuaranteeField rather than sections of the member entry
form like in CollapseFieldsPatronAddForm this is to give librarians more
granulated control if they want to pre-fill some but not all fields in
'contact' section of member entry form for example. 

As I have changed the syspref quite significantly I'll need to obsolete the
patch on this ticket already tested otherwise I'd have to make another
atomicupdate to UPDATE the syspref. 

Could you please re-test Sally (or anyone else interested to do so)?

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:44:52 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-iZUejwCytd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101563|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:45:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:45:27 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-zkf9K0gcRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

--- Comment #15 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 102097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102097&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what sections in member entryfields in
'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship'), 'Alternate address', and 'Alternate contact')
select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* Fields in 'Alternate address' (except for Contact note) are pre-filled from
guarantor record

* None of the fields in 'Alternate contact' are pre-filled from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Restart plack:
sudo koha-plack --restart <instancename>

7. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

8. Observe this syspref contains checkboxes and the following are
selected by default:
Contact - Primary email
Contact - Primary phone
Main address - Address
Main address - City
Main address - Country
Main address - State
Main address - ZIP/Postal code
Main address - street number

Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first
name', Contact - relationship' are not in PrefillGuaranteeField syspref
as they are for non Koha patrons and so should not be pre-filled from a Koha
patron.

9. Repeat step 1 and observe the following fields are prefilled from guarantor:
In Main address section -
streetnumber
address
city
state
zipcode/postal code
country

In Contact section -
Primary phone
Primary email

10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes

11. Repeat step 1 and observe all fields in 'Main address', 'Contact'
(except Guarantor surname, Guarantor first name, and relationship),
Alternate address and Alterate contact are filled from guarantor record.

i.e. The values in guarantor's 'Alternate address' fields fill the
guarantee's 'Alternate address' fields

12. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved in addition to the unaltered pre-filled values in other
fields

13. Amend PrefillGuarantee field syspref to have no checkboxes selected

14. Repeat step 1 and observe none of the fields in Main address,
Contact, Alternate address and Alternate contact are pre-filled

15. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:46:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 00:46:14 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-9f7nyAhm1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:13:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 02:13:04 +0000
Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email
 notice fail
In-Reply-To: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23295-70-JCcr79JdUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:13:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 02:13:07 +0000
Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email
 notice fail
In-Reply-To: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23295-70-xtuedjzZo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102068|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102098&action=edit
Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail

When the 'RestrictPatronsWithFailedNotices' syspref is enabled then
patrons with email and sms notices which failed sending (have a
message_queue.status field of 'failed') have a restriction (debarment)
applied to them.

Test plan:
1. In the Koha staff client > Tools > Overdue notice/status triggers and
create the 'First' rule for all patron categories as:

Delay: 1
Letter: Overdue Notice
SMS: ticked

Ensure you have an SMS notice for the ODUE letter.

2. In the system preferences make sure you enter dummy data into the
SMSSendUsername, SMSSendPassword and EmailSMSSendDriverFromAddress
sysprefs

2. Find two non-debarred patrons and make sure they have invalid SMS numbers
set. The SMS numbers must be INCORRECT, for example "123" as an SMS number.
Leaving this field empty will result in the message_transport_type defaulting
to 'print' instead of 'sms'.

3. Check one item out to each patron in step 2

4. Jump into the database and run the query:

UPDATE issues SET date_due=<2 days before current date> WHERE
borrowernumber=<borrower1>;

UPDATE issues SET date_due=<2 days before current date> WHERE
borrowernumber=<borrower2>;

5. Go to  misc/cronjobs directory and enter the Koha shell:

sudo koha-shell <instancename>

6. Run: ./overdue_notices.pl

7. Exit the shell and jump back into the database and run the query:

SELECT message_transport_type, status FROM message_queue WHERE
borrowernumber=<borrower1> OR borrowernumber=<borrower2>;

8. Confirm both new notice records have the message_transport_type is 'sms' and
the status of 'pending'

9. Exit the database and re-enter the Koha shell and run the command:
./process_message_queue.pl

10. Jump back into the database re-run the query from step 7 and confirm
the status is 'failed' for both

11. Also run the query:
SELECT * FROM borrower_debarments WHERE borrowernumber=<borrower1> OR
borrowernumber=<borrower2>;

Notice there is no added debarment to these two patrons

12. Apply patch, restart memcached and plack. In the
installer/data/mysql directory enter the Koha shell and run the command:
./update_database.pl

13. In the Administration > Global System Preferences interface of the
staff client notice there is a new system (set to "Don't" by default)
named 'RestrictPatronsWithFailedNotices'.

Enable it (i.e. select 'Do')

14. Create a new file in the /etc/cron.daily directory named koha-custom and
add the following line to it:

koha-foreach --chdir --enabled
/usr/share/koha/bin/cronjobs/restrict_patrons_with_failed_notices.pl

15. In the  misc/cronjobs directory enter the Koha shell and run the command:
./restrict_patrons_with_failed_notices.pl

16. The script should output text saying: There are borrowers with
failed SMS or email notices

However because you haven't given the script the argument -c it won't
apply debarments (restrictions) to any of the patrons with the failed
SMS or email notices.

16. Query the borrower_debarments table:

SELECT * FROM borrower_debarments WHERE borrowernumber=<borrower1> OR
borrowernumber=<borrower2>;

Notice they still have no restriction

17. Now in the Koha shell run the command:
./restrict_patrons_with_failed_notices.pl -c

18. Notice the script outputs the text:
There are borrowers with failed SMS or email notices
Applying restriction to patron <borrowernumber>: <borrower firstname>
<borrower surname>;

19. Repeat step 16 and notice both patrons now have 1 restriction each
with the borrower_debarments.type=SUSPENSION and comment=SMSnumber
invalid and expiration=NULL

20. Query the borrowers table:
SELECT debarred, debarredcomment FROM borrowers WHERE
borrowernumber=<borrower1> OR borrowernumber=<borrower2>;

21. Notice the values are:
debarred= 9999-12-31
debarredcomment= SMS number invalid

22. Repeat step 17 and notice the script outputs:
There are borrowers with failed SMS or email notices

Patron <borrowernumber>: <borrower firstname> <borrower surname> is currently
restricted due to having an invalid SMS number. No new restriction applied"

23. Repeat step 16 and notice no new debarment has been added to those
borrowers as they have already been restricted from having a failed SMS
notice.

24. In the Koha home directory run the command:
prove t/db_dependent/Koha/Notices.t

This unit test contains the tests for the new subroutines added to
Koha/Notice/Message.pm which are restrict_patron_when_notice_fails() and
get_failed_notices()

25. All tests should pass

26. Sign off

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 02:56:10 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
 item and allocating to bib-level holds
In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23172-70-TrD5Qz5i13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92250|0                           |1
        is obsolete|                            |

--- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102099&action=edit
Bug 23172: When returning items check issuingrules

When iterating over every reserve on a biblio when it is being returned
retrieve the issuingrule reserveallowed and holds_per_record values for
the reserves requester borrower category and returned item type.

If the issuingrule defines that reservesallowed or holds_per_record is
0 then skip allocating that item to the current bib-level reserve.

Test plan:
1. Find/make a biblio record with two items: one with item type of 'BK'
(book) and the other with the itemtype of 'CR' (Continuing Resource)

2. In Administration > Circulation and fine rules define 2 new rules:

Patron category: 'B' (Board)/ item type: 'BK'/ holds allowed (total): 0/
hold allowed (daily): 0 / holds per record: 0

Patron category: 'P' (Patron)/Item type: 'BK' / holds allowed (total):
1/ holds allowed (daily): 1 / holds per record 1

3. On the biblio record place a biblio-level hold for patron A (who has patron
category of 'B') and patron B (who has patron category of 'P')

4. Return the 'BK' item (item with item type of 'BK')

5. Notice a popup asking you to confirm the hold by patron A (even
though patrons of category 'B' cannot hold items of item type
'BK')

6. Apply patch and restart memcached and plack

7. Remove both holds on biblio

8. Repeat steps 3-5 but notice instead of a popup for patron A
appearing, a popup asking you to confirm patron B appears

i.e. patron A's bib-level hold is skipped as the issuingrules has been
checked when the item was returned and it has been found that they
cannot reserve an item with that specific itemtype

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:56:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 02:56:13 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
 item and allocating to bib-level holds
In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23172-70-EIwXH0NLsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92251|0                           |1
        is obsolete|                            |

--- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102100&action=edit
Bug 23172: Unit tests

Adding unit tests to check the output of the
Koha::Hold->check_if_existing_hold_matches_issuingrules()

Test plan:
1. Run test plan in first patch

2. Enter Koha shell:
sudo koha-shell <instancename>

3. Run: prove t/db_dependent/Hold.t

4. All tests should pass

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 02:56:17 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
 item and allocating to bib-level holds
In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23172-70-4BqJZWvgix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92252|0                           |1
        is obsolete|                            |

--- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 102101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102101&action=edit
Bug 23172: Fixes to failing Circulation.t and Reserves.t unit tests

This patch adds to the unit test coverage of the new
Koha::Hold->check_if_existing_hold_matches_issuingrules().

In patch two on bug 23172 I added unit test for directly testing the new
subroutine Koha::Hold->check_if_existing_hold_matches_issuingrules().

In this patch I fix the test failures in t/db_dependent/Circulation.t
and t/db_dependent/Reserves.t and add a test to confirm
C4::Circulation->AddReturn() works correctly with
Koha::Hold->check_if_existing_hold_matches_issuingrules().

This is because when an item is returned C4::Circulation->AddReturn() calls
C4::Reserves->CheckReserves()
which in turn calls the aforementioned new subroutine.

So the additional unit tests in this patch check all these subroutines
work correctly together.

Test plan:
1. Apply first two patches and follow their respective test plans

2. Enter Koha shell: sudo koha-shell <instancename>

3. Run (from your koha home directory):
prove t/db_dependent/Circulation.t

Confirm it fails

4. Run:
prove t/db_dependent/Reserves.t

Confirm it fails

5. Apply this patch

6. Repeat steps 3 and 4 and confirm the tests pass

6. Confirm t/db_dependent/Holds.t still passes by repeating step 2 and
then running:
prove t/db_dependent/Holds.t

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 08:41:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 06:41:05 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
 OAuth2 login
In-Reply-To: <bug-16892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16892-70-ir3Nhfz6Cb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
David earns the necromancer badge...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 08:44:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 06:44:07 +0000
Subject: [Koha-bugs] [Bug 23323] Koha::RefundLostItemFeeRules->find() should
 require `branchcode`, `categorycode` and `itemtype`
In-Reply-To: <bug-23323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23323-70-C555U1nl1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good call.. lets close it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 08:48:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 06:48:43 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-NNGkubaZrs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 08:48:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 06:48:46 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-qw1FkhK3p9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102089|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 102102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102102&action=edit
Bug 23601: Prevent default for auxclick

The issue appears to be that the default action is not prevented for middle
click because it registers
an 'auxclick' event as opposed to a 'click' event

To test:
1 - Perform a search in staff client
2 - Shift-click and hold on a result
3 - Note a new tab opens
4 - Release the click, no change
5 - Middle click and hold on a result
6 - New tab opens
7 - Release, a second new tab opens
8 - Apply patch
9 - Reload page
10 - Middle click and hold
11 - New tab opens
12 - Release
13 - No new tab

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 08:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 06:50:40 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-YyvwmwLAg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Tested on Ubuntu 18.04 with Firefox 74.0 and Firefox Developer Edition 75.0b11
(64-bit editions).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 07:12:21 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
 biblio number in OPAC search result cover images tooltips
In-Reply-To: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24740-70-83ZseG2fCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:21:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 07:21:13 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-l8a70GLyVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 07:21:16 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-arTwAHRr76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102029|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102103&action=edit
Bug 24941: Serials - Fix link to basket from acquisition details information

Adding orders from subscriptions makes acquisition information visible
in the serials module. In the table of acquisition data is a link back
to the basket - but this link is missing the basket number parameter -
it doesn't work. This patch fixes the TT variable to make it work.

To test:
- Add a subscription
- Add a new basket
- Add a order line using "Add from subscription"
- Go to the subscription details page, check the acquisitions tab
- Try the link to the basket - it should not work
- Apply patch
- Try the link again - now it should bring up the basket page with
  the order.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 07:26:50 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-43EF1IgJyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Notes for testing (mainly as I'm not that familiar with acquisitions or
serials):

- An example of the page where the link is not working correctly is for example
(using koha-testing-docker):
http://127.0.0.1:8081/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1

- Replace the subscriptionid number with one you have setup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:33:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 08:33:33 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-LQ7gLLNzqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That's really helpful David, thankyou.

The tests really aught to take account of that.. I'll take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 08:45:43 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-pxkPfceXdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102104&action=edit
Bug 24474: (QA follow-up) Fix failing test

The test was assuming default data and would fail if you ran through the
test plan (and disabled all but `onpayment` for the
'MarkLostItemsAsReturned' preference) on the data before running the
included unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 08:51:28 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-397SAZ2HCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Final followup pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:53:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 08:53:40 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-b8gQShUhC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #160 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Final follow-up pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:00:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:00:24 +0000
Subject: [Koha-bugs] [Bug 23343] Koha::Library->selected()
In-Reply-To: <bug-23343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23343-70-GqVRyfTefP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23343

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:00:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:00:24 +0000
Subject: [Koha-bugs] [Bug 23342] Branch Transfer Limits
 branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics
In-Reply-To: <bug-23342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23342-70-MUJvLkzbjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23342
Bug 23342 depends on bug 23343, which changed state.

Bug 23343 Summary: Koha::Library->selected()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23343

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:31 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-wL0uBAxoKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:34 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-djhTEmXkt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100229|0                           |1
        is obsolete|                            |

--- Comment #58 from David Nind <david at davidnind.com> ---
Created attachment 102105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102105&action=edit
Bug 24474: Add tests

This does the following using the interface:
- Unselect all the options from MarkLostItemsAsReturned except for
  'onpayment'
- Check an item out
- Create a manual invoice LOST for the checked in item
- Renew the item
- Check that the item was not returned

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:38 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-8c8SeoKls9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100230|0                           |1
        is obsolete|                            |

--- Comment #59 from David Nind <david at davidnind.com> ---
Created attachment 102106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102106&action=edit
Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:42 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-Z64lv54PGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100231|0                           |1
        is obsolete|                            |

--- Comment #60 from David Nind <david at davidnind.com> ---
Created attachment 102107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102107&action=edit
Bug 24474: Filter out LOST_FOUND

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:46 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-9FTJDZapi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100232|0                           |1
        is obsolete|                            |

--- Comment #61 from David Nind <david at davidnind.com> ---
Created attachment 102108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102108&action=edit
Bug 24474: (follow-up) Add onpayment to sysprefs file

This patch adds the required line to the circulation.pref file to
dispaly the onpayment option in the MarkLostItemReturned preference

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:50 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-KvEhhY9yzF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100233|0                           |1
        is obsolete|                            |

--- Comment #62 from David Nind <david at davidnind.com> ---
Created attachment 102109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102109&action=edit
Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay

This patch adds the same updated logic as found in
Koha::Account::Line->apply to handle LOST_FOUND credits being applied
against their associated LOST debit.

Currently a 'LOST_FOUND' credit is never created via the pay method and
so the additional test will always pass, but the addition here accounts
for possible future uses.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:30:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:30:54 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-jJcSsVA3S3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102104|0                           |1
        is obsolete|                            |

--- Comment #63 from David Nind <david at davidnind.com> ---
Created attachment 102110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102110&action=edit
Bug 24474: (QA follow-up) Fix failing test

The test was assuming default data and would fail if you ran through the
test plan (and disabled all but `onpayment` for the
'MarkLostItemsAsReturned' preference) on the data before running the
included unit tests.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:21 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-M2XYK9rni9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98522|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102111&action=edit
Bug 24161: DB changes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:25 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-4bmrCZ0KdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98523|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102112&action=edit
Bug 24161: DBIC changes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:28 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-YjtPIQlFTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98524|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102113&action=edit
Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:31 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-ztaxZY519D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98525|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102114&action=edit
Bug 24161: Keep tracks of late orders claims

So far we only record the number of claims and the date of the last
claim, in the aqorders table.
To keep track of the different claim dates, this patchset is going to
make the following DB changes:
  * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on)
  * Remove the two columns from the aqorders table: claims_count and
  claimed_date

This will allow to display the different claim dates where needed: on
the late orders page, and the basket page.

To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders
has been moved to Koha::Acquisition::Orders->filter_by_late
That way we are going to add consistency, robustness, and cover the
feature with new tests.

Test plan:
0/ Create a bunch of new orders. Make sure they are from different
vendor (with different delivery time).
1/ Go to the late orders page and claim some orders
2/ Reclaim some of those orders
3/ Confirm that you can see the different claim dates for a given orders
(the history of the late orders claims is kept and displayed)

4/ Bonus point: Regression tests:

a. Modify the closedate of the basket in the database. That
will allow you to make sure the patch set did not introduce regressions.
It would be good to test the different filters on the late orders page:
 * delay
 * Estimated delivery date from/to
 * Vendor

b. Confirm that the subtotal and the total values from the late orders
page is correct.

c. Test the update database entry: do not apply these patches, claims
some orders against master. Apply the patch, execute the update DB entry
then confirm that the number of claims is correct (note that the dates
will not as it is not possible to guess them).

QA note: the branchcode parameter has been removed from filter_by_late.
At first glance it seems that it was not used.

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:34 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-RQsYoAt8YJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98526|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102115&action=edit
Bug 24161: Remove GetLateOrders

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:38 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-zqlXoyG5Jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98527|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 102116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102116&action=edit
Bug 24161: Add tests

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:50:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:50:51 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-RK5VfVYVbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:56:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 09:56:00 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-pC7i9jUOvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The order of the columns is not identical, is that expected?

Without: https://snipboard.io/uT4lNK.jpg
With:    https://snipboard.io/iVGqpZ.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:01:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:01:10 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-VrvAROOpFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Removing from PQA, waiting an answer on the different points of the commit
message:

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

You can forget about 1, I rebased the patches on top of it (which is pushed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:09:30 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-GcGiTeBNoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:09:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:09:34 +0000
Subject: [Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results
 sorting button
In-Reply-To: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24996-70-MiyLYX59Mo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102046|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102117&action=edit
Bug 24996: Unwanted CSS change unhides OPAC results sorting button

This patch adds back a CSS selector which was incorrectly removed by Bug
23915. The "Go" button associated with the OPAC search results resort
operation should be hidden if JavaScript is enabled.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Perform a search in the OPAC
 - On the search results page, there should be no "Go" button next to
   the re-sort/results per page selection fields.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:18:35 +0000
Subject: [Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
In-Reply-To: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12187-70-hgFtTzQgVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Pasi,
That's great!
I would recommend 2 things:
1. Add a comment at the top of the include file to add a bit of doc
2. Replace HideStatuses with an array:
  HideStatuses=[1,8]
Then use grep in the include file

What do you think?
Keep in mind that we use snake_case instead of CamelCase for var names.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:26:45 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-xqDY6ADMma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:26:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:26:48 +0000
Subject: [Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options
 in staff and OPAC
In-Reply-To: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25014-70-ybVbjPliXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102049|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102118&action=edit
Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options

There are some ocurrences of "Call Number" in the sort option lists in
staff and OPAC. The patch changes them to "Call number".

To test:
- Check the sort option list in staff and OPAC for the typo
- Apply patch
- Verify it's now all corrected

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:28:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:28:37 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-sr0MsKwFcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:28:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:28:41 +0000
Subject: [Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch
 item edit
In-Reply-To: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25013-70-COU4si5d29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102050|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102119&action=edit
Bug 25013: Fix capitalization: Edit Items on batch item edit

Fixes a tiny string issue: Edit Items --> Edit items

To test:
- Go to tools / batch item edit
- Enter a barcode
- Check the heading above the edit item form
- Apply patch
- Verify the heading is now properly capitalized

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:45:06 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-ksDujk5BnR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Just saying, that's definitely a bug. It works for the OPAC, only.

Please suggest something if you disagree with this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:50:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:50:11 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-ZTp5mTzpsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:50:15 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-YOZJurUTrO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102053|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102120&action=edit
Bug 17938: Fix display of label for repeated MARC 583 - Action note fields

When there are mulitple 583 on a record, the label "Action note" will be
repeated for each. This fixes it, so that the label only appears once and
multiple fields are separated by | following the existing pattern.

Also makes sure there is a space between $z and other subfields.

Note:
Ind. 1 = private - These won't display in the OPAC
Ind. 1 = 0 or empty - These will display in the OPAC
Staff will display all 583 independent from indicator.

To test:
- Add one or more records with none, one and muliple 583, at least one
including $z
  For examples see:
  http://www.loc.gov/marc/bibliographic/bd583.html
- Verify display problems
- Apply patch
- Verify display is improved - one label and $z is followed by a space

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:52:36 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-Zx1GlyOMjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Katrin, please adjust bug report's title (the most important part to me is the
display of the private notes staff-side)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:52:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 10:52:42 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated,
 the label will appear multiple times
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-qRhAgWZIcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:06:20 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-KnS2Cqm1X6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19069

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Great fix Aleisha!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069
[Bug 19069] "Doesn't match" option fails in MARC Modification Templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:06:20 +0000
Subject: [Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC
 Modification Templates
In-Reply-To: <bug-19069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19069-70-hV4Nsgb8D0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24900


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900
[Bug 24900] Fix 'MARC modification templates' to not assume that 'from field'
will match 'conditional field'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:06:39 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-wnPeSIAuNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:06:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:06:44 +0000
Subject: [Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not
 assume that 'from field' will match 'conditional field'
In-Reply-To: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24900-70-PHAUhtTeRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101970|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102121&action=edit
Bug 24900: Checks in MARC mod templates for when from field does not equal
conditional field

When MARC modification template actions are applied, they assume that
the from field is the same as the conditional field. This patch adds
checks for this, as well as tests to confirm the behaviour is correct.

CASE 1: Delete 1st field 020 if 651$z exists
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
                                 of 1st
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020

CASE 3: Delete field 020 if 650$2 does not match fast
BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though
                                 650$2 does match fast
EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields

Confirm tests pass: t/db_dependent/MarcModificationTemplates.t

Sponsored-by: Catalyst IT

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:08:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:08:15 +0000
Subject: [Koha-bugs] [Bug 24820] The cashup workflow should use the static
 'date' field rather than the transient 'timestamp' field in accountlines
In-Reply-To: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24820-70-HNi08SKhNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820

--- Comment #7 from David Nind <david at davidnind.com> ---
Thanks Martin!

I'm happy to sign off, however I'm getting a database error if I do the cashup
from the Point of sale > Branch details screen (any of the buttons), but I
don't get it when doing a cashup from the Point of sale > Register details
screen.

I get this before the patch applies, so it is not related to this bug.

I'm also getting an error when I try to display older transactions on the Point
of sale > Register details screen as well.

Should this be logged as a separate bug(s), or is there a way to fix it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:11:31 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-zam5WWBGyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:11:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:11:35 +0000
Subject: [Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail
 page
In-Reply-To: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25012-70-k85ibjBpIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102045|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102122&action=edit
Bug 25012: Fix class on OPAC view link in staff detail page

Probably a copy & paste error: the OPAC view link on the staff
detail page currently has the class succeeding_entry_note.

This patch changes it to opac_view to allow for independent
styling of the link.

Note: The link will only be visible when OPACBaseURL is set.

To test:
- Use the element inspector or check the source code for
  the class used on the OPAC view link on the staff detail page
- Apply patch
- Repeat and verify that the class has changed to opac_view

Signed-off-by: David Roberts <david at koha-ptfs.co.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:14:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:14:33 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-3k30Q6Yrok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not it be done for XISBN as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:14:49 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-Q1fwlhUcA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 701 [% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a
href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][%
AmazonAssocTag | uri %]#reader-link"><img src="https://images-    
na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html
%].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:21:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:21:37 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-WqCswZfEDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think we should follow the same pattern we have already (in circ-menu.inc)
and use the member-display-address-style-* include files instead, to match the
AddressFormat syspref's value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:21:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:21:44 +0000
Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State
 visible in member.pl
In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22087-70-G43UI2t3BJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:26:50 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-tCway5xnP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:26:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:26:53 +0000
Subject: [Koha-bugs] [Bug 25020] Extending due dates to a specified date
 should preserve time portion of original due date
In-Reply-To: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25020-70-3pllFKnRvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102085|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102123&action=edit
Bug 25020: Preserve time part when batch extending due dates

When selecting a new hard due date, we should keep the time part of the
original checkouts.

Test plan:
1 - Checkout an item specifying a date due
2 - Checkout an item without specifying a date due
3 - Use Tools->Batch extend due date
4 - Select a hard due date
5 - On the confirmation screen you should see that the time part has
been kept
6 - Confirm
7 - Make sure the correct values hava been inserted in DB
8 - Try now using the other option, give a number of days
9 - Repeat 4-7

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:46:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:46:36 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-Ranx8yfKAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102097|0                           |1
        is obsolete|                            |

--- Comment #16 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 102124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102124&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what sections in member entryfields in
'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship'), 'Alternate address', and 'Alternate contact')
select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* Fields in 'Alternate address' (except for Contact note) are pre-filled from
guarantor record

* None of the fields in 'Alternate contact' are pre-filled from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Restart plack:
sudo koha-plack --restart <instancename>

7. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

8. Observe this syspref contains checkboxes and the following are
selected by default:
Contact - Primary email
Contact - Primary phone
Main address - Address
Main address - City
Main address - Country
Main address - State
Main address - ZIP/Postal code
Main address - street number

Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first
name', Contact - relationship' are not in PrefillGuaranteeField syspref
as they are for non Koha patrons and so should not be pre-filled from a Koha
patron.

9. Repeat step 1 and observe the following fields are prefilled from guarantor:
In Main address section -
streetnumber
address
city
state
zipcode/postal code
country

In Contact section -
Primary phone
Primary email

10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes

11. Repeat step 1 and observe all fields in 'Main address', 'Contact'
(except Guarantor surname, Guarantor first name, and relationship),
Alternate address and Alterate contact are filled from guarantor record.

i.e. The values in guarantor's 'Alternate address' fields fill the
guarantee's 'Alternate address' fields

12. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved in addition to the unaltered pre-filled values in other
fields

13. Amend PrefillGuarantee field syspref to have no checkboxes selected

14. Repeat step 1 and observe none of the fields in Main address,
Contact, Alternate address and Alternate contact are pre-filled

15. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

Signed-off-by: Sally <sally.healey at cheshiresharedservices.go.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:47:14 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-3fkDwC6Ic5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:49:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:49:22 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-tCB41slPHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #13)
> Just saying, that's definitely a bug. It works for the OPAC, only.
> 
> Please suggest something if you disagree with this patch.

I dont object to it. But former comments still apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:55:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 11:55:24 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-qWClikS71I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #21)
> The order of the columns is not identical, is that expected?
> 
> Without: https://snipboard.io/uT4lNK.jpg
> With:    https://snipboard.io/iVGqpZ.jpg

That's not expected. I didn't notice!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:09:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:09:47 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-0eLXHChrxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:11:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:11:32 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-25nuVezhuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > Just saying, that's definitely a bug. It works for the OPAC, only.
> > 
> > Please suggest something if you disagree with this patch.
> 
> I dont object to it. But former comments still apply.

Which ones? The one where you ask if we need more paths?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:20:28 +0000
Subject: [Koha-bugs] [Bug 25022] New: Display problem in authority editor
 with repeatable field
Message-ID: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

            Bug ID: 25022
           Summary: Display problem in authority editor with repeatable
                    field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

See attached image. I open an authority record with two 024 fields (that do not
have a $a subfield btw). The second field is not displayed correctly. Looks
like the unordered list is not closed or so?
On current master (writing this 31-03).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:21:20 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-pjpGoKG1qp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 102125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102125&action=edit
Screenshot authority editor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:22:34 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-HNmlCPzYQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:22:39 +0000
Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are
 copied from guarantor to guarantee
In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22534-70-vDTlSaimzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102124|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102126&action=edit
Bug 22534: Added syspref for defining what guarantee fields are pre filled

Librarians should be able to define what sections in member entryfields in
'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are
pre-filled from guarantor's record

The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.

Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship'), 'Alternate address', and 'Alternate contact')
select 'Add guarantee'

2. Observe:

* Fields in 'Main address' are all automatically pre-filled
from guarantor record

* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record

* Fields in 'Alternate address' (except for Contact note) are pre-filled from
guarantor record

* None of the fields in 'Alternate contact' are pre-filled from guarantor

4. Apply patch

5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl

6. Restart plack:
sudo koha-plack --restart <instancename>

7. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference

8. Observe this syspref contains checkboxes and the following are
selected by default:
Contact - Primary email
Contact - Primary phone
Main address - Address
Main address - City
Main address - Country
Main address - State
Main address - ZIP/Postal code
Main address - street number

Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first
name', Contact - relationship' are not in PrefillGuaranteeField syspref
as they are for non Koha patrons and so should not be pre-filled from a Koha
patron.

9. Repeat step 1 and observe the following fields are prefilled from guarantor:
In Main address section -
streetnumber
address
city
state
zipcode/postal code
country

In Contact section -
Primary phone
Primary email

10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes

11. Repeat step 1 and observe all fields in 'Main address', 'Contact'
(except Guarantor surname, Guarantor first name, and relationship),
Alternate address and Alterate contact are filled from guarantor record.

i.e. The values in guarantor's 'Alternate address' fields fill the
guarantee's 'Alternate address' fields

12. Change a few of the prefilled field values and 'Save' and observe your
changes
have been saved in addition to the unaltered pre-filled values in other
fields

13. Amend PrefillGuarantee field syspref to have no checkboxes selected

14. Repeat step 1 and observe none of the fields in Main address,
Contact, Alternate address and Alternate contact are pre-filled

15. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: Waitaki Distict Council, NZ

Signed-off-by: Sally <sally.healey at cheshiresharedservices.go.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:24:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:24:35 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24852-70-u76SwPSzNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Marcel de Rooy from comment #14)
> > (In reply to Jonathan Druart from comment #13)
> > > Just saying, that's definitely a bug. It works for the OPAC, only.
> > > 
> > > Please suggest something if you disagree with this patch.
> > 
> > I dont object to it. But former comments still apply.
> 
> Which ones? The one where you ask if we need more paths?

6/11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:25:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:25:47 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-HYdAzfrb3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Owen, any idea ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:30:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:30:03 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-BHSDgzUY9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Also comes up with 014 and using $a.
So no specific issue with 024 or not using $a.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:31:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:31:03 +0000
Subject: [Koha-bugs] [Bug 25023] New: Claims Returned uses US date format
 (mm/dd/yyyy) in the Claims tab when UK date format (dd/mm/yyyy) is selected
Message-ID: <bug-25023-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023

            Bug ID: 25023
           Summary: Claims Returned uses US date format (mm/dd/yyyy) in
                    the Claims tab when UK date format (dd/mm/yyyy) is
                    selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sally.healey at cheshiresharedservices.gov.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To replicate:

1.  Turn on the Claims Returned feature by setting ClaimReturnedLostValue to 1
2.  Change Koha's date format to UK format by setting DateFormat to dd/mm/yyyy
3.  Check an item out to a patron
4.  Note that the dates in the Check out screen are in UK format - dd/mm/yyyy
5.  Claim the item as returned
6.  Note that in the Claims tab, the date for 'Created on' is in US format
mm/dd/yyyy
7.  In the Claims tab, use the Actions button to mark the item as resolved.
8.  Note that the 'Updated on' and 'Resolution' columns both show the date in
US format - mm/dd/yyyy
9.  Reload the Check out page for the patron and note that the 'Return claims'
column correctly shows the date in UK format - dd/mm/yyyy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:46:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:46:43 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-iy32ZmQvVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:46:46 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-GSvZ9u2sbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102075|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102127&action=edit
Bug 4944: Add OpacNoItemTypeImages system preference

At the moment noItemTypeImages pref controls staff and OPAC
display. With this patch, there will be a separate OpacNoItemTypes
preference that allows to control display of each separately.

To test:
- Apply patch and run database update
In Administration:
- Search for 'noItemTypes' preferences
- Verify the settings of both prefs match
- Toggle prefs, verify everything works ok
- Go to the item types configuration page
- Try different settings for both prefs:
  - Both set to No: Only a message with a link to the prefs should show
  - Both set to Yes or either set to Yes: image configuration options
    should show
In the OPAC:
- Check the following pages with item-level_itypes = record
  - advanced search
  - detail page
  - place hold page
- Check the following pages with item-level_itypes = item
  - result list
  - a list (opac-shelves)
  - checkouts and overdues tabs in patron account
    (Note: this didn't work right before, but will now.)
  - reading history in patron account

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:46:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:46:50 +0000
Subject: [Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences
 for OPAC and staff client
In-Reply-To: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4944-70-tZL4nVUKiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102128&action=edit
Bug 4944: Do not rely on the values from cache during the update DB process

We never know, as we insert values direcly to the DB, the cache may not
be correct.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:54:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:54:18 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-Awd9MIemUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:54:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 12:54:44 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-8bvot1DosZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I cannot recreate that (Firefox 68.4.1esr)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:04:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:04:34 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-UBGmdyzHXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102084|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 102129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102129&action=edit
Bug 24999: Date not correctly formatted in claims table

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:06:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:06:22 +0000
Subject: [Koha-bugs] [Bug 24999] Date not correctly formatted in claims table
In-Reply-To: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24999-70-nJCHhZhvKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
This patch does what it says, so I am signing it off - but I noticed a wider
error with Claims Returned which I've logged under: 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023

Not sure if that wider problem will affect this patch going in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:31:47 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
 subscription
In-Reply-To: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21467-70-cxgc5Lr0zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24941


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941
[Bug 24941] Serials: Link to basket in acqusition details is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:31:47 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-OGJPGIsjZ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21467
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit 679930c8597680a870f7c9801b6dbd40e1254edf
  Bug 21467: Display a summary line per parent_ordernumber


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
[Bug 21467] Allow several receipts for a given subscription
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:32:28 +0000
Subject: [Koha-bugs] [Bug 25024] New: OPAC incorrectly marks branch as
 invalid pickup location when similarly named branch is blocked
Message-ID: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

            Bug ID: 25024
           Summary: OPAC incorrectly marks branch as invalid pickup
                    location when similarly named branch is blocked
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When you've got branches with similar branchcodes, the OPAC can get confused
about which should be blocked by transfer limits.

To test:
- have a branch whose code contains the code for another branch, like "TOWN"
and "TOWNSCHOOL"
- Have a third branch with an unrealated code. I'll use "COUNTRY"
- Have an item of item type BOOK, owned by branch COUNTRY
- Set branch transfer limit to not allow BOOKs to go from COUNTRY to TOWNSCHOOL
- confirm that no transfer limit exists for BOOKS from COUNTRY to TOWN
- On staff client, confirm item allows hold for pickup at TOWN but not at
TOWNSCHOOL
- On OPAC, confirm hold is not allowed for pickup at TOWN or TOWNSCHOOL

This seems to be the problematic bit of code:
[% SET pickup_available_at =
bibitemloo.not_available_at.grep(library.branchcode).size ? 0 : 1 %]

So when we grep "TOWN" it also finds "TOWNSCHOOL," sees that block for
TOWNSCHOOL, and applies it to TOWN in error.

This has come to light as library systems deal with closures of some of their
libraries due to coronavirus and start using branch transfer limits more
intensively.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:32:47 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-bYCcYrpE1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:32:51 +0000
Subject: [Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition
 details is broken
In-Reply-To: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24941-70-oDgCuzHCfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102103|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102130&action=edit
Bug 24941: Serials - Fix link to basket from acquisition details information

Adding orders from subscriptions makes acquisition information visible
in the serials module. In the table of acquisition data is a link back
to the basket - but this link is missing the basket number parameter -
it doesn't work. This patch fixes the TT variable to make it work.

To test:
- Add a subscription
- Add a new basket
- Add a order line using "Add from subscription"
- Go to the subscription details page, check the acquisitions tab
- Try the link to the basket - it should not work
- Apply patch
- Try the link again - now it should bring up the basket page with
  the order.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:32:54 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-CA0cgEw6gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |kelly at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:33:15 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-FNsHbEBvG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> I cannot recreate that (Firefox 68.4.1esr)

I do on Firefox 74.0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:36:31 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-68fTzwy2yl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23049
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:36:31 +0000
Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
 dedicated table
In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23049-70-GIQjMsZdMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25010


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010
[Bug 25010] Fix typo in debit type description: rewewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:37:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:37:42 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-icC3Xso63D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:37:45 +0000
Subject: [Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
In-Reply-To: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25010-70-5s5OU2GA7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102042|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102131&action=edit
Bug 25010: Fix typo 'rewewal' in debit types

This fixes a typo in the debit type description of
RENT_DAILY_RENEW

1) Go to Administration > Debit types
2) Show all debit types
3) Check for the typo
4) Apply patch
5) Verify that the typo is gone
6) Check account_debit_types table for type:
   SELECT * FROM account_debit_types;
7) Run database update
8) Repeat and verify typo is gone

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:42:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:42:49 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-HpDA5hjBls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:52:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:52:50 +0000
Subject: [Koha-bugs] [Bug 25025] New: Drag-and-drop cover image upload
Message-ID: <bug-25025-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025

            Bug ID: 25025
           Summary: Drag-and-drop cover image upload
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

It would be really nice if the process for adding a local cover image to a
title was a simple as dragging the image file into the local cover images tab
on the bibliographic detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:54:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:54:51 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-rCe0zgceLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:54:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:54:55 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-jAUlyv1ack@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102105|0                           |1
        is obsolete|                            |
 Attachment #102106|0                           |1
        is obsolete|                            |
 Attachment #102107|0                           |1
        is obsolete|                            |
 Attachment #102108|0                           |1
        is obsolete|                            |
 Attachment #102109|0                           |1
        is obsolete|                            |
 Attachment #102110|0                           |1
        is obsolete|                            |

--- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102132&action=edit
Bug 24474: Add tests

This does the following using the interface:
- Unselect all the options from MarkLostItemsAsReturned except for
  'onpayment'
- Check an item out
- Create a manual invoice LOST for the checked in item
- Renew the item
- Check that the item was not returned

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:56:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:56:45 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-TfAoeGfaOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102132|0                           |1
        is obsolete|                            |

--- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102133&action=edit
Bug 24474: Add tests

This does the following using the interface:
- Unselect all the options from MarkLostItemsAsReturned except for
  'onpayment'
- Check an item out
- Create a manual invoice LOST for the checked in item
- Renew the item
- Check that the item was not returned

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:56:55 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-PNoufq9jGG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #66 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102134&action=edit
Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:56:59 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-hREKgiwBmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102135&action=edit
Bug 24474: Filter out LOST_FOUND

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:57:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:57:03 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-0BdEoUvLM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102136&action=edit
Bug 24474: (follow-up) Add onpayment to sysprefs file

This patch adds the required line to the circulation.pref file to
dispaly the onpayment option in the MarkLostItemReturned preference

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:57:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:57:07 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-IlBNUYKlQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #69 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102137&action=edit
Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay

This patch adds the same updated logic as found in
Koha::Account::Line->apply to handle LOST_FOUND credits being applied
against their associated LOST debit.

Currently a 'LOST_FOUND' credit is never created via the pay method and
so the additional test will always pass, but the addition here accounts
for possible future uses.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:57:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 13:57:11 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-NPF86ceMdO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #70 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 102138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102138&action=edit
Bug 24474: (QA follow-up) Fix failing test

The test was assuming default data and would fail if you ran through the
test plan (and disabled all but `onpayment` for the
'MarkLostItemsAsReturned' preference) on the data before running the
included unit tests.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:00:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:00:34 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-yW8zyXSo9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:00:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:00:36 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-MfudEtha2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 102139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102139&action=edit
Bug 25024: Make grep match full string

To test:
1 - Create or have a branch with code CPL
2 - Create two new branches 'ACPL' and 'CPLA'
3 - In branch transfer limits disallow some itype or collection from another
branch (FPL) to ACPL and CPLA
4 - Set UseBranchTransferLimits to 'Enforce'
5 - Find a biblio with one item belonging to FPL
6 - On opac, attempt to place a hold
7 - Note that ACPL and CPLA don't show in dropdown, OK
8 - Note that CPL is disabled, NOT OK
9 - Apply patch
10 - Place hold
11 - CPL is now enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:07:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:07:50 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-rZtFuPp6wB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102140&action=edit
Bug 22001: Set unsafe only if RaiseError is not set

Sooooo....

That was tricky, and the solution looks trivial.
However it's not.
We have unsafe set for "historical reason".
Having it on when RaiseError is on have the effect of overwritting the
DBIC error handler.

The problem is:
t/db_dependent/Circulation/MarkIssueReturned.t (and other tests) is failing
with:

  # expecting: Koha::Exceptions::Object::BadValue
  # found: DBIx::Class::Exception ({UNKNOWN}: Can't locate object method
"rethrow" via package "DBD::mysql::st execute failed: Incorrect datetime value:
'bad_date' for column 'returndate' at row 1 [for Statement "UPDATE `issues` SET
`returndate` = ? WHERE ( `issue_id` = ? )" with ParamValues: 0='bad_date',
1=238] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line

In Koha::Object->store, the exception is not a DBIx::Class::Exception object
(as we except), but
a string (on which we cannot call rethrow).

Swithing unsafe off restores the expected behavior.
To make sure the UI will not be affected, it is only turned off when
RaiseError is set.

The situation is still wrong (for UI), from the POD
https://metacpan.org/pod/DBIx::Class::Storage::DBI (/unsafe)
"""
Note that your custom settings can cause Storage to malfunction, especially if
you set a HandleError handler that suppresses exceptions and/or disable
RaiseError.
"""

And also
https://metacpan.org/release/DBIx-Class/source/lib/DBIx/Class/Storage/DBI.pm#L1531

Many thanks Tomas for the digging exploration!

We need to turn RaiseError and remove the unsafe flag, for UI as well,
but that should be done at the beginning of a dev cycle.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:11:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:11:14 +0000
Subject: [Koha-bugs] [Bug 25026] New: RaiseError must be set for the UI
Message-ID: <bug-25026-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

            Bug ID: 25026
           Summary: RaiseError must be set for the UI
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 22001

This is a follow-up for bug 22001.

The patch "Bug 22001: Set unsafe only if RaiseError is not set" proved that
unsafe => 1 and RaiseError => 0 was wrong.
We should move forward and turn RaiseError for the UI, and... see what's
happening. The change goes to the right direction, but we need to know how big
is the task to have a stable release with these parameters correctly set.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001
[Bug 22001] RaiseError and PrintError flags must be set for tests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:11:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:11:14 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-O05gOWzqvm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25026


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026
[Bug 25026] RaiseError must be set for the UI
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:13:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:13:14 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
 and fudge flavors
In-Reply-To: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5158-70-SAU6ogdyPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Chris Cormack from comment #4)
> Koha also needs more Margarita

Can you please submit a patch for that?
Thanks, on behalf of the QA team :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:18:25 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-Q1CPjkdCIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > I cannot recreate that (Firefox 68.4.1esr)
> 
> I do on Firefox 74.0

Wait, I actually do! Lucky me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:19:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:19:35 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-eVQJhHojop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:23:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:23:31 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-fmpOv9H6QD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:23:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:23:35 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-lN3s5vwVFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102102|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102141&action=edit
Bug 23601: Prevent default for auxclick

The issue appears to be that the default action is not prevented for middle
click because it registers
an 'auxclick' event as opposed to a 'click' event

To test:
1 - Perform a search in staff client
2 - Shift-click and hold on a result
3 - Note a new tab opens
4 - Release the click, no change
5 - Middle click and hold on a result
6 - New tab opens
7 - Release, a second new tab opens
8 - Apply patch
9 - Reload page
10 - Middle click and hold
11 - New tab opens
12 - Release
13 - No new tab

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:38:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:38:10 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-lnlVRHVp8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:38:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:38:13 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-lQ4IOEeebp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102139|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 102142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102142&action=edit
Bug 25024: Make grep match full string

To test:
1 - Create or have a branch with code CPL
2 - Create two new branches 'ACPL' and 'CPLA'
3 - In branch transfer limits disallow some itype or collection from another
branch (FPL) to ACPL and CPLA
4 - Set UseBranchTransferLimits to 'Enforce'
5 - Find a biblio with one item belonging to FPL
6 - On opac, attempt to place a hold
7 - Note that ACPL and CPLA don't show in dropdown, OK
8 - Note that CPL is disabled, NOT OK
9 - Apply patch
10 - Place hold
11 - CPL is now enabled

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:38:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:38:35 +0000
Subject: [Koha-bugs] [Bug 25027] New: Result browser should not overload
 onclick event
Message-ID: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027

            Bug ID: 25027
           Summary: Result browser should not overload onclick event
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

$(document).ready(function () {
             //FIXME It's not a good idea to modify the click events
+            $('#searchresults table tr a[href*="/detail.pl"]').on('click
auxclick', function (ev) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:43:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:43:10 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-OoyhfQMxmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:43:12 +0000
Subject: [Koha-bugs] [Bug 25022] Display problem in authority editor with
 repeatable field
In-Reply-To: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25022-70-ZzOfyXNDMK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102143&action=edit
Bug 25022: Display problem in authority editor with repeatable field

This patch corrects an error in the structure of the authority editor
template so that repeating subfields do not generate invalid markup. The
correction was found by comparing with addbiblio.tt.

If you are viewing the diff, please note that some minor whitespace
changes have been made.

To reproduce, clone and and populate any repeatable subfield, save, and
open the authority for editing again. The clones subfield will be
formatting incorrectly, showing bullet points on each line.

To test, apply the patch and reload the authority editor showing the
record with the cloned subfield. It should display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:44:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:44:35 +0000
Subject: [Koha-bugs] [Bug 25027] Result browser should not overload onclick
 event
In-Reply-To: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25027-70-9dw0vpMgXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:44:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:44:39 +0000
Subject: [Koha-bugs] [Bug 25027] Result browser should not overload onclick
 event
In-Reply-To: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25027-70-lM1xhuyqMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102144&action=edit
Bug 25027: Use localStorage instead of sessionStorage for results browser

Staff side, when a search a done and a result clicked, a browser appears
on the left, to navigate between the different results.

We use sessionStorage to know the list of biblionumber from the result.

As sessionStorage is only for the current tab, we do some ugly things,
to catch the click events, then open the new tab, attach it to the
current window, and put the focus back on the result list.

We really should not do that, and let the user decide what they want to
do with their clicks!

To do so, let use the correct storage, localStorage, and have the
results shared between the windows.

We may need to clear that at some point, isn't it?

Test plan:
Launch a search, click result (left or middle), confirm you see the
browser and that the window/tab opened like any other websites
(depending on your web browser settings).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:44:43 +0000
Subject: [Koha-bugs] [Bug 23601] Middle clicking a title from search results
 creates two tabs or a new tab and a new window in Firefox
In-Reply-To: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23601-70-wUjxRl4gEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25027

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Let's do fix that correctly, please?

See bug 25027.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027
[Bug 25027] Result browser should not overload onclick event
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:44:43 +0000
Subject: [Koha-bugs] [Bug 25027] Result browser should not overload onclick
 event
In-Reply-To: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25027-70-ZMwCsvAL0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601
[Bug 23601] Middle clicking a title from search results creates two tabs or a
new tab and a new window in Firefox
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:46:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:46:24 +0000
Subject: [Koha-bugs] [Bug 25027] Result browser should not overload onclick
 event
In-Reply-To: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25027-70-3x4Nrw9849@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #1)
> We may need to clear that at some point, isn't it?

Ignore that, that's done already. We keep 20 searches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:47:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:47:01 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
 notices
In-Reply-To: <bug-8352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8352-70-E6AhTaB8hE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |joy at bywatersolutions.com
             Status|In Discussion               |RESOLVED

--- Comment #111 from Joy Nelson <joy at bywatersolutions.com> ---
Closing this ticket as the printers table no longer exists in master.  Will
revisit and reopen as a new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:47:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:47:02 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-fA06Q5K4J2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764
Bug 16764 depends on bug 8352, which changed state.

Bug 8352 Summary: Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:47:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:47:36 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-D1Zrkrr4b7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Final followup pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:49:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:49:31 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-ALBA0FBlZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:51:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:51:34 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-RsMzCo1bN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:54:52 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-M0wHdEJzar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |17453


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453
[Bug 17453] Inter-site holds improvement
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:54:52 +0000
Subject: [Koha-bugs] [Bug 17453] Inter-site holds improvement
In-Reply-To: <bug-17453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17453-70-G7S80WtheA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25024


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024
[Bug 25024] OPAC incorrectly marks branch as invalid pickup location when
similarly named branch is blocked
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:56:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 14:56:36 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-qb00sjXZ3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, what about the existing syntax:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt:[%
show_marcfield = marcfield_tables.grep('^' _ tablename _ '$').size ? 1 : 0 %]


The '^' _ var _ '$' seems more readable to me, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:03:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:03:08 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
In-Reply-To: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25004-70-yk2g1hARCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:03:11 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
 enabled when checking result checkboxes on opac-search.pl
In-Reply-To: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25004-70-F1fj8CFnBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102008|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 102145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102145&action=edit
Bug 25004: Search results place hold button not enabled when checking result
checkboxes on opac-search.pl

This patch makes a minor correction to the markup of the OPAC search
results page so that the event handlers attached to the checkboxes work
correctly. The broken markup broke the jQuery selector used to control
the event.

An extra </div> was added by mistake by Bug 14715.

To test, apply the patch and test the process of selecting multiple
titles by checking the checkbox. Doing so should activate the "Place
hold" and "Tag" controls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:13:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:13:38 +0000
Subject: [Koha-bugs] [Bug 25028] New: The not-onloan-count index is not used
 in ES
Message-ID: <bug-25028-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25028

            Bug ID: 25028
           Summary: The not-onloan-count index is not used in ES
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

The code in
Koha::SearchEngine::Elasticsearch::QueryBuilder::_fix_limit_special_cases only
sets onloan:false on the query if the availability limit is passed.

This is not (a) matching the Zebra behaviour and (b) it should be using the
not-onloan-count index (which is configured) but as the indexer is feeded with
the output from GerMarcBiblio as-is, it wouldn't include 999$x as the
rebuild_zebra.pl counter part does, using the RecordProcessor filters.

Looking at rebuild_zebra.pl and the fact that ES doesn't use the
EmbedSeeFromHeadings filter either, probably more bugs should be filled.

I'm possibly missing some more magic on the QueryParser code that could deal
with this things in a different way (than Zebra). But the availability one
looks plain wrong so worth filing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:13:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:13:51 +0000
Subject: [Koha-bugs] [Bug 25028] The not-onloan-count index is not used in ES
In-Reply-To: <bug-25028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25028-70-Fqesj3cDW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25028

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:17:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:17:30 +0000
Subject: [Koha-bugs] [Bug 25029] New: AllowPatronToControlAutorenewal needs
 to have a disable setting
Message-ID: <bug-25029-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

            Bug ID: 25029
           Summary: AllowPatronToControlAutorenewal needs to have a
                    disable setting
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The AllowPatronToControlAutorenewal has a Staff or Stand and Patron setting,
but it needs to be a master disable switch as well.  With it in the staff only
position, staff still see a switch for auto renewal in the patron settings,
despite that nothing is set in the circulation rules.

It would be ideal if AllowPatronToControlAutorenewal had a Disable setting
that:
* hid the "Allow auto-renewal of items" choice in the Library Management
settings for the patron.
* hid the three columns in the circulation rules that deal with Auto Renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:27:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:27:15 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
 pickup location when similarly named branch is blocked
In-Reply-To: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25024-70-hU7nqVhUkg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102142|0                           |1
        is obsolete|                            |

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 102146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102146&action=edit
Bug 25024: Make grep match full string

To test:
1 - Create or have a branch with code CPL
2 - Create two new branches 'ACPL' and 'CPLA'
3 - In branch transfer limits disallow some itype or collection from another
branch (FPL) to ACPL and CPLA
4 - Set UseBranchTransferLimits to 'Enforce'
5 - Find a biblio with one item belonging to FPL
6 - On opac, attempt to place a hold
7 - Note that ACPL and CPLA don't show in dropdown, OK
8 - Note that CPL is disabled, NOT OK
9 - Apply patch
10 - Place hold
11 - CPL is now enabled

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joel Sasse <jsasse at plumcreeklibrary.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:28:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:28:20 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-zBj3U8m7xg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102147&action=edit
Bug 22001: Add the DBI error message

Using DBIx::Class error handler, we should not hide the error when
encapsulating it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:57:33 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-uLolCPoiwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #27 from Simon Perry <simon.perry at itcarlow.ie> ---
Created attachment 102148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102148&action=edit
Bug 24159 test 31 March

Hi Jonathan,

Just started testing again. I had the sandbox set to the following
configuration:

(1)     useDaysMode syspref –  Use Calendar to push due date to the next open
day
Today – closed day in calendar
Circulation rules hourly loan Days Mode column – days (ignore calendar)

Result
Hourly loan – correct loan due date same 1hr loan
Long loan -correct due date 6/4/20

the hourly loan checked out correctly retaining today's date and advancing due
time by 1 hour from checkout, but when I tried to check the hourly loan and the
long loan I got a checkin error again. See attachment for details. Not sure if
this is just sandbox playing up or something else but thought you should know.
Regards, Simon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:59:04 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-EhLY3vrOG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102149&action=edit
Bug 22001: Make the DBD error regex less strict

Now the message is looking like
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Duplicate entry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:59:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:59:08 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-sKYF48wqpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102150&action=edit
Bug 22001: Fix Koha/Patrons.t

The message is only printed once

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:59:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:59:13 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-GUdTcQ9GDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102151&action=edit
Bug 22001: execute reports in an eval

Otherwise the tests will fail. We will certainly log twice the error
when run from the UI, but not a big deal. This definitely needs more
attention in a follow-up bug report.
We want to raise proper exceptions here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:59:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 15:59:16 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-CqBH8cKFMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102152&action=edit
Bug 22001: Errors are no longer logged by default (!)

This is one of the biggest part we will have to deal with when we will
switch to DBIC handler for UI as well.
The DBI errors will not be logged if we do not deal with them correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:10:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:10:37 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-kf9WMLwA6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #13)
> Hi Jonathan,
> 
> (In reply to Jonathan Druart from comment #11)
> > 0. Dates look great now! :)
> > 
> > 1. Why not having current holds in the table (behavior intranet-side,
> > members/holdshistory.pl)
> 
> Controller uses object.search, and places order by in dbic.. to replicate
> current behaviour in intranet I should one object.search for both current
> and old holds, merge and sort both arrays depending on search column... I
> decided to wait till requests and old_requests tables were merged to have
> current intranet behaviour 
> 
> > 
> > 2. Is there a plan to make existing intranet-side view using the REST API?
> > ie. only 1 code to maintain.
> > 
> 
> Once we can replicate current intranet behaviour, we can think on changing
> intranet-side
> 
> > 3. Why only 10 results displayed by default? Usually 20
> > 
> 
> ok, will change that
> 
> > 4. Why no way to modify the number of results displayed? Basically, why
> > DataTable does not display as other table? (like no page number, search box,
> > etc.)
> > Is that the OPAC style?
> > 
> 
> OPAC has no style for DataTables.. only intranet has. What you see in other
> tables in OPAC was coded outside DataTables. I thought it best to have a
> search box and page number, but I'm open to suggestions.
> 
> > 5. Not translatable strings:
> > 187                         if(row.cancelation_date) return 'Canceled';
> > 188                         if (data == 'F') return 'Fulfilled';
> > 189                         if (data == 'W') return 'Waiting';
> > 190                         if (data == 'T') return 'In Transit';
> > 191                         return 'Pending';
> > 
> 
> Good catch.. will fix that
> 
> > 6. opac-holdsrecord.pl vs members/holdshistory.pl
> > Should not we use the same script names?
> 
> copied the name from opac-readingrecord, but it can be changed

Jonathan, I just realized this are comments mostly for bug 20936, not this
one.. I'll change what was suggested in point 7, and put this one in SO again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:11:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:11:24 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
 marked as closed (move useDaysMode to circ rules)
In-Reply-To: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24159-70-to1SlvfDnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks for reporting that Simon, that seems a sandbox-related bug. I will ask
Martin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:12:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:12:26 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-PJNVCADeoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #51 from Agustín Moyano <agustinmoyano at theke.io> ---
Failed QA because of comment 11 of bug 24980, that are really for this bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980#c11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:25:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:25:43 +0000
Subject: [Koha-bugs] [Bug 20359] Auto-Renew notice not able to pull branch
 information
In-Reply-To: <bug-20359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20359-70-0KRPR9D7qY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You can easily display it:

Library: [% borrower.library.branchname %]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:29:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:29:50 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-mx5FfL9f9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Yes, that was for bug 20936!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:51:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:51:05 +0000
Subject: [Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set
 for tests
In-Reply-To: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22001-70-ocvAuRpPKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:53:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:53:28 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-4BtWdO1LLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102093|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 102153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102153&action=edit
Bug 23820: Add checkout to default to patron's home branch on club hold

This patch adds a checkbox to make holds created by club hold to default to
patron's home branch if possible.

To test:
1. Apply this patch
2. Create a club, and add two patrons (from now on called patron A and patron
B) to it, each one form a different library..
3. Create a hold for the club, and in the details set pickup location different
from any of the patrons.
4. Check "Pickup at patron's home library when possible" checkbox
SUCCESS => when submitted, pickup location of holds defaults to patron's home
branch
5. Modify patron A's library and set pickup location to no.
6. Repeat steps 3 and 4.
SUCCESS => when submitted, patron A's hold now points to pickup location setted
on step 3, and patron B's hold still points to his home branch.
7. Sign off

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Jason Robb <jrobb at sekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:56:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 16:56:40 +0000
Subject: [Koha-bugs] [Bug 23820] Club Hold pickup locations should be able
 to default to patron's home branch
In-Reply-To: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23820-70-8e2ea905Hf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Jason Robb <jrobb at sekls.org> ---
Tested with a sandbox, works as described! Excellent!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:17:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 17:17:23 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
 details.tt
In-Reply-To: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25007-70-b9HBh9ASMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #12)
> Should not it be done for XISBN as well?

The FRBRizeEditions feature won't link a record if there is no ISBN, so I don't
think it's possible for XISBN.normalized_isbn to evaluate as false AND a row be
returned in the XISBN data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:42:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 17:42:35 +0000
Subject: [Koha-bugs] [Bug 25030] New: IncludeSeeFromInSearches not honoured
Message-ID: <bug-25030-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030

            Bug ID: 25030
           Summary: IncludeSeeFromInSearches not honoured
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

In Elasticsearch there are some things lacking:

- Using the EmbedSeeFromHeadings RecordProcessor filter on indexing
- Probably add a record a normalizer (a RecordProcessor filter?) that strips
the 100a that has ind1=z from the results when retrieving from ES. In Zebra we
only do that for the facets, not sure what's the best approach to be honest.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:46:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 17:46:22 +0000
Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured
In-Reply-To: <bug-25030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25030-70-oKW3TSEVci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:00:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 18:00:15 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15253-70-2DSX61549A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #54 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #53)
> Kyle, your patches are missing entries for log4perl-site.conf.in, and you
> should probably make it dependent on bug 24905, and patch
> koha-common.postinst as well, otherwise people with configured SIP servers
> will end up seeing it broken on upgrade.

Ping @kyle

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:29:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:29:32 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-j1JmchrWfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:29:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:29:36 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-Pbam73a2Qm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101560|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 102154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102154&action=edit
Bug 24965: Regression tests

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail with "Can't call method "count" on an undefined
value..."

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:29:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:29:39 +0000
Subject: [Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef
 counts
In-Reply-To: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24965-70-L1fTWAX3B3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101561|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 102155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102155&action=edit
Bug 24965: Make Koha::Object->to_api handle undef counts

In some cases where we write a class method that is not directly tied to
a DBIC relationship (maybe it should) we are following the following
pattern:

   my $related_object = Koha::RelatedObjects->find($params,$attributes);
   return unless $related_object;
   return $related_object->some_iterator_on_other_class;

While this is not highly consistent (design-wise, because it would be
great if we could return an empty iterator instead of undef) we use this
broadly and consistently.

The to_api method +count handling is not failsafe to those undef cases.
And we should make it return 0 instead of trying to get ->count on
undefined objects.

This patch makes to_api fallback to 0 when it is requested to embed a
count.

To test:
1. Apply the regression test patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Test fails with an error about ->count on undefined variable.
3. Apply this patch
4. Repeat 2
=> SUCCESS: The patch adds the simple fallback to 0 on counts
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:31:04 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-hny4cbMM2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:34:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:34:29 +0000
Subject: [Koha-bugs] [Bug 23395] batch operations on biblios/items should be
 able to pass a list of plugins
In-Reply-To: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23395-70-1xpwR0iW72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #6 from David Nind <david at davidnind.com> ---
Patch no longer applies:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23395: Unit tests
Using index info to reconstruct a base tree...
M       t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
CONFLICT (content): Merge conflict in
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23395: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:40:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:40:25 +0000
Subject: [Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy
 filter
In-Reply-To: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25019-70-ZHDNYHWZgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:40:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 19:40:28 +0000
Subject: [Koha-bugs] [Bug 25019] Non standard initialization in ViewPolicy
 filter
In-Reply-To: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25019-70-COpkXLJro1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25019

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102081|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 102156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102156&action=edit
Bug 25019: Make the ViewPolicy filter initialization standard

This patch makes the ViewPolicy filter use the 'params' accessor instead
of relying of ->{options} which has no accessor. This will allow
interacting with the filter object be similar through all the filters in
the chain.

To test, we just need to verify no behaviour change takes place:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 22:17:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 20:17:37 +0000
Subject: [Koha-bugs] [Bug 17938] XSLT: Label of 583 is repeated for multiple
 tags and private notes don't display in staff
In-Reply-To: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17938-70-ysj8y7GMlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XSLT: if 583 is repeated,   |XSLT: Label of 583 is
                   |the label will appear       |repeated for multiple tags
                   |multiple times              |and private notes don't
                   |                            |display in staff

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #6)
> Katrin, please adjust bug report's title (the most important part to me is
> the display of the private notes staff-side)

You are right - thank you. Actually surprising that it hasn't worked this way
before?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 22:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 20:57:04 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-jTjhQAHjSz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 22:57:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 20:57:07 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-od0bOAo2ZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #17 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 102157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102157&action=edit
Bug 24980: (follow-up) return '' when date is null

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:35:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:35:18 +0000
Subject: [Koha-bugs] [Bug 25031] New: Improve handling of multiple covers on
 the biblio detail page in the staff client
Message-ID: <bug-25031-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031

            Bug ID: 25031
           Summary: Improve handling of multiple covers on the biblio
                    detail page in the staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 25016

I'd like to make a change to the bibliographic detail page in the staff client
so that multiple images from multiple sources are handled more gracefully.

See the short animation here:

https://zivotdesign.com/p/uploads/big/84d60322591e773a46c0abb840c65721.gif


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016
[Bug 25016] Coce should not return a 1-pixel Amazon cover image
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:35:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:35:18 +0000
Subject: [Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon
 cover image
In-Reply-To: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25016-70-kZvPndedc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25031


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031
[Bug 25031] Improve handling of multiple covers on the biblio detail page in
the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:41:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:41:20 +0000
Subject: [Koha-bugs] [Bug 25032] New: Generic unhandled exception handling
Message-ID: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032

            Bug ID: 25032
           Summary: Generic unhandled exception handling
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

The idea is to clean things in the controllers and provide a reliable way to
control the logging of unhandled exceptions for debugging.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:47:49 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-ktHATDrtAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:47:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:47:52 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-A92r0i9iNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101028|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 102158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102158&action=edit
Bug 24908: Unit tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:47:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:47:56 +0000
Subject: [Koha-bugs] [Bug 24908] Allow fetching text-formatted MARC data
In-Reply-To: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24908-70-KwqxLltD7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24908

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101029|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 102159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102159&action=edit
Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id}

This patch makes the route support requesting (through the Accept
header) the MARC record to be output as formatted text as in
$record->as_formatted.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Try the route with your favourite API testing tool (Postman?)
=> SUCCESS: Accept: text/plain returns the expected results
=> SUCCESS: Wrong Accept header returns a list of valid formats, and
includes 'text/plain'.
6. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:51:19 +0000
Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling
In-Reply-To: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25032-70-xPmzj4w4UJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |agustinmoyano at theke.io,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |julian.maurice at biblibre.com
                   |                            |,
                   |                            |kyle at bywatersolutions.com,
                   |                            |lari.taskula at hypernova.fi,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:51:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:51:47 +0000
Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling
In-Reply-To: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25032-70-FBWFhrCuMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102160&action=edit
Bug 25032: Add 'api' target to log4perl.conf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:51:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 21:51:51 +0000
Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling
In-Reply-To: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25032-70-VBEC8ocl5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 102161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102161&action=edit
Bug 25032: Generic unhandled exception handling on API [WIP]

This patch adds Koha::Logger as the default logger for the API, and
introduces a new helper plugin that takes care of handling the unhandled
exceptions. Basically, with this we would write something like this in
our controller methods:

    try {
        ...
    }
    catch {
        if ( know_exception ) {
            handle_known_exception($_);
        }

        $c->unhandled_exception($_);
    }

Without this, we end up adding more and more handling 'just in case'.

This is WIP, to test:
1. Edit the Koha/REST/V1/Cities.pm 'list' method adding
   die("Nada"); before the render step.
2. Restart plack and try the endpoint
=> FAIL: A generic error is displayed, and no traces of the original
problem are found on the logs.
3. Apply this patches, make sure your instance's log4perl has the
   introduced lines for API with the right path.
4. Repeat 2
=> SUCCESS: The message is still generic, but you see something is
logged in /var/log/koha/kohadev/api-error.log
5. Discuss the approach on the bug, with special attention on:
   - Can Koha::Logger be used in Mojo like that? It seems so
   - How the heck can we write tests for the change in V1.pm?
   - Do you really like what I put in the log? Should we change that?
     That was just the first thing that crossed my mind so ideas are
     welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.