[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
I'm happy to test if you could provide some example URLs for ILS-DI requests
and the required parameters.

Notes:
- The patch still applies
- Tests don't pass:

root at 722db1e0af2e:koha(bz22379)$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 6/10 Use of uninitialized value $charge in
numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2991.
t/db_dependent/ILSDI_Services.t .. 8/10     # No tests run!
t/db_dependent/ILSDI_Services.t .. 9/10 
#   Failed test 'No tests run for subtest "CancelHold"'
#   at t/db_dependent/ILSDI_Services.t line 698.
Can't use string ("Su0VSFAs") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Reserves.pm line 175.
# Looks like your test exited with 255 just after 9.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 2/10 subtests 

Test Summary Report
-------------------
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 9 Failed: 1)
  Failed test:  9
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 9.
Files=1, Tests=9, 14 wallclock secs ( 0.04 usr  0.00 sys + 11.33 cusr  1.57
csys = 12.94 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.