[Koha-bugs] [Bug 23727] Editing course reserve items is broken

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Kyle, any ideas about how we could fix this correctly?
> 
> Something bad has happened to CourseReserves::_UpdateCourseItem. This
> function should check to see if the course is active. If it is inactive, it
> should edit the values in the course_items table, if it is active, it should
> edit the values in the items table. In master, it *always* edits the items
> table, and there is no way to ever update the course_items table no matter
> if the course is active or inactive!
> 
> This is appears to be a deeper more problematic issue than the stated one
> though. I think the solution for the "Unchanged" issue is to add a
> 'use/ignore' column for each of the swappable columns (itype_enabled,
> ccode_enabled, etc), along with a checkbox in the editor to enable them.
> 
> This would solves the original issue, that "Unchanged" as a value has been
> unreliable and weird. The module was first written without the expectation
> that a library would want an item column to be undef while *not* on course
> reserve, and have a value while *on* course reserve. Undef was used to
> signify the "Leave unchanged" status. It seems that after solving the more
> pressing issue above, moving the swap-ability indicator to it's own column
> would be the once-and-for-all solution to this problem.

Kyle, did you track down which patch (bug number) broke the original feature?

-- 
You are receiving this mail because:
You are watching all bug changes.