[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #50)
> Comment on attachment 99637 [details] [review]
> Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
> 
> Review of attachment 99637 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> @@ +376,5 @@
> >                    yes: Allow
> >                    no: "Don't allow"
> >              - patrons to submit problem reports for OPAC pages to the library or Koha Administrator.
> > +            - "<br/>"
> > +            - "<strong>NOTE:</strong> You must have KohaAdminEmailAddress enabled."
> 
> This isn't actually true is it?.. we use branch email in preference to
> KohaAdminEmailAddress so it's just a fallback not a hard requirement.

With the 404 redirect in opac-reportproblem.pl it is a hard requirement.
Original code was assuming the pref was filled IIRC.

> ::: opac/opac-reportproblem.pl
> @@ +41,5 @@
> >  );
> >  
> > +if (   !C4::Context->preference('OPACReportProblem')
> > +    || !C4::Context->preference('KohaAdminEmailAddress') )
> > +{
> 
> Don't we actually use branchemail in preference to KohaAdminEmailAddress so
> this isn't actually a hard requirement?

Not what the code is actually doing. Maybe it needs to be adjusted.
105                         to_address             =>
C4::Context->preference('KohaAdminEmailAddress'),

(In reply to Martin Renvoize from comment #51)
> Comment on attachment 99638 [details] [review]
> Bug 4461: Simplify recipients code
> 
> Review of attachment 99638 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
> @@ +32,5 @@
> > +                        [% IF recipient == 'admin' %]
> > +                            Your problem report has been sent to the Koha administrator.
> > +                        [% ELSE %]
> > +                            Your problem report has been sent to the library.
> > +                        [% END %]
> 
> Do we really need to get this specific in the OPAC?
> 
> I'd say we just need to say whether the email was successfully sent or not
> and not worry so much whether it's KohaAdminEmail or Library Branch Email..
> the end user doesn't have a way to select who it goes to anyway.
> 
> If we remove this we could simplify the code a little

Feel free to submit any follow-ups you wish ;)

-- 
You are receiving this mail because:
You are watching all bug changes.