[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 4 15:35:59 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
SIP gives nice feedback, staff client does unless I click 'pay' next to the
individual fine, can you check that one?

I do wonder about write-offs and whether they should also trigger renewal, but
am calling that scope creep

I don't know about the call to 'GetFine' in the renew_item sub, seems an extra
DB hit. I am not sure either - how do you end up with more than one OVERDUE
fine on an item? if from an old checkout that was returned, do we care in this
instance? I may be overthinking - not a blocker, but curious about the
reasoning

Please check my work on rebasing and cleaning in the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list