[Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Bernardo Gonzalez Kriegel from comment #6)
> 
> > Summary:
> > 1) Can be rewritten to single lines if needed
> 
> Nope, that makes sense!

Ok

> 
> > 2a) I think is not a problem
> 
> If I am not wrong, the ^W appeared *with* the patches.

You mean ^M?
Look for example the RENEWAL letter in your dump without patch.
It's a little notice with at least 4 ^M

In sample_notices.sql you can see that the first letter, ODUE, has '\n' for
newlines; the second one, ACQCLAIM, has '\r\n' for the same.
I need to use only one, and '\r\n' works for win/linux

> 
> > 2b) Followup uploaded to Bug 24593
> 
> Thanks!
> 
> > 2d) Waiting your opinion
> 
> How big would it be to allow NULL for translated value? If it can be a quick
> fix I guess it's better to have it.

Not a big problem :)
Followup added to Bug 24262 to skip null values
and followup added to Bug 24583 to restore nulls in labels

-- 
You are receiving this mail because:
You are watching all bug changes.