[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 6 00:55:48 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, there is a problem in the code

->  243     my $quoted_codes = '';
    244     if ($letter_codes) {
    245         my @codes = map { "'$_'" } split(',', $letter_codes);
->  246         my $quoted_codes = join(',', @codes);
    247     }

Two "my $quoted_codes", in lines 243 and 246.
$quoted_codes passed to execute will always be empty.
Remove the second 'my'

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list