[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #101 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Sorry, but I cannot pass QA on this patch set:

You add changes to Reserves.pm but you only change a test script for updating
or inserting age restriction in marc subfields. We need solid test cases for
the changes you make.

But looking further, do we really want this change here? We already check for
maxreserves in opac-reserve.pl and reserve/request.pl. So if you would need it
for ILS-DI, I would expect you add it there? If we want the check in the
module, we should also consider the scripts mentioned. And what about
performance? If you come from CanBook, why would you test it again and again in
CanItem? This check is only needed for the first item?

+         { status => alreadyReserved }, if the borrower has already reserved
this item.
Where do you find that one ?

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.