[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #6)
> Hoping to get an answer from Tomas on this one regarding Jonathan's
> question.. we would like to know if the API should really be returning the
> actual exception error in the 500 response.

The usual pattern is:

        unless ( blessed $_ && $_->can('rethrow') ) {
            return $c->render(
                status  => 500,
                openapi => {
                    error =>
                      "Something went wrong, check Koha logs for details."
                }
            );
        }
        return $c->render(
            status  => 500,
            openapi => { error => "$_" }
        );

So if it is not showing the exception info it is because it is not an
exception. In both cases I'd feel comfortable with a change to send the
exception to the logs, unless debugging is set (i.e. no need to give the
consumer details about the internal problems in Koha). So I vote for all
unhandled exceptions to return a generic internal server error and warn the
exception info.

-- 
You are receiving this mail because:
You are watching all bug changes.