[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 6 13:55:55 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marcel de Rooy from comment #6)
> Wouldnt it be better to return undef or empty string in case of template use?
> If it is concatenated somewhere, we get a 0 in between ?

Returning undef triggered this error in the QA tool:

"# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s)."

I don't think there is a scenario where this variable would be concatenated
with something else, but if you think it's worth preparing for I would be happy
to sign off on a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list