[Koha-bugs] [Bug 24608] Allow modification of checkout due date

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #33 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Agustín Moyano from comment #32)
> seems timezone is not saved in date_due column, because it's a datetime
> rather than timestamp

Good spot Agustín! Since we're wanting to take into account the timezone during
storage and display, I think you're right, a timestamp column would make more
sense.

> Maybe we can alter that column to timestamp, so timezone is saved, or I can
> add a flag to the JS function in 24455 to use timezone or not

Modifying the column seems the proper way to do this. Since the data stored in
a datetime / timestamp column is the same (it's just whether it's considered to
be UTC or not that varies).

However, it's not clear to me how the migration would work though. Currently
everything in date_due is stored in whatever the client's timezone was and
displayed as-is. However, if we convert it to timestamp, it will then be
considered to be UTC and adjusted as appropriate for display at the client. But
because it wasn't stored as UTC, this will lead to incorrect times being
displayed. Since we've no way of knowing the timezone of the client storing the
value, I'm not sure how we can compensate for this.

Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.