[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #22)

So basically nothing was working, thanks for having caught that Nick!

> I tested the following, let me know if i missed elsewhere:
>   editing patron satff
>   editing patron opac
>   importing patron
>   patron creation/update via ldap
> 
> Branch limitations do not save

Fixed.

> Cannot load patron if attribute value not in authorized values (OK, but
> should have a way to identify)

Fixed, I will also open a bug report.

> Opac update of attributes fails, blank value passed to update request

Fixed.

> Patron import with 'replace only included attributes' fails
> Can't use string ("Koha::Patron::Attribute") as a HASH ref while "strict
> refs" in use at /kohadevbox/koha/Koha/Object.pm line 625

Fixed.

> Attributes in ILSDI shows some extra info:
> borrowernumber, authorised_value_category - is noisier than without patch

Yes, I let a FIXME in the code (which refers to bug 14257 comment 15). I would
be happy to fix it you have an idea about what's best here.

> Test failures:
> Test Summary Report
> -------------------
> t/00-testcritic.t                 (Wstat: 256 Tests: 1020 Failed: 1)
>   Failed test:  732
>   Non-zero exit status: 1
> t/00-valid-xml.t                  (Wstat: 512 Tests: 135 Failed: 2)
>   Failed tests:  1-2
>   Non-zero exit status: 2
> t/Logger.t                        (Wstat: 256 Tests: 1 Failed: 1)
>   Failed test:  1
>   Non-zero exit status: 1

They pass for me. Maybe not related to this patchset?

-- 
You are receiving this mail because:
You are watching all bug changes.