[Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #19 from Frank Hansen <frank.hansen at ub.lu.se> ---
Hi,

> 0/ It would be useful to test the update DB entry on a big and old
> production DB, to make sure the constraints will be added correctly.

Here in Lund we have tested your fix on a clone of our production DB with over
90000 subscriptions and the short story is that we are satisfied of what the
fix accomplish. 

> 2/ Make sure you can upgrade from a master install
This step went well, no errors.
I think it is good that orphaned entries is removed before creating the FK
constraints. It turned out in our case there were data that were migrated from
our previous system by mistake. So the subscription was actually deleted in the
old system. So, we didn't lose any important data anyway.

> 3/ Create a subscription, serial, etc. and delete the biblio
> => The subscription/serials should have been deleted from the DB
The fix does what it should. And the performance has also improved
significantly which is important from my perspective.

> 4/ Create a subscription, serial, etc. and delete the subscription
> => The serials should have been deleted from the DB
The fix does what it should. Works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.