[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #103 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to Katrin Fischer from comment #102)
> I agree about the tests, but with all the API work - Doesn't it makes sense
> to centralize all the checks needed instead of repeating (and forgetting
> them) all over the place? The general idea makes sense to me.

Thanks for the +1 Katrin, that was definitely the idea behind this patch.
While working with library frontend software we (@BibLibre) have stumbled
across several checks and behaviors which are different from OPAC to ILS-DI.

Centralizing those checks and behaviors makes a lot of sense to me as well with
also the Rest API coming if we want to have a bit of coherence across the
different entry points of Koha.

Also makes the whole thing much easier to maintain I guess.

Still I do have a bit of work ahead for the tests.
I will try to solve this before the NoHackFest / CanceledHackFest

-- 
You are receiving this mail because:
You are watching all bug changes.