[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 11 03:17:31 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99935|0                           |1
        is obsolete|                            |

--- Comment #76 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 100490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100490&action=edit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list