[Koha-bugs] [Bug 24740] use biblio title if available rather than biblio number in OPAC search result cover images tooltips

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr
             Status|Needs Signoff               |In Discussion

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Indeed, the biblio number doesn't mean much when used as a cover tooltip.

I'm keen to Sign Off on your patch and have the following points to make:

1) "Author: Didier GAutheron" <- unless you want to be credited this way
   in the Koha release notes and in the About page timeline you may want
   to redo your git config and make a small change to your surname.

2) "BUG 24740: [...]": as per the official guidelines in the Koha wiki
   (https://wiki.koha-community.org/wiki/Commit_messages#Subject_line)
   the word "Bug" should be capitalised, and not be in all uppercase,
   otherwise the QA tools will complain.

3) The QA tools will also flag the missing filters at the lines where
   you've added [% img_title %], this is due to the coding guidelines'
   requirement that _all_ template variables must be filtered:
  
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_template_variables

   You should probably remove the filters from the assignments inside
   the IF-ELSE blocks and use the "html" filter whenever the img_title
   variable is used later on in the TT code:

   [% IF ( SEARCH_RESULT.title ) %]
       [% img_title = SEARCH_RESULT.title %]
   [% ELSE %]
       [% img_title = SEARCH_RESULT.biblionumber %]
   [% END %]

   [% IF ( itemsloo.title ) %]
       [% img_title = itemsloo.title %]
   [% ELSE %]
       [% img_title = itemsloo.biblionumber %]
   [% END %]

   <span title="[% img_title | html %]" ... ></span>

4) You have used hard tabs to indent some of the code in your patch,
   the QA tools will notice this. I suggest you change them to soft
   tabs (spaces). The offending lines are:

   254 and 256 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   327 and 329 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt

5) Should we take this opportunity and fix the cover tooltip in the biblio
   details page as well? And the shelf browser, too?

   The relevant TT files are:
   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
   koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc

-- 
You are receiving this mail because:
You are watching all bug changes.