[Koha-bugs] [Bug 21296] Suspend hold ignores system preference on intranet

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Hayley Mapley from comment #9)
> This patch in the 18.11 build has caused two tests to fail:
> 
> _db_dependent_selenium_regressions_t.Display circulation table correctly
> (476)
> t_db_dependent_Circulation_t.AddReturn + suspension_chargeperiod (500)
> 
> Is anyone able to fix these tests for 18.11? Alternatively I can revert the
> patches for now.

Hi Hayley,
I do recreate the selenium failure locally, not Circulation.t
The checkouts table does not display correctly because of a missing
columns_settings variable.

The following commit is part of 19.05 but 18.11:
  commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc
  Bug 17353: Add phone number column to checkout search


-        columns_settings = [% ColumnsSettings.GetColumns( 'circ',
'circulation', 'issues-table', 'json' ) | $raw %]
+        columns_settings_issues_table = [% ColumnsSettings.GetColumns( 'circ',
'circulation', 'issues-table', 'json' ) | $raw %]
+        columns_settings_borrowers_table = [% ColumnsSettings.GetColumns(
'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %]

-- 
You are receiving this mail because:
You are watching all bug changes.