[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #71)
> (In reply to Katrin Fischer from comment #69)
> > Notes & questions
> > 
> > 1) We might want to modify the bug title a little - in addition to allow
> > changing the manager, this will also store the last person to change and
> > date. Also gives a checkbox for TO_PROCESS. We really needs some release
> > notes :)
> 
> Any suggestions? :)

Done, hope that makes sense.

> > 3) Is there a reason why we don't let the db update thelastmodificationdate?
> 
> We can pick the max date of suggesteddate, manageddate, accepteddate,
> rejecteddate,  is that was you have in mind?

I added a follow-up to update the 2 new columns.

> > Blockers
> > 
> > 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?

Still waiting for an answer here, but I think we could fix that on a follow-up
if needed. The change will be minor compared to the work needed to keep this
patchset up-to-date with master.

> > 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> > for the manager. I believe this should be handled separately. ( Bug 13014:
> > Notify budget owner on new suggestion - cronjob)
> 
> That was part of the original specification.
> It makes sense to have 2 different notice templates. Something to suggest?
> UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?

Done, a new template notice "NOTIFY_MANAGER" has been added.

Sending back to the QA queue.

-- 
You are receiving this mail because:
You are watching all bug changes.