[Koha-bugs] [Bug 24608] Allow modification of checkout due date

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've been digging here..

dt_from_string did indeed ignore offsets which is bad.. but it also assumed a
timezone that matches the configured instance timezone rather than respecting
the 'Z' or '+0000' to mean 'UTC'.

As such.. whatever you passed in via the API would be stored 'as is', as a
string with an assumed offset matching your instances configured timezone.

This patchset uses the js date function .toISOString which always returns a
zero offset UTC string (and compensates for local timezone of the browser so
our widget which returns a string of local time results in a date object with
the local offset and as such when the ISO call is called above the offset is
applied to get UTC time).

I've now updated bug 24850 to handle rfc3339 dates correctly and to always
localise as to the instance config time for the output datetime object.. this
will mean that if we pass in a rfc3339 string with or without an offset the
resulting datetime will get properly localised to the instance time with the
difference in offsets applied.

I believe this will resolve the issue face by Jonathan but would like to see
some tests using hourly loans.  I think for a realistic case we should be
setting instance time and browser locale to match.. I don't believe it's a fair
case work with multiple timezones for a single library branch.. or is it?

-- 
You are receiving this mail because:
You are watching all bug changes.