[Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
This patch makes a very small change in the case that we cannot send our notice
directly because the patron doesn't have a valid address to send to.

Current logic:
If we don't have an email address, send a print notice - if we can't find a
print template use the email template
If we don't have an SMS number, send a print notice - if we can't find a print
template use the email template

New logic:
If we don't have an email address, send a print notice - if we can't find a
print template use the email template
If we don't have an SMS number, send a print notice - if we can't find a print
template use the SMS template


(In reply to Jonathan Druart from comment #5)
> If what we want is to not send a SMS notice if there is not SMS template,
> why are not we written that explicitly in the code?

If I set a notice to have a print version and no email version, and I trigger
it as an email, no message is sent. We get an error:
No circulation CHECKOUT letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 608.

Why do we not do the same for SMS?

This code is not changing that anyways, it simply changes that if we try to
send an SMS but cannot and are going to send a 'print' then we should use the
SMS template if there is no print template. This affects the @output_chunks of
the code - the notice that gets sent to libraries saying "These messages were
not sent directly to the patron"

-- 
You are receiving this mail because:
You are watching all bug changes.