[Koha-bugs] [Bug 24455] Date formatting from JS

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm facing similar challenges here as I did with bug 24454.

Now I'm wrapping my head around it, there seems to be a fair bit of duplicate
code introduced here that already exists in
koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc

I'm by no means against introducing moment.js, I like the idea of using well
maintained and thought out third party libraries and the was of accessing the
functions written here is nice and elegant.. much like the way you introduced
elegant accessors for currency handling in bug 24454 (I'd like to see some of
those idea's taken forward too).

But.. I don't like that we're duplicating logic and making it somewhat less
clear which functions should be used for the job so would like some form of
merge/aggregation of such functionality and a clear documentation somewhere for
how to use it before I'm happy pushing this.

-- 
You are receiving this mail because:
You are watching all bug changes.