[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Mar 20 14:42:12 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553
Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101096|0 |1
is obsolete| |
--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101112
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101112&action=edit
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron
The drop_hold routine was using the wrong parameter for item info in the
patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both
waiting and unavailable
holds
To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!
You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling
a hold
and check the messages, test coverage is improved by this patch and should be
sufficient
for testing
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list