[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #26)
> Having doubts if we should add userenv if there is already a login. If there
> is no login, the current approach seems fine to me. But if we have a login
> (by cookie from opac or intranet login), we loose the information which user
> triggered the action. Currently, such actions are saved into action_logs
> with the current user.

ILSDI does not depend on user authentication, the permissions of the user to
edit  items or place holds etc do not match. ILSDI is its own way to interact
with KOha - I think in these instances it is more correct to indicate a system
user as opposed to sign in user.

The trigger for this patch was actually the Aspen discovery system. The ILSDI
calls are routed from a central server which is also passing other calls to
Koha. We began to see holds being manipulated by random patrons - because
without a session set explicitly for ILSDI any other session from the server
was being picked. It was causing logging issues and confusion

> Please add why we need the dependency. Only for the test plan?

Yes, I think there were small differences in logs with those patches, so they
are related

-- 
You are receiving this mail because:
You are watching all bug changes.