[Koha-bugs] [Bug 24740] use biblio title if available rather than biblio number in OPAC search result cover images tooltips

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740

--- Comment #6 from didier <didier.gautheron at biblibre.com> ---
Hi, thanks for you reply.

(In reply to Andreas Roussos from comment #2)
> 1) "Author: Didier GAutheron" <- unless you want to be credited this way
Oops, thanks.

> 
> 2) "BUG 24740: [...]": as per the official guidelines in the Koha wiki
>    (https://wiki.koha-community.org/wiki/Commit_messages#Subject_line)
>    the word "Bug" should be capitalised, and not be in all uppercase,
>    otherwise the QA tools will complain.
Will do.

> 
> 3) The QA tools will also flag the missing filters at the lines where
>    you've added [% img_title %], this is due to the coding guidelines'
>    requirement that _all_ template variables must be filtered:
>
Same.

> 4) You have used hard tabs to indent some of the code in your patch,
>    the QA tools will notice this. I suggest you change them to soft
>    tabs (spaces). The offending lines are:
Note:
Tips in wiki guidlines seem to be wrong, 
You can fix tabs by using 
git config --global core.whitespace trailing-space,space-before-tab
git config --global apply.whitespace fix

Don't replace tab, I have it but still get tab.

> 
>    254 and 256 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>    327 and 329 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
> 
> 5) Should we take this opportunity and fix the cover tooltip in the biblio
>    details page as well? And the shelf browser, too?
> 
>    The relevant TT files are:
>    koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>    koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
I'll look at it.

Regards
Didier

-- 
You are receiving this mail because:
You are watching all bug changes.