[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Mar 20 18:35:07 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101198|0 |1
is obsolete| |
Attachment #101199|0 |1
is obsolete| |
Attachment #101200|0 |1
is obsolete| |
Attachment #101201|0 |1
is obsolete| |
Attachment #101202|0 |1
is obsolete| |
Attachment #101203|0 |1
is obsolete| |
Attachment #101204|0 |1
is obsolete| |
Attachment #101205|0 |1
is obsolete| |
--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 101302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101302&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences
This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.
This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.
The following preferences are affected:
- BorrowerMandatoryField
- BorrowerUnwantedField
- PatronSelfModificationBorrowerUnwantedField
- PatronSelfRegistrationBorrowerMandatoryField
- PatronSelfRegistrationBorrowerUnwantedField
To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.
- Go to Administration -> System preferences, and search for
"PatronSelf"
- The input fields for PatronSelfModificationBorrowerUnwantedField,
PatronSelfRegistrationBorrowerMandatoryField, and
PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
(read-only) inputs.
- Clicking the input field should trigger a modal window with
checkboxes for each available column from the borrowers table.
- Test that the "select all" and "clear all" links work correctly.
- Test that the "cancel" link closes the modal without saving your
selections.
- Test that the "Save" button closes the modal, copies your selections
to the form field, and triggers the preference-saving function (this
eliminates the need to click a save button again after closing the
modal).
- Test this process by making modifications to all three different
preferences, confirming that the right data is preselected each
time the modal is shown and the right data is saved to the right
field each time.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list