[Koha-bugs] [Bug 23415] Notify patron fines when renewing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am wondering if noissuecharge is the right value here.

We got: 
OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff
specifically.

noissuecharge = fine limit for checkouts (as name says). It's used in this
patch set, but there are other complications with this one:

noissuescharge  
Prevent patrons from checking out books if they have more than EUR in fines.

HoldsInNoissuesCharge   
[Don't include|Include] hold charges when summing up charges for
noissuescharge.
ManInvInNoissuesCharge  
[Don't include|Include] custom debit type charges when summing up charges for
noissuescharge.
RentalsInNoissuesCharge         
[Don't include|Include]  rental charges when summing up charges for
noissuescharge. 
NoIssuesChargeGuarantees        
Prevent a patron from checking out if the patron has guarantees owing in total
more than EUR in fines.

So I think this is not covering it:

+  my $amountlimit = C4::Context->preference("noissuescharge");
+  var fines = "[% fines | html %]

We'd need the amount calculated taking all noissues* prefs into account.

I think I'd prefer not using noissuecharge here, as it only speaks of checkouts
and we have a distinct one for renewals. Using OPACFineNoRenewals would make
sense to me, as you can still override in the staff interface. So having a
'hint' there would work.


Also a little worried that this adds a confirm step - but as none of the
testers complained, I think it's probably ok :)

-- 
You are receiving this mail because:
You are watching all bug changes.