[Koha-bugs] [Bug 24201] Attach desk to intranet session

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #9 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Martin Renvoize from comment #7)
> Generally, this patch appears to work as expected so I'll sign it off.
> 
> However, I have some feedback:

Thank you!

> 1/ I'd like to see the whole 'Desks' functionality behind a system
> preference so libraries not interested in using the feature don't see it.

I thought about not adding another syspref. If there is no desk defined it
should not be seen apart from the links “desks” in admin home page and menu. If
it's too much anyway I can surely add a syspref.

> 2/ If there are not desks defined for the logged-in library then a trailing
> `|` is left in the header menu

Oups, that should not happen, I'll fix it.

> 3/ Should you not be able to set a Desk from the Login screen?

Sure, but I wasn't sure how to do it, because it's necessary to change the desk
menu when switching libraries, and I wasn't sure how to do it. I better liked
the idea to attach IP addresses to a desk to automatically set a desk at
logged-in.

> 4/ Jury is out regarding adding the Desk into the header bar menu title.. I
> like that it's immediately obvious, but for narrow screens, this could cause
> issues?

Ho, I'm terrible at web things. We are used to this display, but we certainly
will conform to what suits best the community.

-- 
You are receiving this mail because:
You are watching all bug changes.