[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #43 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #40)
> Comment on attachment 101726 [details] [review]
> Bug 20936: Add patron's hold history menu in OPAC
> 
> Review of attachment 101726 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: api/v1/swagger/paths/public_patrons.json
> @@ +301,5 @@
> > +                  {
> > +                    "name": "timestamp",
> > +                    "in": "query",
> > +                    "description": "Time of latest update",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +313,5 @@
> > +                  {
> > +                    "name": "waiting_date",
> > +                    "in": "query",
> > +                    "description": "Date the item was marked as waiting for the patron",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +319,5 @@
> > +                  {
> > +                    "name": "expiration_date",
> > +                    "in": "query",
> > +                    "description": "Date the hold expires",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry
> 
> @@ +337,5 @@
> > +                  {
> > +                    "name": "suspended_until",
> > +                    "in": "query",
> > +                    "description": "Suspended until",
> > +                    "type": "string"
> 
> This feels wrong.. surely this needs a `format: date-time` entry

These are input parameters.. these are for search, including partial search..
so you cannot put 'format: date-time' if you plan to search by all dates from
year 2020, for example.

-- 
You are receiving this mail because:
You are watching all bug changes.