[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101826|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 101968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101968&action=edit
Bug 23888: (follow-up) Wrap English string in translation function

This patch makes alert added in subscription-add.js translatable using
the new __() function.

To test, apply the patch and confirm that the alert still works
correctly when submitting the subscription edit form with an invalid
vendor id.

Test that the string can be translated (using fr-Fr for example):

1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR

Switch to the fr-FR translation and confirm the the alert shows your
translated string.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Still seeing a false negative in qa tools:
    FAIL Untranslatable string found (The vendor does not exist) - See coding
guideline JS5

-- 
You are receiving this mail because:
You are watching all bug changes.