[Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not assume that 'from field' will match 'conditional field'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

--- Comment #5 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Aleisha Amohia from comment #4)
> Created attachment 101666 [details] [review]
> Bug 24900: Checks in MARC mod templates for when from field does not equal
> conditional field
> 
> When MARC modification template actions are applied, they assume that
> the from field is the same as the conditional field. This patch adds
> checks for this, as well as tests to confirm the behaviour is correct.
> 
> CASE 1: Delete 1st field 020 if 651$z exists
> BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead
>                                  of 1st
> EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020
> 
> CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.')
> BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020
> EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020
> 
> CASE 3: Delete field 020 if 650$2 does not match fast
> BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though
>                                  650$2 does match fast
> EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields
> 
> Confirm tests pass: t/db_dependent/MarcModificationTemplates.t
> 
> Sponsored-by: Catalyst IT

What I can see, this patch does as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.