[Koha-bugs] [Bug 24614] Can't edit reports if not using cache

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 27 17:12:14 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 102013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102013&action=edit
Bug 24614: Fix Reports/Guided.t

DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement
"UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?,
`report_group` = ?, `report_name` = ?, `report_subgroup` = ?,
`savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04',
1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # Looks like you planned 17 tests but ran 6.

update_sql expect all the paramters to be set, otherwise it will be
nulled.

The best way to fix it is at test level. There is only 1 occurrence in
controller/module, and it sends all the parameters. That is the correct
way to do and will make things easier when we will removed them to use
Koha::Reports directly

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list