[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #6 from David Roberts <david.roberts at ptfs-europe.com> ---
I've been through this, and have a few comments.

Firstly, I can't see where the additem.js.inc displays - it doesn't seem to be
on the same page as all the other "Cataloging -> Add/Edit item:" comments that
you've added.

Secondly, <!-- / password_check.inc --> and <!-- password_check.inc --> seem to
render the wrong way round - i.e. the closing tag displays first.

Thirdly, str/tinymce_i18n.inc doesn't seem to have a closing comment.

I haven't been able to test the web installer pages yet, and I can't get to the
source on the Patrons -> Patron -> Print summary screen because the printer
dialogue blocks access to it.

Everything else seems perfect though :-)

-- 
You are receiving this mail because:
You are watching all bug changes.