[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Mar 31 18:10:37 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

--- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Agustín Moyano from comment #13)
> Hi Jonathan,
> 
> (In reply to Jonathan Druart from comment #11)
> > 0. Dates look great now! :)
> > 
> > 1. Why not having current holds in the table (behavior intranet-side,
> > members/holdshistory.pl)
> 
> Controller uses object.search, and places order by in dbic.. to replicate
> current behaviour in intranet I should one object.search for both current
> and old holds, merge and sort both arrays depending on search column... I
> decided to wait till requests and old_requests tables were merged to have
> current intranet behaviour 
> 
> > 
> > 2. Is there a plan to make existing intranet-side view using the REST API?
> > ie. only 1 code to maintain.
> > 
> 
> Once we can replicate current intranet behaviour, we can think on changing
> intranet-side
> 
> > 3. Why only 10 results displayed by default? Usually 20
> > 
> 
> ok, will change that
> 
> > 4. Why no way to modify the number of results displayed? Basically, why
> > DataTable does not display as other table? (like no page number, search box,
> > etc.)
> > Is that the OPAC style?
> > 
> 
> OPAC has no style for DataTables.. only intranet has. What you see in other
> tables in OPAC was coded outside DataTables. I thought it best to have a
> search box and page number, but I'm open to suggestions.
> 
> > 5. Not translatable strings:
> > 187                         if(row.cancelation_date) return 'Canceled';
> > 188                         if (data == 'F') return 'Fulfilled';
> > 189                         if (data == 'W') return 'Waiting';
> > 190                         if (data == 'T') return 'In Transit';
> > 191                         return 'Pending';
> > 
> 
> Good catch.. will fix that
> 
> > 6. opac-holdsrecord.pl vs members/holdshistory.pl
> > Should not we use the same script names?
> 
> copied the name from opac-readingrecord, but it can be changed

Jonathan, I just realized this are comments mostly for bug 20936, not this
one.. I'll change what was suggested in point 7, and put this one in SO again.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list