From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:17:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:17:18 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102602|0 |1
is obsolete| |
--- Comment #26 from Bernardo Gonzalez Kriegel ---
Created attachment 104060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104060&action=edit
Bug 23111: Set a custom framework as the default
when importing records or editing records with no framework mapped.
To test:
1) Go to edit a biblio with no framework mapped
2) Click the Settings dropdown, notice that the 'Default' framework is
selected
3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU'
button and notice the selected framework in the URL is 'Default'
4) Go to Tools -> Stage MARC records for import. Stage a bibliographic
record. Go to Staged MARC management for your newly imported batch.
Notice that the frameworks dropdown (above the 'Import this batch into
the catalog' button) has the 'Default' framework selected
5) Apply this patch and update the database. Apply the schema changes
patch or update your schema files. Restart memcached and plack.
6) Go to Administration -> MARC bibliographic frameworks. Edit one of
your custom frameworks. Set it as default by checking the checkbox and
saving.
7) Edit a different custom framework and set this one as the default
now. Confirm that the previous framework has been unset (the checkbox is
no longer checked) as the default.
8) Repeat steps 1-4 and confirm that the selected framework is your
newly set default framework, instead of the provided 'Default'
framework.
9) Go back to Administration -> MARC bibliographic frameworks. Edit your
default framework and unset it as default (uncheck the checkbox). Save.
10) Repeat steps 1-4 and confirm that the selected framework is the
provided 'Default' framework again, so we can have no default custom
framework if chosen.
11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t
Sponsored-by: Catalyst IT
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:17:24 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104058|0 |1
is obsolete| |
--- Comment #27 from Bernardo Gonzalez Kriegel ---
Created attachment 104061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104061&action=edit
Bug 23111: Schema changes
If not testing on a sandbox, do not apply this patch. Instead, apply
first patch, update dbix files, then apply final patch and test.
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:17:29 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104059|0 |1
is obsolete| |
--- Comment #28 from Bernardo Gonzalez Kriegel ---
Created attachment 104062
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104062&action=edit
Bug 23111: Making is_default a boolean flag
Signed-off-by: Bernardo Gonzalez Kriegel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:20:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:20:21 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104004|0 |1
is obsolete| |
--- Comment #2 from Victor Grousset/tuxayo ---
Created attachment 104063
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104063&action=edit
Bug 25325 ElasticSearch mapping export lacks staff_client/opac fields
Add to export_elasticsearch_mappings.pl two missing fields: staff_client
and opac.
Test plan:
1. Run export_elasticsearch_mappings.pl script. Write the result in
mappings.yaml (the one defined in koha-conf.xml).
2. In Admin > Search engine configuration, click on Reset Mappings
3. Confirm that in Search fields tab, the Searchable column hasn't
changed.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:20:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:20:44 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |victor at tuxayo.net
--- Comment #3 from Victor Grousset/tuxayo ---
Hi, I tried to test and improvised a lot because Koha ES is new for me.
First, I switch SearchEngine syspref to ES but I don't know what else to do. (I
have ES running as part of koha-testing-docker)
> 3. Confirm that in Search fields tab, the Searchable column hasn't
> changed.
Without the patch, the Searchable column hasn't changed. So couldn't reproduce
the issue.
I suspect that it's because my test data (from koha-testing-docker) has
everything to "yes". And that "yes" might be the default.
So in the intranet I change few a columns to "no" and save.
> An error occurred when updating Elasticsearch index mappings:
> Unable to update mappings for index "koha_kohadev_biblios".
> Reason was: "no such index". Index needs to be recreated and reindexed.
> An error occurred when updating Elasticsearch index mappings:
> Unable to update mappings for index "koha_kohadev_authorities".
> Reason was: "no such index". Index needs to be recreated and reindexed.
> Index 'koha_kohadev_biblios' needs to be recreated.
> Index 'koha_kohadev_authorities' needs to be recreated.
Ok that doesn't look good. I must be missing some basic ES config.
At least I can confirm that with the patch there is a diff on the output of
export_elasticsearch_mappings.pl
It's precisely on the changes I made which is encouraging. Let's try anyway.
So my test plan completed was:
- SearchEngine syspref to ES (don't know if that's useful)
- set few fields to not searchable
- scary errors...
- misc/search_tools/export_elasticsearch_mappings.pl
- save to mappings.yaml
- for me it's:
/kohadevbox/koha/admin/searchengine/elasticsearch/mappings.yaml
- restart_all (don't know if that's useful)
- reset mappings
- changes to the fields are lost
- apply patch
- restart_all
- set few fields to not searchable
- scary errors...
- misc/search_tools/export_elasticsearch_mappings.pl
- save to mappings.yaml
- restart_all (don't know if that's useful)
- reset mappings
- changes to the fields are still there! :D
So in spite of the scary errors and my dubious setup. It really look like it's
working :D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:22:12 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #8 from Katrin Fischer ---
> > +
> > + var result = ' Edit';
>
> The button label is not translatable
Not sure if the QA tools catches it, but the icon it should also have the aria
attribute I think.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:23:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:23:22 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #29 from Bernardo Gonzalez Kriegel ---
(In reply to Aleisha Amohia from comment #22)
> See the coding guidelines on the Koha Community wiki about booleans:
> https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans
>
> I realise I have done this wrong so will fix it up anyway, but guidelines
> say to use tinyint.
(In reply to Katrin Fischer from comment #23)
> Bug 12194 might be helpful here - I think it's a 'right' positive.
I read the coding guidelines, but didn't know if it was intended to be Boolean,
so a type change would fix the problem.
If that was the intention, it needed to be declared, and was a 'right' positive
:)
Tested and signed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:39:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:39:12 +0000
Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship
defaults to father
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322
--- Comment #4 from Katrin Fischer ---
If you make it mandatory or leave it - in both situations we will need an empty
value added to the pull down, so that it's a conscious choice. I think we
should add an empty value for now and a new bug for making it optionally
mandatory?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:44:08 +0000
Subject: [Koha-bugs] [Bug 25337] Export/import of Elasticsearch
configuration is lacking information
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25337
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #1 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 25325 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:44:08 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
*** Bug 25337 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:48:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:48:19 +0000
Subject: [Koha-bugs] [Bug 25331] SPAM
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25331
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Master |SPAM
Status|NEW |RESOLVED
Resolution|--- |INVALID
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:51:41 +0000
Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship
defaults to father
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322
--- Comment #5 from David Roberts ---
(In reply to Katrin Fischer from comment #4)
> If you make it mandatory or leave it - in both situations we will need an
> empty value added to the pull down, so that it's a conscious choice. I think
> we should add an empty value for now and a new bug for making it optionally
> mandatory?
That sounds sensible - I'd be happy with that solution. At the moment, it looks
like there is a blank option, but it doesn't appear to be functional.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:51:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:51:49 +0000
Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking
Tech from "phone" to "talkingtech"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333
--- Comment #5 from Katrin Fischer ---
It looks like there was a name change (see bug 24204). Should we start
reflecting this here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 22:56:05 +0000
Subject: [Koha-bugs] [Bug 25262] [19.05.x] Cash register report truncates
manual_inv values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--- Comment #2 from Lucas Gass ---
When I apply this patch and create a manual invoice called 'INCREDIBLE_HULK' it
will not show up in the Cash Register report when I narrow the search to
Transaction Type = "INCREDIBLE_HULK".
If I pay it and then do the search I see the Payment transaction.
Also, after I run cash_register_stats.pl the dropdown defaults back to 'All
payments to the library'.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:09:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 23:09:47 +0000
Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins
from GitHub
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #35 from David Cook ---
(In reply to Jonathan Druart from comment #31)
> I am sorry but I have concerns about this patch. Feel free to ignore them.
>
> To me this feature is not ready as it.
> With those patches, the default will be to search on theke and bws github
> repo. Nothing says that the plugins are fetched from "outside".
> Did anyone review those plugins?
> Why only those 2 companies? What about others (ptfs-e, biblibre, inlibro,
> etc)?
> What if a plugin that have security issues is pushed to those repos?
>
I have those same concerns. At the very least, there should be transparency
about where the plugins are being fetched from.
> When are you going to work on follow-up bugs? Is the plan to have them ready
> for 20.05?
I've done the plugin signing work on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632, but I only did
it for manually uploaded plugins. I only noticed this bug's functionality as I
was wrapping up my initial work. I'll have to revisit it...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:10:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 23:10:36 +0000
Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for
security/verifiability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632
--- Comment #14 from David Cook ---
I noticed late yesterday that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 allows a person
to fetch plugins directly from Github.
I'll have to take a look at that code to see how it relates to what I've done
here. I imagine it shouldn't be too difficult, especially if we use a standard
naming convention for signature files.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 23:20:36 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
be increased
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
--- Comment #91 from Bernardo Gonzalez Kriegel ---
(In reply to Katrin Fischer from comment #90)
>
> I feel like we should continue the discussion on a hardcoded value on bug
> 18308 and keep this one to just change the default value we ship Koha with.
> It will be a step forward that we can get through quickly.
This is bug 18308 :)
What about keeping only the second (comment #4) patch?
It's the only way not to break people's workflows.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:25:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 23:25:01 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
be increased
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
--- Comment #92 from Katrin Fischer ---
(In reply to Bernardo Gonzalez Kriegel from comment #91)
> (In reply to Katrin Fischer from comment #90)
> >
> > I feel like we should continue the discussion on a hardcoded value on bug
> > 18308 and keep this one to just change the default value we ship Koha with.
> > It will be a step forward that we can get through quickly.
>
> This is bug 18308 :)
>
> What about keeping only the second (comment #4) patch?
> It's the only way not to break people's workflows.
Sorry, me and bug numbers.... I meant bug 21314. c#4 looks good to me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Apr 2020 23:26:44 +0000
Subject: [Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the
wrong section of the patron file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336
David Roberts changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
|ity.org |om
CC| |david.roberts at ptfs-europe.c
| |om
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 02:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 00:49:18 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
be increased
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #93 from David Cook ---
Wow... I can't believe this issue has been open for over 3 years, and it still
defaults to 3.
We should do a patch to sysprefs.sql to raise it to 10 (number given by a
security consultant).
Let's just push that out ASAP, and then worry about existing installations.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 06:16:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 04:16:12 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
--- Comment #5 from Frédéric Demians ---
Victor, your correct 'yes' is default value for 'staff_client' and 'opac'
fields. It means you have to set some ES fields to 'false' to see the problem.
You can also see the reverse function of exporting ES config which is:
Koha::SearchEngine::ElasticSearch.pm::reset_elasticsearch_mappings
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/SearchEngine/Elasticsearch.pm;h=66166713259f4a175295384fb30486ee2d8b6431;hb=HEAD#l360
Thks for testing/signing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:28:19 +0000
Subject: [Koha-bugs] [Bug 25340] New: opac-review.pl doesn't show title when
commenting
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340
Bug ID: 25340
Summary: opac-review.pl doesn't show title when commenting
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
When placing a comment/review on a record on the OPAC, Koha says "Comments on
No title" even when there is a title.
The template looks like this:
Comments on [% INCLUDE 'biblio-title.inc' biblio=Stash.stash()
%]
Surely that should have a more appropriate data structure put into biblio.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:39:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:39:50 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:40:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:40:44 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #9 from Tomás Cohen Arazi ---
Created attachment 104065
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104065&action=edit
Bug 25279: (QA follow-up) Make button texts translatable
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:41:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:41:51 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to Josef Moravec from comment #7)
>
> The button label is not translatable
Done
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:43:48 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103999|0 |1
is obsolete| |
--- Comment #375 from Aleisha Amohia ---
Created attachment 104066
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104066&action=edit
Bug 19532: Database and installer stuff
- recalls table
- circulation rules: recalls allowed (total), recalls per record
(count), on shelf recalls allowed, recall due date interval (day),
recall overdue fine, recall shelf time/pickup period (day)
- sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog
- email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM,
RECALL_REQUESTER_DET
- user permission: recalls, manage_recalls
- Recall and CancelRecall reasons for branch transfers
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:43:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:43:57 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104000|0 |1
is obsolete| |
--- Comment #376 from Aleisha Amohia ---
Created attachment 104067
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104067&action=edit
Bug 19532: Updated schema files
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:44:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:44:05 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104001|0 |1
is obsolete| |
--- Comment #377 from Aleisha Amohia ---
Created attachment 104068
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104068&action=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:44:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:44:14 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104005|0 |1
is obsolete| |
--- Comment #378 from Aleisha Amohia ---
Created attachment 104069
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104069&action=edit
Bug 19532: Recalls objects and tests
Getter and setter methods and other object methods for Koha Recalls,
plus tests for these
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:44:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:44:22 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104006|0 |1
is obsolete| |
--- Comment #379 from Aleisha Amohia ---
Created attachment 104070
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104070&action=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation
plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:44:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:44:32 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104007|0 |1
is obsolete| |
--- Comment #380 from Aleisha Amohia ---
Created attachment 104071
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104071&action=edit
Bug 19532: Other objects used in recalls feature
* biblio->recalls
* biblio->can_be_recalled
* item->recall
* item->can_be_recalled
* item->can_set_waiting_recall
* patron->recalls
* tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:46:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:46:54 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104065|0 |1
is obsolete| |
--- Comment #11 from Tomás Cohen Arazi ---
Created attachment 104072
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104072&action=edit
Bug 25279: (QA follow-up) Make button texts translatable
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 07:48:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 05:48:50 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #8)
> > > +
> > > + var result = ' Edit';
> >
> > The button label is not translatable
>
> Not sure if the QA tools catches it, but the icon it should also have the
> aria attribute I think.
There should be (at least) a coding guideline. I read the Mozilla page about
it, and some tutorials, plus looked at what we do, and we are really
heterogeneous regarding this.
I've added the aria-hidden=true to the icons (y), and there's also the
aria-label or aria-labelledby which are (sometimes) used, but my intuition says
in this case it is not required as we are just saying this is a button, and
when reading it the icon should be hidden. Am I right? I'm learning new things
:-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 08:20:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 06:20:47 +0000
Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #8 from Marcel de Rooy ---
No reply to earlier questions. No update for bug 20415.
Changing status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 08:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 06:49:54 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 08:49:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 06:49:57 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101392|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 104073
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104073&action=edit
Bug 23794: Convert OpacMainUserBlock system preference to news block
This patch builds on Bug 22318 to move the OpacMainUserBlock system
preference into the Koha news system, making it possible to have
language- and library-specific content.
To test you should have some content in the OpacMainUserBlock system
preference. Apply the patch and run the database update process.
- Go to the OPAC and confirm that the content which was previously in
the OpacMainUserBlock system preference now displays correctly where
it was before.
- In the staff client, go to Tools -> News and verify that the content
from OpacMainUserBlock is now stored in news items. There should be
one entry for each of the enabled translations in your system, for
instance 'opacmainuserblock_en', 'opacmainuserblock_fr-FR',
'opacmainuserblock_cs-CZ'
- Go to Administration -> System preferences and confirm that the
OpacMainUserBlock preference has been removed.
Signed-off-by: Bernardo Gonzalez Kriegel
Works like a charm.
Don't forget to run ./translate update/install for your language(s)
after the patch
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 08:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 06:50:23 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:08:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:08:34 +0000
Subject: [Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip
overridden object class ->delete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:08:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:08:36 +0000
Subject: [Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip
overridden object class ->delete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303
--- Comment #20 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:03 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |20.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:05 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
--- Comment #4 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:07 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
than one backend
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |20.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:09 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
than one backend
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043
--- Comment #23 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:11 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
with dates with offset
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |20.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:13 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
with dates with offset
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #29 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:15 +0000
Subject: [Koha-bugs] [Bug 25297] Consistent return value in
K::A::Order->current_item_level_holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |20.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:20:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:20:17 +0000
Subject: [Koha-bugs] [Bug 25297] Consistent return value in
K::A::Order->current_item_level_holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297
--- Comment #8 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:22:37 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |In Discussion
--- Comment #17 from Martin Renvoize ---
I've been mulling this one over and I'm inclined to agree, that although this
does move us towards the goal, it's at the wrong level.
I believe we should be formatting based on locale rather than by currency.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:24:27 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:26:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:26:20 +0000
Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #10 from Marcel de Rooy ---
error: sha1 information is lacking or useless
(Koha/SearchEngine/Elasticsearch.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 24823: Remove unused parameters
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:45:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:45:15 +0000
Subject: [Koha-bugs] [Bug 24055] Description of PayPalReturnURL system
preference is unclear
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24055
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |Failed QA
--- Comment #5 from Marcel de Rooy ---
I cant say that it is clear to me now. If we rephrase, please make it more
clear than what we do now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:49:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:49:53 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #18 from Martin Renvoize ---
I think for client-side formatting we should use the native JS function
(Intl.NumberFormat):
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat
For template side, we should try to replicate what the above does via a TT
plugin.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 07:50:37 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #19 from Martin Renvoize ---
https://www.thefinancials.com/Default.aspx?SubSectionID=curformat for
reference... there's ALLOT of different formats out there it would seem.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:24:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:24:59 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #20 from Martin Renvoize ---
Final comment.. why do we use 3 hard coded values for our money formatting at
the moment rather than rely on something like
https://metacpan.org/pod/Locale::Currency::Format which claims to try to
support the full ISO 4217 set?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:37:43 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
not update last seen date for check-ins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:37:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:37:46 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
not update last seen date for check-ins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102692|0 |1
is obsolete| |
--- Comment #9 from Marcel de Rooy ---
Created attachment 104074
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104074&action=edit
Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn
Test plan:
1) Before the patch when one checks in something using the KOCT the last seen
date is not updated.
2) After the patch when one checks in something using the KOCT the last seen
date is updated.
Signed-off-by: Laurence Rault
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:38:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:38:11 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
not update last seen date for check-ins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gmcharlt at gmail.com,
| |kyle.m.hall at gmail.com,
| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
Component|contribs.koha-community.org |Circulation
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:43:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:43:29 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #76 from Marcel de Rooy ---
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
FAIL filters
missing_filter at line 127 (
)
missing_filter at line 261 ( [%
cannot_delete_reason %])
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 08:44:43 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |BLOCKED
--- Comment #77 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:01:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:01:48 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
not update last seen date for check-ins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751
--- Comment #10 from Martin Renvoize ---
(In reply to Magnus Enger from comment #6)
> Looking at signing off this.
>
> Tempted to set it to "in discussion" because of comment 5, but I think
> Martin sort of answered it in comment 3?
>
> Then I see there are no tests for ProcessOfflineReturn, and not for
> ProcessOfflineIssue or ProcessOfflinePayment either. But asking for that
> might be a bit too much on this bug?
Adding tests would certainly be preferable.. I'm going to keep this one in my
queue and attempt to write tests as part of push.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:05:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:05:31 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #78 from Marcel de Rooy ---
Bit weird that sub safe_to_delete returns 1 or a string.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:21:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:21:58 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #79 from Marcel de Rooy ---
"If an item is the last one of a biblio that have biblio-level hold
placed on it, we should block the deletion."
Well, this is quite arguable. Imo probably cleanup_database could remove holds
that make no sense like biblio level holds when there are no items.
The same commit says:
"Note that there is something a bit weird as we are blocking items
from a biblio that has biblio-level holds on it (not found), but we
do not blocking the deletion of an item with a waiting item-level hold."
Lets not push inconsistency but resolve it?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:37:28 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--- Comment #80 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #79)
> "If an item is the last one of a biblio that have biblio-level hold
> placed on it, we should block the deletion."
>
> Well, this is quite arguable. Imo probably cleanup_database could remove
> holds that make no sense like biblio level holds when there are no items.
> The same commit says:
> "Note that there is something a bit weird as we are blocking items
> from a biblio that has biblio-level holds on it (not found), but we
> do not blocking the deletion of an item with a waiting item-level hold."
>
> Lets not push inconsistency but resolve it?
Additional thought:
Note that the user also has the choice to delete a biblio. If he wants to
delete the biblio, the biblio level hold will be deleted too. So you could say
that a choice to not delete the biblio, is a choice to keep the hold. Perhaps
new items are to be expected here and the hold can be filled later. So delete
the item.
If you choose delete biblio too, we should not block the deletion of the hold.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:49:14 +0000
Subject: [Koha-bugs] [Bug 25119] When paying or writing off a single fee,
the account type doesn't display correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25119
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:49:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:49:17 +0000
Subject: [Koha-bugs] [Bug 25119] When paying or writing off a single fee,
the account type doesn't display correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25119
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102933|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 104075
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104075&action=edit
Bug 25119: Fix account type and description for individual writeoffs/payments
When paying or writing off a single line from the list of pending charges,
the account type displayed the code instead of the description.
And when bug 23483 fixed the display of the description, 2 variables where
missed. This change is only visible when looking at the page source:
With the patch applied, the value will be filled with the description.
To test:
- Create one or more manual invoices of different types
- Try to pay/write off using the buttons within the table
- Verify the account type shows as code, not description
- Apply patch
- Repeat
- Bonus points: Check the source code for the hidden input with description.
Signed-off-by: Martin Renvoize
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 11:49:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 09:49:31 +0000
Subject: [Koha-bugs] [Bug 25119] When paying or writing off a single fee,
the account type doesn't display correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25119
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:00:19 +0000
Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with
AllowOnShelfHolds off
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |Failed QA
--- Comment #48 from Marcel de Rooy ---
Not sure this is a In discussion or a Failed QA.
But the report dates from 2011 and the patch from 2013, so there must be a
reason why this took so long.
The first comments says "This may require a pref" too.
Since we are used now to the current behavior since 2011/2013, I think we
cannot revert behavior without a pref.
Changing status
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:00:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:00:33 +0000
Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with
AllowOnShelfHolds off
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Keywords|Academy |
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:16:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:16:06 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #81 from Jonathan Druart ---
Hi Marcel,
Thanks for taking a look at this.
(In reply to Marcel de Rooy from comment #79)
> "If an item is the last one of a biblio that have biblio-level hold
> placed on it, we should block the deletion."
>
> Well, this is quite arguable. Imo probably cleanup_database could remove
> holds that make no sense like biblio level holds when there are no items.
> The same commit says:
> "Note that there is something a bit weird as we are blocking items
> from a biblio that has biblio-level holds on it (not found), but we
> do not blocking the deletion of an item with a waiting item-level hold."
>
> Lets not push inconsistency but resolve it?
What do you suggest?
I'd like to repeat that this bug is about preventing phantom holds, nothing
else. I don't think we should fix other inconsistencies on this bug report (it
has been considered critical during years...)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:24:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:24:53 +0000
Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for
security/verifiability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #15 from Jonathan Druart ---
You are assuming that an author who is trusted once is trusted for all the
plugins they will write. This assumption is wrong IMO.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:30:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:30:52 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #21 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #17)
> I've been mulling this one over and I'm inclined to agree, that although
> this does move us towards the goal, it's at the wrong level.
>
> I believe we should be formatting based on locale rather than by currency.
On the other hand it's either having it now (but not perfect), or not having it
until... who knows?
I am not planning to spend more time on this.
(In reply to Martin Renvoize from comment #20)
> Final comment.. why do we use 3 hard coded values for our money formatting
> at the moment rather than rely on something like
> https://metacpan.org/pod/Locale::Currency::Format which claims to try to
> support the full ISO 4217 set?
For backward compatibility when Koha::Number::Price has been implemented.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:33:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:33:19 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #22 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #20)
> Final comment.. why do we use 3 hard coded values for our money formatting
> at the moment rather than rely on something like
> https://metacpan.org/pod/Locale::Currency::Format which claims to try to
> support the full ISO 4217 set?
Because it's buggy and the author is unresponsive.
Bug 24278 - Replace Locale::Currency::Format because it's buggy
As we support the Goethe libraries, we have run into quite some issues with
different currencies. - Koha currently uses it to format fines in overdue
notices.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:35:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:35:43 +0000
Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:35:46 +0000
Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104050|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 104076
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104076&action=edit
Bug 25334: Add generic 'phone' message transport type
As bug 25333 changed the 'phone' transport type to 'talkingtech', we can
now re-add 'phone' as a transport type again, and allow it to behave and
support the same notices as the email transport type.
Test Plan;
1) Apply this patch
2) Run updatedatabase
3) Restart all the things!
4) Disable TalkingTechItivaPhoneNotificationi if enabled
5) Enable new PhoneNotification system preference
6) Go to a patron's messaging preferences, not you can select the
'phone' option for all the same notices as the 'email' option
7) Enable the phone option for all the message types
8) Browser to the Notices and slips editor
9) Add a phone notice version for each notice you wish to test
10) Test some notices ( CHECKIN, CHECKOUT, etc )
11) Notices should show in the patron's messages as 'phone' notices
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:35:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:35:53 +0000
Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:37:06 +0000
Subject: [Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #6 from David Nind ---
Hi Owen.
I've had a couple of attempts at testing this, but get this message when trying
to add:
Firefox could not download the search plugin from:
http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription
OPACBaseURL is set to http://kohadev.mydnsname.org:8080 - I think this is
correct.
Here is the XML delivered when I look at the source for the URL in the error
message above:
Search the Koha library catalogUTF-8
http://kohadev.myDNSname.org:8080/opac-tmpl/bootstrap/images/favicon.ico
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:39:06 +0000
Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Architecture, internals, |Plugin architecture
|and plumbing |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:40:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:40:20 +0000
Subject: [Koha-bugs] [Bug 24055] Description of PayPalReturnURL system
preference is unclear
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24055
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Katrin Fischer ---
I followed Tomas suggestion, I will need help to find a better description as
honestly I don't really understand myself. Just trying to push this forward to
improve things here!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:42:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:42:39 +0000
Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #13 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Katrin Fischer from comment #8)
> > > > +
> > > > + var result = ' Edit';
> > >
> > > The button label is not translatable
> >
> > Not sure if the QA tools catches it, but the icon it should also have the
> > aria attribute I think.
>
> There should be (at least) a coding guideline. I read the Mozilla page about
> it, and some tutorials, plus looked at what we do, and we are really
> heterogeneous regarding this.
>
> I've added the aria-hidden=true to the icons (y), and there's also the
> aria-label or aria-labelledby which are (sometimes) used, but my intuition
> says in this case it is not required as we are just saying this is a
> button, and when reading it the icon should be hidden. Am I right? I'm
> learning new things :-D
I asked Owen and we agreed that aria-hidden=true should be used on the buttons
when there is an additional text. I fully agree with you about the coding
guideline, adding it to next dev meeting.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:49:52 +0000
Subject: [Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994
--- Comment #7 from Katrin Fischer ---
The OpacBaseURl like this never works for me - I always have to change it to
localhost:8080 (kohadevbox)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:50:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:50:26 +0000
Subject: [Koha-bugs] [Bug 24278] Replace Locale::Currency::Format because
it's buggy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24278
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #2 from Martin Renvoize ---
Hmm.. can we write some tests for this?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 12:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 10:50:56 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
symbol after amount
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352
--- Comment #23 from Martin Renvoize ---
(In reply to Katrin Fischer from comment #22)
> (In reply to Martin Renvoize from comment #20)
> > Final comment.. why do we use 3 hard coded values for our money formatting
> > at the moment rather than rely on something like
> > https://metacpan.org/pod/Locale::Currency::Format which claims to try to
> > support the full ISO 4217 set?
>
> Because it's buggy and the author is unresponsive.
> Bug 24278 - Replace Locale::Currency::Format because it's buggy
>
> As we support the Goethe libraries, we have run into quite some issues with
> different currencies. - Koha currently uses it to format fines in overdue
> notices.
Hmm.. I wasn't aware it had issues.
What about https://metacpan.org/pod/CLDR::Number::Format::Currency.?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:18:54 +0000
Subject: [Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994
--- Comment #8 from David Nind ---
Thanks Katrin!
Unfortunately, the error still happens after making that change 8-(
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:20:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:20:31 +0000
Subject: [Koha-bugs] [Bug 25273] Elasticsearch Authority matching is
returning too many results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24269
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269
[Bug 24269] Authority matching in Elasticsearch is broken when authority has
subdivisions
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:20:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:20:31 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
broken when authority has subdivisions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |25273
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273
[Bug 25273] Elasticsearch Authority matching is returning too many results
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:32:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:32:12 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #82 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #81)
> What do you suggest?
Maybe we should stick to the scope that the title suggests. Do not delete items
with holds. Biblio level holds are out of scope.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:34:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:34:54 +0000
Subject: [Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |david at davidnind.com
--- Comment #10 from David Nind ---
Applying this patch seems to stop the 'Batch extend due dates' from working as
expected (for me anyway):
- Before applying the patch: issued some items, batch extend due dates comes up
with items to extend the due date.
- After applying the patch: Using exactly the same criteria the batch extend
due dates shows 'No checkouts for the selected filters.'
The tests still pass though!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:47:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:47:40 +0000
Subject: [Koha-bugs] [Bug 25311] Better error handling when
creating/updating a patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:47:49 +0000
Subject: [Koha-bugs] [Bug 25311] Better error handling when
creating/updating a patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:47:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:47:55 +0000
Subject: [Koha-bugs] [Bug 25311] Better error handling when
creating/updating a patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|major |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:48:04 +0000
Subject: [Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is
too long
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:48:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:48:32 +0000
Subject: [Koha-bugs] [Bug 25335] Use of an authorised value in a marc
subfield causes strict mode SQL error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:48:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:48:35 +0000
Subject: [Koha-bugs] [Bug 25335] Use of an authorised value in a marc
subfield causes strict mode SQL error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104051|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 104077
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104077&action=edit
Bug 25335: group by authorised_value in addbiblio.pl
To Test:
1- Edit your default framework, connect any subfield outside of the 952 to an
authorised value (for example, connect the 942$n to the Yes_No auth value)
2 - Find a record in that framework
3 - Edit the record and find your subfield
4 - The subfield shows a dropdown with no contents
5 - check plack error log, see "DBD::mysql::st execute failed:
'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY "
6 - apply patch, restart all
7 - reload edit record page, see your auth value dropdown has contents
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:52:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:52:31 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
for authority links on a Z39.50 server.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bgkriegel at gmail.com
Status|Needs Signoff |Patch doesn't apply
--- Comment #34 from Bernardo Gonzalez Kriegel ---
Sorry, does not apply.
Please rebase.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:56:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 11:56:42 +0000
Subject: [Koha-bugs] [Bug 23406] Authorized Value for Suppression when added
to Frameworks doesn't show Suppress in Staff Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
--- Comment #5 from Andrew Fuerste-Henry ---
I'm on master using Koha testing docker, so those should be up to date. Here's
the relevant bit from MARC21slim2intranetResults.xsl (line 285):
Suppressed in
OPAC
Katrin, is that the same file you're using?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:05:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:05:10 +0000
Subject: [Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be
created due to maxFine but cannot be forgiven
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:05:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:05:13 +0000
Subject: [Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be
created due to maxFine but cannot be forgiven
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103430|0 |1
is obsolete| |
--- Comment #28 from Nick Clemens ---
Created attachment 104078
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104078&action=edit
Bug 25127: Unit tests
Signed-off-by: David Nind
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:05:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:05:16 +0000
Subject: [Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be
created due to maxFine but cannot be forgiven
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103431|0 |1
is obsolete| |
--- Comment #29 from Nick Clemens ---
Created attachment 104079
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104079&action=edit
Bug 25127: Correction to tests
Signed-off-by: David Nind
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:05:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:05:19 +0000
Subject: [Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be
created due to maxFine but cannot be forgiven
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103432|0 |1
is obsolete| |
--- Comment #30 from Nick Clemens ---
Created attachment 104080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104080&action=edit
Bug 25127: Use Koha::Number::Price->round for comparison
Signed-off-by: David Nind
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:12:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:12:30 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
--- Comment #11 from Owen Leonard ---
Created attachment 104081
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104081&action=edit
Bug 13388: (follow-up) Remove display of email address
Since the email address configured for a library may not be the email
address libraries want to use as a contact email address the email
should not be displayed by default.
This patch removes display of the email address. Libraries may choose to
add the information to the opac_info column, so there is already a
built-in alternative.
To test, apply the patch and view the detail page for a library in your
system which has an email address configured. The email address should
not display on the page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:12:32 +0000
Subject: [Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is
too long
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309
--- Comment #4 from Martin Renvoize ---
We should probably also disable autofill on this form here perhaps?
I think the original issue was found due to an erroneous autofill.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:12:41 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #83 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #82)
> (In reply to Jonathan Druart from comment #81)
> > What do you suggest?
>
> Maybe we should stick to the scope that the title suggests. Do not delete
> items with holds. Biblio level holds are out of scope.
No, it's the main point of this bug report.
We want to prevent deletion of the last item of a bibliographic record with a
biblio-level hold on it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:16:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:16:32 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #84 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #83)
> (In reply to Marcel de Rooy from comment #82)
> > (In reply to Jonathan Druart from comment #81)
> > > What do you suggest?
> >
> > Maybe we should stick to the scope that the title suggests. Do not delete
> > items with holds. Biblio level holds are out of scope.
>
> No, it's the main point of this bug report.
>
> We want to prevent deletion of the last item of a bibliographic record with
> a biblio-level hold on it.
Sorry, I can't agree on that reading comments and patches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:18:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:18:46 +0000
Subject: [Koha-bugs] [Bug 25262] [19.05.x] Cash register report truncates
manual_inv values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103561|0 |1
is obsolete| |
--- Comment #3 from Nick Clemens ---
Created attachment 104082
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104082&action=edit
Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown
There is an issue in that historic values will still be truncated, but recent
values are not.
I feel the cash register report should reflect recent transactions over
historic, and the historic are a data cleanup issue
To test:
1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK'
2 - Add a manual invoice to a patron's acccount using this value
3 - Note the full code displays in patrons account
4 - Browse to Reports->Cash register
5 - Search for today's date, the value you createed, and all libraries
6 - No results returned
7 - Apply patch
8 - Repeat 5
9 - The transaction shows
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:26:04 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
on them
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #85 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #84)
> (In reply to Jonathan Druart from comment #83)
> > (In reply to Marcel de Rooy from comment #82)
> > > (In reply to Jonathan Druart from comment #81)
> > > > What do you suggest?
> > >
> > > Maybe we should stick to the scope that the title suggests. Do not delete
> > > items with holds. Biblio level holds are out of scope.
> >
> > No, it's the main point of this bug report.
> >
> > We want to prevent deletion of the last item of a bibliographic record with
> > a biblio-level hold on it.
>
> Sorry, I can't agree on that reading comments and patches.
See comment 0:
"""
I don't think it always did this - but I tested today on 3.8 and it deleted an
item and a bib record (cause I checked that box) that had holds on it.
"""
Then comment 1:
"""
This is how you end up with phantom holds that can never be deleted.
"""
And comment 20.
I can confirm that I wrote those patches to prevent such deletion, and so
phantom holds.
That's why I rebuilt a bit the interface to display the why an item cannot be
deleted, and so introduced the new "last_item_for_hold" error code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:26:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:26:40 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104052|0 |1
is obsolete| |
--- Comment #12 from Victor Grousset/tuxayo ---
Created attachment 104083
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104083&action=edit
Bug 13388: Add library pages to the OPAC
This patch adds a script and a template for showing library information
pages in the OPAC. A "libraries" page lists all the libraries in the
system, linking to individual pages for each library showing more
information..
If there is only one library in the system the page shows all of that
library's information.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Go to /cgi-bin/koha/opac-library.pl in the OPAC.
- Verify that all the correct information is displayed for the
libraries in your system.
- Verify that page title and breadcrumbs look correct.
- Click to view details for a library.
- The details page should show the full contents of
branches.opac_info
- A menu should show links to other libraries' detail pages.
EDIT: This revised patch adds a "Libraries" link to the links under the
search bar; Corrects encoding in the breadcrumb link; Makes the page
title more specific when viewing an individual library.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:26:44 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104081|0 |1
is obsolete| |
--- Comment #13 from Victor Grousset/tuxayo ---
Created attachment 104084
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104084&action=edit
Bug 13388: (follow-up) Remove display of email address
Since the email address configured for a library may not be the email
address libraries want to use as a contact email address the email
should not be displayed by default.
This patch removes display of the email address. Libraries may choose to
add the information to the opac_info column, so there is already a
built-in alternative.
To test, apply the patch and view the detail page for a library in your
system which has an email address configured. The email address should
not display on the page.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:38:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:38:05 +0000
Subject: [Koha-bugs] [Bug 25340] opac-review.pl doesn't show title when
commenting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:38:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:38:54 +0000
Subject: [Koha-bugs] [Bug 23406] Authorized Value for Suppression when added
to Frameworks doesn't show Suppress in Staff Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
--- Comment #6 from Katrin Fischer ---
Yes, I am using default - freshly set up database without any changes. What's
your authorised value?
I wonder about this line:
[marc:subfield[@code='n'] = '1']">
I would have expected != ''.
But YES_NO is 0 or 1 so that makes sense. Are you using other values by chance?
OpacSuppression activated?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:40:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:40:01 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
Shelving Location,
then deleting the same course reverts/empties Course Reserve Values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
--- Comment #15 from Victor Grousset/tuxayo ---
Sorry for the confusion. It was an unexpected behavior in the test plan.
That step is in reproducing the bug. A problem still occurs, but not the one
described.
Sometimes when that happen that doesn't prevent me from signing off when it's
clear that the patch works. And sometimes I wait and ask for confirmation. It
depend of how big the difference from was I got and the test plan is.
It's a bit confusing, I haven't settled yet for a more clear strategy.
In this case thanks to the patch, I couldn't reproduce
- the issue from the test plan
- or the one I actually got when testing without patch.
So it seems ok. Should I sign off? Another factor is that I didn't see a hurry
on this patch related to the feature freeze. So I could be picky about
unexpected stuff ^^
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:43:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:43:07 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
Shelving Location,
then deleting the same course reverts/empties Course Reserve Values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
--- Comment #16 from Katrin Fischer ---
I had different finding than Kelly when testing this (comment 0 vs. comment 5),
I think if you agree that the results are now as you would expect, you could
sign off with a comment.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:51:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:51:08 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
Shelving Location,
then deleting the same course reverts/empties Course Reserve Values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103953|0 |1
is obsolete| |
--- Comment #17 from Victor Grousset/tuxayo ---
Created attachment 104085
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104085&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled
Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.
Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
See that Shelving Location has changed back to its original location
4) Deleted course
See that Shelving Location has changed back to what was picked during
adding it to the Course.
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:56:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:56:18 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's
Shelving Location,
then deleting the same course reverts/empties Course Reserve Values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #18 from Victor Grousset/tuxayo ---
IIUC what I got in comment 8 is the same thing as what Katrin describes in
comment 5.
> a. has changed for me, instead of showing the 'course reserves' location, the location is emtpy now.
> I think if you agree that the results are now as you would expect, you could sign off with a comment.
Thanks for the green light! :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:58:22 +0000
Subject: [Koha-bugs] [Bug 23406] Authorized Value for Suppression when added
to Frameworks doesn't show Suppress in Staff Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
--- Comment #7 from Andrew Fuerste-Henry ---
Oop, there's the issue. OpacSuppression wasn't turned on in my testing docker.
That's so standard for us that I forget it's off by default.
So this does work in both master and 19.11.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:58:29 +0000
Subject: [Koha-bugs] [Bug 23406] Authorized Value for Suppression when added
to Frameworks doesn't show Suppress in Staff Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|18.11 |19.05
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:59:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 12:59:37 +0000
Subject: [Koha-bugs] [Bug 23406] Authorized Value for Suppression when added
to Frameworks doesn't show Suppress in Staff Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
--- Comment #8 from Andrew Fuerste-Henry ---
Also, agreed that !=0 would be a better check for suppression, but I'm not
certain the query builder isn't looking for 1 specifically. That's a whole
other bug I'm hoping to get around to filing and working on.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:04:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:04:57 +0000
Subject: [Koha-bugs] [Bug 25340] opac-review.pl doesn't show title when
commenting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:05:00 +0000
Subject: [Koha-bugs] [Bug 25340] opac-review.pl doesn't show title when
commenting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340
--- Comment #1 from Owen Leonard ---
Created attachment 104086
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104086&action=edit
Bug 25340: Pass biblio object to OPAC comments template
This patch modifies the OPAC comments system so that the biblio object
is passed to the template. This allows the biblio-title include to
properly access the title and subtitle information.
Unrelated change: Remove some custom CSS from the page which was
obsolete.
To test, apply the patch and make sure the "reviewson" preference is
enabled.
- Log in to the OPAC and open a bibliographic record's detail page.
- Under the "Comments" tab, click the "Post your comments" link to
trigger the pop-up window.
- In the pop-up window, verify that the item's title is correct in the
page title and the heading. Author should display correctly, if
present.
- Test submitting a comment and editing a comment. Everything should
work correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:14:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:14:13 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103946|0 |1
is obsolete| |
--- Comment #23 from Martin Renvoize ---
Created attachment 104087
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104087&action=edit
Bug 23185: Add tests
Signed-off-by: Bernardo Gonzalez Kriegel
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:14:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:14:17 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103947|0 |1
is obsolete| |
--- Comment #24 from Martin Renvoize ---
Created attachment 104088
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104088&action=edit
Bug 23185: Make Koha::Objects->update loop on the object set if needed
Signed-off-by: Bernardo Gonzalez Kriegel
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:14:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:14:21 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #25 from Martin Renvoize ---
Created attachment 104089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104089&action=edit
Bug 23185: (QA follow-up) Semantics, split fields and options
This patch improves the semantics of the update routine to more clearly
separate the 'fields' we're modifying from the 'options' we wish to
apply to the modification.
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:07 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=23187
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:07 +0000
Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create
without passing through the Koha::Object store method
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=23185
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:25 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|23187 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187
[Bug 23187] Koha::Objects supports find_or_create without passing through the
Koha::Object store method
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:25 +0000
Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create
without passing through the Koha::Object store method
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|23185 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
[Bug 23185] Koha::Objects supports passing through 'update' which means we can
side step 'set' + 'store'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:46 +0000
Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through
'update' which means we can side step 'set' + 'store'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|25303 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303
[Bug 25303] Koha::Objects->delete should not skip overridden object class
->delete
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:16:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:16:46 +0000
Subject: [Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip
overridden object class ->delete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|23185 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
[Bug 23185] Koha::Objects supports passing through 'update' which means we can
side step 'set' + 'store'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:21:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:21:33 +0000
Subject: [Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing
to a list in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:25:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:25:19 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
--- Comment #14 from Martin Renvoize ---
Hmm.. I agree branchemail is probably incorrect as they may, in reality, want
the reply-to address instead.
I think this is pretty good as is, but a future enhancement would be nice to
have behind a system preference for displaying email or not and then that
should use the new method in Koha::Library.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:26:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:26:00 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=22823
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:26:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:26:00 +0000
Subject: [Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining
the inbound email address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=13388
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:27:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:27:47 +0000
Subject: [Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing
to a list in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:27:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:27:50 +0000
Subject: [Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing
to a list in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522
--- Comment #1 from Owen Leonard ---
Created attachment 104090
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104090&action=edit
Bug 24522: Show alert when trying to add nothing to a list in staff
This patch modifies the JavaScript which handles the process of adding
items to a list in the staff client. Error-handling is added in the case
when a set of biblionumbers hasn't been passed to the vShelf function.
To test, apply the patch and perform a catalog search in the staff
client.
On the search results page, select any list from the "Add to list" menu
at the top of the search results table without checking any checkboxes.
You should get an alert, "No item was selected."
Also test that adding to a list works correctly after selecting one or
more titles.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:53:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:53:42 +0000
Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:53:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:53:45 +0000
Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102299|0 |1
is obsolete| |
Attachment #102300|0 |1
is obsolete| |
Attachment #102301|0 |1
is obsolete| |
Attachment #102302|0 |1
is obsolete| |
Attachment #102922|0 |1
is obsolete| |
--- Comment #21 from Nick Clemens ---
Created attachment 104091
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104091&action=edit
Bug 25033: Display both local and all pending suggestions counts if the numbers
differ
To test:
0 - Be in staff client as a superlibrarian
1 - Place some suggestions
1 for any branch
1 for signed in branch
1 for another branch
2 - Go to Koha main page, 3 suggestions pending
3 - Click 'Suggestions pending approval' - you see one suggestion
4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending
5 - Click manage suggestions - you see one suggestion
6 - Apply patch
7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3"
suggestions
8 - Confirm that the links take you to suggestions view of your branch or all
libraries respectively
9 - Turn on IndependentBranches
10 - Create a user with acquisition and suggestions permissions but not
superlibrarian in one of the branches used above
11 - Sign in as that user
11 - See "Centerville: 1" suggestion on mainpage and on acqui home
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:53:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:53:49 +0000
Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
--- Comment #22 from Nick Clemens ---
Created attachment 104092
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104092&action=edit
Bug 25033: Remove CountSuggestion
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:53:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:53:52 +0000
Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
--- Comment #23 from Nick Clemens ---
Created attachment 104093
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104093&action=edit
Bug 25033: Move branchfilter to top of page
There is confusion becase it is not obvious when the suggestions page is being
limited to a branch
Moving the branch filter to the top of the page makes it easier to see
To test:
1 - Apply patch
2 - From mainpage or acqui-home note the link to suggestions takes you to
suggestions limited to current branch
3 - Change the dropdown
4 - Note the page refreshes and loads the correct suggestions
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:55:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:55:45 +0000
Subject: [Koha-bugs] [Bug 10910] Add a warn when deleting a patron with
pending suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103903|0 |1
is obsolete| |
--- Comment #9 from Victor Grousset/tuxayo ---
Created attachment 104094
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104094&action=edit
Bug 10910: Add a warning when deleting a patron with pending suggestions
Test plan:
>From the OPAC, add a suggestion
>From the staff interface, try to delete the patron who created the
suggestion
=> You get a warning message
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:56:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 13:56:14 +0000
Subject: [Koha-bugs] [Bug 10910] Add a warn when deleting a patron with
pending suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:06:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:06:47 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating course reserves before
deleting the same course empties course reserve values in the items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Deactivating Course |Deactivating course
|Reserves reverts Item's |reserves before deleting
|Shelving Location, then |the same course empties
|deleting the same course |course reserve values in
|reverts/empties Course |the items
|Reserve Values |
Status|Signed Off |Failed QA
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:07:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:07:00 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating course reserves before
deleting the same course empties course reserve values in the items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:07:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:07:04 +0000
Subject: [Koha-bugs] [Bug 25332] Add library card to iPhone wallet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332
--- Comment #2 from Owen Leonard ---
The article describe a workaround that an individual might use. I don't think
it gives any insight into how it could be accomplished on our end.
I'm pretty sure you'd have to have an app installed on the iPhone which would
interface with the OS's wallet system. Perhaps someone with some app
development experience could confirm.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:11:31 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #23 from Victor Grousset/tuxayo ---
Finding for QA:
> 3.
> - Create a new AV category 'foo'
> - Create an authorised value
> - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo
> => You get an error message (the category cannot be deleted if it has AV
> linked)
Message is « An error occurred when deleting this authorized value category.
Check the logs. »
Plack error logs don't show anything.
Access logs show a 200 HTTP code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:13:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:13:01 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
--- Comment #24 from Victor Grousset/tuxayo ---
> 4.
> - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1
> => You get an error message (the category Asort1 cannot be deleted, it's an
> internal category.
Same.
Plack error logs don't show anything.
Access logs show a 200 HTTP code.
No issue for the signing off IMO
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:14:52 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104083|0 |1
is obsolete| |
--- Comment #15 from Martin Renvoize ---
Created attachment 104095
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104095&action=edit
Bug 13388: Add library pages to the OPAC
This patch adds a script and a template for showing library information
pages in the OPAC. A "libraries" page lists all the libraries in the
system, linking to individual pages for each library showing more
information..
If there is only one library in the system the page shows all of that
library's information.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Go to /cgi-bin/koha/opac-library.pl in the OPAC.
- Verify that all the correct information is displayed for the
libraries in your system.
- Verify that page title and breadcrumbs look correct.
- Click to view details for a library.
- The details page should show the full contents of
branches.opac_info
- A menu should show links to other libraries' detail pages.
EDIT: This revised patch adds a "Libraries" link to the links under the
search bar; Corrects encoding in the breadcrumb link; Makes the page
title more specific when viewing an individual library.
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:14:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:14:55 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104084|0 |1
is obsolete| |
--- Comment #16 from Martin Renvoize ---
Created attachment 104096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104096&action=edit
Bug 13388: (follow-up) Remove display of email address
Since the email address configured for a library may not be the email
address libraries want to use as a contact email address the email
should not be displayed by default.
This patch removes display of the email address. Libraries may choose to
add the information to the opac_info column, so there is already a
built-in alternative.
To test, apply the patch and view the detail page for a library in your
system which has an email address configured. The email address should
not display on the page.
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:14:58 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
--- Comment #17 from Martin Renvoize ---
Created attachment 104097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104097&action=edit
Bug 13388: (follow-up) Inlcude OpacNav
I believe this page should inlclude the optional OpacNav and
OpacNavBottom blocks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:15:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:15:33 +0000
Subject: [Koha-bugs] [Bug 25341] New: When adding a single item to course
reserves, ignore whitespace
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341
Bug ID: 25341
Summary: When adding a single item to course reserves, ignore
whitespace
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Course reserves
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
Especially when copying your barcodes from other pages in Koha, you easily end
up with a bit of whitespace in front and/or after the barcode when you paste
it.
In circulation, this doesn't matter, but when adding to the course reserves,
the whitepace is not ignored and you end up with "barcode not found". It would
be nice if circ and course reserves behaved the same here.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:17:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:17:33 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
--- Comment #18 from Martin Renvoize ---
I felt we should include at least the left side navigation that we have
elsewhere on this page and have submitted a followup to achieve this.
I'm still not entirely sure about the menu placement.. it somehow feels out of
place amongst the other options.. perhaps in a footer block akin to many other
websites out there.?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:21:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:21:13 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating course reserves before
deleting the same course empties course reserve values in the items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
--- Comment #19 from Katrin Fischer ---
Hm, I've amended Kyle's test plan slightly. In my experience it did not revert
to the course reserve value but was emptied. It might have got lost in the
comments here as the problem presented differently before.
I think we should push the fix, but I'd really love to see tests here - we
should make sure this doesn't get a chance to come back unnoticed.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:21:40 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating course reserves before
deleting the same course empties course reserve values in the items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:21:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:21:43 +0000
Subject: [Koha-bugs] [Bug 24772] Deactivating course reserves before
deleting the same course empties course reserve values in the items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #104085|0 |1
is obsolete| |
--- Comment #20 from Katrin Fischer ---
Created attachment 104098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104098&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled
Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.
Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
See that Shelving Location has changed back to its original location
4) Deleted course
See that Shelving Loction is now empty/wrong
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:21:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:21:46 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
--- Comment #19 from Martin Renvoize ---
(In reply to Martin Renvoize from comment #18)
> I felt we should include at least the left side navigation that we have
> elsewhere on this page and have submitted a followup to achieve this.
>
> I'm still not entirely sure about the menu placement.. it somehow feels out
> of place amongst the other options.. perhaps in a footer block akin to many
> other websites out there.?
Or right at the top next to the cart or on the right near the login?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:22:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:22:00 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103833|0 |1
is obsolete| |
--- Comment #25 from Victor Grousset/tuxayo ---
Created attachment 104099
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104099&action=edit
Bug 17355: DB changes
This patch adds a new authorised_value_category.is_system boolean/tinyint(1)
DB field.
Name 'is_system' is coming from existing tables account_credit_types and
account_debit_types and should not be discussed here (if you disagree
fill a new bug report and deal with naming issue separately)
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:22:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:22:04 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103834|0 |1
is obsolete| |
--- Comment #26 from Victor Grousset/tuxayo ---
Created attachment 104100
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104100&action=edit
Bug 17355: DBIC changes
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:22:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:22:08 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103835|0 |1
is obsolete| |
--- Comment #27 from Victor Grousset/tuxayo ---
Created attachment 104101
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104101&action=edit
Bug 17355: DBIC changes - boolean flag
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:22:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:22:13 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103836|0 |1
is obsolete| |
--- Comment #28 from Victor Grousset/tuxayo ---
Created attachment 104102
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104102&action=edit
Bug 17355: Override delete methods
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:22:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 May 2020 14:22:17 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
deleted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103837|0 |1
is obsolete| |
--- Comment #29 from Victor Grousset/tuxayo ---
Created attachment 104103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104103&action=edit
Bug 17355: DB changes - set is_system for categories
Signed-off-by: Victor Grousset/tuxayo