[Koha-bugs] [Bug 25279] Make the cities list use the API

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Katrin Fischer from comment #8)
> > > > +
> > > > +                            var result = '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/cities.pl?op=add_form&cityid='+ row.id +'"><i class="fa fa-pencil"></i> Edit</a>';
> > > 
> > > The button label is not translatable
> > 
> > Not sure if the QA tools catches it, but the icon it should also have the
> > aria attribute I think.
> 
> There should be (at least) a coding guideline. I read the Mozilla page about
> it, and some tutorials, plus looked at what we do, and we are really
> heterogeneous regarding this.
> 
> I've added the aria-hidden=true to the icons (y), and there's also the
> aria-label or aria-labelledby which are (sometimes) used, but my intuition
> says in this  case it is not required as we are just saying this is a
> button, and when reading it the icon should be hidden. Am I right? I'm
> learning new things :-D

I asked Owen and we agreed that aria-hidden=true should be used on the buttons
when there is an additional text. I fully agree with you about the coding
guideline, adding it to next dev meeting.

-- 
You are receiving this mail because:
You are watching all bug changes.