[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #48)

Thanks Katrin for having a look at this!

> 1) 2 small issues in the QA script:
> 
>  FAIL	Koha/Acquisition/Order/Claim.pm
>    OK	  critic
>    FAIL	  forbidden patterns
> 		forbidden pattern: Incorrect license statement (using postal address), may
> be a false positive if the file is coming from outside Koha (bug 24545)
> (line 16)
> alid
> 
>  FAIL	Koha/Acquisition/Order/Claims.pm
>    OK	  critic
>    FAIL	  forbidden patterns
> 		forbidden pattern: Incorrect license statement (using postal address), may
> be a false positive if the file is coming from outside Koha (bug 24545)
> (line 16)

Fixed!

> 2) Database documentation
> 
> Can you please add notes to the entry in kohastructure.sql?

Done!

> I am still testing, but will need to create some more data in my db first.

(In reply to Katrin Fischer from comment #49)
> 3) In my testing, the vendor pull down was empty, although there showed
> orders in my results. Can you please check? I was testing with an order made
> today, oder 0 days ago, estimated delivery date in the range I searched for
> (between May 1 and May 6).
> 
> It should be that when you select a certain vendor in the filters, you can
> do a 'check all' and claim them all at once (see bug 7930), but can't test
> atm.

Yes, Martin opened bug 25266 for that, it's not directly related to these
patches. I had trouble finding out a solution.

> 4) You mention a removed branch parameter. I was wondering if there was some
> kind of permissions thing going on here that would only allow you to claim
> your own late orders (permission order_manage_all maybe, but more likely the
> older independentbranches?).

The (reverse) path is:
GetLateOrders has "branch" as third parameter, which is sent by lateorders.pl
and it's expecting to come from the lateorders.tt template. But there is no
"branch" parameter in that form.

-- 
You are receiving this mail because:
You are watching all bug changes.