[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi,
patch does not apply, an easy conflict in patrons.pref

Solving that, qa tools little complain

 FAIL   misc/cronjobs/restrict_patrons_with_failed_notices.pl
   FAIL   critic
                "$type" is declared but not used at line 16, column 1. Unused
variables clutter code and make it harder to read.
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

That new file also lacks a copyright notice!

Running that file always generates some output. It has a verbose option, but
not a quiet/silent one. As a cron job it will always send an email with the
output, unless you redirects out to /dev/null. 
Why not print something only with '-v' and be silent otherwise (unless there's
some error)?

Not fully tested yet.

-- 
You are receiving this mail because:
You are watching all bug changes.