[Koha-bugs] [Bug 25421] New: Inconsistent return value in Koha::Libraries->pickup_locations

Fri May 8 11:27:55 CEST 2020

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421

            Bug ID: 25421
           Summary: Inconsistent return value in
                    Koha::Libraries->pickup_locations
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 22284

In list context we sometimes return an array, or an arrayref:

 84     return $libraries->unblessed unless $item or $biblio;                   

110     return wantarray ? @pickup_locations : \@pickup_locations;

It causes the following error:
ARRAY(0x55cb36339ec0) at /usr/share/perl5/CGI/Compile.pm line 137.             

                                                   Template process failed:
undef error - Not a HASH reference at
/kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 129.                     
 at /kohadevbox/koha/C4/Templates.pm line 122                                  

C4::Templates::output('C4::Templates=HASH(0x55cb355b7a40)') called at
/kohadevbox/koha/reserve/request.pl line 764    

When doing:
Have 1 bibliographic record with 1 item on it
Place 1 biblio level hold
Delete the item (from moredetail.pl)
Go to the hold list

Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
[Bug 22284] Groups of pickup locations for holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.