[Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 8 11:33:23 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102487|0                           |1
        is obsolete|                            |
 Attachment #102488|0                           |1
        is obsolete|                            |
 Attachment #102489|0                           |1
        is obsolete|                            |
 Attachment #102490|0                           |1
        is obsolete|                            |
 Attachment #102491|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 104562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104562&action=edit
Bug 25070: Centralize member-alt-address-style

There are 5 includes files per value of AddressFormat (us, de, fr).
The code is duplicated for each language, the only thing that changes is the
order.

Wwith this patchset we are going to refactore them to avoid further
regressions.

The idea is to remove all code that is duplicated and remove the need of
having 5*3 files. We are going to limit them to 5 files, 1 per use.

Note that we could go even further, for instance
member-display-alt-address-style and member-display-address-style are
quite identical.

Test plan (for the whole patchset):
- Create a patron with all the address, contact and alternate info filled
- Edit them and save
- Look at the patron's info (top left) in the patron module, and the
patron detail view.
- Play with the different values of AddressFormat
The order and the info must be displayed identically before and after
this patchset. No change is expected.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list