[Koha-bugs] [Bug 25382] opac-sendbasket.pl and opac-sendshelf.pl don't validate email addresses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25382

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, 

while this works, there are a few catches:

1) I feel like the unconditional carp here is not necessary. We usually don't
ouput erros like this in the logs.

2) You pass parameters to the template - why not have a specific error message?
At the moment we always have: There was an error sending the cart.
For the user that could read like there is a server issue, not an issue with
the entered information.

3) I think we should also add additional client side validation like we have on
the email fields on the staff client or in the patron details form in OPAC.
This way we can give even more specific feedback in a standard way.

Failing for 1, but it would be great if you could consider 2 and 3 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.