[Koha-bugs] [Bug 25421] Make Koha::Item and Koha::Biblio ->pickup_locations return an arrayref

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104602|0                           |1
        is obsolete|                            |

--- Comment #4 from didier <didier.gautheron at biblibre.com> ---
Created attachment 104688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104688&action=edit
Bug 25421: Remove use of Koha::Libraries->pickup_locations

The current implementation uses Koha::Libraries->pickup_locations which
is problematic and due to be removed by bug 24368. This patch makes the
trivial change of just searching for libraries that are marked with
pickup_location => 1.

Calls to Koha::Item->pickup_locations and Koha::Biblio->pickup_locations
are as well adapted to the new arrayref return value.

To test:
1. Pick a record with only one item
2. Place a biblio-level hold on it
3. Edit the items: remove the item
4. Go to the Holds tab
=> FAIL: It explodes
5. Apply this patch and restart:
   $ sudo koha-plack --restart kohadev
6. Go back and go to the holds tab again
=> SUCCESS: No failure!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.