[Koha-bugs] [Bug 25382] opac-sendbasket.pl and opac-sendshelf.pl don't validate email addresses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25382

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #6)
> 1. carp is not needed indeed.
> 2. var you pass to the template need to be useful, otherwise what is the
> purpose?

As I said above, I was just copying the existing patterns of these scripts.

> There is plenty of places where we push @messages, { error => $error_code };
> then loop on the messages in the template.

Not for these scripts we don't. 

> That's mandatory here IMO.

Rewriting these scripts and templates seems out of scope to me, but if that's
mandatory that's OK, as they're very reasonable changes to make. It's more work
than I'm willing to do at this point, so I'll put it on my TODO list for the
future.

This seemed like a faster/easier win than validating the input to Koha::Email
for all scripts, but if that's not the case I'll just maintain the changes
locally for now, and get back to it when I have more time.

-- 
You are receiving this mail because:
You are watching all bug changes.